izzy/UnrealEngineUWP
0
0
Fork 0
mirror of https://github.com/izzy2lost/UnrealEngineUWP.git synced 2026-03-26 18:15:20 -07:00
Code Issues Packages Projects Releases Wiki Activity
282,530 Commits 23 Branches 254 Tags
5.4
Commit Graph

117 Commits

Author SHA1 Message Date
phil popp
6cd95821f3 Fix clamping on metasound block rate override 
#rnx
#jira UE-208569
#rb jimmy.smith

[CL 31998359 by phil popp in 5.4 branch]
 2024-03-04 15:11:39 -05:00
phil popp
7798377e02 Fix race condition in metasound editor and async graph registration 
#jira UE-204828, UE-199013
#rb Rob.Gay


#changelist validated
#virtualized

[CL 31217101 by phil popp in 5.4 branch]
 2024-02-06 11:37:36 -05:00
Maxwell Hayes
3454ac3cf4 Cleaning up metasound experimental cvars 
#rb Phil.Popp
#jira UE-205183
#rnx

[CL 31178199 by Maxwell Hayes in 5.4 branch]
 2024-02-05 12:33:10 -05:00
rob gay
e5fa925482 Fix incorrect transient asset path being registered at times due to template node processing generating new transient object representing provided document interface object. (Added bonus with BuildRegistryDoc now actually living in RegistryImpl private implementation where it should've to begin with rather in asset base now that registration headers have been cleaned up). 
#rb helen.yang
#jira UE-198785
#rnx

[CL 30424305 by rob gay in ue5-main branch]
 2023-12-20 19:49:45 -05:00
rob gay
b7ecd11142 Remove and assert against registration/unregisteration calls of MetaSound graphs when cooking, and make all node unregistration calls synchronous when cooking 
#rb helen.yang
#rnx
#tests AudioUnitTests, AudioQA -run=Cook -TargetPlatform=WindowsClient, rename asset, run Engine 'Audio' Automated Tests

[CL 30402526 by rob gay in ue5-main branch]
 2023-12-19 15:55:04 -05:00
AdricEpic
473f754908 - Registration Race Condition Fixes (Attempt #2 w/ cook fixes) 
- Part 1/2 fixing inconsistent file naming that is causing code query tool slowdowns (2/2 will be deprecating old MetasoundFrontendRegistries.h header path)
- Replace SoftObjectPaths with TopLevelAssetPaths for perf (ObjPaths do string copies all over, TopLevelAssetPaths are just two FNames)
#rb helen.yang
#rnx
[FYI] sondra.moyls
#tests AudioQA/EngineTest MetaSound Automated Tests, AudioTests, cook WindowsClient, submit and backout and then fix those problems
#jira UE-198785

[CL 30354102 by AdricEpic in ue5-main branch]
 2023-12-15 13:21:12 -05:00
rob gay
65111a0774 Fix for cook errors, undo changelist 30246187 
#rb helen.yang
#rnx

[CL 30255375 by rob gay in ue5-main branch]
 2023-12-11 20:36:24 -05:00
rob gay
a876bffd23 - Registration Race Condition Fixes 
- Part 1/2 fixing inconsistent file naming that is causing code query tool slowdowns
- Replace SoftObjectPaths with TopLevelAssetPaths for perf (ObjPaths do string copies all over, TopLevelAssetPaths are just two FNames)
#rb helen.yang
#rnx
#tests AudioQA MetaSound Automated Tests, AudioTests
#jira UE-198785

[CL 30246215 by rob gay in ue5-main branch]
 2023-12-11 14:43:42 -05:00
helen yang
5c92e5dd0f Unregister graph on async task to prevent other MetaSounds being unable to find the node between unregistration and reregistration 
#rb phil.popp

[CL 28863594 by helen yang in ue5-main branch]
 2023-10-17 20:13:54 -04:00
rob gay
94048f43ca - Make FNodeRegistryKey an actual struct as opposed to a string alias 
- Avoids string format/copies/conversions in most cases where its just used as a key
- Deprecate NodeRegistryKey namespace calls
#rb phil.popp
#rb helen.yang

[CL 28727626 by rob gay in ue5-main branch]
 2023-10-12 16:37:45 -04:00
jimmy smith
f2080e3c96 [Resubmit] Make the CVARs a global override instead of just the defaults 
#jira UE-196264
#rb aaron.mcleran

[CL 28627751 by jimmy smith in ue5-main branch]
 2023-10-10 13:37:20 -04:00
phil popp
7e2c4e32d2 Fix deadlock in metasound node registration when updating assets 
#rb Helen.Yang
#rnx
#jira UE-196443, UE-197063

[CL 28621450 by phil popp in ue5-main branch]
 2023-10-10 11:32:28 -04:00
phil popp
eec8fd16a8 CIS fix crash in MetaSoundAssetBase.cpp check(IsInGameThread()) 
#rnx

[CL 28598801 by phil popp in ue5-main branch]
 2023-10-09 16:58:25 -04:00
phil popp
74c2f2dda2 Make Node Registration more robust to graph build errors. 
#jira UE-197063
#rnx
#rb Helen.Yang

[CL 28584419 by phil popp in ue5-main branch]
 2023-10-09 11:42:49 -04:00
bob tellez
28443a5e59 [Backout] - CL28560665 
[FYI] jimmy.smith
Original CL Desc
-----------------------------------------------------------------
Make the CVARs a global override instead of just the defaults
#jira UE-196264
#rb aaron.mcleran

[CL 28563662 by bob tellez in ue5-main branch]
 2023-10-06 19:42:56 -04:00
jimmy smith
8eed59c6e9 Make the CVARs a global override instead of just the defaults 
#jira UE-196264
#rb aaron.mcleran

[CL 28560930 by jimmy smith in ue5-main branch]
 2023-10-06 18:51:06 -04:00
phil popp
1602a336e8 Disable async graph registration again 
#rnx
#jira UE-196443
#rb Miles.Flanagan
[FYI] Miles.Flanagan

[CL 28437076 by phil popp in ue5-main branch]
 2023-10-03 18:26:12 -04:00
phil popp
a0366b7589 Fix deadlock when async building metasounds 
Ensure MetaSound graphs are only registered on the game thread.
#rb Rob.Gay
#jira UE-196443, FORT-660159

[CL 28418467 by phil popp in ue5-main branch]
 2023-10-03 12:17:13 -04:00
phil popp
4b4c1174c5 Unblock playtest. Fix crash in metasound source playing 
#rnx
#rb trivial

[CL 28193768 by phil popp in ue5-main branch]
 2023-09-25 13:27:02 -04:00
phil popp
e631780063 Register metasound graphs asynchronously 
#jira UE-185834, FORT-658630
#rb Rob.Gay, Helen.Yang

[CL 28149471 by phil popp in ue5-main branch]
 2023-09-22 15:01:07 -04:00
phil popp
b478631318 [Backout] - CL28104009 
[FYI] phil.popp
Original CL Desc
-----------------------------------------------------------------
Register metasound graphs asynchronously
#jira UE-185834
#rb Rob.Gay, Helen.Yang

[CL 28111209 by phil popp in ue5-main branch]
 2023-09-21 18:24:25 -04:00
phil popp
adbad7a65f Register metasound graphs asynchronously 
#jira UE-185834
#rb Rob.Gay, Helen.Yang

[CL 28104164 by phil popp in ue5-main branch]
 2023-09-21 16:35:40 -04:00
aaron mcleran
d04b712c03 global metasound sample rate override 
#jira UE-195668
#rb Jimmy.Smith

[CL 28017277 by aaron mcleran in ue5-main branch]
 2023-09-19 18:30:29 -04:00
rob gay
a7b425bc4d Fix for crash due to CacheRuntimeData causing proxy gen when cooking with deterministic guid gen on (which should be omitted from CookMetaSound altogether as its not required) 
#rb helen.yang
#rnx

[CL 27906439 by rob gay in ue5-main branch]
 2023-09-15 00:40:42 -04:00
phil popp
1c5f2a8cdd Update caching of input data to use TSortedMap 
#jira UE-195472
#rb Rob.Gay

[CL 27886540 by phil popp in ue5-main branch]
 2023-09-14 13:49:21 -04:00