505 Commits

Author SHA1 Message Date
phil popp
6cd95821f3 Fix clamping on metasound block rate override
#rnx
#jira UE-208569
#rb jimmy.smith

[CL 31998359 by phil popp in 5.4 branch]
2024-03-04 15:11:39 -05:00
helen yang
f67de70815 Fix MetaSound trigger parameter being retriggered on realizing virtualized sounds and unneeded parameter updates being cached while virtualized
#jira UE-194378
#rb phil.popp, rob.gay

[CL 31581978 by helen yang in 5.4 branch]
2024-02-16 16:59:49 -05:00
helen yang
7837478a80 Fix MetaSound Array Random Get Node not initializing properly
#jira UE-206576
#jira UE-206578
#rb phil.popp

[CL 31457286 by helen yang in 5.4 branch]
2024-02-13 20:27:50 -05:00
ericdrobinson
adcd5c68e1 Update MetaSound FTime accessiblity from MetaSound outputs.
#10697
#10663
#jira UE-190586, UE-190587
#rb charlie.huguenard

[CL 31388195 by ericdrobinson in 5.4 branch]
2024-02-12 12:36:01 -05:00
helen yang
49124df6c9 Fix MetaSound Array Random node shared state not applied when No Repeats is connected to a dynamic value that changes before the Next trigger is called
#jira UE-205840
#rb phil.popp

[CL 31315615 by helen yang in 5.4 branch]
2024-02-08 19:57:31 -05:00
phil popp
ff39b3c1c9 Fix missing reset on post executable input node.
#jira UE-205092
#rb rob.gay#preflight 65c428960451b1c61b641ab2

[CL 31309106 by phil popp in 5.4 branch]
2024-02-08 17:55:13 -05:00
phil popp
7798377e02 Fix race condition in metasound editor and async graph registration
#jira UE-204828, UE-199013
#rb Rob.Gay


#changelist validated
#virtualized

[CL 31217101 by phil popp in 5.4 branch]
2024-02-06 11:37:36 -05:00
Maxwell Hayes
3454ac3cf4 Cleaning up metasound experimental cvars
#rb Phil.Popp
#jira UE-205183
#rnx

[CL 31178199 by Maxwell Hayes in 5.4 branch]
2024-02-05 12:33:10 -05:00
rob gay
11324d211a Fix remove swap logic that wasn't covering case where both separate last index and swap index were in same referencing map entry.
#jira UE-204957
#rb phil.popp
[FYI] helen.yang, sondra.moyls
#tests opened all existing MetaSound assets in a large project by opening MetaSound Editor, confirmed reroute repro was fixed

[CL 30946059 by rob gay in 5.4 branch]
2024-01-26 18:00:33 -05:00
phil popp
bb3dbb7e18 Avoid registering unused send/receive nodes
#jira UE-204391, UE-204393, UE-190886
#rb Rob.Gay

[CL 30890172 by phil popp in 5.4 branch]
2024-01-25 12:08:15 -05:00
steve robb
f029468598 Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.
[CL 30729174 by steve robb in ue5-main branch]
2024-01-19 16:41:35 -05:00
phil popp
b3db59ff1d Fix remaining failures in metasound automated node tests
#rb Rob.Gay
#jira UE-198649

[CL 30688714 by phil popp in ue5-main branch]
2024-01-18 12:47:05 -05:00
helen yang
7d074697a0 Add Find tab for searching within a MetaSound
- Search by node/pin name string, node type, data type, display name, value, or comment
- View default literal values (including marking overridden inputs, array num), extended values on tooltip
- Jump to result in graph on click
#jira UE-200535
#rb Rob.Gay

[CL 30662993 by helen yang in ue5-main branch]
2024-01-17 13:17:18 -05:00
sarah noonan
63b9103240 Delay MetaSoundSource calling RegisterGraphWithFrontend if the MetaSoundAssetManager has not been set yet - to facilitate server preloading assets before the manager has been set.
#rb Rob.Gay

[CL 30655975 by sarah noonan in ue5-main branch]
2024-01-17 07:07:19 -05:00
marc audy
56a32fea9d Silence false V621, V654, and V1078 warnings mostly caused by TStaticArray, placement new, or population of the array inside a lambda
[CL 30587485 by marc audy in ue5-main branch]
2024-01-12 00:52:57 -05:00
rob gay
1ed21ae9e0 Fix for compiled out path setter, le sigh
#rb helen.yang

[CL 30491013 by rob gay in ue5-main branch]
2024-01-08 17:02:57 -05:00
rob gay
e5fa925482 Fix incorrect transient asset path being registered at times due to template node processing generating new transient object representing provided document interface object. (Added bonus with BuildRegistryDoc now actually living in RegistryImpl private implementation where it should've to begin with rather in asset base now that registration headers have been cleaned up).
#rb helen.yang
#jira UE-198785
#rnx

[CL 30424305 by rob gay in ue5-main branch]
2023-12-20 19:49:45 -05:00
cody albert
14db176493 MetaSounds: Clamp RandomGet node's NoRepeats value immediately instead of waiting until it's saved to the RandomGets map. This fixes an issue where Shared State wouldn't work if No Repeat value was being clamped since the comparison would always indicate it needs to be stomped.
#rb helen.yang
#jira UE-203067

[CL 30415551 by cody albert in ue5-main branch]
2023-12-20 12:45:12 -05:00
rob gay
b7ecd11142 Remove and assert against registration/unregisteration calls of MetaSound graphs when cooking, and make all node unregistration calls synchronous when cooking
#rb helen.yang
#rnx
#tests AudioUnitTests, AudioQA -run=Cook -TargetPlatform=WindowsClient, rename asset, run Engine 'Audio' Automated Tests

[CL 30402526 by rob gay in ue5-main branch]
2023-12-19 15:55:04 -05:00
rob gay
5668343434 Don't warn for missing unregistration tasks in cook, where graphs are not registered
#rb helen.yang
#rnx

[CL 30383889 by rob gay in ue5-main branch]
2023-12-18 17:29:43 -05:00
AdricEpic
473f754908 - Registration Race Condition Fixes (Attempt #2 w/ cook fixes)
- Part 1/2 fixing inconsistent file naming that is causing code query tool slowdowns (2/2 will be deprecating old MetasoundFrontendRegistries.h header path)
- Replace SoftObjectPaths with TopLevelAssetPaths for perf (ObjPaths do string copies all over, TopLevelAssetPaths are just two FNames)
#rb helen.yang
#rnx
[FYI] sondra.moyls
#tests AudioQA/EngineTest MetaSound Automated Tests, AudioTests, cook WindowsClient, submit and backout and then fix those problems
#jira UE-198785

[CL 30354102 by AdricEpic in ue5-main branch]
2023-12-15 13:21:12 -05:00
rob gay
65111a0774 Fix for cook errors, undo changelist 30246187
#rb helen.yang
#rnx

[CL 30255375 by rob gay in ue5-main branch]
2023-12-11 20:36:24 -05:00
rob gay
a876bffd23 - Registration Race Condition Fixes
- Part 1/2 fixing inconsistent file naming that is causing code query tool slowdowns
- Replace SoftObjectPaths with TopLevelAssetPaths for perf (ObjPaths do string copies all over, TopLevelAssetPaths are just two FNames)
#rb helen.yang
#rnx
#tests AudioQA MetaSound Automated Tests, AudioTests
#jira UE-198785

[CL 30246215 by rob gay in ue5-main branch]
2023-12-11 14:43:42 -05:00
evgenii babinets
3c155122fc Isolating out some easy wins from deeper investigations into audio parameter optimizations. The biggest change is to the array parameter version of FAudioParameter::Merge where we'll now avoid sorting both arrays and just doing a binary search into the output array. This results in fewer shifting inserts as well, since the order of the output array is not required to be sorted.
Saves about 0.15ms with a dozen AudioComponentGroups updating parameters per frame.

#rb jordan.cristiano, miles.flanagan, Rob.Gay

[CL 30156944 by evgenii babinets in ue5-main branch]
2023-12-06 11:14:23 -05:00
rob gay
39b3a6f74c [MetaSounds] Report changes to transmitter and runtime input map when live edits are enabled during Builder audition
#rb charlie.huguenard
#rnx
#tests Audio Engine Tests including ConnectInputAfterAuditionAndThenSetParameter, Audio Unit Tests
#jira UE-201185
[FYI] sondra.moyls

[CL 30045928 by rob gay in ue5-main branch]
2023-12-01 12:57:59 -05:00