160 Commits

Author SHA1 Message Date
phil popp
c75fe2d241 Do not expect to retrieve quality settings from none-asset metasound. Alter ensure to log warning on failure.
#jira UE-210369, FORT-724365
#rb Rob.Gay

[CL 32512743 by phil popp in 5.4 branch]
2024-03-26 12:27:58 -04:00
jimmy smith
209ed4ce55 Fix for perf regression in Metasounds
#rb Maxwell.Hayes, phil.popp
#tests Local verification

[CL 32500366 by jimmy smith in 5.4 branch]
2024-03-26 03:01:29 -04:00
jimmy smith
20b54e4a7e Fix non-cooked quality settings by adding a cook stage the MetasoundSource to correctly save them out per platform.
Previously the PerPlatformSettings was added to the MetasoundSettings, however as this is not a true asset they weren't being correctly cooked.
The code previously pulled the global settings, then allowed overrides upon this. This decision is now made during cook.
#rb jake.burga, Josh.Adams
#tests Shelve tested back and forth with Sondra Moyles
#jira UE-204075

[CL 32500022 by jimmy smith in 5.4 branch]
2024-03-26 02:48:50 -04:00
jimmy andrews
32fdb471b8 fix unreachable implicit "++iterator" in cases where a for-loop was used to just grab the first element of a set or map
#rb lonnie.li
#lockdown michael.balzer

[CL 31877332 by jimmy andrews in 5.4 branch]
2024-02-28 13:34:31 -05:00
Maxwell Hayes
3454ac3cf4 Cleaning up metasound experimental cvars
#rb Phil.Popp
#jira UE-205183
#rnx

[CL 31178199 by Maxwell Hayes in 5.4 branch]
2024-02-05 12:33:10 -05:00
steve robb
f029468598 Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.
[CL 30729174 by steve robb in ue5-main branch]
2024-01-19 16:41:35 -05:00
sarah noonan
63b9103240 Delay MetaSoundSource calling RegisterGraphWithFrontend if the MetaSoundAssetManager has not been set yet - to facilitate server preloading assets before the manager has been set.
#rb Rob.Gay

[CL 30655975 by sarah noonan in ue5-main branch]
2024-01-17 07:07:19 -05:00
rob gay
b7ecd11142 Remove and assert against registration/unregisteration calls of MetaSound graphs when cooking, and make all node unregistration calls synchronous when cooking
#rb helen.yang
#rnx
#tests AudioUnitTests, AudioQA -run=Cook -TargetPlatform=WindowsClient, rename asset, run Engine 'Audio' Automated Tests

[CL 30402526 by rob gay in ue5-main branch]
2023-12-19 15:55:04 -05:00
AdricEpic
473f754908 - Registration Race Condition Fixes (Attempt #2 w/ cook fixes)
- Part 1/2 fixing inconsistent file naming that is causing code query tool slowdowns (2/2 will be deprecating old MetasoundFrontendRegistries.h header path)
- Replace SoftObjectPaths with TopLevelAssetPaths for perf (ObjPaths do string copies all over, TopLevelAssetPaths are just two FNames)
#rb helen.yang
#rnx
[FYI] sondra.moyls
#tests AudioQA/EngineTest MetaSound Automated Tests, AudioTests, cook WindowsClient, submit and backout and then fix those problems
#jira UE-198785

[CL 30354102 by AdricEpic in ue5-main branch]
2023-12-15 13:21:12 -05:00
rob gay
65111a0774 Fix for cook errors, undo changelist 30246187
#rb helen.yang
#rnx

[CL 30255375 by rob gay in ue5-main branch]
2023-12-11 20:36:24 -05:00
rob gay
a876bffd23 - Registration Race Condition Fixes
- Part 1/2 fixing inconsistent file naming that is causing code query tool slowdowns
- Replace SoftObjectPaths with TopLevelAssetPaths for perf (ObjPaths do string copies all over, TopLevelAssetPaths are just two FNames)
#rb helen.yang
#rnx
#tests AudioQA MetaSound Automated Tests, AudioTests
#jira UE-198785

[CL 30246215 by rob gay in ue5-main branch]
2023-12-11 14:43:42 -05:00
rob gay
39b3a6f74c [MetaSounds] Report changes to transmitter and runtime input map when live edits are enabled during Builder audition
#rb charlie.huguenard
#rnx
#tests Audio Engine Tests including ConnectInputAfterAuditionAndThenSetParameter, Audio Unit Tests
#jira UE-201185
[FYI] sondra.moyls

[CL 30045928 by rob gay in ue5-main branch]
2023-12-01 12:57:59 -05:00
helen yang
af275bf607 CIS fix for MetaSound runtime data being created at cook
#rb jimmy.smith

[CL 29573194 by helen yang in ue5-main branch]
2023-11-08 16:09:39 -05:00
phil popp
af5147f91d Fix use of pooled metasounds using preset graph inflation and constructor inputs
#rnx
#rb Maxwell.Hayes

[CL 29431656 by phil popp in ue5-main branch]
2023-11-03 19:38:58 -04:00
phil popp
559eaa393f Fix default parameter values when skipping preset
#jira UE-199604
#rb Maxwell.Hayes
#rnx

[CL 29385950 by phil popp in ue5-main branch]
2023-11-02 18:41:29 -04:00
phil popp
499d1ce096 [Backout] - CL29329991
[FYI] phil.popp
Original CL Desc
-----------------------------------------------------------------
Default graph preset inflation to "true"
#rb Maxwell.Hayes, Aaron.Mcleran

[CL 29346598 by phil popp in ue5-main branch]
2023-11-01 21:18:10 -04:00
phil popp
c6ed65b2a7 Default graph preset inflation to "true"
#rb Maxwell.Hayes, Aaron.Mcleran

[CL 29338655 by phil popp in ue5-main branch]
2023-11-01 19:17:02 -04:00
phil popp
427b14e23f Enable preset metasound sources to use their base graph instead of themselves.
#rb rob.gay

[CL 29320958 by phil popp in ue5-main branch]
2023-11-01 12:17:48 -04:00
maxwell hayes
8e9187b0cf [Metasounds] Operator precaching mechanism.
#jira UE-185725, UE-179996,
#rb phil.popp
#swarm https://p4-swarm.epicgames.net/reviews/27703580

[CL 28775007 by maxwell hayes in ue5-main branch]
2023-10-13 17:49:56 -04:00
jimmy smith
4cc08333b4 Fix for Metasounds not using device rate when Quality Settings are disabled
#jira UE-197723
#rb jake.burga

[CL 28692628 by jimmy smith in ue5-main branch]
2023-10-11 19:55:59 -04:00
jimmy smith
f2080e3c96 [Resubmit] Make the CVARs a global override instead of just the defaults
#jira UE-196264
#rb aaron.mcleran

[CL 28627751 by jimmy smith in ue5-main branch]
2023-10-10 13:37:20 -04:00
phil popp
7e2c4e32d2 Fix deadlock in metasound node registration when updating assets
#rb Helen.Yang
#rnx
#jira UE-196443, UE-197063

[CL 28621450 by phil popp in ue5-main branch]
2023-10-10 11:32:28 -04:00
helen yang
75d35f6029 Prevent MetaSound InitResources from running during cook from MetaSounds used in SoundCues
#jira UE-197371
#rb phil.popp

[CL 28592187 by helen yang in ue5-main branch]
2023-10-09 14:40:31 -04:00
bob tellez
28443a5e59 [Backout] - CL28560665
[FYI] jimmy.smith
Original CL Desc
-----------------------------------------------------------------
Make the CVARs a global override instead of just the defaults
#jira UE-196264
#rb aaron.mcleran

[CL 28563662 by bob tellez in ue5-main branch]
2023-10-06 19:42:56 -04:00
jimmy smith
8eed59c6e9 Make the CVARs a global override instead of just the defaults
#jira UE-196264
#rb aaron.mcleran

[CL 28560930 by jimmy smith in ue5-main branch]
2023-10-06 18:51:06 -04:00