50 Commits

Author SHA1 Message Date
jimmy smith
20b54e4a7e Fix non-cooked quality settings by adding a cook stage the MetasoundSource to correctly save them out per platform.
Previously the PerPlatformSettings was added to the MetasoundSettings, however as this is not a true asset they weren't being correctly cooked.
The code previously pulled the global settings, then allowed overrides upon this. This decision is now made during cook.
#rb jake.burga, Josh.Adams
#tests Shelve tested back and forth with Sondra Moyles
#jira UE-204075

[CL 32500022 by jimmy smith in 5.4 branch]
2024-03-26 02:48:50 -04:00
steve robb
f029468598 Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.
[CL 30729174 by steve robb in ue5-main branch]
2024-01-19 16:41:35 -05:00
AdricEpic
473f754908 - Registration Race Condition Fixes (Attempt #2 w/ cook fixes)
- Part 1/2 fixing inconsistent file naming that is causing code query tool slowdowns (2/2 will be deprecating old MetasoundFrontendRegistries.h header path)
- Replace SoftObjectPaths with TopLevelAssetPaths for perf (ObjPaths do string copies all over, TopLevelAssetPaths are just two FNames)
#rb helen.yang
#rnx
[FYI] sondra.moyls
#tests AudioQA/EngineTest MetaSound Automated Tests, AudioTests, cook WindowsClient, submit and backout and then fix those problems
#jira UE-198785

[CL 30354102 by AdricEpic in ue5-main branch]
2023-12-15 13:21:12 -05:00
rob gay
65111a0774 Fix for cook errors, undo changelist 30246187
#rb helen.yang
#rnx

[CL 30255375 by rob gay in ue5-main branch]
2023-12-11 20:36:24 -05:00
rob gay
a876bffd23 - Registration Race Condition Fixes
- Part 1/2 fixing inconsistent file naming that is causing code query tool slowdowns
- Replace SoftObjectPaths with TopLevelAssetPaths for perf (ObjPaths do string copies all over, TopLevelAssetPaths are just two FNames)
#rb helen.yang
#rnx
#tests AudioQA MetaSound Automated Tests, AudioTests
#jira UE-198785

[CL 30246215 by rob gay in ue5-main branch]
2023-12-11 14:43:42 -05:00
rob gay
39b3a6f74c [MetaSounds] Report changes to transmitter and runtime input map when live edits are enabled during Builder audition
#rb charlie.huguenard
#rnx
#tests Audio Engine Tests including ConnectInputAfterAuditionAndThenSetParameter, Audio Unit Tests
#jira UE-201185
[FYI] sondra.moyls

[CL 30045928 by rob gay in ue5-main branch]
2023-12-01 12:57:59 -05:00
rob gay
ce52e1385b Enable transaction-based registration in Builder API
[FYI] helen.yang
#rb phil.popp
#jira UE-198400
#rnx

[CL 29695816 by rob gay in ue5-main branch]
2023-11-13 16:53:37 -05:00
rob gay
10d3a99970 Add quality, sample rate & block rate override setters to MS builder API
#jira UE-200031
#rnx
#rb jimmy.smith
[FYI] charlie.huguenard, sondra.moyls, buzz.burrowes, matthew.booth

[CL 29574690 by rob gay in ue5-main branch]
2023-11-08 16:53:27 -05:00
rob gay
9ec52c5d42 Only register assets requested from builder if never built or if builder has transactions logged requiring re-registration (CVar disabled, will enable in subsequent change)
#rb phil.popp
#jira UE-198400
[FYI] helen.yang, Maxwell.Hayes, sondra.moyls, charlie.huguenard

[CL 29291747 by rob gay in ue5-main branch]
2023-10-31 17:16:11 -04:00
rob gay
94048f43ca - Make FNodeRegistryKey an actual struct as opposed to a string alias
- Avoids string format/copies/conversions in most cases where its just used as a key
- Deprecate NodeRegistryKey namespace calls
#rb phil.popp
#rb helen.yang

[CL 28727626 by rob gay in ue5-main branch]
2023-10-12 16:37:45 -04:00
phil popp
e631780063 Register metasound graphs asynchronously
#jira UE-185834, FORT-658630
#rb Rob.Gay, Helen.Yang

[CL 28149471 by phil popp in ue5-main branch]
2023-09-22 15:01:07 -04:00
phil popp
b478631318 [Backout] - CL28104009
[FYI] phil.popp
Original CL Desc
-----------------------------------------------------------------
Register metasound graphs asynchronously
#jira UE-185834
#rb Rob.Gay, Helen.Yang

[CL 28111209 by phil popp in ue5-main branch]
2023-09-21 18:24:25 -04:00
phil popp
adbad7a65f Register metasound graphs asynchronously
#jira UE-185834
#rb Rob.Gay, Helen.Yang

[CL 28104164 by phil popp in ue5-main branch]
2023-09-21 16:35:40 -04:00
rob gay
e2a68f998b Fix for crash in tests when MetaSoundBuilderSubsystem is not yet loaded
#rb trivial
#rnx

[CL 27968125 by rob gay in ue5-main branch]
2023-09-18 14:32:59 -04:00
charlie huguenard
c78e16755c [Metasound] Ensure input node defaults are propagated
#jira UE-193390
#rb phil.popp

[CL 27917778 by charlie huguenard in ue5-main branch]
2023-09-15 11:47:57 -04:00
rob gay
008b0741b2 Move MetasoundDocumentBuilders to cache-on-demand
- Invalidate subsystem registerd asset builder cache upon soft deprecated document access id creation
#rb phil.popp
#jira UE-194159
#rnx

[CL 27894768 by rob gay in ue5-main branch]
2023-09-14 16:54:36 -04:00
rob gay
0b5702d6e8 - Make UMetaSoundSource & UMetaSoundPatch the direct document manipulated object for subsystem builders
- Remove specialized Audition object in favor of directly using UMetaSoundSource for Source builders
#rb phil.popp
#jira UE-194159

[CL 27861100 by rob gay in ue5-main branch]
2023-09-13 20:11:49 -04:00
rob gay
2660985605 [MetaSounds] Automated test & fix-up for getting class, node, access type, and ctor state of node inputs/outputs
#rb helen.yang
#rnx
#jira UE-194159

[CL 27772157 by rob gay in ue5-main branch]
2023-09-11 17:33:43 -04:00
Rob Gay
0ce9da005d Prepare code to preprocess MetaSound cooked layers/pages
- Move reroute preprocessing to Builder API
- Fix for potential memory scribble when deleting output edges in builder
- Move builder to use deterministic guid generation where necessary
#rb helen.yang
#rb phil.popp
#jira UE-194159
#rnx

[CL 27615214 by Rob Gay in ue5-main branch]
2023-09-05 17:54:02 -04:00
helen yang
939f35db64 Various minor MetaSound Builder BP function fixups
- Default MajorVersion to 1 for AddNodeByClassName w/ better log
- Set some lesser used pins to AdvancedDisplay
- Clarify Node Handle display name

#rb maxwell.hayes
#jira UE-192617
#jira UE-192628

[CL 27559967 by helen yang in ue5-main branch]
2023-09-01 13:19:23 -04:00
phil popp
e7c868728a Audio unit test build fixes
#jira UE-193300
#lockdown julien.marchand
#rb rob.guay

[CL 27186267 by phil popp in ue5-main branch]
2023-08-17 17:25:00 -04:00
rob gay
b33d472465 - Fix for crash when attempting to add graph input to MetaSound while auditioning builder from BP
- Fix for ensure if DataType provided to add graph input/output MetaSound Builder is invalid
#rb phil.popp
#jira UE-192614
#rnx

[CL 27159032 by rob gay in ue5-main branch]
2023-08-16 18:37:56 -04:00
rob gay
a7ba7c0b74 Fix for MetaSound live update failing to create & forward input/output (and other currently unsupported types like variable) nodes to transactor
#rb phil.popp
#jira UE-192623
#jira UE-192614
#rnx

[CL 27117956 by rob gay in ue5-main branch]
2023-08-15 16:06:58 -04:00
rob gay
61cb3544cf - Fix for auditioning the same sound multiple times not respecting live updates on additional calls
- Upgrade Live Node Update automation tests to LiveUpdateMultipleMetaSoundSources for more comprehensive coverage
#rb helen.yang
#jira UE-192099
#rnx
#lockdown julien.marchand

[CL 26971688 by rob gay in ue5-main branch]
2023-08-09 16:45:21 -04:00
rob gay
3568cc0034 - Remove --> RemoveSwap delegates to allow for handlers to not duplicate forwarded messages where applicable
- Refactor remove node handler for transactor to not do swap piecemeal, which was resulting in dropped connections
- Add test for adding/removing nodes while auditioning (excercises add/remove edges by extension)
#rb phil.popp
#rnx
#jira UE-191865

[CL 26890183 by rob gay in ue5-main branch]
2023-08-07 13:38:36 -04:00