phil popp
c75fe2d241
Do not expect to retrieve quality settings from none-asset metasound. Alter ensure to log warning on failure.
...
#jira UE-210369, FORT-724365
#rb Rob.Gay
[CL 32512743 by phil popp in 5.4 branch]
2024-03-26 12:27:58 -04:00
jimmy smith
209ed4ce55
Fix for perf regression in Metasounds
...
#rb Maxwell.Hayes, phil.popp
#tests Local verification
[CL 32500366 by jimmy smith in 5.4 branch]
2024-03-26 03:01:29 -04:00
jimmy smith
20b54e4a7e
Fix non-cooked quality settings by adding a cook stage the MetasoundSource to correctly save them out per platform.
...
Previously the PerPlatformSettings was added to the MetasoundSettings, however as this is not a true asset they weren't being correctly cooked.
The code previously pulled the global settings, then allowed overrides upon this. This decision is now made during cook.
#rb jake.burga, Josh.Adams
#tests Shelve tested back and forth with Sondra Moyles
#jira UE-204075
[CL 32500022 by jimmy smith in 5.4 branch]
2024-03-26 02:48:50 -04:00
jimmy smith
a7943f545a
Fix for Client Crash - ADPCM::DecodeBlock() - Code by Aaron.
...
#rb aaron.mcleran
[FYI] aaron.mcleran
[CL 32498400 by jimmy smith in 5.4 branch]
2024-03-26 01:53:38 -04:00
matthew booth
17bd47ef50
[MetasoundEngine] Provide UnwatchOutput API as inverse of WatchOutput operation.
...
#rb charlie.huguenard
[CL 32489798 by matthew booth in 5.4 branch]
2024-03-25 18:42:59 -04:00
Maxwell Hayes
b0678ef0d6
[MetaSound Operator Cache] Added defense and warning against calling Remove without a MetaSound source
...
#jira UE-201800
#swarm 32060562
#rb alfaroh.corneyiii
[CL 32066132 by Maxwell Hayes in 5.4 branch]
2024-03-06 16:03:57 -05:00
jimmy andrews
32fdb471b8
fix unreachable implicit "++iterator" in cases where a for-loop was used to just grab the first element of a set or map
...
#rb lonnie.li
#lockdown michael.balzer
[CL 31877332 by jimmy andrews in 5.4 branch]
2024-02-28 13:34:31 -05:00
Maxwell Hayes
c1ebef860d
[AudioBus] Fix for incorrect clamp at higher channel counts.
...
#rb Aaron.McLeran
#jira UE-204171, UE-205086
[CL 31735897 by Maxwell Hayes in 5.4 branch]
2024-02-22 16:49:48 -05:00
rob gay
e8f67ef2c7
- Fix for shutdown crash in FWaveAsset construction due to IStreamingManager becoming invalid while operator cache is building proxies async
...
- Fix for shutdown stall caused by operator cache not canceling async build gracefully
#jira UE-201787
#rnx
#rb maxwell.hayes
#tests AudioUnitTests, ran bug repro
[CL 31457842 by rob gay in 5.4 branch]
2024-02-13 20:57:28 -05:00
Maxwell Hayes
cdceb69ff9
Fix for metasound ensure during ResavePackages commandlet.
...
#jira UE-203265
#rb helen.yang
[CL 31389223 by Maxwell Hayes in 5.4 branch]
2024-02-12 12:54:06 -05:00
ericdrobinson
adcd5c68e1
Update MetaSound FTime accessiblity from MetaSound outputs.
...
#10697
#10663
#jira UE-190586, UE-190587
#rb charlie.huguenard
[CL 31388195 by ericdrobinson in 5.4 branch]
2024-02-12 12:36:01 -05:00
Maxwell Hayes
49225f988b
Ensures in Metasound Operator Cache Subsystem
...
#jira UE-201794, UE-201795
#rb alfaroh.corneyiii
#rnx
[CL 31310729 by Maxwell Hayes in 5.4 branch]
2024-02-08 18:23:13 -05:00
Maxwell Hayes
3454ac3cf4
Cleaning up metasound experimental cvars
...
#rb Phil.Popp
#jira UE-205183
#rnx
[CL 31178199 by Maxwell Hayes in 5.4 branch]
2024-02-05 12:33:10 -05:00
phil popp
bb3dbb7e18
Avoid registering unused send/receive nodes
...
#jira UE-204391, UE-204393, UE-190886
#rb Rob.Gay
[CL 30890172 by phil popp in 5.4 branch]
2024-01-25 12:08:15 -05:00
steve robb
f029468598
Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.
...
[CL 30729174 by steve robb in ue5-main branch]
2024-01-19 16:41:35 -05:00
sarah noonan
63b9103240
Delay MetaSoundSource calling RegisterGraphWithFrontend if the MetaSoundAssetManager has not been set yet - to facilitate server preloading assets before the manager has been set.
...
#rb Rob.Gay
[CL 30655975 by sarah noonan in ue5-main branch]
2024-01-17 07:07:19 -05:00
maxwell hayes
f6f282a246
[Metasound] (speculative) Guard against Audio Bus Reader crash when AudioBusProxy reports unreasonable channel count.
...
#rb jimmy.smith
[CL 30556146 by maxwell hayes in ue5-main branch]
2024-01-10 19:15:33 -05:00
rob gay
1ed21ae9e0
Fix for compiled out path setter, le sigh
...
#rb helen.yang
[CL 30491013 by rob gay in ue5-main branch]
2024-01-08 17:02:57 -05:00
rob gay
b7ecd11142
Remove and assert against registration/unregisteration calls of MetaSound graphs when cooking, and make all node unregistration calls synchronous when cooking
...
#rb helen.yang
#rnx
#tests AudioUnitTests, AudioQA -run=Cook -TargetPlatform=WindowsClient, rename asset, run Engine 'Audio' Automated Tests
[CL 30402526 by rob gay in ue5-main branch]
2023-12-19 15:55:04 -05:00
AdricEpic
473f754908
- Registration Race Condition Fixes (Attempt #2 w/ cook fixes)
...
- Part 1/2 fixing inconsistent file naming that is causing code query tool slowdowns (2/2 will be deprecating old MetasoundFrontendRegistries.h header path)
- Replace SoftObjectPaths with TopLevelAssetPaths for perf (ObjPaths do string copies all over, TopLevelAssetPaths are just two FNames)
#rb helen.yang
#rnx
[FYI] sondra.moyls
#tests AudioQA/EngineTest MetaSound Automated Tests, AudioTests, cook WindowsClient, submit and backout and then fix those problems
#jira UE-198785
[CL 30354102 by AdricEpic in ue5-main branch]
2023-12-15 13:21:12 -05:00
helen yang
12e25335ce
Fix MetaSound warning for external node classes that should only apply for asset classes
...
#jira UE-202536
#rb Rob.Gay
[CL 30337955 by helen yang in ue5-main branch]
2023-12-14 19:12:32 -05:00
jimmy smith
7e987844d7
Fix quality settings named "None" causing issues with Defaults.
...
#jira UE-202506
#rb Maxwell.Hayes
[CL 30311599 by jimmy smith in ue5-main branch]
2023-12-13 19:54:40 -05:00
rob gay
65111a0774
Fix for cook errors, undo changelist 30246187
...
#rb helen.yang
#rnx
[CL 30255375 by rob gay in ue5-main branch]
2023-12-11 20:36:24 -05:00
rob gay
a876bffd23
- Registration Race Condition Fixes
...
- Part 1/2 fixing inconsistent file naming that is causing code query tool slowdowns
- Replace SoftObjectPaths with TopLevelAssetPaths for perf (ObjPaths do string copies all over, TopLevelAssetPaths are just two FNames)
#rb helen.yang
#rnx
#tests AudioQA MetaSound Automated Tests, AudioTests
#jira UE-198785
[CL 30246215 by rob gay in ue5-main branch]
2023-12-11 14:43:42 -05:00
jake burga
e5270a8e75
Delete IAudioCodec and IAudioCodecRegistry
...
[REVIEW] [at]jimmy.smith
#rb jimmy.smith
#tests PIE
[CL 30212422 by jake burga in ue5-main branch]
2023-12-08 11:50:21 -05:00
