332 Commits

Author SHA1 Message Date
Jimmy Andrews
403e8a33ce add a nullptr check to component collision util's ConvertSimpleCollisionToMeshes, method, fixing consistent crash in Geometry Script's CopyCollisionMeshesFromObject method
#jira UE-213569
#rb jimmy.andrews



#[robomerge][bot5] -FNActiveRelease

#ushell-cherrypick of 33376717 by jimmy.andrews

[CL 33459514 by Jimmy Andrews in 5.4 branch]
2024-05-06 12:24:19 -04:00
jimmy andrews
1c2d077762 fix crash if trying to convert a cooked-for-editor geometry collection
#rb lonnie.li

[CL 32500145 by jimmy andrews in 5.4 branch]
2024-03-26 02:52:58 -04:00
lonnie li
1c2bd0ff82 ModelingTools: Disable Convert tool on bIsCookedForEditor StaticMesh and SkeletalMesh assets again to prevent crashes when running the tool on read-only cooked assets in UEFN.
#rb Jimmy.Andrews

[CL 32497044 by lonnie li in 5.4 branch]
2024-03-26 00:55:47 -04:00
yoan stamant
662e24e634 Converted some header deprecation from 5.5 to 5.4
#rb Marc.Audy

[CL 32483076 by yoan stamant in 5.4 branch]
2024-03-25 16:37:55 -04:00
yoan stamant
c9729340a7 Removed some headers dependencies on 'FHitResult' and 'FOverlapResult'
#rb Mieszko.Zielinski

[CL 32478772 by yoan stamant in 5.4 branch]
2024-03-25 14:41:09 -04:00
alex kahn
6a6abbfa61 [Backout] - CL31425693 - CIS UE Error Backout 4/4
[FYI] Yoan.StAmant
Original CL Desc
-----------------------------------------------------------------
Removed some headers dependencies on 'FHitResult' and 'FOverlapResult'
#rb Mieszko.Zielinski

[CL 32477731 by alex kahn in 5.4 branch]
2024-03-25 14:17:33 -04:00
yoan stamant
e527080e32 Removed some headers dependencies on 'FHitResult' and 'FOverlapResult'
#rb Mieszko.Zielinski

[CL 32477590 by yoan stamant in 5.4 branch]
2024-03-25 14:14:31 -04:00
katie caputo
b936494618 Modeling Tools: Places Mesh Element Selection Gizmo in Object Frame Mode at selected component(s) pivot rather than at object's pivot
#JIRA UE-206515
#rb lonnie.li

[CL 31571303 by katie caputo in 5.4 branch]
2024-02-16 13:05:19 -05:00
jimmy andrews
82fc3c90bb Make create-from-selected tools apply updated materials to both the component as well as the asset, so that the material reliably shows in the result while still applying to the asset
#jira UE-183218
#rb tyson.brochu

[CL 31554905 by jimmy andrews in 5.4 branch]
2024-02-15 23:10:02 -05:00
jimmy andrews
45f71b5fd0 fix convert tool losing materials
#rb tyson.brochu

[CL 31554816 by jimmy andrews in 5.4 branch]
2024-02-15 23:00:01 -05:00
jimmy andrews
324b626381 stop silent-updating the uv layout preview wireframe when its visibility is turned off, so it actually sees the visibility change
#jira UE-187179
#rb David.Hill

[CL 31527943 by jimmy andrews in 5.4 branch]
2024-02-15 14:04:34 -05:00
jimmy andrews
cad9bd3209 deprecate now-unused FGenericMeshSelection struct
#rb David.Hill

[CL 31527830 by jimmy andrews in 5.4 branch]
2024-02-15 14:00:57 -05:00
jimmy andrews
e7446da10c remove various deprecated methods from modeling components code
#rb jimmy.andrews

[CL 31499394 by jimmy andrews in 5.4 branch]
2024-02-14 18:25:03 -05:00
jimmy andrews
43a9f87913 remove deprecated persistent mesh selection code from modelingcomponents
#rb jimmy.andrews

[CL 31496773 by jimmy andrews in 5.4 branch]
2024-02-14 17:42:39 -05:00
nickolas drake
e2ba251d30 MeshModelingToolset: Allow snapping to objects in scene when using DrawPolygonTool even when the camera is positioned such that the raycast does not hit the tool plane.
We now early out when the raycast misses the plane if snapping is disabled. If the tool plane is missed, then we use a point along the camera ray to find scene snap point (passed to FindSceneSnapPoint). A related bug is also fixed in this change in the snapping manager which caused only small sections of snappable edges to be considered. This was because the point passed to FindSceneSnapPoint was used to find a point on the 3 edges of a hit triangle, which is sensitive to camera position. Instead, we now use the raycast's impact point for the purposes of finding snap points on edges.

#rb Jimmy.Andrews, semion.piskarev
#jira UE-203169

[CL 31479814 by nickolas drake in 5.4 branch]
2024-02-14 12:20:29 -05:00
jimmy andrews
772e387d51 disable workarounds for now-fixed collision update bug, so bake transform, edit pivot, and the various voxel/boolean tools will not create two transactions per operation for static meshes that have convex collision
#jira UE-165856
#rb David.Hill, lonnie.li

[CL 31347614 by jimmy andrews in 5.4 branch]
2024-02-09 13:15:25 -05:00
nickolas drake
9b96207b83 MeshModelingToolset: Fix crash when hiding actors deleted by tools with Delete Inputs option.
Our approach to deleting actors was apparently not sufficient to notify various editor systems of the deletion. This CL replaces AActor::Destroy with calls to UUnrealEdEngine::DeleteActors and UWorld::DeleteActor (depending on the context)

#rb lonnie.li
#jira UE-204240

[CL 31297677 by nickolas drake in 5.4 branch]
2024-02-08 14:09:05 -05:00
jimmy andrews
f9eba0c4ac fix polyedit's edge loop selection modifying the edge selection while it iterates through it
#jira UE-205955
#rb semion.piskarev

#changelist validated
#virtualized

[CL 31224079 by jimmy andrews in 5.4 branch]
2024-02-06 14:00:49 -05:00
katie caputo
65f49dec9c Modeling Tools: Adds 'Local Frame Mode' toggle in the Mesh Element Selection Toolbar Settings so users can edit with the gizmo based either on the selected geometry only or on the entire object
#JIRA UE-202681
#rb lonnie.li, nickolas.drake

[CL 31126159 by katie caputo in 5.4 branch]
2024-02-02 10:54:38 -05:00
jimmy andrews
454619ac72 Fix CopyMeshFromComponent in geometryscript not being able to see instance colors for renderdata lod
#rb David.Hill

[CL 31124942 by jimmy andrews in 5.4 branch]
2024-02-02 10:20:00 -05:00
nathan mitchell
26be91fa58 UVEditor: Improved handling of multiple object loading in the UVEditor's 3D viewport.
Two behaviors now exist. When selecting from the Level Editor viewport, relative transforms between all selected objects are preserved in the subsequent UVEditor's viewport. When selecting from the Content Browser, or other sources that don't wrap the selected objects in a Component, the UVEditor will provide an automatic layout based on the object's bounding spheres.

Further, there are two new CVARs:

modeling.UVEditor.EnableLivePreviewArrangement - Enables or Disables the auto arrangement feature when selecting from the Content Browser. This exists to support legacy behavior where users might want the object's baked in transform to position objects in the UVEditor.

modeling.UVEditor.LivePreviewArrangementMode - Selects the mode of the auto arrangement. 0 indicates a line formation. 1 indicates an adaptive circular arrangement.

#rb lonnie.li
#jira UE-202730

[CL 30948349 by nathan mitchell in 5.4 branch]
2024-01-26 18:38:19 -05:00
nickolas drake
af66060d0b MeshElementSelection: Remove deprecation markup from UGeometrySelectionManager::ActivePreviewSelection
This was mistakenly included as I thought the SubmitTool had finished its work and I started messing around and it picked up my change

[FYI] lonnie.li

[CL 30862923 by nickolas drake in 5.4 branch]
2024-01-24 16:48:23 -05:00
nickolas drake
9fe266cccd MeshElementSelection: Make selectable mesh elements visible.
When we have a valid topology type (Triangle or Poly, not None), we render selectable mesh elements.

Added AccumulateElementsFromPredicate to the GeometrySelector interface which allows a predicate function to filter which geometry elements ought to be included in the provided FGeometrySelectionElements. The predicate is aware of the type of element (vert, edge, tri) and the selected element ID (which is a single value encoding the topology ID and the element ID). The predicate returns true for elements to include and false for elements to exclude. Internally, this function builds transient vert, edge, and tri selections with this predicate and then accumulates all selection elements into the provided FGeometrySelectionElements.

#rb lonnie.li
#jira UE-202674

[CL 30862050 by nickolas drake in 5.4 branch]
2024-01-24 16:25:45 -05:00
steve robb
f029468598 Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.
[CL 30729174 by steve robb in ue5-main branch]
2024-01-19 16:41:35 -05:00
semion piskarev
3d4bf819a5 ModelingTools: Allow tools to customize the accept/cancel overlay for sub-activitites, and use this in PolyEd.
#rb lonnie.li
#jira UE-196706

[CL 30601293 by semion piskarev in ue5-main branch]
2024-01-12 15:01:55 -05:00