1865 Commits

Author SHA1 Message Date
juan legaz
acf3d8d0f5 Fix Perforce create changelist moving all files from the default CL to the new changelist instead of creating an empty changelist or moving only the selected files
#rb benoit.chauvin, paul.chipchase

[CL 34280797 by juan legaz in 5.4 branch]
2024-06-11 12:31:39 -04:00
juan legaz
41212abbaa Changed p4 change -i to p4 change and reusing the template that the server provides
This ensures that we use the changelist type from the server which was being dropped

#rb alan.kwan, paul.chipchase
#rnx

[CL 34244739 by juan legaz in 5.4 branch]
2024-06-10 13:28:19 -04:00
zach brockway
1a496a6b36 Concert: Fix for crash when transacting level instance actor filters.
Before, when InObject was a ULevelInstanceComponent, we'd return USceneComponent::StaticClass. That happened to work for any properties which ULevelInstanceComponent inherited from USceneComponent (such as transforms, which we tested), but would crash for any properties introduced in/unique to ULevelInstanceComponent (such as actor filters, which we must not have).

#jira UE-209059
#rb jason.walter

[CL 32512369 by zach brockway in 5.4 branch]
2024-03-26 12:23:02 -04:00
dominik peacock
ac383fdbe9 MU replication: Add missing nullptr check when calling TryLoadClass from a class path that may be invalid.
Also adds logging to similar places to be able to get info next time the class is null (when it should not be).

#jira UE-210276

[CL 32510371 by dominik peacock in 5.4 branch]
2024-03-26 11:31:28 -04:00
dominik peacock
7332bb29b9 Wrap FProperty::GetDisplayNameText with WITH_EDITORONLY_DATA
[CL 32498236 by dominik peacock in 5.4 branch]
2024-03-26 01:49:54 -04:00
dominik peacock
43fa144efc Move the "Replicating x objects for y actors" status text to the bottom of the widget instead of at the top-right corner.
This makes it more consistent with the rest of the engine.

#jira UE-209486

[CL 32498121 by dominik peacock in 5.4 branch]
2024-03-26 01:45:26 -04:00
dominik peacock
aad1b7d297 Adjust replication column content:
- Property Label column now displays names of properties instead of their property paths.  This makes it more consistent how the properties are displayed in details panel (e.g. bools are no longer displayed as bName but Name).
- The Type columns now have padding of 8 from left to align column content in a vertical line with column header

#jira UE-209485

[CL 32498110 by dominik peacock in 5.4 branch]
2024-03-26 01:44:58 -04:00
maxime mercier
d27a8d0354 Fix LiveEdit being broken since the new property bag checkin. Was related to how we store property types now. Fixed by making the archive persistent.
#rb Devin.Doucette

[CL 32496962 by maxime mercier in 5.4 branch]
2024-03-26 00:53:26 -04:00
wouter burgers
6cb4500c45 Skein / ViewportStatus: Update TTypedElementRevisionControlFactory query.
The query now assigns an outline color using the criteria described in the ProductSpec.
- Yellow, if a newer package is available.
- Red, if someone else locked the package,
- Green, if package is added locally.
- Blue, if package is locked by user.

The color indices still, as before, rely on the container in UEditorStyleSettings.

I've introduced a FSCCNotCurrentTag to know in the processor if something is at the latest revision as it will not be obvious for some source control systems to provide an ordering based on just FSCCRevisionId (if it's a GUID for example).

#rb ronald.koppers, zach.rammell
#rnx

[CL 32492266 by wouter burgers in 5.4 branch]
2024-03-25 19:33:31 -04:00
jason walter
19b6bada0f If we are loading the p-level then skip tracking / hot reloading of the sub-level as it will be reloaded when we do the load map.
#lockdown alejandro.arango
#jira UE-208313
#rb jeremie.roy

[CL 31888191 by jason walter in 5.4 branch]
2024-02-28 17:24:55 -05:00
dominik peacock
e22d39ccab MU Replication: when applying received replicated data, fix resetting the transform back to the value it had just before the replicated data was applied.
- This was an "obvious" mistake when replicating component transforms and should not have worked in the first place, but did in some setups. It became apparent on stage.

#jira UE-207718
#rb jason.walter
#lockdown Alejandro.Arango

[CL 31882225 by dominik peacock in 5.4 branch]
2024-02-28 15:29:33 -05:00
paul chipchase
ceaca71158 Fix assert when failing to clobber a file.
#rb juan.legaz
#jira UE-203769
#rnx

- The problem was introduced in my change CL 30208400 where I mistakenly believed that all messages should be routed through ClientUser::Message so added asserts to detect and classes derived from FP4ClientUser calling the lower level Info/Error methods. Server messages do indeed all go through ::Message but local client issues can call the lower level methods directly so my assumption was unsafe. To make matters worse the most common local error we have concerns clobbering files but I tend to run workspaces with "clobber" option rather than "noclobber" so I did not see the problem in testing.
- We once again implement ClientUser::OutputInfo and ClientUser::OutputError and store the messages in the correct array.
- The default implementation of ClientUser::HandleError calls ::OutputError so there is no point implementing this method but we also don't need to assert if it is called.

[CL 31772785 by paul chipchase in 5.4 branch]
2024-02-23 14:53:48 -05:00
dominik peacock
fa2c58d7fe MU replication: Fix several contributing issues that caused assigning different clients to fail and block the replication system
- Struct property stays assigned when reassigning child (UE-207448)
- Property assignment combo box does not reflect correct state (UE-207449)
- Added clear button to unassign properties from all clients (trivial)
- Fix property view closing when you remove the last property from an actor

#jira UE-206947, UE-207448, UE-207449
#rb jason.walter
#lockdown Alejandro.Arango

[CL 31755048 by dominik peacock in 5.4 branch]
2024-02-22 22:26:37 -05:00
dominik peacock
a39e596856 Replication Tree View
- no longer resorts properties based on whether they're being replication
- auto expands child properties when searching by text

#jira UE-207512
#rb jason.walter
#lockdown Alejandro.Arango

[CL 31754344 by dominik peacock in 5.4 branch]
2024-02-22 21:50:12 -05:00
dominik peacock
5f0ddf20f9 Fix missing deregistration of GEngine delegates
#jira UE-207630
#rb jason.walter
#lockdown Alejandro.Arango

[CL 31754284 by dominik peacock in 5.4 branch]
2024-02-22 21:49:06 -05:00
dominik peacock
b2257a054a Add missing copyright boilerplate
[CL 31570103 by dominik peacock in 5.4 branch]
2024-02-16 12:31:27 -05:00
dominik peacock
c45c0067a6 MU Replication: Detect when an object is renamed and re-resolve the soft object path
- This handles replicating e.g. a component that is replaced by running the construction script

#jira UE-206989

[CL 31568931 by dominik peacock in 5.4 branch]
2024-02-16 12:03:52 -05:00
dominik peacock
f2da0c9f4a MU Replication: When switching levels, the user's stream and authority should be cleared
#jira UE-206859

[CL 31559515 by dominik peacock in 5.4 branch]
2024-02-16 06:13:24 -05:00
dominik peacock
640d14d247 Fix forgetting to unregister global delegate FCoreUObjectDelegates::OnObjectTransacted
[CL 31557784 by dominik peacock in 5.4 branch]
2024-02-16 04:11:48 -05:00
dominik peacock
184a2e268d Update the local client's stream and tree view when the user modifies the level
- Removing an actor removes it from the local client's stream
- Refresh subobject hierarchy in tree view UI when it is changed (e.g. by adding a component)

#jira UE-199282, UE-206807

[CL 31557032 by dominik peacock in 5.4 branch]
2024-02-16 03:22:57 -05:00
dominik peacock
e65cb2c577 Handle clients joining and leaving while replication is occuring
#jira UE-191840

[CL 31514111 by dominik peacock in 5.4 branch]
2024-02-15 04:45:24 -05:00
thomas sarkanen
2a3140ccde Fix Lyra PIE property access issues caused by CL 31251549
The changes to always process 'most up to date' classes broke property accesses on many of Lyra's accesses. This was because the runtime functions/properties ended up being accessed on empty skeleton classes.
This change restricts the path resolution via 'most up to date' classes to only where it is needed for this use case: renaming/referencing variables and functions.

#jira UE-204823
#rb jaime.cifuentes

[CL 31429174 by thomas sarkanen in 5.4 branch]
2024-02-13 10:58:27 -05:00
dominik peacock
8a6d832232 Refactor columns injection interface for the MU replication tree view.
- Columns now implement the IReplicationTreeColumn interface

[CL 31422759 by dominik peacock in 5.4 branch]
2024-02-13 08:48:42 -05:00
jeanmichel dignard
ceae9130c0 GitSourceControl:
- Only accept git named executables from its settings.

#rb ronald.koppers

[CL 31385141 by jeanmichel dignard in 5.4 branch]
2024-02-12 11:33:58 -05:00
SRombauts
7a2235f9be PR #11295: [Source Control] Update Plastic SCM provider to 1.9.0 (from 1.8.0)
Compared to the PR:
- Fixed non-Unity compiles by adding several header includes.
- Fixed Linux compile error in SPlasticSourceControlBranchesWidget.cpp: FPlasticSourceControlBranchPtr vs FPlasticSourceControlBranchRef usage in ::GetSelectedBranches().

This was originally submitted to //UE5/Main as #31119614 and #31174444 - manually integrated to //UE5/Release-5.4 (convert to edit).

#jira UE-203360
#rb Manuel.Lang
#fyi Manuel.Lang
#review-30764285

[CL 31334923 by SRombauts in 5.4 branch]
2024-02-09 07:26:39 -05:00