533 Commits

Author SHA1 Message Date
Johan Berg
ecf9f9a6f9 Reenable auto-start of UnrealTraceServer on Mac
#rb ionut.matasaru
#jira UE-188183

[CL 27882057 by Johan Berg in 5.3 branch]
2023-09-14 12:14:21 -04:00
Johan Berg
59736cea0c Remove UE_TRACE_ENABLED check
It should be possible to launch UTS without having tracing enabled in the application. This is important to allow that for example UnrealInsights can launch the trace server. With this the log messages has to be emitted on the LogCore channel, as the LogTrace only exists when tracing is enabled.

#jira UE-190571
#rb ionut.matasaru, catalin.dragoui
#lockdown mark.lintott

[CL 27029198 by Johan Berg in 5.3 branch]
2023-08-11 11:14:31 -04:00
zack neyland
e8cc05b141 CSVProfiler: Return -1 when hot reloading to prevent a crash on Mac/Linux.
#jira UE-190804

[CL 26952997 by zack neyland in 5.3 branch]
2023-08-09 08:45:25 -04:00
alex kahn
24e8648d57 [Backout] - CL26925245 - CIS UE Error
#jira FORT-639935
#fyi zack.neyland
Original CL Desc
-----------------------------------------------------------------
CSVProfiler: Return -1 when hot reloading to prevent a crash.

#jira UE-190804
#rb Tyler Staples

[CL 26928410 by alex kahn in 5.3 branch]
2023-08-08 16:06:52 -04:00
zack neyland
2433dcb093 CSVProfiler: Return -1 when hot reloading to prevent a crash.
#jira UE-190804
#rb Tyler Staples

[CL 26925245 by zack neyland in 5.3 branch]
2023-08-08 14:42:48 -04:00
ionut matasaru
874e287ff9 [Insights] MemoryInsights: Fixed missing ProgramSize allocations for Unix platform.
#jira UE-191384
#rb none

[CL 26878549 by ionut matasaru in 5.3 branch]
2023-08-07 04:14:46 -04:00
ionut matasaru
99661dcfdb [Insights] CpuProfilerTrace:
- Enabled cpu scope tracing of object names (blueprints, functions) by default when app is not running as a commandlet (still requires "cpu" trace channel and -statnamedevents to be enabled). Enabling AssetLoadTime trace channel will enable tracing of object names also in commandlets (ex. cooking).
  - Improved performance when tracing "statnamedevents" cpu scopes (by using a new optimized code path that uses an FName stat id together with a TCHAR* descriptive name).

#jira FORT-532106
#rb Matt.Peters

[CL 26814181 by ionut matasaru in 5.3 branch]
2023-08-03 12:16:00 -04:00
logan buchy
42a2eb7eee Revert commented out ensure in StallDetector
* Commented out during backout of previous change.  Should have still been intact.

#rb trivial
#jira UE-179567
#p4v-cherrypick 26558805

[CL 26620593 by logan buchy in 5.3 branch]
2023-07-26 16:41:08 -04:00
logan buchy
7da3c6d8e4 Backout StallDetector pause on SlowTask
* Some unknown cases are causing ensure() to fire - backout until sorted

#jira UE-179567
#rb trivial
#p4v-cherrypick 26548505

[CL 26620584 by logan buchy in 5.3 branch]
2023-07-26 16:40:50 -04:00
catalin dragoiu
fcfa1bf688 Disable launching of UnrealTraceServer from the Editor on Mac.
#rb Ionut.Matasaru
#jira UE-191107

[CL 26607933 by catalin dragoiu in 5.3 branch]
2023-07-26 11:09:32 -04:00
johan berg
889ed1e375 Rework command line parsing for memory trace
On some platforms and configurations all command line arguments are sent as one string rather than one string per argument. We need to parse each argument in the vector for sub arguments to be sure to catch any memory trace channel.

#rb martin.ridgers
#jira UE-188908

[CL 26255618 by johan berg in 5.3 branch]
2023-06-27 09:12:51 -04:00
johan berg
f6bba5bcf0 [Backout] - CL26252786
[FYI] Johan.Berg
Original CL Desc
-----------------------------------------------------------------
Rework command line parsing for memory trace

On some platforms and configurations all command line arguments are sent as one string rather than one string per argument. We need to parse each argument in the vector for sub arguments to be sure to catch any memory trace channel.

#rb martin.ridgers
#jira UE-188908

[CL 26253331 by johan berg in 5.3 branch]
2023-06-27 05:15:11 -04:00
johan berg
d73046e279 Rework command line parsing for memory trace
On some platforms and configurations all command line arguments are sent as one string rather than one string per argument. We need to parse each argument in the vector for sub arguments to be sure to catch any memory trace channel.

#rb martin.ridgers
#jira UE-188908

[CL 26252807 by johan berg in 5.3 branch]
2023-06-27 03:37:12 -04:00
ben woodhouse
e333f64c85 Make csv named events switchable at runtime via cvars csv.NamedEventsExclusive and csv.NamedEventsTiming
#rb gwennael.arbona

[CL 26231958 by ben woodhouse in 5.3 branch]
2023-06-26 09:02:52 -04:00
matt harris
db29614c8d Adding flags to CSV metadata for LTO and PG_Instrumentation so we can show them in PRS
#reviewer joe.bestrotheray

[CL 26229576 by matt harris in 5.3 branch]
2023-06-26 04:12:18 -04:00
johan berg
71c0bbc15b Fix for trace but no logging configurations
#rb none

[CL 26147158 by johan berg in 5.3 branch]
2023-06-21 09:51:11 -04:00
ben woodhouse
fcb84d5988 CSV Profiler: insights support for -csvNamedEvents
Also add a CSV_  prefix to csv named events so they can be distinguished from ordinary named events
#rb robert.millar

[CL 26144662 by ben woodhouse in 5.3 branch]
2023-06-21 07:06:27 -04:00
johan berg
6a25eeb055 Fix for configurations where trace is disabled.
#rb none

[CL 26103661 by johan berg in 5.3 branch]
2023-06-19 16:20:16 -04:00
johan berg
8e12b76d07 Add listener to TraceLog messages
Implement a listener for TraceLog messages and log any events.

#rb martin.ridgers

[CL 26087864 by johan berg in 5.3 branch]
2023-06-19 08:53:04 -04:00
danny couture
02f2d2a3b0 Skip unreal trace server start when running under TSAN to prevent immediate crash on fork
#rnx
#rb Johan.Berg

[CL 25974260 by danny couture in ue5-main branch]
2023-06-14 06:51:43 -04:00
johan berg
5e70369faf Return allocator result in the case of zero sized allocations.
Remove checks for zero sized allocations in Trace's allocation wrappers leaving it to the allocator implementation to decide. Analysis already supports zero sized allocations (as long as they have unique addresses).

#rb ionut.matasaru

[CL 25947983 by johan berg in ue5-main branch]
2023-06-13 07:06:13 -04:00
Johan Berg
baf0112f93 Add LLM tracing for TraceLog memory usage
#rb none

[CL 25947171 by Johan Berg in ue5-main branch]
2023-06-13 05:29:27 -04:00
martin ridgers
6217ad3be3 Trace counter Get() on atomic ints would return reference to local due to implicit cast.
When fixing the Get() I also discovered a couple of counters where the storage template type was incorrectly the same as the value template type. Fixed to use the atomic counter type given in counters header.

#jira
#rb jb
#rnx

[CL 25910796 by martin ridgers in ue5-main branch]
2023-06-10 09:56:10 -04:00
anton dunchev
d4d9104fe9 Unix MemoryTrace implementation
#rb [at]Brandon.Schaefer, [at]Johan.Berg
#tests DS

[CL 25879889 by anton dunchev in ue5-main branch]
2023-06-08 15:46:12 -04:00
logan buchy
f89b73a3ff Add missing include for StallDetector.cpp which fails to compile when not in unity build
#rb none

[CL 25874866 by logan buchy in ue5-main branch]
2023-06-08 12:41:14 -04:00