4332 Commits

Author SHA1 Message Date
calvin zheng
1c23dcf08a Fixing multiple blocking modern xcode issues
#jira UE-198617
#rb Josh.Adams

[CL 29089493 by calvin zheng in 5.3 branch]
2023-10-25 11:11:04 -04:00
benoit deschenes
437418ec87 Editgrating CL 28854677 from //UE5/Main to Release-5.3 (//UE5/Release-5.3)
Updating the NotarizeTask to now use the new "notarytool" as Apple is deprecating "altool --notarize-app".

#jira UE-189475
#rb Ryan.Hummer, zack.neyland

[CL 28868742 by benoit deschenes in 5.3 branch]
2023-10-17 23:44:29 -04:00
Josh Adams
eb3569c187 - Fixed various blocking issues with making Mac/IOS builds that can be uploaded to AppStore in Xcode
* Missing ThinApp.sh
  * Missing some quotes around a variable in GenerateUniversalDSYM.sh
  * Correctly filter out the stub .app's and such when copying the Staged data directory into the .app
  * Disabled the Mac's Sign To Run Locally option by default, as that causes Xcode's Validation/Upload to not have the team name embedded in it, causing a hassle while pushing up to AppStore/TestFlight
  * Fixed the PRODUCT_NAME for BP projects
  * Made CrashReportClient be a sandboxed app that inherits from parent
  * Fix Hybrid apps to check all platforms before in the project generator, so that if a project needs a temp target for IOS (via a plugin)
  * Disabled the LoginFlow module from OnlineFramework plugin - this was causing issues with having CEF and EpicWebHelper embedded into a sandboxed .app, and LoginFlow isn't seemingly actually used by anything
  * Set the no-encryption setting in the template Mac plist to make uploading to TestFlight/AppStore easier
  * Fixed editor to not compile as universal when using -distribution, only the client should be universal
  * Further improvements to stripping out nested .app's in a final .app (remove them from the staged directory helps)
  * Changed how the Mac app name is displayed, since the .app name itself is shown in the Finder,  unlike IOS where the CFBundleName is shown (the archived .app name in the .xcarchive is named by a project setting, falling back to the .uproject name if not set)
  * Disabled the SignExecutables function on Modern because they attempt to sign the wrong .apps, and one is no longer (previously it was uselessly signing .apps, but now it throws an error due to changes for the third item in this list)
  * Legacy Xcode mode is forced with Window's Remote Mac builds, so use the old legacy code when running under windows
  * Added a third party .cpp file to get copied to remote macs
  * Fix Tools -> Open Xcode not working with modern Xcode

#jira UE-197465

[CL 28723100 by Josh Adams in 5.3 branch]
2023-10-12 15:15:43 -04:00
james singer
b4f8cd9513 Linux: Fix IsVanilla check by implementing EnumerateLauncherEngineInstallations for Linux
- Also add -BuildId flag to allow released builds to be registered as "launcher" builds.
- This gets us telemetry and the ability to open projects made on the Mac and Windows builds without being prompted to open a copy

#jira UE-195467
#rb zack.neyland, ryan.hummer


#p4v-cherrypick 27716361

[CL 27884074 by james singer in 5.3 branch]
2023-09-14 12:55:48 -04:00
andrew phillips
1006d14bce Fixing vulnerable NuGet deps.
System.Drawing.Common 4.7.0 => 4.7.2  (https://github.com/advisories/GHSA-rxg9-xrhp-64gj)
MongoDB.Driver 2.11.5 => 2.19.0  (https://github.com/advisories/GHSA-7j9m-j397-g4wx)

#jira UE-194453
#rb francis.hurteau
#lockdown michal.valient

[CL 27715748 by andrew phillips in 5.3 branch]
2023-09-08 12:39:47 -04:00
Josh Adams
b208994a95 - Correctly name BP non-development IOS/Mac .app's
#jira UE-193585
#rb adam.kinge

[CL 27360354 by Josh Adams in 5.3 branch]
2023-08-24 17:46:33 -04:00
Josh Adams
e3d4257d82 - Fixed plist generation for TVOS BP projects
#jira UE-193518
#rb Adam.kinge

[CL 27339478 by Josh Adams in 5.3 branch]
2023-08-24 09:39:23 -04:00
Chris Babcock
c50b5df36e Update install scripts and deploy for future AndroidFileServer changes
Remove unused AFS receiver

#jira UE-192822
#android
#review @Ben.Temple
#rb Ben.Temple

[CL 27162600 by Chris Babcock in 5.3 branch]
2023-08-16 20:41:56 -04:00
Josh Adams
b94b0ba4ad - Removed the quotes around the signing identity for Xcode manual codesigning
- During staging, we now make the UBTGenerated/Info.Template.plist in the project folder instead of Engine folder, for BP projects
- Fixed an AppStoreConnect label in the Xcode project settings that would have confused anyone trying to set it up

#jira UE-193101, UE-193108, UE-193104
#rb Calvin.zheng

[CL 27130143 by Josh Adams in 5.3 branch]
2023-08-15 21:28:55 -04:00
Zousar Shaker
dd6a1add4a Rework zenserver host address detection when using COTF
Make sure .projectstore file is properly staged in all scenarios

#rb zousar.shaker
#jira UE-193017

[CL 27113585 by Zousar Shaker in 5.3 branch]
2023-08-15 14:44:15 -04:00
Jeff Fisher
b8de9fb881 UE-189611 ARImageDetection Fails to Launch on Android - Error: Unable to load plugin 'XRBase'
-The logic in NativeProjects.cs IsHybridContentOnlyProject which decides whether we need to build an executable for a project was always using the buildhost platform (usually win64) to decide which plugins were active.  This caused it to miss enabled code plugins that build for the actual target platform but not the host platform and potentially not do an executible build when one is required.
-Now we pass the TargetPlatforms for the current build into ConditionalMakeTempTargetForHybridProject so that we can test against them.  If any project in this list needs code built we will make a temp target.
#jira UE-189611 UE-192833
#review-27092992
#rb Josh.Adams

[CL 27101635 by Jeff Fisher in 5.3 branch]
2023-08-15 10:02:42 -04:00
Ryan Hummer
7c92d5068c Fixing compile error
#rnx
#jira none
#rb none
#fyi josh.adams

[CL 27054521 by Ryan Hummer in 5.3 branch]
2023-08-11 20:22:17 -04:00
Josh Adams
9330c1e0b9 - Fixed running Mac games from Staged dir (like when doing Launch On to Mac)
#jira UE-192724
#rb zack.neyland

[CL 27053366 by Josh Adams in 5.3 branch]
2023-08-11 19:51:05 -04:00
Josh Adams
ff9a403bf9 - Tag everything inside .app's after a CompileTask from BuildGraph. This is because with modern Xcode, Xcode will copy files into the .app that UBT doesn't know about
#jira UE-192751

[CL 27053182 by Josh Adams in 5.3 branch]
2023-08-11 19:46:33 -04:00
Josh Adams
a2a6efb984 - Fixed some issues with codesigning BP projects with modern Xcode, when BaseEngine.ini has no signing info, and the signing info is in the projects settings
- The in-process project generation was not able to get the .uproject location
  - The making and using of the stub xcode projects were using UnrealGame target/scheme, not MyProjectGame (which Xcode makes since it can handle content-only uprojects)
  - UnrealGame.app, when just compiling, has no uproject, so it now use the dummy codesigning I added for stub generation, so no projects settings are needed

#jira UE-192593

[CL 27034888 by Josh Adams in 5.3 branch]
2023-08-11 13:32:51 -04:00
Jerome Delattre
5dbb3401db Use CachedConfiguration so GetConfiguration does not get looped over
#rb Gary.Yuan
#rnx
#jira UE-192744

[CL 27016528 by Jerome Delattre in 5.3 branch]
2023-08-10 18:51:38 -04:00
Sebastien Lussier
adfad10378 WorldPartition - WorldPartitionBuilder.Automation.cs: Test if SubmitTags is null before accessing
#jira none
#rb trivial

[CL 26909878 by Sebastien Lussier in 5.3 branch]
2023-08-07 22:36:25 -04:00
Andrew Grant
4cbc7591df Fixes regression where BenchmarkBuild script would not reliably measure build performance.
The fix is to restore the <= 5.1 behavior of UBT where the MaxParallelActions argument specifies the maximum number of actions to execute in parallel, not a cap on UBTs heuristic-based selection.

This change also modifies BenchmarkBuild so it will default to the available processor count if no -cores argument is specified. This ensures the behavior of repeated runs will be deterministic as UBT may select different values if the system free memory changes

#jira UE-192236
#rb swarm
#review-26877381 @Joe.Kirchoff
#tests Ran UBT / BenchmarkBuild with arguments that forces the number of actions higher than the locally available core count

[CL 26888230 by Andrew Grant in 5.3 branch]
2023-08-07 12:47:53 -04:00
brendan lienau
4da6b4f9d8 [Gauntlet] Adds UnrealRoleConfiguration feature
IUnrealRoleConfigurations are a type that let you modularize functionality for any role in a gauntlet test. It's primarily designed to generate command line arguments, but can do anything that's desired to the target Role.
IUnrealRoleConfigurations supply two interface functions

-ApplyConfigToRole - Core implementation of the configuration, this is the "doing"
-VerifyRoleConfig - Verification implementation. This gives you a chance to verify the "Apply" step had the desired result.

#rb Clayton.Langford

[CL 26854876 by brendan lienau in 5.3 branch]
2023-08-04 14:38:15 -04:00
brendan lienau
2ae0dbdfd5 [Automation] Improve csv build version validation checks to catch all build label suffixes.
#rb Clayton.Langford

[CL 26845712 by brendan lienau in 5.3 branch]
2023-08-04 10:34:25 -04:00
zousar shaker
5b83ab17f4 Fix bug where the "silent" mode for project cooking could still emit an exception if the return code from the commandlet was outside the positive signed integer range.
#rb graeme.thornton

[CL 26824766 by zousar shaker in 5.3 branch]
2023-08-03 16:06:07 -04:00
Josh Adams
b04afe3d86 - Added an interface to StagedBuildSource to let a platform determine if a found Staged binary is valid
- This fixes Gauntlet finding a partial .app in Mac staged directories that modern makes that is not a full .app
#jira UE-189368,UE-189819
#rb zack.neyland

[CL 26823186 by Josh Adams in 5.3 branch]
2023-08-03 15:31:03 -04:00
heather howell
e9699120bf [Gauntlet] BugFix: Fix the ability for people to jump directly to the gauntlet log on the network.
#rb [at]adolf.stary
[REVIEW] [at]FN-Tech-Automation

[CL 26818882 by heather howell in 5.3 branch]
2023-08-03 14:07:40 -04:00
Jerome Delattre
8ab02b833f Avoid reverting to simple report if no json report was found
#rnx
#jira none
#rb Josh.Engebretson

[CL 26817961 by Jerome Delattre in 5.3 branch]
2023-08-03 13:47:41 -04:00
Jerome Delattre
4075745812 Gauntlet - Move MaxEventsDisplayPerTest from test config to test node class
#rb trivial
#jira none
#rnx

[CL 26780371 by Jerome Delattre in 5.3 branch]
2023-08-02 14:10:08 -04:00