54 Commits

Author SHA1 Message Date
kirill zorin
de8db5ff76 Converting ARO-facing raw pointers to TObjectPtr ahead of raw pointer ARO API deprecation.
#rb zousar.shaker
#rb markus.breyer
#rb robert.manuszewski

#preflight 646391406b1406b54ab15460

[CL 25489627 by kirill zorin in ue5-main branch]
2023-05-16 10:52:49 -04:00
maxime mercier
73a6f9aeef Made the subobject editor respect overrides Interface API
#preflight 6446e67027014596f38f1038

[CL 25180602 by maxime mercier in ue5-main branch]
2023-04-25 10:53:00 -04:00
jlnordin
76ba018fed PR #9991: Fix Blueprint debugger crash when attempting to observe a TimerHandle variable (Contributed by jlnordin)
#review-23644523 patrick.boutot
#jira UE-173788
#preflight 63bebd47bf54fa7b36e5cc1c

[CL 23645193 by jlnordin in ue5-main branch]
2023-01-11 09:57:42 -05:00
geordiemhall
2f702d7cb3 PR #9595: Fix selected component being lost when compiling a Blueprint (Contributed by geordiemhall)
#jira UE-165026
#preflight 6387c9d3b21cdd3a26dc2082
#rb daren.cheng

[CL 23340078 by geordiemhall in ue5-main branch]
2022-11-30 16:37:42 -05:00
henrik karlsson
b5b86c796c This change is a strategical submit for a coming change that removes lots of includes in headers that are included by many files. This change contains adding of includes in files that previously got those includes transitively from other inclkudes
#preflight 6355d4940313c24974b2107b
#rb none

[CL 22783162 by henrik karlsson in ue5-main branch]
2022-10-26 12:57:32 -04:00
patrick enfedaque
e64f17803d SActorDetails: Fix SubObjectEditor not being cleared properly
#rb ben.hoffman
#preflight 6346e694663dafe4162f6b77
#rnx

[CL 22505214 by patrick enfedaque in ue5-main branch]
2022-10-13 11:21:34 -04:00
bryan sefcik
cb0456c6d4 Cleaned up build.cs files by removing any include paths that were already being added by UBT. This was done to help identify how include paths are being added and to help with future refactoring.
#jira
#preflight 631a5c04967ffc68fbf0dd8f

[CL 21911226 by bryan sefcik in ue5-main branch]
2022-09-08 21:44:02 -04:00
phillip kavan
a5b516dcc9 Add missing imports after dragging one or more non-imported namespaced type assets into the components tree in the Blueprint editor.
Change summary:
- Removed SSubobjectBlueprintEditor::FOnNewSubobjectAdded typedef and OnNewSubobjectAdded delegate members. Deprecation was not needed as these were added after the 5.0 release.
- Restored SSubobjectBlueprintEditor::AddNewSubobject() back to its original implementation (prior to adding the now-defunct OnNewSubobjectAdded event).
- Added USubobjectDataSubsystem::OnNewSubobjectAdded() to allow potential listeners to register for and receive successful subobject "add" event notifications.
- Modified USubobjectDataSubsystem::AddNewSubobject() to broadcast new subobject data to any registered listener(s) after a successful add.
- Added FBlueprintEditor::DeferredNamespaceImports to stack auto-imports for events that can be triggered more than once within a single frame.
- Modified FBlueprintEditor::OnComponentAddedToBlueprint() to handle subobject add events that target editor Blueprint objects. Also fixed to query the subobject class for its default import set instead of the subobject itself.
- Modified the FBlueprintEditor dtor to unregister the OnBlueprintUnloaded() event handler as I noticed this was not previously being done (benign as the shared ptr was skipped for being invalid, but this now removes us from the broadcast chain).
- Fixed up minor formatting inconsistencies in some legacy FBlueprintEditor analytics-related code paths.

#jira UE-148495
#rb Ben.Hoffman
#preflight 63078bf937470da4bf38fcf2

[CL 21688272 by phillip kavan in ue5-main branch]
2022-08-29 16:50:08 -04:00
bryan sefcik
8cc129f2b6 IWYU Pass 1 - Engine/Source/Editor/...
#jira
#preflight 6306736ac85b7fef22be7751

[CL 21558583 by bryan sefcik in ue5-main branch]
2022-08-24 22:45:13 -04:00
scott nelson
b009b1c743 Remove Go/Edit To Blueprint menu options when the blueprint is not accessible
#rb Dave.Belanger
#preflight 630010d00f7187ef8120a99c

[CL 21500775 by scott nelson in ue5-main branch]
2022-08-22 21:51:43 -04:00
bryan sefcik
98b51354ed Ran IWYU on Public headers under Engine/Source/Editor/...
Headers are updated to contain any missing #includes needed to compile and #includes are sorted.  Nothing is removed.

#ushell-cherrypick of 21065253 by bryan.sefcik
#jira
#preflight 62d5b3e91062f2e63014598e

#ROBOMERGE-AUTHOR: bryan.sefcik
#ROBOMERGE-SOURCE: CL 21152630 via CL 21156388 via CL 21157044
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21181817 by bryan sefcik in ue5-main branch]
2022-07-20 11:56:29 -04:00
dave belanger
4b30163a23 Hide C++ related menus and hyperlinks from the subobject editor when C++ is not allowed
#rb Phillip.Kavan
#preflight skip

#ROBOMERGE-AUTHOR: dave.belanger
#ROBOMERGE-SOURCE: CL 21113526 via CL 21113534 via CL 21113687 via CL 21113722 via CL 21113747
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21142385 by dave belanger in ue5-main branch]
2022-07-17 22:41:08 -04:00
nate strohmyer
ae5cf68a2f Fixing empty Actors having a root component with an Edit in Blueprint hyperlink that doesn't work
#jira UE-145339
#rb ben.hoffman
#preflight 629921851941378d7c78e4f4

[CL 20490724 by nate strohmyer in ue5-main branch]
2022-06-03 14:53:17 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
ben hoffman
e629c84afb Only create a new default subobject when destroying a component if the owner's class is not native. Native owner classes do not have to have a DefaultSceneRoot when you drag in the C++ class directly from the content browser into the level.
#jira UE-130740
#rb marc.audy
#preflight 623a33f4b3653cf6afe52385

[CL 19482791 by ben hoffman in ue5-main branch]
2022-03-23 14:41:32 -04:00
Matt Peters
c1b46b1fed FAssetData: Callsites need to handle AssetData.GetClass() returning null. Added IsInstanceOf(UClass*) for the common operation GetClass() && GetClass->IsChildOf(BaseClass).
#jira UE-146521
#rb Zousar.Shaker
#rnx
#preflight 623874b789625f06129e466b

[CL 19450936 by Matt Peters in ue5-main branch]
2022-03-21 09:00:36 -04:00
Phillip Kavan
b5863c2b95 Some minor refactoring to assist with handling removal/reassignment of Blueprint namespaces.
Change summary:
- Added a code path for removing a namespace from the BP editor context.
- Consolidated namespace helper instances into a single BP editor context.
- Extended the FBlueprintEditor::ImportNamespace() API to accept additional options and a post-import callback.
- Refactored the auto-import code path to fix issues with reassignment to/from an imported namespace.
- Decoupled SSubobjectBlueprintEditor from a namespace-aware callback in favor of a generalized "add" callback.
- Linked the CVar for inheriting parent BP imports to a transient BP setting (experimental/not user-facing).
- Consolidated code to gather global/default imports into a utility API so that namespace sets are consistent.
- Modified "Imports" view to include a "default imports" section (similar to inherited interfaces) - these are not removable.
- Moved "Inherited Interfaces" section to be sorted above the "Implemented Interfaces" section for consistency.
- Fixed SBlueprintNamespaceEntry to query for the current text rather than only setting it at construction time.

#jira UE-133288
#rb Ben.Hoffman
#preflight 621ff4b337049be51738bafe

[CL 19236263 by Phillip Kavan in ue5-main branch]
2022-03-02 20:48:04 -05:00
michael noland
ab53a1b72e Split BP project settings out into a separate header
#jira UE-81056
#preflight 61dfb80df61ef33adf330a27

#ROBOMERGE-AUTHOR: michael.noland
#ROBOMERGE-SOURCE: CL 18594094 in //UE5/Release-5.0/... via CL 18594096 via CL 18594101
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Test -> Main) (v899-18417669)

[CL 18596566 by michael noland in ue5-main branch]
2022-01-13 10:03:20 -05:00
ben hoffman
c72ff9d6d4 Fix an ensure that is thrown when searching a component tree that has a brand new component added to it. This is an outdated ensure after the refactor from SCSEditor -> Subobject Editor. Remove an unnecessary include file
#jira UE-138798
#rb trivial
#rnx
#preflight 61df40bd6a076ddb5304ebdc

#ROBOMERGE-AUTHOR: ben.hoffman
#ROBOMERGE-SOURCE: CL 18589405 in //UE5/Release-5.0/... via CL 18589411 via CL 18589432
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Test -> Main) (v899-18417669)

[CL 18589450 by ben hoffman in ue5-main branch]
2022-01-12 16:10:18 -05:00
aditya ravichandran
02e38e60b8 Update Component Tree icons and styling
#jira UE-112704
#rb lauren.barnes
#preflight 61b8cbfb2e65a1df04682cdd

#ROBOMERGE-AUTHOR: aditya.ravichandran
#ROBOMERGE-SOURCE: CL 18455533 in //UE5/Release-5.0/... via CL 18455581
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v898-18417669)

[CL 18455607 by aditya ravichandran in ue5-release-engine-test branch]
2021-12-14 12:08:13 -05:00
phillip kavan
4266aae5f3 Add non-imported class type filtering to the "Add Component" type selection UI in the Blueprint editor.
Additionally auto-import any namespace associated with the selected component class type when a new component is added.

Change summary:
- Modified the component type registry to internally create/store unloaded BP data to assist with unloaded BP component type filtering.
- Added FEditorClassUtils::GetImplementedInterfaceClassPathsFromAsset() to move BP interface asset tag processing into a shared utility API.
- Modified SComponentClassCombo to work with IClassViewFilter-style filtering and added a filter options menu (currently only visible when namespace filtering features are enabled via CVar).
- A few minor modifications/additions to SSubobjectEditor/SSubobjectBlueprintEditor to assist with interfacing with the owning FBlueprintEditor context for filtering, updating etc.

#jira UE-133294
#rb Ben.Hoffman
#preflight 61b7c0601a4451f7ba1d0c46

#ROBOMERGE-AUTHOR: phillip.kavan
#ROBOMERGE-SOURCE: CL 18449755 in //UE5/Release-5.0/... via CL 18449768
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v897-18405271)

[CL 18449772 by phillip kavan in ue5-release-engine-test branch]
2021-12-13 17:39:02 -05:00
jamie dale
1f97a96a67 Fixed the component tree potentially showing stale items
SSubobjectInstanceEditor::OnObjectReplaced was never bound, so we now just handle this directly in SActorDetails instead

#rb Ben.Hoffman
#preflight skip
#rnx

#ROBOMERGE-AUTHOR: jamie.dale
#ROBOMERGE-SOURCE: CL 18346293 via CL 18347479 via CL 18347485 via CL 18347489 via CL 18348493 via CL 18348565
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18348601 by jamie dale in ue5-release-engine-test branch]
2021-12-01 21:15:38 -05:00
aditya ravichandran
d479887ea2 Details Panel Name Area: Fix button padding/spacing issues
#jira UE-135047
#rb lauren.barnes
#preflight 619e9af488439fccfea98818

#ROBOMERGE-AUTHOR: aditya.ravichandran
#ROBOMERGE-SOURCE: CL 18287944 in //UE5/Release-5.0/... via CL 18287963
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18288003 by aditya ravichandran in ue5-release-engine-test branch]
2021-11-24 15:45:32 -05:00
ben hoffman
3fb0faa6e7 Hide filtered components when typing in the Subobject Editor tree view instead of just selecting them.
#FORT-416664
#rb trivial
#rnx

#ROBOMERGE-AUTHOR: ben.hoffman
#ROBOMERGE-SOURCE: CL 18245855 in //UE5/Release-5.0/... via CL 18245900
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18245960 by ben hoffman in ue5-release-engine-test branch]
2021-11-18 18:06:17 -05:00
aurel cordonnier
a6e741e007 Merge from Release-Engine-Staging @ 17915896 to Release-Engine-Test
This represents UE4/Main @17911760, Release-5.0 @17915875 and Dev-PerfTest @17914035

[CL 17918595 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-25 20:05:28 -04:00