1286 Commits

Author SHA1 Message Date
aditya ravichandran
82a61b1f4e Disable the bulk edit section in the Outliner if the property matrix can't be invoked
#rb rex.hill

[CL 26146641 by aditya ravichandran in 5.3 branch]
2023-06-21 09:42:31 -04:00
han chu
e2f901b594 The problem:
When the level is locked, CanSelectElement evaluates to true, causing Unreal Engine to crash in the following two scenarios:
1. After locking the level, the user clicks on an ISM
2. After locking the level, the user drags the remaining gizmo on an ISM

The cause:
1. FSMInstanceElementLevelEditorSelectionCustomization::CanSelectElement evaluates to true because GEdSelectionLock seems always be false
2. DeselectAllActors in SetLocked does not recursively deselect the ISM components

The fix:
1. Determine whether the owner level is lockedin FSMInstanceElementLevelEditorSelectionCustomization::CanSelectElement
2. Use the typed element selection APIs to clear the current level's selection

#jira UE-181821
#rb

[CL 26000790 by han chu in ue5-main branch]
2023-06-14 20:05:51 -04:00
logan buchy
87012153c4 Remove TypedElementViewportInteractionGizmoManipulation from TypedElement ViewportInteraction
* The same functionality is provided by the GizmoManipulationStarted and GizmoManipulationStopped.
* This simplifies the interface and removes the bespoke parameter added to branch between when manipulation starts and when it is ongoing to avoid expensive rendering invalidations
* There are some clients of TypedElementViewportInteractionGizmoManipulation::ApplyDeltaToActor, this CL does not address usage of this function.  Doing so will require further adoption of TypedElements among those systems

#jira UE-187188
#rb Brooke.Hubert

[CL 25964466 by logan buchy in ue5-main branch]
2023-06-13 17:28:30 -04:00
marc audy
4b121aea27 Explicitly register FGlobalEditorCommonCommands to avoid implicit initialization order issues
#horde 317282

[CL 25908436 by marc audy in ue5-main branch]
2023-06-09 19:33:43 -04:00
henrik karlsson
f027bfa856 [Core]
* Fixed compile errors when compiling .h files in isolation

#rb none

[CL 25865668 by henrik karlsson in ue5-main branch]
2023-06-08 02:30:27 -04:00
richard malo
6b9e568792 Fixed WorldOutliner force refreshing for nothing during PIE.
- Avoid broadcasting OnActorEditorContextClientChanged for game worlds
- Prevent UActorEditorContextSubsystem from broacasting ActorEditorContextSubsystemChanged when running Game/PIE.
#rb patrick.enfedaque
#preflight 647a2be0f40c6565433ebde8

[CL 25789367 by richard malo in ue5-main branch]
2023-06-05 07:08:49 -04:00
bryan sefcik
ecd9fa8a99 Removed dependencies that aren't needed by the modules that declare them. This is to help fix bad circular dependencies in the engine.
#preflight 647b5f919c5bac5c6f8be490
#jira

[CL 25782459 by bryan sefcik in ue5-main branch]
2023-06-03 15:25:01 -04:00
brooke hubert
475a3855fe Unshelved from pending changelist '25239902':
PR #10401: Level editor place actors menu to respect Class DisplayName overrides
#contrib 10401
#Jira UE-184698

#rb brooke.hubert
#preflight 6478af138417d79259fb76ce

[CL 25727113 by brooke hubert in ue5-main branch]
2023-06-01 11:01:45 -04:00
aditya ravichandran
f0f4b7fda3 Fix a crash in the bulk edit components submenu on Mac
#jira UE-187340
#rb trivial

[CL 25726527 by aditya ravichandran in ue5-main branch]
2023-06-01 10:36:41 -04:00
patrick enfedaque
b6a5a155c8 ActorMenu: Avoid loading non UClass assets
#rb jeanfrancois.dube
#prefight 647749180848b7126dbc1156
#rnx

[CL 25725216 by patrick enfedaque in ue5-main branch]
2023-06-01 09:54:16 -04:00
ben hoffman
90ed12e1e5 This is two changelists, re-submitting of 25473883 (which was backed out with 25495316) and also a cherry pick of 25507685 to fix an ensure the original CL caused.
#preflight 647773ab0d55081f5494ab67
#jira none

--------------------------------------------------
Add ability to add a widget inside the global window overlay

#rb Patrick.Boutot

#ushell-cherrypick of 25473883 by kristof.morva1

----------------------------------------------
Fix ensure when hiding mouse capture label after exiting PIE

#rb Vincent.Gauthier

#ushell-cherrypick of 25507685 by kristof.morva1

[CL 25709904 by ben hoffman in ue5-main branch]
2023-05-31 14:56:43 -04:00
Patrick Enfedaque
baddbd59d0 [Backout] - CL25689444
#fyi han.chu
Original CL Desc
-----------------------------------------------------------------
Fix crash when interacting with a script actor containing an ISM when the level is locked

#jira UE-181821
#rb Zach.Rammell
#preflight 647666294a277ca8f023dcc4

[CL 25699655 by Patrick Enfedaque in ue5-main branch]
2023-05-31 07:47:01 -04:00
han chu
1728c4847c Fix crash when interacting with a script actor containing an ISM when the level is locked
#jira UE-181821
#rb Zach.Rammell
#preflight 647666294a277ca8f023dcc4

[CL 25689444 by han chu in ue5-main branch]
2023-05-30 17:19:03 -04:00
patrick enfedaque
924ce2e2c5 ActorEditorContext:
- Allow switching Current level from context in WP World
- Unify display of Current Level when editing Level Instance (WP and non-WP)
- Level Instance Mode will lock/unlock selection and render postprocess based on current level being the Level Instance level or not.

#rb richard.malo, jeanfrancois.dube
#preflight 647501192e05bcc330bd4059
#rnx

[CL 25674513 by patrick enfedaque in ue5-main branch]
2023-05-30 06:44:15 -04:00
aditya ravichandran
d822cb508a Add an option to the Outliner to bulk edit components in the Property Matrix
#rb jeanmichel.dignard
#preflight 646fc7ef560bb18621ab144b

[CL 25647201 by aditya ravichandran in ue5-main branch]
2023-05-26 12:51:22 -04:00
aditya ravichandran
ec139ed473 Fix a bug causing "Edit Asset" to stop working from the Level Editor context menu
#jira UE-186236

[CL 25536577 by aditya ravichandran in ue5-main branch]
2023-05-18 19:45:01 -04:00
aditya ravichandran
07f12688e4 Property Matrix Reskin
#rb JeanMichel.Dignard
#preflight 646413f5fa4cf41651def1a5

[CL 25507370 by aditya ravichandran in ue5-main branch]
2023-05-17 10:49:51 -04:00
Vincent Gauthier
bf96119127 Tentative fix for ensure when exiting pie and fix to error message.
#jira UE-185992
#preflight 6463ee8311205d3573683fcf

[CL 25498085 by Vincent Gauthier in ue5-main branch]
2023-05-16 17:18:57 -04:00
kirill zorin
de8db5ff76 Converting ARO-facing raw pointers to TObjectPtr ahead of raw pointer ARO API deprecation.
#rb zousar.shaker
#rb markus.breyer
#rb robert.manuszewski

#preflight 646391406b1406b54ab15460

[CL 25489627 by kirill zorin in ue5-main branch]
2023-05-16 10:52:49 -04:00
bryan sefcik
da92084a12 Optimized out more private modules includes and dependencies.
#preflight 64627c382965f6ea8ea83bd6

[CL 25479683 by bryan sefcik in ue5-main branch]
2023-05-15 16:26:12 -04:00
sebastien hillaire
256b3e8ba4 First simple LocalHeightFog volume component support.
Lots of missing bits but that is a good first step for iterations.

#rb none
#preflight https://horde.devtools.epicgames.com/job/645e51146b4bdec267ea31cf

[CL 25472344 by sebastien hillaire in ue5-main branch]
2023-05-15 09:23:13 -04:00
bryan sefcik
d205101cc8 Removed unnecessary private include modules.
#preflight 645da640cf788a25581110bb

[CL 25451545 by bryan sefcik in ue5-main branch]
2023-05-12 12:13:52 -04:00
bryan sefcik
91c57d395e Removed redundant module includes.
#preflight 645d4bf3aa3c584c0b5b3a67

[CL 25435653 by bryan sefcik in ue5-main branch]
2023-05-11 16:48:21 -04:00
christopher fiala
0b3e8305c8 Fixes screenshot crashes on HMD without altering ReadPixels in order to avoid crashes for non-screenshot uses. All screenshot pathways now explicitly indicate screenshot size, and use GetRenderTargetTextureSizeXY() instead of GetSizeXY() in order to accommodate the stereo case in which RTTSize varies from viewport size, which can cause a crash if we request a screenshot larger than the actual texture.
#jira UE-179279
#rb jeff.fisher
#preflight 64556388d02ea5289f054516

[CL 25359403 by christopher fiala in ue5-main branch]
2023-05-05 16:32:17 -04:00
aditya ravichandran
31830290ab Asset Editors: Deprecate OnClose and RequestClose in favor of similar functions that take in a close reason
Fix a crash in some asset editors when you force deleted an asset with pending changes and hit "cancel" on the save dialog

#jira UE-107248
#preflight 64517c880e33f2d51d6e3adb

[CL 25321878 by aditya ravichandran in ue5-main branch]
2023-05-03 14:45:26 -04:00