46 Commits

Author SHA1 Message Date
julien stjean
b28ad33a57 Added a new search directory type: ProjectOverrides.
It's a in between the default for a project and the one user add to is local configs.

Added a way to register a search directory before editor config subsystem is initialized. This usefull if you need to add a search directory before a editor config could be read.

#rb Benoit.Deschenes

[CL 26181271 by julien stjean in 5.3 branch]
2023-06-22 09:59:51 -04:00
rex hill
8e2942a557 EditorConfig - Adjust error messages to include line number to assist with fixing .json file errors.
#preflight 6423711fa86ae7cbcce004b7
#rnx

[CL 24831964 by rex hill in ue5-main branch]
2023-03-29 02:31:05 -04:00
sebastian nordgren
d9b2639fd2 EditorConfigSubsystem no longer creates new threads every frame.
This was caused by a logic error, whereby a new thread was spawned 3 seconds after the save was enqueued and then every frame thereafter regardless of whether or not one had been created. We now use EAsyncExecution::TaskGraph as well.

[REVIEW] [at]danny.couture, [at]devin.doucette
#rnx

[CL 22888566 by sebastian nordgren in ue5-main branch]
2022-11-01 15:07:25 -04:00
sebastian nordgren
4d7ea59775 Fixed wrong include: ScopeExit.h -> ScopeLock.h
#rb trivial
#rnx
#preflight 635fac7fe27df24a3f927668

[CL 22858311 by sebastian nordgren in ue5-main branch]
2022-10-31 07:21:37 -04:00
sebastian nordgren
0ccecd8e22 EditorConfigSubsystem no longer crashes when running under -nothreading.
Async() could complete before the result of the call was assigned to the FPendingSave::WasSuccess variable, which would cause OnSaveCompleted() to remove the entry and then immediately after assign to the newly deleted memory. We now remove all completed saves in Tick().

#jira UE-1644780
[REVIEW] [at]paul.chipchase
#preflight 635a9b1f7515720a5f6b3dfd

[CL 22812050 by sebastian nordgren in ue5-main branch]
2022-10-27 12:40:12 -04:00
joe pribele
89ce1f5ccd [EditorConfig] fix for failing tests
#rb sebastian.nordgren
#preflight 63177827f448dc6e5836f907

[CL 21823061 by joe pribele in ue5-main branch]
2022-09-06 13:44:54 -04:00
bryan sefcik
0837230669 Ran IWYU again on half of the Engine/Source/Editor/... source files.
#jira

[CL 21716414 by bryan sefcik in ue5-main branch]
2022-08-30 23:03:03 -04:00
bryan sefcik
8cc129f2b6 IWYU Pass 1 - Engine/Source/Editor/...
#jira
#preflight 6306736ac85b7fef22be7751

[CL 21558583 by bryan sefcik in ue5-main branch]
2022-08-24 22:45:13 -04:00
sebastian nordgren
2fe816a617 Fixed broken EditorConfig unit test due to missing enum name.
#rb trivial
#rnx
#preflight 62fe35c1200ff87e07b55cba

[CL 21440676 by sebastian nordgren in ue5-main branch]
2022-08-18 09:04:34 -04:00
rex hill
16a7bb17c5 Add support for UE_SAVED_DIR_OVERRIDE to EditorConfigSubsystem
#preflight skip

#ROBOMERGE-AUTHOR: rex.hill
#ROBOMERGE-SOURCE: CL 21341680 via CL 21344202 via CL 21344415 via CL 21344601
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21346102 by rex hill in ue5-main branch]
2022-08-11 17:45:14 -04:00
rex hill
74670d4282 Fix shipping configuration not saving TMaps with string keys to json editorconfig
#preflight skip
#rb aditya.ravichandran

#ROBOMERGE-AUTHOR: rex.hill
#ROBOMERGE-SOURCE: CL 21341173 via CL 21344186 via CL 21344397 via CL 21344589
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21346095 by rex hill in ue5-main branch]
2022-08-11 17:45:07 -04:00
rex hill
826c1a3783 Update FEditorConfig json parsing to support importing string for structs.
Allows FSoftObjectPath property and many other properties to use simple strings.

#rb dave.belanger, jason.stasik
#preflight 62d5b131af68cd745b24e996

#ROBOMERGE-AUTHOR: rex.hill
#ROBOMERGE-SOURCE: CL 21151751 via CL 21153344 via CL 21156614 via CL 21157127
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21181899 by rex hill in ue5-main branch]
2022-07-20 11:58:55 -04:00
bryan sefcik
98b51354ed Ran IWYU on Public headers under Engine/Source/Editor/...
Headers are updated to contain any missing #includes needed to compile and #includes are sorted.  Nothing is removed.

#ushell-cherrypick of 21065253 by bryan.sefcik
#jira
#preflight 62d5b3e91062f2e63014598e

#ROBOMERGE-AUTHOR: bryan.sefcik
#ROBOMERGE-SOURCE: CL 21152630 via CL 21156388 via CL 21157044
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21181817 by bryan sefcik in ue5-main branch]
2022-07-20 11:56:29 -04:00
aditya ravichandran
002f7c803a EditorConfig:
Fix issue with the ResultValue not being set when Enum Properties were serialized
#fyi sebastian.nordgren
#rb lauren.barnes
#preflight 62bf04d0ed35ee71a76c88f5

[CL 20914634 by aditya ravichandran in ue5-main branch]
2022-07-01 10:59:18 -04:00
sebastian nordgren
14ddaf399b Enum properties in EditorConfigs now serialize correctly. Previously we were casting directly to int64*, which in the case of smaller enum types (eg. uint8), would cause more memory to be read and the values to be incorrect.
EditorConfig will now always keep $type keys.

Fixed some unit test failures that hadn't been caught previously, caused by eg. ANY_PACKAGE change.

#review @aditya.ravichandran
#preflight 62bef519a3568e30669ce1b6

[CL 20913918 by sebastian nordgren in ue5-main branch]
2022-07-01 10:05:15 -04:00
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
sebastian nordgren
73e62b9ef3 JsonConfig shared pointers are now passed by const&.
Added tests for EditorConfig.

#review-20127432 @aditya.ravichandran, @lauren.barnes
#preflight 628764ef2c34da686ac74123
#rnx

[CL 20292425 by sebastian nordgren in ue5-main branch]
2022-05-20 06:20:33 -04:00
sebastian nordgren
8eafe4f70e Editor configs now correctly diff against the CDO when serializing.
Previously, I had assumed that FProperty::InitializeValue() would initialize a simple member (eg. a float) to the correct value, but this appears not to be the case, rather values are zero-initialized and the CDO stores the correct default values. In the case of structs, InitializeStruct() does in fact initialize correctly.

However, this means that we can't use GetMutableDefault() to get an instance of the UObject, since then we're changing what we're diffing against and serialize no values. Changed the usages of this pattern to use singletons instead.

#jira UE-141150
#review-19900014 @lauren.barnes, @aditya.ravichandran
#preflight 6267fa44a021c91a50f26a65

[CL 19919719 by sebastian nordgren in ue5-main branch]
2022-04-26 10:20:56 -04:00
jason stasik
e4651fb422 Fix non-unity error
#rb none
#preflight skip

#ROBOMERGE-AUTHOR: jason.stasik
#ROBOMERGE-SOURCE: CL 19798556 via CL 19798564 via CL 19798565
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v939-19570697)

[CL 19809766 by jason stasik in ue5-main branch]
2022-04-19 11:44:04 -04:00
jason stasik
a650434255 Log error when JSON deserializer fails to parse an EditorConfig file
#rb rex.hill,eric.knapik
#preflight 6259d6ca201cdc3ec501a4b3

#ROBOMERGE-AUTHOR: jason.stasik
#ROBOMERGE-SOURCE: CL 19794091 via CL 19798053 via CL 19798283 via CL 19798394
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v939-19570697)

[CL 19809723 by jason stasik in ue5-main branch]
2022-04-19 11:41:31 -04:00
marc audy
cff01aa9fa Added support for native FProperty setters and getters.
Setters and getters are native functions called by FProperties when setting property values with *_InContainer functions.
Setters and getter function names can be manually specified with Setter = Func and Getter = Func keywords inside of UPROEPRTY macro but they will also be automatically parsed if the name is not explicitly specified if the setter or getter function name matches SetPropertyName and GetPropertyName pattern.
The latter behavior can be disabled in UHT's DefaultEngine.ini by setting AutomaticSettersAndGetters=False.
ImportText and ExportTextItem functions have been deprecated and should be replaced with *_InContainer or *_Direct variants.

#rb Steve.Robb
#preflight 6210a377a83e0bcefd03d9e1

#ROBOMERGE-OWNER: marc.audy
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 19070318 via CL 19098059 via CL 19104650 via CL 19104661 via CL 19110012
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19147839 by marc audy in ue5-main branch]
2022-02-25 10:39:39 -05:00
jason stasik
57ecabf8c0 Expose AddSearchDirectory and LoadFromFile for EditorConfigs
#rb sebatian.nordgren

#ROBOMERGE-OWNER: jason.stasik
#ROBOMERGE-AUTHOR: jason.stasik
#ROBOMERGE-SOURCE: CL 18795736 via CL 18797126 via CL 18803326 via CL 18803348 via CL 18803356 via CL 18804424 via CL 18821688
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18822076 by jason stasik in ue5-main branch]
2022-02-02 02:16:18 -05:00
sebastian nordgren
c7a3bb7e05 Details Favorites are now stored between sessions again.
The EPropertyFilter property was introduced, but FEditorMetadataOverrides was not updated to make use of it.

#jira UE-139483
#rb paul.chipchase
#preflight 61e7fe4d614a721b0c3dfbef

#ROBOMERGE-AUTHOR: sebastian.nordgren
#ROBOMERGE-SOURCE: CL 18656991 in //UE5/Release-5.0/... via CL 18656997 via CL 18656999
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v900-18638592)

[CL 18657002 by sebastian nordgren in ue5-main branch]
2022-01-19 07:42:49 -05:00
sebastian nordgren
79cb0d89b4 EditorConfig map handling fixed so that holes in the map won't cause an ensure - you must check IsValidIndex before accessing any value.
#review-18237997 @lauren.barnes
#preflight 619b8f2ecb49ea94932131ed

[CL 18258550 by sebastian nordgren in ue5-main branch]
2021-11-22 10:10:08 -05:00
Marc Audy
0c3be2b6ad Merge Release-Engine-Staging to Test @ CL# 18240298
[CL 18241953 by Marc Audy in ue5-release-engine-test branch]
2021-11-18 14:37:34 -05:00