25 Commits

Author SHA1 Message Date
julien stjean
8787c97df0 Additional improvement for the filter compilations of the asset views.
Added a system to cache some data that can be used when recompiling the filters for the incremental data updates.
For now this only used by for the asset data source internal path compilation of the asset views.

In my test on a bad scenario this yielded a reduction 98% of the time it take to call UContentBrowserAssetDataSource::CreateAssetFilter when the cache is used.

Before the optimization the reference call took  26.3 ms
After the optimization the reference call took 0.3725 ms

Also this change fix an issue with my last change interacting badly with the alias data source by not using its customization of the package paths hierarchy.

#preflight 645a92f42d27fa25b3069003
#jira UE-183276
#rb Rex.Hill

[CL 25396753 by julien stjean in ue5-main branch]
2023-05-09 18:06:59 -04:00
jamie dale
b95e92ef3d Content Browser UX improvements for cooked content
* Plugins that only contain cooked content (and have no C++ modules) no longer show their "Content" suffix.
* Folders that only contain private cooked content are no longer visible in the asset or path views.

#preflight 642f2e3cb306e98c632f0195
#rb Jason.Stasik, Aditya.RaviChandran

[CL 24994922 by jamie dale in ue5-main branch]
2023-04-11 14:22:33 -04:00
paul chipchase
6e57dd4c26 The content browser can now respond to packages changing on disk.
#rb Julien.StJean, Matt.Peters
#jira UE-177133
#preflight 64072b19ba12ba64167e20e6

- In the last year we have started to make changes to the package format to allow data to be stored in the same file, but not actually inside of the package itself (See FPackageTrailer) and we might consider moving some other data blobs there in the future. This change has meant that there are code paths that can change things with the package file, that don't actually call save package, such as the process that virtualizes assets and can leave incorrect, stale data in the content browser tool tip.
-- This means when a user virtualizes an asset, the tooltip might indicate that it has not been virtualized and the size of the file on disk has not been changed until they browser to a different folder and browse back to refresh. This has caused people to believe that the virtualization operation has failed.
- This change hooks up UContentBrowserAssetDataSource to trigger a EContentBrowserItemUpdateType::Modified event when ever the package file changes on disk.
- During package save this could trigger multiple EContentBrowserItemUpdateType::Modified events for the same package (one from saving and one from the file being modified) but it looks like duplicate events already occur (if the packages are checked out as part of the save, this will introduce another EContentBrowserItemUpdateType::Modified event). There is a TODO in the code that suggests we might want to spend time removing duplicates events before broadcasting the delegate but when profiling I found that the overhead is quite low. In one test, saving 20 packages cost 4ms for the events triggered by the save and an additional 4ms for the events triggered by the file changing on disk. With the margins being so low it still doesn't look like a problem that is worth spending time on, however I did add a TRACE_CPUPROFILER_EVENT_SCOPE to the broadcasting of the delegate (UContentBrowserDataSubsystem::ItemDataUpdatedDelegate) so if it does become a problem in the future it will be easier to track down.

[CL 24556355 by paul chipchase in ue5-main branch]
2023-03-08 04:32:05 -05:00
daren cheng
f0294a60e8 Prevent content browser ticks during inital content load
#preflight 63f3c49d91018822cc5310d5
#rb Dave.Belanger, Jamie.Dale

[CL 24327456 by daren cheng in ue5-main branch]
2023-02-20 17:05:53 -05:00
scott nelson
92da116445 Add ability to filter CB folders for Editability + Fix AliasDataType usage of Public/Private assets
#rb Rex.Hill
#preflight 63b5d081ab0e99a2bed56c2d

[CL 23581927 by scott nelson in ue5-main branch]
2023-01-04 17:07:54 -05:00
robert millar
5516f8d0d4 FNames containing asset paths are deprecated. FSoftObjectPath or FTopLevelAssetPath should be used instead.
Fixups for editor support classes for content browser code.

#jira UE-161932
#rb jason.stasik,jamie.dale
#preflight 631bd2a0d31788ea3ac03570

[CL 21935588 by robert millar in ue5-main branch]
2022-09-10 00:02:37 -04:00
bryan sefcik
0837230669 Ran IWYU again on half of the Engine/Source/Editor/... source files.
#jira

[CL 21716414 by bryan sefcik in ue5-main branch]
2022-08-30 23:03:03 -04:00
jason stasik
ce3cf77a50 Allow actors to change which asset they Browse to
Allow browsing to aliases if source asset is not visible
Allow aliases in collections
#rb dave.belanger,jamie.dale
#preflight 62d0b1ad8e4b379590da3397

#ROBOMERGE-AUTHOR: jason.stasik
#ROBOMERGE-SOURCE: CL 21115320 via CL 21115363 via CL 21115394 via CL 21115412 via CL 21115431
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21142427 by jason stasik in ue5-main branch]
2022-07-17 22:42:48 -04:00
dave belanger
b1c525af2b Move implementation of FContentBrowserVirtualPathTree::GetMountPointFromPath to FPathViews
#rb Rex.Hill
#preflight 62accbcdc0449d3dccd56ac1

#ROBOMERGE-AUTHOR: dave.belanger
#ROBOMERGE-SOURCE: CL 20709056 via CL 20709527 via CL 20709609 via CL 20709671
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v970-20704180)

[CL 20732589 by dave belanger in ue5-main branch]
2022-06-19 23:39:22 -04:00
rex hill
be91a9445b Expose FContentBrowserItemPath to scripting
#rb jamie.dale
#preflight 624f8a9a70773560e4f88654

#ROBOMERGE-AUTHOR: rex.hill
#ROBOMERGE-SOURCE: CL 19706140 via CL 19707819 via CL 19707829 via CL 19707846
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v938-19570697)

[CL 19708766 by rex hill in ue5-main branch]
2022-04-11 13:33:14 -04:00
rex hill
5f1f162d71 [ContentBrowser] Add debug cvar commands for testing path conversion
#preflight skip
#rnx

#ROBOMERGE-AUTHOR: rex.hill
#ROBOMERGE-SOURCE: CL 19050950 via CL 19052025 via CL 19052037 via CL 19052053 via CL 19058939
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v918-19018356)

[CL 19066071 by rex hill in ue5-main branch]
2022-02-21 01:13:03 -05:00
daren cheng
6379293808 Performance improvements to widget library.
Add callback for source data generation to asset views.
Add UObject enumeration to content browser API (By Rex Hill).
Intentionally reserve thumbnail pool sizes instead of flat 1024 reservation.

#jira UE-129795
#rb Rex.Hill
#preflight 615e0c51c5e9590001f4a22a
#preflight 615e4400f13022000126efda
#robomerge[BOT4] 5.0
#robomerge[BOT1] Main

[CL 17744889 by daren cheng in ue5-main branch]
2021-10-06 21:33:14 -04:00
Andriy Tylychko
2a295eb685 deprecated FTicker and family and replaced by thread-safe FTSTicker
#jira UE-120090
#rb francis.hurteau

[CL 17176325 by Andriy Tylychko in ue5-main branch]
2021-08-16 11:05:18 -04:00
rex hill
fb47b7854c Reduce content browser hitches during PIE by delaying modification updates until after PIE finishes.
#rb jamie.dale
#preflight 60c2b5d11ab0310001d12a7c


#ROBOMERGE-SOURCE: CL 16640821
#ROBOMERGE-BOT: (v831-16623017)

[CL 16640843 by rex hill in ue5-main branch]
2021-06-11 09:55:32 -04:00
jamie dale
b0dc233686 Ensure that the array of FContentBrowserItemDataUpdate can't be invalidated mid-update
Speculative fix for an issue of bogus data being passed into the callback, likely from the array being appended to mid-update

#jira UE-117392
#rb Francis.Hurteau
#lockdown Simon.Tourangeau

#ROBOMERGE-SOURCE: CL 16594535 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v828-16531559)

[CL 16594560 by jamie dale in ue5-main branch]
2021-06-08 17:47:10 -04:00
aurel cordonnier
43fa62fcd8 Merge from Release-Engine-Test @ 16487383 to UE5/Main
This represents UE4/Main @ 16445039 and Dev-PerfTest @ 16444526

[CL 16488106 by aurel cordonnier in ue5-main branch]
2021-05-27 13:40:37 -04:00
Jamie Dale
3649fdd9e3 Suppress Tick from modal dialogs during rename finalization in the Content Browser
This can cause a reentrancy issue where the item currently being renamed is removed via an update while we're still processing it

#rb Francis.Hurteau

[CL 16412079 by Jamie Dale in ue5-main branch]
2021-05-20 18:56:49 -04:00
aurel cordonnier
8eebe8841f Merge UE5/RET @ 16305968 to UE5/Main
This represents UE4/Main @ 16261013 and Dev-PerfTest @ 16259937

[CL 16306996 by aurel cordonnier in ue5-main branch]
2021-05-12 18:10:03 -04:00
aurel cordonnier
50944fd712 Merge UE5/RES @ 16162155 to UE5/Main
This represents UE4/Main @ 16130047 and Dev-PerfTest @ 16126156

[CL 16163576 by aurel cordonnier in ue5-main branch]
2021-04-29 19:32:06 -04:00
jamie dale
691d65008e Avoid ticking UContentBrowserDataSubsystem when it may be unsafe to do so
#jira UE-113940

#ROBOMERGE-SOURCE: CL 16066215 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v789-15992632)

[CL 16068396 by jamie dale in ue5-main branch]
2021-04-20 20:34:37 -04:00
Marc Audy
9753392e2b Merge UE5/RES CL# 15462083 to UE5/Main
This represents UE4/Main @ 15414221

[CL 15463811 by Marc Audy in ue5-main branch]
2021-02-18 18:13:28 -04:00
Marc Audy
cac1fe0019 Merge UE5/Release-Engine-Staging @ CL# 15299266 to UE5/Main
This represents UE4/Main @ CL# 15277572

[CL 15299962 by Marc Audy in ue5-main branch]
2021-02-03 14:57:28 -04:00
Marc Audy
7379fa99c5 Merging //UE5/Release-Engine-Staging to Main (//UE5/Main) @ 14229157
[CL 14233282 by Marc Audy in ue5-main branch]
2020-09-01 14:07:48 -04:00
Marc Audy
a7c9001a94 Merging //UE5/Release-Engine-Staging to Main (//UE5/Main) @ 14075166
#rb
#rnx

[CL 14075271 by Marc Audy in ue5-main branch]
2020-08-11 01:36:57 -04:00
Marc Audy
11f5b21210 Merging //UE5/Release-Engine-Staging @ 13752110 to Main (//UE5/Main)
#rnx

[CL 13753156 by Marc Audy in ue5-main branch]
2020-06-23 18:40:00 -04:00