30166 Commits

Author SHA1 Message Date
Matt Peters
bf83fbdc47 Cooker: GeneratedPackages: During garbage collection, for generator and generated packages, fix the condition for whether we need to keep all CachedObjectsInOuter referenced to be HasTakenOverCachedCookedPlatformData. The previous condition of GetSaveState() > CallObjectsToMove was incorrect and should have been >=. HasTakenOverCachedCookedPlatformData is the same thing as comparing with State >= CallObjectsToMove, but is more authoritative if we ever change the state where we do the take over.
The incorrect comparison caused us not to keep the objects referenced, which allowed them to be GC'd, which breaks the CookPackageSplitter contract and also triggered an error in FGeneratorPackage::ResetSaveState when we detected that deletion and demoted the package out of save.

Cooker: GeneratedPackages: do not demote generator or generated packages when private objects are garbage collected. Demote  (and give an error) only  when public objects are garbage collected. Normal packages that are not a generator and are not owned by a generator keep the same behavior of demoting if any object, even a private one, is garbage collected.

Cooker: When a generated package is demoted due to deleted objects, add feedback with the name of the object that was deleted.

#jira UE-197955
#rbx

[CL 28918477 by Matt Peters in 5.3 branch]
2023-10-19 10:29:36 -04:00
Max Chen
8e0b03c518 Sequencer: Fix static analysis for 28883250
Sequencer: Fix property owner/container

PropertyContainer is what we look to for the setter function
PropertyOwner is the owner struct, which is where we look for permissions

The original fix was to find the property owner struct to determine DoesPropertyPassFilter. This broke finding setter functions for some properties.

Modified version of 27916475 to make this hotfix compatible.

#jira UE-198396
#rb andrew.rodham, ludovic.chabant
#lockdown aurel.cordonnier

[CL 28903124 by Max Chen in 5.3 branch]
2023-10-18 20:52:15 -04:00
Max Chen
8968a25cd7 Sequencer: Fix property owner/container
PropertyContainer is what we look to for the setter function
PropertyOwner is the owner struct, which is where we look for permissions

The original fix was to find the property owner struct to determine DoesPropertyPassFilter. This broke finding setter functions for some properties.

Modified version of 27916475 to make this hotfix compatible.

#jira UE-198396
#rb andrew.rodham, ludovic.chabant
#lockdown aurel.cordonnier

[CL 28883250 by Max Chen in 5.3 branch]
2023-10-18 13:42:36 -04:00
Zousar Shaker
906eeefe30 MPCook: Fix CookWorker commandlines to have the correct project dir when cooking projects in external directories (outside of UnrealEngine root) .
#jira UE-196471
[RN] Bugfix, Foundation
#rb Zousar.Shaker



#[robomerge][bot5] -FNMain

#ushell-cherrypick of 28331505 by matt.peters

[CL 28878783 by Zousar Shaker in 5.3 branch]
2023-10-18 11:37:39 -04:00
calvin zheng
e984cb141a Fix for NavigateToFunctionSource crash/error, use xcode built in atos instead of UnrealAtoS as it can't handle universal build.
#jira UE-195221
#rb Josh.Adams, Zack.Neyland

[CL 28758868 by calvin zheng in 5.3 branch]
2023-10-13 13:13:54 -04:00
tiago costa
1f15f74a8c Don't replace the default local exposure settings specified in templates when creating a new project.
- for example, virtual production projects want to have local exposure disabled by default.

#rb
#jira UE-195152

#ushell-cherrypick of 27786211 by tiago.costa

[CL 27964101 by tiago costa in 5.3 branch]
2023-09-18 13:08:18 -04:00
Vincent Gauthier
9d13d655c5 MVVM: Fix bad copy paste when building the setter for FieldNotify.
#jira UE-194774
#rb yohann.dossantos


#p4v-cherrypick 27670569

[CL 27923271 by Vincent Gauthier in 5.3 branch]
2023-09-15 13:47:45 -04:00
tim doerries
118a044620 Fix for jittering SparseVolumeTexture frames when importing a sequence with different translations in the transforms of all the input files/frames. A popular third party tool for baking volumetrics unfortunately always creates such sequences. The UnrealEngine .vdb importer assumes that all frames of a sequence share the same transform and effectively ignores that transform. This fix detects changes in the translation and bakes the translation into the created SVT, eliminating the jittering.
#rb Sebastian.Hillaire
#jira UE-194916
#rnx

[CL 27881724 by tim doerries in 5.3 branch]
2023-09-14 12:08:00 -04:00
zahra nikbakht
b0e8ab5450 UMG library tiles do not show names.
5.3 hotfix
#jira UE-193377

[CL 27764900 by zahra nikbakht in 5.3 branch]
2023-09-11 14:51:46 -04:00
tim doerries
f055d39e56 Fix for SparseVolumeTexture .vdb importer creating broken assets when importing .vdb sequences with this pattern: FILENAME.NUMBER.vdb. When importing a sequence, the importer creates an animated SVT and uses the filename with the number stripped at the end as asset/package name. With files using this pattern, we end up with a dot at the end of the asset/package name, which violates UE naming rules and makes the asset completely unusable without any proper warnings or error messages. The fix now also strips the dot (and other invalid chars).
#rb ?
#jira UE-194914
#rnx

[CL 27754452 by tim doerries in 5.3 branch]
2023-09-11 11:05:40 -04:00
Mike Zyracki
9b18a796ef Sequencer: Control Rig FBX import.
Transform channels are being negated twice (ty, ry/rz).
Script doesn't seem to pick-up the correct values for other controls (they match if looking at the curves but the script is warning about mismatch's and empty curves)
Fix from AnatoleM but out of office hours.
#rb max.chen
#jira UE-193225
#lockdown julien.marchand

[CL 27160909 by Mike Zyracki in 5.3 branch]
2023-08-16 19:44:48 -04:00
Max Chen
63cfcdcaaf Sequencer: Clear selected marked frames after marked frames are deleted.
This fixes a crash moving keys after deleting marked frames because the selected marked frames is stale.

Note, when keys are deleted, we similarly clear the key selection.

#jira UE-193116
#rb andrew.rodham
#lockdown julien.marchand

[CL 27140577 by Max Chen in 5.3 branch]
2023-08-16 11:07:55 -04:00
Jurre deBaare
e7eb0a5e28 Curve Editor - Undoing/Redo keys does not work.
#fix ensure per-curve drawing parameters are always reset - issue occured when deleting the last key on a curve, leaving the cached drawing params in place until getting user-focus or making another change to the curve
#jira UE-188647
#rb Thomas.Sarkanen, Mike.Zyracki

[CL 27139322 by Jurre deBaare in 5.3 branch]
2023-08-16 10:22:55 -04:00
rex hill
2876f40cbe [UEFN] Hide Play-In-Editor 3D Resolution section in UEFN which does not have PIE
#rnx

[CL 27111569 by rex hill in 5.3 branch]
2023-08-15 14:08:49 -04:00
Thomas Sarkanen
590e7c8108 Fixed being unable to select external BPs in linked anim layer nodes
Switched custom parsing to use FEditorClassUtils::GetImplementedInterfaceClassPathsFromAsset

#jira UE-192562

[CL 27070113 by Thomas Sarkanen in 5.3 branch]
2023-08-14 10:40:40 -04:00
sara schvartzman
1a80149cce RigVM: Fix crash when clicking on pin of default node in details panel
#jira UE-189034
#rb helge.mathee
#rnx

[CL 27068554 by sara schvartzman in 5.3 branch]
2023-08-14 09:59:20 -04:00
Jurre deBaare
b51a170c3a The user cannot paste curves created in an Animation Sequence into another Animation Sequence
#fix reinstate adding of any missing curve(s) that the user is trying to paste
#jira UE-192483

[CL 27029478 by Jurre deBaare in 5.3 branch]
2023-08-11 11:21:47 -04:00
adam kinge
a53e767cf7 Only iOS and tvOS currently support device connection type specific icons
#jira UE-190844
#rb jack.porter
#rnx
#lockdown jack.porter

[CL 27022277 by adam kinge in 5.3 branch]
2023-08-11 00:43:13 -04:00
Phillip Kavan
6708e92ae4 Back out explicitly-transactional Blueprint CDOs (25372870) to mitigate possible undo/redo regressions. Will revisit for a future release.
#rnx
#jira UE-184781, UE-192529
#rb Jodon.Karlik
#lockdown julien.marchand

[CL 27013244 by Phillip Kavan in 5.3 branch]
2023-08-10 17:38:37 -04:00
zach brockway
8f3a20f4ca Virtual Scouting: Fix for gizmos not loading correctly.
Don't load the UViewportInteractionAssetContainer in the APivotTransformGizmo constructor, and don't early out of the constructor if the CDO flag is set. Instead, if no other material has been specified, let UGizmoHandleGroup::UpdateHandleColor load the default materials from the asset container just before it creates the MIDs.

#jira UE-191486
#rb ben.zeigler
#rnx

[CL 26970691 by zach brockway in 5.3 branch]
2023-08-09 16:21:44 -04:00
UnrealBot
e332249d7b Branch snapshot for CL 26969186
[CL 26969186 in 5.3 branch]
2023-08-09 20:15:04 +00:00
jordan hoffmann
523a358777 [Backout] - CL26921657
Accidentally merged change to 5.3... Backing out and resubmitting without the robomerge flag

Original CL Desc
-----------------------------------------------------------------
[BugFix] Made it so users can no longer reparent blueprints to classes managed by a different blueprint type (IE Actor to EditorUtilityActor)
#jira UE-159086
#rb dan.oconnor

[CL 26922220 by jordan hoffmann in 5.3 branch]
2023-08-08 13:24:32 -04:00
jordan hoffmann
f09665a5da [BugFix] Made it so users can no longer reparent blueprints to classes managed by a different blueprint type (IE Actor to EditorUtilityActor)
#jira UE-159086
#rb dan.oconnor

[CL 26921795 by jordan hoffmann in 5.3 branch]
2023-08-08 13:15:28 -04:00
Mike Zyracki
84dc01e38d Sequencer: NLA revert previous submit that made things a little worse when moving root bone
#jira UE-176279
#rb benoit.gadreau

[CL 26908886 by Mike Zyracki in 5.3 branch]
2023-08-07 21:28:01 -04:00
Mike Zyracki
5b9fe2f9d5 Sequencer: Curve Editor: Normalized/Stack view take into account time range when figuring out min, max values for positioning. We added a new CurveModel function to handle this instead of breaking the other one since that's used in other places (Rich curve, plugins), and didn't want to regress any expected behaviors.
#jira UE-184423
#rb max.chen

[CL 26906648 by Mike Zyracki in 5.3 branch]
2023-08-07 20:06:01 -04:00