90 Commits

Author SHA1 Message Date
adam kinge
b31af19cc7 Fix display of multiple iOS/tvOS devices in the QuickLaunch menu within the editor. The iOS icon will now show the type of device connection (wifi/usb)
- On a mouse hover over the mobile device (includes Android), show additional info about the OS version and model of the device
  - fixes top level device not showing the last selected device
  - don't reshow the selected device in the sub-menu

#jira UE-176230
#rb josh.adams
#preflight 646d3a424422ba05f4c29427

[CL 25601745 by adam kinge in ue5-main branch]
2023-05-24 09:39:39 -04:00
David Harvey
59d71816c0 Add more LLM tags to platform-related editor things.
#jira UE-154803
#rnx
#rb trivial
#preflight 64120228924f0cb7222ffcee

[CL 24658216 by David Harvey in ue5-main branch]
2023-03-15 13:56:57 -04:00
joe pribele
4c3a3b420d added LLM_SCOPE_BYTAG to tag allocations
https://p4-swarm.epicgames.net/reviews/24503827
#rb zousar.shaker
#preflight 64024704d249add4a27cbc46

[CL 24504362 by joe pribele in ue5-main branch]
2023-03-03 14:23:28 -05:00
Zak Middleton
73efd27f6c #ue5 - Truncation fixes for modules:
StatsViewer
StatusBar
TargetDeviceServices
TargetPlatform
Teleporter
TimeManagement
TranslationEditor
ViewportInteraction
Virtualization
WindowsPlatformFeatures
WindowsTargetPlatform

#jira UE-160837, UE-160843
#rb Andrew.Davidson, Dave.Jones2
#preflight 636024751c75ff834a526197

[CL 22873932 by Zak Middleton in ue5-main branch]
2022-10-31 18:33:27 -04:00
bryan sefcik
a3dddc6630 Pass 1 on Developer include fixes:
Removed redundant private include paths from build.cs files.
Fixed include paths to be relative to the private or public folders.
Hid or removed includes that reached into other private module folders.
Updated PublicInclude paths when necessary.

#jira
#preflight 631e281694758d0bf2ea1399

[CL 21960082 by bryan sefcik in ue5-main branch]
2022-09-11 18:32:18 -04:00
marc audy
6553e6cd0a Remove as much C++ deprecation as possible up to 4.17 (along with a few scattered removals from beyond)
#preflight 61eefc77ba69a4fdb220bf23

#ROBOMERGE-AUTHOR: marc.audy
#ROBOMERGE-SOURCE: CL 18712765 in //UE5/Release-5.0/... via CL 18712784 via CL 18713147
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18713191 by marc audy in ue5-main branch]
2022-01-24 15:07:48 -05:00
matt johnson
feed139a14 Messaging: replace more instances of message construction using operator new with FMessageEndpoint::MakeMessage()
#jira UE-118666
#rb mihnea.balta, francis.hurteau
#preflight 61b8f463da103dd4d3851872

#ROBOMERGE-AUTHOR: matt.johnson
#ROBOMERGE-SOURCE: CL 18468887 in //UE5/Release-5.0/... via CL 18468901
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18468908 by matt johnson in ue5-release-engine-test branch]
2021-12-15 13:28:11 -05:00
andriy tylychko
6bf3101dcd deprecated FTicker and family and replaced by thread-safe FTSTicker
#jira UE-120090
#rb francis.hurteau


#ROBOMERGE-SOURCE: CL 17176325 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v855-17104924)

[CL 17176374 by andriy tylychko in ue5-release-engine-test branch]
2021-08-16 11:09:22 -04:00
mihnea balta
cfe83027c3 Fixing lots of places which created USTRUCTs with operator new and passed them to FMessageEndpoint::Publish or Send, wich crashes when ASAN is used.
The messaging system destroys these objects with FMemory::Free, which has different alignment logic than operator new when ASAN is used, resulting in a crash.

#jira none
#rnx
#rb Jerome.Delattre, Matt.Peters

#ROBOMERGE-SOURCE: CL 17116813 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v855-17104924)

[CL 17116851 by mihnea balta in ue5-release-engine-test branch]
2021-08-10 10:58:07 -04:00
Marc Audy
3cfedaade8 Fix PVS warning V502 when comparing against NAME_None in a trinary
[CL 16137741 by Marc Audy in ue5-main branch]
2021-04-28 01:58:36 -04:00
Marc Audy
9753392e2b Merge UE5/RES CL# 15462083 to UE5/Main
This represents UE4/Main @ 15414221

[CL 15463811 by Marc Audy in ue5-main branch]
2021-02-18 18:13:28 -04:00
dmitriy dyomin
345ebd6335 Fixed: Editor crash on canceling Launch On Device
#rb jack.porter

#ROBOMERGE-SOURCE: CL 15431818 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v771-15082668)

[CL 15431842 by dmitriy dyomin in ue5-main branch]
2021-02-17 04:04:19 -04:00
Josh Adams
e23157fc94 - Removing unused ITargetDevice functionality (like Deploy and Run in C++). These are are supported in some platforms but not all, and are only used by undocumented UFE "commands". UAT is expected to handle all of this.
#rb brandon.schaefer

[CL 15178023 by Josh Adams in ue5-main branch]
2021-01-25 11:21:44 -04:00
Josh Adams
d0daf0380c - Moved valid device software (flash) versions into UEBuildPlatformSDK subclasses to put alongside the SDK version, and made them min-max
- General fixes for some platforms
- DDPI now remembers the SDK version information from Turnkey
- Updated Turnkey Launch menu to have SDK information, including device software versions,
- Moved the initial turnkey query earlier before AutoSDKs are setup so envvars are not blown away for the child process
- Added concept of "Prepare For Debugging", but not enabled on any platforms yet (what it means is per platform, and is somewhere between cooking and packaging)
- VerifySdk Turnkey command now puts its output into a (x=y, z=w) format for easier parsing in C++
- NullCopyProvider now copies large remote files, and remote directories, locally before using

[CL 14377385 by Josh Adams in ue5-main branch]
2020-09-23 11:47:14 -04:00
Josh Adams
a40269a987 - Removed temp logging added to aid QA
[CL 14182122 by Josh Adams in ue5-main branch]
2020-08-25 14:53:44 -04:00
Josh Adams
d8ee16dd3c - Disabled the editor device sharing between machines/copies of the editor, but only broadcasting the Ping message to the current Process (instead of Network). Doesn't remove any code complexity, but is a safe solution
#jira 97514

[CL 14181868 by Josh Adams in ue5-main branch]
2020-08-25 14:43:09 -04:00
Josh Adams
217bd35a2d - Added a log to help QA track down an oddity I can't repro
[CL 14180248 by Josh Adams in ue5-main branch]
2020-08-25 11:38:15 -04:00
Josh Adams
5f27a8dbcb [Upgrade Notes Critical! Licensee build scripts and DeviceProfiles may need updating]
- Formalizing all TargetPlatforms to have a Client version, rename WindowsNoEditor to Windows, and removing DDPI specification of TargetPlatforms, and generate them programmatically
- Updated names DeviceProfiles and Build scripts, as above
- Some PlatformInfo class cleanup
- Added a TNonDesktopTargetPlatformBase class to make most TargetPlatforms simpler
- Added "No Compiled Support" to the Turnkey LaunchOn menu when the TargetPlatforms aren't compiled in (to show that even if you install an SDK, you will need to compile before you can LaunchOn)\
- Starting the transition away from PlatformInfo::FPlatformInfo to FDDPI

[CL 13966487 by Josh Adams in ue5-main branch]
2020-07-29 16:19:10 -04:00
Josh Adams
94f4be4de1 - Renamed PlatformInfo::FPlatformInfo to PlatformInfo::FTargetPlatformInfo
- Renamed FDataDrivenPlatformRegistry::FPlatformInfo to FDataDrivenPlatformInfo
- Moved some fields from PlatformInfo::FTargetPlatformInfo to FDataDrivenPlatformInfo, and cleaned them up in the process
- Fixed the DataDrivePlatformInfo.ini files to match the previous items
- Removed FVanillaPlatformEntry, and now just using FTargetPlatformInfo to manage flavors under a vanilla PlatformInfo (see PlatformInfo::GetVanillaPlatformInfoArray())
- Cleaned up TPerPlatformValue, as it was often misused (took a group and platform name, but we can get the group from the platform name) [AnimationSharingManager.cpp, *Engine.cpp, Runtime\Engine\*, ]
- Fixed FBlueprintNativeCodeGenPaths::GetDefaultCodeGenPaths() to use IniPlatformName instead of some hacky code [BlueprintNativeCodeGenManifest.cpp]
- Fixed various Turnkey bugs that recent testing exposed
- Enabled AUTOSDKS_ENABLED in both Mac and Linux on the Editor side (not that there are much set up to use it)
- Using Turnkey to get the SDK status instead of ValidatePlatforms (gives more detailed information - may want to go back to ValidatePlatforms so only UBT is needed, but change it to give more info)
- Moved OnDeviceDiscovered and Lost delegates from each platform's TargetPlatform class to a static in ITargetPlatform - there was no need for per-platform implementations
- Started working on allowing for SDK to be installed with editor running and not need to restart editor - Work in Progress! It is not usable yet.
#fyi jack.porter
#rb pete.sauerbrei

[CL 13816905 by Josh Adams in ue5-main branch]
2020-07-01 17:07:12 -04:00
ryan durand
471d972e62 Updating copyright for Engine Developer.
#rnx
#rb none


#ROBOMERGE-SOURCE: CL 10869240 via CL 10869516 via CL 10869902
#ROBOMERGE-BOT: (v613-10869866)

[CL 10870584 by ryan durand in Main branch]
2019-12-26 15:32:37 -05:00
johan torp
f057c79303 Fixed intermittent launch failures when cook-on-the-fly is used.
A timeout deletes target devices if they fail to respond in 7.5s. The timeout logic was flawed and triggered when the device manager wasn't pumped for 7.5s - even though ping responses came in very quickly. The new logic clears the timeout on a ping response.

Note that there is still a >10s long editor freeze during which the network filesystem seems to clear its cache. There is LogNetworkPlatformFile log spam like below during the freeze:
  Deleting cached file: ... Module.RawInput.gen.cpp
  Deleting cached file: ... Module.RawInput.gen.cpp.obj
  Deleting cached file: ... Module.RawInput.gen.cpp.old
  Deleting cached file: ... Module.RawInput.gen.cpp.txt
  Deleting cached file: ... UE4Editor-RawInput.exp
  Deleting cached file: ... UE4Editor-RawInput.lib

Bonus drive-by changes: Fixed a  memory leak and aligned up some allocations.

#jira UE-78331
#rb graeme.thornton

(ushell-p4-cherrypick of 7840548 by Johan.Torp)

#ROBOMERGE-OWNER: ben.marsh
#ROBOMERGE-AUTHOR: johan.torp
#ROBOMERGE-SOURCE: CL 7949261 in //UE4/Release-4.23/... via CL 7949262
#ROBOMERGE-BOT: BUILD (Main -> Dev-Build) (v398-8029740)

[CL 8035166 by johan torp in Dev-Build branch]
2019-08-14 12:10:22 -04:00
johan torp
34437af335 Fixed intermittent launch failures when cook-on-the-fly is used.
A timeout deletes target devices if they fail to respond in 7.5s. The timeout logic was flawed and triggered when the device manager wasn't pumped for 7.5s - even though ping responses came in very quickly. The new logic clears the timeout on a ping response.

Note that there is still a >10s long editor freeze during which the network filesystem seems to clear its cache. There is LogNetworkPlatformFile log spam like below during the freeze:
  Deleting cached file: ... Module.RawInput.gen.cpp
  Deleting cached file: ... Module.RawInput.gen.cpp.obj
  Deleting cached file: ... Module.RawInput.gen.cpp.old
  Deleting cached file: ... Module.RawInput.gen.cpp.txt
  Deleting cached file: ... UE4Editor-RawInput.exp
  Deleting cached file: ... UE4Editor-RawInput.lib

Bonus drive-by changes: Fixed a  memory leak and aligned up some allocations.

#jira UE-78331
#rb graeme.thornton

(ushell-p4-cherrypick of 7840548 by Johan.Torp)

#ROBOMERGE-SOURCE: CL 7949261 in //UE4/Release-4.23/...
#ROBOMERGE-BOT: RELEASE (Release-4.23 -> Main) (v391-7919777)

[CL 7949262 by johan torp in Main branch]
2019-08-12 03:54:48 -04:00
Ben Marsh
beb4519169 Rename EBuildConfigurations::Type to EBuildConfiguration.
#rb none

[CL 7937697 by Ben Marsh in Dev-Build branch]
2019-08-09 17:35:36 -04:00
Ben Marsh
78e5da3eab Rename EBuildTargets::Type to EBuildTargetType, and add missing entries for server and program targets. Also replace usages of PlatformInfo::EPlatformType with EBuildTargetType.
#rb none
#rnx

[CL 7937405 by Ben Marsh in Dev-Build branch]
2019-08-09 16:46:25 -04:00
Ben Marsh
c09b6d7f18 Merge from //UE4/Main.
#rb none
#rnx

[CL 4701155 by Ben Marsh in Dev-Build branch]
2019-01-10 11:10:29 -05:00