117 Commits

Author SHA1 Message Date
elliot colp
e091296e22 [RemoteControl] Fix HTTP query parameters not being parsed when sent via WebSocket http route
#jira UE-188884
#rb Jeremie.Roy

[CL 26060555 by elliot colp in 5.3 branch]
2023-06-16 13:41:33 -04:00
kirill zorin
b6ee3a6c64 Fix UE_LOG callsites that have format string-related UB
#rb trivial
#preflight 647107780a6634dbb236a0a6

[CL 25651638 by kirill zorin in ue5-main branch]
2023-05-26 15:52:39 -04:00
jeremie roy
f64749b722 Fix remote control crash on exit
#jira UE-185974
#preflight 6463c3fefa4cf41651bc844c
#rb simon.therriault

[CL 25494647 by jeremie roy in ue5-main branch]
2023-05-16 15:17:50 -04:00
jeremie roy
b1d8fc9d47 Fix race condition in web interface requests that would result in an empty preset.
Fix forwarded local IP being treated as remote IP for security purposes

#jira UE-182875
#rb amir.keren
#preflight 644042eb8d0bcde49c5eafd6

[CL 25139576 by jeremie roy in ue5-main branch]
2023-04-20 19:04:26 -04:00
Elliot Colp
58359ce279 [RemoteControl] Fix property reset over HTTP. Fix property reset for properties with no CDO data
#jira UE-183193
#rb Jeremie.Roy
#preflight 644022f573470c177c8f027b

[CL 25110739 by Elliot Colp in ue5-main branch]
2023-04-19 13:31:44 -04:00
jeremie roy
3818b77d66 Fix server restart when changing RC settings
Fix Websocket keeping port open after changing it (Our version of lws has a bug that keeps listening on port even if lws_context_destroy is called

#rb simon.therriault
#jira UE-181152
#lockdown alejandro.arango
#preflight 6425a3be9621ba9cb4443c66

[CL 24858283 by jeremie roy in ue5-main branch]
2023-03-30 14:59:08 -04:00
paul vincent
0cd9996cca Remote Control - Crash when changing levels
#jira UE-181176
#rb Alejandro.Arango Simon.Therriault Jeremie.Roy
#preflight 6421a6f9c42c7fd1cb83c2aa

[CL 24810980 by paul vincent in ue5-main branch]
2023-03-27 18:26:29 -04:00
jeremie roy
6f50b74191 Remote Control expose websocket server bind address
#jira UE-180918
#preflight 641c5c0c691c5ebc15afda23
#lockdown alejandro.arango
#rb simon.therriault

[CL 24763869 by jeremie roy in ue5-main branch]
2023-03-23 12:41:57 -04:00
jeremie roy
0fad228315 Remote Control Security
Unify Allowed IP and AllowListed IP settings
Unify Use Passphrase and Allow passphrase



#jira UE-180586
#rb simon.therriault
#preflight 64149e303f3d31c94a973dd0
#lockdown alejandro.arango

[CL 24724032 by jeremie roy in ue5-main branch]
2023-03-20 17:19:34 -04:00
nick edwards
4bc34701c0 Fix C++20 compile error. Some types in RemoteControl are can no longer be aggregate initialized in C++20.
#preflight 6418451642618c85c474ea25
#rb none
#jira none

[CL 24719412 by nick edwards in ue5-main branch]
2023-03-20 13:28:35 -04:00
jeremie roy
e9a955c2ee Fix remote control routes circumventing security features
Remote control internal preprocessors will now be redirected to the same preprocessors that are used for http routes.

#jira UE-176324
#rb simon.therriault
#lockdown alejandro.arango
#preflight 6412090c924f0cb7223190f8

[CL 24678296 by jeremie roy in ue5-main branch]
2023-03-16 16:16:54 -04:00
paul vincent
b1252d8dce Remote Control Web Interface bind address should not be 0.0.0.0
#jira UE-175336
#rb Alejandro.Arango Simon.Therriault Jeremie.Roy
#preflight 640a016eaf3fc3529230903b

[CL 24578393 by paul vincent in ue5-main branch]
2023-03-09 12:42:37 -05:00
Paul Vincent
33be1ef8df Remote Control - HTTP preset property routes fail to set values for array elements
#jira UE-175360
#author Andrea.Botti
#rb Simon.Therriault Jeremie.Roy
#preflight 64094950827cf9251b55936b

[CL 24571143 by Paul Vincent in ue5-main branch]
2023-03-08 22:00:53 -05:00
paul vincent
f64e723d72 Remote Control Websocket server should not bind to 0.0.0.0 by default
#jira UE-175332
#rb Alejandro.Arango Simon.Therriault Jeremie.Roy
#preflight https://horde.devtools.epicgames.com/job/6406aaf58832f48a4deedc89

[CL 24542026 by paul vincent in ue5-main branch]
2023-03-07 12:02:27 -05:00
jeremie roy
279654fa69 Enforce passphrase for clients outside localhost
#rb simon.therriault geoffrey.douglas
#preflight 64062b073206d45d20211961
#jira UE-175343
#lockdown alejandro.arango

[CL 24533936 by jeremie roy in ue5-main branch]
2023-03-06 19:02:08 -05:00
Elliot Colp
e767f65b44 [RemoteControl] HTTP routes to add items to/remove items from arrays
#jira UE-175281
#rb Alejandro.Arango, Jeremie.Roy
#preflight 64025971aa00423335d6848b

[CL 24506076 by Elliot Colp in ue5-main branch]
2023-03-03 15:40:36 -05:00
simon therriault
6d8dad7b09 - Fix for AllowOrigin and AllowedIP being verified even if RestrictServer is disabled
#rb jeremie.roy
#jira UE-178465
#preflight 6402005cd249add4a25bb170
#lockdown alejandro.arango

[CL 24502885 by simon therriault in ue5-main branch]
2023-03-03 13:21:50 -05:00
jeremie roy
a4a8f07c80 Remote Control
- Add setting to control allowed origins
- Add request preprocessor to validate IP of peer that initiated connection

Http Listener
- Pass IP to request callback

#jira UE-175325 UE-176065 UE-176161
#rb simon.therriault geoffrey.douglas
#preflight 63eba0020a06073fef4334e5

[CL 24216481 by jeremie roy in ue5-main branch]
2023-02-14 13:29:16 -05:00
jeremie roy
489b0c6e27 Add remote control security settings
#preflight 63dd3ead244dc45a20990654
#rb simon.therriault geoffrey.douglas
#jira UE-175342

[CL 23993435 by jeremie roy in ue5-main branch]
2023-02-03 12:49:06 -05:00
george rolfe
83903f7c23 RC error output callback
#jira UE-175568
#rb simon.therriault
#preflight 63c8d9c52a6acaf162601344

[CL 23924033 by george rolfe in ue5-main branch]
2023-01-31 01:28:00 -05:00
Paul Vincent
12c8e1f7aa 1. RCP -Allowing String controller to be multiline when controller is binding Textbox
#author Andrea.Botti
#jira UE-172320
#rb Simon.Therriault Jeremie.Roy
#preflight 63ca581f894b640314817969

2. Remote Control Preset WebSocket updates are sometimes incorrect for nested bitfields

#author Andrea.Botti
#jira UE-169031
#rb Simon.Therriault Jeremie.Roy
#preflight 63ca581f894b640314817969

[CL 23787339 by Paul Vincent in ue5-main branch]
2023-01-20 04:11:09 -05:00
mikko mononen
a0c3b7ba8e StructUtils: FixStructUtils constness issues in RemoteControl.
#jira UE-172049
#rb Jeremie.Roy
#preflight 63bbe441d862fdd34736f5b9

[CL 23610893 by mikko mononen in ue5-main branch]
2023-01-09 06:46:16 -05:00
jeremie roy
1d9286b665 Disable remote control in qa virtualproduction tests
#jira UE-172673
#rb simon.therriault
#preflight 6398c7f62540a78d2733320b

[CL 23495371 by jeremie roy in ue5-main branch]
2022-12-13 14:23:54 -05:00
jeremie roy
3e975b6053 Fix uninitialized structs warning
#rb simon.therriault
#preflight 6388d5949242c01326ce4fc0

[CL 23360593 by jeremie roy in ue5-main branch]
2022-12-01 15:44:03 -05:00
jeremie roy
f35d69d139 Improve time for opening remote control preset in huge maps or when it has a lot of exposed properties
Significantly improve OnObjectPropertyChanged callback time
Fix hang when recompiling materials
Add traces

#jira IRON-319 IRON-320
#rb simon.therriault
#preflight 636a56a87c2b505190989f19

[CL 23026939 by jeremie roy in ue5-main branch]
2022-11-08 08:32:24 -05:00