53 Commits

Author SHA1 Message Date
Dario Mazzanti
d9a46a142a [Remote Control] Enums not properly supported in RCP
C++ and BP enum properties are handled differently, with the former not properly working with RC Controllers.

#jira UE-189659
#rb Jeremie.Roy

[CL 26608918 by Dario Mazzanti in 5.3 branch]
2023-07-26 11:37:11 -04:00
Dario Mazzanti
1491b4415e [Remote Control] Texture Controller not working with dynamic material
Code was not properly taking into account TObjectPtr vs. raw pointer

#jira none
#rb Jeremie.Roy
#p4v-cherrypick 26181917

[CL 26208353 by Dario Mazzanti in 5.3 branch]
2023-06-23 08:24:01 -04:00
juan portillo
26a26dd9ed Remote Control Logic:
- Update Target Entity when target entity is invalid or out of date

#rb Simon.Therriault

[CL 26098069 by juan portillo in 5.3 branch]
2023-06-19 14:29:14 -04:00
Dario Mazzanti
c990308c0e [Remote Control] Fix non-unity compile issue #316763
#jira none
#rb trivial

[CL 25930279 by Dario Mazzanti in ue5-main branch]
2023-06-12 11:33:17 -04:00
Dario Mazzanti
bd888f028b [Remote Control] QAVirtualProduction Compile Win64 linking error
Functions were wrongly wrapped in WITH_EDITOR define

#jira UE-188351
#rb Simon.Therriault

[CL 25898050 by Dario Mazzanti in ue5-main branch]
2023-06-09 13:18:29 -04:00
Dario Mazzanti
6bedcbf4f5 [Remote Control] Fix non-unity compile issue #316763
Horde issue 316763: https://horde.devtools.epicgames.com/job/64825d9637416fd06c7bed23?step=b9d4&issue=316763

#jira none
#rb trivial

[CL 25890842 by Dario Mazzanti in ue5-main branch]
2023-06-09 09:18:52 -04:00
Ola Olsson
9078c2e8e5 Fix mismatched WITH_EDITOR so CitySample win64 game compiles.
#rb trvial
#fyi dario.mazzanti

[CL 25888601 by Ola Olsson in ue5-main branch]
2023-06-09 03:53:46 -04:00
Dario Mazzanti
9dd0bf95f1 [Remote Control] Remote Control Logic - Adds Object controllers and Custom Texture controller
Adds support for some Object controllers:
- Static Mesh
- Material Interface
- Texture (as a custom controller)

Adds support for "custom" controllers, which can be considered as a specialized version of existing controller types
- Custom Texture controller is a specialized string controller loading a texture from a file path or from an asset, through a dedicated widget.

Known issues: transaction are not handled properly. It was difficult to differentiate between what's the expected RC handling of controllers and exposed properties, and the behavior resulting from undoing actions for these new controllers.

Further development of the Texture controller might include the creation of a dedicated struct e.g. FTextureSelector

#jira UE-184894
#rb Jeremie.Roy

[CL 25874085 by Dario Mazzanti in ue5-main branch]
2023-06-08 12:17:02 -04:00
Dario Mazzanti
ffaebaed0c [Remote Control] Crash in RangeMap action
- Code was directly accessing a map value with a non valid key
- PrevValueDifference was being computed starting from a non-normalized prev input value.

#jira UE-187132
#rb Jeremie.Roy
#preflight 6470c8049b33948f41a1243a

[CL 25643162 by Dario Mazzanti in ue5-main branch]
2023-05-26 11:02:46 -04:00
Dario Mazzanti
a76563908b [Remote Control] - Duplicating Action Doesn't Modify Values with Range Map Behavior
URCRangeMapBehaviour::DuplicateAction was creating a new RangeMapInput for the duplicated property without creating a new InputProperty.
Consequence was that all duplicated Range Map Actionswere acting as a single one.

Fix creates a new URCVirtualPropertySelfContainer, initialized with the Input Property taken from the source action RangeMapInput.

#jira UE-182661
#rb Jeremie.Roy
#preflight 646f8632d1157dc4a770f1bc

[CL 25623238 by Dario Mazzanti in ue5-main branch]
2023-05-25 12:30:34 -04:00
Juan Portillo
3455fadc50 Remote Control:
- Added fix for Double Properties not working for Bind

#jira none
#rb Simon.Therriault
#preflight 6439b3f4db681113a40e192c

[CL 25049461 by Juan Portillo in ue5-main branch]
2023-04-14 16:40:25 -04:00
paul vincent
7f0281939c 1. Crashes related to missing exposed property
#jira UE-175365
#rb Simon.Therriault Jeremie.Roy

2. Creating Controller with an Unbound Entity Crashes Editor

#jira UE-173762
#rb Simon.Therriault Jeremie.Roy

#preflight 63ee53aeb5262f41ae3379b8

[CL 24261237 by paul vincent in ue5-main branch]
2023-02-16 12:44:16 -05:00
henrik karlsson
ac40964430 [Engine]
* Fixed non unity/pch compile errors for various platforms

Can't run preflight, seems like horde don't recognize my changelist

#preflight skipped
#rb none
#jira none

[CL 23595926 by henrik karlsson in ue5-main branch]
2023-01-06 01:03:10 -05:00
paul vincent
efc4cc4f75 Bind Behavior Not Working With Integers in Avalanche
#jira UE-171675
#rb Alejandro.Arango Simon.Therriault Jeremie.Roy
#preflight 639852fc2540a78d27102a97
#lockdown Alejandro.Arango

[CL 23500066 by paul vincent in ue5-main branch]
2022-12-13 18:24:42 -05:00
Patrick Gross
b30d6e414f Remote Control Logic - Path Behaviour - External Textures
- Add HTTP Support

#rb paul.vincent
#jira UE-160531
#preflight 6381562cf514e1ded92fe754

[CL 23328349 by Patrick Gross in ue5-main branch]
2022-11-30 09:14:41 -05:00
joe pribele
dfb3ae4d41 removed PRAGMA_DISABLE_OPTIMIZATION that was left in
#preflight 6372ae5d1c114bec056ced96

[CL 23125912 by joe pribele in ue5-main branch]
2022-11-14 16:19:00 -05:00
henrik karlsson
fa90b399a4 Added includes for future change. This changelist only contains added #include and a couple of empty placeholder files
Tested compiling fortnite, unrealeditor, lyra, qagame with non-unity/pch

#preflight 63635997876630122adeab9f
#rb none

[CL 22958990 by henrik karlsson in ue5-main branch]
2022-11-03 14:18:47 -04:00
henrik karlsson
5298cc8120 Non-unity/pch compile fixes when building UnrealEditor linux
#rb none
#preflight skipped

[CL 22794114 by henrik karlsson in ue5-main branch]
2022-10-26 17:49:37 -04:00
venugopalan sreedha
0e536d5052 Refresh pivot gizmo post RC location updates
#jira UE-139903
#rb paul.vincent, simon.therriault
#lockdown alejandro.arango
#preflight 635044b3047f3570ada3951d

[CL 22649038 by venugopalan sreedha in ue5-main branch]
2022-10-19 22:39:01 -04:00
patrick gross
af680e9d71 Change away the Range Map Normalized Input to ones fitting the Min and Max Value
A small change which changes the current handling of Range Map, going from 0 - 1 as normalized values between an arbritrary Min and Max value, to an actual value set between it.

#rb simon.therriault
#jira UE-164565
#preflight 633f31e42a0a2c1ead3e53f0
#lockdown alejandro.arango

[CL 22432471 by patrick gross in ue5-main branch]
2022-10-10 12:47:03 -04:00
patrick gross
5ed2801963 Remote Control Logic - WebAPI Extension for RC Logc Controllers
Adds the required Callbacks and missing Routes for the WebApp, so that it can control the VirtualProperties/Controllers.
Following changes have been made:
- Add OnAdded/OnChanged/OnRemoved/OnRenamed Callback for Controllers
- Add Websocket Messages from those Callbacks to the Server
- Add Metadata Callbacks and implementation of imoprtant information such as "Widget" Metadata
- Fix up existing calls to Deserializer to work for structs
- Renaming VirtualProperty Calls/Methods within the Preset to Controllers

#rb paul.vincent
#rb venugopalan.sreedha
#rb simon.therriault
#rb amir.keren
#jira UE-163264
#preflight 633b5446b12b8af5fd015430

[CL 22324865 by patrick gross in ue5-main branch]
2022-10-03 22:03:22 -04:00
patrick gross
a953e3416d Remote Contorl Logic - RangeMap Behaviour Fix Setter Error
Fix a Remote Control Propert Handle Bug where the Pathing wouldn't work for Structs within the Exposed Object.

#jira UE-164565
#rb jeremie.roy
#rb simon.therriault
#rb venugopalan.sreedha'
#rb paul.vincent
#preflight 633b26eef513083ba3fd692c

[CL 22323351 by patrick gross in ue5-main branch]
2022-10-03 21:13:11 -04:00
patrick gross
bab8744d46 Remote Control Logic - RangeMap Behaviour - Implement UI Feedback
- Change from Step to Input
- Remove Threshold and make it an internal value of 0.05

#rb paul.vincent, venugopalan.sreedha
#jira UE-164567
#preflight 6336d3d57c11614c21bda50f

[CL 22279120 by patrick gross in ue5-main branch]
2022-09-30 15:46:50 -04:00
venugopalan sreedha
6222f7c122 Regression: Multiple Actions for same field
This was broken by the commit for supporting Material Actions.

We needed to explicitly check if we're dealing with an Array property as well, in addition to the other checks.

#jira UE-164511
#rb paul.vincent
#preflight 6336ec99e72271755f15ab91

[CL 22272855 by venugopalan sreedha in ue5-main branch]
2022-09-30 12:25:15 -04:00
venugopalan sreedha
22e209f6d1 "Edit Step" option for Range Map Behaviour
#jira UE-164566
#rb paul.vincent, patrick.gross
#preflight 6336e4fa0d2b0d7bd8940440

[CL 22272819 by venugopalan sreedha in ue5-main branch]
2022-09-30 12:24:05 -04:00