40 Commits

Author SHA1 Message Date
kirill zorin
b6ee3a6c64 Fix UE_LOG callsites that have format string-related UB
#rb trivial
#preflight 647107780a6634dbb236a0a6

[CL 25651638 by kirill zorin in ue5-main branch]
2023-05-26 15:52:39 -04:00
jeremie roy
167173022d Allow changing RC web interface bind address
Enable remote passphrase enforcement by default when Restrict Server access is enabled

#jira UE-175341
#rb simon.therriault
#lockdown alejandro.arango
#preflight 6425a54d9834526476348afb

[CL 24861268 by jeremie roy in ue5-main branch]
2023-03-30 17:55:41 -04:00
jeremie roy
6f50b74191 Remote Control expose websocket server bind address
#jira UE-180918
#preflight 641c5c0c691c5ebc15afda23
#lockdown alejandro.arango
#rb simon.therriault

[CL 24763869 by jeremie roy in ue5-main branch]
2023-03-23 12:41:57 -04:00
jeremie roy
32f74abb44 Fix CIS error caused by submission of UE_DISABLE_OPTIMIZATION
#rb simon.therriault
#preflight 641893eb5d3e25354f0e63b1
#jira UE-180743
#lockdown alejandro.arango

[CL 24724086 by jeremie roy in ue5-main branch]
2023-03-20 17:21:47 -04:00
jeremie roy
0fad228315 Remote Control Security
Unify Allowed IP and AllowListed IP settings
Unify Use Passphrase and Allow passphrase



#jira UE-180586
#rb simon.therriault
#preflight 64149e303f3d31c94a973dd0
#lockdown alejandro.arango

[CL 24724032 by jeremie roy in ue5-main branch]
2023-03-20 17:19:34 -04:00
nick edwards
4bc34701c0 Fix C++20 compile error. Some types in RemoteControl are can no longer be aggregate initialized in C++20.
#preflight 6418451642618c85c474ea25
#rb none
#jira none

[CL 24719412 by nick edwards in ue5-main branch]
2023-03-20 13:28:35 -04:00
paul vincent
b1252d8dce Remote Control Web Interface bind address should not be 0.0.0.0
#jira UE-175336
#rb Alejandro.Arango Simon.Therriault Jeremie.Roy
#preflight 640a016eaf3fc3529230903b

[CL 24578393 by paul vincent in ue5-main branch]
2023-03-09 12:42:37 -05:00
paul vincent
f64e723d72 Remote Control Websocket server should not bind to 0.0.0.0 by default
#jira UE-175332
#rb Alejandro.Arango Simon.Therriault Jeremie.Roy
#preflight https://horde.devtools.epicgames.com/job/6406aaf58832f48a4deedc89

[CL 24542026 by paul vincent in ue5-main branch]
2023-03-07 12:02:27 -05:00
jeremie roy
279654fa69 Enforce passphrase for clients outside localhost
#rb simon.therriault geoffrey.douglas
#preflight 64062b073206d45d20211961
#jira UE-175343
#lockdown alejandro.arango

[CL 24533936 by jeremie roy in ue5-main branch]
2023-03-06 19:02:08 -05:00
jeremie roy
a4a8f07c80 Remote Control
- Add setting to control allowed origins
- Add request preprocessor to validate IP of peer that initiated connection

Http Listener
- Pass IP to request callback

#jira UE-175325 UE-176065 UE-176161
#rb simon.therriault geoffrey.douglas
#preflight 63eba0020a06073fef4334e5

[CL 24216481 by jeremie roy in ue5-main branch]
2023-02-14 13:29:16 -05:00
jeremie roy
489b0c6e27 Add remote control security settings
#preflight 63dd3ead244dc45a20990654
#rb simon.therriault geoffrey.douglas
#jira UE-175342

[CL 23993435 by jeremie roy in ue5-main branch]
2023-02-03 12:49:06 -05:00
bryan sefcik
f91212124f Added generated.h includes and updated enums to have underlying types.
#preflight 63d458095354589b5c16c0e3

[CL 23895079 by bryan sefcik in ue5-main branch]
2023-01-27 18:45:50 -05:00
steve robb
517e300e49 CIS fix.
#rb none
#jira none
#preflight none

[CL 23889507 by steve robb in ue5-main branch]
2023-01-27 14:51:41 -05:00
steve robb
4900d8a570 Replaced TModels traits class with TModels_V.
#rb devin.doucette
#preflight 63d3aabf5354589b5cd2343b

[CL 23889491 by steve robb in ue5-main branch]
2023-01-27 14:51:16 -05:00
steve robb
48359cce3e Removed some TIsSame usage (part of a larger change to deprecate TIsSame).
#rb james.hopkin
#preflight 63bff06d4b018bfa800453f0

[CL 23661851 by steve robb in ue5-main branch]
2023-01-12 09:01:39 -05:00
Patrick Gross
71b4199aa4 Fix allowing changes to protected proeprties without the AllowPrivateAccess Metadata
- Adds two warning widgets to the Panel which warn the users in case its activated
- Adds the ability to ignore protected and Getter/Setter Properties using certian functions.

#jira UE-166715
#rb jeremie.roy
#preflight https://horde.devtools.epicgames.com/job/637e6668f514e1ded98269dc

[CL 23266740 by Patrick Gross in ue5-main branch]
2022-11-25 10:55:34 -05:00
henrik karlsson
fa90b399a4 Added includes for future change. This changelist only contains added #include and a couple of empty placeholder files
Tested compiling fortnite, unrealeditor, lyra, qagame with non-unity/pch

#preflight 63635997876630122adeab9f
#rb none

[CL 22958990 by henrik karlsson in ue5-main branch]
2022-11-03 14:18:47 -04:00
paul vincent
a493d64735 1. Remote API Protocols - Masking Limitation
#jira UE-162294
#rb Simon.Therriault Jeremie.Roy
#preflight 632bfb8eb4515b7e22aede93

2. MIDI Muting/Isolating Channels

#jira UE-113372
#rb Simon.Therriault Jeremie.Roy
#preflight 632bfb8eb4515b7e22aede93

[CL 22143303 by paul vincent in ue5-main branch]
2022-09-22 15:41:39 -04:00
George Rolfe
9316b050f5 RCPropertyContainer setter fix
#jira UE-151244
#rb simon.therriault
#preflight 6285b80f9016c6dd8965278e

[CL 20274951 by George Rolfe in ue5-main branch]
2022-05-18 23:44:18 -04:00
George Rolfe
f43055b426 RCPropertyUtilities cis fix
#jira none
#rb none
#preflight 6285ab427f55da1a6ed3d302

[CL 20274206 by George Rolfe in ue5-main branch]
2022-05-18 23:00:33 -04:00
George Rolfe
724f9a7c8f LightComponent LightColor setter + RC patch
#jira UE-147609
#rb simon.therriault
#preflight 6285a4e1a474f8bb21896f08

[CL 20273701 by George Rolfe in ue5-main branch]
2022-05-18 22:17:42 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
jeremie roy
ee96e96e7a Fix values not transacting through nDisplay when driving Remote Control parameter
#rb simon.therriault
#lockdown simon.tourangeau
#jira UE-145251
#preflight 622b8db7cd605bd993cd82cc

#ROBOMERGE-AUTHOR: jeremie.roy
#ROBOMERGE-SOURCE: CL 19359071 in //UE5/Release-5.0/... via CL 19360208
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v926-19321884)

[CL 19361050 by jeremie roy in ue5-main branch]
2022-03-11 16:37:11 -05:00
simon therriault
2e288b6fe8 Potential Security Issue, Login Screen
Have addeda a FHttpRequestHandler as a RequestPreprocessor which checks whether or not an Requests Header has a corresponding ApiKey to allow the execution, using MD5 hashing to obscure it a bit.
This affects Http Calls and Websocket Calls. Changes Wrapped RCWebsocketRequest to allow holding hashed ApiKeys from the outside. Mainly hooked as an additional Handler in WebRemoteControl.

#jira UE-139210
#rb simon.therriault, amir.keren
#preflight 622113f2c7262e0e538118cf
#lockdown alejandro.arango

#ROBOMERGE-OWNER: simon.therriault
#ROBOMERGE-AUTHOR: patrick.gross
#ROBOMERGE-SOURCE: CL 19252881 in //UE5/Release-5.0/... via CL 19257182
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v924-19243027)

[CL 19263496 by simon therriault in ue5-main branch]
2022-03-04 03:45:11 -05:00
simon therriault
eb076771e4 - Changing default webapp port to avoid conflicts on mac
#b amir.keren
[FYI] jeremie.roy
#jira UE-138889
#preflight 61f44b367a7f0d39ddf2f09c

#ROBOMERGE-AUTHOR: simon.therriault
#ROBOMERGE-SOURCE: CL 18777279 in //UE5/Release-5.0/... via CL 18778402 via CL 18778929
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18778965 by simon therriault in ue5-main branch]
2022-01-28 16:45:44 -05:00