425 Commits

Author SHA1 Message Date
Dario Mazzanti
d9a46a142a [Remote Control] Enums not properly supported in RCP
C++ and BP enum properties are handled differently, with the former not properly working with RC Controllers.

#jira UE-189659
#rb Jeremie.Roy

[CL 26608918 by Dario Mazzanti in 5.3 branch]
2023-07-26 11:37:11 -04:00
Dario Mazzanti
5cead17245 [Remote Control] Controllers List Items: add column extensibility
By registering to the new IRemoteControlUIModule delegates:
- OnAddControllerExtensionColumn
- OnGenerateControllerExtensionsWidgets

it is possible to add a custom column to the controllers list, and customize its widget, e.g. to perform custom actions on the controller

#jira UE-190624
#rb Jeremie.Roy
#p4v-cherrypick 26515173

[CL 26603892 by Dario Mazzanti in 5.3 branch]
2023-07-26 08:51:53 -04:00
Dario Mazzanti
098c1ebeff [Remote Control] Prevent unsupported types to be available for controller creation when performing drag and drop
Note: not all enums are supported. For now, this CL will disable drag and drop for all enums. Created jira UE-189659 to address that.

#jira UE-189658
#rb Jeremie.Roy

[CL 26585416 by Dario Mazzanti in 5.3 branch]
2023-07-25 15:38:19 -04:00
jeremie roy
2b71a175f4 Fix property watchers not working in PIE
#rb simon.therriault
#jira UE-190505

[CL 26433520 by jeremie roy in 5.3 branch]
2023-07-18 10:19:08 -04:00
Dario Mazzanti
1491b4415e [Remote Control] Texture Controller not working with dynamic material
Code was not properly taking into account TObjectPtr vs. raw pointer

#jira none
#rb Jeremie.Roy
#p4v-cherrypick 26181917

[CL 26208353 by Dario Mazzanti in 5.3 branch]
2023-06-23 08:24:01 -04:00
juan portillo
26a26dd9ed Remote Control Logic:
- Update Target Entity when target entity is invalid or out of date

#rb Simon.Therriault

[CL 26098069 by juan portillo in 5.3 branch]
2023-06-19 14:29:14 -04:00
elliot colp
e091296e22 [RemoteControl] Fix HTTP query parameters not being parsed when sent via WebSocket http route
#jira UE-188884
#rb Jeremie.Roy

[CL 26060555 by elliot colp in 5.3 branch]
2023-06-16 13:41:33 -04:00
dario mazzanti
c44c2be605 [Remote Control] Add UI Module method to retrieve a custom controller widget from outside the RC Module
#jira UE-188914
#rb Jeremie.Roy

[CL 26058780 by dario mazzanti in 5.3 branch]
2023-06-16 13:03:06 -04:00
Dario Mazzanti
eeb3c74890 [Remote Control] Crash in Virtual Production template project
#jira UE-188465
#rb Jeremie.Roy

[CL 25977598 by Dario Mazzanti in ue5-main branch]
2023-06-14 10:14:57 -04:00
Dario Mazzanti
c990308c0e [Remote Control] Fix non-unity compile issue #316763
#jira none
#rb trivial

[CL 25930279 by Dario Mazzanti in ue5-main branch]
2023-06-12 11:33:17 -04:00
jeremie roy
0e985865d5 Fix duplicated LOCTEXT macro keys in RemoteControlUI causing CIS error
#jira UE-188450
#rb simon.therriault
#fyi Dario.Mazzanti

[CL 25927514 by jeremie roy in ue5-main branch]
2023-06-12 09:41:45 -04:00
Dario Mazzanti
bd888f028b [Remote Control] QAVirtualProduction Compile Win64 linking error
Functions were wrongly wrapped in WITH_EDITOR define

#jira UE-188351
#rb Simon.Therriault

[CL 25898050 by Dario Mazzanti in ue5-main branch]
2023-06-09 13:18:29 -04:00
Dario Mazzanti
4c98dcb432 [Remote Control] Expose Sub Properties
(on behalf of Andrea Botti)

#jira none
#rb Jeremie.Roy

[CL 25892646 by Dario Mazzanti in ue5-main branch]
2023-06-09 10:24:17 -04:00
Dario Mazzanti
6bedcbf4f5 [Remote Control] Fix non-unity compile issue #316763
Horde issue 316763: https://horde.devtools.epicgames.com/job/64825d9637416fd06c7bed23?step=b9d4&issue=316763

#jira none
#rb trivial

[CL 25890842 by Dario Mazzanti in ue5-main branch]
2023-06-09 09:18:52 -04:00
Ola Olsson
9078c2e8e5 Fix mismatched WITH_EDITOR so CitySample win64 game compiles.
#rb trvial
#fyi dario.mazzanti

[CL 25888601 by Ola Olsson in ue5-main branch]
2023-06-09 03:53:46 -04:00
Dario Mazzanti
9dd0bf95f1 [Remote Control] Remote Control Logic - Adds Object controllers and Custom Texture controller
Adds support for some Object controllers:
- Static Mesh
- Material Interface
- Texture (as a custom controller)

Adds support for "custom" controllers, which can be considered as a specialized version of existing controller types
- Custom Texture controller is a specialized string controller loading a texture from a file path or from an asset, through a dedicated widget.

Known issues: transaction are not handled properly. It was difficult to differentiate between what's the expected RC handling of controllers and exposed properties, and the behavior resulting from undoing actions for these new controllers.

Further development of the Texture controller might include the creation of a dedicated struct e.g. FTextureSelector

#jira UE-184894
#rb Jeremie.Roy

[CL 25874085 by Dario Mazzanti in ue5-main branch]
2023-06-08 12:17:02 -04:00
Elliot Colp
6e741e0c9f [RemoteControl] Fix incorrect property expose/unexpose events on undo/redo when exposure occurs outside a transaction or in a transient preset
#jira UE-187470
#author andrea.botti
#preflight 647a4b6f4678712034c30d1b

[CL 25772249 by Elliot Colp in ue5-main branch]
2023-06-02 16:20:44 -04:00
Elliot Colp
86c4e0e10a [RemoteControl] Fix crash due to binding returning null despite being bound
#jira UE-186575
#rb Alejandro.Arango, Simon.Therriault
#preflight 6477a45c4b0d5a1eb1611bf6

[CL 25712047 by Elliot Colp in ue5-main branch]
2023-05-31 16:05:16 -04:00
kirill zorin
b6ee3a6c64 Fix UE_LOG callsites that have format string-related UB
#rb trivial
#preflight 647107780a6634dbb236a0a6

[CL 25651638 by kirill zorin in ue5-main branch]
2023-05-26 15:52:39 -04:00
Dario Mazzanti
ffaebaed0c [Remote Control] Crash in RangeMap action
- Code was directly accessing a map value with a non valid key
- PrevValueDifference was being computed starting from a non-normalized prev input value.

#jira UE-187132
#rb Jeremie.Roy
#preflight 6470c8049b33948f41a1243a

[CL 25643162 by Dario Mazzanti in ue5-main branch]
2023-05-26 11:02:46 -04:00
Dario Mazzanti
a76563908b [Remote Control] - Duplicating Action Doesn't Modify Values with Range Map Behavior
URCRangeMapBehaviour::DuplicateAction was creating a new RangeMapInput for the duplicated property without creating a new InputProperty.
Consequence was that all duplicated Range Map Actionswere acting as a single one.

Fix creates a new URCVirtualPropertySelfContainer, initialized with the Input Property taken from the source action RangeMapInput.

#jira UE-182661
#rb Jeremie.Roy
#preflight 646f8632d1157dc4a770f1bc

[CL 25623238 by Dario Mazzanti in ue5-main branch]
2023-05-25 12:30:34 -04:00
jeremie roy
4e169175c1 Fix remote control not finding object in PIE
#preflight 64665f35ec5109088b3b3722
#rb simon.therriault

[CL 25533626 by jeremie roy in ue5-main branch]
2023-05-18 16:49:58 -04:00
Elliot Colp
109c8532c9 [RemoteControl] Fix property changes being missed in manual transactions
#jira UE-186278
#rb Jeremie.Roy
#preflight 646687c7b1176e43bde86447

[CL 25533503 by Elliot Colp in ue5-main branch]
2023-05-18 16:42:58 -04:00
jeremie roy
f64749b722 Fix remote control crash on exit
#jira UE-185974
#preflight 6463c3fefa4cf41651bc844c
#rb simon.therriault

[CL 25494647 by jeremie roy in ue5-main branch]
2023-05-16 15:17:50 -04:00
Dario Mazzanti
63ad85c122 [Remote Control] Rebinding Remote Control Property Does not change owner name of multiple properties
Adds an override to Refresh in SRCPanelExposedEntity, and call SRCPanelExposedEntity::Refresh from child classes SRCPanelExposedField::Refresh() and SRCPanelExposedActpr::Refresh().
This allows the Entity internal cached data to be updated after the Rebind.

Upvoted ver.5
Version 6 is merging changes coming from latest.

#jira UE-182526
#rb Jeremie:Roy
#preflight 64622b4df760fe87e9ee418d

[CL 25472287 by Dario Mazzanti in ue5-main branch]
2023-05-15 09:15:58 -04:00