196 Commits

Author SHA1 Message Date
louisphilippe seguin
2bac2b1d0f RepGraph
* Added comment explaining why we always calculate actor distance to view when replicating

#rb trivial
#rnx

[CL 26818894 by louisphilippe seguin in 5.3 branch]
2023-08-03 14:07:51 -04:00
urias rooney
24c88b09cc ## RepGraph actor reference validation
* Added ValidateActorReferences to RepGraph and RepGraphNode types
  * Iterates over all nodes in the RepGraph and checks for potentally stale actor references

## Performance

Tested on a Win64 Test Server
* ValidateActorReferences: 10-20us

[CL 26713129 by urias rooney in 5.3 branch]
2023-07-31 13:46:37 -04:00
joe bestrotheray
ce16e22475 Change saturation analytics so that connection saturation, fast path saturation, and DSF saturation are all tracked separately
#rb LouisPhilippe.Seguin

[CL 26623996 by joe bestrotheray in 5.3 branch]
2023-07-26 17:54:47 -04:00
christopher daniel
7a897ddef5 Replication / Dormancy and Always Relevant: Fixed bug where an always relevant, dormant actor could lose relevancy on clients. Now that actor will not be destroyed on clients where they are always relevant.
#rnx
#rb LouisPhilippe.Seguin
[REVIEW] [at]Dan.Kaufman, [at]Beth.Reid, [at]Anthony.Glueck

[CL 26070293 by christopher daniel in 5.3 branch]
2023-06-16 17:06:54 -04:00
henrik karlsson
bad8a3e8c9 [ReplicationGraph]
* Fixed include placement bug where UE_ENABLE_INCLUDE_ORDER_DEPRECATED_IN_5_2 was placed after .generated.h include but before code.

[CL 26067044 by henrik karlsson in 5.3 branch]
2023-06-16 15:54:06 -04:00
louisphilippe seguin
84b4cc7018 RepGraph
* Fix log spam caused by actors going outside the legal world bounds and staying OOB.
* Now we will only log a warning once when the actor goes OOB
* net.ReplicationGraph.PrintGraph now prints the list of DynamicSpatializedActors monitored by the Grid2D node.

#rb Ryan.Gerleve

[CL 25934977 by louisphilippe seguin in ue5-main branch]
2023-06-12 15:27:57 -04:00
nathan green
9a09c86175 - Fixing assert on FloatToIntCastChecked when you set your actor cull distance larger than std::numerics<int>
[REVIEW] [at]Ryan.Gerleve, [at]Cory.Kolek
#jira: FORT-620840

[CL 25906326 by nathan green in ue5-main branch]
2023-06-09 18:01:30 -04:00
joe bestrotheray
6518935a73 Make CVar_RepGraph_DynamicSpatialFrequency_UncapBandwidth non-const in shipping builds so it can be hotfixed on/off
[CL 25891529 by joe bestrotheray in ue5-main branch]
2023-06-09 09:48:29 -04:00
louisphilippe seguin
d2f271bbdd RepGraph: Fix int to float cast warning
#rb trivial
#rnx

[CL 25794864 by louisphilippe seguin in ue5-main branch]
2023-06-05 12:26:09 -04:00
louisphilippe seguin
5d56917cd7 Fix int to float cast error
#rb trivial

[CL 25794829 by louisphilippe seguin in ue5-main branch]
2023-06-05 12:25:32 -04:00
louisphilippe seguin
d3e3be0585 NetDriver
* Deprecated NetServerMaxTickRate variable and replaced them with Get/Set functions.
* Added FOnNetServerMaxTickRateChanged delegate. Register to receive callbacks when the server tick rate changes.

#jira UE-185786
#rb Ryan.Gerleve

[CL 25793458 by louisphilippe seguin in ue5-main branch]
2023-06-05 11:41:28 -04:00
kirill zorin
b6ee3a6c64 Fix UE_LOG callsites that have format string-related UB
#rb trivial
#preflight 647107780a6634dbb236a0a6

[CL 25651638 by kirill zorin in ue5-main branch]
2023-05-26 15:52:39 -04:00
kirill zorin
de8db5ff76 Converting ARO-facing raw pointers to TObjectPtr ahead of raw pointer ARO API deprecation.
#rb zousar.shaker
#rb markus.breyer
#rb robert.manuszewski

#preflight 646391406b1406b54ab15460

[CL 25489627 by kirill zorin in ue5-main branch]
2023-05-16 10:52:49 -04:00
kirill zorin
a469aafd78 Update callsites to prepare for upcoming TArray/TArrayView<TObjectPtr<...>> restrictions
#rb zousar.shaker
#rb devin.doucette
#rb steve.robb
#rb robert.manuszewski
#rb saam.barati
#preflight 643f4c09a35280ed4f53ccb3

[CL 25100071 by kirill zorin in ue5-main branch]
2023-04-18 22:39:29 -04:00
Brian Bekich
933b3733c1 Handle gameplay debugger replicator in basic rep graph
#jira UE-183272
#jira UE-183273
#preflight 643963a0c947f6523a56e24c
#rb louisphilippe.seguin

[CL 25048869 by Brian Bekich in ue5-main branch]
2023-04-14 16:19:55 -04:00
Brian Bekich
ddda7e829a Reverting uses of FloatCastChecked
#jira UE-181363
#preflight 64222de1c42c7fd1cbb14030

[CL 24813420 by Brian Bekich in ue5-main branch]
2023-03-27 20:15:42 -04:00
Brian Bekich
26610f72b2 Enabling UnsafeTypeCastWarningLevel for rep graph
#jira none
#preflight 641882a042618c85c48c0385
#rb louisphilippe.seguin, jon.fairchild, ryan.gerleve

[CL 24732881 by Brian Bekich in ue5-main branch]
2023-03-21 11:42:33 -04:00
louisphilippe seguin
234eccbf75 ReplicationGraph
* Prevent sending multicast RPCs on a channel that is closing but not yet cleaned up.

#rb Ryan.Gerleve

[CL 24617952 by louisphilippe seguin in ue5-main branch]
2023-03-13 14:37:56 -04:00
anton dunchev
4076ae4e46 Fix DormantActorDestruction: remove cached nodes, so 2 arrays point to same cell data.
[REVIEW] [at]brian.bekich, [at]louisphilippe.seguin, [at]richard.smith
#rb andrew.ladenberger
#rnx

#localization none
#tests PIE

[CL 24509700 by anton dunchev in ue5-main branch]
2023-03-03 18:16:21 -05:00
brian bekich
09edde2147 Lowering net frequency of rep graph debug actor
#rb ryan.gerleve

[CL 24295943 by brian bekich in ue5-main branch]
2023-02-17 20:29:33 -05:00
brian bekich
1de597a7bb Add optional driver name filter to rep graph debug commands
#rb ryan.gerleve

[CL 24138163 by brian bekich in ue5-main branch]
2023-02-11 13:03:07 -05:00
anton dunchev
99e519be25 ReplicationGraph amortize the cost of dormant actor cleanup by allowing gathering actor lists for 1 connection at a time.
#rb LouisPhilippe.Seguin
#tests PIE

[CL 24058151 by anton dunchev in ue5-main branch]
2023-02-07 15:43:54 -05:00
anton dunchev
5813842292 Fix stale nodes cleanup from caches when Node disconnected from the connection
#rnx
[FYI] andrew.ladenberger, brian.bekich, LouisPhilippe.Seguin

[CL 23782222 by anton dunchev in ue5-main branch]
2023-01-19 17:27:57 -05:00
anton dunchev
f506434e62 Fix stale nodes cleanup from caches when Node disconnected from the connection
#rnx
[FYI] andrew.ladenberger, brian.bekich, LouisPhilippe.Seguin

[CL 23781885 by anton dunchev in ue5-main branch]
2023-01-19 17:14:50 -05:00
anton dunchev
98624ca781 Fix TTL decrease for dormant actor cleanup
#rnx
[FYI] andrew.ladenberger, brian.bekich, LouisPhilippe.Seguin

[CL 23781861 by anton dunchev in ue5-main branch]
2023-01-19 17:14:02 -05:00