58 Commits

Author SHA1 Message Date
patrick boutot
71b99248bb MVVM: Fix conversion function allow test when the graph is a wrapper.
[CL 26870831 by patrick boutot in 5.3 branch]
2023-08-05 11:49:18 -04:00
patrick boutot
7142dd466a MVVM: Undo modification made to make property blueprintreadonly. Introduced with CL 26845876
#rb trivial

[CL 26848348 by patrick boutot in 5.3 branch]
2023-08-04 11:35:27 -04:00
patrick boutot
6362905afd MVVM: Fix conversion function with multiples input paths.
Bindings will only be executed once at initialization. The bug happend when more than once source can activate the same binding.
Binding can now be OneWay if at least one argument is a FieldNotify. Otherwise it needs to be a OneTime.
Binding that has hardcoded value, no paths, are now supported.
#rb vincent.gauthier

[CL 26845984 by patrick boutot in 5.3 branch]
2023-08-04 10:43:00 -04:00
patrick boutot
a0ab119c05 MVVM: Add UX for view's settings. Seperate bindings initialization and sources initialization. Use can now select if it wants the bindings and the sources to be initialized.
#rb editor-ui-systems

[CL 26715781 by patrick boutot in 5.3 branch]
2023-07-31 14:42:30 -04:00
patrick boutot
5e7ddbdf85 MVVM: Fix bad refactor code introduced with CL 26614337
#jira UE-191378
#rb none

[CL 26652010 by patrick boutot in 5.3 branch]
2023-07-27 15:54:37 -04:00
patrick boutot
5f93aa6138 Temporary fix for UE-191378. Log an error instead of crashing until we figure out what is going on.
#rnx
#jira UE-191378

[CL 26649784 by patrick boutot in 5.3 branch]
2023-07-27 15:14:36 -04:00
patrick boutot
225ca03821 MVVM: When a conversion function is virtual, reevaluate at runtime the function.
#jira UE-189301
#rb vincent.gauthier

[CL 26629110 by patrick boutot in 5.3 branch]
2023-07-26 20:19:13 -04:00
patrick boutot
81e077a7d4 MVVM: Add option to generate conversion graph when compiling and not saved in the packages.
Useful when graph cannot be saved.
#jira UE-130879

[CL 26614351 by patrick boutot in 5.3 branch]
2023-07-26 13:51:11 -04:00
patrick boutot
f7a219685a MVVM: Save the MemberReference with self context. That allow the path to be used in the skeletal compilation phase.
#rb editor-ui-systems

[CL 26058530 by patrick boutot in 5.3 branch]
2023-06-16 12:57:13 -04:00
keaton stewart
f31c33bf04 [Backout] - CL25766777 CIS FastCook Error
[FYI] Patrick.Boutot
Original CL Desc
-----------------------------------------------------------------
MVVM: Supports FieldNotify broadcast on BP defined variable.
#rb editor-ui-systems
#preflight 6479ed64d36d33e0e45190c7

[CL 25770631 by keaton stewart in ue5-main branch]
2023-06-02 15:16:58 -04:00
patrick boutot
624d0d37a6 MVVM: Supports FieldNotify broadcast on BP defined variable.
#rb editor-ui-systems
#preflight 6479ed64d36d33e0e45190c7

[CL 25766805 by patrick boutot in ue5-main branch]
2023-06-02 13:33:02 -04:00
patrick boutot
47f876b932 MVVM: Fix static analysis warning
#rnx
#rb none

[CL 25546030 by patrick boutot in ue5-main branch]
2023-05-19 12:03:31 -04:00
patrick boutot
384a2ffacf MVVM: Enable bindings from view to view or viewmodel to viewmodel for the compiler. The binding execution does not care. It was restricted by the UI.
#rb editor-ui-systems
#preflight 6464d204f033744ae66aa602

[CL 25509715 by patrick boutot in ue5-main branch]
2023-05-17 12:34:34 -04:00
patrick boutot
67693ef1b7 MVVM: Fix SetViewModel that didn't trigger the child viewmodel binding when changed. Use QAGame UMG_MVVM_LongPath to test. The order the sources are added is important to make sure the bindings are executed in the correct order.
#rb yohann.dossantos
#preflight 642ebaca4847065878530573

[CL 24956638 by patrick boutot in ue5-main branch]
2023-04-06 16:59:04 -04:00
patrick boutot
427ba04371 MVVM: Remove needs to have a SourcePath for ComplexConversionFunction. The source data is inside the function itself and the fieldnotify name is already saved in the class binding.
Update GetBindingInfoFromFieldPath to support viewmodel inside another viewmodel. Add unittest for the function.
Add DoesInitializeAtConstruction on the view class. That is to support manual initialization. When the flag is false, the user is responsible for initializing the view.
Add ReevaluateSourceCreator. A source that was discovered at compile time and added to the list of SourceCreator may need to be evaluated if the path contains notify. That function is similar to SetViewModel but finds the new value from the SourceCreator.
Fix issue when a binding destination can't be evaluated at initialization. Since we only reactivate the bindings link to a source in SetViewModel, some bindings were never registered and never executed after the SetViewModel properly set the binding destination.
Update the view class ToString functions with the new flags.
Prevent adding a new binding when the editor data contains a conversion function and a regular function. That may occur when the user started with a regular binding and changed it afterward for a conversion function. We may not want to reset the binding to be non destructive.
#prefligth 6419e837bb1320be412d274d, 641b068aee0aed13479e6ea3

[CL 24750233 by patrick boutot in ue5-main branch]
2023-03-22 13:07:37 -04:00
zahra nikbakht
e206fdedb6 - Move the list of messages (errors, warnings, info) from the bindings themselves to the owning viewmodel.
- Add a border on each MVVM binding row in the list view of bindings that changes color to red/yellow if there is any error/warning for that binding
- detect if a property is bound to both a MVVM binding and a legacy binding at the same time and add a warning for it.
#jira UE-170983
#jira UE-170403
#rb patrick.boutot, vincent.gauthier
#preflight 6414c614ca2afe3ee6b1c7c8

[CL 24695764 by zahra nikbakht in ue5-main branch]
2023-03-17 16:33:42 -04:00
patrick boutot
0f5123a168 MVVM: Add option to log all bindings after compilations. Complete the ToString library from CompiledBindings. Expose the LogMVVM to other MVVM modules. In the view, properly report error in the message log.
#jira UE-178313
#preflight 64130274bd6894c43518c04e
#rb daren.cheng

[CL 24673818 by patrick boutot in ue5-main branch]
2023-03-16 13:02:33 -04:00
patrick boutot
2c2fa3761b MVVM: Add a global option to allow viewmodel setter function. This prevent the validation for object /Script/CoreUObject.Function.
Add an option to show the detail view in the binding panel. This prevent the bad memory access in the customizer used by a the binding panel.
#preflight 640b5c260e1f02786bff27f5

[CL 24603096 by patrick boutot in ue5-main branch]
2023-03-10 23:20:09 -05:00
patrick boutot
bc181cb231 MVVM: Rename MVVMBlueprintViewBinding.ViewModelPath and WidgetPath to SourePath and DestinationPath. Historicly they were named that way because it made sense to bind grom viewmodel to a widget. Now we can bind from any property to any property. We renamed to remove the confusion.
#test MVVM asset in QAGame
#rb Yohann.DosSantos
#preflight 64089d788c0039bbf73e80d8

[CL 24574634 by patrick boutot in ue5-main branch]
2023-03-09 08:41:28 -05:00
patrick boutot
8f4aae576d MVVM: Temporary disable code that make the viewmodel variable private. The code is there to prevent setting the variable without using the Setter function.
[CL 24525458 by patrick boutot in ue5-main branch]
2023-03-06 13:07:33 -05:00
patrick boutot
91dfcc1e92 MVVM: First step to support viewmodel inside viewmodel. The wiew now support source that is not a UserWidget property. The compiler generates the missing path.
#jira UE-155920
#preflight 6405aa936e1dadfcdaec0442

[CL 24521505 by patrick boutot in ue5-main branch]
2023-03-06 09:41:11 -05:00
ronald koppers
6f5addd262 Renamed PropertyEditorPermissionList to PropertyPermissionList.
#preflight 63fd04f5c35a14198011368b
#rb Rex.Hill

[CL 24432348 by ronald koppers in ue5-main branch]
2023-02-27 16:27:44 -05:00
ronald koppers
a15889181b Added a new hidden property validation list.
#rb Rex.Hill
#preflight 63f7c9562b1a2765f90a26a5

[CL 24397802 by ronald koppers in ue5-main branch]
2023-02-24 03:57:54 -05:00
patrick boutot
fb31ea2d89 MVVM: Test if the properties or functions are allowed at compile time.
#jira UE-164316
#preflight 63eaf47eb91ae11c1cf4ded7, 63ece0c9514832b242a0f66b

[CL 24289488 by patrick boutot in ue5-main branch]
2023-02-17 15:28:46 -05:00
patrick boutot
2758a900b9 MVVM: Rename ViewModelResolver to ViewModelContextResolver
#jira UE-171160
#preflight 63e67449bd38b4c5cbe7374e

[CL 24136977 by patrick boutot in ue5-main branch]
2023-02-11 12:38:02 -05:00