412 Commits

Author SHA1 Message Date
helen yang
ad6852bbc5 Fix ensure when adding a MetaSound input/output node with an invalid data type using the Builder API
#rb rob.gay
#jira UE-192570

[CL 27053069 by helen yang in 5.3 branch]
2023-08-11 19:43:43 -04:00
Rob Gay
4a29925129 - Remove --> RemoveSwap delegates to allow for handlers to not duplicate forwarded messages where applicable
- Refactor remove node handler for transactor to not do swap piecemeal, which was resulting in dropped connections
- Add test for adding/removing nodes while auditioning (excercises add/remove edges by extension)
#rb phil.popp
#rnx
#jira UE-191865

[CL 26888573 by Rob Gay in 5.3 branch]
2023-08-07 12:58:06 -04:00
phil popp
87c3c7fb52 Fix for bindinputs failuer on metasound send node.
#jira UE-189224

[CL 26860650 by phil popp in 5.3 branch]
2023-08-04 16:38:22 -04:00
Rob Gay
3b5c8cc728 Fix unity: missing headers
#rb trivial
#jira none
#rnx

[CL 26786317 by Rob Gay in 5.3 branch]
2023-08-02 16:22:03 -04:00
Rob Gay
b6a49e7924 - Guard against re-initialization of MetaSound doc caches double registering delegate notifiers (happens when clearing a graph)
- Fix copy/pasta in guard against attempting to add output twice (was checking existence of matching input name)
#rb phil.popp
#jira UE-191151
#rnx

[CL 26781550 by Rob Gay in 5.3 branch]
2023-08-02 14:33:50 -04:00
phil popp
9b14ead0e9 Fix for VaraibleNode test warnings in automation tests
#jira UE-190890
#rnx
#rb Helen.Yang

[CL 26780473 by phil popp in 5.3 branch]
2023-08-02 14:11:40 -04:00
phil popp
60af6e07bc Fixing audio pops when connecting/disconnecting audio in dynamic metasound
#jira UE-190802
#rb Rob.Gay

[CL 26775722 by phil popp in 5.3 branch]
2023-08-02 12:08:53 -04:00
helen yang
4bd7868eec Fix MetaSound search engine class query retaining deleted assets
#jira UE-190795
#rb phil.popp

[CL 26748968 by helen yang in 5.3 branch]
2023-08-01 14:55:58 -04:00
Rob Gay
08fb2fe474 Fix for overlapping input/output boxes introduced by earlier CL
#rb trivial
#jira UE-191505
#rnx

[CL 26721607 by Rob Gay in 5.3 branch]
2023-07-31 17:21:19 -04:00
Rob Gay
7466c13388 - Add ability to set node position explicitly via MetaSound Editor Subsystem
- Fix bug introduced recently with BuildToAsset not applying a clean class name/guid
- Fix case where builder was added to root and not freed
- MetaSoundEditorSubsystem minor clean-up
#rb helen.yang
#jira UE-191435 UE-191505
#rnx

[CL 26714951 by Rob Gay in 5.3 branch]
2023-07-31 14:21:10 -04:00
Rob Gay
053a214231 - Make Connect... MetaSoundBuilderSubsystem API calls replace edges as needed to parallel editor behavior more
- Update MetaSoundFrontendDocumentBuilder AddEdge... API calls to support both replacement and ignoring invalid requests where applicable
#rb phil.popp
#jira UE-190989

[CL 26659820 by Rob Gay in 5.3 branch]
2023-07-27 18:35:37 -04:00
nicholas howe
6bbf92e9b0 Metasound FDataTypeRegistry::IsValidUObjectForDataType uses GetSuperClass instead of GetOwnerClass when traversing class hierarchy and checks bIsExplicit.
#rb @rob.gay
#jira FORT-633885

Merging

//UE5/Main/Engine/Plugins/Runtime/Metasound/Source/...

to //UE5/Release-5.3/Engine/Plugins/Runtime/Metasound/Source/...

[CL 26620477 by nicholas howe in 5.3 branch]
2023-07-26 16:38:03 -04:00
rob gay
b086e2218f Enable nulling out object parameters/proxies from BP/game thread transmitter requests.
#rb phil.popp
#rnx
#fyi buzz.burrows
#p4v-cherrypick 26490829

[CL 26558324 by rob gay in 5.3 branch]
2023-07-24 18:29:31 -04:00
Rob Gay
e19b76c22a Fix for MetaSound transaction stack manipulation not updating builder caches if builder is associated with edited object/asset & edge cache not initializing properly
#rb phil.popp
#jira UE-190358

[CL 26556826 by Rob Gay in 5.3 branch]
2023-07-24 17:35:47 -04:00
helen yang
9f86aabdd1 Fix ensures with empty MetaSound object literals
#jira UE-189035
#jira UE-189600
#rb rob.gay

[CL 26552896 by helen yang in 5.3 branch]
2023-07-24 15:39:14 -04:00
phil popp
018659facd Fix MetaSound binding issues on oscillator and noise nodes
Fix crash in array random get node during automated stress tests for metasounds.
#jira UE-187400, UE-187402, UE-189191, UE-189190
#rnx
#rb Jimmy.Smith

[CL 26513830 by phil popp in 5.3 branch]
2023-07-21 11:38:26 -04:00
rob gay
7e914cb0f5 Fix for nametable/MetaSound Search Engine entry leaks due to new class name being generated on every builder build/audition call associated with a given target object
#rb todo
#jira UE-190590
#rnx
#p4v-cherrypick 26471782

[CL 26493827 by rob gay in 5.3 branch]
2023-07-20 15:51:29 -04:00
rob gay
3bcd69f01b Add missing forward of early return value causing false negative when attempting to add MetaSound Interface via Builder API
#rb trivial
#jira UE-190478
#fyi sondra.moyls
#p4v-cherrypick 26443241

[CL 26493726 by rob gay in 5.3 branch]
2023-07-20 15:45:25 -04:00
helen yang
5f5bdbf7aa Fix ensures when migrating MetaSound assets
- Create new class names for temporary packages created during migration to avoid duplicate node registration
- Change duplicate node registration ensure to if check with better logging of asset causing collision

#jira UE-161039
#jira UE-175059
#jira UE-188854
#rb rob.gay

[CL 26299112 by helen yang in 5.3 branch]
2023-06-28 17:05:14 -04:00
Rob Gay
bf790a161b - Fix for inconsistent delegate implementation for MetaSound input/output removal
- Add tests for matching node/graph inputs & outputs
#rb trivial
#jira UE-189613
#rnx

[CL 26273511 by Rob Gay in 5.3 branch]
2023-06-27 18:17:55 -04:00
Rob Gay
65f5c26b30 Fix for reducing channel count to output interface other than mono (and other ways in which interfaces were potentially swapping related API members)
#rb trivial
#jira UE-189613
#rnx

[CL 26248823 by Rob Gay in 5.3 branch]
2023-06-26 19:28:06 -04:00
Rob Gay
429fc0618b Missing part of earlier MetaSound builder cache corruption fix
#rb trivial
#rnx
#jira UE-189434

[CL 26242599 by Rob Gay in 5.3 branch]
2023-06-26 15:46:23 -04:00
Rob Gay
329fb2c898 Fix ConnectNode<In/Out>sToMatchingGraphInterface<In/Out>puts
- Add tests for connecting & disconnecting nodes that match graph interfaces
- Rename test accordingly
#rnx
#jira UE-186188
#rb helen.yang

[CL 26242420 by Rob Gay in 5.3 branch]
2023-06-26 15:40:12 -04:00
phil popp
f74ae5a0b9 Fix dynamic transactor missing node.
#jira UE-189289
#rnx
#rb Rob.Gay

[CL 26214256 by phil popp in 5.3 branch]
2023-06-23 14:17:18 -04:00
Rob Gay
ffdd4391f0 - Added test for binding interfaces & fixed following fallout
Major:
- Added missing input MetaSound audio interfaces
- Fixed interface bindings not working with referenced transient, non-asset MetaSounds

Minor:
- Fix builder name not being propagated to transient builders
- Fix not defaulting to success enum when creating patch builder
- Generalized pool of named/registered builders on Builder Subsystem instead of having them per type (to support future types without having to update the subystem for each additional future type.)
#rb helen.yang
#jira todo

[CL 26189337 by Rob Gay in 5.3 branch]
2023-06-22 14:43:52 -04:00