48 Commits

Author SHA1 Message Date
Rob Gay
4e8111273c Fix comment with unacceptable word
#rb helen.yang
#jira
#rnx
#lockdown julien.marchand

[CL 26977471 by Rob Gay in 5.3 branch]
2023-08-09 18:54:57 -04:00
Rob Gay
af9396d4ba - Fix for auditioning the same sound multiple times not respecting live updates on additional calls
- Upgrade Live Node Update automation tests to LiveUpdateMultipleMetaSoundSources for more comprehensive coverage
#rb helen.yang
#jira UE-192099
#rnx
#lockdown julien.marchand

[CL 26968567 by Rob Gay in 5.3 branch]
2023-08-09 15:32:55 -04:00
Rob Gay
4a29925129 - Remove --> RemoveSwap delegates to allow for handlers to not duplicate forwarded messages where applicable
- Refactor remove node handler for transactor to not do swap piecemeal, which was resulting in dropped connections
- Add test for adding/removing nodes while auditioning (excercises add/remove edges by extension)
#rb phil.popp
#rnx
#jira UE-191865

[CL 26888573 by Rob Gay in 5.3 branch]
2023-08-07 12:58:06 -04:00
Rob Gay
053a214231 - Make Connect... MetaSoundBuilderSubsystem API calls replace edges as needed to parallel editor behavior more
- Update MetaSoundFrontendDocumentBuilder AddEdge... API calls to support both replacement and ignoring invalid requests where applicable
#rb phil.popp
#jira UE-190989

[CL 26659820 by Rob Gay in 5.3 branch]
2023-07-27 18:35:37 -04:00
Rob Gay
3563bfcbd6 Conform test component initialization in MetaSound Engine Tests & fix false negative error in case where component is built with invalid initial state of built sound.
#rb trivial
#jira UE-190758
#rnx

[CL 26577875 by Rob Gay in 5.3 branch]
2023-07-25 12:33:23 -04:00
Rob Gay
d7c6069194 Fix-up false negative in MetaSound engine test(s)
#rb trivial
#jira UE-190758 UE-190759
#rnx

[CL 26560065 by Rob Gay in 5.3 branch]
2023-07-24 20:06:34 -04:00
rob gay
7e914cb0f5 Fix for nametable/MetaSound Search Engine entry leaks due to new class name being generated on every builder build/audition call associated with a given target object
#rb todo
#jira UE-190590
#rnx
#p4v-cherrypick 26471782

[CL 26493827 by rob gay in 5.3 branch]
2023-07-20 15:51:29 -04:00
rob gay
3bcd69f01b Add missing forward of early return value causing false negative when attempting to add MetaSound Interface via Builder API
#rb trivial
#jira UE-190478
#fyi sondra.moyls
#p4v-cherrypick 26443241

[CL 26493726 by rob gay in 5.3 branch]
2023-07-20 15:45:25 -04:00
phil popp
7cf867de88 Fix for disconnecting MetaSound node using builder API does not update output
#jira UE-189292
#rb Rob.Gay

[CL 26444445 by phil popp in 5.3 branch]
2023-07-18 15:59:17 -04:00
Rob Gay
bf790a161b - Fix for inconsistent delegate implementation for MetaSound input/output removal
- Add tests for matching node/graph inputs & outputs
#rb trivial
#jira UE-189613
#rnx

[CL 26273511 by Rob Gay in 5.3 branch]
2023-06-27 18:17:55 -04:00
Rob Gay
329fb2c898 Fix ConnectNode<In/Out>sToMatchingGraphInterface<In/Out>puts
- Add tests for connecting & disconnecting nodes that match graph interfaces
- Rename test accordingly
#rnx
#jira UE-186188
#rb helen.yang

[CL 26242420 by Rob Gay in 5.3 branch]
2023-06-26 15:40:12 -04:00
Rob Gay
ffdd4391f0 - Added test for binding interfaces & fixed following fallout
Major:
- Added missing input MetaSound audio interfaces
- Fixed interface bindings not working with referenced transient, non-asset MetaSounds

Minor:
- Fix builder name not being propagated to transient builders
- Fix not defaulting to success enum when creating patch builder
- Generalized pool of named/registered builders on Builder Subsystem instead of having them per type (to support future types without having to update the subystem for each additional future type.)
#rb helen.yang
#jira todo

[CL 26189337 by Rob Gay in 5.3 branch]
2023-06-22 14:43:52 -04:00
Rob Gay
aa51d6ab5d - Fix-up MetaSound dynamic builder engine tests
- Add missing move of transactor to generator init params

#rb Phil.Popp
#jira UE-181889
#rnx

[CL 26128465 by Rob Gay in 5.3 branch]
2023-06-20 13:58:22 -04:00
rob gay
48b172ac25 Initial work to pipe builder updates to dynamic graph
- Add delegates to respond to builder changes to document
- Add delegate handlers to source builder to forward requests to audition sound if live update enabled
- Misc piping for live updating
#jira UE-186952
#ok forgithub public
#rb phil.popp

[CL 26072716 by rob gay in 5.3 branch]
2023-06-16 17:55:08 -04:00
jake burga
7791a8f04a Add ability to define a custom name for connected input/output nodes
cleanup some java-docs

#rb charlie.huguenard
[REVIEW] [at]charlie.huguenard [at]phil.popp [at]buzz.burrowes

[CL 25797498 by jake burga in ue5-main branch]
2023-06-05 13:42:51 -04:00
phil popp
f044d2accf CIS Fix for IsAudioMixerEnabled in metasound engine test
#rb trivial
#preflight skip

[CL 25690543 by phil popp in ue5-main branch]
2023-05-30 17:37:33 -04:00
phil popp
4aeebe19ee Automated MetaSound node tests for rebind.
#jira UE-186627
#rb Maxwell.Hayes
#preflight 64763f004b1ead7c7f2a2ee9

[CL 25688935 by phil popp in ue5-main branch]
2023-05-30 17:07:23 -04:00
jake burga
70f0eedf71 Move Graph builder helper functions to NodeTestGraphBuilder
Fix up some test checks in MetronomeNodeTests
- more comprehensive tests in MetronomedNodeTests
- Test a range of Tempos and Time Signatures

[REVIEW] [at]charlie.huguenard [at]buzz.burrowes [at]phil.popp
#preflight 647619f4d8097b4382d66eba
#rb charlie.huguenard

[CL 25682772 by jake burga in ue5-main branch]
2023-05-30 14:25:18 -04:00
phil popp
dd8874c739 Metasound Rebindable Graph Operator
- Added Metasound::FRebindableGraphOperator
- Modified FOperatorBuilder to build either FGraphOperator or FRebindableGraphOperator
- Various API updates and fix-ups to support aforementioned changes.
#jira UE-184987
#rb Maxwell.Hayes
#preflight 6463ab60317ee2d9d1b37655

[CL 25496057 by phil popp in ue5-main branch]
2023-05-16 16:02:58 -04:00
jason weiler
ad3b95a556 [Metasound] Build fix - missing variable capture in a lambda definition
[FYI] [at]charlie.huguenard
#preflight 64527354d863ba262120c4e0

[CL 25323472 by jason weiler in ue5-main branch]
2023-05-03 15:37:25 -04:00
charlie huguenard
7b12ccaeae [Metasound] Get history of output changes instead of last value
#preflight 64513fbb4d593c0b42b03cc8
#rb phil.popp

[CL 25320519 by charlie huguenard in ue5-main branch]
2023-05-03 13:43:51 -04:00
charlie huguenard
62ba6250c5 [Metasound] Support constructor pins in test graph builder
#preflight 6451233ac86798f650b6d816
#rb simon.yan

[CL 25309515 by charlie huguenard in ue5-main branch]
2023-05-02 18:18:27 -04:00
phil popp
337d5f3cfb Add more tests for metasound automated node tests
#jira UE-179002
#rb Rob.Gay
#preflight 6446a343641e2c3cb4a6af03

[CL 25175153 by phil popp in ue5-main branch]
2023-04-24 23:05:42 -04:00
Aaron McLeran
70e7c3734f Removing many vestigates of old audio engine code.
#rb Ryan.Mangin
#jira UE-144348
#preflight 6446e9d30206a6e20f49f2e7

[CL 25172786 by Aaron McLeran in ue5-main branch]
2023-04-24 18:22:37 -04:00
charlie huguenard
55777a0917 [Metasound] Use generators for node tests and fix up tests.
#rb phil.popp, jake.burga, simon.yan
#preflight 64307638b4329f6f1a401afc

[CL 24976780 by charlie huguenard in ue5-main branch]
2023-04-10 09:26:19 -04:00