9 Commits

Author SHA1 Message Date
phil popp
7cf867de88 Fix for disconnecting MetaSound node using builder API does not update output
#jira UE-189292
#rb Rob.Gay

[CL 26444445 by phil popp in 5.3 branch]
2023-07-18 15:59:17 -04:00
charlie huguenard
657def06c3 [Metasound] Fix race which would sometimes cause generator handles to stop receiving output updates from generators.
While the "thread-safe" variety of delegates does protect the invocation list from data races, if you use AddUObject, it will end up calling TWeakObjectPtr::Get() when it attempts to compact the invocation list (as it does when broadcasting or adding), which as far as I can tell is not thread-safe. This means it can sometimes incorrectly report that the object is no longer valid and should be removed from the invocation list.

#rnx
#rb phil.popp
#preflight 645beeb9ab621cb7013043a9

[CL 25429370 by charlie huguenard in ue5-main branch]
2023-05-11 12:18:34 -04:00
buzz burrowes
46600099fa Merge conflict reolution (by hand)
[CL 25418491 by buzz burrowes in ue5-main branch]
2023-05-10 18:10:35 -04:00
charlie huguenard
7b12ccaeae [Metasound] Get history of output changes instead of last value
#preflight 64513fbb4d593c0b42b03cc8
#rb phil.popp

[CL 25320519 by charlie huguenard in ue5-main branch]
2023-05-03 13:43:51 -04:00
charlie huguenard
fb1959d641 [Metasound] Fix races in UMetasoundOutputSubsystem
The generator created/destroyed events get called on the audio thread, so avoid manipulating containers used on the game thread in the event.

#rnx
#rb phil.popp, aaron.mcleran
#preflight 642db4d71d19c0312a39ab12

[CL 24937556 by charlie huguenard in ue5-main branch]
2023-04-05 17:42:36 -04:00
buzz burrowes
93831837d9 Namespace the names of the multicast delegate definitions (move them into the class definition) to avoid polluting the global namespace.
[REVIEW] [at]phil.popp [at]charlie.huguenard
#preflight 642b2a92ce01db47acc4bf9b

[CL 24906544 by buzz burrowes in ue5-main branch]
2023-04-03 23:31:26 -04:00
marc audy
4cbcbd309d Add delegates for when the MusicClockComponent connects and disconnects from an underling MidiClock in the associated metasound.
[REVIEW] [at]kevin.cavanaugh [at]aaron.mcleran [at]max.hayes
#preflight 642b13501d19c0312a597334

[CL 24906530 by marc audy in ue5-main branch]
2023-04-03 23:30:36 -04:00
buzz burrowes
fb48d94232 MusicClockComponent & MusicTempometerComponent for the new Harmonix plugin. Includes massive refactor for Measure -> Bar and Pulse -> Beat.
[REVIEW] [at]nicholas.howe [at]jake.burga
#preflight 6418998932723d4a20488334

[CL 24724583 by buzz burrowes in ue5-main branch]
2023-03-20 17:38:24 -04:00
buzz burrowes
6a343186d8 MetasoundParameterPack V1
[REVIEW] [at]phil.popp [at]rob.gay [at]aaron.mcleran
#preflight 639b5db4012902cb8d76c448

[CL 23532613 by buzz burrowes in ue5-main branch]
2022-12-15 17:03:02 -05:00