339 Commits

Author SHA1 Message Date
phil popp
c3415402a7 Audio unit test build fixes
#jira UE-193300
#lockdown julien.marchand
#rb rob.guay

[CL 27186108 by phil popp in 5.3 branch]
2023-08-17 17:19:56 -04:00
Rob Gay
a883eee8cc - Fix for crash when attempting to add graph input to MetaSound while auditioning builder from BP
- Fix for ensure if DataType provided to add graph input/output MetaSound Builder is invalid
#rb phil.popp
#jira UE-192614
#rnx

[CL 27158677 by Rob Gay in 5.3 branch]
2023-08-16 18:30:52 -04:00
Rob Gay
629572a7f9 Fix for MetaSound live update failing to create & forward input/output (and other currently unsupported types like variable) nodes to transactor
#rb phil.popp
#jira UE-192623
#jira UE-192614
#rnx

[CL 27117346 by Rob Gay in 5.3 branch]
2023-08-15 15:56:36 -04:00
Rob Gay
af9396d4ba - Fix for auditioning the same sound multiple times not respecting live updates on additional calls
- Upgrade Live Node Update automation tests to LiveUpdateMultipleMetaSoundSources for more comprehensive coverage
#rb helen.yang
#jira UE-192099
#rnx
#lockdown julien.marchand

[CL 26968567 by Rob Gay in 5.3 branch]
2023-08-09 15:32:55 -04:00
Rob Gay
45ec420b40 Clean-up reporting when gathering referenced assets to avoid warnings of asset registry not being loaded when its not necessary to be.
#rb helen.yang
#jira UE-189745
#rnx

[CL 26898912 by Rob Gay in 5.3 branch]
2023-08-07 16:58:38 -04:00
Rob Gay
4a29925129 - Remove --> RemoveSwap delegates to allow for handlers to not duplicate forwarded messages where applicable
- Refactor remove node handler for transactor to not do swap piecemeal, which was resulting in dropped connections
- Add test for adding/removing nodes while auditioning (excercises add/remove edges by extension)
#rb phil.popp
#rnx
#jira UE-191865

[CL 26888573 by Rob Gay in 5.3 branch]
2023-08-07 12:58:06 -04:00
Rob Gay
53471e7fee Add/clean-up missing or improper category identifiers on MetaSound node classes
- Make Wave Writer/Players follow alphabetical expectation to avoid most used implementations (mono/stereo) from being at bottom of node picker list
#rb maxwell.hayes
#jira UE-191837
#rnx

[CL 26781826 by Rob Gay in 5.3 branch]
2023-08-02 14:38:51 -04:00
Rob Gay
3f3ee5654e - Fix for missing detach in PostOutputFormatChange case where persistent builder was registered when system is not ready for this (changes could be made by controllers behind the back of the builder system, snuck in from controller mutation delegate notification change)
- Fix crash if attempting to Create<Patch/Source>PresetBuilder with null script interface ref
- Misc clean-up
#rb phil.popp
#rnx
#jira UE-191633

[CL 26781330 by Rob Gay in 5.3 branch]
2023-08-02 14:29:01 -04:00
phil popp
369c389f99 Fix for dynamic metasounds not updating when disconnecting by interface bindings.
#jira UE-191433
#rb Max.Hayes, Rob.Gay

[CL 26775453 by phil popp in 5.3 branch]
2023-08-02 12:03:07 -04:00
Rob Gay
7466c13388 - Add ability to set node position explicitly via MetaSound Editor Subsystem
- Fix bug introduced recently with BuildToAsset not applying a clean class name/guid
- Fix case where builder was added to root and not freed
- MetaSoundEditorSubsystem minor clean-up
#rb helen.yang
#jira UE-191435 UE-191505
#rnx

[CL 26714951 by Rob Gay in 5.3 branch]
2023-07-31 14:21:10 -04:00
Rob Gay
a4da8a570d Only audition literal update if no edge is already set.
#rb phil.popp
#jira UE-191434
#rnx

[CL 26686276 by Rob Gay in 5.3 branch]
2023-07-28 16:20:02 -04:00
Rob Gay
053a214231 - Make Connect... MetaSoundBuilderSubsystem API calls replace edges as needed to parallel editor behavior more
- Update MetaSoundFrontendDocumentBuilder AddEdge... API calls to support both replacement and ignoring invalid requests where applicable
#rb phil.popp
#jira UE-190989

[CL 26659820 by Rob Gay in 5.3 branch]
2023-07-27 18:35:37 -04:00
nicholas howe
6bbf92e9b0 Metasound FDataTypeRegistry::IsValidUObjectForDataType uses GetSuperClass instead of GetOwnerClass when traversing class hierarchy and checks bIsExplicit.
#rb @rob.gay
#jira FORT-633885

Merging

//UE5/Main/Engine/Plugins/Runtime/Metasound/Source/...

to //UE5/Release-5.3/Engine/Plugins/Runtime/Metasound/Source/...

[CL 26620477 by nicholas howe in 5.3 branch]
2023-07-26 16:38:03 -04:00
Rob Gay
5bd9cc220e Nuke temporary cvar for disabling MetaSound Builder audition live updates
#rb trivial
#jira none
#rnx
#fyi phil.popp
#fyi buzz.burrows

[CL 26559644 by Rob Gay in 5.3 branch]
2023-07-24 19:49:03 -04:00
Rob Gay
b05b773e01 Fix for incorrect element type being used from earlier change to support null object ptr passing to MetaSound parameter system
#rb trivial
#jira UE-190979
#rnx

[CL 26559300 by Rob Gay in 5.3 branch]
2023-07-24 19:28:06 -04:00
rob gay
b086e2218f Enable nulling out object parameters/proxies from BP/game thread transmitter requests.
#rb phil.popp
#rnx
#fyi buzz.burrows
#p4v-cherrypick 26490829

[CL 26558324 by rob gay in 5.3 branch]
2023-07-24 18:29:31 -04:00
Rob Gay
e19b76c22a Fix for MetaSound transaction stack manipulation not updating builder caches if builder is associated with edited object/asset & edge cache not initializing properly
#rb phil.popp
#jira UE-190358

[CL 26556826 by Rob Gay in 5.3 branch]
2023-07-24 17:35:47 -04:00
rob gay
7e914cb0f5 Fix for nametable/MetaSound Search Engine entry leaks due to new class name being generated on every builder build/audition call associated with a given target object
#rb todo
#jira UE-190590
#rnx
#p4v-cherrypick 26471782

[CL 26493827 by rob gay in 5.3 branch]
2023-07-20 15:51:29 -04:00
phil popp
7cf867de88 Fix for disconnecting MetaSound node using builder API does not update output
#jira UE-189292
#rb Rob.Gay

[CL 26444445 by phil popp in 5.3 branch]
2023-07-18 15:59:17 -04:00
helen yang
5f5bdbf7aa Fix ensures when migrating MetaSound assets
- Create new class names for temporary packages created during migration to avoid duplicate node registration
- Change duplicate node registration ensure to if check with better logging of asset causing collision

#jira UE-161039
#jira UE-175059
#jira UE-188854
#rb rob.gay

[CL 26299112 by helen yang in 5.3 branch]
2023-06-28 17:05:14 -04:00
maxwell hayes
c7a6074901 [Metasounds] Bind Inputs / Outputs follow up (Automated Test Fixes)
#jira UE-187393, UE-187390, UE-189226, UE-187397
#rb Phil.Popp

[CL 26273662 by maxwell hayes in 5.3 branch]
2023-06-27 18:22:44 -04:00
Rob Gay
329fb2c898 Fix ConnectNode<In/Out>sToMatchingGraphInterface<In/Out>puts
- Add tests for connecting & disconnecting nodes that match graph interfaces
- Rename test accordingly
#rnx
#jira UE-186188
#rb helen.yang

[CL 26242420 by Rob Gay in 5.3 branch]
2023-06-26 15:40:12 -04:00
phil popp
f74ae5a0b9 Fix dynamic transactor missing node.
#jira UE-189289
#rnx
#rb Rob.Gay

[CL 26214256 by phil popp in 5.3 branch]
2023-06-23 14:17:18 -04:00
Rob Gay
ffdd4391f0 - Added test for binding interfaces & fixed following fallout
Major:
- Added missing input MetaSound audio interfaces
- Fixed interface bindings not working with referenced transient, non-asset MetaSounds

Minor:
- Fix builder name not being propagated to transient builders
- Fix not defaulting to success enum when creating patch builder
- Generalized pool of named/registered builders on Builder Subsystem instead of having them per type (to support future types without having to update the subystem for each additional future type.)
#rb helen.yang
#jira todo

[CL 26189337 by Rob Gay in 5.3 branch]
2023-06-22 14:43:52 -04:00
Maxwell Hayes
e3f3080c14 [Metasounds] Follow up fixes for new BindInputs/ BindOutputs API.
#jira UE-189241
#rb none
#fyi Chris.Ritter

[CL 26157427 by Maxwell Hayes in 5.3 branch]
2023-06-21 14:58:56 -04:00