1605 Commits

Author SHA1 Message Date
calvin zheng
e984cb141a Fix for NavigateToFunctionSource crash/error, use xcode built in atos instead of UnrealAtoS as it can't handle universal build.
#jira UE-195221
#rb Josh.Adams, Zack.Neyland

[CL 28758868 by calvin zheng in 5.3 branch]
2023-10-13 13:13:54 -04:00
Josh Adams
eb3569c187 - Fixed various blocking issues with making Mac/IOS builds that can be uploaded to AppStore in Xcode
* Missing ThinApp.sh
  * Missing some quotes around a variable in GenerateUniversalDSYM.sh
  * Correctly filter out the stub .app's and such when copying the Staged data directory into the .app
  * Disabled the Mac's Sign To Run Locally option by default, as that causes Xcode's Validation/Upload to not have the team name embedded in it, causing a hassle while pushing up to AppStore/TestFlight
  * Fixed the PRODUCT_NAME for BP projects
  * Made CrashReportClient be a sandboxed app that inherits from parent
  * Fix Hybrid apps to check all platforms before in the project generator, so that if a project needs a temp target for IOS (via a plugin)
  * Disabled the LoginFlow module from OnlineFramework plugin - this was causing issues with having CEF and EpicWebHelper embedded into a sandboxed .app, and LoginFlow isn't seemingly actually used by anything
  * Set the no-encryption setting in the template Mac plist to make uploading to TestFlight/AppStore easier
  * Fixed editor to not compile as universal when using -distribution, only the client should be universal
  * Further improvements to stripping out nested .app's in a final .app (remove them from the staged directory helps)
  * Changed how the Mac app name is displayed, since the .app name itself is shown in the Finder,  unlike IOS where the CFBundleName is shown (the archived .app name in the .xcarchive is named by a project setting, falling back to the .uproject name if not set)
  * Disabled the SignExecutables function on Modern because they attempt to sign the wrong .apps, and one is no longer (previously it was uselessly signing .apps, but now it throws an error due to changes for the third item in this list)
  * Legacy Xcode mode is forced with Window's Remote Mac builds, so use the old legacy code when running under windows
  * Added a third party .cpp file to get copied to remote macs
  * Fix Tools -> Open Xcode not working with modern Xcode

#jira UE-197465

[CL 28723100 by Josh Adams in 5.3 branch]
2023-10-12 15:15:43 -04:00
jason walter
5445c54ded When invoking the OpenAssetInEditor ensure we are referring to the level sequence object and not the pending take.
#jira UE-195863
#rb zach.brockway

#ushell-cherrypick of 27964820 by jason.walter

[CL 28049449 by jason walter in 5.3 branch]
2023-09-20 15:03:54 -04:00
jason walter
c3b95c4b47 Check that we have serialized data prior to reading CreationMethod data.
#jira UE-194924
#rb jamie.dale

#ushell-cherrypick of 27649318 by jason.walter

[CL 27917280 by jason walter in 5.3 branch]
2023-09-15 11:35:32 -04:00
valentin ritzi
da915f9486 [Concert] Adding required QuicServer command line arguments when starting MultiUserSlateServer
#jira UE-192522
#rb dominik.peacock, manuel.lang, stuart.hill
#lockdown jason.walter

[CL 27072057 by valentin ritzi in 5.3 branch]
2023-08-14 11:43:10 -04:00
jason walter
bd21a9b810 Add an exclusion list to exlude certain properties that should not be included in a Multi-user transaction. This will prevent trying to re-create an abstract class on a nDisplay instance thus crashing.
#jira UE-192567
#rb zach.brockway
#lockdown mitchell.wilson

[CL 27038159 by jason walter in 5.3 branch]
2023-08-11 14:34:37 -04:00
marc audy
800d5cd2ac Fix Mac/iOS non-unity
#horde 347422
#jira
#rnx

[CL 27022185 by marc audy in 5.3 branch]
2023-08-11 00:03:56 -04:00
valentin ritzi
6737096f3a [Concert] Modifying ConcertSyncServer transport plugin check
Modifying the ConcertSyncServer transport plugin check to shutdown if neither of the two supported plugins UdpMessaging/QuicMessaging is available.

#jira none
#rb jason.walter, stuart.hill, federico.lopez

[CL 26768628 by valentin ritzi in 5.3 branch]
2023-08-02 08:07:32 -04:00
Joe Kirchoff
2b5b64c59f Remove marketplace url causing build issues
#rnx
#jira UE-191567

[CL 26744755 by Joe Kirchoff in 5.3 branch]
2023-08-01 13:09:43 -04:00
BenVlodgi
eae605d259 GitHub #10551: Fix PropertyAccess Crash when used in child AnimBP
Slightly modified from the original PR to add a reasoning comment and fallback error in case we are somehow not in a child anim BP context

#jira UE-189057
#rb Nicholas.Frechette

[CL 26704604 by BenVlodgi in 5.3 branch]
2023-07-31 09:42:07 -04:00
jason walter
0a525a9a3a Fix crash on -game instances when loading the pending take.
#jira UE-191397
#rb none
#rnx

[CL 26671686 by jason walter in 5.3 branch]
2023-07-28 09:26:31 -04:00
jason walter
c883336660 Fix ensure during leaving MU session.
#jira UE-191310
#rb none
#rnx

[CL 26641945 by jason walter in 5.3 branch]
2023-07-27 11:30:27 -04:00
jason walter
bf83992e2c Cloase all open sequencers opened during a Multi-user session.
#jira UE-180324
#rb none
#rnx

[CL 26618461 by jason walter in 5.3 branch]
2023-07-26 15:42:01 -04:00
jason walter
b8ea8e3e25 Add a scoped variable to control the call of FlushRenderingCommands() in ActorComponent. This causes some performance issues on -game instances. It is only disabled during snapshot transactions in Multi-user.
#jira UE-191134
#rb jamie.dale

[CL 26617622 by jason walter in 5.3 branch]
2023-07-26 15:18:08 -04:00
jason walter
0754f34376 Only call the base implementation to PreEditChange() when in -game nodes to prevent FlushRenderingCommands(). This is only for interactive changes.
#jira UE-191134
#rb francis.hurteau, jamie.dale

[CL 26611204 by jason walter in 5.3 branch]
2023-07-26 12:41:58 -04:00
jason walter
395e50c912 Only serialize our nested object flag when we are running the reader/writer in those modes.
#rb rex.hill

[CL 26573176 by jason walter in 5.3 branch]
2023-07-25 10:33:41 -04:00
Martin Sevigny
eced9128d9 Add ShortName to ConcertSharedSlate.
#rb trivial
#fyi marc.audy

[CL 26522911 by Martin Sevigny in 5.3 branch]
2023-07-21 15:39:14 -04:00
jason walter
2335dfecfa Fix deferencing nullptr found by static analysis.
#jira UE-174790
#rb none
#rnx

[CL 26502219 by jason walter in 5.3 branch]
2023-07-20 20:37:24 -04:00
jason walter
300868b2cc Check for nullptr before attempting to save the layout.
#jira UE-190547
#rb none
#rnx

[CL 26492452 by jason walter in 5.3 branch]
2023-07-20 15:03:57 -04:00
jason walter
db00880a54 Serialize pending take data and send it over the wire when users open the pending take. This allows users to capture uses of level sequences that were opened in Take Recorder.
#jira UE-174790
#rb dominik.peacock
#rnx

[CL 26487850 by jason walter in 5.3 branch]
2023-07-20 11:59:29 -04:00
Martin Sevigny
3686eae71a Add a ShortName to modules that generated paths over the 200 chars limit and a few modules that were realy close (198+)
#rb Joe.Kirchoff
#jira none

[CL 26461049 by Martin Sevigny in 5.3 branch]
2023-07-19 10:58:57 -04:00
robert millar
094ab3eddf Optimize FPerforceGetPendingChangelistsWorker when getting files for all changelists by executing a single 'opened' command and parsing the results.
Speeds up query from 20+s to around 1.5s in an example workspace with 54 changelists.

#rb brooke.hubert

[CL 26294240 by robert millar in 5.3 branch]
2023-06-28 14:52:20 -04:00
joe kirchoff
623cf44a98 When opening code in a solution also check any running instances of Visual Studio to find the best solution to use
#rnx
#jira UE-188820

[CL 26239648 by joe kirchoff in 5.3 branch]
2023-06-26 14:30:56 -04:00
DecoyRS
d5f499080b PR #10511: Fix rsca for toolbox 2 0
#jira UE-188056

[CL 26214205 by DecoyRS in 5.3 branch]
2023-06-23 14:13:43 -04:00
valentin ritzi
63f6a62f18 [Concert] Adapting ConcertSyncServer / UnrealMultiUserServer to work with QuicMessaging
Adapting the ConcertSyncServer and the UnrealMultiUserServer configs and code to work with QuicMessaging as an alternative to UdpMessaging.

#jira UCS-7220
#rb jason.walter, manuel.lang
#review-26052126

[CL 26176638 by valentin ritzi in 5.3 branch]
2023-06-22 04:20:52 -04:00