26 Commits

Author SHA1 Message Date
Rolando Caloca
aa0d2303d6 Copying //UE4/Dev-Rendering to Dev-Main (//UE4/Dev-Main) @ 6944469
#rb none
#rnx

[CL 6944849 by Rolando Caloca in Main branch]
2019-06-11 18:27:07 -04:00
johan berg
45fe0d7d31 Generating stable shader info is now configurable.
Shader code library was always emitting "<shadermodel>.scl.csv" files while cooking. This output data is only needed for users (or automated jobs) that update the PSO cache. With this change the configuration value "NeedsShaderStableKeys" needs to be set to true for platforms that use PSO (e.g. AndroidEngine.ini and  IOSEngine.ini).

This saves diskspace and around 90 seconds on a iterative cook on a large project.

#rb Dmitriy.Dyomin


#ROBOMERGE-SOURCE: CL 6604300 via CL 6604799
#ROBOMERGE-BOT: (v351-6581450)

[CL 6604833 by johan berg in Main branch]
2019-05-22 10:28:16 -04:00
michael trepka
d0529f3c65 Modified error handling code in ShaderCodeLibrary to display a message box telling players the game files are missing instead of crashing with fatal UE_LOG message.
#rb Chris.Bunner


#ROBOMERGE-SOURCE: CL 6446280 via CL 6446292 via CL 6447699

[CL 6447733 by michael trepka in Main branch]
2019-05-14 11:36:00 -04:00
ben woodhouse
644e6136c2 Add cvar to set IO priority for shader code library reads: r.ShaderCodeLibrary.DefaultAsyncIOPriority. Sometimes they are thrashing during uobject reads and causing seeks.
Setting is unchanged for now
[FYI] gil.gribb


#ROBOMERGE-SOURCE: CL 6417507 via CL 6418864 via CL 6418876 via CL 6418960

[CL 6418983 by ben woodhouse in Main branch]
2019-05-11 05:52:15 -04:00
peter sauerbrei
8a68393339 potential fix for PSO problems
#rb gil.gribb


#ROBOMERGE-SOURCE: CL 6195143 via CL 6195202 via CL 6196410

[CL 6196455 by peter sauerbrei in Main branch]
2019-05-01 17:01:12 -04:00
arciel rekman
666cb97676 Shader Library: use proper shader format names (UE-72416).
- Vulkan (and GL) can have variant names like _NOUB.

#rb Dmitriy.Dyomin
#jira UE-72416
[FYI] Marcin.Undak, Brandon.Schaefer
#lockdown Cristina.Riveron

#ROBOMERGE-SOURCE: CL 6011769 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 6011770 by arciel rekman in Main branch]
2019-04-19 09:03:39 -04:00
mark satterthwaite
1eebce443b Initial work to support creating additive 'patch' shader libraries from the metadata of two different cooked builds.
#rb none


#ROBOMERGE-SOURCE: CL 5929239 via CL 5933291

[CL 5933354 by mark satterthwaite in Main branch]
2019-04-16 19:30:02 -04:00
richard wallis
cd9c18700f Remove the error log (logging still reports internally) and report result back to higher level for it to decide if this is an error - we can not know at the engine level. Soften the language of some of the other internal fail messages to steer the thinking away from errors and more informational.
#rb michael.trepka


#ROBOMERGE-SOURCE: CL 5916504 via CL 5916508 via CL 5917359

[CL 5917425 by richard wallis in Main branch]
2019-04-16 11:54:47 -04:00
pj kack
da2a5e3d66 Back out integrated changelist 5586728 (5571078) to resubmit all cook -iterate optimizations implemented on //UE4/Dev-core/... (see 5533504)
New AssetRegistryState::InitializeFromExistingAndPrune temporarily disabled until some bugs have been fixed.

Test Scenario:
1) BuildCookStageAndRun with these arguments: -platform=Win64 -configuration=Development
2) CookIterate with these arguments: -run=Cook -CookCultures=en -TargetPlatform=WindowsClient -unversioned -stdout -unattended -iterate

Wall Time Results (as an average of running step 2) two times):
Before: ~09:40 (580 seconds) cook commandlet time
After: ~02:30 (150 seconds) cook commandlet time
=> 07:10 (430 seconds ) faster, i.e. a ~ 3.9x speedup

Win32 FileSystem Results:
Before: 1.5 million GetFileAttribute calls and 1.2 million FindNextFile calls
After: 35 0000 GetFileAttribute calls and 1.6 million FindNextFile calls
=> ~400 000 calls to FindNextFile replaces ~1.5 million calls to GetFileAttribute

#rb none


(peafour-cherrypick of //UE4/Dev-Core/[at]5645695 by PJ.Kack)


#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: pj.kack
#ROBOMERGE-SOURCE: CL 5533504 via CL 5533655 via CL 5536177 via CL 5772728 via CL 5772753

[CL 5772793 by pj kack in Main branch]
2019-04-08 01:19:56 -04:00
bob tellez
0ae7f9c6dd Back out changelist 5533504. Crash at startup on forking linux servers. (Missing referencer information)
#ROBOMERGE-SOURCE: CL 5571078 via CL 5572105

[CL 5572109 by bob tellez in Main branch]
2019-03-26 20:30:52 -04:00
bob tellez
f3febb7191 #UE4 Fix a copy error due to an open file handle in FEditorShaderStableInfo::Finalize. Also added some additional logging in case copy failures happen again in the future.
[FYI] Johan.Berg


#ROBOMERGE-SOURCE: CL 5550462 via CL 5550501

[CL 5550502 by bob tellez in Main branch]
2019-03-25 23:35:11 -04:00
pj kack
5bde52e113 Copying task stream Dev-cook to Main
Integrate all cook -iterate optimizations from //UE4/Dev-core/...

Test Scenario:
1) BuildCookStageAndRun with these arguments: -platform=Win64 -configuration=Development
2) CookIterate with these arguments: -run=Cook -CookCultures=en -TargetPlatform=WindowsClient -unversioned -stdout -unattended -iterate

Wall Time Results (as an average of running step 2) two times):
Before: ~09:40 (580 seconds) cook commandlet time
After: ~02:30 (150 seconds) cook commandlet time
=> 07:10 (430 seconds ) faster, i.e. a ~ 3.9x speedup

Win32 FileSystem Results:
Before: 1.5 million GetFileAttribute calls and 1.2 million FindNextFile calls
After: 35 0000 GetFileAttribute calls and 1.6 million FindNextFile calls
=> ~400 000 calls to FindNextFile replaces ~1.5 million calls to GetFileAttribute

#rb none


#ROBOMERGE-SOURCE: CL 5533504 via CL 5533655

[CL 5536177 by pj kack in Main branch]
2019-03-25 14:18:15 -04:00
mark satterthwaite
7523b61d4d Change the ShaderCodeLibrary to only initialise when the project settings require it and make a failure to open the 'Global' shader library fatal for non-Editor builds.
#rb none



#ROBOMERGE-SOURCE: CL 5421993 via CL 5421998 via CL 5428544

[CL 5428632 by mark satterthwaite in Main branch]
2019-03-18 11:39:48 -04:00
Justin Marcus
a6267fe237 Merging using //Fortnite/Dev-EngineMerge-To-//UE4/Main
Manual merge of CL 4940744 because robomerge had issues.

Original Description:

Merging //Fortnite/Dev-Kairos to Main (//Fortnite/Main)

Getting ready for Install Bundle Manager merge to main.  These are Engine/Core fixes


4440445
Fix FBuildPatchInstaller::Initialize() failing for manifests that did not include the empty tag.

#jira no jira
#rb Leigh.Swift


4474598
Add Android Macros to disable optimization
Fix Android directory iteration for OBBs.  FindFilesRecursive() now works.
#jira UEATM-177
#rb Chris.Babcock

4487221
Android file - When mounting an OBB, fix possibly mounting directories as files.
#rb Chris.Babcock

4511214
Fix Android directory iteration not returning the visitor result.  This would cause IPlatformFile::FindFilesRecursively() to prematurely end iteration.
#rb Chris.Babcock

4670945
Fix GetVarArgs format specifier off by 1 error.  These would only show up if you had the format specifier at the end of the format string and only with 'l' and not 'll'.  In that case the code would walk off the end of the format string, usually into another static string.

Fix GetVarArgs to never walk off the end of the format string.

#rb [at]ben.ziegler

4746778
Fix FShaderCodeEntry ref counts being off by one.
This bug was exposed because [Project Name Redacted] doesn't load shaderlibs or the PSO cache until well after engine init.  That means some FShaderResource's are loaded before shader libs or PSO cache and FShaderCodeLibrary::RequestShaderCode() can fail in FShaderResource::SerializeShaderCode().

#rb [at]Gil.Gribb [at]Chris.Babcock

[CL 4948018 by Justin Marcus in Main branch]
2019-02-08 11:00:43 -05:00
Rolando Caloca
732810a13b DR - Copying //UE4/Dev-Main@4785067 to //UE4-DevRendering
#rb none
#rnx
#lockdown Marcus.Wassmer

[CL 4790611 by Rolando Caloca in Dev-Rendering branch]
2019-01-23 17:01:56 -05:00
Robert Manuszewski
cfa01c09c7 Merging //UE4/Dev-Main to Dev-Core (//UE4/Dev-Core)
#rb none

[CL 4731457 by Robert Manuszewski in Dev-Core branch]
2019-01-16 04:23:12 -05:00
Marcus Wassmer
a8d6cc952b Merging //UE4/Dev-Main@4700769 to Dev-Rendering (//UE4/Dev-Rendering)
#rb none

[CL 4729861 by Marcus Wassmer in Dev-Rendering branch]
2019-01-15 18:04:38 -05:00
Marc Audy
ab108c215e Copying to Dev-Main @ CL# 4688301
#rb
#rnx

[CL 4688816 by Marc Audy in Main branch]
2019-01-08 11:38:48 -05:00
Marcus Wassmer
cbfcbbb93b Merging //UE4/Dev-Main@4662404 to Dev-Rendering (//UE4/Dev-Rendering)
#rb none
Should be just copyright updates

[CL 4680440 by Marcus Wassmer in Dev-Rendering branch]
2019-01-03 19:16:26 -05:00
Robert Manuszewski
2752c82adc Merging //UE4/Dev-Main @ 4664414 to Dev-Core (//UE4/Dev-Core)
#rb none

[CL 4675693 by Robert Manuszewski in Dev-Core branch]
2019-01-02 00:55:51 -05:00
Ben Marsh
7598af0532 Update copyright notices to 2019.
#rb none
#lockdown Nick.Penwarden

[CL 4662404 by Ben Marsh in Main branch]
2018-12-14 13:41:00 -05:00
Robert Manuszewski
9115b1f991 Merging //UE4/Dev-Main @ 4629913 to Dev-Core (//UE4/Dev-Core)
#rb none

[CL 4631340 by Robert Manuszewski in Dev-Core branch]
2018-12-05 02:19:48 -05:00
Marcus Wassmer
2b944cb943 Copying //UE4/Dev-Rendering@4626416 to Dev-Main (//UE4/Dev-Main)
#rb none
#lockdown nick.penwarden

[CL 4626501 by Marcus Wassmer in Main branch]
2018-12-03 22:25:23 -05:00
Richard Wallis
0290bd70f3 Clone of CL 4589926 for 4.21.1:
Fix for shader code library iterative cooking missing previous cook library data.  Don't clean at the end of a cook as we might be iterative next time - it's done at cook startup anyway based on the iterate flag.  Fix previous cooked cache file name searches - formats seem to have changed.

#jira UE-64067
#rb dmitriy.dyomin

[CL 4590118 by Richard Wallis in Dev-Rendering branch]
2018-11-23 09:44:40 -05:00
Marcus Wassmer
c56a69a8c0 Merging //UE4/Dev-Main@4567547 to Dev-Rendering (//UE4/Dev-Rendering)
#rb none

[CL 4568017 by Marcus Wassmer in Dev-Rendering branch]
2018-11-14 21:37:16 -05:00