#lockdown Nick.Penwarden
#rb none
============================
MAJOR FEATURES & CHANGES
============================
Change 3805828 by Gil.Gribb
UE4 - Fixed a bug in the lock free stalling task queue and adjusted a comment. The code is not current used, so this is not actually change the way the code works.
Change 3806784 by Ben.Marsh
UAT: Remove code to compile UBT when using UE4Build. It should already be compiled as a dependency of UAT.
Change 3807549 by Graeme.Thornton
Add a cook timer around VerifyCanCookPackage. A licensee reports this taking a lot of time so it'll be good to account for it.
Change 3807727 by Graeme.Thornton
Unhide the text asset format experimental editor option
Change 3807746 by Josh.Engebretson
Remove WER from iOS platform
Change 3807928 by Robert.Manuszewski
When async loading, GC Clusters will be created after packages have been processed to avoid situations where some of the objects that are being added to a cluster haven't been fully loaded yet
Change 3808221 by Steve.Robb
GitHub #4307 - Made GetModulePtr() thread safe by not using GetModule()
^ I'm not convinced by how much thread-safer this is really, but it's tidier anyway.
Change 3809233 by Graeme.Thornton
TBA: Misc changes to text asset commandlet
- Rename mode to "loadsave"
- Add -outputFormat option which can be assigned "text" or "binary"
- When saving binary, use a differentiated filename so that source assets aren't overwritten
Change 3809518 by Ben.Marsh
Remove the outdated UnrealSync automation script.
Change 3809643 by Steve.Robb
GitHub #4277 : fix bug; FMath::FormatIntToHumanReadable 3rd comma and negative value
#jira UE-53037
Change 3809862 by Steve.Robb
GitHub #3342 : [FRotator.h] Fix to DecompressAxisFromByte to be more efficient and reflect its intent accurately
#jira UE-42593
Change 3811190 by Graeme.Thornton
Add support for writing specific log channels to their own files
Change 3811197 by Graeme.Thornton
Minor updates to output formatting and timing for the text asset commandlet
Change 3811257 by Robert.Manuszewski
Cluster creation will now be time-sliced
Change 3811565 by Steve.Robb
Define out non-monolithic module functions.
Change 3812561 by Steve.Robb
GitHub #3886 : Enable Brace-Initialization for Declaring Variables
Incorrect semi-colon search removed after discussion with author.
Test added.
#jira UE-48242
Change 3812864 by Steve.Robb
Removal of some unproven code which was supposed to fix hot reloading BP class functions in plugins.
See: https://udn.unrealengine.com/questions/376978/aitask-blueprint-nodes-disappear-when-their-module.html
#jira UE-53089
Change 3820358 by Ben.Marsh
PR #4358: Incredibuild use ShowAgent by default (Contributed by projectgheist)
Change 3822594 by Ben.Marsh
UAT: Improvements to log file handling.
- Always create log files in the final location, rather than writing to a temp directory and copying in later.
- Now supports -Verbose and -VeryVerbose for increasing log verbosity, rather than -Verbose=XXX.
- Keep a backlog of log output before the log system is initialized, and flush it to the log file once it is.
- Allow buildmachines to specify the uebp_FinalLogFolder environment variable, which is used to form paths for display. When build machines copy log files elsewhere after UAT finishes (eg. a network share), this allows error messages to display the right location.
Change 3823695 by Ben.Marsh
UGS: Fix issue where precompiled binaries would not be shown as available for a change until scrolling the last submitted code change into the buffer (other symptoms, like de-focussing the main window would cause it to go back to an unavailable state, since the changes buffer was shrunk).
Now always queries changes up to the last change for which zipped binaries are available.
Change 3823845 by Ben.Marsh
UBT: Exclude C# projects for unsupported platforms when generating project files.
Change 3824180 by Ben.Marsh
UGS: Add an option to show changes by build machines, and move the "only show reviewed" option in there too (Options > Show Changes).
#jira
Change 3825777 by Steve.Robb
Fix to return value of StringToBytes.
Change 3825810 by Ben.Marsh
UBT: Reduce length of include paths for MSVC toolchain.
Change 3825822 by Robert.Manuszewski
Optimized PIE lazy pointer fixup. Should be up to 8x faster now.
Change 3826734 by Ben.Marsh
Remove code to disable TextureFormatAndroid on Linux. It seems to be an editor dependency.
Change 3827730 by Steve.Robb
Try to avoid decltype(auto) if it's not supported.
See: https://udn.unrealengine.com/questions/395644/build-417-with-c11-on-linux-ttuple-errors.html
Change 3827745 by Steve.Robb
Initializer list support for TMap.
Change 3827770 by Steve.Robb
GitHub #4399 : Added a CONSTEXPR qualifiers to FVariant::GetType()
#jira UE-53813
Change 3829189 by Ben.Marsh
UBT: Now always writes a minimal log file. By default, just contains the regular console output and any reasons why actions are outdated and needed to be executed. UAT directs child UBT instances to output logs into its own log folder, so that build machines can save them off.
Change 3830444 by Steve.Robb
BuildVersion and ModuleManifest moved to Core, and parsing of these files reimplemented to avoid a JSON library.
This should be revisited when Core has its own JSON library.
Change 3830718 by Ben.Marsh
Fix incorrect group name being returned by FStatNameAndInfo::GetGroupName() for stat groups.
The editor populates the viewport stats list by calling this for every registered stat and stat group (via FLevelViewportCommands::HandleNewStatGroup). The menu entry attempts to show the stat name with STAT_XXX stripped from the start as the menu item label, with the free-form text description as a tooltip.
For stat groups, the it would previously just return the stat group name as "Groups" (due to the raw naming convention of "//Groups//STATGROUP_Foo//..."). Since this didn't match the expected naming convention in FLevelViewportCommands::HandleNewStat (ie. STAT_XXX or STATGROUP_XXX), it would fail to add it.
When the first actual stat belonging to that group is added, it would add a menu entry for the group based on that, but the stat description no longer makes sense as a tooltip for the group. As a result, all the editor tooltips were junk.
#jira UE-53845
Change 3831064 by Ben.Marsh
Fix log file contention when spawning UBT recursively.
Change 3832654 by Ben.Marsh
UGS: Fix error panel not being selected when opened, and weird alignment/color issues on it.
Change 3832680 by Ben.Marsh
UGS: Fix failing to detect workspace if synced to a different stream. Seems to be a regression caused by recent P4D upgrade.
Change 3832695 by Ben.Marsh
UGS: Invert the options in the 'Show Changes' submenu for simplicity.
Change 3833528 by Ben.Marsh
UAT: Script to rewrite source files with public include paths relative to the 'Public' folder. Usage is: RebasePublicIncludePaths -UpdateDir=<Dir> [-Project=<Dir>] [-Write].
Change 3833543 by Ben.Marsh
UBT: Allow targets to opt-out of having public include paths added for every dependent module. This reduces the command line length when building a target, which has recently become a problem with larger games (due to Microsoft's compiler embedding the command line into each object file, with a maximum length of 64kb). All engine modules are compiled with this enabled; games may opt into it by setting bLegacyPublicIncludePaths = false; from their .target.cs, as may individual modules.
Change 3834354 by Robert.Manuszewski
Archetype pointer will now be cached to avoid locking the object tables when acquiring its info. It should also be faster this way regardless of any locks.
#jira UE-52035
Change 3834400 by Robert.Manuszewski
Fixing crash on exit caused by cached archetypes not being cleaned up before static exit cleanup.
#jira UE-52035
Change 3834947 by Steve.Robb
USE_FORMAT_STRING_TYPE_CHECKING removed from FMsg::Logf and FMsg::Logf_Internal.
Change 3835004 by Ben.Marsh
Fix code that relies on dubious behavior of requiring referenced "include path only" modules having their _API macros set to be empty, even if the module is actually implemented in a separate DLL.
Change 3835340 by Ben.Marsh
Fix errors making installed build from directories with spaces in the name.
Change 3835972 by Ben.Marsh
UBT: Improved diagnostic message for targets which don't need a version file.
Change 3836019 by Ben.Marsh
UBT: Fix warnings caused by defining linkage macros for third party libraries.
Change 3836269 by Ben.Marsh
Fix message box larger than the screen height being created when a large number of modules are incompatible on startup.
Change 3836543 by Ben.Marsh
Enable SoundMod plugin on Linux, since it's already supported through the editor.
Change 3836546 by Ben.Marsh
PR #4412: fix type mismatch (Contributed by nakapon)
Change 3836805 by Ben.Marsh
Fix commandlet to compile marketplace plugins.
Change 3836829 by Ben.Marsh
UBT: Fix ability to precompile plugins from installed engine builds.
Change 3837036 by Ben.Marsh
UBT: Write the previous and new contents of intermediate files to the log if they change. Makes it easier to debug unexpected rebuilds.
Change 3837037 by Ben.Marsh
UBT: Fix engine modules having inconsistent definitions depending on whether modules are only referenced for their include paths vs being linked into a binary (due to different _API macro).
Change 3837040 by Ben.Marsh
UBT: Remove code that initializes members in ModuleRules and TargetRules objects before the constructor is run. This is no longer necessary, now that the backwards-compatible default constructors have been removed.
Change 3837247 by Ben.Marsh
UBT: Remove UELinkerFixups module, now that plugins and precompiled modules do not require hacks to force initialization (since they're linked in as object files).
Encryption and signing keys are now set via macros expanded from the IMPLEMENT_PRIMARY_GAME_MODULE macro, via project-specific macros added in the TargetRules constructor.
Change 3837262 by Ben.Marsh
UBT: Set whether a module is an engine module or not via a default value for the rules assembly. All non-program engine and enterprise modules are created with this flag set to true; program targets and modules are now created from a different assembly that sets it to false. This removes hacks from UEBuildModule needed to adjust behavior for different module types based on the directory containing the module.
Also add a bUseBackwardsCompatibleDefaults flag to the TargetRules class, also initialized to a default value from a setting passed to the RulesAssembly constructor. This controls whether modules created for the target should be configured to allow breaking changes to default settings, and is set to false for all engine targets, and true for all project targets.
Change 3837343 by Ben.Marsh
UBT: Remove the OverrideExecutableFileExtension target property. Change the only current use for this (the MayaLiveLinkPlugin target) to use a post build step to copy the file instead.
Change 3837356 by Ben.Marsh
Fix invalid character encodings.
Change 3837727 by Graeme.Thornton
UnrealPak: KeyGenerator: Only generate prime table when required, not all the time
Change 3837823 by Ben.Marsh
UBT: Output warnings and errors when compiling module rules assembly in a way that allows them to be double-clicked in the Visual Studio output window.
Change 3837831 by Graeme.Thornton
UBT: When parsing crypto settings, always load legacy data first, then allow the new system to override it. Provides the same key backwards compatibility that the editor settings class gives
Change 3837857 by Robert.Manuszewski
PR #4404: Make FGCArrayPool singleton global instead of per-CU (Contributed by mhutch)
Change 3837943 by Robert.Manuszewski
PR #4405: Fix FGarbageCollectionTracer (Contributed by mhutch)
Change 3838451 by Ben.Marsh
UBT: Fix exceptions thrown on a background thread while caching C++ includes not being caught and logged correctly. Now captures exceptions and re-throws on the main thread.
#jira UE-53996
Change 3839519 by Ben.Marsh
UBT: Simplify configuring bPrecompile and bUsePrecompile settings for modules. Each rules assembly can now be configured as installed, which defaults the module rules it creates to use precompiled data.
Change 3843790 by Graeme.Thornton
UnrealPak: Log the size of all encrypted data
Change 3844258 by Ben.Marsh
Fix plugin compile failure when created via new plugin wizard. Passing -plugin on the command line is unnecessary, and is now reserved for packaging external plugins for the marketplace.
Also extend the length of time that the error toast stays visible, and don't delete the plugin on failure.
#jira UE-54157
Change 3845796 by Ben.Marsh
Workaround for slow performance of String.EndsWith() on Mono.
Change 3845823 by Ben.Marsh
Fix case sensitive matching of platform names in -TargetPlatform=X argument to BuildCookRun.
#jira UE-54123
Change 3845901 by Arciel.Rekman
Linux: fix crash due to lambda lifetime issues (UE-54040).
- The lambda goes out of scope in FBufferVisualizationMenuCommands::CreateVisualizationCommands, crashing the editor if compiled with a recent clang (5.0+).
(Edigrating 3819174 to Dev-Core)
Change 3846439 by Ben.Marsh
Revert CL 3822742 to always call Process.WaitForExit(). The Android target platform module in the editor spawns ADB.EXE, which inherits the editor's stdout/stderr handles and forks itself. Process.WaitForExit() waits for EOF on those pipes, which never occurs because the forked process never terminates.
Proper fix is probably to have the engine explicitly duplicate stdout/stderr handles for new pipes to output process, but too risky before copying up to Main.
Change 3816608 by Ben.Marsh
UBT: Use DirectoryReference objects for all include paths.
Change 3816954 by Ben.Marsh
UBT: Remove bIncludeDependentLibrariesInLibrary option. This is not widely supported by platform toolchains, and is not used anywhere.
Change 3816986 by Ben.Marsh
UBT: Remove UEBuildBinaryConfig; UEBuildBinary objects are now just created directly.
Change 3816991 by Ben.Marsh
UBT: Deprecate PlatformSpecificDynamicallyLoadedModules. We no longer have any special behavior for these modules.
Change 3823090 by Ben.Marsh
UAT: Improve logging for child UAT instances.
- Calling RunUAT now requires an identifier for prefixing into the parent log, which is also used to determine the name of the log folder.
- Stdout is no longer written to its own output file, since it's written to the parent stdout, the parent log file, and the child log file anyway.
- Log folders for child UAT instances are left intact, rather than being copied to the parent folder. The derived names for the copied names were confusing and hard to read.
- Output from UAT is no longer returned as a string. It should not be parsed anyway (but may be huge!). ProcessResult now supports running without capturing output.
Change 3826082 by Ben.Marsh
UBT: Add a check to make sure that all modules that are precompiled are correctly marked to enable it, even if they are part of the build target.
Change 3827025 by Ben.Marsh
UBT: Move the compile output directory into a property on the module, and explicitly pass it to the toolchain when compiling.
Change 3829927 by James.Hopkin
Made HTTP interface const correct
Change 3833533 by Ben.Marsh
Rewrite engine source files to base include paths relative to the "Public" directory. This allows reducing the number of public include paths that have to be added for engine modules.
Change 3835826 by Ben.Marsh
UBT: Precompiled targets now generate a separate manifest for each precompiled module, rather than adding object files to a library. This fixes issues where object files from static libraries would not be linked into a target if a symbol in them was not referenced.
Change 3835969 by Ben.Marsh
UBT: Fix cases where text is being written directly to the console rather than via logging functions.
Change 3837777 by Steve.Robb
Format string type checking added to FOutputDevice::Logf.
Fixes for those.
Change 3838569 by Steve.Robb
Algo moved up a folder.
[CL 3847482 by Ben Marsh in Main branch]
#rb none
#lockdown Nick.Penwarden
=================================================================================================
THESE CHANGES TOUCH MULTIPLE PLATFORMS AND/OR RESTRICTED FOLDERS.
YOU MUST REVIEW THESE MANUALLY AND APPEND THEM TO THE DESCRIPTIONS FOR THE APPROPRIATE PLATFORMS.
=================================================================================================
Change 3662267 by Nick.Darnell
Engine - Fixing a bug in GetAccurateRealTime, it wasn't subtracting GStartTime, which if you don't prevents accurate platform time when you try to store it in a float.
#jira nojira
Change 3662176 by Ben.Marsh
Disable image integrity report generation if a debugger is attached, and in editor builds.
#jira FORT-55656
Change 3656958 by Luke.Thatcher
[FORTNITE] [CONSOLE] [+] Improved frame syncing mechanism
- Improves input latency by allowing the game thread to sync to the swap chain flip of the previous frame.
- Added "r.GTSyncType" CVar to control how the game thread syncs with the rest of the pipe.
- r.GTSyncType 2 will sync the game thread with the flip of the swap chain, preventing the pipe from getting too long and causing excess input latency.
Platforms are required to implement RHIWaitForFlip and RHISignalFlipEvent, and call RHIInitializeFlipTracking on RHI startup.
A separate thread monitors the progress of frame flips and signals task graph events as they pass their corresponding frame index.
In r.GTSyncType 2 mode, the game thread is signaled by this flip tracking thread.
[~] Unified platform specific sync interval CVars (D3D12.SyncInterval, D3D11.SyncInterval, r.PS4FlipRate, RHI.SyncIntervalOgl) into one: rhi.SyncInterval
- 1 == 60Hz
- 2 == 30Hz
- 3 == 20Hz
[-] Removed large number in XboxOneTime. Adding this arbitrary number prevents us from comparing timestamps from FPlatformTime::Seconds() and various OS callbacks (e.g. flip timings).
#jira FORT-50803
Change 3655598 by Lukasz.Furman
added filtering for navmesh's low height spans to fix crash on layer partitioning
% of span reductions depends on presence of stair or roof building in navmesh tile, changed failsafes in layer code to ignore entire tile if heightfield is too complex to partition instead of reallocating memory
#jira FORT-35375
Change 3648972 by Keith.Judge
Add analytics to help diagnose default parameter collection buffer issue.
+++ REMOVE ONCE CORE ISSUE IS SOLVED +++
#jira FORT-54690
Change 3648756 by Bart.Hawthorne
Integrate 3645298 from //UE4/Dev-Networking
Deprecate GetNetworkObjectInfo in favor of separate FindNetworkObjectInfo and FindOrCreateNetworkObjectInfo methods.
#jira none
Change 3643090 by Josh.Markiewicz
#UE4 - proper handling of "pending connection lost"
- triggered only if a connection is lost and there no "owning actor" to deal with the connection loss
-- added Rejoin and CleanedUp states to connection to make sure that the pending connection lost delegate only fires at the appropriate time
- delegate returns the unique id of the player if known (still possible to be unknown if connection lost after NMT_Hello)
- changed debug output on timeout if the net connection was already in the process of being destroyed
-- occurs when game hitches during the pending destroy 2 second wait
-- ReceivedAcks should have been called to clean things up quietly in those 2 seconds but blocking the game thread will cause the cleanup to look like a timeout
- added userid to UNetConnection::Describe
- bad split screen player handling of unique id
-- splitscreen uniqueid was overwriting the primary player id
-- only store the id on the child connection
- added some clarifying comments
#review-3642816 @ryan.gerleve, @bob.tellez, @sam.zamani, @bart.hawthorne, @dave.ratti
#jira FORT-26776
Change 3639043 by Alex.Thurman
Fix CommonTreeView SetSelection to correctly update list navigation, and behave similarly to CommonListView's SetSelectedItem.
#JIRA FORT-45841
Change 3632275 by Seth.Weedin
#JIRA FORT-54203 - Add clamps to ActiveSound fade interpolation to prevent unwanted volume spikes. Remove 0.01 start time for single-fire audio cues. Should remove the sudden pops sometimes heard when firing weapons, as well as smooth out fade volume in general.
Change 3626944 by Josh.Markiewicz
#UE4 - added "updates connection status" flag to ServiceConfigMCP
- disable updates on Cloud and Friend services (Fortnite only)
- removed overloaded ProcessConnectionStatus function in cloud service
#jira FORT-53113
Change 3626226 by Stewart.Lynch
LLM Update - Memory reductions, Summary page, enum scopes, refactor and cleanup of tags
* Remove all static arrays and hard limits from LLM. Everything is now dynamically allocated using the internal LLM allocators. The overhead when LLM is disabled is now only 48K (was 40MB)
* re-wrote LLMMap. Now stores an int32 index rather then pointer in the HashMap array. Also, changed the Values to be arrays for structs instead of structs of arrays. Means that the tag can be stored in a single byte. Changed the size of the allocation size from int64 to int32. All this takes the memory down from around 600MB to 100MB. It was 120 bytes per allocation, now 29 bytes.
* changed all LLM scopes over to enums. This has a number of benefits; LLM can be enable in Test, less CPU overhead, stored in a byte (LLM overhead /= 8)
* summary page for content creators where all lower-level stats are grouped under one Engine stat
* renamed ELLMScopeTag enum to ELLMTag
* renamed LLM_SCOPED_TAG_WITH_ENUM macro to LLM_SCOPE
* removed Tracker arg from LLM_SCOPE and added LLM_PLATFORM_SCOPE macro
* fixed GenericPlatformMallocCrash stat. Although it seems not be be used anymore
* fixed BackupOOMMemoryPool stat (now shows in both default and platform pages)
* added separate LLM enums for XB1, PS4 and D3D12 (PS4LLM.cpp/h etc.)
* lots of changes adding/removing/renaming tags
* added LLMArray and FLLMObjectAllocator classes
* disabled asset tag tracking by default because it takes up so much memory even when not used
* enable LLM in all non-shipping builds. In Test the on screendisplay won't show because it uses the stats system but it till still write out the csv.
* all the stat macros have been left as they were and can be enabled on the LLM_STAT_TAGS_ENABLED define. These are needed for the asset tagging.
* disabled LLM_TRACK_PEAK_MEMORY because there is a problem with the way it adds the peaks for multiple threads. This needs to be fixed.
* added a CVar to control the csv write interval: LLM.LLMWriteInterval
* added static arrays for the enum tags setup. Easier to manage and removes need for slow switch statements.
* renamed FLLMThreadStateManager to FLLMTracker to make it consistent with the enum
* fixed program size stat which was broken recently on PS4. This was due to initialisation order and global platform stats setup
#jira NONE-01
Change 3622978 by Lukasz.Furman
changed WeaponStatus BT decorator to be event driven, fixes AI trying to check ranged weapon abilities without valid weapon
includes copy of CL# 3620700
#jira FORT-45914
#review-3622979 John.Abercrombie
Change 3622340 by Josh.Markiewicz
#UE4 - playerid netconnection variable setup properly on clients and servers for both beacons and game net drivers
- ipconnection prints uniqueid with lowleveldescribe
#jira fort-0
Change 3621386 by Tim.Tillotson
Add the ability to retry HTTP operations by VERB. This allows us to automatically retry cloud save PUT operations.
#JIRA FORT-53717
#review-3621317 @Josh.Markiewicz @Ian.Fox @Carlos.Cuello
Change 3620517 by Keith.Judge
Xbox One - Revert iOS behaviour for the depth bias back to how it was, and make separate XB1 change use its own define to avoid confusion.
#jira FORT-53928
Change 3620248 by Lukasz.Furman
changed behavior of UBTTask_MoveTo.bStopOnOverlap flag after recent AcceptanceRadius fix, updated comments to be more detailed
#jira nojira
Change 3616187 by Bob.Tellez
#UE4 Throwing an error (for now) if you attempt to use both the malloc profiler and leak detection at the same time since it causes a deadlock.
#JIRA UE-0
Change 3613935 by Peter.Knepley
More logging on update launcher launching
#jira nojira
#robomerge rp rn
Change 3613537 by Marcus.Wassmer
Safety asserts around the MarkPendingKill feature for rendering classes.
#jira FORT-50385
Change 3613399 by Arne.Schober
Extended ShowMaterialDrawEvents to enable it only in very specific passes and default enabled Depth for Fortnite on PS4 to track down a crash.
#RB Marcus.Wassmer
#jira FORT-53610
Change 3610794 by robomerge
#ROBOMERGE-AUTHOR: marc.audy
Reduce UMG class memory
#jira UE-52043
#ROBOMERGE-SOURCE: CL 3610792 in //Fortnite/Release-Prep/...
#ROBOMERGE-BOT: FORTNITE (Release-Prep -> Main)
Change 3610144 by Stewart.Lynch
General LLM improvements
* added tracking for misc task graph tasks (moves 20MB out of Untagged)
* renamed EngineTick to EngineMisc
* added tracking for FName
* added tracking for GC_ProcessObjectArray potential leak
* renamed index & vertex buffers stat to Meshes
* added hooks for MemPro to track allocations from a single category. Currently defined out. I haven't added MemPro.cpp/h.
* removed AVAILABLE_PHYSICAL stat from LLM csv
* csv files now include the date in the filename
* fixed potential threading bug when reading stat values to csv
* made IsDebugMemoryEnabled() always return false in shipping and if not runnong on a dev-kit (PS4). The reason is that the function is a bit hacky, and should only be used for debug purposes, such as displaying the on screen warning.
* added lots more scopes
* started changing Stat scopes to enum scopes. Stat scopes will be phased out.
* added tracking of FName memory
* added llmplatform tracking for XBoxSymbols
* added llm tracking for CPU symbol allocations (20MB)
* wrote an allocator for XBoxOneStack reading so that it doesn't go through Malloc and get tracked by LLM.
* added tracking for GC
* fixed tracking for TransientMemoryAllocator
* added tracking for networking memory
* added more audio memory tracking
* added tracking for blueprints
* added tracking for static meshes
* show on screen warning if debug memory is enabled
* added tracking for particles
* renamed Phys to PhysX and added more scopes
* renamed Slate to UI and added more scopes
* much better coverage of networking memory
* improved coverage of audio
#jira FORT-53420
Change 3610136 by robomerge
#ROBOMERGE-AUTHOR: marc.audy
Reduce size of UStaticMeshComponent by 224 bytes (cumulative, 64 bytes exclusive)
Reduce size of UPrimitiveComponent by 176 bytes (cumulative, 64 bytes exclusive).
Reduce size of USceneComponent by 112 bytes.
Reduce size of FLightingChannels from 3 bytes to 1.
Reduce size of FBodyInstance by 16 bytes.
#jira FORT-52043
#ROBOMERGE-SOURCE: CL 3610134 in //Fortnite/Release-Prep/...
#ROBOMERGE-BOT: FORTNITE (Release-Prep -> Main)
Change 3607937 by robomerge
#ROBOMERGE-AUTHOR: paul.moore
#jira FORT-53105
- Fix websocket not providing information when the peer closes the connection.
#ROBOMERGE-SOURCE: CL 3607933 in //Fortnite/Release-Prep/...
#ROBOMERGE-BOT: FORTNITE (Release-Prep -> Main)
Change 3607042 by Bart.Hawthorne
Move replay.Loop functionality into the demo net driver and rename it demo.Loop
#jira none
Change 3605448 by robomerge
#ROBOMERGE-AUTHOR: seth.weedin
#Athena - Pass owner to ActiveSounds created using PlaySoundAtLocation/PlaySound2D to allow "Limit to Owner" concurrency rules to work. Hook up for weapon sounds. #JIRA FORT-53180
#ROBOMERGE-SOURCE: CL 3605443 in //Fortnite/Release-Prep/...
#ROBOMERGE-BOT: FORTNITE (Release-Prep -> Main)
Change 3604787 by robomerge
#ROBOMERGE-AUTHOR: mike.fricker
Initial support for hotfixing live assets from .ini files
- This allows clients and server to patch certain assets in memory whenever .ini file hotfixes are downloaded
- Only CurveTables and DataTables are supported for now
- The new asset content must be in Json format, the same format the editor uses for importing
- Assets that are hotfixed will be synchronously loaded if they're not already in memory. They'll be retained in memory afterwards.
- IMPORTANT: Json data must be supplied on a single line, and all double quotes must be escaped!
- The changes must go in the Game.ini file and use the following syntax:
[AssetHotfix]
+CurveTable=("/Game/Folder/MyCurveTable","[{\"Name\":\"Default\"}]")
+DataTable=("/Game/Folder2/MyDataTable","[{\"Name\":\"Foo\"}]")
#jira FORT-52099
[CODEREVIEW] frank.gigliotti
[FYI] peter.knepley,bob.tellez
#ROBOMERGE-SOURCE: CL 3604784 in //Fortnite/Release-Prep/...
#ROBOMERGE-BOT: FORTNITE (Release-Prep -> Main)
Change 3602067 by robomerge
#ROBOMERGE-AUTHOR: mike.fricker
Loading time improvements
- This shaves off up to 10 seconds of load time on PS4 in Athena
Details:
- Fixed multiple sub-levels not being able to be enqueued for loading in a single client frame. Athena has ~300 sub-levels, so this ended up wasting up many seconds.
- Fixed 3D world being rendered while loading (frees up game thread cycles for throttled streaming)
- UWorld::AllowLevelLoadRequests() was not allowing load requests to go through while an async load was in progress and the match had started. It now allows this as long as the world isn't being rendered (loading screen.)
- Eliminated extra 2 second delay before loading screen is dismissed (in Athena only)
- Note: A side effect of this change is that the progress bar may not update as smoothly on loading screen. We'll look at tuning the throttle settings if it ends up being a problem.
[CODEREVIEW] ori.cohen
#jira AT-1477
#ROBOMERGE-SOURCE: CL 3602061 in //Fortnite/Release-Prep/...
#ROBOMERGE-BOT: FORTNITE (Release-Prep -> Main)
Change 3601951 by Luke.Thatcher
[FORTNITE] [PS4] [!] Fix memory stats in the old PS4 memory system
- Physical memory stat now includes garlic and onion allocations. CPU OOMs will result in "AvailablePhysical" being close to 0.
- Added garlic, onion and defrag stats to the platform memory stats struct.
- Added fixed pool sizes to platform memory stats.
- Modified the Fortnite heartbeat logging to include extra details of PS4 fixed sized pools.
#jira FORT-52910
Change 3600340 by robomerge
#ROBOMERGE-AUTHOR: wes.hunt
All Fort analytics events now contain a GameState attribute indicating the active GameState ClassName when the event is sent.
Added some new context to crashreporter to help identify Athena matches near and long term.
* Near Term: GameNameSuffix - set via FCoreDelegates::CrashOverrideParamsChanged
* Added bools to the params to indicate WHICH ones are changing
* Allows you to set only some values, and clear them out.
* Hooked up in FortGameState::PostInitializeComponents.
* FortGameState clears it (for returning to main menu).
* FortGameStateAthena sets it (for going into an Athena match).
* Only does this when it's a true GameMode GameState instance (ie, not PIE) so PIE crashes aren't modified.
* Long Term: GameStateName - set via FCoreDelegates::GameStateClassChanged.
* This works for ANY crash on ANY game.
* Hooked up in GameState::HandleMatchIsWaitingToStart.
#jira AT-1457
#jira AT-519
[CODEREVIEW] peter.knepley,josh.markiewicz
#ROBOMERGE-SOURCE: CL 3600278 in //Fortnite/Release-Prep/...
#ROBOMERGE-BOT: FORTNITE (Release-Prep -> Main)
Change 3597593 by Ben.Zeigler
#jira FORT-50722
Fix issues where AssetBundles weren't being correctly updated during cook, which is blocking both Noland and Abercrombie
Partial copy of CL #3402335 and #3526538
#robomerge rp, rn
Change 3597577 by Luke.Thatcher
[FORTNITE] [PS4] [~] Modified the way memory is allocated on Playstation to make more memory available to the CPU.
- Previously the amount of texture memory wasn╞t fixed due to the way the defrag memory is allocated on PS4. This meant we had to have a significant amount of slack.
- With the new configuration, we have a guaranteed texture memory pool, so the slack can be significantly smaller, meaning we can give more memory to the CPU, which is where most of our memory pressure is.
#jira FORT-50825
#jira FORT-49688
#jira FORT-49695
#jira FORT-50054
Change 3596556 by robomerge
#ROBOMERGE-AUTHOR: mike.fricker
Enable GC clustering for actors and blueprints in Fortnite
- This shaves off about 10 ms on GC frames in Athena on PS4 (~52 ms -> 42 ms)
- Clustering doesn't work on building actors because they're very dynamic, but general Fort static meshes and blueprints are clustered!
- This gets us into the realm of shippability on console for very large UObject counts
[FYI] bob.tellez,peter.knepley,michael.noland
#jira AT-1440
#ROBOMERGE-SOURCE: CL 3596552 in //Fortnite/Release-Prep/...
#ROBOMERGE-BOT: FORTNITE (Release-Prep -> Main)
Change 3593994 by robomerge
#ROBOMERGE-AUTHOR: mike.fricker
Force largest distance field atlas size in Athena
- We now force the largest distance field atlas size before preloading Athena content (512x512x1024 = 256 MB). This helps with load times because it's expensive to re-create this texture on consoles, and typically it gets resized over a dozen times.
- Added new CVar "r.DistanceFields.ForceMaxAtlasSize" (defaults to zero)
- Important: Currently we never "reset" this atlas texture. This will be a problem when going back to play Campaigns after preloading to play Athena. I will look into this soon!
[CODEREVIEW] peter.knepley,marcus.wassmer,michael.noland,daniel.wright
#jira AT-1477
#ROBOMERGE-SOURCE: CL 3593992 in //Fortnite/Release-Prep/...
#ROBOMERGE-BOT: FORTNITE (Release-Prep -> Main)
Change 3592096 by robomerge
#ROBOMERGE-AUTHOR: ben.salem
Prototype of gauntlet memory soak test. Not fully fiinished, but want changes in tonight's cook so we can experiment on cooked build tomorrow morning.
#jira FORT-0
#ROBOMERGE-SOURCE: CL 3592025 in //Fortnite/Release-Prep/...
#ROBOMERGE-BOT: FORTNITE (Release-Prep -> Main)
Change 3592085 by robomerge
#ROBOMERGE-AUTHOR: mike.fricker
HLOD: Added support for a fixed distance override via CVar
- Use this to force all HLODs to transition at a specific distance, regardless of their TransitionSize/MinDrawDistance/LODDrawDistance
- New CVar: r.HLOD.DistanceOverride (defaults to 0)
- Fortnite uses 350m for this distance, fornow
[CODEREVIEW] jurre.debaare
#jira AT-1462
#ROBOMERGE-SOURCE: CL 3591929 in //Fortnite/Release-Prep/...
#ROBOMERGE-BOT: FORTNITE (Release-Prep -> Main)
Change 3587391 by Michael.Noland
Fortnite: Lots of memory tracking stuff
- Added memory logging to game state transitions and overall health tracking for the entire session
- Added support for Gauntlet-based tests to Fortnite
- Enabled the Gauntlet plugin (and fixed spaces instead of tabs in the .uproject file)
- Added code to set gauntlet state based on the current subclass of AFortGameState
- Added a base controller and a memory report controller (WIP, ported from equivalents in Paragon)
- Updated FortniteClient to use MALLOC_LEAKDETECTION=1, PLATFORM_USES_FIXED_GMalloc_CLASS=0, and AllowASLRInShipping=false in Development builds (may enable them in Test builds in a future CL, to match Paragon)
#jira FORT-50567
Change 3583307 by Peter.Knepley
Need non-jittered ViewToClip matrix in order to do "after tonemapper" postprocess blendable material that's positioned in view space
Modify the AttachScope material function to use "ViewSpaceTransformToClipSpace" instead of going back to world space first. This also means it can utilitize the ViewToClipNoAA matrix.
#jira AT-733
Change 3582378 by Luke.Thatcher
[FORTNITE] [~] Unify Xbox and PS4 scalability settings and device profiles.
- All Xbox and PS4 r. CVars are overriden in their platform's Scalability.ini file. The device profile only selects sg. groups.
- Fixed the Neo 4K profile for Fortnite. Previously players with 4K monitors would choose the Neo_4K profile, which looks worse than Neo, but still renders at 1080p.
- Console specific settings have to live in the Base/Default .ini's, as the cooker doesn't load the console specific files. This is fixed in UE4 Main.
#jira FORT-50206
Change 3580934 by Luke.Thatcher
[FORTNITE] [PS4] [+] Support different garlic and onion heap sizes in the old memory system for base and neo.
- Neo has 512 MB more direct memory than a base kit.
- Increased the garlic heap size by 416 MB on Neo, and CPU heap by 96 MB.
#jira FORT-50206
Change 3576664 by Bart.Hawthorne
Re-enable Oodle and add Mac implementation. Also includes fixed oodle libraries by MichaelT.
#jira FORT-49986
#tests Connected to PC server with editor -game build on Mac in Athena
Change 3575671 by Nick.Darnell
Athena - The gameplay ability system now supports adding Gameplay Cue's with params. Now using cues instead of gameplay effects in order to notify when the bandaging/shielding begin and end. THe new method should properly show and disappear on time, b/c it's all client side. Added a way in the Athena Context to easily hook gameplay "UI" cues that are rebroadcast from the Athena Pawn.
#jira AT-644
Change 3575534 by Peter.Knepley
Ability montage replication optimizations
#jira AT-955
Change 3573305 by Lukasz.Furman
disabled path section update when crowd simulated AI is moving through navlink, fixed AI getting stuck in some corners
#jira FORT-49748
Change 3566775 by John.Abercrombie
Optimizations from Dev-Athena
- Tested with PIE & and 2 Player local server game
#ue4-athena - (merge CLs 3345771 and 3363030 from Framework) - Refactored CharacterMovementComponent determination of net send rate when combining moves into a virtual function GetClientNetSendDeltaTime(). Added configurable values to GameNetworkManager under [/Script/Engine.GameNetworkManager].
For Fortnite, set unthrottled (<= 10 player) limit to 60Hz (from 90Hz), and trying throttled at 30Hz (from 45Hz).
#AUTOMERGE using branch //Fortnite/Main-To-//Fortnite/Dev-Athena (reversed) of change#3545535 by Zak.Middleton on 2017/07/19 20:15:17.
#ue4-athena - (merge CL 3377054 from Framework) - Fix CharacterMovementComponent updated with very high delta time on server when initially joining. Make sure the ServerTimeStamp is initialized to current world time rather than zero to prevent large delta.
#AUTOMERGE using branch //Fortnite/Main-To-//Fortnite/Dev-Athena (reversed) of change#3545452 by Zak.Middleton on 2017/07/19 18:57:45.
#athena - If network smoothing mode is not linear, don't replicate ReplicatedServerLastTransformUpdateTimeStamp. Only AI use linear smoothing in FN.
#AUTOMERGE using branch //Fortnite/Main-To-//Fortnite/Dev-Athena (reversed) of change#3545559 by Zak.Middleton on 2017/07/19 20:47:18.
#ue4-athena - Converted all RPCs on UCharacterMovementComponent to be on ACharacter instead, to avoid the bandwidth overhead of calling RPCs on a component.
Existing overrides of _Implementation and _Validate functions should remain unchanged. If for some reason someone overrode the old RPC virtuals, those are now non-virtual on UCharacterMovementComponent but are still virtual on ACharacter.
#AUTOMERGE using branch //Fortnite/Main-To-//Fortnite/Dev-Athena (reversed) of change#3557564 by Zak.Middleton on 2017/07/26 20:13:43.
#ue4-athena - Throttle character movement server corrections and acks to the client based on time since last adjustment. Cuts down on network traffic for character movement.
Added configurable settings to control this. Set times to zero to disable this.
- NetworkMinTimeBetweenClientAckGoodMove
- NetworkMinTimeBetweenClientAdjustments
- NetworkMinTimeBetweenClientAdjustmentsLargeCorrection
- NetworkLargeClientCorrectionDistance
#ue4-athena - Perf: (EditMerge CL 3492200 from Dev-Framework): Always reset the input array in AActor::GetComponents(), but do so without affecting allocated size.
#AUTOMERGE using branch //Fortnite/Main-To-//Fortnite/Dev-Athena (reversed) of change#3561669 by Zak.Middleton on 2017/07/28 14:16:19.
#ue4-athena - Perf: (EditMerge CL 3468253 from Dev-AnimPhys): Remove the need for calling constructors for physx PxRaycastHit in the dynamic hit result buffer. Saves 30% of the cost of doing small raycasts.
#AUTOMERGE using branch //Fortnite/Main-To-//Fortnite/Dev-Athena (reversed) of change#3561672 by Zak.Middleton on 2017/07/28 14:17:12.
#ue4-athena - Perf: (EditMerge CL 3359553 from Dev-Framework): Optimization in CharacterMovement tick to not extract transform values twice.
#AUTOMERGE using branch //Fortnite/Main-To-//Fortnite/Dev-Athena (reversed) of change#3561674 by Zak.Middleton on 2017/07/28 14:18:04.
#ue4-athena - Perf: (EditMerge CL 3426174 from Dev-Framework): Avoid call to virtual getSimulationFilterData() to only use it when needed in PreFilter if we actually have items in the IgnoreComponents list (which is rare). The sim filter data 'word2' stores the component ID.
#AUTOMERGE using branch //Fortnite/Main-To-//Fortnite/Dev-Athena (reversed) of change#3561709 by Zak.Middleton on 2017/07/28 14:32:11.
#ue4-athena - Perf: (EditMerge CL 3382054 from Dev-Framework): Optimize CharacterMovementComponent::GetPredictionData_Client_Character() and GetPredictionData_Server_Character() to remove virtual calls.
#AUTOMERGE using branch //Fortnite/Main-To-//Fortnite/Dev-Athena (reversed) of change#3561856 by Zak.Middleton on 2017/07/28 15:11:57.
#ue4-athena - Use less bandwidth for CharacterMovement RPCs when the character is not standing on any component (ie during jumps and falling). Added separate "...NoBase()" versions of ServerMove() and ServerMoveDual().
Undid part of 3557564 and restored the CMC functions to be virtual, and removed virtual keyword from matching Character functions, so that overrides are in one consistent place. Also guarantees backwards compat for licensees.
#AUTOMERGE using branch //Fortnite/Main-To-//Fortnite/Dev-Athena (reversed) of change#3564858 by Zak.Middleton on 2017/07/31 15:24:39.
#jira Fort-1
Change 3562825 by Chris.Gagnon
Added CommonCustomNavigation Widget, this widget can be used to capture navigation requests to handle in custom ways.
#jira FORT-0
Change 3562098 by Josh.Markiewicz
#UE4 Encryption token/ack changes
- moved encryption token request/ack to delegates
- moved FNetworkNotify to NetworkDelegates.h
- moved connection logic out of GameInstance and back into networking code
-- GameInstance sends an enum and the network code does the right thing based on that
#review-3559694 @ryan.gerleve
#tests PC dedicated server connections golden path and forced failures
#jira FORT-0
Change 3559354 by Luke.Thatcher
[FORTNITE] [PS4] [^] Merging (as edit) support for setting flip rate on PS4 (CLs 3555687 and 3558843) from //Fortnite/Dev-Athena/... to //Fortnite/Main/...
- Allowed rates are now 60Hz, 30Hz and 20Hz.
- Exposed by r.PS4FlipRate CVar, set to 60Hz by default. Requires r.Vsync 1.
#jira FORT-49463
Change 3532644 by Jeff.Campeau
Fix mapping current culture to movie audio channels using data table to map languages to track indices.
Don't rewind cinematics (they all start from the begining because we load them and play them once). Seeks cause us to have to redecode video frames at a large perf cost.
Delay cutscene playback by 0.5 seconds to give us time to build up a buffer of decoded video. (Temporary workaround for audio/video sync).
Generic implementation for getting current languages in BP.
Fix more issues with calling into media source functionality when using the source reader (potential hangs).
#jira FORT-44376,FORT-48209,FORT-48040
#testedon Preflight from last night combined with Bob's changes from today clear all known issues. This change tested on Xbox and PC multiple times each.
Change 3527761 by Chris.Gagnon
Fixed various issues in the widget switcher, also added Advanced calls that allow the user to specify if activation/deactivation should occur.
#jira FORT-47988, FORT-47984
Change 3525390 by Jeff.Campeau
Remove media player log spam
#jira FORT-47393
#testedon compiled client
Change 3518692 by Chris.Gagnon
Added CleanOperation Adding which will remove unneeded op combinations from the op queue.
Also added the ability to suspend starting operation queue processing to allow complex operations to accumulate and in turn allow the Clean Op adding code to be effective.
GameFeedback, and the widget switcer utilize this to avoid unnesacary activations of a screen that is immediately being deactivated.
Root issue of the mentioned bug is that activation of the quest screen created a latent navigation du to the deferal of scrolling into view.
This is still an issue in general, there isn't much we can do about it. Other than avoid activating a panel that will deactivated that frame as we did with the code changes in this CL.
#jira FORT-47395
Change 3514658 by Jeff.Campeau
Fixed a media player threading issue where the OnMediaOpened event could be called before the media Init script completed.
Moved the event Cinematic used when setting up and playing media after media file load to use a delayed event from the MovieWidget so that it will always happen after the movie widget processing.
Fixed an issue that could cause samples to leak in MfMedia plugin and cause ReadSample to lockup.
Fixed an issue where a default texture is displayed for movies before the movie starts playing (the player may be active before the first frame of the video is decoded). Default is now all black as it is expected that this texture will be displayed for several frames.
#jira FORT-46801
#testedon Xbox through rocket launch cinematic including vintertip for stairs, skill tree nodes, and victory result video
Change 3507896 by Ryan.Gerleve
Changed the net.UseEncryptionToken to be more useful and renamed it to net.AllowEncryption.
This cvar, if 0, will prevent the PacketHandler from adding the configured encryption component, and prevent UPendingNetGame and AOnlineBeaconClient from filling out the EncryptionToken parameter of NMT_Hello - which prevents the extra encryption handshake connection step.
#jira FORT-46878
#review-3507897 @josh.markiewicz
Change 3503928 by Ryan.Gerleve
Add safety checks around some of the encryption functionality. Fixes a server crash seen during load testing.
#jira FORT-46772
#review-3503929 bob.tellez
#robomerge ReleaseNext
[CL 3673993 by Bob Tellez in Main branch]
Ben Marsh
Bob Tellez
Arciel Rekman