Fix for AddressSanitizer: stack-use-after-scope in FCustomVersionContainer::SetVersionUsingRegistry

#preflight 646e4124f85111e06caa45ec
#rb none
[FYI] steve.robb

[CL 25614963 by sergio gardeazabal in ue5-main branch]
This commit is contained in:
sergio gardeazabal
2023-05-24 19:34:34 -04:00
parent 455021df94
commit eb87ac278e
@@ -415,13 +415,17 @@ void FCustomVersionContainer::SetVersionUsingRegistry(FGuid CustomKey, ESetCusto
return;
}
const FCustomVersion& RegisteredVersion = FCurrentCustomVersions::Get(CustomKey).GetValue();
Found->Version = RegisteredVersion.Version;
Found->FriendlyName = RegisteredVersion.FriendlyName;
TOptional<FCustomVersion> RegisteredVersion = FCurrentCustomVersions::Get(CustomKey);
checkf(RegisteredVersion, TEXT("Attempted to set a version that is not registered"));
Found->Version = RegisteredVersion->Version;
Found->FriendlyName = RegisteredVersion->FriendlyName;
}
else
{
const FCustomVersion& RegisteredVersion = FCurrentCustomVersions::Get(CustomKey).GetValue();
Versions.Emplace(FCustomVersion(CustomKey, RegisteredVersion.Version, RegisteredVersion.FriendlyName));
TOptional<FCustomVersion> RegisteredVersion = FCurrentCustomVersions::Get(CustomKey);
checkf(RegisteredVersion, TEXT("Attempted to set a version that is not registered"));
Versions.Emplace(FCustomVersion(CustomKey, RegisteredVersion->Version, RegisteredVersion->FriendlyName));
}
}