izzy/UnrealEngineUWP
0
0
Fork 0
mirror of https://github.com/izzy2lost/UnrealEngineUWP.git synced 2026-03-26 18:15:20 -07:00
Code Issues Packages Projects Releases Wiki Activity

[Solidworks] Fixed Datasmith plugin preventing proper shutdown of Solidworks

Browse Source 
- repro: run SW, make Datasmith addin enabled, open a model and Sync it, then exit SW. Expected: Solidwokrs process exits(check in TaskManager as it can have its window destroyed but not process itself).

#jira none
#preflight 63ee26b77d2ec3d2fda510e6
#rb JeanLuc.Corenthin

[CL 24277710 by kerim borchaev in ue5-main branch]
This commit is contained in:
kerim borchaev
2023-02-16 23:27:46 -05:00
parent 9eb085795d
commit de540d62e8
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Engine/Source/Programs/Enterprise/Datasmith/DatasmithSolidworksExporter/Private/Addin.cs
+10
View File
@@ -202,6 +202,13 @@ namespace DatasmithSolidworks
return true;
}
private static int OnAppDestroy()
{
// Calling this only on App exit(see comment below)
FDatasmithFacadeDirectLink.Shutdown();
return 0;
}
public bool DisconnectFromSW()
{
// Disabled Shutdown as Initing again crashes if the plugin is re-enabled in SW
@@ -325,6 +332,7 @@ namespace DatasmithSolidworks
AppEvents.FileCloseNotify += new DSldWorksEvents_FileCloseNotifyEventHandler(OnFileClose);
AppEvents.CommandCloseNotify += new DSldWorksEvents_CommandCloseNotifyEventHandler(OnCommandClose);
AppEvents.OnIdleNotify += new DSldWorksEvents_OnIdleNotifyEventHandler(OnIdle);
AppEvents.DestroyNotify += OnAppDestroy;
}
catch {}
}
@@ -340,6 +348,8 @@ namespace DatasmithSolidworks
AppEvents.FileCloseNotify -= new DSldWorksEvents_FileCloseNotifyEventHandler(OnFileClose);
AppEvents.CommandCloseNotify -= new DSldWorksEvents_CommandCloseNotifyEventHandler(OnCommandClose);
AppEvents.OnIdleNotify -= new DSldWorksEvents_OnIdleNotifyEventHandler(OnIdle);
// AppEvents.DestroyNotify - don't teach destroy handler as Detach is called in DisconnectFromSW(which also executed on addin disable)
// and we need this handler to shutdown DirectLink(with all the Unreal engine) that we can do only once
}
catch {}
}