izzy/UnrealEngineUWP
0
0
Fork 0
mirror of https://github.com/izzy2lost/UnrealEngineUWP.git synced 2026-03-26 18:15:20 -07:00
Code Issues Packages Projects Releases Wiki Activity

Fixing lots of places which created USTRUCTs with operator new and passed them to FMessageEndpoint::Publish or Send, wich crashes when ASAN is used.

Browse Source 
The messaging system destroys these objects with FMemory::Free, which has different alignment logic than operator new when ASAN is used, resulting in a crash.

#jira none
#rnx
#rb Jerome.Delattre, Matt.Peters

#ROBOMERGE-SOURCE: CL 17116813 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v855-17104924)

[CL 17116851 by mihnea balta in ue5-release-engine-test branch]
This commit is contained in:
mihnea balta
2021-08-10 10:58:07 -04:00
parent be05ec480b
commit cfe83027c3
27 changed files with 84 additions and 108 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Engine/Source/Runtime/SessionServices/Private/SessionInstanceInfo.cpp
+2 -2
View File
@@ -73,7 +73,7 @@ void FSessionInstanceInfo::ExecuteCommand(const FString& CommandString)
{
if (MessageEndpoint.IsValid() && EngineAddress.IsValid())
{
MessageEndpoint->Send(new FEngineServiceExecuteCommand(CommandString, FPlatformProcess::UserName(false)), EngineAddress);
MessageEndpoint->Send(FMessageEndpoint::MakeMessage<FEngineServiceExecuteCommand>(CommandString, FPlatformProcess::UserName(false)), EngineAddress);
}
}
@@ -82,7 +82,7 @@ void FSessionInstanceInfo::Terminate()
{
if (MessageEndpoint.IsValid() && EngineAddress.IsValid())
{
MessageEndpoint->Send(new FEngineServiceTerminate(FPlatformProcess::UserName(false)), EngineAddress);
MessageEndpoint->Send(FMessageEndpoint::MakeMessage<FEngineServiceTerminate>(FPlatformProcess::UserName(false)), EngineAddress);
}
}