izzy/UnrealEngineUWP
0
0
Fork 0
mirror of https://github.com/izzy2lost/UnrealEngineUWP.git synced 2026-03-26 18:15:20 -07:00
Code Issues Packages Projects Releases Wiki Activity

Modified the source control submit window opened from the changelist window:

Browse Source 
- Supported editing the changelist and saving it in P4. If the submit fails, the code will also try to save any edited changelist description.
  - Enabled the 'keep checked out' button when submitting from the changelist window.
  - Fixed the P4 cache not properly updating the file 'kept in checkout'.
  - If the submit window is opened from the Source Control menu at the bottom right of the Eitor, the new 'Update' button to save the changelist description is not visible, this is not supported for all source control provider.

Added a delay of 1.5 seconds before showing the slow stack in the changelist window when refreshing the UI.

#jira UE-155238 - Add the option to "keep file in checkout"
#jira UE-155235 - Allow the user to save the description from the submit window.
#rb Patrick.Enfedaque
#preflight 6303e4e75a5d4e4624f5ab6d

[CL 21512088 by patrick laflamme in ue5-main branch]
This commit is contained in:
patrick laflamme
2022-08-23 13:05:52 -04:00
parent 8d6ab0d952
commit bff7926319
6 changed files with 143 additions and 97 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Engine/Source/Editor/SourceControlWindows/Private/SSourceControlChangelists.h
-18
View File
@@ -141,26 +141,11 @@ private:
void RestoreExpandedAndSelectionStates(const FExpandedAndSelectionStates& InStates);
TSharedRef<SWidget> MakeToolBar();
/**
* Returns a new changelist description if needed, appending validation tag.
*
* @param bInValidationResult The result of the validation step
* @param InOriginalChangelistDescription Description of the changelist before modification
*
* @return The new changelist description
*/
FText UpdateChangelistDescriptionToSubmitIfNeeded(const bool bInValidationResult, const FText& InOriginalChangelistDescription) const;
/** Returns true if the provided changelist description contains a validation tag. */
bool HasValidationTag(const FText& InChangelistDescription) const;
/** Executes an operation to updates the changelist description of the provided changelist with a new description. */
void EditChangelistDescription(const FText& InNewChangelistDescription, const FSourceControlChangelistStatePtr& InChangelistState);
private:
/** Tag to append to a changelist that passed validation */
static const FText ChangelistValidatedTag;
TSharedPtr<SExpandableChangelistArea> ChangelistExpandableArea;
TSharedPtr<SExpandableChangelistArea> UncontrolledChangelistExpandableArea;
@@ -182,9 +167,6 @@ private:
/** Source control state changed delegate handle */
FDelegateHandle SourceControlStateChangedDelegateHandle;
/** Uncontrolled Changelist changed delegate handle */
FDelegateHandle UncontrolledChangelistChangedDelegateHandle;
bool bShouldRefresh = false;
bool bSourceControlAvailable = false;