From b2acdadf67c052d41c8b899b535520faca6e8ad1 Mon Sep 17 00:00:00 2001 From: Ben Marsh Date: Sun, 27 Sep 2015 13:10:21 -0400 Subject: [PATCH] Remove unnecessary UEBuildTarget parameter being passed to build platforms. [CL 2707256 by Ben Marsh in Main branch] --- .../Programs/UnrealBuildTool/Android/UEBuildAndroid.cs | 2 +- .../UnrealBuildTool/Configuration/UEBuildPlatform.cs | 5 ++--- .../Programs/UnrealBuildTool/Configuration/UEBuildTarget.cs | 2 +- Engine/Source/Programs/UnrealBuildTool/Linux/UEBuildLinux.cs | 3 +-- Engine/Source/Programs/UnrealBuildTool/WinRT/UEBuildWinRT.cs | 3 +-- 5 files changed, 6 insertions(+), 9 deletions(-) diff --git a/Engine/Source/Programs/UnrealBuildTool/Android/UEBuildAndroid.cs b/Engine/Source/Programs/UnrealBuildTool/Android/UEBuildAndroid.cs index 68fc19f8e1e4..f3bf862f9d1e 100644 --- a/Engine/Source/Programs/UnrealBuildTool/Android/UEBuildAndroid.cs +++ b/Engine/Source/Programs/UnrealBuildTool/Android/UEBuildAndroid.cs @@ -292,7 +292,7 @@ namespace UnrealBuildTool return true; } - public override void GetExtraModules(TargetInfo Target, UEBuildTarget BuildTarget, ref List PlatformExtraModules) + public override void GetExtraModules(TargetInfo Target, List PlatformExtraModules) { } diff --git a/Engine/Source/Programs/UnrealBuildTool/Configuration/UEBuildPlatform.cs b/Engine/Source/Programs/UnrealBuildTool/Configuration/UEBuildPlatform.cs index 91d36b4ebe21..15f243c1e731 100644 --- a/Engine/Source/Programs/UnrealBuildTool/Configuration/UEBuildPlatform.cs +++ b/Engine/Source/Programs/UnrealBuildTool/Configuration/UEBuildPlatform.cs @@ -125,9 +125,8 @@ namespace UnrealBuildTool /// This is to allow undisclosed platforms to add modules they need without exposing information about the platform. /// /// The target being build - /// The UEBuildTarget getting build /// OUTPUT the list of extra modules the platform needs to add to the target - void GetExtraModules(TargetInfo Target, UEBuildTarget BuildTarget, ref List PlatformExtraModules); + void GetExtraModules(TargetInfo Target, List PlatformExtraModules); /// /// Modify the newly created module passed in for this platform. @@ -591,7 +590,7 @@ namespace UnrealBuildTool /// The target being build /// The UEBuildTarget getting build /// OUTPUT the list of extra modules the platform needs to add to the target - public virtual void GetExtraModules(TargetInfo Target, UEBuildTarget BuildTarget, ref List PlatformExtraModules) + public virtual void GetExtraModules(TargetInfo Target, List PlatformExtraModules) { } diff --git a/Engine/Source/Programs/UnrealBuildTool/Configuration/UEBuildTarget.cs b/Engine/Source/Programs/UnrealBuildTool/Configuration/UEBuildTarget.cs index 78a18e24771e..8e05d5698236 100644 --- a/Engine/Source/Programs/UnrealBuildTool/Configuration/UEBuildTarget.cs +++ b/Engine/Source/Programs/UnrealBuildTool/Configuration/UEBuildTarget.cs @@ -3050,7 +3050,7 @@ namespace UnrealBuildTool { var BuildPlatform = UEBuildPlatform.GetBuildPlatform(Platform); List PlatformExtraModules = new List(); - BuildPlatform.GetExtraModules(TargetInfo, this, ref PlatformExtraModules); + BuildPlatform.GetExtraModules(TargetInfo, PlatformExtraModules); ExtraModuleNames.AddRange(PlatformExtraModules); } diff --git a/Engine/Source/Programs/UnrealBuildTool/Linux/UEBuildLinux.cs b/Engine/Source/Programs/UnrealBuildTool/Linux/UEBuildLinux.cs index 65be29f5b1ca..5e95f820f510 100644 --- a/Engine/Source/Programs/UnrealBuildTool/Linux/UEBuildLinux.cs +++ b/Engine/Source/Programs/UnrealBuildTool/Linux/UEBuildLinux.cs @@ -264,9 +264,8 @@ namespace UnrealBuildTool /// This is to allow undisclosed platforms to add modules they need without exposing information about the platfomr. /// /// The target being build - /// The UEBuildTarget getting build /// OUTPUT the list of extra modules the platform needs to add to the target - public override void GetExtraModules(TargetInfo Target, UEBuildTarget BuildTarget, ref List PlatformExtraModules) + public override void GetExtraModules(TargetInfo Target, List PlatformExtraModules) { } diff --git a/Engine/Source/Programs/UnrealBuildTool/WinRT/UEBuildWinRT.cs b/Engine/Source/Programs/UnrealBuildTool/WinRT/UEBuildWinRT.cs index 6683e5fdd3c5..f81afdc0ec5e 100644 --- a/Engine/Source/Programs/UnrealBuildTool/WinRT/UEBuildWinRT.cs +++ b/Engine/Source/Programs/UnrealBuildTool/WinRT/UEBuildWinRT.cs @@ -218,9 +218,8 @@ namespace UnrealBuildTool /// This is to allow undisclosed platforms to add modules they need without exposing information about the platfomr. /// /// The target being build - /// The UEBuildTarget getting build /// OUTPUT the list of extra modules the platform needs to add to the target - public override void GetExtraModules(TargetInfo Target, UEBuildTarget BuildTarget, ref List PlatformExtraModules) + public override void GetExtraModules(TargetInfo Target, List PlatformExtraModules) { if (Target.Platform == UnrealTargetPlatform.WinRT) {