Horde: Improve diagnostic output from compute command.

#preflight none

[CL 18791170 by Ben Marsh in ue5-main branch]
This commit is contained in:
Ben Marsh
2022-01-31 11:36:14 -05:00
parent d6284950fe
commit 9ab4221e40
2 changed files with 7 additions and 1 deletions

View File

@@ -248,6 +248,10 @@ namespace HordeAgent.Commands
}
if (Response.State == ComputeTaskState.Complete)
{
if (Response.Outcome != ComputeTaskOutcome.Success)
{
Logger.LogError("{OperationName}: Outcome: {Outcome}, Detail: {Detail}", Response.TaskRefId, Response.Outcome.ToString(), Response.Detail ?? "(none)");
}
break;
}
}

View File

@@ -240,6 +240,7 @@ namespace HordeServer.Compute.Impl
ComputeTaskStatus Status = new ComputeTaskStatus(ComputeTask.TaskRefId, ComputeTaskState.Complete, null, null);
Status.Outcome = ComputeTaskOutcome.Expired;
Status.Outcome = $"No agents monitoring queue {QueueKey}";
Logger.LogInformation("Compute task expired (queue: {RequirementsHash}, task: {TaskHash}, channel: {ChannelId})", QueueKey, ComputeTask.TaskRefId, ComputeTask.ChannelId);
await PostStatusMessageAsync(ComputeTask, Status);
}
@@ -480,7 +481,8 @@ namespace HordeServer.Compute.Impl
ComputeTaskStatus Status = new ComputeTaskStatus(ComputeTask.TaskRefId, ComputeTaskState.Complete, null, null);
Status.Outcome = ComputeTaskOutcome.BlobNotFound;
Logger.LogInformation("Compute task failed due to missing requirements (queue: {RequirementsHash}, task: {TaskHash}, channel: {ChannelId})", QueueKey, ComputeTask.TaskRefId, ComputeTask.ChannelId);
Status.Detail = $"Missing requirements object {QueueKey.RequirementsHash}";
Logger.LogInformation("Compute task failed due to missing requirements (queue: {QueueKey}, task: {TaskHash}, channel: {ChannelId})", QueueKey, ComputeTask.TaskRefId, ComputeTask.ChannelId);
await PostStatusMessageAsync(ComputeTask, Status);
}
}