izzy/UnrealEngineUWP
0
0
Fork 0
mirror of https://github.com/izzy2lost/UnrealEngineUWP.git synced 2026-03-26 18:15:20 -07:00
Code Issues Packages Projects Releases Wiki Activity

Settings: Various improvements to the API

Browse Source 
- made public headers compilable individually
- easier access to settings section delegates
- removed module singleton accessor
- moved non-trivial definitions into cpp files
- code & documentation cleanup

#UpgradeNotes:

- instead of ISettingsModule::Get() use FModuleManager::GetModulePtr<ISettingsModule>("Settings")
- instead of using FSettingsSectionDelegates assign delegates directly through the new ISettingsSection methods

[CL 2340711 by Max Preussner in Main branch]
This commit is contained in:
Max Preussner
2014-10-27 07:53:18 -04:00
committed by UnrealBot
parent 92aede9c8d
commit 9884344213
68 changed files with 1157 additions and 1025 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
Engine/Source/Developer/SourceCodeAccess/Private/SourceCodeAccessModule.cpp
View File

@@ -2,9 +2,11 @@
#include "SourceCodeAccessPrivatePCH.h"
#include "Runtime/Core/Public/Features/IModularFeatures.h"
#include "ISettingsModule.h"
#include "ModuleManager.h"
#include "SourceCodeAccessModule.h"
#include "SourceCodeAccessSettings.h"
#include "Settings.h"
IMPLEMENT_MODULE( FSourceCodeAccessModule, SourceCodeAccess );
@@ -12,10 +14,11 @@ IMPLEMENT_MODULE( FSourceCodeAccessModule, SourceCodeAccess );
static FName SourceCodeAccessorFeatureName(TEXT("SourceCodeAccessor"));
FSourceCodeAccessModule::FSourceCodeAccessModule()
: CurrentSourceCodeAccessor(nullptr)
{
}
{ }
void FSourceCodeAccessModule::StartupModule()
{
@@ -29,7 +32,8 @@ void FSourceCodeAccessModule::StartupModule()
IModularFeatures::Get().RegisterModularFeature(SourceCodeAccessorFeatureName, &DefaultSourceCodeAccessor);
// Register to display our settings
ISettingsModule* SettingsModule = ISettingsModule::Get();
ISettingsModule* SettingsModule = FModuleManager::GetModulePtr<ISettingsModule>("Settings");
if (SettingsModule != nullptr)
{
SettingsModule->RegisterSettings("Editor", "General", "Source Code",
@@ -40,10 +44,12 @@ void FSourceCodeAccessModule::StartupModule()
}
}
void FSourceCodeAccessModule::ShutdownModule()
{
// Unregister our settings
ISettingsModule* SettingsModule = ISettingsModule::Get();
ISettingsModule* SettingsModule = FModuleManager::GetModulePtr<ISettingsModule>("Settings");
if (SettingsModule != nullptr)
{
SettingsModule->UnregisterSettings("Editor", "General", "Source Code");
@@ -57,16 +63,19 @@ void FSourceCodeAccessModule::ShutdownModule()
IModularFeatures::Get().OnModularFeatureUnregistered().RemoveAll(this);
}
bool FSourceCodeAccessModule::CanAccessSourceCode() const
{
return CurrentSourceCodeAccessor->CanAccessSourceCode();
}
ISourceCodeAccessor& FSourceCodeAccessModule::GetAccessor() const
{
return *CurrentSourceCodeAccessor;
}
void FSourceCodeAccessModule::SetAccessor(const FName& InName)
{
const int32 FeatureCount = IModularFeatures::Get().GetModularFeatureImplementationCount(SourceCodeAccessorFeatureName);
@@ -89,6 +98,7 @@ void FSourceCodeAccessModule::SetAccessor(const FName& InName)
}
}
FLaunchingCodeAccessor& FSourceCodeAccessModule::OnLaunchingCodeAccessor()
{
return LaunchingCodeAccessorDelegate;
@@ -99,11 +109,13 @@ FDoneLaunchingCodeAccessor& FSourceCodeAccessModule::OnDoneLaunchingCodeAccessor
return DoneLaunchingCodeAccessorDelegate;
}
FOpenFileFailed& FSourceCodeAccessModule::OnOpenFileFailed()
{
return OpenFileFailedDelegate;
}
void FSourceCodeAccessModule::HandleModularFeatureRegistered(const FName& Type, IModularFeature* ModularFeature)
{
if(Type == SourceCodeAccessorFeatureName)
@@ -133,6 +145,7 @@ void FSourceCodeAccessModule::HandleModularFeatureRegistered(const FName& Type,
}
}
void FSourceCodeAccessModule::HandleModularFeatureUnregistered(const FName& Type, IModularFeature* ModularFeature)
{
if(Type == SourceCodeAccessorFeatureName && CurrentSourceCodeAccessor == static_cast<ISourceCodeAccessor*>(ModularFeature))
@@ -141,4 +154,5 @@ void FSourceCodeAccessModule::HandleModularFeatureUnregistered(const FName& Type
}
}
#undef LOCTEXT_NAMESPACE
#undef LOCTEXT_NAMESPACE