izzy/UnrealEngineUWP
0
0
Fork 0
mirror of https://github.com/izzy2lost/UnrealEngineUWP.git synced 2026-03-26 18:15:20 -07:00
Code Issues Packages Projects Releases Wiki Activity

RT polling fixes. Still disabled by default.

Browse Source 
- Fixed assertion related to stall queue being used in stalling mode when the RT uses it in polling mode.
- Added csv stat to show the delay between FDrawSceneCommand enqueue and execution on the RT.
- Changed ProcessTasksNamedThread RT check to use ThreadId instead of IsInRenderingThread. This makes it consistent with the RT check in EnqueueFromOtherThread.

#jira UE-91598, FORT-269443
#rb andriy.tylychko
#rnx

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: jordan.cristiano
#ROBOMERGE-SOURCE: CL 12830260 via CL 12847809 via CL 12847849 via CL 12847913 via CL 12847983
#ROBOMERGE-BOT: NETWORKING (Main -> Dev-Networking) (v682-12900288)

[CL 12915327 by jordan cristiano in Dev-Networking branch]
This commit is contained in:
jordan cristiano
2020-04-20 04:22:55 -04:00
parent e8ca0d4b00
commit 3038640b0d
2 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
Engine/Source/Runtime/Core/Private/Async/TaskGraph.cpp
View File

@@ -680,9 +680,11 @@ public:
ProcessingTasks.Start(StatName);
}
#endif
const bool bIsRenderThread = (ENamedThreads::GetThreadIndex(ThreadId) == ENamedThreads::GetRenderThread());
while (!Queue(QueueIndex).QuitForReturn)
{
FBaseGraphTask* Task = Queue(QueueIndex).StallQueue.Pop(0, bAllowStall);
const bool bStallQueueAllowStall = bAllowStall && (!bIsRenderThread || GDoRenderThreadWakeupTrigger);
FBaseGraphTask* Task = Queue(QueueIndex).StallQueue.Pop(0, bStallQueueAllowStall);
TestRandomizedThreads();
if (!Task)
{
@@ -697,7 +699,7 @@ public:
{
{
FScopeCycleCounter Scope(StallStatId);
Queue(QueueIndex).StallRestartEvent->Wait(IsInRenderingThread() ? GRenderThreadPollPeriodMs : MAX_uint32, bCountAsStall);
Queue(QueueIndex).StallRestartEvent->Wait(bIsRenderThread ? GRenderThreadPollPeriodMs : MAX_uint32, bCountAsStall);
if (Queue(QueueIndex).QuitForShutdown)
{
return ProcessedTasks;
@@ -777,7 +779,8 @@ public:
if (ThreadToStart >= 0)
{
checkThreadGraph(ThreadToStart == 0);
if ((ENamedThreads::GetThreadIndex(Task->ThreadToExecuteOn) != ENamedThreads::GetRenderThread()) || GDoRenderThreadWakeupTrigger)
const bool bExecuteOnRenderThread = (ENamedThreads::GetThreadIndex(Task->ThreadToExecuteOn) == ENamedThreads::GetRenderThread());
if (!bExecuteOnRenderThread || GDoRenderThreadWakeupTrigger)
{
QUICK_SCOPE_CYCLE_COUNTER(STAT_TaskGraph_EnqueueFromOtherThread_Trigger);
TASKGRAPH_SCOPE_CYCLE_COUNTER(1, STAT_TaskGraph_EnqueueFromOtherThread_Trigger);

6
Engine/Source/Runtime/Renderer/Private/SceneRendering.cpp
View File

@@ -3716,9 +3716,13 @@ void FRendererModule::BeginRenderingViewFamily(FCanvas* Canvas, FSceneViewFamily
SceneRenderer->ViewFamily.DisplayInternalsData.Setup(World);
const uint32 DrawSceneEnqueue = FPlatformTime::Cycles();
ENQUEUE_RENDER_COMMAND(FDrawSceneCommand)(
[SceneRenderer](FRHICommandListImmediate& RHICmdList)
[SceneRenderer, DrawSceneEnqueue](FRHICommandListImmediate& RHICmdList)
{
const float StartDelayMillisec = FPlatformTime::ToMilliseconds(FPlatformTime::Cycles() - DrawSceneEnqueue);
CSV_CUSTOM_STAT_GLOBAL(DrawSceneCommand_StartDelay, StartDelayMillisec, ECsvCustomStatOp::Set);
RenderViewFamily_RenderThread(RHICmdList, SceneRenderer);
FlushPendingDeleteRHIResources_RenderThread();
});