izzy/UnrealEngineUWP
0
0
Fork 0
mirror of https://github.com/izzy2lost/UnrealEngineUWP.git synced 2026-03-26 18:15:20 -07:00
Code Issues Packages Projects Releases Wiki Activity

Constraint & additive ControlRig:

Browse Source 
In the context of additive rigs, the evaluation as to be forced after setting the control value to request keyframing thru the OnControlModified delegate.
    Not doing this results in the keys not being added (FControlRigParameterTrackEditor::HandleControlModified is not in game thread when evaluating the additive rig) so there's not new FMovieSceneRootEvaluationTemplateInstance created

NOTE
   Calling Evaluate_AnyThread here will force the update off every controls whereas we're just trying to add keys on a single one. Having a function taht could only compute the additive value on a set of keys could help reducing the cost but there might be some side effets as well.
   Leaving this as it is for now as additive rigs are still experimental atm.

#jira UE-193993
#rb sara.schvartzman

#rnx

[CL 27707896 by benoit gadreau in ue5-main branch]
This commit is contained in:
benoit gadreau
2023-09-08 07:45:31 -04:00
parent 5da8ce3238
commit 2418883c42
1 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
Engine/Plugins/Animation/ControlRig/Source/ControlRig/Private/Constraints/ControlRigTransformableHandle.cpp
View File

@@ -489,9 +489,19 @@ bool UTransformableControlHandle::AddTransformKeys(const TArray<FFrameNumber>& I
if (bLocal)
{
return InControlRig->SetControlLocalTransform(ControlName, InTransform, bNotify, InKeyframeContext, bUndo, bFixEuler);
InControlRig->SetControlLocalTransform(ControlName, InTransform, bNotify, InKeyframeContext, bUndo, bFixEuler);
if (InControlRig->IsAdditive())
{
InControlRig->Evaluate_AnyThread();
}
return;
}
InControlRig->SetControlGlobalTransform(ControlName, InTransform, bNotify, InKeyframeContext, bUndo, bFixEuler);
if (InControlRig->IsAdditive())
{
InControlRig->Evaluate_AnyThread();
}
};
FRigControlModifiedContext KeyframeContext;