izzy/UnrealEngineUWP
0
0
Fork 0
mirror of https://github.com/izzy2lost/UnrealEngineUWP.git synced 2026-03-26 18:15:20 -07:00
Code Issues Packages Projects Releases Wiki Activity

When opening at a given file & line in Xcode make sure that the project file exists before trying to execute the Applescript, or it won't work.

Browse Source 
[CL 2618149 by Mark Satterthwaite in Main branch]
This commit is contained in:
Mark Satterthwaite
2015-07-13 09:52:26 -04:00
committed by Mark.Satterthwaite@epicgames.com
parent 9b089462cd
commit 185f391325
1 changed files with 79 additions and 72 deletions
Download Patch File Download Diff File Expand all files Collapse all files

151
Engine/Plugins/Developer/XCodeSourceCodeAccess/Source/XCodeSourceCodeAccess/Private/XCodeSourceCodeAccessor.cpp
View File

@@ -21,14 +21,16 @@ static const char* OpenXCodeAtFileAndLineAppleScript =
" tell process \"Xcode\"\n"
" \n"
" if theOffset is not 1 then\n"
" set bActivated to false\n"
" repeat until window \"Open Quickly\" exists\n"
" tell application \"Xcode\"\n"
" if application \"Xcode\" is not frontmost then\n"
" activate\n"
" end if\n"
" end tell\n"
" if application \"Xcode\" is frontmost then\n"
" if application \"Xcode\" is frontmost and bActivated is false then\n"
" keystroke \"o\" using {command down, shift down}\n"
" set bActivated to true\n"
" end if\n"
" end repeat\n"
" click text field 1 of window \"Open Quickly\"\n"
@@ -36,14 +38,16 @@ static const char* OpenXCodeAtFileAndLineAppleScript =
" keystroke return\n"
" end if\n"
" \n"
" set bActivated to false\n"
" repeat until window \"Open Quickly\" exists\n"
" tell application \"Xcode\"\n"
" if application \"Xcode\" is not frontmost then\n"
" activate\n"
" end if\n"
" end tell\n"
" if application \"Xcode\" is frontmost then\n"
" if application \"Xcode\" is frontmost and bActivated is false then\n"
" keystroke \"l\" using command down\n"
" set bActivated to true\n"
" end if\n"
" end repeat\n"
" \n"
@@ -114,87 +118,90 @@ bool FXCodeSourceCodeAccessor::OpenFileAtLine(const FString& FullPath, int32 Lin
ColumnNumber++;
}
bool ExecutionSucceeded = false;
FString SolutionPath;
if(FDesktopPlatformModule::Get()->GetSolutionPath(SolutionPath))
{
FString ProjPath = FPaths::ConvertRelativePathToFull(*SolutionPath);
CFStringRef ProjPathString = FPlatformString::TCHARToCFString(*ProjPath);
NSString* ProjectPath = [(NSString*)ProjPathString stringByDeletingLastPathComponent];
[[NSWorkspace sharedWorkspace] openFile:ProjectPath withApplication:@"Xcode" andDeactivate:YES];
}
bool ExecutionSucceeded = false;
NSAppleScript* AppleScript = nil;
NSString* AppleScriptString = [NSString stringWithCString:OpenXCodeAtFileAndLineAppleScript encoding:NSUTF8StringEncoding];
AppleScript = [[NSAppleScript alloc] initWithSource:AppleScriptString];
int PID = [[NSProcessInfo processInfo] processIdentifier];
NSAppleEventDescriptor* ThisApplication = [NSAppleEventDescriptor descriptorWithDescriptorType:typeKernelProcessID bytes:&PID length:sizeof(PID)];
NSAppleEventDescriptor* ContainerEvent = [NSAppleEventDescriptor appleEventWithEventClass:'ascr' eventID:'psbr' targetDescriptor:ThisApplication returnID:kAutoGenerateReturnID transactionID:kAnyTransactionID];
[ContainerEvent setParamDescriptor:[NSAppleEventDescriptor descriptorWithString:@"OpenXcodeAtFileAndLine"] forKeyword:'snam'];
{
NSAppleEventDescriptor* Arguments = [[NSAppleEventDescriptor alloc] initListDescriptor];
CFStringRef FileString = FPlatformString::TCHARToCFString(*FullPath);
NSString* Path = (NSString*)FileString;
if([Path isAbsolutePath] == NO)
const FString ProjPath = IFileManager::Get().ConvertToAbsolutePathForExternalAppForRead( *SolutionPath );
if ( FPaths::FileExists( ProjPath ) )
{
NSString* CurDir = [[NSFileManager defaultManager] currentDirectoryPath];
NSString* ResolvedPath = [[NSString stringWithFormat:@"%@/%@", CurDir, Path] stringByResolvingSymlinksInPath];
if([[NSFileManager defaultManager] fileExistsAtPath:ResolvedPath])
NSString* ProjectPath = [ProjPath.GetNSString() stringByDeletingLastPathComponent];
[[NSWorkspace sharedWorkspace] openFile:ProjectPath withApplication:@"Xcode" andDeactivate:YES];
NSAppleScript* AppleScript = nil;
NSString* AppleScriptString = [NSString stringWithCString:OpenXCodeAtFileAndLineAppleScript encoding:NSUTF8StringEncoding];
AppleScript = [[NSAppleScript alloc] initWithSource:AppleScriptString];
int PID = [[NSProcessInfo processInfo] processIdentifier];
NSAppleEventDescriptor* ThisApplication = [NSAppleEventDescriptor descriptorWithDescriptorType:typeKernelProcessID bytes:&PID length:sizeof(PID)];
NSAppleEventDescriptor* ContainerEvent = [NSAppleEventDescriptor appleEventWithEventClass:'ascr' eventID:'psbr' targetDescriptor:ThisApplication returnID:kAutoGenerateReturnID transactionID:kAnyTransactionID];
[ContainerEvent setParamDescriptor:[NSAppleEventDescriptor descriptorWithString:@"OpenXcodeAtFileAndLine"] forKeyword:'snam'];
{
Path = ResolvedPath;
NSAppleEventDescriptor* Arguments = [[NSAppleEventDescriptor alloc] initListDescriptor];
CFStringRef FileString = FPlatformString::TCHARToCFString(*FullPath);
NSString* Path = (NSString*)FileString;
if([Path isAbsolutePath] == NO)
{
NSString* CurDir = [[NSFileManager defaultManager] currentDirectoryPath];
NSString* ResolvedPath = [[NSString stringWithFormat:@"%@/%@", CurDir, Path] stringByResolvingSymlinksInPath];
if([[NSFileManager defaultManager] fileExistsAtPath:ResolvedPath])
{
Path = ResolvedPath;
}
else // If it doesn't exist, supply only the filename, we'll use Open Quickly to try and find it from Xcode
{
Path = [Path lastPathComponent];
}
}
[Arguments insertDescriptor:[NSAppleEventDescriptor descriptorWithString:Path] atIndex:([Arguments numberOfItems] + 1)];
CFRelease(FileString);
CFStringRef LineString = FPlatformString::TCHARToCFString(*FString::FromInt(LineNumber));
if(LineString)
{
[Arguments insertDescriptor:[NSAppleEventDescriptor descriptorWithString:(NSString*)LineString] atIndex:([Arguments numberOfItems] + 1)];
CFRelease(LineString);
}
else
{
[Arguments insertDescriptor:[NSAppleEventDescriptor descriptorWithString:@"1"] atIndex:([Arguments numberOfItems] + 1)];
}
[ContainerEvent setParamDescriptor:Arguments forKeyword:keyDirectObject];
[Arguments release];
}
else // If it doesn't exist, supply only the filename, we'll use Open Quickly to try and find it from Xcode
NSDictionary* ExecutionError = nil;
[AppleScript executeAppleEvent:ContainerEvent error:&ExecutionError];
if(ExecutionError == nil)
{
Path = [Path lastPathComponent];
ExecutionSucceeded = true;
}
else
{
UE_LOG(LogXcodeAccessor, Error, TEXT("%s"), *FString([ExecutionError description]));
}
[AppleScript release];
// Fallback to trivial implementation when something goes wrong (like not having permission for UI scripting)
if(ExecutionSucceeded == false)
{
FPlatformProcess::LaunchFileInDefaultExternalApplication(*FullPath);
ExecutionSucceeded = true;
}
}
[Arguments insertDescriptor:[NSAppleEventDescriptor descriptorWithString:Path] atIndex:([Arguments numberOfItems] + 1)];
CFRelease(FileString);
CFStringRef LineString = FPlatformString::TCHARToCFString(*FString::FromInt(LineNumber));
if(LineString)
{
[Arguments insertDescriptor:[NSAppleEventDescriptor descriptorWithString:(NSString*)LineString] atIndex:([Arguments numberOfItems] + 1)];
CFRelease(LineString);
}
else
{
[Arguments insertDescriptor:[NSAppleEventDescriptor descriptorWithString:@"1"] atIndex:([Arguments numberOfItems] + 1)];
}
[ContainerEvent setParamDescriptor:Arguments forKeyword:keyDirectObject];
[Arguments release];
}
NSDictionary* ExecutionError = nil;
[AppleScript executeAppleEvent:ContainerEvent error:&ExecutionError];
if(ExecutionError == nil)
{
ExecutionSucceeded = true;
}
else
{
UE_LOG(LogXcodeAccessor, Error, TEXT("%s"), *FString([ExecutionError description]));
}
[AppleScript release];
// Fallback to trivial implementation when something goes wrong (like not having permission for UI scripting)
if(ExecutionSucceeded == false)
{
FPlatformProcess::LaunchFileInDefaultExternalApplication(*FullPath);
}
return true;
return ExecutionSucceeded;
}
bool FXCodeSourceCodeAccessor::OpenSourceFiles(const TArray<FString>& AbsoluteSourcePaths)