izzy/UnrealEngineUWP
0
0
Fork 0
mirror of https://github.com/izzy2lost/UnrealEngineUWP.git synced 2026-03-26 18:15:20 -07:00
Code Issues Packages Projects Releases Wiki Activity

UE-146778 - CIS Content Error: Unhandled implicit casts found during compilation of function

Browse Source 
The BP compiler erroneously reports that python nodes might be missing implicit casts. However, UK2Node_ExecutePythonScript nodes handle argument slightly differently than conventional function nodes. The pins don't actually correspond to actual arguments on ExecutePythonScript. Instead, they more or less serve as references to their linked inputs, which ExecutePythonScript will pop from the stack and perform a direct conversion to a Python type. As a result, there's nothing to cast, and we can safely remove the entries from the ImplicitCastMap on the current content.

#rb jamie.dale
#jira UE-146778
#preflight 623b4fbeca34ffd7bf7db3e8

[CL 19482561 by dave jones2 in ue5-main branch]
This commit is contained in:
dave jones2
2022-03-23 14:24:22 -04:00
parent 10bce07e2a
commit 135eb09732
4 changed files with 43 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
Engine/Plugins/Experimental/PythonScriptPlugin/Source/PythonScriptPlugin/Private/K2Node_ExecutePythonScript.cpp
View File

@@ -13,6 +13,8 @@
#include "Kismet2/BlueprintEditorUtils.h"
#include "BlueprintNodeSpawner.h"
#include "BlueprintActionDatabaseRegistrar.h"
#include "CallFunctionHandler.h"
#include "KismetCastingUtils.h"
#define LOCTEXT_NAMESPACE "K2Node_ExecutePythonScript"
@@ -39,6 +41,37 @@ FString PythonizePinName(const UEdGraphPin* InPin)
}
class FKCHandler_ExecutePythonScript : public FKCHandler_CallFunction
{
public:
FKCHandler_ExecutePythonScript(FKismetCompilerContext& InCompilerContext)
: FKCHandler_CallFunction(InCompilerContext)
{
}
virtual void Compile(FKismetFunctionContext& Context, UEdGraphNode* Node) override
{
using namespace UE::KismetCompiler;
FKCHandler_CallFunction::Compile(Context, Node);
UK2Node_ExecutePythonScript* PythonNode = CastChecked<UK2Node_ExecutePythonScript>(Node);
// The ExecutePythonScript function uses variadic inputs, which obviates the need for implicit casting.
// In other words, ExecutePythonScript's native signature doesn't include the parameters corresponding
// to the inputs pins. As a result, there's nothing to cast the inputs to. Instead, the implementation of
// execExecutePythonScript directly inspects these arguments and converts them to a Python type.
for (FName InputName : PythonNode->Inputs)
{
UEdGraphPin* Pin = PythonNode->FindPinChecked(InputName, EGPD_Input);
if (Pin->PinType.PinCategory == UEdGraphSchema_K2::PC_Real)
{
CastingUtils::RemoveRegisteredImplicitCast(Context, Pin);
}
}
}
};
UK2Node_ExecutePythonScript::UK2Node_ExecutePythonScript()
{
FunctionReference.SetExternalMember(GET_FUNCTION_NAME_CHECKED(UPythonScriptLibrary, ExecutePythonScript), UPythonScriptLibrary::StaticClass());
@@ -289,6 +322,11 @@ void UK2Node_ExecutePythonScript::ExpandNode(FKismetCompilerContext& CompilerCon
Super::ExpandNode(CompilerContext, SourceGraph);
}
class FNodeHandlingFunctor* UK2Node_ExecutePythonScript::CreateNodeHandler(class FKismetCompilerContext& CompilerContext) const
{
return new FKCHandler_ExecutePythonScript(CompilerContext);
}
bool UK2Node_ExecutePythonScript::CanPasteHere(const UEdGraph* TargetGraph) const
{
bool bCanPaste = Super::CanPasteHere(TargetGraph);

3
Engine/Plugins/Experimental/PythonScriptPlugin/Source/PythonScriptPlugin/Private/K2Node_ExecutePythonScript.h
View File

@@ -33,6 +33,7 @@ class UK2Node_ExecutePythonScript : public UK2Node_CallFunction
//~ Begin UK2Node Interface.
virtual void EarlyValidation(class FCompilerResultsLog& MessageLog) const override;
virtual void ExpandNode(class FKismetCompilerContext& CompilerContext, UEdGraph* SourceGraph) override;
virtual class FNodeHandlingFunctor* CreateNodeHandler(class FKismetCompilerContext& CompilerContext) const override;
virtual bool CanPasteHere(const UEdGraph* TargetGraph) const override;
virtual bool IsActionFilteredOut(const class FBlueprintActionFilter& Filter) override;
virtual void GetMenuActions(FBlueprintActionDatabaseRegistrar& ActionRegistrar) const override;
@@ -48,6 +49,8 @@ private:
UEdGraphPin* FindArgumentPinChecked(const FName PinName, EEdGraphPinDirection PinDirection = EGPD_MAX);
private:
friend class FKCHandler_ExecutePythonScript;
/** User-defined input pins */
UPROPERTY(EditAnywhere, Category="Arguments")
TArray<FName> Inputs;

1
Engine/Plugins/Experimental/PythonScriptPlugin/Source/PythonScriptPlugin/PythonScriptPlugin.Build.cs
View File

@@ -42,6 +42,7 @@ namespace UnrealBuildTool.Rules
PrivateDependencyModuleNames.AddRange(
new string[] {
"BlueprintGraph",
"DesktopPlatform",
"EditorStyle",
"LevelEditor",