izzy/UnrealEngineUWP
0
0
Fork 0
mirror of https://github.com/izzy2lost/UnrealEngineUWP.git synced 2026-03-26 18:15:20 -07:00
Code Issues Packages Projects Releases Wiki Activity

[Solidworks] Refactor - ComVisible removal

Browse Source 
- made ComVisible false by default  - simplifies code and doesn't expose unneeded types

#jira none
#preflight 63c6eb350b358b97d1abb126
#rb benoit.deschenes

[CL 23826729 by kerim borchaev in ue5-main branch]
This commit is contained in:
kerim borchaev
2023-01-23 23:01:56 -05:00
parent 1d92b83cac
commit 06f70ac5c5
23 changed files with 2 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Engine/Source/Programs/Enterprise/Datasmith/DatasmithSolidworksExporter/DatasmithSolidworks/Properties/AssemblyInfo.cs
+2 -2
View File
@@ -61,5 +61,5 @@ using System.Runtime.InteropServices;
[assembly: AssemblyKeyName("")]
[assembly: AssemblyFileVersion("1.0.0.21")]
// todo: We don't need com visibility for every class. Only for the Addin and whatever we'd want to expose and automation API
// [assembly: ComVisible(false)]
// We don't need com visibility for every class. Only for the Addin and whatever we'd want to expose as automation API
[assembly: ComVisible(false)]
Engine/Source/Programs/Enterprise/Datasmith/DatasmithSolidworksExporter/Private/Body.cs
-2
View File
@@ -9,14 +9,12 @@ using System.Collections.Concurrent;
namespace DatasmithSolidworks
{
[ComVisible(false)]
public class FBody
{
public List<FBodyFace> Faces { get; set; } = new List<FBodyFace>();
public Body2 Body { get; private set; } = null;
public FBoundingBox Bounds { get; private set; }
[ComVisible(false)]
public class FBodyFace
{
public Face2 Face { get; private set; } = null;
Engine/Source/Programs/Enterprise/Datasmith/DatasmithSolidworksExporter/Private/BoundingBox.cs
-1
View File
@@ -5,7 +5,6 @@ using System.Runtime.InteropServices;
namespace DatasmithSolidworks
{
[ComVisible(false)]
public class FBoundingBox
{
public FVec3 Min { get; private set; }
Engine/Source/Programs/Enterprise/Datasmith/DatasmithSolidworksExporter/Private/ConfigurationExporter.cs
-5
View File
@@ -13,7 +13,6 @@ using static DatasmithSolidworks.FConfigurationTree;
namespace DatasmithSolidworks
{
[ComVisible(false)]
public class FConfigurationData
{
public string Name;
@@ -22,7 +21,6 @@ namespace DatasmithSolidworks
public Dictionary<FComponentName, bool> ComponentVisibility = new Dictionary<FComponentName, bool>();
public Dictionary<FComponentName, FObjectMaterials> ComponentMaterials = new Dictionary<FComponentName, FObjectMaterials>();
[ComVisible(false)]
public struct FComponentGeometryVariant
{
public FActorName VisibleActor; // Actor enabled for this variant
@@ -40,14 +38,12 @@ namespace DatasmithSolidworks
}
};
[ComVisible(false)]
public class FMeshes
{
private Dictionary<string, FConfiguration> Configurations = new Dictionary<string, FConfiguration>();
private HashSet<FMesh> Meshes = new HashSet<FMesh>();
[ComVisible(false)]
public struct FMesh
{
public FMeshData MeshData;
@@ -228,7 +224,6 @@ namespace DatasmithSolidworks
}
}
[ComVisible(false)]
public class FConfigurationExporter
{
public readonly FMeshes Meshes;
Engine/Source/Programs/Enterprise/Datasmith/DatasmithSolidworksExporter/Private/ConfigurationTree.cs
-3
View File
@@ -9,7 +9,6 @@ using DatasmithSolidworks.Names;
namespace DatasmithSolidworks
{
[ComVisible(false)]
public class FConfigurationTree
{
// Component state for a single configuration
@@ -49,12 +48,10 @@ namespace DatasmithSolidworks
};
// A node contains all the configuration data for a single component
[ComVisible(false)]
public class FComponentTreeNode
{
public readonly Component2 Component;
[ComVisible(false)]
public struct FComponentInfo
{
public FComponentName ComponentName;
Engine/Source/Programs/Enterprise/Datasmith/DatasmithSolidworksExporter/Private/ConstructionGeometry.cs
-1
View File
@@ -7,7 +7,6 @@ using System.Runtime.InteropServices;
namespace DatasmithSolidworks
{
[ComVisible(false)]
public class FConstructionGeometry
{
public List<FVec3> CVertices;
Engine/Source/Programs/Enterprise/Datasmith/DatasmithSolidworksExporter/Private/DatasmithExporter.cs
-4
View File
@@ -20,7 +20,6 @@ namespace DatasmithSolidworks
// - avoid using sanitized(Datasmith) name to check component's name and vice versa
namespace Names
{
[ComVisible(false)]
public struct FActorName : IEquatable<FActorName>
{
private string Value;
@@ -47,7 +46,6 @@ namespace DatasmithSolidworks
public override int GetHashCode() => Value.GetHashCode();
}
[ComVisible(false)]
public struct FComponentName: IEquatable<FComponentName>
{
private string Value;
@@ -103,7 +101,6 @@ namespace DatasmithSolidworks
public override int GetHashCode() => Value.GetHashCode();
}
[ComVisible(false)]
public struct FMeshName : IEquatable<FMeshName>
{
private string Value;
@@ -167,7 +164,6 @@ namespace DatasmithSolidworks
private FDatasmithFacadeScene DatasmithScene = null;
[ComVisible(false)]
public struct FMeshExportInfo
{
public FComponentName ComponentName;
Engine/Source/Programs/Enterprise/Datasmith/DatasmithSolidworksExporter/Private/GeometryChunk.cs
-1
View File
@@ -4,7 +4,6 @@ using System.Runtime.InteropServices;
namespace DatasmithSolidworks
{
[ComVisible(false)]
public class FGeometryChunk
{
public FVec3[] Vertices { get; set; } = null;
Engine/Source/Programs/Enterprise/Datasmith/DatasmithSolidworksExporter/Private/Material.cs
-1
View File
@@ -10,7 +10,6 @@ using SolidWorks.Interop.sldworks;
namespace DatasmithSolidworks
{
[ComVisible(false)]
public class FMaterial
{
private static List<Tuple<string, string>> SpecialFinishes = new List<Tuple<string, string>>();
Engine/Source/Programs/Enterprise/Datasmith/DatasmithSolidworksExporter/Private/MathUtils.cs
-1
View File
@@ -7,7 +7,6 @@ using System.Runtime.InteropServices;
namespace DatasmithSolidworks
{
[ComVisible(false)]
public static class MathUtils
{
public static float Rad2Deg { get { return (float)(180.0 / Math.PI); } }
Engine/Source/Programs/Enterprise/Datasmith/DatasmithSolidworksExporter/Private/Matrix4.cs
-1
View File
@@ -5,7 +5,6 @@ using System.Runtime.InteropServices;
namespace DatasmithSolidworks
{
[ComVisible(false)]
public class FMatrix4
{
public FVec3 XBasis { get { return new FVec3(Data[0], Data[1], Data[2]); } }
Engine/Source/Programs/Enterprise/Datasmith/DatasmithSolidworksExporter/Private/MeshData.cs
-1
View File
@@ -5,7 +5,6 @@ using System.Runtime.InteropServices;
namespace DatasmithSolidworks
{
[ComVisible(false)]
public class FMeshData
{
public FVec3[] Vertices { get; set; } = null;
Engine/Source/Programs/Enterprise/Datasmith/DatasmithSolidworksExporter/Private/MetadataManager.cs
-1
View File
@@ -47,7 +47,6 @@ namespace DatasmithSolidworks
}
}
[ComVisible(false)]
public class FMetadata
{
public enum EOwnerType
Engine/Source/Programs/Enterprise/Datasmith/DatasmithSolidworksExporter/Private/ObjectMaterials.cs
-1
View File
@@ -11,7 +11,6 @@ using DatasmithSolidworks.Names;
namespace DatasmithSolidworks
{
[ComVisible(false)]
public class FObjectMaterials
{
// Note: part document might be a different document than the owner one:
Engine/Source/Programs/Enterprise/Datasmith/DatasmithSolidworksExporter/Private/StripGeometry.cs
-3
View File
@@ -7,7 +7,6 @@ using System.Threading.Tasks;
namespace DatasmithSolidworks
{
[ComVisible(false)]
public class FStripGeometryBody
{
public FBoundingBox Bounds { get; set; } = null;
@@ -26,7 +25,6 @@ namespace DatasmithSolidworks
}
}
[ComVisible(false)]
public class FStripGeometryFace
{
public FMaterial Material { get; set; } = null;
@@ -61,7 +59,6 @@ namespace DatasmithSolidworks
}
}
[ComVisible(false)]
public class FStripGeometry
{
private ConcurrentBag<FStripGeometryBody> Bodies { get; set; } = new ConcurrentBag<FStripGeometryBody>();
Engine/Source/Programs/Enterprise/Datasmith/DatasmithSolidworksExporter/Private/StripUnion.cs
-1
View File
@@ -4,7 +4,6 @@ using System.Runtime.InteropServices;
namespace DatasmithSolidworks
{
[ComVisible(false)]
[StructLayout(LayoutKind.Explicit)]
public struct FStripUnion
{
Engine/Source/Programs/Enterprise/Datasmith/DatasmithSolidworksExporter/Private/StripVector.cs
-1
View File
@@ -4,7 +4,6 @@ using System.Runtime.InteropServices;
namespace DatasmithSolidworks
{
[ComVisible(false)]
public class FStripVector
{
private FStripUnion BaseArray;
Engine/Source/Programs/Enterprise/Datasmith/DatasmithSolidworksExporter/Private/Triangle.cs
-1
View File
@@ -4,7 +4,6 @@ using System.Runtime.InteropServices;
namespace DatasmithSolidworks
{
[ComVisible(false)]
public class FTriangle
{
private int[] Indices = new int[3];
Engine/Source/Programs/Enterprise/Datasmith/DatasmithSolidworksExporter/Private/TriangleStrip.cs
-1
View File
@@ -4,7 +4,6 @@ using System.Runtime.InteropServices;
namespace DatasmithSolidworks
{
[ComVisible(false)]
public class FTriangleStrip
{
public FStripUnion Vertices { get; set; }
Engine/Source/Programs/Enterprise/Datasmith/DatasmithSolidworksExporter/Private/UVPlane.cs
-1
View File
@@ -4,7 +4,6 @@ using System.Runtime.InteropServices;
namespace DatasmithSolidworks
{
[ComVisible(false)]
public class FUVPlane
{
public FVec3 UDirection { get; set; }

Some files were not shown because too many files have changed in this diff Show More