From 00a44348e3fef14268100bfbc41cd9d416dc99cb Mon Sep 17 00:00:00 2001 From: ionut matasaru Date: Fri, 29 Sep 2023 09:47:47 -0400 Subject: [PATCH] SynthBenchmark: Fixed conversion warnings. Enabled UnsafeTypeCast warnings as errors. #rb Catalin.Dragoiu [CL 28340939 by ionut matasaru in ue5-main branch] --- .../SynthBenchmark/Private/FractalBenchmark.cpp | 2 +- .../SynthBenchmark/Private/RayIntersectBenchmark.cpp | 2 +- .../SynthBenchmark/Private/SynthBenchmarkPrivate.cpp | 2 +- .../Runtime/SynthBenchmark/SynthBenchmark.Build.cs | 12 +++++++----- 4 files changed, 10 insertions(+), 8 deletions(-) diff --git a/Engine/Source/Runtime/SynthBenchmark/Private/FractalBenchmark.cpp b/Engine/Source/Runtime/SynthBenchmark/Private/FractalBenchmark.cpp index 348414d4ed3f..c764969869e9 100644 --- a/Engine/Source/Runtime/SynthBenchmark/Private/FractalBenchmark.cpp +++ b/Engine/Source/Runtime/SynthBenchmark/Private/FractalBenchmark.cpp @@ -46,7 +46,7 @@ float FractalBenchmark() { for(int x = 0; x < Extent; ++x) { - Sum += EvaluateJuliaFractalAt(x / (float)Extent * 2 - 1, y / (float)Extent * 2 - 1); + Sum += (float)EvaluateJuliaFractalAt((float)x / (float)Extent * 2.0f - 1.0f, (float)y / (float)Extent * 2.0f - 1.0f); } } diff --git a/Engine/Source/Runtime/SynthBenchmark/Private/RayIntersectBenchmark.cpp b/Engine/Source/Runtime/SynthBenchmark/Private/RayIntersectBenchmark.cpp index 674104ef2c1d..eb8cbde73dc7 100644 --- a/Engine/Source/Runtime/SynthBenchmark/Private/RayIntersectBenchmark.cpp +++ b/Engine/Source/Runtime/SynthBenchmark/Private/RayIntersectBenchmark.cpp @@ -72,5 +72,5 @@ float RayIntersectBenchmark() } // to avoid getting optimized out - return HitCount / (float)StepCount; + return (float)HitCount / (float)StepCount; } diff --git a/Engine/Source/Runtime/SynthBenchmark/Private/SynthBenchmarkPrivate.cpp b/Engine/Source/Runtime/SynthBenchmark/Private/SynthBenchmarkPrivate.cpp index 8b70649dd056..34d03e047713 100644 --- a/Engine/Source/Runtime/SynthBenchmark/Private/SynthBenchmarkPrivate.cpp +++ b/Engine/Source/Runtime/SynthBenchmark/Private/SynthBenchmarkPrivate.cpp @@ -63,7 +63,7 @@ static FTimeSample RunBenchmark(float WorkScale, float (*Function)()) FPlatformMisc::MemoryBarrier(); } - return FTimeSample(Sum, Sum / RunCount); + return FTimeSample(Sum, Sum / (float)RunCount); } template diff --git a/Engine/Source/Runtime/SynthBenchmark/SynthBenchmark.Build.cs b/Engine/Source/Runtime/SynthBenchmark/SynthBenchmark.Build.cs index 42b4ba6b7bc8..8600f544b927 100644 --- a/Engine/Source/Runtime/SynthBenchmark/SynthBenchmark.Build.cs +++ b/Engine/Source/Runtime/SynthBenchmark/SynthBenchmark.Build.cs @@ -6,15 +6,17 @@ namespace UnrealBuildTool.Rules { public SynthBenchmark(ReadOnlyTargetRules Target) : base(Target) { + UnsafeTypeCastWarningLevel = WarningLevel.Error; + PublicDependencyModuleNames.AddRange( new string[] { "Core", - "RenderCore", - "RHI", + "RenderCore", + "RHI", // ... add other public dependencies that you statically link with here ... } - ); + ); PrivateDependencyModuleNames.AddRange( new string[] @@ -22,14 +24,14 @@ namespace UnrealBuildTool.Rules "ApplicationCore" // ... add private dependencies that you statically link with here ... } - ); + ); DynamicallyLoadedModuleNames.AddRange( new string[] { // ... add any modules that your module loads dynamically here ... } - ); + ); } } }