Files
UnrealEngineUWP/Engine/Source/Programs/CrashReportClient/Private/CrashReportClientApp.cpp

389 lines
12 KiB
C++
Raw Normal View History

// Copyright 1998-2019 Epic Games, Inc. All Rights Reserved.
#include "CrashReportClientApp.h"
#include "Misc/Parse.h"
#include "Misc/CommandLine.h"
#include "Misc/QueuedThreadPool.h"
#include "Internationalization/Internationalization.h"
#include "Math/Vector2D.h"
#include "Misc/ConfigCacheIni.h"
#include "GenericPlatform/GenericApplication.h"
#include "Misc/App.h"
#include "CrashReportCoreConfig.h"
#include "GenericPlatform/GenericPlatformCrashContext.h"
#include "CrashDescription.h"
#include "CrashReportAnalytics.h"
#include "Modules/ModuleManager.h"
#include "HAL/PlatformApplicationMisc.h"
#if !CRASH_REPORT_UNATTENDED_ONLY
#include "SCrashReportClient.h"
#include "CrashReportClient.h"
#include "CrashReportClientStyle.h"
#include "ISlateReflectorModule.h"
#include "Framework/Application/SlateApplication.h"
#endif // !CRASH_REPORT_UNATTENDED_ONLY
#include "CrashReportCoreUnattended.h"
#include "Async/TaskGraphInterfaces.h"
#include "RequiredProgramMainCPPInclude.h"
#include "MainLoopTiming.h"
#include "PlatformErrorReport.h"
#include "XmlFile.h"
/** Default main window size */
const FVector2D InitialWindowDimensions(740, 560);
/** Average tick rate the app aims for */
const float IdealTickRate = 30.f;
/** Set this to true in the code to open the widget reflector to debug the UI */
const bool RunWidgetReflector = false;
IMPLEMENT_APPLICATION(CrashReportClient, "CrashReportClient");
DEFINE_LOG_CATEGORY(CrashReportClientLog);
/** Directory containing the report */
static TArray<FString> FoundReportDirectoryAbsolutePaths;
/** Name of the game passed via the command line. */
static FString GameNameFromCmd;
/** GUID of the crash passed via the command line. */
static FString CrashGUIDFromCmd;
/**
* Look for the report to upload, either in the command line or in the platform's report queue
*/
void ParseCommandLine(const TCHAR* CommandLine)
{
const TCHAR* CommandLineAfterExe = FCommandLine::RemoveExeName(CommandLine);
FoundReportDirectoryAbsolutePaths.Empty();
// Use the first argument if present and it's not a flag
if (*CommandLineAfterExe)
{
TArray<FString> Switches;
TArray<FString> Tokens;
TMap<FString, FString> Params;
{
FString NextToken;
while (FParse::Token(CommandLineAfterExe, NextToken, false))
{
if (**NextToken == TCHAR('-'))
{
new(Switches)FString(NextToken.Mid(1));
}
else
{
new(Tokens)FString(NextToken);
}
}
for (int32 SwitchIdx = Switches.Num() - 1; SwitchIdx >= 0; --SwitchIdx)
{
FString& Switch = Switches[SwitchIdx];
TArray<FString> SplitSwitch;
if (2 == Switch.ParseIntoArray(SplitSwitch, TEXT("="), true))
{
Params.Add(SplitSwitch[0], SplitSwitch[1].TrimQuotes());
Switches.RemoveAt(SwitchIdx);
}
}
}
if (Tokens.Num() > 0)
{
FoundReportDirectoryAbsolutePaths.Add(Tokens[0]);
}
GameNameFromCmd = Params.FindRef(TEXT("AppName"));
CrashGUIDFromCmd = FString();
if (Params.Contains(TEXT("CrashGUID")))
{
CrashGUIDFromCmd = Params.FindRef(TEXT("CrashGUID"));
}
}
if (FoundReportDirectoryAbsolutePaths.Num() == 0)
{
FPlatformErrorReport::FindMostRecentErrorReports(FoundReportDirectoryAbsolutePaths, FTimespan::FromDays(30)); //FTimespan::FromMinutes(30));
}
}
/**
* Find the error report folder and check it matches the app name if provided
*/
FPlatformErrorReport LoadErrorReport()
{
if (FoundReportDirectoryAbsolutePaths.Num() == 0)
{
UE_LOG(CrashReportClientLog, Warning, TEXT("No error report found"));
return FPlatformErrorReport();
}
for (const FString& ReportDirectoryAbsolutePath : FoundReportDirectoryAbsolutePaths)
{
FPlatformErrorReport ErrorReport(ReportDirectoryAbsolutePath);
FString Filename;
// CrashContext.runtime-xml has the precedence over the WER
if (ErrorReport.FindFirstReportFileWithExtension(Filename, *FGenericCrashContext::CrashContextExtension))
{
FPrimaryCrashProperties::Set(new FCrashContext(ReportDirectoryAbsolutePath / Filename));
}
else if (ErrorReport.FindFirstReportFileWithExtension(Filename, TEXT(".xml")))
{
FPrimaryCrashProperties::Set(new FCrashWERContext(ReportDirectoryAbsolutePath / Filename));
}
else
{
continue;
}
#if CRASH_REPORT_UNATTENDED_ONLY
return ErrorReport;
#else
bool NameMatch = false;
if (GameNameFromCmd.IsEmpty() || GameNameFromCmd == FPrimaryCrashProperties::Get()->GameName)
{
NameMatch = true;
}
bool GUIDMatch = false;
if (CrashGUIDFromCmd.IsEmpty() || CrashGUIDFromCmd == FPrimaryCrashProperties::Get()->CrashGUID)
{
GUIDMatch = true;
}
if (NameMatch && GUIDMatch)
{
FString ConfigFilename;
if (ErrorReport.FindFirstReportFileWithExtension(ConfigFilename, *FGenericCrashContext::CrashConfigExtension))
{
FConfigFile CrashConfigFile;
CrashConfigFile.Read(ReportDirectoryAbsolutePath / ConfigFilename);
FCrashReportCoreConfig::Get().SetProjectConfigOverrides(CrashConfigFile);
}
return ErrorReport;
}
#endif
}
// Don't display or upload anything if we can't find the report we expected
return FPlatformErrorReport();
}
static void OnRequestExit()
{
GIsRequestingExit = true;
}
#if !CRASH_REPORT_UNATTENDED_ONLY
bool RunWithUI(FPlatformErrorReport ErrorReport)
{
// create the platform slate application (what FSlateApplication::Get() returns)
TSharedRef<FSlateApplication> Slate = FSlateApplication::Create(MakeShareable(FPlatformApplicationMisc::CreateApplication()));
// initialize renderer
TSharedRef<FSlateRenderer> SlateRenderer = GetStandardStandaloneRenderer();
// Grab renderer initialization retry settings from ini
int32 SlateRendererInitRetryCount = 10;
GConfig->GetInt(TEXT("CrashReportClient"), TEXT("UIInitRetryCount"), SlateRendererInitRetryCount, GEngineIni);
double SlateRendererInitRetryInterval = 2.0;
GConfig->GetDouble(TEXT("CrashReportClient"), TEXT("UIInitRetryInterval"), SlateRendererInitRetryInterval, GEngineIni);
// Try to initialize the renderer. It's possible that we launched when the driver crashed so try a few times before giving up.
bool bRendererInitialized = false;
bool bRendererFailedToInitializeAtLeastOnce = false;
do
{
SlateRendererInitRetryCount--;
bRendererInitialized = FSlateApplication::Get().InitializeRenderer(SlateRenderer, true);
if (!bRendererInitialized && SlateRendererInitRetryCount > 0)
{
bRendererFailedToInitializeAtLeastOnce = true;
FPlatformProcess::Sleep(SlateRendererInitRetryInterval);
}
} while (!bRendererInitialized && SlateRendererInitRetryCount > 0);
if (!bRendererInitialized)
{
// Close down the Slate application
FSlateApplication::Shutdown();
return false;
}
else if (bRendererFailedToInitializeAtLeastOnce)
{
// Wait until the driver is fully restored
FPlatformProcess::Sleep(2.0f);
// Update the display metrics
FDisplayMetrics DisplayMetrics;
FDisplayMetrics::RebuildDisplayMetrics(DisplayMetrics);
FSlateApplication::Get().GetPlatformApplication()->OnDisplayMetricsChanged().Broadcast(DisplayMetrics);
}
// Set up the main ticker
FMainLoopTiming MainLoop(IdealTickRate, EMainLoopOptions::UsingSlate);
// set the normal UE4 GIsRequestingExit when outer frame is closed
FSlateApplication::Get().SetExitRequestedHandler(FSimpleDelegate::CreateStatic(&OnRequestExit));
// Prepare the custom Slate styles
FCrashReportClientStyle::Initialize();
// Create the main implementation object
TSharedRef<FCrashReportClient> CrashReportClient = MakeShareable(new FCrashReportClient(ErrorReport));
// open up the app window
TSharedRef<SCrashReportClient> ClientControl = SNew(SCrashReportClient, CrashReportClient);
TSharedRef<SWindow> Window = FSlateApplication::Get().AddWindow(
SNew(SWindow)
.Title(NSLOCTEXT("CrashReportClient", "CrashReportClientAppName", "Unreal Engine 4 Crash Reporter"))
.HasCloseButton(FCrashReportCoreConfig::Get().IsAllowedToCloseWithoutSending())
.ClientSize(InitialWindowDimensions)
[
ClientControl
]);
Window->SetRequestDestroyWindowOverride(FRequestDestroyWindowOverride::CreateSP(CrashReportClient, &FCrashReportClient::RequestCloseWindow));
// Setting focus seems to have to happen after the Window has been added
FSlateApplication::Get().ClearKeyboardFocus(EFocusCause::Cleared);
// Debugging code
if (RunWidgetReflector)
{
FModuleManager::LoadModuleChecked<ISlateReflectorModule>("SlateReflector").DisplayWidgetReflector();
}
// loop until the app is ready to quit
while (!GIsRequestingExit)
{
MainLoop.Tick();
if (CrashReportClient->ShouldWindowBeHidden())
{
Window->HideWindow();
}
}
// Make sure the window is hidden, because it might take a while for the background thread to finish.
Window->HideWindow();
// Stop the background thread
CrashReportClient->StopBackgroundThread();
// Clean up the custom styles
FCrashReportClientStyle::Shutdown();
// Close down the Slate application
FSlateApplication::Shutdown();
return true;
}
#endif // !CRASH_REPORT_UNATTENDED_ONLY
void RunUnattended(FPlatformErrorReport ErrorReport)
{
// Set up the main ticker
FMainLoopTiming MainLoop(IdealTickRate, EMainLoopOptions::CoreTickerOnly);
// In the unattended mode we don't send any PII.
FCrashReportCoreUnattended CrashReportClient(ErrorReport);
ErrorReport.SetUserComment(NSLOCTEXT("CrashReportClient", "UnattendedMode", "Sent in the unattended mode"));
// loop until the app is ready to quit
while (!GIsRequestingExit)
{
MainLoop.Tick();
}
}
void RunCrashReportClient(const TCHAR* CommandLine)
{
// Override the stack size for the thread pool.
FQueuedThreadPool::OverrideStackSize = 256 * 1024;
// Set up the main loop
GEngineLoop.PreInit(CommandLine);
// Make sure all UObject classes are registered and default properties have been initialized
ProcessNewlyLoadedUObjects();
// Tell the module manager is may now process newly-loaded UObjects when new C++ modules are loaded
FModuleManager::Get().StartProcessingNewlyLoadedObjects();
// Initialize config.
FCrashReportCoreConfig::Get();
const bool bUnattended =
#if CRASH_REPORT_UNATTENDED_ONLY
true;
#else
FApp::IsUnattended();
#endif // CRASH_REPORT_UNATTENDED_ONLY
// Find the report to upload in the command line arguments
ParseCommandLine(CommandLine);
// Increase the HttpSendTimeout to 5 minutes
GConfig->SetFloat(TEXT("HTTP"), TEXT("HttpSendTimeout"), 5*60.0f, GEngineIni);
FPlatformErrorReport::Init();
FPlatformErrorReport ErrorReport = LoadErrorReport();
Copying //UE4/Release-Staging-4.20 to //UE4/Dev-Main (Source: //UE4/Release-4.20 @ 4112782) ============================ MAJOR FEATURES & CHANGES ============================ Change 4112782 by Mitchell.Wilson Resaving some cloth assets and fixing material compile warnings. #jira UE-59946 Change 4112762 by Max.Chen Sequence Recorder: Fix case where first recording is null but there are other valid recordings. StopRecording wasn't getting called because the EndPIE delegate wasn't bound since ActorWorld was incorrectly set. #jira UE-58688 Change 4112738 by Michael.Dupuis #jira none: Fixed Editor instance count, to only include placed instances. Calling GenerateProceduralContent will no longer automatically remove the current content, as we might want to get the generation for something else than replacing existing data. When deleting procedural foliage, we can now specify if we want to rebuild the tree. Change 4112696 by Matt.Kuhlenschmidt Prevent GC of material editor active preview expression #jira UE-49777 Change 4112611 by Michael.Dupuis Fixed Instance count when Alt+Dragging instance #jira UE-59544: After the operation, reselect the instances, as the selection info into the buffer was lost Change 4112536 by Thomas.Sarkanen Fixed static analysis warning caused by CL 4109096 #jira none Change 4112139 by Phillip.Kavan Fix invalid child actor template cast in nativized code when the child actor class type is a converted Blueprint class asset. - Mirrored from //UE4/Dev-Framework (4111638). #jira UE-53747 Change 4112138 by Phillip.Kavan Fix UHT warning about duplicating UFUNCTION() meta on nativized child Blueprint classes that override at least one BPIE method from the parent class. - Mirrored from //UE4/Dev-Framework (4111613). #jira UE-59182 Change 4111630 by Matt.Collins #jira UE-59934 Rolling back the previous integration of CL 4080446 Change 4111526 by Mike.Beach Guarding against bad settings pointers internal to Oculus. #jira UE-59778 Change 4111525 by Daniel.Wright UStaticMeshComponent::PostEditUndo now initializes its UStaticMesh's rendering resources. This is necessary for cases where the UStaticMesh is in the same transaction (PostEditUndo will be called AFTER the component). However, when calling UStaticMesh::InitResources we must use a FStaticMeshComponentRecreateRenderStateContext to safely handle any components using the UStaticMesh which are not in the transaction. #jira UE-59333 Change 4111518 by Mike.Beach Making sure to load the third party dll, and initing Oculus when we querry for Vulkan extensions. Otherwise we end up calling into the OVR plugin before the dll is loaded. #jira UE-53643 Change 4111482 by Matt.Kuhlenschmidt Fix blend sample context menu appering offset on high dpi monitors #jira UE-59925 Change 4111362 by Ben.Marsh Fix warnings building samples due to missing paths. #jira Change 4111299 by James.McNatton Changed category of Virtual Camera plugin to Virtual Production #RNX #Jira UE-59404 Change 4111153 by Max.Chen Sequencer: Fix dereferencing null pointer - CameraNode #jira UE-59347 Change 4111143 by Matt.Collins #jira UE-59934 CL 4107446 from Dev-Rendering. Always force a commandbuffer submission during EndFrame. Change 4111106 by Matt.Collins #jira UERNDR-406 Bringing CL 4104051 from Dev-Rendering (//UE4/Dev-Rendering) to Release-4.20 (//UE4/Release-4.20) --- Some fixes for semaphore handling. Moved the completion handler to EndFrame (out of FlushFreeList()) FlushFreeList() attached a handler to the command buffer that signaled the semaphore. This can be called through RHIFlushResources which will cause a mismatched signal() Added BeginFrame/EndFrame to the loop in AddModalWindows so the renderer gets the expected frame delimiters. Removed call to EndFrame from EndDrawingViewport. --- Change 4111099 by Ben.Zeigler #jira UE-59199 Add enum redirector for CVD_NormalVision, some values map to normal as they were removed This is needed because that enum value would have been written into the EditorPerProjectSettings for anyone that modified editor style, and then cause mysterious cook warnings Change 4111039 by Ben.Zeigler #jira UE-59046 Fix it so trying to convert a soft path to hard object ref will throw error during async loading instead of silently failing Change 4111013 by Steve.Robb Fix for adding a new module to a project. #jira UE-59770 Change 4110907 by Marc.Audy Add required redirectorfor moving classes from TimeManagement to CoreUObject #jira Change 4110897 by Ben.Zeigler #jira UE-57739 Don't crash if dropping a pin on a node causes the source pin to become invalid, just fail to connect instead Change 4110868 by Ben.Zeigler #jira UE-59920 Fix several issues where half-connected reroute nodes could break AutoCreateRefTerm and other node expansions if they happened to be late in the nodes array, by always expanding knot nodes first Change 4110704 by Ben.Zeigler #jira UE-56365 Fix k2 node tooltip code to not crash if the node is out of date due to slate updates being a tick behind Change 4110686 by Andrew.Grant Resaved to fix empty engine version warning #jira UE-59695 Change 4110466 by Ben.Zeigler #jira UE-59908 Change loading screen logo back to one with text baked in and clean up comments Delete unused logo images Change 4110418 by Ben.Zeigler #jira UE-58025 Fix non editor builds Change 4110258 by Max.Chen Sequencer: Fix some erroneous cases in import fbx. In particular, this fixes an issue where importing an fbx onto one node would behave differently if there are multiple nodes in the fbx since it was ambiguous as to which fbx node to map onto the single node in sequencer. - Changed import operation to be more explicit - when invoking through the general import fbx menu, all object bindings are mapped onto. When invoking through the context menu, only the selected object bindings are mapped onto. - Added a user toggle to match by name only. The default is true. - When importing onto a selected node, disable the creation of cameras. - Don't set range bounds on imported keys since external packages, ie. maya, most likely only have 1 equivalent infinite section range. - Remove any existing sections/keys when importing onto existing tracks. #jira UE-59347 Change 4109923 by Michael.Dupuis #jira UE-59904: Build tree post Serialize otherwise sometime foliage will be missing Change 4109916 by mason.seay Updated level blueprint so it Resets Ignore Look Input, which will prevent look input from being ignored if user triggers Ignore multiple times #jira UE-29618 Change 4109849 by Michael.Dupuis #jira none: Removed PRAGMA_ENABLE_OPTIMISATION Change 4109835 by Lukasz.Furman added OnTaskFinished call when behavior tree's subtree is deactivated #jira UE-48353 Change 4109829 by Ben.Zeigler #jira UE-59909 Add logic so the player cannot be hurt during ShieldNS anim notify by adding and removing a damage immune gameplay effect Change 4109820 by Michael.Dupuis #jira UE-59533: Update the LOD Distribution settings to fix the landscape popping Change 4109813 by Michael.Dupuis #jira UE-59533: Increase the max LOD0 distribution factor so on map with very small component, the value can be increase more than before. Change 4109780 by Alexis.Matte Add the tps file for the levenshtein distance algorithm #jira none Change 4109567 by Ben.Marsh Fix incorrect console colors after a warning or error on Mac. Cannot assume that the default foreground color is gray. #jira UE-55093 Change 4109542 by mason.seay Updated timeline on BP #jira UE-29618 Change 4109474 by Marc.Audy Fix shadow variable warning #jira UE-59895 Change 4109420 by Michael.Dupuis #jira UE-58672 : Since it's possible the GetInstanceBasePtr() would not find the base id we hit, do not assume it must always be valid, and simply skip it instead of crashing. Change 4109397 by Ben.Marsh Speculative fix for exception reading UBT makefiles on Mono. Doesn't seem to be able to deserialize dictionaries with custom comparison functions correctly. #jira UE-59222 Change 4109395 by Lauren.Ridge Removing legacy uses of GetEditorIcon from UMG #jira UE-59038 Change 4109390 by Zachary.Wilson Adding alternative ground truth images for AMD on the planar reflection tests. ST_PR00, 03, 04, 05 #jira UE-59409 Change 4109373 by Michael.Dupuis #jira UE-58664 Restrict the Paint/Unpaint Density to 1.0 Restrict the Foliage Density type to 10000 Restrict the Grass Density type to 1000 Fixed a NAN that could be generated when adding instances These settings would still allow to paint ~2 millions instances with the biggest brush and max density per click. Change 4109348 by Lauren.Ridge Removing engine content that used a material attribute layers node inside a material function #jira UE-55739 Change 4109296 by Lauren.Ridge Fix for crash on adding OnClicked event to button in Widget BP #jira UE-59846 Change 4109193 by Matt.Kuhlenschmidt Fixed crash when construction scripts are rerun during the details panel calling posteditchange #jira UE-59649 Change 4109096 by Thomas.Sarkanen Fixed crash when running in standalone editor build using sub-instances that copy properties Revamped change as the last one failed Fast Path automated tests. This change limits the property re-find only to cases where we are using sub-instances. DestProperty serialization was always a bad idea, this is another artifact of the problem where the property persists but the class it belongs to gets trashed. Re-mapping the property by name to the correct outer fixes this for a minor startup cost. #jira UE-59510 - Crash in Standalone When Sub Anim Instance Uses Exposed Variable Change 4109078 by Ben.Marsh Fix warnings building PlatformerGame due to incorrect include path. #jira Change 4109066 by Matt.Kuhlenschmidt Prevent alt-f4 during slow tasks as it causes entry into the shutdown sequence at abnormal times #jira UE-59866 Change 4109020 by Ben.Marsh Fix client targets showing up in packaging menu for installed builds (which don't ship with client binaries). (This implementation is a little suspect in general - there is no requirement that client targets are called "*Client.Target.cs", though that is typically the case.) #jira UE-59641 Change 4108991 by Martin.Wilson Fix crash when trying to extract transform from raw track with no track data. #jira UE-58025 Change 4108987 by Martin.Wilson Make sure rotations are normalized before creating blended transform #jira UE-53971 Change 4108932 by Thomas.Sarkanen Back out changelist 4108877 This was causing a 100% crash in an automated test #jira none Change 4108930 by Danny.Bouimad Fixing testcase content #Jira UEQATC-405 Change 4108883 by Danny.Bouimad Fixing Automated LodCurveLinkingTest1 #Jira UE-59763 Change 4108877 by Thomas.Sarkanen Fixed crash when running in standalone editor build using sub-instances that copy properties DestProperty serialization was always a bad idea, this is another artifact of the problem where the property persists but the class it belongs to gets trashed. Re-mapping the property by name to the correct outer fixes this for a minor startup cost. #jira UE-59510 - Crash in Standalone When Sub Anim Instance Uses Exposed Variable Change 4108874 by Thomas.Sarkanen Fixed incorrect preview mesh being applied after retargeting On first setup, the preview mesh was obtained using a legacy path that didnt use the skeleton fallback #jira UE-59636 - When Retargeting Animation, Mesh Set as Preview that Shares Skeleton Isn't Kept Change 4108834 by Thomas.Sarkanen Pressing enter when selecting an object from a Blueprint node now works #jira UE-58017 - Enter key does not set chosen asset on some blueprint nodes Change 4108833 by Thomas.Sarkanen Fixed crash caused by retargeting a skeleton when some of its animations are still open Firstly we now auto-close all assets that use a skeleton when retergetting instead of popping up a dialog to suggest the user does it. Secondly as a safety measure we dont re-use an animation editor if the persona toolkit's skeleton doesnt match. #jira UE-58681 - [CrashReport] UE4Editor_Persona!FPersonaToolkit::SetAnimationAsset() [personatoolkit.cpp:211] Change 4108808 by Dmitriy.Dyomin Fixed: ARPG crashes on Vulkan PC and Android #jira UE-59781 Change 4108719 by Max.Chen Sequencer: Fix CIS #jira UESEQ-355 Change 4108675 by Max.Chen Sequencer: Added audio support to FCP XML import/export #jira UESEQ-355 Change 4108674 by Max.Chen Sequencer: Upon export, log warnings when filename format is not '{shot}' #jira UESEQ-358 Change 4108673 by Max.Chen Sequencer: Added 'Write FCPXML' option to Render Movie Settings dialog. Changed track menu FCPXML export to get default resolution and frame rate from MovieSceneCaptureSettings. #jira UESEQ-358 Change 4108418 by Mark.Satterthwaite Fix Shipping iOS builds. #jira UE-59883 Change 4108118 by Alexis.Matte Make sure GIsImportingT3D is false when the scene importer open the blueprint editor. This flag force a load of UObject when we do FindObject, which in this case was forcing a load of all blueprints assets. #jira UE-59854 #jira UE-57861 Change 4108059 by Ben.Marsh Merge latest UGS fixes (up to 1.140) to 4.20 branch. #jira Change 4107719 by Mark.Satterthwaite Duplicate 4107661: Refactor the MetalRHI debugging tools to move away from reimplementing the Objective-C protocols to adding separate debugging classes. This makes it easier to build on/for future OSes without having to interpose new functionality we don't yet use. #jira UE-59883 Change 4107443 by Lauren.Ridge Fix for crash on connecting curve param node with no texture set #jira UE-59880 Change 4107248 by Dan.Oconnor Explicitly close floating Blueprint Debugger controls when the master tab is closed #jira UE-59835 Change 4107137 by Jason.Bestimt Removing ML Analytics Plugin to fix regressions #JIRA: UE-59874, UE-59873 Change 4107125 by paulo.souza #jira UE-59806 - ARPG - Goblin death not running all destroy logic Change 4107113 by Phillip.Kavan Allow the NativizedAssets plugin source to include monolithic engine header files without a compiler warning. - Mirrored from //UE4/Dev-Framework (4081432). #jira UE-59125 Change 4106736 by Jamie.Dale Fixed content browser filter failing to match certain names if asset paths were omitted from the search #jira UE-59849 Change 4106581 by Martin.Wilson Fix issue with double ticking a reused animation instance on set skeletal mesh because of parallel evaluation. #jira UE-54851 Change 4106475 by Jason.Bestimt Fix for Lumin Linux dependency in a better way #JIRA: CIS Change 4106201 by Michael.Trepka Don't allow invalid cursor clip rects when locking the cursor on Mac #jira UE-59842 Change 4106188 by Jason.Bestimt Wrapping Lumin call with PLATFORM_LUMIN #JIRA: CIS Change 4106179 by Michael.Dupuis #jira UE-53944: Integrated guard from user to prevent crash if bad data is found in the view #4714 Change 4106176 by Martin.Wilson Fix for crash introduced in 4105998 #jira UE-56395 Change 4106103 by Ben.Marsh UBT: Fix intellisense search paths not being set correctly for modules which are not built by default. #jira Change 4106081 by Marc.Audy Fix shadow variable #jira UE-59848 Change 4106078 by Jason.Bestimt Fix for Linux trying to build MagicLeapAnalytics by swapping from Blacklist to Whitelist #JIRA: none Change 4106015 by Martin.Wilson Make sure that animations that have transform curves are up to date on loading. #4320 #jira UE-53392 Change 4106005 by Anthony.Bills [Linux] Add support for terminfo2 to fix mono issue 6752, and rebuild .net 4.5's mscorlib.dll #jira UE-59382 Change 4105998 by Martin.Wilson Fix crash when re registering a skeletal mesh component with a post process instance that references invalid virtual bones #Jira UE-56395 Change 4105962 by Jeff.Fisher Duplicating for 4.20: Change: 4097595 and 4104555 UE-59359 Mr Mesh Crash at startup -Vulkan does not work correctly unless we fill in all of the vertex buffers. MRMesh now requires that via assert and MeshTrackerComponent fills in placeholder data as necessary. -Also fixed the vr.MagicLeap.FakeMeshTrackerData cvar, it was missing the 'MagicLeap'. #jira UE-59359 Change 4105952 by Ben.Marsh Add an "IsTerminating" event to the record of active sessions. Should allow detecting whether RequestExit() was called before an abnormal shutdown was triggered. #jira Change 4105946 by Ben.Marsh Disable debug info for IOS and TVOS in installed builds. #jira UE-59816 Change 4105939 by Michael.Dupuis #jira UE-59256: Properly take into account the scale of the instances when determining LOD transition Added the possibility to see the Cluster tree bounds in the Show->Advanced Menu Change 4105915 by Jamie.Dale Implemented negative indexing for Python wrapped arrays #jira UE-59841 Change 4105896 by Richard.Wallis Another macOS TIS non-MainThread spam warning fix. #jira UE-54623 Change 4105813 by Michael.Dupuis #jira none: Prevent a possible crash if using world offset with a landscape without sub sections Change 4105764 by Ben.Marsh Add a check that a 2015 compiler exists under VS2015 toolchain directories - it may not have been installed. #jira Change 4105747 by Ben.Marsh Fix detection of VS2017 toolchains that only have a 32-bit compiler for x64 (eg. VS2017 Express Desktop) #jira UE-59838 Change 4105642 by Jason.Bestimt Disabling Lumin Platform Editor modules on linux #JIRA: UE-59543 Change 4105553 by Matt.Kuhlenschmidt PR #4633: Fixed DPI awareness of two functions (Contributed by Temaran) #jira UE-57283 Change 4105486 by Michael.Dupuis #jira UE-58074: Include the HeightmapScaleBias in the DDC hash as component can share the same heightmap with different HeightmapScaleBias Change 4105474 by Michael.Dupuis #jira UE-57957: Fixed neightbord component extend used when component was not visible (so not custom data and generating neighbord) #jira UE-58995: Change 4105427 by Sorin.Gradinaru UE-59698 Cannot load youtube URLs on Android #jira UE-59698 #Android #4.20 The native WebView cannot load HTML5 movies if the control's layout doesn't have the FILL_PARENT param Change 4105308 by Mieszko.Zielinski Merge of 4077826 over from Dev-Framework #UE4 #jira UE-59186 Change 4105050 by Ben.Marsh Disable debug info for all target platforms in installed engine builds, to fix bloated install size. IOS and TVOS still have it enabled for now, due to errors when packaging. #jira UE-59816 Change 4104584 by Mike.Beach Mirroring CL 4103694 from Dev-VR Making it so the HMD post-process pass properly fills out its RenderTargetDesc (so it doesn't rely on being the final output to have it set). #jira UE-56511 Change 4104538 by Alexis.Matte Fix crash when reloading a skeletal mesh actor with some vertex painting #jira UE-57891 Change 4104534 by Mike.Beach Mirroring CL 4090670/4094620 from Dev-VR MR Calibration - Fixing an issue where the alignment models would disappear. MR Calibration - Saving garbage mattes when exiting using escape. #jira UEVR-24 Change 4104381 by Alexis.Matte Fix a render thread crash when reimporting skeletal mesh #jira UE-51935 Change 4104365 by Mike.Beach Mirroring CL 4064903 from Dev-VR Removing duplicate redirects, and resaving MRCalibration content so packaging works without failing on old package references. #jira UE-58914 Change 4104341 by Alexis.Matte Support non uniform scale scene transform for fbx skeletal mesh exporter #jira UE-57733 Change 4104328 by Alexis.Matte Fix a crash when re-importing an animation and we have to choose a skeleton for the anim sequence #jira UE-58027 Change 4104318 by Phillip.Kavan Monolithic engine header file exclusion from nativized Blueprint assets is now tied to a project setting. - Mirrored from //UE4/Dev-Framework (4082035). #jira UE-59125 Change 4104305 by Mike.Beach Mirroring CL 4098493 from Dev-VR Not forcing stereo scene capture target to resize (only intended for the main stereo scene buffer, as the depth buffer needs to match the color buffer on some platforms). #jira UE-58953 Change 4104274 by Mike.Beach Mirroring CL 4088048 from Dev-VR Use the standardized tracking-to-world transform for world layer positioning on Oculus - handles both explicit and implicit HMD positioning. #jira UE-59275 Change 4104259 by Mike.Beach Mirroring CL 4084827/4085071 from Dev-VR MRC - Adding CVar for overriding the tracking latency (makes development easier in the calibration process). #jira UEVR-847 Change 4104246 by Mike.Beach Mirroring CL 4084289 from Dev-VR MR - Setting up the calibration save data so that we version it in the future (know that a lens param change is inbound after 4.20). #jira UE-58187 Change 4104240 by Mike.Beach Mirroring CL 4083160 from Dev-VR Making it so the HMD post-process pass properly fills out its RenderTargetDesc (so it doesn't rely on being the final output to have it set). #jira UE-56511 Change 4104233 by Mike.Beach Mirroring CL 4081823 from Dev-VR Loading Oculus controller models in the editor so that they get included in the cooking process (so that the MotionController components that indirectly uses these at runtime don't get dropped). #jira UE-58190 Change 4104196 by Alexis.Matte Unshelved from pending changelist '4075677': Fix fbx scene re-import crash when the user re-import more then one time with some override material. #jira UE-57937 Change 4104191 by Mike.Beach Mirroring CL 4080389 from Dev-VR Speculative fix/guard against live crash - trying to catch malformed model data. Logging helpful information to give us insight in the future. #jira UE-57680 Change 4104177 by Mike.Beach Mirroring CL 4080119 from Dev-VR CIS fix - circumventing vs2015 errors/warnings #jira UE-59326, UE-59324 Change 4104170 by Mike.Beach Mirroring CL 4078631 from Dev-VR Fixing MR Calibration so it scales the alignment model according the the capture's FOV (so they appear the same size across capture devices - leading to a homogenous experience). Also moved the FOV override config setting to be a console command/setting (mrc.FovOverride) to help in testing this. #jira UE-55499 Change 4104167 by Jostin.Bilyeu Checking in needed changes to level TM-DualLobeSpec in order to correctly verify intended functionality of feature #jira UE-29618 Change 4104158 by Peter.Sumanaseni #jira Change 4104057 by Wes.Hunt Remove sending of UniqueAdvertisingId from AnalyticsET SessionStart events. #jira UE-59790 SOURCE CL 4101872 in //UE4/Main/... Change 4104031 by Dan.Oconnor Update assert to handle subobjects nested in components #jira UE-56422 Change 4103946 by Dan.Oconnor No need to load AnimationBlueprintEditor so early #jira UE-59669 Change 4103859 by Brandon.Schaefer Vulkan on Linux does not allow debugging with markers This is required for debugging wtih Render Doc or anything that uses VK debug markers #jira none Change 4103677 by Sorin.Gradinaru UE-59052 Can't use touch to interact with Web Browser on iPhoneX #jira UE-59052 #iOS #4.20 from CL4077699 on Dev-Mobile Fixed crash on some iOS 11 devices (addSubview before setting WebView's params) Fixed unresponsive WebView on iPhone X (resize the parent with the same size as the child, the touch won't work if the parent is smaller) Change 4103637 by Sorin.Gradinaru UE-39451 Web browser widget causes app to crash when packaging for Distribution on Android #UE-39451 #Android #4.30 from CL 4067204 on Dev-Mobile Adding a proguard exception for the WebViewControl.FrameUpdateInfo Change 4103619 by Marc.Audy Allow the default physics volume to be spawned during construction script execution if it needs to be lazily created #jira UE-58875 Change 4103590 by mason.seay Added Show Mouse Cursor #jira UE-29618 Change 4103469 by paulo.souza #jira UE-59807 - War Hammer weapon was missing Ability setting resulting in it not working correctly. Change 4103459 by mason.seay Updated maps so users can toggle UI-only input #jira UE-29618 Change 4103423 by paulo.souza #jira UE-59808 - Projectile abilities collision blocking on the camera trace Change 4103280 by Jason.Bestimt Fixing copyright in Lumin Plugins #JIRA: 59192 Change 4103238 by JeanMichel.Dignard Copied cl 4077328 from dev-enterprise Fixed SoftObjectPtr/Paths becoming invalid when saving a new world since it's being moved from /Temp/Untitled to its own package. #jira UEENT-1423 Change 4103138 by Richard.Wallis Emergency Fix for bug I introduced in macOS UnrealFrontend crashing on open. FSlateMacMenu::PostInitStartup() gets called much much earler in the front end tool than in the editor. Unfortunatly the style set referenced is invalid as this call happens much earlier in the startup than with the game or the editor 1) Changed GetStyleSetName() - this is not imortant for us so it won't crash there again. 2) Added a check to see if the menu hasn't been setup correctly - if not initialize - this allows localization and and correct keyboard short cuts in non editor / game builds. 3) Keep Editor and Game menu startup behaviour the same as before. #jira UE-59704 Change 4102958 by mason.seay Test map update #jira UE-29618 Change 4102847 by Marc.Audy Try and find the full path name for default value of class parameters #jira UE-59746 Change 4102449 by Ben.Marsh PR #4700: This patch fixes a build failure that occurs on the very first build after adding new files with reflected types. (Contributed by junkimu) #jira UE-58275 Change 4102431 by Ben.Marsh UBT: Fix issue where overlapping circularly header dependencies would not be parsed correctly, preventing files not being rebuilt on header changes (noted where Clang detected an out of date PCH). #jira UE-54979 Change 4102328 by Guillaume.Abadie Cherry-pick 4102327: Fixes a bug in FTAAPassParameters::TopLeftCornerViewRects() that was mistakenly increasing input and output view sizes, causing DOF buffers misalignement for split screen & VR. #jira none Change 4102318 by Emil.Persson Fix for dark metal (missing reflections) in Blueprint Editor. Duplicate of changelist 4099649. #jira UE-59217 Change 4102310 by Dmitriy.Dyomin Fixed: UMG element clipping does not work on Android with Mali GPUs #jira UE-56058 Change 4101920 by Ben.Marsh Don't bother tagging the BuildConfiguration schema on Linux and Mac; we only include it in the distribution for Visual Studio anyway. #jira Change 4101538 by Mark.Satterthwaite Duplicate 4073368 Linear allocator for <2MB Managed buffers allocated in 4MB chunks - hopefully this reduces the total number of buffers and thus reduces the churn in the driver further. These should all be Volatile buffers meaning that we should eventually get semi-decent reuse of these buffers. Fixes some buffer alignment and sizing gotcha's along the way. #jira NA Change 4101500 by Mark.Satterthwaite Duplicate 4098091 On Mac we can avoid continually reallocating the depth-fallback texture as we only need the largest size to hang around and we can use DontCare for Load & Store. On iOS due to driver bugs we need to match the size and either Clear or Load - but I think Clear should be faster. Should make FortGPUTestBed faster on the CPU. #jira NA Change 4101453 by Mark.Satterthwaite Duplicate 4078874 & 4079396 Make LPV visualisation work on macOS to aid debugging. #jira UE-58937 Export the constant-buffer bindings that are actually used by Metal shaders to prevent overwriting SRVs & UAVs with unused uniform-buffer data. #jira UE-58937 Change 4101448 by Max.Chen Sequencer: Fix uninitialized default completion mode #jira UE-58335 Change 4101417 by Sam.Deiter #JIRA #RB UEDOC-7656 - Fixed an issue with ARPG not building the loading screen CPP file. Change 4101412 by Mark.Satterthwaite Duplicate 4075868 Metal Vega drivers in 10.13.5 fix blitting with non-zero offsets and we should be using the same buffer blitting path on 2013 Mac Pro's now that we aren't paying an exorbitant cost for doing so. #jira N/A Change 4101393 by Mark.Satterthwaite Fixed a mistake I let slip through in 3934147 that will potentially cause slight miscompilation of SP_METAL. #jira N/A Change 4101390 by Marc.Audy Placed Editor Utility Base once again ticks in the editor as intended #jira UE-59743 Change 4101367 by Brandon.Schaefer Avoid printing when in a signal handler. Put that off until the end #jira UE-36663 Change 4101362 by Mark.Satterthwaite Duplicate 4091485 PR - Fixed potential memory leak. #4751 #jira UE-59490 Change 4101349 by Brandon.Schaefer VHACD Needs to be recompiled #jira UE-59506 Change 4101335 by Brandon.Schaefer Cache files that are invalid or the wrong case sensitivity #jira UE-58250 Change 4101325 by Dan.Oconnor SA fix, remove unneeded null check #jira UE-46834 Change 4101278 by Brandon.Schaefer Set our location to Linux/Mac GenerateProject.sh if we are not running from that location #jira UE-59127, UE-57928 Change 4101219 by Brandon.Schaefer If RunUAT gets a signal while running mono bring mono down as well #jira UE-56041 Change 4101169 by Dan.Oconnor Mirror 4094297 from Dev-Framework Mark blueprint created properties as RF_LoadCompleted to prevent the linker from finding them and overwriting them #jira UE-59642 Change 4101157 by Sam.Deiter #jira UEDOC-7655 Updating these images to reflect the name of the project and look like the other loading screens. Change 4101132 by Jamie.Dale Fixed some places that were running asset registry queries inside a loop and causing performance issues #jira UE-59766 Change 4101125 by Jamie.Dale Added IAssetRegistry::GetAssetsByTags to optimize tag look-up when you can have several potential values #jira UE-59766 Change 4101102 by Dan.Oconnor Mirror 4090824 from Dev-Framework Add abillity to insert pins before or after a target pin for Sequence nodes via the context menu #jira UE-59530 Change 4101017 by Brandon.Schaefer Add a pop up message box for Linux to check if we want to or not submit crash report data #jira UE-59617 Change 4100961 by Michael.Trepka Updated Mac VHACD libs #jira UE-59506 Change 4100703 by Dan.Oconnor Mirror 4090523 from Dev-Framework Allow user to close Blueprint Debugger while at a breakpoint, origin of this behavior was 1148085 and the original issue no longer seems to happen. Also fix mismatch between tab name and context menu entry #jira UE-59526 Change 4100697 by Dan.Oconnor Merge 4083850 from Dev-Framework Prevent GameplayAbilitiesEditor from creating FBluerpintActionDatabase when not neccessary, improve performance of FBlueprintActionDatabase::RegisterAllNodeAction #jira UE-59036 Change 4100687 by Dan.Oconnor Mirror 4086666 from Dev-Framework Fix regression due to 'Step Over' fixes - we could pause VM execution when trying to end a Play-in-Editor or Simulated-in-Editor session #jira UE-58916 Change 4100658 by Jostin.Bilyeu Checking in new level TM-DuelLobeSpec and corresponding assets needed to verify Duel Lobe Specularity #jira UE-29618 Change 4100600 by Max.Chen Sequencer: Fix uninitialized default completion mode #jira UE-58335 Change 4100576 by Dan.Oconnor Mirror 4081417 from Dev-Framework Enum literals are now more similar to byte literals, which makes them safer to pass by reference #jira UE-58473 Change 4100559 by Dan.Oconnor Mirror 4081153 from Dev-Framework Watch Point Viewer should not be a nomad tab, is owned by the Blueprint Debugger tab manager #jira UE-59313 Change 4100540 by Dan.Oconnor Mirror 4078822 from Dev-Framework Continue trying to finish reinstancing when instances of the old class are being async loaded #jira UE-58123 Change 4100527 by Dan.Oconnor Mirror 4092349 from Dev-Framework Speculative fix for shutdown crash, avoid use of LoadModule in DataValidator ShutdownModule and delete delegates registered in another module when BlueprintGraph shuts down #jira UE-57763 Change 4100478 by Mike.Zyracki weighted, non-weighted fix typo fix for issue found by AndrewP #jira UE-58573 Change 4100445 by Mike.Zyracki Fix for build warning, order of initialization. #jira UE-58712 #trivial Change 4100438 by Dan.Oconnor Mirror 4083455 from Dev-Framework Reduce use of template nodes - a template node was causing an ensure when asset reload code attempted to fix it up #jira UE-46834 Change 4100374 by Mike.Zyracki Fix for bad Camera Rotation Imported From Maya Main issue was that we don't support RotationOrders that aren't XYZ. We had some code to zero out other part's of the FBX transform pipeline but it wasn't setting the Rotation Order correctly and was also based upon old documentation. Currently recommendation is to always just zero everything out. Finally had to use ResetPivotSetAndConvertAnimation since there appears to be a bug with ConvertPivotAnimationRecursive into the correct space. #jira UE-59116 Change 4100310 by Jamie.Dale Fixed ExecutePythonScript failing when passing file arguments #jira none Change 4100305 by Mike.Zyracki Fix for performance issues with motion trails. Found that the main issue was the GetRefTM call. Refactored the code so that we only call that once per tick, instead of up to 4 times per tick. Also we cache the calculation of the key positions, so we don't need to calculate them again when calculating keys. Finally the GetRefTM call was recursive which was a decent hint, so we cache out it's parent's first and just get the transform's linearly. Also we don't select parents or children to show their trails also, this seemed buggy and possibly very very slow. #jira UE-58712 Change 4100290 by Ben.Marsh Prevent schema being added as a build product twice. #jira UE-59757 Change 4100259 by Jeff.Fisher Duplicating in Release-4.20: Change: 4087159 UE-58249 Late update has FP precision issues on PSVR -In lateupdate the TranslatedViewMatrix and its inverse were being calculated from the ViewMatrix, by subtracting the PreViewTranslation. This doesn't work because the translation numerical innacuracy is already in the ViewMatrix. -I also rearanged the UpdateViewMatrix code some to make it look more like the FViewMatrix constructor code that sets this up, just to make it easier to spot the difference. #review-4087096 #jira UE-58249 Files: //UE4/Dev-VR/Engine/Source/Runtime/Engine/Private/SceneView.cpp#71 Change 4100170 by Brandon.Schaefer Need dump_syms and BreakpadSymbolEncoder in installed builds #jira UE-59500 Change 4100070 by Richard.Wallis Speculative fix for crash in macOS AppKit NSPersistentUIManager. Disable NSWindow application resume feature per window - we are not using it anyway. OS system may still be called but hopefully this reduces the amount of work it is doing. There still seems to be some generic data getting written however. There is also an undocumented *NSDisablePersistence* plist key. Using this plist key completely stops any data getting written by the OS window resume feature. This CL does NOT use this because it's undocumented but maybe an option for the future. #jira UE-52294 Change 4099999 by James.McNatton Removed the disconnect button in the VirtualCamera plugin and cleaned up redirectors in VCam Widgets folder #jira UE-58032 #rb none Change 4099996 by Ben.Marsh Build: Merge changes to support AutoSDKs on Mac. #jira UE-59574 Change 4099991 by Jamie.Dale Updated wrapped enums to be more consistent with native Python enums - Wrapped enums now generate values that are instances of the enum type itself, containing a name and value field (like native Python enums). - Wrapped enums are now strongly typed and do not allow implicit conversion from numbers (explicit casting is available, but throws if the value is unknown). - Wrapped enum entries may be compared against numbers (even numbers that don't have valid values) via the == and != operators (like IntEnum in Python). - Wrapped enums may now be iterated (like native Python enums). - Wrapped enums now return a length based on their number of entries (like native Python enums). - ScriptName meta-data can now be used with enum entries. #jira none Change 4099973 by Mitchell.Wilson Removing some more content that got duplicated into the main project from the virtualcamera plugin content. #jira UE-59744 Change 4099913 by Jamie.Dale Fixed some places that were calling LoadModuleChecked during shutdown #jira UE-59482 Change 4099905 by Jamie.Dale Fixed InitializeAvailableCultures missing some languages #jira UE-59349 Change 4099879 by Jamie.Dale Fixed a crash when a Blueprint with variable watches was destroyed #jira UE-59117 Change 4099874 by Mitchell.Wilson Removing some unused files from the Content directory. Updating defaultengine.ini with remote session channel info. #jira UE-59745 UE-59744 Change 4099860 by Benn.Gallagher Fixed clothing data binding state becomming mismatched after a reimport over multiple LODs, moved the unbind and rebind steps out of the inner import loop to be handled before and after the total reimport. #jira UE-57337 Change 4099819 by Richard.Wallis Fix for Timed Notifies scrub incorrectly on timeline on Mac. This is also an issue if running in Hi DPI on windows. #jira UE-55678 Change 4099808 by Jamie.Dale Fixed crash when content hot-reloading the build data for the currently loaded world #jira UE-59163 Change 4099773 by Jamie.Dale Fixed crash after attempting to load a package that is too new #jira UE-58121 Change 4099759 by Jamie.Dale Fixed material editor crash if reloading a texture used by the material #jira UE-57762 Change 4099744 by Jamie.Dale Fixed placeholder string table entries being considered identical as their entry may appear in the future #jira UE-58987 Change 4099735 by Jurre.deBaare Crash importing specific Alembic file #fix Additional fix to triangulation vs indexing of vertex attributes, this fixes the crash but also normal issues seen before #misc default constructor for FTrackRenderData which could cause jittering/invisible geometry #jira UE-59095 Change 4099612 by Michael.Trepka Reverted change that delays crash reporting initialization for CEF on Mac #jira UE-57378 Change 4099564 by Guillaume.Abadie Cherry-pick 4075014: Works arround HLSLCC's issue with InterlockedOr in DOF's reduce pass. #jira none Change 4099557 by Guillaume.Abadie Cherry-pick 4074767: Fixes DOF's scattered bokeh changing of intensity dynamic resolution + TAAU. #jira none Change 4099549 by Guillaume.Abadie Cherry-pick 4073050: Whitelists vulkan for DOF's R11G11B10 optimisation and increase to 4 gathering on consoles. #jira none Change 4099544 by Guillaume.Abadie Cherry-pick 4073044: PR #4681: UE-58051: Scene Capture 2D: additive mode not working in 4.19 (Contributed by lion03) #jira UE-58051 Change 4099540 by Richard.Wallis Fix for PIE HighDPI touch location. #jira UE-59015 Change 4099516 by Richard.Wallis speculative fix for FSlateMacMenu::UpdateMenu() crashes. I've not been able to reproduce this. All the crash call stacks seem to be at shutdown, maybe with the save changes dialogue that would appear after modifications then a CMD+Q. I can get similar behaviour by adjusting when the FMacMenu adds and removes itself to the GCachedMenuState map. This fix changes the access pattern to the map from operator[] (which uses a FindChecked underneath and is the cause of this crash/assert) to a FindRef then checking for a valid node. Since these crashes are at shutdown I think this is ok to do and I've tested with this fix in place, randomly not adding those items to GCachedMenuState object during editor operation and it now survives this and recovers if you then reenable the adding of the items. My best guess as to the cause is that the defered update event on shutdown is happenning way after the FMacMenu dealloc has been called and so the GCachedMenuState is empty by then. #jira UE-57012 Change 4099511 by Max.Chen Fix CIS #jira UE-59739 Change 4099486 by Richard.Wallis Speculative fix for crash in FMacWindow::ApplySizeAndModeChanges(). I had seen a crash in here while working on UE-46999 (fix for that submitted in CL 4016062) due to the window handle becoming nil mid way through the ApplySizeAndModeChanges() function then a deref'd. This CL adds extra null pointer protection to make sure we check the validity of the WindowHandle after calls to UpdateFullScreenState(). #jira UE-55071 Change 4099392 by Andrew.Rodham Sequencer: Fixed RootToSequence transform not being used when compiling segments with "Evaluate Sub Sequences in Isolation" enabled #jira UE-59138 Change 4099386 by Ben.Marsh Include the BuildConfiguration.Schema.xsd file in the installed engine build, and don't write it out when running in an installed build. #jira UE-58692 Change 4099382 by Benn.Gallagher Fixed crash when switching clothing meshes when clothing LOD0 is unbound on a clothing data object. #jira UE-55780 Change 4099363 by Jason.Bestimt Fix for HMD errors #jira UEVR-1191 Change 4099307 by Richard.Wallis Clone of CL 4077664: Fix for Mac crash from crash report: [CrashReport] UE4Editor-Renderer.dylib!void FForwardLightingParameters::Set<FRHICommandList, FRHIPixelShader*>(). Reflection uniform buffer is NULL when shader parameter is bound - fails checkSlow(!Parameter.IsBound() || UniformBufferRHI); in SetUniformBufferParameter(). #jira UE-51698 Change 4099289 by Richard.Wallis Clone of CL 4059587: Fix for Sequencer window opening behind Main Window. FLevelSequenceEditorToolkit::Initialize() Closes and reopens the world outliner after adding the Sequencer window. On Mac this makes the world outliner / main window move back in front of the sequencer window. This change swaps around those operations. Reopen the world outliner then add the sequencer window. Outliner info still changes it's visible data as before. Tested with World Outliner docked and undocked. #jira UE-55280 Change 4099279 by Richard.Wallis Fix for crash in Mac editor copying unusual characters in the output log. Current operation is unsafe. String Length, number of bytes and code units are not always interchangeable in this way - use FString as that is the target type and does the right thing. #jira UE-57774 Change 4099256 by Richard.Wallis Fix for menu options not updating immediatly after creating or removing collision on Mac. We set the bChachedMacMenuStateNeedsUpdate when a menu is opening, key up and mouse up. However these can be missed on a mouse menu selection (mouse up doesn't cover this case). This change makes sure that the menu cache updates after a menu item execute operation has been called. #jira UE-57049 Change 4098972 by Max.Chen Sequencer: Modify the section when toggling the bounded range. This fixes an issue where the evaluation would be incorrect because the template wouldn't regenerate when toggling the section bounds. #jira UE-59726 Change 4098967 by Mike.Zyracki Turn off turning off optimization for geometry sequencer tracks. #trivial #jira UESEQ-372 Change 4098942 by Max.Chen Fix CIS #jira UESEQ-372 Change 4098906 by Max.Chen Fix CIS #jira UESEQ-372 Change 4098881 by Max.Chen Fix CIS #jira UESEQ-372 Change 4098667 by Marcus.Wassmer Duplicate 4098665. Fix d3ddebug error on launch #jira UE-59693 Change 4098542 by Mike.Zyracki Geometry Cache Sequencer Support for 4.20 #jira UESEQ-372 Change 4098373 by Jason.Bestimt Misc Vulkan/Lumin fixes from Dev-VR CL 4071730, 4077567, 4077947, 4078460, 4078467, 4081212, 4081315, 4081648, 4083015 #JIRA: UE-59722 Change 4098334 by Ethan.Geller [Release 4.20] #jira UE-54812 fix up include path. Change 4098286 by Matt.Kuhlenschmidt Fix slate resources being destroyed when a dynamic image brush is destoyed even if the resource is shared. #jira UE-55792 Change 4098284 by Brandon.Schaefer Missing header in Monolithic builds Fixed indent issues, was using spaces vs tabs #jira UE-59705 Change 4098247 by Michael.Trepka Fixed a crash in FMacApplication::ProcessMouseUpEvent() #jira UE-57859 Change 4098219 by Matt.Hoffman Linux CIS Fixes for TOptional #trivial #jira None Change 4098209 by Matt.Kuhlenschmidt Disable "restart detection" reimport test until we can reproduce the issue. Its not detecting a legit issue #jira UE-59710 Change 4098132 by Ben.Marsh Add "Nuget Package Manager" to the list of required components for compiling the engine. #jira UE-59376 Change 4098110 by Ben.Marsh Fix missing DLL errors when compiling for Win32 with the VC++ 14.14 toolchain. #jira UE-59150 Change 4098088 by Matt.Kuhlenschmidt Fix ensure starting tutorials in any editor project #jira UE-59714 Change 4098011 by Ben.Marsh Fix editor targets not being rebuilt when packaging from an installed engine build. #jira UE-58652 Change 4098006 by Matt.Hoffman Deleting keys, undoing the deletion, selecting them and then redoing the deletion no longer causes a crash in Sequencer/UMG's Curve Editors. KeyHandleLookupTables were not being serialized so when Undo/Redo transactions happened their map of the key handles would not be restored. This caused a mis-match in the data (the map contained more entries than actual data) so the map would falsely report a valid index when there was not one. Graph Editor selections are not sync'd with the Undo/Redo system currently so redoing a deletion after selecting keys would leave you in a state where you tried to request now out of bounds keys on the next Tick to update the UI. #jira UE-58270 Change 4097995 by Ryan.Vance #jira UEVR-1190 Disable rhi thread when running with vulkan on oculus android platforms. Change 4097981 by Ben.Marsh Ignore private include paths for any precompiled modules. Prevents warnings when they are stripped out from an installed engine build. #jira Change 4097963 by Ben.Marsh Write the exception callstack to the UBT log when thrown reading a makefile. #jira UE-59222 Change 4097940 by Ben.Marsh Prevent source folder being added as a private include path if it does not exist. #jira UE-59145 Change 4097927 by Ethan.Geller [Release-4.20] #jira UE-54812 Bring fixes over for Set Mic Threshold issue in binary builds. #rb aaron.mcleran Change 4097905 by Krzysztof.Narkowicz Added dual specular for subsurface profile shading model. It is controlled by parameters inside subsurface profile. #jira UE-59709 Change 4097898 by Ryan.Vance #jira UEVR-1191 Ensure we prefer VK_PRESENT_MODE_MAILBOX_KHR or VK_PRESENT_MODE_IMMEDIATE_KHR over VK_PRESENT_MODE_FIFO_KHR when creating a swap chain when running inVRr. VSync will interfere with compositor cadence. Change 4097855 by Ben.Marsh Move checks for unique field names behind an additional define, to avoid performance hit when compiling blueprints. #jira UE-58593 Change 4097850 by Ben.Marsh Fix UE4Game compile errors. #jira UE-58593 Change 4097849 by Marcin.Undak Vulkan: fix missing debug markers (TCHAR_TO_ANSI lifetime issues) - Fixed by BrandonS. #jira UE-59484 (merged from Dev-Console) Change 4097844 by Ben.Marsh TBA: Use the trivially relocatable allocator with structured archives, to reduce time taken allocating memory in the constructor. #jira UE-58593 Change 4097840 by Ben.Marsh Add a new allocator (TNonRelocatableInlineAllocator) which eliminates conditional logic from GetAllocation(), at the expense of not being trivially relocatable. This provides a significant performance increase for allocators that are dereferenced frequently, but prevents instances of it being stored inside other allocators (which are expected to be trivially relocatable by default). #jira UE-58593 Change 4097831 by Ben.Marsh TBA: Add a fast path for serializing to binary archives that don't require callbacks when leaving slots. #jira UE-58593 Change 4097825 by Marcin.Undak UAT: don't produce .pak file while cooking on the fly (merged from Dev-Console) #jira UE-58923 Change 4097783 by Ethan.Geller [Release-4.20] #jira UE-58004 fix AudioMixer checks in AudioMixerBlueprintLibary, which solves crash when calling recording BP functions. #rb Aaron.McLeran Change 4097767 by Matt.Kuhlenschmidt Fix crash processing mainframe keybindings during slow tasks #jira UE-55765 Change 4097745 by Ben.Marsh Fixes to UpdateCopyright for latest source. #jira Change 4097743 by mason.seay Test map for Virtual Camera Focus testing #jira UE-29618 Change 4097723 by Matt.Kuhlenschmidt Fix crash when importing assets in a folder containing an invalid character for a package name #jira UE-59166,UE-44071 Change 4097713 by Max.Chen Sequencer: Fix missing buttons in the particle toggle track. Fixed CreateKeyEditor and make the the channel handles reflect the channel's inheritance hierarchy. #jira UE-59542 Change 4097683 by Max.Chen Sequencer Scripting: Move to "Scripting" category alongside Python Script Plugin #jira UE-59568 Change 4097681 by Krzysztof.Narkowicz Missing file for CL 4097655: "Added subsurface profile for eye shading model." #jira UE-59708 Change 4097655 by Krzysztof.Narkowicz Added subsurface profile for eye shading model. #jira UE-59708 Change 4097634 by Max.Chen Sequencer: Add checks for valid sequencer. #jira UE-59287 Change 4097627 by Max.Chen Sequencer: Fix for crash OnKeySelected and GetAutoSizeRange #jira UE-58343 Change 4097625 by Max.Chen Sequence Recorder: Fix StopRecording() condition when there is an actor recording that doesn't have a valid actor to record. Fix bool recorder not using bool channels. #jira UE-58688 Change 4097620 by Max.Chen Actor Sequence: Fix crash on compiling blueprint with deleted actor sequence #jira UE-53186 #jira UE-59664 Change 4097616 by Max.Chen Text Render Component: Fix crash on shutdown. #jira UE-58116 Change 4097607 by Max.Chen Sequencer: Use non-throttled spin box for numeric key editor #jira UE-59219 Change 4097606 by Max.Chen Sequencer: Check for a valid segment ID in EvaluateStatic #jira UE-57596 Change 4097538 by Marc.Audy PR #4755: Fix minor typo in comment (Contributed by Marenz) #jira UE-59671 Change 4097518 by Marcin.Undak UBT: fix for platforms overriding project generation (merge from Dev-Console) #jira UE-59485 Change 4097417 by Benn.Gallagher Fixed barycentric computation case causing a check. Should really just output an invalid sentinel value. Warns about failures but no longer crashes. #jira UE-57097 Change 4097407 by Jason.Bestimt Changing MLSDK missing callback to launch MagicLeap URL #JIRA: UE-58631 Change 4097404 by Jason.Bestimt Proper fix for UE-58864 (crash for Android derived platforms in Launch on menu) #JIRA: UE-58864 Change 4097296 by Matt.Kuhlenschmidt Fix rotation widget no longer correctly displaying rotation label while rotating in high dpi #jira UE-58983 Change 4097284 by Matt.Kuhlenschmidt PR #4650: Git plugin: fix crash on commit error (Contributed by SRombauts) #jira UE-57562 Change 4097275 by Matt.Kuhlenschmidt Fix crash if slate shuts down while a drag drop operation is in progress #jira UE-58888 Change 4097261 by Matt.Kuhlenschmidt Undo //UE4/Release-4.20/Engine/Source/Runtime/Slate/Private/Framework/Application/... changelist 4097249 #jira 0 Change 4097249 by Matt.Kuhlenschmidt Fix crash if slate shuts down while a drag drop operation is in progress #jira UE-58888 Change 4097165 by Nick.Shin #jira UE-58441 HTML5 package crashes on several key combinations: uncaught exception: ASM_CONSTS Change 4097163 by Nick.Shin #jira UE-58423 HTML5 Quicklaunch through UnrealFrontEnd fails on Stage Command: Error: System.NullReferenceExeception Change 4096984 by Ben.Marsh Merging changes to //UE4/Main after 4.20 stream was created. #jira Change 4096873 by Ben.Marsh Fix compile errors for UE4Editor when Oodle SDK is not available. #jira Change 4095992 by Ben.Marsh Update stream for analytics. #robomerge none #jira Change 4111924 by Ben.Marsh Force Win32/Win64 game targets in the installed engine build to be compiled with VS2015, to fix missing symbols linking object files built with VS2017 with VS0215 MSVCRT. #jira UE-59891 Change 4106160 by Ben.Marsh UBT: Fix intermittent PDB errors when compiling with ParallelExecutor, caused by MSPDBSRV.EXE instances being terminated while generating multiple PDBs in parallel. #jira UE-59691 Change 4101702 by Mark.Satterthwaite Duplicate 4098660 & 4101604 Restore the MacGraphicsSwitching plugin removed in 3212253 and begin refactoring it to support switching the Editor between Metal GPUs - primarily this is of benefit to those with eGPUs. - Changing the GPU will ask you to restart. - Fixes a bug where 27" iMacs report an Intel GPU even though it is physically disabled. Add support for Metal device notiications and amend the MacGraphicsSwitching plugin to use it to update when GPUs are added or removed. #jira UERNDR-404 Change 4101598 by Andrew.Grant Changed RemoteSession background to something more generic. #jira UE-59062 Change 4101553 by Mark.Satterthwaite Duplicate 4072923 & 4081236 & 4082081 & 4084046 & 4084647 - Fixes LLM double-counting in MetalRHI. - MetalProfiler improvements. #jira NA Change 4099406 by Ben.Marsh Disable building IOS in installed builds on Windows by default. We don't support this on the cross-compile toolchain. #jira UE-57801 [CL 4112874 by jason bestimt in Dev-VR branch]
2018-06-05 10:27:10 -04:00
if (!GIsRequestingExit && ErrorReport.HasFilesToUpload() && FPrimaryCrashProperties::Get() != nullptr)
{
ErrorReport.SetCrashReportClientVersion(FCrashReportCoreConfig::Get().GetVersion());
FCrashReportAnalytics::Initialize();
if (bUnattended)
{
RunUnattended(ErrorReport);
}
#if !CRASH_REPORT_UNATTENDED_ONLY
else
{
if (!RunWithUI(ErrorReport))
{
// UI failed to initialize, probably due to driver crash. Send in unattended mode if allowed.
bool bCanSendWhenUIFailedToInitialize = true;
GConfig->GetBool(TEXT("CrashReportClient"), TEXT("CanSendWhenUIFailedToInitialize"), bCanSendWhenUIFailedToInitialize, GEngineIni);
if (bCanSendWhenUIFailedToInitialize && !FCrashReportCoreConfig::Get().IsAllowedToCloseWithoutSending())
{
RunUnattended(ErrorReport);
}
}
}
#endif // !CRASH_REPORT_UNATTENDED_ONLY
// Shutdown analytics.
FCrashReportAnalytics::Shutdown();
}
else
{
// Needed to let systems that are shutting down that we are shutting down by request
GIsRequestingExit = true;
}
FPrimaryCrashProperties::Shutdown();
FPlatformErrorReport::ShutDown();
FEngineLoop::AppPreExit();
FModuleManager::Get().UnloadModulesAtShutdown();
FTaskGraphInterface::Shutdown();
FEngineLoop::AppExit();
}