2019-12-26 14:45:42 -05:00
// Copyright Epic Games, Inc. All Rights Reserved.
2015-06-10 03:14:50 -04:00
# include "RuntimeAssetCache.h"
Copying //UE4/Dev-Build to //UE4/Dev-Main (Source: //UE4/Dev-Build @ 3209340)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3209340 on 2016/11/23 by Ben.Marsh
Convert UE4 codebase to an "include what you use" model - where every header just includes the dependencies it needs, rather than every source file including large monolithic headers like Engine.h and UnrealEd.h.
Measured full rebuild times around 2x faster using XGE on Windows, and improvements of 25% or more for incremental builds and full rebuilds on most other platforms.
* Every header now includes everything it needs to compile.
* There's a CoreMinimal.h header that gets you a set of ubiquitous types from Core (eg. FString, FName, TArray, FVector, etc...). Most headers now include this first.
* There's a CoreTypes.h header that sets up primitive UE4 types and build macros (int32, PLATFORM_WIN64, etc...). All headers in Core include this first, as does CoreMinimal.h.
* Every .cpp file includes its matching .h file first.
* This helps validate that each header is including everything it needs to compile.
* No engine code includes a monolithic header such as Engine.h or UnrealEd.h any more.
* You will get a warning if you try to include one of these from the engine. They still exist for compatibility with game projects and do not produce warnings when included there.
* There have only been minor changes to our internal games down to accommodate these changes. The intent is for this to be as seamless as possible.
* No engine code explicitly includes a precompiled header any more.
* We still use PCHs, but they're force-included on the compiler command line by UnrealBuildTool instead. This lets us tune what they contain without breaking any existing include dependencies.
* PCHs are generated by a tool to get a statistical amount of coverage for the source files using it, and I've seeded the new shared PCHs to contain any header included by > 15% of source files.
Tool used to generate this transform is at Engine\Source\Programs\IncludeTool.
[CL 3209342 by Ben Marsh in Main branch]
2016-11-23 15:48:37 -05:00
# include "Misc/ScopeLock.h"
# include "Stats/StatsMisc.h"
# include "Misc/ConfigCacheIni.h"
2015-06-10 03:14:50 -04:00
# include "RuntimeAssetCachePluginInterface.h"
Copying //UE4/Dev-Build to //UE4/Dev-Main (Source: //UE4/Dev-Build @ 3209340)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3209340 on 2016/11/23 by Ben.Marsh
Convert UE4 codebase to an "include what you use" model - where every header just includes the dependencies it needs, rather than every source file including large monolithic headers like Engine.h and UnrealEd.h.
Measured full rebuild times around 2x faster using XGE on Windows, and improvements of 25% or more for incremental builds and full rebuilds on most other platforms.
* Every header now includes everything it needs to compile.
* There's a CoreMinimal.h header that gets you a set of ubiquitous types from Core (eg. FString, FName, TArray, FVector, etc...). Most headers now include this first.
* There's a CoreTypes.h header that sets up primitive UE4 types and build macros (int32, PLATFORM_WIN64, etc...). All headers in Core include this first, as does CoreMinimal.h.
* Every .cpp file includes its matching .h file first.
* This helps validate that each header is including everything it needs to compile.
* No engine code includes a monolithic header such as Engine.h or UnrealEd.h any more.
* You will get a warning if you try to include one of these from the engine. They still exist for compatibility with game projects and do not produce warnings when included there.
* There have only been minor changes to our internal games down to accommodate these changes. The intent is for this to be as seamless as possible.
* No engine code explicitly includes a precompiled header any more.
* We still use PCHs, but they're force-included on the compiler command line by UnrealBuildTool instead. This lets us tune what they contain without breaking any existing include dependencies.
* PCHs are generated by a tool to get a statistical amount of coverage for the source files using it, and I've seeded the new shared PCHs to contain any header included by > 15% of source files.
Tool used to generate this transform is at Engine\Source\Programs\IncludeTool.
[CL 3209342 by Ben Marsh in Main branch]
2016-11-23 15:48:37 -05:00
# include "RuntimeAssetCacheBackend.h"
2015-06-10 03:14:50 -04:00
# include "RuntimeAssetCacheBucket.h"
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3544039)
#lockdown Nick.Penwarden
#rb none
#rnx
=====================================
MAJOR FEATURES + CHANGES
=====================================
Change 3343905 by Dan.Oconnor
ResolveMember optimizations and moved into cpp. ResolveMember<UFunction> now checks UClass::FuncMap before doing more expensive searches
Change 3346637 by Ben.Zeigler
Actually fix in non editor builds
Change 3355484 by Dan.Oconnor
Back out FMemberReference Optimization
Change 3425833 by Ben.Zeigler
#jira UE-31749 Fix it so Undo works properly when modifying a local variable
#jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value
Change 3510091 by Marc.Audy
Expose on Spawn functional test
#rnx
Change 3510100 by Marc.Audy
Fix spelling error
#rnx
Change 3510132 by Marc.Audy
Fix issues with marking a widget blueprint class as abstract
Change 3510133 by Marc.Audy
Minor code cleanup
#rnx
Change 3510178 by Ben.Zeigler
#jira UE-46500 Fix it so editor-only and transient stuct members are not serialized for literal blueprint structs. It's unsafe to serialize them because they may not exist in the cooked build
Change 3510466 by Ben.Zeigler
Start adding basic ability system tests to enginetest, very minimal so far
Change 3511295 by Marc.Audy
Fix wasted work going weak -> object -> weak -> object
#rnx
Change 3511824 by Marc.Audy
Fix spelling error in tooltip
#jira UE-46515
#rnx
Change 3514446 by Ben.Zeigler
Fix ActorBoundEvent and ComponentBoundEvent to always refresh their event signature from the delegate property they are bound to. This is required to correctly deal with delegate signatures being moved or renamed. Both types now do the fixup one time, in ReconstructNode.
Change 3514578 by Marc.Audy
Move clearing of the actor component need end of frame update mark to base class instead of just primitive component
Change 3514583 by Ben.Zeigler
Better fix to last delegate checkin that also handles moving functions between modules but not renaming
Change 3515325 by Dan.Oconnor
Fix for rare orphan pin false positive, rare exposed on spawn false positive
#rnx
Change 3515761 by Marc.Audy
fix shipping configuration
#rnx
Change 3515772 by Marc.Audy
Fix static analysis warnings
#rnx
Change 3516287 by Marc.Audy
Fix references to instanced components not being updated when resetting component to default
#jira UE-44706
#rnx
Change 3516303 by Marc.Audy
Back out CL# 3516287 while an oddity is investigated
#rnx
Change 3516563 by Marc.Audy
(4.17) Fix references to instanced components not being updated when resetting component to default
#jira UE-44706
Change 3516637 by Phillip.Kavan
#jira UE-44661 - Fix potential crash when changing the ChildActorComponent class default value on a Blueprint that also sets the class in the Construction Script.
Change summary:
- Modified UChildActorComponent::DestroyChildActor() to move the check for PendingKill/Unreachable so that we can also rename a defunct ChildActor instance out of the way in order to allow for a new ChildActor instance w/ the cached name.
Change 3517735 by Marc.Audy
Avoid unnecessary string copy
#rnx
Change 3517931 by Marc.Audy
Small optimization to CleanupActors
Change 3518221 by Dan.Oconnor
Fix rare crash when running ConformImplementedEvents when async loading
#jira UE-45348
Change 3518270 by Ben.Zeigler
#jira UE-46574 Add FCollectionReference type and customization to allow setting an FName to an editor collection
Add AssetCollection to PrimaryAssetLabel that derives the bundled assets from an editor collection
Change 3518271 by Marc.Audy
Get rid of unnecessary construction differentiation if custom reset is being used
Change 3518310 by Ben.Marsh
Re-adding IOS files with correct case.
Change 3518423 by Ben.Zeigler
#jira UE-46574 Initial support for chunk installation in Asset Manager.
Refactor AssetManagerSettings so it copies runtime bools into the asset manager for fast access
Add a concept of a stalled streamable manager handle, handles can be created stalled and will not execute their async load until all needed resources have been acquired externally
Change 3518480 by Marc.Audy
Correctly get the variable reference for an input variable get from the member scope rather than a member variable of the same name on the class
#jira UE-46737
Change 3518498 by Ben.Zeigler
Fix bug with AssetManager where requesting the same load twice in a row before the first one finishes caused the complete callback to get called too early for the second load
Update test map to catch this
Change 3518526 by Ben.Zeigler
IOS Fix
Change 3518619 by Ben.Zeigler
#jira UE-46744 Fix issue where refreshing asset manager editor settings would throw away asset label rules overrides, causing the recursive flag to accidentally get set
Change 3518747 by Phillip.Kavan
#jira UE-43154 - Prevent ConstructGenericObject nodes from compiling if the selected type does not include 'BlueprintType' in its inheritance hierarchy.
Change summary:
- Moved UGameplayStatics::CanSpawnObjectOfClass() into UK2Node_GenericCreateObject as a local util method (per JIRA notes). This was not exposed to Blueprints and as such was inconsistent with the rest of the API.
- Modified UGameplayStatics::SpawnObject() to no longer call CanSpawnObjectOfClass(). This seemed redundant as this will already have been called during node validation at Blueprint compile time.
- Refactored CanSpawnObjectOfClass() into FK2Node_GenericCreateObject_Utils. Walking up the inheritance chain no longer starts out w/ the assumption that 'BlueprintType' is set by default, which was previously including a lot of engine-specific classes into the "allowed" set (e.g. UByteProperty). Also unified the 2 loop iterations that were being used to check for 'BlueprintType'/'NotBlueprintType' and 'DontUseGenericSpawnObjectName', as well as the check for whether or not the class is a derivative of AActor/UActorComponent.
- Modified UK2Node_GenericCreateObject::EarlyValidation() to call FK2Node_GenericCreateObject_Utils::CanSpawnObjectOfClass() and emit a slightly more informative error message to the BP compiler message log.
Change 3518756 by Michael.Noland
(4.17) Framework: Prevent various asserts when USplineComponent methods are called on a spline with no points
Change 3518760 by Michael.Noland
Core: Changed FRuntimeAssetCache ensures to ensureAsRuntimeWarning
Change 3518771 by Michael.Noland
AI: Prevent an ensure in UBlackboardComponent::ClearValue when called on a component with a null BlackboardAsset
Change 3518818 by Michael.Noland
Rendering: Fixed a whitespace issue in UCanvasRenderTarget2D::RepaintCanvas()
#rnx
Change 3518822 by Michael.Noland
Sequencer: Prevented crashes in some methods of UMovieSceneSequencePlayer when there is no Sequence set
Sequencer: Prevented a crash in FMovieSceneRootEvaluationTemplateInstance::Evaluate when the instance has no template set
Change 3518824 by Michael.Noland
Landscape: Marked ULandscapeComponent and ULandscapeHeightfieldCollisionComponent as Within=LandscapeProxy, since they do CastChecked on their Outer all the time
Change 3519073 by Michael.Noland
QAGame: Fixed a crash in UQASynth::PlaySynth() if called on a directly created instance rather than using the factory method
Change 3519076 by Michael.Noland
Preventing crashes in UAutomationPerformaceHelper (sic) when spawned abnormally for fuzzing (assumes that the outer will have a route to a world)
#rnx
Change 3519079 by Michael.Noland
Sequencer: Fixed a potential crash in UMediaPlaylist::Insert and UMediaPlaylist::RemoveAt when passed an invalid index
Change 3519081 by Michael.Noland
Blueprints: Added support for creating appropriate outers for objects that must be nested within another class during fuzzing (ones that specify Within=, other relationships aren't knowable yet)
Change 3519082 by Michael.Noland
VR: Prevent a crash in UMRMeshComponent::ConnectReconstructor when passed a null reconstructor
Change 3519084 by Michael.Noland
Rendering: Prevent crashes when UNiagaraComponent::GetEffectDataInterface is called on a component with no effect asset set
Change 3521889 by Michael.Noland
Sequencer: Prevented a bogus static analysis warning by reworking the code (FixedFrameInterval could have only been set if the pointer were valid from the line above)
#rnx
Change 3521987 by Michael.Noland
Animation: Prevent a couple of potential asserts in UControlRig::GetOrAllocateSubControlRig
Change 3522101 by Michael.Noland
Physics: Improved the comment on UPhysicalMaterial::Friction
#rn
Change 3522105 by Michael.Noland
Physics: Fixed a few crashes in UVehicleWheel when spawned directly
Change 3522106 by Michael.Noland
Framework: Marked ULevelStreaming as Within=World, since it does CastChecked on the Outer all the time
Change 3522109 by Michael.Noland
Animation: Marked UAnimInstance as Within=SkeletalMeshComponent since it assumes the outer in various places
Change 3522121 by Michael.Noland
Mobile: Prevent UMobileInstalledContent methods from crashing when called on a created instance in an uncooked build (no installed manifest)
Change 3522783 by Zak.Middleton
#ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before).
Change 3525477 by Dan.Oconnor
Remove Tooltip, Category, and HideCategories tooltip from the blueprint generated class if source data is cleared
Change 3526538 by Ben.Zeigler
Refresh primary asset labels if their bundles are different at all and not just if they're added or removed. This is required because they now work based on collections or directories. This fixes issue with the onboarding collection changes not correctly modifying chunks
Copy of CL #3526501
Change 3526817 by Ben.Zeigler
#jira UE-46917 Fix issue where maps that do not contain level script blueprints were being counted as unindexed for find in blueprints. The old behavior depended on detecting the existence of empty tags, but the asset registry now filters those out so treat maps with no FiB data as indexed
Change 3526873 by Ben.Zeigler
#jira UE-46627 Change it so blueprint or native subclasses of static mesh actor cannot be added to clusters, as they are not likely to be immutable the way the base class is
Add code to to the ubergraph frame to fall back to hard reference serialization if the reference collector doesn't support weak references, such as the cluster collector
Change 3526958 by Marc.Audy
(4.17) Don't copy and then break pin links when reconstructing. Instead simply move.
#jira UE-46935
Change 3528916 by Marc.Audy
PR #3609: Adds GetKeysForAxis() to complement GetKeysForAction() in UPlayerInput (Contributed by alanedwardes)
#jira UE-45347
Change 3529080 by mason.seay
BP asset for undetermined type bug
Change 3529381 by Marc.Audy
Fix ability to insert duplicates in to a set or map
Change 3529471 by Dan.Oconnor
Fix for clang 4.0 error: definition of builtin function '__rdtsc' inline unsigned long long __rdtsc()
Change 3530876 by Marc.Audy
Based on PR #3457: Add MakeSet BP node (Contributed by projectgheist)
Also refactored MakeArray/Set to share a base MakeContainer class
Cleaned up some dead code from MakeArray
Added icon for MakeSet
Added Functional Test for MakeSet
#jira UE-43717
Change 3531070 by Phillip.Kavan
#jira UE-46866 - Fix crash on load when an external variable member reference's owning type cannot be loaded.
Change summary:
- Modified FBlueprintEditorUtils::GetSkeletonClass() to check for NULL before attempting to check for the generating BP.
Change 3531081 by Marc.Audy
Remove deprecated CustomMapParamValue code
Change 3531094 by Phillip.Kavan
#jira UE-46952 - Fix a packaging code build failure that will occur with a nativized Blueprint class that contains a UInterfaceProperty.
Change summary:
- Modified TScriptInterface::operator=() to cast the given 'SourceObject' instance to the 'InterfaceType' type before assigning to 'SourceInterface'. This was necessary because if the caller (in this case nativized codegen) passes in a UObject* that does not explicitly inherit from 'InterfaceType', then it will need to go through the object's GetInterfaceAddress() API instead and cast the result back to an 'InterfaceType' pointer.
Change 3531186 by Phillip.Kavan
Back out changelist 3531094 (temp CIS fix).
#rnx
Change 3532082 by Marc.Audy
Move garbage collection timers and other management to UEngine instead of UWorld
Fixes CollectGarbage blueprint node not working in shipping
#jira UE-46566
Change 3532134 by Phillip.Kavan
Restored changelist 3531094 w/ fix for non-unity.
- Mirrored from //UE4/Release-4.17 (CL# 3531232).
#rnx
Change 3533009 by Marc.Audy
Fixup missing function and deprecation warnings
Change 3534056 by Marc.Audy
(4.17) Fix expose on spawn of map and sets to work
#jira UE-47140
Change 3534761 by Marc.Audy
(4.17) Apply code review changes to Dev-Framework as well
#rnx
Change 3535147 by Dan.Oconnor
Build fix, already made in 4.17
#rnx
Change 3535530 by mason.seay
Resaving to remove error when opening level blueprint
Change 3535581 by Marc.Audy
Class Properties are only identical if they are literally the same object. Do not consider the deep compare port flags as object property base does.
#jira UE-46533
Change 3535583 by Marc.Audy
When properties are imported in to a child actor component the cached instance data is invalidated, so clear it.
#jira UE-46533
Change 3535617 by Marc.Audy
PR #3788: UE-39237: Prevent (im-)pure casting during BP debugging (Contributed by projectgheist)
#jira UE-47188
#jira UE-39237
Change 3535671 by Marc.Audy
Change NodeFactory to look at interface to use sequence node instead of each node having to add itself
Change 3535955 by Marc.Audy
Prevent MakeSet from removing split pins
Change 3536114 by Michael.Noland
Paper2D: Removing deprecated code from 4.3/4.4 era
#rnx
Change 3536120 by Michael.Noland
Animation: Removed deprecated FTAlphaBlend class and AlphaBlendType.h header
Change 3536124 by Michael.Noland
Physics: Removed deprecated methods that were replaced by _AssumesLocked variations
Change 3536131 by Michael.Noland
Slate: Converting remaining uses of EKeyboardFocusCause to EFocusCause and properly deprecating it
Change 3536138 by Michael.Noland
Slate: Removed any deprecated code older than 4.10 that didn't affect content compatibility
Change 3536167 by Dan.Oconnor
When a client provides a skeleton class as the self scope, make sure we also use a skel class for non-self scopes - but only if using the compilation manager. Skel classes are not reliably up to date when not using the compilation manager
#jira UE-46904
Change 3536221 by Michael.Noland
Editor: Removing deprecated code from 4.9 or earlier
Change 3536240 by Michael.Noland
Blueprints: Removed long-deprecated TypeToString method from the K2 schema
#rnx
Change 3536243 by Michael.Noland
AI: Prevent crashes if UMockTask_Log is created manually rather than via the CreateTask factory method
Change 3536244 by Michael.Noland
Core: Prevent FScopedExternalProfilerBase::StopScopedTimer() from asserting if called an unmatched number of times with StartScopedTimer, as both are exposed to BPs now
Change 3536250 by Michael.Noland
CoreUObject: Removed any deprecated code older than 4.10 that didn't affect content compatibility
Change 3536253 by Michael.Noland
Core: Removed any deprecated code older than 4.10 that didn't affect content compatibility
Change 3536310 by Michael.Noland
Engine: Removed any deprecated code older than 4.10 that didn't affect content compatibility
Change 3536397 by Mieszko.Zielinski
Fixed UCrowdFollowingComponent::UpdateCachedDirections crashing when CharacterMovement is not set #UE4
#jira UE-46860
Change 3536404 by Michael.Noland
Platform: Added a warning for others when they try to remove this 'deprecated' method
Change 3536639 by Michael.Noland
CharacterMovement: Changed the name of a variable introduced in CL# 3536397 to better match intent
#rnx
Change 3536893 by Michael.Noland
Blueprints: Clear the stale value on the value pin when a map find node fails to find an item
#jira UE-47233
Change 3536902 by Michael.Noland
Framework: Killed a couple of more deprecated methods that were not exposed to Blueprints
#rnx
Change 3537038 by Ben.Marsh
Fixing case of iOS directories, pt1
Change 3537039 by Ben.Marsh
Fixing case of iOS directories, pt2
Change 3538246 by Michael.Noland
UnrealTournament: Fixing issues with renamed enum
#rnx
Change 3538618 by Ben.Zeigler
Fix ensure when closing sequencer transform UI
Change 3540213 by Ben.Zeigler
#jira UE-47313 Fix crash serializing a MapProperty where the value type has changed for a type that implements ConvertFromType. The address passed to ConvertFromType needs to be the container root, not the specific value address, keys worked because the offset was 0.
Change 3540253 by Marc.Audy
Only copy default values for input pins as output pins do not have them
#rnx
Change 3540376 by Marc.Audy
Add utility FromPinType for FEdGraphTerminalType
#rnx
Change 3540433 by Marc.Audy
Add MakeMap
#jira UE-47093
Unify IsConnectionDisallowed for containers and fix static analysis warning
#jira UE-47291
Change 3540585 by Phillip.Kavan
#jira UE-47117 - Fix crash on launch of a nativized build that includes an instanced default subobject that's referenced by another instanced default subobject.
Change summary:
- Modified FEmitDefaultValueHelper::HandleSpecialTypes() to only direct HandleInstancedSubobject() to emit code to create the instanced subobject if it's not a default subobject. This was previously being incorrectly interpreted as an object having the 'RF_ArchetypeObject' flag set; however, default subobjects will also have that flag set in addition to the 'RF_DefaultSubobject' flag.
- Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert in the 'GetDefaultSubobjectByName' case if the given object is not also a default subobject.
Change 3541147 by Dan.Oconnor
Fix for not being able to override custom events when using the compilation manager post 3536167
#jira UE-47292
#rnx
Change 3541177 by Ben.Zeigler
#jira UE-46595, UE-46553 Fix issue where creating a widget template could cause a widget blueprint being cooked to have the wrong package flags, making it appear to be an uncooked package
Copy of CL #3541027
Change 3541325 by Dan.Oconnor
K2node data table data needs to preload data before the compilation queue is flushed
#rnx
#jira UE-47319
Change 3541409 by Michael.Noland
Blueprints: Added code to reapply any active breakpoints after recompilation when using the BP compilation manager
#jira UE-47322
[reimplementing CL# 3541404 in Dev-Framework]
Change 3541418 by Dan.Oconnor
Fix for bad SKEL_ CDO reference in blueprint bytecode
#jira UE-47265
#rnx
Change 3541482 by Dan.Oconnor
Blanket fix up of preload calls that are being done in AllocateDefaultPins. AllocatDefaultPins is not called until compile, meaning if these preload calls load blueprints they will be loaded while the compilation manager is compiling blueprints
#rnx
#jira UE-47319
Change 3541817 by Marc.Audy
Fix static analysis warnings
#rnx
Change 3542299 by Michael.Noland
Blueprints: Speculative fix for static analysis warning
#rnx
Change 3542406 by Marc.Audy
Use a check slow to avoid any cost
#rnx
Change 3542486 by Michael.Noland
Asset Manager: Removing an unnecessary ensure (it's a potentially expected case)
#jira UE-47380
Change 3542659 by Michael.Noland
Blueprints: Clear out null entries in the LastEditedDocuments list during PostLoad() and remove entries when a graph is being deleted to prevent their generation in the first place
#jira UE-47385
Change 3543620 by Dan.Oconnor
Remove overzealous ensure - we may recompile blueprints that are asynchronously loading when a user triggers a synchronous compile
#jira UE-47415
#rnx
Change 3518415 by Ben.Zeigler
#jira UE-46574 Deprecate IPlatformChunkInstall::SetChunkInstallDelgate as it was spelled wrong, was only half implemented, and did not support success vs failure
Replace with AddChunkInstallDelegate, which supports a bool error code and is bound once instead of separately for each chunk. All implementations support this delegate at a basic level, although several could be improved to call the failure delegate in more cases
Change 3534339 by Michael.Noland
Platforms: Changed DEPRECATED() macro description to use 4.xx rather than a speciifc version in examples, so it doesn't show up when removing deprecated code
[CL 3544050 by Marc Audy in Main branch]
2017-07-19 09:49:59 -04:00
# include "Misc/RuntimeErrors.h"
2015-06-10 03:14:50 -04:00
DEFINE_STAT ( STAT_RAC_ASyncWaitTime ) ;
FRuntimeAssetCache : : FRuntimeAssetCache ( )
{
FString BucketName ;
int32 BucketSize ;
TArray < FString > BucketNames ;
GConfig - > GetArray ( TEXT ( " RuntimeAssetCache " ) , TEXT ( " BucketConfigs " ) , BucketNames , GEngineIni ) ;
for ( FString & Bucket : BucketNames )
{
if ( FParse : : Value ( * Bucket , TEXT ( " Name= " ) , BucketName ) )
{
BucketSize = FRuntimeAssetCacheBucket : : DefaultBucketSize ;
FParse : : Value ( * Bucket , TEXT ( " Size= " ) , BucketSize ) ;
FRuntimeAssetCacheBucket * BucketDesc = FRuntimeAssetCacheBackend : : Get ( ) . PreLoadBucket ( FName ( * BucketName ) , BucketSize ) ;
Buckets . Add ( FName ( * BucketName ) , BucketDesc ) ;
}
}
}
FRuntimeAssetCache : : ~ FRuntimeAssetCache ( )
{
for ( auto & Bucket : Buckets )
{
delete Bucket . Value ;
}
Buckets . Empty ( ) ;
}
int32 FRuntimeAssetCache : : GetCacheSize ( FName Bucket ) const
{
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3544039)
#lockdown Nick.Penwarden
#rb none
#rnx
=====================================
MAJOR FEATURES + CHANGES
=====================================
Change 3343905 by Dan.Oconnor
ResolveMember optimizations and moved into cpp. ResolveMember<UFunction> now checks UClass::FuncMap before doing more expensive searches
Change 3346637 by Ben.Zeigler
Actually fix in non editor builds
Change 3355484 by Dan.Oconnor
Back out FMemberReference Optimization
Change 3425833 by Ben.Zeigler
#jira UE-31749 Fix it so Undo works properly when modifying a local variable
#jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value
Change 3510091 by Marc.Audy
Expose on Spawn functional test
#rnx
Change 3510100 by Marc.Audy
Fix spelling error
#rnx
Change 3510132 by Marc.Audy
Fix issues with marking a widget blueprint class as abstract
Change 3510133 by Marc.Audy
Minor code cleanup
#rnx
Change 3510178 by Ben.Zeigler
#jira UE-46500 Fix it so editor-only and transient stuct members are not serialized for literal blueprint structs. It's unsafe to serialize them because they may not exist in the cooked build
Change 3510466 by Ben.Zeigler
Start adding basic ability system tests to enginetest, very minimal so far
Change 3511295 by Marc.Audy
Fix wasted work going weak -> object -> weak -> object
#rnx
Change 3511824 by Marc.Audy
Fix spelling error in tooltip
#jira UE-46515
#rnx
Change 3514446 by Ben.Zeigler
Fix ActorBoundEvent and ComponentBoundEvent to always refresh their event signature from the delegate property they are bound to. This is required to correctly deal with delegate signatures being moved or renamed. Both types now do the fixup one time, in ReconstructNode.
Change 3514578 by Marc.Audy
Move clearing of the actor component need end of frame update mark to base class instead of just primitive component
Change 3514583 by Ben.Zeigler
Better fix to last delegate checkin that also handles moving functions between modules but not renaming
Change 3515325 by Dan.Oconnor
Fix for rare orphan pin false positive, rare exposed on spawn false positive
#rnx
Change 3515761 by Marc.Audy
fix shipping configuration
#rnx
Change 3515772 by Marc.Audy
Fix static analysis warnings
#rnx
Change 3516287 by Marc.Audy
Fix references to instanced components not being updated when resetting component to default
#jira UE-44706
#rnx
Change 3516303 by Marc.Audy
Back out CL# 3516287 while an oddity is investigated
#rnx
Change 3516563 by Marc.Audy
(4.17) Fix references to instanced components not being updated when resetting component to default
#jira UE-44706
Change 3516637 by Phillip.Kavan
#jira UE-44661 - Fix potential crash when changing the ChildActorComponent class default value on a Blueprint that also sets the class in the Construction Script.
Change summary:
- Modified UChildActorComponent::DestroyChildActor() to move the check for PendingKill/Unreachable so that we can also rename a defunct ChildActor instance out of the way in order to allow for a new ChildActor instance w/ the cached name.
Change 3517735 by Marc.Audy
Avoid unnecessary string copy
#rnx
Change 3517931 by Marc.Audy
Small optimization to CleanupActors
Change 3518221 by Dan.Oconnor
Fix rare crash when running ConformImplementedEvents when async loading
#jira UE-45348
Change 3518270 by Ben.Zeigler
#jira UE-46574 Add FCollectionReference type and customization to allow setting an FName to an editor collection
Add AssetCollection to PrimaryAssetLabel that derives the bundled assets from an editor collection
Change 3518271 by Marc.Audy
Get rid of unnecessary construction differentiation if custom reset is being used
Change 3518310 by Ben.Marsh
Re-adding IOS files with correct case.
Change 3518423 by Ben.Zeigler
#jira UE-46574 Initial support for chunk installation in Asset Manager.
Refactor AssetManagerSettings so it copies runtime bools into the asset manager for fast access
Add a concept of a stalled streamable manager handle, handles can be created stalled and will not execute their async load until all needed resources have been acquired externally
Change 3518480 by Marc.Audy
Correctly get the variable reference for an input variable get from the member scope rather than a member variable of the same name on the class
#jira UE-46737
Change 3518498 by Ben.Zeigler
Fix bug with AssetManager where requesting the same load twice in a row before the first one finishes caused the complete callback to get called too early for the second load
Update test map to catch this
Change 3518526 by Ben.Zeigler
IOS Fix
Change 3518619 by Ben.Zeigler
#jira UE-46744 Fix issue where refreshing asset manager editor settings would throw away asset label rules overrides, causing the recursive flag to accidentally get set
Change 3518747 by Phillip.Kavan
#jira UE-43154 - Prevent ConstructGenericObject nodes from compiling if the selected type does not include 'BlueprintType' in its inheritance hierarchy.
Change summary:
- Moved UGameplayStatics::CanSpawnObjectOfClass() into UK2Node_GenericCreateObject as a local util method (per JIRA notes). This was not exposed to Blueprints and as such was inconsistent with the rest of the API.
- Modified UGameplayStatics::SpawnObject() to no longer call CanSpawnObjectOfClass(). This seemed redundant as this will already have been called during node validation at Blueprint compile time.
- Refactored CanSpawnObjectOfClass() into FK2Node_GenericCreateObject_Utils. Walking up the inheritance chain no longer starts out w/ the assumption that 'BlueprintType' is set by default, which was previously including a lot of engine-specific classes into the "allowed" set (e.g. UByteProperty). Also unified the 2 loop iterations that were being used to check for 'BlueprintType'/'NotBlueprintType' and 'DontUseGenericSpawnObjectName', as well as the check for whether or not the class is a derivative of AActor/UActorComponent.
- Modified UK2Node_GenericCreateObject::EarlyValidation() to call FK2Node_GenericCreateObject_Utils::CanSpawnObjectOfClass() and emit a slightly more informative error message to the BP compiler message log.
Change 3518756 by Michael.Noland
(4.17) Framework: Prevent various asserts when USplineComponent methods are called on a spline with no points
Change 3518760 by Michael.Noland
Core: Changed FRuntimeAssetCache ensures to ensureAsRuntimeWarning
Change 3518771 by Michael.Noland
AI: Prevent an ensure in UBlackboardComponent::ClearValue when called on a component with a null BlackboardAsset
Change 3518818 by Michael.Noland
Rendering: Fixed a whitespace issue in UCanvasRenderTarget2D::RepaintCanvas()
#rnx
Change 3518822 by Michael.Noland
Sequencer: Prevented crashes in some methods of UMovieSceneSequencePlayer when there is no Sequence set
Sequencer: Prevented a crash in FMovieSceneRootEvaluationTemplateInstance::Evaluate when the instance has no template set
Change 3518824 by Michael.Noland
Landscape: Marked ULandscapeComponent and ULandscapeHeightfieldCollisionComponent as Within=LandscapeProxy, since they do CastChecked on their Outer all the time
Change 3519073 by Michael.Noland
QAGame: Fixed a crash in UQASynth::PlaySynth() if called on a directly created instance rather than using the factory method
Change 3519076 by Michael.Noland
Preventing crashes in UAutomationPerformaceHelper (sic) when spawned abnormally for fuzzing (assumes that the outer will have a route to a world)
#rnx
Change 3519079 by Michael.Noland
Sequencer: Fixed a potential crash in UMediaPlaylist::Insert and UMediaPlaylist::RemoveAt when passed an invalid index
Change 3519081 by Michael.Noland
Blueprints: Added support for creating appropriate outers for objects that must be nested within another class during fuzzing (ones that specify Within=, other relationships aren't knowable yet)
Change 3519082 by Michael.Noland
VR: Prevent a crash in UMRMeshComponent::ConnectReconstructor when passed a null reconstructor
Change 3519084 by Michael.Noland
Rendering: Prevent crashes when UNiagaraComponent::GetEffectDataInterface is called on a component with no effect asset set
Change 3521889 by Michael.Noland
Sequencer: Prevented a bogus static analysis warning by reworking the code (FixedFrameInterval could have only been set if the pointer were valid from the line above)
#rnx
Change 3521987 by Michael.Noland
Animation: Prevent a couple of potential asserts in UControlRig::GetOrAllocateSubControlRig
Change 3522101 by Michael.Noland
Physics: Improved the comment on UPhysicalMaterial::Friction
#rn
Change 3522105 by Michael.Noland
Physics: Fixed a few crashes in UVehicleWheel when spawned directly
Change 3522106 by Michael.Noland
Framework: Marked ULevelStreaming as Within=World, since it does CastChecked on the Outer all the time
Change 3522109 by Michael.Noland
Animation: Marked UAnimInstance as Within=SkeletalMeshComponent since it assumes the outer in various places
Change 3522121 by Michael.Noland
Mobile: Prevent UMobileInstalledContent methods from crashing when called on a created instance in an uncooked build (no installed manifest)
Change 3522783 by Zak.Middleton
#ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before).
Change 3525477 by Dan.Oconnor
Remove Tooltip, Category, and HideCategories tooltip from the blueprint generated class if source data is cleared
Change 3526538 by Ben.Zeigler
Refresh primary asset labels if their bundles are different at all and not just if they're added or removed. This is required because they now work based on collections or directories. This fixes issue with the onboarding collection changes not correctly modifying chunks
Copy of CL #3526501
Change 3526817 by Ben.Zeigler
#jira UE-46917 Fix issue where maps that do not contain level script blueprints were being counted as unindexed for find in blueprints. The old behavior depended on detecting the existence of empty tags, but the asset registry now filters those out so treat maps with no FiB data as indexed
Change 3526873 by Ben.Zeigler
#jira UE-46627 Change it so blueprint or native subclasses of static mesh actor cannot be added to clusters, as they are not likely to be immutable the way the base class is
Add code to to the ubergraph frame to fall back to hard reference serialization if the reference collector doesn't support weak references, such as the cluster collector
Change 3526958 by Marc.Audy
(4.17) Don't copy and then break pin links when reconstructing. Instead simply move.
#jira UE-46935
Change 3528916 by Marc.Audy
PR #3609: Adds GetKeysForAxis() to complement GetKeysForAction() in UPlayerInput (Contributed by alanedwardes)
#jira UE-45347
Change 3529080 by mason.seay
BP asset for undetermined type bug
Change 3529381 by Marc.Audy
Fix ability to insert duplicates in to a set or map
Change 3529471 by Dan.Oconnor
Fix for clang 4.0 error: definition of builtin function '__rdtsc' inline unsigned long long __rdtsc()
Change 3530876 by Marc.Audy
Based on PR #3457: Add MakeSet BP node (Contributed by projectgheist)
Also refactored MakeArray/Set to share a base MakeContainer class
Cleaned up some dead code from MakeArray
Added icon for MakeSet
Added Functional Test for MakeSet
#jira UE-43717
Change 3531070 by Phillip.Kavan
#jira UE-46866 - Fix crash on load when an external variable member reference's owning type cannot be loaded.
Change summary:
- Modified FBlueprintEditorUtils::GetSkeletonClass() to check for NULL before attempting to check for the generating BP.
Change 3531081 by Marc.Audy
Remove deprecated CustomMapParamValue code
Change 3531094 by Phillip.Kavan
#jira UE-46952 - Fix a packaging code build failure that will occur with a nativized Blueprint class that contains a UInterfaceProperty.
Change summary:
- Modified TScriptInterface::operator=() to cast the given 'SourceObject' instance to the 'InterfaceType' type before assigning to 'SourceInterface'. This was necessary because if the caller (in this case nativized codegen) passes in a UObject* that does not explicitly inherit from 'InterfaceType', then it will need to go through the object's GetInterfaceAddress() API instead and cast the result back to an 'InterfaceType' pointer.
Change 3531186 by Phillip.Kavan
Back out changelist 3531094 (temp CIS fix).
#rnx
Change 3532082 by Marc.Audy
Move garbage collection timers and other management to UEngine instead of UWorld
Fixes CollectGarbage blueprint node not working in shipping
#jira UE-46566
Change 3532134 by Phillip.Kavan
Restored changelist 3531094 w/ fix for non-unity.
- Mirrored from //UE4/Release-4.17 (CL# 3531232).
#rnx
Change 3533009 by Marc.Audy
Fixup missing function and deprecation warnings
Change 3534056 by Marc.Audy
(4.17) Fix expose on spawn of map and sets to work
#jira UE-47140
Change 3534761 by Marc.Audy
(4.17) Apply code review changes to Dev-Framework as well
#rnx
Change 3535147 by Dan.Oconnor
Build fix, already made in 4.17
#rnx
Change 3535530 by mason.seay
Resaving to remove error when opening level blueprint
Change 3535581 by Marc.Audy
Class Properties are only identical if they are literally the same object. Do not consider the deep compare port flags as object property base does.
#jira UE-46533
Change 3535583 by Marc.Audy
When properties are imported in to a child actor component the cached instance data is invalidated, so clear it.
#jira UE-46533
Change 3535617 by Marc.Audy
PR #3788: UE-39237: Prevent (im-)pure casting during BP debugging (Contributed by projectgheist)
#jira UE-47188
#jira UE-39237
Change 3535671 by Marc.Audy
Change NodeFactory to look at interface to use sequence node instead of each node having to add itself
Change 3535955 by Marc.Audy
Prevent MakeSet from removing split pins
Change 3536114 by Michael.Noland
Paper2D: Removing deprecated code from 4.3/4.4 era
#rnx
Change 3536120 by Michael.Noland
Animation: Removed deprecated FTAlphaBlend class and AlphaBlendType.h header
Change 3536124 by Michael.Noland
Physics: Removed deprecated methods that were replaced by _AssumesLocked variations
Change 3536131 by Michael.Noland
Slate: Converting remaining uses of EKeyboardFocusCause to EFocusCause and properly deprecating it
Change 3536138 by Michael.Noland
Slate: Removed any deprecated code older than 4.10 that didn't affect content compatibility
Change 3536167 by Dan.Oconnor
When a client provides a skeleton class as the self scope, make sure we also use a skel class for non-self scopes - but only if using the compilation manager. Skel classes are not reliably up to date when not using the compilation manager
#jira UE-46904
Change 3536221 by Michael.Noland
Editor: Removing deprecated code from 4.9 or earlier
Change 3536240 by Michael.Noland
Blueprints: Removed long-deprecated TypeToString method from the K2 schema
#rnx
Change 3536243 by Michael.Noland
AI: Prevent crashes if UMockTask_Log is created manually rather than via the CreateTask factory method
Change 3536244 by Michael.Noland
Core: Prevent FScopedExternalProfilerBase::StopScopedTimer() from asserting if called an unmatched number of times with StartScopedTimer, as both are exposed to BPs now
Change 3536250 by Michael.Noland
CoreUObject: Removed any deprecated code older than 4.10 that didn't affect content compatibility
Change 3536253 by Michael.Noland
Core: Removed any deprecated code older than 4.10 that didn't affect content compatibility
Change 3536310 by Michael.Noland
Engine: Removed any deprecated code older than 4.10 that didn't affect content compatibility
Change 3536397 by Mieszko.Zielinski
Fixed UCrowdFollowingComponent::UpdateCachedDirections crashing when CharacterMovement is not set #UE4
#jira UE-46860
Change 3536404 by Michael.Noland
Platform: Added a warning for others when they try to remove this 'deprecated' method
Change 3536639 by Michael.Noland
CharacterMovement: Changed the name of a variable introduced in CL# 3536397 to better match intent
#rnx
Change 3536893 by Michael.Noland
Blueprints: Clear the stale value on the value pin when a map find node fails to find an item
#jira UE-47233
Change 3536902 by Michael.Noland
Framework: Killed a couple of more deprecated methods that were not exposed to Blueprints
#rnx
Change 3537038 by Ben.Marsh
Fixing case of iOS directories, pt1
Change 3537039 by Ben.Marsh
Fixing case of iOS directories, pt2
Change 3538246 by Michael.Noland
UnrealTournament: Fixing issues with renamed enum
#rnx
Change 3538618 by Ben.Zeigler
Fix ensure when closing sequencer transform UI
Change 3540213 by Ben.Zeigler
#jira UE-47313 Fix crash serializing a MapProperty where the value type has changed for a type that implements ConvertFromType. The address passed to ConvertFromType needs to be the container root, not the specific value address, keys worked because the offset was 0.
Change 3540253 by Marc.Audy
Only copy default values for input pins as output pins do not have them
#rnx
Change 3540376 by Marc.Audy
Add utility FromPinType for FEdGraphTerminalType
#rnx
Change 3540433 by Marc.Audy
Add MakeMap
#jira UE-47093
Unify IsConnectionDisallowed for containers and fix static analysis warning
#jira UE-47291
Change 3540585 by Phillip.Kavan
#jira UE-47117 - Fix crash on launch of a nativized build that includes an instanced default subobject that's referenced by another instanced default subobject.
Change summary:
- Modified FEmitDefaultValueHelper::HandleSpecialTypes() to only direct HandleInstancedSubobject() to emit code to create the instanced subobject if it's not a default subobject. This was previously being incorrectly interpreted as an object having the 'RF_ArchetypeObject' flag set; however, default subobjects will also have that flag set in addition to the 'RF_DefaultSubobject' flag.
- Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert in the 'GetDefaultSubobjectByName' case if the given object is not also a default subobject.
Change 3541147 by Dan.Oconnor
Fix for not being able to override custom events when using the compilation manager post 3536167
#jira UE-47292
#rnx
Change 3541177 by Ben.Zeigler
#jira UE-46595, UE-46553 Fix issue where creating a widget template could cause a widget blueprint being cooked to have the wrong package flags, making it appear to be an uncooked package
Copy of CL #3541027
Change 3541325 by Dan.Oconnor
K2node data table data needs to preload data before the compilation queue is flushed
#rnx
#jira UE-47319
Change 3541409 by Michael.Noland
Blueprints: Added code to reapply any active breakpoints after recompilation when using the BP compilation manager
#jira UE-47322
[reimplementing CL# 3541404 in Dev-Framework]
Change 3541418 by Dan.Oconnor
Fix for bad SKEL_ CDO reference in blueprint bytecode
#jira UE-47265
#rnx
Change 3541482 by Dan.Oconnor
Blanket fix up of preload calls that are being done in AllocateDefaultPins. AllocatDefaultPins is not called until compile, meaning if these preload calls load blueprints they will be loaded while the compilation manager is compiling blueprints
#rnx
#jira UE-47319
Change 3541817 by Marc.Audy
Fix static analysis warnings
#rnx
Change 3542299 by Michael.Noland
Blueprints: Speculative fix for static analysis warning
#rnx
Change 3542406 by Marc.Audy
Use a check slow to avoid any cost
#rnx
Change 3542486 by Michael.Noland
Asset Manager: Removing an unnecessary ensure (it's a potentially expected case)
#jira UE-47380
Change 3542659 by Michael.Noland
Blueprints: Clear out null entries in the LastEditedDocuments list during PostLoad() and remove entries when a graph is being deleted to prevent their generation in the first place
#jira UE-47385
Change 3543620 by Dan.Oconnor
Remove overzealous ensure - we may recompile blueprints that are asynchronously loading when a user triggers a synchronous compile
#jira UE-47415
#rnx
Change 3518415 by Ben.Zeigler
#jira UE-46574 Deprecate IPlatformChunkInstall::SetChunkInstallDelgate as it was spelled wrong, was only half implemented, and did not support success vs failure
Replace with AddChunkInstallDelegate, which supports a bool error code and is bound once instead of separately for each chunk. All implementations support this delegate at a basic level, although several could be improved to call the failure delegate in more cases
Change 3534339 by Michael.Noland
Platforms: Changed DEPRECATED() macro description to use 4.xx rather than a speciifc version in examples, so it doesn't show up when removing deprecated code
[CL 3544050 by Marc Audy in Main branch]
2017-07-19 09:49:59 -04:00
return ensureAsRuntimeWarning ( Buckets . Contains ( Bucket ) ) ? Buckets [ Bucket ] - > GetSize ( ) : 0 ;
2015-06-10 03:14:50 -04:00
}
2015-06-19 03:13:33 -04:00
int32 FRuntimeAssetCache : : GetAsynchronous ( IRuntimeAssetCacheBuilder * CacheBuilder , const FOnRuntimeAssetCacheAsyncComplete & OnComplete )
2015-06-10 03:14:50 -04:00
{
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3544039)
#lockdown Nick.Penwarden
#rb none
#rnx
=====================================
MAJOR FEATURES + CHANGES
=====================================
Change 3343905 by Dan.Oconnor
ResolveMember optimizations and moved into cpp. ResolveMember<UFunction> now checks UClass::FuncMap before doing more expensive searches
Change 3346637 by Ben.Zeigler
Actually fix in non editor builds
Change 3355484 by Dan.Oconnor
Back out FMemberReference Optimization
Change 3425833 by Ben.Zeigler
#jira UE-31749 Fix it so Undo works properly when modifying a local variable
#jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value
Change 3510091 by Marc.Audy
Expose on Spawn functional test
#rnx
Change 3510100 by Marc.Audy
Fix spelling error
#rnx
Change 3510132 by Marc.Audy
Fix issues with marking a widget blueprint class as abstract
Change 3510133 by Marc.Audy
Minor code cleanup
#rnx
Change 3510178 by Ben.Zeigler
#jira UE-46500 Fix it so editor-only and transient stuct members are not serialized for literal blueprint structs. It's unsafe to serialize them because they may not exist in the cooked build
Change 3510466 by Ben.Zeigler
Start adding basic ability system tests to enginetest, very minimal so far
Change 3511295 by Marc.Audy
Fix wasted work going weak -> object -> weak -> object
#rnx
Change 3511824 by Marc.Audy
Fix spelling error in tooltip
#jira UE-46515
#rnx
Change 3514446 by Ben.Zeigler
Fix ActorBoundEvent and ComponentBoundEvent to always refresh their event signature from the delegate property they are bound to. This is required to correctly deal with delegate signatures being moved or renamed. Both types now do the fixup one time, in ReconstructNode.
Change 3514578 by Marc.Audy
Move clearing of the actor component need end of frame update mark to base class instead of just primitive component
Change 3514583 by Ben.Zeigler
Better fix to last delegate checkin that also handles moving functions between modules but not renaming
Change 3515325 by Dan.Oconnor
Fix for rare orphan pin false positive, rare exposed on spawn false positive
#rnx
Change 3515761 by Marc.Audy
fix shipping configuration
#rnx
Change 3515772 by Marc.Audy
Fix static analysis warnings
#rnx
Change 3516287 by Marc.Audy
Fix references to instanced components not being updated when resetting component to default
#jira UE-44706
#rnx
Change 3516303 by Marc.Audy
Back out CL# 3516287 while an oddity is investigated
#rnx
Change 3516563 by Marc.Audy
(4.17) Fix references to instanced components not being updated when resetting component to default
#jira UE-44706
Change 3516637 by Phillip.Kavan
#jira UE-44661 - Fix potential crash when changing the ChildActorComponent class default value on a Blueprint that also sets the class in the Construction Script.
Change summary:
- Modified UChildActorComponent::DestroyChildActor() to move the check for PendingKill/Unreachable so that we can also rename a defunct ChildActor instance out of the way in order to allow for a new ChildActor instance w/ the cached name.
Change 3517735 by Marc.Audy
Avoid unnecessary string copy
#rnx
Change 3517931 by Marc.Audy
Small optimization to CleanupActors
Change 3518221 by Dan.Oconnor
Fix rare crash when running ConformImplementedEvents when async loading
#jira UE-45348
Change 3518270 by Ben.Zeigler
#jira UE-46574 Add FCollectionReference type and customization to allow setting an FName to an editor collection
Add AssetCollection to PrimaryAssetLabel that derives the bundled assets from an editor collection
Change 3518271 by Marc.Audy
Get rid of unnecessary construction differentiation if custom reset is being used
Change 3518310 by Ben.Marsh
Re-adding IOS files with correct case.
Change 3518423 by Ben.Zeigler
#jira UE-46574 Initial support for chunk installation in Asset Manager.
Refactor AssetManagerSettings so it copies runtime bools into the asset manager for fast access
Add a concept of a stalled streamable manager handle, handles can be created stalled and will not execute their async load until all needed resources have been acquired externally
Change 3518480 by Marc.Audy
Correctly get the variable reference for an input variable get from the member scope rather than a member variable of the same name on the class
#jira UE-46737
Change 3518498 by Ben.Zeigler
Fix bug with AssetManager where requesting the same load twice in a row before the first one finishes caused the complete callback to get called too early for the second load
Update test map to catch this
Change 3518526 by Ben.Zeigler
IOS Fix
Change 3518619 by Ben.Zeigler
#jira UE-46744 Fix issue where refreshing asset manager editor settings would throw away asset label rules overrides, causing the recursive flag to accidentally get set
Change 3518747 by Phillip.Kavan
#jira UE-43154 - Prevent ConstructGenericObject nodes from compiling if the selected type does not include 'BlueprintType' in its inheritance hierarchy.
Change summary:
- Moved UGameplayStatics::CanSpawnObjectOfClass() into UK2Node_GenericCreateObject as a local util method (per JIRA notes). This was not exposed to Blueprints and as such was inconsistent with the rest of the API.
- Modified UGameplayStatics::SpawnObject() to no longer call CanSpawnObjectOfClass(). This seemed redundant as this will already have been called during node validation at Blueprint compile time.
- Refactored CanSpawnObjectOfClass() into FK2Node_GenericCreateObject_Utils. Walking up the inheritance chain no longer starts out w/ the assumption that 'BlueprintType' is set by default, which was previously including a lot of engine-specific classes into the "allowed" set (e.g. UByteProperty). Also unified the 2 loop iterations that were being used to check for 'BlueprintType'/'NotBlueprintType' and 'DontUseGenericSpawnObjectName', as well as the check for whether or not the class is a derivative of AActor/UActorComponent.
- Modified UK2Node_GenericCreateObject::EarlyValidation() to call FK2Node_GenericCreateObject_Utils::CanSpawnObjectOfClass() and emit a slightly more informative error message to the BP compiler message log.
Change 3518756 by Michael.Noland
(4.17) Framework: Prevent various asserts when USplineComponent methods are called on a spline with no points
Change 3518760 by Michael.Noland
Core: Changed FRuntimeAssetCache ensures to ensureAsRuntimeWarning
Change 3518771 by Michael.Noland
AI: Prevent an ensure in UBlackboardComponent::ClearValue when called on a component with a null BlackboardAsset
Change 3518818 by Michael.Noland
Rendering: Fixed a whitespace issue in UCanvasRenderTarget2D::RepaintCanvas()
#rnx
Change 3518822 by Michael.Noland
Sequencer: Prevented crashes in some methods of UMovieSceneSequencePlayer when there is no Sequence set
Sequencer: Prevented a crash in FMovieSceneRootEvaluationTemplateInstance::Evaluate when the instance has no template set
Change 3518824 by Michael.Noland
Landscape: Marked ULandscapeComponent and ULandscapeHeightfieldCollisionComponent as Within=LandscapeProxy, since they do CastChecked on their Outer all the time
Change 3519073 by Michael.Noland
QAGame: Fixed a crash in UQASynth::PlaySynth() if called on a directly created instance rather than using the factory method
Change 3519076 by Michael.Noland
Preventing crashes in UAutomationPerformaceHelper (sic) when spawned abnormally for fuzzing (assumes that the outer will have a route to a world)
#rnx
Change 3519079 by Michael.Noland
Sequencer: Fixed a potential crash in UMediaPlaylist::Insert and UMediaPlaylist::RemoveAt when passed an invalid index
Change 3519081 by Michael.Noland
Blueprints: Added support for creating appropriate outers for objects that must be nested within another class during fuzzing (ones that specify Within=, other relationships aren't knowable yet)
Change 3519082 by Michael.Noland
VR: Prevent a crash in UMRMeshComponent::ConnectReconstructor when passed a null reconstructor
Change 3519084 by Michael.Noland
Rendering: Prevent crashes when UNiagaraComponent::GetEffectDataInterface is called on a component with no effect asset set
Change 3521889 by Michael.Noland
Sequencer: Prevented a bogus static analysis warning by reworking the code (FixedFrameInterval could have only been set if the pointer were valid from the line above)
#rnx
Change 3521987 by Michael.Noland
Animation: Prevent a couple of potential asserts in UControlRig::GetOrAllocateSubControlRig
Change 3522101 by Michael.Noland
Physics: Improved the comment on UPhysicalMaterial::Friction
#rn
Change 3522105 by Michael.Noland
Physics: Fixed a few crashes in UVehicleWheel when spawned directly
Change 3522106 by Michael.Noland
Framework: Marked ULevelStreaming as Within=World, since it does CastChecked on the Outer all the time
Change 3522109 by Michael.Noland
Animation: Marked UAnimInstance as Within=SkeletalMeshComponent since it assumes the outer in various places
Change 3522121 by Michael.Noland
Mobile: Prevent UMobileInstalledContent methods from crashing when called on a created instance in an uncooked build (no installed manifest)
Change 3522783 by Zak.Middleton
#ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before).
Change 3525477 by Dan.Oconnor
Remove Tooltip, Category, and HideCategories tooltip from the blueprint generated class if source data is cleared
Change 3526538 by Ben.Zeigler
Refresh primary asset labels if their bundles are different at all and not just if they're added or removed. This is required because they now work based on collections or directories. This fixes issue with the onboarding collection changes not correctly modifying chunks
Copy of CL #3526501
Change 3526817 by Ben.Zeigler
#jira UE-46917 Fix issue where maps that do not contain level script blueprints were being counted as unindexed for find in blueprints. The old behavior depended on detecting the existence of empty tags, but the asset registry now filters those out so treat maps with no FiB data as indexed
Change 3526873 by Ben.Zeigler
#jira UE-46627 Change it so blueprint or native subclasses of static mesh actor cannot be added to clusters, as they are not likely to be immutable the way the base class is
Add code to to the ubergraph frame to fall back to hard reference serialization if the reference collector doesn't support weak references, such as the cluster collector
Change 3526958 by Marc.Audy
(4.17) Don't copy and then break pin links when reconstructing. Instead simply move.
#jira UE-46935
Change 3528916 by Marc.Audy
PR #3609: Adds GetKeysForAxis() to complement GetKeysForAction() in UPlayerInput (Contributed by alanedwardes)
#jira UE-45347
Change 3529080 by mason.seay
BP asset for undetermined type bug
Change 3529381 by Marc.Audy
Fix ability to insert duplicates in to a set or map
Change 3529471 by Dan.Oconnor
Fix for clang 4.0 error: definition of builtin function '__rdtsc' inline unsigned long long __rdtsc()
Change 3530876 by Marc.Audy
Based on PR #3457: Add MakeSet BP node (Contributed by projectgheist)
Also refactored MakeArray/Set to share a base MakeContainer class
Cleaned up some dead code from MakeArray
Added icon for MakeSet
Added Functional Test for MakeSet
#jira UE-43717
Change 3531070 by Phillip.Kavan
#jira UE-46866 - Fix crash on load when an external variable member reference's owning type cannot be loaded.
Change summary:
- Modified FBlueprintEditorUtils::GetSkeletonClass() to check for NULL before attempting to check for the generating BP.
Change 3531081 by Marc.Audy
Remove deprecated CustomMapParamValue code
Change 3531094 by Phillip.Kavan
#jira UE-46952 - Fix a packaging code build failure that will occur with a nativized Blueprint class that contains a UInterfaceProperty.
Change summary:
- Modified TScriptInterface::operator=() to cast the given 'SourceObject' instance to the 'InterfaceType' type before assigning to 'SourceInterface'. This was necessary because if the caller (in this case nativized codegen) passes in a UObject* that does not explicitly inherit from 'InterfaceType', then it will need to go through the object's GetInterfaceAddress() API instead and cast the result back to an 'InterfaceType' pointer.
Change 3531186 by Phillip.Kavan
Back out changelist 3531094 (temp CIS fix).
#rnx
Change 3532082 by Marc.Audy
Move garbage collection timers and other management to UEngine instead of UWorld
Fixes CollectGarbage blueprint node not working in shipping
#jira UE-46566
Change 3532134 by Phillip.Kavan
Restored changelist 3531094 w/ fix for non-unity.
- Mirrored from //UE4/Release-4.17 (CL# 3531232).
#rnx
Change 3533009 by Marc.Audy
Fixup missing function and deprecation warnings
Change 3534056 by Marc.Audy
(4.17) Fix expose on spawn of map and sets to work
#jira UE-47140
Change 3534761 by Marc.Audy
(4.17) Apply code review changes to Dev-Framework as well
#rnx
Change 3535147 by Dan.Oconnor
Build fix, already made in 4.17
#rnx
Change 3535530 by mason.seay
Resaving to remove error when opening level blueprint
Change 3535581 by Marc.Audy
Class Properties are only identical if they are literally the same object. Do not consider the deep compare port flags as object property base does.
#jira UE-46533
Change 3535583 by Marc.Audy
When properties are imported in to a child actor component the cached instance data is invalidated, so clear it.
#jira UE-46533
Change 3535617 by Marc.Audy
PR #3788: UE-39237: Prevent (im-)pure casting during BP debugging (Contributed by projectgheist)
#jira UE-47188
#jira UE-39237
Change 3535671 by Marc.Audy
Change NodeFactory to look at interface to use sequence node instead of each node having to add itself
Change 3535955 by Marc.Audy
Prevent MakeSet from removing split pins
Change 3536114 by Michael.Noland
Paper2D: Removing deprecated code from 4.3/4.4 era
#rnx
Change 3536120 by Michael.Noland
Animation: Removed deprecated FTAlphaBlend class and AlphaBlendType.h header
Change 3536124 by Michael.Noland
Physics: Removed deprecated methods that were replaced by _AssumesLocked variations
Change 3536131 by Michael.Noland
Slate: Converting remaining uses of EKeyboardFocusCause to EFocusCause and properly deprecating it
Change 3536138 by Michael.Noland
Slate: Removed any deprecated code older than 4.10 that didn't affect content compatibility
Change 3536167 by Dan.Oconnor
When a client provides a skeleton class as the self scope, make sure we also use a skel class for non-self scopes - but only if using the compilation manager. Skel classes are not reliably up to date when not using the compilation manager
#jira UE-46904
Change 3536221 by Michael.Noland
Editor: Removing deprecated code from 4.9 or earlier
Change 3536240 by Michael.Noland
Blueprints: Removed long-deprecated TypeToString method from the K2 schema
#rnx
Change 3536243 by Michael.Noland
AI: Prevent crashes if UMockTask_Log is created manually rather than via the CreateTask factory method
Change 3536244 by Michael.Noland
Core: Prevent FScopedExternalProfilerBase::StopScopedTimer() from asserting if called an unmatched number of times with StartScopedTimer, as both are exposed to BPs now
Change 3536250 by Michael.Noland
CoreUObject: Removed any deprecated code older than 4.10 that didn't affect content compatibility
Change 3536253 by Michael.Noland
Core: Removed any deprecated code older than 4.10 that didn't affect content compatibility
Change 3536310 by Michael.Noland
Engine: Removed any deprecated code older than 4.10 that didn't affect content compatibility
Change 3536397 by Mieszko.Zielinski
Fixed UCrowdFollowingComponent::UpdateCachedDirections crashing when CharacterMovement is not set #UE4
#jira UE-46860
Change 3536404 by Michael.Noland
Platform: Added a warning for others when they try to remove this 'deprecated' method
Change 3536639 by Michael.Noland
CharacterMovement: Changed the name of a variable introduced in CL# 3536397 to better match intent
#rnx
Change 3536893 by Michael.Noland
Blueprints: Clear the stale value on the value pin when a map find node fails to find an item
#jira UE-47233
Change 3536902 by Michael.Noland
Framework: Killed a couple of more deprecated methods that were not exposed to Blueprints
#rnx
Change 3537038 by Ben.Marsh
Fixing case of iOS directories, pt1
Change 3537039 by Ben.Marsh
Fixing case of iOS directories, pt2
Change 3538246 by Michael.Noland
UnrealTournament: Fixing issues with renamed enum
#rnx
Change 3538618 by Ben.Zeigler
Fix ensure when closing sequencer transform UI
Change 3540213 by Ben.Zeigler
#jira UE-47313 Fix crash serializing a MapProperty where the value type has changed for a type that implements ConvertFromType. The address passed to ConvertFromType needs to be the container root, not the specific value address, keys worked because the offset was 0.
Change 3540253 by Marc.Audy
Only copy default values for input pins as output pins do not have them
#rnx
Change 3540376 by Marc.Audy
Add utility FromPinType for FEdGraphTerminalType
#rnx
Change 3540433 by Marc.Audy
Add MakeMap
#jira UE-47093
Unify IsConnectionDisallowed for containers and fix static analysis warning
#jira UE-47291
Change 3540585 by Phillip.Kavan
#jira UE-47117 - Fix crash on launch of a nativized build that includes an instanced default subobject that's referenced by another instanced default subobject.
Change summary:
- Modified FEmitDefaultValueHelper::HandleSpecialTypes() to only direct HandleInstancedSubobject() to emit code to create the instanced subobject if it's not a default subobject. This was previously being incorrectly interpreted as an object having the 'RF_ArchetypeObject' flag set; however, default subobjects will also have that flag set in addition to the 'RF_DefaultSubobject' flag.
- Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert in the 'GetDefaultSubobjectByName' case if the given object is not also a default subobject.
Change 3541147 by Dan.Oconnor
Fix for not being able to override custom events when using the compilation manager post 3536167
#jira UE-47292
#rnx
Change 3541177 by Ben.Zeigler
#jira UE-46595, UE-46553 Fix issue where creating a widget template could cause a widget blueprint being cooked to have the wrong package flags, making it appear to be an uncooked package
Copy of CL #3541027
Change 3541325 by Dan.Oconnor
K2node data table data needs to preload data before the compilation queue is flushed
#rnx
#jira UE-47319
Change 3541409 by Michael.Noland
Blueprints: Added code to reapply any active breakpoints after recompilation when using the BP compilation manager
#jira UE-47322
[reimplementing CL# 3541404 in Dev-Framework]
Change 3541418 by Dan.Oconnor
Fix for bad SKEL_ CDO reference in blueprint bytecode
#jira UE-47265
#rnx
Change 3541482 by Dan.Oconnor
Blanket fix up of preload calls that are being done in AllocateDefaultPins. AllocatDefaultPins is not called until compile, meaning if these preload calls load blueprints they will be loaded while the compilation manager is compiling blueprints
#rnx
#jira UE-47319
Change 3541817 by Marc.Audy
Fix static analysis warnings
#rnx
Change 3542299 by Michael.Noland
Blueprints: Speculative fix for static analysis warning
#rnx
Change 3542406 by Marc.Audy
Use a check slow to avoid any cost
#rnx
Change 3542486 by Michael.Noland
Asset Manager: Removing an unnecessary ensure (it's a potentially expected case)
#jira UE-47380
Change 3542659 by Michael.Noland
Blueprints: Clear out null entries in the LastEditedDocuments list during PostLoad() and remove entries when a graph is being deleted to prevent their generation in the first place
#jira UE-47385
Change 3543620 by Dan.Oconnor
Remove overzealous ensure - we may recompile blueprints that are asynchronously loading when a user triggers a synchronous compile
#jira UE-47415
#rnx
Change 3518415 by Ben.Zeigler
#jira UE-46574 Deprecate IPlatformChunkInstall::SetChunkInstallDelgate as it was spelled wrong, was only half implemented, and did not support success vs failure
Replace with AddChunkInstallDelegate, which supports a bool error code and is bound once instead of separately for each chunk. All implementations support this delegate at a basic level, although several could be improved to call the failure delegate in more cases
Change 3534339 by Michael.Noland
Platforms: Changed DEPRECATED() macro description to use 4.xx rather than a speciifc version in examples, so it doesn't show up when removing deprecated code
[CL 3544050 by Marc Audy in Main branch]
2017-07-19 09:49:59 -04:00
if ( ensureAsRuntimeWarning ( CacheBuilder ! = nullptr ) )
2015-06-10 03:14:50 -04:00
{
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3510040)
#lockdown Nick.Penwarden
=====================================
MAJOR FEATURES + CHANGES
=====================================
Change 3459524 by Marc.Audy
Get/Set of properties that were previously BPRW/BPRO should error when used
#jira UE-20993
Change 3460004 by Phillip.Kavan
#jira UE-45171 - Fix C++ compilation failures during packaging caused by nativizing a Blueprint that overrides a native function with a 'TSubclassOf' parameter or return value.
Change summary:
- Modified FKismetCompilerContext::CreateParametersForFunction() to pass the 'CPF_UObjectWrapper' flag through to new function parameter properties during Blueprint compilation.
Change 3461210 by Phillip.Kavan
#jira UE-44505 - Fix occasional Blueprint editor crashes that could occur while rebuilding the context menu from the action registry.
Change summary:
- Modified FBlueprintActionDatabase::FActionRegistry to use an FObjectKey as the key type. This allows us to test entries for UObject validity before rebuilding context menu items based on the action database.
- Changed FBlueprintActionInfo::CachedOwnerClass to be a TWeakObjectPtr rather than a raw UClass* since it's based on the ActionOwner, which could potentially become invalid after the OwnerClass has been cached.
- Modified FBlueprintActionDatabase::RefreshAssetActions() to exclude World assets if the WorldType is not EWorldType::Editor. This eliminates an issue with unreferenced "inactive" GC'd world objects being left in the BP action registry after cooking, at which point the keys could become invalid.
- Added FBlueprintActionDatabase::DeferredRemoveEntry() to allow for scheduling removal of entries from outside of the database if they are known to be invalid.
- Modified FBlueprintActionDatabase::Tick() to handle deferred entry removals.
- Modified FBlueprintActionMenuBuilder::RebuildActionList() to both test actions for validity before building menu items and schedule removal of invalid actions on the next tick.
Notes:
- Alternatively we could just include UObject keys in the database's AddReferencedObject impl, but that would then prevent objects from ever being GC'd if they are not explicitly removed. For most entries the action database takes the approach of explicitly removing entries via delegate when the UObject is destroyed, so I chose to use a TWeakObjectPtr instead so that any entries that may not be getting explicitly removed via delegate will now simply become invalidated if the UObject key is GC'd due to not being referenced. I also set it up to clean and remove any entries (along with any associated node spawners) that are found to be invalid the next time we open the BP editor.
Change 3461373 by Lukasz.Furman
fixed async navmesh rebuilds not kicking in for requests from navdata.bForceRebuildOnLoad
#jira UE-44231
Change 3461409 by Lukasz.Furman
fixed reenabling automatic navmesh generation in Editor Preferences
#ue4
Change 3461550 by Ben.Zeigler
#jira UE-45328 Fix local variable support for Redirectors and other save-time validation. We need to run the local variables to UProperty and back at save time
Add new flag PPF_SerializedAsImportText which is used for BP pins/default values and indicates that something has been serialized as import text and so needs to handle string asset redirectors
Change 3462625 by Zak.Middleton
#ue4 - Fix InterpToMovementComponent not setting velocity on the object it moves. Fix movement rate when substepping enabled (other related fixes to come).
github PR #3620
Change 3462796 by Dan.Oconnor
Fix for spamming BroadcastBlueprintReinstanced and for creating CDO at wrong time when compiling FrontEnd.uasset in OrionGame
#jira UE-45434
Change 3462995 by Ben.Zeigler
#jira UE-16941 Fix it so Load Asset node works with a literal value as well as a connected pin
Change 3463099 by Ben.Zeigler
#jira UE-45471 Allow abstract base classes for primary assets
Change 3464809 by Marc.Audy
Expose FVector2D / FVector2D to blueprints
#jira UE-45427
Change 3467254 by Mieszko.Zielinski
Added an AI helper BP function that supplies caller with a copy of navigation path given controller is currently following #UE4
Change 3467644 by Dan.Oconnor
Fix for cook issues in ocean when using compilation manager, one issue caused by bad dependencies list, one issue caused by lack of subobject mapping in archetype reinstancing.
#jira UE-45443, UE-45444
Change 3468176 by Dan.Oconnor
Fix dependent blueprints being marked dirty when a blueprint is compiled
Change 3468353 by Michael.Noland
UnrealHeaderTool: Improved the warning generated when missing Category= on a function or property declared in an engine module, and centralized the logic that determines if the module is engine or game
Change 3470532 by Dan.Oconnor
Re-enable compilation manager
Change 3470572 by Dan.Oconnor
Fix for pin paramters resetting when an archetype was reinstanced
#jira UE-45619
#rnx
Change 3471949 by Mason.Seay
Adding Primary Assets for testing
Change 3472074 by Ben.Zeigler
#jira UE-45140 Convert iterative cooking to use the Asset Registry as it's only mode, remove old hash and timestamp versions. This allows deleting the entire PackageDependencyInfo module
Change the asset registry iteration to not compute a hash at all, and instead store the script package guids in it's cache.
Expose bIgnoreIniSettingsOutOfDateForIteration and bIgnoreScriptPackagesOutOfDateForIteration in cooker settings, affects rather to listen to ini/script changes when doing iterative cooking
Change 3472079 by Ben.Zeigler
With new incremental cook options, change Fortnite to never care about ini settings, but do care about code changes. This can be changed but from previous discussions we wanted to be more safe than fast here
Change 3473429 by Lukasz.Furman
changed path following update tick to allow working on "invalid, update pending" paths, solves AI getting stuck when navigation is rebuild very frequently (e.g. every tick from moving mesh)
#jira UE-41884
Change 3473476 by Lukasz.Furman
changed crowd simulation path update tick to allow working on "invalid, update pending" paths, solves AI getting stuck when navigation is rebuild very frequently (e.g. every tick from moving mesh)
#jira UE-41884
Change 3473663 by Ben.Zeigler
Fix it so base k2node registers framework version, this is needed for the assetptr fixup I previously added
Change 3473679 by Mason.Seay
Slight cleanup of test map and added ability to teleport across level for easy navigation
Change 3473712 by Marc.Audy
Do default value validation against the actual value of the default entry of an enum rather than the serialized empty autogenerated default value
Change 3474055 by Marc.Audy
When nodes are reconstructed any pins that were previously linked or set to non-default values that have been removed will no longer simply vanish, but instead will remain in an Orphaned state until dealt with.
#jira UE-41828
Change 3474119 by mason.seay
Tweaked Force Feedback test
Change 3474156 by Marc.Audy
Actually enable orphan pin retention
Change 3474382 by Ben.Zeigler
Class.h Header and comment cleanup. Started this because IsChildOf did not have a comment and it's usage is a bit confusing
Change 3474386 by Ben.Zeigler
Close popup window when adding asset class to audit window
Change 3474491 by Ben.Zeigler
Remove ability for Worlds to not be saved as assets, this has been the default since 2014.
Change 3475363 by Marc.Audy
Alt-click now works with orphaned pins
#jira UE-45699
Change 3475523 by Marc.Audy
Fixup Fortnite and Paragon content for orphaned pin errors and warnings
Change 3475623 by Phillip.Kavan
#jira UE-45477 - Fix an EDL assertion on load in a nativized build with one or more Actor subobjects instanced via the EditInlineNew UI in the BP class defaults property editor.
Change summary:
- Modified FEmitDefaultValueHelper::OuterGenerate() to emit code to construct/initialize instanced subobject values that do not have the RF_DefaultSubObject flag set, and also to recursively handle nested subobjects for those values.
- Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to alternatively emit a 'NewObject' assignment statement rather than a 'CreateDefaultSubobject' statement if only RF_ArchetypeObject is set on the source object value.
Change 3476008 by Dan.Oconnor
Fix for failing to preload our super class's subobjects. Effectively moving UBlueprint::ForceLoad calls earlier in loading process. This only results in data resetting to your parent's parent's default value from your parent's default value.
#jira UE-18765
Change 3476115 by Dan.Oconnor
Fix missing category information for inherited functions when using compilation manager
#jira UE-45660
#rnx
Change 3476577 by Lukasz.Furman
added early outs from navmesh layer generation when there's no walkable cells or contours to avoid allocating 0 bytes by next generation steps (behavior differs between platforms)
#ue4
Change 3476587 by Phillip.Kavan
#jira UE-45517 - Fix a regression in which dragging UMG widgets around in the designer view results in redundantly-compounded BP class properties and context menu actions.
Change summary:
- Modified SDesignerView::ClearDropPreviews() to move the widget that was removed from the tree into the transient package. This ensures that FWidgetBlueprintCompiler::CreateClassVariablesFromBlueprint() won't pick them up.
- Modified SDesignerView::ProcessDropAndAddWidget() to also consider any widgets not added to the 'DropPreviews' array as being transient (i.e. also move them into the transient package since they were not added to the tree).
Notes:
- The regression was introduced by the changes in CL# 3410168, and was merged to Main at CL# 3431398.
#rnx
Change 3476723 by Dan.Oconnor
Match old behavior wrt updating implemented interfaces in blueprints - this logic from FKismetEditorUtilities::CompileBlueprint was missing in compilation manager
#jira UE-45468
#rnx
Change 3476948 by Michael.Noland
Framework: Changed AActor::FindComponentByClass (and AActor::GetComponentByClass by extension) to return nullptr when passed a nullptr class, rather than crashing
Change 3476970 by Ben.Zeigler
Fix bug I introduced in 4.16 where assigning assets to multiple chunks did not work properly
Change 3477536 by Marc.Audy
Don't display default value box on linked orphaned input pins
Change 3477835 by Marc.Audy
Fix pins orphaned by deletion of an entry in a user-defined enum disappearing instead of remaining connected
#jira UE-45754
Change 3478027 by Marc.Audy
Minor performance optimization
#rnx
Change 3478198 by Phillip.Kavan
#jira UE-42431 - Remove an unnecessary ensure() when pasting an event node.
Change summary:
- Modified UEdGraphSchema_K2::CreateSubstituteNode() to no longer ensure() that we have a valid PreExistingNode; it's only used for logging when a substitute node is created in response to a conflict with an existing node.
Change 3478485 by Marc.Audy
Eliminate extraneous error messages about orphaned pins on get/set nodes
#jira UE-45749
#rnx
Change 3478756 by Marc.Audy
Fix fallout from changes to DoesDefaultValueMatchAutogenerated for user defined enums
#jira UE-45721
#rnx
Change 3478926 by Marc.Audy
Non-blueprint type structs can no longer be made/broken
Non-blueprint visible properties in structs will no longer have pins created for them
#jira UE-43122
Change 3478988 by Marc.Audy
DeltaTime for a tick function with a tick interval is now correct after disabling and then reenabling the tick function.
#jira UE-45524
Change 3479818 by Marc.Audy
Allow ctrl-drag off of orphan pins
#jira UE-45803
Change 3480214 by Marc.Audy
Modifications to user defined enumerations are now transacted
#jira UE-43866
Change 3480579 by Marc.Audy
Maintain all pin properties through transactions.
#rn Reference pins that are removed and then restored via undo now correctly have the diamond icon instead of the standard circle.
Change 3481043 by Marc.Audy
Make/Break of structs does not depend on having blueprint exposed properties.
Splitting of a struct pin still requires blueprint exposed properties.
#jira UE-45840
#jira UE-45831
Change 3481271 by Ben.Zeigler
Fix the AssetManager chunking code to use ChunkDependencyInfo instead of a hardcoded check for chunk 0
Clean up ChunkDependencyInfo and make it properly public
Move ShouldSetManager to be WITH_EDITOR
Ported from WEX branch
#RB peter.sauerbrei
Change 3481373 by Dan.Oconnor
Reduce reliance on expensive FindDelegateSignature. 3275922 made warnings about a ambiguous search more likely as it preserved names of members on the REINST_ classes
#jira UE-45704
Change 3481380 by Ben.Zeigler
Change it so Struct and Object AssetRegistrySearchable properties do not show up in content browser, they are not helpful
Change 3482362 by Marc.Audy
Fix properties not exposed to blueprint warnings for input properties on function graphs.
#jira UE-45824
Change 3482406 by Ben.Zeigler
#jira UE-45883 Fix Switch On Gameplay Tag Container node, and add switch nodes to TagCheck map
Change 3482498 by Ben.Zeigler
Attempt to fix hot reload issues with Asset Manager. We need to reset and re-acquire the asset classes when rescanning, as they may be pointing to the replaced class
Change 3482517 by Lukasz.Furman
fixed smart navlink update functions removing important flag
#jira UE-45875
Change 3482538 by Marc.Audy
When comparing float, vector, and rotator values for whether the the default matches the autogenerated do not use the string compare because differences in use of decimal or number of 0s after decimal are then considered not the same float
#jira UE-45846
Change 3482773 by Marc.Audy
Don't show default value or pass by reference for exec pins
#jira UE-45868
Change 3482791 by Ben.Zeigler
#jira UE-45800 Correctly dirty game mode blueprint when changing player controller/etc classes from game mode customization
Fix it so MarkBlueprintAsStructurallyModified calls MarkBlueprintAsModified as several fixes were only in the second function
Change 3483131 by Zak.Middleton
#ue4 - InterpToMovementComponent:
- Fix velocity not zeroed when interpolation stops.
- Various fixes when calculating velocity and time when substepping is enabled.
- Improve accuracy of interpolation when looping and there is time remaining after the loop event is hit. Consume the remainder of the time after the event back in the loop (similar to handling a blocking impact).
#jira UE-45690
Change 3483146 by Phillip.Kavan
#jira UE-38358 - Propagate 'const' function flag from interface Blueprint to implementing Blueprints.
Change summary:
- Modified FBlueprintEditorUtils::MarkBlueprintAsStructurallyModified() to call SkeletalRecompileChildren() on dependent BPs when the target is an interface BP.
- Modified FBlueprintEditorUtils::MarkBlueprintAsStructurallyModified::FRefreshHelper::SkeletalRecompileChildren() to set child BP status to BS_Dirty after compiling.
- Modified ConformInterfaceByName() (FBlueprintEditorUtils) to use the interface's skeleton class for function iteration as well as to match the Function Entry node's 'const' setting to the interface UFunction's signature.
Change 3483340 by Ben.Zeigler
Fix issue querying asset registry after a hot reload, make sure pending kill objects are never considered to be Assets
Change 3483548 by Michael.Noland
Epic Friday: Playing around with some prototype traps
Change 3483700 by Phillip.Kavan
Fix CIS cook crash introduced by last submit.
#rnx
Change 3485217 by Ben.Zeigler
#jira UE-45519 Fix regression introduced in 4.16 where it would no longer cook all maps when no explicit maps were specified in ini or game callback. Moved the code that detects changes before culture/default map code and hardened it to deal with the case where some engine packages were already in the list before it entered the function
Change 3485367 by Dan.Oconnor
Avoid adding mappings to anim node when creating variables on the skeleton class and using the compilation manager
#jira UE-45756
Change 3485565 by Ben.Zeigler
#jira UE-45948 Fix compilation manager to properly reset variable default values after promoting a pin to local variable
Change 3485566 by Marc.Audy
Fix crashes caused by undo/redo of user defined struct changes
#jira UE-45775
#jira UE-45781
Change 3485805 by Michael.Noland
PR #3459: Fix for world origin shifting and SpringArmComponent location lag (Contributed by michail-nikolaev)
#jira UE-43747
Change 3485807 by Michael.Noland
PR #3485: Added additional textures field to paper 2d tileset class (Contributed by gryphonmyers)
#jira UE-44041
Change 3485811 by Michael.Noland
Framework: Fixed a bug in FStreamLevelAction::MakeSafeLevelName to avoid appending the PIE prefix multiple times (fixes functions like Unload Streaming Level when passed a full package name from an instanced streaming level)
Change 3485829 by Michael.Noland
Framework: Made GetWorldAssetPackageFName BlueprintCallable so instanced levels can be unloaded
Change 3485830 by Michael.Noland
PR #3568: add API declarations to ALevelStreamingVolume methods (Contributed by kayama-shift)
#jira UE-45002
Change 3486039 by Michael.Noland
PR #3495: UE-44014: Refreshing node error fixes (Contributed by projectgheist)
- Empty out the ErrorMsg when a node gets refreshed to prevent the same error messages from compounding
- Added support for split pins in UK2Node_Event::IsFunctionEntryCompatible
- Added a missing check for the delegate pin name on the entry node part of UK2Node_Event::IsFunctionEntryCompatible
#jira UE-44014
Change 3486093 by Michael.Noland
PR #3379: Added GAMEPLAYABILITIES_API to all Ability Tasks. (Contributed by ryanjon2040)
#jira UE-42903
Change 3486139 by Michael.Noland
Blueprints: Added new config options for execution wire thickness when not debugging (DefaultExecutionWireThickness) and data wire thicknesses (DefaultDataWireThickness) to the Graph Editor Settings page
#rn
Change 3486154 by Michael.Noland
Framework: Speculative fix for CIS error about FStructOnScope
#rnx
Change 3486180 by Dan.Oconnor
Better match old logic for determining when to skip data only compile
#jira UE-45830
Change 3487276 by Marc.Audy
Fix crash when using Setter with a locally scoped variable
#rnx
Change 3487278 by Marc.Audy
Ensure that pin change notifications occur on all pin breaks unless it is part of a node being garbage collected
Change 3487658 by Marc.Audy
Ensure that child actor template is created for subclasses
#jira UE-45985
Change 3487699 by Marc.Audy
Move non-templated elements out of FArchiveReplaceObjectRef and put them in FArchiveReplaceObjectRefBase
Change 3487813 by Dan.Oconnor
Asset demonstrating a crash
Change 3488101 by Marc.Audy
Fix crash with spawn/construct actor/object from class nodes when they no longer had any pins.
Correctly orphan pins when a node goes to 0 pins.
Change 3488337 by Marc.Audy
Editable pin base should not manually remove pin and let reconstruct node and rewire pins do their job
#jira UE-46020
Change 3488512 by Dan.Oconnor
ConstructObject nodes and SubInstances nodes use skeleton class when compilation manager can provide it
#jira UE-45830, UE-45965
#rnx
Change 3488631 by Michael.Noland
Framework: Fixed a crash when loading a blueprint with a parent class of ALevelBounds caused by trying to register the class default object with a non-existent level
#jira UE-45630
Change 3488665 by Michael.Noland
Blueprints: Improve the details panel customization for optional pin nodes like Struct Member Get/Set
- The category, raw name, and tooltip of the property are now included as part of the filter text as well
- The property tooltip is now displayed when hovering over the property name
- Code updated to use GET_MEMBER_NAME_CHECKED() where appropriate
Change 3489324 by Marc.Audy
Fix recursion causing stack crash
#jira UE-46038
#rnx
Change 3489326 by Marc.Audy
Fix cooking crash
#jira UE-46031
#rnx
Change 3489687 by mason.seay
Assets for testing orphan pins
Change 3489701 by Marc.Audy
Back out changelist 3487278 and 3489443 and make targetted changes for fixing up orphan pin cases where changing connections doesn't remove the pin.
#jira UE-46051
#jira UE-46052
#rnx
Change 3490352 by Dan.Oconnor
Fix for missing WidgetTree on Skeleton class - just look directly at the WidgetBlueprint
#jira UE-46062
Change 3490814 by Marc.Audy
Make callfunction/macro instances save all pins in orphan state more similar to previous behavior
#rnx
Change 3491022 by Dan.Oconnor
Properly clean up 'Key' property when we fail to create a value property
#jira UE-45279
Change 3491071 by Ben.Zeigler
#jira UE-45981 Fix rotation issues, vector/rotator pins with empty strings were not matching due to uninitialized memory.
Change 3491244 by Michael.Noland
Blueprints: Add compile time message back to the output log (will not auto-open the output log if there were no warnings/errors)
#jira UE-32948
Change 3491276 by Michael.Noland
Blueprints: Fixed some bugs where a newly added item would fail show up in the "My Blueprints" tree if there was a filter active (e.g., when promoting a variable)
- Centralized the logic for clearing the filter so it happens when we try and fail to select the item, rather than ad hoc in various other places
- Made it only clear the filter if necessary, rather than (almost) always clearing it when adding an item
#jira UE-43372
Change 3491562 by Marc.Audy
Put back pin removal in to editable pin base and instead modify the pin destroy implementation to take down child split pins with it
#jira UE-46020
#rnx
Change 3491658 by Marc.Audy
Unify RemoveUserDefinedPin implementations. Use version that has break to avoid size change assert
#rnx
Change 3491946 by Marc.Audy
ReconstructSinglePin no longer destroys OldPin (avoids oprhaned sub pins being destroyed before reparented)
RewireOldPinsToNewPins now destroys OldPins at the end (calling code no longer reponsible)
DestroyImpl now prunes out SubPins that had already been trashed
#rnx
Change 3492040 by Marc.Audy
Discard exec/then pins from a callfunction that has been converted to a pure node
#rnx
Change 3492200 by Zak.Middleton
#ue4 - Always reset the input array in AActor::GetComponents(), but do so without affecting allocated size.
Fixes possible regression from CL 3359561 that removed the Reset(...) entirely.
#jira UE-46012
Change 3492290 by Ben.Zeigler
#jira UE-46108 Fix StringLibrary Mid to never crash, Substring had already been fixed
Change 3492311 by Marc.Audy
Don't clear the pin type if what you're connecting to's pin type is wildcard
#rnx
Change 3492680 by Dan.Oconnor
Handle missing generated class when using compilation manager - tested by forcing compile of BP_ParentClassIsMissingType.uasset
Change 3492826 by Marc.Audy
Don't do pin connection list change notifications from DestroyPins while regenerating on load
#jira UE-46112
#rnx
Change 3492851 by Michael.Noland
Core: Fixed various crashes when using UObject::CallFunctionByNameWithArguments with non-trivial argument types by properly initializing the allocated parameters
Change 3492852 by Michael.Noland
Framework: Fixed a crash if ACharacter::FindComponentByClass was passed a nullptr class
Change 3492934 by Marc.Audy
Fix ensure and crash delete macro containing orphaned pin
#rnx
Change 3493079 by Dan.Oconnor
Fix for crash when opening ThirdPersonAnimBlueprint and ThirdPersonAnimBlueprint_Perf then clicking 'Compile' button in ThirdPersonAnimBlueprint editor. Make sure the convenience members in the derived compilers get set when we relink child classes (which requires making cdos, which requires PropagateValuesToCDO..)
#rnx
Change 3493346 by Phillip.Kavan
#jira UE-40560 - Fix a reported crash when pasting nodes between unrelated Blueprint graphs.
Change summary:
- Modified FEdGraphUtilities::PostProcessPastedNodes() to ensure() on a NULL pin entry; this will allow execution to continue while still alerting us since it is an unexpected result. Also added an 'else' case to then remove the NULL entry so that PostPasteNode() implementations don't all have to guard against NULL pin entries. When the node is reconstructed, the NULL entry will be replaced with the correct pin initialized to its default values.
- Modified UEdGraphPin::ImportTextItem() to add some additional logging to parse error cases when importing pin properties from source T3D text. Hopefully this gives us more information when this is encountered in the future.
Change 3493938 by Michael.Noland
Blueprints: Prevent issues with renaming event dispatchers to contain periods (this may be disallowed in the future, but they no longer become uneditable)
#jira UE-45780
Change 3493945 by Michael.Noland
Blueprints: Fixed GetDelegatePoperty typos
#rnx
Change 3493997 by Michael.Noland
Blueprints: Partially reverting changes from CL# 3319966 to reroute nodes, restoring their alignment but losing the symmetrical grab handle changes
#jira UE-45760
Change 3493998 by Dan.Oconnor
Fix rare crash in RefreshStandAloneDefaultsEditor when the blueprint editor is opened and a blueprint had errors in it
Note: I stumbled across this by running a unit test and then opening a blueprint in the BPE. CrashReporter indicates 3 crashes in the last 3 days
Change 3494025 by Michael.Noland
Engine: Deleted some dead code (DEBUGGING_VIEWPORT_SIZES)
#rnx
Change 3494026 by Michael.Noland
Blueprints: V0 of a BlueprintCallable/BlueprintPure function fuzzer
- Calls exposed methods with default parameters on classes it is able to spawn for now, which catches crashes due to null and /0 but not out of bounds issues or ones on classes it can't spawn due to classwithin, abstract, etc...
- Can be called using Test.ScriptFuzzing, won't be integrated into automated tests until it is more fully fleshed out and all known issues are addressed
#rnx
Change 3496382 by Ben.Zeigler
Fix ensure when launching editor with cook on the side and incremental cooking enabled. It now flushes the background asset gather when calling the sync load all assets if one is in progress
Change 3496688 by Marc.Audy
Avoid crashing in component instance data if (for some reason) the Actor's root component isn't properly set up
#jira UE-46073
Change 3496830 by Michael.Noland
Editor: Change FEditorCategoryUtils methods to take UStruct* instead of UClass*, as they are just reading metadata
#rnx
Change 3496840 by Michael.Noland
Framework: Remove the requirement for a local player in UCheatManager::CheatScript, so it can be be started from the server side (doesn't change the availability of the cheat manager, just allows things like the redundant "cheat cheatscript scriptname" to work)
Change 3497038 by Michael.Noland
Fortnite: Added UFortDeveloperSettings to allow developers to auto-run cheats in PIE (does not occur in -game or outside of WITH_EDITOR builds)
- You can specify a list of cheat commands to run when a pawn is possessed (also needs CL# 3496840 for cheatscripts)
- You can also specify a set of items to grant to your local inventory when it is created
Change 3497204 by Marc.Audy
Fix AbilitySystemComponent not being blueprint readable.
#rnx
Change 3497668 by Mieszko.Zielinski
Fixed a crash in BT editor when dealing with enum-typed Blackboard-keys pointing to enum values that have been deleted #UE4
#jira UE-43659
Change 3497677 by Mieszko.Zielinski
Added a community-suggested working solution to patching up dynamic navmesh after world offset #UE4
Also, fixed a crash related to navmesh rebuilding if generation was configured to lazily gather navigatble geometry
#jira UE-41293
Change 3497678 by Mieszko.Zielinski
Marked AbstractNavData class as transient #UE4
We never want to save it to levels
Change 3497679 by Mieszko.Zielinski
Made NavModifierVolume responsive to editor-time property changes #UE4
#jira UE-32831
Change 3497900 by Dan.Oconnor
Fix bad skel reference when using construct object from class, just limiting scope of 3491946. To reproduce the bug just nativize QA Game, including the TM-Gameplay level
#rnx
Change 3497904 by Dan.Oconnor
Use K2Node_Event::FindEventSignatureFunction in order when directly generating the skeleton generated class to get event params correct
#jira UE-46153
#rnx
Change 3497907 by Dan.Oconnor
Correctly set blueprint visibility flags on params for inherited functions when generating the skeleton class
#rnx
#jira UE-46186
Change 3498218 by mason.seay
Updates to pin testing BP's
Change 3498323 by Mieszko.Zielinski
Made UNavCollision instance assigned to StaticMesh not get re-created from scratch every single time any StaticMesh property changes #UE4
Recreation was resulting in some of the UNavCollision's properties not getting saved and the way we were recreating the nav collision could also interfere with undo buffers
#jira UE-44891
Change 3499007 by Marc.Audy
Allow systems to hook Pre and PostCompile to do custom behaviors
Change 3499013 by Mieszko.Zielinski
Made AbstractNavData class non-transient again #UE4
Implemented AbstractNavData instances' transientness in a different manner.
#jira UE-46194
Change 3499204 by Mieszko.Zielinski
Introduced CrowdManagerBase, an engine-level class that can be extended to implement custom crowd management #Orion
Extracted FRecastQueryFilter into a separate file, which will break some peoples' compilation.
#jira UE-43799
Change 3499321 by mason.seay
Updated bp for struct testing
Change 3499388 by Marc.Audy
Allow the compiler log to store off potential messages from earlier in the compile cycle (early validation), that can be committed later (for example once pruning is completed).
Change 3499390 by Marc.Audy
Generate the orphan pin error messages during EarlyValidation, but cache until the regular validation phase. This ensures all are generated, but only those that aren't pruned will be emitted.
#rnx
Change 3499420 by Michael.Noland
Engine: Introduced a new version of UEngine::GetWorldFromContextObject which takes an enum specifying the behavior on failures and updated all existing uses
The new version intentionally does not have a default value for ErrorMode, callers need to think about which variant of behavior they want:
- ReturnNull: Silently returns nullptr, the calling code is expected to handle this gracefully
- LogAndReturnNull: Raises a runtime error but still returns nullptr, the calling code is expected to handle this gracefully
- Assert: Asserts, the calling code is not expecting to handle a failure gracefully
- Deprecated UEngine::GetWorldFromContextObject(object, boolean) and changed the default behavior for the deprecated instances to do LogAndReturnNull rather than Assert, based on the real-world call pattern
- Introduced GetWorldFromContextObjectChecked(object) as a shorthand for passing in EGetWorldErrorMode::Assert
- Made UObject::GetWorldChecked() actually assert if it would return nullptr (under some cases the old function could silently return nullptr while reporting bSupported = true, so it neither ensured nor checked)
- Fixed a race condition in the 'is implemented' bookkeeping logic in GetWorld()/GetWorldChecked() by confining it to the game thread and added a check() to ImplementsGetWorld() to make it clear that it only works on the game thread
The typical recommended call pattern is to use something like:
if (UWorld* World = GEngine->GetWorldFromContextObject(WorldContextObject, EGetWorldErrorMode::LogAndReturnNull))
{
... Do something with World
}
Handling the failure case but requesting a log message (with BP call stack printed out) if it failed. This is now also the default behavior for old calls to UEngine::GetWorldFromContextObject(Object) (using the default value of bChecked=true), which is a behavior change but it matches how the function was being used in practice; the vast majority of call sites actually expected it to potentially fail and handled the nullptr case gracefully; very few places used the return value unguarded and wanted it to assert when passed a nullptr.
#jira UE-42458
Change 3499429 by Michael.Noland
Engine: Removed a bogus TODO (the problematic code had already been reworked)
#rnx
Change 3499470 by Michael.Noland
Core: Improved and corrected the comment for ensure()
- It doesn't crash when checking is disabled (and hasn't since UE3, maybe ever?)
- It now only fires once per ensure() by default, added a note about ensureAlways()
#rnx
Change 3499643 by Marc.Audy
Use TGuardValue instead of manually managing it
#rnx
Change 3499874 by Marc.Audy
Display <Unnamed> instead of nothing for Pins with blank display name in the compiler log
Change 3499875 by Marc.Audy
When changing function parameter types, don't orphan a pin on the function entry/exit nodes (but do at the call sites)
#jira UE-46224
Change 3499927 by Dan.Oconnor
UField::Serialize no longer serialize's its next ptr, UStruct::Serialize serializes all Children properties instead. This resolves a hard circular dependency between function libraries that EDL detected. It was resolved in an ad hoc way by the old linker
#jira UE-43458
Change 3499953 by Michael.Noland
Core: Created a variant of ensure that does runtime error logging without stopping in the debugger and some related functions that print a warning or error and may trigger a BP callstack (under the same rules as FFrame::KismetExecutionMessage)
- These are WIP and the API may change in the future, but are being used to fix various crashes found by fuzzing BP exposed functions
Change 3499957 by Michael.Noland
Animation: Added runtime errors for nullptr ControlRigs passed into BP methods
#rnx
Change 3499958 by Michael.Noland
Blueprints: Changed an ensure in UKismetNodeHelperLibrary::GetValidValue to a runtime error
#rnx
Change 3499959 by Michael.Noland
Engine: Downgrade various checks() to ensures() in the runtime asset cache functions exposed to Blueprints
Change 3499960 by Michael.Noland
AI: Changed UBTFunctionLibrary to not check/ensure if passed a null world context object
Change 3499968 by Michael.Noland
Editor: Fixed a couple of crashes in UEditorLevelUtils when passed nullptr arguments, and reformatted the entire file to fix widespread indentation issues
#rnx
Change 3499969 by Michael.Noland
Engine: Changed the verbosity of the failure log message of UEngine::GetWorldFromContextObject(..., LogAndReturnNull) from Warning to Error, so it always prints out a BP callstack
#rnx
Change 3499973 by Michael.Noland
Rendering: Fixed asserts in various UKismetRenderingLibrary methods if passed a nullptr for the WorldContextObject
- Also fixed flipped warnings in the failure cases for EndDrawCanvasToRenderTarget
Change 3499979 by Michael.Noland
Editor: Prevented a crash in UMaterialEditingLibrary::RecompileMaterial when passed a nullptr material
Change 3499984 by Michael.Noland
Physics: Prevented a crash in UTraceQueryTestResults::AssertEqual when passed in nullptr for Expected
Change 3499993 by Michael.Noland
Blueprints: Added validation when renaming variables, functions, components, multicast delegates, etc... to prevent names from containing some unacceptable characters
- This validation only kicks in when trying to rename an item, so bad names in existing content are 'grandfathered in'
- These bad names can cause bugs when working with content that contains these characters (e.g., names that contain a period cannot be found via FindObject<T>)
- Currently only . is banned, but eventually we may expand it to include all of INVALID_OBJECTNAME_CHARACTERS
Change 3500009 by Michael.Noland
Blueprints: Made the fuzzer skip classes declared in UnrealEd for now (some of the exposed methods change global state that can cause other tests to fail as the fuzzer isn't particularly sandboxed ATM)
#rnx
Change 3500011 by Michael.Noland
Android: Fixed a crash in UAndroidPermissionFunctionLibrary::AcquirePermissions when called with an empty array on non-Android platforms
Change 3500012 by Michael.Noland
Editor: Prevent a crash in UEditorTutorial::OpenAsset when passed a nullptr Asset
Change 3500014 by Michael.Noland
Engine: Changed FRuntimeAssetCacheFilesystemBackend::ClearCache(NAME_None) to not try to clear all cache directories (there is a separate no-args method for that)
Change 3500019 by Michael.Noland
Core: Fixed some more issues with CallFunctionByNameWithArguments and initializing / destroying parameters
- It was skipping the return value and incorrectly relying on the FirstPropertyToInit list which isn't set for by ref arguments
Change 3500020 by Michael.Noland
Automation: Prevent UFunctionalTestingManager::RunAllFunctionalTests and UFunctionalTestingManager* UFunctionalTestingManager::GetManager from crashing when a manager cannot be created (because we can't route to a world)
Change 3501062 by Marc.Audy
MakeArray AddInputPin is often used as part of node expansion, so need to move the transaction out of the function
Fix inability to undo/redo pin additions to sequence node
Add a K2Node_AddPinInterface to generalize the interface that K2Nodes implement to interact with SGraphNodeK2Sequence so it can be more generally used
#jira UE-46164
#jira UE-46270
Change 3501330 by Michael.Noland
AI: Fix an error on shutdown when the CDO of UAIPerceptionComponent tries to clean up (as it was never registered in the first place)
#jira UE-46271
Change 3501356 by Marc.Audy
Fix crash when multi-editing actor blueprints
#jira UE-46248
Change 3501408 by Michael.Noland
Core: Improve the print-out of FFrame::GetStackTrace() / FFrame::GetScriptCallstack() when there is no script stack (e.g., when FFrame::KismetExecutionMessage is called by native code with no BP above in the call stack)
Change 3501457 by Phillip.Kavan
#jira UE-46054 - Fix crash when launching a packaged build that includes a nativized Blueprint instance with a ChildActorComponent instanced via an AddComponent node.
Change summary:
- Removed UK2Node_AddComponent::PostDuplicate(). This eliminates the creation of redundant component templates that were being unnecessarily created during the Blueprint duplication that precedes the nativization pass.
- Modified SMyBlueprint::OnDuplicateAction() to call MakeNewComponentTemplate() in response to a graph duplication action within the same Blueprint context (replaces previous UK2Node_AddComponent::PostDuplicate() impl).
- Modified FEmitDefaultValueHelper::HandleSpecialTypes() to force AddComponent-based CAC-owned template objects in the emitted codegen to use the UDynamicClass as the Outer when instancing. This matches what we already do for SCS-based CAC-owned template objects - that logic was added in CL# 3270456, and this matches up with FBlueprintNativeCodeGenModule::FindReplacedNameAndOuter(), where we specifically handle CAC-owned template objects.
Change 3502741 by Phillip.Kavan
#jira UE-45782 - Fix undo for index pin type changes.
Change summary:
- Modified SGraphPinIndex::OnTypeChanged() to call Modify() on the pin that was changed.
Change 3502939 by Michael.Noland
Back out changelist 3499927
Change 3503087 by Marc.Audy
Re-fixed ocean content as editor had also changed so had to take theirs and redo
#rnx
Change 3503266 by Ben.Zeigler
#jira UE-46335 Fix regression added in 4.16 where AssetRegistry GetAncesorClassNames/GetDerivedClassNames were not working properly in cooked builds for classes not in memory
Change 3503325 by mason.seay
updated Anim BP to prep for pin testing
Change 3503445 by Marc.Audy
Fix crash caused by OldPins being destroyed before rewiring
#rnx
Change 3505024 by Marc.Audy
Fix NodeEffectsPanel blueprint as it was using pins that no longer existed
#rnx
Change 3505254 by Marc.Audy
Don't include orphan pins when gather source property names
If a property doesn't exist for a source property name just skip the property rather than crashing
#jira UE-46345
#rnx
Change 3506125 by Ben.Zeigler
#jira UE-46311 Fix issues when blueprints are reloaded in place, it needs to remove them from root properly and sanitize the old class. It's still not clear why they are being reloaded in place
Change 3506334 by Dan.Oconnor
Move UAnimGraphNode_Base::PreloadRequiredAssets up to K2Node, make sure nodes get a chance to preload data before compilation manager compiles newly loaded blueprints
#jira UE-46411
Change 3506439 by Dan.Oconnor
Return to pre 3488512 behavior for construct object nodes. This means that we can still get warnings on load when users compile after saving a blueprint, but the current behavior loses default values because it's lookng at the skeleton cdo
#jira UE-46308
Change 3506468 by Dan.Oconnor
Return to pre 3488512 behavior, as it causes bad default values
#jira UE-46414
#rnx
Change 3506733 by Marc.Audy
Use the most up to date class to determine whether a property still exists when adding pins during reconstruction
#jira UE-45965
#author Dan.OConnor
#rnx
Change 3507531 by Ben.Zeigler
#jira UE-46449 Better fix to flush the asset registry queue when the editor requests a synchronous scan at startup. Sometimes it can take a few frames because of file handle delays
Change 3507924 by mason.seay
Sanity save of TM-Gameplay and sublevels to maybe resolve level streaming issues
Change 3507962 by Marc.Audy
Remake changes from CL# 3150796 wiped out by WEX-Staging merge to Main in CL# 3479958
#rnx
Change 3509131 by Dan.Oconnor
Compilation manager compile on load flow never called FindExportsInMemoryFirst, which is critical to prevent reloading of UBlueprintGeneratedClasses when Rename clears the export table
#jira UE-46311
Change 3509345 by Marc.Audy
CVar to disable orphan pins if necessary
#rnx
Change 3509959 by Marc.Audy
Protect against crashing due to large values in Timespan From functions
#jira UE-43840
Change 3510040 by Marc.Audy
Remove all the old unneeded ShooterGame test maps
#rnx
[CL 3510073 by Marc Audy in Main branch]
2017-06-26 15:07:18 -04:00
int32 Handle = GetNextHandle ( ) ;
/** Must return a valid handle */
check ( Handle ! = 0 ) ;
/** Make sure task isn't processed twice. */
check ( ! PendingTasks . Contains ( Handle ) ) ;
checkf ( CacheBuilder - > IsBuildThreadSafe ( ) , TEXT ( " CacheBuilder %s Build function is not thread safe, but builder was used in asynchronous code. Use GetSynchronous instead. " ) , CacheBuilder - > GetBuilderName ( ) ) ;
FAsyncTask < FRuntimeAssetCacheAsyncWorker > * AsyncTask = new FAsyncTask < FRuntimeAssetCacheAsyncWorker > ( CacheBuilder , & Buckets , Handle , OnComplete ) ;
{
FScopeLock ScopeLock ( & SynchronizationObject ) ;
PendingTasks . Add ( Handle , AsyncTask ) ;
}
AddToAsyncCompletionCounter ( 1 ) ;
AsyncTask - > StartBackgroundTask ( ) ;
return Handle ;
}
else
{
// Using this with other functions is going to cause knock-on errors
return 0 ;
2015-06-10 03:14:50 -04:00
}
}
2015-06-29 03:57:39 -04:00
2015-06-19 03:13:33 -04:00
int32 FRuntimeAssetCache : : GetAsynchronous ( IRuntimeAssetCacheBuilder * CacheBuilder )
2015-06-10 03:14:50 -04:00
{
2015-06-19 03:13:33 -04:00
return GetAsynchronous ( CacheBuilder , FOnRuntimeAssetCacheAsyncComplete ( ) ) ;
}
2015-06-29 21:12:06 -04:00
FVoidPtrParam FRuntimeAssetCache : : GetSynchronous ( IRuntimeAssetCacheBuilder * CacheBuilder )
2015-06-19 03:13:33 -04:00
{
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3544039)
#lockdown Nick.Penwarden
#rb none
#rnx
=====================================
MAJOR FEATURES + CHANGES
=====================================
Change 3343905 by Dan.Oconnor
ResolveMember optimizations and moved into cpp. ResolveMember<UFunction> now checks UClass::FuncMap before doing more expensive searches
Change 3346637 by Ben.Zeigler
Actually fix in non editor builds
Change 3355484 by Dan.Oconnor
Back out FMemberReference Optimization
Change 3425833 by Ben.Zeigler
#jira UE-31749 Fix it so Undo works properly when modifying a local variable
#jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value
Change 3510091 by Marc.Audy
Expose on Spawn functional test
#rnx
Change 3510100 by Marc.Audy
Fix spelling error
#rnx
Change 3510132 by Marc.Audy
Fix issues with marking a widget blueprint class as abstract
Change 3510133 by Marc.Audy
Minor code cleanup
#rnx
Change 3510178 by Ben.Zeigler
#jira UE-46500 Fix it so editor-only and transient stuct members are not serialized for literal blueprint structs. It's unsafe to serialize them because they may not exist in the cooked build
Change 3510466 by Ben.Zeigler
Start adding basic ability system tests to enginetest, very minimal so far
Change 3511295 by Marc.Audy
Fix wasted work going weak -> object -> weak -> object
#rnx
Change 3511824 by Marc.Audy
Fix spelling error in tooltip
#jira UE-46515
#rnx
Change 3514446 by Ben.Zeigler
Fix ActorBoundEvent and ComponentBoundEvent to always refresh their event signature from the delegate property they are bound to. This is required to correctly deal with delegate signatures being moved or renamed. Both types now do the fixup one time, in ReconstructNode.
Change 3514578 by Marc.Audy
Move clearing of the actor component need end of frame update mark to base class instead of just primitive component
Change 3514583 by Ben.Zeigler
Better fix to last delegate checkin that also handles moving functions between modules but not renaming
Change 3515325 by Dan.Oconnor
Fix for rare orphan pin false positive, rare exposed on spawn false positive
#rnx
Change 3515761 by Marc.Audy
fix shipping configuration
#rnx
Change 3515772 by Marc.Audy
Fix static analysis warnings
#rnx
Change 3516287 by Marc.Audy
Fix references to instanced components not being updated when resetting component to default
#jira UE-44706
#rnx
Change 3516303 by Marc.Audy
Back out CL# 3516287 while an oddity is investigated
#rnx
Change 3516563 by Marc.Audy
(4.17) Fix references to instanced components not being updated when resetting component to default
#jira UE-44706
Change 3516637 by Phillip.Kavan
#jira UE-44661 - Fix potential crash when changing the ChildActorComponent class default value on a Blueprint that also sets the class in the Construction Script.
Change summary:
- Modified UChildActorComponent::DestroyChildActor() to move the check for PendingKill/Unreachable so that we can also rename a defunct ChildActor instance out of the way in order to allow for a new ChildActor instance w/ the cached name.
Change 3517735 by Marc.Audy
Avoid unnecessary string copy
#rnx
Change 3517931 by Marc.Audy
Small optimization to CleanupActors
Change 3518221 by Dan.Oconnor
Fix rare crash when running ConformImplementedEvents when async loading
#jira UE-45348
Change 3518270 by Ben.Zeigler
#jira UE-46574 Add FCollectionReference type and customization to allow setting an FName to an editor collection
Add AssetCollection to PrimaryAssetLabel that derives the bundled assets from an editor collection
Change 3518271 by Marc.Audy
Get rid of unnecessary construction differentiation if custom reset is being used
Change 3518310 by Ben.Marsh
Re-adding IOS files with correct case.
Change 3518423 by Ben.Zeigler
#jira UE-46574 Initial support for chunk installation in Asset Manager.
Refactor AssetManagerSettings so it copies runtime bools into the asset manager for fast access
Add a concept of a stalled streamable manager handle, handles can be created stalled and will not execute their async load until all needed resources have been acquired externally
Change 3518480 by Marc.Audy
Correctly get the variable reference for an input variable get from the member scope rather than a member variable of the same name on the class
#jira UE-46737
Change 3518498 by Ben.Zeigler
Fix bug with AssetManager where requesting the same load twice in a row before the first one finishes caused the complete callback to get called too early for the second load
Update test map to catch this
Change 3518526 by Ben.Zeigler
IOS Fix
Change 3518619 by Ben.Zeigler
#jira UE-46744 Fix issue where refreshing asset manager editor settings would throw away asset label rules overrides, causing the recursive flag to accidentally get set
Change 3518747 by Phillip.Kavan
#jira UE-43154 - Prevent ConstructGenericObject nodes from compiling if the selected type does not include 'BlueprintType' in its inheritance hierarchy.
Change summary:
- Moved UGameplayStatics::CanSpawnObjectOfClass() into UK2Node_GenericCreateObject as a local util method (per JIRA notes). This was not exposed to Blueprints and as such was inconsistent with the rest of the API.
- Modified UGameplayStatics::SpawnObject() to no longer call CanSpawnObjectOfClass(). This seemed redundant as this will already have been called during node validation at Blueprint compile time.
- Refactored CanSpawnObjectOfClass() into FK2Node_GenericCreateObject_Utils. Walking up the inheritance chain no longer starts out w/ the assumption that 'BlueprintType' is set by default, which was previously including a lot of engine-specific classes into the "allowed" set (e.g. UByteProperty). Also unified the 2 loop iterations that were being used to check for 'BlueprintType'/'NotBlueprintType' and 'DontUseGenericSpawnObjectName', as well as the check for whether or not the class is a derivative of AActor/UActorComponent.
- Modified UK2Node_GenericCreateObject::EarlyValidation() to call FK2Node_GenericCreateObject_Utils::CanSpawnObjectOfClass() and emit a slightly more informative error message to the BP compiler message log.
Change 3518756 by Michael.Noland
(4.17) Framework: Prevent various asserts when USplineComponent methods are called on a spline with no points
Change 3518760 by Michael.Noland
Core: Changed FRuntimeAssetCache ensures to ensureAsRuntimeWarning
Change 3518771 by Michael.Noland
AI: Prevent an ensure in UBlackboardComponent::ClearValue when called on a component with a null BlackboardAsset
Change 3518818 by Michael.Noland
Rendering: Fixed a whitespace issue in UCanvasRenderTarget2D::RepaintCanvas()
#rnx
Change 3518822 by Michael.Noland
Sequencer: Prevented crashes in some methods of UMovieSceneSequencePlayer when there is no Sequence set
Sequencer: Prevented a crash in FMovieSceneRootEvaluationTemplateInstance::Evaluate when the instance has no template set
Change 3518824 by Michael.Noland
Landscape: Marked ULandscapeComponent and ULandscapeHeightfieldCollisionComponent as Within=LandscapeProxy, since they do CastChecked on their Outer all the time
Change 3519073 by Michael.Noland
QAGame: Fixed a crash in UQASynth::PlaySynth() if called on a directly created instance rather than using the factory method
Change 3519076 by Michael.Noland
Preventing crashes in UAutomationPerformaceHelper (sic) when spawned abnormally for fuzzing (assumes that the outer will have a route to a world)
#rnx
Change 3519079 by Michael.Noland
Sequencer: Fixed a potential crash in UMediaPlaylist::Insert and UMediaPlaylist::RemoveAt when passed an invalid index
Change 3519081 by Michael.Noland
Blueprints: Added support for creating appropriate outers for objects that must be nested within another class during fuzzing (ones that specify Within=, other relationships aren't knowable yet)
Change 3519082 by Michael.Noland
VR: Prevent a crash in UMRMeshComponent::ConnectReconstructor when passed a null reconstructor
Change 3519084 by Michael.Noland
Rendering: Prevent crashes when UNiagaraComponent::GetEffectDataInterface is called on a component with no effect asset set
Change 3521889 by Michael.Noland
Sequencer: Prevented a bogus static analysis warning by reworking the code (FixedFrameInterval could have only been set if the pointer were valid from the line above)
#rnx
Change 3521987 by Michael.Noland
Animation: Prevent a couple of potential asserts in UControlRig::GetOrAllocateSubControlRig
Change 3522101 by Michael.Noland
Physics: Improved the comment on UPhysicalMaterial::Friction
#rn
Change 3522105 by Michael.Noland
Physics: Fixed a few crashes in UVehicleWheel when spawned directly
Change 3522106 by Michael.Noland
Framework: Marked ULevelStreaming as Within=World, since it does CastChecked on the Outer all the time
Change 3522109 by Michael.Noland
Animation: Marked UAnimInstance as Within=SkeletalMeshComponent since it assumes the outer in various places
Change 3522121 by Michael.Noland
Mobile: Prevent UMobileInstalledContent methods from crashing when called on a created instance in an uncooked build (no installed manifest)
Change 3522783 by Zak.Middleton
#ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before).
Change 3525477 by Dan.Oconnor
Remove Tooltip, Category, and HideCategories tooltip from the blueprint generated class if source data is cleared
Change 3526538 by Ben.Zeigler
Refresh primary asset labels if their bundles are different at all and not just if they're added or removed. This is required because they now work based on collections or directories. This fixes issue with the onboarding collection changes not correctly modifying chunks
Copy of CL #3526501
Change 3526817 by Ben.Zeigler
#jira UE-46917 Fix issue where maps that do not contain level script blueprints were being counted as unindexed for find in blueprints. The old behavior depended on detecting the existence of empty tags, but the asset registry now filters those out so treat maps with no FiB data as indexed
Change 3526873 by Ben.Zeigler
#jira UE-46627 Change it so blueprint or native subclasses of static mesh actor cannot be added to clusters, as they are not likely to be immutable the way the base class is
Add code to to the ubergraph frame to fall back to hard reference serialization if the reference collector doesn't support weak references, such as the cluster collector
Change 3526958 by Marc.Audy
(4.17) Don't copy and then break pin links when reconstructing. Instead simply move.
#jira UE-46935
Change 3528916 by Marc.Audy
PR #3609: Adds GetKeysForAxis() to complement GetKeysForAction() in UPlayerInput (Contributed by alanedwardes)
#jira UE-45347
Change 3529080 by mason.seay
BP asset for undetermined type bug
Change 3529381 by Marc.Audy
Fix ability to insert duplicates in to a set or map
Change 3529471 by Dan.Oconnor
Fix for clang 4.0 error: definition of builtin function '__rdtsc' inline unsigned long long __rdtsc()
Change 3530876 by Marc.Audy
Based on PR #3457: Add MakeSet BP node (Contributed by projectgheist)
Also refactored MakeArray/Set to share a base MakeContainer class
Cleaned up some dead code from MakeArray
Added icon for MakeSet
Added Functional Test for MakeSet
#jira UE-43717
Change 3531070 by Phillip.Kavan
#jira UE-46866 - Fix crash on load when an external variable member reference's owning type cannot be loaded.
Change summary:
- Modified FBlueprintEditorUtils::GetSkeletonClass() to check for NULL before attempting to check for the generating BP.
Change 3531081 by Marc.Audy
Remove deprecated CustomMapParamValue code
Change 3531094 by Phillip.Kavan
#jira UE-46952 - Fix a packaging code build failure that will occur with a nativized Blueprint class that contains a UInterfaceProperty.
Change summary:
- Modified TScriptInterface::operator=() to cast the given 'SourceObject' instance to the 'InterfaceType' type before assigning to 'SourceInterface'. This was necessary because if the caller (in this case nativized codegen) passes in a UObject* that does not explicitly inherit from 'InterfaceType', then it will need to go through the object's GetInterfaceAddress() API instead and cast the result back to an 'InterfaceType' pointer.
Change 3531186 by Phillip.Kavan
Back out changelist 3531094 (temp CIS fix).
#rnx
Change 3532082 by Marc.Audy
Move garbage collection timers and other management to UEngine instead of UWorld
Fixes CollectGarbage blueprint node not working in shipping
#jira UE-46566
Change 3532134 by Phillip.Kavan
Restored changelist 3531094 w/ fix for non-unity.
- Mirrored from //UE4/Release-4.17 (CL# 3531232).
#rnx
Change 3533009 by Marc.Audy
Fixup missing function and deprecation warnings
Change 3534056 by Marc.Audy
(4.17) Fix expose on spawn of map and sets to work
#jira UE-47140
Change 3534761 by Marc.Audy
(4.17) Apply code review changes to Dev-Framework as well
#rnx
Change 3535147 by Dan.Oconnor
Build fix, already made in 4.17
#rnx
Change 3535530 by mason.seay
Resaving to remove error when opening level blueprint
Change 3535581 by Marc.Audy
Class Properties are only identical if they are literally the same object. Do not consider the deep compare port flags as object property base does.
#jira UE-46533
Change 3535583 by Marc.Audy
When properties are imported in to a child actor component the cached instance data is invalidated, so clear it.
#jira UE-46533
Change 3535617 by Marc.Audy
PR #3788: UE-39237: Prevent (im-)pure casting during BP debugging (Contributed by projectgheist)
#jira UE-47188
#jira UE-39237
Change 3535671 by Marc.Audy
Change NodeFactory to look at interface to use sequence node instead of each node having to add itself
Change 3535955 by Marc.Audy
Prevent MakeSet from removing split pins
Change 3536114 by Michael.Noland
Paper2D: Removing deprecated code from 4.3/4.4 era
#rnx
Change 3536120 by Michael.Noland
Animation: Removed deprecated FTAlphaBlend class and AlphaBlendType.h header
Change 3536124 by Michael.Noland
Physics: Removed deprecated methods that were replaced by _AssumesLocked variations
Change 3536131 by Michael.Noland
Slate: Converting remaining uses of EKeyboardFocusCause to EFocusCause and properly deprecating it
Change 3536138 by Michael.Noland
Slate: Removed any deprecated code older than 4.10 that didn't affect content compatibility
Change 3536167 by Dan.Oconnor
When a client provides a skeleton class as the self scope, make sure we also use a skel class for non-self scopes - but only if using the compilation manager. Skel classes are not reliably up to date when not using the compilation manager
#jira UE-46904
Change 3536221 by Michael.Noland
Editor: Removing deprecated code from 4.9 or earlier
Change 3536240 by Michael.Noland
Blueprints: Removed long-deprecated TypeToString method from the K2 schema
#rnx
Change 3536243 by Michael.Noland
AI: Prevent crashes if UMockTask_Log is created manually rather than via the CreateTask factory method
Change 3536244 by Michael.Noland
Core: Prevent FScopedExternalProfilerBase::StopScopedTimer() from asserting if called an unmatched number of times with StartScopedTimer, as both are exposed to BPs now
Change 3536250 by Michael.Noland
CoreUObject: Removed any deprecated code older than 4.10 that didn't affect content compatibility
Change 3536253 by Michael.Noland
Core: Removed any deprecated code older than 4.10 that didn't affect content compatibility
Change 3536310 by Michael.Noland
Engine: Removed any deprecated code older than 4.10 that didn't affect content compatibility
Change 3536397 by Mieszko.Zielinski
Fixed UCrowdFollowingComponent::UpdateCachedDirections crashing when CharacterMovement is not set #UE4
#jira UE-46860
Change 3536404 by Michael.Noland
Platform: Added a warning for others when they try to remove this 'deprecated' method
Change 3536639 by Michael.Noland
CharacterMovement: Changed the name of a variable introduced in CL# 3536397 to better match intent
#rnx
Change 3536893 by Michael.Noland
Blueprints: Clear the stale value on the value pin when a map find node fails to find an item
#jira UE-47233
Change 3536902 by Michael.Noland
Framework: Killed a couple of more deprecated methods that were not exposed to Blueprints
#rnx
Change 3537038 by Ben.Marsh
Fixing case of iOS directories, pt1
Change 3537039 by Ben.Marsh
Fixing case of iOS directories, pt2
Change 3538246 by Michael.Noland
UnrealTournament: Fixing issues with renamed enum
#rnx
Change 3538618 by Ben.Zeigler
Fix ensure when closing sequencer transform UI
Change 3540213 by Ben.Zeigler
#jira UE-47313 Fix crash serializing a MapProperty where the value type has changed for a type that implements ConvertFromType. The address passed to ConvertFromType needs to be the container root, not the specific value address, keys worked because the offset was 0.
Change 3540253 by Marc.Audy
Only copy default values for input pins as output pins do not have them
#rnx
Change 3540376 by Marc.Audy
Add utility FromPinType for FEdGraphTerminalType
#rnx
Change 3540433 by Marc.Audy
Add MakeMap
#jira UE-47093
Unify IsConnectionDisallowed for containers and fix static analysis warning
#jira UE-47291
Change 3540585 by Phillip.Kavan
#jira UE-47117 - Fix crash on launch of a nativized build that includes an instanced default subobject that's referenced by another instanced default subobject.
Change summary:
- Modified FEmitDefaultValueHelper::HandleSpecialTypes() to only direct HandleInstancedSubobject() to emit code to create the instanced subobject if it's not a default subobject. This was previously being incorrectly interpreted as an object having the 'RF_ArchetypeObject' flag set; however, default subobjects will also have that flag set in addition to the 'RF_DefaultSubobject' flag.
- Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert in the 'GetDefaultSubobjectByName' case if the given object is not also a default subobject.
Change 3541147 by Dan.Oconnor
Fix for not being able to override custom events when using the compilation manager post 3536167
#jira UE-47292
#rnx
Change 3541177 by Ben.Zeigler
#jira UE-46595, UE-46553 Fix issue where creating a widget template could cause a widget blueprint being cooked to have the wrong package flags, making it appear to be an uncooked package
Copy of CL #3541027
Change 3541325 by Dan.Oconnor
K2node data table data needs to preload data before the compilation queue is flushed
#rnx
#jira UE-47319
Change 3541409 by Michael.Noland
Blueprints: Added code to reapply any active breakpoints after recompilation when using the BP compilation manager
#jira UE-47322
[reimplementing CL# 3541404 in Dev-Framework]
Change 3541418 by Dan.Oconnor
Fix for bad SKEL_ CDO reference in blueprint bytecode
#jira UE-47265
#rnx
Change 3541482 by Dan.Oconnor
Blanket fix up of preload calls that are being done in AllocateDefaultPins. AllocatDefaultPins is not called until compile, meaning if these preload calls load blueprints they will be loaded while the compilation manager is compiling blueprints
#rnx
#jira UE-47319
Change 3541817 by Marc.Audy
Fix static analysis warnings
#rnx
Change 3542299 by Michael.Noland
Blueprints: Speculative fix for static analysis warning
#rnx
Change 3542406 by Marc.Audy
Use a check slow to avoid any cost
#rnx
Change 3542486 by Michael.Noland
Asset Manager: Removing an unnecessary ensure (it's a potentially expected case)
#jira UE-47380
Change 3542659 by Michael.Noland
Blueprints: Clear out null entries in the LastEditedDocuments list during PostLoad() and remove entries when a graph is being deleted to prevent their generation in the first place
#jira UE-47385
Change 3543620 by Dan.Oconnor
Remove overzealous ensure - we may recompile blueprints that are asynchronously loading when a user triggers a synchronous compile
#jira UE-47415
#rnx
Change 3518415 by Ben.Zeigler
#jira UE-46574 Deprecate IPlatformChunkInstall::SetChunkInstallDelgate as it was spelled wrong, was only half implemented, and did not support success vs failure
Replace with AddChunkInstallDelegate, which supports a bool error code and is bound once instead of separately for each chunk. All implementations support this delegate at a basic level, although several could be improved to call the failure delegate in more cases
Change 3534339 by Michael.Noland
Platforms: Changed DEPRECATED() macro description to use 4.xx rather than a speciifc version in examples, so it doesn't show up when removing deprecated code
[CL 3544050 by Marc Audy in Main branch]
2017-07-19 09:49:59 -04:00
if ( ensureAsRuntimeWarning ( CacheBuilder ) )
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3510040)
#lockdown Nick.Penwarden
=====================================
MAJOR FEATURES + CHANGES
=====================================
Change 3459524 by Marc.Audy
Get/Set of properties that were previously BPRW/BPRO should error when used
#jira UE-20993
Change 3460004 by Phillip.Kavan
#jira UE-45171 - Fix C++ compilation failures during packaging caused by nativizing a Blueprint that overrides a native function with a 'TSubclassOf' parameter or return value.
Change summary:
- Modified FKismetCompilerContext::CreateParametersForFunction() to pass the 'CPF_UObjectWrapper' flag through to new function parameter properties during Blueprint compilation.
Change 3461210 by Phillip.Kavan
#jira UE-44505 - Fix occasional Blueprint editor crashes that could occur while rebuilding the context menu from the action registry.
Change summary:
- Modified FBlueprintActionDatabase::FActionRegistry to use an FObjectKey as the key type. This allows us to test entries for UObject validity before rebuilding context menu items based on the action database.
- Changed FBlueprintActionInfo::CachedOwnerClass to be a TWeakObjectPtr rather than a raw UClass* since it's based on the ActionOwner, which could potentially become invalid after the OwnerClass has been cached.
- Modified FBlueprintActionDatabase::RefreshAssetActions() to exclude World assets if the WorldType is not EWorldType::Editor. This eliminates an issue with unreferenced "inactive" GC'd world objects being left in the BP action registry after cooking, at which point the keys could become invalid.
- Added FBlueprintActionDatabase::DeferredRemoveEntry() to allow for scheduling removal of entries from outside of the database if they are known to be invalid.
- Modified FBlueprintActionDatabase::Tick() to handle deferred entry removals.
- Modified FBlueprintActionMenuBuilder::RebuildActionList() to both test actions for validity before building menu items and schedule removal of invalid actions on the next tick.
Notes:
- Alternatively we could just include UObject keys in the database's AddReferencedObject impl, but that would then prevent objects from ever being GC'd if they are not explicitly removed. For most entries the action database takes the approach of explicitly removing entries via delegate when the UObject is destroyed, so I chose to use a TWeakObjectPtr instead so that any entries that may not be getting explicitly removed via delegate will now simply become invalidated if the UObject key is GC'd due to not being referenced. I also set it up to clean and remove any entries (along with any associated node spawners) that are found to be invalid the next time we open the BP editor.
Change 3461373 by Lukasz.Furman
fixed async navmesh rebuilds not kicking in for requests from navdata.bForceRebuildOnLoad
#jira UE-44231
Change 3461409 by Lukasz.Furman
fixed reenabling automatic navmesh generation in Editor Preferences
#ue4
Change 3461550 by Ben.Zeigler
#jira UE-45328 Fix local variable support for Redirectors and other save-time validation. We need to run the local variables to UProperty and back at save time
Add new flag PPF_SerializedAsImportText which is used for BP pins/default values and indicates that something has been serialized as import text and so needs to handle string asset redirectors
Change 3462625 by Zak.Middleton
#ue4 - Fix InterpToMovementComponent not setting velocity on the object it moves. Fix movement rate when substepping enabled (other related fixes to come).
github PR #3620
Change 3462796 by Dan.Oconnor
Fix for spamming BroadcastBlueprintReinstanced and for creating CDO at wrong time when compiling FrontEnd.uasset in OrionGame
#jira UE-45434
Change 3462995 by Ben.Zeigler
#jira UE-16941 Fix it so Load Asset node works with a literal value as well as a connected pin
Change 3463099 by Ben.Zeigler
#jira UE-45471 Allow abstract base classes for primary assets
Change 3464809 by Marc.Audy
Expose FVector2D / FVector2D to blueprints
#jira UE-45427
Change 3467254 by Mieszko.Zielinski
Added an AI helper BP function that supplies caller with a copy of navigation path given controller is currently following #UE4
Change 3467644 by Dan.Oconnor
Fix for cook issues in ocean when using compilation manager, one issue caused by bad dependencies list, one issue caused by lack of subobject mapping in archetype reinstancing.
#jira UE-45443, UE-45444
Change 3468176 by Dan.Oconnor
Fix dependent blueprints being marked dirty when a blueprint is compiled
Change 3468353 by Michael.Noland
UnrealHeaderTool: Improved the warning generated when missing Category= on a function or property declared in an engine module, and centralized the logic that determines if the module is engine or game
Change 3470532 by Dan.Oconnor
Re-enable compilation manager
Change 3470572 by Dan.Oconnor
Fix for pin paramters resetting when an archetype was reinstanced
#jira UE-45619
#rnx
Change 3471949 by Mason.Seay
Adding Primary Assets for testing
Change 3472074 by Ben.Zeigler
#jira UE-45140 Convert iterative cooking to use the Asset Registry as it's only mode, remove old hash and timestamp versions. This allows deleting the entire PackageDependencyInfo module
Change the asset registry iteration to not compute a hash at all, and instead store the script package guids in it's cache.
Expose bIgnoreIniSettingsOutOfDateForIteration and bIgnoreScriptPackagesOutOfDateForIteration in cooker settings, affects rather to listen to ini/script changes when doing iterative cooking
Change 3472079 by Ben.Zeigler
With new incremental cook options, change Fortnite to never care about ini settings, but do care about code changes. This can be changed but from previous discussions we wanted to be more safe than fast here
Change 3473429 by Lukasz.Furman
changed path following update tick to allow working on "invalid, update pending" paths, solves AI getting stuck when navigation is rebuild very frequently (e.g. every tick from moving mesh)
#jira UE-41884
Change 3473476 by Lukasz.Furman
changed crowd simulation path update tick to allow working on "invalid, update pending" paths, solves AI getting stuck when navigation is rebuild very frequently (e.g. every tick from moving mesh)
#jira UE-41884
Change 3473663 by Ben.Zeigler
Fix it so base k2node registers framework version, this is needed for the assetptr fixup I previously added
Change 3473679 by Mason.Seay
Slight cleanup of test map and added ability to teleport across level for easy navigation
Change 3473712 by Marc.Audy
Do default value validation against the actual value of the default entry of an enum rather than the serialized empty autogenerated default value
Change 3474055 by Marc.Audy
When nodes are reconstructed any pins that were previously linked or set to non-default values that have been removed will no longer simply vanish, but instead will remain in an Orphaned state until dealt with.
#jira UE-41828
Change 3474119 by mason.seay
Tweaked Force Feedback test
Change 3474156 by Marc.Audy
Actually enable orphan pin retention
Change 3474382 by Ben.Zeigler
Class.h Header and comment cleanup. Started this because IsChildOf did not have a comment and it's usage is a bit confusing
Change 3474386 by Ben.Zeigler
Close popup window when adding asset class to audit window
Change 3474491 by Ben.Zeigler
Remove ability for Worlds to not be saved as assets, this has been the default since 2014.
Change 3475363 by Marc.Audy
Alt-click now works with orphaned pins
#jira UE-45699
Change 3475523 by Marc.Audy
Fixup Fortnite and Paragon content for orphaned pin errors and warnings
Change 3475623 by Phillip.Kavan
#jira UE-45477 - Fix an EDL assertion on load in a nativized build with one or more Actor subobjects instanced via the EditInlineNew UI in the BP class defaults property editor.
Change summary:
- Modified FEmitDefaultValueHelper::OuterGenerate() to emit code to construct/initialize instanced subobject values that do not have the RF_DefaultSubObject flag set, and also to recursively handle nested subobjects for those values.
- Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to alternatively emit a 'NewObject' assignment statement rather than a 'CreateDefaultSubobject' statement if only RF_ArchetypeObject is set on the source object value.
Change 3476008 by Dan.Oconnor
Fix for failing to preload our super class's subobjects. Effectively moving UBlueprint::ForceLoad calls earlier in loading process. This only results in data resetting to your parent's parent's default value from your parent's default value.
#jira UE-18765
Change 3476115 by Dan.Oconnor
Fix missing category information for inherited functions when using compilation manager
#jira UE-45660
#rnx
Change 3476577 by Lukasz.Furman
added early outs from navmesh layer generation when there's no walkable cells or contours to avoid allocating 0 bytes by next generation steps (behavior differs between platforms)
#ue4
Change 3476587 by Phillip.Kavan
#jira UE-45517 - Fix a regression in which dragging UMG widgets around in the designer view results in redundantly-compounded BP class properties and context menu actions.
Change summary:
- Modified SDesignerView::ClearDropPreviews() to move the widget that was removed from the tree into the transient package. This ensures that FWidgetBlueprintCompiler::CreateClassVariablesFromBlueprint() won't pick them up.
- Modified SDesignerView::ProcessDropAndAddWidget() to also consider any widgets not added to the 'DropPreviews' array as being transient (i.e. also move them into the transient package since they were not added to the tree).
Notes:
- The regression was introduced by the changes in CL# 3410168, and was merged to Main at CL# 3431398.
#rnx
Change 3476723 by Dan.Oconnor
Match old behavior wrt updating implemented interfaces in blueprints - this logic from FKismetEditorUtilities::CompileBlueprint was missing in compilation manager
#jira UE-45468
#rnx
Change 3476948 by Michael.Noland
Framework: Changed AActor::FindComponentByClass (and AActor::GetComponentByClass by extension) to return nullptr when passed a nullptr class, rather than crashing
Change 3476970 by Ben.Zeigler
Fix bug I introduced in 4.16 where assigning assets to multiple chunks did not work properly
Change 3477536 by Marc.Audy
Don't display default value box on linked orphaned input pins
Change 3477835 by Marc.Audy
Fix pins orphaned by deletion of an entry in a user-defined enum disappearing instead of remaining connected
#jira UE-45754
Change 3478027 by Marc.Audy
Minor performance optimization
#rnx
Change 3478198 by Phillip.Kavan
#jira UE-42431 - Remove an unnecessary ensure() when pasting an event node.
Change summary:
- Modified UEdGraphSchema_K2::CreateSubstituteNode() to no longer ensure() that we have a valid PreExistingNode; it's only used for logging when a substitute node is created in response to a conflict with an existing node.
Change 3478485 by Marc.Audy
Eliminate extraneous error messages about orphaned pins on get/set nodes
#jira UE-45749
#rnx
Change 3478756 by Marc.Audy
Fix fallout from changes to DoesDefaultValueMatchAutogenerated for user defined enums
#jira UE-45721
#rnx
Change 3478926 by Marc.Audy
Non-blueprint type structs can no longer be made/broken
Non-blueprint visible properties in structs will no longer have pins created for them
#jira UE-43122
Change 3478988 by Marc.Audy
DeltaTime for a tick function with a tick interval is now correct after disabling and then reenabling the tick function.
#jira UE-45524
Change 3479818 by Marc.Audy
Allow ctrl-drag off of orphan pins
#jira UE-45803
Change 3480214 by Marc.Audy
Modifications to user defined enumerations are now transacted
#jira UE-43866
Change 3480579 by Marc.Audy
Maintain all pin properties through transactions.
#rn Reference pins that are removed and then restored via undo now correctly have the diamond icon instead of the standard circle.
Change 3481043 by Marc.Audy
Make/Break of structs does not depend on having blueprint exposed properties.
Splitting of a struct pin still requires blueprint exposed properties.
#jira UE-45840
#jira UE-45831
Change 3481271 by Ben.Zeigler
Fix the AssetManager chunking code to use ChunkDependencyInfo instead of a hardcoded check for chunk 0
Clean up ChunkDependencyInfo and make it properly public
Move ShouldSetManager to be WITH_EDITOR
Ported from WEX branch
#RB peter.sauerbrei
Change 3481373 by Dan.Oconnor
Reduce reliance on expensive FindDelegateSignature. 3275922 made warnings about a ambiguous search more likely as it preserved names of members on the REINST_ classes
#jira UE-45704
Change 3481380 by Ben.Zeigler
Change it so Struct and Object AssetRegistrySearchable properties do not show up in content browser, they are not helpful
Change 3482362 by Marc.Audy
Fix properties not exposed to blueprint warnings for input properties on function graphs.
#jira UE-45824
Change 3482406 by Ben.Zeigler
#jira UE-45883 Fix Switch On Gameplay Tag Container node, and add switch nodes to TagCheck map
Change 3482498 by Ben.Zeigler
Attempt to fix hot reload issues with Asset Manager. We need to reset and re-acquire the asset classes when rescanning, as they may be pointing to the replaced class
Change 3482517 by Lukasz.Furman
fixed smart navlink update functions removing important flag
#jira UE-45875
Change 3482538 by Marc.Audy
When comparing float, vector, and rotator values for whether the the default matches the autogenerated do not use the string compare because differences in use of decimal or number of 0s after decimal are then considered not the same float
#jira UE-45846
Change 3482773 by Marc.Audy
Don't show default value or pass by reference for exec pins
#jira UE-45868
Change 3482791 by Ben.Zeigler
#jira UE-45800 Correctly dirty game mode blueprint when changing player controller/etc classes from game mode customization
Fix it so MarkBlueprintAsStructurallyModified calls MarkBlueprintAsModified as several fixes were only in the second function
Change 3483131 by Zak.Middleton
#ue4 - InterpToMovementComponent:
- Fix velocity not zeroed when interpolation stops.
- Various fixes when calculating velocity and time when substepping is enabled.
- Improve accuracy of interpolation when looping and there is time remaining after the loop event is hit. Consume the remainder of the time after the event back in the loop (similar to handling a blocking impact).
#jira UE-45690
Change 3483146 by Phillip.Kavan
#jira UE-38358 - Propagate 'const' function flag from interface Blueprint to implementing Blueprints.
Change summary:
- Modified FBlueprintEditorUtils::MarkBlueprintAsStructurallyModified() to call SkeletalRecompileChildren() on dependent BPs when the target is an interface BP.
- Modified FBlueprintEditorUtils::MarkBlueprintAsStructurallyModified::FRefreshHelper::SkeletalRecompileChildren() to set child BP status to BS_Dirty after compiling.
- Modified ConformInterfaceByName() (FBlueprintEditorUtils) to use the interface's skeleton class for function iteration as well as to match the Function Entry node's 'const' setting to the interface UFunction's signature.
Change 3483340 by Ben.Zeigler
Fix issue querying asset registry after a hot reload, make sure pending kill objects are never considered to be Assets
Change 3483548 by Michael.Noland
Epic Friday: Playing around with some prototype traps
Change 3483700 by Phillip.Kavan
Fix CIS cook crash introduced by last submit.
#rnx
Change 3485217 by Ben.Zeigler
#jira UE-45519 Fix regression introduced in 4.16 where it would no longer cook all maps when no explicit maps were specified in ini or game callback. Moved the code that detects changes before culture/default map code and hardened it to deal with the case where some engine packages were already in the list before it entered the function
Change 3485367 by Dan.Oconnor
Avoid adding mappings to anim node when creating variables on the skeleton class and using the compilation manager
#jira UE-45756
Change 3485565 by Ben.Zeigler
#jira UE-45948 Fix compilation manager to properly reset variable default values after promoting a pin to local variable
Change 3485566 by Marc.Audy
Fix crashes caused by undo/redo of user defined struct changes
#jira UE-45775
#jira UE-45781
Change 3485805 by Michael.Noland
PR #3459: Fix for world origin shifting and SpringArmComponent location lag (Contributed by michail-nikolaev)
#jira UE-43747
Change 3485807 by Michael.Noland
PR #3485: Added additional textures field to paper 2d tileset class (Contributed by gryphonmyers)
#jira UE-44041
Change 3485811 by Michael.Noland
Framework: Fixed a bug in FStreamLevelAction::MakeSafeLevelName to avoid appending the PIE prefix multiple times (fixes functions like Unload Streaming Level when passed a full package name from an instanced streaming level)
Change 3485829 by Michael.Noland
Framework: Made GetWorldAssetPackageFName BlueprintCallable so instanced levels can be unloaded
Change 3485830 by Michael.Noland
PR #3568: add API declarations to ALevelStreamingVolume methods (Contributed by kayama-shift)
#jira UE-45002
Change 3486039 by Michael.Noland
PR #3495: UE-44014: Refreshing node error fixes (Contributed by projectgheist)
- Empty out the ErrorMsg when a node gets refreshed to prevent the same error messages from compounding
- Added support for split pins in UK2Node_Event::IsFunctionEntryCompatible
- Added a missing check for the delegate pin name on the entry node part of UK2Node_Event::IsFunctionEntryCompatible
#jira UE-44014
Change 3486093 by Michael.Noland
PR #3379: Added GAMEPLAYABILITIES_API to all Ability Tasks. (Contributed by ryanjon2040)
#jira UE-42903
Change 3486139 by Michael.Noland
Blueprints: Added new config options for execution wire thickness when not debugging (DefaultExecutionWireThickness) and data wire thicknesses (DefaultDataWireThickness) to the Graph Editor Settings page
#rn
Change 3486154 by Michael.Noland
Framework: Speculative fix for CIS error about FStructOnScope
#rnx
Change 3486180 by Dan.Oconnor
Better match old logic for determining when to skip data only compile
#jira UE-45830
Change 3487276 by Marc.Audy
Fix crash when using Setter with a locally scoped variable
#rnx
Change 3487278 by Marc.Audy
Ensure that pin change notifications occur on all pin breaks unless it is part of a node being garbage collected
Change 3487658 by Marc.Audy
Ensure that child actor template is created for subclasses
#jira UE-45985
Change 3487699 by Marc.Audy
Move non-templated elements out of FArchiveReplaceObjectRef and put them in FArchiveReplaceObjectRefBase
Change 3487813 by Dan.Oconnor
Asset demonstrating a crash
Change 3488101 by Marc.Audy
Fix crash with spawn/construct actor/object from class nodes when they no longer had any pins.
Correctly orphan pins when a node goes to 0 pins.
Change 3488337 by Marc.Audy
Editable pin base should not manually remove pin and let reconstruct node and rewire pins do their job
#jira UE-46020
Change 3488512 by Dan.Oconnor
ConstructObject nodes and SubInstances nodes use skeleton class when compilation manager can provide it
#jira UE-45830, UE-45965
#rnx
Change 3488631 by Michael.Noland
Framework: Fixed a crash when loading a blueprint with a parent class of ALevelBounds caused by trying to register the class default object with a non-existent level
#jira UE-45630
Change 3488665 by Michael.Noland
Blueprints: Improve the details panel customization for optional pin nodes like Struct Member Get/Set
- The category, raw name, and tooltip of the property are now included as part of the filter text as well
- The property tooltip is now displayed when hovering over the property name
- Code updated to use GET_MEMBER_NAME_CHECKED() where appropriate
Change 3489324 by Marc.Audy
Fix recursion causing stack crash
#jira UE-46038
#rnx
Change 3489326 by Marc.Audy
Fix cooking crash
#jira UE-46031
#rnx
Change 3489687 by mason.seay
Assets for testing orphan pins
Change 3489701 by Marc.Audy
Back out changelist 3487278 and 3489443 and make targetted changes for fixing up orphan pin cases where changing connections doesn't remove the pin.
#jira UE-46051
#jira UE-46052
#rnx
Change 3490352 by Dan.Oconnor
Fix for missing WidgetTree on Skeleton class - just look directly at the WidgetBlueprint
#jira UE-46062
Change 3490814 by Marc.Audy
Make callfunction/macro instances save all pins in orphan state more similar to previous behavior
#rnx
Change 3491022 by Dan.Oconnor
Properly clean up 'Key' property when we fail to create a value property
#jira UE-45279
Change 3491071 by Ben.Zeigler
#jira UE-45981 Fix rotation issues, vector/rotator pins with empty strings were not matching due to uninitialized memory.
Change 3491244 by Michael.Noland
Blueprints: Add compile time message back to the output log (will not auto-open the output log if there were no warnings/errors)
#jira UE-32948
Change 3491276 by Michael.Noland
Blueprints: Fixed some bugs where a newly added item would fail show up in the "My Blueprints" tree if there was a filter active (e.g., when promoting a variable)
- Centralized the logic for clearing the filter so it happens when we try and fail to select the item, rather than ad hoc in various other places
- Made it only clear the filter if necessary, rather than (almost) always clearing it when adding an item
#jira UE-43372
Change 3491562 by Marc.Audy
Put back pin removal in to editable pin base and instead modify the pin destroy implementation to take down child split pins with it
#jira UE-46020
#rnx
Change 3491658 by Marc.Audy
Unify RemoveUserDefinedPin implementations. Use version that has break to avoid size change assert
#rnx
Change 3491946 by Marc.Audy
ReconstructSinglePin no longer destroys OldPin (avoids oprhaned sub pins being destroyed before reparented)
RewireOldPinsToNewPins now destroys OldPins at the end (calling code no longer reponsible)
DestroyImpl now prunes out SubPins that had already been trashed
#rnx
Change 3492040 by Marc.Audy
Discard exec/then pins from a callfunction that has been converted to a pure node
#rnx
Change 3492200 by Zak.Middleton
#ue4 - Always reset the input array in AActor::GetComponents(), but do so without affecting allocated size.
Fixes possible regression from CL 3359561 that removed the Reset(...) entirely.
#jira UE-46012
Change 3492290 by Ben.Zeigler
#jira UE-46108 Fix StringLibrary Mid to never crash, Substring had already been fixed
Change 3492311 by Marc.Audy
Don't clear the pin type if what you're connecting to's pin type is wildcard
#rnx
Change 3492680 by Dan.Oconnor
Handle missing generated class when using compilation manager - tested by forcing compile of BP_ParentClassIsMissingType.uasset
Change 3492826 by Marc.Audy
Don't do pin connection list change notifications from DestroyPins while regenerating on load
#jira UE-46112
#rnx
Change 3492851 by Michael.Noland
Core: Fixed various crashes when using UObject::CallFunctionByNameWithArguments with non-trivial argument types by properly initializing the allocated parameters
Change 3492852 by Michael.Noland
Framework: Fixed a crash if ACharacter::FindComponentByClass was passed a nullptr class
Change 3492934 by Marc.Audy
Fix ensure and crash delete macro containing orphaned pin
#rnx
Change 3493079 by Dan.Oconnor
Fix for crash when opening ThirdPersonAnimBlueprint and ThirdPersonAnimBlueprint_Perf then clicking 'Compile' button in ThirdPersonAnimBlueprint editor. Make sure the convenience members in the derived compilers get set when we relink child classes (which requires making cdos, which requires PropagateValuesToCDO..)
#rnx
Change 3493346 by Phillip.Kavan
#jira UE-40560 - Fix a reported crash when pasting nodes between unrelated Blueprint graphs.
Change summary:
- Modified FEdGraphUtilities::PostProcessPastedNodes() to ensure() on a NULL pin entry; this will allow execution to continue while still alerting us since it is an unexpected result. Also added an 'else' case to then remove the NULL entry so that PostPasteNode() implementations don't all have to guard against NULL pin entries. When the node is reconstructed, the NULL entry will be replaced with the correct pin initialized to its default values.
- Modified UEdGraphPin::ImportTextItem() to add some additional logging to parse error cases when importing pin properties from source T3D text. Hopefully this gives us more information when this is encountered in the future.
Change 3493938 by Michael.Noland
Blueprints: Prevent issues with renaming event dispatchers to contain periods (this may be disallowed in the future, but they no longer become uneditable)
#jira UE-45780
Change 3493945 by Michael.Noland
Blueprints: Fixed GetDelegatePoperty typos
#rnx
Change 3493997 by Michael.Noland
Blueprints: Partially reverting changes from CL# 3319966 to reroute nodes, restoring their alignment but losing the symmetrical grab handle changes
#jira UE-45760
Change 3493998 by Dan.Oconnor
Fix rare crash in RefreshStandAloneDefaultsEditor when the blueprint editor is opened and a blueprint had errors in it
Note: I stumbled across this by running a unit test and then opening a blueprint in the BPE. CrashReporter indicates 3 crashes in the last 3 days
Change 3494025 by Michael.Noland
Engine: Deleted some dead code (DEBUGGING_VIEWPORT_SIZES)
#rnx
Change 3494026 by Michael.Noland
Blueprints: V0 of a BlueprintCallable/BlueprintPure function fuzzer
- Calls exposed methods with default parameters on classes it is able to spawn for now, which catches crashes due to null and /0 but not out of bounds issues or ones on classes it can't spawn due to classwithin, abstract, etc...
- Can be called using Test.ScriptFuzzing, won't be integrated into automated tests until it is more fully fleshed out and all known issues are addressed
#rnx
Change 3496382 by Ben.Zeigler
Fix ensure when launching editor with cook on the side and incremental cooking enabled. It now flushes the background asset gather when calling the sync load all assets if one is in progress
Change 3496688 by Marc.Audy
Avoid crashing in component instance data if (for some reason) the Actor's root component isn't properly set up
#jira UE-46073
Change 3496830 by Michael.Noland
Editor: Change FEditorCategoryUtils methods to take UStruct* instead of UClass*, as they are just reading metadata
#rnx
Change 3496840 by Michael.Noland
Framework: Remove the requirement for a local player in UCheatManager::CheatScript, so it can be be started from the server side (doesn't change the availability of the cheat manager, just allows things like the redundant "cheat cheatscript scriptname" to work)
Change 3497038 by Michael.Noland
Fortnite: Added UFortDeveloperSettings to allow developers to auto-run cheats in PIE (does not occur in -game or outside of WITH_EDITOR builds)
- You can specify a list of cheat commands to run when a pawn is possessed (also needs CL# 3496840 for cheatscripts)
- You can also specify a set of items to grant to your local inventory when it is created
Change 3497204 by Marc.Audy
Fix AbilitySystemComponent not being blueprint readable.
#rnx
Change 3497668 by Mieszko.Zielinski
Fixed a crash in BT editor when dealing with enum-typed Blackboard-keys pointing to enum values that have been deleted #UE4
#jira UE-43659
Change 3497677 by Mieszko.Zielinski
Added a community-suggested working solution to patching up dynamic navmesh after world offset #UE4
Also, fixed a crash related to navmesh rebuilding if generation was configured to lazily gather navigatble geometry
#jira UE-41293
Change 3497678 by Mieszko.Zielinski
Marked AbstractNavData class as transient #UE4
We never want to save it to levels
Change 3497679 by Mieszko.Zielinski
Made NavModifierVolume responsive to editor-time property changes #UE4
#jira UE-32831
Change 3497900 by Dan.Oconnor
Fix bad skel reference when using construct object from class, just limiting scope of 3491946. To reproduce the bug just nativize QA Game, including the TM-Gameplay level
#rnx
Change 3497904 by Dan.Oconnor
Use K2Node_Event::FindEventSignatureFunction in order when directly generating the skeleton generated class to get event params correct
#jira UE-46153
#rnx
Change 3497907 by Dan.Oconnor
Correctly set blueprint visibility flags on params for inherited functions when generating the skeleton class
#rnx
#jira UE-46186
Change 3498218 by mason.seay
Updates to pin testing BP's
Change 3498323 by Mieszko.Zielinski
Made UNavCollision instance assigned to StaticMesh not get re-created from scratch every single time any StaticMesh property changes #UE4
Recreation was resulting in some of the UNavCollision's properties not getting saved and the way we were recreating the nav collision could also interfere with undo buffers
#jira UE-44891
Change 3499007 by Marc.Audy
Allow systems to hook Pre and PostCompile to do custom behaviors
Change 3499013 by Mieszko.Zielinski
Made AbstractNavData class non-transient again #UE4
Implemented AbstractNavData instances' transientness in a different manner.
#jira UE-46194
Change 3499204 by Mieszko.Zielinski
Introduced CrowdManagerBase, an engine-level class that can be extended to implement custom crowd management #Orion
Extracted FRecastQueryFilter into a separate file, which will break some peoples' compilation.
#jira UE-43799
Change 3499321 by mason.seay
Updated bp for struct testing
Change 3499388 by Marc.Audy
Allow the compiler log to store off potential messages from earlier in the compile cycle (early validation), that can be committed later (for example once pruning is completed).
Change 3499390 by Marc.Audy
Generate the orphan pin error messages during EarlyValidation, but cache until the regular validation phase. This ensures all are generated, but only those that aren't pruned will be emitted.
#rnx
Change 3499420 by Michael.Noland
Engine: Introduced a new version of UEngine::GetWorldFromContextObject which takes an enum specifying the behavior on failures and updated all existing uses
The new version intentionally does not have a default value for ErrorMode, callers need to think about which variant of behavior they want:
- ReturnNull: Silently returns nullptr, the calling code is expected to handle this gracefully
- LogAndReturnNull: Raises a runtime error but still returns nullptr, the calling code is expected to handle this gracefully
- Assert: Asserts, the calling code is not expecting to handle a failure gracefully
- Deprecated UEngine::GetWorldFromContextObject(object, boolean) and changed the default behavior for the deprecated instances to do LogAndReturnNull rather than Assert, based on the real-world call pattern
- Introduced GetWorldFromContextObjectChecked(object) as a shorthand for passing in EGetWorldErrorMode::Assert
- Made UObject::GetWorldChecked() actually assert if it would return nullptr (under some cases the old function could silently return nullptr while reporting bSupported = true, so it neither ensured nor checked)
- Fixed a race condition in the 'is implemented' bookkeeping logic in GetWorld()/GetWorldChecked() by confining it to the game thread and added a check() to ImplementsGetWorld() to make it clear that it only works on the game thread
The typical recommended call pattern is to use something like:
if (UWorld* World = GEngine->GetWorldFromContextObject(WorldContextObject, EGetWorldErrorMode::LogAndReturnNull))
{
... Do something with World
}
Handling the failure case but requesting a log message (with BP call stack printed out) if it failed. This is now also the default behavior for old calls to UEngine::GetWorldFromContextObject(Object) (using the default value of bChecked=true), which is a behavior change but it matches how the function was being used in practice; the vast majority of call sites actually expected it to potentially fail and handled the nullptr case gracefully; very few places used the return value unguarded and wanted it to assert when passed a nullptr.
#jira UE-42458
Change 3499429 by Michael.Noland
Engine: Removed a bogus TODO (the problematic code had already been reworked)
#rnx
Change 3499470 by Michael.Noland
Core: Improved and corrected the comment for ensure()
- It doesn't crash when checking is disabled (and hasn't since UE3, maybe ever?)
- It now only fires once per ensure() by default, added a note about ensureAlways()
#rnx
Change 3499643 by Marc.Audy
Use TGuardValue instead of manually managing it
#rnx
Change 3499874 by Marc.Audy
Display <Unnamed> instead of nothing for Pins with blank display name in the compiler log
Change 3499875 by Marc.Audy
When changing function parameter types, don't orphan a pin on the function entry/exit nodes (but do at the call sites)
#jira UE-46224
Change 3499927 by Dan.Oconnor
UField::Serialize no longer serialize's its next ptr, UStruct::Serialize serializes all Children properties instead. This resolves a hard circular dependency between function libraries that EDL detected. It was resolved in an ad hoc way by the old linker
#jira UE-43458
Change 3499953 by Michael.Noland
Core: Created a variant of ensure that does runtime error logging without stopping in the debugger and some related functions that print a warning or error and may trigger a BP callstack (under the same rules as FFrame::KismetExecutionMessage)
- These are WIP and the API may change in the future, but are being used to fix various crashes found by fuzzing BP exposed functions
Change 3499957 by Michael.Noland
Animation: Added runtime errors for nullptr ControlRigs passed into BP methods
#rnx
Change 3499958 by Michael.Noland
Blueprints: Changed an ensure in UKismetNodeHelperLibrary::GetValidValue to a runtime error
#rnx
Change 3499959 by Michael.Noland
Engine: Downgrade various checks() to ensures() in the runtime asset cache functions exposed to Blueprints
Change 3499960 by Michael.Noland
AI: Changed UBTFunctionLibrary to not check/ensure if passed a null world context object
Change 3499968 by Michael.Noland
Editor: Fixed a couple of crashes in UEditorLevelUtils when passed nullptr arguments, and reformatted the entire file to fix widespread indentation issues
#rnx
Change 3499969 by Michael.Noland
Engine: Changed the verbosity of the failure log message of UEngine::GetWorldFromContextObject(..., LogAndReturnNull) from Warning to Error, so it always prints out a BP callstack
#rnx
Change 3499973 by Michael.Noland
Rendering: Fixed asserts in various UKismetRenderingLibrary methods if passed a nullptr for the WorldContextObject
- Also fixed flipped warnings in the failure cases for EndDrawCanvasToRenderTarget
Change 3499979 by Michael.Noland
Editor: Prevented a crash in UMaterialEditingLibrary::RecompileMaterial when passed a nullptr material
Change 3499984 by Michael.Noland
Physics: Prevented a crash in UTraceQueryTestResults::AssertEqual when passed in nullptr for Expected
Change 3499993 by Michael.Noland
Blueprints: Added validation when renaming variables, functions, components, multicast delegates, etc... to prevent names from containing some unacceptable characters
- This validation only kicks in when trying to rename an item, so bad names in existing content are 'grandfathered in'
- These bad names can cause bugs when working with content that contains these characters (e.g., names that contain a period cannot be found via FindObject<T>)
- Currently only . is banned, but eventually we may expand it to include all of INVALID_OBJECTNAME_CHARACTERS
Change 3500009 by Michael.Noland
Blueprints: Made the fuzzer skip classes declared in UnrealEd for now (some of the exposed methods change global state that can cause other tests to fail as the fuzzer isn't particularly sandboxed ATM)
#rnx
Change 3500011 by Michael.Noland
Android: Fixed a crash in UAndroidPermissionFunctionLibrary::AcquirePermissions when called with an empty array on non-Android platforms
Change 3500012 by Michael.Noland
Editor: Prevent a crash in UEditorTutorial::OpenAsset when passed a nullptr Asset
Change 3500014 by Michael.Noland
Engine: Changed FRuntimeAssetCacheFilesystemBackend::ClearCache(NAME_None) to not try to clear all cache directories (there is a separate no-args method for that)
Change 3500019 by Michael.Noland
Core: Fixed some more issues with CallFunctionByNameWithArguments and initializing / destroying parameters
- It was skipping the return value and incorrectly relying on the FirstPropertyToInit list which isn't set for by ref arguments
Change 3500020 by Michael.Noland
Automation: Prevent UFunctionalTestingManager::RunAllFunctionalTests and UFunctionalTestingManager* UFunctionalTestingManager::GetManager from crashing when a manager cannot be created (because we can't route to a world)
Change 3501062 by Marc.Audy
MakeArray AddInputPin is often used as part of node expansion, so need to move the transaction out of the function
Fix inability to undo/redo pin additions to sequence node
Add a K2Node_AddPinInterface to generalize the interface that K2Nodes implement to interact with SGraphNodeK2Sequence so it can be more generally used
#jira UE-46164
#jira UE-46270
Change 3501330 by Michael.Noland
AI: Fix an error on shutdown when the CDO of UAIPerceptionComponent tries to clean up (as it was never registered in the first place)
#jira UE-46271
Change 3501356 by Marc.Audy
Fix crash when multi-editing actor blueprints
#jira UE-46248
Change 3501408 by Michael.Noland
Core: Improve the print-out of FFrame::GetStackTrace() / FFrame::GetScriptCallstack() when there is no script stack (e.g., when FFrame::KismetExecutionMessage is called by native code with no BP above in the call stack)
Change 3501457 by Phillip.Kavan
#jira UE-46054 - Fix crash when launching a packaged build that includes a nativized Blueprint instance with a ChildActorComponent instanced via an AddComponent node.
Change summary:
- Removed UK2Node_AddComponent::PostDuplicate(). This eliminates the creation of redundant component templates that were being unnecessarily created during the Blueprint duplication that precedes the nativization pass.
- Modified SMyBlueprint::OnDuplicateAction() to call MakeNewComponentTemplate() in response to a graph duplication action within the same Blueprint context (replaces previous UK2Node_AddComponent::PostDuplicate() impl).
- Modified FEmitDefaultValueHelper::HandleSpecialTypes() to force AddComponent-based CAC-owned template objects in the emitted codegen to use the UDynamicClass as the Outer when instancing. This matches what we already do for SCS-based CAC-owned template objects - that logic was added in CL# 3270456, and this matches up with FBlueprintNativeCodeGenModule::FindReplacedNameAndOuter(), where we specifically handle CAC-owned template objects.
Change 3502741 by Phillip.Kavan
#jira UE-45782 - Fix undo for index pin type changes.
Change summary:
- Modified SGraphPinIndex::OnTypeChanged() to call Modify() on the pin that was changed.
Change 3502939 by Michael.Noland
Back out changelist 3499927
Change 3503087 by Marc.Audy
Re-fixed ocean content as editor had also changed so had to take theirs and redo
#rnx
Change 3503266 by Ben.Zeigler
#jira UE-46335 Fix regression added in 4.16 where AssetRegistry GetAncesorClassNames/GetDerivedClassNames were not working properly in cooked builds for classes not in memory
Change 3503325 by mason.seay
updated Anim BP to prep for pin testing
Change 3503445 by Marc.Audy
Fix crash caused by OldPins being destroyed before rewiring
#rnx
Change 3505024 by Marc.Audy
Fix NodeEffectsPanel blueprint as it was using pins that no longer existed
#rnx
Change 3505254 by Marc.Audy
Don't include orphan pins when gather source property names
If a property doesn't exist for a source property name just skip the property rather than crashing
#jira UE-46345
#rnx
Change 3506125 by Ben.Zeigler
#jira UE-46311 Fix issues when blueprints are reloaded in place, it needs to remove them from root properly and sanitize the old class. It's still not clear why they are being reloaded in place
Change 3506334 by Dan.Oconnor
Move UAnimGraphNode_Base::PreloadRequiredAssets up to K2Node, make sure nodes get a chance to preload data before compilation manager compiles newly loaded blueprints
#jira UE-46411
Change 3506439 by Dan.Oconnor
Return to pre 3488512 behavior for construct object nodes. This means that we can still get warnings on load when users compile after saving a blueprint, but the current behavior loses default values because it's lookng at the skeleton cdo
#jira UE-46308
Change 3506468 by Dan.Oconnor
Return to pre 3488512 behavior, as it causes bad default values
#jira UE-46414
#rnx
Change 3506733 by Marc.Audy
Use the most up to date class to determine whether a property still exists when adding pins during reconstruction
#jira UE-45965
#author Dan.OConnor
#rnx
Change 3507531 by Ben.Zeigler
#jira UE-46449 Better fix to flush the asset registry queue when the editor requests a synchronous scan at startup. Sometimes it can take a few frames because of file handle delays
Change 3507924 by mason.seay
Sanity save of TM-Gameplay and sublevels to maybe resolve level streaming issues
Change 3507962 by Marc.Audy
Remake changes from CL# 3150796 wiped out by WEX-Staging merge to Main in CL# 3479958
#rnx
Change 3509131 by Dan.Oconnor
Compilation manager compile on load flow never called FindExportsInMemoryFirst, which is critical to prevent reloading of UBlueprintGeneratedClasses when Rename clears the export table
#jira UE-46311
Change 3509345 by Marc.Audy
CVar to disable orphan pins if necessary
#rnx
Change 3509959 by Marc.Audy
Protect against crashing due to large values in Timespan From functions
#jira UE-43840
Change 3510040 by Marc.Audy
Remove all the old unneeded ShooterGame test maps
#rnx
[CL 3510073 by Marc Audy in Main branch]
2017-06-26 15:07:18 -04:00
{
if ( ensureMsgf ( ! CacheBuilder - > ShouldBuildAsynchronously ( ) , TEXT ( " CacheBuilder %s can be only called asynchronously. " ) , CacheBuilder - > GetBuilderName ( ) ) )
{
FAsyncTask < FRuntimeAssetCacheAsyncWorker > * AsyncTask = new FAsyncTask < FRuntimeAssetCacheAsyncWorker > ( CacheBuilder , & Buckets , - 1 , FOnRuntimeAssetCacheAsyncComplete ( ) ) ;
AddToAsyncCompletionCounter ( 1 ) ;
AsyncTask - > StartSynchronousTask ( ) ;
return AsyncTask - > GetTask ( ) . GetDataAndSize ( ) ;
}
}
return FVoidPtrParam : : NullPtr ( ) ;
2015-06-10 03:14:50 -04:00
}
bool FRuntimeAssetCache : : ClearCache ( )
{
/** Tell backend to clean itself up. */
bool bResult = FRuntimeAssetCacheBackend : : Get ( ) . ClearCache ( ) ;
if ( ! bResult )
{
return bResult ;
}
/** If backend is cleaned up, clean up all buckets. */
for ( auto & Bucket : Buckets )
{
Bucket . Value - > Reset ( ) ;
}
return bResult ;
}
2015-06-19 10:16:40 -04:00
bool FRuntimeAssetCache : : ClearCache ( FName BucketName )
2015-06-10 03:14:50 -04:00
{
/** Tell backend to clean bucket up. */
2015-06-19 10:16:40 -04:00
bool bResult = FRuntimeAssetCacheBackend : : Get ( ) . ClearCache ( BucketName ) ;
2015-06-10 03:14:50 -04:00
if ( ! bResult )
{
return bResult ;
}
/** If backend is cleaned up, clean up all buckets. */
for ( auto & Bucket : Buckets )
{
Bucket . Value - > Reset ( ) ;
}
return bResult ;
}
void FRuntimeAssetCache : : AddToAsyncCompletionCounter ( int32 Value )
{
PendingTasksCounter . Add ( Value ) ;
check ( PendingTasksCounter . GetValue ( ) > = 0 ) ;
}
2015-06-19 03:13:33 -04:00
void FRuntimeAssetCache : : WaitAsynchronousCompletion ( int32 Handle )
2015-06-10 03:14:50 -04:00
{
STAT ( double ThisTime = 0 ) ;
{
SCOPE_SECONDS_COUNTER ( ThisTime ) ;
FAsyncTask < FRuntimeAssetCacheAsyncWorker > * AsyncTask = NULL ;
{
FScopeLock ScopeLock ( & SynchronizationObject ) ;
AsyncTask = PendingTasks . FindRef ( Handle ) ;
}
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3510040)
#lockdown Nick.Penwarden
=====================================
MAJOR FEATURES + CHANGES
=====================================
Change 3459524 by Marc.Audy
Get/Set of properties that were previously BPRW/BPRO should error when used
#jira UE-20993
Change 3460004 by Phillip.Kavan
#jira UE-45171 - Fix C++ compilation failures during packaging caused by nativizing a Blueprint that overrides a native function with a 'TSubclassOf' parameter or return value.
Change summary:
- Modified FKismetCompilerContext::CreateParametersForFunction() to pass the 'CPF_UObjectWrapper' flag through to new function parameter properties during Blueprint compilation.
Change 3461210 by Phillip.Kavan
#jira UE-44505 - Fix occasional Blueprint editor crashes that could occur while rebuilding the context menu from the action registry.
Change summary:
- Modified FBlueprintActionDatabase::FActionRegistry to use an FObjectKey as the key type. This allows us to test entries for UObject validity before rebuilding context menu items based on the action database.
- Changed FBlueprintActionInfo::CachedOwnerClass to be a TWeakObjectPtr rather than a raw UClass* since it's based on the ActionOwner, which could potentially become invalid after the OwnerClass has been cached.
- Modified FBlueprintActionDatabase::RefreshAssetActions() to exclude World assets if the WorldType is not EWorldType::Editor. This eliminates an issue with unreferenced "inactive" GC'd world objects being left in the BP action registry after cooking, at which point the keys could become invalid.
- Added FBlueprintActionDatabase::DeferredRemoveEntry() to allow for scheduling removal of entries from outside of the database if they are known to be invalid.
- Modified FBlueprintActionDatabase::Tick() to handle deferred entry removals.
- Modified FBlueprintActionMenuBuilder::RebuildActionList() to both test actions for validity before building menu items and schedule removal of invalid actions on the next tick.
Notes:
- Alternatively we could just include UObject keys in the database's AddReferencedObject impl, but that would then prevent objects from ever being GC'd if they are not explicitly removed. For most entries the action database takes the approach of explicitly removing entries via delegate when the UObject is destroyed, so I chose to use a TWeakObjectPtr instead so that any entries that may not be getting explicitly removed via delegate will now simply become invalidated if the UObject key is GC'd due to not being referenced. I also set it up to clean and remove any entries (along with any associated node spawners) that are found to be invalid the next time we open the BP editor.
Change 3461373 by Lukasz.Furman
fixed async navmesh rebuilds not kicking in for requests from navdata.bForceRebuildOnLoad
#jira UE-44231
Change 3461409 by Lukasz.Furman
fixed reenabling automatic navmesh generation in Editor Preferences
#ue4
Change 3461550 by Ben.Zeigler
#jira UE-45328 Fix local variable support for Redirectors and other save-time validation. We need to run the local variables to UProperty and back at save time
Add new flag PPF_SerializedAsImportText which is used for BP pins/default values and indicates that something has been serialized as import text and so needs to handle string asset redirectors
Change 3462625 by Zak.Middleton
#ue4 - Fix InterpToMovementComponent not setting velocity on the object it moves. Fix movement rate when substepping enabled (other related fixes to come).
github PR #3620
Change 3462796 by Dan.Oconnor
Fix for spamming BroadcastBlueprintReinstanced and for creating CDO at wrong time when compiling FrontEnd.uasset in OrionGame
#jira UE-45434
Change 3462995 by Ben.Zeigler
#jira UE-16941 Fix it so Load Asset node works with a literal value as well as a connected pin
Change 3463099 by Ben.Zeigler
#jira UE-45471 Allow abstract base classes for primary assets
Change 3464809 by Marc.Audy
Expose FVector2D / FVector2D to blueprints
#jira UE-45427
Change 3467254 by Mieszko.Zielinski
Added an AI helper BP function that supplies caller with a copy of navigation path given controller is currently following #UE4
Change 3467644 by Dan.Oconnor
Fix for cook issues in ocean when using compilation manager, one issue caused by bad dependencies list, one issue caused by lack of subobject mapping in archetype reinstancing.
#jira UE-45443, UE-45444
Change 3468176 by Dan.Oconnor
Fix dependent blueprints being marked dirty when a blueprint is compiled
Change 3468353 by Michael.Noland
UnrealHeaderTool: Improved the warning generated when missing Category= on a function or property declared in an engine module, and centralized the logic that determines if the module is engine or game
Change 3470532 by Dan.Oconnor
Re-enable compilation manager
Change 3470572 by Dan.Oconnor
Fix for pin paramters resetting when an archetype was reinstanced
#jira UE-45619
#rnx
Change 3471949 by Mason.Seay
Adding Primary Assets for testing
Change 3472074 by Ben.Zeigler
#jira UE-45140 Convert iterative cooking to use the Asset Registry as it's only mode, remove old hash and timestamp versions. This allows deleting the entire PackageDependencyInfo module
Change the asset registry iteration to not compute a hash at all, and instead store the script package guids in it's cache.
Expose bIgnoreIniSettingsOutOfDateForIteration and bIgnoreScriptPackagesOutOfDateForIteration in cooker settings, affects rather to listen to ini/script changes when doing iterative cooking
Change 3472079 by Ben.Zeigler
With new incremental cook options, change Fortnite to never care about ini settings, but do care about code changes. This can be changed but from previous discussions we wanted to be more safe than fast here
Change 3473429 by Lukasz.Furman
changed path following update tick to allow working on "invalid, update pending" paths, solves AI getting stuck when navigation is rebuild very frequently (e.g. every tick from moving mesh)
#jira UE-41884
Change 3473476 by Lukasz.Furman
changed crowd simulation path update tick to allow working on "invalid, update pending" paths, solves AI getting stuck when navigation is rebuild very frequently (e.g. every tick from moving mesh)
#jira UE-41884
Change 3473663 by Ben.Zeigler
Fix it so base k2node registers framework version, this is needed for the assetptr fixup I previously added
Change 3473679 by Mason.Seay
Slight cleanup of test map and added ability to teleport across level for easy navigation
Change 3473712 by Marc.Audy
Do default value validation against the actual value of the default entry of an enum rather than the serialized empty autogenerated default value
Change 3474055 by Marc.Audy
When nodes are reconstructed any pins that were previously linked or set to non-default values that have been removed will no longer simply vanish, but instead will remain in an Orphaned state until dealt with.
#jira UE-41828
Change 3474119 by mason.seay
Tweaked Force Feedback test
Change 3474156 by Marc.Audy
Actually enable orphan pin retention
Change 3474382 by Ben.Zeigler
Class.h Header and comment cleanup. Started this because IsChildOf did not have a comment and it's usage is a bit confusing
Change 3474386 by Ben.Zeigler
Close popup window when adding asset class to audit window
Change 3474491 by Ben.Zeigler
Remove ability for Worlds to not be saved as assets, this has been the default since 2014.
Change 3475363 by Marc.Audy
Alt-click now works with orphaned pins
#jira UE-45699
Change 3475523 by Marc.Audy
Fixup Fortnite and Paragon content for orphaned pin errors and warnings
Change 3475623 by Phillip.Kavan
#jira UE-45477 - Fix an EDL assertion on load in a nativized build with one or more Actor subobjects instanced via the EditInlineNew UI in the BP class defaults property editor.
Change summary:
- Modified FEmitDefaultValueHelper::OuterGenerate() to emit code to construct/initialize instanced subobject values that do not have the RF_DefaultSubObject flag set, and also to recursively handle nested subobjects for those values.
- Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to alternatively emit a 'NewObject' assignment statement rather than a 'CreateDefaultSubobject' statement if only RF_ArchetypeObject is set on the source object value.
Change 3476008 by Dan.Oconnor
Fix for failing to preload our super class's subobjects. Effectively moving UBlueprint::ForceLoad calls earlier in loading process. This only results in data resetting to your parent's parent's default value from your parent's default value.
#jira UE-18765
Change 3476115 by Dan.Oconnor
Fix missing category information for inherited functions when using compilation manager
#jira UE-45660
#rnx
Change 3476577 by Lukasz.Furman
added early outs from navmesh layer generation when there's no walkable cells or contours to avoid allocating 0 bytes by next generation steps (behavior differs between platforms)
#ue4
Change 3476587 by Phillip.Kavan
#jira UE-45517 - Fix a regression in which dragging UMG widgets around in the designer view results in redundantly-compounded BP class properties and context menu actions.
Change summary:
- Modified SDesignerView::ClearDropPreviews() to move the widget that was removed from the tree into the transient package. This ensures that FWidgetBlueprintCompiler::CreateClassVariablesFromBlueprint() won't pick them up.
- Modified SDesignerView::ProcessDropAndAddWidget() to also consider any widgets not added to the 'DropPreviews' array as being transient (i.e. also move them into the transient package since they were not added to the tree).
Notes:
- The regression was introduced by the changes in CL# 3410168, and was merged to Main at CL# 3431398.
#rnx
Change 3476723 by Dan.Oconnor
Match old behavior wrt updating implemented interfaces in blueprints - this logic from FKismetEditorUtilities::CompileBlueprint was missing in compilation manager
#jira UE-45468
#rnx
Change 3476948 by Michael.Noland
Framework: Changed AActor::FindComponentByClass (and AActor::GetComponentByClass by extension) to return nullptr when passed a nullptr class, rather than crashing
Change 3476970 by Ben.Zeigler
Fix bug I introduced in 4.16 where assigning assets to multiple chunks did not work properly
Change 3477536 by Marc.Audy
Don't display default value box on linked orphaned input pins
Change 3477835 by Marc.Audy
Fix pins orphaned by deletion of an entry in a user-defined enum disappearing instead of remaining connected
#jira UE-45754
Change 3478027 by Marc.Audy
Minor performance optimization
#rnx
Change 3478198 by Phillip.Kavan
#jira UE-42431 - Remove an unnecessary ensure() when pasting an event node.
Change summary:
- Modified UEdGraphSchema_K2::CreateSubstituteNode() to no longer ensure() that we have a valid PreExistingNode; it's only used for logging when a substitute node is created in response to a conflict with an existing node.
Change 3478485 by Marc.Audy
Eliminate extraneous error messages about orphaned pins on get/set nodes
#jira UE-45749
#rnx
Change 3478756 by Marc.Audy
Fix fallout from changes to DoesDefaultValueMatchAutogenerated for user defined enums
#jira UE-45721
#rnx
Change 3478926 by Marc.Audy
Non-blueprint type structs can no longer be made/broken
Non-blueprint visible properties in structs will no longer have pins created for them
#jira UE-43122
Change 3478988 by Marc.Audy
DeltaTime for a tick function with a tick interval is now correct after disabling and then reenabling the tick function.
#jira UE-45524
Change 3479818 by Marc.Audy
Allow ctrl-drag off of orphan pins
#jira UE-45803
Change 3480214 by Marc.Audy
Modifications to user defined enumerations are now transacted
#jira UE-43866
Change 3480579 by Marc.Audy
Maintain all pin properties through transactions.
#rn Reference pins that are removed and then restored via undo now correctly have the diamond icon instead of the standard circle.
Change 3481043 by Marc.Audy
Make/Break of structs does not depend on having blueprint exposed properties.
Splitting of a struct pin still requires blueprint exposed properties.
#jira UE-45840
#jira UE-45831
Change 3481271 by Ben.Zeigler
Fix the AssetManager chunking code to use ChunkDependencyInfo instead of a hardcoded check for chunk 0
Clean up ChunkDependencyInfo and make it properly public
Move ShouldSetManager to be WITH_EDITOR
Ported from WEX branch
#RB peter.sauerbrei
Change 3481373 by Dan.Oconnor
Reduce reliance on expensive FindDelegateSignature. 3275922 made warnings about a ambiguous search more likely as it preserved names of members on the REINST_ classes
#jira UE-45704
Change 3481380 by Ben.Zeigler
Change it so Struct and Object AssetRegistrySearchable properties do not show up in content browser, they are not helpful
Change 3482362 by Marc.Audy
Fix properties not exposed to blueprint warnings for input properties on function graphs.
#jira UE-45824
Change 3482406 by Ben.Zeigler
#jira UE-45883 Fix Switch On Gameplay Tag Container node, and add switch nodes to TagCheck map
Change 3482498 by Ben.Zeigler
Attempt to fix hot reload issues with Asset Manager. We need to reset and re-acquire the asset classes when rescanning, as they may be pointing to the replaced class
Change 3482517 by Lukasz.Furman
fixed smart navlink update functions removing important flag
#jira UE-45875
Change 3482538 by Marc.Audy
When comparing float, vector, and rotator values for whether the the default matches the autogenerated do not use the string compare because differences in use of decimal or number of 0s after decimal are then considered not the same float
#jira UE-45846
Change 3482773 by Marc.Audy
Don't show default value or pass by reference for exec pins
#jira UE-45868
Change 3482791 by Ben.Zeigler
#jira UE-45800 Correctly dirty game mode blueprint when changing player controller/etc classes from game mode customization
Fix it so MarkBlueprintAsStructurallyModified calls MarkBlueprintAsModified as several fixes were only in the second function
Change 3483131 by Zak.Middleton
#ue4 - InterpToMovementComponent:
- Fix velocity not zeroed when interpolation stops.
- Various fixes when calculating velocity and time when substepping is enabled.
- Improve accuracy of interpolation when looping and there is time remaining after the loop event is hit. Consume the remainder of the time after the event back in the loop (similar to handling a blocking impact).
#jira UE-45690
Change 3483146 by Phillip.Kavan
#jira UE-38358 - Propagate 'const' function flag from interface Blueprint to implementing Blueprints.
Change summary:
- Modified FBlueprintEditorUtils::MarkBlueprintAsStructurallyModified() to call SkeletalRecompileChildren() on dependent BPs when the target is an interface BP.
- Modified FBlueprintEditorUtils::MarkBlueprintAsStructurallyModified::FRefreshHelper::SkeletalRecompileChildren() to set child BP status to BS_Dirty after compiling.
- Modified ConformInterfaceByName() (FBlueprintEditorUtils) to use the interface's skeleton class for function iteration as well as to match the Function Entry node's 'const' setting to the interface UFunction's signature.
Change 3483340 by Ben.Zeigler
Fix issue querying asset registry after a hot reload, make sure pending kill objects are never considered to be Assets
Change 3483548 by Michael.Noland
Epic Friday: Playing around with some prototype traps
Change 3483700 by Phillip.Kavan
Fix CIS cook crash introduced by last submit.
#rnx
Change 3485217 by Ben.Zeigler
#jira UE-45519 Fix regression introduced in 4.16 where it would no longer cook all maps when no explicit maps were specified in ini or game callback. Moved the code that detects changes before culture/default map code and hardened it to deal with the case where some engine packages were already in the list before it entered the function
Change 3485367 by Dan.Oconnor
Avoid adding mappings to anim node when creating variables on the skeleton class and using the compilation manager
#jira UE-45756
Change 3485565 by Ben.Zeigler
#jira UE-45948 Fix compilation manager to properly reset variable default values after promoting a pin to local variable
Change 3485566 by Marc.Audy
Fix crashes caused by undo/redo of user defined struct changes
#jira UE-45775
#jira UE-45781
Change 3485805 by Michael.Noland
PR #3459: Fix for world origin shifting and SpringArmComponent location lag (Contributed by michail-nikolaev)
#jira UE-43747
Change 3485807 by Michael.Noland
PR #3485: Added additional textures field to paper 2d tileset class (Contributed by gryphonmyers)
#jira UE-44041
Change 3485811 by Michael.Noland
Framework: Fixed a bug in FStreamLevelAction::MakeSafeLevelName to avoid appending the PIE prefix multiple times (fixes functions like Unload Streaming Level when passed a full package name from an instanced streaming level)
Change 3485829 by Michael.Noland
Framework: Made GetWorldAssetPackageFName BlueprintCallable so instanced levels can be unloaded
Change 3485830 by Michael.Noland
PR #3568: add API declarations to ALevelStreamingVolume methods (Contributed by kayama-shift)
#jira UE-45002
Change 3486039 by Michael.Noland
PR #3495: UE-44014: Refreshing node error fixes (Contributed by projectgheist)
- Empty out the ErrorMsg when a node gets refreshed to prevent the same error messages from compounding
- Added support for split pins in UK2Node_Event::IsFunctionEntryCompatible
- Added a missing check for the delegate pin name on the entry node part of UK2Node_Event::IsFunctionEntryCompatible
#jira UE-44014
Change 3486093 by Michael.Noland
PR #3379: Added GAMEPLAYABILITIES_API to all Ability Tasks. (Contributed by ryanjon2040)
#jira UE-42903
Change 3486139 by Michael.Noland
Blueprints: Added new config options for execution wire thickness when not debugging (DefaultExecutionWireThickness) and data wire thicknesses (DefaultDataWireThickness) to the Graph Editor Settings page
#rn
Change 3486154 by Michael.Noland
Framework: Speculative fix for CIS error about FStructOnScope
#rnx
Change 3486180 by Dan.Oconnor
Better match old logic for determining when to skip data only compile
#jira UE-45830
Change 3487276 by Marc.Audy
Fix crash when using Setter with a locally scoped variable
#rnx
Change 3487278 by Marc.Audy
Ensure that pin change notifications occur on all pin breaks unless it is part of a node being garbage collected
Change 3487658 by Marc.Audy
Ensure that child actor template is created for subclasses
#jira UE-45985
Change 3487699 by Marc.Audy
Move non-templated elements out of FArchiveReplaceObjectRef and put them in FArchiveReplaceObjectRefBase
Change 3487813 by Dan.Oconnor
Asset demonstrating a crash
Change 3488101 by Marc.Audy
Fix crash with spawn/construct actor/object from class nodes when they no longer had any pins.
Correctly orphan pins when a node goes to 0 pins.
Change 3488337 by Marc.Audy
Editable pin base should not manually remove pin and let reconstruct node and rewire pins do their job
#jira UE-46020
Change 3488512 by Dan.Oconnor
ConstructObject nodes and SubInstances nodes use skeleton class when compilation manager can provide it
#jira UE-45830, UE-45965
#rnx
Change 3488631 by Michael.Noland
Framework: Fixed a crash when loading a blueprint with a parent class of ALevelBounds caused by trying to register the class default object with a non-existent level
#jira UE-45630
Change 3488665 by Michael.Noland
Blueprints: Improve the details panel customization for optional pin nodes like Struct Member Get/Set
- The category, raw name, and tooltip of the property are now included as part of the filter text as well
- The property tooltip is now displayed when hovering over the property name
- Code updated to use GET_MEMBER_NAME_CHECKED() where appropriate
Change 3489324 by Marc.Audy
Fix recursion causing stack crash
#jira UE-46038
#rnx
Change 3489326 by Marc.Audy
Fix cooking crash
#jira UE-46031
#rnx
Change 3489687 by mason.seay
Assets for testing orphan pins
Change 3489701 by Marc.Audy
Back out changelist 3487278 and 3489443 and make targetted changes for fixing up orphan pin cases where changing connections doesn't remove the pin.
#jira UE-46051
#jira UE-46052
#rnx
Change 3490352 by Dan.Oconnor
Fix for missing WidgetTree on Skeleton class - just look directly at the WidgetBlueprint
#jira UE-46062
Change 3490814 by Marc.Audy
Make callfunction/macro instances save all pins in orphan state more similar to previous behavior
#rnx
Change 3491022 by Dan.Oconnor
Properly clean up 'Key' property when we fail to create a value property
#jira UE-45279
Change 3491071 by Ben.Zeigler
#jira UE-45981 Fix rotation issues, vector/rotator pins with empty strings were not matching due to uninitialized memory.
Change 3491244 by Michael.Noland
Blueprints: Add compile time message back to the output log (will not auto-open the output log if there were no warnings/errors)
#jira UE-32948
Change 3491276 by Michael.Noland
Blueprints: Fixed some bugs where a newly added item would fail show up in the "My Blueprints" tree if there was a filter active (e.g., when promoting a variable)
- Centralized the logic for clearing the filter so it happens when we try and fail to select the item, rather than ad hoc in various other places
- Made it only clear the filter if necessary, rather than (almost) always clearing it when adding an item
#jira UE-43372
Change 3491562 by Marc.Audy
Put back pin removal in to editable pin base and instead modify the pin destroy implementation to take down child split pins with it
#jira UE-46020
#rnx
Change 3491658 by Marc.Audy
Unify RemoveUserDefinedPin implementations. Use version that has break to avoid size change assert
#rnx
Change 3491946 by Marc.Audy
ReconstructSinglePin no longer destroys OldPin (avoids oprhaned sub pins being destroyed before reparented)
RewireOldPinsToNewPins now destroys OldPins at the end (calling code no longer reponsible)
DestroyImpl now prunes out SubPins that had already been trashed
#rnx
Change 3492040 by Marc.Audy
Discard exec/then pins from a callfunction that has been converted to a pure node
#rnx
Change 3492200 by Zak.Middleton
#ue4 - Always reset the input array in AActor::GetComponents(), but do so without affecting allocated size.
Fixes possible regression from CL 3359561 that removed the Reset(...) entirely.
#jira UE-46012
Change 3492290 by Ben.Zeigler
#jira UE-46108 Fix StringLibrary Mid to never crash, Substring had already been fixed
Change 3492311 by Marc.Audy
Don't clear the pin type if what you're connecting to's pin type is wildcard
#rnx
Change 3492680 by Dan.Oconnor
Handle missing generated class when using compilation manager - tested by forcing compile of BP_ParentClassIsMissingType.uasset
Change 3492826 by Marc.Audy
Don't do pin connection list change notifications from DestroyPins while regenerating on load
#jira UE-46112
#rnx
Change 3492851 by Michael.Noland
Core: Fixed various crashes when using UObject::CallFunctionByNameWithArguments with non-trivial argument types by properly initializing the allocated parameters
Change 3492852 by Michael.Noland
Framework: Fixed a crash if ACharacter::FindComponentByClass was passed a nullptr class
Change 3492934 by Marc.Audy
Fix ensure and crash delete macro containing orphaned pin
#rnx
Change 3493079 by Dan.Oconnor
Fix for crash when opening ThirdPersonAnimBlueprint and ThirdPersonAnimBlueprint_Perf then clicking 'Compile' button in ThirdPersonAnimBlueprint editor. Make sure the convenience members in the derived compilers get set when we relink child classes (which requires making cdos, which requires PropagateValuesToCDO..)
#rnx
Change 3493346 by Phillip.Kavan
#jira UE-40560 - Fix a reported crash when pasting nodes between unrelated Blueprint graphs.
Change summary:
- Modified FEdGraphUtilities::PostProcessPastedNodes() to ensure() on a NULL pin entry; this will allow execution to continue while still alerting us since it is an unexpected result. Also added an 'else' case to then remove the NULL entry so that PostPasteNode() implementations don't all have to guard against NULL pin entries. When the node is reconstructed, the NULL entry will be replaced with the correct pin initialized to its default values.
- Modified UEdGraphPin::ImportTextItem() to add some additional logging to parse error cases when importing pin properties from source T3D text. Hopefully this gives us more information when this is encountered in the future.
Change 3493938 by Michael.Noland
Blueprints: Prevent issues with renaming event dispatchers to contain periods (this may be disallowed in the future, but they no longer become uneditable)
#jira UE-45780
Change 3493945 by Michael.Noland
Blueprints: Fixed GetDelegatePoperty typos
#rnx
Change 3493997 by Michael.Noland
Blueprints: Partially reverting changes from CL# 3319966 to reroute nodes, restoring their alignment but losing the symmetrical grab handle changes
#jira UE-45760
Change 3493998 by Dan.Oconnor
Fix rare crash in RefreshStandAloneDefaultsEditor when the blueprint editor is opened and a blueprint had errors in it
Note: I stumbled across this by running a unit test and then opening a blueprint in the BPE. CrashReporter indicates 3 crashes in the last 3 days
Change 3494025 by Michael.Noland
Engine: Deleted some dead code (DEBUGGING_VIEWPORT_SIZES)
#rnx
Change 3494026 by Michael.Noland
Blueprints: V0 of a BlueprintCallable/BlueprintPure function fuzzer
- Calls exposed methods with default parameters on classes it is able to spawn for now, which catches crashes due to null and /0 but not out of bounds issues or ones on classes it can't spawn due to classwithin, abstract, etc...
- Can be called using Test.ScriptFuzzing, won't be integrated into automated tests until it is more fully fleshed out and all known issues are addressed
#rnx
Change 3496382 by Ben.Zeigler
Fix ensure when launching editor with cook on the side and incremental cooking enabled. It now flushes the background asset gather when calling the sync load all assets if one is in progress
Change 3496688 by Marc.Audy
Avoid crashing in component instance data if (for some reason) the Actor's root component isn't properly set up
#jira UE-46073
Change 3496830 by Michael.Noland
Editor: Change FEditorCategoryUtils methods to take UStruct* instead of UClass*, as they are just reading metadata
#rnx
Change 3496840 by Michael.Noland
Framework: Remove the requirement for a local player in UCheatManager::CheatScript, so it can be be started from the server side (doesn't change the availability of the cheat manager, just allows things like the redundant "cheat cheatscript scriptname" to work)
Change 3497038 by Michael.Noland
Fortnite: Added UFortDeveloperSettings to allow developers to auto-run cheats in PIE (does not occur in -game or outside of WITH_EDITOR builds)
- You can specify a list of cheat commands to run when a pawn is possessed (also needs CL# 3496840 for cheatscripts)
- You can also specify a set of items to grant to your local inventory when it is created
Change 3497204 by Marc.Audy
Fix AbilitySystemComponent not being blueprint readable.
#rnx
Change 3497668 by Mieszko.Zielinski
Fixed a crash in BT editor when dealing with enum-typed Blackboard-keys pointing to enum values that have been deleted #UE4
#jira UE-43659
Change 3497677 by Mieszko.Zielinski
Added a community-suggested working solution to patching up dynamic navmesh after world offset #UE4
Also, fixed a crash related to navmesh rebuilding if generation was configured to lazily gather navigatble geometry
#jira UE-41293
Change 3497678 by Mieszko.Zielinski
Marked AbstractNavData class as transient #UE4
We never want to save it to levels
Change 3497679 by Mieszko.Zielinski
Made NavModifierVolume responsive to editor-time property changes #UE4
#jira UE-32831
Change 3497900 by Dan.Oconnor
Fix bad skel reference when using construct object from class, just limiting scope of 3491946. To reproduce the bug just nativize QA Game, including the TM-Gameplay level
#rnx
Change 3497904 by Dan.Oconnor
Use K2Node_Event::FindEventSignatureFunction in order when directly generating the skeleton generated class to get event params correct
#jira UE-46153
#rnx
Change 3497907 by Dan.Oconnor
Correctly set blueprint visibility flags on params for inherited functions when generating the skeleton class
#rnx
#jira UE-46186
Change 3498218 by mason.seay
Updates to pin testing BP's
Change 3498323 by Mieszko.Zielinski
Made UNavCollision instance assigned to StaticMesh not get re-created from scratch every single time any StaticMesh property changes #UE4
Recreation was resulting in some of the UNavCollision's properties not getting saved and the way we were recreating the nav collision could also interfere with undo buffers
#jira UE-44891
Change 3499007 by Marc.Audy
Allow systems to hook Pre and PostCompile to do custom behaviors
Change 3499013 by Mieszko.Zielinski
Made AbstractNavData class non-transient again #UE4
Implemented AbstractNavData instances' transientness in a different manner.
#jira UE-46194
Change 3499204 by Mieszko.Zielinski
Introduced CrowdManagerBase, an engine-level class that can be extended to implement custom crowd management #Orion
Extracted FRecastQueryFilter into a separate file, which will break some peoples' compilation.
#jira UE-43799
Change 3499321 by mason.seay
Updated bp for struct testing
Change 3499388 by Marc.Audy
Allow the compiler log to store off potential messages from earlier in the compile cycle (early validation), that can be committed later (for example once pruning is completed).
Change 3499390 by Marc.Audy
Generate the orphan pin error messages during EarlyValidation, but cache until the regular validation phase. This ensures all are generated, but only those that aren't pruned will be emitted.
#rnx
Change 3499420 by Michael.Noland
Engine: Introduced a new version of UEngine::GetWorldFromContextObject which takes an enum specifying the behavior on failures and updated all existing uses
The new version intentionally does not have a default value for ErrorMode, callers need to think about which variant of behavior they want:
- ReturnNull: Silently returns nullptr, the calling code is expected to handle this gracefully
- LogAndReturnNull: Raises a runtime error but still returns nullptr, the calling code is expected to handle this gracefully
- Assert: Asserts, the calling code is not expecting to handle a failure gracefully
- Deprecated UEngine::GetWorldFromContextObject(object, boolean) and changed the default behavior for the deprecated instances to do LogAndReturnNull rather than Assert, based on the real-world call pattern
- Introduced GetWorldFromContextObjectChecked(object) as a shorthand for passing in EGetWorldErrorMode::Assert
- Made UObject::GetWorldChecked() actually assert if it would return nullptr (under some cases the old function could silently return nullptr while reporting bSupported = true, so it neither ensured nor checked)
- Fixed a race condition in the 'is implemented' bookkeeping logic in GetWorld()/GetWorldChecked() by confining it to the game thread and added a check() to ImplementsGetWorld() to make it clear that it only works on the game thread
The typical recommended call pattern is to use something like:
if (UWorld* World = GEngine->GetWorldFromContextObject(WorldContextObject, EGetWorldErrorMode::LogAndReturnNull))
{
... Do something with World
}
Handling the failure case but requesting a log message (with BP call stack printed out) if it failed. This is now also the default behavior for old calls to UEngine::GetWorldFromContextObject(Object) (using the default value of bChecked=true), which is a behavior change but it matches how the function was being used in practice; the vast majority of call sites actually expected it to potentially fail and handled the nullptr case gracefully; very few places used the return value unguarded and wanted it to assert when passed a nullptr.
#jira UE-42458
Change 3499429 by Michael.Noland
Engine: Removed a bogus TODO (the problematic code had already been reworked)
#rnx
Change 3499470 by Michael.Noland
Core: Improved and corrected the comment for ensure()
- It doesn't crash when checking is disabled (and hasn't since UE3, maybe ever?)
- It now only fires once per ensure() by default, added a note about ensureAlways()
#rnx
Change 3499643 by Marc.Audy
Use TGuardValue instead of manually managing it
#rnx
Change 3499874 by Marc.Audy
Display <Unnamed> instead of nothing for Pins with blank display name in the compiler log
Change 3499875 by Marc.Audy
When changing function parameter types, don't orphan a pin on the function entry/exit nodes (but do at the call sites)
#jira UE-46224
Change 3499927 by Dan.Oconnor
UField::Serialize no longer serialize's its next ptr, UStruct::Serialize serializes all Children properties instead. This resolves a hard circular dependency between function libraries that EDL detected. It was resolved in an ad hoc way by the old linker
#jira UE-43458
Change 3499953 by Michael.Noland
Core: Created a variant of ensure that does runtime error logging without stopping in the debugger and some related functions that print a warning or error and may trigger a BP callstack (under the same rules as FFrame::KismetExecutionMessage)
- These are WIP and the API may change in the future, but are being used to fix various crashes found by fuzzing BP exposed functions
Change 3499957 by Michael.Noland
Animation: Added runtime errors for nullptr ControlRigs passed into BP methods
#rnx
Change 3499958 by Michael.Noland
Blueprints: Changed an ensure in UKismetNodeHelperLibrary::GetValidValue to a runtime error
#rnx
Change 3499959 by Michael.Noland
Engine: Downgrade various checks() to ensures() in the runtime asset cache functions exposed to Blueprints
Change 3499960 by Michael.Noland
AI: Changed UBTFunctionLibrary to not check/ensure if passed a null world context object
Change 3499968 by Michael.Noland
Editor: Fixed a couple of crashes in UEditorLevelUtils when passed nullptr arguments, and reformatted the entire file to fix widespread indentation issues
#rnx
Change 3499969 by Michael.Noland
Engine: Changed the verbosity of the failure log message of UEngine::GetWorldFromContextObject(..., LogAndReturnNull) from Warning to Error, so it always prints out a BP callstack
#rnx
Change 3499973 by Michael.Noland
Rendering: Fixed asserts in various UKismetRenderingLibrary methods if passed a nullptr for the WorldContextObject
- Also fixed flipped warnings in the failure cases for EndDrawCanvasToRenderTarget
Change 3499979 by Michael.Noland
Editor: Prevented a crash in UMaterialEditingLibrary::RecompileMaterial when passed a nullptr material
Change 3499984 by Michael.Noland
Physics: Prevented a crash in UTraceQueryTestResults::AssertEqual when passed in nullptr for Expected
Change 3499993 by Michael.Noland
Blueprints: Added validation when renaming variables, functions, components, multicast delegates, etc... to prevent names from containing some unacceptable characters
- This validation only kicks in when trying to rename an item, so bad names in existing content are 'grandfathered in'
- These bad names can cause bugs when working with content that contains these characters (e.g., names that contain a period cannot be found via FindObject<T>)
- Currently only . is banned, but eventually we may expand it to include all of INVALID_OBJECTNAME_CHARACTERS
Change 3500009 by Michael.Noland
Blueprints: Made the fuzzer skip classes declared in UnrealEd for now (some of the exposed methods change global state that can cause other tests to fail as the fuzzer isn't particularly sandboxed ATM)
#rnx
Change 3500011 by Michael.Noland
Android: Fixed a crash in UAndroidPermissionFunctionLibrary::AcquirePermissions when called with an empty array on non-Android platforms
Change 3500012 by Michael.Noland
Editor: Prevent a crash in UEditorTutorial::OpenAsset when passed a nullptr Asset
Change 3500014 by Michael.Noland
Engine: Changed FRuntimeAssetCacheFilesystemBackend::ClearCache(NAME_None) to not try to clear all cache directories (there is a separate no-args method for that)
Change 3500019 by Michael.Noland
Core: Fixed some more issues with CallFunctionByNameWithArguments and initializing / destroying parameters
- It was skipping the return value and incorrectly relying on the FirstPropertyToInit list which isn't set for by ref arguments
Change 3500020 by Michael.Noland
Automation: Prevent UFunctionalTestingManager::RunAllFunctionalTests and UFunctionalTestingManager* UFunctionalTestingManager::GetManager from crashing when a manager cannot be created (because we can't route to a world)
Change 3501062 by Marc.Audy
MakeArray AddInputPin is often used as part of node expansion, so need to move the transaction out of the function
Fix inability to undo/redo pin additions to sequence node
Add a K2Node_AddPinInterface to generalize the interface that K2Nodes implement to interact with SGraphNodeK2Sequence so it can be more generally used
#jira UE-46164
#jira UE-46270
Change 3501330 by Michael.Noland
AI: Fix an error on shutdown when the CDO of UAIPerceptionComponent tries to clean up (as it was never registered in the first place)
#jira UE-46271
Change 3501356 by Marc.Audy
Fix crash when multi-editing actor blueprints
#jira UE-46248
Change 3501408 by Michael.Noland
Core: Improve the print-out of FFrame::GetStackTrace() / FFrame::GetScriptCallstack() when there is no script stack (e.g., when FFrame::KismetExecutionMessage is called by native code with no BP above in the call stack)
Change 3501457 by Phillip.Kavan
#jira UE-46054 - Fix crash when launching a packaged build that includes a nativized Blueprint instance with a ChildActorComponent instanced via an AddComponent node.
Change summary:
- Removed UK2Node_AddComponent::PostDuplicate(). This eliminates the creation of redundant component templates that were being unnecessarily created during the Blueprint duplication that precedes the nativization pass.
- Modified SMyBlueprint::OnDuplicateAction() to call MakeNewComponentTemplate() in response to a graph duplication action within the same Blueprint context (replaces previous UK2Node_AddComponent::PostDuplicate() impl).
- Modified FEmitDefaultValueHelper::HandleSpecialTypes() to force AddComponent-based CAC-owned template objects in the emitted codegen to use the UDynamicClass as the Outer when instancing. This matches what we already do for SCS-based CAC-owned template objects - that logic was added in CL# 3270456, and this matches up with FBlueprintNativeCodeGenModule::FindReplacedNameAndOuter(), where we specifically handle CAC-owned template objects.
Change 3502741 by Phillip.Kavan
#jira UE-45782 - Fix undo for index pin type changes.
Change summary:
- Modified SGraphPinIndex::OnTypeChanged() to call Modify() on the pin that was changed.
Change 3502939 by Michael.Noland
Back out changelist 3499927
Change 3503087 by Marc.Audy
Re-fixed ocean content as editor had also changed so had to take theirs and redo
#rnx
Change 3503266 by Ben.Zeigler
#jira UE-46335 Fix regression added in 4.16 where AssetRegistry GetAncesorClassNames/GetDerivedClassNames were not working properly in cooked builds for classes not in memory
Change 3503325 by mason.seay
updated Anim BP to prep for pin testing
Change 3503445 by Marc.Audy
Fix crash caused by OldPins being destroyed before rewiring
#rnx
Change 3505024 by Marc.Audy
Fix NodeEffectsPanel blueprint as it was using pins that no longer existed
#rnx
Change 3505254 by Marc.Audy
Don't include orphan pins when gather source property names
If a property doesn't exist for a source property name just skip the property rather than crashing
#jira UE-46345
#rnx
Change 3506125 by Ben.Zeigler
#jira UE-46311 Fix issues when blueprints are reloaded in place, it needs to remove them from root properly and sanitize the old class. It's still not clear why they are being reloaded in place
Change 3506334 by Dan.Oconnor
Move UAnimGraphNode_Base::PreloadRequiredAssets up to K2Node, make sure nodes get a chance to preload data before compilation manager compiles newly loaded blueprints
#jira UE-46411
Change 3506439 by Dan.Oconnor
Return to pre 3488512 behavior for construct object nodes. This means that we can still get warnings on load when users compile after saving a blueprint, but the current behavior loses default values because it's lookng at the skeleton cdo
#jira UE-46308
Change 3506468 by Dan.Oconnor
Return to pre 3488512 behavior, as it causes bad default values
#jira UE-46414
#rnx
Change 3506733 by Marc.Audy
Use the most up to date class to determine whether a property still exists when adding pins during reconstruction
#jira UE-45965
#author Dan.OConnor
#rnx
Change 3507531 by Ben.Zeigler
#jira UE-46449 Better fix to flush the asset registry queue when the editor requests a synchronous scan at startup. Sometimes it can take a few frames because of file handle delays
Change 3507924 by mason.seay
Sanity save of TM-Gameplay and sublevels to maybe resolve level streaming issues
Change 3507962 by Marc.Audy
Remake changes from CL# 3150796 wiped out by WEX-Staging merge to Main in CL# 3479958
#rnx
Change 3509131 by Dan.Oconnor
Compilation manager compile on load flow never called FindExportsInMemoryFirst, which is critical to prevent reloading of UBlueprintGeneratedClasses when Rename clears the export table
#jira UE-46311
Change 3509345 by Marc.Audy
CVar to disable orphan pins if necessary
#rnx
Change 3509959 by Marc.Audy
Protect against crashing due to large values in Timespan From functions
#jira UE-43840
Change 3510040 by Marc.Audy
Remove all the old unneeded ShooterGame test maps
#rnx
[CL 3510073 by Marc Audy in Main branch]
2017-06-26 15:07:18 -04:00
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3544039)
#lockdown Nick.Penwarden
#rb none
#rnx
=====================================
MAJOR FEATURES + CHANGES
=====================================
Change 3343905 by Dan.Oconnor
ResolveMember optimizations and moved into cpp. ResolveMember<UFunction> now checks UClass::FuncMap before doing more expensive searches
Change 3346637 by Ben.Zeigler
Actually fix in non editor builds
Change 3355484 by Dan.Oconnor
Back out FMemberReference Optimization
Change 3425833 by Ben.Zeigler
#jira UE-31749 Fix it so Undo works properly when modifying a local variable
#jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value
Change 3510091 by Marc.Audy
Expose on Spawn functional test
#rnx
Change 3510100 by Marc.Audy
Fix spelling error
#rnx
Change 3510132 by Marc.Audy
Fix issues with marking a widget blueprint class as abstract
Change 3510133 by Marc.Audy
Minor code cleanup
#rnx
Change 3510178 by Ben.Zeigler
#jira UE-46500 Fix it so editor-only and transient stuct members are not serialized for literal blueprint structs. It's unsafe to serialize them because they may not exist in the cooked build
Change 3510466 by Ben.Zeigler
Start adding basic ability system tests to enginetest, very minimal so far
Change 3511295 by Marc.Audy
Fix wasted work going weak -> object -> weak -> object
#rnx
Change 3511824 by Marc.Audy
Fix spelling error in tooltip
#jira UE-46515
#rnx
Change 3514446 by Ben.Zeigler
Fix ActorBoundEvent and ComponentBoundEvent to always refresh their event signature from the delegate property they are bound to. This is required to correctly deal with delegate signatures being moved or renamed. Both types now do the fixup one time, in ReconstructNode.
Change 3514578 by Marc.Audy
Move clearing of the actor component need end of frame update mark to base class instead of just primitive component
Change 3514583 by Ben.Zeigler
Better fix to last delegate checkin that also handles moving functions between modules but not renaming
Change 3515325 by Dan.Oconnor
Fix for rare orphan pin false positive, rare exposed on spawn false positive
#rnx
Change 3515761 by Marc.Audy
fix shipping configuration
#rnx
Change 3515772 by Marc.Audy
Fix static analysis warnings
#rnx
Change 3516287 by Marc.Audy
Fix references to instanced components not being updated when resetting component to default
#jira UE-44706
#rnx
Change 3516303 by Marc.Audy
Back out CL# 3516287 while an oddity is investigated
#rnx
Change 3516563 by Marc.Audy
(4.17) Fix references to instanced components not being updated when resetting component to default
#jira UE-44706
Change 3516637 by Phillip.Kavan
#jira UE-44661 - Fix potential crash when changing the ChildActorComponent class default value on a Blueprint that also sets the class in the Construction Script.
Change summary:
- Modified UChildActorComponent::DestroyChildActor() to move the check for PendingKill/Unreachable so that we can also rename a defunct ChildActor instance out of the way in order to allow for a new ChildActor instance w/ the cached name.
Change 3517735 by Marc.Audy
Avoid unnecessary string copy
#rnx
Change 3517931 by Marc.Audy
Small optimization to CleanupActors
Change 3518221 by Dan.Oconnor
Fix rare crash when running ConformImplementedEvents when async loading
#jira UE-45348
Change 3518270 by Ben.Zeigler
#jira UE-46574 Add FCollectionReference type and customization to allow setting an FName to an editor collection
Add AssetCollection to PrimaryAssetLabel that derives the bundled assets from an editor collection
Change 3518271 by Marc.Audy
Get rid of unnecessary construction differentiation if custom reset is being used
Change 3518310 by Ben.Marsh
Re-adding IOS files with correct case.
Change 3518423 by Ben.Zeigler
#jira UE-46574 Initial support for chunk installation in Asset Manager.
Refactor AssetManagerSettings so it copies runtime bools into the asset manager for fast access
Add a concept of a stalled streamable manager handle, handles can be created stalled and will not execute their async load until all needed resources have been acquired externally
Change 3518480 by Marc.Audy
Correctly get the variable reference for an input variable get from the member scope rather than a member variable of the same name on the class
#jira UE-46737
Change 3518498 by Ben.Zeigler
Fix bug with AssetManager where requesting the same load twice in a row before the first one finishes caused the complete callback to get called too early for the second load
Update test map to catch this
Change 3518526 by Ben.Zeigler
IOS Fix
Change 3518619 by Ben.Zeigler
#jira UE-46744 Fix issue where refreshing asset manager editor settings would throw away asset label rules overrides, causing the recursive flag to accidentally get set
Change 3518747 by Phillip.Kavan
#jira UE-43154 - Prevent ConstructGenericObject nodes from compiling if the selected type does not include 'BlueprintType' in its inheritance hierarchy.
Change summary:
- Moved UGameplayStatics::CanSpawnObjectOfClass() into UK2Node_GenericCreateObject as a local util method (per JIRA notes). This was not exposed to Blueprints and as such was inconsistent with the rest of the API.
- Modified UGameplayStatics::SpawnObject() to no longer call CanSpawnObjectOfClass(). This seemed redundant as this will already have been called during node validation at Blueprint compile time.
- Refactored CanSpawnObjectOfClass() into FK2Node_GenericCreateObject_Utils. Walking up the inheritance chain no longer starts out w/ the assumption that 'BlueprintType' is set by default, which was previously including a lot of engine-specific classes into the "allowed" set (e.g. UByteProperty). Also unified the 2 loop iterations that were being used to check for 'BlueprintType'/'NotBlueprintType' and 'DontUseGenericSpawnObjectName', as well as the check for whether or not the class is a derivative of AActor/UActorComponent.
- Modified UK2Node_GenericCreateObject::EarlyValidation() to call FK2Node_GenericCreateObject_Utils::CanSpawnObjectOfClass() and emit a slightly more informative error message to the BP compiler message log.
Change 3518756 by Michael.Noland
(4.17) Framework: Prevent various asserts when USplineComponent methods are called on a spline with no points
Change 3518760 by Michael.Noland
Core: Changed FRuntimeAssetCache ensures to ensureAsRuntimeWarning
Change 3518771 by Michael.Noland
AI: Prevent an ensure in UBlackboardComponent::ClearValue when called on a component with a null BlackboardAsset
Change 3518818 by Michael.Noland
Rendering: Fixed a whitespace issue in UCanvasRenderTarget2D::RepaintCanvas()
#rnx
Change 3518822 by Michael.Noland
Sequencer: Prevented crashes in some methods of UMovieSceneSequencePlayer when there is no Sequence set
Sequencer: Prevented a crash in FMovieSceneRootEvaluationTemplateInstance::Evaluate when the instance has no template set
Change 3518824 by Michael.Noland
Landscape: Marked ULandscapeComponent and ULandscapeHeightfieldCollisionComponent as Within=LandscapeProxy, since they do CastChecked on their Outer all the time
Change 3519073 by Michael.Noland
QAGame: Fixed a crash in UQASynth::PlaySynth() if called on a directly created instance rather than using the factory method
Change 3519076 by Michael.Noland
Preventing crashes in UAutomationPerformaceHelper (sic) when spawned abnormally for fuzzing (assumes that the outer will have a route to a world)
#rnx
Change 3519079 by Michael.Noland
Sequencer: Fixed a potential crash in UMediaPlaylist::Insert and UMediaPlaylist::RemoveAt when passed an invalid index
Change 3519081 by Michael.Noland
Blueprints: Added support for creating appropriate outers for objects that must be nested within another class during fuzzing (ones that specify Within=, other relationships aren't knowable yet)
Change 3519082 by Michael.Noland
VR: Prevent a crash in UMRMeshComponent::ConnectReconstructor when passed a null reconstructor
Change 3519084 by Michael.Noland
Rendering: Prevent crashes when UNiagaraComponent::GetEffectDataInterface is called on a component with no effect asset set
Change 3521889 by Michael.Noland
Sequencer: Prevented a bogus static analysis warning by reworking the code (FixedFrameInterval could have only been set if the pointer were valid from the line above)
#rnx
Change 3521987 by Michael.Noland
Animation: Prevent a couple of potential asserts in UControlRig::GetOrAllocateSubControlRig
Change 3522101 by Michael.Noland
Physics: Improved the comment on UPhysicalMaterial::Friction
#rn
Change 3522105 by Michael.Noland
Physics: Fixed a few crashes in UVehicleWheel when spawned directly
Change 3522106 by Michael.Noland
Framework: Marked ULevelStreaming as Within=World, since it does CastChecked on the Outer all the time
Change 3522109 by Michael.Noland
Animation: Marked UAnimInstance as Within=SkeletalMeshComponent since it assumes the outer in various places
Change 3522121 by Michael.Noland
Mobile: Prevent UMobileInstalledContent methods from crashing when called on a created instance in an uncooked build (no installed manifest)
Change 3522783 by Zak.Middleton
#ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before).
Change 3525477 by Dan.Oconnor
Remove Tooltip, Category, and HideCategories tooltip from the blueprint generated class if source data is cleared
Change 3526538 by Ben.Zeigler
Refresh primary asset labels if their bundles are different at all and not just if they're added or removed. This is required because they now work based on collections or directories. This fixes issue with the onboarding collection changes not correctly modifying chunks
Copy of CL #3526501
Change 3526817 by Ben.Zeigler
#jira UE-46917 Fix issue where maps that do not contain level script blueprints were being counted as unindexed for find in blueprints. The old behavior depended on detecting the existence of empty tags, but the asset registry now filters those out so treat maps with no FiB data as indexed
Change 3526873 by Ben.Zeigler
#jira UE-46627 Change it so blueprint or native subclasses of static mesh actor cannot be added to clusters, as they are not likely to be immutable the way the base class is
Add code to to the ubergraph frame to fall back to hard reference serialization if the reference collector doesn't support weak references, such as the cluster collector
Change 3526958 by Marc.Audy
(4.17) Don't copy and then break pin links when reconstructing. Instead simply move.
#jira UE-46935
Change 3528916 by Marc.Audy
PR #3609: Adds GetKeysForAxis() to complement GetKeysForAction() in UPlayerInput (Contributed by alanedwardes)
#jira UE-45347
Change 3529080 by mason.seay
BP asset for undetermined type bug
Change 3529381 by Marc.Audy
Fix ability to insert duplicates in to a set or map
Change 3529471 by Dan.Oconnor
Fix for clang 4.0 error: definition of builtin function '__rdtsc' inline unsigned long long __rdtsc()
Change 3530876 by Marc.Audy
Based on PR #3457: Add MakeSet BP node (Contributed by projectgheist)
Also refactored MakeArray/Set to share a base MakeContainer class
Cleaned up some dead code from MakeArray
Added icon for MakeSet
Added Functional Test for MakeSet
#jira UE-43717
Change 3531070 by Phillip.Kavan
#jira UE-46866 - Fix crash on load when an external variable member reference's owning type cannot be loaded.
Change summary:
- Modified FBlueprintEditorUtils::GetSkeletonClass() to check for NULL before attempting to check for the generating BP.
Change 3531081 by Marc.Audy
Remove deprecated CustomMapParamValue code
Change 3531094 by Phillip.Kavan
#jira UE-46952 - Fix a packaging code build failure that will occur with a nativized Blueprint class that contains a UInterfaceProperty.
Change summary:
- Modified TScriptInterface::operator=() to cast the given 'SourceObject' instance to the 'InterfaceType' type before assigning to 'SourceInterface'. This was necessary because if the caller (in this case nativized codegen) passes in a UObject* that does not explicitly inherit from 'InterfaceType', then it will need to go through the object's GetInterfaceAddress() API instead and cast the result back to an 'InterfaceType' pointer.
Change 3531186 by Phillip.Kavan
Back out changelist 3531094 (temp CIS fix).
#rnx
Change 3532082 by Marc.Audy
Move garbage collection timers and other management to UEngine instead of UWorld
Fixes CollectGarbage blueprint node not working in shipping
#jira UE-46566
Change 3532134 by Phillip.Kavan
Restored changelist 3531094 w/ fix for non-unity.
- Mirrored from //UE4/Release-4.17 (CL# 3531232).
#rnx
Change 3533009 by Marc.Audy
Fixup missing function and deprecation warnings
Change 3534056 by Marc.Audy
(4.17) Fix expose on spawn of map and sets to work
#jira UE-47140
Change 3534761 by Marc.Audy
(4.17) Apply code review changes to Dev-Framework as well
#rnx
Change 3535147 by Dan.Oconnor
Build fix, already made in 4.17
#rnx
Change 3535530 by mason.seay
Resaving to remove error when opening level blueprint
Change 3535581 by Marc.Audy
Class Properties are only identical if they are literally the same object. Do not consider the deep compare port flags as object property base does.
#jira UE-46533
Change 3535583 by Marc.Audy
When properties are imported in to a child actor component the cached instance data is invalidated, so clear it.
#jira UE-46533
Change 3535617 by Marc.Audy
PR #3788: UE-39237: Prevent (im-)pure casting during BP debugging (Contributed by projectgheist)
#jira UE-47188
#jira UE-39237
Change 3535671 by Marc.Audy
Change NodeFactory to look at interface to use sequence node instead of each node having to add itself
Change 3535955 by Marc.Audy
Prevent MakeSet from removing split pins
Change 3536114 by Michael.Noland
Paper2D: Removing deprecated code from 4.3/4.4 era
#rnx
Change 3536120 by Michael.Noland
Animation: Removed deprecated FTAlphaBlend class and AlphaBlendType.h header
Change 3536124 by Michael.Noland
Physics: Removed deprecated methods that were replaced by _AssumesLocked variations
Change 3536131 by Michael.Noland
Slate: Converting remaining uses of EKeyboardFocusCause to EFocusCause and properly deprecating it
Change 3536138 by Michael.Noland
Slate: Removed any deprecated code older than 4.10 that didn't affect content compatibility
Change 3536167 by Dan.Oconnor
When a client provides a skeleton class as the self scope, make sure we also use a skel class for non-self scopes - but only if using the compilation manager. Skel classes are not reliably up to date when not using the compilation manager
#jira UE-46904
Change 3536221 by Michael.Noland
Editor: Removing deprecated code from 4.9 or earlier
Change 3536240 by Michael.Noland
Blueprints: Removed long-deprecated TypeToString method from the K2 schema
#rnx
Change 3536243 by Michael.Noland
AI: Prevent crashes if UMockTask_Log is created manually rather than via the CreateTask factory method
Change 3536244 by Michael.Noland
Core: Prevent FScopedExternalProfilerBase::StopScopedTimer() from asserting if called an unmatched number of times with StartScopedTimer, as both are exposed to BPs now
Change 3536250 by Michael.Noland
CoreUObject: Removed any deprecated code older than 4.10 that didn't affect content compatibility
Change 3536253 by Michael.Noland
Core: Removed any deprecated code older than 4.10 that didn't affect content compatibility
Change 3536310 by Michael.Noland
Engine: Removed any deprecated code older than 4.10 that didn't affect content compatibility
Change 3536397 by Mieszko.Zielinski
Fixed UCrowdFollowingComponent::UpdateCachedDirections crashing when CharacterMovement is not set #UE4
#jira UE-46860
Change 3536404 by Michael.Noland
Platform: Added a warning for others when they try to remove this 'deprecated' method
Change 3536639 by Michael.Noland
CharacterMovement: Changed the name of a variable introduced in CL# 3536397 to better match intent
#rnx
Change 3536893 by Michael.Noland
Blueprints: Clear the stale value on the value pin when a map find node fails to find an item
#jira UE-47233
Change 3536902 by Michael.Noland
Framework: Killed a couple of more deprecated methods that were not exposed to Blueprints
#rnx
Change 3537038 by Ben.Marsh
Fixing case of iOS directories, pt1
Change 3537039 by Ben.Marsh
Fixing case of iOS directories, pt2
Change 3538246 by Michael.Noland
UnrealTournament: Fixing issues with renamed enum
#rnx
Change 3538618 by Ben.Zeigler
Fix ensure when closing sequencer transform UI
Change 3540213 by Ben.Zeigler
#jira UE-47313 Fix crash serializing a MapProperty where the value type has changed for a type that implements ConvertFromType. The address passed to ConvertFromType needs to be the container root, not the specific value address, keys worked because the offset was 0.
Change 3540253 by Marc.Audy
Only copy default values for input pins as output pins do not have them
#rnx
Change 3540376 by Marc.Audy
Add utility FromPinType for FEdGraphTerminalType
#rnx
Change 3540433 by Marc.Audy
Add MakeMap
#jira UE-47093
Unify IsConnectionDisallowed for containers and fix static analysis warning
#jira UE-47291
Change 3540585 by Phillip.Kavan
#jira UE-47117 - Fix crash on launch of a nativized build that includes an instanced default subobject that's referenced by another instanced default subobject.
Change summary:
- Modified FEmitDefaultValueHelper::HandleSpecialTypes() to only direct HandleInstancedSubobject() to emit code to create the instanced subobject if it's not a default subobject. This was previously being incorrectly interpreted as an object having the 'RF_ArchetypeObject' flag set; however, default subobjects will also have that flag set in addition to the 'RF_DefaultSubobject' flag.
- Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert in the 'GetDefaultSubobjectByName' case if the given object is not also a default subobject.
Change 3541147 by Dan.Oconnor
Fix for not being able to override custom events when using the compilation manager post 3536167
#jira UE-47292
#rnx
Change 3541177 by Ben.Zeigler
#jira UE-46595, UE-46553 Fix issue where creating a widget template could cause a widget blueprint being cooked to have the wrong package flags, making it appear to be an uncooked package
Copy of CL #3541027
Change 3541325 by Dan.Oconnor
K2node data table data needs to preload data before the compilation queue is flushed
#rnx
#jira UE-47319
Change 3541409 by Michael.Noland
Blueprints: Added code to reapply any active breakpoints after recompilation when using the BP compilation manager
#jira UE-47322
[reimplementing CL# 3541404 in Dev-Framework]
Change 3541418 by Dan.Oconnor
Fix for bad SKEL_ CDO reference in blueprint bytecode
#jira UE-47265
#rnx
Change 3541482 by Dan.Oconnor
Blanket fix up of preload calls that are being done in AllocateDefaultPins. AllocatDefaultPins is not called until compile, meaning if these preload calls load blueprints they will be loaded while the compilation manager is compiling blueprints
#rnx
#jira UE-47319
Change 3541817 by Marc.Audy
Fix static analysis warnings
#rnx
Change 3542299 by Michael.Noland
Blueprints: Speculative fix for static analysis warning
#rnx
Change 3542406 by Marc.Audy
Use a check slow to avoid any cost
#rnx
Change 3542486 by Michael.Noland
Asset Manager: Removing an unnecessary ensure (it's a potentially expected case)
#jira UE-47380
Change 3542659 by Michael.Noland
Blueprints: Clear out null entries in the LastEditedDocuments list during PostLoad() and remove entries when a graph is being deleted to prevent their generation in the first place
#jira UE-47385
Change 3543620 by Dan.Oconnor
Remove overzealous ensure - we may recompile blueprints that are asynchronously loading when a user triggers a synchronous compile
#jira UE-47415
#rnx
Change 3518415 by Ben.Zeigler
#jira UE-46574 Deprecate IPlatformChunkInstall::SetChunkInstallDelgate as it was spelled wrong, was only half implemented, and did not support success vs failure
Replace with AddChunkInstallDelegate, which supports a bool error code and is bound once instead of separately for each chunk. All implementations support this delegate at a basic level, although several could be improved to call the failure delegate in more cases
Change 3534339 by Michael.Noland
Platforms: Changed DEPRECATED() macro description to use 4.xx rather than a speciifc version in examples, so it doesn't show up when removing deprecated code
[CL 3544050 by Marc Audy in Main branch]
2017-07-19 09:49:59 -04:00
if ( ensureAsRuntimeWarning ( AsyncTask ) )
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3510040)
#lockdown Nick.Penwarden
=====================================
MAJOR FEATURES + CHANGES
=====================================
Change 3459524 by Marc.Audy
Get/Set of properties that were previously BPRW/BPRO should error when used
#jira UE-20993
Change 3460004 by Phillip.Kavan
#jira UE-45171 - Fix C++ compilation failures during packaging caused by nativizing a Blueprint that overrides a native function with a 'TSubclassOf' parameter or return value.
Change summary:
- Modified FKismetCompilerContext::CreateParametersForFunction() to pass the 'CPF_UObjectWrapper' flag through to new function parameter properties during Blueprint compilation.
Change 3461210 by Phillip.Kavan
#jira UE-44505 - Fix occasional Blueprint editor crashes that could occur while rebuilding the context menu from the action registry.
Change summary:
- Modified FBlueprintActionDatabase::FActionRegistry to use an FObjectKey as the key type. This allows us to test entries for UObject validity before rebuilding context menu items based on the action database.
- Changed FBlueprintActionInfo::CachedOwnerClass to be a TWeakObjectPtr rather than a raw UClass* since it's based on the ActionOwner, which could potentially become invalid after the OwnerClass has been cached.
- Modified FBlueprintActionDatabase::RefreshAssetActions() to exclude World assets if the WorldType is not EWorldType::Editor. This eliminates an issue with unreferenced "inactive" GC'd world objects being left in the BP action registry after cooking, at which point the keys could become invalid.
- Added FBlueprintActionDatabase::DeferredRemoveEntry() to allow for scheduling removal of entries from outside of the database if they are known to be invalid.
- Modified FBlueprintActionDatabase::Tick() to handle deferred entry removals.
- Modified FBlueprintActionMenuBuilder::RebuildActionList() to both test actions for validity before building menu items and schedule removal of invalid actions on the next tick.
Notes:
- Alternatively we could just include UObject keys in the database's AddReferencedObject impl, but that would then prevent objects from ever being GC'd if they are not explicitly removed. For most entries the action database takes the approach of explicitly removing entries via delegate when the UObject is destroyed, so I chose to use a TWeakObjectPtr instead so that any entries that may not be getting explicitly removed via delegate will now simply become invalidated if the UObject key is GC'd due to not being referenced. I also set it up to clean and remove any entries (along with any associated node spawners) that are found to be invalid the next time we open the BP editor.
Change 3461373 by Lukasz.Furman
fixed async navmesh rebuilds not kicking in for requests from navdata.bForceRebuildOnLoad
#jira UE-44231
Change 3461409 by Lukasz.Furman
fixed reenabling automatic navmesh generation in Editor Preferences
#ue4
Change 3461550 by Ben.Zeigler
#jira UE-45328 Fix local variable support for Redirectors and other save-time validation. We need to run the local variables to UProperty and back at save time
Add new flag PPF_SerializedAsImportText which is used for BP pins/default values and indicates that something has been serialized as import text and so needs to handle string asset redirectors
Change 3462625 by Zak.Middleton
#ue4 - Fix InterpToMovementComponent not setting velocity on the object it moves. Fix movement rate when substepping enabled (other related fixes to come).
github PR #3620
Change 3462796 by Dan.Oconnor
Fix for spamming BroadcastBlueprintReinstanced and for creating CDO at wrong time when compiling FrontEnd.uasset in OrionGame
#jira UE-45434
Change 3462995 by Ben.Zeigler
#jira UE-16941 Fix it so Load Asset node works with a literal value as well as a connected pin
Change 3463099 by Ben.Zeigler
#jira UE-45471 Allow abstract base classes for primary assets
Change 3464809 by Marc.Audy
Expose FVector2D / FVector2D to blueprints
#jira UE-45427
Change 3467254 by Mieszko.Zielinski
Added an AI helper BP function that supplies caller with a copy of navigation path given controller is currently following #UE4
Change 3467644 by Dan.Oconnor
Fix for cook issues in ocean when using compilation manager, one issue caused by bad dependencies list, one issue caused by lack of subobject mapping in archetype reinstancing.
#jira UE-45443, UE-45444
Change 3468176 by Dan.Oconnor
Fix dependent blueprints being marked dirty when a blueprint is compiled
Change 3468353 by Michael.Noland
UnrealHeaderTool: Improved the warning generated when missing Category= on a function or property declared in an engine module, and centralized the logic that determines if the module is engine or game
Change 3470532 by Dan.Oconnor
Re-enable compilation manager
Change 3470572 by Dan.Oconnor
Fix for pin paramters resetting when an archetype was reinstanced
#jira UE-45619
#rnx
Change 3471949 by Mason.Seay
Adding Primary Assets for testing
Change 3472074 by Ben.Zeigler
#jira UE-45140 Convert iterative cooking to use the Asset Registry as it's only mode, remove old hash and timestamp versions. This allows deleting the entire PackageDependencyInfo module
Change the asset registry iteration to not compute a hash at all, and instead store the script package guids in it's cache.
Expose bIgnoreIniSettingsOutOfDateForIteration and bIgnoreScriptPackagesOutOfDateForIteration in cooker settings, affects rather to listen to ini/script changes when doing iterative cooking
Change 3472079 by Ben.Zeigler
With new incremental cook options, change Fortnite to never care about ini settings, but do care about code changes. This can be changed but from previous discussions we wanted to be more safe than fast here
Change 3473429 by Lukasz.Furman
changed path following update tick to allow working on "invalid, update pending" paths, solves AI getting stuck when navigation is rebuild very frequently (e.g. every tick from moving mesh)
#jira UE-41884
Change 3473476 by Lukasz.Furman
changed crowd simulation path update tick to allow working on "invalid, update pending" paths, solves AI getting stuck when navigation is rebuild very frequently (e.g. every tick from moving mesh)
#jira UE-41884
Change 3473663 by Ben.Zeigler
Fix it so base k2node registers framework version, this is needed for the assetptr fixup I previously added
Change 3473679 by Mason.Seay
Slight cleanup of test map and added ability to teleport across level for easy navigation
Change 3473712 by Marc.Audy
Do default value validation against the actual value of the default entry of an enum rather than the serialized empty autogenerated default value
Change 3474055 by Marc.Audy
When nodes are reconstructed any pins that were previously linked or set to non-default values that have been removed will no longer simply vanish, but instead will remain in an Orphaned state until dealt with.
#jira UE-41828
Change 3474119 by mason.seay
Tweaked Force Feedback test
Change 3474156 by Marc.Audy
Actually enable orphan pin retention
Change 3474382 by Ben.Zeigler
Class.h Header and comment cleanup. Started this because IsChildOf did not have a comment and it's usage is a bit confusing
Change 3474386 by Ben.Zeigler
Close popup window when adding asset class to audit window
Change 3474491 by Ben.Zeigler
Remove ability for Worlds to not be saved as assets, this has been the default since 2014.
Change 3475363 by Marc.Audy
Alt-click now works with orphaned pins
#jira UE-45699
Change 3475523 by Marc.Audy
Fixup Fortnite and Paragon content for orphaned pin errors and warnings
Change 3475623 by Phillip.Kavan
#jira UE-45477 - Fix an EDL assertion on load in a nativized build with one or more Actor subobjects instanced via the EditInlineNew UI in the BP class defaults property editor.
Change summary:
- Modified FEmitDefaultValueHelper::OuterGenerate() to emit code to construct/initialize instanced subobject values that do not have the RF_DefaultSubObject flag set, and also to recursively handle nested subobjects for those values.
- Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to alternatively emit a 'NewObject' assignment statement rather than a 'CreateDefaultSubobject' statement if only RF_ArchetypeObject is set on the source object value.
Change 3476008 by Dan.Oconnor
Fix for failing to preload our super class's subobjects. Effectively moving UBlueprint::ForceLoad calls earlier in loading process. This only results in data resetting to your parent's parent's default value from your parent's default value.
#jira UE-18765
Change 3476115 by Dan.Oconnor
Fix missing category information for inherited functions when using compilation manager
#jira UE-45660
#rnx
Change 3476577 by Lukasz.Furman
added early outs from navmesh layer generation when there's no walkable cells or contours to avoid allocating 0 bytes by next generation steps (behavior differs between platforms)
#ue4
Change 3476587 by Phillip.Kavan
#jira UE-45517 - Fix a regression in which dragging UMG widgets around in the designer view results in redundantly-compounded BP class properties and context menu actions.
Change summary:
- Modified SDesignerView::ClearDropPreviews() to move the widget that was removed from the tree into the transient package. This ensures that FWidgetBlueprintCompiler::CreateClassVariablesFromBlueprint() won't pick them up.
- Modified SDesignerView::ProcessDropAndAddWidget() to also consider any widgets not added to the 'DropPreviews' array as being transient (i.e. also move them into the transient package since they were not added to the tree).
Notes:
- The regression was introduced by the changes in CL# 3410168, and was merged to Main at CL# 3431398.
#rnx
Change 3476723 by Dan.Oconnor
Match old behavior wrt updating implemented interfaces in blueprints - this logic from FKismetEditorUtilities::CompileBlueprint was missing in compilation manager
#jira UE-45468
#rnx
Change 3476948 by Michael.Noland
Framework: Changed AActor::FindComponentByClass (and AActor::GetComponentByClass by extension) to return nullptr when passed a nullptr class, rather than crashing
Change 3476970 by Ben.Zeigler
Fix bug I introduced in 4.16 where assigning assets to multiple chunks did not work properly
Change 3477536 by Marc.Audy
Don't display default value box on linked orphaned input pins
Change 3477835 by Marc.Audy
Fix pins orphaned by deletion of an entry in a user-defined enum disappearing instead of remaining connected
#jira UE-45754
Change 3478027 by Marc.Audy
Minor performance optimization
#rnx
Change 3478198 by Phillip.Kavan
#jira UE-42431 - Remove an unnecessary ensure() when pasting an event node.
Change summary:
- Modified UEdGraphSchema_K2::CreateSubstituteNode() to no longer ensure() that we have a valid PreExistingNode; it's only used for logging when a substitute node is created in response to a conflict with an existing node.
Change 3478485 by Marc.Audy
Eliminate extraneous error messages about orphaned pins on get/set nodes
#jira UE-45749
#rnx
Change 3478756 by Marc.Audy
Fix fallout from changes to DoesDefaultValueMatchAutogenerated for user defined enums
#jira UE-45721
#rnx
Change 3478926 by Marc.Audy
Non-blueprint type structs can no longer be made/broken
Non-blueprint visible properties in structs will no longer have pins created for them
#jira UE-43122
Change 3478988 by Marc.Audy
DeltaTime for a tick function with a tick interval is now correct after disabling and then reenabling the tick function.
#jira UE-45524
Change 3479818 by Marc.Audy
Allow ctrl-drag off of orphan pins
#jira UE-45803
Change 3480214 by Marc.Audy
Modifications to user defined enumerations are now transacted
#jira UE-43866
Change 3480579 by Marc.Audy
Maintain all pin properties through transactions.
#rn Reference pins that are removed and then restored via undo now correctly have the diamond icon instead of the standard circle.
Change 3481043 by Marc.Audy
Make/Break of structs does not depend on having blueprint exposed properties.
Splitting of a struct pin still requires blueprint exposed properties.
#jira UE-45840
#jira UE-45831
Change 3481271 by Ben.Zeigler
Fix the AssetManager chunking code to use ChunkDependencyInfo instead of a hardcoded check for chunk 0
Clean up ChunkDependencyInfo and make it properly public
Move ShouldSetManager to be WITH_EDITOR
Ported from WEX branch
#RB peter.sauerbrei
Change 3481373 by Dan.Oconnor
Reduce reliance on expensive FindDelegateSignature. 3275922 made warnings about a ambiguous search more likely as it preserved names of members on the REINST_ classes
#jira UE-45704
Change 3481380 by Ben.Zeigler
Change it so Struct and Object AssetRegistrySearchable properties do not show up in content browser, they are not helpful
Change 3482362 by Marc.Audy
Fix properties not exposed to blueprint warnings for input properties on function graphs.
#jira UE-45824
Change 3482406 by Ben.Zeigler
#jira UE-45883 Fix Switch On Gameplay Tag Container node, and add switch nodes to TagCheck map
Change 3482498 by Ben.Zeigler
Attempt to fix hot reload issues with Asset Manager. We need to reset and re-acquire the asset classes when rescanning, as they may be pointing to the replaced class
Change 3482517 by Lukasz.Furman
fixed smart navlink update functions removing important flag
#jira UE-45875
Change 3482538 by Marc.Audy
When comparing float, vector, and rotator values for whether the the default matches the autogenerated do not use the string compare because differences in use of decimal or number of 0s after decimal are then considered not the same float
#jira UE-45846
Change 3482773 by Marc.Audy
Don't show default value or pass by reference for exec pins
#jira UE-45868
Change 3482791 by Ben.Zeigler
#jira UE-45800 Correctly dirty game mode blueprint when changing player controller/etc classes from game mode customization
Fix it so MarkBlueprintAsStructurallyModified calls MarkBlueprintAsModified as several fixes were only in the second function
Change 3483131 by Zak.Middleton
#ue4 - InterpToMovementComponent:
- Fix velocity not zeroed when interpolation stops.
- Various fixes when calculating velocity and time when substepping is enabled.
- Improve accuracy of interpolation when looping and there is time remaining after the loop event is hit. Consume the remainder of the time after the event back in the loop (similar to handling a blocking impact).
#jira UE-45690
Change 3483146 by Phillip.Kavan
#jira UE-38358 - Propagate 'const' function flag from interface Blueprint to implementing Blueprints.
Change summary:
- Modified FBlueprintEditorUtils::MarkBlueprintAsStructurallyModified() to call SkeletalRecompileChildren() on dependent BPs when the target is an interface BP.
- Modified FBlueprintEditorUtils::MarkBlueprintAsStructurallyModified::FRefreshHelper::SkeletalRecompileChildren() to set child BP status to BS_Dirty after compiling.
- Modified ConformInterfaceByName() (FBlueprintEditorUtils) to use the interface's skeleton class for function iteration as well as to match the Function Entry node's 'const' setting to the interface UFunction's signature.
Change 3483340 by Ben.Zeigler
Fix issue querying asset registry after a hot reload, make sure pending kill objects are never considered to be Assets
Change 3483548 by Michael.Noland
Epic Friday: Playing around with some prototype traps
Change 3483700 by Phillip.Kavan
Fix CIS cook crash introduced by last submit.
#rnx
Change 3485217 by Ben.Zeigler
#jira UE-45519 Fix regression introduced in 4.16 where it would no longer cook all maps when no explicit maps were specified in ini or game callback. Moved the code that detects changes before culture/default map code and hardened it to deal with the case where some engine packages were already in the list before it entered the function
Change 3485367 by Dan.Oconnor
Avoid adding mappings to anim node when creating variables on the skeleton class and using the compilation manager
#jira UE-45756
Change 3485565 by Ben.Zeigler
#jira UE-45948 Fix compilation manager to properly reset variable default values after promoting a pin to local variable
Change 3485566 by Marc.Audy
Fix crashes caused by undo/redo of user defined struct changes
#jira UE-45775
#jira UE-45781
Change 3485805 by Michael.Noland
PR #3459: Fix for world origin shifting and SpringArmComponent location lag (Contributed by michail-nikolaev)
#jira UE-43747
Change 3485807 by Michael.Noland
PR #3485: Added additional textures field to paper 2d tileset class (Contributed by gryphonmyers)
#jira UE-44041
Change 3485811 by Michael.Noland
Framework: Fixed a bug in FStreamLevelAction::MakeSafeLevelName to avoid appending the PIE prefix multiple times (fixes functions like Unload Streaming Level when passed a full package name from an instanced streaming level)
Change 3485829 by Michael.Noland
Framework: Made GetWorldAssetPackageFName BlueprintCallable so instanced levels can be unloaded
Change 3485830 by Michael.Noland
PR #3568: add API declarations to ALevelStreamingVolume methods (Contributed by kayama-shift)
#jira UE-45002
Change 3486039 by Michael.Noland
PR #3495: UE-44014: Refreshing node error fixes (Contributed by projectgheist)
- Empty out the ErrorMsg when a node gets refreshed to prevent the same error messages from compounding
- Added support for split pins in UK2Node_Event::IsFunctionEntryCompatible
- Added a missing check for the delegate pin name on the entry node part of UK2Node_Event::IsFunctionEntryCompatible
#jira UE-44014
Change 3486093 by Michael.Noland
PR #3379: Added GAMEPLAYABILITIES_API to all Ability Tasks. (Contributed by ryanjon2040)
#jira UE-42903
Change 3486139 by Michael.Noland
Blueprints: Added new config options for execution wire thickness when not debugging (DefaultExecutionWireThickness) and data wire thicknesses (DefaultDataWireThickness) to the Graph Editor Settings page
#rn
Change 3486154 by Michael.Noland
Framework: Speculative fix for CIS error about FStructOnScope
#rnx
Change 3486180 by Dan.Oconnor
Better match old logic for determining when to skip data only compile
#jira UE-45830
Change 3487276 by Marc.Audy
Fix crash when using Setter with a locally scoped variable
#rnx
Change 3487278 by Marc.Audy
Ensure that pin change notifications occur on all pin breaks unless it is part of a node being garbage collected
Change 3487658 by Marc.Audy
Ensure that child actor template is created for subclasses
#jira UE-45985
Change 3487699 by Marc.Audy
Move non-templated elements out of FArchiveReplaceObjectRef and put them in FArchiveReplaceObjectRefBase
Change 3487813 by Dan.Oconnor
Asset demonstrating a crash
Change 3488101 by Marc.Audy
Fix crash with spawn/construct actor/object from class nodes when they no longer had any pins.
Correctly orphan pins when a node goes to 0 pins.
Change 3488337 by Marc.Audy
Editable pin base should not manually remove pin and let reconstruct node and rewire pins do their job
#jira UE-46020
Change 3488512 by Dan.Oconnor
ConstructObject nodes and SubInstances nodes use skeleton class when compilation manager can provide it
#jira UE-45830, UE-45965
#rnx
Change 3488631 by Michael.Noland
Framework: Fixed a crash when loading a blueprint with a parent class of ALevelBounds caused by trying to register the class default object with a non-existent level
#jira UE-45630
Change 3488665 by Michael.Noland
Blueprints: Improve the details panel customization for optional pin nodes like Struct Member Get/Set
- The category, raw name, and tooltip of the property are now included as part of the filter text as well
- The property tooltip is now displayed when hovering over the property name
- Code updated to use GET_MEMBER_NAME_CHECKED() where appropriate
Change 3489324 by Marc.Audy
Fix recursion causing stack crash
#jira UE-46038
#rnx
Change 3489326 by Marc.Audy
Fix cooking crash
#jira UE-46031
#rnx
Change 3489687 by mason.seay
Assets for testing orphan pins
Change 3489701 by Marc.Audy
Back out changelist 3487278 and 3489443 and make targetted changes for fixing up orphan pin cases where changing connections doesn't remove the pin.
#jira UE-46051
#jira UE-46052
#rnx
Change 3490352 by Dan.Oconnor
Fix for missing WidgetTree on Skeleton class - just look directly at the WidgetBlueprint
#jira UE-46062
Change 3490814 by Marc.Audy
Make callfunction/macro instances save all pins in orphan state more similar to previous behavior
#rnx
Change 3491022 by Dan.Oconnor
Properly clean up 'Key' property when we fail to create a value property
#jira UE-45279
Change 3491071 by Ben.Zeigler
#jira UE-45981 Fix rotation issues, vector/rotator pins with empty strings were not matching due to uninitialized memory.
Change 3491244 by Michael.Noland
Blueprints: Add compile time message back to the output log (will not auto-open the output log if there were no warnings/errors)
#jira UE-32948
Change 3491276 by Michael.Noland
Blueprints: Fixed some bugs where a newly added item would fail show up in the "My Blueprints" tree if there was a filter active (e.g., when promoting a variable)
- Centralized the logic for clearing the filter so it happens when we try and fail to select the item, rather than ad hoc in various other places
- Made it only clear the filter if necessary, rather than (almost) always clearing it when adding an item
#jira UE-43372
Change 3491562 by Marc.Audy
Put back pin removal in to editable pin base and instead modify the pin destroy implementation to take down child split pins with it
#jira UE-46020
#rnx
Change 3491658 by Marc.Audy
Unify RemoveUserDefinedPin implementations. Use version that has break to avoid size change assert
#rnx
Change 3491946 by Marc.Audy
ReconstructSinglePin no longer destroys OldPin (avoids oprhaned sub pins being destroyed before reparented)
RewireOldPinsToNewPins now destroys OldPins at the end (calling code no longer reponsible)
DestroyImpl now prunes out SubPins that had already been trashed
#rnx
Change 3492040 by Marc.Audy
Discard exec/then pins from a callfunction that has been converted to a pure node
#rnx
Change 3492200 by Zak.Middleton
#ue4 - Always reset the input array in AActor::GetComponents(), but do so without affecting allocated size.
Fixes possible regression from CL 3359561 that removed the Reset(...) entirely.
#jira UE-46012
Change 3492290 by Ben.Zeigler
#jira UE-46108 Fix StringLibrary Mid to never crash, Substring had already been fixed
Change 3492311 by Marc.Audy
Don't clear the pin type if what you're connecting to's pin type is wildcard
#rnx
Change 3492680 by Dan.Oconnor
Handle missing generated class when using compilation manager - tested by forcing compile of BP_ParentClassIsMissingType.uasset
Change 3492826 by Marc.Audy
Don't do pin connection list change notifications from DestroyPins while regenerating on load
#jira UE-46112
#rnx
Change 3492851 by Michael.Noland
Core: Fixed various crashes when using UObject::CallFunctionByNameWithArguments with non-trivial argument types by properly initializing the allocated parameters
Change 3492852 by Michael.Noland
Framework: Fixed a crash if ACharacter::FindComponentByClass was passed a nullptr class
Change 3492934 by Marc.Audy
Fix ensure and crash delete macro containing orphaned pin
#rnx
Change 3493079 by Dan.Oconnor
Fix for crash when opening ThirdPersonAnimBlueprint and ThirdPersonAnimBlueprint_Perf then clicking 'Compile' button in ThirdPersonAnimBlueprint editor. Make sure the convenience members in the derived compilers get set when we relink child classes (which requires making cdos, which requires PropagateValuesToCDO..)
#rnx
Change 3493346 by Phillip.Kavan
#jira UE-40560 - Fix a reported crash when pasting nodes between unrelated Blueprint graphs.
Change summary:
- Modified FEdGraphUtilities::PostProcessPastedNodes() to ensure() on a NULL pin entry; this will allow execution to continue while still alerting us since it is an unexpected result. Also added an 'else' case to then remove the NULL entry so that PostPasteNode() implementations don't all have to guard against NULL pin entries. When the node is reconstructed, the NULL entry will be replaced with the correct pin initialized to its default values.
- Modified UEdGraphPin::ImportTextItem() to add some additional logging to parse error cases when importing pin properties from source T3D text. Hopefully this gives us more information when this is encountered in the future.
Change 3493938 by Michael.Noland
Blueprints: Prevent issues with renaming event dispatchers to contain periods (this may be disallowed in the future, but they no longer become uneditable)
#jira UE-45780
Change 3493945 by Michael.Noland
Blueprints: Fixed GetDelegatePoperty typos
#rnx
Change 3493997 by Michael.Noland
Blueprints: Partially reverting changes from CL# 3319966 to reroute nodes, restoring their alignment but losing the symmetrical grab handle changes
#jira UE-45760
Change 3493998 by Dan.Oconnor
Fix rare crash in RefreshStandAloneDefaultsEditor when the blueprint editor is opened and a blueprint had errors in it
Note: I stumbled across this by running a unit test and then opening a blueprint in the BPE. CrashReporter indicates 3 crashes in the last 3 days
Change 3494025 by Michael.Noland
Engine: Deleted some dead code (DEBUGGING_VIEWPORT_SIZES)
#rnx
Change 3494026 by Michael.Noland
Blueprints: V0 of a BlueprintCallable/BlueprintPure function fuzzer
- Calls exposed methods with default parameters on classes it is able to spawn for now, which catches crashes due to null and /0 but not out of bounds issues or ones on classes it can't spawn due to classwithin, abstract, etc...
- Can be called using Test.ScriptFuzzing, won't be integrated into automated tests until it is more fully fleshed out and all known issues are addressed
#rnx
Change 3496382 by Ben.Zeigler
Fix ensure when launching editor with cook on the side and incremental cooking enabled. It now flushes the background asset gather when calling the sync load all assets if one is in progress
Change 3496688 by Marc.Audy
Avoid crashing in component instance data if (for some reason) the Actor's root component isn't properly set up
#jira UE-46073
Change 3496830 by Michael.Noland
Editor: Change FEditorCategoryUtils methods to take UStruct* instead of UClass*, as they are just reading metadata
#rnx
Change 3496840 by Michael.Noland
Framework: Remove the requirement for a local player in UCheatManager::CheatScript, so it can be be started from the server side (doesn't change the availability of the cheat manager, just allows things like the redundant "cheat cheatscript scriptname" to work)
Change 3497038 by Michael.Noland
Fortnite: Added UFortDeveloperSettings to allow developers to auto-run cheats in PIE (does not occur in -game or outside of WITH_EDITOR builds)
- You can specify a list of cheat commands to run when a pawn is possessed (also needs CL# 3496840 for cheatscripts)
- You can also specify a set of items to grant to your local inventory when it is created
Change 3497204 by Marc.Audy
Fix AbilitySystemComponent not being blueprint readable.
#rnx
Change 3497668 by Mieszko.Zielinski
Fixed a crash in BT editor when dealing with enum-typed Blackboard-keys pointing to enum values that have been deleted #UE4
#jira UE-43659
Change 3497677 by Mieszko.Zielinski
Added a community-suggested working solution to patching up dynamic navmesh after world offset #UE4
Also, fixed a crash related to navmesh rebuilding if generation was configured to lazily gather navigatble geometry
#jira UE-41293
Change 3497678 by Mieszko.Zielinski
Marked AbstractNavData class as transient #UE4
We never want to save it to levels
Change 3497679 by Mieszko.Zielinski
Made NavModifierVolume responsive to editor-time property changes #UE4
#jira UE-32831
Change 3497900 by Dan.Oconnor
Fix bad skel reference when using construct object from class, just limiting scope of 3491946. To reproduce the bug just nativize QA Game, including the TM-Gameplay level
#rnx
Change 3497904 by Dan.Oconnor
Use K2Node_Event::FindEventSignatureFunction in order when directly generating the skeleton generated class to get event params correct
#jira UE-46153
#rnx
Change 3497907 by Dan.Oconnor
Correctly set blueprint visibility flags on params for inherited functions when generating the skeleton class
#rnx
#jira UE-46186
Change 3498218 by mason.seay
Updates to pin testing BP's
Change 3498323 by Mieszko.Zielinski
Made UNavCollision instance assigned to StaticMesh not get re-created from scratch every single time any StaticMesh property changes #UE4
Recreation was resulting in some of the UNavCollision's properties not getting saved and the way we were recreating the nav collision could also interfere with undo buffers
#jira UE-44891
Change 3499007 by Marc.Audy
Allow systems to hook Pre and PostCompile to do custom behaviors
Change 3499013 by Mieszko.Zielinski
Made AbstractNavData class non-transient again #UE4
Implemented AbstractNavData instances' transientness in a different manner.
#jira UE-46194
Change 3499204 by Mieszko.Zielinski
Introduced CrowdManagerBase, an engine-level class that can be extended to implement custom crowd management #Orion
Extracted FRecastQueryFilter into a separate file, which will break some peoples' compilation.
#jira UE-43799
Change 3499321 by mason.seay
Updated bp for struct testing
Change 3499388 by Marc.Audy
Allow the compiler log to store off potential messages from earlier in the compile cycle (early validation), that can be committed later (for example once pruning is completed).
Change 3499390 by Marc.Audy
Generate the orphan pin error messages during EarlyValidation, but cache until the regular validation phase. This ensures all are generated, but only those that aren't pruned will be emitted.
#rnx
Change 3499420 by Michael.Noland
Engine: Introduced a new version of UEngine::GetWorldFromContextObject which takes an enum specifying the behavior on failures and updated all existing uses
The new version intentionally does not have a default value for ErrorMode, callers need to think about which variant of behavior they want:
- ReturnNull: Silently returns nullptr, the calling code is expected to handle this gracefully
- LogAndReturnNull: Raises a runtime error but still returns nullptr, the calling code is expected to handle this gracefully
- Assert: Asserts, the calling code is not expecting to handle a failure gracefully
- Deprecated UEngine::GetWorldFromContextObject(object, boolean) and changed the default behavior for the deprecated instances to do LogAndReturnNull rather than Assert, based on the real-world call pattern
- Introduced GetWorldFromContextObjectChecked(object) as a shorthand for passing in EGetWorldErrorMode::Assert
- Made UObject::GetWorldChecked() actually assert if it would return nullptr (under some cases the old function could silently return nullptr while reporting bSupported = true, so it neither ensured nor checked)
- Fixed a race condition in the 'is implemented' bookkeeping logic in GetWorld()/GetWorldChecked() by confining it to the game thread and added a check() to ImplementsGetWorld() to make it clear that it only works on the game thread
The typical recommended call pattern is to use something like:
if (UWorld* World = GEngine->GetWorldFromContextObject(WorldContextObject, EGetWorldErrorMode::LogAndReturnNull))
{
... Do something with World
}
Handling the failure case but requesting a log message (with BP call stack printed out) if it failed. This is now also the default behavior for old calls to UEngine::GetWorldFromContextObject(Object) (using the default value of bChecked=true), which is a behavior change but it matches how the function was being used in practice; the vast majority of call sites actually expected it to potentially fail and handled the nullptr case gracefully; very few places used the return value unguarded and wanted it to assert when passed a nullptr.
#jira UE-42458
Change 3499429 by Michael.Noland
Engine: Removed a bogus TODO (the problematic code had already been reworked)
#rnx
Change 3499470 by Michael.Noland
Core: Improved and corrected the comment for ensure()
- It doesn't crash when checking is disabled (and hasn't since UE3, maybe ever?)
- It now only fires once per ensure() by default, added a note about ensureAlways()
#rnx
Change 3499643 by Marc.Audy
Use TGuardValue instead of manually managing it
#rnx
Change 3499874 by Marc.Audy
Display <Unnamed> instead of nothing for Pins with blank display name in the compiler log
Change 3499875 by Marc.Audy
When changing function parameter types, don't orphan a pin on the function entry/exit nodes (but do at the call sites)
#jira UE-46224
Change 3499927 by Dan.Oconnor
UField::Serialize no longer serialize's its next ptr, UStruct::Serialize serializes all Children properties instead. This resolves a hard circular dependency between function libraries that EDL detected. It was resolved in an ad hoc way by the old linker
#jira UE-43458
Change 3499953 by Michael.Noland
Core: Created a variant of ensure that does runtime error logging without stopping in the debugger and some related functions that print a warning or error and may trigger a BP callstack (under the same rules as FFrame::KismetExecutionMessage)
- These are WIP and the API may change in the future, but are being used to fix various crashes found by fuzzing BP exposed functions
Change 3499957 by Michael.Noland
Animation: Added runtime errors for nullptr ControlRigs passed into BP methods
#rnx
Change 3499958 by Michael.Noland
Blueprints: Changed an ensure in UKismetNodeHelperLibrary::GetValidValue to a runtime error
#rnx
Change 3499959 by Michael.Noland
Engine: Downgrade various checks() to ensures() in the runtime asset cache functions exposed to Blueprints
Change 3499960 by Michael.Noland
AI: Changed UBTFunctionLibrary to not check/ensure if passed a null world context object
Change 3499968 by Michael.Noland
Editor: Fixed a couple of crashes in UEditorLevelUtils when passed nullptr arguments, and reformatted the entire file to fix widespread indentation issues
#rnx
Change 3499969 by Michael.Noland
Engine: Changed the verbosity of the failure log message of UEngine::GetWorldFromContextObject(..., LogAndReturnNull) from Warning to Error, so it always prints out a BP callstack
#rnx
Change 3499973 by Michael.Noland
Rendering: Fixed asserts in various UKismetRenderingLibrary methods if passed a nullptr for the WorldContextObject
- Also fixed flipped warnings in the failure cases for EndDrawCanvasToRenderTarget
Change 3499979 by Michael.Noland
Editor: Prevented a crash in UMaterialEditingLibrary::RecompileMaterial when passed a nullptr material
Change 3499984 by Michael.Noland
Physics: Prevented a crash in UTraceQueryTestResults::AssertEqual when passed in nullptr for Expected
Change 3499993 by Michael.Noland
Blueprints: Added validation when renaming variables, functions, components, multicast delegates, etc... to prevent names from containing some unacceptable characters
- This validation only kicks in when trying to rename an item, so bad names in existing content are 'grandfathered in'
- These bad names can cause bugs when working with content that contains these characters (e.g., names that contain a period cannot be found via FindObject<T>)
- Currently only . is banned, but eventually we may expand it to include all of INVALID_OBJECTNAME_CHARACTERS
Change 3500009 by Michael.Noland
Blueprints: Made the fuzzer skip classes declared in UnrealEd for now (some of the exposed methods change global state that can cause other tests to fail as the fuzzer isn't particularly sandboxed ATM)
#rnx
Change 3500011 by Michael.Noland
Android: Fixed a crash in UAndroidPermissionFunctionLibrary::AcquirePermissions when called with an empty array on non-Android platforms
Change 3500012 by Michael.Noland
Editor: Prevent a crash in UEditorTutorial::OpenAsset when passed a nullptr Asset
Change 3500014 by Michael.Noland
Engine: Changed FRuntimeAssetCacheFilesystemBackend::ClearCache(NAME_None) to not try to clear all cache directories (there is a separate no-args method for that)
Change 3500019 by Michael.Noland
Core: Fixed some more issues with CallFunctionByNameWithArguments and initializing / destroying parameters
- It was skipping the return value and incorrectly relying on the FirstPropertyToInit list which isn't set for by ref arguments
Change 3500020 by Michael.Noland
Automation: Prevent UFunctionalTestingManager::RunAllFunctionalTests and UFunctionalTestingManager* UFunctionalTestingManager::GetManager from crashing when a manager cannot be created (because we can't route to a world)
Change 3501062 by Marc.Audy
MakeArray AddInputPin is often used as part of node expansion, so need to move the transaction out of the function
Fix inability to undo/redo pin additions to sequence node
Add a K2Node_AddPinInterface to generalize the interface that K2Nodes implement to interact with SGraphNodeK2Sequence so it can be more generally used
#jira UE-46164
#jira UE-46270
Change 3501330 by Michael.Noland
AI: Fix an error on shutdown when the CDO of UAIPerceptionComponent tries to clean up (as it was never registered in the first place)
#jira UE-46271
Change 3501356 by Marc.Audy
Fix crash when multi-editing actor blueprints
#jira UE-46248
Change 3501408 by Michael.Noland
Core: Improve the print-out of FFrame::GetStackTrace() / FFrame::GetScriptCallstack() when there is no script stack (e.g., when FFrame::KismetExecutionMessage is called by native code with no BP above in the call stack)
Change 3501457 by Phillip.Kavan
#jira UE-46054 - Fix crash when launching a packaged build that includes a nativized Blueprint instance with a ChildActorComponent instanced via an AddComponent node.
Change summary:
- Removed UK2Node_AddComponent::PostDuplicate(). This eliminates the creation of redundant component templates that were being unnecessarily created during the Blueprint duplication that precedes the nativization pass.
- Modified SMyBlueprint::OnDuplicateAction() to call MakeNewComponentTemplate() in response to a graph duplication action within the same Blueprint context (replaces previous UK2Node_AddComponent::PostDuplicate() impl).
- Modified FEmitDefaultValueHelper::HandleSpecialTypes() to force AddComponent-based CAC-owned template objects in the emitted codegen to use the UDynamicClass as the Outer when instancing. This matches what we already do for SCS-based CAC-owned template objects - that logic was added in CL# 3270456, and this matches up with FBlueprintNativeCodeGenModule::FindReplacedNameAndOuter(), where we specifically handle CAC-owned template objects.
Change 3502741 by Phillip.Kavan
#jira UE-45782 - Fix undo for index pin type changes.
Change summary:
- Modified SGraphPinIndex::OnTypeChanged() to call Modify() on the pin that was changed.
Change 3502939 by Michael.Noland
Back out changelist 3499927
Change 3503087 by Marc.Audy
Re-fixed ocean content as editor had also changed so had to take theirs and redo
#rnx
Change 3503266 by Ben.Zeigler
#jira UE-46335 Fix regression added in 4.16 where AssetRegistry GetAncesorClassNames/GetDerivedClassNames were not working properly in cooked builds for classes not in memory
Change 3503325 by mason.seay
updated Anim BP to prep for pin testing
Change 3503445 by Marc.Audy
Fix crash caused by OldPins being destroyed before rewiring
#rnx
Change 3505024 by Marc.Audy
Fix NodeEffectsPanel blueprint as it was using pins that no longer existed
#rnx
Change 3505254 by Marc.Audy
Don't include orphan pins when gather source property names
If a property doesn't exist for a source property name just skip the property rather than crashing
#jira UE-46345
#rnx
Change 3506125 by Ben.Zeigler
#jira UE-46311 Fix issues when blueprints are reloaded in place, it needs to remove them from root properly and sanitize the old class. It's still not clear why they are being reloaded in place
Change 3506334 by Dan.Oconnor
Move UAnimGraphNode_Base::PreloadRequiredAssets up to K2Node, make sure nodes get a chance to preload data before compilation manager compiles newly loaded blueprints
#jira UE-46411
Change 3506439 by Dan.Oconnor
Return to pre 3488512 behavior for construct object nodes. This means that we can still get warnings on load when users compile after saving a blueprint, but the current behavior loses default values because it's lookng at the skeleton cdo
#jira UE-46308
Change 3506468 by Dan.Oconnor
Return to pre 3488512 behavior, as it causes bad default values
#jira UE-46414
#rnx
Change 3506733 by Marc.Audy
Use the most up to date class to determine whether a property still exists when adding pins during reconstruction
#jira UE-45965
#author Dan.OConnor
#rnx
Change 3507531 by Ben.Zeigler
#jira UE-46449 Better fix to flush the asset registry queue when the editor requests a synchronous scan at startup. Sometimes it can take a few frames because of file handle delays
Change 3507924 by mason.seay
Sanity save of TM-Gameplay and sublevels to maybe resolve level streaming issues
Change 3507962 by Marc.Audy
Remake changes from CL# 3150796 wiped out by WEX-Staging merge to Main in CL# 3479958
#rnx
Change 3509131 by Dan.Oconnor
Compilation manager compile on load flow never called FindExportsInMemoryFirst, which is critical to prevent reloading of UBlueprintGeneratedClasses when Rename clears the export table
#jira UE-46311
Change 3509345 by Marc.Audy
CVar to disable orphan pins if necessary
#rnx
Change 3509959 by Marc.Audy
Protect against crashing due to large values in Timespan From functions
#jira UE-43840
Change 3510040 by Marc.Audy
Remove all the old unneeded ShooterGame test maps
#rnx
[CL 3510073 by Marc Audy in Main branch]
2017-06-26 15:07:18 -04:00
{
AsyncTask - > EnsureCompletion ( ) ;
}
2015-06-10 03:14:50 -04:00
}
INC_FLOAT_STAT_BY ( STAT_RAC_ASyncWaitTime , ( float ) ThisTime ) ;
}
2015-06-29 21:12:06 -04:00
FVoidPtrParam FRuntimeAssetCache : : GetAsynchronousResults ( int32 Handle )
2015-06-10 03:14:50 -04:00
{
2015-06-19 03:13:33 -04:00
FAsyncTask < FRuntimeAssetCacheAsyncWorker > * AsyncTask = nullptr ;
2015-06-10 03:14:50 -04:00
{
FScopeLock ScopeLock ( & SynchronizationObject ) ;
PendingTasks . RemoveAndCopyValue ( Handle , AsyncTask ) ;
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3544039)
#lockdown Nick.Penwarden
#rb none
#rnx
=====================================
MAJOR FEATURES + CHANGES
=====================================
Change 3343905 by Dan.Oconnor
ResolveMember optimizations and moved into cpp. ResolveMember<UFunction> now checks UClass::FuncMap before doing more expensive searches
Change 3346637 by Ben.Zeigler
Actually fix in non editor builds
Change 3355484 by Dan.Oconnor
Back out FMemberReference Optimization
Change 3425833 by Ben.Zeigler
#jira UE-31749 Fix it so Undo works properly when modifying a local variable
#jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value
Change 3510091 by Marc.Audy
Expose on Spawn functional test
#rnx
Change 3510100 by Marc.Audy
Fix spelling error
#rnx
Change 3510132 by Marc.Audy
Fix issues with marking a widget blueprint class as abstract
Change 3510133 by Marc.Audy
Minor code cleanup
#rnx
Change 3510178 by Ben.Zeigler
#jira UE-46500 Fix it so editor-only and transient stuct members are not serialized for literal blueprint structs. It's unsafe to serialize them because they may not exist in the cooked build
Change 3510466 by Ben.Zeigler
Start adding basic ability system tests to enginetest, very minimal so far
Change 3511295 by Marc.Audy
Fix wasted work going weak -> object -> weak -> object
#rnx
Change 3511824 by Marc.Audy
Fix spelling error in tooltip
#jira UE-46515
#rnx
Change 3514446 by Ben.Zeigler
Fix ActorBoundEvent and ComponentBoundEvent to always refresh their event signature from the delegate property they are bound to. This is required to correctly deal with delegate signatures being moved or renamed. Both types now do the fixup one time, in ReconstructNode.
Change 3514578 by Marc.Audy
Move clearing of the actor component need end of frame update mark to base class instead of just primitive component
Change 3514583 by Ben.Zeigler
Better fix to last delegate checkin that also handles moving functions between modules but not renaming
Change 3515325 by Dan.Oconnor
Fix for rare orphan pin false positive, rare exposed on spawn false positive
#rnx
Change 3515761 by Marc.Audy
fix shipping configuration
#rnx
Change 3515772 by Marc.Audy
Fix static analysis warnings
#rnx
Change 3516287 by Marc.Audy
Fix references to instanced components not being updated when resetting component to default
#jira UE-44706
#rnx
Change 3516303 by Marc.Audy
Back out CL# 3516287 while an oddity is investigated
#rnx
Change 3516563 by Marc.Audy
(4.17) Fix references to instanced components not being updated when resetting component to default
#jira UE-44706
Change 3516637 by Phillip.Kavan
#jira UE-44661 - Fix potential crash when changing the ChildActorComponent class default value on a Blueprint that also sets the class in the Construction Script.
Change summary:
- Modified UChildActorComponent::DestroyChildActor() to move the check for PendingKill/Unreachable so that we can also rename a defunct ChildActor instance out of the way in order to allow for a new ChildActor instance w/ the cached name.
Change 3517735 by Marc.Audy
Avoid unnecessary string copy
#rnx
Change 3517931 by Marc.Audy
Small optimization to CleanupActors
Change 3518221 by Dan.Oconnor
Fix rare crash when running ConformImplementedEvents when async loading
#jira UE-45348
Change 3518270 by Ben.Zeigler
#jira UE-46574 Add FCollectionReference type and customization to allow setting an FName to an editor collection
Add AssetCollection to PrimaryAssetLabel that derives the bundled assets from an editor collection
Change 3518271 by Marc.Audy
Get rid of unnecessary construction differentiation if custom reset is being used
Change 3518310 by Ben.Marsh
Re-adding IOS files with correct case.
Change 3518423 by Ben.Zeigler
#jira UE-46574 Initial support for chunk installation in Asset Manager.
Refactor AssetManagerSettings so it copies runtime bools into the asset manager for fast access
Add a concept of a stalled streamable manager handle, handles can be created stalled and will not execute their async load until all needed resources have been acquired externally
Change 3518480 by Marc.Audy
Correctly get the variable reference for an input variable get from the member scope rather than a member variable of the same name on the class
#jira UE-46737
Change 3518498 by Ben.Zeigler
Fix bug with AssetManager where requesting the same load twice in a row before the first one finishes caused the complete callback to get called too early for the second load
Update test map to catch this
Change 3518526 by Ben.Zeigler
IOS Fix
Change 3518619 by Ben.Zeigler
#jira UE-46744 Fix issue where refreshing asset manager editor settings would throw away asset label rules overrides, causing the recursive flag to accidentally get set
Change 3518747 by Phillip.Kavan
#jira UE-43154 - Prevent ConstructGenericObject nodes from compiling if the selected type does not include 'BlueprintType' in its inheritance hierarchy.
Change summary:
- Moved UGameplayStatics::CanSpawnObjectOfClass() into UK2Node_GenericCreateObject as a local util method (per JIRA notes). This was not exposed to Blueprints and as such was inconsistent with the rest of the API.
- Modified UGameplayStatics::SpawnObject() to no longer call CanSpawnObjectOfClass(). This seemed redundant as this will already have been called during node validation at Blueprint compile time.
- Refactored CanSpawnObjectOfClass() into FK2Node_GenericCreateObject_Utils. Walking up the inheritance chain no longer starts out w/ the assumption that 'BlueprintType' is set by default, which was previously including a lot of engine-specific classes into the "allowed" set (e.g. UByteProperty). Also unified the 2 loop iterations that were being used to check for 'BlueprintType'/'NotBlueprintType' and 'DontUseGenericSpawnObjectName', as well as the check for whether or not the class is a derivative of AActor/UActorComponent.
- Modified UK2Node_GenericCreateObject::EarlyValidation() to call FK2Node_GenericCreateObject_Utils::CanSpawnObjectOfClass() and emit a slightly more informative error message to the BP compiler message log.
Change 3518756 by Michael.Noland
(4.17) Framework: Prevent various asserts when USplineComponent methods are called on a spline with no points
Change 3518760 by Michael.Noland
Core: Changed FRuntimeAssetCache ensures to ensureAsRuntimeWarning
Change 3518771 by Michael.Noland
AI: Prevent an ensure in UBlackboardComponent::ClearValue when called on a component with a null BlackboardAsset
Change 3518818 by Michael.Noland
Rendering: Fixed a whitespace issue in UCanvasRenderTarget2D::RepaintCanvas()
#rnx
Change 3518822 by Michael.Noland
Sequencer: Prevented crashes in some methods of UMovieSceneSequencePlayer when there is no Sequence set
Sequencer: Prevented a crash in FMovieSceneRootEvaluationTemplateInstance::Evaluate when the instance has no template set
Change 3518824 by Michael.Noland
Landscape: Marked ULandscapeComponent and ULandscapeHeightfieldCollisionComponent as Within=LandscapeProxy, since they do CastChecked on their Outer all the time
Change 3519073 by Michael.Noland
QAGame: Fixed a crash in UQASynth::PlaySynth() if called on a directly created instance rather than using the factory method
Change 3519076 by Michael.Noland
Preventing crashes in UAutomationPerformaceHelper (sic) when spawned abnormally for fuzzing (assumes that the outer will have a route to a world)
#rnx
Change 3519079 by Michael.Noland
Sequencer: Fixed a potential crash in UMediaPlaylist::Insert and UMediaPlaylist::RemoveAt when passed an invalid index
Change 3519081 by Michael.Noland
Blueprints: Added support for creating appropriate outers for objects that must be nested within another class during fuzzing (ones that specify Within=, other relationships aren't knowable yet)
Change 3519082 by Michael.Noland
VR: Prevent a crash in UMRMeshComponent::ConnectReconstructor when passed a null reconstructor
Change 3519084 by Michael.Noland
Rendering: Prevent crashes when UNiagaraComponent::GetEffectDataInterface is called on a component with no effect asset set
Change 3521889 by Michael.Noland
Sequencer: Prevented a bogus static analysis warning by reworking the code (FixedFrameInterval could have only been set if the pointer were valid from the line above)
#rnx
Change 3521987 by Michael.Noland
Animation: Prevent a couple of potential asserts in UControlRig::GetOrAllocateSubControlRig
Change 3522101 by Michael.Noland
Physics: Improved the comment on UPhysicalMaterial::Friction
#rn
Change 3522105 by Michael.Noland
Physics: Fixed a few crashes in UVehicleWheel when spawned directly
Change 3522106 by Michael.Noland
Framework: Marked ULevelStreaming as Within=World, since it does CastChecked on the Outer all the time
Change 3522109 by Michael.Noland
Animation: Marked UAnimInstance as Within=SkeletalMeshComponent since it assumes the outer in various places
Change 3522121 by Michael.Noland
Mobile: Prevent UMobileInstalledContent methods from crashing when called on a created instance in an uncooked build (no installed manifest)
Change 3522783 by Zak.Middleton
#ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before).
Change 3525477 by Dan.Oconnor
Remove Tooltip, Category, and HideCategories tooltip from the blueprint generated class if source data is cleared
Change 3526538 by Ben.Zeigler
Refresh primary asset labels if their bundles are different at all and not just if they're added or removed. This is required because they now work based on collections or directories. This fixes issue with the onboarding collection changes not correctly modifying chunks
Copy of CL #3526501
Change 3526817 by Ben.Zeigler
#jira UE-46917 Fix issue where maps that do not contain level script blueprints were being counted as unindexed for find in blueprints. The old behavior depended on detecting the existence of empty tags, but the asset registry now filters those out so treat maps with no FiB data as indexed
Change 3526873 by Ben.Zeigler
#jira UE-46627 Change it so blueprint or native subclasses of static mesh actor cannot be added to clusters, as they are not likely to be immutable the way the base class is
Add code to to the ubergraph frame to fall back to hard reference serialization if the reference collector doesn't support weak references, such as the cluster collector
Change 3526958 by Marc.Audy
(4.17) Don't copy and then break pin links when reconstructing. Instead simply move.
#jira UE-46935
Change 3528916 by Marc.Audy
PR #3609: Adds GetKeysForAxis() to complement GetKeysForAction() in UPlayerInput (Contributed by alanedwardes)
#jira UE-45347
Change 3529080 by mason.seay
BP asset for undetermined type bug
Change 3529381 by Marc.Audy
Fix ability to insert duplicates in to a set or map
Change 3529471 by Dan.Oconnor
Fix for clang 4.0 error: definition of builtin function '__rdtsc' inline unsigned long long __rdtsc()
Change 3530876 by Marc.Audy
Based on PR #3457: Add MakeSet BP node (Contributed by projectgheist)
Also refactored MakeArray/Set to share a base MakeContainer class
Cleaned up some dead code from MakeArray
Added icon for MakeSet
Added Functional Test for MakeSet
#jira UE-43717
Change 3531070 by Phillip.Kavan
#jira UE-46866 - Fix crash on load when an external variable member reference's owning type cannot be loaded.
Change summary:
- Modified FBlueprintEditorUtils::GetSkeletonClass() to check for NULL before attempting to check for the generating BP.
Change 3531081 by Marc.Audy
Remove deprecated CustomMapParamValue code
Change 3531094 by Phillip.Kavan
#jira UE-46952 - Fix a packaging code build failure that will occur with a nativized Blueprint class that contains a UInterfaceProperty.
Change summary:
- Modified TScriptInterface::operator=() to cast the given 'SourceObject' instance to the 'InterfaceType' type before assigning to 'SourceInterface'. This was necessary because if the caller (in this case nativized codegen) passes in a UObject* that does not explicitly inherit from 'InterfaceType', then it will need to go through the object's GetInterfaceAddress() API instead and cast the result back to an 'InterfaceType' pointer.
Change 3531186 by Phillip.Kavan
Back out changelist 3531094 (temp CIS fix).
#rnx
Change 3532082 by Marc.Audy
Move garbage collection timers and other management to UEngine instead of UWorld
Fixes CollectGarbage blueprint node not working in shipping
#jira UE-46566
Change 3532134 by Phillip.Kavan
Restored changelist 3531094 w/ fix for non-unity.
- Mirrored from //UE4/Release-4.17 (CL# 3531232).
#rnx
Change 3533009 by Marc.Audy
Fixup missing function and deprecation warnings
Change 3534056 by Marc.Audy
(4.17) Fix expose on spawn of map and sets to work
#jira UE-47140
Change 3534761 by Marc.Audy
(4.17) Apply code review changes to Dev-Framework as well
#rnx
Change 3535147 by Dan.Oconnor
Build fix, already made in 4.17
#rnx
Change 3535530 by mason.seay
Resaving to remove error when opening level blueprint
Change 3535581 by Marc.Audy
Class Properties are only identical if they are literally the same object. Do not consider the deep compare port flags as object property base does.
#jira UE-46533
Change 3535583 by Marc.Audy
When properties are imported in to a child actor component the cached instance data is invalidated, so clear it.
#jira UE-46533
Change 3535617 by Marc.Audy
PR #3788: UE-39237: Prevent (im-)pure casting during BP debugging (Contributed by projectgheist)
#jira UE-47188
#jira UE-39237
Change 3535671 by Marc.Audy
Change NodeFactory to look at interface to use sequence node instead of each node having to add itself
Change 3535955 by Marc.Audy
Prevent MakeSet from removing split pins
Change 3536114 by Michael.Noland
Paper2D: Removing deprecated code from 4.3/4.4 era
#rnx
Change 3536120 by Michael.Noland
Animation: Removed deprecated FTAlphaBlend class and AlphaBlendType.h header
Change 3536124 by Michael.Noland
Physics: Removed deprecated methods that were replaced by _AssumesLocked variations
Change 3536131 by Michael.Noland
Slate: Converting remaining uses of EKeyboardFocusCause to EFocusCause and properly deprecating it
Change 3536138 by Michael.Noland
Slate: Removed any deprecated code older than 4.10 that didn't affect content compatibility
Change 3536167 by Dan.Oconnor
When a client provides a skeleton class as the self scope, make sure we also use a skel class for non-self scopes - but only if using the compilation manager. Skel classes are not reliably up to date when not using the compilation manager
#jira UE-46904
Change 3536221 by Michael.Noland
Editor: Removing deprecated code from 4.9 or earlier
Change 3536240 by Michael.Noland
Blueprints: Removed long-deprecated TypeToString method from the K2 schema
#rnx
Change 3536243 by Michael.Noland
AI: Prevent crashes if UMockTask_Log is created manually rather than via the CreateTask factory method
Change 3536244 by Michael.Noland
Core: Prevent FScopedExternalProfilerBase::StopScopedTimer() from asserting if called an unmatched number of times with StartScopedTimer, as both are exposed to BPs now
Change 3536250 by Michael.Noland
CoreUObject: Removed any deprecated code older than 4.10 that didn't affect content compatibility
Change 3536253 by Michael.Noland
Core: Removed any deprecated code older than 4.10 that didn't affect content compatibility
Change 3536310 by Michael.Noland
Engine: Removed any deprecated code older than 4.10 that didn't affect content compatibility
Change 3536397 by Mieszko.Zielinski
Fixed UCrowdFollowingComponent::UpdateCachedDirections crashing when CharacterMovement is not set #UE4
#jira UE-46860
Change 3536404 by Michael.Noland
Platform: Added a warning for others when they try to remove this 'deprecated' method
Change 3536639 by Michael.Noland
CharacterMovement: Changed the name of a variable introduced in CL# 3536397 to better match intent
#rnx
Change 3536893 by Michael.Noland
Blueprints: Clear the stale value on the value pin when a map find node fails to find an item
#jira UE-47233
Change 3536902 by Michael.Noland
Framework: Killed a couple of more deprecated methods that were not exposed to Blueprints
#rnx
Change 3537038 by Ben.Marsh
Fixing case of iOS directories, pt1
Change 3537039 by Ben.Marsh
Fixing case of iOS directories, pt2
Change 3538246 by Michael.Noland
UnrealTournament: Fixing issues with renamed enum
#rnx
Change 3538618 by Ben.Zeigler
Fix ensure when closing sequencer transform UI
Change 3540213 by Ben.Zeigler
#jira UE-47313 Fix crash serializing a MapProperty where the value type has changed for a type that implements ConvertFromType. The address passed to ConvertFromType needs to be the container root, not the specific value address, keys worked because the offset was 0.
Change 3540253 by Marc.Audy
Only copy default values for input pins as output pins do not have them
#rnx
Change 3540376 by Marc.Audy
Add utility FromPinType for FEdGraphTerminalType
#rnx
Change 3540433 by Marc.Audy
Add MakeMap
#jira UE-47093
Unify IsConnectionDisallowed for containers and fix static analysis warning
#jira UE-47291
Change 3540585 by Phillip.Kavan
#jira UE-47117 - Fix crash on launch of a nativized build that includes an instanced default subobject that's referenced by another instanced default subobject.
Change summary:
- Modified FEmitDefaultValueHelper::HandleSpecialTypes() to only direct HandleInstancedSubobject() to emit code to create the instanced subobject if it's not a default subobject. This was previously being incorrectly interpreted as an object having the 'RF_ArchetypeObject' flag set; however, default subobjects will also have that flag set in addition to the 'RF_DefaultSubobject' flag.
- Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert in the 'GetDefaultSubobjectByName' case if the given object is not also a default subobject.
Change 3541147 by Dan.Oconnor
Fix for not being able to override custom events when using the compilation manager post 3536167
#jira UE-47292
#rnx
Change 3541177 by Ben.Zeigler
#jira UE-46595, UE-46553 Fix issue where creating a widget template could cause a widget blueprint being cooked to have the wrong package flags, making it appear to be an uncooked package
Copy of CL #3541027
Change 3541325 by Dan.Oconnor
K2node data table data needs to preload data before the compilation queue is flushed
#rnx
#jira UE-47319
Change 3541409 by Michael.Noland
Blueprints: Added code to reapply any active breakpoints after recompilation when using the BP compilation manager
#jira UE-47322
[reimplementing CL# 3541404 in Dev-Framework]
Change 3541418 by Dan.Oconnor
Fix for bad SKEL_ CDO reference in blueprint bytecode
#jira UE-47265
#rnx
Change 3541482 by Dan.Oconnor
Blanket fix up of preload calls that are being done in AllocateDefaultPins. AllocatDefaultPins is not called until compile, meaning if these preload calls load blueprints they will be loaded while the compilation manager is compiling blueprints
#rnx
#jira UE-47319
Change 3541817 by Marc.Audy
Fix static analysis warnings
#rnx
Change 3542299 by Michael.Noland
Blueprints: Speculative fix for static analysis warning
#rnx
Change 3542406 by Marc.Audy
Use a check slow to avoid any cost
#rnx
Change 3542486 by Michael.Noland
Asset Manager: Removing an unnecessary ensure (it's a potentially expected case)
#jira UE-47380
Change 3542659 by Michael.Noland
Blueprints: Clear out null entries in the LastEditedDocuments list during PostLoad() and remove entries when a graph is being deleted to prevent their generation in the first place
#jira UE-47385
Change 3543620 by Dan.Oconnor
Remove overzealous ensure - we may recompile blueprints that are asynchronously loading when a user triggers a synchronous compile
#jira UE-47415
#rnx
Change 3518415 by Ben.Zeigler
#jira UE-46574 Deprecate IPlatformChunkInstall::SetChunkInstallDelgate as it was spelled wrong, was only half implemented, and did not support success vs failure
Replace with AddChunkInstallDelegate, which supports a bool error code and is bound once instead of separately for each chunk. All implementations support this delegate at a basic level, although several could be improved to call the failure delegate in more cases
Change 3534339 by Michael.Noland
Platforms: Changed DEPRECATED() macro description to use 4.xx rather than a speciifc version in examples, so it doesn't show up when removing deprecated code
[CL 3544050 by Marc Audy in Main branch]
2017-07-19 09:49:59 -04:00
if ( ensureAsRuntimeWarning ( AsyncTask ) )
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3510040)
#lockdown Nick.Penwarden
=====================================
MAJOR FEATURES + CHANGES
=====================================
Change 3459524 by Marc.Audy
Get/Set of properties that were previously BPRW/BPRO should error when used
#jira UE-20993
Change 3460004 by Phillip.Kavan
#jira UE-45171 - Fix C++ compilation failures during packaging caused by nativizing a Blueprint that overrides a native function with a 'TSubclassOf' parameter or return value.
Change summary:
- Modified FKismetCompilerContext::CreateParametersForFunction() to pass the 'CPF_UObjectWrapper' flag through to new function parameter properties during Blueprint compilation.
Change 3461210 by Phillip.Kavan
#jira UE-44505 - Fix occasional Blueprint editor crashes that could occur while rebuilding the context menu from the action registry.
Change summary:
- Modified FBlueprintActionDatabase::FActionRegistry to use an FObjectKey as the key type. This allows us to test entries for UObject validity before rebuilding context menu items based on the action database.
- Changed FBlueprintActionInfo::CachedOwnerClass to be a TWeakObjectPtr rather than a raw UClass* since it's based on the ActionOwner, which could potentially become invalid after the OwnerClass has been cached.
- Modified FBlueprintActionDatabase::RefreshAssetActions() to exclude World assets if the WorldType is not EWorldType::Editor. This eliminates an issue with unreferenced "inactive" GC'd world objects being left in the BP action registry after cooking, at which point the keys could become invalid.
- Added FBlueprintActionDatabase::DeferredRemoveEntry() to allow for scheduling removal of entries from outside of the database if they are known to be invalid.
- Modified FBlueprintActionDatabase::Tick() to handle deferred entry removals.
- Modified FBlueprintActionMenuBuilder::RebuildActionList() to both test actions for validity before building menu items and schedule removal of invalid actions on the next tick.
Notes:
- Alternatively we could just include UObject keys in the database's AddReferencedObject impl, but that would then prevent objects from ever being GC'd if they are not explicitly removed. For most entries the action database takes the approach of explicitly removing entries via delegate when the UObject is destroyed, so I chose to use a TWeakObjectPtr instead so that any entries that may not be getting explicitly removed via delegate will now simply become invalidated if the UObject key is GC'd due to not being referenced. I also set it up to clean and remove any entries (along with any associated node spawners) that are found to be invalid the next time we open the BP editor.
Change 3461373 by Lukasz.Furman
fixed async navmesh rebuilds not kicking in for requests from navdata.bForceRebuildOnLoad
#jira UE-44231
Change 3461409 by Lukasz.Furman
fixed reenabling automatic navmesh generation in Editor Preferences
#ue4
Change 3461550 by Ben.Zeigler
#jira UE-45328 Fix local variable support for Redirectors and other save-time validation. We need to run the local variables to UProperty and back at save time
Add new flag PPF_SerializedAsImportText which is used for BP pins/default values and indicates that something has been serialized as import text and so needs to handle string asset redirectors
Change 3462625 by Zak.Middleton
#ue4 - Fix InterpToMovementComponent not setting velocity on the object it moves. Fix movement rate when substepping enabled (other related fixes to come).
github PR #3620
Change 3462796 by Dan.Oconnor
Fix for spamming BroadcastBlueprintReinstanced and for creating CDO at wrong time when compiling FrontEnd.uasset in OrionGame
#jira UE-45434
Change 3462995 by Ben.Zeigler
#jira UE-16941 Fix it so Load Asset node works with a literal value as well as a connected pin
Change 3463099 by Ben.Zeigler
#jira UE-45471 Allow abstract base classes for primary assets
Change 3464809 by Marc.Audy
Expose FVector2D / FVector2D to blueprints
#jira UE-45427
Change 3467254 by Mieszko.Zielinski
Added an AI helper BP function that supplies caller with a copy of navigation path given controller is currently following #UE4
Change 3467644 by Dan.Oconnor
Fix for cook issues in ocean when using compilation manager, one issue caused by bad dependencies list, one issue caused by lack of subobject mapping in archetype reinstancing.
#jira UE-45443, UE-45444
Change 3468176 by Dan.Oconnor
Fix dependent blueprints being marked dirty when a blueprint is compiled
Change 3468353 by Michael.Noland
UnrealHeaderTool: Improved the warning generated when missing Category= on a function or property declared in an engine module, and centralized the logic that determines if the module is engine or game
Change 3470532 by Dan.Oconnor
Re-enable compilation manager
Change 3470572 by Dan.Oconnor
Fix for pin paramters resetting when an archetype was reinstanced
#jira UE-45619
#rnx
Change 3471949 by Mason.Seay
Adding Primary Assets for testing
Change 3472074 by Ben.Zeigler
#jira UE-45140 Convert iterative cooking to use the Asset Registry as it's only mode, remove old hash and timestamp versions. This allows deleting the entire PackageDependencyInfo module
Change the asset registry iteration to not compute a hash at all, and instead store the script package guids in it's cache.
Expose bIgnoreIniSettingsOutOfDateForIteration and bIgnoreScriptPackagesOutOfDateForIteration in cooker settings, affects rather to listen to ini/script changes when doing iterative cooking
Change 3472079 by Ben.Zeigler
With new incremental cook options, change Fortnite to never care about ini settings, but do care about code changes. This can be changed but from previous discussions we wanted to be more safe than fast here
Change 3473429 by Lukasz.Furman
changed path following update tick to allow working on "invalid, update pending" paths, solves AI getting stuck when navigation is rebuild very frequently (e.g. every tick from moving mesh)
#jira UE-41884
Change 3473476 by Lukasz.Furman
changed crowd simulation path update tick to allow working on "invalid, update pending" paths, solves AI getting stuck when navigation is rebuild very frequently (e.g. every tick from moving mesh)
#jira UE-41884
Change 3473663 by Ben.Zeigler
Fix it so base k2node registers framework version, this is needed for the assetptr fixup I previously added
Change 3473679 by Mason.Seay
Slight cleanup of test map and added ability to teleport across level for easy navigation
Change 3473712 by Marc.Audy
Do default value validation against the actual value of the default entry of an enum rather than the serialized empty autogenerated default value
Change 3474055 by Marc.Audy
When nodes are reconstructed any pins that were previously linked or set to non-default values that have been removed will no longer simply vanish, but instead will remain in an Orphaned state until dealt with.
#jira UE-41828
Change 3474119 by mason.seay
Tweaked Force Feedback test
Change 3474156 by Marc.Audy
Actually enable orphan pin retention
Change 3474382 by Ben.Zeigler
Class.h Header and comment cleanup. Started this because IsChildOf did not have a comment and it's usage is a bit confusing
Change 3474386 by Ben.Zeigler
Close popup window when adding asset class to audit window
Change 3474491 by Ben.Zeigler
Remove ability for Worlds to not be saved as assets, this has been the default since 2014.
Change 3475363 by Marc.Audy
Alt-click now works with orphaned pins
#jira UE-45699
Change 3475523 by Marc.Audy
Fixup Fortnite and Paragon content for orphaned pin errors and warnings
Change 3475623 by Phillip.Kavan
#jira UE-45477 - Fix an EDL assertion on load in a nativized build with one or more Actor subobjects instanced via the EditInlineNew UI in the BP class defaults property editor.
Change summary:
- Modified FEmitDefaultValueHelper::OuterGenerate() to emit code to construct/initialize instanced subobject values that do not have the RF_DefaultSubObject flag set, and also to recursively handle nested subobjects for those values.
- Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to alternatively emit a 'NewObject' assignment statement rather than a 'CreateDefaultSubobject' statement if only RF_ArchetypeObject is set on the source object value.
Change 3476008 by Dan.Oconnor
Fix for failing to preload our super class's subobjects. Effectively moving UBlueprint::ForceLoad calls earlier in loading process. This only results in data resetting to your parent's parent's default value from your parent's default value.
#jira UE-18765
Change 3476115 by Dan.Oconnor
Fix missing category information for inherited functions when using compilation manager
#jira UE-45660
#rnx
Change 3476577 by Lukasz.Furman
added early outs from navmesh layer generation when there's no walkable cells or contours to avoid allocating 0 bytes by next generation steps (behavior differs between platforms)
#ue4
Change 3476587 by Phillip.Kavan
#jira UE-45517 - Fix a regression in which dragging UMG widgets around in the designer view results in redundantly-compounded BP class properties and context menu actions.
Change summary:
- Modified SDesignerView::ClearDropPreviews() to move the widget that was removed from the tree into the transient package. This ensures that FWidgetBlueprintCompiler::CreateClassVariablesFromBlueprint() won't pick them up.
- Modified SDesignerView::ProcessDropAndAddWidget() to also consider any widgets not added to the 'DropPreviews' array as being transient (i.e. also move them into the transient package since they were not added to the tree).
Notes:
- The regression was introduced by the changes in CL# 3410168, and was merged to Main at CL# 3431398.
#rnx
Change 3476723 by Dan.Oconnor
Match old behavior wrt updating implemented interfaces in blueprints - this logic from FKismetEditorUtilities::CompileBlueprint was missing in compilation manager
#jira UE-45468
#rnx
Change 3476948 by Michael.Noland
Framework: Changed AActor::FindComponentByClass (and AActor::GetComponentByClass by extension) to return nullptr when passed a nullptr class, rather than crashing
Change 3476970 by Ben.Zeigler
Fix bug I introduced in 4.16 where assigning assets to multiple chunks did not work properly
Change 3477536 by Marc.Audy
Don't display default value box on linked orphaned input pins
Change 3477835 by Marc.Audy
Fix pins orphaned by deletion of an entry in a user-defined enum disappearing instead of remaining connected
#jira UE-45754
Change 3478027 by Marc.Audy
Minor performance optimization
#rnx
Change 3478198 by Phillip.Kavan
#jira UE-42431 - Remove an unnecessary ensure() when pasting an event node.
Change summary:
- Modified UEdGraphSchema_K2::CreateSubstituteNode() to no longer ensure() that we have a valid PreExistingNode; it's only used for logging when a substitute node is created in response to a conflict with an existing node.
Change 3478485 by Marc.Audy
Eliminate extraneous error messages about orphaned pins on get/set nodes
#jira UE-45749
#rnx
Change 3478756 by Marc.Audy
Fix fallout from changes to DoesDefaultValueMatchAutogenerated for user defined enums
#jira UE-45721
#rnx
Change 3478926 by Marc.Audy
Non-blueprint type structs can no longer be made/broken
Non-blueprint visible properties in structs will no longer have pins created for them
#jira UE-43122
Change 3478988 by Marc.Audy
DeltaTime for a tick function with a tick interval is now correct after disabling and then reenabling the tick function.
#jira UE-45524
Change 3479818 by Marc.Audy
Allow ctrl-drag off of orphan pins
#jira UE-45803
Change 3480214 by Marc.Audy
Modifications to user defined enumerations are now transacted
#jira UE-43866
Change 3480579 by Marc.Audy
Maintain all pin properties through transactions.
#rn Reference pins that are removed and then restored via undo now correctly have the diamond icon instead of the standard circle.
Change 3481043 by Marc.Audy
Make/Break of structs does not depend on having blueprint exposed properties.
Splitting of a struct pin still requires blueprint exposed properties.
#jira UE-45840
#jira UE-45831
Change 3481271 by Ben.Zeigler
Fix the AssetManager chunking code to use ChunkDependencyInfo instead of a hardcoded check for chunk 0
Clean up ChunkDependencyInfo and make it properly public
Move ShouldSetManager to be WITH_EDITOR
Ported from WEX branch
#RB peter.sauerbrei
Change 3481373 by Dan.Oconnor
Reduce reliance on expensive FindDelegateSignature. 3275922 made warnings about a ambiguous search more likely as it preserved names of members on the REINST_ classes
#jira UE-45704
Change 3481380 by Ben.Zeigler
Change it so Struct and Object AssetRegistrySearchable properties do not show up in content browser, they are not helpful
Change 3482362 by Marc.Audy
Fix properties not exposed to blueprint warnings for input properties on function graphs.
#jira UE-45824
Change 3482406 by Ben.Zeigler
#jira UE-45883 Fix Switch On Gameplay Tag Container node, and add switch nodes to TagCheck map
Change 3482498 by Ben.Zeigler
Attempt to fix hot reload issues with Asset Manager. We need to reset and re-acquire the asset classes when rescanning, as they may be pointing to the replaced class
Change 3482517 by Lukasz.Furman
fixed smart navlink update functions removing important flag
#jira UE-45875
Change 3482538 by Marc.Audy
When comparing float, vector, and rotator values for whether the the default matches the autogenerated do not use the string compare because differences in use of decimal or number of 0s after decimal are then considered not the same float
#jira UE-45846
Change 3482773 by Marc.Audy
Don't show default value or pass by reference for exec pins
#jira UE-45868
Change 3482791 by Ben.Zeigler
#jira UE-45800 Correctly dirty game mode blueprint when changing player controller/etc classes from game mode customization
Fix it so MarkBlueprintAsStructurallyModified calls MarkBlueprintAsModified as several fixes were only in the second function
Change 3483131 by Zak.Middleton
#ue4 - InterpToMovementComponent:
- Fix velocity not zeroed when interpolation stops.
- Various fixes when calculating velocity and time when substepping is enabled.
- Improve accuracy of interpolation when looping and there is time remaining after the loop event is hit. Consume the remainder of the time after the event back in the loop (similar to handling a blocking impact).
#jira UE-45690
Change 3483146 by Phillip.Kavan
#jira UE-38358 - Propagate 'const' function flag from interface Blueprint to implementing Blueprints.
Change summary:
- Modified FBlueprintEditorUtils::MarkBlueprintAsStructurallyModified() to call SkeletalRecompileChildren() on dependent BPs when the target is an interface BP.
- Modified FBlueprintEditorUtils::MarkBlueprintAsStructurallyModified::FRefreshHelper::SkeletalRecompileChildren() to set child BP status to BS_Dirty after compiling.
- Modified ConformInterfaceByName() (FBlueprintEditorUtils) to use the interface's skeleton class for function iteration as well as to match the Function Entry node's 'const' setting to the interface UFunction's signature.
Change 3483340 by Ben.Zeigler
Fix issue querying asset registry after a hot reload, make sure pending kill objects are never considered to be Assets
Change 3483548 by Michael.Noland
Epic Friday: Playing around with some prototype traps
Change 3483700 by Phillip.Kavan
Fix CIS cook crash introduced by last submit.
#rnx
Change 3485217 by Ben.Zeigler
#jira UE-45519 Fix regression introduced in 4.16 where it would no longer cook all maps when no explicit maps were specified in ini or game callback. Moved the code that detects changes before culture/default map code and hardened it to deal with the case where some engine packages were already in the list before it entered the function
Change 3485367 by Dan.Oconnor
Avoid adding mappings to anim node when creating variables on the skeleton class and using the compilation manager
#jira UE-45756
Change 3485565 by Ben.Zeigler
#jira UE-45948 Fix compilation manager to properly reset variable default values after promoting a pin to local variable
Change 3485566 by Marc.Audy
Fix crashes caused by undo/redo of user defined struct changes
#jira UE-45775
#jira UE-45781
Change 3485805 by Michael.Noland
PR #3459: Fix for world origin shifting and SpringArmComponent location lag (Contributed by michail-nikolaev)
#jira UE-43747
Change 3485807 by Michael.Noland
PR #3485: Added additional textures field to paper 2d tileset class (Contributed by gryphonmyers)
#jira UE-44041
Change 3485811 by Michael.Noland
Framework: Fixed a bug in FStreamLevelAction::MakeSafeLevelName to avoid appending the PIE prefix multiple times (fixes functions like Unload Streaming Level when passed a full package name from an instanced streaming level)
Change 3485829 by Michael.Noland
Framework: Made GetWorldAssetPackageFName BlueprintCallable so instanced levels can be unloaded
Change 3485830 by Michael.Noland
PR #3568: add API declarations to ALevelStreamingVolume methods (Contributed by kayama-shift)
#jira UE-45002
Change 3486039 by Michael.Noland
PR #3495: UE-44014: Refreshing node error fixes (Contributed by projectgheist)
- Empty out the ErrorMsg when a node gets refreshed to prevent the same error messages from compounding
- Added support for split pins in UK2Node_Event::IsFunctionEntryCompatible
- Added a missing check for the delegate pin name on the entry node part of UK2Node_Event::IsFunctionEntryCompatible
#jira UE-44014
Change 3486093 by Michael.Noland
PR #3379: Added GAMEPLAYABILITIES_API to all Ability Tasks. (Contributed by ryanjon2040)
#jira UE-42903
Change 3486139 by Michael.Noland
Blueprints: Added new config options for execution wire thickness when not debugging (DefaultExecutionWireThickness) and data wire thicknesses (DefaultDataWireThickness) to the Graph Editor Settings page
#rn
Change 3486154 by Michael.Noland
Framework: Speculative fix for CIS error about FStructOnScope
#rnx
Change 3486180 by Dan.Oconnor
Better match old logic for determining when to skip data only compile
#jira UE-45830
Change 3487276 by Marc.Audy
Fix crash when using Setter with a locally scoped variable
#rnx
Change 3487278 by Marc.Audy
Ensure that pin change notifications occur on all pin breaks unless it is part of a node being garbage collected
Change 3487658 by Marc.Audy
Ensure that child actor template is created for subclasses
#jira UE-45985
Change 3487699 by Marc.Audy
Move non-templated elements out of FArchiveReplaceObjectRef and put them in FArchiveReplaceObjectRefBase
Change 3487813 by Dan.Oconnor
Asset demonstrating a crash
Change 3488101 by Marc.Audy
Fix crash with spawn/construct actor/object from class nodes when they no longer had any pins.
Correctly orphan pins when a node goes to 0 pins.
Change 3488337 by Marc.Audy
Editable pin base should not manually remove pin and let reconstruct node and rewire pins do their job
#jira UE-46020
Change 3488512 by Dan.Oconnor
ConstructObject nodes and SubInstances nodes use skeleton class when compilation manager can provide it
#jira UE-45830, UE-45965
#rnx
Change 3488631 by Michael.Noland
Framework: Fixed a crash when loading a blueprint with a parent class of ALevelBounds caused by trying to register the class default object with a non-existent level
#jira UE-45630
Change 3488665 by Michael.Noland
Blueprints: Improve the details panel customization for optional pin nodes like Struct Member Get/Set
- The category, raw name, and tooltip of the property are now included as part of the filter text as well
- The property tooltip is now displayed when hovering over the property name
- Code updated to use GET_MEMBER_NAME_CHECKED() where appropriate
Change 3489324 by Marc.Audy
Fix recursion causing stack crash
#jira UE-46038
#rnx
Change 3489326 by Marc.Audy
Fix cooking crash
#jira UE-46031
#rnx
Change 3489687 by mason.seay
Assets for testing orphan pins
Change 3489701 by Marc.Audy
Back out changelist 3487278 and 3489443 and make targetted changes for fixing up orphan pin cases where changing connections doesn't remove the pin.
#jira UE-46051
#jira UE-46052
#rnx
Change 3490352 by Dan.Oconnor
Fix for missing WidgetTree on Skeleton class - just look directly at the WidgetBlueprint
#jira UE-46062
Change 3490814 by Marc.Audy
Make callfunction/macro instances save all pins in orphan state more similar to previous behavior
#rnx
Change 3491022 by Dan.Oconnor
Properly clean up 'Key' property when we fail to create a value property
#jira UE-45279
Change 3491071 by Ben.Zeigler
#jira UE-45981 Fix rotation issues, vector/rotator pins with empty strings were not matching due to uninitialized memory.
Change 3491244 by Michael.Noland
Blueprints: Add compile time message back to the output log (will not auto-open the output log if there were no warnings/errors)
#jira UE-32948
Change 3491276 by Michael.Noland
Blueprints: Fixed some bugs where a newly added item would fail show up in the "My Blueprints" tree if there was a filter active (e.g., when promoting a variable)
- Centralized the logic for clearing the filter so it happens when we try and fail to select the item, rather than ad hoc in various other places
- Made it only clear the filter if necessary, rather than (almost) always clearing it when adding an item
#jira UE-43372
Change 3491562 by Marc.Audy
Put back pin removal in to editable pin base and instead modify the pin destroy implementation to take down child split pins with it
#jira UE-46020
#rnx
Change 3491658 by Marc.Audy
Unify RemoveUserDefinedPin implementations. Use version that has break to avoid size change assert
#rnx
Change 3491946 by Marc.Audy
ReconstructSinglePin no longer destroys OldPin (avoids oprhaned sub pins being destroyed before reparented)
RewireOldPinsToNewPins now destroys OldPins at the end (calling code no longer reponsible)
DestroyImpl now prunes out SubPins that had already been trashed
#rnx
Change 3492040 by Marc.Audy
Discard exec/then pins from a callfunction that has been converted to a pure node
#rnx
Change 3492200 by Zak.Middleton
#ue4 - Always reset the input array in AActor::GetComponents(), but do so without affecting allocated size.
Fixes possible regression from CL 3359561 that removed the Reset(...) entirely.
#jira UE-46012
Change 3492290 by Ben.Zeigler
#jira UE-46108 Fix StringLibrary Mid to never crash, Substring had already been fixed
Change 3492311 by Marc.Audy
Don't clear the pin type if what you're connecting to's pin type is wildcard
#rnx
Change 3492680 by Dan.Oconnor
Handle missing generated class when using compilation manager - tested by forcing compile of BP_ParentClassIsMissingType.uasset
Change 3492826 by Marc.Audy
Don't do pin connection list change notifications from DestroyPins while regenerating on load
#jira UE-46112
#rnx
Change 3492851 by Michael.Noland
Core: Fixed various crashes when using UObject::CallFunctionByNameWithArguments with non-trivial argument types by properly initializing the allocated parameters
Change 3492852 by Michael.Noland
Framework: Fixed a crash if ACharacter::FindComponentByClass was passed a nullptr class
Change 3492934 by Marc.Audy
Fix ensure and crash delete macro containing orphaned pin
#rnx
Change 3493079 by Dan.Oconnor
Fix for crash when opening ThirdPersonAnimBlueprint and ThirdPersonAnimBlueprint_Perf then clicking 'Compile' button in ThirdPersonAnimBlueprint editor. Make sure the convenience members in the derived compilers get set when we relink child classes (which requires making cdos, which requires PropagateValuesToCDO..)
#rnx
Change 3493346 by Phillip.Kavan
#jira UE-40560 - Fix a reported crash when pasting nodes between unrelated Blueprint graphs.
Change summary:
- Modified FEdGraphUtilities::PostProcessPastedNodes() to ensure() on a NULL pin entry; this will allow execution to continue while still alerting us since it is an unexpected result. Also added an 'else' case to then remove the NULL entry so that PostPasteNode() implementations don't all have to guard against NULL pin entries. When the node is reconstructed, the NULL entry will be replaced with the correct pin initialized to its default values.
- Modified UEdGraphPin::ImportTextItem() to add some additional logging to parse error cases when importing pin properties from source T3D text. Hopefully this gives us more information when this is encountered in the future.
Change 3493938 by Michael.Noland
Blueprints: Prevent issues with renaming event dispatchers to contain periods (this may be disallowed in the future, but they no longer become uneditable)
#jira UE-45780
Change 3493945 by Michael.Noland
Blueprints: Fixed GetDelegatePoperty typos
#rnx
Change 3493997 by Michael.Noland
Blueprints: Partially reverting changes from CL# 3319966 to reroute nodes, restoring their alignment but losing the symmetrical grab handle changes
#jira UE-45760
Change 3493998 by Dan.Oconnor
Fix rare crash in RefreshStandAloneDefaultsEditor when the blueprint editor is opened and a blueprint had errors in it
Note: I stumbled across this by running a unit test and then opening a blueprint in the BPE. CrashReporter indicates 3 crashes in the last 3 days
Change 3494025 by Michael.Noland
Engine: Deleted some dead code (DEBUGGING_VIEWPORT_SIZES)
#rnx
Change 3494026 by Michael.Noland
Blueprints: V0 of a BlueprintCallable/BlueprintPure function fuzzer
- Calls exposed methods with default parameters on classes it is able to spawn for now, which catches crashes due to null and /0 but not out of bounds issues or ones on classes it can't spawn due to classwithin, abstract, etc...
- Can be called using Test.ScriptFuzzing, won't be integrated into automated tests until it is more fully fleshed out and all known issues are addressed
#rnx
Change 3496382 by Ben.Zeigler
Fix ensure when launching editor with cook on the side and incremental cooking enabled. It now flushes the background asset gather when calling the sync load all assets if one is in progress
Change 3496688 by Marc.Audy
Avoid crashing in component instance data if (for some reason) the Actor's root component isn't properly set up
#jira UE-46073
Change 3496830 by Michael.Noland
Editor: Change FEditorCategoryUtils methods to take UStruct* instead of UClass*, as they are just reading metadata
#rnx
Change 3496840 by Michael.Noland
Framework: Remove the requirement for a local player in UCheatManager::CheatScript, so it can be be started from the server side (doesn't change the availability of the cheat manager, just allows things like the redundant "cheat cheatscript scriptname" to work)
Change 3497038 by Michael.Noland
Fortnite: Added UFortDeveloperSettings to allow developers to auto-run cheats in PIE (does not occur in -game or outside of WITH_EDITOR builds)
- You can specify a list of cheat commands to run when a pawn is possessed (also needs CL# 3496840 for cheatscripts)
- You can also specify a set of items to grant to your local inventory when it is created
Change 3497204 by Marc.Audy
Fix AbilitySystemComponent not being blueprint readable.
#rnx
Change 3497668 by Mieszko.Zielinski
Fixed a crash in BT editor when dealing with enum-typed Blackboard-keys pointing to enum values that have been deleted #UE4
#jira UE-43659
Change 3497677 by Mieszko.Zielinski
Added a community-suggested working solution to patching up dynamic navmesh after world offset #UE4
Also, fixed a crash related to navmesh rebuilding if generation was configured to lazily gather navigatble geometry
#jira UE-41293
Change 3497678 by Mieszko.Zielinski
Marked AbstractNavData class as transient #UE4
We never want to save it to levels
Change 3497679 by Mieszko.Zielinski
Made NavModifierVolume responsive to editor-time property changes #UE4
#jira UE-32831
Change 3497900 by Dan.Oconnor
Fix bad skel reference when using construct object from class, just limiting scope of 3491946. To reproduce the bug just nativize QA Game, including the TM-Gameplay level
#rnx
Change 3497904 by Dan.Oconnor
Use K2Node_Event::FindEventSignatureFunction in order when directly generating the skeleton generated class to get event params correct
#jira UE-46153
#rnx
Change 3497907 by Dan.Oconnor
Correctly set blueprint visibility flags on params for inherited functions when generating the skeleton class
#rnx
#jira UE-46186
Change 3498218 by mason.seay
Updates to pin testing BP's
Change 3498323 by Mieszko.Zielinski
Made UNavCollision instance assigned to StaticMesh not get re-created from scratch every single time any StaticMesh property changes #UE4
Recreation was resulting in some of the UNavCollision's properties not getting saved and the way we were recreating the nav collision could also interfere with undo buffers
#jira UE-44891
Change 3499007 by Marc.Audy
Allow systems to hook Pre and PostCompile to do custom behaviors
Change 3499013 by Mieszko.Zielinski
Made AbstractNavData class non-transient again #UE4
Implemented AbstractNavData instances' transientness in a different manner.
#jira UE-46194
Change 3499204 by Mieszko.Zielinski
Introduced CrowdManagerBase, an engine-level class that can be extended to implement custom crowd management #Orion
Extracted FRecastQueryFilter into a separate file, which will break some peoples' compilation.
#jira UE-43799
Change 3499321 by mason.seay
Updated bp for struct testing
Change 3499388 by Marc.Audy
Allow the compiler log to store off potential messages from earlier in the compile cycle (early validation), that can be committed later (for example once pruning is completed).
Change 3499390 by Marc.Audy
Generate the orphan pin error messages during EarlyValidation, but cache until the regular validation phase. This ensures all are generated, but only those that aren't pruned will be emitted.
#rnx
Change 3499420 by Michael.Noland
Engine: Introduced a new version of UEngine::GetWorldFromContextObject which takes an enum specifying the behavior on failures and updated all existing uses
The new version intentionally does not have a default value for ErrorMode, callers need to think about which variant of behavior they want:
- ReturnNull: Silently returns nullptr, the calling code is expected to handle this gracefully
- LogAndReturnNull: Raises a runtime error but still returns nullptr, the calling code is expected to handle this gracefully
- Assert: Asserts, the calling code is not expecting to handle a failure gracefully
- Deprecated UEngine::GetWorldFromContextObject(object, boolean) and changed the default behavior for the deprecated instances to do LogAndReturnNull rather than Assert, based on the real-world call pattern
- Introduced GetWorldFromContextObjectChecked(object) as a shorthand for passing in EGetWorldErrorMode::Assert
- Made UObject::GetWorldChecked() actually assert if it would return nullptr (under some cases the old function could silently return nullptr while reporting bSupported = true, so it neither ensured nor checked)
- Fixed a race condition in the 'is implemented' bookkeeping logic in GetWorld()/GetWorldChecked() by confining it to the game thread and added a check() to ImplementsGetWorld() to make it clear that it only works on the game thread
The typical recommended call pattern is to use something like:
if (UWorld* World = GEngine->GetWorldFromContextObject(WorldContextObject, EGetWorldErrorMode::LogAndReturnNull))
{
... Do something with World
}
Handling the failure case but requesting a log message (with BP call stack printed out) if it failed. This is now also the default behavior for old calls to UEngine::GetWorldFromContextObject(Object) (using the default value of bChecked=true), which is a behavior change but it matches how the function was being used in practice; the vast majority of call sites actually expected it to potentially fail and handled the nullptr case gracefully; very few places used the return value unguarded and wanted it to assert when passed a nullptr.
#jira UE-42458
Change 3499429 by Michael.Noland
Engine: Removed a bogus TODO (the problematic code had already been reworked)
#rnx
Change 3499470 by Michael.Noland
Core: Improved and corrected the comment for ensure()
- It doesn't crash when checking is disabled (and hasn't since UE3, maybe ever?)
- It now only fires once per ensure() by default, added a note about ensureAlways()
#rnx
Change 3499643 by Marc.Audy
Use TGuardValue instead of manually managing it
#rnx
Change 3499874 by Marc.Audy
Display <Unnamed> instead of nothing for Pins with blank display name in the compiler log
Change 3499875 by Marc.Audy
When changing function parameter types, don't orphan a pin on the function entry/exit nodes (but do at the call sites)
#jira UE-46224
Change 3499927 by Dan.Oconnor
UField::Serialize no longer serialize's its next ptr, UStruct::Serialize serializes all Children properties instead. This resolves a hard circular dependency between function libraries that EDL detected. It was resolved in an ad hoc way by the old linker
#jira UE-43458
Change 3499953 by Michael.Noland
Core: Created a variant of ensure that does runtime error logging without stopping in the debugger and some related functions that print a warning or error and may trigger a BP callstack (under the same rules as FFrame::KismetExecutionMessage)
- These are WIP and the API may change in the future, but are being used to fix various crashes found by fuzzing BP exposed functions
Change 3499957 by Michael.Noland
Animation: Added runtime errors for nullptr ControlRigs passed into BP methods
#rnx
Change 3499958 by Michael.Noland
Blueprints: Changed an ensure in UKismetNodeHelperLibrary::GetValidValue to a runtime error
#rnx
Change 3499959 by Michael.Noland
Engine: Downgrade various checks() to ensures() in the runtime asset cache functions exposed to Blueprints
Change 3499960 by Michael.Noland
AI: Changed UBTFunctionLibrary to not check/ensure if passed a null world context object
Change 3499968 by Michael.Noland
Editor: Fixed a couple of crashes in UEditorLevelUtils when passed nullptr arguments, and reformatted the entire file to fix widespread indentation issues
#rnx
Change 3499969 by Michael.Noland
Engine: Changed the verbosity of the failure log message of UEngine::GetWorldFromContextObject(..., LogAndReturnNull) from Warning to Error, so it always prints out a BP callstack
#rnx
Change 3499973 by Michael.Noland
Rendering: Fixed asserts in various UKismetRenderingLibrary methods if passed a nullptr for the WorldContextObject
- Also fixed flipped warnings in the failure cases for EndDrawCanvasToRenderTarget
Change 3499979 by Michael.Noland
Editor: Prevented a crash in UMaterialEditingLibrary::RecompileMaterial when passed a nullptr material
Change 3499984 by Michael.Noland
Physics: Prevented a crash in UTraceQueryTestResults::AssertEqual when passed in nullptr for Expected
Change 3499993 by Michael.Noland
Blueprints: Added validation when renaming variables, functions, components, multicast delegates, etc... to prevent names from containing some unacceptable characters
- This validation only kicks in when trying to rename an item, so bad names in existing content are 'grandfathered in'
- These bad names can cause bugs when working with content that contains these characters (e.g., names that contain a period cannot be found via FindObject<T>)
- Currently only . is banned, but eventually we may expand it to include all of INVALID_OBJECTNAME_CHARACTERS
Change 3500009 by Michael.Noland
Blueprints: Made the fuzzer skip classes declared in UnrealEd for now (some of the exposed methods change global state that can cause other tests to fail as the fuzzer isn't particularly sandboxed ATM)
#rnx
Change 3500011 by Michael.Noland
Android: Fixed a crash in UAndroidPermissionFunctionLibrary::AcquirePermissions when called with an empty array on non-Android platforms
Change 3500012 by Michael.Noland
Editor: Prevent a crash in UEditorTutorial::OpenAsset when passed a nullptr Asset
Change 3500014 by Michael.Noland
Engine: Changed FRuntimeAssetCacheFilesystemBackend::ClearCache(NAME_None) to not try to clear all cache directories (there is a separate no-args method for that)
Change 3500019 by Michael.Noland
Core: Fixed some more issues with CallFunctionByNameWithArguments and initializing / destroying parameters
- It was skipping the return value and incorrectly relying on the FirstPropertyToInit list which isn't set for by ref arguments
Change 3500020 by Michael.Noland
Automation: Prevent UFunctionalTestingManager::RunAllFunctionalTests and UFunctionalTestingManager* UFunctionalTestingManager::GetManager from crashing when a manager cannot be created (because we can't route to a world)
Change 3501062 by Marc.Audy
MakeArray AddInputPin is often used as part of node expansion, so need to move the transaction out of the function
Fix inability to undo/redo pin additions to sequence node
Add a K2Node_AddPinInterface to generalize the interface that K2Nodes implement to interact with SGraphNodeK2Sequence so it can be more generally used
#jira UE-46164
#jira UE-46270
Change 3501330 by Michael.Noland
AI: Fix an error on shutdown when the CDO of UAIPerceptionComponent tries to clean up (as it was never registered in the first place)
#jira UE-46271
Change 3501356 by Marc.Audy
Fix crash when multi-editing actor blueprints
#jira UE-46248
Change 3501408 by Michael.Noland
Core: Improve the print-out of FFrame::GetStackTrace() / FFrame::GetScriptCallstack() when there is no script stack (e.g., when FFrame::KismetExecutionMessage is called by native code with no BP above in the call stack)
Change 3501457 by Phillip.Kavan
#jira UE-46054 - Fix crash when launching a packaged build that includes a nativized Blueprint instance with a ChildActorComponent instanced via an AddComponent node.
Change summary:
- Removed UK2Node_AddComponent::PostDuplicate(). This eliminates the creation of redundant component templates that were being unnecessarily created during the Blueprint duplication that precedes the nativization pass.
- Modified SMyBlueprint::OnDuplicateAction() to call MakeNewComponentTemplate() in response to a graph duplication action within the same Blueprint context (replaces previous UK2Node_AddComponent::PostDuplicate() impl).
- Modified FEmitDefaultValueHelper::HandleSpecialTypes() to force AddComponent-based CAC-owned template objects in the emitted codegen to use the UDynamicClass as the Outer when instancing. This matches what we already do for SCS-based CAC-owned template objects - that logic was added in CL# 3270456, and this matches up with FBlueprintNativeCodeGenModule::FindReplacedNameAndOuter(), where we specifically handle CAC-owned template objects.
Change 3502741 by Phillip.Kavan
#jira UE-45782 - Fix undo for index pin type changes.
Change summary:
- Modified SGraphPinIndex::OnTypeChanged() to call Modify() on the pin that was changed.
Change 3502939 by Michael.Noland
Back out changelist 3499927
Change 3503087 by Marc.Audy
Re-fixed ocean content as editor had also changed so had to take theirs and redo
#rnx
Change 3503266 by Ben.Zeigler
#jira UE-46335 Fix regression added in 4.16 where AssetRegistry GetAncesorClassNames/GetDerivedClassNames were not working properly in cooked builds for classes not in memory
Change 3503325 by mason.seay
updated Anim BP to prep for pin testing
Change 3503445 by Marc.Audy
Fix crash caused by OldPins being destroyed before rewiring
#rnx
Change 3505024 by Marc.Audy
Fix NodeEffectsPanel blueprint as it was using pins that no longer existed
#rnx
Change 3505254 by Marc.Audy
Don't include orphan pins when gather source property names
If a property doesn't exist for a source property name just skip the property rather than crashing
#jira UE-46345
#rnx
Change 3506125 by Ben.Zeigler
#jira UE-46311 Fix issues when blueprints are reloaded in place, it needs to remove them from root properly and sanitize the old class. It's still not clear why they are being reloaded in place
Change 3506334 by Dan.Oconnor
Move UAnimGraphNode_Base::PreloadRequiredAssets up to K2Node, make sure nodes get a chance to preload data before compilation manager compiles newly loaded blueprints
#jira UE-46411
Change 3506439 by Dan.Oconnor
Return to pre 3488512 behavior for construct object nodes. This means that we can still get warnings on load when users compile after saving a blueprint, but the current behavior loses default values because it's lookng at the skeleton cdo
#jira UE-46308
Change 3506468 by Dan.Oconnor
Return to pre 3488512 behavior, as it causes bad default values
#jira UE-46414
#rnx
Change 3506733 by Marc.Audy
Use the most up to date class to determine whether a property still exists when adding pins during reconstruction
#jira UE-45965
#author Dan.OConnor
#rnx
Change 3507531 by Ben.Zeigler
#jira UE-46449 Better fix to flush the asset registry queue when the editor requests a synchronous scan at startup. Sometimes it can take a few frames because of file handle delays
Change 3507924 by mason.seay
Sanity save of TM-Gameplay and sublevels to maybe resolve level streaming issues
Change 3507962 by Marc.Audy
Remake changes from CL# 3150796 wiped out by WEX-Staging merge to Main in CL# 3479958
#rnx
Change 3509131 by Dan.Oconnor
Compilation manager compile on load flow never called FindExportsInMemoryFirst, which is critical to prevent reloading of UBlueprintGeneratedClasses when Rename clears the export table
#jira UE-46311
Change 3509345 by Marc.Audy
CVar to disable orphan pins if necessary
#rnx
Change 3509959 by Marc.Audy
Protect against crashing due to large values in Timespan From functions
#jira UE-43840
Change 3510040 by Marc.Audy
Remove all the old unneeded ShooterGame test maps
#rnx
[CL 3510073 by Marc Audy in Main branch]
2017-06-26 15:07:18 -04:00
{
AsyncTask - > GetTask ( ) . FireCompletionDelegate ( ) ;
}
2015-06-10 03:14:50 -04:00
}
2015-06-19 03:13:33 -04:00
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3544039)
#lockdown Nick.Penwarden
#rb none
#rnx
=====================================
MAJOR FEATURES + CHANGES
=====================================
Change 3343905 by Dan.Oconnor
ResolveMember optimizations and moved into cpp. ResolveMember<UFunction> now checks UClass::FuncMap before doing more expensive searches
Change 3346637 by Ben.Zeigler
Actually fix in non editor builds
Change 3355484 by Dan.Oconnor
Back out FMemberReference Optimization
Change 3425833 by Ben.Zeigler
#jira UE-31749 Fix it so Undo works properly when modifying a local variable
#jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value
Change 3510091 by Marc.Audy
Expose on Spawn functional test
#rnx
Change 3510100 by Marc.Audy
Fix spelling error
#rnx
Change 3510132 by Marc.Audy
Fix issues with marking a widget blueprint class as abstract
Change 3510133 by Marc.Audy
Minor code cleanup
#rnx
Change 3510178 by Ben.Zeigler
#jira UE-46500 Fix it so editor-only and transient stuct members are not serialized for literal blueprint structs. It's unsafe to serialize them because they may not exist in the cooked build
Change 3510466 by Ben.Zeigler
Start adding basic ability system tests to enginetest, very minimal so far
Change 3511295 by Marc.Audy
Fix wasted work going weak -> object -> weak -> object
#rnx
Change 3511824 by Marc.Audy
Fix spelling error in tooltip
#jira UE-46515
#rnx
Change 3514446 by Ben.Zeigler
Fix ActorBoundEvent and ComponentBoundEvent to always refresh their event signature from the delegate property they are bound to. This is required to correctly deal with delegate signatures being moved or renamed. Both types now do the fixup one time, in ReconstructNode.
Change 3514578 by Marc.Audy
Move clearing of the actor component need end of frame update mark to base class instead of just primitive component
Change 3514583 by Ben.Zeigler
Better fix to last delegate checkin that also handles moving functions between modules but not renaming
Change 3515325 by Dan.Oconnor
Fix for rare orphan pin false positive, rare exposed on spawn false positive
#rnx
Change 3515761 by Marc.Audy
fix shipping configuration
#rnx
Change 3515772 by Marc.Audy
Fix static analysis warnings
#rnx
Change 3516287 by Marc.Audy
Fix references to instanced components not being updated when resetting component to default
#jira UE-44706
#rnx
Change 3516303 by Marc.Audy
Back out CL# 3516287 while an oddity is investigated
#rnx
Change 3516563 by Marc.Audy
(4.17) Fix references to instanced components not being updated when resetting component to default
#jira UE-44706
Change 3516637 by Phillip.Kavan
#jira UE-44661 - Fix potential crash when changing the ChildActorComponent class default value on a Blueprint that also sets the class in the Construction Script.
Change summary:
- Modified UChildActorComponent::DestroyChildActor() to move the check for PendingKill/Unreachable so that we can also rename a defunct ChildActor instance out of the way in order to allow for a new ChildActor instance w/ the cached name.
Change 3517735 by Marc.Audy
Avoid unnecessary string copy
#rnx
Change 3517931 by Marc.Audy
Small optimization to CleanupActors
Change 3518221 by Dan.Oconnor
Fix rare crash when running ConformImplementedEvents when async loading
#jira UE-45348
Change 3518270 by Ben.Zeigler
#jira UE-46574 Add FCollectionReference type and customization to allow setting an FName to an editor collection
Add AssetCollection to PrimaryAssetLabel that derives the bundled assets from an editor collection
Change 3518271 by Marc.Audy
Get rid of unnecessary construction differentiation if custom reset is being used
Change 3518310 by Ben.Marsh
Re-adding IOS files with correct case.
Change 3518423 by Ben.Zeigler
#jira UE-46574 Initial support for chunk installation in Asset Manager.
Refactor AssetManagerSettings so it copies runtime bools into the asset manager for fast access
Add a concept of a stalled streamable manager handle, handles can be created stalled and will not execute their async load until all needed resources have been acquired externally
Change 3518480 by Marc.Audy
Correctly get the variable reference for an input variable get from the member scope rather than a member variable of the same name on the class
#jira UE-46737
Change 3518498 by Ben.Zeigler
Fix bug with AssetManager where requesting the same load twice in a row before the first one finishes caused the complete callback to get called too early for the second load
Update test map to catch this
Change 3518526 by Ben.Zeigler
IOS Fix
Change 3518619 by Ben.Zeigler
#jira UE-46744 Fix issue where refreshing asset manager editor settings would throw away asset label rules overrides, causing the recursive flag to accidentally get set
Change 3518747 by Phillip.Kavan
#jira UE-43154 - Prevent ConstructGenericObject nodes from compiling if the selected type does not include 'BlueprintType' in its inheritance hierarchy.
Change summary:
- Moved UGameplayStatics::CanSpawnObjectOfClass() into UK2Node_GenericCreateObject as a local util method (per JIRA notes). This was not exposed to Blueprints and as such was inconsistent with the rest of the API.
- Modified UGameplayStatics::SpawnObject() to no longer call CanSpawnObjectOfClass(). This seemed redundant as this will already have been called during node validation at Blueprint compile time.
- Refactored CanSpawnObjectOfClass() into FK2Node_GenericCreateObject_Utils. Walking up the inheritance chain no longer starts out w/ the assumption that 'BlueprintType' is set by default, which was previously including a lot of engine-specific classes into the "allowed" set (e.g. UByteProperty). Also unified the 2 loop iterations that were being used to check for 'BlueprintType'/'NotBlueprintType' and 'DontUseGenericSpawnObjectName', as well as the check for whether or not the class is a derivative of AActor/UActorComponent.
- Modified UK2Node_GenericCreateObject::EarlyValidation() to call FK2Node_GenericCreateObject_Utils::CanSpawnObjectOfClass() and emit a slightly more informative error message to the BP compiler message log.
Change 3518756 by Michael.Noland
(4.17) Framework: Prevent various asserts when USplineComponent methods are called on a spline with no points
Change 3518760 by Michael.Noland
Core: Changed FRuntimeAssetCache ensures to ensureAsRuntimeWarning
Change 3518771 by Michael.Noland
AI: Prevent an ensure in UBlackboardComponent::ClearValue when called on a component with a null BlackboardAsset
Change 3518818 by Michael.Noland
Rendering: Fixed a whitespace issue in UCanvasRenderTarget2D::RepaintCanvas()
#rnx
Change 3518822 by Michael.Noland
Sequencer: Prevented crashes in some methods of UMovieSceneSequencePlayer when there is no Sequence set
Sequencer: Prevented a crash in FMovieSceneRootEvaluationTemplateInstance::Evaluate when the instance has no template set
Change 3518824 by Michael.Noland
Landscape: Marked ULandscapeComponent and ULandscapeHeightfieldCollisionComponent as Within=LandscapeProxy, since they do CastChecked on their Outer all the time
Change 3519073 by Michael.Noland
QAGame: Fixed a crash in UQASynth::PlaySynth() if called on a directly created instance rather than using the factory method
Change 3519076 by Michael.Noland
Preventing crashes in UAutomationPerformaceHelper (sic) when spawned abnormally for fuzzing (assumes that the outer will have a route to a world)
#rnx
Change 3519079 by Michael.Noland
Sequencer: Fixed a potential crash in UMediaPlaylist::Insert and UMediaPlaylist::RemoveAt when passed an invalid index
Change 3519081 by Michael.Noland
Blueprints: Added support for creating appropriate outers for objects that must be nested within another class during fuzzing (ones that specify Within=, other relationships aren't knowable yet)
Change 3519082 by Michael.Noland
VR: Prevent a crash in UMRMeshComponent::ConnectReconstructor when passed a null reconstructor
Change 3519084 by Michael.Noland
Rendering: Prevent crashes when UNiagaraComponent::GetEffectDataInterface is called on a component with no effect asset set
Change 3521889 by Michael.Noland
Sequencer: Prevented a bogus static analysis warning by reworking the code (FixedFrameInterval could have only been set if the pointer were valid from the line above)
#rnx
Change 3521987 by Michael.Noland
Animation: Prevent a couple of potential asserts in UControlRig::GetOrAllocateSubControlRig
Change 3522101 by Michael.Noland
Physics: Improved the comment on UPhysicalMaterial::Friction
#rn
Change 3522105 by Michael.Noland
Physics: Fixed a few crashes in UVehicleWheel when spawned directly
Change 3522106 by Michael.Noland
Framework: Marked ULevelStreaming as Within=World, since it does CastChecked on the Outer all the time
Change 3522109 by Michael.Noland
Animation: Marked UAnimInstance as Within=SkeletalMeshComponent since it assumes the outer in various places
Change 3522121 by Michael.Noland
Mobile: Prevent UMobileInstalledContent methods from crashing when called on a created instance in an uncooked build (no installed manifest)
Change 3522783 by Zak.Middleton
#ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before).
Change 3525477 by Dan.Oconnor
Remove Tooltip, Category, and HideCategories tooltip from the blueprint generated class if source data is cleared
Change 3526538 by Ben.Zeigler
Refresh primary asset labels if their bundles are different at all and not just if they're added or removed. This is required because they now work based on collections or directories. This fixes issue with the onboarding collection changes not correctly modifying chunks
Copy of CL #3526501
Change 3526817 by Ben.Zeigler
#jira UE-46917 Fix issue where maps that do not contain level script blueprints were being counted as unindexed for find in blueprints. The old behavior depended on detecting the existence of empty tags, but the asset registry now filters those out so treat maps with no FiB data as indexed
Change 3526873 by Ben.Zeigler
#jira UE-46627 Change it so blueprint or native subclasses of static mesh actor cannot be added to clusters, as they are not likely to be immutable the way the base class is
Add code to to the ubergraph frame to fall back to hard reference serialization if the reference collector doesn't support weak references, such as the cluster collector
Change 3526958 by Marc.Audy
(4.17) Don't copy and then break pin links when reconstructing. Instead simply move.
#jira UE-46935
Change 3528916 by Marc.Audy
PR #3609: Adds GetKeysForAxis() to complement GetKeysForAction() in UPlayerInput (Contributed by alanedwardes)
#jira UE-45347
Change 3529080 by mason.seay
BP asset for undetermined type bug
Change 3529381 by Marc.Audy
Fix ability to insert duplicates in to a set or map
Change 3529471 by Dan.Oconnor
Fix for clang 4.0 error: definition of builtin function '__rdtsc' inline unsigned long long __rdtsc()
Change 3530876 by Marc.Audy
Based on PR #3457: Add MakeSet BP node (Contributed by projectgheist)
Also refactored MakeArray/Set to share a base MakeContainer class
Cleaned up some dead code from MakeArray
Added icon for MakeSet
Added Functional Test for MakeSet
#jira UE-43717
Change 3531070 by Phillip.Kavan
#jira UE-46866 - Fix crash on load when an external variable member reference's owning type cannot be loaded.
Change summary:
- Modified FBlueprintEditorUtils::GetSkeletonClass() to check for NULL before attempting to check for the generating BP.
Change 3531081 by Marc.Audy
Remove deprecated CustomMapParamValue code
Change 3531094 by Phillip.Kavan
#jira UE-46952 - Fix a packaging code build failure that will occur with a nativized Blueprint class that contains a UInterfaceProperty.
Change summary:
- Modified TScriptInterface::operator=() to cast the given 'SourceObject' instance to the 'InterfaceType' type before assigning to 'SourceInterface'. This was necessary because if the caller (in this case nativized codegen) passes in a UObject* that does not explicitly inherit from 'InterfaceType', then it will need to go through the object's GetInterfaceAddress() API instead and cast the result back to an 'InterfaceType' pointer.
Change 3531186 by Phillip.Kavan
Back out changelist 3531094 (temp CIS fix).
#rnx
Change 3532082 by Marc.Audy
Move garbage collection timers and other management to UEngine instead of UWorld
Fixes CollectGarbage blueprint node not working in shipping
#jira UE-46566
Change 3532134 by Phillip.Kavan
Restored changelist 3531094 w/ fix for non-unity.
- Mirrored from //UE4/Release-4.17 (CL# 3531232).
#rnx
Change 3533009 by Marc.Audy
Fixup missing function and deprecation warnings
Change 3534056 by Marc.Audy
(4.17) Fix expose on spawn of map and sets to work
#jira UE-47140
Change 3534761 by Marc.Audy
(4.17) Apply code review changes to Dev-Framework as well
#rnx
Change 3535147 by Dan.Oconnor
Build fix, already made in 4.17
#rnx
Change 3535530 by mason.seay
Resaving to remove error when opening level blueprint
Change 3535581 by Marc.Audy
Class Properties are only identical if they are literally the same object. Do not consider the deep compare port flags as object property base does.
#jira UE-46533
Change 3535583 by Marc.Audy
When properties are imported in to a child actor component the cached instance data is invalidated, so clear it.
#jira UE-46533
Change 3535617 by Marc.Audy
PR #3788: UE-39237: Prevent (im-)pure casting during BP debugging (Contributed by projectgheist)
#jira UE-47188
#jira UE-39237
Change 3535671 by Marc.Audy
Change NodeFactory to look at interface to use sequence node instead of each node having to add itself
Change 3535955 by Marc.Audy
Prevent MakeSet from removing split pins
Change 3536114 by Michael.Noland
Paper2D: Removing deprecated code from 4.3/4.4 era
#rnx
Change 3536120 by Michael.Noland
Animation: Removed deprecated FTAlphaBlend class and AlphaBlendType.h header
Change 3536124 by Michael.Noland
Physics: Removed deprecated methods that were replaced by _AssumesLocked variations
Change 3536131 by Michael.Noland
Slate: Converting remaining uses of EKeyboardFocusCause to EFocusCause and properly deprecating it
Change 3536138 by Michael.Noland
Slate: Removed any deprecated code older than 4.10 that didn't affect content compatibility
Change 3536167 by Dan.Oconnor
When a client provides a skeleton class as the self scope, make sure we also use a skel class for non-self scopes - but only if using the compilation manager. Skel classes are not reliably up to date when not using the compilation manager
#jira UE-46904
Change 3536221 by Michael.Noland
Editor: Removing deprecated code from 4.9 or earlier
Change 3536240 by Michael.Noland
Blueprints: Removed long-deprecated TypeToString method from the K2 schema
#rnx
Change 3536243 by Michael.Noland
AI: Prevent crashes if UMockTask_Log is created manually rather than via the CreateTask factory method
Change 3536244 by Michael.Noland
Core: Prevent FScopedExternalProfilerBase::StopScopedTimer() from asserting if called an unmatched number of times with StartScopedTimer, as both are exposed to BPs now
Change 3536250 by Michael.Noland
CoreUObject: Removed any deprecated code older than 4.10 that didn't affect content compatibility
Change 3536253 by Michael.Noland
Core: Removed any deprecated code older than 4.10 that didn't affect content compatibility
Change 3536310 by Michael.Noland
Engine: Removed any deprecated code older than 4.10 that didn't affect content compatibility
Change 3536397 by Mieszko.Zielinski
Fixed UCrowdFollowingComponent::UpdateCachedDirections crashing when CharacterMovement is not set #UE4
#jira UE-46860
Change 3536404 by Michael.Noland
Platform: Added a warning for others when they try to remove this 'deprecated' method
Change 3536639 by Michael.Noland
CharacterMovement: Changed the name of a variable introduced in CL# 3536397 to better match intent
#rnx
Change 3536893 by Michael.Noland
Blueprints: Clear the stale value on the value pin when a map find node fails to find an item
#jira UE-47233
Change 3536902 by Michael.Noland
Framework: Killed a couple of more deprecated methods that were not exposed to Blueprints
#rnx
Change 3537038 by Ben.Marsh
Fixing case of iOS directories, pt1
Change 3537039 by Ben.Marsh
Fixing case of iOS directories, pt2
Change 3538246 by Michael.Noland
UnrealTournament: Fixing issues with renamed enum
#rnx
Change 3538618 by Ben.Zeigler
Fix ensure when closing sequencer transform UI
Change 3540213 by Ben.Zeigler
#jira UE-47313 Fix crash serializing a MapProperty where the value type has changed for a type that implements ConvertFromType. The address passed to ConvertFromType needs to be the container root, not the specific value address, keys worked because the offset was 0.
Change 3540253 by Marc.Audy
Only copy default values for input pins as output pins do not have them
#rnx
Change 3540376 by Marc.Audy
Add utility FromPinType for FEdGraphTerminalType
#rnx
Change 3540433 by Marc.Audy
Add MakeMap
#jira UE-47093
Unify IsConnectionDisallowed for containers and fix static analysis warning
#jira UE-47291
Change 3540585 by Phillip.Kavan
#jira UE-47117 - Fix crash on launch of a nativized build that includes an instanced default subobject that's referenced by another instanced default subobject.
Change summary:
- Modified FEmitDefaultValueHelper::HandleSpecialTypes() to only direct HandleInstancedSubobject() to emit code to create the instanced subobject if it's not a default subobject. This was previously being incorrectly interpreted as an object having the 'RF_ArchetypeObject' flag set; however, default subobjects will also have that flag set in addition to the 'RF_DefaultSubobject' flag.
- Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert in the 'GetDefaultSubobjectByName' case if the given object is not also a default subobject.
Change 3541147 by Dan.Oconnor
Fix for not being able to override custom events when using the compilation manager post 3536167
#jira UE-47292
#rnx
Change 3541177 by Ben.Zeigler
#jira UE-46595, UE-46553 Fix issue where creating a widget template could cause a widget blueprint being cooked to have the wrong package flags, making it appear to be an uncooked package
Copy of CL #3541027
Change 3541325 by Dan.Oconnor
K2node data table data needs to preload data before the compilation queue is flushed
#rnx
#jira UE-47319
Change 3541409 by Michael.Noland
Blueprints: Added code to reapply any active breakpoints after recompilation when using the BP compilation manager
#jira UE-47322
[reimplementing CL# 3541404 in Dev-Framework]
Change 3541418 by Dan.Oconnor
Fix for bad SKEL_ CDO reference in blueprint bytecode
#jira UE-47265
#rnx
Change 3541482 by Dan.Oconnor
Blanket fix up of preload calls that are being done in AllocateDefaultPins. AllocatDefaultPins is not called until compile, meaning if these preload calls load blueprints they will be loaded while the compilation manager is compiling blueprints
#rnx
#jira UE-47319
Change 3541817 by Marc.Audy
Fix static analysis warnings
#rnx
Change 3542299 by Michael.Noland
Blueprints: Speculative fix for static analysis warning
#rnx
Change 3542406 by Marc.Audy
Use a check slow to avoid any cost
#rnx
Change 3542486 by Michael.Noland
Asset Manager: Removing an unnecessary ensure (it's a potentially expected case)
#jira UE-47380
Change 3542659 by Michael.Noland
Blueprints: Clear out null entries in the LastEditedDocuments list during PostLoad() and remove entries when a graph is being deleted to prevent their generation in the first place
#jira UE-47385
Change 3543620 by Dan.Oconnor
Remove overzealous ensure - we may recompile blueprints that are asynchronously loading when a user triggers a synchronous compile
#jira UE-47415
#rnx
Change 3518415 by Ben.Zeigler
#jira UE-46574 Deprecate IPlatformChunkInstall::SetChunkInstallDelgate as it was spelled wrong, was only half implemented, and did not support success vs failure
Replace with AddChunkInstallDelegate, which supports a bool error code and is bound once instead of separately for each chunk. All implementations support this delegate at a basic level, although several could be improved to call the failure delegate in more cases
Change 3534339 by Michael.Noland
Platforms: Changed DEPRECATED() macro description to use 4.xx rather than a speciifc version in examples, so it doesn't show up when removing deprecated code
[CL 3544050 by Marc Audy in Main branch]
2017-07-19 09:49:59 -04:00
if ( ensureAsRuntimeWarning ( AsyncTask ) )
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3510040)
#lockdown Nick.Penwarden
=====================================
MAJOR FEATURES + CHANGES
=====================================
Change 3459524 by Marc.Audy
Get/Set of properties that were previously BPRW/BPRO should error when used
#jira UE-20993
Change 3460004 by Phillip.Kavan
#jira UE-45171 - Fix C++ compilation failures during packaging caused by nativizing a Blueprint that overrides a native function with a 'TSubclassOf' parameter or return value.
Change summary:
- Modified FKismetCompilerContext::CreateParametersForFunction() to pass the 'CPF_UObjectWrapper' flag through to new function parameter properties during Blueprint compilation.
Change 3461210 by Phillip.Kavan
#jira UE-44505 - Fix occasional Blueprint editor crashes that could occur while rebuilding the context menu from the action registry.
Change summary:
- Modified FBlueprintActionDatabase::FActionRegistry to use an FObjectKey as the key type. This allows us to test entries for UObject validity before rebuilding context menu items based on the action database.
- Changed FBlueprintActionInfo::CachedOwnerClass to be a TWeakObjectPtr rather than a raw UClass* since it's based on the ActionOwner, which could potentially become invalid after the OwnerClass has been cached.
- Modified FBlueprintActionDatabase::RefreshAssetActions() to exclude World assets if the WorldType is not EWorldType::Editor. This eliminates an issue with unreferenced "inactive" GC'd world objects being left in the BP action registry after cooking, at which point the keys could become invalid.
- Added FBlueprintActionDatabase::DeferredRemoveEntry() to allow for scheduling removal of entries from outside of the database if they are known to be invalid.
- Modified FBlueprintActionDatabase::Tick() to handle deferred entry removals.
- Modified FBlueprintActionMenuBuilder::RebuildActionList() to both test actions for validity before building menu items and schedule removal of invalid actions on the next tick.
Notes:
- Alternatively we could just include UObject keys in the database's AddReferencedObject impl, but that would then prevent objects from ever being GC'd if they are not explicitly removed. For most entries the action database takes the approach of explicitly removing entries via delegate when the UObject is destroyed, so I chose to use a TWeakObjectPtr instead so that any entries that may not be getting explicitly removed via delegate will now simply become invalidated if the UObject key is GC'd due to not being referenced. I also set it up to clean and remove any entries (along with any associated node spawners) that are found to be invalid the next time we open the BP editor.
Change 3461373 by Lukasz.Furman
fixed async navmesh rebuilds not kicking in for requests from navdata.bForceRebuildOnLoad
#jira UE-44231
Change 3461409 by Lukasz.Furman
fixed reenabling automatic navmesh generation in Editor Preferences
#ue4
Change 3461550 by Ben.Zeigler
#jira UE-45328 Fix local variable support for Redirectors and other save-time validation. We need to run the local variables to UProperty and back at save time
Add new flag PPF_SerializedAsImportText which is used for BP pins/default values and indicates that something has been serialized as import text and so needs to handle string asset redirectors
Change 3462625 by Zak.Middleton
#ue4 - Fix InterpToMovementComponent not setting velocity on the object it moves. Fix movement rate when substepping enabled (other related fixes to come).
github PR #3620
Change 3462796 by Dan.Oconnor
Fix for spamming BroadcastBlueprintReinstanced and for creating CDO at wrong time when compiling FrontEnd.uasset in OrionGame
#jira UE-45434
Change 3462995 by Ben.Zeigler
#jira UE-16941 Fix it so Load Asset node works with a literal value as well as a connected pin
Change 3463099 by Ben.Zeigler
#jira UE-45471 Allow abstract base classes for primary assets
Change 3464809 by Marc.Audy
Expose FVector2D / FVector2D to blueprints
#jira UE-45427
Change 3467254 by Mieszko.Zielinski
Added an AI helper BP function that supplies caller with a copy of navigation path given controller is currently following #UE4
Change 3467644 by Dan.Oconnor
Fix for cook issues in ocean when using compilation manager, one issue caused by bad dependencies list, one issue caused by lack of subobject mapping in archetype reinstancing.
#jira UE-45443, UE-45444
Change 3468176 by Dan.Oconnor
Fix dependent blueprints being marked dirty when a blueprint is compiled
Change 3468353 by Michael.Noland
UnrealHeaderTool: Improved the warning generated when missing Category= on a function or property declared in an engine module, and centralized the logic that determines if the module is engine or game
Change 3470532 by Dan.Oconnor
Re-enable compilation manager
Change 3470572 by Dan.Oconnor
Fix for pin paramters resetting when an archetype was reinstanced
#jira UE-45619
#rnx
Change 3471949 by Mason.Seay
Adding Primary Assets for testing
Change 3472074 by Ben.Zeigler
#jira UE-45140 Convert iterative cooking to use the Asset Registry as it's only mode, remove old hash and timestamp versions. This allows deleting the entire PackageDependencyInfo module
Change the asset registry iteration to not compute a hash at all, and instead store the script package guids in it's cache.
Expose bIgnoreIniSettingsOutOfDateForIteration and bIgnoreScriptPackagesOutOfDateForIteration in cooker settings, affects rather to listen to ini/script changes when doing iterative cooking
Change 3472079 by Ben.Zeigler
With new incremental cook options, change Fortnite to never care about ini settings, but do care about code changes. This can be changed but from previous discussions we wanted to be more safe than fast here
Change 3473429 by Lukasz.Furman
changed path following update tick to allow working on "invalid, update pending" paths, solves AI getting stuck when navigation is rebuild very frequently (e.g. every tick from moving mesh)
#jira UE-41884
Change 3473476 by Lukasz.Furman
changed crowd simulation path update tick to allow working on "invalid, update pending" paths, solves AI getting stuck when navigation is rebuild very frequently (e.g. every tick from moving mesh)
#jira UE-41884
Change 3473663 by Ben.Zeigler
Fix it so base k2node registers framework version, this is needed for the assetptr fixup I previously added
Change 3473679 by Mason.Seay
Slight cleanup of test map and added ability to teleport across level for easy navigation
Change 3473712 by Marc.Audy
Do default value validation against the actual value of the default entry of an enum rather than the serialized empty autogenerated default value
Change 3474055 by Marc.Audy
When nodes are reconstructed any pins that were previously linked or set to non-default values that have been removed will no longer simply vanish, but instead will remain in an Orphaned state until dealt with.
#jira UE-41828
Change 3474119 by mason.seay
Tweaked Force Feedback test
Change 3474156 by Marc.Audy
Actually enable orphan pin retention
Change 3474382 by Ben.Zeigler
Class.h Header and comment cleanup. Started this because IsChildOf did not have a comment and it's usage is a bit confusing
Change 3474386 by Ben.Zeigler
Close popup window when adding asset class to audit window
Change 3474491 by Ben.Zeigler
Remove ability for Worlds to not be saved as assets, this has been the default since 2014.
Change 3475363 by Marc.Audy
Alt-click now works with orphaned pins
#jira UE-45699
Change 3475523 by Marc.Audy
Fixup Fortnite and Paragon content for orphaned pin errors and warnings
Change 3475623 by Phillip.Kavan
#jira UE-45477 - Fix an EDL assertion on load in a nativized build with one or more Actor subobjects instanced via the EditInlineNew UI in the BP class defaults property editor.
Change summary:
- Modified FEmitDefaultValueHelper::OuterGenerate() to emit code to construct/initialize instanced subobject values that do not have the RF_DefaultSubObject flag set, and also to recursively handle nested subobjects for those values.
- Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to alternatively emit a 'NewObject' assignment statement rather than a 'CreateDefaultSubobject' statement if only RF_ArchetypeObject is set on the source object value.
Change 3476008 by Dan.Oconnor
Fix for failing to preload our super class's subobjects. Effectively moving UBlueprint::ForceLoad calls earlier in loading process. This only results in data resetting to your parent's parent's default value from your parent's default value.
#jira UE-18765
Change 3476115 by Dan.Oconnor
Fix missing category information for inherited functions when using compilation manager
#jira UE-45660
#rnx
Change 3476577 by Lukasz.Furman
added early outs from navmesh layer generation when there's no walkable cells or contours to avoid allocating 0 bytes by next generation steps (behavior differs between platforms)
#ue4
Change 3476587 by Phillip.Kavan
#jira UE-45517 - Fix a regression in which dragging UMG widgets around in the designer view results in redundantly-compounded BP class properties and context menu actions.
Change summary:
- Modified SDesignerView::ClearDropPreviews() to move the widget that was removed from the tree into the transient package. This ensures that FWidgetBlueprintCompiler::CreateClassVariablesFromBlueprint() won't pick them up.
- Modified SDesignerView::ProcessDropAndAddWidget() to also consider any widgets not added to the 'DropPreviews' array as being transient (i.e. also move them into the transient package since they were not added to the tree).
Notes:
- The regression was introduced by the changes in CL# 3410168, and was merged to Main at CL# 3431398.
#rnx
Change 3476723 by Dan.Oconnor
Match old behavior wrt updating implemented interfaces in blueprints - this logic from FKismetEditorUtilities::CompileBlueprint was missing in compilation manager
#jira UE-45468
#rnx
Change 3476948 by Michael.Noland
Framework: Changed AActor::FindComponentByClass (and AActor::GetComponentByClass by extension) to return nullptr when passed a nullptr class, rather than crashing
Change 3476970 by Ben.Zeigler
Fix bug I introduced in 4.16 where assigning assets to multiple chunks did not work properly
Change 3477536 by Marc.Audy
Don't display default value box on linked orphaned input pins
Change 3477835 by Marc.Audy
Fix pins orphaned by deletion of an entry in a user-defined enum disappearing instead of remaining connected
#jira UE-45754
Change 3478027 by Marc.Audy
Minor performance optimization
#rnx
Change 3478198 by Phillip.Kavan
#jira UE-42431 - Remove an unnecessary ensure() when pasting an event node.
Change summary:
- Modified UEdGraphSchema_K2::CreateSubstituteNode() to no longer ensure() that we have a valid PreExistingNode; it's only used for logging when a substitute node is created in response to a conflict with an existing node.
Change 3478485 by Marc.Audy
Eliminate extraneous error messages about orphaned pins on get/set nodes
#jira UE-45749
#rnx
Change 3478756 by Marc.Audy
Fix fallout from changes to DoesDefaultValueMatchAutogenerated for user defined enums
#jira UE-45721
#rnx
Change 3478926 by Marc.Audy
Non-blueprint type structs can no longer be made/broken
Non-blueprint visible properties in structs will no longer have pins created for them
#jira UE-43122
Change 3478988 by Marc.Audy
DeltaTime for a tick function with a tick interval is now correct after disabling and then reenabling the tick function.
#jira UE-45524
Change 3479818 by Marc.Audy
Allow ctrl-drag off of orphan pins
#jira UE-45803
Change 3480214 by Marc.Audy
Modifications to user defined enumerations are now transacted
#jira UE-43866
Change 3480579 by Marc.Audy
Maintain all pin properties through transactions.
#rn Reference pins that are removed and then restored via undo now correctly have the diamond icon instead of the standard circle.
Change 3481043 by Marc.Audy
Make/Break of structs does not depend on having blueprint exposed properties.
Splitting of a struct pin still requires blueprint exposed properties.
#jira UE-45840
#jira UE-45831
Change 3481271 by Ben.Zeigler
Fix the AssetManager chunking code to use ChunkDependencyInfo instead of a hardcoded check for chunk 0
Clean up ChunkDependencyInfo and make it properly public
Move ShouldSetManager to be WITH_EDITOR
Ported from WEX branch
#RB peter.sauerbrei
Change 3481373 by Dan.Oconnor
Reduce reliance on expensive FindDelegateSignature. 3275922 made warnings about a ambiguous search more likely as it preserved names of members on the REINST_ classes
#jira UE-45704
Change 3481380 by Ben.Zeigler
Change it so Struct and Object AssetRegistrySearchable properties do not show up in content browser, they are not helpful
Change 3482362 by Marc.Audy
Fix properties not exposed to blueprint warnings for input properties on function graphs.
#jira UE-45824
Change 3482406 by Ben.Zeigler
#jira UE-45883 Fix Switch On Gameplay Tag Container node, and add switch nodes to TagCheck map
Change 3482498 by Ben.Zeigler
Attempt to fix hot reload issues with Asset Manager. We need to reset and re-acquire the asset classes when rescanning, as they may be pointing to the replaced class
Change 3482517 by Lukasz.Furman
fixed smart navlink update functions removing important flag
#jira UE-45875
Change 3482538 by Marc.Audy
When comparing float, vector, and rotator values for whether the the default matches the autogenerated do not use the string compare because differences in use of decimal or number of 0s after decimal are then considered not the same float
#jira UE-45846
Change 3482773 by Marc.Audy
Don't show default value or pass by reference for exec pins
#jira UE-45868
Change 3482791 by Ben.Zeigler
#jira UE-45800 Correctly dirty game mode blueprint when changing player controller/etc classes from game mode customization
Fix it so MarkBlueprintAsStructurallyModified calls MarkBlueprintAsModified as several fixes were only in the second function
Change 3483131 by Zak.Middleton
#ue4 - InterpToMovementComponent:
- Fix velocity not zeroed when interpolation stops.
- Various fixes when calculating velocity and time when substepping is enabled.
- Improve accuracy of interpolation when looping and there is time remaining after the loop event is hit. Consume the remainder of the time after the event back in the loop (similar to handling a blocking impact).
#jira UE-45690
Change 3483146 by Phillip.Kavan
#jira UE-38358 - Propagate 'const' function flag from interface Blueprint to implementing Blueprints.
Change summary:
- Modified FBlueprintEditorUtils::MarkBlueprintAsStructurallyModified() to call SkeletalRecompileChildren() on dependent BPs when the target is an interface BP.
- Modified FBlueprintEditorUtils::MarkBlueprintAsStructurallyModified::FRefreshHelper::SkeletalRecompileChildren() to set child BP status to BS_Dirty after compiling.
- Modified ConformInterfaceByName() (FBlueprintEditorUtils) to use the interface's skeleton class for function iteration as well as to match the Function Entry node's 'const' setting to the interface UFunction's signature.
Change 3483340 by Ben.Zeigler
Fix issue querying asset registry after a hot reload, make sure pending kill objects are never considered to be Assets
Change 3483548 by Michael.Noland
Epic Friday: Playing around with some prototype traps
Change 3483700 by Phillip.Kavan
Fix CIS cook crash introduced by last submit.
#rnx
Change 3485217 by Ben.Zeigler
#jira UE-45519 Fix regression introduced in 4.16 where it would no longer cook all maps when no explicit maps were specified in ini or game callback. Moved the code that detects changes before culture/default map code and hardened it to deal with the case where some engine packages were already in the list before it entered the function
Change 3485367 by Dan.Oconnor
Avoid adding mappings to anim node when creating variables on the skeleton class and using the compilation manager
#jira UE-45756
Change 3485565 by Ben.Zeigler
#jira UE-45948 Fix compilation manager to properly reset variable default values after promoting a pin to local variable
Change 3485566 by Marc.Audy
Fix crashes caused by undo/redo of user defined struct changes
#jira UE-45775
#jira UE-45781
Change 3485805 by Michael.Noland
PR #3459: Fix for world origin shifting and SpringArmComponent location lag (Contributed by michail-nikolaev)
#jira UE-43747
Change 3485807 by Michael.Noland
PR #3485: Added additional textures field to paper 2d tileset class (Contributed by gryphonmyers)
#jira UE-44041
Change 3485811 by Michael.Noland
Framework: Fixed a bug in FStreamLevelAction::MakeSafeLevelName to avoid appending the PIE prefix multiple times (fixes functions like Unload Streaming Level when passed a full package name from an instanced streaming level)
Change 3485829 by Michael.Noland
Framework: Made GetWorldAssetPackageFName BlueprintCallable so instanced levels can be unloaded
Change 3485830 by Michael.Noland
PR #3568: add API declarations to ALevelStreamingVolume methods (Contributed by kayama-shift)
#jira UE-45002
Change 3486039 by Michael.Noland
PR #3495: UE-44014: Refreshing node error fixes (Contributed by projectgheist)
- Empty out the ErrorMsg when a node gets refreshed to prevent the same error messages from compounding
- Added support for split pins in UK2Node_Event::IsFunctionEntryCompatible
- Added a missing check for the delegate pin name on the entry node part of UK2Node_Event::IsFunctionEntryCompatible
#jira UE-44014
Change 3486093 by Michael.Noland
PR #3379: Added GAMEPLAYABILITIES_API to all Ability Tasks. (Contributed by ryanjon2040)
#jira UE-42903
Change 3486139 by Michael.Noland
Blueprints: Added new config options for execution wire thickness when not debugging (DefaultExecutionWireThickness) and data wire thicknesses (DefaultDataWireThickness) to the Graph Editor Settings page
#rn
Change 3486154 by Michael.Noland
Framework: Speculative fix for CIS error about FStructOnScope
#rnx
Change 3486180 by Dan.Oconnor
Better match old logic for determining when to skip data only compile
#jira UE-45830
Change 3487276 by Marc.Audy
Fix crash when using Setter with a locally scoped variable
#rnx
Change 3487278 by Marc.Audy
Ensure that pin change notifications occur on all pin breaks unless it is part of a node being garbage collected
Change 3487658 by Marc.Audy
Ensure that child actor template is created for subclasses
#jira UE-45985
Change 3487699 by Marc.Audy
Move non-templated elements out of FArchiveReplaceObjectRef and put them in FArchiveReplaceObjectRefBase
Change 3487813 by Dan.Oconnor
Asset demonstrating a crash
Change 3488101 by Marc.Audy
Fix crash with spawn/construct actor/object from class nodes when they no longer had any pins.
Correctly orphan pins when a node goes to 0 pins.
Change 3488337 by Marc.Audy
Editable pin base should not manually remove pin and let reconstruct node and rewire pins do their job
#jira UE-46020
Change 3488512 by Dan.Oconnor
ConstructObject nodes and SubInstances nodes use skeleton class when compilation manager can provide it
#jira UE-45830, UE-45965
#rnx
Change 3488631 by Michael.Noland
Framework: Fixed a crash when loading a blueprint with a parent class of ALevelBounds caused by trying to register the class default object with a non-existent level
#jira UE-45630
Change 3488665 by Michael.Noland
Blueprints: Improve the details panel customization for optional pin nodes like Struct Member Get/Set
- The category, raw name, and tooltip of the property are now included as part of the filter text as well
- The property tooltip is now displayed when hovering over the property name
- Code updated to use GET_MEMBER_NAME_CHECKED() where appropriate
Change 3489324 by Marc.Audy
Fix recursion causing stack crash
#jira UE-46038
#rnx
Change 3489326 by Marc.Audy
Fix cooking crash
#jira UE-46031
#rnx
Change 3489687 by mason.seay
Assets for testing orphan pins
Change 3489701 by Marc.Audy
Back out changelist 3487278 and 3489443 and make targetted changes for fixing up orphan pin cases where changing connections doesn't remove the pin.
#jira UE-46051
#jira UE-46052
#rnx
Change 3490352 by Dan.Oconnor
Fix for missing WidgetTree on Skeleton class - just look directly at the WidgetBlueprint
#jira UE-46062
Change 3490814 by Marc.Audy
Make callfunction/macro instances save all pins in orphan state more similar to previous behavior
#rnx
Change 3491022 by Dan.Oconnor
Properly clean up 'Key' property when we fail to create a value property
#jira UE-45279
Change 3491071 by Ben.Zeigler
#jira UE-45981 Fix rotation issues, vector/rotator pins with empty strings were not matching due to uninitialized memory.
Change 3491244 by Michael.Noland
Blueprints: Add compile time message back to the output log (will not auto-open the output log if there were no warnings/errors)
#jira UE-32948
Change 3491276 by Michael.Noland
Blueprints: Fixed some bugs where a newly added item would fail show up in the "My Blueprints" tree if there was a filter active (e.g., when promoting a variable)
- Centralized the logic for clearing the filter so it happens when we try and fail to select the item, rather than ad hoc in various other places
- Made it only clear the filter if necessary, rather than (almost) always clearing it when adding an item
#jira UE-43372
Change 3491562 by Marc.Audy
Put back pin removal in to editable pin base and instead modify the pin destroy implementation to take down child split pins with it
#jira UE-46020
#rnx
Change 3491658 by Marc.Audy
Unify RemoveUserDefinedPin implementations. Use version that has break to avoid size change assert
#rnx
Change 3491946 by Marc.Audy
ReconstructSinglePin no longer destroys OldPin (avoids oprhaned sub pins being destroyed before reparented)
RewireOldPinsToNewPins now destroys OldPins at the end (calling code no longer reponsible)
DestroyImpl now prunes out SubPins that had already been trashed
#rnx
Change 3492040 by Marc.Audy
Discard exec/then pins from a callfunction that has been converted to a pure node
#rnx
Change 3492200 by Zak.Middleton
#ue4 - Always reset the input array in AActor::GetComponents(), but do so without affecting allocated size.
Fixes possible regression from CL 3359561 that removed the Reset(...) entirely.
#jira UE-46012
Change 3492290 by Ben.Zeigler
#jira UE-46108 Fix StringLibrary Mid to never crash, Substring had already been fixed
Change 3492311 by Marc.Audy
Don't clear the pin type if what you're connecting to's pin type is wildcard
#rnx
Change 3492680 by Dan.Oconnor
Handle missing generated class when using compilation manager - tested by forcing compile of BP_ParentClassIsMissingType.uasset
Change 3492826 by Marc.Audy
Don't do pin connection list change notifications from DestroyPins while regenerating on load
#jira UE-46112
#rnx
Change 3492851 by Michael.Noland
Core: Fixed various crashes when using UObject::CallFunctionByNameWithArguments with non-trivial argument types by properly initializing the allocated parameters
Change 3492852 by Michael.Noland
Framework: Fixed a crash if ACharacter::FindComponentByClass was passed a nullptr class
Change 3492934 by Marc.Audy
Fix ensure and crash delete macro containing orphaned pin
#rnx
Change 3493079 by Dan.Oconnor
Fix for crash when opening ThirdPersonAnimBlueprint and ThirdPersonAnimBlueprint_Perf then clicking 'Compile' button in ThirdPersonAnimBlueprint editor. Make sure the convenience members in the derived compilers get set when we relink child classes (which requires making cdos, which requires PropagateValuesToCDO..)
#rnx
Change 3493346 by Phillip.Kavan
#jira UE-40560 - Fix a reported crash when pasting nodes between unrelated Blueprint graphs.
Change summary:
- Modified FEdGraphUtilities::PostProcessPastedNodes() to ensure() on a NULL pin entry; this will allow execution to continue while still alerting us since it is an unexpected result. Also added an 'else' case to then remove the NULL entry so that PostPasteNode() implementations don't all have to guard against NULL pin entries. When the node is reconstructed, the NULL entry will be replaced with the correct pin initialized to its default values.
- Modified UEdGraphPin::ImportTextItem() to add some additional logging to parse error cases when importing pin properties from source T3D text. Hopefully this gives us more information when this is encountered in the future.
Change 3493938 by Michael.Noland
Blueprints: Prevent issues with renaming event dispatchers to contain periods (this may be disallowed in the future, but they no longer become uneditable)
#jira UE-45780
Change 3493945 by Michael.Noland
Blueprints: Fixed GetDelegatePoperty typos
#rnx
Change 3493997 by Michael.Noland
Blueprints: Partially reverting changes from CL# 3319966 to reroute nodes, restoring their alignment but losing the symmetrical grab handle changes
#jira UE-45760
Change 3493998 by Dan.Oconnor
Fix rare crash in RefreshStandAloneDefaultsEditor when the blueprint editor is opened and a blueprint had errors in it
Note: I stumbled across this by running a unit test and then opening a blueprint in the BPE. CrashReporter indicates 3 crashes in the last 3 days
Change 3494025 by Michael.Noland
Engine: Deleted some dead code (DEBUGGING_VIEWPORT_SIZES)
#rnx
Change 3494026 by Michael.Noland
Blueprints: V0 of a BlueprintCallable/BlueprintPure function fuzzer
- Calls exposed methods with default parameters on classes it is able to spawn for now, which catches crashes due to null and /0 but not out of bounds issues or ones on classes it can't spawn due to classwithin, abstract, etc...
- Can be called using Test.ScriptFuzzing, won't be integrated into automated tests until it is more fully fleshed out and all known issues are addressed
#rnx
Change 3496382 by Ben.Zeigler
Fix ensure when launching editor with cook on the side and incremental cooking enabled. It now flushes the background asset gather when calling the sync load all assets if one is in progress
Change 3496688 by Marc.Audy
Avoid crashing in component instance data if (for some reason) the Actor's root component isn't properly set up
#jira UE-46073
Change 3496830 by Michael.Noland
Editor: Change FEditorCategoryUtils methods to take UStruct* instead of UClass*, as they are just reading metadata
#rnx
Change 3496840 by Michael.Noland
Framework: Remove the requirement for a local player in UCheatManager::CheatScript, so it can be be started from the server side (doesn't change the availability of the cheat manager, just allows things like the redundant "cheat cheatscript scriptname" to work)
Change 3497038 by Michael.Noland
Fortnite: Added UFortDeveloperSettings to allow developers to auto-run cheats in PIE (does not occur in -game or outside of WITH_EDITOR builds)
- You can specify a list of cheat commands to run when a pawn is possessed (also needs CL# 3496840 for cheatscripts)
- You can also specify a set of items to grant to your local inventory when it is created
Change 3497204 by Marc.Audy
Fix AbilitySystemComponent not being blueprint readable.
#rnx
Change 3497668 by Mieszko.Zielinski
Fixed a crash in BT editor when dealing with enum-typed Blackboard-keys pointing to enum values that have been deleted #UE4
#jira UE-43659
Change 3497677 by Mieszko.Zielinski
Added a community-suggested working solution to patching up dynamic navmesh after world offset #UE4
Also, fixed a crash related to navmesh rebuilding if generation was configured to lazily gather navigatble geometry
#jira UE-41293
Change 3497678 by Mieszko.Zielinski
Marked AbstractNavData class as transient #UE4
We never want to save it to levels
Change 3497679 by Mieszko.Zielinski
Made NavModifierVolume responsive to editor-time property changes #UE4
#jira UE-32831
Change 3497900 by Dan.Oconnor
Fix bad skel reference when using construct object from class, just limiting scope of 3491946. To reproduce the bug just nativize QA Game, including the TM-Gameplay level
#rnx
Change 3497904 by Dan.Oconnor
Use K2Node_Event::FindEventSignatureFunction in order when directly generating the skeleton generated class to get event params correct
#jira UE-46153
#rnx
Change 3497907 by Dan.Oconnor
Correctly set blueprint visibility flags on params for inherited functions when generating the skeleton class
#rnx
#jira UE-46186
Change 3498218 by mason.seay
Updates to pin testing BP's
Change 3498323 by Mieszko.Zielinski
Made UNavCollision instance assigned to StaticMesh not get re-created from scratch every single time any StaticMesh property changes #UE4
Recreation was resulting in some of the UNavCollision's properties not getting saved and the way we were recreating the nav collision could also interfere with undo buffers
#jira UE-44891
Change 3499007 by Marc.Audy
Allow systems to hook Pre and PostCompile to do custom behaviors
Change 3499013 by Mieszko.Zielinski
Made AbstractNavData class non-transient again #UE4
Implemented AbstractNavData instances' transientness in a different manner.
#jira UE-46194
Change 3499204 by Mieszko.Zielinski
Introduced CrowdManagerBase, an engine-level class that can be extended to implement custom crowd management #Orion
Extracted FRecastQueryFilter into a separate file, which will break some peoples' compilation.
#jira UE-43799
Change 3499321 by mason.seay
Updated bp for struct testing
Change 3499388 by Marc.Audy
Allow the compiler log to store off potential messages from earlier in the compile cycle (early validation), that can be committed later (for example once pruning is completed).
Change 3499390 by Marc.Audy
Generate the orphan pin error messages during EarlyValidation, but cache until the regular validation phase. This ensures all are generated, but only those that aren't pruned will be emitted.
#rnx
Change 3499420 by Michael.Noland
Engine: Introduced a new version of UEngine::GetWorldFromContextObject which takes an enum specifying the behavior on failures and updated all existing uses
The new version intentionally does not have a default value for ErrorMode, callers need to think about which variant of behavior they want:
- ReturnNull: Silently returns nullptr, the calling code is expected to handle this gracefully
- LogAndReturnNull: Raises a runtime error but still returns nullptr, the calling code is expected to handle this gracefully
- Assert: Asserts, the calling code is not expecting to handle a failure gracefully
- Deprecated UEngine::GetWorldFromContextObject(object, boolean) and changed the default behavior for the deprecated instances to do LogAndReturnNull rather than Assert, based on the real-world call pattern
- Introduced GetWorldFromContextObjectChecked(object) as a shorthand for passing in EGetWorldErrorMode::Assert
- Made UObject::GetWorldChecked() actually assert if it would return nullptr (under some cases the old function could silently return nullptr while reporting bSupported = true, so it neither ensured nor checked)
- Fixed a race condition in the 'is implemented' bookkeeping logic in GetWorld()/GetWorldChecked() by confining it to the game thread and added a check() to ImplementsGetWorld() to make it clear that it only works on the game thread
The typical recommended call pattern is to use something like:
if (UWorld* World = GEngine->GetWorldFromContextObject(WorldContextObject, EGetWorldErrorMode::LogAndReturnNull))
{
... Do something with World
}
Handling the failure case but requesting a log message (with BP call stack printed out) if it failed. This is now also the default behavior for old calls to UEngine::GetWorldFromContextObject(Object) (using the default value of bChecked=true), which is a behavior change but it matches how the function was being used in practice; the vast majority of call sites actually expected it to potentially fail and handled the nullptr case gracefully; very few places used the return value unguarded and wanted it to assert when passed a nullptr.
#jira UE-42458
Change 3499429 by Michael.Noland
Engine: Removed a bogus TODO (the problematic code had already been reworked)
#rnx
Change 3499470 by Michael.Noland
Core: Improved and corrected the comment for ensure()
- It doesn't crash when checking is disabled (and hasn't since UE3, maybe ever?)
- It now only fires once per ensure() by default, added a note about ensureAlways()
#rnx
Change 3499643 by Marc.Audy
Use TGuardValue instead of manually managing it
#rnx
Change 3499874 by Marc.Audy
Display <Unnamed> instead of nothing for Pins with blank display name in the compiler log
Change 3499875 by Marc.Audy
When changing function parameter types, don't orphan a pin on the function entry/exit nodes (but do at the call sites)
#jira UE-46224
Change 3499927 by Dan.Oconnor
UField::Serialize no longer serialize's its next ptr, UStruct::Serialize serializes all Children properties instead. This resolves a hard circular dependency between function libraries that EDL detected. It was resolved in an ad hoc way by the old linker
#jira UE-43458
Change 3499953 by Michael.Noland
Core: Created a variant of ensure that does runtime error logging without stopping in the debugger and some related functions that print a warning or error and may trigger a BP callstack (under the same rules as FFrame::KismetExecutionMessage)
- These are WIP and the API may change in the future, but are being used to fix various crashes found by fuzzing BP exposed functions
Change 3499957 by Michael.Noland
Animation: Added runtime errors for nullptr ControlRigs passed into BP methods
#rnx
Change 3499958 by Michael.Noland
Blueprints: Changed an ensure in UKismetNodeHelperLibrary::GetValidValue to a runtime error
#rnx
Change 3499959 by Michael.Noland
Engine: Downgrade various checks() to ensures() in the runtime asset cache functions exposed to Blueprints
Change 3499960 by Michael.Noland
AI: Changed UBTFunctionLibrary to not check/ensure if passed a null world context object
Change 3499968 by Michael.Noland
Editor: Fixed a couple of crashes in UEditorLevelUtils when passed nullptr arguments, and reformatted the entire file to fix widespread indentation issues
#rnx
Change 3499969 by Michael.Noland
Engine: Changed the verbosity of the failure log message of UEngine::GetWorldFromContextObject(..., LogAndReturnNull) from Warning to Error, so it always prints out a BP callstack
#rnx
Change 3499973 by Michael.Noland
Rendering: Fixed asserts in various UKismetRenderingLibrary methods if passed a nullptr for the WorldContextObject
- Also fixed flipped warnings in the failure cases for EndDrawCanvasToRenderTarget
Change 3499979 by Michael.Noland
Editor: Prevented a crash in UMaterialEditingLibrary::RecompileMaterial when passed a nullptr material
Change 3499984 by Michael.Noland
Physics: Prevented a crash in UTraceQueryTestResults::AssertEqual when passed in nullptr for Expected
Change 3499993 by Michael.Noland
Blueprints: Added validation when renaming variables, functions, components, multicast delegates, etc... to prevent names from containing some unacceptable characters
- This validation only kicks in when trying to rename an item, so bad names in existing content are 'grandfathered in'
- These bad names can cause bugs when working with content that contains these characters (e.g., names that contain a period cannot be found via FindObject<T>)
- Currently only . is banned, but eventually we may expand it to include all of INVALID_OBJECTNAME_CHARACTERS
Change 3500009 by Michael.Noland
Blueprints: Made the fuzzer skip classes declared in UnrealEd for now (some of the exposed methods change global state that can cause other tests to fail as the fuzzer isn't particularly sandboxed ATM)
#rnx
Change 3500011 by Michael.Noland
Android: Fixed a crash in UAndroidPermissionFunctionLibrary::AcquirePermissions when called with an empty array on non-Android platforms
Change 3500012 by Michael.Noland
Editor: Prevent a crash in UEditorTutorial::OpenAsset when passed a nullptr Asset
Change 3500014 by Michael.Noland
Engine: Changed FRuntimeAssetCacheFilesystemBackend::ClearCache(NAME_None) to not try to clear all cache directories (there is a separate no-args method for that)
Change 3500019 by Michael.Noland
Core: Fixed some more issues with CallFunctionByNameWithArguments and initializing / destroying parameters
- It was skipping the return value and incorrectly relying on the FirstPropertyToInit list which isn't set for by ref arguments
Change 3500020 by Michael.Noland
Automation: Prevent UFunctionalTestingManager::RunAllFunctionalTests and UFunctionalTestingManager* UFunctionalTestingManager::GetManager from crashing when a manager cannot be created (because we can't route to a world)
Change 3501062 by Marc.Audy
MakeArray AddInputPin is often used as part of node expansion, so need to move the transaction out of the function
Fix inability to undo/redo pin additions to sequence node
Add a K2Node_AddPinInterface to generalize the interface that K2Nodes implement to interact with SGraphNodeK2Sequence so it can be more generally used
#jira UE-46164
#jira UE-46270
Change 3501330 by Michael.Noland
AI: Fix an error on shutdown when the CDO of UAIPerceptionComponent tries to clean up (as it was never registered in the first place)
#jira UE-46271
Change 3501356 by Marc.Audy
Fix crash when multi-editing actor blueprints
#jira UE-46248
Change 3501408 by Michael.Noland
Core: Improve the print-out of FFrame::GetStackTrace() / FFrame::GetScriptCallstack() when there is no script stack (e.g., when FFrame::KismetExecutionMessage is called by native code with no BP above in the call stack)
Change 3501457 by Phillip.Kavan
#jira UE-46054 - Fix crash when launching a packaged build that includes a nativized Blueprint instance with a ChildActorComponent instanced via an AddComponent node.
Change summary:
- Removed UK2Node_AddComponent::PostDuplicate(). This eliminates the creation of redundant component templates that were being unnecessarily created during the Blueprint duplication that precedes the nativization pass.
- Modified SMyBlueprint::OnDuplicateAction() to call MakeNewComponentTemplate() in response to a graph duplication action within the same Blueprint context (replaces previous UK2Node_AddComponent::PostDuplicate() impl).
- Modified FEmitDefaultValueHelper::HandleSpecialTypes() to force AddComponent-based CAC-owned template objects in the emitted codegen to use the UDynamicClass as the Outer when instancing. This matches what we already do for SCS-based CAC-owned template objects - that logic was added in CL# 3270456, and this matches up with FBlueprintNativeCodeGenModule::FindReplacedNameAndOuter(), where we specifically handle CAC-owned template objects.
Change 3502741 by Phillip.Kavan
#jira UE-45782 - Fix undo for index pin type changes.
Change summary:
- Modified SGraphPinIndex::OnTypeChanged() to call Modify() on the pin that was changed.
Change 3502939 by Michael.Noland
Back out changelist 3499927
Change 3503087 by Marc.Audy
Re-fixed ocean content as editor had also changed so had to take theirs and redo
#rnx
Change 3503266 by Ben.Zeigler
#jira UE-46335 Fix regression added in 4.16 where AssetRegistry GetAncesorClassNames/GetDerivedClassNames were not working properly in cooked builds for classes not in memory
Change 3503325 by mason.seay
updated Anim BP to prep for pin testing
Change 3503445 by Marc.Audy
Fix crash caused by OldPins being destroyed before rewiring
#rnx
Change 3505024 by Marc.Audy
Fix NodeEffectsPanel blueprint as it was using pins that no longer existed
#rnx
Change 3505254 by Marc.Audy
Don't include orphan pins when gather source property names
If a property doesn't exist for a source property name just skip the property rather than crashing
#jira UE-46345
#rnx
Change 3506125 by Ben.Zeigler
#jira UE-46311 Fix issues when blueprints are reloaded in place, it needs to remove them from root properly and sanitize the old class. It's still not clear why they are being reloaded in place
Change 3506334 by Dan.Oconnor
Move UAnimGraphNode_Base::PreloadRequiredAssets up to K2Node, make sure nodes get a chance to preload data before compilation manager compiles newly loaded blueprints
#jira UE-46411
Change 3506439 by Dan.Oconnor
Return to pre 3488512 behavior for construct object nodes. This means that we can still get warnings on load when users compile after saving a blueprint, but the current behavior loses default values because it's lookng at the skeleton cdo
#jira UE-46308
Change 3506468 by Dan.Oconnor
Return to pre 3488512 behavior, as it causes bad default values
#jira UE-46414
#rnx
Change 3506733 by Marc.Audy
Use the most up to date class to determine whether a property still exists when adding pins during reconstruction
#jira UE-45965
#author Dan.OConnor
#rnx
Change 3507531 by Ben.Zeigler
#jira UE-46449 Better fix to flush the asset registry queue when the editor requests a synchronous scan at startup. Sometimes it can take a few frames because of file handle delays
Change 3507924 by mason.seay
Sanity save of TM-Gameplay and sublevels to maybe resolve level streaming issues
Change 3507962 by Marc.Audy
Remake changes from CL# 3150796 wiped out by WEX-Staging merge to Main in CL# 3479958
#rnx
Change 3509131 by Dan.Oconnor
Compilation manager compile on load flow never called FindExportsInMemoryFirst, which is critical to prevent reloading of UBlueprintGeneratedClasses when Rename clears the export table
#jira UE-46311
Change 3509345 by Marc.Audy
CVar to disable orphan pins if necessary
#rnx
Change 3509959 by Marc.Audy
Protect against crashing due to large values in Timespan From functions
#jira UE-43840
Change 3510040 by Marc.Audy
Remove all the old unneeded ShooterGame test maps
#rnx
[CL 3510073 by Marc Audy in Main branch]
2017-06-26 15:07:18 -04:00
{
FVoidPtrParam Data = AsyncTask - > GetTask ( ) . GetDataAndSize ( ) ;
delete AsyncTask ;
return Data ;
}
else
{
return FVoidPtrParam : : NullPtr ( ) ;
}
2015-06-10 03:14:50 -04:00
}
2015-06-19 03:13:33 -04:00
bool FRuntimeAssetCache : : PollAsynchronousCompletion ( int32 Handle )
2015-06-10 03:14:50 -04:00
{
2015-06-19 03:13:33 -04:00
FAsyncTask < FRuntimeAssetCacheAsyncWorker > * AsyncTask = nullptr ;
2015-06-10 03:14:50 -04:00
{
FScopeLock ScopeLock ( & SynchronizationObject ) ;
AsyncTask = PendingTasks . FindRef ( Handle ) ;
}
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3544039)
#lockdown Nick.Penwarden
#rb none
#rnx
=====================================
MAJOR FEATURES + CHANGES
=====================================
Change 3343905 by Dan.Oconnor
ResolveMember optimizations and moved into cpp. ResolveMember<UFunction> now checks UClass::FuncMap before doing more expensive searches
Change 3346637 by Ben.Zeigler
Actually fix in non editor builds
Change 3355484 by Dan.Oconnor
Back out FMemberReference Optimization
Change 3425833 by Ben.Zeigler
#jira UE-31749 Fix it so Undo works properly when modifying a local variable
#jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value
Change 3510091 by Marc.Audy
Expose on Spawn functional test
#rnx
Change 3510100 by Marc.Audy
Fix spelling error
#rnx
Change 3510132 by Marc.Audy
Fix issues with marking a widget blueprint class as abstract
Change 3510133 by Marc.Audy
Minor code cleanup
#rnx
Change 3510178 by Ben.Zeigler
#jira UE-46500 Fix it so editor-only and transient stuct members are not serialized for literal blueprint structs. It's unsafe to serialize them because they may not exist in the cooked build
Change 3510466 by Ben.Zeigler
Start adding basic ability system tests to enginetest, very minimal so far
Change 3511295 by Marc.Audy
Fix wasted work going weak -> object -> weak -> object
#rnx
Change 3511824 by Marc.Audy
Fix spelling error in tooltip
#jira UE-46515
#rnx
Change 3514446 by Ben.Zeigler
Fix ActorBoundEvent and ComponentBoundEvent to always refresh their event signature from the delegate property they are bound to. This is required to correctly deal with delegate signatures being moved or renamed. Both types now do the fixup one time, in ReconstructNode.
Change 3514578 by Marc.Audy
Move clearing of the actor component need end of frame update mark to base class instead of just primitive component
Change 3514583 by Ben.Zeigler
Better fix to last delegate checkin that also handles moving functions between modules but not renaming
Change 3515325 by Dan.Oconnor
Fix for rare orphan pin false positive, rare exposed on spawn false positive
#rnx
Change 3515761 by Marc.Audy
fix shipping configuration
#rnx
Change 3515772 by Marc.Audy
Fix static analysis warnings
#rnx
Change 3516287 by Marc.Audy
Fix references to instanced components not being updated when resetting component to default
#jira UE-44706
#rnx
Change 3516303 by Marc.Audy
Back out CL# 3516287 while an oddity is investigated
#rnx
Change 3516563 by Marc.Audy
(4.17) Fix references to instanced components not being updated when resetting component to default
#jira UE-44706
Change 3516637 by Phillip.Kavan
#jira UE-44661 - Fix potential crash when changing the ChildActorComponent class default value on a Blueprint that also sets the class in the Construction Script.
Change summary:
- Modified UChildActorComponent::DestroyChildActor() to move the check for PendingKill/Unreachable so that we can also rename a defunct ChildActor instance out of the way in order to allow for a new ChildActor instance w/ the cached name.
Change 3517735 by Marc.Audy
Avoid unnecessary string copy
#rnx
Change 3517931 by Marc.Audy
Small optimization to CleanupActors
Change 3518221 by Dan.Oconnor
Fix rare crash when running ConformImplementedEvents when async loading
#jira UE-45348
Change 3518270 by Ben.Zeigler
#jira UE-46574 Add FCollectionReference type and customization to allow setting an FName to an editor collection
Add AssetCollection to PrimaryAssetLabel that derives the bundled assets from an editor collection
Change 3518271 by Marc.Audy
Get rid of unnecessary construction differentiation if custom reset is being used
Change 3518310 by Ben.Marsh
Re-adding IOS files with correct case.
Change 3518423 by Ben.Zeigler
#jira UE-46574 Initial support for chunk installation in Asset Manager.
Refactor AssetManagerSettings so it copies runtime bools into the asset manager for fast access
Add a concept of a stalled streamable manager handle, handles can be created stalled and will not execute their async load until all needed resources have been acquired externally
Change 3518480 by Marc.Audy
Correctly get the variable reference for an input variable get from the member scope rather than a member variable of the same name on the class
#jira UE-46737
Change 3518498 by Ben.Zeigler
Fix bug with AssetManager where requesting the same load twice in a row before the first one finishes caused the complete callback to get called too early for the second load
Update test map to catch this
Change 3518526 by Ben.Zeigler
IOS Fix
Change 3518619 by Ben.Zeigler
#jira UE-46744 Fix issue where refreshing asset manager editor settings would throw away asset label rules overrides, causing the recursive flag to accidentally get set
Change 3518747 by Phillip.Kavan
#jira UE-43154 - Prevent ConstructGenericObject nodes from compiling if the selected type does not include 'BlueprintType' in its inheritance hierarchy.
Change summary:
- Moved UGameplayStatics::CanSpawnObjectOfClass() into UK2Node_GenericCreateObject as a local util method (per JIRA notes). This was not exposed to Blueprints and as such was inconsistent with the rest of the API.
- Modified UGameplayStatics::SpawnObject() to no longer call CanSpawnObjectOfClass(). This seemed redundant as this will already have been called during node validation at Blueprint compile time.
- Refactored CanSpawnObjectOfClass() into FK2Node_GenericCreateObject_Utils. Walking up the inheritance chain no longer starts out w/ the assumption that 'BlueprintType' is set by default, which was previously including a lot of engine-specific classes into the "allowed" set (e.g. UByteProperty). Also unified the 2 loop iterations that were being used to check for 'BlueprintType'/'NotBlueprintType' and 'DontUseGenericSpawnObjectName', as well as the check for whether or not the class is a derivative of AActor/UActorComponent.
- Modified UK2Node_GenericCreateObject::EarlyValidation() to call FK2Node_GenericCreateObject_Utils::CanSpawnObjectOfClass() and emit a slightly more informative error message to the BP compiler message log.
Change 3518756 by Michael.Noland
(4.17) Framework: Prevent various asserts when USplineComponent methods are called on a spline with no points
Change 3518760 by Michael.Noland
Core: Changed FRuntimeAssetCache ensures to ensureAsRuntimeWarning
Change 3518771 by Michael.Noland
AI: Prevent an ensure in UBlackboardComponent::ClearValue when called on a component with a null BlackboardAsset
Change 3518818 by Michael.Noland
Rendering: Fixed a whitespace issue in UCanvasRenderTarget2D::RepaintCanvas()
#rnx
Change 3518822 by Michael.Noland
Sequencer: Prevented crashes in some methods of UMovieSceneSequencePlayer when there is no Sequence set
Sequencer: Prevented a crash in FMovieSceneRootEvaluationTemplateInstance::Evaluate when the instance has no template set
Change 3518824 by Michael.Noland
Landscape: Marked ULandscapeComponent and ULandscapeHeightfieldCollisionComponent as Within=LandscapeProxy, since they do CastChecked on their Outer all the time
Change 3519073 by Michael.Noland
QAGame: Fixed a crash in UQASynth::PlaySynth() if called on a directly created instance rather than using the factory method
Change 3519076 by Michael.Noland
Preventing crashes in UAutomationPerformaceHelper (sic) when spawned abnormally for fuzzing (assumes that the outer will have a route to a world)
#rnx
Change 3519079 by Michael.Noland
Sequencer: Fixed a potential crash in UMediaPlaylist::Insert and UMediaPlaylist::RemoveAt when passed an invalid index
Change 3519081 by Michael.Noland
Blueprints: Added support for creating appropriate outers for objects that must be nested within another class during fuzzing (ones that specify Within=, other relationships aren't knowable yet)
Change 3519082 by Michael.Noland
VR: Prevent a crash in UMRMeshComponent::ConnectReconstructor when passed a null reconstructor
Change 3519084 by Michael.Noland
Rendering: Prevent crashes when UNiagaraComponent::GetEffectDataInterface is called on a component with no effect asset set
Change 3521889 by Michael.Noland
Sequencer: Prevented a bogus static analysis warning by reworking the code (FixedFrameInterval could have only been set if the pointer were valid from the line above)
#rnx
Change 3521987 by Michael.Noland
Animation: Prevent a couple of potential asserts in UControlRig::GetOrAllocateSubControlRig
Change 3522101 by Michael.Noland
Physics: Improved the comment on UPhysicalMaterial::Friction
#rn
Change 3522105 by Michael.Noland
Physics: Fixed a few crashes in UVehicleWheel when spawned directly
Change 3522106 by Michael.Noland
Framework: Marked ULevelStreaming as Within=World, since it does CastChecked on the Outer all the time
Change 3522109 by Michael.Noland
Animation: Marked UAnimInstance as Within=SkeletalMeshComponent since it assumes the outer in various places
Change 3522121 by Michael.Noland
Mobile: Prevent UMobileInstalledContent methods from crashing when called on a created instance in an uncooked build (no installed manifest)
Change 3522783 by Zak.Middleton
#ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before).
Change 3525477 by Dan.Oconnor
Remove Tooltip, Category, and HideCategories tooltip from the blueprint generated class if source data is cleared
Change 3526538 by Ben.Zeigler
Refresh primary asset labels if their bundles are different at all and not just if they're added or removed. This is required because they now work based on collections or directories. This fixes issue with the onboarding collection changes not correctly modifying chunks
Copy of CL #3526501
Change 3526817 by Ben.Zeigler
#jira UE-46917 Fix issue where maps that do not contain level script blueprints were being counted as unindexed for find in blueprints. The old behavior depended on detecting the existence of empty tags, but the asset registry now filters those out so treat maps with no FiB data as indexed
Change 3526873 by Ben.Zeigler
#jira UE-46627 Change it so blueprint or native subclasses of static mesh actor cannot be added to clusters, as they are not likely to be immutable the way the base class is
Add code to to the ubergraph frame to fall back to hard reference serialization if the reference collector doesn't support weak references, such as the cluster collector
Change 3526958 by Marc.Audy
(4.17) Don't copy and then break pin links when reconstructing. Instead simply move.
#jira UE-46935
Change 3528916 by Marc.Audy
PR #3609: Adds GetKeysForAxis() to complement GetKeysForAction() in UPlayerInput (Contributed by alanedwardes)
#jira UE-45347
Change 3529080 by mason.seay
BP asset for undetermined type bug
Change 3529381 by Marc.Audy
Fix ability to insert duplicates in to a set or map
Change 3529471 by Dan.Oconnor
Fix for clang 4.0 error: definition of builtin function '__rdtsc' inline unsigned long long __rdtsc()
Change 3530876 by Marc.Audy
Based on PR #3457: Add MakeSet BP node (Contributed by projectgheist)
Also refactored MakeArray/Set to share a base MakeContainer class
Cleaned up some dead code from MakeArray
Added icon for MakeSet
Added Functional Test for MakeSet
#jira UE-43717
Change 3531070 by Phillip.Kavan
#jira UE-46866 - Fix crash on load when an external variable member reference's owning type cannot be loaded.
Change summary:
- Modified FBlueprintEditorUtils::GetSkeletonClass() to check for NULL before attempting to check for the generating BP.
Change 3531081 by Marc.Audy
Remove deprecated CustomMapParamValue code
Change 3531094 by Phillip.Kavan
#jira UE-46952 - Fix a packaging code build failure that will occur with a nativized Blueprint class that contains a UInterfaceProperty.
Change summary:
- Modified TScriptInterface::operator=() to cast the given 'SourceObject' instance to the 'InterfaceType' type before assigning to 'SourceInterface'. This was necessary because if the caller (in this case nativized codegen) passes in a UObject* that does not explicitly inherit from 'InterfaceType', then it will need to go through the object's GetInterfaceAddress() API instead and cast the result back to an 'InterfaceType' pointer.
Change 3531186 by Phillip.Kavan
Back out changelist 3531094 (temp CIS fix).
#rnx
Change 3532082 by Marc.Audy
Move garbage collection timers and other management to UEngine instead of UWorld
Fixes CollectGarbage blueprint node not working in shipping
#jira UE-46566
Change 3532134 by Phillip.Kavan
Restored changelist 3531094 w/ fix for non-unity.
- Mirrored from //UE4/Release-4.17 (CL# 3531232).
#rnx
Change 3533009 by Marc.Audy
Fixup missing function and deprecation warnings
Change 3534056 by Marc.Audy
(4.17) Fix expose on spawn of map and sets to work
#jira UE-47140
Change 3534761 by Marc.Audy
(4.17) Apply code review changes to Dev-Framework as well
#rnx
Change 3535147 by Dan.Oconnor
Build fix, already made in 4.17
#rnx
Change 3535530 by mason.seay
Resaving to remove error when opening level blueprint
Change 3535581 by Marc.Audy
Class Properties are only identical if they are literally the same object. Do not consider the deep compare port flags as object property base does.
#jira UE-46533
Change 3535583 by Marc.Audy
When properties are imported in to a child actor component the cached instance data is invalidated, so clear it.
#jira UE-46533
Change 3535617 by Marc.Audy
PR #3788: UE-39237: Prevent (im-)pure casting during BP debugging (Contributed by projectgheist)
#jira UE-47188
#jira UE-39237
Change 3535671 by Marc.Audy
Change NodeFactory to look at interface to use sequence node instead of each node having to add itself
Change 3535955 by Marc.Audy
Prevent MakeSet from removing split pins
Change 3536114 by Michael.Noland
Paper2D: Removing deprecated code from 4.3/4.4 era
#rnx
Change 3536120 by Michael.Noland
Animation: Removed deprecated FTAlphaBlend class and AlphaBlendType.h header
Change 3536124 by Michael.Noland
Physics: Removed deprecated methods that were replaced by _AssumesLocked variations
Change 3536131 by Michael.Noland
Slate: Converting remaining uses of EKeyboardFocusCause to EFocusCause and properly deprecating it
Change 3536138 by Michael.Noland
Slate: Removed any deprecated code older than 4.10 that didn't affect content compatibility
Change 3536167 by Dan.Oconnor
When a client provides a skeleton class as the self scope, make sure we also use a skel class for non-self scopes - but only if using the compilation manager. Skel classes are not reliably up to date when not using the compilation manager
#jira UE-46904
Change 3536221 by Michael.Noland
Editor: Removing deprecated code from 4.9 or earlier
Change 3536240 by Michael.Noland
Blueprints: Removed long-deprecated TypeToString method from the K2 schema
#rnx
Change 3536243 by Michael.Noland
AI: Prevent crashes if UMockTask_Log is created manually rather than via the CreateTask factory method
Change 3536244 by Michael.Noland
Core: Prevent FScopedExternalProfilerBase::StopScopedTimer() from asserting if called an unmatched number of times with StartScopedTimer, as both are exposed to BPs now
Change 3536250 by Michael.Noland
CoreUObject: Removed any deprecated code older than 4.10 that didn't affect content compatibility
Change 3536253 by Michael.Noland
Core: Removed any deprecated code older than 4.10 that didn't affect content compatibility
Change 3536310 by Michael.Noland
Engine: Removed any deprecated code older than 4.10 that didn't affect content compatibility
Change 3536397 by Mieszko.Zielinski
Fixed UCrowdFollowingComponent::UpdateCachedDirections crashing when CharacterMovement is not set #UE4
#jira UE-46860
Change 3536404 by Michael.Noland
Platform: Added a warning for others when they try to remove this 'deprecated' method
Change 3536639 by Michael.Noland
CharacterMovement: Changed the name of a variable introduced in CL# 3536397 to better match intent
#rnx
Change 3536893 by Michael.Noland
Blueprints: Clear the stale value on the value pin when a map find node fails to find an item
#jira UE-47233
Change 3536902 by Michael.Noland
Framework: Killed a couple of more deprecated methods that were not exposed to Blueprints
#rnx
Change 3537038 by Ben.Marsh
Fixing case of iOS directories, pt1
Change 3537039 by Ben.Marsh
Fixing case of iOS directories, pt2
Change 3538246 by Michael.Noland
UnrealTournament: Fixing issues with renamed enum
#rnx
Change 3538618 by Ben.Zeigler
Fix ensure when closing sequencer transform UI
Change 3540213 by Ben.Zeigler
#jira UE-47313 Fix crash serializing a MapProperty where the value type has changed for a type that implements ConvertFromType. The address passed to ConvertFromType needs to be the container root, not the specific value address, keys worked because the offset was 0.
Change 3540253 by Marc.Audy
Only copy default values for input pins as output pins do not have them
#rnx
Change 3540376 by Marc.Audy
Add utility FromPinType for FEdGraphTerminalType
#rnx
Change 3540433 by Marc.Audy
Add MakeMap
#jira UE-47093
Unify IsConnectionDisallowed for containers and fix static analysis warning
#jira UE-47291
Change 3540585 by Phillip.Kavan
#jira UE-47117 - Fix crash on launch of a nativized build that includes an instanced default subobject that's referenced by another instanced default subobject.
Change summary:
- Modified FEmitDefaultValueHelper::HandleSpecialTypes() to only direct HandleInstancedSubobject() to emit code to create the instanced subobject if it's not a default subobject. This was previously being incorrectly interpreted as an object having the 'RF_ArchetypeObject' flag set; however, default subobjects will also have that flag set in addition to the 'RF_DefaultSubobject' flag.
- Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert in the 'GetDefaultSubobjectByName' case if the given object is not also a default subobject.
Change 3541147 by Dan.Oconnor
Fix for not being able to override custom events when using the compilation manager post 3536167
#jira UE-47292
#rnx
Change 3541177 by Ben.Zeigler
#jira UE-46595, UE-46553 Fix issue where creating a widget template could cause a widget blueprint being cooked to have the wrong package flags, making it appear to be an uncooked package
Copy of CL #3541027
Change 3541325 by Dan.Oconnor
K2node data table data needs to preload data before the compilation queue is flushed
#rnx
#jira UE-47319
Change 3541409 by Michael.Noland
Blueprints: Added code to reapply any active breakpoints after recompilation when using the BP compilation manager
#jira UE-47322
[reimplementing CL# 3541404 in Dev-Framework]
Change 3541418 by Dan.Oconnor
Fix for bad SKEL_ CDO reference in blueprint bytecode
#jira UE-47265
#rnx
Change 3541482 by Dan.Oconnor
Blanket fix up of preload calls that are being done in AllocateDefaultPins. AllocatDefaultPins is not called until compile, meaning if these preload calls load blueprints they will be loaded while the compilation manager is compiling blueprints
#rnx
#jira UE-47319
Change 3541817 by Marc.Audy
Fix static analysis warnings
#rnx
Change 3542299 by Michael.Noland
Blueprints: Speculative fix for static analysis warning
#rnx
Change 3542406 by Marc.Audy
Use a check slow to avoid any cost
#rnx
Change 3542486 by Michael.Noland
Asset Manager: Removing an unnecessary ensure (it's a potentially expected case)
#jira UE-47380
Change 3542659 by Michael.Noland
Blueprints: Clear out null entries in the LastEditedDocuments list during PostLoad() and remove entries when a graph is being deleted to prevent their generation in the first place
#jira UE-47385
Change 3543620 by Dan.Oconnor
Remove overzealous ensure - we may recompile blueprints that are asynchronously loading when a user triggers a synchronous compile
#jira UE-47415
#rnx
Change 3518415 by Ben.Zeigler
#jira UE-46574 Deprecate IPlatformChunkInstall::SetChunkInstallDelgate as it was spelled wrong, was only half implemented, and did not support success vs failure
Replace with AddChunkInstallDelegate, which supports a bool error code and is bound once instead of separately for each chunk. All implementations support this delegate at a basic level, although several could be improved to call the failure delegate in more cases
Change 3534339 by Michael.Noland
Platforms: Changed DEPRECATED() macro description to use 4.xx rather than a speciifc version in examples, so it doesn't show up when removing deprecated code
[CL 3544050 by Marc Audy in Main branch]
2017-07-19 09:49:59 -04:00
ensureAsRuntimeWarning ( AsyncTask ) ;
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3510040)
#lockdown Nick.Penwarden
=====================================
MAJOR FEATURES + CHANGES
=====================================
Change 3459524 by Marc.Audy
Get/Set of properties that were previously BPRW/BPRO should error when used
#jira UE-20993
Change 3460004 by Phillip.Kavan
#jira UE-45171 - Fix C++ compilation failures during packaging caused by nativizing a Blueprint that overrides a native function with a 'TSubclassOf' parameter or return value.
Change summary:
- Modified FKismetCompilerContext::CreateParametersForFunction() to pass the 'CPF_UObjectWrapper' flag through to new function parameter properties during Blueprint compilation.
Change 3461210 by Phillip.Kavan
#jira UE-44505 - Fix occasional Blueprint editor crashes that could occur while rebuilding the context menu from the action registry.
Change summary:
- Modified FBlueprintActionDatabase::FActionRegistry to use an FObjectKey as the key type. This allows us to test entries for UObject validity before rebuilding context menu items based on the action database.
- Changed FBlueprintActionInfo::CachedOwnerClass to be a TWeakObjectPtr rather than a raw UClass* since it's based on the ActionOwner, which could potentially become invalid after the OwnerClass has been cached.
- Modified FBlueprintActionDatabase::RefreshAssetActions() to exclude World assets if the WorldType is not EWorldType::Editor. This eliminates an issue with unreferenced "inactive" GC'd world objects being left in the BP action registry after cooking, at which point the keys could become invalid.
- Added FBlueprintActionDatabase::DeferredRemoveEntry() to allow for scheduling removal of entries from outside of the database if they are known to be invalid.
- Modified FBlueprintActionDatabase::Tick() to handle deferred entry removals.
- Modified FBlueprintActionMenuBuilder::RebuildActionList() to both test actions for validity before building menu items and schedule removal of invalid actions on the next tick.
Notes:
- Alternatively we could just include UObject keys in the database's AddReferencedObject impl, but that would then prevent objects from ever being GC'd if they are not explicitly removed. For most entries the action database takes the approach of explicitly removing entries via delegate when the UObject is destroyed, so I chose to use a TWeakObjectPtr instead so that any entries that may not be getting explicitly removed via delegate will now simply become invalidated if the UObject key is GC'd due to not being referenced. I also set it up to clean and remove any entries (along with any associated node spawners) that are found to be invalid the next time we open the BP editor.
Change 3461373 by Lukasz.Furman
fixed async navmesh rebuilds not kicking in for requests from navdata.bForceRebuildOnLoad
#jira UE-44231
Change 3461409 by Lukasz.Furman
fixed reenabling automatic navmesh generation in Editor Preferences
#ue4
Change 3461550 by Ben.Zeigler
#jira UE-45328 Fix local variable support for Redirectors and other save-time validation. We need to run the local variables to UProperty and back at save time
Add new flag PPF_SerializedAsImportText which is used for BP pins/default values and indicates that something has been serialized as import text and so needs to handle string asset redirectors
Change 3462625 by Zak.Middleton
#ue4 - Fix InterpToMovementComponent not setting velocity on the object it moves. Fix movement rate when substepping enabled (other related fixes to come).
github PR #3620
Change 3462796 by Dan.Oconnor
Fix for spamming BroadcastBlueprintReinstanced and for creating CDO at wrong time when compiling FrontEnd.uasset in OrionGame
#jira UE-45434
Change 3462995 by Ben.Zeigler
#jira UE-16941 Fix it so Load Asset node works with a literal value as well as a connected pin
Change 3463099 by Ben.Zeigler
#jira UE-45471 Allow abstract base classes for primary assets
Change 3464809 by Marc.Audy
Expose FVector2D / FVector2D to blueprints
#jira UE-45427
Change 3467254 by Mieszko.Zielinski
Added an AI helper BP function that supplies caller with a copy of navigation path given controller is currently following #UE4
Change 3467644 by Dan.Oconnor
Fix for cook issues in ocean when using compilation manager, one issue caused by bad dependencies list, one issue caused by lack of subobject mapping in archetype reinstancing.
#jira UE-45443, UE-45444
Change 3468176 by Dan.Oconnor
Fix dependent blueprints being marked dirty when a blueprint is compiled
Change 3468353 by Michael.Noland
UnrealHeaderTool: Improved the warning generated when missing Category= on a function or property declared in an engine module, and centralized the logic that determines if the module is engine or game
Change 3470532 by Dan.Oconnor
Re-enable compilation manager
Change 3470572 by Dan.Oconnor
Fix for pin paramters resetting when an archetype was reinstanced
#jira UE-45619
#rnx
Change 3471949 by Mason.Seay
Adding Primary Assets for testing
Change 3472074 by Ben.Zeigler
#jira UE-45140 Convert iterative cooking to use the Asset Registry as it's only mode, remove old hash and timestamp versions. This allows deleting the entire PackageDependencyInfo module
Change the asset registry iteration to not compute a hash at all, and instead store the script package guids in it's cache.
Expose bIgnoreIniSettingsOutOfDateForIteration and bIgnoreScriptPackagesOutOfDateForIteration in cooker settings, affects rather to listen to ini/script changes when doing iterative cooking
Change 3472079 by Ben.Zeigler
With new incremental cook options, change Fortnite to never care about ini settings, but do care about code changes. This can be changed but from previous discussions we wanted to be more safe than fast here
Change 3473429 by Lukasz.Furman
changed path following update tick to allow working on "invalid, update pending" paths, solves AI getting stuck when navigation is rebuild very frequently (e.g. every tick from moving mesh)
#jira UE-41884
Change 3473476 by Lukasz.Furman
changed crowd simulation path update tick to allow working on "invalid, update pending" paths, solves AI getting stuck when navigation is rebuild very frequently (e.g. every tick from moving mesh)
#jira UE-41884
Change 3473663 by Ben.Zeigler
Fix it so base k2node registers framework version, this is needed for the assetptr fixup I previously added
Change 3473679 by Mason.Seay
Slight cleanup of test map and added ability to teleport across level for easy navigation
Change 3473712 by Marc.Audy
Do default value validation against the actual value of the default entry of an enum rather than the serialized empty autogenerated default value
Change 3474055 by Marc.Audy
When nodes are reconstructed any pins that were previously linked or set to non-default values that have been removed will no longer simply vanish, but instead will remain in an Orphaned state until dealt with.
#jira UE-41828
Change 3474119 by mason.seay
Tweaked Force Feedback test
Change 3474156 by Marc.Audy
Actually enable orphan pin retention
Change 3474382 by Ben.Zeigler
Class.h Header and comment cleanup. Started this because IsChildOf did not have a comment and it's usage is a bit confusing
Change 3474386 by Ben.Zeigler
Close popup window when adding asset class to audit window
Change 3474491 by Ben.Zeigler
Remove ability for Worlds to not be saved as assets, this has been the default since 2014.
Change 3475363 by Marc.Audy
Alt-click now works with orphaned pins
#jira UE-45699
Change 3475523 by Marc.Audy
Fixup Fortnite and Paragon content for orphaned pin errors and warnings
Change 3475623 by Phillip.Kavan
#jira UE-45477 - Fix an EDL assertion on load in a nativized build with one or more Actor subobjects instanced via the EditInlineNew UI in the BP class defaults property editor.
Change summary:
- Modified FEmitDefaultValueHelper::OuterGenerate() to emit code to construct/initialize instanced subobject values that do not have the RF_DefaultSubObject flag set, and also to recursively handle nested subobjects for those values.
- Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to alternatively emit a 'NewObject' assignment statement rather than a 'CreateDefaultSubobject' statement if only RF_ArchetypeObject is set on the source object value.
Change 3476008 by Dan.Oconnor
Fix for failing to preload our super class's subobjects. Effectively moving UBlueprint::ForceLoad calls earlier in loading process. This only results in data resetting to your parent's parent's default value from your parent's default value.
#jira UE-18765
Change 3476115 by Dan.Oconnor
Fix missing category information for inherited functions when using compilation manager
#jira UE-45660
#rnx
Change 3476577 by Lukasz.Furman
added early outs from navmesh layer generation when there's no walkable cells or contours to avoid allocating 0 bytes by next generation steps (behavior differs between platforms)
#ue4
Change 3476587 by Phillip.Kavan
#jira UE-45517 - Fix a regression in which dragging UMG widgets around in the designer view results in redundantly-compounded BP class properties and context menu actions.
Change summary:
- Modified SDesignerView::ClearDropPreviews() to move the widget that was removed from the tree into the transient package. This ensures that FWidgetBlueprintCompiler::CreateClassVariablesFromBlueprint() won't pick them up.
- Modified SDesignerView::ProcessDropAndAddWidget() to also consider any widgets not added to the 'DropPreviews' array as being transient (i.e. also move them into the transient package since they were not added to the tree).
Notes:
- The regression was introduced by the changes in CL# 3410168, and was merged to Main at CL# 3431398.
#rnx
Change 3476723 by Dan.Oconnor
Match old behavior wrt updating implemented interfaces in blueprints - this logic from FKismetEditorUtilities::CompileBlueprint was missing in compilation manager
#jira UE-45468
#rnx
Change 3476948 by Michael.Noland
Framework: Changed AActor::FindComponentByClass (and AActor::GetComponentByClass by extension) to return nullptr when passed a nullptr class, rather than crashing
Change 3476970 by Ben.Zeigler
Fix bug I introduced in 4.16 where assigning assets to multiple chunks did not work properly
Change 3477536 by Marc.Audy
Don't display default value box on linked orphaned input pins
Change 3477835 by Marc.Audy
Fix pins orphaned by deletion of an entry in a user-defined enum disappearing instead of remaining connected
#jira UE-45754
Change 3478027 by Marc.Audy
Minor performance optimization
#rnx
Change 3478198 by Phillip.Kavan
#jira UE-42431 - Remove an unnecessary ensure() when pasting an event node.
Change summary:
- Modified UEdGraphSchema_K2::CreateSubstituteNode() to no longer ensure() that we have a valid PreExistingNode; it's only used for logging when a substitute node is created in response to a conflict with an existing node.
Change 3478485 by Marc.Audy
Eliminate extraneous error messages about orphaned pins on get/set nodes
#jira UE-45749
#rnx
Change 3478756 by Marc.Audy
Fix fallout from changes to DoesDefaultValueMatchAutogenerated for user defined enums
#jira UE-45721
#rnx
Change 3478926 by Marc.Audy
Non-blueprint type structs can no longer be made/broken
Non-blueprint visible properties in structs will no longer have pins created for them
#jira UE-43122
Change 3478988 by Marc.Audy
DeltaTime for a tick function with a tick interval is now correct after disabling and then reenabling the tick function.
#jira UE-45524
Change 3479818 by Marc.Audy
Allow ctrl-drag off of orphan pins
#jira UE-45803
Change 3480214 by Marc.Audy
Modifications to user defined enumerations are now transacted
#jira UE-43866
Change 3480579 by Marc.Audy
Maintain all pin properties through transactions.
#rn Reference pins that are removed and then restored via undo now correctly have the diamond icon instead of the standard circle.
Change 3481043 by Marc.Audy
Make/Break of structs does not depend on having blueprint exposed properties.
Splitting of a struct pin still requires blueprint exposed properties.
#jira UE-45840
#jira UE-45831
Change 3481271 by Ben.Zeigler
Fix the AssetManager chunking code to use ChunkDependencyInfo instead of a hardcoded check for chunk 0
Clean up ChunkDependencyInfo and make it properly public
Move ShouldSetManager to be WITH_EDITOR
Ported from WEX branch
#RB peter.sauerbrei
Change 3481373 by Dan.Oconnor
Reduce reliance on expensive FindDelegateSignature. 3275922 made warnings about a ambiguous search more likely as it preserved names of members on the REINST_ classes
#jira UE-45704
Change 3481380 by Ben.Zeigler
Change it so Struct and Object AssetRegistrySearchable properties do not show up in content browser, they are not helpful
Change 3482362 by Marc.Audy
Fix properties not exposed to blueprint warnings for input properties on function graphs.
#jira UE-45824
Change 3482406 by Ben.Zeigler
#jira UE-45883 Fix Switch On Gameplay Tag Container node, and add switch nodes to TagCheck map
Change 3482498 by Ben.Zeigler
Attempt to fix hot reload issues with Asset Manager. We need to reset and re-acquire the asset classes when rescanning, as they may be pointing to the replaced class
Change 3482517 by Lukasz.Furman
fixed smart navlink update functions removing important flag
#jira UE-45875
Change 3482538 by Marc.Audy
When comparing float, vector, and rotator values for whether the the default matches the autogenerated do not use the string compare because differences in use of decimal or number of 0s after decimal are then considered not the same float
#jira UE-45846
Change 3482773 by Marc.Audy
Don't show default value or pass by reference for exec pins
#jira UE-45868
Change 3482791 by Ben.Zeigler
#jira UE-45800 Correctly dirty game mode blueprint when changing player controller/etc classes from game mode customization
Fix it so MarkBlueprintAsStructurallyModified calls MarkBlueprintAsModified as several fixes were only in the second function
Change 3483131 by Zak.Middleton
#ue4 - InterpToMovementComponent:
- Fix velocity not zeroed when interpolation stops.
- Various fixes when calculating velocity and time when substepping is enabled.
- Improve accuracy of interpolation when looping and there is time remaining after the loop event is hit. Consume the remainder of the time after the event back in the loop (similar to handling a blocking impact).
#jira UE-45690
Change 3483146 by Phillip.Kavan
#jira UE-38358 - Propagate 'const' function flag from interface Blueprint to implementing Blueprints.
Change summary:
- Modified FBlueprintEditorUtils::MarkBlueprintAsStructurallyModified() to call SkeletalRecompileChildren() on dependent BPs when the target is an interface BP.
- Modified FBlueprintEditorUtils::MarkBlueprintAsStructurallyModified::FRefreshHelper::SkeletalRecompileChildren() to set child BP status to BS_Dirty after compiling.
- Modified ConformInterfaceByName() (FBlueprintEditorUtils) to use the interface's skeleton class for function iteration as well as to match the Function Entry node's 'const' setting to the interface UFunction's signature.
Change 3483340 by Ben.Zeigler
Fix issue querying asset registry after a hot reload, make sure pending kill objects are never considered to be Assets
Change 3483548 by Michael.Noland
Epic Friday: Playing around with some prototype traps
Change 3483700 by Phillip.Kavan
Fix CIS cook crash introduced by last submit.
#rnx
Change 3485217 by Ben.Zeigler
#jira UE-45519 Fix regression introduced in 4.16 where it would no longer cook all maps when no explicit maps were specified in ini or game callback. Moved the code that detects changes before culture/default map code and hardened it to deal with the case where some engine packages were already in the list before it entered the function
Change 3485367 by Dan.Oconnor
Avoid adding mappings to anim node when creating variables on the skeleton class and using the compilation manager
#jira UE-45756
Change 3485565 by Ben.Zeigler
#jira UE-45948 Fix compilation manager to properly reset variable default values after promoting a pin to local variable
Change 3485566 by Marc.Audy
Fix crashes caused by undo/redo of user defined struct changes
#jira UE-45775
#jira UE-45781
Change 3485805 by Michael.Noland
PR #3459: Fix for world origin shifting and SpringArmComponent location lag (Contributed by michail-nikolaev)
#jira UE-43747
Change 3485807 by Michael.Noland
PR #3485: Added additional textures field to paper 2d tileset class (Contributed by gryphonmyers)
#jira UE-44041
Change 3485811 by Michael.Noland
Framework: Fixed a bug in FStreamLevelAction::MakeSafeLevelName to avoid appending the PIE prefix multiple times (fixes functions like Unload Streaming Level when passed a full package name from an instanced streaming level)
Change 3485829 by Michael.Noland
Framework: Made GetWorldAssetPackageFName BlueprintCallable so instanced levels can be unloaded
Change 3485830 by Michael.Noland
PR #3568: add API declarations to ALevelStreamingVolume methods (Contributed by kayama-shift)
#jira UE-45002
Change 3486039 by Michael.Noland
PR #3495: UE-44014: Refreshing node error fixes (Contributed by projectgheist)
- Empty out the ErrorMsg when a node gets refreshed to prevent the same error messages from compounding
- Added support for split pins in UK2Node_Event::IsFunctionEntryCompatible
- Added a missing check for the delegate pin name on the entry node part of UK2Node_Event::IsFunctionEntryCompatible
#jira UE-44014
Change 3486093 by Michael.Noland
PR #3379: Added GAMEPLAYABILITIES_API to all Ability Tasks. (Contributed by ryanjon2040)
#jira UE-42903
Change 3486139 by Michael.Noland
Blueprints: Added new config options for execution wire thickness when not debugging (DefaultExecutionWireThickness) and data wire thicknesses (DefaultDataWireThickness) to the Graph Editor Settings page
#rn
Change 3486154 by Michael.Noland
Framework: Speculative fix for CIS error about FStructOnScope
#rnx
Change 3486180 by Dan.Oconnor
Better match old logic for determining when to skip data only compile
#jira UE-45830
Change 3487276 by Marc.Audy
Fix crash when using Setter with a locally scoped variable
#rnx
Change 3487278 by Marc.Audy
Ensure that pin change notifications occur on all pin breaks unless it is part of a node being garbage collected
Change 3487658 by Marc.Audy
Ensure that child actor template is created for subclasses
#jira UE-45985
Change 3487699 by Marc.Audy
Move non-templated elements out of FArchiveReplaceObjectRef and put them in FArchiveReplaceObjectRefBase
Change 3487813 by Dan.Oconnor
Asset demonstrating a crash
Change 3488101 by Marc.Audy
Fix crash with spawn/construct actor/object from class nodes when they no longer had any pins.
Correctly orphan pins when a node goes to 0 pins.
Change 3488337 by Marc.Audy
Editable pin base should not manually remove pin and let reconstruct node and rewire pins do their job
#jira UE-46020
Change 3488512 by Dan.Oconnor
ConstructObject nodes and SubInstances nodes use skeleton class when compilation manager can provide it
#jira UE-45830, UE-45965
#rnx
Change 3488631 by Michael.Noland
Framework: Fixed a crash when loading a blueprint with a parent class of ALevelBounds caused by trying to register the class default object with a non-existent level
#jira UE-45630
Change 3488665 by Michael.Noland
Blueprints: Improve the details panel customization for optional pin nodes like Struct Member Get/Set
- The category, raw name, and tooltip of the property are now included as part of the filter text as well
- The property tooltip is now displayed when hovering over the property name
- Code updated to use GET_MEMBER_NAME_CHECKED() where appropriate
Change 3489324 by Marc.Audy
Fix recursion causing stack crash
#jira UE-46038
#rnx
Change 3489326 by Marc.Audy
Fix cooking crash
#jira UE-46031
#rnx
Change 3489687 by mason.seay
Assets for testing orphan pins
Change 3489701 by Marc.Audy
Back out changelist 3487278 and 3489443 and make targetted changes for fixing up orphan pin cases where changing connections doesn't remove the pin.
#jira UE-46051
#jira UE-46052
#rnx
Change 3490352 by Dan.Oconnor
Fix for missing WidgetTree on Skeleton class - just look directly at the WidgetBlueprint
#jira UE-46062
Change 3490814 by Marc.Audy
Make callfunction/macro instances save all pins in orphan state more similar to previous behavior
#rnx
Change 3491022 by Dan.Oconnor
Properly clean up 'Key' property when we fail to create a value property
#jira UE-45279
Change 3491071 by Ben.Zeigler
#jira UE-45981 Fix rotation issues, vector/rotator pins with empty strings were not matching due to uninitialized memory.
Change 3491244 by Michael.Noland
Blueprints: Add compile time message back to the output log (will not auto-open the output log if there were no warnings/errors)
#jira UE-32948
Change 3491276 by Michael.Noland
Blueprints: Fixed some bugs where a newly added item would fail show up in the "My Blueprints" tree if there was a filter active (e.g., when promoting a variable)
- Centralized the logic for clearing the filter so it happens when we try and fail to select the item, rather than ad hoc in various other places
- Made it only clear the filter if necessary, rather than (almost) always clearing it when adding an item
#jira UE-43372
Change 3491562 by Marc.Audy
Put back pin removal in to editable pin base and instead modify the pin destroy implementation to take down child split pins with it
#jira UE-46020
#rnx
Change 3491658 by Marc.Audy
Unify RemoveUserDefinedPin implementations. Use version that has break to avoid size change assert
#rnx
Change 3491946 by Marc.Audy
ReconstructSinglePin no longer destroys OldPin (avoids oprhaned sub pins being destroyed before reparented)
RewireOldPinsToNewPins now destroys OldPins at the end (calling code no longer reponsible)
DestroyImpl now prunes out SubPins that had already been trashed
#rnx
Change 3492040 by Marc.Audy
Discard exec/then pins from a callfunction that has been converted to a pure node
#rnx
Change 3492200 by Zak.Middleton
#ue4 - Always reset the input array in AActor::GetComponents(), but do so without affecting allocated size.
Fixes possible regression from CL 3359561 that removed the Reset(...) entirely.
#jira UE-46012
Change 3492290 by Ben.Zeigler
#jira UE-46108 Fix StringLibrary Mid to never crash, Substring had already been fixed
Change 3492311 by Marc.Audy
Don't clear the pin type if what you're connecting to's pin type is wildcard
#rnx
Change 3492680 by Dan.Oconnor
Handle missing generated class when using compilation manager - tested by forcing compile of BP_ParentClassIsMissingType.uasset
Change 3492826 by Marc.Audy
Don't do pin connection list change notifications from DestroyPins while regenerating on load
#jira UE-46112
#rnx
Change 3492851 by Michael.Noland
Core: Fixed various crashes when using UObject::CallFunctionByNameWithArguments with non-trivial argument types by properly initializing the allocated parameters
Change 3492852 by Michael.Noland
Framework: Fixed a crash if ACharacter::FindComponentByClass was passed a nullptr class
Change 3492934 by Marc.Audy
Fix ensure and crash delete macro containing orphaned pin
#rnx
Change 3493079 by Dan.Oconnor
Fix for crash when opening ThirdPersonAnimBlueprint and ThirdPersonAnimBlueprint_Perf then clicking 'Compile' button in ThirdPersonAnimBlueprint editor. Make sure the convenience members in the derived compilers get set when we relink child classes (which requires making cdos, which requires PropagateValuesToCDO..)
#rnx
Change 3493346 by Phillip.Kavan
#jira UE-40560 - Fix a reported crash when pasting nodes between unrelated Blueprint graphs.
Change summary:
- Modified FEdGraphUtilities::PostProcessPastedNodes() to ensure() on a NULL pin entry; this will allow execution to continue while still alerting us since it is an unexpected result. Also added an 'else' case to then remove the NULL entry so that PostPasteNode() implementations don't all have to guard against NULL pin entries. When the node is reconstructed, the NULL entry will be replaced with the correct pin initialized to its default values.
- Modified UEdGraphPin::ImportTextItem() to add some additional logging to parse error cases when importing pin properties from source T3D text. Hopefully this gives us more information when this is encountered in the future.
Change 3493938 by Michael.Noland
Blueprints: Prevent issues with renaming event dispatchers to contain periods (this may be disallowed in the future, but they no longer become uneditable)
#jira UE-45780
Change 3493945 by Michael.Noland
Blueprints: Fixed GetDelegatePoperty typos
#rnx
Change 3493997 by Michael.Noland
Blueprints: Partially reverting changes from CL# 3319966 to reroute nodes, restoring their alignment but losing the symmetrical grab handle changes
#jira UE-45760
Change 3493998 by Dan.Oconnor
Fix rare crash in RefreshStandAloneDefaultsEditor when the blueprint editor is opened and a blueprint had errors in it
Note: I stumbled across this by running a unit test and then opening a blueprint in the BPE. CrashReporter indicates 3 crashes in the last 3 days
Change 3494025 by Michael.Noland
Engine: Deleted some dead code (DEBUGGING_VIEWPORT_SIZES)
#rnx
Change 3494026 by Michael.Noland
Blueprints: V0 of a BlueprintCallable/BlueprintPure function fuzzer
- Calls exposed methods with default parameters on classes it is able to spawn for now, which catches crashes due to null and /0 but not out of bounds issues or ones on classes it can't spawn due to classwithin, abstract, etc...
- Can be called using Test.ScriptFuzzing, won't be integrated into automated tests until it is more fully fleshed out and all known issues are addressed
#rnx
Change 3496382 by Ben.Zeigler
Fix ensure when launching editor with cook on the side and incremental cooking enabled. It now flushes the background asset gather when calling the sync load all assets if one is in progress
Change 3496688 by Marc.Audy
Avoid crashing in component instance data if (for some reason) the Actor's root component isn't properly set up
#jira UE-46073
Change 3496830 by Michael.Noland
Editor: Change FEditorCategoryUtils methods to take UStruct* instead of UClass*, as they are just reading metadata
#rnx
Change 3496840 by Michael.Noland
Framework: Remove the requirement for a local player in UCheatManager::CheatScript, so it can be be started from the server side (doesn't change the availability of the cheat manager, just allows things like the redundant "cheat cheatscript scriptname" to work)
Change 3497038 by Michael.Noland
Fortnite: Added UFortDeveloperSettings to allow developers to auto-run cheats in PIE (does not occur in -game or outside of WITH_EDITOR builds)
- You can specify a list of cheat commands to run when a pawn is possessed (also needs CL# 3496840 for cheatscripts)
- You can also specify a set of items to grant to your local inventory when it is created
Change 3497204 by Marc.Audy
Fix AbilitySystemComponent not being blueprint readable.
#rnx
Change 3497668 by Mieszko.Zielinski
Fixed a crash in BT editor when dealing with enum-typed Blackboard-keys pointing to enum values that have been deleted #UE4
#jira UE-43659
Change 3497677 by Mieszko.Zielinski
Added a community-suggested working solution to patching up dynamic navmesh after world offset #UE4
Also, fixed a crash related to navmesh rebuilding if generation was configured to lazily gather navigatble geometry
#jira UE-41293
Change 3497678 by Mieszko.Zielinski
Marked AbstractNavData class as transient #UE4
We never want to save it to levels
Change 3497679 by Mieszko.Zielinski
Made NavModifierVolume responsive to editor-time property changes #UE4
#jira UE-32831
Change 3497900 by Dan.Oconnor
Fix bad skel reference when using construct object from class, just limiting scope of 3491946. To reproduce the bug just nativize QA Game, including the TM-Gameplay level
#rnx
Change 3497904 by Dan.Oconnor
Use K2Node_Event::FindEventSignatureFunction in order when directly generating the skeleton generated class to get event params correct
#jira UE-46153
#rnx
Change 3497907 by Dan.Oconnor
Correctly set blueprint visibility flags on params for inherited functions when generating the skeleton class
#rnx
#jira UE-46186
Change 3498218 by mason.seay
Updates to pin testing BP's
Change 3498323 by Mieszko.Zielinski
Made UNavCollision instance assigned to StaticMesh not get re-created from scratch every single time any StaticMesh property changes #UE4
Recreation was resulting in some of the UNavCollision's properties not getting saved and the way we were recreating the nav collision could also interfere with undo buffers
#jira UE-44891
Change 3499007 by Marc.Audy
Allow systems to hook Pre and PostCompile to do custom behaviors
Change 3499013 by Mieszko.Zielinski
Made AbstractNavData class non-transient again #UE4
Implemented AbstractNavData instances' transientness in a different manner.
#jira UE-46194
Change 3499204 by Mieszko.Zielinski
Introduced CrowdManagerBase, an engine-level class that can be extended to implement custom crowd management #Orion
Extracted FRecastQueryFilter into a separate file, which will break some peoples' compilation.
#jira UE-43799
Change 3499321 by mason.seay
Updated bp for struct testing
Change 3499388 by Marc.Audy
Allow the compiler log to store off potential messages from earlier in the compile cycle (early validation), that can be committed later (for example once pruning is completed).
Change 3499390 by Marc.Audy
Generate the orphan pin error messages during EarlyValidation, but cache until the regular validation phase. This ensures all are generated, but only those that aren't pruned will be emitted.
#rnx
Change 3499420 by Michael.Noland
Engine: Introduced a new version of UEngine::GetWorldFromContextObject which takes an enum specifying the behavior on failures and updated all existing uses
The new version intentionally does not have a default value for ErrorMode, callers need to think about which variant of behavior they want:
- ReturnNull: Silently returns nullptr, the calling code is expected to handle this gracefully
- LogAndReturnNull: Raises a runtime error but still returns nullptr, the calling code is expected to handle this gracefully
- Assert: Asserts, the calling code is not expecting to handle a failure gracefully
- Deprecated UEngine::GetWorldFromContextObject(object, boolean) and changed the default behavior for the deprecated instances to do LogAndReturnNull rather than Assert, based on the real-world call pattern
- Introduced GetWorldFromContextObjectChecked(object) as a shorthand for passing in EGetWorldErrorMode::Assert
- Made UObject::GetWorldChecked() actually assert if it would return nullptr (under some cases the old function could silently return nullptr while reporting bSupported = true, so it neither ensured nor checked)
- Fixed a race condition in the 'is implemented' bookkeeping logic in GetWorld()/GetWorldChecked() by confining it to the game thread and added a check() to ImplementsGetWorld() to make it clear that it only works on the game thread
The typical recommended call pattern is to use something like:
if (UWorld* World = GEngine->GetWorldFromContextObject(WorldContextObject, EGetWorldErrorMode::LogAndReturnNull))
{
... Do something with World
}
Handling the failure case but requesting a log message (with BP call stack printed out) if it failed. This is now also the default behavior for old calls to UEngine::GetWorldFromContextObject(Object) (using the default value of bChecked=true), which is a behavior change but it matches how the function was being used in practice; the vast majority of call sites actually expected it to potentially fail and handled the nullptr case gracefully; very few places used the return value unguarded and wanted it to assert when passed a nullptr.
#jira UE-42458
Change 3499429 by Michael.Noland
Engine: Removed a bogus TODO (the problematic code had already been reworked)
#rnx
Change 3499470 by Michael.Noland
Core: Improved and corrected the comment for ensure()
- It doesn't crash when checking is disabled (and hasn't since UE3, maybe ever?)
- It now only fires once per ensure() by default, added a note about ensureAlways()
#rnx
Change 3499643 by Marc.Audy
Use TGuardValue instead of manually managing it
#rnx
Change 3499874 by Marc.Audy
Display <Unnamed> instead of nothing for Pins with blank display name in the compiler log
Change 3499875 by Marc.Audy
When changing function parameter types, don't orphan a pin on the function entry/exit nodes (but do at the call sites)
#jira UE-46224
Change 3499927 by Dan.Oconnor
UField::Serialize no longer serialize's its next ptr, UStruct::Serialize serializes all Children properties instead. This resolves a hard circular dependency between function libraries that EDL detected. It was resolved in an ad hoc way by the old linker
#jira UE-43458
Change 3499953 by Michael.Noland
Core: Created a variant of ensure that does runtime error logging without stopping in the debugger and some related functions that print a warning or error and may trigger a BP callstack (under the same rules as FFrame::KismetExecutionMessage)
- These are WIP and the API may change in the future, but are being used to fix various crashes found by fuzzing BP exposed functions
Change 3499957 by Michael.Noland
Animation: Added runtime errors for nullptr ControlRigs passed into BP methods
#rnx
Change 3499958 by Michael.Noland
Blueprints: Changed an ensure in UKismetNodeHelperLibrary::GetValidValue to a runtime error
#rnx
Change 3499959 by Michael.Noland
Engine: Downgrade various checks() to ensures() in the runtime asset cache functions exposed to Blueprints
Change 3499960 by Michael.Noland
AI: Changed UBTFunctionLibrary to not check/ensure if passed a null world context object
Change 3499968 by Michael.Noland
Editor: Fixed a couple of crashes in UEditorLevelUtils when passed nullptr arguments, and reformatted the entire file to fix widespread indentation issues
#rnx
Change 3499969 by Michael.Noland
Engine: Changed the verbosity of the failure log message of UEngine::GetWorldFromContextObject(..., LogAndReturnNull) from Warning to Error, so it always prints out a BP callstack
#rnx
Change 3499973 by Michael.Noland
Rendering: Fixed asserts in various UKismetRenderingLibrary methods if passed a nullptr for the WorldContextObject
- Also fixed flipped warnings in the failure cases for EndDrawCanvasToRenderTarget
Change 3499979 by Michael.Noland
Editor: Prevented a crash in UMaterialEditingLibrary::RecompileMaterial when passed a nullptr material
Change 3499984 by Michael.Noland
Physics: Prevented a crash in UTraceQueryTestResults::AssertEqual when passed in nullptr for Expected
Change 3499993 by Michael.Noland
Blueprints: Added validation when renaming variables, functions, components, multicast delegates, etc... to prevent names from containing some unacceptable characters
- This validation only kicks in when trying to rename an item, so bad names in existing content are 'grandfathered in'
- These bad names can cause bugs when working with content that contains these characters (e.g., names that contain a period cannot be found via FindObject<T>)
- Currently only . is banned, but eventually we may expand it to include all of INVALID_OBJECTNAME_CHARACTERS
Change 3500009 by Michael.Noland
Blueprints: Made the fuzzer skip classes declared in UnrealEd for now (some of the exposed methods change global state that can cause other tests to fail as the fuzzer isn't particularly sandboxed ATM)
#rnx
Change 3500011 by Michael.Noland
Android: Fixed a crash in UAndroidPermissionFunctionLibrary::AcquirePermissions when called with an empty array on non-Android platforms
Change 3500012 by Michael.Noland
Editor: Prevent a crash in UEditorTutorial::OpenAsset when passed a nullptr Asset
Change 3500014 by Michael.Noland
Engine: Changed FRuntimeAssetCacheFilesystemBackend::ClearCache(NAME_None) to not try to clear all cache directories (there is a separate no-args method for that)
Change 3500019 by Michael.Noland
Core: Fixed some more issues with CallFunctionByNameWithArguments and initializing / destroying parameters
- It was skipping the return value and incorrectly relying on the FirstPropertyToInit list which isn't set for by ref arguments
Change 3500020 by Michael.Noland
Automation: Prevent UFunctionalTestingManager::RunAllFunctionalTests and UFunctionalTestingManager* UFunctionalTestingManager::GetManager from crashing when a manager cannot be created (because we can't route to a world)
Change 3501062 by Marc.Audy
MakeArray AddInputPin is often used as part of node expansion, so need to move the transaction out of the function
Fix inability to undo/redo pin additions to sequence node
Add a K2Node_AddPinInterface to generalize the interface that K2Nodes implement to interact with SGraphNodeK2Sequence so it can be more generally used
#jira UE-46164
#jira UE-46270
Change 3501330 by Michael.Noland
AI: Fix an error on shutdown when the CDO of UAIPerceptionComponent tries to clean up (as it was never registered in the first place)
#jira UE-46271
Change 3501356 by Marc.Audy
Fix crash when multi-editing actor blueprints
#jira UE-46248
Change 3501408 by Michael.Noland
Core: Improve the print-out of FFrame::GetStackTrace() / FFrame::GetScriptCallstack() when there is no script stack (e.g., when FFrame::KismetExecutionMessage is called by native code with no BP above in the call stack)
Change 3501457 by Phillip.Kavan
#jira UE-46054 - Fix crash when launching a packaged build that includes a nativized Blueprint instance with a ChildActorComponent instanced via an AddComponent node.
Change summary:
- Removed UK2Node_AddComponent::PostDuplicate(). This eliminates the creation of redundant component templates that were being unnecessarily created during the Blueprint duplication that precedes the nativization pass.
- Modified SMyBlueprint::OnDuplicateAction() to call MakeNewComponentTemplate() in response to a graph duplication action within the same Blueprint context (replaces previous UK2Node_AddComponent::PostDuplicate() impl).
- Modified FEmitDefaultValueHelper::HandleSpecialTypes() to force AddComponent-based CAC-owned template objects in the emitted codegen to use the UDynamicClass as the Outer when instancing. This matches what we already do for SCS-based CAC-owned template objects - that logic was added in CL# 3270456, and this matches up with FBlueprintNativeCodeGenModule::FindReplacedNameAndOuter(), where we specifically handle CAC-owned template objects.
Change 3502741 by Phillip.Kavan
#jira UE-45782 - Fix undo for index pin type changes.
Change summary:
- Modified SGraphPinIndex::OnTypeChanged() to call Modify() on the pin that was changed.
Change 3502939 by Michael.Noland
Back out changelist 3499927
Change 3503087 by Marc.Audy
Re-fixed ocean content as editor had also changed so had to take theirs and redo
#rnx
Change 3503266 by Ben.Zeigler
#jira UE-46335 Fix regression added in 4.16 where AssetRegistry GetAncesorClassNames/GetDerivedClassNames were not working properly in cooked builds for classes not in memory
Change 3503325 by mason.seay
updated Anim BP to prep for pin testing
Change 3503445 by Marc.Audy
Fix crash caused by OldPins being destroyed before rewiring
#rnx
Change 3505024 by Marc.Audy
Fix NodeEffectsPanel blueprint as it was using pins that no longer existed
#rnx
Change 3505254 by Marc.Audy
Don't include orphan pins when gather source property names
If a property doesn't exist for a source property name just skip the property rather than crashing
#jira UE-46345
#rnx
Change 3506125 by Ben.Zeigler
#jira UE-46311 Fix issues when blueprints are reloaded in place, it needs to remove them from root properly and sanitize the old class. It's still not clear why they are being reloaded in place
Change 3506334 by Dan.Oconnor
Move UAnimGraphNode_Base::PreloadRequiredAssets up to K2Node, make sure nodes get a chance to preload data before compilation manager compiles newly loaded blueprints
#jira UE-46411
Change 3506439 by Dan.Oconnor
Return to pre 3488512 behavior for construct object nodes. This means that we can still get warnings on load when users compile after saving a blueprint, but the current behavior loses default values because it's lookng at the skeleton cdo
#jira UE-46308
Change 3506468 by Dan.Oconnor
Return to pre 3488512 behavior, as it causes bad default values
#jira UE-46414
#rnx
Change 3506733 by Marc.Audy
Use the most up to date class to determine whether a property still exists when adding pins during reconstruction
#jira UE-45965
#author Dan.OConnor
#rnx
Change 3507531 by Ben.Zeigler
#jira UE-46449 Better fix to flush the asset registry queue when the editor requests a synchronous scan at startup. Sometimes it can take a few frames because of file handle delays
Change 3507924 by mason.seay
Sanity save of TM-Gameplay and sublevels to maybe resolve level streaming issues
Change 3507962 by Marc.Audy
Remake changes from CL# 3150796 wiped out by WEX-Staging merge to Main in CL# 3479958
#rnx
Change 3509131 by Dan.Oconnor
Compilation manager compile on load flow never called FindExportsInMemoryFirst, which is critical to prevent reloading of UBlueprintGeneratedClasses when Rename clears the export table
#jira UE-46311
Change 3509345 by Marc.Audy
CVar to disable orphan pins if necessary
#rnx
Change 3509959 by Marc.Audy
Protect against crashing due to large values in Timespan From functions
#jira UE-43840
Change 3510040 by Marc.Audy
Remove all the old unneeded ShooterGame test maps
#rnx
[CL 3510073 by Marc Audy in Main branch]
2017-06-26 15:07:18 -04:00
return AsyncTask ? AsyncTask - > IsDone ( ) : true ;
2015-06-10 03:14:50 -04:00
}
2015-06-19 03:13:33 -04:00
void FRuntimeAssetCache : : Tick ( )
{
FScopeLock ScopeLock ( & SynchronizationObject ) ;
for ( auto Kvp : PendingTasks )
{
if ( Kvp . Value - > IsDone ( ) )
{
Kvp . Value - > GetTask ( ) . FireCompletionDelegate ( ) ;
}
}
}