2019-12-26 14:45:42 -05:00
// Copyright Epic Games, Inc. All Rights Reserved.
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
# include "BoneControllers/AnimNode_LegIK.h"
2023-12-06 14:46:33 -05:00
Copying //UE4/Dev-Build to //UE4/Dev-Main (Source: //UE4/Dev-Build @ 3209340)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3209340 on 2016/11/23 by Ben.Marsh
Convert UE4 codebase to an "include what you use" model - where every header just includes the dependencies it needs, rather than every source file including large monolithic headers like Engine.h and UnrealEd.h.
Measured full rebuild times around 2x faster using XGE on Windows, and improvements of 25% or more for incremental builds and full rebuilds on most other platforms.
* Every header now includes everything it needs to compile.
* There's a CoreMinimal.h header that gets you a set of ubiquitous types from Core (eg. FString, FName, TArray, FVector, etc...). Most headers now include this first.
* There's a CoreTypes.h header that sets up primitive UE4 types and build macros (int32, PLATFORM_WIN64, etc...). All headers in Core include this first, as does CoreMinimal.h.
* Every .cpp file includes its matching .h file first.
* This helps validate that each header is including everything it needs to compile.
* No engine code includes a monolithic header such as Engine.h or UnrealEd.h any more.
* You will get a warning if you try to include one of these from the engine. They still exist for compatibility with game projects and do not produce warnings when included there.
* There have only been minor changes to our internal games down to accommodate these changes. The intent is for this to be as seamless as possible.
* No engine code explicitly includes a precompiled header any more.
* We still use PCHs, but they're force-included on the compiler command line by UnrealBuildTool instead. This lets us tune what they contain without breaking any existing include dependencies.
* PCHs are generated by a tool to get a statistical amount of coverage for the source files using it, and I've seeded the new shared PCHs to contain any header included by > 15% of source files.
Tool used to generate this transform is at Engine\Source\Programs\IncludeTool.
[CL 3209342 by Ben Marsh in Main branch]
2016-11-23 15:48:37 -05:00
# include "Components/SkeletalMeshComponent.h"
# include "DrawDebugHelpers.h"
# include "Engine/Engine.h"
# include "EngineGlobals.h"
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3362413)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3281394 on 2017/02/01 by Chad.Garyet
one more try on the name here, with the extension this time
Change 3286009 on 2017/02/03 by Jon.Nabozny
Fix SkelMeshMerge duplicating Skeleton sockets.
#jira UE-39690
Change 3288374 on 2017/02/06 by Jon.Nabozny
Fix MaterialIndex checks in USkinnedMeshComponent::GetMaterial
Change 3288640 on 2017/02/06 by Jon.Nabozny
#rn Fix UPhysicsConstraintComponent details to allow modification of MaxForce, Stiffness, and Damping for Linear and Angular constraints.
#jira UE-40261
Change 3288978 on 2017/02/06 by Jon.Nabozny
Add code to debug for duplicate sockets in UQAMeshMergeComponent::MergeMeshes.
Change 3290332 on 2017/02/07 by Marc.Audy
Add AnimPhys object version
Change 3290753 on 2017/02/07 by Jon.Nabozny
Update CoM documentation for CoM offset.
#jira UE-40136
Change 3290783 on 2017/02/07 by Jon.Nabozny
Update mass dependent wheel properties in UWheeledVehicleMovementComponent when mass is updated.
#jira UE-39820
Change 3292286 on 2017/02/08 by Jon.Nabozny
Fix OSSNull query filtering.
#codereview: John.Pollard, Josh.Markiewicz, JohnHenry.Carawon
#jira: UE-37512
Change 3294138 on 2017/02/09 by Thomas.Sarkanen
Add more descriptive name for sub-struct members in property tracks
Change 3294139 on 2017/02/09 by Thomas.Sarkanen
Moving to individual structs for limbs
Change 3294140 on 2017/02/09 by Thomas.Sarkanen
Updated base human asset to reflect limb changes
Updated map to just contain the mannequin for now
Updated Sequence to contain some default IK keys
Change 3294178 on 2017/02/09 by Thomas.Sarkanen
Fix shadow variable warning
Change 3294554 on 2017/02/09 by Thomas.Sarkanen
Fixed persistent limb drift issues with non-participant bones
Still have rotational drift with IK chain nodes (still to fix).
Also fixes the addition of initial keys on binding when animating.
Also fixes not being able to pick the widget sometimes when picking nodes in the tree.
Change 3294826 on 2017/02/09 by Chad.Garyet
fixing up busted defaultvalues on physx and precompiled binaries
Change 3294827 on 2017/02/09 by Thomas.Sarkanen
CIS fixes for non-editor and monolithic builds
Change 3296363 on 2017/02/10 by Thomas.Sarkanen
Fix bone drifting
Re-using local transforms then resetting each update pass was accumulating error (via GetRelativeTransform), causing limbs to drift. To address this, simply set the global transform in the case where we know the local transform wont change.
Also optimized the hierarchy API a little & prevented excess work when nothing changes.
Change 3296393 on 2017/02/10 by James.Golding
Add support for clicking on PoseDriver targets in viewport
Change 3296465 on 2017/02/10 by Thomas.Sarkanen
Removed component visualizer (no longer used)
Change 3296467 on 2017/02/10 by Thomas.Sarkanen
Fixed extra keys being made when switching IK/FK mode. Now we only key on user action.
Added ability to hide nodes (advanced setting) and manipualtors (on playback)
Change 3296554 on 2017/02/10 by Thomas.Sarkanen
Fixed up some workflow issues
Widget visibility and the ability to move actors around is now corrected by calling the base FEdMode class functions appropriately.
Added a focus of the chosen actor so orbiting the actor is easier. There is a hitch when we do this (probably because Sequencer is re-initialized the next frame), so we miss the nice transition.
Change 3296621 on 2017/02/10 by Thomas.Sarkanen
Added ability to specify manipulator type when adding
Not exposed in the 'add' UI yet, just enough to allow me to batch-change the ones we have for now
Also tweaked default extents for box manipulators.
Change 3296622 on 2017/02/10 by Thomas.Sarkanen
Changed FK manipulators to boxes
Change 3296740 on 2017/02/10 by James.Golding
Added bOnlyDriveSelectedBones option to PoseDriver
Change 3296957 on 2017/02/10 by James.Golding
Fix AnimNode_PoseHandler using mesh bone index not compact bone index for setting up BoneBlendWeights array
Change 3297092 on 2017/02/10 by Jon.Nabozny
#rn Fix InstancedStaticMesh not properly creating physics state when Stationary.
#JIRA UE-39876
Change 3297160 on 2017/02/10 by Ori.Cohen
Temp fix for physx immediate mode crashing when 0 rows are generated.
Change 3297203 on 2017/02/10 by Ori.Cohen
Temp fix for immediate mode crash when free joints are batched together
#JIRA UE-41026
Change 3297326 on 2017/02/10 by Jon.Nabozny
PR #2965: Update comments in several classes within demo projects to match style present and provide more detail for new users (Contributed by Markyroson)
Changed some of the comment blocks to multiple single line (inside definitions). This is for consistency with our codebase.
#JIRA UE-38981
Change 3297618 on 2017/02/10 by Charles.Anderson
Arcblade - GDC
- Created a new mor polished Phat for this. Probably not gonna use it.
- Created a Ragdoll asset. Need to talk to Ori about getting it working better.
Change 3297799 on 2017/02/10 by mason.seay
Test map for testing audio attenuation
Change 3297940 on 2017/02/10 by Jon.Nabozny
#rn Fix ConstraintComponentVisualizer with AngularOffset.
Needed to apply local transform before world.
#JIRA UE-39597
Change 3297947 on 2017/02/10 by Chad.Garyet
adding automated test build option
Change 3299203 on 2017/02/13 by Thomas.Sarkanen
Fixed local coord system issues with rotation (etc).
Delta transforms are supplied in the space we specify in GetCustomDrawingCoordSystem(), so we now perform our operations in that space, then convert back when applying to the animation.
Fixed up to allow for animating actors with transformed skeletal mesh components.
Also added some proximity scaling to manipulators.
Change 3299220 on 2017/02/13 by Thomas.Sarkanen
Fixed CIS missing include
Change 3299343 on 2017/02/13 by Lina.Halper
Spine twist/roll check in
- control points are disabled
#rb: Thomas.Sarkanen
Change 3299388 on 2017/02/13 by James.Cobbett
Updating QA-Physics map
Change 3299518 on 2017/02/13 by Lina.Halper
fix build issue
#rb: none
Change 3299701 on 2017/02/13 by Ori.Cohen
Add finer grain physx stat information.
Change 3299894 on 2017/02/13 by Ori.Cohen
Added LOD support for immediate mode physics
Change 3299906 on 2017/02/13 by James.Cobbett
Updating QA-Collision map with new test scenarios
Change 3299962 on 2017/02/13 by Ori.Cohen
Fix shadow warning
Change 3300100 on 2017/02/13 by Lina.Halper
- renamed Constraint Axes option to FFilterOptionPerAxis : was going to reuse it for something else but didn't have to but left name changed because it makes more sense
- enable control point reading part
- twist/roll controll is localspace reader - BaseHuman
#rb: none
#code review:Thomas.Sarkanen
Change 3300206 on 2017/02/13 by Ori.Cohen
Rename Ragdoll node to RigidBody node
Change 3300899 on 2017/02/13 by Alan.Noon
Migrating Paragon Origin and Origin Small maps content.
Change 3301279 on 2017/02/14 by Jurre.deBaare
Mesh paint refactor
Change 3301288 on 2017/02/14 by Jurre.deBaare
Incremental CIS fixes
Change 3301290 on 2017/02/14 by Jurre.deBaare
Another CIS fix
Change 3301311 on 2017/02/14 by Thomas.Sarkanen
Fixed non-editor builds
Change 3301313 on 2017/02/14 by Jurre.deBaare
More CIS fixes
Change 3301315 on 2017/02/14 by Jurre.deBaare
Include CIS fix
Change 3301333 on 2017/02/14 by Jurre.deBaare
Non-Unity CIS fixes
Change 3301388 on 2017/02/14 by Benn.Gallagher
CIS fix for cloth create panel
Change 3301445 on 2017/02/14 by Benn.Gallagher
Last few changes over from the mesh paint branch
hooked up LOD dropdown box
Moved asset selection out of details panel
Change 3301527 on 2017/02/14 by mason.seay
Deleting unneeded map
Change 3301531 on 2017/02/14 by mason.seay
Renaming Map to fix naming scheme
Change 3301558 on 2017/02/14 by Ori.Cohen
Fix physx stats not being counted properly as we were not using static data.
Change 3301604 on 2017/02/14 by Ori.Cohen
Fix static analysis warning
Change 3301615 on 2017/02/14 by Jurre.deBaare
All. The. CIS. Fixes
Change 3301630 on 2017/02/14 by mason.seay
Updating Map for testing
Change 3301697 on 2017/02/14 by mason.seay
Final change to map
Change 3301734 on 2017/02/14 by Jurre.deBaare
- Crash CTRL-Z when having cloth painter and paint mode open
- Fill action not being undo-able
- Import vertex colors should default to to-instance
- Paint mode buttons in level painter are now toggle buttons (clarifies UI for user)
Change 3301763 on 2017/02/14 by Jurre.deBaare
- Fix for asset without engine version
- Fix for crash due to missing skeletal mesh permutation in mesh paint view modes
Change 3302421 on 2017/02/14 by Lina.Halper
Fixed issue where spline gets incorrect position when it has many control points.
#rb: Thomas.Sarkanen
Change 3302667 on 2017/02/14 by Lina.Halper
- added spine control points to work
- FK/IK switch isn't working great yet. Don't try
- disabled all twist/roll handling since control point itself can twist also and they were conflicting each other
- added option to add fk nodes, change parnets
- fixed issue with drawing skeleton drawing, when parents weren't added yet.
- Added neck/head/body control
#code review: Thomas.Sarkanen
#rb: none
Change 3303200 on 2017/02/14 by Alan.Noon
Collision shapes for Immediate Mode Ragdolls
Change 3303201 on 2017/02/14 by Alan.Noon
Adding Origin, Full Map
Change 3303477 on 2017/02/15 by James.Golding
Add Get and SetComponentForAxis to FVector and FRotator
Change 3303478 on 2017/02/15 by James.Golding
Add support for multiple source bones to PoseDriver
Change 3303480 on 2017/02/15 by James.Golding
Added per-scene frame number, handles cases like motion blur caching.
Refactored GPUSkinCache to have an explicit frame advance function, called after all viewports have rendered in game/editor, PostRenderAllViewportClients.
(Original author Chris.Bunner)
Change 3303513 on 2017/02/15 by Jurre.deBaare
CIS: Linux file name case fixes and incorrect pragma once
Change 3303576 on 2017/02/15 by Thomas.Sarkanen
Sub-sequence sections can now override how they instance their template
Added UMovieSceneSubSection::GenerateTemplateForSubSequence. This just performs the original call to SubSequenceStore.GetCompiledTemplate in the dcefault case.
Allowed non-const access to FMovieSceneEvaluationTemplate::GetTracks so they can be potentially modified once instanced.
Added access for FMovieSceneEvaluationTrack::ChildTemplates.
Change 3303578 on 2017/02/15 by Thomas.Sarkanen
Rich curves can now be transformed post-copy correctly
Using GetKeyIterator rather than aquiring the iterator directly makes sure we have valid key handles, which we dont if we have just copied the curve.
Change 3303579 on 2017/02/15 by Thomas.Sarkanen
Added GetLinkNode to complement SetLinkNode in FAnimNode_Base
Change 3303580 on 2017/02/15 by Thomas.Sarkanen
Made the logic around when sub-tracks can be primed for recording more specific
Prevents rig control sub tracks form being able to be primed.
Change 3303581 on 2017/02/15 by Thomas.Sarkanen
Allowing alpha on rig tracks to work
Alpha curve is now pushed down to tracks on template compilation along with bone masks & additive flag.
Sequencer anim instance updated to use new flags. Structure altered to accomodate layered blending for masked body parts (should probably push this to the regulat sequence instance too).
Moved anim node to local space (now it is just derived form FAnimNode_Base).
Also fixed opening/binding order issues - Now you should be able to open a sequence, bind to an actor and create a new rig control in a sequence in any order.
Change 3303582 on 2017/02/15 by Thomas.Sarkanen
Fixed UE4Game CIS - Moved AddConstraint() to non-editor-only
Also fixed crash in property chain iteration (for non-existent array properties)
Change 3303594 on 2017/02/15 by Jurre.deBaare
Fix for crash on deleting painted actors
Change 3303636 on 2017/02/15 by Lina.Halper
-remove temp code to add constraints. - they serialize, so once you add them you don't have to add these anymore.
This will move to editor menu soon.
#rb: none
Change 3303648 on 2017/02/15 by Martin.Wilson
Fix reimport crashes if the animation uses additive transform tracks.
#jira UE-41929
#jira UE-41921
Change 3303652 on 2017/02/15 by Benn.Gallagher
Added merged Ice mesh with new simulation mesh to match mesh from APEX version.
Change 3303660 on 2017/02/15 by Benn.Gallagher
map update for clothing demo
Change 3303662 on 2017/02/15 by Benn.Gallagher
State machine update for Ice anim
Change 3303676 on 2017/02/15 by mason.seay
Adjusted sound actor location
Change 3303689 on 2017/02/15 by Benn.Gallagher
Updated Ice mesh to have clothing present on the back part of the dress
Change 3303691 on 2017/02/15 by Jurre.deBaare
CIS fixes for pose driver details
Change 3303704 on 2017/02/15 by Lina.Halper
Add FK limb links
- enabled temp code to add constraints. It's not serialized from BP editor, so this has to be added everytime. Will fix this in the futre check-ins
#rb:none
Change 3303716 on 2017/02/15 by Thomas.Sarkanen
Updated manipulators to always draw in front of the mesh
Added material & enabled content for the plugin.
Change 3303730 on 2017/02/15 by thomas.sarkanen
Resaving manipulator material with correct engine version
Change 3303754 on 2017/02/15 by Thomas.Sarkanen
Fix manipulators popping to max size when manipulating
Change 3303835 on 2017/02/15 by Thomas.Sarkanen
Fix hitch by not displaying spawned objects if we dont have a sequence focused.
Change 3303843 on 2017/02/15 by Lina.Halper
Added normalize rotation on inputs/outputs
#code review: Thomas.Sarkanen
#rb: none
Change 3303916 on 2017/02/15 by Jurre.deBaare
CIS: Linux incorrect pragma once
Change 3304084 on 2017/02/15 by James.Golding
Update pose driver test after addition of multi-bone input
Change 3304188 on 2017/02/15 by James.Golding
Add custom remap curve option per-target in PoseDriver
Change 3304189 on 2017/02/15 by James.Golding
Fix CIS for ControlManipulator.cpp
Change 3304210 on 2017/02/15 by Alan.Noon
Added hidden collision objects for stairs area. Added brighter lighting on plinth area. Hooked up minion placement randomization. Added 100 minions to minion level for ragdol
Change 3304327 on 2017/02/15 by Alan.Noon
Created new Persistent levels for each Anim Tech demo, which loads in Origin_Small_P
Change 3304337 on 2017/02/15 by Alan.Noon
renamed minion demo level for GDC
Change 3304508 on 2017/02/15 by Lina.Halper
- You can see constraints in the tree view (full edit mode)
- YOu can add or update constraints (using update constraints button)
- You can delete constraints
- Cleaned up constraints interface
#rb: none
#code review: Thomas.Sarkanen
Change 3304537 on 2017/02/15 by chris.evans
!N Initial PSD test [chrise]
Change 3304551 on 2017/02/15 by James.Golding
Fix missing 'break's from SetComponentForAxis in FVector and FRotator
Change 3304570 on 2017/02/15 by Chris.Evans
!N Source assets for psd test
#RB none
Change 3304964 on 2017/02/15 by Lina.Halper
fix build issue
#code review: James.Golding
#rb: none
Change 3304998 on 2017/02/15 by Chris.Evans
!B Checking in correct FBX
#RB none
Change 3305314 on 2017/02/15 by chris.evans
!N Adding materials driven
!N Adding 'simulation' animation which simulates the driven result
Change 3305355 on 2017/02/15 by chris.evans
!N Initial test shoulder pose
Change 3305357 on 2017/02/15 by chris.evans
!N Initial Mambo shoulder ROM
Change 3305446 on 2017/02/15 by Lina.Halper
fixed CIS error
#rb: none
#code review: Thomas.Sarkanen
Change 3305768 on 2017/02/16 by Jurre.deBaare
CIS: Clang compile errors
Change 3305857 on 2017/02/16 by thomas.sarkanen
Removed particle systems from top plinth as they interfere with selection and obscure demo somewhat.
Change 3305907 on 2017/02/16 by Thomas.Sarkanen
Fix hitches on selection of multiple keys
Prevented multiple seleciton callbacks being called for each key (we now just edit the selection then broadcast later).
Dont force the details panel to refresh if nothing has changed.
Make sure we make a list of unique object IDs when processing the selection delegate, as we get an object ID per track.
Change 3305910 on 2017/02/16 by Thomas.Sarkanen
Allow multiple instances ot the same parameterized subsequence to exist and function correctly
Subsequences in the store are now keyed off an optionally specified 'other' object. In the case of parameterized subsequences, this object is the section.
Editor only right now - cooked builds are still to come
Change 3305911 on 2017/02/16 by Thomas.Sarkanen
Fix NaNs from uninitialized poses
Change 3305922 on 2017/02/16 by Thomas.Sarkanen
BuiltData for Origin_Small_P
Change 3305927 on 2017/02/16 by Thomas.Sarkanen
Moved ControlRig->ControlRigDemo in preparation for keeping all assets in one folder
Added some test assets
Change 3305928 on 2017/02/16 by Thomas.Sarkanen
Dont select actors when we bind to them
Selection can sometimes look bad and obscure the character.
Change 3306118 on 2017/02/16 by Thomas.Sarkanen
CIS fix
Change 3306230 on 2017/02/16 by Jurre.deBaare
CIS fix for linking errors on specific platforms
#test compile PS4 OrionGame
Change 3306378 on 2017/02/16 by Martin.Wilson
First pass Live Link system (Initially from //Tasks/UE4/Dev-Causeway)
- Live Link Maya plugin build files (builds a .mll file that can be loaded into Maya)
- Live Link Interface (editor module with interface files)
- Live Link Message Bus Framework (editor module with files needed for building message bus based live link plugins)
- Live Link (experiemental plugin that contains editor part of live link system)
Change 3306388 on 2017/02/16 by Lina.Halper
- build issue fix
- also tweaked display name to display only node name in editing mode
#rb: none
Change 3306455 on 2017/02/16 by Jon.Nabozny
#rn Perf improvements to FAnimNode_RigidBody.
Cache bounds to prevent unnecessary overlap updates.
Move overlaps off game thread.
Change 3306591 on 2017/02/16 by Martin.Wilson
Updates to live link
- Copyright changes (some were still 2016)
- Rename BlankMayaPlugin to LiveLinkMayaPlugin
Change 3306907 on 2017/02/16 by Jon.Nabozny
MinionDemo Content Perf Pass.
Change 3306914 on 2017/02/16 by Thomas.Sarkanen
Back out changelist 3305857 and 3305922
Reverts particle system changes to Origin_Small_P
Change 3306942 on 2017/02/16 by Martin.Wilson
Live link demo content
-Feng mao mesh that matches maya scene
- LiveLinkGDC Map
- Beginning of camera control sequencer
Change 3307154 on 2017/02/16 by Alan.Noon
Merged in new content to fix badly collapsed BP Static meshes deleted ragdoll minions for new posing. Stopped animation on spawn pad materials
Change 3307382 on 2017/02/16 by Martin.Wilson
Fix CIS (Add virtual destructor to ILiveLinkSource)
Change 3307497 on 2017/02/16 by chris.evans
!N Moving mats
Change 3307541 on 2017/02/16 by Chris.Evans
!B Rebuilding test assets with new skeleton
Change 3307873 on 2017/02/16 by Chris.Evans
!N Mambo updates
Change 3307875 on 2017/02/16 by Chris.Evans
!R Update to blueprint
Change 3308030 on 2017/02/16 by Alan.Noon
Changed lighting of Origin_Small_P based on feedback. Placed new objects were previous were exhibiting bad lightmaps.
Change 3308246 on 2017/02/16 by Alan.Noon
Consolidated new lighting content from sublevels into Origin_Small_P. Hooked up Physics asset to ArcBlade Skeletal mesh
Change 3308470 on 2017/02/16 by Lina.Halper
- make sure all are hooked up properly to pelvis and spine_03
- no multiple pelvis anymore. Using one to tweak all of them. all limbs are connected through constraints
- make sure end effector rotation is modifying IK's last chain rotation
- had to hack for saving offset for IK/FK switch mode but it works fine
- fixed lots of constraint issue with deleting node, parent constraints. Added new spine after that fix.
#rb:none
#code review: Thomas.Sarkanen
Change 3308764 on 2017/02/17 by Jurre.deBaare
Fix for non-unity Orion game build
Change 3308774 on 2017/02/17 by Thomas.Sarkanen
Added multi-selection of manipulators
Allowed BoxSelect, FrustumSelect and SelectNone to be overriden by the edit mode. Our edit mode doesnt have a sub-tool, it handles everything itself.
Also fixed manipulators drawing in front of widget
Changed manipualtors to be world-relative rather than screen relative scaled.
Tweaked proximity to be stateful so we only highlight the closest node
Also fixed slow FPS when dragging.
Change 3308802 on 2017/02/17 by James.Golding
Fix 'apply custom curve' for pose driver targets being on by default
Change 3308824 on 2017/02/17 by Lina.Halper
Fix build issue
#code review:Thomas.Sarkanen
#rb: none
Change 3308851 on 2017/02/17 by James.Golding
Add new control manipulator picking UI
Change 3308863 on 2017/02/17 by Martin.Wilson
Enable Live Link plugin in AnimTechDemo
Change 3308880 on 2017/02/17 by Thomas.Sarkanen
Getting instanced subsequences working in cooked builds
Change 3309009 on 2017/02/17 by Benn.Gallagher
Mask support and UI, not hooked up to painter yet
Added clothing tools experimental flag and hooked up
Change 3309016 on 2017/02/17 by Martin.Wilson
Clean up engine provided output devices and supply a Maya one, stops Maya hanging on shutdown
Change 3309108 on 2017/02/17 by Jurre.deBaare
CIS fix: missing definition of FWeakObjectPtr (strangely not part of CoreMinimal)
Change 3309134 on 2017/02/17 by Jurre.deBaare
Crash in texure painting mode
#fix Required some extra checks for new setup (can only paint while having one mesh selected)
Issue with vertex paint propagating to lower LOD levels
#fix There was no setup to propagate colors from source static mesh data so added the path
#misc Re-added flow painting and removed flow-strength property
#misc Added detail customization for texture paint UV channel
Change 3309256 on 2017/02/17 by Benn.Gallagher
CIS fix
Change 3309393 on 2017/02/17 by James.Golding
Set color for kinematic controls
Change 3309410 on 2017/02/17 by Ori.Cohen
PR #3221: Kinematic body interpolation in substepping causes invalid raycasting/sweeping/overlapping (Contributed by PhoenixBlack)
Change 3309469 on 2017/02/17 by Benn.Gallagher
Added ContentExamples cloth assets
Added camera transitions and controls
Cleanup logic
Move characters and materials onto upper plinth
Hid actor mesh from game view.
Change 3309625 on 2017/02/17 by mason.seay
Resaving assets to remove warnings
Change 3309802 on 2017/02/17 by Alan.Noon
Modified Origin_Small_P lighting. Set up ArcBlade for presentation
Change 3309985 on 2017/02/17 by Thomas.Sarkanen
Fixed crash adding multiple rigs to sequence
If a hierarchy is empty, dont attempt to access a non-existent node
#jira UE-42103
Change 3310209 on 2017/02/17 by Lina.Halper
- Fix limbs detaching issues
- added set translation to override translation
- moved joint targets away from the limbs
- Spine FK is on by default
- spnie IK/FK switch should work better. It can still pop depending on your control point can handle or not.
#rb: none
Change 3310389 on 2017/02/17 by Chris.Evans
!N Mambo multi-joint pose demo
Change 3310911 on 2017/02/18 by Lina.Halper
Ice/Mambo mapping fix with BaseHuman
Change 3311138 on 2017/02/19 by James.Golding
- Allow multi-select in control picker
- Clicking on background clears selection
- Add 'Select All' button
- Darken controls that are disabled (is in different kinematic mode)
- Use selection color from control instead of outline
- Center and fit picker to details panel width
- Remove entire Nodes section of edit mode panel (not just tree)
- Fix rig properties not scrolling
- Place picker in expandable area, collapsed when no rig selected
Change 3311147 on 2017/02/19 by Thomas.Sarkanen
Fix spine keying
Add the ablity for array elements to be keyed directly. The spine properties are FTransforms in an array and previously it ignored them because of assumptions about allowed structures.
This should probably be refactored to a more generic 'traverse up my property chain looking for Interp properties' at some point in the future.
Change 3311150 on 2017/02/19 by Thomas.Sarkanen
Synchronizing sequencer selection
Now enter key works for keying selected tracks
Added new way to select sequencer tracks externally via property paths.
Change 3311152 on 2017/02/19 by Thomas.Sarkanen
Missed files
Change 3311153 on 2017/02/19 by Thomas.Sarkanen
CIS fixes
Change 3311154 on 2017/02/19 by Thomas.Sarkanen
File I missed (CIS fix)
Change 3311156 on 2017/02/19 by James.Golding
Change 'ControlRig Edit Mode' icon
Change 3311176 on 2017/02/19 by Lina.Halper
Fix build issue
#rb:none
#code review: Thomas.Sarkanen, Jurre.DeBarre, James.Golding
p.s. not sure who's code, so just adding everybody I can think of
Change 3311261 on 2017/02/19 by Lina.Halper
- Fixed an issue when you don't have parent in the rig
- get all component space, and convert to local
#rb:none
#code review: Thomas.Sarkanen
Change 3311282 on 2017/02/19 by Lina.Halper
Fixed issue where pivot location is incorrect when mapping to other meshes
#rb: none
#code review:Thomas.Sarkanen
Change 3311491 on 2017/02/20 by Thomas.Sarkanen
CIS fix
Change 3311497 on 2017/02/20 by Jurre.deBaare
Game editor compile error
#fix WITH_EDITORONLY_DATA instead of WITH_EDITOR ifdef around UPROPERTY
Change 3311507 on 2017/02/20 by Jurre.deBaare
Cloth paint progress
- Different approach / refactored out paint ray retrieval
- Added key input callback to IMeshPainter and derived classes
- Added toggle for showing invisible vertices
- Added gradient paint tool
- Details customization for brush/gradient tool settings
- Some cleaning
Change 3311527 on 2017/02/20 by Jurre.deBaare
CIS header guard warning
Change 3311530 on 2017/02/20 by Jurre.deBaare
CIS dereferencing possible nullptr warning
Change 3311533 on 2017/02/20 by Jurre.deBaare
CIS dereferencing warning (better fix)
Change 3311543 on 2017/02/20 by James.Golding
Add buttons for switching IK/FK mode of limb/spine to picker
Put picker and details panel in a scroll box
Fix spine manipulators not being hidden when disabled
Change 3311649 on 2017/02/20 by James.Golding
R key now toggles manipulator visibility
Change 3311707 on 2017/02/20 by Lina.Halper
Added Clavicle FK controls
#code review: Danny.Bouimad
Change 3311764 on 2017/02/20 by Martin.Wilson
Update cameras for Live link demo map and turn on recompute tangents on Feng Mao
Change 3311858 on 2017/02/20 by Chris.Evans
!R Updated with pose values
Change 3312043 on 2017/02/20 by Jon.Nabozny
Change SkelMeshMerge logic to fix duplicates (again) and fix crash.
#jira UE-39690, UE-42146
Change 3312046 on 2017/02/20 by Thomas.Sarkanen
Fix crash drag/dropping skeletal mesh
#jira UE-42139 - Crash when adding SK_Mannequin to a Level Sequence in QAGame
Change 3312052 on 2017/02/20 by James.Golding
Change manipulator colors to red for right, blue for left, white for middle
Change IK/FK switch buttons to yellow/purple
Move picker buttons to take up less horizontal space
Move IK/FK switch button positions out of C++
Change 3312137 on 2017/02/20 by Ben.Marsh
Fix settings for using precompiled binaries in Dev-AnimPhys.
Change 3312517 on 2017/02/20 by Alan.Noon
Created new persistent level for Chris E's demo. Placed a few minions for CharlesA to test improved ragdoll asset. Tuned lighting in Origin_Small_P and fixed light leaks.
Change 3312570 on 2017/02/20 by Charles.Anderson
More work on Arcblade Ragdoll for GDC
Change 3312594 on 2017/02/20 by Alan.Noon
MultipleJointPoseDriving_GDC_P_pose_test_level
Change 3312637 on 2017/02/20 by Alan.Noon
Reconciling offline content
Change 3312902 on 2017/02/20 by Charles.Anderson
Minions for GDC
Change 3313206 on 2017/02/20 by Ori.Cohen
Added trimesh support for immediate mode.
Change 3313247 on 2017/02/20 by Chris.Evans
!N updated with both demo assets in one map
Change 3313447 on 2017/02/20 by Ori.Cohen
Fix immediate mode collision not working with convex transforms being baked in
Change 3313472 on 2017/02/20 by Ori.Cohen
Fix crash caused by missing switch case break
Change 3313518 on 2017/02/20 by Lina.Halper
IK knee issue/Twist issue
#code review: Thomas.Sarkanen, James.Golding
#rb: none
Change 3313547 on 2017/02/20 by Lina.Halper
Fixed Body-Ctrl to work with every node.
Change 3313617 on 2017/02/20 by Lina.Halper
- Fix for limbs delaying when moving BodyCtrl
- Fix for additive issue for control rig anim node
#rb: none
#code review: Thomas.Sarkanen
Change 3313618 on 2017/02/20 by Lina.Halper
remove unnecessary calc
#rb:none
Change 3313625 on 2017/02/20 by Lina.Halper
Fixed body ctrl move keys
- all IK keys also have to be in local space (but they're local to body_ctrl)
Change 3313633 on 2017/02/20 by Alan.Noon
Quick laying out of Minions for stress testing. Iterated on Environment collision.Built lighting
Change 3313655 on 2017/02/20 by Lina.Halper
- Fixed so that you can tweak pelvis and move body also
- Fixed mambo mapping
Change 3313897 on 2017/02/21 by James.Golding
Make all FK manipulators smaller (3 instead of 4.5)
Change 3313898 on 2017/02/21 by James.Golding
Integrate CL 3311876 to Dev-AnimPhys (original author Rolando.Caloca)
DR - Expose skin cache cvar r.SkinCache.AccumulationBufferSizeInKB
Change 3313902 on 2017/02/21 by James.Golding
Draw lines from IK target to mid-joint
Change 3313906 on 2017/02/21 by Thomas.Sarkanen
Fix undo/redo/save t-pose and crashes
Binding now only does what it needs to do an no more (i.e. force a reig evaluation and re-select the rig we are looking at).
Object spawner now does not root its objects. Rather it hangs them off of a 'holder' object so that they can exist safely in the transaciton buffer.
Change 3313938 on 2017/02/21 by Benn.Gallagher
Migrated clothing assets
Change 3313982 on 2017/02/21 by James.Golding
Fix static analysis in ClothPainter.cpp
Change 3313985 on 2017/02/21 by Benn.Gallagher
Fixed crash when attempting to create clothing with degenerate triangles. Now a log error and toast warn the user of conincident tri points.
#jira UE-41935
#rnx
Change 3314052 on 2017/02/21 by James.Golding
Fix CIS in ControlRigEditModeSettings.cpp
Change 3314100 on 2017/02/21 by Lina.Halper
IK fix for retargeting
- using rig transform and remapping doesn't work. I'll have to use mesh space for IK at least. It still does blend in rig space, though with FK.
#rb: none
Change 3314160 on 2017/02/21 by Thomas.Sarkanen
Added optional node trajectories
Added trajectory cache which uses similar mechanisms to the thumbnail cache to build trajectories for nodes.
Builds trajectories and their meshes incrementally when relevant things change
Change 3314167 on 2017/02/21 by James.Golding
Fix undo when pushing IK/FK toggle buttons
Change 3314168 on 2017/02/21 by Benn.Gallagher
Disabled skin cache on tech demo project
Change 3314290 on 2017/02/21 by Lina.Halper
- Cleaned up code a bit
- Fixed thigh to rotate to target and fixed a bug that caused jittering
#rb: none
Change 3314418 on 2017/02/21 by Thomas.Sarkanen
Fix CIS issue
Change 3314428 on 2017/02/21 by Thomas.Sarkanen
Fixup anim node to be of correct editor-time type
Caused crash when placed in an anim BP
Change 3314574 on 2017/02/21 by Thomas.Sarkanen
Fixed crash on shutdown
#jira UE-42214
Change 3314705 on 2017/02/21 by Alan.Noon
Iterating on map collision. Made minion weapon joint unbreakable
Change 3314722 on 2017/02/21 by Alan.Noon
Moved minions back into Minion demo Persistent level.
Change 3314778 on 2017/02/21 by Lina.Halper
added neck/ball_r/l control
#code review: Daniel.Bouimad
Change 3314908 on 2017/02/21 by Ori.Cohen
Temp fix for cloth bounds issue.
Change 3314920 on 2017/02/21 by Alan.Noon
Placing minions. Iterating collision
Change 3314970 on 2017/02/21 by Lina.Halper
added bone picker for toes, neck
Change 3315006 on 2017/02/21 by Benn.Gallagher
Fixed clothing bounds issue with empty simulations.
Change 3315017 on 2017/02/21 by Lina.Halper
fix crash on null proxy
#rb: Benn.Gallagher
Change 3315054 on 2017/02/21 by Alan.Noon
Placing minions
Change 3315671 on 2017/02/21 by Chris.Evans
!B Fixed default material
!N Added physics subgraph for Mambo
!N Added third 'gameplay' complex example
Change 3315693 on 2017/02/21 by chris.evans
!N Enabling tangent recompute on Mambo face and arm pits.
Change 3315838 on 2017/02/21 by Alan.Noon
New Orbital Laser Pawn. New ragdoll sublevels for minion demo (400 minions)
Change 3316206 on 2017/02/22 by Thomas.Sarkanen
Fix shadowed variables
Change 3316207 on 2017/02/22 by Thomas.Sarkanen
Manipulators are now transparent
Change 3316258 on 2017/02/22 by Jurre.deBaare
- Fix for changing levels while force painting to a specific LOD
- Brush depth not same as in main
Change 3316259 on 2017/02/22 by Jurre.deBaare
Fix for paint verts being rendered outside of painting area
#misc want to change underlying behaviour for the brush representation but this'll patch it up for now
Change 3316260 on 2017/02/22 by Jurre.deBaare
Changed default paint brush settings
Change 3316267 on 2017/02/22 by Jurre.deBaare
Added channel paint flags to texture painting settings
#misc might want to create base class for common paint settings
Change 3316268 on 2017/02/22 by Jurre.deBaare
Fix for issue with viewport color mode not being reset when exiting mesh paint mode
#jira UE-42221
Change 3316278 on 2017/02/22 by James.Golding
Fix crash when pose asset contains a bone that is not in the mesh
Change 3316304 on 2017/02/22 by Thomas.Sarkanen
Prevent sequencer from reselecting tracks when keys are selected
Also fixed crash concurrently modifying an itterating TSet when removing selection nodes.
Also made manipualtors not grow and shrink when transacting.
Also tweaked sequencer selection to not allow movement of infinite areas - this allows us to start drag-selecting over these tracks rather than trying to move a seciton that cannot be moved.
#jira UE-42164
Change 3316325 on 2017/02/22 by James.Golding
Hook up Mambo physics as 'Pose Process AnimBP'
Change 3316384 on 2017/02/22 by James.Golding
Slow down mambo anim playback rate
Change 3316385 on 2017/02/22 by Jurre.deBaare
CIS: Deprecation warning fix
Change 3316424 on 2017/02/22 by Lina.Halper
#fix : control rig mapping fix for Mambo
#lockdown: James.Golding
Change 3316525 on 2017/02/22 by Lina.Halper
- Fixed so that the mapping happening with retarget base pose, not ref pose
- Added refresh mapping option for all nodes to refresh bone transform - in case you change retarget base pose
- WIP of fingers, don't think we'll make it to demo, but it is still wip going in.
#lockdown: James.Golding
#rb: none
#code review: Thomas.Sarkanen, James.Golding
Change 3316684 on 2017/02/22 by Lina.Halper
fix shadow warning
#rb: none
#lockdown: james.golding
Change 3316748 on 2017/02/22 by Thomas.Sarkanen
Fix t-pose bindings in various demo workflow situations
Fix a crash when clearing actor
Fix t-pose when opening a new sequence over an old one
Fix t-pose on save
Note: Added a couple of 'nuke it from orbit' re-binds to the actor because some code paths were not correctly setting up all of our data. Particularily we were always setting up the anim instance. We should revisit this after GDC.
#jira UE-42136
Change 3316895 on 2017/02/22 by Jurre.deBaare
Incorrect simulation verts getting painted
#fix added an early rejection test
#misc fixed sqrd vs non-sqrd check
#misc level painting already did this in other specific code
Change 3316917 on 2017/02/22 by thomas.sarkanen
Disabling threaded update on Mambo's post process anim BP
We dont support running the main BP non-threaded and the post process threaded right now.
Change 3316933 on 2017/02/22 by Thomas.Sarkanen
Fixed linux shadow variable warning
Change 3317104 on 2017/02/22 by Chris.Evans
!N Initial animation with face
Change 3317483 on 2017/02/22 by Alan.Noon
Added controls to resize the Orbital Laser Impulse in the minion demo
Change 3317592 on 2017/02/22 by Alan.Noon
Tweaking Parameters on orbital Laser Pawn
Change 3317608 on 2017/02/22 by Lina.Halper
Sorry - missed this files from previous check-in
It should have gone with CL 3316525
#rb:none
#code review:Thomas.Sarkanen, James.Golding
#lockdown: James.Golding
Change 3317762 on 2017/02/22 by Lina.Halper
- allow dependency array to be added by IK effectors - but this isn't actual bug in this case
- the bug was property was overriding the value, so we'll have to make sure to update property from code change (bForceUpdatePropertyInTheNextTick)
#rb:none
#code review: Thomas.Sarkanen, James.Golding
#lockdown: James.Golding
Change 3317807 on 2017/02/22 by Martin.Wilson
Update for Live link code
-Rename Maya Source to Message Bus Source
-Fix typo in ReceiveClient function name
Change 3318031 on 2017/02/22 by Alan.Noon
100 more minions in a sublevel. Tuned new pawn. Added sound, particle effects to impulse
Change 3318217 on 2017/02/22 by Jon.Nabozny
Re-enable Dynamic Shadows for minions. Also enable Single Sample Shadow for perf reasons.
Change 3318365 on 2017/02/22 by Alan.Noon
Created new shadow capsule asset for minion. Disabled DOF.
Change 3318421 on 2017/02/22 by Alan.Noon
Adding more minion anims for variety
Change 3318435 on 2017/02/22 by Alan.Noon
Tweak to minion anim BP: minions pick and idle and stay with it.
Change 3318860 on 2017/02/23 by James.Golding
Force update nodes and manipulators when changing IK/FK mode
Better fix for UE-42257
Change 3318869 on 2017/02/23 by James.Golding
Key limb manipulators when switching IK/FK mode
Change 3318870 on 2017/02/23 by James.Golding
Fix head button picker location
Change 3318875 on 2017/02/23 by James.Golding
Add 'T' key shortcut for toggling trajectory drawing
Change 3318907 on 2017/02/23 by Benn.Gallagher
Added rail for clothing sheet examples
Change 3318909 on 2017/02/23 by Thomas.Sarkanen
Fix trajectories jittering as they generate
The rig needs ticking twice because of what looks like some stateful assumptions that were recently made.
Basically to get the rig to a state it needs ticking more than once.
This also means that we need to tick sequencer twice to make sure the rig state gets pushed to the anim instance too.
This may be to do with the latent IK/FK switching, and needs to be investigated.
For now, I'm leaving it like this but its not ideal because it makes the trajectory generation twice as expensive.
Change 3318929 on 2017/02/23 by James.Golding
Make PoseDriver Details not assume there is always a posedrivernode (fix potential crash during demo)
Change 3318930 on 2017/02/23 by James.Golding
Resave pose_test_level with camera in better default position
Change 3318969 on 2017/02/23 by thomas.sarkanen
Added demo map with mannequin and mambo
Change 3318975 on 2017/02/23 by thomas.sarkanen
Improved embededed test sequence
Kept blends away from initial binding because of t-pose issues
Change 3318979 on 2017/02/23 by thomas.sarkanen
Added sequence showing retargeting to multiple skeletons
Change 3318983 on 2017/02/23 by thomas.sarkanen
Improved retargeting sequence so that loop points dont pop animation
Change 3318991 on 2017/02/23 by Thomas.Sarkanen
Prevent division by zero in trajectory generation
Newly created sequences dont have a frame interval set up.
Change 3319013 on 2017/02/23 by Lina.Halper
Fixed twist issue
#lockdown: James.Golding
#rb: none
Change 3319017 on 2017/02/23 by Lina.Halper
Checked in wrong line - disabling optimization
#rb:none
#lockdown:James.Golding
Change 3319034 on 2017/02/23 by Lina.Halper
sorry about that - for some reason p4 reverted the merged changes, and removing function that was merged
#rb: none
#lockdown: James.Golding
Change 3319056 on 2017/02/23 by Lina.Halper
Back out changelist 3319013
#lockdown:James.Golding
Change 3319090 on 2017/02/23 by Thomas.Sarkanen
Added bookmarks to level, fixed up animation sequeces to be used in demo
Cleaned up unused assets from demo folder
Change 3319209 on 2017/02/23 by Chris.Evans
!R Lighting rebuilt
!N cameras added, camera switching functionality
Change 3319219 on 2017/02/23 by Chris.Evans
!R Disabling physics on the snake head on left shoulder
Change 3319268 on 2017/02/23 by Chris.Evans
!R Says it's dirty, could have sworn checked in latest, tested and works fine, sync'd to last rev can't see what changed.
Change 3319290 on 2017/02/23 by James.Golding
Default bShowManipulatorsDuringPlayback to on
Change 3319291 on 2017/02/23 by James.Golding
Add GDC2017 shared collection
Change 3319867 on 2017/02/23 by Alan.Noon
Moved Audio to a level and removed from sublevel list. Deleted particles.
Change 3320056 on 2017/02/23 by Alan.Noon
Built lighting in Clothing_GDC_P
Change 3320067 on 2017/02/23 by Ori.Cohen
Fix rigid body tooltip having the same loctext key as the node name causing bad node name (matters for live demo)
Change 3320085 on 2017/02/23 by Alan.Noon
Changed Origin_Small_P in ControlRigDemoMap to "Always Loaded"
Change 3320098 on 2017/02/23 by Martin.Wilson
Final updates for Live Link GDC Demo
-Add maya scene for demo
-Add binary for maya plugin + installation instructions
-Update actor location from based on latest maya scene and fix cameras in sequencer
-Updates on live link system for demo that I have been running with locally. Should be safe.
Change 3320579 on 2017/02/23 by Alan.Noon
Bound Spacebar to GoRagdoll in ArcBlade map. Built lighting. Killed printing to screen/log in MinionBP.
Change 3321144 on 2017/02/24 by Chris.Evans
!B Lighting was bad in PIE, forced -1.5 exposure bias on all cameras
Change 3321317 on 2017/02/24 by James.Golding
PIE on pose_test_level jumps to first placed camera
Change 3321956 on 2017/02/24 by Alan.Noon
Adding missing minion anims. And Stuff.
Change 3324190 on 2017/02/27 by Lina.Halper
Removed ensure from EvaluateAnimation
- this is invalid because of worker thread but I'll have more conversation over this change.
#rb: none
#code review: Laurent.Delayen, Martin.Wilson
#jira: UE-41731
Change 3324309 on 2017/02/27 by Lina.Halper
fixed issue with skeleton bone not displaying for curve picker
#jira: UE-41909
#rb: Marc.Audy
Change 3324342 on 2017/02/27 by mason.seay
First round of assets for testing root motion with framerate
Change 3324562 on 2017/02/27 by Lina.Halper
Fix build error
#rb: none
Change 3325010 on 2017/02/28 by mason.seay
Finished map
Change 3325124 on 2017/02/28 by mason.seay
Updated test to use trigger instead of delay
Change 3325205 on 2017/02/28 by mason.seay
Deleting old map
Change 3325207 on 2017/02/28 by mason.seay
Deleting old map
Change 3325752 on 2017/02/28 by Lina.Halper
Back out changelist 3319056
- adding upper twist back again
#rb: none
Change 3325759 on 2017/02/28 by James.Cobbett
Moving Weld automated tests to EngineTest project
Change 3326039 on 2017/02/28 by Lina.Halper
Fix spine issues
This is almost like content change as this contains lots of rigging changes from code. So I'm just checking with no review.
#jira: UE-42260, UE-42268
#rb: none
Change 3326246 on 2017/02/28 by mason.seay
Test map and assets for overlap functional tests
Change 3327926 on 2017/03/01 by Lina.Halper
- disabled pelvis animation on WaveAnimationGDC
- added pelvis controls so that you can animate without worring about gmibal lock.
#code review: danny.bouimad
Change 3327971 on 2017/03/01 by Lina.Halper
Moved BaseHuman to ControlRig/Content folder
- checking in redirector for the people who have local contents that want to keep
#code review: Thomas.Sarkanen
Change 3329196 on 2017/03/02 by James.Cobbett
Deleting from QAGame. These maps and assets were migrated over to EngineTest in CL 3325759 and CL 3325802.
Change 3329263 on 2017/03/02 by mason.seay
Temp submission as I reorganize other content
Change 3329321 on 2017/03/02 by mason.seay
Reorganizing content
Change 3329493 on 2017/03/02 by James.Cobbett
Moving/renaming automated tests
Change 3332044 on 2017/03/03 by mason.seay
Procedural Mesh Functional Tests
Change 3332049 on 2017/03/03 by Mason.Seay
Screenshot comparisons for Procedural Mesh Tests
Change 3333080 on 2017/03/06 by Lina.Halper
Fix crash on not sorted OutBoneTransforms from Hand IK Retargeting node
#jira: UE-42460
Change 3333826 on 2017/03/06 by Lina.Halper
Renamed nodes -
- adding rename feature for HumanRig
#rb: none
Change 3333847 on 2017/03/06 by Lina.Halper
Fixed build error
Change 3333865 on 2017/03/06 by Lina.Halper
Fixed build error on shadow warning
Change 3333957 on 2017/03/06 by Lina.Halper
Fixed issue where limb length wasn't applied correctly on human rig
#jira: UE-42307
Change 3335109 on 2017/03/07 by Thomas.Sarkanen
Prevent us from rebuilding node tree in 'view' mode
This means that a rare crash cant occur any more
#jira UE-42568 - Editor crashes when using the eye dropper to switch actor skeleton after deleting sequence
Change 3335110 on 2017/03/07 by Jurre.deBaare
Editor crashes on importing Alembic file
#fix ensure that we generate objects with a valid object name (used to be able to include invalid characters such as periods)
#jira UE-40189
Change 3335117 on 2017/03/07 by Jurre.deBaare
Crash when opening cloth painter with Paint mode open and selecting different actor
#fix ensure that we only initialize static adapter factory data once, now that we have multiple painters
#jira UE-42573
Change 3335119 on 2017/03/07 by Jurre.deBaare
In Persona, the lighting rig rotation changes when switching between profiles
#fix don't know how I wrote this code before, but made it so it makes sense now
#jira UE-40877
Change 3335120 on 2017/03/07 by Jurre.deBaare
Auto-Exposure Overriding Preview Scene Profile Settings
#fix also update showflags when passed property is Name_none, on opening static mesh editor make sure we pick last set profile instead of default 0, and make sure we push propertyt change when changing profiles
#misc made same changes for animation editors
#jira UE-39217
Change 3335121 on 2017/03/07 by Jurre.deBaare
Points not marked as invalid in Aim Offset graph when in invalid positions
#fix ensure that samples which have a valid grid point when checking their animation ptr
#misc whitespace fixes
#jira UE-40715
Change 3335122 on 2017/03/07 by Jurre.deBaare
Cannot right-click a blend point if the green preview point is in the way
#fix changed condition slightly, now do gather highlighted index so it can be used in rightclick instead of not setting it while hovering the preview pin point
#jira UE-39060
Change 3335123 on 2017/03/07 by Jurre.deBaare
It's not clear which Grid Stretch mode in blend space is currently on
#jira UE-39080
#fix added color change on grid stretch type state
Change 3335124 on 2017/03/07 by Jurre.deBaare
Not clear that material baking is only supported for single lod merge actors
#fix extended tooltip to include requirement for material merging
#jira UE-39621
Change 3335125 on 2017/03/07 by Jurre.deBaare
#fix Alembic import fix (indexed UVs) copy-pasta error
Change 3335126 on 2017/03/07 by Jurre.deBaare
Accessor and Modifier for StartTimeOffset in GeometryCacheComponent.h
#jira UE-37080
#feature Added bp exposed get/set-er
#misc Corrected some comments
Change 3335127 on 2017/03/07 by Jurre.deBaare
Blend space interpolation settings do not update until the user reopens the asset
#fix made reintializing of interpolation filter editor only to start with, and update the filter when necessary (this way multiple players, e.g. thumbnail renderer and persona) both give the expected result, before only one of them would be reinitialized see comment on flag in header
#jira UE-40950
Change 3335129 on 2017/03/07 by Jurre.deBaare
Store imported mesh names for Alembic files (makes reimporting easier)
#jira UE-39034
Change 3335161 on 2017/03/07 by Jurre.deBaare
CIS fix: Partial back out changelist 3335129
Change 3335426 on 2017/03/07 by Jurre.deBaare
Crash fix for importing random maya shapes through Alembic
#fix add safety checks for writing material indices
#jira UE-40189
Change 3335427 on 2017/03/07 by Jurre.deBaare
Editor hard locks when adding Profile in Preview Scene Settings
#fix previous change created an infinite loop while adding a new profile, now calling OnAssetViewerSettingsChanged directly and from a different spot
#jira UE-42609
Change 3335448 on 2017/03/07 by Thomas.Sarkanen
Fixed binding (and re-binding) of rig that was broken by main integration
Templates are no longer always regenerated, so re-binding doesnt work if we rely on template regeneration
Moved runtime and compile-time binding into the template (rather than the track).
Removed hacky 'static stack' of binding IDs. This is no longer needed now we have a way to propgate per-instance template data at compile time.
Change 3336018 on 2017/03/07 by Ori.Cohen
Make sure InstantiatePhysicsAsset does not create uninitialized bodies and constraints when it is given a physics asset with inappropriate bone names. Fixes crash in rigid body node when re-targetting.
#JIRA UE-42090
Change 3336508 on 2017/03/07 by Ori.Cohen
PR #3325: Allow Physics Notification Dispatching with Engine API (Contributed by 0lento)
#JIRA UE-42533
Change 3336524 on 2017/03/07 by Ori.Cohen
Added compiler error when component space sim and world collision is used.
#JIRA UE-41402
Change 3336700 on 2017/03/07 by Ben.Marsh
Fix stream name for bulding PhysX.
Change 3336949 on 2017/03/08 by James.Golding
In BindToSkeletalMesh, make sure skel mesh resources are init'd before calling Register on SkelMeshComp
#jira UE-42377
Change 3337008 on 2017/03/08 by Lina.Halper
- Fix for lagging update
- Removed unnecessary update from trajectory cache
#rb: Thomas.Sarkanen
Change 3337190 on 2017/03/08 by James.Golding
Remove defunct PhysX 3.3 libs
Change 3337562 on 2017/03/08 by Ori.Cohen
Touch engine to force re-link of latest PhysX libs. Fixes crash when free joints are used with immediate mode.
#JIRA UE-41026, UE-42628
Change 3337779 on 2017/03/08 by Ori.Cohen
Added skeletal mesh component override for sync vs async scene.
#JIRA UE-39829
Change 3337859 on 2017/03/08 by Ori.Cohen
Fix CIS
Change 3338593 on 2017/03/08 by Ori.Cohen
Remove physx get geometry macro and replace with calls to .any which should be faster.
#JIRA UE-40503
Change 3338614 on 2017/03/08 by Ori.Cohen
Fix warning about missing EditAnywhere
#JIRA UE-41361
Change 3338677 on 2017/03/08 by Ori.Cohen
Fix new generated physics assets not properly setting user settings to default profile.
#JIRA UE-41135
Change 3338683 on 2017/03/08 by Ori.Cohen
PR #3225: UPhysicsConstraintComponent works as expected when target is an UChildActorComponent (Contributed by PhoenixBlack)
#JIRA UE-3225
Change 3338694 on 2017/03/08 by Ori.Cohen
Added a getter to physical animation component (PR #3163)
#JIRA UE-41047
Change 3339131 on 2017/03/09 by James.Golding
Merging Engine changes from //UE4/Private-GDC17-FaceRig
- Set default CurveSourceBindingName on AudioCurveSourceComponent to 'Default' (to match node default)
- Add CurveSyncOffset option to AudioCurveSourceComponent
- Add 'Copy Curves To SoundWave' option to Anim Editor
- Bind possible curve sources by iterating over component properties, rather than owned components
- Add ref-pose override option to SkinnedMeshComponent
- Major fixes for per-instance skin-weights (was not using per-section map)
- Improve warnings for per-instance skin weight problems
Change 3339223 on 2017/03/09 by Thomas.Sarkanen
Exposed preview scene settings in the existing settings tab rather than in a hidden menu in the viewport
Tab is now shown by default
Added default preview scene collection so you dont end up having to create assets all the time just to preview meshes (although this is still possible).
#jira UE-39365 - Make Preview scene setup more discoverable
Change 3339270 on 2017/03/09 by Lina.Halper
Added create animation blueprint back since now we have a separate editor.
#jira: UE-39457
#rb: Martin.Wilson
Change 3339318 on 2017/03/09 by Danny.Bouimad
TM-TangentNormals, Test map for checking tangent recalculation with and without skin cache.
Change 3339431 on 2017/03/09 by James.Golding
Make UDestructibleComponent::SpawnFractureEffectsFromDamageEvent virtual
(UDN request: https://udn.unrealengine.com/questions/335389/custom-destructible-fracture-effects.html)
Change 3339809 on 2017/03/09 by James.Golding
Add support for 'UCP' prefix for importing capsule collision on static meshes via FBX
#jira UE-5262
Change 3339955 on 2017/03/09 by Ori.Cohen
Allow kinematic leaf bodies in immediate mode
Change 3339995 on 2017/03/09 by mason.seay
Collision functional tests
Change 3340085 on 2017/03/09 by Ori.Cohen
Change default contact-gen method to PCM. This is the default in PhysX 3.4
#JIRA UE-40365
Change 3340562 on 2017/03/09 by Ori.Cohen
Added physx simulation shader override.
#JIRA UE-35304
Change 3341155 on 2017/03/10 by Ori.Cohen
Fix CIS warnings
Change 3341295 on 2017/03/10 by Martin.Wilson
Cache compact pose bone index on FBoneReference and remove manual caching in Paragon
#jira UE-42302
Change 3341943 on 2017/03/10 by mason.seay
Cleaned up logic for map blueprints. Worked around delays
Change 3342029 on 2017/03/10 by mason.seay
Cleaned up blueprint logic to remove dependency on delays
Change 3342063 on 2017/03/10 by mason.seay
Disabling tests
Change 3342071 on 2017/03/10 by mason.seay
Updated map to use assertions
Change 3342884 on 2017/03/13 by James.Golding
Expose 'trace by profile' functions to BP
Refactor duplicated code in KismetSystemLibrary collision functions
#jira UE-32912
Change 3342886 on 2017/03/13 by James.Golding
Moving sprite from PhysicsThruster actor to PhysicsThrusterComponent (like light and audio, for example)
#jira UE-6015
Change 3342921 on 2017/03/13 by Benn.Gallagher
Added some checking to anim dynamics pre update to avoid crashes when world isn't available
#jira UE-42729
Change 3342970 on 2017/03/13 by James.Golding
Fix incorrect display names for some ..ByProfile trace funcs
Change 3342972 on 2017/03/13 by James.Golding
PR #3060: Added virtual keyword to DestructibleComponent ApplyDamage, ApplyDamageRadius (Contributed by looterz)
Change 3343032 on 2017/03/13 by Josh.Stoddard
Enable stabilization in PhysX by default
- set PxSceneFlag::eENABLE_STABILIZATION by default
- removed USE_ADAPTIVE_FORCES_FOR_ASYNC_SCENE because eADAPTED_FORCES is incompatible with eENABLE_STABILIZATION
- added FBodyInstance parameter StabilizationThresholdMultiplier to control PxRigidDynamic stabilization threshold
#jira UE-6612 #rb ori.cohen
Change 3343073 on 2017/03/13 by Martin.Wilson
Properly initialize single bone controller bone references
#jira UE-42776
Change 3343074 on 2017/03/13 by Martin.Wilson
Clear raw curve data during cooking
#jira UE-37897
Change 3343317 on 2017/03/13 by Jurre.deBaare
Crash after clearing the animation from a sample point in a 1D Blendspace
#jira UE-42672
#misc made sure that we do not deem empty blend spaces as additive
Change 3343498 on 2017/03/13 by Lina.Halper
Fix on odin cook crash
- fallout from CL 3336018
#rb:Marc.Audy
#code review:Ori.Cohen
Change 3343548 on 2017/03/13 by Lina.Halper
Fix crash on ocean -
#rb: none
#code review: Ori.Cohen
Change 3344764 on 2017/03/14 by Thomas.Sarkanen
Fixed crash right-clicking empty space in the asset shortcut dropdown
#jira UE-42782 - Crash right-clicking in anim blueprint asset picker
#jira UE-42799 - GitHub 3366 : Asset selection null check before Opening Editor
Change 3344776 on 2017/03/14 by James.Golding
Really fix names for BP-expose 'ByProfile' traces
Change 3344780 on 2017/03/14 by James.Golding
PR #3359: UE4.15 Morpheme integration changes (Contributed by NaturalMotionTechnology)
#jira UE-42771
Change 3344781 on 2017/03/14 by James.Golding
PR #3346: Expose URadialForceComponent for inheritance (Contributed by projectgheist)
#jira UE-42610
Change 3344782 on 2017/03/14 by James.Golding
Fix procmesh->staticmesh conversion if only a single triangle
#jira UE-42310
Change 3344783 on 2017/03/14 by James.Golding
PR #3234: Fix the incorrect UIMin value for InitialAverageFrameRate physics setting. (Contributed by 0lento)
#jira UE-41832
Change 3344785 on 2017/03/14 by James.Golding
PR #3196: Improved Constraint warning message (Contributed by projectgheist)
Change 3344790 on 2017/03/14 by James.Golding
PR #3362: Fix NULL pointer dereference when debugging null animation sequence. (Contributed by ill)
Change 3344891 on 2017/03/14 by Jurre.deBaare
Incorporate back list of animations into blendspace editor
#feature added labels toggle to blend space grid
#feature can now override animations when drop on sample
#jira UE-39368
Change 3344921 on 2017/03/14 by Jurre.deBaare
Expose Opacity and Opacity Mask options on material flattening
#feature added support for baking out opacity and opacity masks
#jira UE-39563
Change 3344963 on 2017/03/14 by Jurre.deBaare
Need Simplygon to create LODs on animated pose, vs skeletal mesh pose
#feature added ability to specify an animation sequence from which frame 0 will be baked into the LOD mesh
#jira UE-38909
Change 3345060 on 2017/03/14 by Jurre.deBaare
CIS fix: missing include
Change 3345929 on 2017/03/14 by Jon.Nabozny
Fix Grux skeletal mesh to properly point at Grux Phys Asset (instead of Steel's).
#jira UE-42772
Change 3346970 on 2017/03/15 by Jurre.deBaare
#feature Support importing vertex colours from Alembic files
#jira UE-39032
Change 3346976 on 2017/03/15 by Jurre.deBaare
Missing files from CL 3344921
Change 3346983 on 2017/03/15 by Jurre.deBaare
Static mesh editor crashes when opening
#fix default value for additional settings
Change 3347019 on 2017/03/15 by James.Cobbett
Tidying up blueprint comments
Change 3347128 on 2017/03/15 by mason.seay
Updated descriptions on tests
Change 3347146 on 2017/03/15 by mason.seay
Updated descriptions on tests
Change 3347178 on 2017/03/15 by Martin.Wilson
PR #3358: Actually compress CompressedCurveData during anim compression (Contributed by stefanzimecki)
Change 3347257 on 2017/03/15 by Thomas.Sarkanen
Fixed crash when canceling saving a new preview mesh collection
Change 3347314 on 2017/03/15 by mason.seay
Narrowed collision volumes by half
Change 3347386 on 2017/03/15 by mason.seay
Updated descriptions
Change 3347388 on 2017/03/15 by mason.seay
Forgot to disable tests :P
Change 3347397 on 2017/03/15 by James.Cobbett
Tidying up blueprint comments for WeldingScreenshots.umap automated test
Change 3347433 on 2017/03/15 by Thomas.Sarkanen
Fix IK/FK switch on first frame (clobbering FK data)
Added a 'first frame' flag to limbs etc.
Change 3347436 on 2017/03/15 by Thomas.Sarkanen
Control rig sequences can now be exported to anim sequences
Control rig sequences can now be exported from sequencer and exported, re-exported, imported and re-imported from the content browser.
Added converter function that performs similar logic to the animation recorder.
Fixed binding template in cooked builds.
Exposed anim sequence factory via UNREALED_API to allow for me to derive from it (I force the skeleton to a known value)
#jira UE-42608 - Add "export to anim sequence" to control rig sequences
Change 3347475 on 2017/03/15 by Lina.Halper
#LookAt node refactor
- you can use LookAtLocation based on joint or socket (jira UE-8972)
- improved visualizer (jira UE-2737) - clamp was there but now you can visuzlie it
- GetOnScreenDebugInfo changed parameter - added runtime node
- possibly we could query runtime node only but right now GetOnScrrenDebugInfo belongs to AnimGraphNode
- deprecated previous GetOnScreenDebugInfo
- Added AnimPhys Object version GUID
#rb:Thomas.Sarkanen
Change 3347512 on 2017/03/15 by Thomas.Sarkanen
Filter anim sequences to the correct skeleton when exporting
Feeback from code review of CL 3347436.
Change 3347543 on 2017/03/15 by Thomas.Sarkanen
Fix shadow variable warnings
Change 3347556 on 2017/03/15 by Jurre.deBaare
Unable to select bones in the animation editor viewport
#fix issues came from hit proxies being turned on and always being hit instead of the bone physic shapes
#feature added toggle button to skeletal mesh editor to enable mesh section selection
#jira UE-42893
Change 3347559 on 2017/03/15 by James.Golding
By default, re-use anim editor with correct Skeleton when double clicking anim asset
Add menu option to force a new edtor to open
#jira UE-42912
Change 3347749 on 2017/03/15 by Lina.Halper
Fix build issue.
#rb: none
Change 3347926 on 2017/03/15 by James.Cobbett
Adding new test to Welding.umap for children welding when attached to ragdoll
Change 3347938 on 2017/03/15 by Lina.Halper
Fix build error
#rb: none
Change 3347939 on 2017/03/15 by Mason.Seay
General cleanup of bp logic in maps and blueprint actors
Added scenarios to test actor descriptions
Fixed an error in blueprints (I think I failed to submit changes before)
Change 3348074 on 2017/03/15 by Lina.Halper
build error fix
#rb: none
#code review: martin.wilson
Change 3348154 on 2017/03/15 by Lina.Halper
last fix, hopefully
#rb: none
#code review: MArtin.wilson
Change 3349160 on 2017/03/16 by Thomas.Sarkanen
Adding 'set preview mesh' to toolbar
#jira UE-42910 - Add 'preview mesh' button to toolbar
Change 3349175 on 2017/03/16 by Jurre.deBaare
Notification on reimported animations that might be bad
#fix added two warning messages for different sequence length and missing curve in reimported file (hidden behind editor user setting -> bAnimationReimportWarnings)
#jira UE-34522
Change 3349197 on 2017/03/16 by Martin.Wilson
Add ability to choose slot to preview to montage editor
#jira UE-38910
Change 3349216 on 2017/03/16 by James.Cobbett
Additional Welding tests: static meshes attached to ragdolls and simulated children detaching and retaining welded children
Change 3349217 on 2017/03/16 by James.Cobbett
Disabling new Welding tests pending review
Change 3349314 on 2017/03/16 by Benn.Gallagher
Fixed clothing not running in PS4 packaged builds
#jira UE-42857
Change 3349504 on 2017/03/16 by James.Fox
Enabling RootMotion automation tests. Approved: UEENGQA-12277
Change 3349611 on 2017/03/16 by Lina.Halper
retargeting pose options change
- now reset, import pose, use current pose
#rb: Martin.Wilson
#jira: UE-19768
Change 3349738 on 2017/03/16 by Martin.Wilson
Remove force inline from virtual compression functions.
#jira UE-33070
Change 3349787 on 2017/03/16 by James.Golding
Fix xbox one compile (FControlRigBindingTemplate::ObjectBinding was not all wrapped in WITH_EDITORONLY_DATA)
Change 3349827 on 2017/03/16 by Josh.Stoddard
- Expose PhysX stabilization as project setting, disabled by default
- remove obsolete USE_SPECIAL_FRICTION_MODEL_FOR_ASYNC_SCENE
#jira UE-42868
Change 3349932 on 2017/03/16 by James.Golding
Possible fix for cooking crash - ContentBrowser module not necessarily being loaded
Change 3350011 on 2017/03/16 by Jon.Nabozny
Created AddForceAtLocationLocal function to allow component space forces.
#jira UE-38115
Change 3350134 on 2017/03/16 by Josh.Stoddard
Fix memory leak from GPhysXSDK->createShape()
#jira UE-42733 #rb ori.cohen
Change 3351166 on 2017/03/16 by Lina.Halper
Fixed build issue
#code review:Jon.Nabozny
Change 3351451 on 2017/03/17 by Benn.Gallagher
Fixed clothing reimports not working correctly and possibly leading to editor crash
#jira UE-42953
Change 3351564 on 2017/03/17 by Benn.Gallagher
Xbox NvCloth fix, module rules incorrectly set up and were not actually compiling NvCloth into the binary
#jira UE-42224
Change 3351594 on 2017/03/17 by mason.seay
Updated BP logic to use Set Actor Location (speeds up tests)
Gave actors distinct names
Reworded descriptions
Change 3351629 on 2017/03/17 by Jon.Nabozny
Add methods to determine the WeldParent and WeldChildren of a given component.
#jira UE-40733
Change 3351639 on 2017/03/17 by Jon.Nabozny
Fix StopMovementImmediately for WheeledVehicleMovementComponent.
#jira UE-40078
Change 3351649 on 2017/03/17 by Jon.Nabozny
Update comment on AddForceAtLocationLocal to be explicit that both Force vector and Location are in Body space.
Change 3351663 on 2017/03/17 by Thomas.Sarkanen
Anim notify blueprints now start with a 'received notify' event node (ghosted)
#jira UE-27386 - A new anim notify blueprints should start with a Received Notify override
Change 3351696 on 2017/03/17 by Thomas.Sarkanen
Refactored EvaluateBoneTransforms to prevent usage of skeletal mesh component
Deprecated EvaluateBoneTransforms in favor of new EvaluateSkeletalControl_AnyThread.
Added various useful transforms to the proxy as these were the most used data from the skeletal mesh component.
Some instances still require access to skeletal mesh to access the world for debug rendering. I'm leaving these alone for the moment as they should be addressed for 4.17 with the fixes for multi-threaded debug rendering.
Commented & re-formatted ConvertCSTransformToBoneSpace and ConvertBoneSpaceTransformToCS. Deprecated signatures that take a skeletal mesh component.
Commented FAnimNode_Base interface.
#jira UE-35238 - FAnimNode_SkeletalControlBase::EvaluateBoneTransforms takes in SkeletalMeshComponent which is not safe
Change 3351698 on 2017/03/17 by James.Golding
Add GetMaterialFromFaceIndex to MeshComponent, implement for StaticMeshComponent and ModelComponent
#jira UE-42802
Change 3351701 on 2017/03/17 by James.Golding
Change from Ctrl to Shift for 'open new editor' when double-clicking anim assets
Change 3351703 on 2017/03/17 by James.Golding
Change Box and Sphyl elements to use Rotator instead of Quat, to make them easier to edit via details panel
#jira UE-39664
Change 3351704 on 2017/03/17 by James.Golding
Fix scrubbing curves that aren't selected
#jira UE-39574
Change 3351805 on 2017/03/17 by Thomas.Sarkanen
Prevent crash when trying to implement a function in a child anim blueprint
The assumption that the ubergraph was the zeroth entry in the array didnt hold for child anim BPs with overriden functions. Now we just search for the ubergraph and check it if we find it.
#jira UE-42996 - Editor Crashes when creating a function in Child Anim Blueprint
Change 3352000 on 2017/03/17 by James.Cobbett
Adding VehicleAdvBP assets for use in upcoming Welding tests
Change 3352067 on 2017/03/17 by Lina.Halper
Removed AnimGraph from GraphEditor module
- Created node factory, pin factory, pin connection policy factory
- Moved all anim related files out of GraphEditor
#code review: Michael.Noland
#jira: UE-37976
#rb: Michael.Noland
Change 3352178 on 2017/03/17 by Lina.Halper
Moved to AnimationBlueprintEditor as these are just graph visual nodes
#code review:Michael.Noland
Change 3352753 on 2017/03/17 by James.Fox
Checking in some naming convention changes for Overlap automation test.
Change 3353371 on 2017/03/19 by Lina.Halper
Fix build error
#code review: Bob.Tellez
Change 3353644 on 2017/03/20 by Jurre.deBaare
Animation thumbnails vanishing
#fix ensure that we draw the mesh regardless of whether or not we have dynamic render data
#jira UE-42974
Change 3353654 on 2017/03/20 by James.Golding
Move SGraphNodeK2Default and SGraphNodeK2Event to Public as well, as they are used by Fortnite
Update includes in SFortGrtaphNodeK2ExecuteEvent and HandleEvent to only include parent class header
Change 3353684 on 2017/03/20 by Jurre.deBaare
Separate asset viewer profiles for local / shared
- Split out profiles in local/shared UProperty
- Modifications to ini writing :(
- Extra checks for default ini writing
- Add checkout/make writable for default editor ini file
Change 3353803 on 2017/03/20 by Jurre.deBaare
CIS fixes
Change 3353830 on 2017/03/20 by Martin.Wilson
Fix additives breaking when pose link not connected to anything
#jira ue-39174
Change 3353847 on 2017/03/20 by Martin.Wilson
Add property to blend space player nodes to specify whether the blend space current time is reset when the blend space changes
#jira UE-40446
Change 3353950 on 2017/03/20 by Ori.Cohen
Undo the null entries for invalid body/bodysetup pairs. Instead we check if the body and constraints are valid in the rigid body node.
#JIRA UE-42090
Change 3353956 on 2017/03/20 by Ori.Cohen
Back out changelist 3343498 (this was needed for the null entries on bodies array which has been fixed)
Change 3354003 on 2017/03/20 by Thomas.Sarkanen
Back out changelist 3353914
Change 3354031 on 2017/03/20 by Benn.Gallagher
Speculative fix for clothing crashes using Mambo. It was possible that the skeletal mesh component could have triggered deletion or creation of simulation state objects while the simulation was in flight on another thread, added tracking and waiting for outstanding tasks.
#jira UE-42975
Change 3354151 on 2017/03/20 by Lina.Halper
Make sure nullptr tick function still works
- this is prerequisite for the play and export option
#rb:Ori.Cohen
Change 3354229 on 2017/03/20 by James.Golding
Add 'default camera' options for skel meshes
#jira UE-42762
Change 3354342 on 2017/03/20 by Martin.Wilson
Strip out identity raw tracks when baking additives.
#jira UE-40508
Change 3354388 on 2017/03/20 by Martin.Wilson
Fix false anim blueprint compile errors with aim offset pins
#jira UE-38196
Change 3354494 on 2017/03/20 by Martin.Wilson
Serialize compressed anim data when counting memory
#jira UE-39691
Change 3354515 on 2017/03/20 by Josh.Stoddard
Expose PxSceneFlag::eENABLE_ENHANCED_DETERMINISM
#jira UE-41484 #rb ori.cohen
Change 3355932 on 2017/03/21 by Thomas.Sarkanen
Back out changelist 3354003
Reinstating merge from Main:
Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys)
Change 3355954 on 2017/03/21 by Thomas.Sarkanen
Fixed up CIS issues post merge from Main
Change 3355974 on 2017/03/21 by James.Golding
Fix Mac CIS warning (constructor order of FAnimNode_BlendSpacePlayer)
Change 3355981 on 2017/03/21 by Jurre.deBaare
Whitelisted circular dependencies between meshpaintmode and VR editor modules
Change 3355986 on 2017/03/21 by Jurre.deBaare
Linux CIS file, non-capital M
Change 3356072 on 2017/03/21 by James.Golding
Fix UStaticMeshComponent::GetMaterialFromCollisionFaceIndex to not depend on editor-only data
#jira UE-43117
Change 3356073 on 2017/03/21 by James.Golding
Implement GetMaterialFromCollisionFaceIndex for ProceduralMeshComponent
Change 3356300 on 2017/03/21 by Ori.Cohen
Allow kinematic bodies with simulated parents using the full scene solver
Change 3356362 on 2017/03/21 by Lina.Halper
- Support create animation from Play
- Support export animation from Play
- this allows retargeting, post graph, or anything you see in engine will be baked to the animation
#rb: Thomas.Sarkanen
#jira: UE-19746
Change 3356482 on 2017/03/21 by Martin.Wilson
Fix crash when opening a new montage
#UE-43132
Change 3356709 on 2017/03/21 by James.Golding
Check for NaN when converting rotator->quat (very large inputs can result in nan's, need to handle to avoid hitting asserts elsewhere)
Add clamps when editing rotation of collision shapes, to avoid massive rotation entries
#jira UE-39664
Change 3356968 on 2017/03/21 by Ori.Cohen
Fix physics asset bounds to be as small as 1cm.
This introduces flicker, but passing to rendering to fix that on their end.
Change 3357092 on 2017/03/21 by Josh.Stoddard
Don't update kinematic target if the body isn't moving
#jira UE-42784 #rb ori.cohen
Change 3357194 on 2017/03/21 by Lina.Halper
Fix on vehicle anim instance look at node issue
#rb: Ori.Cohen
#jira: UE-43116
Change 3357298 on 2017/03/21 by Ori.Cohen
Fix invalid warning when dragging actors into the world. This is invalid because we manually disable collision on actors when this happens, and the warning is only needed for actual runtime.
#JIRA UE-42211
Change 3357494 on 2017/03/21 by Jon.Nabozny
Fix FPropertyEditorInlineClassFilter filtering classes incorrectly.
#jira UE-43098
Change 3357892 on 2017/03/21 by Lina.Halper
fix build error
#rb: none
Change 3358078 on 2017/03/22 by James.Golding
Fix CIS - AnimNode_FootPlacement in Platformer game after SkelControl refactor (from CL 3351696)
Change 3358080 on 2017/03/22 by Jurre.deBaare
Updating Alembic importer thirdparty dependencies for Windows and Mac
Change 3358081 on 2017/03/22 by James.Golding
Add comment to help people fix up code after moving many properties in ContraintInstance to ProfileInstance member
Change 3358092 on 2017/03/22 by James.Golding
Fix undo for saving/clearing default cam on mesh (also marks mesh dirty)
Change 3358093 on 2017/03/22 by James.Golding
Panning in orbit mode now takes in account camera speed
#jira UE-43082
Change 3358106 on 2017/03/22 by Thomas.Sarkanen
Fix fallout from Main integration
Change 3358454 on 2017/03/22 by Ori.Cohen
Temporarily disable phat immediate mode previewing to break the dependency on immediate physics plugin. Will be turned back on in later refactor
#JIRA UE-41711
Change 3358886 on 2017/03/22 by Ori.Cohen
Fix AutoWeld not being disabled in blueprint editor when the object is simulated
#JIRA UE-40193
Change 3358950 on 2017/03/22 by Lina.Halper
reverted code asking about asset name when create asset
#rb: none
Change 3359034 on 2017/03/22 by Lina.Halper
#fix fall out from previous revert
- because now export also shows the window. we don't want export to FBX to show name dialog
- it will use asset name as base
#rb: none
#code review:Thomas.Sarkanen
Change 3359165 on 2017/03/22 by Ori.Cohen
Fix welded capsules not using the right rotation
#JIRA UE-41546
Change 3359232 on 2017/03/22 by Ori.Cohen
Bump DDC key for new bvh34.
Change 3359233 on 2017/03/22 by mason.seay
Added a couple more scenarios and updated names. Needs more organization
Change 3359293 on 2017/03/22 by tim.gautier
Submitting MeshPaint test content for QAGame.
Change 3359389 on 2017/03/22 by Ori.Cohen
Back out changelist 3356589
Change 3359402 on 2017/03/22 by Jon.Nabozny
Move GetWeldParent and GetWeldChildren to EngineTest.
Change 3359978 on 2017/03/23 by Jurre.deBaare
Mesh Paint brush disappears when painting in VR
#fix removed conditional clause for painting the interactors
#jira UE-43150
Change 3359980 on 2017/03/23 by Jurre.deBaare
Mesh Paint hotkeys to modify brush size are inconsistent with other Paint modes
#fix reverted to old behavior, paint mode overriding catching key input to viewport
#jira UE-43158
Change 3360052 on 2017/03/23 by James.Golding
Back out changelist 3359165, as it was made after smoke testing. Will re-submit after copy to main.
Change 3360121 on 2017/03/23 by James.Golding
Fix perf regression from testing for NaN's in FRotator::Quaternion in shipping builds
Change 3360177 on 2017/03/23 by Jurre.deBaare
Related to previous brush size check in, early out when the painter has handled the input, that way the rest of the editor can't take the brackets [] input anymore
Change 3360358 on 2017/03/23 by mason.seay
Updated naming and organization of actors in Outliner
Change 3362050 on 2017/03/23 by Lina.Halper
Back out changelist 3343074
#rb:none
#code review: Martin.Wilson, James.Golding
[CL 3362661 by Thomas Sarkanen in Main branch]
2017-03-24 09:53:37 -04:00
# include "Animation/AnimInstanceProxy.h"
2023-12-06 14:46:33 -05:00
# include "SoftIK.h"
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
2022-09-24 13:57:58 -04:00
# include UE_INLINE_GENERATED_CPP_BY_NAME(AnimNode_LegIK)
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
# if ENABLE_ANIM_DEBUG
TAutoConsoleVariable < int32 > CVarAnimNodeLegIKDebug ( TEXT ( " a.AnimNode.LegIK.Debug " ) , 0 , TEXT ( " Turn on debug for FAnimNode_LegIK " ) ) ;
# endif
TAutoConsoleVariable < int32 > CVarAnimLegIKEnable ( TEXT ( " a.AnimNode.LegIK.Enable " ) , 1 , TEXT ( " Toggle LegIK node. " ) ) ;
TAutoConsoleVariable < int32 > CVarAnimLegIKMaxIterations ( TEXT ( " a.AnimNode.LegIK.MaxIterations " ) , 0 , TEXT ( " Leg IK MaxIterations override. 0 = node default, > 0 override. " ) ) ;
TAutoConsoleVariable < float > CVarAnimLegIKTargetReachStepPercent ( TEXT ( " a.AnimNode.LegIK.TargetReachStepPercent " ) , 0.7f , TEXT ( " Leg IK TargetReachStepPercent. " ) ) ;
TAutoConsoleVariable < float > CVarAnimLegIKPullDistribution ( TEXT ( " a.AnimNode.LegIK.PullDistribution " ) , 0.5f , TEXT ( " Leg IK PullDistribution. 0 = foot, 0.5 = balanced, 1.f = hip " ) ) ;
/////////////////////////////////////////////////////
// FAnimAnimNode_LegIK
DECLARE_CYCLE_STAT ( TEXT ( " LegIK Eval " ) , STAT_LegIK_Eval , STATGROUP_Anim ) ;
DECLARE_CYCLE_STAT ( TEXT ( " LegIK FABRIK Eval " ) , STAT_LegIK_FABRIK_Eval , STATGROUP_Anim ) ;
FAnimNode_LegIK : : FAnimNode_LegIK ( )
2018-02-22 11:25:06 -05:00
: MyAnimInstanceProxy ( nullptr )
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
{
ReachPrecision = 0.01f ;
MaxIterations = 12 ;
2023-12-06 14:46:33 -05:00
SoftPercentLength = 1.0f ;
SoftAlpha = 1.0f ;
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
}
void FAnimNode_LegIK : : GatherDebugData ( FNodeDebugData & DebugData )
{
2019-07-16 11:49:59 -04:00
DECLARE_SCOPE_HIERARCHICAL_COUNTER_ANIMNODE ( GatherDebugData )
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
FString DebugLine = DebugData . GetNodeName ( this ) ;
// DebugLine += "(";
// AddDebugNodeData(DebugLine);
// DebugLine += FString::Printf(TEXT(" Target: %s)"), *BoneToModify.BoneName.ToString());
DebugData . AddDebugItem ( DebugLine ) ;
ComponentPose . GatherDebugData ( DebugData ) ;
}
2018-02-22 11:25:06 -05:00
static FVector GetBoneWorldLocation ( const FTransform & InBoneTransform , FAnimInstanceProxy * MyAnimInstanceProxy )
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
{
const FVector MeshCompSpaceLocation = InBoneTransform . GetLocation ( ) ;
2018-02-22 11:25:06 -05:00
return MyAnimInstanceProxy - > GetComponentTransform ( ) . TransformPosition ( MeshCompSpaceLocation ) ;
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
}
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3153514)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3050254 on 2016/07/14 by Marc.Audy
Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3049614
Change 3136629 on 2016/09/22 by Marc.Audy
bye bye auto
Change 3136631 on 2016/09/22 by Marc.Audy
Allow objects to be marked as duplicate transient or non PIE duplicate transient
ChildActors are not marked consistent with the property that references them as text export transient and non PIE duplicate transient
#jira UE-35680
Change 3136636 on 2016/09/22 by Marc.Audy
ParticleSystem and Audio Components now route Activate/Deactivate events to blueprints
Component Activate/Deactivate events now provide component as a property
#jira UE-35191
Change 3136640 on 2016/09/22 by Marc.Audy
Expose bReplicates to blueprint component properties
#jira UE-34433
Change 3136709 on 2016/09/22 by Ori.Cohen
Fix GetBodyInstance returning incorrect bodies when welded kinematics are attached.
#JIRA UE-36234
Change 3136710 on 2016/09/22 by Ori.Cohen
Fix defer actors not working when the physics scene is simulating. We now flush when the scene is not simulating, as well as a lazy flush that goes through the slow path when needed. This allows us to batch multiple components together.
#JIRA UE-35899
Change 3136770 on 2016/09/22 by Marc.Audy
Fix compile error
Change 3136854 on 2016/09/22 by Marc.Audy
Sprite components need to be text export transient
#jira UE-36064
Change 3136926 on 2016/09/22 by Ori.Cohen
Fix ensure when skeletal mesh bodies have no collision.
Change 3137054 on 2016/09/22 by Aaron.McLeran
PR #2628: Fix UAudioComponent SubtitlePriority not being initialised (Contributed by alanedwardes)
Change 3137058 on 2016/09/22 by Aaron.McLeran
PR #2562: ReadCompressedInfo calculates duration for ADPCM audio (Contributed by derekvanvliet)
Change 3137060 on 2016/09/22 by Aaron.McLeran
UE-36336 Fixing A3D for mono/2D sounds
- Making it so if A3D is being loaded but not enabled, we can not have reverb on 2D sounds
- Fixing A3D mono sources from failing after a time
Change 3137066 on 2016/09/22 by Aaron.McLeran
Checking in Ngs2.Build.cs with A3D and USING_A3D set to 0
Change 3137098 on 2016/09/22 by dan.reynolds
AEOverview Update: EQ Map, Reverb Map plus improvements on Main array cleanup process.
Change 3137132 on 2016/09/22 by Aaron.McLeran
PR #2789: Fixed signature of FActiveSound::GetIntParameter (Contributed by Laurie-Hedge)
Change 3137175 on 2016/09/22 by Aaron.McLeran
Fixing compile error with PhysXCollision.cpp from CL 3136710
Change 3137540 on 2016/09/23 by Thomas.Sarkanen
Fixed crash when generating LODs automatically for skeletal meshes
Quadric error reduction does not support skeletal meshes, so fails. Client code assumes that it cannot fail so crashed. This guards against immediatly assuming that LODs are valid after simplification.
#jira UE-36253 - Crash applying LOD changes in Persona
Change 3137720 on 2016/09/23 by Thomas.Sarkanen
Changed asset shortcut bar to display asset names & reworked padding
#jira UE-36347 - Anim asset shortcut bar has difficult to read/cut-off text
Change 3137761 on 2016/09/23 by Martin.Wilson
Fix typo in root motion from everything accumulation code
Change 3137877 on 2016/09/23 by Thomas.Sarkanen
Fixed undo/redo forcing skeletal meshes into t-pose
Re-populated AnimationData in InitAnim for UDebugSkelMeshComponent.
#jira UE-35579 - If you undo an animation change to any animation asset (for single preview), the playback controls will no longer function
Change 3137885 on 2016/09/23 by Benn.Gallagher
Fixed APEX clothing disappearing when time dilation results in a dt of 0. After simulating an actor with 0 APEX will fill positions and normals with NaNs, causing the disappearance. The fix in this case is to not schedule the evaluation task if we're not wanting to do any work. The simulation then freezes as we would expect.
#jira UE-35151
Change 3137888 on 2016/09/23 by Benn.Gallagher
Fixed transition nodes being able to be pasted or duplicated without 2 valid pin links
#jira UE-24860
Change 3137889 on 2016/09/23 by Benn.Gallagher
Fixed transform and widget inconsistencies in IK edit mode
#jira UE-20628
Change 3137890 on 2016/09/23 by Jurre.deBaare
Alembic Cached Geometry Does Not Display in Stand Alone Game
#fix required to force load the GeometryCache module during runtime
#jira UE-36187
Change 3137892 on 2016/09/23 by Jurre.deBaare
Geometry cache playback should work in sequencer
#fix add Interp UProperty tag to specific properties used for playing back the cache, future fix is having same approach as skeletal mesh animation for sequencer (depends on needs, -> skeletal mesh import has better compression anyway)
#jira UE-35447
Change 3137893 on 2016/09/23 by Jurre.deBaare
Alembic Cache Importer option for Hard Edge Angle Threshold does not work for objects with no normals
#fix adhere to the assumed 'standard' no normals in ABC file means completely smooth normals throughout the sequence
#jira UE-35091
Change 3137894 on 2016/09/23 by Jurre.deBaare
Importing an Alembic File While mesh Distance Fields are Enabled Crashes Editor
#fix Needed to save the raw mesh before building the mesh to ensure a LOD resource was created
#misc added a new check + message in case this occurs again
#jira UE-36059
Change 3137938 on 2016/09/23 by Jurre.deBaare
Alembic Importing with Incorrect UV's
#fix adding option for flipping UVs on import
#jira UE-36190
Alembic import axis not aligned correctly
#fix also added option to specify scale and rotation to be applied during import (with preset for Maya and Max)
#jira UE-35510
Change 3137949 on 2016/09/23 by Jurre.deBaare
Frame range importing causes confusion during Alembic importing
#fix this required storing information per Alembic object at which frame index it actual has stored frames, using this data we can determine which frames are empty, and at which frame there is data. This allows us to skip empty frames if we want to import data-only frames, or to import all frames in the sequence including empty (pre-roll) frames.
#misc changed settings UI listview layout (extra columns and resized old ones)
#jira UE-35498
Change 3137994 on 2016/09/23 by Martin.Wilson
Fix for creating an empty state when dragging a montage into a state machine graph
#jira UE-33371
Change 3138103 on 2016/09/23 by Aaron.McLeran
UE-36312 Fixing sound node distance cross fade for case of looping sounds
Change 3138104 on 2016/09/23 by Aaron.McLeran
UE-35392 Copy pasting local node into separate project crashes the engine
Change 3138224 on 2016/09/23 by Aaron.McLeran
UE-36312 Fixing sound node distance cross fade for case of looping sounds
- Adding a check for wave instance count to account for virtualized sounds (one-shots)
Change 3138666 on 2016/09/23 by Ben.Zeigler
#UEFW-204 Add more comprehensive gameplay tag tests
Fix issue with HasTag(Tag, IncludeParent, IncludeParent) revealed by tests, this was not returning true correctly in some cases. This use case is weird and will be deprecated soon
Change 3138779 on 2016/09/23 by Marc.Audy
Get rid of pointless casts
Change 3138782 on 2016/09/23 by Marc.Audy
remove some GWorlds
Change 3139701 on 2016/09/26 by Jurre.deBaare
Assert failed on GemetryCache for PS4 package
#fix add GeometryCache reference in engine build.cs and fix the serialization of geometry cache files
#jira UE-36392
Change 3139704 on 2016/09/26 by Jurre.deBaare
Fix for -1 begin frame
#fix do the max as an signed int, to make sure we don't wrap around
Change 3139748 on 2016/09/26 by Benn.Gallagher
PR #2784: Make sure that SceneScratchBufferSize is a multiple of 16K as requested by PhysX (Contributed by DenizPiri)
Moved the definition of the boundary to a FPhysScene class static
Changed comments on original user settings property to communicate the fact that the value is now rounded to the next 16K boundary
#jira UE-35736
Change 3139903 on 2016/09/26 by Benn.Gallagher
Fixed exposing subinstance pins stomping over class defaults and setting to uninitialized values
#jira UE-34366
Change 3140409 on 2016/09/26 by Lukasz.Furman
fixed uninitialized configs of gameplay debugger
copy of CL# 3140399
Change 3140516 on 2016/09/26 by dan.reynolds
AEOverview Map Update - Ambient Zone + Focus Test
Change 3140526 on 2016/09/26 by Jon.Nabozny
#rn Fixed CanJump inconsistencies with previous versions.
Deferred JumpCurrentCount increment until after jump, made bWasJumping a member variable, and updated how
jump count and hold time were compared in CanJump.
#jira UE-35524, UE-35582
Change 3140745 on 2016/09/26 by dan.reynolds
AEOverview Test Map Update + Occlusion Test
Change 3140839 on 2016/09/26 by dan.reynolds
AEOverview - minor updates
Change 3141101 on 2016/09/27 by Thomas.Sarkanen
Preview scene worlds now render correctly
Split "Preview" type into "EditorPreview" (the default) and "GamePreview". Deprecated the old "Preview" world type (but kept its index).
In-game hidden flags now apply to GamePreview, but not EditorPreview worlds.
Deprecated old bHack_Force_UsesGameHiddenFlags_True boolean. GamePReview now serves this purpose.
Fixed up UT cases where this was being used.
FPreviewScenes now use the editor mode by default, but can be set to non-editor if needed (as is the case with the still-experimental UViewport).
Custom depth pass is not enabled for EditorPreview (as before) but is for GamePreview.
Fixed erroneous use of TEnumAsByte for non-uproperty WorldType.
#jira UE-22883 - Using FPreviewScenes in-game for scene captures
Change 3141106 on 2016/09/27 by Thomas.Sarkanen
Column toggling improvements
Column toggle menu now does not close when items are selected.
This requries some Slate changes to how submenus are built to allow for sumbenus to specify whether they close after selection.
Also allowed columns to be hidden by default for specific use cases (like the sequence browser).
#jira UE-35818 - Anim asset browser column picker should stay up
Change 3141131 on 2016/09/27 by Thomas.Sarkanen
Fix CIS warnings
Fallout from preview world changes
Change 3141143 on 2016/09/27 by Jurre.deBaare
Fix for CIS errors
Change 3141235 on 2016/09/27 by Thomas.Sarkanen
Fix offset of Persona floor mesh when auto-alignment is enabled
When auto alignment was disabled, the offset wasnt getting taken into account.
#jira UE-35544 - In Persona, Floor Height Offset does nothing with Auto Align Floor to Mesh disabled
Change 3141327 on 2016/09/27 by Marc.Audy
Ensure that the client side AttachChildren array remains accurate
#jira UE-26025
Change 3141474 on 2016/09/27 by mason.seay
Updating test map name and moving PlayerStart
Change 3141501 on 2016/09/27 by Benn.Gallagher
Loading time improvements for destructibles from Nvidia
Updated to use new framework custom version instead of global object version
Fixed usage of TArray to enable correct loading and saving of the cached data.
#jira UE-29680
Change 3141889 on 2016/09/27 by Marc.Audy
Fix DestructibleMesh when WITH_APEX is 0
#jira UE-36484
Change 3142034 on 2016/09/27 by Marc.Audy
Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3141971
Change 3142131 on 2016/09/27 by Ori.Cohen
Make sure we return eTouch to physx during an overlap query. Fixes bad behavior when multiple objects blocked in an overlap query.
#JIRA UE-36381
Change 3142154 on 2016/09/27 by Ori.Cohen
Fix build, ModuleCachedData instead of NxApexModuleCachedData
Change 3142159 on 2016/09/27 by mason.seay
Blueprint for testing Child Actor Templates
Change 3142255 on 2016/09/27 by Jon.Nabozny
Fix crashes in QAMeshMerge component by making it a UObject, exposing it's method statically, and taking QASkeletalMeshMergeParams as an argument.
#jira UE-35199, UE-35197, UE-35201
Change 3142717 on 2016/09/27 by dan.reynolds
AEOverview Update + Sound Class Test
Change 3142764 on 2016/09/27 by Marc.Audy
Fix Ocean deprecation warnings
Change 3142962 on 2016/09/28 by Thomas.Sarkanen
Fixed bounds calculations for local camera animations
Correctly calculated bounds as local to the initial transform in the track.
Implemented suggested fixes from UDN user chhaddon (The Coalition).
#jira UE-29594 - CameraAnim bounds are incorrect when bRelativeToInitialTransform == true
Change 3143007 on 2016/09/28 by Martin.Wilson
Added virtual bones to USkeleton
API Breaking change:
-Added USkeleton pointer to RemoveBonesByName
-FReferenceSkeleton::UpdateRefPoseTransform & FReferenceSkeleton::Add made private. Must use FReferenceSkeletonModifier instead
#jira UEFW-81
Change 3143040 on 2016/09/28 by James.Golding
Strip DrawDebug.. functions from Shipping and Test builds, controlled by new define ENABLE_DRAW_DEBUG
Fix up game projects to compile in Shipping/Test after this change
PR #2757: (Contributed by projectgheist)
#jira UE-35488
Change 3143046 on 2016/09/28 by James.Golding
Fix OrionEnvironmentPerfTest.cpp compiling in Shipping (optimizations were not being re-enabled at end of file)
Change 3143047 on 2016/09/28 by James.Golding
PR #2731: Capsule primitive drawing fix (Contributed by kamrann)
#jira UE-35142
Change 3143050 on 2016/09/28 by Martin.Wilson
Update DDC key as some animation have stale data
Change 3143088 on 2016/09/28 by Martin.Wilson
CIS Fixes for Ocean after FReferenceSkeleton changes
Change 3143090 on 2016/09/28 by Benn.Gallagher
Fixed split pins in animation blueprints losing their pin links on editor restart. The anim nodes had opted out of the Super version of reconstruct, but that's where split pin restoration was added so we were skipping it.
#jira UE-36482
Change 3143091 on 2016/09/28 by Thomas.Sarkanen
Fix play/pause keyboard shortcut toggle in Persona based editors
Correctly handled widget mode switching in the skeleton selection edit mode (previously it was manually handling this rather than hooking into the correct level viewport callbacks).
Added the ability for FEdModes to specify whether they can use a widget mode.
Added a common set of commands that all Persona-based editors can opt into (only contains TogglePlay for now).
#jira UE-35163 - Cannot use Play/Pause shortcut in Persona if viewport is focused
Change 3143100 on 2016/09/28 by James.Golding
UE-32275 Fix Anim Curve entries losing Auto state when hidden/reshown
Change 3143107 on 2016/09/28 by Martin.Wilson
Add check to IsRunningParallelEvaluation to verify that the skeletal mesh component in question still references us
#jira UE-34431
Change 3143125 on 2016/09/28 by Jurre.deBaare
PR #2749: Fix blend space triangulation (Contributed by tmiv)
Change 3143225 on 2016/09/28 by Jurre.deBaare
Mesh/material merging basic test files
Change 3143235 on 2016/09/28 by Martin.Wilson
Fix issue where montage wrong section was updated with changes from details panel when clicking on a new section
#jira UE-35929
Change 3143312 on 2016/09/28 by Marc.Audy
Don't globally reregister components, globally recreate render state instead when force deleting assets
Fixes crash force deleting a blueprint with a child actor component in it from the content browser
Change 3143340 on 2016/09/28 by Mieszko.Zielinski
Improved consistency of loudness usage in AISense_Hearing #UE4
Change 3143359 on 2016/09/28 by Marc.Audy
Fix spelling error in comment
Change 3143372 on 2016/09/28 by Jurre.deBaare
HLOD meshes are causing degenerate triangles
#fix Setting flag to ignore degenerate triangles when building the meshes vertex/index buffers
#jira UE-34336
Change 3143420 on 2016/09/28 by Mieszko.Zielinski
Fix to BlackboardData initialization's dependency on parent asset's initialization #UE4
Change 3143421 on 2016/09/28 by Martin.Wilson
Allow reading on animation sequence length in blueprints
#jira UE-34168
Change 3143455 on 2016/09/28 by James.Golding
Add 'noop' versions of DrawDebug function, so you will not get compile errors by default for calling them in Shipping/Test builds.
Added optional SHIPPING_DRAW_DEBUG_ERROR define, which will give compile errors in Shipping/Test if still calling DrawDebug functions
Change 3143518 on 2016/09/28 by Jurre.deBaare
Meshes with no UV Coordinates will break the UVs of other meshes contained in the same HLOD if they share a material
#fix calculate UV bounds and check whether they occupy any space (if not do not use them for baking out the material)
#misc set texture sampling for HLOD proxy base material to clamp
#jira UE-35221
Change 3143542 on 2016/09/28 by James.Golding
Change SHIPPING_DRAW_DEBUG_ERROR define from ifdef to if
Fix comment
Enable by default for FN
Change 3143543 on 2016/09/28 by Benn.Gallagher
Changed branch + early return into an ensure during FPxQueryFilterCallback::preFilter. We were checking for invalid shapes in preFilter but that shouldn't happen. More likely to get some information as an ensure instead of earlying out on the funciton.
Change 3143556 on 2016/09/28 by Aaron.McLeran
UE-36540 Editor Preferences 'Enable Sound' option causes Real Time Audio to Stop Working after PIE
Change 3143566 on 2016/09/28 by Benn.Gallagher
Readded early out alongside new ensure for catching bad preFilter shapes
Change 3143568 on 2016/09/28 by Marc.Audy
Fix deprecation warnings in UT
Change 3143572 on 2016/09/28 by Jurre.deBaare
More test content for mesh/material merging
Change 3143581 on 2016/09/28 by Jurre.deBaare
More content :D
Change 3143585 on 2016/09/28 by Jurre.deBaare
Geometry cache cleaning
#misc fix for missing materials, not serialized (facepalm) as they were added later on (required custom version bump)
#misc cleaning out unecessary code
Change 3143594 on 2016/09/28 by Marc.Audy
Creating a child actor component by dragging an actor blueprint in to another blueprint now properly creates the template
#jira UE-36511
Change 3143658 on 2016/09/28 by Marc.Audy
RootComponent can be null by the time we hit PostUnregisterAllComponents so need to protect against the dereference
#jira UE-36553
Change 3143776 on 2016/09/28 by Marc.Audy
Properly reinstance child actor templates when using the fast reinstancing path
#jira UE-36516
Change 3143896 on 2016/09/28 by Ori.Cohen
Remove UPROPERTY on aggregate threshold which is always read from the physics settings.
Change 3144022 on 2016/09/28 by Ben.Zeigler
Move AIMoveTo node from BlueprintGraph to AIGraph and remove BlueprintGraph->AIModule dependency in build system
Change 3144252 on 2016/09/28 by mason.seay
More blueprints for child actor template testing
Change 3144262 on 2016/09/28 by Mason.Seay
Deleting assets
Change 3144283 on 2016/09/28 by dan.reynolds
AEOverview update + Sound Priority Test
Change 3144411 on 2016/09/28 by dan.reynolds
AEOverview end of day update and tweaks
Change 3144679 on 2016/09/29 by Benn.Gallagher
Changed skeletal bounds calculation to not consider clothing assets that aren't simulating in the current LOD. In this case we're not rendering the clothing, we're only rendering the skeletal geometry for that section in that LOD which isn't bound to cloth.
Change 3144856 on 2016/09/29 by Jurre.deBaare
HLOD Outliner scrolls back to the top when generating proxy meshes
#fix OnLevelActorsAdded was getting called for actors in the thumbnail worlds, which forced a refresh on the listview
#jira UE-30384
Change 3144864 on 2016/09/29 by Thomas.Sarkanen
Preview mesh fixes
Animation preview meshes are now respected (and saved). Mesh is displayed as empty if none is set (but a default is chosen).
Skeleton preview meshes are now shown as empty if none is set (but a default is chosen).
#jira UE-36582 - Cannot set preview mesh per-animation
Change 3144865 on 2016/09/29 by Jurre.deBaare
More test content
Change 3144885 on 2016/09/29 by James.Golding
UE-35307 Move 'invalid scale' warning to Message Log to be more visible in editor
Change scale clamping in UpdateBodyScale to catch cases like (1,0,1)
Change 3144903 on 2016/09/29 by Thomas.Sarkanen
Deprecating StaticMesh in UStaticMeshComponent
Added GetStaticMesh to access the value as read-only.
SetStaticMesh is now called in all locations that used to call "StaticMesh =".
Lots of fixups.
#jira UE-24859 - Deprecate public access to StaticMesh property in UStaticMeshComponent
Change 3145020 on 2016/09/29 by Thomas.Sarkanen
Fix bounds calculations that include bones to respect LOD (and other requried bones)
Sometimes bones would not be updated if we LOD switched, extending the bounds.
#jira UE-36525 - UDebugSkelMeshComponent::CalcBounds should filter by LOD
Change 3145041 on 2016/09/29 by Jurre.deBaare
Setting the Target Lightmap UV Channel to an incorrect value leads to inconsistent results
#fix removed target light map channel, we now determine according to the UV channels which are unused in the final mesh
#misc ignore the source lightmap uv channels to reduce data
#jira UE-36595
Change 3145219 on 2016/09/29 by Benn.Gallagher
Fixed clothing actors not casting shadows in editor, after the material editing change the copy of the shadow flag was missed from the clothing association code, which runs on again on older clothing assets to use the new render data skinning. Also added some fix up for assets that have be saved in the mean time.
#jira UE-36552
Change 3145222 on 2016/09/29 by Jurre.deBaare
Exporting Alembic Skeletal mesh from UE4 to FBX causes a crash
#fix on import set _all_ bone influence to 0
#jira UE-36602
Change 3145267 on 2016/09/29 by Ori.Cohen
Move OnConstraintBreak delegate so that it fires outside of fetchResults. Fixes crash from user doing unsafe things during fetchResults.
#JIRA UE-36483
Change 3145306 on 2016/09/29 by Jon.Nabozny
Fixed PhAT so multiple constraints can be selected and edited properly at the same time.
#JIRA: UE-31493
Change 3145342 on 2016/09/29 by Marc.Audy
Do not update cull distance volumes whenever any property changes
* Any movement or property change of a cull distance volume still does a global update
* Any movement of a component belong to any other Actor updates only the components of that Actor
* Any property change of a primitive component only updates that component
#jira UE-36399
Change 3145958 on 2016/09/29 by Marc.Audy
In game worlds don't auto activate components until the actor is ready to process them
#jira UE-35189
Change 3146110 on 2016/09/29 by dan.reynolds
AEOverview update + Soundwave Procedural Test Map
Change 3146375 on 2016/09/30 by Benn.Gallagher
Fixed crash saving newly created destructible mesh after material refactor.
#jira UE-36619
Change 3146378 on 2016/09/30 by James.Golding
UE-35908 Line trace against a BodyInstance now returns closest hit for trimesh (was any hit before)
Also add stat for FBodyInstance::LineTrace
Change 3146379 on 2016/09/30 by James.Golding
Add test assets for creating procmesh collision in non-editor builds
Change 3146386 on 2016/09/30 by Thomas.Sarkanen
Fixed ensures (and functionality) of 'show uncompressed animation' option in Persona viewports
Made sure that PreEvaluateAnimation is called for th einstance in use, rather than only the preview instance.
This unearthed another issuye where each of the calls to GenSpaceBAses was causing the animation to run faster. Fixed this by resetting the update flag in the update context after it is used.
#jira UE-36251 - Ensures showing uncompressed animations in anim blueprints
Change 3146464 on 2016/09/30 by Thomas.Sarkanen
Fix layered blend per bone odd/even connection counts alternately working/not working
Older hacky fix for multi-property to array copies flip-flipped between using fast path and not, when it really should have disabled fast path after the first array pin. Now it disables fast path based on whether this is a new handler or not, rather than looking at the SimpleCopyPropertyName.
#jira UE-35648 - Layered Blend Per Bone doesn't work correctly with 3+ inputs
Change 3146652 on 2016/09/30 by Benn.Gallagher
Fixed subinstance properties appearing in the caller's details panel as oddly named properties.
#jira UE-34141
Change 3146673 on 2016/09/30 by Martin.Wilson
Make RawAnimationData (and associated anim sequence data) private
#jira ue-25869
Change 3146680 on 2016/09/30 by Benn.Gallagher
Fixed errant asterisks in tooltips for source and target bone on rotation multiplier controller node
#jira UE-29847
Change 3146681 on 2016/09/30 by Benn.Gallagher
Fixed incorrect tooltip on left hand IK bone in hand ik retargetting node
#jira UE-30885
Change 3146711 on 2016/09/30 by Jon.Nabozny
Fix PhAT SnapConstraintToBone.
#jira UE-31491
Change 3146717 on 2016/09/30 by Danny.Bouimad
Adding Jurres really useful merge actor test assets to somewhere QA can get em.
Change 3146738 on 2016/09/30 by Martin.Wilson
Fix pose blending for on non-additive pose blending + remove normalising of weights for weights less than 1
#tests Editor tests with mambo pose asset
#jira UE-36189
Change 3146750 on 2016/09/30 by Jurre.deBaare
Material baking issue
#misc Removed the renderer initialization which causes issue the first time you would render out a material (gradient from top left to bottom right over the texture)
#misc Replaced incorrect masks with _way_ better approach thanks to Martin
Change 3146755 on 2016/09/30 by Jurre.deBaare
Need better progress bar for HLOD
#fix replaced the progress updates with new more 'correct' ones according to the actual workload and fixed up the Simplygon progress callback
#jira UE-34334
Change 3147085 on 2016/09/30 by Marc.Audy
PR #2815: GetNextViewablePlayer now checking and returning correct PlayerState. (Contributed by joshkay)
#jira UE-36632
Change 3147224 on 2016/09/30 by Martin.Wilson
CIS Fix
Change 3147280 on 2016/09/30 by Marc.Audy
Mouse smoothing should use application frame rate, not the dilated game frame rate
#jira UE-31040
Change 3147446 on 2016/09/30 by Aaron.McLeran
UE-36682 SoundCue Delay Not Consuming Input StartTime Correctly
Change 3147693 on 2016/09/30 by Ben.Zeigler
#jira UE-36657
If a player has an existing Pawn during RestartPlayer, use that pawn's rotation instead of the start spot, because we were already keeping the pawn's location
Change 3147697 on 2016/09/30 by Jon.Nabozny
Add rotation parameter to FBodyInstance::Sweep and FBodyInstance::InternalSweepPhysX
#jira UE-30486
Change 3147761 on 2016/09/30 by Jon.Nabozny
Fix AUTRepulsorBubble UPrimitiveComponent::SweepComponent usage.
Change 3148533 on 2016/10/03 by Thomas.Sarkanen
Fix new deprecation warnings introduced by the pull from main
Change 3148567 on 2016/10/03 by Marc.Audy
Fix crash when exiting PIE while a panoramic screenshot is being taken
Make stereo panorama tick with the world it is operating on
#jira UE-36492
Change 3148571 on 2016/10/03 by Marc.Audy
Allow modification of components that are EditAnywhere but don't exist in the CDO
#jira UE-36694
Change 3148607 on 2016/10/03 by Martin.Wilson
Properly end notify states when we clear the anim instance on a skeletal mesh.
#jira UE-32488
Change 3148711 on 2016/10/03 by Martin.Wilson
Fix type in virtual bone tooltip
#jira UE-36703
Change 3148746 on 2016/10/03 by Benn.Gallagher
Fixed a few cases where post process and sub instance anim calls weren't being made correctly.
#jira UE-36529
Change 3148807 on 2016/10/03 by Martin.Wilson
Fix mismatch skeleton error when undoing virtual bone changes
#jira UE-36705
Change 3148812 on 2016/10/03 by Martin.Wilson
Add undo support to removing virtual bones
#jira UE-36706
Change 3148975 on 2016/10/03 by Jurre.deBaare
Issue with combining meshes both with/without normal maps
#fix make sure we always output atleast the default normal value when baking out materials, this to ensure we output non-black values for meshes without normal maps (this would cause the normal to be incorrect)
#misc fixed issue in function to set texture rectangle to a single colour
#misc spotted comparison error
Change 3148976 on 2016/10/03 by Ori.Cohen
Make sure that shape queries that we pass into physx are never size 0. Fixes some NaNs
#JIRA UE-36639
Change 3148991 on 2016/10/03 by Jurre.deBaare
Changing LOD materials on Merged Actors Crashes Editor
#fix take into account LOD that is using the material when remapping (removing duplicate) materials
#jira UE-35883
Change 3148997 on 2016/10/03 by Jurre.deBaare
Make sure we remove matrix samples that fall outside of the import range and remap those that are in range
Change 3149002 on 2016/10/03 by Jurre.deBaare
Issues with importing Alembic caches using matrix transformations
#fix Apply conversion matrix to imported matrix samples to make them match the DCC package they were exported from
Change 3149030 on 2016/10/03 by Martin.Wilson
Dont show save warning on animations when we have curve data
#jira UE-34145
Change 3149115 on 2016/10/03 by Mieszko.Zielinski
Made PathfollowingComponent distinct between patrial and full paths in terms of acceptance radius used, when trying to determin if pathing agent is at goal location #UE4
#jira UE-35153
Change 3149186 on 2016/10/03 by Ben.Zeigler
#UE-36722 Fix failure to spawn when trying to spawn 4 capsules in the exact same location
There's no "Correct" direction to move out of a penetrating capsule, but old PhysX appeared to be consistent. New PhysX is not, so now we save and restore the adjustment instead of letting previous iterations modify it.
This code is weird but this solution is better than the old version and handles inconsistent results
Change 3149235 on 2016/10/03 by Martin.Wilson
Change inline curve name editing to only change the name of that specific curve, instead of renaming the smart name itself.
#jira UE-20005
Change 3149245 on 2016/10/03 by Marc.Audy
Remove duplicate entries from AttachChildren caused by lack of atomic cross-object updates.
Change 3149397 on 2016/10/03 by Ori.Cohen
Fix collision profile writing out response values to channels that don't exist.
#JIRA UE-36359
Change 3149679 on 2016/10/03 by Zak.Middleton
#ue4 - Don't mark CharacterMovementComponent::bUseControllerDesiredRotation as an advanced property. Consolidate rotation settings (RotationRate, bUseControllerDesiredRotation, bOrientRotationToMovement) in a new "Rotation Settings" category.
Change 3149929 on 2016/10/04 by Jurre.deBaare
Fix for CIS errors
#fix Mac didn't like undefined struct
Change 3149977 on 2016/10/04 by danny.bouimad
Massive update to Merge Actor test files
Change 3150014 on 2016/10/04 by James.Golding
UE-36686 Fix crash when slicing and not creating other section
Change 3150016 on 2016/10/04 by James.Golding
UE-35335 MergeActors now converts box collision to convex, so collision scales correctly after merging
Change 3150019 on 2016/10/04 by James.Golding
UE-36737 Fix LineTraceComponent not returning face index
Change 3150020 on 2016/10/04 by James.Golding
UE-36672 Export PhysicsContstraintComponent class so it can be subclassed outside Engine module
Change 3150027 on 2016/10/04 by Ben.Marsh
Add PhysX build option into Dev-Framework.
Change 3150042 on 2016/10/04 by Benn.Gallagher
Fixed clothing example 1.3 collision glitches
Change 3150172 on 2016/10/04 by Benn.Gallagher
Made Skeletal Mesh LOD reimports clear any existing simplification flag so we don't show "generated" next to LOD entries for them.
#jira UE-36589
Change 3150319 on 2016/10/04 by Ori.Cohen
Go back to only deferring body creation per component. This can now use the slow path when needed. Can't support deferring of multiple components without changing locking API so we'll do that in the future.
#JIRA UE-36535, UE-36504
Change 3150355 on 2016/10/04 by Zak.Middleton
#ue4 - Change checkSlow() to check() in GetDefaultObject<> because this is potentially an unsafe static cast.
Change 3150370 on 2016/10/04 by Ori.Cohen
Fix deferred actors not getting flushed.
Change 3150386 on 2016/10/04 by Martin.Wilson
Fix additive animation check failing in cooked builds when using virtual bones
#jira UE-36743
Change 3150424 on 2016/10/04 by Ori.Cohen
Exclude kinematic actors from active transforms generation.
Change 3150613 on 2016/10/04 by Zak.Middleton
#ue4 - Fix bad GetDefaultObject<> in AbilitySystemGlobals. Turned up since changing checkSlow() to check() in GetDefaultObject.
(Mirror CL 3138304 in Orion-DevGeneral)
#jira UE-36810
#tests compiled
Change 3150679 on 2016/10/04 by Ben.Zeigler
Crash fix with no async scene
Change 3150765 on 2016/10/04 by Ben.Zeigler
Deprecate UStructProperty::ExportTextItem_Static and ImportItem_Static, and add ExportText and ImportText directly to UScriptStruct
Add bAllowNativeOverride to specify rather to call the native override. For unclear reasons the static export skipped the native override while the static import included it
This allows calling the generic ImportText from inside a native ImportTextItem and then doing some post processing
Change 3150796 on 2016/10/04 by Marc.Audy
Fix LOCTEXT warnings related to blueprint class menu options
Change 3150806 on 2016/10/04 by Ben.Zeigler
Fix bad text format in import error message, lead to double error
Change 3150891 on 2016/10/04 by Ben.Zeigler
#jira UE-36170 Fix duplicate GUID spam when async loading levels during PIE by checking the package flag instead of the runtime global
Change 3150914 on 2016/10/04 by Marc.Audy
Don't try to recreate render state if it has already been recreated while the recreate context was active
#jira UE-36590
Change 3151195 on 2016/10/04 by Dan.Reynolds
Updates to QASoundWaveProcedural
QASoundWaveProcedural edited to be a GameplayStatic which spawns an Audio Component Handler as well as a Procedural Sound Wave. Support for envelope shaping (Attack, Sustain, Release) as well as multiple waveforms (Sine, Triangle, Sawtooth, Square). Blueprint API expanded to include separate functions for setting QASoundWaveProcedural settings and Playing.
Change 3151233 on 2016/10/04 by Ben.Zeigler
#jira UE-36836 Fix variable shadowing warnings
Change 3151328 on 2016/10/04 by dan.reynolds
AEOverview Update - Added Sound Wave Procedural test map and added support for mobile (tested on Android) menu selection - Still a WIP
Change 3151461 on 2016/10/05 by Thomas.Sarkanen
Fix localization warnings
#jira UE-36720 - //UE4/Main: Step 'Build Engine Localization' - 2 Warnings
Change 3151546 on 2016/10/05 by Martin.Wilson
Fix pose watch regression due to persona refactor changes.
#jira UE-36851
Change 3151587 on 2016/10/05 by Jurre.deBaare
Updating Simplygon to SDK version 8.0
#misc removed redundant files
#misc fixed landscape culling in merge actor path
#misc added support for volume culling using simplygon
#misc fixed when or not to use mesh data for material baking
#notes
Change: 3137650
Date: 23/09/2016 07:57
Client: Mustafa.Tungekar_Dev-Partner-Simplygon
User: Mustafa.Tungekar
Status: submitted
Type: restricted
ImportedBy:
Identity:
Description:
-Renamed commandline variables for ZipUtils AutomationScript
-Implemented Execute instead of ExecuteBuild
-Updated commandline arguments in SimplygonSwarm
JobStatus:
Jobs:
Files:
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Private/SimplygonSwarm.cpp#4
//UE4/Dev-Partner-Simplygon/Engine/Source/Programs/AutomationTool/Scripts/ZipUtils.Automation.cs#2
Change: 3137649
Date: 23/09/2016 07:56
Client: Mustafa.Tungekar_Dev-Partner-Simplygon
User: Mustafa.Tungekar
Status: submitted
Type: restricted
ImportedBy:
Identity:
Description:
Moved file hash computation to ImportObject
JobStatus:
Jobs:
Files:
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Classes/Factories/Factory.h#4
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Private/Factories/Factory.cpp#4
Change: 3137646
Date: 23/09/2016 07:55
Client: Mustafa.Tungekar_Dev-Partner-Simplygon
User: Mustafa.Tungekar
Status: submitted
Type: restricted
ImportedBy:
Identity:
Description:
Fixes CL3099204
EditorPerProjectUserSetting
Removed ConfigRestartRequired attribute from properties where it was not required
MeshUtilities
-Added FProxyFailedDelegate
-Extended IMeshMerging to include FProxyFailed delegate
-Added ProxyGenerationFailed method to FProxyGenerationProcessor class
-Setup FailedDelegate for both MeshMerging and DistributedMeshMerging
SimplygonMeshReduction
-Added check for invalid texture id
-Updated notes and removed commented code that is not required.
-Setup failed delegate
-Fixed issue where image data was never hooked into the texture.
-Fixed issue where texture table was never passed into casters
SimplygonSwarm
-Setup failed delegate
-Fixed RawMesh pointer usage.
-Move helper method into SimplygonSwarmHelpers.h.
-Added SimplygonSwarmHelpers
-Removed redundant constant path to 7-zip
-Removed GetSimplygonDirectory instead using inplace.
-Removed commented code that is currently not required.
-Fixed Typos
JobStatus:
Jobs:
Files:
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/MeshUtilities/Private/MeshUtilities.cpp#3
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/MeshUtilities/Public/MeshUtilities.h#3
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonMeshReduction/Private/SimplygonMeshReduction.cpp#4
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Private/SimplygonSwarm.cpp#3
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Public/SimplygonSwarmHelpers.h#1
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Classes/Editor/EditorPerProjectUserSettings.h#3
Change: 3099204
Date: 24/08/2016 07:56
Client: Mustafa.Tungekar_Dev-Partner-Simplygon
User: Mustafa.Tungekar
Status: submitted
Type: restricted
ImportedBy:
Identity:
Description:
Simplygon 8.0 Updates
Deprecated support for 7.0 and updated SimplygonSwarm and SimplygonMeshReduction to use 8.0
EditorPerProjectSettings
*SwarmMaxUploadChunkSizeInMB for limiting the max upload size for swarm. Note the Simplygon Grid has a limitation of 2GB
*SwarmNumOfConcurrentJobs for executing number of concurrent jobs
*Fixed issue where SG_MATERIAL_CHANNEL_METALLIC to SG_MATERIAL_CHANNEL_METALNESS (Chage in 8.0 SDK)
SPL, SimplygonSwarm, RESTClient
*Bumped up SPL Version to 8
*Fixed code paths to use ZipUtils UAT script for zipping and unzipping CL3094374
*Removed SPL Templates for version 7.0
*Added conditional logging to REST methods
*Added multi part upload. The RESTClient automatically decided if large files need to be split up before uploading to simplygon grid.
*Updated method to take in texturepath
SimplygonMeshReduction
*Removed minimum version requirement.
*Bumped up minimum version
*Chagned license file name to refelect 8.0 changes
*MaterialBaking related method now take in TextureTable as an extra parameter. This is due to 8.0 move away from old way of setting up materials and using SimplygonShadingNetowrk based appraoch.
JobStatus:
Jobs:
Files:
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonMeshReduction/Private/SimplygonMeshReduction.cpp#3
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonMeshReduction/Public/SimplygonTypes.h#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Private/SimplygonRESTClient.cpp#3
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Private/SimplygonSwarm.cpp#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Public/SimplygonRESTClient.h#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Public/SimplygonSwarmPrivatePCH.h#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Classes/Editor/EditorPerProjectUserSettings.h#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Private/Settings/EditorPerProjectUserSettings.cpp#2
Change: 3099200
Date: 24/08/2016 07:48
Client: Mustafa.Tungekar_Dev-Partner-Simplygon
User: Mustafa.Tungekar
Status: submitted
Type: restricted
ImportedBy:
Identity:
Description:
#fix Copy constructor for FMeshReduciton mapped ShadingImportance to SilhouetteImportance
JobStatus:
Jobs:
Files:
//UE4/Dev-Partner-Simplygon/Engine/Source/Runtime/Engine/Classes/Engine/MeshMerging.h#2
Change: 3099199
Date: 24/08/2016 07:47
Client: Mustafa.Tungekar_Dev-Partner-Simplygon
User: Mustafa.Tungekar
Status: submitted
Type: restricted
ImportedBy:
Identity:
Description:
Added Automation Script ZipUtils to zip file and unzip files from SimplygonSwarm.
This will remove any dependency on external zip program and should work across platforms
JobStatus:
Jobs:
Files:
//UE4/Dev-Partner-Simplygon/Engine/Source/Programs/AutomationTool/Scripts/AutomationScripts.Automation.csproj#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Programs/AutomationTool/Scripts/ZipUtils.Automation.cs#1
Change: 3099197
Date: 24/08/2016 07:40
Client: Mustafa.Tungekar_Dev-Partner-Simplygon
User: Mustafa.Tungekar
Status: submitted
Type: restricted
ImportedBy:
Identity:
Description:
*Speed improvements for FBX Scene Importer
*Added a static method to compute Hash.
JobStatus:
Jobs:
Files:
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Classes/Factories/Factory.h#3
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Private/Factories/Factory.cpp#3
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Private/Fbx/FbxStaticMeshImport.cpp#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Runtime/Engine/Classes/EditorFramework/AssetImportData.h#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Runtime/Engine/Private/EditorFramework/AssetImportData.cpp#2
Change 3151664 on 2016/10/05 by Richard.Hinckley
Fixing ACharacter template for "New C++ Class" feature. Avoiding naming a function parameter the same as an existing class member.
Change 3151729 on 2016/10/05 by Thomas.Sarkanen
Audit of remaining NaN checks
Some checks remain on in shipping (generally those called from blueprint):
- AActor::TeleportTo
- AActor::SetActorRelativeScale3D
#jira UE-30999 - Optimize ⌠ContainsNaN÷ and ⌠ContainsNaNOrInfinite÷, audit those still in shipping/test
Change 3151742 on 2016/10/05 by Ori.Cohen
Make sure that if physical animation component doesn't find a body and bone it doesn't crash.
#JIRA UE-36839
Change 3151756 on 2016/10/05 by Jurre.deBaare
Fixing d3dcompiler_47.dll missing issue
#fix added runtime dependency and dll name to build.cs file
#fix now load the d3dcompiler_47.dll from the Binaries/ThirdParty/Windows folder before loading the simplygon DLL
Change 3151761 on 2016/10/05 by Thomas.Sarkanen
Fix deprecation warning from last integration
Moved Preview to EditorPreview in FEditorWorldManager::OnWorldContextAdd.
#jira UE-36858 - Compile UE4Editor* completed with 1 warning
Change 3151782 on 2016/10/05 by Jurre.deBaare
Simplygon patch up
#misc linker errors popping up from JSONCPP
#misc incorporated emissive material property fix from other shelve
#misc static analysis fix
Change 3151804 on 2016/10/05 by Marc.Audy
Clear need end of frame update when unregistering a component
Change 3151928 on 2016/10/05 by Ori.Cohen
Fix runtime DLLs not including all delay loaded physx dll files.
#JIRA UE-36816
Change 3151977 on 2016/10/05 by Martin.Wilson
Notifies can no longer occupy the same time on the same track.
#jira UE-30658
Change 3151989 on 2016/10/05 by Jon.Nabozny
Fix ArchVis character rotation pitch when looking up/down.
#jira UE-35706
Change 3152083 on 2016/10/05 by Marc.Audy
Ensure that pending kill components get their marked for end of frame state cleared.
Change 3152086 on 2016/10/05 by Ben.Zeigler
#jira UE-36169 Fix it so missing linker errors that point to Blueprint CDOs are skipped, the same way it skips linker errors going to the actual class. Fixes a lot of spurious warnings from deleting components from blueprints or native classes
Clean up the VerifyImport error handling so it also displays in -game and cook, and fix the missing class warning to work properly, previously it would happen 0% in development 100% in debug even if the class was valid
Change 3152093 on 2016/10/05 by Marc.Audy
Change logic for when location cannot be changed for a static component to be independent of has begun play and have to do with whether construction script is running or the level is in the process of loading (mostly for backwards compatibility adjustments in post load).
#jira UE-36146
#jira UE-24647
Change 3152100 on 2016/10/05 by Ben.Zeigler
Remove pragma optmize
Change 3152112 on 2016/10/05 by Marc.Audy
Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3152072
Change 3152134 on 2016/10/05 by Jurre.deBaare
Simplygon/Merge actor issues
#fix for emissive output on meshes that do not have emissive properties
#fix for texture binning, not removing invalid split area causing overlapped textures
Change 3152136 on 2016/10/05 by James.Golding
UE-36859 Fix tooltip saying you can click to stop recording
Change 3152169 on 2016/10/05 by James.Golding
UE-31209 UE-30935 : Expose bDeformableMesh and bFastCook options in FTriMeshCollisionData
ProceduralMeshComponent will now cook using 'fast' and 'deformable' options, so updating collision on sections should work correctly
Change ERuntimePhysxCookOptimizationFlags to EPhysXMeshCookFlags and use that to pass options to CookConvex and CookTriMesh
Change 3152202 on 2016/10/05 by Jurre.deBaare
Mac/Linux fix
Change 3152303 on 2016/10/05 by Marc.Audy
Fix deprecation warning post merge from main
Change 3152320 on 2016/10/05 by Martin.Wilson
Fix root motion from everything calculating incorrect root motion when animations haven't been ticking
#jira UE-35364
Change 3152354 on 2016/10/05 by James.Golding
PoseDriver should pass through if no poses activated
Change 3152357 on 2016/10/05 by James.Golding
UE-36844 Remove unused OnAssetModifiedNotifier delegate from PoseAsset, ensure OnPoseListChanged is called when updating PoseAsset from anim.
Change 3152556 on 2016/10/05 by Marc.Audy
Remove autos
Change 3152560 on 2016/10/05 by Marc.Audy
Don't allow child actor references to be dragged from the outliner to a level script
#jira UE-16700
Change 3152568 on 2016/10/05 by Marc.Audy
Don't allow non-networking code to set bRemoteOwned in the actor spawn parameters
Remove deprecated bNoCollisionFail
#jira UE-35928
Change 3152575 on 2016/10/05 by Marc.Audy
Allow construction script to run post move for native classes. Actor can determine whether it should only occur on finish or every call to post edit move
Change 3153101 on 2016/10/06 by Thomas.Sarkanen
Fix crash re-opening the viewport in Persona-based editors
#jira UE-36775 - Editor crashes when re-opening viewport in Persona
Change 3153139 on 2016/10/06 by James.Golding
UE-36908 Remove GetRuntimeOnlyCookOptimizationFlags if cooking is not supported
Change 3153160 on 2016/10/06 by Thomas.Sarkanen
Fix for crash when deleting additive layer track
Code had not been updated to use the new delgate system (was still using reciprocal FPersona ptr).
#jira UE-36740 - Crash when removing or disabling an additive layer track in Persona
Change 3153175 on 2016/10/06 by Benn.Gallagher
Fixed crashes when using subinstances in non-default states. we previously initialized the anim instances in the node initialize, but in states that haven't been hit by an initialize this will happen off the game thread which is not allowed.
#jira UE-36900
Change 3153223 on 2016/10/06 by Thomas.Sarkanen
Fixed crash when opening an asset from the blend space editor
Code was still trying to open 'old' Persona when it was disabled.
Also fix other call sites where this was being done outside of asset type actions.
#jira UE-36766 - Crash attempting to open an asset from Aim Offset graph in Persona
Change 3153324 on 2016/10/06 by Thomas.Sarkanen
Prevented invalid GUIDs from being saved into smart name containers
AddOrFindName now checks to see if existing GUIDs are valid before using them.
AddName now requires a valid GUID to be passed in.
Also added Modify() call to the skeleton when FindOrAddSmartName is called from VerifySmartNameInternal, as without this the skeleton might not get saved.
Also add Laurent's fix for fixing up already-saved invalid GUIDs (CL 3138068).
#jira UE-36367 - It is possible for curves with an invalid GUID to be saved into the USkeleton asset
Change 3153348 on 2016/10/06 by Martin.Wilson
Re add ticking code so all Persona editors viewports tick during drag events (went missing in Persona refactor)
#jira UE-36751
Change 3153426 on 2016/10/06 by Mieszko.Zielinski
Added missing elements of block comments support in BT editor #UE4
Change 3153454 on 2016/10/06 by Benn.Gallagher
Fixed crash using anim debug with subinstances that are preceded by branching nodes.
#jira UE-36935
[CL 3153517 by Ori Cohen in Main branch]
2016-10-06 12:11:11 -04:00
# if ENABLE_DRAW_DEBUG
2018-02-22 11:25:06 -05:00
static void DrawDebugLeg ( const FAnimLegIKData & InLegData , FAnimInstanceProxy * MyAnimInstanceProxy , const FColor & InColor )
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
{
2018-02-22 11:25:06 -05:00
const USkeletalMeshComponent * SkelMeshComp = MyAnimInstanceProxy - > GetSkelMeshComponent ( ) ;
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
for ( int32 Index = 0 ; Index < InLegData . NumBones - 1 ; Index + + )
{
2018-02-22 11:25:06 -05:00
const FVector CurrentBoneWorldLoc = GetBoneWorldLocation ( InLegData . FKLegBoneTransforms [ Index ] , MyAnimInstanceProxy ) ;
const FVector ParentBoneWorldLoc = GetBoneWorldLocation ( InLegData . FKLegBoneTransforms [ Index + 1 ] , MyAnimInstanceProxy ) ;
MyAnimInstanceProxy - > AnimDrawDebugLine ( CurrentBoneWorldLoc , ParentBoneWorldLoc , InColor , false , - 1.f , 2.f ) ;
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
}
}
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3153514)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3050254 on 2016/07/14 by Marc.Audy
Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3049614
Change 3136629 on 2016/09/22 by Marc.Audy
bye bye auto
Change 3136631 on 2016/09/22 by Marc.Audy
Allow objects to be marked as duplicate transient or non PIE duplicate transient
ChildActors are not marked consistent with the property that references them as text export transient and non PIE duplicate transient
#jira UE-35680
Change 3136636 on 2016/09/22 by Marc.Audy
ParticleSystem and Audio Components now route Activate/Deactivate events to blueprints
Component Activate/Deactivate events now provide component as a property
#jira UE-35191
Change 3136640 on 2016/09/22 by Marc.Audy
Expose bReplicates to blueprint component properties
#jira UE-34433
Change 3136709 on 2016/09/22 by Ori.Cohen
Fix GetBodyInstance returning incorrect bodies when welded kinematics are attached.
#JIRA UE-36234
Change 3136710 on 2016/09/22 by Ori.Cohen
Fix defer actors not working when the physics scene is simulating. We now flush when the scene is not simulating, as well as a lazy flush that goes through the slow path when needed. This allows us to batch multiple components together.
#JIRA UE-35899
Change 3136770 on 2016/09/22 by Marc.Audy
Fix compile error
Change 3136854 on 2016/09/22 by Marc.Audy
Sprite components need to be text export transient
#jira UE-36064
Change 3136926 on 2016/09/22 by Ori.Cohen
Fix ensure when skeletal mesh bodies have no collision.
Change 3137054 on 2016/09/22 by Aaron.McLeran
PR #2628: Fix UAudioComponent SubtitlePriority not being initialised (Contributed by alanedwardes)
Change 3137058 on 2016/09/22 by Aaron.McLeran
PR #2562: ReadCompressedInfo calculates duration for ADPCM audio (Contributed by derekvanvliet)
Change 3137060 on 2016/09/22 by Aaron.McLeran
UE-36336 Fixing A3D for mono/2D sounds
- Making it so if A3D is being loaded but not enabled, we can not have reverb on 2D sounds
- Fixing A3D mono sources from failing after a time
Change 3137066 on 2016/09/22 by Aaron.McLeran
Checking in Ngs2.Build.cs with A3D and USING_A3D set to 0
Change 3137098 on 2016/09/22 by dan.reynolds
AEOverview Update: EQ Map, Reverb Map plus improvements on Main array cleanup process.
Change 3137132 on 2016/09/22 by Aaron.McLeran
PR #2789: Fixed signature of FActiveSound::GetIntParameter (Contributed by Laurie-Hedge)
Change 3137175 on 2016/09/22 by Aaron.McLeran
Fixing compile error with PhysXCollision.cpp from CL 3136710
Change 3137540 on 2016/09/23 by Thomas.Sarkanen
Fixed crash when generating LODs automatically for skeletal meshes
Quadric error reduction does not support skeletal meshes, so fails. Client code assumes that it cannot fail so crashed. This guards against immediatly assuming that LODs are valid after simplification.
#jira UE-36253 - Crash applying LOD changes in Persona
Change 3137720 on 2016/09/23 by Thomas.Sarkanen
Changed asset shortcut bar to display asset names & reworked padding
#jira UE-36347 - Anim asset shortcut bar has difficult to read/cut-off text
Change 3137761 on 2016/09/23 by Martin.Wilson
Fix typo in root motion from everything accumulation code
Change 3137877 on 2016/09/23 by Thomas.Sarkanen
Fixed undo/redo forcing skeletal meshes into t-pose
Re-populated AnimationData in InitAnim for UDebugSkelMeshComponent.
#jira UE-35579 - If you undo an animation change to any animation asset (for single preview), the playback controls will no longer function
Change 3137885 on 2016/09/23 by Benn.Gallagher
Fixed APEX clothing disappearing when time dilation results in a dt of 0. After simulating an actor with 0 APEX will fill positions and normals with NaNs, causing the disappearance. The fix in this case is to not schedule the evaluation task if we're not wanting to do any work. The simulation then freezes as we would expect.
#jira UE-35151
Change 3137888 on 2016/09/23 by Benn.Gallagher
Fixed transition nodes being able to be pasted or duplicated without 2 valid pin links
#jira UE-24860
Change 3137889 on 2016/09/23 by Benn.Gallagher
Fixed transform and widget inconsistencies in IK edit mode
#jira UE-20628
Change 3137890 on 2016/09/23 by Jurre.deBaare
Alembic Cached Geometry Does Not Display in Stand Alone Game
#fix required to force load the GeometryCache module during runtime
#jira UE-36187
Change 3137892 on 2016/09/23 by Jurre.deBaare
Geometry cache playback should work in sequencer
#fix add Interp UProperty tag to specific properties used for playing back the cache, future fix is having same approach as skeletal mesh animation for sequencer (depends on needs, -> skeletal mesh import has better compression anyway)
#jira UE-35447
Change 3137893 on 2016/09/23 by Jurre.deBaare
Alembic Cache Importer option for Hard Edge Angle Threshold does not work for objects with no normals
#fix adhere to the assumed 'standard' no normals in ABC file means completely smooth normals throughout the sequence
#jira UE-35091
Change 3137894 on 2016/09/23 by Jurre.deBaare
Importing an Alembic File While mesh Distance Fields are Enabled Crashes Editor
#fix Needed to save the raw mesh before building the mesh to ensure a LOD resource was created
#misc added a new check + message in case this occurs again
#jira UE-36059
Change 3137938 on 2016/09/23 by Jurre.deBaare
Alembic Importing with Incorrect UV's
#fix adding option for flipping UVs on import
#jira UE-36190
Alembic import axis not aligned correctly
#fix also added option to specify scale and rotation to be applied during import (with preset for Maya and Max)
#jira UE-35510
Change 3137949 on 2016/09/23 by Jurre.deBaare
Frame range importing causes confusion during Alembic importing
#fix this required storing information per Alembic object at which frame index it actual has stored frames, using this data we can determine which frames are empty, and at which frame there is data. This allows us to skip empty frames if we want to import data-only frames, or to import all frames in the sequence including empty (pre-roll) frames.
#misc changed settings UI listview layout (extra columns and resized old ones)
#jira UE-35498
Change 3137994 on 2016/09/23 by Martin.Wilson
Fix for creating an empty state when dragging a montage into a state machine graph
#jira UE-33371
Change 3138103 on 2016/09/23 by Aaron.McLeran
UE-36312 Fixing sound node distance cross fade for case of looping sounds
Change 3138104 on 2016/09/23 by Aaron.McLeran
UE-35392 Copy pasting local node into separate project crashes the engine
Change 3138224 on 2016/09/23 by Aaron.McLeran
UE-36312 Fixing sound node distance cross fade for case of looping sounds
- Adding a check for wave instance count to account for virtualized sounds (one-shots)
Change 3138666 on 2016/09/23 by Ben.Zeigler
#UEFW-204 Add more comprehensive gameplay tag tests
Fix issue with HasTag(Tag, IncludeParent, IncludeParent) revealed by tests, this was not returning true correctly in some cases. This use case is weird and will be deprecated soon
Change 3138779 on 2016/09/23 by Marc.Audy
Get rid of pointless casts
Change 3138782 on 2016/09/23 by Marc.Audy
remove some GWorlds
Change 3139701 on 2016/09/26 by Jurre.deBaare
Assert failed on GemetryCache for PS4 package
#fix add GeometryCache reference in engine build.cs and fix the serialization of geometry cache files
#jira UE-36392
Change 3139704 on 2016/09/26 by Jurre.deBaare
Fix for -1 begin frame
#fix do the max as an signed int, to make sure we don't wrap around
Change 3139748 on 2016/09/26 by Benn.Gallagher
PR #2784: Make sure that SceneScratchBufferSize is a multiple of 16K as requested by PhysX (Contributed by DenizPiri)
Moved the definition of the boundary to a FPhysScene class static
Changed comments on original user settings property to communicate the fact that the value is now rounded to the next 16K boundary
#jira UE-35736
Change 3139903 on 2016/09/26 by Benn.Gallagher
Fixed exposing subinstance pins stomping over class defaults and setting to uninitialized values
#jira UE-34366
Change 3140409 on 2016/09/26 by Lukasz.Furman
fixed uninitialized configs of gameplay debugger
copy of CL# 3140399
Change 3140516 on 2016/09/26 by dan.reynolds
AEOverview Map Update - Ambient Zone + Focus Test
Change 3140526 on 2016/09/26 by Jon.Nabozny
#rn Fixed CanJump inconsistencies with previous versions.
Deferred JumpCurrentCount increment until after jump, made bWasJumping a member variable, and updated how
jump count and hold time were compared in CanJump.
#jira UE-35524, UE-35582
Change 3140745 on 2016/09/26 by dan.reynolds
AEOverview Test Map Update + Occlusion Test
Change 3140839 on 2016/09/26 by dan.reynolds
AEOverview - minor updates
Change 3141101 on 2016/09/27 by Thomas.Sarkanen
Preview scene worlds now render correctly
Split "Preview" type into "EditorPreview" (the default) and "GamePreview". Deprecated the old "Preview" world type (but kept its index).
In-game hidden flags now apply to GamePreview, but not EditorPreview worlds.
Deprecated old bHack_Force_UsesGameHiddenFlags_True boolean. GamePReview now serves this purpose.
Fixed up UT cases where this was being used.
FPreviewScenes now use the editor mode by default, but can be set to non-editor if needed (as is the case with the still-experimental UViewport).
Custom depth pass is not enabled for EditorPreview (as before) but is for GamePreview.
Fixed erroneous use of TEnumAsByte for non-uproperty WorldType.
#jira UE-22883 - Using FPreviewScenes in-game for scene captures
Change 3141106 on 2016/09/27 by Thomas.Sarkanen
Column toggling improvements
Column toggle menu now does not close when items are selected.
This requries some Slate changes to how submenus are built to allow for sumbenus to specify whether they close after selection.
Also allowed columns to be hidden by default for specific use cases (like the sequence browser).
#jira UE-35818 - Anim asset browser column picker should stay up
Change 3141131 on 2016/09/27 by Thomas.Sarkanen
Fix CIS warnings
Fallout from preview world changes
Change 3141143 on 2016/09/27 by Jurre.deBaare
Fix for CIS errors
Change 3141235 on 2016/09/27 by Thomas.Sarkanen
Fix offset of Persona floor mesh when auto-alignment is enabled
When auto alignment was disabled, the offset wasnt getting taken into account.
#jira UE-35544 - In Persona, Floor Height Offset does nothing with Auto Align Floor to Mesh disabled
Change 3141327 on 2016/09/27 by Marc.Audy
Ensure that the client side AttachChildren array remains accurate
#jira UE-26025
Change 3141474 on 2016/09/27 by mason.seay
Updating test map name and moving PlayerStart
Change 3141501 on 2016/09/27 by Benn.Gallagher
Loading time improvements for destructibles from Nvidia
Updated to use new framework custom version instead of global object version
Fixed usage of TArray to enable correct loading and saving of the cached data.
#jira UE-29680
Change 3141889 on 2016/09/27 by Marc.Audy
Fix DestructibleMesh when WITH_APEX is 0
#jira UE-36484
Change 3142034 on 2016/09/27 by Marc.Audy
Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3141971
Change 3142131 on 2016/09/27 by Ori.Cohen
Make sure we return eTouch to physx during an overlap query. Fixes bad behavior when multiple objects blocked in an overlap query.
#JIRA UE-36381
Change 3142154 on 2016/09/27 by Ori.Cohen
Fix build, ModuleCachedData instead of NxApexModuleCachedData
Change 3142159 on 2016/09/27 by mason.seay
Blueprint for testing Child Actor Templates
Change 3142255 on 2016/09/27 by Jon.Nabozny
Fix crashes in QAMeshMerge component by making it a UObject, exposing it's method statically, and taking QASkeletalMeshMergeParams as an argument.
#jira UE-35199, UE-35197, UE-35201
Change 3142717 on 2016/09/27 by dan.reynolds
AEOverview Update + Sound Class Test
Change 3142764 on 2016/09/27 by Marc.Audy
Fix Ocean deprecation warnings
Change 3142962 on 2016/09/28 by Thomas.Sarkanen
Fixed bounds calculations for local camera animations
Correctly calculated bounds as local to the initial transform in the track.
Implemented suggested fixes from UDN user chhaddon (The Coalition).
#jira UE-29594 - CameraAnim bounds are incorrect when bRelativeToInitialTransform == true
Change 3143007 on 2016/09/28 by Martin.Wilson
Added virtual bones to USkeleton
API Breaking change:
-Added USkeleton pointer to RemoveBonesByName
-FReferenceSkeleton::UpdateRefPoseTransform & FReferenceSkeleton::Add made private. Must use FReferenceSkeletonModifier instead
#jira UEFW-81
Change 3143040 on 2016/09/28 by James.Golding
Strip DrawDebug.. functions from Shipping and Test builds, controlled by new define ENABLE_DRAW_DEBUG
Fix up game projects to compile in Shipping/Test after this change
PR #2757: (Contributed by projectgheist)
#jira UE-35488
Change 3143046 on 2016/09/28 by James.Golding
Fix OrionEnvironmentPerfTest.cpp compiling in Shipping (optimizations were not being re-enabled at end of file)
Change 3143047 on 2016/09/28 by James.Golding
PR #2731: Capsule primitive drawing fix (Contributed by kamrann)
#jira UE-35142
Change 3143050 on 2016/09/28 by Martin.Wilson
Update DDC key as some animation have stale data
Change 3143088 on 2016/09/28 by Martin.Wilson
CIS Fixes for Ocean after FReferenceSkeleton changes
Change 3143090 on 2016/09/28 by Benn.Gallagher
Fixed split pins in animation blueprints losing their pin links on editor restart. The anim nodes had opted out of the Super version of reconstruct, but that's where split pin restoration was added so we were skipping it.
#jira UE-36482
Change 3143091 on 2016/09/28 by Thomas.Sarkanen
Fix play/pause keyboard shortcut toggle in Persona based editors
Correctly handled widget mode switching in the skeleton selection edit mode (previously it was manually handling this rather than hooking into the correct level viewport callbacks).
Added the ability for FEdModes to specify whether they can use a widget mode.
Added a common set of commands that all Persona-based editors can opt into (only contains TogglePlay for now).
#jira UE-35163 - Cannot use Play/Pause shortcut in Persona if viewport is focused
Change 3143100 on 2016/09/28 by James.Golding
UE-32275 Fix Anim Curve entries losing Auto state when hidden/reshown
Change 3143107 on 2016/09/28 by Martin.Wilson
Add check to IsRunningParallelEvaluation to verify that the skeletal mesh component in question still references us
#jira UE-34431
Change 3143125 on 2016/09/28 by Jurre.deBaare
PR #2749: Fix blend space triangulation (Contributed by tmiv)
Change 3143225 on 2016/09/28 by Jurre.deBaare
Mesh/material merging basic test files
Change 3143235 on 2016/09/28 by Martin.Wilson
Fix issue where montage wrong section was updated with changes from details panel when clicking on a new section
#jira UE-35929
Change 3143312 on 2016/09/28 by Marc.Audy
Don't globally reregister components, globally recreate render state instead when force deleting assets
Fixes crash force deleting a blueprint with a child actor component in it from the content browser
Change 3143340 on 2016/09/28 by Mieszko.Zielinski
Improved consistency of loudness usage in AISense_Hearing #UE4
Change 3143359 on 2016/09/28 by Marc.Audy
Fix spelling error in comment
Change 3143372 on 2016/09/28 by Jurre.deBaare
HLOD meshes are causing degenerate triangles
#fix Setting flag to ignore degenerate triangles when building the meshes vertex/index buffers
#jira UE-34336
Change 3143420 on 2016/09/28 by Mieszko.Zielinski
Fix to BlackboardData initialization's dependency on parent asset's initialization #UE4
Change 3143421 on 2016/09/28 by Martin.Wilson
Allow reading on animation sequence length in blueprints
#jira UE-34168
Change 3143455 on 2016/09/28 by James.Golding
Add 'noop' versions of DrawDebug function, so you will not get compile errors by default for calling them in Shipping/Test builds.
Added optional SHIPPING_DRAW_DEBUG_ERROR define, which will give compile errors in Shipping/Test if still calling DrawDebug functions
Change 3143518 on 2016/09/28 by Jurre.deBaare
Meshes with no UV Coordinates will break the UVs of other meshes contained in the same HLOD if they share a material
#fix calculate UV bounds and check whether they occupy any space (if not do not use them for baking out the material)
#misc set texture sampling for HLOD proxy base material to clamp
#jira UE-35221
Change 3143542 on 2016/09/28 by James.Golding
Change SHIPPING_DRAW_DEBUG_ERROR define from ifdef to if
Fix comment
Enable by default for FN
Change 3143543 on 2016/09/28 by Benn.Gallagher
Changed branch + early return into an ensure during FPxQueryFilterCallback::preFilter. We were checking for invalid shapes in preFilter but that shouldn't happen. More likely to get some information as an ensure instead of earlying out on the funciton.
Change 3143556 on 2016/09/28 by Aaron.McLeran
UE-36540 Editor Preferences 'Enable Sound' option causes Real Time Audio to Stop Working after PIE
Change 3143566 on 2016/09/28 by Benn.Gallagher
Readded early out alongside new ensure for catching bad preFilter shapes
Change 3143568 on 2016/09/28 by Marc.Audy
Fix deprecation warnings in UT
Change 3143572 on 2016/09/28 by Jurre.deBaare
More test content for mesh/material merging
Change 3143581 on 2016/09/28 by Jurre.deBaare
More content :D
Change 3143585 on 2016/09/28 by Jurre.deBaare
Geometry cache cleaning
#misc fix for missing materials, not serialized (facepalm) as they were added later on (required custom version bump)
#misc cleaning out unecessary code
Change 3143594 on 2016/09/28 by Marc.Audy
Creating a child actor component by dragging an actor blueprint in to another blueprint now properly creates the template
#jira UE-36511
Change 3143658 on 2016/09/28 by Marc.Audy
RootComponent can be null by the time we hit PostUnregisterAllComponents so need to protect against the dereference
#jira UE-36553
Change 3143776 on 2016/09/28 by Marc.Audy
Properly reinstance child actor templates when using the fast reinstancing path
#jira UE-36516
Change 3143896 on 2016/09/28 by Ori.Cohen
Remove UPROPERTY on aggregate threshold which is always read from the physics settings.
Change 3144022 on 2016/09/28 by Ben.Zeigler
Move AIMoveTo node from BlueprintGraph to AIGraph and remove BlueprintGraph->AIModule dependency in build system
Change 3144252 on 2016/09/28 by mason.seay
More blueprints for child actor template testing
Change 3144262 on 2016/09/28 by Mason.Seay
Deleting assets
Change 3144283 on 2016/09/28 by dan.reynolds
AEOverview update + Sound Priority Test
Change 3144411 on 2016/09/28 by dan.reynolds
AEOverview end of day update and tweaks
Change 3144679 on 2016/09/29 by Benn.Gallagher
Changed skeletal bounds calculation to not consider clothing assets that aren't simulating in the current LOD. In this case we're not rendering the clothing, we're only rendering the skeletal geometry for that section in that LOD which isn't bound to cloth.
Change 3144856 on 2016/09/29 by Jurre.deBaare
HLOD Outliner scrolls back to the top when generating proxy meshes
#fix OnLevelActorsAdded was getting called for actors in the thumbnail worlds, which forced a refresh on the listview
#jira UE-30384
Change 3144864 on 2016/09/29 by Thomas.Sarkanen
Preview mesh fixes
Animation preview meshes are now respected (and saved). Mesh is displayed as empty if none is set (but a default is chosen).
Skeleton preview meshes are now shown as empty if none is set (but a default is chosen).
#jira UE-36582 - Cannot set preview mesh per-animation
Change 3144865 on 2016/09/29 by Jurre.deBaare
More test content
Change 3144885 on 2016/09/29 by James.Golding
UE-35307 Move 'invalid scale' warning to Message Log to be more visible in editor
Change scale clamping in UpdateBodyScale to catch cases like (1,0,1)
Change 3144903 on 2016/09/29 by Thomas.Sarkanen
Deprecating StaticMesh in UStaticMeshComponent
Added GetStaticMesh to access the value as read-only.
SetStaticMesh is now called in all locations that used to call "StaticMesh =".
Lots of fixups.
#jira UE-24859 - Deprecate public access to StaticMesh property in UStaticMeshComponent
Change 3145020 on 2016/09/29 by Thomas.Sarkanen
Fix bounds calculations that include bones to respect LOD (and other requried bones)
Sometimes bones would not be updated if we LOD switched, extending the bounds.
#jira UE-36525 - UDebugSkelMeshComponent::CalcBounds should filter by LOD
Change 3145041 on 2016/09/29 by Jurre.deBaare
Setting the Target Lightmap UV Channel to an incorrect value leads to inconsistent results
#fix removed target light map channel, we now determine according to the UV channels which are unused in the final mesh
#misc ignore the source lightmap uv channels to reduce data
#jira UE-36595
Change 3145219 on 2016/09/29 by Benn.Gallagher
Fixed clothing actors not casting shadows in editor, after the material editing change the copy of the shadow flag was missed from the clothing association code, which runs on again on older clothing assets to use the new render data skinning. Also added some fix up for assets that have be saved in the mean time.
#jira UE-36552
Change 3145222 on 2016/09/29 by Jurre.deBaare
Exporting Alembic Skeletal mesh from UE4 to FBX causes a crash
#fix on import set _all_ bone influence to 0
#jira UE-36602
Change 3145267 on 2016/09/29 by Ori.Cohen
Move OnConstraintBreak delegate so that it fires outside of fetchResults. Fixes crash from user doing unsafe things during fetchResults.
#JIRA UE-36483
Change 3145306 on 2016/09/29 by Jon.Nabozny
Fixed PhAT so multiple constraints can be selected and edited properly at the same time.
#JIRA: UE-31493
Change 3145342 on 2016/09/29 by Marc.Audy
Do not update cull distance volumes whenever any property changes
* Any movement or property change of a cull distance volume still does a global update
* Any movement of a component belong to any other Actor updates only the components of that Actor
* Any property change of a primitive component only updates that component
#jira UE-36399
Change 3145958 on 2016/09/29 by Marc.Audy
In game worlds don't auto activate components until the actor is ready to process them
#jira UE-35189
Change 3146110 on 2016/09/29 by dan.reynolds
AEOverview update + Soundwave Procedural Test Map
Change 3146375 on 2016/09/30 by Benn.Gallagher
Fixed crash saving newly created destructible mesh after material refactor.
#jira UE-36619
Change 3146378 on 2016/09/30 by James.Golding
UE-35908 Line trace against a BodyInstance now returns closest hit for trimesh (was any hit before)
Also add stat for FBodyInstance::LineTrace
Change 3146379 on 2016/09/30 by James.Golding
Add test assets for creating procmesh collision in non-editor builds
Change 3146386 on 2016/09/30 by Thomas.Sarkanen
Fixed ensures (and functionality) of 'show uncompressed animation' option in Persona viewports
Made sure that PreEvaluateAnimation is called for th einstance in use, rather than only the preview instance.
This unearthed another issuye where each of the calls to GenSpaceBAses was causing the animation to run faster. Fixed this by resetting the update flag in the update context after it is used.
#jira UE-36251 - Ensures showing uncompressed animations in anim blueprints
Change 3146464 on 2016/09/30 by Thomas.Sarkanen
Fix layered blend per bone odd/even connection counts alternately working/not working
Older hacky fix for multi-property to array copies flip-flipped between using fast path and not, when it really should have disabled fast path after the first array pin. Now it disables fast path based on whether this is a new handler or not, rather than looking at the SimpleCopyPropertyName.
#jira UE-35648 - Layered Blend Per Bone doesn't work correctly with 3+ inputs
Change 3146652 on 2016/09/30 by Benn.Gallagher
Fixed subinstance properties appearing in the caller's details panel as oddly named properties.
#jira UE-34141
Change 3146673 on 2016/09/30 by Martin.Wilson
Make RawAnimationData (and associated anim sequence data) private
#jira ue-25869
Change 3146680 on 2016/09/30 by Benn.Gallagher
Fixed errant asterisks in tooltips for source and target bone on rotation multiplier controller node
#jira UE-29847
Change 3146681 on 2016/09/30 by Benn.Gallagher
Fixed incorrect tooltip on left hand IK bone in hand ik retargetting node
#jira UE-30885
Change 3146711 on 2016/09/30 by Jon.Nabozny
Fix PhAT SnapConstraintToBone.
#jira UE-31491
Change 3146717 on 2016/09/30 by Danny.Bouimad
Adding Jurres really useful merge actor test assets to somewhere QA can get em.
Change 3146738 on 2016/09/30 by Martin.Wilson
Fix pose blending for on non-additive pose blending + remove normalising of weights for weights less than 1
#tests Editor tests with mambo pose asset
#jira UE-36189
Change 3146750 on 2016/09/30 by Jurre.deBaare
Material baking issue
#misc Removed the renderer initialization which causes issue the first time you would render out a material (gradient from top left to bottom right over the texture)
#misc Replaced incorrect masks with _way_ better approach thanks to Martin
Change 3146755 on 2016/09/30 by Jurre.deBaare
Need better progress bar for HLOD
#fix replaced the progress updates with new more 'correct' ones according to the actual workload and fixed up the Simplygon progress callback
#jira UE-34334
Change 3147085 on 2016/09/30 by Marc.Audy
PR #2815: GetNextViewablePlayer now checking and returning correct PlayerState. (Contributed by joshkay)
#jira UE-36632
Change 3147224 on 2016/09/30 by Martin.Wilson
CIS Fix
Change 3147280 on 2016/09/30 by Marc.Audy
Mouse smoothing should use application frame rate, not the dilated game frame rate
#jira UE-31040
Change 3147446 on 2016/09/30 by Aaron.McLeran
UE-36682 SoundCue Delay Not Consuming Input StartTime Correctly
Change 3147693 on 2016/09/30 by Ben.Zeigler
#jira UE-36657
If a player has an existing Pawn during RestartPlayer, use that pawn's rotation instead of the start spot, because we were already keeping the pawn's location
Change 3147697 on 2016/09/30 by Jon.Nabozny
Add rotation parameter to FBodyInstance::Sweep and FBodyInstance::InternalSweepPhysX
#jira UE-30486
Change 3147761 on 2016/09/30 by Jon.Nabozny
Fix AUTRepulsorBubble UPrimitiveComponent::SweepComponent usage.
Change 3148533 on 2016/10/03 by Thomas.Sarkanen
Fix new deprecation warnings introduced by the pull from main
Change 3148567 on 2016/10/03 by Marc.Audy
Fix crash when exiting PIE while a panoramic screenshot is being taken
Make stereo panorama tick with the world it is operating on
#jira UE-36492
Change 3148571 on 2016/10/03 by Marc.Audy
Allow modification of components that are EditAnywhere but don't exist in the CDO
#jira UE-36694
Change 3148607 on 2016/10/03 by Martin.Wilson
Properly end notify states when we clear the anim instance on a skeletal mesh.
#jira UE-32488
Change 3148711 on 2016/10/03 by Martin.Wilson
Fix type in virtual bone tooltip
#jira UE-36703
Change 3148746 on 2016/10/03 by Benn.Gallagher
Fixed a few cases where post process and sub instance anim calls weren't being made correctly.
#jira UE-36529
Change 3148807 on 2016/10/03 by Martin.Wilson
Fix mismatch skeleton error when undoing virtual bone changes
#jira UE-36705
Change 3148812 on 2016/10/03 by Martin.Wilson
Add undo support to removing virtual bones
#jira UE-36706
Change 3148975 on 2016/10/03 by Jurre.deBaare
Issue with combining meshes both with/without normal maps
#fix make sure we always output atleast the default normal value when baking out materials, this to ensure we output non-black values for meshes without normal maps (this would cause the normal to be incorrect)
#misc fixed issue in function to set texture rectangle to a single colour
#misc spotted comparison error
Change 3148976 on 2016/10/03 by Ori.Cohen
Make sure that shape queries that we pass into physx are never size 0. Fixes some NaNs
#JIRA UE-36639
Change 3148991 on 2016/10/03 by Jurre.deBaare
Changing LOD materials on Merged Actors Crashes Editor
#fix take into account LOD that is using the material when remapping (removing duplicate) materials
#jira UE-35883
Change 3148997 on 2016/10/03 by Jurre.deBaare
Make sure we remove matrix samples that fall outside of the import range and remap those that are in range
Change 3149002 on 2016/10/03 by Jurre.deBaare
Issues with importing Alembic caches using matrix transformations
#fix Apply conversion matrix to imported matrix samples to make them match the DCC package they were exported from
Change 3149030 on 2016/10/03 by Martin.Wilson
Dont show save warning on animations when we have curve data
#jira UE-34145
Change 3149115 on 2016/10/03 by Mieszko.Zielinski
Made PathfollowingComponent distinct between patrial and full paths in terms of acceptance radius used, when trying to determin if pathing agent is at goal location #UE4
#jira UE-35153
Change 3149186 on 2016/10/03 by Ben.Zeigler
#UE-36722 Fix failure to spawn when trying to spawn 4 capsules in the exact same location
There's no "Correct" direction to move out of a penetrating capsule, but old PhysX appeared to be consistent. New PhysX is not, so now we save and restore the adjustment instead of letting previous iterations modify it.
This code is weird but this solution is better than the old version and handles inconsistent results
Change 3149235 on 2016/10/03 by Martin.Wilson
Change inline curve name editing to only change the name of that specific curve, instead of renaming the smart name itself.
#jira UE-20005
Change 3149245 on 2016/10/03 by Marc.Audy
Remove duplicate entries from AttachChildren caused by lack of atomic cross-object updates.
Change 3149397 on 2016/10/03 by Ori.Cohen
Fix collision profile writing out response values to channels that don't exist.
#JIRA UE-36359
Change 3149679 on 2016/10/03 by Zak.Middleton
#ue4 - Don't mark CharacterMovementComponent::bUseControllerDesiredRotation as an advanced property. Consolidate rotation settings (RotationRate, bUseControllerDesiredRotation, bOrientRotationToMovement) in a new "Rotation Settings" category.
Change 3149929 on 2016/10/04 by Jurre.deBaare
Fix for CIS errors
#fix Mac didn't like undefined struct
Change 3149977 on 2016/10/04 by danny.bouimad
Massive update to Merge Actor test files
Change 3150014 on 2016/10/04 by James.Golding
UE-36686 Fix crash when slicing and not creating other section
Change 3150016 on 2016/10/04 by James.Golding
UE-35335 MergeActors now converts box collision to convex, so collision scales correctly after merging
Change 3150019 on 2016/10/04 by James.Golding
UE-36737 Fix LineTraceComponent not returning face index
Change 3150020 on 2016/10/04 by James.Golding
UE-36672 Export PhysicsContstraintComponent class so it can be subclassed outside Engine module
Change 3150027 on 2016/10/04 by Ben.Marsh
Add PhysX build option into Dev-Framework.
Change 3150042 on 2016/10/04 by Benn.Gallagher
Fixed clothing example 1.3 collision glitches
Change 3150172 on 2016/10/04 by Benn.Gallagher
Made Skeletal Mesh LOD reimports clear any existing simplification flag so we don't show "generated" next to LOD entries for them.
#jira UE-36589
Change 3150319 on 2016/10/04 by Ori.Cohen
Go back to only deferring body creation per component. This can now use the slow path when needed. Can't support deferring of multiple components without changing locking API so we'll do that in the future.
#JIRA UE-36535, UE-36504
Change 3150355 on 2016/10/04 by Zak.Middleton
#ue4 - Change checkSlow() to check() in GetDefaultObject<> because this is potentially an unsafe static cast.
Change 3150370 on 2016/10/04 by Ori.Cohen
Fix deferred actors not getting flushed.
Change 3150386 on 2016/10/04 by Martin.Wilson
Fix additive animation check failing in cooked builds when using virtual bones
#jira UE-36743
Change 3150424 on 2016/10/04 by Ori.Cohen
Exclude kinematic actors from active transforms generation.
Change 3150613 on 2016/10/04 by Zak.Middleton
#ue4 - Fix bad GetDefaultObject<> in AbilitySystemGlobals. Turned up since changing checkSlow() to check() in GetDefaultObject.
(Mirror CL 3138304 in Orion-DevGeneral)
#jira UE-36810
#tests compiled
Change 3150679 on 2016/10/04 by Ben.Zeigler
Crash fix with no async scene
Change 3150765 on 2016/10/04 by Ben.Zeigler
Deprecate UStructProperty::ExportTextItem_Static and ImportItem_Static, and add ExportText and ImportText directly to UScriptStruct
Add bAllowNativeOverride to specify rather to call the native override. For unclear reasons the static export skipped the native override while the static import included it
This allows calling the generic ImportText from inside a native ImportTextItem and then doing some post processing
Change 3150796 on 2016/10/04 by Marc.Audy
Fix LOCTEXT warnings related to blueprint class menu options
Change 3150806 on 2016/10/04 by Ben.Zeigler
Fix bad text format in import error message, lead to double error
Change 3150891 on 2016/10/04 by Ben.Zeigler
#jira UE-36170 Fix duplicate GUID spam when async loading levels during PIE by checking the package flag instead of the runtime global
Change 3150914 on 2016/10/04 by Marc.Audy
Don't try to recreate render state if it has already been recreated while the recreate context was active
#jira UE-36590
Change 3151195 on 2016/10/04 by Dan.Reynolds
Updates to QASoundWaveProcedural
QASoundWaveProcedural edited to be a GameplayStatic which spawns an Audio Component Handler as well as a Procedural Sound Wave. Support for envelope shaping (Attack, Sustain, Release) as well as multiple waveforms (Sine, Triangle, Sawtooth, Square). Blueprint API expanded to include separate functions for setting QASoundWaveProcedural settings and Playing.
Change 3151233 on 2016/10/04 by Ben.Zeigler
#jira UE-36836 Fix variable shadowing warnings
Change 3151328 on 2016/10/04 by dan.reynolds
AEOverview Update - Added Sound Wave Procedural test map and added support for mobile (tested on Android) menu selection - Still a WIP
Change 3151461 on 2016/10/05 by Thomas.Sarkanen
Fix localization warnings
#jira UE-36720 - //UE4/Main: Step 'Build Engine Localization' - 2 Warnings
Change 3151546 on 2016/10/05 by Martin.Wilson
Fix pose watch regression due to persona refactor changes.
#jira UE-36851
Change 3151587 on 2016/10/05 by Jurre.deBaare
Updating Simplygon to SDK version 8.0
#misc removed redundant files
#misc fixed landscape culling in merge actor path
#misc added support for volume culling using simplygon
#misc fixed when or not to use mesh data for material baking
#notes
Change: 3137650
Date: 23/09/2016 07:57
Client: Mustafa.Tungekar_Dev-Partner-Simplygon
User: Mustafa.Tungekar
Status: submitted
Type: restricted
ImportedBy:
Identity:
Description:
-Renamed commandline variables for ZipUtils AutomationScript
-Implemented Execute instead of ExecuteBuild
-Updated commandline arguments in SimplygonSwarm
JobStatus:
Jobs:
Files:
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Private/SimplygonSwarm.cpp#4
//UE4/Dev-Partner-Simplygon/Engine/Source/Programs/AutomationTool/Scripts/ZipUtils.Automation.cs#2
Change: 3137649
Date: 23/09/2016 07:56
Client: Mustafa.Tungekar_Dev-Partner-Simplygon
User: Mustafa.Tungekar
Status: submitted
Type: restricted
ImportedBy:
Identity:
Description:
Moved file hash computation to ImportObject
JobStatus:
Jobs:
Files:
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Classes/Factories/Factory.h#4
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Private/Factories/Factory.cpp#4
Change: 3137646
Date: 23/09/2016 07:55
Client: Mustafa.Tungekar_Dev-Partner-Simplygon
User: Mustafa.Tungekar
Status: submitted
Type: restricted
ImportedBy:
Identity:
Description:
Fixes CL3099204
EditorPerProjectUserSetting
Removed ConfigRestartRequired attribute from properties where it was not required
MeshUtilities
-Added FProxyFailedDelegate
-Extended IMeshMerging to include FProxyFailed delegate
-Added ProxyGenerationFailed method to FProxyGenerationProcessor class
-Setup FailedDelegate for both MeshMerging and DistributedMeshMerging
SimplygonMeshReduction
-Added check for invalid texture id
-Updated notes and removed commented code that is not required.
-Setup failed delegate
-Fixed issue where image data was never hooked into the texture.
-Fixed issue where texture table was never passed into casters
SimplygonSwarm
-Setup failed delegate
-Fixed RawMesh pointer usage.
-Move helper method into SimplygonSwarmHelpers.h.
-Added SimplygonSwarmHelpers
-Removed redundant constant path to 7-zip
-Removed GetSimplygonDirectory instead using inplace.
-Removed commented code that is currently not required.
-Fixed Typos
JobStatus:
Jobs:
Files:
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/MeshUtilities/Private/MeshUtilities.cpp#3
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/MeshUtilities/Public/MeshUtilities.h#3
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonMeshReduction/Private/SimplygonMeshReduction.cpp#4
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Private/SimplygonSwarm.cpp#3
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Public/SimplygonSwarmHelpers.h#1
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Classes/Editor/EditorPerProjectUserSettings.h#3
Change: 3099204
Date: 24/08/2016 07:56
Client: Mustafa.Tungekar_Dev-Partner-Simplygon
User: Mustafa.Tungekar
Status: submitted
Type: restricted
ImportedBy:
Identity:
Description:
Simplygon 8.0 Updates
Deprecated support for 7.0 and updated SimplygonSwarm and SimplygonMeshReduction to use 8.0
EditorPerProjectSettings
*SwarmMaxUploadChunkSizeInMB for limiting the max upload size for swarm. Note the Simplygon Grid has a limitation of 2GB
*SwarmNumOfConcurrentJobs for executing number of concurrent jobs
*Fixed issue where SG_MATERIAL_CHANNEL_METALLIC to SG_MATERIAL_CHANNEL_METALNESS (Chage in 8.0 SDK)
SPL, SimplygonSwarm, RESTClient
*Bumped up SPL Version to 8
*Fixed code paths to use ZipUtils UAT script for zipping and unzipping CL3094374
*Removed SPL Templates for version 7.0
*Added conditional logging to REST methods
*Added multi part upload. The RESTClient automatically decided if large files need to be split up before uploading to simplygon grid.
*Updated method to take in texturepath
SimplygonMeshReduction
*Removed minimum version requirement.
*Bumped up minimum version
*Chagned license file name to refelect 8.0 changes
*MaterialBaking related method now take in TextureTable as an extra parameter. This is due to 8.0 move away from old way of setting up materials and using SimplygonShadingNetowrk based appraoch.
JobStatus:
Jobs:
Files:
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonMeshReduction/Private/SimplygonMeshReduction.cpp#3
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonMeshReduction/Public/SimplygonTypes.h#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Private/SimplygonRESTClient.cpp#3
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Private/SimplygonSwarm.cpp#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Public/SimplygonRESTClient.h#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Public/SimplygonSwarmPrivatePCH.h#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Classes/Editor/EditorPerProjectUserSettings.h#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Private/Settings/EditorPerProjectUserSettings.cpp#2
Change: 3099200
Date: 24/08/2016 07:48
Client: Mustafa.Tungekar_Dev-Partner-Simplygon
User: Mustafa.Tungekar
Status: submitted
Type: restricted
ImportedBy:
Identity:
Description:
#fix Copy constructor for FMeshReduciton mapped ShadingImportance to SilhouetteImportance
JobStatus:
Jobs:
Files:
//UE4/Dev-Partner-Simplygon/Engine/Source/Runtime/Engine/Classes/Engine/MeshMerging.h#2
Change: 3099199
Date: 24/08/2016 07:47
Client: Mustafa.Tungekar_Dev-Partner-Simplygon
User: Mustafa.Tungekar
Status: submitted
Type: restricted
ImportedBy:
Identity:
Description:
Added Automation Script ZipUtils to zip file and unzip files from SimplygonSwarm.
This will remove any dependency on external zip program and should work across platforms
JobStatus:
Jobs:
Files:
//UE4/Dev-Partner-Simplygon/Engine/Source/Programs/AutomationTool/Scripts/AutomationScripts.Automation.csproj#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Programs/AutomationTool/Scripts/ZipUtils.Automation.cs#1
Change: 3099197
Date: 24/08/2016 07:40
Client: Mustafa.Tungekar_Dev-Partner-Simplygon
User: Mustafa.Tungekar
Status: submitted
Type: restricted
ImportedBy:
Identity:
Description:
*Speed improvements for FBX Scene Importer
*Added a static method to compute Hash.
JobStatus:
Jobs:
Files:
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Classes/Factories/Factory.h#3
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Private/Factories/Factory.cpp#3
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Private/Fbx/FbxStaticMeshImport.cpp#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Runtime/Engine/Classes/EditorFramework/AssetImportData.h#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Runtime/Engine/Private/EditorFramework/AssetImportData.cpp#2
Change 3151664 on 2016/10/05 by Richard.Hinckley
Fixing ACharacter template for "New C++ Class" feature. Avoiding naming a function parameter the same as an existing class member.
Change 3151729 on 2016/10/05 by Thomas.Sarkanen
Audit of remaining NaN checks
Some checks remain on in shipping (generally those called from blueprint):
- AActor::TeleportTo
- AActor::SetActorRelativeScale3D
#jira UE-30999 - Optimize ⌠ContainsNaN÷ and ⌠ContainsNaNOrInfinite÷, audit those still in shipping/test
Change 3151742 on 2016/10/05 by Ori.Cohen
Make sure that if physical animation component doesn't find a body and bone it doesn't crash.
#JIRA UE-36839
Change 3151756 on 2016/10/05 by Jurre.deBaare
Fixing d3dcompiler_47.dll missing issue
#fix added runtime dependency and dll name to build.cs file
#fix now load the d3dcompiler_47.dll from the Binaries/ThirdParty/Windows folder before loading the simplygon DLL
Change 3151761 on 2016/10/05 by Thomas.Sarkanen
Fix deprecation warning from last integration
Moved Preview to EditorPreview in FEditorWorldManager::OnWorldContextAdd.
#jira UE-36858 - Compile UE4Editor* completed with 1 warning
Change 3151782 on 2016/10/05 by Jurre.deBaare
Simplygon patch up
#misc linker errors popping up from JSONCPP
#misc incorporated emissive material property fix from other shelve
#misc static analysis fix
Change 3151804 on 2016/10/05 by Marc.Audy
Clear need end of frame update when unregistering a component
Change 3151928 on 2016/10/05 by Ori.Cohen
Fix runtime DLLs not including all delay loaded physx dll files.
#JIRA UE-36816
Change 3151977 on 2016/10/05 by Martin.Wilson
Notifies can no longer occupy the same time on the same track.
#jira UE-30658
Change 3151989 on 2016/10/05 by Jon.Nabozny
Fix ArchVis character rotation pitch when looking up/down.
#jira UE-35706
Change 3152083 on 2016/10/05 by Marc.Audy
Ensure that pending kill components get their marked for end of frame state cleared.
Change 3152086 on 2016/10/05 by Ben.Zeigler
#jira UE-36169 Fix it so missing linker errors that point to Blueprint CDOs are skipped, the same way it skips linker errors going to the actual class. Fixes a lot of spurious warnings from deleting components from blueprints or native classes
Clean up the VerifyImport error handling so it also displays in -game and cook, and fix the missing class warning to work properly, previously it would happen 0% in development 100% in debug even if the class was valid
Change 3152093 on 2016/10/05 by Marc.Audy
Change logic for when location cannot be changed for a static component to be independent of has begun play and have to do with whether construction script is running or the level is in the process of loading (mostly for backwards compatibility adjustments in post load).
#jira UE-36146
#jira UE-24647
Change 3152100 on 2016/10/05 by Ben.Zeigler
Remove pragma optmize
Change 3152112 on 2016/10/05 by Marc.Audy
Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3152072
Change 3152134 on 2016/10/05 by Jurre.deBaare
Simplygon/Merge actor issues
#fix for emissive output on meshes that do not have emissive properties
#fix for texture binning, not removing invalid split area causing overlapped textures
Change 3152136 on 2016/10/05 by James.Golding
UE-36859 Fix tooltip saying you can click to stop recording
Change 3152169 on 2016/10/05 by James.Golding
UE-31209 UE-30935 : Expose bDeformableMesh and bFastCook options in FTriMeshCollisionData
ProceduralMeshComponent will now cook using 'fast' and 'deformable' options, so updating collision on sections should work correctly
Change ERuntimePhysxCookOptimizationFlags to EPhysXMeshCookFlags and use that to pass options to CookConvex and CookTriMesh
Change 3152202 on 2016/10/05 by Jurre.deBaare
Mac/Linux fix
Change 3152303 on 2016/10/05 by Marc.Audy
Fix deprecation warning post merge from main
Change 3152320 on 2016/10/05 by Martin.Wilson
Fix root motion from everything calculating incorrect root motion when animations haven't been ticking
#jira UE-35364
Change 3152354 on 2016/10/05 by James.Golding
PoseDriver should pass through if no poses activated
Change 3152357 on 2016/10/05 by James.Golding
UE-36844 Remove unused OnAssetModifiedNotifier delegate from PoseAsset, ensure OnPoseListChanged is called when updating PoseAsset from anim.
Change 3152556 on 2016/10/05 by Marc.Audy
Remove autos
Change 3152560 on 2016/10/05 by Marc.Audy
Don't allow child actor references to be dragged from the outliner to a level script
#jira UE-16700
Change 3152568 on 2016/10/05 by Marc.Audy
Don't allow non-networking code to set bRemoteOwned in the actor spawn parameters
Remove deprecated bNoCollisionFail
#jira UE-35928
Change 3152575 on 2016/10/05 by Marc.Audy
Allow construction script to run post move for native classes. Actor can determine whether it should only occur on finish or every call to post edit move
Change 3153101 on 2016/10/06 by Thomas.Sarkanen
Fix crash re-opening the viewport in Persona-based editors
#jira UE-36775 - Editor crashes when re-opening viewport in Persona
Change 3153139 on 2016/10/06 by James.Golding
UE-36908 Remove GetRuntimeOnlyCookOptimizationFlags if cooking is not supported
Change 3153160 on 2016/10/06 by Thomas.Sarkanen
Fix for crash when deleting additive layer track
Code had not been updated to use the new delgate system (was still using reciprocal FPersona ptr).
#jira UE-36740 - Crash when removing or disabling an additive layer track in Persona
Change 3153175 on 2016/10/06 by Benn.Gallagher
Fixed crashes when using subinstances in non-default states. we previously initialized the anim instances in the node initialize, but in states that haven't been hit by an initialize this will happen off the game thread which is not allowed.
#jira UE-36900
Change 3153223 on 2016/10/06 by Thomas.Sarkanen
Fixed crash when opening an asset from the blend space editor
Code was still trying to open 'old' Persona when it was disabled.
Also fix other call sites where this was being done outside of asset type actions.
#jira UE-36766 - Crash attempting to open an asset from Aim Offset graph in Persona
Change 3153324 on 2016/10/06 by Thomas.Sarkanen
Prevented invalid GUIDs from being saved into smart name containers
AddOrFindName now checks to see if existing GUIDs are valid before using them.
AddName now requires a valid GUID to be passed in.
Also added Modify() call to the skeleton when FindOrAddSmartName is called from VerifySmartNameInternal, as without this the skeleton might not get saved.
Also add Laurent's fix for fixing up already-saved invalid GUIDs (CL 3138068).
#jira UE-36367 - It is possible for curves with an invalid GUID to be saved into the USkeleton asset
Change 3153348 on 2016/10/06 by Martin.Wilson
Re add ticking code so all Persona editors viewports tick during drag events (went missing in Persona refactor)
#jira UE-36751
Change 3153426 on 2016/10/06 by Mieszko.Zielinski
Added missing elements of block comments support in BT editor #UE4
Change 3153454 on 2016/10/06 by Benn.Gallagher
Fixed crash using anim debug with subinstances that are preceded by branching nodes.
#jira UE-36935
[CL 3153517 by Ori Cohen in Main branch]
2016-10-06 12:11:11 -04:00
# endif // ENABLE_DRAW_DEBUG
2018-02-22 11:25:06 -05:00
void FAnimNode_LegIK : : Initialize_AnyThread ( const FAnimationInitializeContext & Context )
{
2019-07-16 11:49:59 -04:00
DECLARE_SCOPE_HIERARCHICAL_COUNTER_ANIMNODE ( Initialize_AnyThread )
2018-02-22 11:25:06 -05:00
FAnimNode_SkeletalControlBase : : Initialize_AnyThread ( Context ) ;
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
2018-02-22 11:25:06 -05:00
MyAnimInstanceProxy = Context . AnimInstanceProxy ;
}
void FAnimLegIKData : : InitializeTransforms ( FAnimInstanceProxy * MyAnimInstanceProxy , FCSPose < FCompactPose > & MeshBases )
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
{
// Initialize bone transforms
IKFootTransform = MeshBases . GetComponentSpaceTransform ( IKFootBoneIndex ) ;
FKLegBoneTransforms . Reset ( NumBones ) ;
2018-05-23 21:04:31 -04:00
for ( const FCompactPoseBoneIndex & LegBoneIndex : FKLegBoneIndices )
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
{
FKLegBoneTransforms . Add ( MeshBases . GetComponentSpaceTransform ( LegBoneIndex ) ) ;
}
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3153514)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3050254 on 2016/07/14 by Marc.Audy
Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3049614
Change 3136629 on 2016/09/22 by Marc.Audy
bye bye auto
Change 3136631 on 2016/09/22 by Marc.Audy
Allow objects to be marked as duplicate transient or non PIE duplicate transient
ChildActors are not marked consistent with the property that references them as text export transient and non PIE duplicate transient
#jira UE-35680
Change 3136636 on 2016/09/22 by Marc.Audy
ParticleSystem and Audio Components now route Activate/Deactivate events to blueprints
Component Activate/Deactivate events now provide component as a property
#jira UE-35191
Change 3136640 on 2016/09/22 by Marc.Audy
Expose bReplicates to blueprint component properties
#jira UE-34433
Change 3136709 on 2016/09/22 by Ori.Cohen
Fix GetBodyInstance returning incorrect bodies when welded kinematics are attached.
#JIRA UE-36234
Change 3136710 on 2016/09/22 by Ori.Cohen
Fix defer actors not working when the physics scene is simulating. We now flush when the scene is not simulating, as well as a lazy flush that goes through the slow path when needed. This allows us to batch multiple components together.
#JIRA UE-35899
Change 3136770 on 2016/09/22 by Marc.Audy
Fix compile error
Change 3136854 on 2016/09/22 by Marc.Audy
Sprite components need to be text export transient
#jira UE-36064
Change 3136926 on 2016/09/22 by Ori.Cohen
Fix ensure when skeletal mesh bodies have no collision.
Change 3137054 on 2016/09/22 by Aaron.McLeran
PR #2628: Fix UAudioComponent SubtitlePriority not being initialised (Contributed by alanedwardes)
Change 3137058 on 2016/09/22 by Aaron.McLeran
PR #2562: ReadCompressedInfo calculates duration for ADPCM audio (Contributed by derekvanvliet)
Change 3137060 on 2016/09/22 by Aaron.McLeran
UE-36336 Fixing A3D for mono/2D sounds
- Making it so if A3D is being loaded but not enabled, we can not have reverb on 2D sounds
- Fixing A3D mono sources from failing after a time
Change 3137066 on 2016/09/22 by Aaron.McLeran
Checking in Ngs2.Build.cs with A3D and USING_A3D set to 0
Change 3137098 on 2016/09/22 by dan.reynolds
AEOverview Update: EQ Map, Reverb Map plus improvements on Main array cleanup process.
Change 3137132 on 2016/09/22 by Aaron.McLeran
PR #2789: Fixed signature of FActiveSound::GetIntParameter (Contributed by Laurie-Hedge)
Change 3137175 on 2016/09/22 by Aaron.McLeran
Fixing compile error with PhysXCollision.cpp from CL 3136710
Change 3137540 on 2016/09/23 by Thomas.Sarkanen
Fixed crash when generating LODs automatically for skeletal meshes
Quadric error reduction does not support skeletal meshes, so fails. Client code assumes that it cannot fail so crashed. This guards against immediatly assuming that LODs are valid after simplification.
#jira UE-36253 - Crash applying LOD changes in Persona
Change 3137720 on 2016/09/23 by Thomas.Sarkanen
Changed asset shortcut bar to display asset names & reworked padding
#jira UE-36347 - Anim asset shortcut bar has difficult to read/cut-off text
Change 3137761 on 2016/09/23 by Martin.Wilson
Fix typo in root motion from everything accumulation code
Change 3137877 on 2016/09/23 by Thomas.Sarkanen
Fixed undo/redo forcing skeletal meshes into t-pose
Re-populated AnimationData in InitAnim for UDebugSkelMeshComponent.
#jira UE-35579 - If you undo an animation change to any animation asset (for single preview), the playback controls will no longer function
Change 3137885 on 2016/09/23 by Benn.Gallagher
Fixed APEX clothing disappearing when time dilation results in a dt of 0. After simulating an actor with 0 APEX will fill positions and normals with NaNs, causing the disappearance. The fix in this case is to not schedule the evaluation task if we're not wanting to do any work. The simulation then freezes as we would expect.
#jira UE-35151
Change 3137888 on 2016/09/23 by Benn.Gallagher
Fixed transition nodes being able to be pasted or duplicated without 2 valid pin links
#jira UE-24860
Change 3137889 on 2016/09/23 by Benn.Gallagher
Fixed transform and widget inconsistencies in IK edit mode
#jira UE-20628
Change 3137890 on 2016/09/23 by Jurre.deBaare
Alembic Cached Geometry Does Not Display in Stand Alone Game
#fix required to force load the GeometryCache module during runtime
#jira UE-36187
Change 3137892 on 2016/09/23 by Jurre.deBaare
Geometry cache playback should work in sequencer
#fix add Interp UProperty tag to specific properties used for playing back the cache, future fix is having same approach as skeletal mesh animation for sequencer (depends on needs, -> skeletal mesh import has better compression anyway)
#jira UE-35447
Change 3137893 on 2016/09/23 by Jurre.deBaare
Alembic Cache Importer option for Hard Edge Angle Threshold does not work for objects with no normals
#fix adhere to the assumed 'standard' no normals in ABC file means completely smooth normals throughout the sequence
#jira UE-35091
Change 3137894 on 2016/09/23 by Jurre.deBaare
Importing an Alembic File While mesh Distance Fields are Enabled Crashes Editor
#fix Needed to save the raw mesh before building the mesh to ensure a LOD resource was created
#misc added a new check + message in case this occurs again
#jira UE-36059
Change 3137938 on 2016/09/23 by Jurre.deBaare
Alembic Importing with Incorrect UV's
#fix adding option for flipping UVs on import
#jira UE-36190
Alembic import axis not aligned correctly
#fix also added option to specify scale and rotation to be applied during import (with preset for Maya and Max)
#jira UE-35510
Change 3137949 on 2016/09/23 by Jurre.deBaare
Frame range importing causes confusion during Alembic importing
#fix this required storing information per Alembic object at which frame index it actual has stored frames, using this data we can determine which frames are empty, and at which frame there is data. This allows us to skip empty frames if we want to import data-only frames, or to import all frames in the sequence including empty (pre-roll) frames.
#misc changed settings UI listview layout (extra columns and resized old ones)
#jira UE-35498
Change 3137994 on 2016/09/23 by Martin.Wilson
Fix for creating an empty state when dragging a montage into a state machine graph
#jira UE-33371
Change 3138103 on 2016/09/23 by Aaron.McLeran
UE-36312 Fixing sound node distance cross fade for case of looping sounds
Change 3138104 on 2016/09/23 by Aaron.McLeran
UE-35392 Copy pasting local node into separate project crashes the engine
Change 3138224 on 2016/09/23 by Aaron.McLeran
UE-36312 Fixing sound node distance cross fade for case of looping sounds
- Adding a check for wave instance count to account for virtualized sounds (one-shots)
Change 3138666 on 2016/09/23 by Ben.Zeigler
#UEFW-204 Add more comprehensive gameplay tag tests
Fix issue with HasTag(Tag, IncludeParent, IncludeParent) revealed by tests, this was not returning true correctly in some cases. This use case is weird and will be deprecated soon
Change 3138779 on 2016/09/23 by Marc.Audy
Get rid of pointless casts
Change 3138782 on 2016/09/23 by Marc.Audy
remove some GWorlds
Change 3139701 on 2016/09/26 by Jurre.deBaare
Assert failed on GemetryCache for PS4 package
#fix add GeometryCache reference in engine build.cs and fix the serialization of geometry cache files
#jira UE-36392
Change 3139704 on 2016/09/26 by Jurre.deBaare
Fix for -1 begin frame
#fix do the max as an signed int, to make sure we don't wrap around
Change 3139748 on 2016/09/26 by Benn.Gallagher
PR #2784: Make sure that SceneScratchBufferSize is a multiple of 16K as requested by PhysX (Contributed by DenizPiri)
Moved the definition of the boundary to a FPhysScene class static
Changed comments on original user settings property to communicate the fact that the value is now rounded to the next 16K boundary
#jira UE-35736
Change 3139903 on 2016/09/26 by Benn.Gallagher
Fixed exposing subinstance pins stomping over class defaults and setting to uninitialized values
#jira UE-34366
Change 3140409 on 2016/09/26 by Lukasz.Furman
fixed uninitialized configs of gameplay debugger
copy of CL# 3140399
Change 3140516 on 2016/09/26 by dan.reynolds
AEOverview Map Update - Ambient Zone + Focus Test
Change 3140526 on 2016/09/26 by Jon.Nabozny
#rn Fixed CanJump inconsistencies with previous versions.
Deferred JumpCurrentCount increment until after jump, made bWasJumping a member variable, and updated how
jump count and hold time were compared in CanJump.
#jira UE-35524, UE-35582
Change 3140745 on 2016/09/26 by dan.reynolds
AEOverview Test Map Update + Occlusion Test
Change 3140839 on 2016/09/26 by dan.reynolds
AEOverview - minor updates
Change 3141101 on 2016/09/27 by Thomas.Sarkanen
Preview scene worlds now render correctly
Split "Preview" type into "EditorPreview" (the default) and "GamePreview". Deprecated the old "Preview" world type (but kept its index).
In-game hidden flags now apply to GamePreview, but not EditorPreview worlds.
Deprecated old bHack_Force_UsesGameHiddenFlags_True boolean. GamePReview now serves this purpose.
Fixed up UT cases where this was being used.
FPreviewScenes now use the editor mode by default, but can be set to non-editor if needed (as is the case with the still-experimental UViewport).
Custom depth pass is not enabled for EditorPreview (as before) but is for GamePreview.
Fixed erroneous use of TEnumAsByte for non-uproperty WorldType.
#jira UE-22883 - Using FPreviewScenes in-game for scene captures
Change 3141106 on 2016/09/27 by Thomas.Sarkanen
Column toggling improvements
Column toggle menu now does not close when items are selected.
This requries some Slate changes to how submenus are built to allow for sumbenus to specify whether they close after selection.
Also allowed columns to be hidden by default for specific use cases (like the sequence browser).
#jira UE-35818 - Anim asset browser column picker should stay up
Change 3141131 on 2016/09/27 by Thomas.Sarkanen
Fix CIS warnings
Fallout from preview world changes
Change 3141143 on 2016/09/27 by Jurre.deBaare
Fix for CIS errors
Change 3141235 on 2016/09/27 by Thomas.Sarkanen
Fix offset of Persona floor mesh when auto-alignment is enabled
When auto alignment was disabled, the offset wasnt getting taken into account.
#jira UE-35544 - In Persona, Floor Height Offset does nothing with Auto Align Floor to Mesh disabled
Change 3141327 on 2016/09/27 by Marc.Audy
Ensure that the client side AttachChildren array remains accurate
#jira UE-26025
Change 3141474 on 2016/09/27 by mason.seay
Updating test map name and moving PlayerStart
Change 3141501 on 2016/09/27 by Benn.Gallagher
Loading time improvements for destructibles from Nvidia
Updated to use new framework custom version instead of global object version
Fixed usage of TArray to enable correct loading and saving of the cached data.
#jira UE-29680
Change 3141889 on 2016/09/27 by Marc.Audy
Fix DestructibleMesh when WITH_APEX is 0
#jira UE-36484
Change 3142034 on 2016/09/27 by Marc.Audy
Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3141971
Change 3142131 on 2016/09/27 by Ori.Cohen
Make sure we return eTouch to physx during an overlap query. Fixes bad behavior when multiple objects blocked in an overlap query.
#JIRA UE-36381
Change 3142154 on 2016/09/27 by Ori.Cohen
Fix build, ModuleCachedData instead of NxApexModuleCachedData
Change 3142159 on 2016/09/27 by mason.seay
Blueprint for testing Child Actor Templates
Change 3142255 on 2016/09/27 by Jon.Nabozny
Fix crashes in QAMeshMerge component by making it a UObject, exposing it's method statically, and taking QASkeletalMeshMergeParams as an argument.
#jira UE-35199, UE-35197, UE-35201
Change 3142717 on 2016/09/27 by dan.reynolds
AEOverview Update + Sound Class Test
Change 3142764 on 2016/09/27 by Marc.Audy
Fix Ocean deprecation warnings
Change 3142962 on 2016/09/28 by Thomas.Sarkanen
Fixed bounds calculations for local camera animations
Correctly calculated bounds as local to the initial transform in the track.
Implemented suggested fixes from UDN user chhaddon (The Coalition).
#jira UE-29594 - CameraAnim bounds are incorrect when bRelativeToInitialTransform == true
Change 3143007 on 2016/09/28 by Martin.Wilson
Added virtual bones to USkeleton
API Breaking change:
-Added USkeleton pointer to RemoveBonesByName
-FReferenceSkeleton::UpdateRefPoseTransform & FReferenceSkeleton::Add made private. Must use FReferenceSkeletonModifier instead
#jira UEFW-81
Change 3143040 on 2016/09/28 by James.Golding
Strip DrawDebug.. functions from Shipping and Test builds, controlled by new define ENABLE_DRAW_DEBUG
Fix up game projects to compile in Shipping/Test after this change
PR #2757: (Contributed by projectgheist)
#jira UE-35488
Change 3143046 on 2016/09/28 by James.Golding
Fix OrionEnvironmentPerfTest.cpp compiling in Shipping (optimizations were not being re-enabled at end of file)
Change 3143047 on 2016/09/28 by James.Golding
PR #2731: Capsule primitive drawing fix (Contributed by kamrann)
#jira UE-35142
Change 3143050 on 2016/09/28 by Martin.Wilson
Update DDC key as some animation have stale data
Change 3143088 on 2016/09/28 by Martin.Wilson
CIS Fixes for Ocean after FReferenceSkeleton changes
Change 3143090 on 2016/09/28 by Benn.Gallagher
Fixed split pins in animation blueprints losing their pin links on editor restart. The anim nodes had opted out of the Super version of reconstruct, but that's where split pin restoration was added so we were skipping it.
#jira UE-36482
Change 3143091 on 2016/09/28 by Thomas.Sarkanen
Fix play/pause keyboard shortcut toggle in Persona based editors
Correctly handled widget mode switching in the skeleton selection edit mode (previously it was manually handling this rather than hooking into the correct level viewport callbacks).
Added the ability for FEdModes to specify whether they can use a widget mode.
Added a common set of commands that all Persona-based editors can opt into (only contains TogglePlay for now).
#jira UE-35163 - Cannot use Play/Pause shortcut in Persona if viewport is focused
Change 3143100 on 2016/09/28 by James.Golding
UE-32275 Fix Anim Curve entries losing Auto state when hidden/reshown
Change 3143107 on 2016/09/28 by Martin.Wilson
Add check to IsRunningParallelEvaluation to verify that the skeletal mesh component in question still references us
#jira UE-34431
Change 3143125 on 2016/09/28 by Jurre.deBaare
PR #2749: Fix blend space triangulation (Contributed by tmiv)
Change 3143225 on 2016/09/28 by Jurre.deBaare
Mesh/material merging basic test files
Change 3143235 on 2016/09/28 by Martin.Wilson
Fix issue where montage wrong section was updated with changes from details panel when clicking on a new section
#jira UE-35929
Change 3143312 on 2016/09/28 by Marc.Audy
Don't globally reregister components, globally recreate render state instead when force deleting assets
Fixes crash force deleting a blueprint with a child actor component in it from the content browser
Change 3143340 on 2016/09/28 by Mieszko.Zielinski
Improved consistency of loudness usage in AISense_Hearing #UE4
Change 3143359 on 2016/09/28 by Marc.Audy
Fix spelling error in comment
Change 3143372 on 2016/09/28 by Jurre.deBaare
HLOD meshes are causing degenerate triangles
#fix Setting flag to ignore degenerate triangles when building the meshes vertex/index buffers
#jira UE-34336
Change 3143420 on 2016/09/28 by Mieszko.Zielinski
Fix to BlackboardData initialization's dependency on parent asset's initialization #UE4
Change 3143421 on 2016/09/28 by Martin.Wilson
Allow reading on animation sequence length in blueprints
#jira UE-34168
Change 3143455 on 2016/09/28 by James.Golding
Add 'noop' versions of DrawDebug function, so you will not get compile errors by default for calling them in Shipping/Test builds.
Added optional SHIPPING_DRAW_DEBUG_ERROR define, which will give compile errors in Shipping/Test if still calling DrawDebug functions
Change 3143518 on 2016/09/28 by Jurre.deBaare
Meshes with no UV Coordinates will break the UVs of other meshes contained in the same HLOD if they share a material
#fix calculate UV bounds and check whether they occupy any space (if not do not use them for baking out the material)
#misc set texture sampling for HLOD proxy base material to clamp
#jira UE-35221
Change 3143542 on 2016/09/28 by James.Golding
Change SHIPPING_DRAW_DEBUG_ERROR define from ifdef to if
Fix comment
Enable by default for FN
Change 3143543 on 2016/09/28 by Benn.Gallagher
Changed branch + early return into an ensure during FPxQueryFilterCallback::preFilter. We were checking for invalid shapes in preFilter but that shouldn't happen. More likely to get some information as an ensure instead of earlying out on the funciton.
Change 3143556 on 2016/09/28 by Aaron.McLeran
UE-36540 Editor Preferences 'Enable Sound' option causes Real Time Audio to Stop Working after PIE
Change 3143566 on 2016/09/28 by Benn.Gallagher
Readded early out alongside new ensure for catching bad preFilter shapes
Change 3143568 on 2016/09/28 by Marc.Audy
Fix deprecation warnings in UT
Change 3143572 on 2016/09/28 by Jurre.deBaare
More test content for mesh/material merging
Change 3143581 on 2016/09/28 by Jurre.deBaare
More content :D
Change 3143585 on 2016/09/28 by Jurre.deBaare
Geometry cache cleaning
#misc fix for missing materials, not serialized (facepalm) as they were added later on (required custom version bump)
#misc cleaning out unecessary code
Change 3143594 on 2016/09/28 by Marc.Audy
Creating a child actor component by dragging an actor blueprint in to another blueprint now properly creates the template
#jira UE-36511
Change 3143658 on 2016/09/28 by Marc.Audy
RootComponent can be null by the time we hit PostUnregisterAllComponents so need to protect against the dereference
#jira UE-36553
Change 3143776 on 2016/09/28 by Marc.Audy
Properly reinstance child actor templates when using the fast reinstancing path
#jira UE-36516
Change 3143896 on 2016/09/28 by Ori.Cohen
Remove UPROPERTY on aggregate threshold which is always read from the physics settings.
Change 3144022 on 2016/09/28 by Ben.Zeigler
Move AIMoveTo node from BlueprintGraph to AIGraph and remove BlueprintGraph->AIModule dependency in build system
Change 3144252 on 2016/09/28 by mason.seay
More blueprints for child actor template testing
Change 3144262 on 2016/09/28 by Mason.Seay
Deleting assets
Change 3144283 on 2016/09/28 by dan.reynolds
AEOverview update + Sound Priority Test
Change 3144411 on 2016/09/28 by dan.reynolds
AEOverview end of day update and tweaks
Change 3144679 on 2016/09/29 by Benn.Gallagher
Changed skeletal bounds calculation to not consider clothing assets that aren't simulating in the current LOD. In this case we're not rendering the clothing, we're only rendering the skeletal geometry for that section in that LOD which isn't bound to cloth.
Change 3144856 on 2016/09/29 by Jurre.deBaare
HLOD Outliner scrolls back to the top when generating proxy meshes
#fix OnLevelActorsAdded was getting called for actors in the thumbnail worlds, which forced a refresh on the listview
#jira UE-30384
Change 3144864 on 2016/09/29 by Thomas.Sarkanen
Preview mesh fixes
Animation preview meshes are now respected (and saved). Mesh is displayed as empty if none is set (but a default is chosen).
Skeleton preview meshes are now shown as empty if none is set (but a default is chosen).
#jira UE-36582 - Cannot set preview mesh per-animation
Change 3144865 on 2016/09/29 by Jurre.deBaare
More test content
Change 3144885 on 2016/09/29 by James.Golding
UE-35307 Move 'invalid scale' warning to Message Log to be more visible in editor
Change scale clamping in UpdateBodyScale to catch cases like (1,0,1)
Change 3144903 on 2016/09/29 by Thomas.Sarkanen
Deprecating StaticMesh in UStaticMeshComponent
Added GetStaticMesh to access the value as read-only.
SetStaticMesh is now called in all locations that used to call "StaticMesh =".
Lots of fixups.
#jira UE-24859 - Deprecate public access to StaticMesh property in UStaticMeshComponent
Change 3145020 on 2016/09/29 by Thomas.Sarkanen
Fix bounds calculations that include bones to respect LOD (and other requried bones)
Sometimes bones would not be updated if we LOD switched, extending the bounds.
#jira UE-36525 - UDebugSkelMeshComponent::CalcBounds should filter by LOD
Change 3145041 on 2016/09/29 by Jurre.deBaare
Setting the Target Lightmap UV Channel to an incorrect value leads to inconsistent results
#fix removed target light map channel, we now determine according to the UV channels which are unused in the final mesh
#misc ignore the source lightmap uv channels to reduce data
#jira UE-36595
Change 3145219 on 2016/09/29 by Benn.Gallagher
Fixed clothing actors not casting shadows in editor, after the material editing change the copy of the shadow flag was missed from the clothing association code, which runs on again on older clothing assets to use the new render data skinning. Also added some fix up for assets that have be saved in the mean time.
#jira UE-36552
Change 3145222 on 2016/09/29 by Jurre.deBaare
Exporting Alembic Skeletal mesh from UE4 to FBX causes a crash
#fix on import set _all_ bone influence to 0
#jira UE-36602
Change 3145267 on 2016/09/29 by Ori.Cohen
Move OnConstraintBreak delegate so that it fires outside of fetchResults. Fixes crash from user doing unsafe things during fetchResults.
#JIRA UE-36483
Change 3145306 on 2016/09/29 by Jon.Nabozny
Fixed PhAT so multiple constraints can be selected and edited properly at the same time.
#JIRA: UE-31493
Change 3145342 on 2016/09/29 by Marc.Audy
Do not update cull distance volumes whenever any property changes
* Any movement or property change of a cull distance volume still does a global update
* Any movement of a component belong to any other Actor updates only the components of that Actor
* Any property change of a primitive component only updates that component
#jira UE-36399
Change 3145958 on 2016/09/29 by Marc.Audy
In game worlds don't auto activate components until the actor is ready to process them
#jira UE-35189
Change 3146110 on 2016/09/29 by dan.reynolds
AEOverview update + Soundwave Procedural Test Map
Change 3146375 on 2016/09/30 by Benn.Gallagher
Fixed crash saving newly created destructible mesh after material refactor.
#jira UE-36619
Change 3146378 on 2016/09/30 by James.Golding
UE-35908 Line trace against a BodyInstance now returns closest hit for trimesh (was any hit before)
Also add stat for FBodyInstance::LineTrace
Change 3146379 on 2016/09/30 by James.Golding
Add test assets for creating procmesh collision in non-editor builds
Change 3146386 on 2016/09/30 by Thomas.Sarkanen
Fixed ensures (and functionality) of 'show uncompressed animation' option in Persona viewports
Made sure that PreEvaluateAnimation is called for th einstance in use, rather than only the preview instance.
This unearthed another issuye where each of the calls to GenSpaceBAses was causing the animation to run faster. Fixed this by resetting the update flag in the update context after it is used.
#jira UE-36251 - Ensures showing uncompressed animations in anim blueprints
Change 3146464 on 2016/09/30 by Thomas.Sarkanen
Fix layered blend per bone odd/even connection counts alternately working/not working
Older hacky fix for multi-property to array copies flip-flipped between using fast path and not, when it really should have disabled fast path after the first array pin. Now it disables fast path based on whether this is a new handler or not, rather than looking at the SimpleCopyPropertyName.
#jira UE-35648 - Layered Blend Per Bone doesn't work correctly with 3+ inputs
Change 3146652 on 2016/09/30 by Benn.Gallagher
Fixed subinstance properties appearing in the caller's details panel as oddly named properties.
#jira UE-34141
Change 3146673 on 2016/09/30 by Martin.Wilson
Make RawAnimationData (and associated anim sequence data) private
#jira ue-25869
Change 3146680 on 2016/09/30 by Benn.Gallagher
Fixed errant asterisks in tooltips for source and target bone on rotation multiplier controller node
#jira UE-29847
Change 3146681 on 2016/09/30 by Benn.Gallagher
Fixed incorrect tooltip on left hand IK bone in hand ik retargetting node
#jira UE-30885
Change 3146711 on 2016/09/30 by Jon.Nabozny
Fix PhAT SnapConstraintToBone.
#jira UE-31491
Change 3146717 on 2016/09/30 by Danny.Bouimad
Adding Jurres really useful merge actor test assets to somewhere QA can get em.
Change 3146738 on 2016/09/30 by Martin.Wilson
Fix pose blending for on non-additive pose blending + remove normalising of weights for weights less than 1
#tests Editor tests with mambo pose asset
#jira UE-36189
Change 3146750 on 2016/09/30 by Jurre.deBaare
Material baking issue
#misc Removed the renderer initialization which causes issue the first time you would render out a material (gradient from top left to bottom right over the texture)
#misc Replaced incorrect masks with _way_ better approach thanks to Martin
Change 3146755 on 2016/09/30 by Jurre.deBaare
Need better progress bar for HLOD
#fix replaced the progress updates with new more 'correct' ones according to the actual workload and fixed up the Simplygon progress callback
#jira UE-34334
Change 3147085 on 2016/09/30 by Marc.Audy
PR #2815: GetNextViewablePlayer now checking and returning correct PlayerState. (Contributed by joshkay)
#jira UE-36632
Change 3147224 on 2016/09/30 by Martin.Wilson
CIS Fix
Change 3147280 on 2016/09/30 by Marc.Audy
Mouse smoothing should use application frame rate, not the dilated game frame rate
#jira UE-31040
Change 3147446 on 2016/09/30 by Aaron.McLeran
UE-36682 SoundCue Delay Not Consuming Input StartTime Correctly
Change 3147693 on 2016/09/30 by Ben.Zeigler
#jira UE-36657
If a player has an existing Pawn during RestartPlayer, use that pawn's rotation instead of the start spot, because we were already keeping the pawn's location
Change 3147697 on 2016/09/30 by Jon.Nabozny
Add rotation parameter to FBodyInstance::Sweep and FBodyInstance::InternalSweepPhysX
#jira UE-30486
Change 3147761 on 2016/09/30 by Jon.Nabozny
Fix AUTRepulsorBubble UPrimitiveComponent::SweepComponent usage.
Change 3148533 on 2016/10/03 by Thomas.Sarkanen
Fix new deprecation warnings introduced by the pull from main
Change 3148567 on 2016/10/03 by Marc.Audy
Fix crash when exiting PIE while a panoramic screenshot is being taken
Make stereo panorama tick with the world it is operating on
#jira UE-36492
Change 3148571 on 2016/10/03 by Marc.Audy
Allow modification of components that are EditAnywhere but don't exist in the CDO
#jira UE-36694
Change 3148607 on 2016/10/03 by Martin.Wilson
Properly end notify states when we clear the anim instance on a skeletal mesh.
#jira UE-32488
Change 3148711 on 2016/10/03 by Martin.Wilson
Fix type in virtual bone tooltip
#jira UE-36703
Change 3148746 on 2016/10/03 by Benn.Gallagher
Fixed a few cases where post process and sub instance anim calls weren't being made correctly.
#jira UE-36529
Change 3148807 on 2016/10/03 by Martin.Wilson
Fix mismatch skeleton error when undoing virtual bone changes
#jira UE-36705
Change 3148812 on 2016/10/03 by Martin.Wilson
Add undo support to removing virtual bones
#jira UE-36706
Change 3148975 on 2016/10/03 by Jurre.deBaare
Issue with combining meshes both with/without normal maps
#fix make sure we always output atleast the default normal value when baking out materials, this to ensure we output non-black values for meshes without normal maps (this would cause the normal to be incorrect)
#misc fixed issue in function to set texture rectangle to a single colour
#misc spotted comparison error
Change 3148976 on 2016/10/03 by Ori.Cohen
Make sure that shape queries that we pass into physx are never size 0. Fixes some NaNs
#JIRA UE-36639
Change 3148991 on 2016/10/03 by Jurre.deBaare
Changing LOD materials on Merged Actors Crashes Editor
#fix take into account LOD that is using the material when remapping (removing duplicate) materials
#jira UE-35883
Change 3148997 on 2016/10/03 by Jurre.deBaare
Make sure we remove matrix samples that fall outside of the import range and remap those that are in range
Change 3149002 on 2016/10/03 by Jurre.deBaare
Issues with importing Alembic caches using matrix transformations
#fix Apply conversion matrix to imported matrix samples to make them match the DCC package they were exported from
Change 3149030 on 2016/10/03 by Martin.Wilson
Dont show save warning on animations when we have curve data
#jira UE-34145
Change 3149115 on 2016/10/03 by Mieszko.Zielinski
Made PathfollowingComponent distinct between patrial and full paths in terms of acceptance radius used, when trying to determin if pathing agent is at goal location #UE4
#jira UE-35153
Change 3149186 on 2016/10/03 by Ben.Zeigler
#UE-36722 Fix failure to spawn when trying to spawn 4 capsules in the exact same location
There's no "Correct" direction to move out of a penetrating capsule, but old PhysX appeared to be consistent. New PhysX is not, so now we save and restore the adjustment instead of letting previous iterations modify it.
This code is weird but this solution is better than the old version and handles inconsistent results
Change 3149235 on 2016/10/03 by Martin.Wilson
Change inline curve name editing to only change the name of that specific curve, instead of renaming the smart name itself.
#jira UE-20005
Change 3149245 on 2016/10/03 by Marc.Audy
Remove duplicate entries from AttachChildren caused by lack of atomic cross-object updates.
Change 3149397 on 2016/10/03 by Ori.Cohen
Fix collision profile writing out response values to channels that don't exist.
#JIRA UE-36359
Change 3149679 on 2016/10/03 by Zak.Middleton
#ue4 - Don't mark CharacterMovementComponent::bUseControllerDesiredRotation as an advanced property. Consolidate rotation settings (RotationRate, bUseControllerDesiredRotation, bOrientRotationToMovement) in a new "Rotation Settings" category.
Change 3149929 on 2016/10/04 by Jurre.deBaare
Fix for CIS errors
#fix Mac didn't like undefined struct
Change 3149977 on 2016/10/04 by danny.bouimad
Massive update to Merge Actor test files
Change 3150014 on 2016/10/04 by James.Golding
UE-36686 Fix crash when slicing and not creating other section
Change 3150016 on 2016/10/04 by James.Golding
UE-35335 MergeActors now converts box collision to convex, so collision scales correctly after merging
Change 3150019 on 2016/10/04 by James.Golding
UE-36737 Fix LineTraceComponent not returning face index
Change 3150020 on 2016/10/04 by James.Golding
UE-36672 Export PhysicsContstraintComponent class so it can be subclassed outside Engine module
Change 3150027 on 2016/10/04 by Ben.Marsh
Add PhysX build option into Dev-Framework.
Change 3150042 on 2016/10/04 by Benn.Gallagher
Fixed clothing example 1.3 collision glitches
Change 3150172 on 2016/10/04 by Benn.Gallagher
Made Skeletal Mesh LOD reimports clear any existing simplification flag so we don't show "generated" next to LOD entries for them.
#jira UE-36589
Change 3150319 on 2016/10/04 by Ori.Cohen
Go back to only deferring body creation per component. This can now use the slow path when needed. Can't support deferring of multiple components without changing locking API so we'll do that in the future.
#JIRA UE-36535, UE-36504
Change 3150355 on 2016/10/04 by Zak.Middleton
#ue4 - Change checkSlow() to check() in GetDefaultObject<> because this is potentially an unsafe static cast.
Change 3150370 on 2016/10/04 by Ori.Cohen
Fix deferred actors not getting flushed.
Change 3150386 on 2016/10/04 by Martin.Wilson
Fix additive animation check failing in cooked builds when using virtual bones
#jira UE-36743
Change 3150424 on 2016/10/04 by Ori.Cohen
Exclude kinematic actors from active transforms generation.
Change 3150613 on 2016/10/04 by Zak.Middleton
#ue4 - Fix bad GetDefaultObject<> in AbilitySystemGlobals. Turned up since changing checkSlow() to check() in GetDefaultObject.
(Mirror CL 3138304 in Orion-DevGeneral)
#jira UE-36810
#tests compiled
Change 3150679 on 2016/10/04 by Ben.Zeigler
Crash fix with no async scene
Change 3150765 on 2016/10/04 by Ben.Zeigler
Deprecate UStructProperty::ExportTextItem_Static and ImportItem_Static, and add ExportText and ImportText directly to UScriptStruct
Add bAllowNativeOverride to specify rather to call the native override. For unclear reasons the static export skipped the native override while the static import included it
This allows calling the generic ImportText from inside a native ImportTextItem and then doing some post processing
Change 3150796 on 2016/10/04 by Marc.Audy
Fix LOCTEXT warnings related to blueprint class menu options
Change 3150806 on 2016/10/04 by Ben.Zeigler
Fix bad text format in import error message, lead to double error
Change 3150891 on 2016/10/04 by Ben.Zeigler
#jira UE-36170 Fix duplicate GUID spam when async loading levels during PIE by checking the package flag instead of the runtime global
Change 3150914 on 2016/10/04 by Marc.Audy
Don't try to recreate render state if it has already been recreated while the recreate context was active
#jira UE-36590
Change 3151195 on 2016/10/04 by Dan.Reynolds
Updates to QASoundWaveProcedural
QASoundWaveProcedural edited to be a GameplayStatic which spawns an Audio Component Handler as well as a Procedural Sound Wave. Support for envelope shaping (Attack, Sustain, Release) as well as multiple waveforms (Sine, Triangle, Sawtooth, Square). Blueprint API expanded to include separate functions for setting QASoundWaveProcedural settings and Playing.
Change 3151233 on 2016/10/04 by Ben.Zeigler
#jira UE-36836 Fix variable shadowing warnings
Change 3151328 on 2016/10/04 by dan.reynolds
AEOverview Update - Added Sound Wave Procedural test map and added support for mobile (tested on Android) menu selection - Still a WIP
Change 3151461 on 2016/10/05 by Thomas.Sarkanen
Fix localization warnings
#jira UE-36720 - //UE4/Main: Step 'Build Engine Localization' - 2 Warnings
Change 3151546 on 2016/10/05 by Martin.Wilson
Fix pose watch regression due to persona refactor changes.
#jira UE-36851
Change 3151587 on 2016/10/05 by Jurre.deBaare
Updating Simplygon to SDK version 8.0
#misc removed redundant files
#misc fixed landscape culling in merge actor path
#misc added support for volume culling using simplygon
#misc fixed when or not to use mesh data for material baking
#notes
Change: 3137650
Date: 23/09/2016 07:57
Client: Mustafa.Tungekar_Dev-Partner-Simplygon
User: Mustafa.Tungekar
Status: submitted
Type: restricted
ImportedBy:
Identity:
Description:
-Renamed commandline variables for ZipUtils AutomationScript
-Implemented Execute instead of ExecuteBuild
-Updated commandline arguments in SimplygonSwarm
JobStatus:
Jobs:
Files:
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Private/SimplygonSwarm.cpp#4
//UE4/Dev-Partner-Simplygon/Engine/Source/Programs/AutomationTool/Scripts/ZipUtils.Automation.cs#2
Change: 3137649
Date: 23/09/2016 07:56
Client: Mustafa.Tungekar_Dev-Partner-Simplygon
User: Mustafa.Tungekar
Status: submitted
Type: restricted
ImportedBy:
Identity:
Description:
Moved file hash computation to ImportObject
JobStatus:
Jobs:
Files:
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Classes/Factories/Factory.h#4
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Private/Factories/Factory.cpp#4
Change: 3137646
Date: 23/09/2016 07:55
Client: Mustafa.Tungekar_Dev-Partner-Simplygon
User: Mustafa.Tungekar
Status: submitted
Type: restricted
ImportedBy:
Identity:
Description:
Fixes CL3099204
EditorPerProjectUserSetting
Removed ConfigRestartRequired attribute from properties where it was not required
MeshUtilities
-Added FProxyFailedDelegate
-Extended IMeshMerging to include FProxyFailed delegate
-Added ProxyGenerationFailed method to FProxyGenerationProcessor class
-Setup FailedDelegate for both MeshMerging and DistributedMeshMerging
SimplygonMeshReduction
-Added check for invalid texture id
-Updated notes and removed commented code that is not required.
-Setup failed delegate
-Fixed issue where image data was never hooked into the texture.
-Fixed issue where texture table was never passed into casters
SimplygonSwarm
-Setup failed delegate
-Fixed RawMesh pointer usage.
-Move helper method into SimplygonSwarmHelpers.h.
-Added SimplygonSwarmHelpers
-Removed redundant constant path to 7-zip
-Removed GetSimplygonDirectory instead using inplace.
-Removed commented code that is currently not required.
-Fixed Typos
JobStatus:
Jobs:
Files:
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/MeshUtilities/Private/MeshUtilities.cpp#3
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/MeshUtilities/Public/MeshUtilities.h#3
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonMeshReduction/Private/SimplygonMeshReduction.cpp#4
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Private/SimplygonSwarm.cpp#3
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Public/SimplygonSwarmHelpers.h#1
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Classes/Editor/EditorPerProjectUserSettings.h#3
Change: 3099204
Date: 24/08/2016 07:56
Client: Mustafa.Tungekar_Dev-Partner-Simplygon
User: Mustafa.Tungekar
Status: submitted
Type: restricted
ImportedBy:
Identity:
Description:
Simplygon 8.0 Updates
Deprecated support for 7.0 and updated SimplygonSwarm and SimplygonMeshReduction to use 8.0
EditorPerProjectSettings
*SwarmMaxUploadChunkSizeInMB for limiting the max upload size for swarm. Note the Simplygon Grid has a limitation of 2GB
*SwarmNumOfConcurrentJobs for executing number of concurrent jobs
*Fixed issue where SG_MATERIAL_CHANNEL_METALLIC to SG_MATERIAL_CHANNEL_METALNESS (Chage in 8.0 SDK)
SPL, SimplygonSwarm, RESTClient
*Bumped up SPL Version to 8
*Fixed code paths to use ZipUtils UAT script for zipping and unzipping CL3094374
*Removed SPL Templates for version 7.0
*Added conditional logging to REST methods
*Added multi part upload. The RESTClient automatically decided if large files need to be split up before uploading to simplygon grid.
*Updated method to take in texturepath
SimplygonMeshReduction
*Removed minimum version requirement.
*Bumped up minimum version
*Chagned license file name to refelect 8.0 changes
*MaterialBaking related method now take in TextureTable as an extra parameter. This is due to 8.0 move away from old way of setting up materials and using SimplygonShadingNetowrk based appraoch.
JobStatus:
Jobs:
Files:
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonMeshReduction/Private/SimplygonMeshReduction.cpp#3
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonMeshReduction/Public/SimplygonTypes.h#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Private/SimplygonRESTClient.cpp#3
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Private/SimplygonSwarm.cpp#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Public/SimplygonRESTClient.h#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Public/SimplygonSwarmPrivatePCH.h#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Classes/Editor/EditorPerProjectUserSettings.h#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Private/Settings/EditorPerProjectUserSettings.cpp#2
Change: 3099200
Date: 24/08/2016 07:48
Client: Mustafa.Tungekar_Dev-Partner-Simplygon
User: Mustafa.Tungekar
Status: submitted
Type: restricted
ImportedBy:
Identity:
Description:
#fix Copy constructor for FMeshReduciton mapped ShadingImportance to SilhouetteImportance
JobStatus:
Jobs:
Files:
//UE4/Dev-Partner-Simplygon/Engine/Source/Runtime/Engine/Classes/Engine/MeshMerging.h#2
Change: 3099199
Date: 24/08/2016 07:47
Client: Mustafa.Tungekar_Dev-Partner-Simplygon
User: Mustafa.Tungekar
Status: submitted
Type: restricted
ImportedBy:
Identity:
Description:
Added Automation Script ZipUtils to zip file and unzip files from SimplygonSwarm.
This will remove any dependency on external zip program and should work across platforms
JobStatus:
Jobs:
Files:
//UE4/Dev-Partner-Simplygon/Engine/Source/Programs/AutomationTool/Scripts/AutomationScripts.Automation.csproj#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Programs/AutomationTool/Scripts/ZipUtils.Automation.cs#1
Change: 3099197
Date: 24/08/2016 07:40
Client: Mustafa.Tungekar_Dev-Partner-Simplygon
User: Mustafa.Tungekar
Status: submitted
Type: restricted
ImportedBy:
Identity:
Description:
*Speed improvements for FBX Scene Importer
*Added a static method to compute Hash.
JobStatus:
Jobs:
Files:
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Classes/Factories/Factory.h#3
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Private/Factories/Factory.cpp#3
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Private/Fbx/FbxStaticMeshImport.cpp#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Runtime/Engine/Classes/EditorFramework/AssetImportData.h#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Runtime/Engine/Private/EditorFramework/AssetImportData.cpp#2
Change 3151664 on 2016/10/05 by Richard.Hinckley
Fixing ACharacter template for "New C++ Class" feature. Avoiding naming a function parameter the same as an existing class member.
Change 3151729 on 2016/10/05 by Thomas.Sarkanen
Audit of remaining NaN checks
Some checks remain on in shipping (generally those called from blueprint):
- AActor::TeleportTo
- AActor::SetActorRelativeScale3D
#jira UE-30999 - Optimize ⌠ContainsNaN÷ and ⌠ContainsNaNOrInfinite÷, audit those still in shipping/test
Change 3151742 on 2016/10/05 by Ori.Cohen
Make sure that if physical animation component doesn't find a body and bone it doesn't crash.
#JIRA UE-36839
Change 3151756 on 2016/10/05 by Jurre.deBaare
Fixing d3dcompiler_47.dll missing issue
#fix added runtime dependency and dll name to build.cs file
#fix now load the d3dcompiler_47.dll from the Binaries/ThirdParty/Windows folder before loading the simplygon DLL
Change 3151761 on 2016/10/05 by Thomas.Sarkanen
Fix deprecation warning from last integration
Moved Preview to EditorPreview in FEditorWorldManager::OnWorldContextAdd.
#jira UE-36858 - Compile UE4Editor* completed with 1 warning
Change 3151782 on 2016/10/05 by Jurre.deBaare
Simplygon patch up
#misc linker errors popping up from JSONCPP
#misc incorporated emissive material property fix from other shelve
#misc static analysis fix
Change 3151804 on 2016/10/05 by Marc.Audy
Clear need end of frame update when unregistering a component
Change 3151928 on 2016/10/05 by Ori.Cohen
Fix runtime DLLs not including all delay loaded physx dll files.
#JIRA UE-36816
Change 3151977 on 2016/10/05 by Martin.Wilson
Notifies can no longer occupy the same time on the same track.
#jira UE-30658
Change 3151989 on 2016/10/05 by Jon.Nabozny
Fix ArchVis character rotation pitch when looking up/down.
#jira UE-35706
Change 3152083 on 2016/10/05 by Marc.Audy
Ensure that pending kill components get their marked for end of frame state cleared.
Change 3152086 on 2016/10/05 by Ben.Zeigler
#jira UE-36169 Fix it so missing linker errors that point to Blueprint CDOs are skipped, the same way it skips linker errors going to the actual class. Fixes a lot of spurious warnings from deleting components from blueprints or native classes
Clean up the VerifyImport error handling so it also displays in -game and cook, and fix the missing class warning to work properly, previously it would happen 0% in development 100% in debug even if the class was valid
Change 3152093 on 2016/10/05 by Marc.Audy
Change logic for when location cannot be changed for a static component to be independent of has begun play and have to do with whether construction script is running or the level is in the process of loading (mostly for backwards compatibility adjustments in post load).
#jira UE-36146
#jira UE-24647
Change 3152100 on 2016/10/05 by Ben.Zeigler
Remove pragma optmize
Change 3152112 on 2016/10/05 by Marc.Audy
Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3152072
Change 3152134 on 2016/10/05 by Jurre.deBaare
Simplygon/Merge actor issues
#fix for emissive output on meshes that do not have emissive properties
#fix for texture binning, not removing invalid split area causing overlapped textures
Change 3152136 on 2016/10/05 by James.Golding
UE-36859 Fix tooltip saying you can click to stop recording
Change 3152169 on 2016/10/05 by James.Golding
UE-31209 UE-30935 : Expose bDeformableMesh and bFastCook options in FTriMeshCollisionData
ProceduralMeshComponent will now cook using 'fast' and 'deformable' options, so updating collision on sections should work correctly
Change ERuntimePhysxCookOptimizationFlags to EPhysXMeshCookFlags and use that to pass options to CookConvex and CookTriMesh
Change 3152202 on 2016/10/05 by Jurre.deBaare
Mac/Linux fix
Change 3152303 on 2016/10/05 by Marc.Audy
Fix deprecation warning post merge from main
Change 3152320 on 2016/10/05 by Martin.Wilson
Fix root motion from everything calculating incorrect root motion when animations haven't been ticking
#jira UE-35364
Change 3152354 on 2016/10/05 by James.Golding
PoseDriver should pass through if no poses activated
Change 3152357 on 2016/10/05 by James.Golding
UE-36844 Remove unused OnAssetModifiedNotifier delegate from PoseAsset, ensure OnPoseListChanged is called when updating PoseAsset from anim.
Change 3152556 on 2016/10/05 by Marc.Audy
Remove autos
Change 3152560 on 2016/10/05 by Marc.Audy
Don't allow child actor references to be dragged from the outliner to a level script
#jira UE-16700
Change 3152568 on 2016/10/05 by Marc.Audy
Don't allow non-networking code to set bRemoteOwned in the actor spawn parameters
Remove deprecated bNoCollisionFail
#jira UE-35928
Change 3152575 on 2016/10/05 by Marc.Audy
Allow construction script to run post move for native classes. Actor can determine whether it should only occur on finish or every call to post edit move
Change 3153101 on 2016/10/06 by Thomas.Sarkanen
Fix crash re-opening the viewport in Persona-based editors
#jira UE-36775 - Editor crashes when re-opening viewport in Persona
Change 3153139 on 2016/10/06 by James.Golding
UE-36908 Remove GetRuntimeOnlyCookOptimizationFlags if cooking is not supported
Change 3153160 on 2016/10/06 by Thomas.Sarkanen
Fix for crash when deleting additive layer track
Code had not been updated to use the new delgate system (was still using reciprocal FPersona ptr).
#jira UE-36740 - Crash when removing or disabling an additive layer track in Persona
Change 3153175 on 2016/10/06 by Benn.Gallagher
Fixed crashes when using subinstances in non-default states. we previously initialized the anim instances in the node initialize, but in states that haven't been hit by an initialize this will happen off the game thread which is not allowed.
#jira UE-36900
Change 3153223 on 2016/10/06 by Thomas.Sarkanen
Fixed crash when opening an asset from the blend space editor
Code was still trying to open 'old' Persona when it was disabled.
Also fix other call sites where this was being done outside of asset type actions.
#jira UE-36766 - Crash attempting to open an asset from Aim Offset graph in Persona
Change 3153324 on 2016/10/06 by Thomas.Sarkanen
Prevented invalid GUIDs from being saved into smart name containers
AddOrFindName now checks to see if existing GUIDs are valid before using them.
AddName now requires a valid GUID to be passed in.
Also added Modify() call to the skeleton when FindOrAddSmartName is called from VerifySmartNameInternal, as without this the skeleton might not get saved.
Also add Laurent's fix for fixing up already-saved invalid GUIDs (CL 3138068).
#jira UE-36367 - It is possible for curves with an invalid GUID to be saved into the USkeleton asset
Change 3153348 on 2016/10/06 by Martin.Wilson
Re add ticking code so all Persona editors viewports tick during drag events (went missing in Persona refactor)
#jira UE-36751
Change 3153426 on 2016/10/06 by Mieszko.Zielinski
Added missing elements of block comments support in BT editor #UE4
Change 3153454 on 2016/10/06 by Benn.Gallagher
Fixed crash using anim debug with subinstances that are preceded by branching nodes.
#jira UE-36935
[CL 3153517 by Ori Cohen in Main branch]
2016-10-06 12:11:11 -04:00
# if ENABLE_ANIM_DEBUG && ENABLE_DRAW_DEBUG
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
const bool bShowDebug = ( CVarAnimNodeLegIKDebug . GetValueOnAnyThread ( ) = = 1 ) ;
if ( bShowDebug )
{
2018-02-22 11:25:06 -05:00
DrawDebugLeg ( * this , MyAnimInstanceProxy , FColor : : Red ) ;
MyAnimInstanceProxy - > AnimDrawDebugSphere ( GetBoneWorldLocation ( IKFootTransform , MyAnimInstanceProxy ) , 4.f , 4 , FColor : : Red , false , - 1.f , 2.f ) ;
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
}
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3153514)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3050254 on 2016/07/14 by Marc.Audy
Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3049614
Change 3136629 on 2016/09/22 by Marc.Audy
bye bye auto
Change 3136631 on 2016/09/22 by Marc.Audy
Allow objects to be marked as duplicate transient or non PIE duplicate transient
ChildActors are not marked consistent with the property that references them as text export transient and non PIE duplicate transient
#jira UE-35680
Change 3136636 on 2016/09/22 by Marc.Audy
ParticleSystem and Audio Components now route Activate/Deactivate events to blueprints
Component Activate/Deactivate events now provide component as a property
#jira UE-35191
Change 3136640 on 2016/09/22 by Marc.Audy
Expose bReplicates to blueprint component properties
#jira UE-34433
Change 3136709 on 2016/09/22 by Ori.Cohen
Fix GetBodyInstance returning incorrect bodies when welded kinematics are attached.
#JIRA UE-36234
Change 3136710 on 2016/09/22 by Ori.Cohen
Fix defer actors not working when the physics scene is simulating. We now flush when the scene is not simulating, as well as a lazy flush that goes through the slow path when needed. This allows us to batch multiple components together.
#JIRA UE-35899
Change 3136770 on 2016/09/22 by Marc.Audy
Fix compile error
Change 3136854 on 2016/09/22 by Marc.Audy
Sprite components need to be text export transient
#jira UE-36064
Change 3136926 on 2016/09/22 by Ori.Cohen
Fix ensure when skeletal mesh bodies have no collision.
Change 3137054 on 2016/09/22 by Aaron.McLeran
PR #2628: Fix UAudioComponent SubtitlePriority not being initialised (Contributed by alanedwardes)
Change 3137058 on 2016/09/22 by Aaron.McLeran
PR #2562: ReadCompressedInfo calculates duration for ADPCM audio (Contributed by derekvanvliet)
Change 3137060 on 2016/09/22 by Aaron.McLeran
UE-36336 Fixing A3D for mono/2D sounds
- Making it so if A3D is being loaded but not enabled, we can not have reverb on 2D sounds
- Fixing A3D mono sources from failing after a time
Change 3137066 on 2016/09/22 by Aaron.McLeran
Checking in Ngs2.Build.cs with A3D and USING_A3D set to 0
Change 3137098 on 2016/09/22 by dan.reynolds
AEOverview Update: EQ Map, Reverb Map plus improvements on Main array cleanup process.
Change 3137132 on 2016/09/22 by Aaron.McLeran
PR #2789: Fixed signature of FActiveSound::GetIntParameter (Contributed by Laurie-Hedge)
Change 3137175 on 2016/09/22 by Aaron.McLeran
Fixing compile error with PhysXCollision.cpp from CL 3136710
Change 3137540 on 2016/09/23 by Thomas.Sarkanen
Fixed crash when generating LODs automatically for skeletal meshes
Quadric error reduction does not support skeletal meshes, so fails. Client code assumes that it cannot fail so crashed. This guards against immediatly assuming that LODs are valid after simplification.
#jira UE-36253 - Crash applying LOD changes in Persona
Change 3137720 on 2016/09/23 by Thomas.Sarkanen
Changed asset shortcut bar to display asset names & reworked padding
#jira UE-36347 - Anim asset shortcut bar has difficult to read/cut-off text
Change 3137761 on 2016/09/23 by Martin.Wilson
Fix typo in root motion from everything accumulation code
Change 3137877 on 2016/09/23 by Thomas.Sarkanen
Fixed undo/redo forcing skeletal meshes into t-pose
Re-populated AnimationData in InitAnim for UDebugSkelMeshComponent.
#jira UE-35579 - If you undo an animation change to any animation asset (for single preview), the playback controls will no longer function
Change 3137885 on 2016/09/23 by Benn.Gallagher
Fixed APEX clothing disappearing when time dilation results in a dt of 0. After simulating an actor with 0 APEX will fill positions and normals with NaNs, causing the disappearance. The fix in this case is to not schedule the evaluation task if we're not wanting to do any work. The simulation then freezes as we would expect.
#jira UE-35151
Change 3137888 on 2016/09/23 by Benn.Gallagher
Fixed transition nodes being able to be pasted or duplicated without 2 valid pin links
#jira UE-24860
Change 3137889 on 2016/09/23 by Benn.Gallagher
Fixed transform and widget inconsistencies in IK edit mode
#jira UE-20628
Change 3137890 on 2016/09/23 by Jurre.deBaare
Alembic Cached Geometry Does Not Display in Stand Alone Game
#fix required to force load the GeometryCache module during runtime
#jira UE-36187
Change 3137892 on 2016/09/23 by Jurre.deBaare
Geometry cache playback should work in sequencer
#fix add Interp UProperty tag to specific properties used for playing back the cache, future fix is having same approach as skeletal mesh animation for sequencer (depends on needs, -> skeletal mesh import has better compression anyway)
#jira UE-35447
Change 3137893 on 2016/09/23 by Jurre.deBaare
Alembic Cache Importer option for Hard Edge Angle Threshold does not work for objects with no normals
#fix adhere to the assumed 'standard' no normals in ABC file means completely smooth normals throughout the sequence
#jira UE-35091
Change 3137894 on 2016/09/23 by Jurre.deBaare
Importing an Alembic File While mesh Distance Fields are Enabled Crashes Editor
#fix Needed to save the raw mesh before building the mesh to ensure a LOD resource was created
#misc added a new check + message in case this occurs again
#jira UE-36059
Change 3137938 on 2016/09/23 by Jurre.deBaare
Alembic Importing with Incorrect UV's
#fix adding option for flipping UVs on import
#jira UE-36190
Alembic import axis not aligned correctly
#fix also added option to specify scale and rotation to be applied during import (with preset for Maya and Max)
#jira UE-35510
Change 3137949 on 2016/09/23 by Jurre.deBaare
Frame range importing causes confusion during Alembic importing
#fix this required storing information per Alembic object at which frame index it actual has stored frames, using this data we can determine which frames are empty, and at which frame there is data. This allows us to skip empty frames if we want to import data-only frames, or to import all frames in the sequence including empty (pre-roll) frames.
#misc changed settings UI listview layout (extra columns and resized old ones)
#jira UE-35498
Change 3137994 on 2016/09/23 by Martin.Wilson
Fix for creating an empty state when dragging a montage into a state machine graph
#jira UE-33371
Change 3138103 on 2016/09/23 by Aaron.McLeran
UE-36312 Fixing sound node distance cross fade for case of looping sounds
Change 3138104 on 2016/09/23 by Aaron.McLeran
UE-35392 Copy pasting local node into separate project crashes the engine
Change 3138224 on 2016/09/23 by Aaron.McLeran
UE-36312 Fixing sound node distance cross fade for case of looping sounds
- Adding a check for wave instance count to account for virtualized sounds (one-shots)
Change 3138666 on 2016/09/23 by Ben.Zeigler
#UEFW-204 Add more comprehensive gameplay tag tests
Fix issue with HasTag(Tag, IncludeParent, IncludeParent) revealed by tests, this was not returning true correctly in some cases. This use case is weird and will be deprecated soon
Change 3138779 on 2016/09/23 by Marc.Audy
Get rid of pointless casts
Change 3138782 on 2016/09/23 by Marc.Audy
remove some GWorlds
Change 3139701 on 2016/09/26 by Jurre.deBaare
Assert failed on GemetryCache for PS4 package
#fix add GeometryCache reference in engine build.cs and fix the serialization of geometry cache files
#jira UE-36392
Change 3139704 on 2016/09/26 by Jurre.deBaare
Fix for -1 begin frame
#fix do the max as an signed int, to make sure we don't wrap around
Change 3139748 on 2016/09/26 by Benn.Gallagher
PR #2784: Make sure that SceneScratchBufferSize is a multiple of 16K as requested by PhysX (Contributed by DenizPiri)
Moved the definition of the boundary to a FPhysScene class static
Changed comments on original user settings property to communicate the fact that the value is now rounded to the next 16K boundary
#jira UE-35736
Change 3139903 on 2016/09/26 by Benn.Gallagher
Fixed exposing subinstance pins stomping over class defaults and setting to uninitialized values
#jira UE-34366
Change 3140409 on 2016/09/26 by Lukasz.Furman
fixed uninitialized configs of gameplay debugger
copy of CL# 3140399
Change 3140516 on 2016/09/26 by dan.reynolds
AEOverview Map Update - Ambient Zone + Focus Test
Change 3140526 on 2016/09/26 by Jon.Nabozny
#rn Fixed CanJump inconsistencies with previous versions.
Deferred JumpCurrentCount increment until after jump, made bWasJumping a member variable, and updated how
jump count and hold time were compared in CanJump.
#jira UE-35524, UE-35582
Change 3140745 on 2016/09/26 by dan.reynolds
AEOverview Test Map Update + Occlusion Test
Change 3140839 on 2016/09/26 by dan.reynolds
AEOverview - minor updates
Change 3141101 on 2016/09/27 by Thomas.Sarkanen
Preview scene worlds now render correctly
Split "Preview" type into "EditorPreview" (the default) and "GamePreview". Deprecated the old "Preview" world type (but kept its index).
In-game hidden flags now apply to GamePreview, but not EditorPreview worlds.
Deprecated old bHack_Force_UsesGameHiddenFlags_True boolean. GamePReview now serves this purpose.
Fixed up UT cases where this was being used.
FPreviewScenes now use the editor mode by default, but can be set to non-editor if needed (as is the case with the still-experimental UViewport).
Custom depth pass is not enabled for EditorPreview (as before) but is for GamePreview.
Fixed erroneous use of TEnumAsByte for non-uproperty WorldType.
#jira UE-22883 - Using FPreviewScenes in-game for scene captures
Change 3141106 on 2016/09/27 by Thomas.Sarkanen
Column toggling improvements
Column toggle menu now does not close when items are selected.
This requries some Slate changes to how submenus are built to allow for sumbenus to specify whether they close after selection.
Also allowed columns to be hidden by default for specific use cases (like the sequence browser).
#jira UE-35818 - Anim asset browser column picker should stay up
Change 3141131 on 2016/09/27 by Thomas.Sarkanen
Fix CIS warnings
Fallout from preview world changes
Change 3141143 on 2016/09/27 by Jurre.deBaare
Fix for CIS errors
Change 3141235 on 2016/09/27 by Thomas.Sarkanen
Fix offset of Persona floor mesh when auto-alignment is enabled
When auto alignment was disabled, the offset wasnt getting taken into account.
#jira UE-35544 - In Persona, Floor Height Offset does nothing with Auto Align Floor to Mesh disabled
Change 3141327 on 2016/09/27 by Marc.Audy
Ensure that the client side AttachChildren array remains accurate
#jira UE-26025
Change 3141474 on 2016/09/27 by mason.seay
Updating test map name and moving PlayerStart
Change 3141501 on 2016/09/27 by Benn.Gallagher
Loading time improvements for destructibles from Nvidia
Updated to use new framework custom version instead of global object version
Fixed usage of TArray to enable correct loading and saving of the cached data.
#jira UE-29680
Change 3141889 on 2016/09/27 by Marc.Audy
Fix DestructibleMesh when WITH_APEX is 0
#jira UE-36484
Change 3142034 on 2016/09/27 by Marc.Audy
Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3141971
Change 3142131 on 2016/09/27 by Ori.Cohen
Make sure we return eTouch to physx during an overlap query. Fixes bad behavior when multiple objects blocked in an overlap query.
#JIRA UE-36381
Change 3142154 on 2016/09/27 by Ori.Cohen
Fix build, ModuleCachedData instead of NxApexModuleCachedData
Change 3142159 on 2016/09/27 by mason.seay
Blueprint for testing Child Actor Templates
Change 3142255 on 2016/09/27 by Jon.Nabozny
Fix crashes in QAMeshMerge component by making it a UObject, exposing it's method statically, and taking QASkeletalMeshMergeParams as an argument.
#jira UE-35199, UE-35197, UE-35201
Change 3142717 on 2016/09/27 by dan.reynolds
AEOverview Update + Sound Class Test
Change 3142764 on 2016/09/27 by Marc.Audy
Fix Ocean deprecation warnings
Change 3142962 on 2016/09/28 by Thomas.Sarkanen
Fixed bounds calculations for local camera animations
Correctly calculated bounds as local to the initial transform in the track.
Implemented suggested fixes from UDN user chhaddon (The Coalition).
#jira UE-29594 - CameraAnim bounds are incorrect when bRelativeToInitialTransform == true
Change 3143007 on 2016/09/28 by Martin.Wilson
Added virtual bones to USkeleton
API Breaking change:
-Added USkeleton pointer to RemoveBonesByName
-FReferenceSkeleton::UpdateRefPoseTransform & FReferenceSkeleton::Add made private. Must use FReferenceSkeletonModifier instead
#jira UEFW-81
Change 3143040 on 2016/09/28 by James.Golding
Strip DrawDebug.. functions from Shipping and Test builds, controlled by new define ENABLE_DRAW_DEBUG
Fix up game projects to compile in Shipping/Test after this change
PR #2757: (Contributed by projectgheist)
#jira UE-35488
Change 3143046 on 2016/09/28 by James.Golding
Fix OrionEnvironmentPerfTest.cpp compiling in Shipping (optimizations were not being re-enabled at end of file)
Change 3143047 on 2016/09/28 by James.Golding
PR #2731: Capsule primitive drawing fix (Contributed by kamrann)
#jira UE-35142
Change 3143050 on 2016/09/28 by Martin.Wilson
Update DDC key as some animation have stale data
Change 3143088 on 2016/09/28 by Martin.Wilson
CIS Fixes for Ocean after FReferenceSkeleton changes
Change 3143090 on 2016/09/28 by Benn.Gallagher
Fixed split pins in animation blueprints losing their pin links on editor restart. The anim nodes had opted out of the Super version of reconstruct, but that's where split pin restoration was added so we were skipping it.
#jira UE-36482
Change 3143091 on 2016/09/28 by Thomas.Sarkanen
Fix play/pause keyboard shortcut toggle in Persona based editors
Correctly handled widget mode switching in the skeleton selection edit mode (previously it was manually handling this rather than hooking into the correct level viewport callbacks).
Added the ability for FEdModes to specify whether they can use a widget mode.
Added a common set of commands that all Persona-based editors can opt into (only contains TogglePlay for now).
#jira UE-35163 - Cannot use Play/Pause shortcut in Persona if viewport is focused
Change 3143100 on 2016/09/28 by James.Golding
UE-32275 Fix Anim Curve entries losing Auto state when hidden/reshown
Change 3143107 on 2016/09/28 by Martin.Wilson
Add check to IsRunningParallelEvaluation to verify that the skeletal mesh component in question still references us
#jira UE-34431
Change 3143125 on 2016/09/28 by Jurre.deBaare
PR #2749: Fix blend space triangulation (Contributed by tmiv)
Change 3143225 on 2016/09/28 by Jurre.deBaare
Mesh/material merging basic test files
Change 3143235 on 2016/09/28 by Martin.Wilson
Fix issue where montage wrong section was updated with changes from details panel when clicking on a new section
#jira UE-35929
Change 3143312 on 2016/09/28 by Marc.Audy
Don't globally reregister components, globally recreate render state instead when force deleting assets
Fixes crash force deleting a blueprint with a child actor component in it from the content browser
Change 3143340 on 2016/09/28 by Mieszko.Zielinski
Improved consistency of loudness usage in AISense_Hearing #UE4
Change 3143359 on 2016/09/28 by Marc.Audy
Fix spelling error in comment
Change 3143372 on 2016/09/28 by Jurre.deBaare
HLOD meshes are causing degenerate triangles
#fix Setting flag to ignore degenerate triangles when building the meshes vertex/index buffers
#jira UE-34336
Change 3143420 on 2016/09/28 by Mieszko.Zielinski
Fix to BlackboardData initialization's dependency on parent asset's initialization #UE4
Change 3143421 on 2016/09/28 by Martin.Wilson
Allow reading on animation sequence length in blueprints
#jira UE-34168
Change 3143455 on 2016/09/28 by James.Golding
Add 'noop' versions of DrawDebug function, so you will not get compile errors by default for calling them in Shipping/Test builds.
Added optional SHIPPING_DRAW_DEBUG_ERROR define, which will give compile errors in Shipping/Test if still calling DrawDebug functions
Change 3143518 on 2016/09/28 by Jurre.deBaare
Meshes with no UV Coordinates will break the UVs of other meshes contained in the same HLOD if they share a material
#fix calculate UV bounds and check whether they occupy any space (if not do not use them for baking out the material)
#misc set texture sampling for HLOD proxy base material to clamp
#jira UE-35221
Change 3143542 on 2016/09/28 by James.Golding
Change SHIPPING_DRAW_DEBUG_ERROR define from ifdef to if
Fix comment
Enable by default for FN
Change 3143543 on 2016/09/28 by Benn.Gallagher
Changed branch + early return into an ensure during FPxQueryFilterCallback::preFilter. We were checking for invalid shapes in preFilter but that shouldn't happen. More likely to get some information as an ensure instead of earlying out on the funciton.
Change 3143556 on 2016/09/28 by Aaron.McLeran
UE-36540 Editor Preferences 'Enable Sound' option causes Real Time Audio to Stop Working after PIE
Change 3143566 on 2016/09/28 by Benn.Gallagher
Readded early out alongside new ensure for catching bad preFilter shapes
Change 3143568 on 2016/09/28 by Marc.Audy
Fix deprecation warnings in UT
Change 3143572 on 2016/09/28 by Jurre.deBaare
More test content for mesh/material merging
Change 3143581 on 2016/09/28 by Jurre.deBaare
More content :D
Change 3143585 on 2016/09/28 by Jurre.deBaare
Geometry cache cleaning
#misc fix for missing materials, not serialized (facepalm) as they were added later on (required custom version bump)
#misc cleaning out unecessary code
Change 3143594 on 2016/09/28 by Marc.Audy
Creating a child actor component by dragging an actor blueprint in to another blueprint now properly creates the template
#jira UE-36511
Change 3143658 on 2016/09/28 by Marc.Audy
RootComponent can be null by the time we hit PostUnregisterAllComponents so need to protect against the dereference
#jira UE-36553
Change 3143776 on 2016/09/28 by Marc.Audy
Properly reinstance child actor templates when using the fast reinstancing path
#jira UE-36516
Change 3143896 on 2016/09/28 by Ori.Cohen
Remove UPROPERTY on aggregate threshold which is always read from the physics settings.
Change 3144022 on 2016/09/28 by Ben.Zeigler
Move AIMoveTo node from BlueprintGraph to AIGraph and remove BlueprintGraph->AIModule dependency in build system
Change 3144252 on 2016/09/28 by mason.seay
More blueprints for child actor template testing
Change 3144262 on 2016/09/28 by Mason.Seay
Deleting assets
Change 3144283 on 2016/09/28 by dan.reynolds
AEOverview update + Sound Priority Test
Change 3144411 on 2016/09/28 by dan.reynolds
AEOverview end of day update and tweaks
Change 3144679 on 2016/09/29 by Benn.Gallagher
Changed skeletal bounds calculation to not consider clothing assets that aren't simulating in the current LOD. In this case we're not rendering the clothing, we're only rendering the skeletal geometry for that section in that LOD which isn't bound to cloth.
Change 3144856 on 2016/09/29 by Jurre.deBaare
HLOD Outliner scrolls back to the top when generating proxy meshes
#fix OnLevelActorsAdded was getting called for actors in the thumbnail worlds, which forced a refresh on the listview
#jira UE-30384
Change 3144864 on 2016/09/29 by Thomas.Sarkanen
Preview mesh fixes
Animation preview meshes are now respected (and saved). Mesh is displayed as empty if none is set (but a default is chosen).
Skeleton preview meshes are now shown as empty if none is set (but a default is chosen).
#jira UE-36582 - Cannot set preview mesh per-animation
Change 3144865 on 2016/09/29 by Jurre.deBaare
More test content
Change 3144885 on 2016/09/29 by James.Golding
UE-35307 Move 'invalid scale' warning to Message Log to be more visible in editor
Change scale clamping in UpdateBodyScale to catch cases like (1,0,1)
Change 3144903 on 2016/09/29 by Thomas.Sarkanen
Deprecating StaticMesh in UStaticMeshComponent
Added GetStaticMesh to access the value as read-only.
SetStaticMesh is now called in all locations that used to call "StaticMesh =".
Lots of fixups.
#jira UE-24859 - Deprecate public access to StaticMesh property in UStaticMeshComponent
Change 3145020 on 2016/09/29 by Thomas.Sarkanen
Fix bounds calculations that include bones to respect LOD (and other requried bones)
Sometimes bones would not be updated if we LOD switched, extending the bounds.
#jira UE-36525 - UDebugSkelMeshComponent::CalcBounds should filter by LOD
Change 3145041 on 2016/09/29 by Jurre.deBaare
Setting the Target Lightmap UV Channel to an incorrect value leads to inconsistent results
#fix removed target light map channel, we now determine according to the UV channels which are unused in the final mesh
#misc ignore the source lightmap uv channels to reduce data
#jira UE-36595
Change 3145219 on 2016/09/29 by Benn.Gallagher
Fixed clothing actors not casting shadows in editor, after the material editing change the copy of the shadow flag was missed from the clothing association code, which runs on again on older clothing assets to use the new render data skinning. Also added some fix up for assets that have be saved in the mean time.
#jira UE-36552
Change 3145222 on 2016/09/29 by Jurre.deBaare
Exporting Alembic Skeletal mesh from UE4 to FBX causes a crash
#fix on import set _all_ bone influence to 0
#jira UE-36602
Change 3145267 on 2016/09/29 by Ori.Cohen
Move OnConstraintBreak delegate so that it fires outside of fetchResults. Fixes crash from user doing unsafe things during fetchResults.
#JIRA UE-36483
Change 3145306 on 2016/09/29 by Jon.Nabozny
Fixed PhAT so multiple constraints can be selected and edited properly at the same time.
#JIRA: UE-31493
Change 3145342 on 2016/09/29 by Marc.Audy
Do not update cull distance volumes whenever any property changes
* Any movement or property change of a cull distance volume still does a global update
* Any movement of a component belong to any other Actor updates only the components of that Actor
* Any property change of a primitive component only updates that component
#jira UE-36399
Change 3145958 on 2016/09/29 by Marc.Audy
In game worlds don't auto activate components until the actor is ready to process them
#jira UE-35189
Change 3146110 on 2016/09/29 by dan.reynolds
AEOverview update + Soundwave Procedural Test Map
Change 3146375 on 2016/09/30 by Benn.Gallagher
Fixed crash saving newly created destructible mesh after material refactor.
#jira UE-36619
Change 3146378 on 2016/09/30 by James.Golding
UE-35908 Line trace against a BodyInstance now returns closest hit for trimesh (was any hit before)
Also add stat for FBodyInstance::LineTrace
Change 3146379 on 2016/09/30 by James.Golding
Add test assets for creating procmesh collision in non-editor builds
Change 3146386 on 2016/09/30 by Thomas.Sarkanen
Fixed ensures (and functionality) of 'show uncompressed animation' option in Persona viewports
Made sure that PreEvaluateAnimation is called for th einstance in use, rather than only the preview instance.
This unearthed another issuye where each of the calls to GenSpaceBAses was causing the animation to run faster. Fixed this by resetting the update flag in the update context after it is used.
#jira UE-36251 - Ensures showing uncompressed animations in anim blueprints
Change 3146464 on 2016/09/30 by Thomas.Sarkanen
Fix layered blend per bone odd/even connection counts alternately working/not working
Older hacky fix for multi-property to array copies flip-flipped between using fast path and not, when it really should have disabled fast path after the first array pin. Now it disables fast path based on whether this is a new handler or not, rather than looking at the SimpleCopyPropertyName.
#jira UE-35648 - Layered Blend Per Bone doesn't work correctly with 3+ inputs
Change 3146652 on 2016/09/30 by Benn.Gallagher
Fixed subinstance properties appearing in the caller's details panel as oddly named properties.
#jira UE-34141
Change 3146673 on 2016/09/30 by Martin.Wilson
Make RawAnimationData (and associated anim sequence data) private
#jira ue-25869
Change 3146680 on 2016/09/30 by Benn.Gallagher
Fixed errant asterisks in tooltips for source and target bone on rotation multiplier controller node
#jira UE-29847
Change 3146681 on 2016/09/30 by Benn.Gallagher
Fixed incorrect tooltip on left hand IK bone in hand ik retargetting node
#jira UE-30885
Change 3146711 on 2016/09/30 by Jon.Nabozny
Fix PhAT SnapConstraintToBone.
#jira UE-31491
Change 3146717 on 2016/09/30 by Danny.Bouimad
Adding Jurres really useful merge actor test assets to somewhere QA can get em.
Change 3146738 on 2016/09/30 by Martin.Wilson
Fix pose blending for on non-additive pose blending + remove normalising of weights for weights less than 1
#tests Editor tests with mambo pose asset
#jira UE-36189
Change 3146750 on 2016/09/30 by Jurre.deBaare
Material baking issue
#misc Removed the renderer initialization which causes issue the first time you would render out a material (gradient from top left to bottom right over the texture)
#misc Replaced incorrect masks with _way_ better approach thanks to Martin
Change 3146755 on 2016/09/30 by Jurre.deBaare
Need better progress bar for HLOD
#fix replaced the progress updates with new more 'correct' ones according to the actual workload and fixed up the Simplygon progress callback
#jira UE-34334
Change 3147085 on 2016/09/30 by Marc.Audy
PR #2815: GetNextViewablePlayer now checking and returning correct PlayerState. (Contributed by joshkay)
#jira UE-36632
Change 3147224 on 2016/09/30 by Martin.Wilson
CIS Fix
Change 3147280 on 2016/09/30 by Marc.Audy
Mouse smoothing should use application frame rate, not the dilated game frame rate
#jira UE-31040
Change 3147446 on 2016/09/30 by Aaron.McLeran
UE-36682 SoundCue Delay Not Consuming Input StartTime Correctly
Change 3147693 on 2016/09/30 by Ben.Zeigler
#jira UE-36657
If a player has an existing Pawn during RestartPlayer, use that pawn's rotation instead of the start spot, because we were already keeping the pawn's location
Change 3147697 on 2016/09/30 by Jon.Nabozny
Add rotation parameter to FBodyInstance::Sweep and FBodyInstance::InternalSweepPhysX
#jira UE-30486
Change 3147761 on 2016/09/30 by Jon.Nabozny
Fix AUTRepulsorBubble UPrimitiveComponent::SweepComponent usage.
Change 3148533 on 2016/10/03 by Thomas.Sarkanen
Fix new deprecation warnings introduced by the pull from main
Change 3148567 on 2016/10/03 by Marc.Audy
Fix crash when exiting PIE while a panoramic screenshot is being taken
Make stereo panorama tick with the world it is operating on
#jira UE-36492
Change 3148571 on 2016/10/03 by Marc.Audy
Allow modification of components that are EditAnywhere but don't exist in the CDO
#jira UE-36694
Change 3148607 on 2016/10/03 by Martin.Wilson
Properly end notify states when we clear the anim instance on a skeletal mesh.
#jira UE-32488
Change 3148711 on 2016/10/03 by Martin.Wilson
Fix type in virtual bone tooltip
#jira UE-36703
Change 3148746 on 2016/10/03 by Benn.Gallagher
Fixed a few cases where post process and sub instance anim calls weren't being made correctly.
#jira UE-36529
Change 3148807 on 2016/10/03 by Martin.Wilson
Fix mismatch skeleton error when undoing virtual bone changes
#jira UE-36705
Change 3148812 on 2016/10/03 by Martin.Wilson
Add undo support to removing virtual bones
#jira UE-36706
Change 3148975 on 2016/10/03 by Jurre.deBaare
Issue with combining meshes both with/without normal maps
#fix make sure we always output atleast the default normal value when baking out materials, this to ensure we output non-black values for meshes without normal maps (this would cause the normal to be incorrect)
#misc fixed issue in function to set texture rectangle to a single colour
#misc spotted comparison error
Change 3148976 on 2016/10/03 by Ori.Cohen
Make sure that shape queries that we pass into physx are never size 0. Fixes some NaNs
#JIRA UE-36639
Change 3148991 on 2016/10/03 by Jurre.deBaare
Changing LOD materials on Merged Actors Crashes Editor
#fix take into account LOD that is using the material when remapping (removing duplicate) materials
#jira UE-35883
Change 3148997 on 2016/10/03 by Jurre.deBaare
Make sure we remove matrix samples that fall outside of the import range and remap those that are in range
Change 3149002 on 2016/10/03 by Jurre.deBaare
Issues with importing Alembic caches using matrix transformations
#fix Apply conversion matrix to imported matrix samples to make them match the DCC package they were exported from
Change 3149030 on 2016/10/03 by Martin.Wilson
Dont show save warning on animations when we have curve data
#jira UE-34145
Change 3149115 on 2016/10/03 by Mieszko.Zielinski
Made PathfollowingComponent distinct between patrial and full paths in terms of acceptance radius used, when trying to determin if pathing agent is at goal location #UE4
#jira UE-35153
Change 3149186 on 2016/10/03 by Ben.Zeigler
#UE-36722 Fix failure to spawn when trying to spawn 4 capsules in the exact same location
There's no "Correct" direction to move out of a penetrating capsule, but old PhysX appeared to be consistent. New PhysX is not, so now we save and restore the adjustment instead of letting previous iterations modify it.
This code is weird but this solution is better than the old version and handles inconsistent results
Change 3149235 on 2016/10/03 by Martin.Wilson
Change inline curve name editing to only change the name of that specific curve, instead of renaming the smart name itself.
#jira UE-20005
Change 3149245 on 2016/10/03 by Marc.Audy
Remove duplicate entries from AttachChildren caused by lack of atomic cross-object updates.
Change 3149397 on 2016/10/03 by Ori.Cohen
Fix collision profile writing out response values to channels that don't exist.
#JIRA UE-36359
Change 3149679 on 2016/10/03 by Zak.Middleton
#ue4 - Don't mark CharacterMovementComponent::bUseControllerDesiredRotation as an advanced property. Consolidate rotation settings (RotationRate, bUseControllerDesiredRotation, bOrientRotationToMovement) in a new "Rotation Settings" category.
Change 3149929 on 2016/10/04 by Jurre.deBaare
Fix for CIS errors
#fix Mac didn't like undefined struct
Change 3149977 on 2016/10/04 by danny.bouimad
Massive update to Merge Actor test files
Change 3150014 on 2016/10/04 by James.Golding
UE-36686 Fix crash when slicing and not creating other section
Change 3150016 on 2016/10/04 by James.Golding
UE-35335 MergeActors now converts box collision to convex, so collision scales correctly after merging
Change 3150019 on 2016/10/04 by James.Golding
UE-36737 Fix LineTraceComponent not returning face index
Change 3150020 on 2016/10/04 by James.Golding
UE-36672 Export PhysicsContstraintComponent class so it can be subclassed outside Engine module
Change 3150027 on 2016/10/04 by Ben.Marsh
Add PhysX build option into Dev-Framework.
Change 3150042 on 2016/10/04 by Benn.Gallagher
Fixed clothing example 1.3 collision glitches
Change 3150172 on 2016/10/04 by Benn.Gallagher
Made Skeletal Mesh LOD reimports clear any existing simplification flag so we don't show "generated" next to LOD entries for them.
#jira UE-36589
Change 3150319 on 2016/10/04 by Ori.Cohen
Go back to only deferring body creation per component. This can now use the slow path when needed. Can't support deferring of multiple components without changing locking API so we'll do that in the future.
#JIRA UE-36535, UE-36504
Change 3150355 on 2016/10/04 by Zak.Middleton
#ue4 - Change checkSlow() to check() in GetDefaultObject<> because this is potentially an unsafe static cast.
Change 3150370 on 2016/10/04 by Ori.Cohen
Fix deferred actors not getting flushed.
Change 3150386 on 2016/10/04 by Martin.Wilson
Fix additive animation check failing in cooked builds when using virtual bones
#jira UE-36743
Change 3150424 on 2016/10/04 by Ori.Cohen
Exclude kinematic actors from active transforms generation.
Change 3150613 on 2016/10/04 by Zak.Middleton
#ue4 - Fix bad GetDefaultObject<> in AbilitySystemGlobals. Turned up since changing checkSlow() to check() in GetDefaultObject.
(Mirror CL 3138304 in Orion-DevGeneral)
#jira UE-36810
#tests compiled
Change 3150679 on 2016/10/04 by Ben.Zeigler
Crash fix with no async scene
Change 3150765 on 2016/10/04 by Ben.Zeigler
Deprecate UStructProperty::ExportTextItem_Static and ImportItem_Static, and add ExportText and ImportText directly to UScriptStruct
Add bAllowNativeOverride to specify rather to call the native override. For unclear reasons the static export skipped the native override while the static import included it
This allows calling the generic ImportText from inside a native ImportTextItem and then doing some post processing
Change 3150796 on 2016/10/04 by Marc.Audy
Fix LOCTEXT warnings related to blueprint class menu options
Change 3150806 on 2016/10/04 by Ben.Zeigler
Fix bad text format in import error message, lead to double error
Change 3150891 on 2016/10/04 by Ben.Zeigler
#jira UE-36170 Fix duplicate GUID spam when async loading levels during PIE by checking the package flag instead of the runtime global
Change 3150914 on 2016/10/04 by Marc.Audy
Don't try to recreate render state if it has already been recreated while the recreate context was active
#jira UE-36590
Change 3151195 on 2016/10/04 by Dan.Reynolds
Updates to QASoundWaveProcedural
QASoundWaveProcedural edited to be a GameplayStatic which spawns an Audio Component Handler as well as a Procedural Sound Wave. Support for envelope shaping (Attack, Sustain, Release) as well as multiple waveforms (Sine, Triangle, Sawtooth, Square). Blueprint API expanded to include separate functions for setting QASoundWaveProcedural settings and Playing.
Change 3151233 on 2016/10/04 by Ben.Zeigler
#jira UE-36836 Fix variable shadowing warnings
Change 3151328 on 2016/10/04 by dan.reynolds
AEOverview Update - Added Sound Wave Procedural test map and added support for mobile (tested on Android) menu selection - Still a WIP
Change 3151461 on 2016/10/05 by Thomas.Sarkanen
Fix localization warnings
#jira UE-36720 - //UE4/Main: Step 'Build Engine Localization' - 2 Warnings
Change 3151546 on 2016/10/05 by Martin.Wilson
Fix pose watch regression due to persona refactor changes.
#jira UE-36851
Change 3151587 on 2016/10/05 by Jurre.deBaare
Updating Simplygon to SDK version 8.0
#misc removed redundant files
#misc fixed landscape culling in merge actor path
#misc added support for volume culling using simplygon
#misc fixed when or not to use mesh data for material baking
#notes
Change: 3137650
Date: 23/09/2016 07:57
Client: Mustafa.Tungekar_Dev-Partner-Simplygon
User: Mustafa.Tungekar
Status: submitted
Type: restricted
ImportedBy:
Identity:
Description:
-Renamed commandline variables for ZipUtils AutomationScript
-Implemented Execute instead of ExecuteBuild
-Updated commandline arguments in SimplygonSwarm
JobStatus:
Jobs:
Files:
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Private/SimplygonSwarm.cpp#4
//UE4/Dev-Partner-Simplygon/Engine/Source/Programs/AutomationTool/Scripts/ZipUtils.Automation.cs#2
Change: 3137649
Date: 23/09/2016 07:56
Client: Mustafa.Tungekar_Dev-Partner-Simplygon
User: Mustafa.Tungekar
Status: submitted
Type: restricted
ImportedBy:
Identity:
Description:
Moved file hash computation to ImportObject
JobStatus:
Jobs:
Files:
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Classes/Factories/Factory.h#4
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Private/Factories/Factory.cpp#4
Change: 3137646
Date: 23/09/2016 07:55
Client: Mustafa.Tungekar_Dev-Partner-Simplygon
User: Mustafa.Tungekar
Status: submitted
Type: restricted
ImportedBy:
Identity:
Description:
Fixes CL3099204
EditorPerProjectUserSetting
Removed ConfigRestartRequired attribute from properties where it was not required
MeshUtilities
-Added FProxyFailedDelegate
-Extended IMeshMerging to include FProxyFailed delegate
-Added ProxyGenerationFailed method to FProxyGenerationProcessor class
-Setup FailedDelegate for both MeshMerging and DistributedMeshMerging
SimplygonMeshReduction
-Added check for invalid texture id
-Updated notes and removed commented code that is not required.
-Setup failed delegate
-Fixed issue where image data was never hooked into the texture.
-Fixed issue where texture table was never passed into casters
SimplygonSwarm
-Setup failed delegate
-Fixed RawMesh pointer usage.
-Move helper method into SimplygonSwarmHelpers.h.
-Added SimplygonSwarmHelpers
-Removed redundant constant path to 7-zip
-Removed GetSimplygonDirectory instead using inplace.
-Removed commented code that is currently not required.
-Fixed Typos
JobStatus:
Jobs:
Files:
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/MeshUtilities/Private/MeshUtilities.cpp#3
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/MeshUtilities/Public/MeshUtilities.h#3
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonMeshReduction/Private/SimplygonMeshReduction.cpp#4
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Private/SimplygonSwarm.cpp#3
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Public/SimplygonSwarmHelpers.h#1
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Classes/Editor/EditorPerProjectUserSettings.h#3
Change: 3099204
Date: 24/08/2016 07:56
Client: Mustafa.Tungekar_Dev-Partner-Simplygon
User: Mustafa.Tungekar
Status: submitted
Type: restricted
ImportedBy:
Identity:
Description:
Simplygon 8.0 Updates
Deprecated support for 7.0 and updated SimplygonSwarm and SimplygonMeshReduction to use 8.0
EditorPerProjectSettings
*SwarmMaxUploadChunkSizeInMB for limiting the max upload size for swarm. Note the Simplygon Grid has a limitation of 2GB
*SwarmNumOfConcurrentJobs for executing number of concurrent jobs
*Fixed issue where SG_MATERIAL_CHANNEL_METALLIC to SG_MATERIAL_CHANNEL_METALNESS (Chage in 8.0 SDK)
SPL, SimplygonSwarm, RESTClient
*Bumped up SPL Version to 8
*Fixed code paths to use ZipUtils UAT script for zipping and unzipping CL3094374
*Removed SPL Templates for version 7.0
*Added conditional logging to REST methods
*Added multi part upload. The RESTClient automatically decided if large files need to be split up before uploading to simplygon grid.
*Updated method to take in texturepath
SimplygonMeshReduction
*Removed minimum version requirement.
*Bumped up minimum version
*Chagned license file name to refelect 8.0 changes
*MaterialBaking related method now take in TextureTable as an extra parameter. This is due to 8.0 move away from old way of setting up materials and using SimplygonShadingNetowrk based appraoch.
JobStatus:
Jobs:
Files:
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonMeshReduction/Private/SimplygonMeshReduction.cpp#3
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonMeshReduction/Public/SimplygonTypes.h#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Private/SimplygonRESTClient.cpp#3
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Private/SimplygonSwarm.cpp#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Public/SimplygonRESTClient.h#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Public/SimplygonSwarmPrivatePCH.h#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Classes/Editor/EditorPerProjectUserSettings.h#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Private/Settings/EditorPerProjectUserSettings.cpp#2
Change: 3099200
Date: 24/08/2016 07:48
Client: Mustafa.Tungekar_Dev-Partner-Simplygon
User: Mustafa.Tungekar
Status: submitted
Type: restricted
ImportedBy:
Identity:
Description:
#fix Copy constructor for FMeshReduciton mapped ShadingImportance to SilhouetteImportance
JobStatus:
Jobs:
Files:
//UE4/Dev-Partner-Simplygon/Engine/Source/Runtime/Engine/Classes/Engine/MeshMerging.h#2
Change: 3099199
Date: 24/08/2016 07:47
Client: Mustafa.Tungekar_Dev-Partner-Simplygon
User: Mustafa.Tungekar
Status: submitted
Type: restricted
ImportedBy:
Identity:
Description:
Added Automation Script ZipUtils to zip file and unzip files from SimplygonSwarm.
This will remove any dependency on external zip program and should work across platforms
JobStatus:
Jobs:
Files:
//UE4/Dev-Partner-Simplygon/Engine/Source/Programs/AutomationTool/Scripts/AutomationScripts.Automation.csproj#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Programs/AutomationTool/Scripts/ZipUtils.Automation.cs#1
Change: 3099197
Date: 24/08/2016 07:40
Client: Mustafa.Tungekar_Dev-Partner-Simplygon
User: Mustafa.Tungekar
Status: submitted
Type: restricted
ImportedBy:
Identity:
Description:
*Speed improvements for FBX Scene Importer
*Added a static method to compute Hash.
JobStatus:
Jobs:
Files:
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Classes/Factories/Factory.h#3
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Private/Factories/Factory.cpp#3
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Private/Fbx/FbxStaticMeshImport.cpp#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Runtime/Engine/Classes/EditorFramework/AssetImportData.h#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Runtime/Engine/Private/EditorFramework/AssetImportData.cpp#2
Change 3151664 on 2016/10/05 by Richard.Hinckley
Fixing ACharacter template for "New C++ Class" feature. Avoiding naming a function parameter the same as an existing class member.
Change 3151729 on 2016/10/05 by Thomas.Sarkanen
Audit of remaining NaN checks
Some checks remain on in shipping (generally those called from blueprint):
- AActor::TeleportTo
- AActor::SetActorRelativeScale3D
#jira UE-30999 - Optimize ⌠ContainsNaN÷ and ⌠ContainsNaNOrInfinite÷, audit those still in shipping/test
Change 3151742 on 2016/10/05 by Ori.Cohen
Make sure that if physical animation component doesn't find a body and bone it doesn't crash.
#JIRA UE-36839
Change 3151756 on 2016/10/05 by Jurre.deBaare
Fixing d3dcompiler_47.dll missing issue
#fix added runtime dependency and dll name to build.cs file
#fix now load the d3dcompiler_47.dll from the Binaries/ThirdParty/Windows folder before loading the simplygon DLL
Change 3151761 on 2016/10/05 by Thomas.Sarkanen
Fix deprecation warning from last integration
Moved Preview to EditorPreview in FEditorWorldManager::OnWorldContextAdd.
#jira UE-36858 - Compile UE4Editor* completed with 1 warning
Change 3151782 on 2016/10/05 by Jurre.deBaare
Simplygon patch up
#misc linker errors popping up from JSONCPP
#misc incorporated emissive material property fix from other shelve
#misc static analysis fix
Change 3151804 on 2016/10/05 by Marc.Audy
Clear need end of frame update when unregistering a component
Change 3151928 on 2016/10/05 by Ori.Cohen
Fix runtime DLLs not including all delay loaded physx dll files.
#JIRA UE-36816
Change 3151977 on 2016/10/05 by Martin.Wilson
Notifies can no longer occupy the same time on the same track.
#jira UE-30658
Change 3151989 on 2016/10/05 by Jon.Nabozny
Fix ArchVis character rotation pitch when looking up/down.
#jira UE-35706
Change 3152083 on 2016/10/05 by Marc.Audy
Ensure that pending kill components get their marked for end of frame state cleared.
Change 3152086 on 2016/10/05 by Ben.Zeigler
#jira UE-36169 Fix it so missing linker errors that point to Blueprint CDOs are skipped, the same way it skips linker errors going to the actual class. Fixes a lot of spurious warnings from deleting components from blueprints or native classes
Clean up the VerifyImport error handling so it also displays in -game and cook, and fix the missing class warning to work properly, previously it would happen 0% in development 100% in debug even if the class was valid
Change 3152093 on 2016/10/05 by Marc.Audy
Change logic for when location cannot be changed for a static component to be independent of has begun play and have to do with whether construction script is running or the level is in the process of loading (mostly for backwards compatibility adjustments in post load).
#jira UE-36146
#jira UE-24647
Change 3152100 on 2016/10/05 by Ben.Zeigler
Remove pragma optmize
Change 3152112 on 2016/10/05 by Marc.Audy
Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3152072
Change 3152134 on 2016/10/05 by Jurre.deBaare
Simplygon/Merge actor issues
#fix for emissive output on meshes that do not have emissive properties
#fix for texture binning, not removing invalid split area causing overlapped textures
Change 3152136 on 2016/10/05 by James.Golding
UE-36859 Fix tooltip saying you can click to stop recording
Change 3152169 on 2016/10/05 by James.Golding
UE-31209 UE-30935 : Expose bDeformableMesh and bFastCook options in FTriMeshCollisionData
ProceduralMeshComponent will now cook using 'fast' and 'deformable' options, so updating collision on sections should work correctly
Change ERuntimePhysxCookOptimizationFlags to EPhysXMeshCookFlags and use that to pass options to CookConvex and CookTriMesh
Change 3152202 on 2016/10/05 by Jurre.deBaare
Mac/Linux fix
Change 3152303 on 2016/10/05 by Marc.Audy
Fix deprecation warning post merge from main
Change 3152320 on 2016/10/05 by Martin.Wilson
Fix root motion from everything calculating incorrect root motion when animations haven't been ticking
#jira UE-35364
Change 3152354 on 2016/10/05 by James.Golding
PoseDriver should pass through if no poses activated
Change 3152357 on 2016/10/05 by James.Golding
UE-36844 Remove unused OnAssetModifiedNotifier delegate from PoseAsset, ensure OnPoseListChanged is called when updating PoseAsset from anim.
Change 3152556 on 2016/10/05 by Marc.Audy
Remove autos
Change 3152560 on 2016/10/05 by Marc.Audy
Don't allow child actor references to be dragged from the outliner to a level script
#jira UE-16700
Change 3152568 on 2016/10/05 by Marc.Audy
Don't allow non-networking code to set bRemoteOwned in the actor spawn parameters
Remove deprecated bNoCollisionFail
#jira UE-35928
Change 3152575 on 2016/10/05 by Marc.Audy
Allow construction script to run post move for native classes. Actor can determine whether it should only occur on finish or every call to post edit move
Change 3153101 on 2016/10/06 by Thomas.Sarkanen
Fix crash re-opening the viewport in Persona-based editors
#jira UE-36775 - Editor crashes when re-opening viewport in Persona
Change 3153139 on 2016/10/06 by James.Golding
UE-36908 Remove GetRuntimeOnlyCookOptimizationFlags if cooking is not supported
Change 3153160 on 2016/10/06 by Thomas.Sarkanen
Fix for crash when deleting additive layer track
Code had not been updated to use the new delgate system (was still using reciprocal FPersona ptr).
#jira UE-36740 - Crash when removing or disabling an additive layer track in Persona
Change 3153175 on 2016/10/06 by Benn.Gallagher
Fixed crashes when using subinstances in non-default states. we previously initialized the anim instances in the node initialize, but in states that haven't been hit by an initialize this will happen off the game thread which is not allowed.
#jira UE-36900
Change 3153223 on 2016/10/06 by Thomas.Sarkanen
Fixed crash when opening an asset from the blend space editor
Code was still trying to open 'old' Persona when it was disabled.
Also fix other call sites where this was being done outside of asset type actions.
#jira UE-36766 - Crash attempting to open an asset from Aim Offset graph in Persona
Change 3153324 on 2016/10/06 by Thomas.Sarkanen
Prevented invalid GUIDs from being saved into smart name containers
AddOrFindName now checks to see if existing GUIDs are valid before using them.
AddName now requires a valid GUID to be passed in.
Also added Modify() call to the skeleton when FindOrAddSmartName is called from VerifySmartNameInternal, as without this the skeleton might not get saved.
Also add Laurent's fix for fixing up already-saved invalid GUIDs (CL 3138068).
#jira UE-36367 - It is possible for curves with an invalid GUID to be saved into the USkeleton asset
Change 3153348 on 2016/10/06 by Martin.Wilson
Re add ticking code so all Persona editors viewports tick during drag events (went missing in Persona refactor)
#jira UE-36751
Change 3153426 on 2016/10/06 by Mieszko.Zielinski
Added missing elements of block comments support in BT editor #UE4
Change 3153454 on 2016/10/06 by Benn.Gallagher
Fixed crash using anim debug with subinstances that are preceded by branching nodes.
#jira UE-36935
[CL 3153517 by Ori Cohen in Main branch]
2016-10-06 12:11:11 -04:00
# endif // ENABLE_ANIM_DEBUG && ENABLE_DRAW_DEBUG
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
}
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3362413)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3281394 on 2017/02/01 by Chad.Garyet
one more try on the name here, with the extension this time
Change 3286009 on 2017/02/03 by Jon.Nabozny
Fix SkelMeshMerge duplicating Skeleton sockets.
#jira UE-39690
Change 3288374 on 2017/02/06 by Jon.Nabozny
Fix MaterialIndex checks in USkinnedMeshComponent::GetMaterial
Change 3288640 on 2017/02/06 by Jon.Nabozny
#rn Fix UPhysicsConstraintComponent details to allow modification of MaxForce, Stiffness, and Damping for Linear and Angular constraints.
#jira UE-40261
Change 3288978 on 2017/02/06 by Jon.Nabozny
Add code to debug for duplicate sockets in UQAMeshMergeComponent::MergeMeshes.
Change 3290332 on 2017/02/07 by Marc.Audy
Add AnimPhys object version
Change 3290753 on 2017/02/07 by Jon.Nabozny
Update CoM documentation for CoM offset.
#jira UE-40136
Change 3290783 on 2017/02/07 by Jon.Nabozny
Update mass dependent wheel properties in UWheeledVehicleMovementComponent when mass is updated.
#jira UE-39820
Change 3292286 on 2017/02/08 by Jon.Nabozny
Fix OSSNull query filtering.
#codereview: John.Pollard, Josh.Markiewicz, JohnHenry.Carawon
#jira: UE-37512
Change 3294138 on 2017/02/09 by Thomas.Sarkanen
Add more descriptive name for sub-struct members in property tracks
Change 3294139 on 2017/02/09 by Thomas.Sarkanen
Moving to individual structs for limbs
Change 3294140 on 2017/02/09 by Thomas.Sarkanen
Updated base human asset to reflect limb changes
Updated map to just contain the mannequin for now
Updated Sequence to contain some default IK keys
Change 3294178 on 2017/02/09 by Thomas.Sarkanen
Fix shadow variable warning
Change 3294554 on 2017/02/09 by Thomas.Sarkanen
Fixed persistent limb drift issues with non-participant bones
Still have rotational drift with IK chain nodes (still to fix).
Also fixes the addition of initial keys on binding when animating.
Also fixes not being able to pick the widget sometimes when picking nodes in the tree.
Change 3294826 on 2017/02/09 by Chad.Garyet
fixing up busted defaultvalues on physx and precompiled binaries
Change 3294827 on 2017/02/09 by Thomas.Sarkanen
CIS fixes for non-editor and monolithic builds
Change 3296363 on 2017/02/10 by Thomas.Sarkanen
Fix bone drifting
Re-using local transforms then resetting each update pass was accumulating error (via GetRelativeTransform), causing limbs to drift. To address this, simply set the global transform in the case where we know the local transform wont change.
Also optimized the hierarchy API a little & prevented excess work when nothing changes.
Change 3296393 on 2017/02/10 by James.Golding
Add support for clicking on PoseDriver targets in viewport
Change 3296465 on 2017/02/10 by Thomas.Sarkanen
Removed component visualizer (no longer used)
Change 3296467 on 2017/02/10 by Thomas.Sarkanen
Fixed extra keys being made when switching IK/FK mode. Now we only key on user action.
Added ability to hide nodes (advanced setting) and manipualtors (on playback)
Change 3296554 on 2017/02/10 by Thomas.Sarkanen
Fixed up some workflow issues
Widget visibility and the ability to move actors around is now corrected by calling the base FEdMode class functions appropriately.
Added a focus of the chosen actor so orbiting the actor is easier. There is a hitch when we do this (probably because Sequencer is re-initialized the next frame), so we miss the nice transition.
Change 3296621 on 2017/02/10 by Thomas.Sarkanen
Added ability to specify manipulator type when adding
Not exposed in the 'add' UI yet, just enough to allow me to batch-change the ones we have for now
Also tweaked default extents for box manipulators.
Change 3296622 on 2017/02/10 by Thomas.Sarkanen
Changed FK manipulators to boxes
Change 3296740 on 2017/02/10 by James.Golding
Added bOnlyDriveSelectedBones option to PoseDriver
Change 3296957 on 2017/02/10 by James.Golding
Fix AnimNode_PoseHandler using mesh bone index not compact bone index for setting up BoneBlendWeights array
Change 3297092 on 2017/02/10 by Jon.Nabozny
#rn Fix InstancedStaticMesh not properly creating physics state when Stationary.
#JIRA UE-39876
Change 3297160 on 2017/02/10 by Ori.Cohen
Temp fix for physx immediate mode crashing when 0 rows are generated.
Change 3297203 on 2017/02/10 by Ori.Cohen
Temp fix for immediate mode crash when free joints are batched together
#JIRA UE-41026
Change 3297326 on 2017/02/10 by Jon.Nabozny
PR #2965: Update comments in several classes within demo projects to match style present and provide more detail for new users (Contributed by Markyroson)
Changed some of the comment blocks to multiple single line (inside definitions). This is for consistency with our codebase.
#JIRA UE-38981
Change 3297618 on 2017/02/10 by Charles.Anderson
Arcblade - GDC
- Created a new mor polished Phat for this. Probably not gonna use it.
- Created a Ragdoll asset. Need to talk to Ori about getting it working better.
Change 3297799 on 2017/02/10 by mason.seay
Test map for testing audio attenuation
Change 3297940 on 2017/02/10 by Jon.Nabozny
#rn Fix ConstraintComponentVisualizer with AngularOffset.
Needed to apply local transform before world.
#JIRA UE-39597
Change 3297947 on 2017/02/10 by Chad.Garyet
adding automated test build option
Change 3299203 on 2017/02/13 by Thomas.Sarkanen
Fixed local coord system issues with rotation (etc).
Delta transforms are supplied in the space we specify in GetCustomDrawingCoordSystem(), so we now perform our operations in that space, then convert back when applying to the animation.
Fixed up to allow for animating actors with transformed skeletal mesh components.
Also added some proximity scaling to manipulators.
Change 3299220 on 2017/02/13 by Thomas.Sarkanen
Fixed CIS missing include
Change 3299343 on 2017/02/13 by Lina.Halper
Spine twist/roll check in
- control points are disabled
#rb: Thomas.Sarkanen
Change 3299388 on 2017/02/13 by James.Cobbett
Updating QA-Physics map
Change 3299518 on 2017/02/13 by Lina.Halper
fix build issue
#rb: none
Change 3299701 on 2017/02/13 by Ori.Cohen
Add finer grain physx stat information.
Change 3299894 on 2017/02/13 by Ori.Cohen
Added LOD support for immediate mode physics
Change 3299906 on 2017/02/13 by James.Cobbett
Updating QA-Collision map with new test scenarios
Change 3299962 on 2017/02/13 by Ori.Cohen
Fix shadow warning
Change 3300100 on 2017/02/13 by Lina.Halper
- renamed Constraint Axes option to FFilterOptionPerAxis : was going to reuse it for something else but didn't have to but left name changed because it makes more sense
- enable control point reading part
- twist/roll controll is localspace reader - BaseHuman
#rb: none
#code review:Thomas.Sarkanen
Change 3300206 on 2017/02/13 by Ori.Cohen
Rename Ragdoll node to RigidBody node
Change 3300899 on 2017/02/13 by Alan.Noon
Migrating Paragon Origin and Origin Small maps content.
Change 3301279 on 2017/02/14 by Jurre.deBaare
Mesh paint refactor
Change 3301288 on 2017/02/14 by Jurre.deBaare
Incremental CIS fixes
Change 3301290 on 2017/02/14 by Jurre.deBaare
Another CIS fix
Change 3301311 on 2017/02/14 by Thomas.Sarkanen
Fixed non-editor builds
Change 3301313 on 2017/02/14 by Jurre.deBaare
More CIS fixes
Change 3301315 on 2017/02/14 by Jurre.deBaare
Include CIS fix
Change 3301333 on 2017/02/14 by Jurre.deBaare
Non-Unity CIS fixes
Change 3301388 on 2017/02/14 by Benn.Gallagher
CIS fix for cloth create panel
Change 3301445 on 2017/02/14 by Benn.Gallagher
Last few changes over from the mesh paint branch
hooked up LOD dropdown box
Moved asset selection out of details panel
Change 3301527 on 2017/02/14 by mason.seay
Deleting unneeded map
Change 3301531 on 2017/02/14 by mason.seay
Renaming Map to fix naming scheme
Change 3301558 on 2017/02/14 by Ori.Cohen
Fix physx stats not being counted properly as we were not using static data.
Change 3301604 on 2017/02/14 by Ori.Cohen
Fix static analysis warning
Change 3301615 on 2017/02/14 by Jurre.deBaare
All. The. CIS. Fixes
Change 3301630 on 2017/02/14 by mason.seay
Updating Map for testing
Change 3301697 on 2017/02/14 by mason.seay
Final change to map
Change 3301734 on 2017/02/14 by Jurre.deBaare
- Crash CTRL-Z when having cloth painter and paint mode open
- Fill action not being undo-able
- Import vertex colors should default to to-instance
- Paint mode buttons in level painter are now toggle buttons (clarifies UI for user)
Change 3301763 on 2017/02/14 by Jurre.deBaare
- Fix for asset without engine version
- Fix for crash due to missing skeletal mesh permutation in mesh paint view modes
Change 3302421 on 2017/02/14 by Lina.Halper
Fixed issue where spline gets incorrect position when it has many control points.
#rb: Thomas.Sarkanen
Change 3302667 on 2017/02/14 by Lina.Halper
- added spine control points to work
- FK/IK switch isn't working great yet. Don't try
- disabled all twist/roll handling since control point itself can twist also and they were conflicting each other
- added option to add fk nodes, change parnets
- fixed issue with drawing skeleton drawing, when parents weren't added yet.
- Added neck/head/body control
#code review: Thomas.Sarkanen
#rb: none
Change 3303200 on 2017/02/14 by Alan.Noon
Collision shapes for Immediate Mode Ragdolls
Change 3303201 on 2017/02/14 by Alan.Noon
Adding Origin, Full Map
Change 3303477 on 2017/02/15 by James.Golding
Add Get and SetComponentForAxis to FVector and FRotator
Change 3303478 on 2017/02/15 by James.Golding
Add support for multiple source bones to PoseDriver
Change 3303480 on 2017/02/15 by James.Golding
Added per-scene frame number, handles cases like motion blur caching.
Refactored GPUSkinCache to have an explicit frame advance function, called after all viewports have rendered in game/editor, PostRenderAllViewportClients.
(Original author Chris.Bunner)
Change 3303513 on 2017/02/15 by Jurre.deBaare
CIS: Linux file name case fixes and incorrect pragma once
Change 3303576 on 2017/02/15 by Thomas.Sarkanen
Sub-sequence sections can now override how they instance their template
Added UMovieSceneSubSection::GenerateTemplateForSubSequence. This just performs the original call to SubSequenceStore.GetCompiledTemplate in the dcefault case.
Allowed non-const access to FMovieSceneEvaluationTemplate::GetTracks so they can be potentially modified once instanced.
Added access for FMovieSceneEvaluationTrack::ChildTemplates.
Change 3303578 on 2017/02/15 by Thomas.Sarkanen
Rich curves can now be transformed post-copy correctly
Using GetKeyIterator rather than aquiring the iterator directly makes sure we have valid key handles, which we dont if we have just copied the curve.
Change 3303579 on 2017/02/15 by Thomas.Sarkanen
Added GetLinkNode to complement SetLinkNode in FAnimNode_Base
Change 3303580 on 2017/02/15 by Thomas.Sarkanen
Made the logic around when sub-tracks can be primed for recording more specific
Prevents rig control sub tracks form being able to be primed.
Change 3303581 on 2017/02/15 by Thomas.Sarkanen
Allowing alpha on rig tracks to work
Alpha curve is now pushed down to tracks on template compilation along with bone masks & additive flag.
Sequencer anim instance updated to use new flags. Structure altered to accomodate layered blending for masked body parts (should probably push this to the regulat sequence instance too).
Moved anim node to local space (now it is just derived form FAnimNode_Base).
Also fixed opening/binding order issues - Now you should be able to open a sequence, bind to an actor and create a new rig control in a sequence in any order.
Change 3303582 on 2017/02/15 by Thomas.Sarkanen
Fixed UE4Game CIS - Moved AddConstraint() to non-editor-only
Also fixed crash in property chain iteration (for non-existent array properties)
Change 3303594 on 2017/02/15 by Jurre.deBaare
Fix for crash on deleting painted actors
Change 3303636 on 2017/02/15 by Lina.Halper
-remove temp code to add constraints. - they serialize, so once you add them you don't have to add these anymore.
This will move to editor menu soon.
#rb: none
Change 3303648 on 2017/02/15 by Martin.Wilson
Fix reimport crashes if the animation uses additive transform tracks.
#jira UE-41929
#jira UE-41921
Change 3303652 on 2017/02/15 by Benn.Gallagher
Added merged Ice mesh with new simulation mesh to match mesh from APEX version.
Change 3303660 on 2017/02/15 by Benn.Gallagher
map update for clothing demo
Change 3303662 on 2017/02/15 by Benn.Gallagher
State machine update for Ice anim
Change 3303676 on 2017/02/15 by mason.seay
Adjusted sound actor location
Change 3303689 on 2017/02/15 by Benn.Gallagher
Updated Ice mesh to have clothing present on the back part of the dress
Change 3303691 on 2017/02/15 by Jurre.deBaare
CIS fixes for pose driver details
Change 3303704 on 2017/02/15 by Lina.Halper
Add FK limb links
- enabled temp code to add constraints. It's not serialized from BP editor, so this has to be added everytime. Will fix this in the futre check-ins
#rb:none
Change 3303716 on 2017/02/15 by Thomas.Sarkanen
Updated manipulators to always draw in front of the mesh
Added material & enabled content for the plugin.
Change 3303730 on 2017/02/15 by thomas.sarkanen
Resaving manipulator material with correct engine version
Change 3303754 on 2017/02/15 by Thomas.Sarkanen
Fix manipulators popping to max size when manipulating
Change 3303835 on 2017/02/15 by Thomas.Sarkanen
Fix hitch by not displaying spawned objects if we dont have a sequence focused.
Change 3303843 on 2017/02/15 by Lina.Halper
Added normalize rotation on inputs/outputs
#code review: Thomas.Sarkanen
#rb: none
Change 3303916 on 2017/02/15 by Jurre.deBaare
CIS: Linux incorrect pragma once
Change 3304084 on 2017/02/15 by James.Golding
Update pose driver test after addition of multi-bone input
Change 3304188 on 2017/02/15 by James.Golding
Add custom remap curve option per-target in PoseDriver
Change 3304189 on 2017/02/15 by James.Golding
Fix CIS for ControlManipulator.cpp
Change 3304210 on 2017/02/15 by Alan.Noon
Added hidden collision objects for stairs area. Added brighter lighting on plinth area. Hooked up minion placement randomization. Added 100 minions to minion level for ragdol
Change 3304327 on 2017/02/15 by Alan.Noon
Created new Persistent levels for each Anim Tech demo, which loads in Origin_Small_P
Change 3304337 on 2017/02/15 by Alan.Noon
renamed minion demo level for GDC
Change 3304508 on 2017/02/15 by Lina.Halper
- You can see constraints in the tree view (full edit mode)
- YOu can add or update constraints (using update constraints button)
- You can delete constraints
- Cleaned up constraints interface
#rb: none
#code review: Thomas.Sarkanen
Change 3304537 on 2017/02/15 by chris.evans
!N Initial PSD test [chrise]
Change 3304551 on 2017/02/15 by James.Golding
Fix missing 'break's from SetComponentForAxis in FVector and FRotator
Change 3304570 on 2017/02/15 by Chris.Evans
!N Source assets for psd test
#RB none
Change 3304964 on 2017/02/15 by Lina.Halper
fix build issue
#code review: James.Golding
#rb: none
Change 3304998 on 2017/02/15 by Chris.Evans
!B Checking in correct FBX
#RB none
Change 3305314 on 2017/02/15 by chris.evans
!N Adding materials driven
!N Adding 'simulation' animation which simulates the driven result
Change 3305355 on 2017/02/15 by chris.evans
!N Initial test shoulder pose
Change 3305357 on 2017/02/15 by chris.evans
!N Initial Mambo shoulder ROM
Change 3305446 on 2017/02/15 by Lina.Halper
fixed CIS error
#rb: none
#code review: Thomas.Sarkanen
Change 3305768 on 2017/02/16 by Jurre.deBaare
CIS: Clang compile errors
Change 3305857 on 2017/02/16 by thomas.sarkanen
Removed particle systems from top plinth as they interfere with selection and obscure demo somewhat.
Change 3305907 on 2017/02/16 by Thomas.Sarkanen
Fix hitches on selection of multiple keys
Prevented multiple seleciton callbacks being called for each key (we now just edit the selection then broadcast later).
Dont force the details panel to refresh if nothing has changed.
Make sure we make a list of unique object IDs when processing the selection delegate, as we get an object ID per track.
Change 3305910 on 2017/02/16 by Thomas.Sarkanen
Allow multiple instances ot the same parameterized subsequence to exist and function correctly
Subsequences in the store are now keyed off an optionally specified 'other' object. In the case of parameterized subsequences, this object is the section.
Editor only right now - cooked builds are still to come
Change 3305911 on 2017/02/16 by Thomas.Sarkanen
Fix NaNs from uninitialized poses
Change 3305922 on 2017/02/16 by Thomas.Sarkanen
BuiltData for Origin_Small_P
Change 3305927 on 2017/02/16 by Thomas.Sarkanen
Moved ControlRig->ControlRigDemo in preparation for keeping all assets in one folder
Added some test assets
Change 3305928 on 2017/02/16 by Thomas.Sarkanen
Dont select actors when we bind to them
Selection can sometimes look bad and obscure the character.
Change 3306118 on 2017/02/16 by Thomas.Sarkanen
CIS fix
Change 3306230 on 2017/02/16 by Jurre.deBaare
CIS fix for linking errors on specific platforms
#test compile PS4 OrionGame
Change 3306378 on 2017/02/16 by Martin.Wilson
First pass Live Link system (Initially from //Tasks/UE4/Dev-Causeway)
- Live Link Maya plugin build files (builds a .mll file that can be loaded into Maya)
- Live Link Interface (editor module with interface files)
- Live Link Message Bus Framework (editor module with files needed for building message bus based live link plugins)
- Live Link (experiemental plugin that contains editor part of live link system)
Change 3306388 on 2017/02/16 by Lina.Halper
- build issue fix
- also tweaked display name to display only node name in editing mode
#rb: none
Change 3306455 on 2017/02/16 by Jon.Nabozny
#rn Perf improvements to FAnimNode_RigidBody.
Cache bounds to prevent unnecessary overlap updates.
Move overlaps off game thread.
Change 3306591 on 2017/02/16 by Martin.Wilson
Updates to live link
- Copyright changes (some were still 2016)
- Rename BlankMayaPlugin to LiveLinkMayaPlugin
Change 3306907 on 2017/02/16 by Jon.Nabozny
MinionDemo Content Perf Pass.
Change 3306914 on 2017/02/16 by Thomas.Sarkanen
Back out changelist 3305857 and 3305922
Reverts particle system changes to Origin_Small_P
Change 3306942 on 2017/02/16 by Martin.Wilson
Live link demo content
-Feng mao mesh that matches maya scene
- LiveLinkGDC Map
- Beginning of camera control sequencer
Change 3307154 on 2017/02/16 by Alan.Noon
Merged in new content to fix badly collapsed BP Static meshes deleted ragdoll minions for new posing. Stopped animation on spawn pad materials
Change 3307382 on 2017/02/16 by Martin.Wilson
Fix CIS (Add virtual destructor to ILiveLinkSource)
Change 3307497 on 2017/02/16 by chris.evans
!N Moving mats
Change 3307541 on 2017/02/16 by Chris.Evans
!B Rebuilding test assets with new skeleton
Change 3307873 on 2017/02/16 by Chris.Evans
!N Mambo updates
Change 3307875 on 2017/02/16 by Chris.Evans
!R Update to blueprint
Change 3308030 on 2017/02/16 by Alan.Noon
Changed lighting of Origin_Small_P based on feedback. Placed new objects were previous were exhibiting bad lightmaps.
Change 3308246 on 2017/02/16 by Alan.Noon
Consolidated new lighting content from sublevels into Origin_Small_P. Hooked up Physics asset to ArcBlade Skeletal mesh
Change 3308470 on 2017/02/16 by Lina.Halper
- make sure all are hooked up properly to pelvis and spine_03
- no multiple pelvis anymore. Using one to tweak all of them. all limbs are connected through constraints
- make sure end effector rotation is modifying IK's last chain rotation
- had to hack for saving offset for IK/FK switch mode but it works fine
- fixed lots of constraint issue with deleting node, parent constraints. Added new spine after that fix.
#rb:none
#code review: Thomas.Sarkanen
Change 3308764 on 2017/02/17 by Jurre.deBaare
Fix for non-unity Orion game build
Change 3308774 on 2017/02/17 by Thomas.Sarkanen
Added multi-selection of manipulators
Allowed BoxSelect, FrustumSelect and SelectNone to be overriden by the edit mode. Our edit mode doesnt have a sub-tool, it handles everything itself.
Also fixed manipulators drawing in front of widget
Changed manipualtors to be world-relative rather than screen relative scaled.
Tweaked proximity to be stateful so we only highlight the closest node
Also fixed slow FPS when dragging.
Change 3308802 on 2017/02/17 by James.Golding
Fix 'apply custom curve' for pose driver targets being on by default
Change 3308824 on 2017/02/17 by Lina.Halper
Fix build issue
#code review:Thomas.Sarkanen
#rb: none
Change 3308851 on 2017/02/17 by James.Golding
Add new control manipulator picking UI
Change 3308863 on 2017/02/17 by Martin.Wilson
Enable Live Link plugin in AnimTechDemo
Change 3308880 on 2017/02/17 by Thomas.Sarkanen
Getting instanced subsequences working in cooked builds
Change 3309009 on 2017/02/17 by Benn.Gallagher
Mask support and UI, not hooked up to painter yet
Added clothing tools experimental flag and hooked up
Change 3309016 on 2017/02/17 by Martin.Wilson
Clean up engine provided output devices and supply a Maya one, stops Maya hanging on shutdown
Change 3309108 on 2017/02/17 by Jurre.deBaare
CIS fix: missing definition of FWeakObjectPtr (strangely not part of CoreMinimal)
Change 3309134 on 2017/02/17 by Jurre.deBaare
Crash in texure painting mode
#fix Required some extra checks for new setup (can only paint while having one mesh selected)
Issue with vertex paint propagating to lower LOD levels
#fix There was no setup to propagate colors from source static mesh data so added the path
#misc Re-added flow painting and removed flow-strength property
#misc Added detail customization for texture paint UV channel
Change 3309256 on 2017/02/17 by Benn.Gallagher
CIS fix
Change 3309393 on 2017/02/17 by James.Golding
Set color for kinematic controls
Change 3309410 on 2017/02/17 by Ori.Cohen
PR #3221: Kinematic body interpolation in substepping causes invalid raycasting/sweeping/overlapping (Contributed by PhoenixBlack)
Change 3309469 on 2017/02/17 by Benn.Gallagher
Added ContentExamples cloth assets
Added camera transitions and controls
Cleanup logic
Move characters and materials onto upper plinth
Hid actor mesh from game view.
Change 3309625 on 2017/02/17 by mason.seay
Resaving assets to remove warnings
Change 3309802 on 2017/02/17 by Alan.Noon
Modified Origin_Small_P lighting. Set up ArcBlade for presentation
Change 3309985 on 2017/02/17 by Thomas.Sarkanen
Fixed crash adding multiple rigs to sequence
If a hierarchy is empty, dont attempt to access a non-existent node
#jira UE-42103
Change 3310209 on 2017/02/17 by Lina.Halper
- Fix limbs detaching issues
- added set translation to override translation
- moved joint targets away from the limbs
- Spine FK is on by default
- spnie IK/FK switch should work better. It can still pop depending on your control point can handle or not.
#rb: none
Change 3310389 on 2017/02/17 by Chris.Evans
!N Mambo multi-joint pose demo
Change 3310911 on 2017/02/18 by Lina.Halper
Ice/Mambo mapping fix with BaseHuman
Change 3311138 on 2017/02/19 by James.Golding
- Allow multi-select in control picker
- Clicking on background clears selection
- Add 'Select All' button
- Darken controls that are disabled (is in different kinematic mode)
- Use selection color from control instead of outline
- Center and fit picker to details panel width
- Remove entire Nodes section of edit mode panel (not just tree)
- Fix rig properties not scrolling
- Place picker in expandable area, collapsed when no rig selected
Change 3311147 on 2017/02/19 by Thomas.Sarkanen
Fix spine keying
Add the ablity for array elements to be keyed directly. The spine properties are FTransforms in an array and previously it ignored them because of assumptions about allowed structures.
This should probably be refactored to a more generic 'traverse up my property chain looking for Interp properties' at some point in the future.
Change 3311150 on 2017/02/19 by Thomas.Sarkanen
Synchronizing sequencer selection
Now enter key works for keying selected tracks
Added new way to select sequencer tracks externally via property paths.
Change 3311152 on 2017/02/19 by Thomas.Sarkanen
Missed files
Change 3311153 on 2017/02/19 by Thomas.Sarkanen
CIS fixes
Change 3311154 on 2017/02/19 by Thomas.Sarkanen
File I missed (CIS fix)
Change 3311156 on 2017/02/19 by James.Golding
Change 'ControlRig Edit Mode' icon
Change 3311176 on 2017/02/19 by Lina.Halper
Fix build issue
#rb:none
#code review: Thomas.Sarkanen, Jurre.DeBarre, James.Golding
p.s. not sure who's code, so just adding everybody I can think of
Change 3311261 on 2017/02/19 by Lina.Halper
- Fixed an issue when you don't have parent in the rig
- get all component space, and convert to local
#rb:none
#code review: Thomas.Sarkanen
Change 3311282 on 2017/02/19 by Lina.Halper
Fixed issue where pivot location is incorrect when mapping to other meshes
#rb: none
#code review:Thomas.Sarkanen
Change 3311491 on 2017/02/20 by Thomas.Sarkanen
CIS fix
Change 3311497 on 2017/02/20 by Jurre.deBaare
Game editor compile error
#fix WITH_EDITORONLY_DATA instead of WITH_EDITOR ifdef around UPROPERTY
Change 3311507 on 2017/02/20 by Jurre.deBaare
Cloth paint progress
- Different approach / refactored out paint ray retrieval
- Added key input callback to IMeshPainter and derived classes
- Added toggle for showing invisible vertices
- Added gradient paint tool
- Details customization for brush/gradient tool settings
- Some cleaning
Change 3311527 on 2017/02/20 by Jurre.deBaare
CIS header guard warning
Change 3311530 on 2017/02/20 by Jurre.deBaare
CIS dereferencing possible nullptr warning
Change 3311533 on 2017/02/20 by Jurre.deBaare
CIS dereferencing warning (better fix)
Change 3311543 on 2017/02/20 by James.Golding
Add buttons for switching IK/FK mode of limb/spine to picker
Put picker and details panel in a scroll box
Fix spine manipulators not being hidden when disabled
Change 3311649 on 2017/02/20 by James.Golding
R key now toggles manipulator visibility
Change 3311707 on 2017/02/20 by Lina.Halper
Added Clavicle FK controls
#code review: Danny.Bouimad
Change 3311764 on 2017/02/20 by Martin.Wilson
Update cameras for Live link demo map and turn on recompute tangents on Feng Mao
Change 3311858 on 2017/02/20 by Chris.Evans
!R Updated with pose values
Change 3312043 on 2017/02/20 by Jon.Nabozny
Change SkelMeshMerge logic to fix duplicates (again) and fix crash.
#jira UE-39690, UE-42146
Change 3312046 on 2017/02/20 by Thomas.Sarkanen
Fix crash drag/dropping skeletal mesh
#jira UE-42139 - Crash when adding SK_Mannequin to a Level Sequence in QAGame
Change 3312052 on 2017/02/20 by James.Golding
Change manipulator colors to red for right, blue for left, white for middle
Change IK/FK switch buttons to yellow/purple
Move picker buttons to take up less horizontal space
Move IK/FK switch button positions out of C++
Change 3312137 on 2017/02/20 by Ben.Marsh
Fix settings for using precompiled binaries in Dev-AnimPhys.
Change 3312517 on 2017/02/20 by Alan.Noon
Created new persistent level for Chris E's demo. Placed a few minions for CharlesA to test improved ragdoll asset. Tuned lighting in Origin_Small_P and fixed light leaks.
Change 3312570 on 2017/02/20 by Charles.Anderson
More work on Arcblade Ragdoll for GDC
Change 3312594 on 2017/02/20 by Alan.Noon
MultipleJointPoseDriving_GDC_P_pose_test_level
Change 3312637 on 2017/02/20 by Alan.Noon
Reconciling offline content
Change 3312902 on 2017/02/20 by Charles.Anderson
Minions for GDC
Change 3313206 on 2017/02/20 by Ori.Cohen
Added trimesh support for immediate mode.
Change 3313247 on 2017/02/20 by Chris.Evans
!N updated with both demo assets in one map
Change 3313447 on 2017/02/20 by Ori.Cohen
Fix immediate mode collision not working with convex transforms being baked in
Change 3313472 on 2017/02/20 by Ori.Cohen
Fix crash caused by missing switch case break
Change 3313518 on 2017/02/20 by Lina.Halper
IK knee issue/Twist issue
#code review: Thomas.Sarkanen, James.Golding
#rb: none
Change 3313547 on 2017/02/20 by Lina.Halper
Fixed Body-Ctrl to work with every node.
Change 3313617 on 2017/02/20 by Lina.Halper
- Fix for limbs delaying when moving BodyCtrl
- Fix for additive issue for control rig anim node
#rb: none
#code review: Thomas.Sarkanen
Change 3313618 on 2017/02/20 by Lina.Halper
remove unnecessary calc
#rb:none
Change 3313625 on 2017/02/20 by Lina.Halper
Fixed body ctrl move keys
- all IK keys also have to be in local space (but they're local to body_ctrl)
Change 3313633 on 2017/02/20 by Alan.Noon
Quick laying out of Minions for stress testing. Iterated on Environment collision.Built lighting
Change 3313655 on 2017/02/20 by Lina.Halper
- Fixed so that you can tweak pelvis and move body also
- Fixed mambo mapping
Change 3313897 on 2017/02/21 by James.Golding
Make all FK manipulators smaller (3 instead of 4.5)
Change 3313898 on 2017/02/21 by James.Golding
Integrate CL 3311876 to Dev-AnimPhys (original author Rolando.Caloca)
DR - Expose skin cache cvar r.SkinCache.AccumulationBufferSizeInKB
Change 3313902 on 2017/02/21 by James.Golding
Draw lines from IK target to mid-joint
Change 3313906 on 2017/02/21 by Thomas.Sarkanen
Fix undo/redo/save t-pose and crashes
Binding now only does what it needs to do an no more (i.e. force a reig evaluation and re-select the rig we are looking at).
Object spawner now does not root its objects. Rather it hangs them off of a 'holder' object so that they can exist safely in the transaciton buffer.
Change 3313938 on 2017/02/21 by Benn.Gallagher
Migrated clothing assets
Change 3313982 on 2017/02/21 by James.Golding
Fix static analysis in ClothPainter.cpp
Change 3313985 on 2017/02/21 by Benn.Gallagher
Fixed crash when attempting to create clothing with degenerate triangles. Now a log error and toast warn the user of conincident tri points.
#jira UE-41935
#rnx
Change 3314052 on 2017/02/21 by James.Golding
Fix CIS in ControlRigEditModeSettings.cpp
Change 3314100 on 2017/02/21 by Lina.Halper
IK fix for retargeting
- using rig transform and remapping doesn't work. I'll have to use mesh space for IK at least. It still does blend in rig space, though with FK.
#rb: none
Change 3314160 on 2017/02/21 by Thomas.Sarkanen
Added optional node trajectories
Added trajectory cache which uses similar mechanisms to the thumbnail cache to build trajectories for nodes.
Builds trajectories and their meshes incrementally when relevant things change
Change 3314167 on 2017/02/21 by James.Golding
Fix undo when pushing IK/FK toggle buttons
Change 3314168 on 2017/02/21 by Benn.Gallagher
Disabled skin cache on tech demo project
Change 3314290 on 2017/02/21 by Lina.Halper
- Cleaned up code a bit
- Fixed thigh to rotate to target and fixed a bug that caused jittering
#rb: none
Change 3314418 on 2017/02/21 by Thomas.Sarkanen
Fix CIS issue
Change 3314428 on 2017/02/21 by Thomas.Sarkanen
Fixup anim node to be of correct editor-time type
Caused crash when placed in an anim BP
Change 3314574 on 2017/02/21 by Thomas.Sarkanen
Fixed crash on shutdown
#jira UE-42214
Change 3314705 on 2017/02/21 by Alan.Noon
Iterating on map collision. Made minion weapon joint unbreakable
Change 3314722 on 2017/02/21 by Alan.Noon
Moved minions back into Minion demo Persistent level.
Change 3314778 on 2017/02/21 by Lina.Halper
added neck/ball_r/l control
#code review: Daniel.Bouimad
Change 3314908 on 2017/02/21 by Ori.Cohen
Temp fix for cloth bounds issue.
Change 3314920 on 2017/02/21 by Alan.Noon
Placing minions. Iterating collision
Change 3314970 on 2017/02/21 by Lina.Halper
added bone picker for toes, neck
Change 3315006 on 2017/02/21 by Benn.Gallagher
Fixed clothing bounds issue with empty simulations.
Change 3315017 on 2017/02/21 by Lina.Halper
fix crash on null proxy
#rb: Benn.Gallagher
Change 3315054 on 2017/02/21 by Alan.Noon
Placing minions
Change 3315671 on 2017/02/21 by Chris.Evans
!B Fixed default material
!N Added physics subgraph for Mambo
!N Added third 'gameplay' complex example
Change 3315693 on 2017/02/21 by chris.evans
!N Enabling tangent recompute on Mambo face and arm pits.
Change 3315838 on 2017/02/21 by Alan.Noon
New Orbital Laser Pawn. New ragdoll sublevels for minion demo (400 minions)
Change 3316206 on 2017/02/22 by Thomas.Sarkanen
Fix shadowed variables
Change 3316207 on 2017/02/22 by Thomas.Sarkanen
Manipulators are now transparent
Change 3316258 on 2017/02/22 by Jurre.deBaare
- Fix for changing levels while force painting to a specific LOD
- Brush depth not same as in main
Change 3316259 on 2017/02/22 by Jurre.deBaare
Fix for paint verts being rendered outside of painting area
#misc want to change underlying behaviour for the brush representation but this'll patch it up for now
Change 3316260 on 2017/02/22 by Jurre.deBaare
Changed default paint brush settings
Change 3316267 on 2017/02/22 by Jurre.deBaare
Added channel paint flags to texture painting settings
#misc might want to create base class for common paint settings
Change 3316268 on 2017/02/22 by Jurre.deBaare
Fix for issue with viewport color mode not being reset when exiting mesh paint mode
#jira UE-42221
Change 3316278 on 2017/02/22 by James.Golding
Fix crash when pose asset contains a bone that is not in the mesh
Change 3316304 on 2017/02/22 by Thomas.Sarkanen
Prevent sequencer from reselecting tracks when keys are selected
Also fixed crash concurrently modifying an itterating TSet when removing selection nodes.
Also made manipualtors not grow and shrink when transacting.
Also tweaked sequencer selection to not allow movement of infinite areas - this allows us to start drag-selecting over these tracks rather than trying to move a seciton that cannot be moved.
#jira UE-42164
Change 3316325 on 2017/02/22 by James.Golding
Hook up Mambo physics as 'Pose Process AnimBP'
Change 3316384 on 2017/02/22 by James.Golding
Slow down mambo anim playback rate
Change 3316385 on 2017/02/22 by Jurre.deBaare
CIS: Deprecation warning fix
Change 3316424 on 2017/02/22 by Lina.Halper
#fix : control rig mapping fix for Mambo
#lockdown: James.Golding
Change 3316525 on 2017/02/22 by Lina.Halper
- Fixed so that the mapping happening with retarget base pose, not ref pose
- Added refresh mapping option for all nodes to refresh bone transform - in case you change retarget base pose
- WIP of fingers, don't think we'll make it to demo, but it is still wip going in.
#lockdown: James.Golding
#rb: none
#code review: Thomas.Sarkanen, James.Golding
Change 3316684 on 2017/02/22 by Lina.Halper
fix shadow warning
#rb: none
#lockdown: james.golding
Change 3316748 on 2017/02/22 by Thomas.Sarkanen
Fix t-pose bindings in various demo workflow situations
Fix a crash when clearing actor
Fix t-pose when opening a new sequence over an old one
Fix t-pose on save
Note: Added a couple of 'nuke it from orbit' re-binds to the actor because some code paths were not correctly setting up all of our data. Particularily we were always setting up the anim instance. We should revisit this after GDC.
#jira UE-42136
Change 3316895 on 2017/02/22 by Jurre.deBaare
Incorrect simulation verts getting painted
#fix added an early rejection test
#misc fixed sqrd vs non-sqrd check
#misc level painting already did this in other specific code
Change 3316917 on 2017/02/22 by thomas.sarkanen
Disabling threaded update on Mambo's post process anim BP
We dont support running the main BP non-threaded and the post process threaded right now.
Change 3316933 on 2017/02/22 by Thomas.Sarkanen
Fixed linux shadow variable warning
Change 3317104 on 2017/02/22 by Chris.Evans
!N Initial animation with face
Change 3317483 on 2017/02/22 by Alan.Noon
Added controls to resize the Orbital Laser Impulse in the minion demo
Change 3317592 on 2017/02/22 by Alan.Noon
Tweaking Parameters on orbital Laser Pawn
Change 3317608 on 2017/02/22 by Lina.Halper
Sorry - missed this files from previous check-in
It should have gone with CL 3316525
#rb:none
#code review:Thomas.Sarkanen, James.Golding
#lockdown: James.Golding
Change 3317762 on 2017/02/22 by Lina.Halper
- allow dependency array to be added by IK effectors - but this isn't actual bug in this case
- the bug was property was overriding the value, so we'll have to make sure to update property from code change (bForceUpdatePropertyInTheNextTick)
#rb:none
#code review: Thomas.Sarkanen, James.Golding
#lockdown: James.Golding
Change 3317807 on 2017/02/22 by Martin.Wilson
Update for Live link code
-Rename Maya Source to Message Bus Source
-Fix typo in ReceiveClient function name
Change 3318031 on 2017/02/22 by Alan.Noon
100 more minions in a sublevel. Tuned new pawn. Added sound, particle effects to impulse
Change 3318217 on 2017/02/22 by Jon.Nabozny
Re-enable Dynamic Shadows for minions. Also enable Single Sample Shadow for perf reasons.
Change 3318365 on 2017/02/22 by Alan.Noon
Created new shadow capsule asset for minion. Disabled DOF.
Change 3318421 on 2017/02/22 by Alan.Noon
Adding more minion anims for variety
Change 3318435 on 2017/02/22 by Alan.Noon
Tweak to minion anim BP: minions pick and idle and stay with it.
Change 3318860 on 2017/02/23 by James.Golding
Force update nodes and manipulators when changing IK/FK mode
Better fix for UE-42257
Change 3318869 on 2017/02/23 by James.Golding
Key limb manipulators when switching IK/FK mode
Change 3318870 on 2017/02/23 by James.Golding
Fix head button picker location
Change 3318875 on 2017/02/23 by James.Golding
Add 'T' key shortcut for toggling trajectory drawing
Change 3318907 on 2017/02/23 by Benn.Gallagher
Added rail for clothing sheet examples
Change 3318909 on 2017/02/23 by Thomas.Sarkanen
Fix trajectories jittering as they generate
The rig needs ticking twice because of what looks like some stateful assumptions that were recently made.
Basically to get the rig to a state it needs ticking more than once.
This also means that we need to tick sequencer twice to make sure the rig state gets pushed to the anim instance too.
This may be to do with the latent IK/FK switching, and needs to be investigated.
For now, I'm leaving it like this but its not ideal because it makes the trajectory generation twice as expensive.
Change 3318929 on 2017/02/23 by James.Golding
Make PoseDriver Details not assume there is always a posedrivernode (fix potential crash during demo)
Change 3318930 on 2017/02/23 by James.Golding
Resave pose_test_level with camera in better default position
Change 3318969 on 2017/02/23 by thomas.sarkanen
Added demo map with mannequin and mambo
Change 3318975 on 2017/02/23 by thomas.sarkanen
Improved embededed test sequence
Kept blends away from initial binding because of t-pose issues
Change 3318979 on 2017/02/23 by thomas.sarkanen
Added sequence showing retargeting to multiple skeletons
Change 3318983 on 2017/02/23 by thomas.sarkanen
Improved retargeting sequence so that loop points dont pop animation
Change 3318991 on 2017/02/23 by Thomas.Sarkanen
Prevent division by zero in trajectory generation
Newly created sequences dont have a frame interval set up.
Change 3319013 on 2017/02/23 by Lina.Halper
Fixed twist issue
#lockdown: James.Golding
#rb: none
Change 3319017 on 2017/02/23 by Lina.Halper
Checked in wrong line - disabling optimization
#rb:none
#lockdown:James.Golding
Change 3319034 on 2017/02/23 by Lina.Halper
sorry about that - for some reason p4 reverted the merged changes, and removing function that was merged
#rb: none
#lockdown: James.Golding
Change 3319056 on 2017/02/23 by Lina.Halper
Back out changelist 3319013
#lockdown:James.Golding
Change 3319090 on 2017/02/23 by Thomas.Sarkanen
Added bookmarks to level, fixed up animation sequeces to be used in demo
Cleaned up unused assets from demo folder
Change 3319209 on 2017/02/23 by Chris.Evans
!R Lighting rebuilt
!N cameras added, camera switching functionality
Change 3319219 on 2017/02/23 by Chris.Evans
!R Disabling physics on the snake head on left shoulder
Change 3319268 on 2017/02/23 by Chris.Evans
!R Says it's dirty, could have sworn checked in latest, tested and works fine, sync'd to last rev can't see what changed.
Change 3319290 on 2017/02/23 by James.Golding
Default bShowManipulatorsDuringPlayback to on
Change 3319291 on 2017/02/23 by James.Golding
Add GDC2017 shared collection
Change 3319867 on 2017/02/23 by Alan.Noon
Moved Audio to a level and removed from sublevel list. Deleted particles.
Change 3320056 on 2017/02/23 by Alan.Noon
Built lighting in Clothing_GDC_P
Change 3320067 on 2017/02/23 by Ori.Cohen
Fix rigid body tooltip having the same loctext key as the node name causing bad node name (matters for live demo)
Change 3320085 on 2017/02/23 by Alan.Noon
Changed Origin_Small_P in ControlRigDemoMap to "Always Loaded"
Change 3320098 on 2017/02/23 by Martin.Wilson
Final updates for Live Link GDC Demo
-Add maya scene for demo
-Add binary for maya plugin + installation instructions
-Update actor location from based on latest maya scene and fix cameras in sequencer
-Updates on live link system for demo that I have been running with locally. Should be safe.
Change 3320579 on 2017/02/23 by Alan.Noon
Bound Spacebar to GoRagdoll in ArcBlade map. Built lighting. Killed printing to screen/log in MinionBP.
Change 3321144 on 2017/02/24 by Chris.Evans
!B Lighting was bad in PIE, forced -1.5 exposure bias on all cameras
Change 3321317 on 2017/02/24 by James.Golding
PIE on pose_test_level jumps to first placed camera
Change 3321956 on 2017/02/24 by Alan.Noon
Adding missing minion anims. And Stuff.
Change 3324190 on 2017/02/27 by Lina.Halper
Removed ensure from EvaluateAnimation
- this is invalid because of worker thread but I'll have more conversation over this change.
#rb: none
#code review: Laurent.Delayen, Martin.Wilson
#jira: UE-41731
Change 3324309 on 2017/02/27 by Lina.Halper
fixed issue with skeleton bone not displaying for curve picker
#jira: UE-41909
#rb: Marc.Audy
Change 3324342 on 2017/02/27 by mason.seay
First round of assets for testing root motion with framerate
Change 3324562 on 2017/02/27 by Lina.Halper
Fix build error
#rb: none
Change 3325010 on 2017/02/28 by mason.seay
Finished map
Change 3325124 on 2017/02/28 by mason.seay
Updated test to use trigger instead of delay
Change 3325205 on 2017/02/28 by mason.seay
Deleting old map
Change 3325207 on 2017/02/28 by mason.seay
Deleting old map
Change 3325752 on 2017/02/28 by Lina.Halper
Back out changelist 3319056
- adding upper twist back again
#rb: none
Change 3325759 on 2017/02/28 by James.Cobbett
Moving Weld automated tests to EngineTest project
Change 3326039 on 2017/02/28 by Lina.Halper
Fix spine issues
This is almost like content change as this contains lots of rigging changes from code. So I'm just checking with no review.
#jira: UE-42260, UE-42268
#rb: none
Change 3326246 on 2017/02/28 by mason.seay
Test map and assets for overlap functional tests
Change 3327926 on 2017/03/01 by Lina.Halper
- disabled pelvis animation on WaveAnimationGDC
- added pelvis controls so that you can animate without worring about gmibal lock.
#code review: danny.bouimad
Change 3327971 on 2017/03/01 by Lina.Halper
Moved BaseHuman to ControlRig/Content folder
- checking in redirector for the people who have local contents that want to keep
#code review: Thomas.Sarkanen
Change 3329196 on 2017/03/02 by James.Cobbett
Deleting from QAGame. These maps and assets were migrated over to EngineTest in CL 3325759 and CL 3325802.
Change 3329263 on 2017/03/02 by mason.seay
Temp submission as I reorganize other content
Change 3329321 on 2017/03/02 by mason.seay
Reorganizing content
Change 3329493 on 2017/03/02 by James.Cobbett
Moving/renaming automated tests
Change 3332044 on 2017/03/03 by mason.seay
Procedural Mesh Functional Tests
Change 3332049 on 2017/03/03 by Mason.Seay
Screenshot comparisons for Procedural Mesh Tests
Change 3333080 on 2017/03/06 by Lina.Halper
Fix crash on not sorted OutBoneTransforms from Hand IK Retargeting node
#jira: UE-42460
Change 3333826 on 2017/03/06 by Lina.Halper
Renamed nodes -
- adding rename feature for HumanRig
#rb: none
Change 3333847 on 2017/03/06 by Lina.Halper
Fixed build error
Change 3333865 on 2017/03/06 by Lina.Halper
Fixed build error on shadow warning
Change 3333957 on 2017/03/06 by Lina.Halper
Fixed issue where limb length wasn't applied correctly on human rig
#jira: UE-42307
Change 3335109 on 2017/03/07 by Thomas.Sarkanen
Prevent us from rebuilding node tree in 'view' mode
This means that a rare crash cant occur any more
#jira UE-42568 - Editor crashes when using the eye dropper to switch actor skeleton after deleting sequence
Change 3335110 on 2017/03/07 by Jurre.deBaare
Editor crashes on importing Alembic file
#fix ensure that we generate objects with a valid object name (used to be able to include invalid characters such as periods)
#jira UE-40189
Change 3335117 on 2017/03/07 by Jurre.deBaare
Crash when opening cloth painter with Paint mode open and selecting different actor
#fix ensure that we only initialize static adapter factory data once, now that we have multiple painters
#jira UE-42573
Change 3335119 on 2017/03/07 by Jurre.deBaare
In Persona, the lighting rig rotation changes when switching between profiles
#fix don't know how I wrote this code before, but made it so it makes sense now
#jira UE-40877
Change 3335120 on 2017/03/07 by Jurre.deBaare
Auto-Exposure Overriding Preview Scene Profile Settings
#fix also update showflags when passed property is Name_none, on opening static mesh editor make sure we pick last set profile instead of default 0, and make sure we push propertyt change when changing profiles
#misc made same changes for animation editors
#jira UE-39217
Change 3335121 on 2017/03/07 by Jurre.deBaare
Points not marked as invalid in Aim Offset graph when in invalid positions
#fix ensure that samples which have a valid grid point when checking their animation ptr
#misc whitespace fixes
#jira UE-40715
Change 3335122 on 2017/03/07 by Jurre.deBaare
Cannot right-click a blend point if the green preview point is in the way
#fix changed condition slightly, now do gather highlighted index so it can be used in rightclick instead of not setting it while hovering the preview pin point
#jira UE-39060
Change 3335123 on 2017/03/07 by Jurre.deBaare
It's not clear which Grid Stretch mode in blend space is currently on
#jira UE-39080
#fix added color change on grid stretch type state
Change 3335124 on 2017/03/07 by Jurre.deBaare
Not clear that material baking is only supported for single lod merge actors
#fix extended tooltip to include requirement for material merging
#jira UE-39621
Change 3335125 on 2017/03/07 by Jurre.deBaare
#fix Alembic import fix (indexed UVs) copy-pasta error
Change 3335126 on 2017/03/07 by Jurre.deBaare
Accessor and Modifier for StartTimeOffset in GeometryCacheComponent.h
#jira UE-37080
#feature Added bp exposed get/set-er
#misc Corrected some comments
Change 3335127 on 2017/03/07 by Jurre.deBaare
Blend space interpolation settings do not update until the user reopens the asset
#fix made reintializing of interpolation filter editor only to start with, and update the filter when necessary (this way multiple players, e.g. thumbnail renderer and persona) both give the expected result, before only one of them would be reinitialized see comment on flag in header
#jira UE-40950
Change 3335129 on 2017/03/07 by Jurre.deBaare
Store imported mesh names for Alembic files (makes reimporting easier)
#jira UE-39034
Change 3335161 on 2017/03/07 by Jurre.deBaare
CIS fix: Partial back out changelist 3335129
Change 3335426 on 2017/03/07 by Jurre.deBaare
Crash fix for importing random maya shapes through Alembic
#fix add safety checks for writing material indices
#jira UE-40189
Change 3335427 on 2017/03/07 by Jurre.deBaare
Editor hard locks when adding Profile in Preview Scene Settings
#fix previous change created an infinite loop while adding a new profile, now calling OnAssetViewerSettingsChanged directly and from a different spot
#jira UE-42609
Change 3335448 on 2017/03/07 by Thomas.Sarkanen
Fixed binding (and re-binding) of rig that was broken by main integration
Templates are no longer always regenerated, so re-binding doesnt work if we rely on template regeneration
Moved runtime and compile-time binding into the template (rather than the track).
Removed hacky 'static stack' of binding IDs. This is no longer needed now we have a way to propgate per-instance template data at compile time.
Change 3336018 on 2017/03/07 by Ori.Cohen
Make sure InstantiatePhysicsAsset does not create uninitialized bodies and constraints when it is given a physics asset with inappropriate bone names. Fixes crash in rigid body node when re-targetting.
#JIRA UE-42090
Change 3336508 on 2017/03/07 by Ori.Cohen
PR #3325: Allow Physics Notification Dispatching with Engine API (Contributed by 0lento)
#JIRA UE-42533
Change 3336524 on 2017/03/07 by Ori.Cohen
Added compiler error when component space sim and world collision is used.
#JIRA UE-41402
Change 3336700 on 2017/03/07 by Ben.Marsh
Fix stream name for bulding PhysX.
Change 3336949 on 2017/03/08 by James.Golding
In BindToSkeletalMesh, make sure skel mesh resources are init'd before calling Register on SkelMeshComp
#jira UE-42377
Change 3337008 on 2017/03/08 by Lina.Halper
- Fix for lagging update
- Removed unnecessary update from trajectory cache
#rb: Thomas.Sarkanen
Change 3337190 on 2017/03/08 by James.Golding
Remove defunct PhysX 3.3 libs
Change 3337562 on 2017/03/08 by Ori.Cohen
Touch engine to force re-link of latest PhysX libs. Fixes crash when free joints are used with immediate mode.
#JIRA UE-41026, UE-42628
Change 3337779 on 2017/03/08 by Ori.Cohen
Added skeletal mesh component override for sync vs async scene.
#JIRA UE-39829
Change 3337859 on 2017/03/08 by Ori.Cohen
Fix CIS
Change 3338593 on 2017/03/08 by Ori.Cohen
Remove physx get geometry macro and replace with calls to .any which should be faster.
#JIRA UE-40503
Change 3338614 on 2017/03/08 by Ori.Cohen
Fix warning about missing EditAnywhere
#JIRA UE-41361
Change 3338677 on 2017/03/08 by Ori.Cohen
Fix new generated physics assets not properly setting user settings to default profile.
#JIRA UE-41135
Change 3338683 on 2017/03/08 by Ori.Cohen
PR #3225: UPhysicsConstraintComponent works as expected when target is an UChildActorComponent (Contributed by PhoenixBlack)
#JIRA UE-3225
Change 3338694 on 2017/03/08 by Ori.Cohen
Added a getter to physical animation component (PR #3163)
#JIRA UE-41047
Change 3339131 on 2017/03/09 by James.Golding
Merging Engine changes from //UE4/Private-GDC17-FaceRig
- Set default CurveSourceBindingName on AudioCurveSourceComponent to 'Default' (to match node default)
- Add CurveSyncOffset option to AudioCurveSourceComponent
- Add 'Copy Curves To SoundWave' option to Anim Editor
- Bind possible curve sources by iterating over component properties, rather than owned components
- Add ref-pose override option to SkinnedMeshComponent
- Major fixes for per-instance skin-weights (was not using per-section map)
- Improve warnings for per-instance skin weight problems
Change 3339223 on 2017/03/09 by Thomas.Sarkanen
Exposed preview scene settings in the existing settings tab rather than in a hidden menu in the viewport
Tab is now shown by default
Added default preview scene collection so you dont end up having to create assets all the time just to preview meshes (although this is still possible).
#jira UE-39365 - Make Preview scene setup more discoverable
Change 3339270 on 2017/03/09 by Lina.Halper
Added create animation blueprint back since now we have a separate editor.
#jira: UE-39457
#rb: Martin.Wilson
Change 3339318 on 2017/03/09 by Danny.Bouimad
TM-TangentNormals, Test map for checking tangent recalculation with and without skin cache.
Change 3339431 on 2017/03/09 by James.Golding
Make UDestructibleComponent::SpawnFractureEffectsFromDamageEvent virtual
(UDN request: https://udn.unrealengine.com/questions/335389/custom-destructible-fracture-effects.html)
Change 3339809 on 2017/03/09 by James.Golding
Add support for 'UCP' prefix for importing capsule collision on static meshes via FBX
#jira UE-5262
Change 3339955 on 2017/03/09 by Ori.Cohen
Allow kinematic leaf bodies in immediate mode
Change 3339995 on 2017/03/09 by mason.seay
Collision functional tests
Change 3340085 on 2017/03/09 by Ori.Cohen
Change default contact-gen method to PCM. This is the default in PhysX 3.4
#JIRA UE-40365
Change 3340562 on 2017/03/09 by Ori.Cohen
Added physx simulation shader override.
#JIRA UE-35304
Change 3341155 on 2017/03/10 by Ori.Cohen
Fix CIS warnings
Change 3341295 on 2017/03/10 by Martin.Wilson
Cache compact pose bone index on FBoneReference and remove manual caching in Paragon
#jira UE-42302
Change 3341943 on 2017/03/10 by mason.seay
Cleaned up logic for map blueprints. Worked around delays
Change 3342029 on 2017/03/10 by mason.seay
Cleaned up blueprint logic to remove dependency on delays
Change 3342063 on 2017/03/10 by mason.seay
Disabling tests
Change 3342071 on 2017/03/10 by mason.seay
Updated map to use assertions
Change 3342884 on 2017/03/13 by James.Golding
Expose 'trace by profile' functions to BP
Refactor duplicated code in KismetSystemLibrary collision functions
#jira UE-32912
Change 3342886 on 2017/03/13 by James.Golding
Moving sprite from PhysicsThruster actor to PhysicsThrusterComponent (like light and audio, for example)
#jira UE-6015
Change 3342921 on 2017/03/13 by Benn.Gallagher
Added some checking to anim dynamics pre update to avoid crashes when world isn't available
#jira UE-42729
Change 3342970 on 2017/03/13 by James.Golding
Fix incorrect display names for some ..ByProfile trace funcs
Change 3342972 on 2017/03/13 by James.Golding
PR #3060: Added virtual keyword to DestructibleComponent ApplyDamage, ApplyDamageRadius (Contributed by looterz)
Change 3343032 on 2017/03/13 by Josh.Stoddard
Enable stabilization in PhysX by default
- set PxSceneFlag::eENABLE_STABILIZATION by default
- removed USE_ADAPTIVE_FORCES_FOR_ASYNC_SCENE because eADAPTED_FORCES is incompatible with eENABLE_STABILIZATION
- added FBodyInstance parameter StabilizationThresholdMultiplier to control PxRigidDynamic stabilization threshold
#jira UE-6612 #rb ori.cohen
Change 3343073 on 2017/03/13 by Martin.Wilson
Properly initialize single bone controller bone references
#jira UE-42776
Change 3343074 on 2017/03/13 by Martin.Wilson
Clear raw curve data during cooking
#jira UE-37897
Change 3343317 on 2017/03/13 by Jurre.deBaare
Crash after clearing the animation from a sample point in a 1D Blendspace
#jira UE-42672
#misc made sure that we do not deem empty blend spaces as additive
Change 3343498 on 2017/03/13 by Lina.Halper
Fix on odin cook crash
- fallout from CL 3336018
#rb:Marc.Audy
#code review:Ori.Cohen
Change 3343548 on 2017/03/13 by Lina.Halper
Fix crash on ocean -
#rb: none
#code review: Ori.Cohen
Change 3344764 on 2017/03/14 by Thomas.Sarkanen
Fixed crash right-clicking empty space in the asset shortcut dropdown
#jira UE-42782 - Crash right-clicking in anim blueprint asset picker
#jira UE-42799 - GitHub 3366 : Asset selection null check before Opening Editor
Change 3344776 on 2017/03/14 by James.Golding
Really fix names for BP-expose 'ByProfile' traces
Change 3344780 on 2017/03/14 by James.Golding
PR #3359: UE4.15 Morpheme integration changes (Contributed by NaturalMotionTechnology)
#jira UE-42771
Change 3344781 on 2017/03/14 by James.Golding
PR #3346: Expose URadialForceComponent for inheritance (Contributed by projectgheist)
#jira UE-42610
Change 3344782 on 2017/03/14 by James.Golding
Fix procmesh->staticmesh conversion if only a single triangle
#jira UE-42310
Change 3344783 on 2017/03/14 by James.Golding
PR #3234: Fix the incorrect UIMin value for InitialAverageFrameRate physics setting. (Contributed by 0lento)
#jira UE-41832
Change 3344785 on 2017/03/14 by James.Golding
PR #3196: Improved Constraint warning message (Contributed by projectgheist)
Change 3344790 on 2017/03/14 by James.Golding
PR #3362: Fix NULL pointer dereference when debugging null animation sequence. (Contributed by ill)
Change 3344891 on 2017/03/14 by Jurre.deBaare
Incorporate back list of animations into blendspace editor
#feature added labels toggle to blend space grid
#feature can now override animations when drop on sample
#jira UE-39368
Change 3344921 on 2017/03/14 by Jurre.deBaare
Expose Opacity and Opacity Mask options on material flattening
#feature added support for baking out opacity and opacity masks
#jira UE-39563
Change 3344963 on 2017/03/14 by Jurre.deBaare
Need Simplygon to create LODs on animated pose, vs skeletal mesh pose
#feature added ability to specify an animation sequence from which frame 0 will be baked into the LOD mesh
#jira UE-38909
Change 3345060 on 2017/03/14 by Jurre.deBaare
CIS fix: missing include
Change 3345929 on 2017/03/14 by Jon.Nabozny
Fix Grux skeletal mesh to properly point at Grux Phys Asset (instead of Steel's).
#jira UE-42772
Change 3346970 on 2017/03/15 by Jurre.deBaare
#feature Support importing vertex colours from Alembic files
#jira UE-39032
Change 3346976 on 2017/03/15 by Jurre.deBaare
Missing files from CL 3344921
Change 3346983 on 2017/03/15 by Jurre.deBaare
Static mesh editor crashes when opening
#fix default value for additional settings
Change 3347019 on 2017/03/15 by James.Cobbett
Tidying up blueprint comments
Change 3347128 on 2017/03/15 by mason.seay
Updated descriptions on tests
Change 3347146 on 2017/03/15 by mason.seay
Updated descriptions on tests
Change 3347178 on 2017/03/15 by Martin.Wilson
PR #3358: Actually compress CompressedCurveData during anim compression (Contributed by stefanzimecki)
Change 3347257 on 2017/03/15 by Thomas.Sarkanen
Fixed crash when canceling saving a new preview mesh collection
Change 3347314 on 2017/03/15 by mason.seay
Narrowed collision volumes by half
Change 3347386 on 2017/03/15 by mason.seay
Updated descriptions
Change 3347388 on 2017/03/15 by mason.seay
Forgot to disable tests :P
Change 3347397 on 2017/03/15 by James.Cobbett
Tidying up blueprint comments for WeldingScreenshots.umap automated test
Change 3347433 on 2017/03/15 by Thomas.Sarkanen
Fix IK/FK switch on first frame (clobbering FK data)
Added a 'first frame' flag to limbs etc.
Change 3347436 on 2017/03/15 by Thomas.Sarkanen
Control rig sequences can now be exported to anim sequences
Control rig sequences can now be exported from sequencer and exported, re-exported, imported and re-imported from the content browser.
Added converter function that performs similar logic to the animation recorder.
Fixed binding template in cooked builds.
Exposed anim sequence factory via UNREALED_API to allow for me to derive from it (I force the skeleton to a known value)
#jira UE-42608 - Add "export to anim sequence" to control rig sequences
Change 3347475 on 2017/03/15 by Lina.Halper
#LookAt node refactor
- you can use LookAtLocation based on joint or socket (jira UE-8972)
- improved visualizer (jira UE-2737) - clamp was there but now you can visuzlie it
- GetOnScreenDebugInfo changed parameter - added runtime node
- possibly we could query runtime node only but right now GetOnScrrenDebugInfo belongs to AnimGraphNode
- deprecated previous GetOnScreenDebugInfo
- Added AnimPhys Object version GUID
#rb:Thomas.Sarkanen
Change 3347512 on 2017/03/15 by Thomas.Sarkanen
Filter anim sequences to the correct skeleton when exporting
Feeback from code review of CL 3347436.
Change 3347543 on 2017/03/15 by Thomas.Sarkanen
Fix shadow variable warnings
Change 3347556 on 2017/03/15 by Jurre.deBaare
Unable to select bones in the animation editor viewport
#fix issues came from hit proxies being turned on and always being hit instead of the bone physic shapes
#feature added toggle button to skeletal mesh editor to enable mesh section selection
#jira UE-42893
Change 3347559 on 2017/03/15 by James.Golding
By default, re-use anim editor with correct Skeleton when double clicking anim asset
Add menu option to force a new edtor to open
#jira UE-42912
Change 3347749 on 2017/03/15 by Lina.Halper
Fix build issue.
#rb: none
Change 3347926 on 2017/03/15 by James.Cobbett
Adding new test to Welding.umap for children welding when attached to ragdoll
Change 3347938 on 2017/03/15 by Lina.Halper
Fix build error
#rb: none
Change 3347939 on 2017/03/15 by Mason.Seay
General cleanup of bp logic in maps and blueprint actors
Added scenarios to test actor descriptions
Fixed an error in blueprints (I think I failed to submit changes before)
Change 3348074 on 2017/03/15 by Lina.Halper
build error fix
#rb: none
#code review: martin.wilson
Change 3348154 on 2017/03/15 by Lina.Halper
last fix, hopefully
#rb: none
#code review: MArtin.wilson
Change 3349160 on 2017/03/16 by Thomas.Sarkanen
Adding 'set preview mesh' to toolbar
#jira UE-42910 - Add 'preview mesh' button to toolbar
Change 3349175 on 2017/03/16 by Jurre.deBaare
Notification on reimported animations that might be bad
#fix added two warning messages for different sequence length and missing curve in reimported file (hidden behind editor user setting -> bAnimationReimportWarnings)
#jira UE-34522
Change 3349197 on 2017/03/16 by Martin.Wilson
Add ability to choose slot to preview to montage editor
#jira UE-38910
Change 3349216 on 2017/03/16 by James.Cobbett
Additional Welding tests: static meshes attached to ragdolls and simulated children detaching and retaining welded children
Change 3349217 on 2017/03/16 by James.Cobbett
Disabling new Welding tests pending review
Change 3349314 on 2017/03/16 by Benn.Gallagher
Fixed clothing not running in PS4 packaged builds
#jira UE-42857
Change 3349504 on 2017/03/16 by James.Fox
Enabling RootMotion automation tests. Approved: UEENGQA-12277
Change 3349611 on 2017/03/16 by Lina.Halper
retargeting pose options change
- now reset, import pose, use current pose
#rb: Martin.Wilson
#jira: UE-19768
Change 3349738 on 2017/03/16 by Martin.Wilson
Remove force inline from virtual compression functions.
#jira UE-33070
Change 3349787 on 2017/03/16 by James.Golding
Fix xbox one compile (FControlRigBindingTemplate::ObjectBinding was not all wrapped in WITH_EDITORONLY_DATA)
Change 3349827 on 2017/03/16 by Josh.Stoddard
- Expose PhysX stabilization as project setting, disabled by default
- remove obsolete USE_SPECIAL_FRICTION_MODEL_FOR_ASYNC_SCENE
#jira UE-42868
Change 3349932 on 2017/03/16 by James.Golding
Possible fix for cooking crash - ContentBrowser module not necessarily being loaded
Change 3350011 on 2017/03/16 by Jon.Nabozny
Created AddForceAtLocationLocal function to allow component space forces.
#jira UE-38115
Change 3350134 on 2017/03/16 by Josh.Stoddard
Fix memory leak from GPhysXSDK->createShape()
#jira UE-42733 #rb ori.cohen
Change 3351166 on 2017/03/16 by Lina.Halper
Fixed build issue
#code review:Jon.Nabozny
Change 3351451 on 2017/03/17 by Benn.Gallagher
Fixed clothing reimports not working correctly and possibly leading to editor crash
#jira UE-42953
Change 3351564 on 2017/03/17 by Benn.Gallagher
Xbox NvCloth fix, module rules incorrectly set up and were not actually compiling NvCloth into the binary
#jira UE-42224
Change 3351594 on 2017/03/17 by mason.seay
Updated BP logic to use Set Actor Location (speeds up tests)
Gave actors distinct names
Reworded descriptions
Change 3351629 on 2017/03/17 by Jon.Nabozny
Add methods to determine the WeldParent and WeldChildren of a given component.
#jira UE-40733
Change 3351639 on 2017/03/17 by Jon.Nabozny
Fix StopMovementImmediately for WheeledVehicleMovementComponent.
#jira UE-40078
Change 3351649 on 2017/03/17 by Jon.Nabozny
Update comment on AddForceAtLocationLocal to be explicit that both Force vector and Location are in Body space.
Change 3351663 on 2017/03/17 by Thomas.Sarkanen
Anim notify blueprints now start with a 'received notify' event node (ghosted)
#jira UE-27386 - A new anim notify blueprints should start with a Received Notify override
Change 3351696 on 2017/03/17 by Thomas.Sarkanen
Refactored EvaluateBoneTransforms to prevent usage of skeletal mesh component
Deprecated EvaluateBoneTransforms in favor of new EvaluateSkeletalControl_AnyThread.
Added various useful transforms to the proxy as these were the most used data from the skeletal mesh component.
Some instances still require access to skeletal mesh to access the world for debug rendering. I'm leaving these alone for the moment as they should be addressed for 4.17 with the fixes for multi-threaded debug rendering.
Commented & re-formatted ConvertCSTransformToBoneSpace and ConvertBoneSpaceTransformToCS. Deprecated signatures that take a skeletal mesh component.
Commented FAnimNode_Base interface.
#jira UE-35238 - FAnimNode_SkeletalControlBase::EvaluateBoneTransforms takes in SkeletalMeshComponent which is not safe
Change 3351698 on 2017/03/17 by James.Golding
Add GetMaterialFromFaceIndex to MeshComponent, implement for StaticMeshComponent and ModelComponent
#jira UE-42802
Change 3351701 on 2017/03/17 by James.Golding
Change from Ctrl to Shift for 'open new editor' when double-clicking anim assets
Change 3351703 on 2017/03/17 by James.Golding
Change Box and Sphyl elements to use Rotator instead of Quat, to make them easier to edit via details panel
#jira UE-39664
Change 3351704 on 2017/03/17 by James.Golding
Fix scrubbing curves that aren't selected
#jira UE-39574
Change 3351805 on 2017/03/17 by Thomas.Sarkanen
Prevent crash when trying to implement a function in a child anim blueprint
The assumption that the ubergraph was the zeroth entry in the array didnt hold for child anim BPs with overriden functions. Now we just search for the ubergraph and check it if we find it.
#jira UE-42996 - Editor Crashes when creating a function in Child Anim Blueprint
Change 3352000 on 2017/03/17 by James.Cobbett
Adding VehicleAdvBP assets for use in upcoming Welding tests
Change 3352067 on 2017/03/17 by Lina.Halper
Removed AnimGraph from GraphEditor module
- Created node factory, pin factory, pin connection policy factory
- Moved all anim related files out of GraphEditor
#code review: Michael.Noland
#jira: UE-37976
#rb: Michael.Noland
Change 3352178 on 2017/03/17 by Lina.Halper
Moved to AnimationBlueprintEditor as these are just graph visual nodes
#code review:Michael.Noland
Change 3352753 on 2017/03/17 by James.Fox
Checking in some naming convention changes for Overlap automation test.
Change 3353371 on 2017/03/19 by Lina.Halper
Fix build error
#code review: Bob.Tellez
Change 3353644 on 2017/03/20 by Jurre.deBaare
Animation thumbnails vanishing
#fix ensure that we draw the mesh regardless of whether or not we have dynamic render data
#jira UE-42974
Change 3353654 on 2017/03/20 by James.Golding
Move SGraphNodeK2Default and SGraphNodeK2Event to Public as well, as they are used by Fortnite
Update includes in SFortGrtaphNodeK2ExecuteEvent and HandleEvent to only include parent class header
Change 3353684 on 2017/03/20 by Jurre.deBaare
Separate asset viewer profiles for local / shared
- Split out profiles in local/shared UProperty
- Modifications to ini writing :(
- Extra checks for default ini writing
- Add checkout/make writable for default editor ini file
Change 3353803 on 2017/03/20 by Jurre.deBaare
CIS fixes
Change 3353830 on 2017/03/20 by Martin.Wilson
Fix additives breaking when pose link not connected to anything
#jira ue-39174
Change 3353847 on 2017/03/20 by Martin.Wilson
Add property to blend space player nodes to specify whether the blend space current time is reset when the blend space changes
#jira UE-40446
Change 3353950 on 2017/03/20 by Ori.Cohen
Undo the null entries for invalid body/bodysetup pairs. Instead we check if the body and constraints are valid in the rigid body node.
#JIRA UE-42090
Change 3353956 on 2017/03/20 by Ori.Cohen
Back out changelist 3343498 (this was needed for the null entries on bodies array which has been fixed)
Change 3354003 on 2017/03/20 by Thomas.Sarkanen
Back out changelist 3353914
Change 3354031 on 2017/03/20 by Benn.Gallagher
Speculative fix for clothing crashes using Mambo. It was possible that the skeletal mesh component could have triggered deletion or creation of simulation state objects while the simulation was in flight on another thread, added tracking and waiting for outstanding tasks.
#jira UE-42975
Change 3354151 on 2017/03/20 by Lina.Halper
Make sure nullptr tick function still works
- this is prerequisite for the play and export option
#rb:Ori.Cohen
Change 3354229 on 2017/03/20 by James.Golding
Add 'default camera' options for skel meshes
#jira UE-42762
Change 3354342 on 2017/03/20 by Martin.Wilson
Strip out identity raw tracks when baking additives.
#jira UE-40508
Change 3354388 on 2017/03/20 by Martin.Wilson
Fix false anim blueprint compile errors with aim offset pins
#jira UE-38196
Change 3354494 on 2017/03/20 by Martin.Wilson
Serialize compressed anim data when counting memory
#jira UE-39691
Change 3354515 on 2017/03/20 by Josh.Stoddard
Expose PxSceneFlag::eENABLE_ENHANCED_DETERMINISM
#jira UE-41484 #rb ori.cohen
Change 3355932 on 2017/03/21 by Thomas.Sarkanen
Back out changelist 3354003
Reinstating merge from Main:
Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys)
Change 3355954 on 2017/03/21 by Thomas.Sarkanen
Fixed up CIS issues post merge from Main
Change 3355974 on 2017/03/21 by James.Golding
Fix Mac CIS warning (constructor order of FAnimNode_BlendSpacePlayer)
Change 3355981 on 2017/03/21 by Jurre.deBaare
Whitelisted circular dependencies between meshpaintmode and VR editor modules
Change 3355986 on 2017/03/21 by Jurre.deBaare
Linux CIS file, non-capital M
Change 3356072 on 2017/03/21 by James.Golding
Fix UStaticMeshComponent::GetMaterialFromCollisionFaceIndex to not depend on editor-only data
#jira UE-43117
Change 3356073 on 2017/03/21 by James.Golding
Implement GetMaterialFromCollisionFaceIndex for ProceduralMeshComponent
Change 3356300 on 2017/03/21 by Ori.Cohen
Allow kinematic bodies with simulated parents using the full scene solver
Change 3356362 on 2017/03/21 by Lina.Halper
- Support create animation from Play
- Support export animation from Play
- this allows retargeting, post graph, or anything you see in engine will be baked to the animation
#rb: Thomas.Sarkanen
#jira: UE-19746
Change 3356482 on 2017/03/21 by Martin.Wilson
Fix crash when opening a new montage
#UE-43132
Change 3356709 on 2017/03/21 by James.Golding
Check for NaN when converting rotator->quat (very large inputs can result in nan's, need to handle to avoid hitting asserts elsewhere)
Add clamps when editing rotation of collision shapes, to avoid massive rotation entries
#jira UE-39664
Change 3356968 on 2017/03/21 by Ori.Cohen
Fix physics asset bounds to be as small as 1cm.
This introduces flicker, but passing to rendering to fix that on their end.
Change 3357092 on 2017/03/21 by Josh.Stoddard
Don't update kinematic target if the body isn't moving
#jira UE-42784 #rb ori.cohen
Change 3357194 on 2017/03/21 by Lina.Halper
Fix on vehicle anim instance look at node issue
#rb: Ori.Cohen
#jira: UE-43116
Change 3357298 on 2017/03/21 by Ori.Cohen
Fix invalid warning when dragging actors into the world. This is invalid because we manually disable collision on actors when this happens, and the warning is only needed for actual runtime.
#JIRA UE-42211
Change 3357494 on 2017/03/21 by Jon.Nabozny
Fix FPropertyEditorInlineClassFilter filtering classes incorrectly.
#jira UE-43098
Change 3357892 on 2017/03/21 by Lina.Halper
fix build error
#rb: none
Change 3358078 on 2017/03/22 by James.Golding
Fix CIS - AnimNode_FootPlacement in Platformer game after SkelControl refactor (from CL 3351696)
Change 3358080 on 2017/03/22 by Jurre.deBaare
Updating Alembic importer thirdparty dependencies for Windows and Mac
Change 3358081 on 2017/03/22 by James.Golding
Add comment to help people fix up code after moving many properties in ContraintInstance to ProfileInstance member
Change 3358092 on 2017/03/22 by James.Golding
Fix undo for saving/clearing default cam on mesh (also marks mesh dirty)
Change 3358093 on 2017/03/22 by James.Golding
Panning in orbit mode now takes in account camera speed
#jira UE-43082
Change 3358106 on 2017/03/22 by Thomas.Sarkanen
Fix fallout from Main integration
Change 3358454 on 2017/03/22 by Ori.Cohen
Temporarily disable phat immediate mode previewing to break the dependency on immediate physics plugin. Will be turned back on in later refactor
#JIRA UE-41711
Change 3358886 on 2017/03/22 by Ori.Cohen
Fix AutoWeld not being disabled in blueprint editor when the object is simulated
#JIRA UE-40193
Change 3358950 on 2017/03/22 by Lina.Halper
reverted code asking about asset name when create asset
#rb: none
Change 3359034 on 2017/03/22 by Lina.Halper
#fix fall out from previous revert
- because now export also shows the window. we don't want export to FBX to show name dialog
- it will use asset name as base
#rb: none
#code review:Thomas.Sarkanen
Change 3359165 on 2017/03/22 by Ori.Cohen
Fix welded capsules not using the right rotation
#JIRA UE-41546
Change 3359232 on 2017/03/22 by Ori.Cohen
Bump DDC key for new bvh34.
Change 3359233 on 2017/03/22 by mason.seay
Added a couple more scenarios and updated names. Needs more organization
Change 3359293 on 2017/03/22 by tim.gautier
Submitting MeshPaint test content for QAGame.
Change 3359389 on 2017/03/22 by Ori.Cohen
Back out changelist 3356589
Change 3359402 on 2017/03/22 by Jon.Nabozny
Move GetWeldParent and GetWeldChildren to EngineTest.
Change 3359978 on 2017/03/23 by Jurre.deBaare
Mesh Paint brush disappears when painting in VR
#fix removed conditional clause for painting the interactors
#jira UE-43150
Change 3359980 on 2017/03/23 by Jurre.deBaare
Mesh Paint hotkeys to modify brush size are inconsistent with other Paint modes
#fix reverted to old behavior, paint mode overriding catching key input to viewport
#jira UE-43158
Change 3360052 on 2017/03/23 by James.Golding
Back out changelist 3359165, as it was made after smoke testing. Will re-submit after copy to main.
Change 3360121 on 2017/03/23 by James.Golding
Fix perf regression from testing for NaN's in FRotator::Quaternion in shipping builds
Change 3360177 on 2017/03/23 by Jurre.deBaare
Related to previous brush size check in, early out when the painter has handled the input, that way the rest of the editor can't take the brackets [] input anymore
Change 3360358 on 2017/03/23 by mason.seay
Updated naming and organization of actors in Outliner
Change 3362050 on 2017/03/23 by Lina.Halper
Back out changelist 3343074
#rb:none
#code review: Martin.Wilson, James.Golding
[CL 3362661 by Thomas Sarkanen in Main branch]
2017-03-24 09:53:37 -04:00
void FAnimNode_LegIK : : EvaluateSkeletalControl_AnyThread ( FComponentSpacePoseContext & Output , TArray < FBoneTransform > & OutBoneTransforms )
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
{
2019-07-16 11:49:59 -04:00
DECLARE_SCOPE_HIERARCHICAL_COUNTER_ANIMNODE ( EvaluateSkeletalControl_AnyThread )
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
SCOPE_CYCLE_COUNTER ( STAT_LegIK_Eval ) ;
check ( OutBoneTransforms . Num ( ) = = 0 ) ;
// Get transforms for each leg.
2018-05-23 21:04:31 -04:00
for ( int32 LimbIndex = 0 ; LimbIndex < LegsData . Num ( ) ; LimbIndex + + )
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
{
2018-05-23 21:04:31 -04:00
FAnimLegIKData & LegData = LegsData [ LimbIndex ] ;
LegData . InitializeTransforms ( MyAnimInstanceProxy , Output . Pose ) ;
2023-05-30 14:35:39 -04:00
LegData . TwistOffsetDegrees = Output . Curve . Get ( LegData . LegDefPtr - > TwistOffsetCurveName ) ;
2018-05-23 21:04:31 -04:00
// rotate hips so foot aligns with effector.
const bool bOrientedLegTowardsIK = OrientLegTowardsIK ( LegData ) ;
// expand/compress leg, so foot reaches effector.
const bool bDidLegReachIK = DoLegReachIK ( LegData ) ;
// Adjust knee twist orientation
const bool bAdjustedKneeTwist = LegData . LegDefPtr - > bEnableKneeTwistCorrection ? AdjustKneeTwist ( LegData ) : false ;
// Override Foot FK Rotation with Foot IK Rotation.
bool bModifiedLimb = bOrientedLegTowardsIK | | bDidLegReachIK | | bAdjustedKneeTwist ;
bool bOverrideFootFKRotation = false ;
const FQuat IKFootRotation = LegData . IKFootTransform . GetRotation ( ) ;
if ( bModifiedLimb | | ! LegData . FKLegBoneTransforms [ 0 ] . GetRotation ( ) . Equals ( IKFootRotation ) )
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
{
2018-05-23 21:04:31 -04:00
LegData . FKLegBoneTransforms [ 0 ] . SetRotation ( IKFootRotation ) ;
bOverrideFootFKRotation = true ;
bModifiedLimb = true ;
}
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
2018-05-23 21:04:31 -04:00
if ( bModifiedLimb )
{
// Add modified transforms
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
for ( int32 Index = 0 ; Index < LegData . NumBones ; Index + + )
{
OutBoneTransforms . Add ( FBoneTransform ( LegData . FKLegBoneIndices [ Index ] , LegData . FKLegBoneTransforms [ Index ] ) ) ;
}
}
2018-05-23 21:04:31 -04:00
# if ENABLE_ANIM_DEBUG
const bool bShowDebug = ( CVarAnimNodeLegIKDebug . GetValueOnAnyThread ( ) = = 1 ) ;
if ( bShowDebug )
{
FString DebugString = FString : : Printf ( TEXT ( " Limb[%d/%d] (%s) bModifiedLimb(%d) bOrientedLegTowardsIK(%d) bDidLegReachIK(%d) bAdjustedKneeTwist(%d) bOverrideFootFKRotation(%d) " ) ,
LimbIndex + 1 , LegsData . Num ( ) , * LegData . LegDefPtr - > FKFootBone . BoneName . ToString ( ) ,
bModifiedLimb , bOrientedLegTowardsIK , bDidLegReachIK , bAdjustedKneeTwist , bOverrideFootFKRotation ) ;
MyAnimInstanceProxy - > AnimDrawDebugOnScreenMessage ( DebugString , FColor : : Red ) ;
}
# endif
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
}
// Sort OutBoneTransforms so indices are in increasing order.
OutBoneTransforms . Sort ( FCompareBoneTransformIndex ( ) ) ;
}
static bool RotateLegByQuat ( const FQuat & InDeltaRotation , FAnimLegIKData & InLegData )
{
if ( ! InDeltaRotation . IsIdentity ( ) )
{
const FVector HipLocation = InLegData . FKLegBoneTransforms . Last ( ) . GetLocation ( ) ;
// Rotate Leg so it is aligned with IK Target
2018-05-23 21:04:31 -04:00
for ( FTransform & LegBoneTransform : InLegData . FKLegBoneTransforms )
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
{
LegBoneTransform . SetRotation ( InDeltaRotation * LegBoneTransform . GetRotation ( ) ) ;
const FVector BoneLocation = LegBoneTransform . GetLocation ( ) ;
LegBoneTransform . SetLocation ( HipLocation + InDeltaRotation . RotateVector ( BoneLocation - HipLocation ) ) ;
}
return true ;
}
return false ;
}
static bool RotateLegByDeltaNormals ( const FVector & InInitialDir , const FVector & InTargetDir , FAnimLegIKData & InLegData )
{
if ( ! InInitialDir . IsZero ( ) & & ! InInitialDir . Equals ( InTargetDir ) )
{
// Find Delta Rotation take takes us from Old to New dir
const FQuat DeltaRotation = FQuat : : FindBetweenNormals ( InInitialDir , InTargetDir ) ;
return RotateLegByQuat ( DeltaRotation , InLegData ) ;
}
return false ;
}
2018-05-23 21:04:31 -04:00
bool FAnimNode_LegIK : : OrientLegTowardsIK ( FAnimLegIKData & InLegData )
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
{
check ( InLegData . NumBones > 1 ) ;
const FVector HipLocation = InLegData . FKLegBoneTransforms . Last ( ) . GetLocation ( ) ;
const FVector FootFKLocation = InLegData . FKLegBoneTransforms [ 0 ] . GetLocation ( ) ;
const FVector FootIKLocation = InLegData . IKFootTransform . GetLocation ( ) ;
const FVector InitialDir = ( FootFKLocation - HipLocation ) . GetSafeNormal ( ) ;
const FVector TargetDir = ( FootIKLocation - HipLocation ) . GetSafeNormal ( ) ;
if ( RotateLegByDeltaNormals ( InitialDir , TargetDir , InLegData ) )
{
# if ENABLE_ANIM_DEBUG
const bool bShowDebug = ( CVarAnimNodeLegIKDebug . GetValueOnAnyThread ( ) = = 1 ) ;
if ( bShowDebug )
{
2018-02-22 11:25:06 -05:00
DrawDebugLeg ( InLegData , MyAnimInstanceProxy , FColor : : Green ) ;
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
}
# endif
2018-05-23 21:04:31 -04:00
return true ;
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
}
2018-05-23 21:04:31 -04:00
return false ;
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
}
2018-05-23 21:04:31 -04:00
void FIKChain : : InitializeFromLegData ( FAnimLegIKData & InLegData , FAnimInstanceProxy * InAnimInstanceProxy )
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
{
2018-05-23 21:04:31 -04:00
if ( Links . Num ( ) ! = InLegData . NumBones )
{
Links . Init ( FIKChainLink ( ) , InLegData . NumBones ) ;
}
2023-12-06 14:46:33 -05:00
TotalChainLength = 0.0 ;
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
check ( InLegData . NumBones > 1 ) ;
for ( int32 Index = 0 ; Index < InLegData . NumBones - 1 ; Index + + )
{
const FVector BoneLocation = InLegData . FKLegBoneTransforms [ Index ] . GetLocation ( ) ;
const FVector ParentLocation = InLegData . FKLegBoneTransforms [ Index + 1 ] . GetLocation ( ) ;
2022-10-26 07:34:18 -04:00
const double BoneLength = FVector : : Dist ( BoneLocation , ParentLocation ) ;
2018-05-23 21:04:31 -04:00
FIKChainLink & Link = Links [ Index ] ;
Link . Location = BoneLocation ;
Link . Length = BoneLength ;
2023-12-06 14:46:33 -05:00
TotalChainLength + = BoneLength ;
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
}
// Add root bone last
2018-05-23 21:04:31 -04:00
const int32 RootIndex = InLegData . NumBones - 1 ;
Links [ RootIndex ] . Location = InLegData . FKLegBoneTransforms [ RootIndex ] . GetLocation ( ) ;
Links [ RootIndex ] . Length = 0.f ;
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
NumLinks = Links . Num ( ) ;
check ( NumLinks = = InLegData . NumBones ) ;
if ( InLegData . LegDefPtr ! = nullptr )
{
bEnableRotationLimit = InLegData . LegDefPtr - > bEnableRotationLimit ;
if ( bEnableRotationLimit )
{
MinRotationAngleRadians = FMath : : DegreesToRadians ( FMath : : Clamp ( InLegData . LegDefPtr - > MinRotationAngle , 0.f , 90.f ) ) ;
}
2018-05-23 21:04:31 -04:00
HingeRotationAxis = ( InLegData . LegDefPtr - > HingeRotationAxis ! = EAxis : : None )
? InLegData . FKLegBoneTransforms . Last ( ) . GetUnitAxis ( InLegData . LegDefPtr - > HingeRotationAxis )
: FVector : : ZeroVector ;
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
}
2018-02-22 11:25:06 -05:00
MyAnimInstanceProxy = InAnimInstanceProxy ;
bInitialized = true ;
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
}
2018-05-23 21:04:31 -04:00
TAutoConsoleVariable < int32 > CVarAnimLegIKTwoBone ( TEXT ( " a.AnimNode.LegIK.EnableTwoBone " ) , 1 , TEXT ( " Enable Two Bone Code Path. " ) ) ;
2023-12-06 14:46:33 -05:00
void FIKChain : : ReachTarget (
const FVector & InTargetLocation ,
double InReachPrecision ,
int32 InMaxIterations ,
float SoftPercentLength ,
float SoftAlpha )
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
{
if ( ! bInitialized )
{
return ;
}
const FVector RootLocation = Links . Last ( ) . Location ;
2023-12-06 14:46:33 -05:00
// Optionally soften the target location to prevent knee popping
FVector FinalTargetLocation = InTargetLocation ;
const bool bUsingSoftIK = SoftPercentLength < 1.0f & & SoftAlpha > 0.f ;
if ( bUsingSoftIK )
{
AnimationCore : : SoftenIKEffectorPosition ( RootLocation , TotalChainLength , SoftPercentLength , SoftAlpha , FinalTargetLocation ) ;
}
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
// If we can't reach, we just go in a straight line towards the target,
2023-12-06 14:46:33 -05:00
const bool bTargetIsReachable = FVector : : DistSquared ( RootLocation , InTargetLocation ) < FMath : : Square ( GetMaximumReach ( ) ) ;
const bool bHasTwoOrFewerLinks = NumLinks < = 2 ;
if ( bHasTwoOrFewerLinks | | ( ! bTargetIsReachable & & ! bUsingSoftIK ) )
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
{
const FVector Direction = ( InTargetLocation - RootLocation ) . GetSafeNormal ( ) ;
OrientAllLinksToDirection ( Direction ) ;
}
2018-05-23 21:04:31 -04:00
// Two Bones, we can figure out solution instantly
else if ( NumLinks = = 3 & & ( CVarAnimLegIKTwoBone . GetValueOnAnyThread ( ) = = 1 ) )
{
2023-12-06 14:46:33 -05:00
SolveTwoBoneIK ( FinalTargetLocation ) ;
2018-05-23 21:04:31 -04:00
}
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
// Do iterative approach based on FABRIK
else
{
2023-12-06 14:46:33 -05:00
SolveFABRIK ( FinalTargetLocation , InReachPrecision , InMaxIterations ) ;
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
}
}
2023-05-30 14:35:39 -04:00
void FIKChain : : ApplyTwistOffset ( const float InTwistOffsetDegrees )
{
const FVector & HeadLoc = Links [ 0 ] . Location ;
const FVector HeadToTail = Links . Last ( ) . Location - HeadLoc ;
const FVector RotationAxis = HeadToTail . GetSafeNormal ( ) ;
// Only apply twist to non tail/head links.
for ( int32 Index = 1 ; Index < Links . Num ( ) - 1 ; + + Index )
{
FVector & LinkLoc = Links [ Index ] . Location ;
const FVector LinkToHead = LinkLoc - HeadLoc ;
LinkLoc = HeadLoc + LinkToHead . RotateAngleAxis ( InTwistOffsetDegrees , RotationAxis ) ;
}
}
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
void FIKChain : : OrientAllLinksToDirection ( const FVector & InDirection )
{
for ( int32 Index = Links . Num ( ) - 2 ; Index > = 0 ; Index - - )
{
Links [ Index ] . Location = Links [ Index + 1 ] . Location + InDirection * Links [ Index ] . Length ;
}
}
2018-05-23 21:04:31 -04:00
void FIKChain : : SolveTwoBoneIK ( const FVector & InTargetLocation )
{
check ( Links . Num ( ) = = 3 ) ;
FVector & pA = Links [ 0 ] . Location ; // Foot
FVector & pB = Links [ 1 ] . Location ; // Knee
FVector & pC = Links [ 2 ] . Location ; // Hip / Root
// Move foot directly to target.
pA = InTargetLocation ;
const FVector HipToFoot = pA - pC ;
// Use Law of Cosines to work out solution.
// At this point we know the target location is reachable, and we are already aligned with that location. So the leg is in the right plane.
2022-10-26 07:34:18 -04:00
const double a = Links [ 1 ] . Length ; // hip to knee
const double b = HipToFoot . Size ( ) ; // hip to foot
const double c = Links [ 0 ] . Length ; // knee to foot
2018-05-23 21:04:31 -04:00
2022-10-26 07:34:18 -04:00
const double Two_ab = 2.f * a * b ;
const double CosC = ! FMath : : IsNearlyZero ( Two_ab ) ? ( a * a + b * b - c * c ) / Two_ab : 0.0 ;
const double C = FMath : : Acos ( CosC ) ;
2018-05-23 21:04:31 -04:00
// Project Knee onto Hip to Foot line.
const FVector HipToFootDir = ! FMath : : IsNearlyZero ( b ) ? HipToFoot / b : FVector : : ZeroVector ;
const FVector HipToKnee = pB - pC ;
const FVector ProjKnee = pC + HipToKnee . ProjectOnToNormal ( HipToFootDir ) ;
const FVector ProjKneeToKnee = ( pB - ProjKnee ) ;
FVector BendDir = ProjKneeToKnee . GetSafeNormal ( KINDA_SMALL_NUMBER ) ;
// If we have a HingeRotationAxis defined, we can cache 'BendDir'
// and use it when we can't determine it. (When limb is straight without a bend).
// We do this instead of using an explicit one, so we carry over the pole vector that animators use.
// So they can animate it, and we try to extract it from the animation.
if ( ( HingeRotationAxis ! = FVector : : ZeroVector ) & & ( HipToFootDir ! = FVector : : ZeroVector ) & & ! FMath : : IsNearlyZero ( a ) )
{
const FVector HipToKneeDir = HipToKnee / a ;
2022-10-26 07:34:18 -04:00
const double KneeBendDot = HipToKneeDir | HipToFootDir ;
2018-05-23 21:04:31 -04:00
FVector & CachedRealBendDir = Links [ 1 ] . RealBendDir ;
FVector & CachedBaseBendDir = Links [ 1 ] . BaseBendDir ;
// Valid 'bend', cache 'BendDir'
2022-10-26 07:34:18 -04:00
if ( ( BendDir ! = FVector : : ZeroVector ) & & ( KneeBendDot < 0.99 ) )
2018-05-23 21:04:31 -04:00
{
CachedRealBendDir = BendDir ;
CachedBaseBendDir = HingeRotationAxis ^ HipToFootDir ;
}
// Limb is too straight, can't determine BendDir accurately, so use cached value if possible.
else
{
// If we have cached 'BendDir', then reorient it based on 'HingeRotationAxis'
if ( CachedRealBendDir ! = FVector : : ZeroVector )
{
const FVector CurrentBaseBendDir = HingeRotationAxis ^ HipToFootDir ;
const FQuat DeltaCachedToCurrBendDir = FQuat : : FindBetweenNormals ( CachedBaseBendDir , CurrentBaseBendDir ) ;
BendDir = DeltaCachedToCurrBendDir . RotateVector ( CachedRealBendDir ) ;
}
}
}
// We just combine both lines into one to save a multiplication.
// const FVector NewProjectedKneeLoc = pC + HipToFootDir * a * CosC;
// const FVector NewKneeLoc = NewProjectedKneeLoc + Dir_LegLineToKnee * a * FMath::Sin(C);
const FVector NewKneeLoc = pC + a * ( HipToFootDir * CosC + BendDir * FMath : : Sin ( C ) ) ;
pB = NewKneeLoc ;
}
bool FAnimNode_LegIK : : DoLegReachIK ( FAnimLegIKData & InLegData )
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
{
SCOPE_CYCLE_COUNTER ( STAT_LegIK_FABRIK_Eval ) ;
const FVector FootFKLocation = InLegData . FKLegBoneTransforms [ 0 ] . GetLocation ( ) ;
const FVector FootIKLocation = InLegData . IKFootTransform . GetLocation ( ) ;
2023-05-30 14:35:39 -04:00
// There's no work to do if:
// - We don't have a twist offset.
// - We don't need to run the solver.
const bool bHasTwistOffset = ! FMath : : IsNearlyZero ( InLegData . TwistOffsetDegrees ) ;
// The solver is needed if:
// - Our FK foot is not at the IK goal.
// - We're applying a rotation limit.
2024-01-22 18:09:29 -05:00
// - We're using Soft IK (even if foot is at goal, it may be bent by the soft IK if limb is fully extended)
const bool bUsingSoftIK = SoftPercentLength < 1.0f & & SoftAlpha > 0.f ;
2023-05-30 14:35:39 -04:00
const bool bFootAtGoal = FootFKLocation . Equals ( FootIKLocation , ReachPrecision ) ;
const bool bUsingRotationLimit = InLegData . LegDefPtr - > bEnableRotationLimit ;
2024-01-22 18:09:29 -05:00
const bool bNeedsSolver = ! bFootAtGoal | | bUsingRotationLimit | | bUsingSoftIK ;
2023-05-30 14:35:39 -04:00
if ( ! bNeedsSolver & & ! bHasTwistOffset )
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
{
2018-05-23 21:04:31 -04:00
return false ;
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
}
2018-05-23 21:04:31 -04:00
FIKChain & IKChain = InLegData . IKChain ;
2018-02-22 11:25:06 -05:00
IKChain . InitializeFromLegData ( InLegData , MyAnimInstanceProxy ) ;
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
2023-05-30 14:35:39 -04:00
if ( bNeedsSolver )
{
const int32 MaxIterationsOverride = CVarAnimLegIKMaxIterations . GetValueOnAnyThread ( ) > 0 ? CVarAnimLegIKMaxIterations . GetValueOnAnyThread ( ) : MaxIterations ;
2023-12-06 14:46:33 -05:00
IKChain . ReachTarget ( FootIKLocation , ReachPrecision , MaxIterationsOverride , SoftPercentLength , SoftAlpha ) ;
2023-05-30 14:35:39 -04:00
}
if ( bHasTwistOffset )
{
IKChain . ApplyTwistOffset ( InLegData . TwistOffsetDegrees ) ;
}
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
// Update bone transforms based on IKChain
// Rotations
for ( int32 LinkIndex = InLegData . NumBones - 2 ; LinkIndex > = 0 ; LinkIndex - - )
{
const FIKChainLink & ParentLink = IKChain . Links [ LinkIndex + 1 ] ;
const FIKChainLink & CurrentLink = IKChain . Links [ LinkIndex ] ;
FTransform & ParentTransform = InLegData . FKLegBoneTransforms [ LinkIndex + 1 ] ;
FTransform & CurrentTransform = InLegData . FKLegBoneTransforms [ LinkIndex ] ;
// Calculate pre-translation vector between this bone and child
const FVector InitialDir = ( CurrentTransform . GetLocation ( ) - ParentTransform . GetLocation ( ) ) . GetSafeNormal ( ) ;
// Get vector from the post-translation bone to it's child
const FVector TargetDir = ( CurrentLink . Location - ParentLink . Location ) . GetSafeNormal ( ) ;
const FQuat DeltaRotation = FQuat : : FindBetweenNormals ( InitialDir , TargetDir ) ;
ParentTransform . SetRotation ( DeltaRotation * ParentTransform . GetRotation ( ) ) ;
}
// Translations
for ( int32 LinkIndex = InLegData . NumBones - 2 ; LinkIndex > = 0 ; LinkIndex - - )
{
const FIKChainLink & CurrentLink = IKChain . Links [ LinkIndex ] ;
FTransform & CurrentTransform = InLegData . FKLegBoneTransforms [ LinkIndex ] ;
CurrentTransform . SetTranslation ( CurrentLink . Location ) ;
}
# if ENABLE_ANIM_DEBUG
const bool bShowDebug = ( CVarAnimNodeLegIKDebug . GetValueOnAnyThread ( ) = = 1 ) ;
if ( bShowDebug )
{
2018-02-22 11:25:06 -05:00
DrawDebugLeg ( InLegData , MyAnimInstanceProxy , FColor : : Yellow ) ;
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
}
# endif
2018-05-23 21:04:31 -04:00
return true ;
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
}
void FIKChain : : DrawDebugIKChain ( const FIKChain & IKChain , const FColor & InColor )
{
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3153514)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3050254 on 2016/07/14 by Marc.Audy
Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3049614
Change 3136629 on 2016/09/22 by Marc.Audy
bye bye auto
Change 3136631 on 2016/09/22 by Marc.Audy
Allow objects to be marked as duplicate transient or non PIE duplicate transient
ChildActors are not marked consistent with the property that references them as text export transient and non PIE duplicate transient
#jira UE-35680
Change 3136636 on 2016/09/22 by Marc.Audy
ParticleSystem and Audio Components now route Activate/Deactivate events to blueprints
Component Activate/Deactivate events now provide component as a property
#jira UE-35191
Change 3136640 on 2016/09/22 by Marc.Audy
Expose bReplicates to blueprint component properties
#jira UE-34433
Change 3136709 on 2016/09/22 by Ori.Cohen
Fix GetBodyInstance returning incorrect bodies when welded kinematics are attached.
#JIRA UE-36234
Change 3136710 on 2016/09/22 by Ori.Cohen
Fix defer actors not working when the physics scene is simulating. We now flush when the scene is not simulating, as well as a lazy flush that goes through the slow path when needed. This allows us to batch multiple components together.
#JIRA UE-35899
Change 3136770 on 2016/09/22 by Marc.Audy
Fix compile error
Change 3136854 on 2016/09/22 by Marc.Audy
Sprite components need to be text export transient
#jira UE-36064
Change 3136926 on 2016/09/22 by Ori.Cohen
Fix ensure when skeletal mesh bodies have no collision.
Change 3137054 on 2016/09/22 by Aaron.McLeran
PR #2628: Fix UAudioComponent SubtitlePriority not being initialised (Contributed by alanedwardes)
Change 3137058 on 2016/09/22 by Aaron.McLeran
PR #2562: ReadCompressedInfo calculates duration for ADPCM audio (Contributed by derekvanvliet)
Change 3137060 on 2016/09/22 by Aaron.McLeran
UE-36336 Fixing A3D for mono/2D sounds
- Making it so if A3D is being loaded but not enabled, we can not have reverb on 2D sounds
- Fixing A3D mono sources from failing after a time
Change 3137066 on 2016/09/22 by Aaron.McLeran
Checking in Ngs2.Build.cs with A3D and USING_A3D set to 0
Change 3137098 on 2016/09/22 by dan.reynolds
AEOverview Update: EQ Map, Reverb Map plus improvements on Main array cleanup process.
Change 3137132 on 2016/09/22 by Aaron.McLeran
PR #2789: Fixed signature of FActiveSound::GetIntParameter (Contributed by Laurie-Hedge)
Change 3137175 on 2016/09/22 by Aaron.McLeran
Fixing compile error with PhysXCollision.cpp from CL 3136710
Change 3137540 on 2016/09/23 by Thomas.Sarkanen
Fixed crash when generating LODs automatically for skeletal meshes
Quadric error reduction does not support skeletal meshes, so fails. Client code assumes that it cannot fail so crashed. This guards against immediatly assuming that LODs are valid after simplification.
#jira UE-36253 - Crash applying LOD changes in Persona
Change 3137720 on 2016/09/23 by Thomas.Sarkanen
Changed asset shortcut bar to display asset names & reworked padding
#jira UE-36347 - Anim asset shortcut bar has difficult to read/cut-off text
Change 3137761 on 2016/09/23 by Martin.Wilson
Fix typo in root motion from everything accumulation code
Change 3137877 on 2016/09/23 by Thomas.Sarkanen
Fixed undo/redo forcing skeletal meshes into t-pose
Re-populated AnimationData in InitAnim for UDebugSkelMeshComponent.
#jira UE-35579 - If you undo an animation change to any animation asset (for single preview), the playback controls will no longer function
Change 3137885 on 2016/09/23 by Benn.Gallagher
Fixed APEX clothing disappearing when time dilation results in a dt of 0. After simulating an actor with 0 APEX will fill positions and normals with NaNs, causing the disappearance. The fix in this case is to not schedule the evaluation task if we're not wanting to do any work. The simulation then freezes as we would expect.
#jira UE-35151
Change 3137888 on 2016/09/23 by Benn.Gallagher
Fixed transition nodes being able to be pasted or duplicated without 2 valid pin links
#jira UE-24860
Change 3137889 on 2016/09/23 by Benn.Gallagher
Fixed transform and widget inconsistencies in IK edit mode
#jira UE-20628
Change 3137890 on 2016/09/23 by Jurre.deBaare
Alembic Cached Geometry Does Not Display in Stand Alone Game
#fix required to force load the GeometryCache module during runtime
#jira UE-36187
Change 3137892 on 2016/09/23 by Jurre.deBaare
Geometry cache playback should work in sequencer
#fix add Interp UProperty tag to specific properties used for playing back the cache, future fix is having same approach as skeletal mesh animation for sequencer (depends on needs, -> skeletal mesh import has better compression anyway)
#jira UE-35447
Change 3137893 on 2016/09/23 by Jurre.deBaare
Alembic Cache Importer option for Hard Edge Angle Threshold does not work for objects with no normals
#fix adhere to the assumed 'standard' no normals in ABC file means completely smooth normals throughout the sequence
#jira UE-35091
Change 3137894 on 2016/09/23 by Jurre.deBaare
Importing an Alembic File While mesh Distance Fields are Enabled Crashes Editor
#fix Needed to save the raw mesh before building the mesh to ensure a LOD resource was created
#misc added a new check + message in case this occurs again
#jira UE-36059
Change 3137938 on 2016/09/23 by Jurre.deBaare
Alembic Importing with Incorrect UV's
#fix adding option for flipping UVs on import
#jira UE-36190
Alembic import axis not aligned correctly
#fix also added option to specify scale and rotation to be applied during import (with preset for Maya and Max)
#jira UE-35510
Change 3137949 on 2016/09/23 by Jurre.deBaare
Frame range importing causes confusion during Alembic importing
#fix this required storing information per Alembic object at which frame index it actual has stored frames, using this data we can determine which frames are empty, and at which frame there is data. This allows us to skip empty frames if we want to import data-only frames, or to import all frames in the sequence including empty (pre-roll) frames.
#misc changed settings UI listview layout (extra columns and resized old ones)
#jira UE-35498
Change 3137994 on 2016/09/23 by Martin.Wilson
Fix for creating an empty state when dragging a montage into a state machine graph
#jira UE-33371
Change 3138103 on 2016/09/23 by Aaron.McLeran
UE-36312 Fixing sound node distance cross fade for case of looping sounds
Change 3138104 on 2016/09/23 by Aaron.McLeran
UE-35392 Copy pasting local node into separate project crashes the engine
Change 3138224 on 2016/09/23 by Aaron.McLeran
UE-36312 Fixing sound node distance cross fade for case of looping sounds
- Adding a check for wave instance count to account for virtualized sounds (one-shots)
Change 3138666 on 2016/09/23 by Ben.Zeigler
#UEFW-204 Add more comprehensive gameplay tag tests
Fix issue with HasTag(Tag, IncludeParent, IncludeParent) revealed by tests, this was not returning true correctly in some cases. This use case is weird and will be deprecated soon
Change 3138779 on 2016/09/23 by Marc.Audy
Get rid of pointless casts
Change 3138782 on 2016/09/23 by Marc.Audy
remove some GWorlds
Change 3139701 on 2016/09/26 by Jurre.deBaare
Assert failed on GemetryCache for PS4 package
#fix add GeometryCache reference in engine build.cs and fix the serialization of geometry cache files
#jira UE-36392
Change 3139704 on 2016/09/26 by Jurre.deBaare
Fix for -1 begin frame
#fix do the max as an signed int, to make sure we don't wrap around
Change 3139748 on 2016/09/26 by Benn.Gallagher
PR #2784: Make sure that SceneScratchBufferSize is a multiple of 16K as requested by PhysX (Contributed by DenizPiri)
Moved the definition of the boundary to a FPhysScene class static
Changed comments on original user settings property to communicate the fact that the value is now rounded to the next 16K boundary
#jira UE-35736
Change 3139903 on 2016/09/26 by Benn.Gallagher
Fixed exposing subinstance pins stomping over class defaults and setting to uninitialized values
#jira UE-34366
Change 3140409 on 2016/09/26 by Lukasz.Furman
fixed uninitialized configs of gameplay debugger
copy of CL# 3140399
Change 3140516 on 2016/09/26 by dan.reynolds
AEOverview Map Update - Ambient Zone + Focus Test
Change 3140526 on 2016/09/26 by Jon.Nabozny
#rn Fixed CanJump inconsistencies with previous versions.
Deferred JumpCurrentCount increment until after jump, made bWasJumping a member variable, and updated how
jump count and hold time were compared in CanJump.
#jira UE-35524, UE-35582
Change 3140745 on 2016/09/26 by dan.reynolds
AEOverview Test Map Update + Occlusion Test
Change 3140839 on 2016/09/26 by dan.reynolds
AEOverview - minor updates
Change 3141101 on 2016/09/27 by Thomas.Sarkanen
Preview scene worlds now render correctly
Split "Preview" type into "EditorPreview" (the default) and "GamePreview". Deprecated the old "Preview" world type (but kept its index).
In-game hidden flags now apply to GamePreview, but not EditorPreview worlds.
Deprecated old bHack_Force_UsesGameHiddenFlags_True boolean. GamePReview now serves this purpose.
Fixed up UT cases where this was being used.
FPreviewScenes now use the editor mode by default, but can be set to non-editor if needed (as is the case with the still-experimental UViewport).
Custom depth pass is not enabled for EditorPreview (as before) but is for GamePreview.
Fixed erroneous use of TEnumAsByte for non-uproperty WorldType.
#jira UE-22883 - Using FPreviewScenes in-game for scene captures
Change 3141106 on 2016/09/27 by Thomas.Sarkanen
Column toggling improvements
Column toggle menu now does not close when items are selected.
This requries some Slate changes to how submenus are built to allow for sumbenus to specify whether they close after selection.
Also allowed columns to be hidden by default for specific use cases (like the sequence browser).
#jira UE-35818 - Anim asset browser column picker should stay up
Change 3141131 on 2016/09/27 by Thomas.Sarkanen
Fix CIS warnings
Fallout from preview world changes
Change 3141143 on 2016/09/27 by Jurre.deBaare
Fix for CIS errors
Change 3141235 on 2016/09/27 by Thomas.Sarkanen
Fix offset of Persona floor mesh when auto-alignment is enabled
When auto alignment was disabled, the offset wasnt getting taken into account.
#jira UE-35544 - In Persona, Floor Height Offset does nothing with Auto Align Floor to Mesh disabled
Change 3141327 on 2016/09/27 by Marc.Audy
Ensure that the client side AttachChildren array remains accurate
#jira UE-26025
Change 3141474 on 2016/09/27 by mason.seay
Updating test map name and moving PlayerStart
Change 3141501 on 2016/09/27 by Benn.Gallagher
Loading time improvements for destructibles from Nvidia
Updated to use new framework custom version instead of global object version
Fixed usage of TArray to enable correct loading and saving of the cached data.
#jira UE-29680
Change 3141889 on 2016/09/27 by Marc.Audy
Fix DestructibleMesh when WITH_APEX is 0
#jira UE-36484
Change 3142034 on 2016/09/27 by Marc.Audy
Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3141971
Change 3142131 on 2016/09/27 by Ori.Cohen
Make sure we return eTouch to physx during an overlap query. Fixes bad behavior when multiple objects blocked in an overlap query.
#JIRA UE-36381
Change 3142154 on 2016/09/27 by Ori.Cohen
Fix build, ModuleCachedData instead of NxApexModuleCachedData
Change 3142159 on 2016/09/27 by mason.seay
Blueprint for testing Child Actor Templates
Change 3142255 on 2016/09/27 by Jon.Nabozny
Fix crashes in QAMeshMerge component by making it a UObject, exposing it's method statically, and taking QASkeletalMeshMergeParams as an argument.
#jira UE-35199, UE-35197, UE-35201
Change 3142717 on 2016/09/27 by dan.reynolds
AEOverview Update + Sound Class Test
Change 3142764 on 2016/09/27 by Marc.Audy
Fix Ocean deprecation warnings
Change 3142962 on 2016/09/28 by Thomas.Sarkanen
Fixed bounds calculations for local camera animations
Correctly calculated bounds as local to the initial transform in the track.
Implemented suggested fixes from UDN user chhaddon (The Coalition).
#jira UE-29594 - CameraAnim bounds are incorrect when bRelativeToInitialTransform == true
Change 3143007 on 2016/09/28 by Martin.Wilson
Added virtual bones to USkeleton
API Breaking change:
-Added USkeleton pointer to RemoveBonesByName
-FReferenceSkeleton::UpdateRefPoseTransform & FReferenceSkeleton::Add made private. Must use FReferenceSkeletonModifier instead
#jira UEFW-81
Change 3143040 on 2016/09/28 by James.Golding
Strip DrawDebug.. functions from Shipping and Test builds, controlled by new define ENABLE_DRAW_DEBUG
Fix up game projects to compile in Shipping/Test after this change
PR #2757: (Contributed by projectgheist)
#jira UE-35488
Change 3143046 on 2016/09/28 by James.Golding
Fix OrionEnvironmentPerfTest.cpp compiling in Shipping (optimizations were not being re-enabled at end of file)
Change 3143047 on 2016/09/28 by James.Golding
PR #2731: Capsule primitive drawing fix (Contributed by kamrann)
#jira UE-35142
Change 3143050 on 2016/09/28 by Martin.Wilson
Update DDC key as some animation have stale data
Change 3143088 on 2016/09/28 by Martin.Wilson
CIS Fixes for Ocean after FReferenceSkeleton changes
Change 3143090 on 2016/09/28 by Benn.Gallagher
Fixed split pins in animation blueprints losing their pin links on editor restart. The anim nodes had opted out of the Super version of reconstruct, but that's where split pin restoration was added so we were skipping it.
#jira UE-36482
Change 3143091 on 2016/09/28 by Thomas.Sarkanen
Fix play/pause keyboard shortcut toggle in Persona based editors
Correctly handled widget mode switching in the skeleton selection edit mode (previously it was manually handling this rather than hooking into the correct level viewport callbacks).
Added the ability for FEdModes to specify whether they can use a widget mode.
Added a common set of commands that all Persona-based editors can opt into (only contains TogglePlay for now).
#jira UE-35163 - Cannot use Play/Pause shortcut in Persona if viewport is focused
Change 3143100 on 2016/09/28 by James.Golding
UE-32275 Fix Anim Curve entries losing Auto state when hidden/reshown
Change 3143107 on 2016/09/28 by Martin.Wilson
Add check to IsRunningParallelEvaluation to verify that the skeletal mesh component in question still references us
#jira UE-34431
Change 3143125 on 2016/09/28 by Jurre.deBaare
PR #2749: Fix blend space triangulation (Contributed by tmiv)
Change 3143225 on 2016/09/28 by Jurre.deBaare
Mesh/material merging basic test files
Change 3143235 on 2016/09/28 by Martin.Wilson
Fix issue where montage wrong section was updated with changes from details panel when clicking on a new section
#jira UE-35929
Change 3143312 on 2016/09/28 by Marc.Audy
Don't globally reregister components, globally recreate render state instead when force deleting assets
Fixes crash force deleting a blueprint with a child actor component in it from the content browser
Change 3143340 on 2016/09/28 by Mieszko.Zielinski
Improved consistency of loudness usage in AISense_Hearing #UE4
Change 3143359 on 2016/09/28 by Marc.Audy
Fix spelling error in comment
Change 3143372 on 2016/09/28 by Jurre.deBaare
HLOD meshes are causing degenerate triangles
#fix Setting flag to ignore degenerate triangles when building the meshes vertex/index buffers
#jira UE-34336
Change 3143420 on 2016/09/28 by Mieszko.Zielinski
Fix to BlackboardData initialization's dependency on parent asset's initialization #UE4
Change 3143421 on 2016/09/28 by Martin.Wilson
Allow reading on animation sequence length in blueprints
#jira UE-34168
Change 3143455 on 2016/09/28 by James.Golding
Add 'noop' versions of DrawDebug function, so you will not get compile errors by default for calling them in Shipping/Test builds.
Added optional SHIPPING_DRAW_DEBUG_ERROR define, which will give compile errors in Shipping/Test if still calling DrawDebug functions
Change 3143518 on 2016/09/28 by Jurre.deBaare
Meshes with no UV Coordinates will break the UVs of other meshes contained in the same HLOD if they share a material
#fix calculate UV bounds and check whether they occupy any space (if not do not use them for baking out the material)
#misc set texture sampling for HLOD proxy base material to clamp
#jira UE-35221
Change 3143542 on 2016/09/28 by James.Golding
Change SHIPPING_DRAW_DEBUG_ERROR define from ifdef to if
Fix comment
Enable by default for FN
Change 3143543 on 2016/09/28 by Benn.Gallagher
Changed branch + early return into an ensure during FPxQueryFilterCallback::preFilter. We were checking for invalid shapes in preFilter but that shouldn't happen. More likely to get some information as an ensure instead of earlying out on the funciton.
Change 3143556 on 2016/09/28 by Aaron.McLeran
UE-36540 Editor Preferences 'Enable Sound' option causes Real Time Audio to Stop Working after PIE
Change 3143566 on 2016/09/28 by Benn.Gallagher
Readded early out alongside new ensure for catching bad preFilter shapes
Change 3143568 on 2016/09/28 by Marc.Audy
Fix deprecation warnings in UT
Change 3143572 on 2016/09/28 by Jurre.deBaare
More test content for mesh/material merging
Change 3143581 on 2016/09/28 by Jurre.deBaare
More content :D
Change 3143585 on 2016/09/28 by Jurre.deBaare
Geometry cache cleaning
#misc fix for missing materials, not serialized (facepalm) as they were added later on (required custom version bump)
#misc cleaning out unecessary code
Change 3143594 on 2016/09/28 by Marc.Audy
Creating a child actor component by dragging an actor blueprint in to another blueprint now properly creates the template
#jira UE-36511
Change 3143658 on 2016/09/28 by Marc.Audy
RootComponent can be null by the time we hit PostUnregisterAllComponents so need to protect against the dereference
#jira UE-36553
Change 3143776 on 2016/09/28 by Marc.Audy
Properly reinstance child actor templates when using the fast reinstancing path
#jira UE-36516
Change 3143896 on 2016/09/28 by Ori.Cohen
Remove UPROPERTY on aggregate threshold which is always read from the physics settings.
Change 3144022 on 2016/09/28 by Ben.Zeigler
Move AIMoveTo node from BlueprintGraph to AIGraph and remove BlueprintGraph->AIModule dependency in build system
Change 3144252 on 2016/09/28 by mason.seay
More blueprints for child actor template testing
Change 3144262 on 2016/09/28 by Mason.Seay
Deleting assets
Change 3144283 on 2016/09/28 by dan.reynolds
AEOverview update + Sound Priority Test
Change 3144411 on 2016/09/28 by dan.reynolds
AEOverview end of day update and tweaks
Change 3144679 on 2016/09/29 by Benn.Gallagher
Changed skeletal bounds calculation to not consider clothing assets that aren't simulating in the current LOD. In this case we're not rendering the clothing, we're only rendering the skeletal geometry for that section in that LOD which isn't bound to cloth.
Change 3144856 on 2016/09/29 by Jurre.deBaare
HLOD Outliner scrolls back to the top when generating proxy meshes
#fix OnLevelActorsAdded was getting called for actors in the thumbnail worlds, which forced a refresh on the listview
#jira UE-30384
Change 3144864 on 2016/09/29 by Thomas.Sarkanen
Preview mesh fixes
Animation preview meshes are now respected (and saved). Mesh is displayed as empty if none is set (but a default is chosen).
Skeleton preview meshes are now shown as empty if none is set (but a default is chosen).
#jira UE-36582 - Cannot set preview mesh per-animation
Change 3144865 on 2016/09/29 by Jurre.deBaare
More test content
Change 3144885 on 2016/09/29 by James.Golding
UE-35307 Move 'invalid scale' warning to Message Log to be more visible in editor
Change scale clamping in UpdateBodyScale to catch cases like (1,0,1)
Change 3144903 on 2016/09/29 by Thomas.Sarkanen
Deprecating StaticMesh in UStaticMeshComponent
Added GetStaticMesh to access the value as read-only.
SetStaticMesh is now called in all locations that used to call "StaticMesh =".
Lots of fixups.
#jira UE-24859 - Deprecate public access to StaticMesh property in UStaticMeshComponent
Change 3145020 on 2016/09/29 by Thomas.Sarkanen
Fix bounds calculations that include bones to respect LOD (and other requried bones)
Sometimes bones would not be updated if we LOD switched, extending the bounds.
#jira UE-36525 - UDebugSkelMeshComponent::CalcBounds should filter by LOD
Change 3145041 on 2016/09/29 by Jurre.deBaare
Setting the Target Lightmap UV Channel to an incorrect value leads to inconsistent results
#fix removed target light map channel, we now determine according to the UV channels which are unused in the final mesh
#misc ignore the source lightmap uv channels to reduce data
#jira UE-36595
Change 3145219 on 2016/09/29 by Benn.Gallagher
Fixed clothing actors not casting shadows in editor, after the material editing change the copy of the shadow flag was missed from the clothing association code, which runs on again on older clothing assets to use the new render data skinning. Also added some fix up for assets that have be saved in the mean time.
#jira UE-36552
Change 3145222 on 2016/09/29 by Jurre.deBaare
Exporting Alembic Skeletal mesh from UE4 to FBX causes a crash
#fix on import set _all_ bone influence to 0
#jira UE-36602
Change 3145267 on 2016/09/29 by Ori.Cohen
Move OnConstraintBreak delegate so that it fires outside of fetchResults. Fixes crash from user doing unsafe things during fetchResults.
#JIRA UE-36483
Change 3145306 on 2016/09/29 by Jon.Nabozny
Fixed PhAT so multiple constraints can be selected and edited properly at the same time.
#JIRA: UE-31493
Change 3145342 on 2016/09/29 by Marc.Audy
Do not update cull distance volumes whenever any property changes
* Any movement or property change of a cull distance volume still does a global update
* Any movement of a component belong to any other Actor updates only the components of that Actor
* Any property change of a primitive component only updates that component
#jira UE-36399
Change 3145958 on 2016/09/29 by Marc.Audy
In game worlds don't auto activate components until the actor is ready to process them
#jira UE-35189
Change 3146110 on 2016/09/29 by dan.reynolds
AEOverview update + Soundwave Procedural Test Map
Change 3146375 on 2016/09/30 by Benn.Gallagher
Fixed crash saving newly created destructible mesh after material refactor.
#jira UE-36619
Change 3146378 on 2016/09/30 by James.Golding
UE-35908 Line trace against a BodyInstance now returns closest hit for trimesh (was any hit before)
Also add stat for FBodyInstance::LineTrace
Change 3146379 on 2016/09/30 by James.Golding
Add test assets for creating procmesh collision in non-editor builds
Change 3146386 on 2016/09/30 by Thomas.Sarkanen
Fixed ensures (and functionality) of 'show uncompressed animation' option in Persona viewports
Made sure that PreEvaluateAnimation is called for th einstance in use, rather than only the preview instance.
This unearthed another issuye where each of the calls to GenSpaceBAses was causing the animation to run faster. Fixed this by resetting the update flag in the update context after it is used.
#jira UE-36251 - Ensures showing uncompressed animations in anim blueprints
Change 3146464 on 2016/09/30 by Thomas.Sarkanen
Fix layered blend per bone odd/even connection counts alternately working/not working
Older hacky fix for multi-property to array copies flip-flipped between using fast path and not, when it really should have disabled fast path after the first array pin. Now it disables fast path based on whether this is a new handler or not, rather than looking at the SimpleCopyPropertyName.
#jira UE-35648 - Layered Blend Per Bone doesn't work correctly with 3+ inputs
Change 3146652 on 2016/09/30 by Benn.Gallagher
Fixed subinstance properties appearing in the caller's details panel as oddly named properties.
#jira UE-34141
Change 3146673 on 2016/09/30 by Martin.Wilson
Make RawAnimationData (and associated anim sequence data) private
#jira ue-25869
Change 3146680 on 2016/09/30 by Benn.Gallagher
Fixed errant asterisks in tooltips for source and target bone on rotation multiplier controller node
#jira UE-29847
Change 3146681 on 2016/09/30 by Benn.Gallagher
Fixed incorrect tooltip on left hand IK bone in hand ik retargetting node
#jira UE-30885
Change 3146711 on 2016/09/30 by Jon.Nabozny
Fix PhAT SnapConstraintToBone.
#jira UE-31491
Change 3146717 on 2016/09/30 by Danny.Bouimad
Adding Jurres really useful merge actor test assets to somewhere QA can get em.
Change 3146738 on 2016/09/30 by Martin.Wilson
Fix pose blending for on non-additive pose blending + remove normalising of weights for weights less than 1
#tests Editor tests with mambo pose asset
#jira UE-36189
Change 3146750 on 2016/09/30 by Jurre.deBaare
Material baking issue
#misc Removed the renderer initialization which causes issue the first time you would render out a material (gradient from top left to bottom right over the texture)
#misc Replaced incorrect masks with _way_ better approach thanks to Martin
Change 3146755 on 2016/09/30 by Jurre.deBaare
Need better progress bar for HLOD
#fix replaced the progress updates with new more 'correct' ones according to the actual workload and fixed up the Simplygon progress callback
#jira UE-34334
Change 3147085 on 2016/09/30 by Marc.Audy
PR #2815: GetNextViewablePlayer now checking and returning correct PlayerState. (Contributed by joshkay)
#jira UE-36632
Change 3147224 on 2016/09/30 by Martin.Wilson
CIS Fix
Change 3147280 on 2016/09/30 by Marc.Audy
Mouse smoothing should use application frame rate, not the dilated game frame rate
#jira UE-31040
Change 3147446 on 2016/09/30 by Aaron.McLeran
UE-36682 SoundCue Delay Not Consuming Input StartTime Correctly
Change 3147693 on 2016/09/30 by Ben.Zeigler
#jira UE-36657
If a player has an existing Pawn during RestartPlayer, use that pawn's rotation instead of the start spot, because we were already keeping the pawn's location
Change 3147697 on 2016/09/30 by Jon.Nabozny
Add rotation parameter to FBodyInstance::Sweep and FBodyInstance::InternalSweepPhysX
#jira UE-30486
Change 3147761 on 2016/09/30 by Jon.Nabozny
Fix AUTRepulsorBubble UPrimitiveComponent::SweepComponent usage.
Change 3148533 on 2016/10/03 by Thomas.Sarkanen
Fix new deprecation warnings introduced by the pull from main
Change 3148567 on 2016/10/03 by Marc.Audy
Fix crash when exiting PIE while a panoramic screenshot is being taken
Make stereo panorama tick with the world it is operating on
#jira UE-36492
Change 3148571 on 2016/10/03 by Marc.Audy
Allow modification of components that are EditAnywhere but don't exist in the CDO
#jira UE-36694
Change 3148607 on 2016/10/03 by Martin.Wilson
Properly end notify states when we clear the anim instance on a skeletal mesh.
#jira UE-32488
Change 3148711 on 2016/10/03 by Martin.Wilson
Fix type in virtual bone tooltip
#jira UE-36703
Change 3148746 on 2016/10/03 by Benn.Gallagher
Fixed a few cases where post process and sub instance anim calls weren't being made correctly.
#jira UE-36529
Change 3148807 on 2016/10/03 by Martin.Wilson
Fix mismatch skeleton error when undoing virtual bone changes
#jira UE-36705
Change 3148812 on 2016/10/03 by Martin.Wilson
Add undo support to removing virtual bones
#jira UE-36706
Change 3148975 on 2016/10/03 by Jurre.deBaare
Issue with combining meshes both with/without normal maps
#fix make sure we always output atleast the default normal value when baking out materials, this to ensure we output non-black values for meshes without normal maps (this would cause the normal to be incorrect)
#misc fixed issue in function to set texture rectangle to a single colour
#misc spotted comparison error
Change 3148976 on 2016/10/03 by Ori.Cohen
Make sure that shape queries that we pass into physx are never size 0. Fixes some NaNs
#JIRA UE-36639
Change 3148991 on 2016/10/03 by Jurre.deBaare
Changing LOD materials on Merged Actors Crashes Editor
#fix take into account LOD that is using the material when remapping (removing duplicate) materials
#jira UE-35883
Change 3148997 on 2016/10/03 by Jurre.deBaare
Make sure we remove matrix samples that fall outside of the import range and remap those that are in range
Change 3149002 on 2016/10/03 by Jurre.deBaare
Issues with importing Alembic caches using matrix transformations
#fix Apply conversion matrix to imported matrix samples to make them match the DCC package they were exported from
Change 3149030 on 2016/10/03 by Martin.Wilson
Dont show save warning on animations when we have curve data
#jira UE-34145
Change 3149115 on 2016/10/03 by Mieszko.Zielinski
Made PathfollowingComponent distinct between patrial and full paths in terms of acceptance radius used, when trying to determin if pathing agent is at goal location #UE4
#jira UE-35153
Change 3149186 on 2016/10/03 by Ben.Zeigler
#UE-36722 Fix failure to spawn when trying to spawn 4 capsules in the exact same location
There's no "Correct" direction to move out of a penetrating capsule, but old PhysX appeared to be consistent. New PhysX is not, so now we save and restore the adjustment instead of letting previous iterations modify it.
This code is weird but this solution is better than the old version and handles inconsistent results
Change 3149235 on 2016/10/03 by Martin.Wilson
Change inline curve name editing to only change the name of that specific curve, instead of renaming the smart name itself.
#jira UE-20005
Change 3149245 on 2016/10/03 by Marc.Audy
Remove duplicate entries from AttachChildren caused by lack of atomic cross-object updates.
Change 3149397 on 2016/10/03 by Ori.Cohen
Fix collision profile writing out response values to channels that don't exist.
#JIRA UE-36359
Change 3149679 on 2016/10/03 by Zak.Middleton
#ue4 - Don't mark CharacterMovementComponent::bUseControllerDesiredRotation as an advanced property. Consolidate rotation settings (RotationRate, bUseControllerDesiredRotation, bOrientRotationToMovement) in a new "Rotation Settings" category.
Change 3149929 on 2016/10/04 by Jurre.deBaare
Fix for CIS errors
#fix Mac didn't like undefined struct
Change 3149977 on 2016/10/04 by danny.bouimad
Massive update to Merge Actor test files
Change 3150014 on 2016/10/04 by James.Golding
UE-36686 Fix crash when slicing and not creating other section
Change 3150016 on 2016/10/04 by James.Golding
UE-35335 MergeActors now converts box collision to convex, so collision scales correctly after merging
Change 3150019 on 2016/10/04 by James.Golding
UE-36737 Fix LineTraceComponent not returning face index
Change 3150020 on 2016/10/04 by James.Golding
UE-36672 Export PhysicsContstraintComponent class so it can be subclassed outside Engine module
Change 3150027 on 2016/10/04 by Ben.Marsh
Add PhysX build option into Dev-Framework.
Change 3150042 on 2016/10/04 by Benn.Gallagher
Fixed clothing example 1.3 collision glitches
Change 3150172 on 2016/10/04 by Benn.Gallagher
Made Skeletal Mesh LOD reimports clear any existing simplification flag so we don't show "generated" next to LOD entries for them.
#jira UE-36589
Change 3150319 on 2016/10/04 by Ori.Cohen
Go back to only deferring body creation per component. This can now use the slow path when needed. Can't support deferring of multiple components without changing locking API so we'll do that in the future.
#JIRA UE-36535, UE-36504
Change 3150355 on 2016/10/04 by Zak.Middleton
#ue4 - Change checkSlow() to check() in GetDefaultObject<> because this is potentially an unsafe static cast.
Change 3150370 on 2016/10/04 by Ori.Cohen
Fix deferred actors not getting flushed.
Change 3150386 on 2016/10/04 by Martin.Wilson
Fix additive animation check failing in cooked builds when using virtual bones
#jira UE-36743
Change 3150424 on 2016/10/04 by Ori.Cohen
Exclude kinematic actors from active transforms generation.
Change 3150613 on 2016/10/04 by Zak.Middleton
#ue4 - Fix bad GetDefaultObject<> in AbilitySystemGlobals. Turned up since changing checkSlow() to check() in GetDefaultObject.
(Mirror CL 3138304 in Orion-DevGeneral)
#jira UE-36810
#tests compiled
Change 3150679 on 2016/10/04 by Ben.Zeigler
Crash fix with no async scene
Change 3150765 on 2016/10/04 by Ben.Zeigler
Deprecate UStructProperty::ExportTextItem_Static and ImportItem_Static, and add ExportText and ImportText directly to UScriptStruct
Add bAllowNativeOverride to specify rather to call the native override. For unclear reasons the static export skipped the native override while the static import included it
This allows calling the generic ImportText from inside a native ImportTextItem and then doing some post processing
Change 3150796 on 2016/10/04 by Marc.Audy
Fix LOCTEXT warnings related to blueprint class menu options
Change 3150806 on 2016/10/04 by Ben.Zeigler
Fix bad text format in import error message, lead to double error
Change 3150891 on 2016/10/04 by Ben.Zeigler
#jira UE-36170 Fix duplicate GUID spam when async loading levels during PIE by checking the package flag instead of the runtime global
Change 3150914 on 2016/10/04 by Marc.Audy
Don't try to recreate render state if it has already been recreated while the recreate context was active
#jira UE-36590
Change 3151195 on 2016/10/04 by Dan.Reynolds
Updates to QASoundWaveProcedural
QASoundWaveProcedural edited to be a GameplayStatic which spawns an Audio Component Handler as well as a Procedural Sound Wave. Support for envelope shaping (Attack, Sustain, Release) as well as multiple waveforms (Sine, Triangle, Sawtooth, Square). Blueprint API expanded to include separate functions for setting QASoundWaveProcedural settings and Playing.
Change 3151233 on 2016/10/04 by Ben.Zeigler
#jira UE-36836 Fix variable shadowing warnings
Change 3151328 on 2016/10/04 by dan.reynolds
AEOverview Update - Added Sound Wave Procedural test map and added support for mobile (tested on Android) menu selection - Still a WIP
Change 3151461 on 2016/10/05 by Thomas.Sarkanen
Fix localization warnings
#jira UE-36720 - //UE4/Main: Step 'Build Engine Localization' - 2 Warnings
Change 3151546 on 2016/10/05 by Martin.Wilson
Fix pose watch regression due to persona refactor changes.
#jira UE-36851
Change 3151587 on 2016/10/05 by Jurre.deBaare
Updating Simplygon to SDK version 8.0
#misc removed redundant files
#misc fixed landscape culling in merge actor path
#misc added support for volume culling using simplygon
#misc fixed when or not to use mesh data for material baking
#notes
Change: 3137650
Date: 23/09/2016 07:57
Client: Mustafa.Tungekar_Dev-Partner-Simplygon
User: Mustafa.Tungekar
Status: submitted
Type: restricted
ImportedBy:
Identity:
Description:
-Renamed commandline variables for ZipUtils AutomationScript
-Implemented Execute instead of ExecuteBuild
-Updated commandline arguments in SimplygonSwarm
JobStatus:
Jobs:
Files:
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Private/SimplygonSwarm.cpp#4
//UE4/Dev-Partner-Simplygon/Engine/Source/Programs/AutomationTool/Scripts/ZipUtils.Automation.cs#2
Change: 3137649
Date: 23/09/2016 07:56
Client: Mustafa.Tungekar_Dev-Partner-Simplygon
User: Mustafa.Tungekar
Status: submitted
Type: restricted
ImportedBy:
Identity:
Description:
Moved file hash computation to ImportObject
JobStatus:
Jobs:
Files:
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Classes/Factories/Factory.h#4
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Private/Factories/Factory.cpp#4
Change: 3137646
Date: 23/09/2016 07:55
Client: Mustafa.Tungekar_Dev-Partner-Simplygon
User: Mustafa.Tungekar
Status: submitted
Type: restricted
ImportedBy:
Identity:
Description:
Fixes CL3099204
EditorPerProjectUserSetting
Removed ConfigRestartRequired attribute from properties where it was not required
MeshUtilities
-Added FProxyFailedDelegate
-Extended IMeshMerging to include FProxyFailed delegate
-Added ProxyGenerationFailed method to FProxyGenerationProcessor class
-Setup FailedDelegate for both MeshMerging and DistributedMeshMerging
SimplygonMeshReduction
-Added check for invalid texture id
-Updated notes and removed commented code that is not required.
-Setup failed delegate
-Fixed issue where image data was never hooked into the texture.
-Fixed issue where texture table was never passed into casters
SimplygonSwarm
-Setup failed delegate
-Fixed RawMesh pointer usage.
-Move helper method into SimplygonSwarmHelpers.h.
-Added SimplygonSwarmHelpers
-Removed redundant constant path to 7-zip
-Removed GetSimplygonDirectory instead using inplace.
-Removed commented code that is currently not required.
-Fixed Typos
JobStatus:
Jobs:
Files:
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/MeshUtilities/Private/MeshUtilities.cpp#3
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/MeshUtilities/Public/MeshUtilities.h#3
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonMeshReduction/Private/SimplygonMeshReduction.cpp#4
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Private/SimplygonSwarm.cpp#3
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Public/SimplygonSwarmHelpers.h#1
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Classes/Editor/EditorPerProjectUserSettings.h#3
Change: 3099204
Date: 24/08/2016 07:56
Client: Mustafa.Tungekar_Dev-Partner-Simplygon
User: Mustafa.Tungekar
Status: submitted
Type: restricted
ImportedBy:
Identity:
Description:
Simplygon 8.0 Updates
Deprecated support for 7.0 and updated SimplygonSwarm and SimplygonMeshReduction to use 8.0
EditorPerProjectSettings
*SwarmMaxUploadChunkSizeInMB for limiting the max upload size for swarm. Note the Simplygon Grid has a limitation of 2GB
*SwarmNumOfConcurrentJobs for executing number of concurrent jobs
*Fixed issue where SG_MATERIAL_CHANNEL_METALLIC to SG_MATERIAL_CHANNEL_METALNESS (Chage in 8.0 SDK)
SPL, SimplygonSwarm, RESTClient
*Bumped up SPL Version to 8
*Fixed code paths to use ZipUtils UAT script for zipping and unzipping CL3094374
*Removed SPL Templates for version 7.0
*Added conditional logging to REST methods
*Added multi part upload. The RESTClient automatically decided if large files need to be split up before uploading to simplygon grid.
*Updated method to take in texturepath
SimplygonMeshReduction
*Removed minimum version requirement.
*Bumped up minimum version
*Chagned license file name to refelect 8.0 changes
*MaterialBaking related method now take in TextureTable as an extra parameter. This is due to 8.0 move away from old way of setting up materials and using SimplygonShadingNetowrk based appraoch.
JobStatus:
Jobs:
Files:
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonMeshReduction/Private/SimplygonMeshReduction.cpp#3
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonMeshReduction/Public/SimplygonTypes.h#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Private/SimplygonRESTClient.cpp#3
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Private/SimplygonSwarm.cpp#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Public/SimplygonRESTClient.h#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Public/SimplygonSwarmPrivatePCH.h#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Classes/Editor/EditorPerProjectUserSettings.h#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Private/Settings/EditorPerProjectUserSettings.cpp#2
Change: 3099200
Date: 24/08/2016 07:48
Client: Mustafa.Tungekar_Dev-Partner-Simplygon
User: Mustafa.Tungekar
Status: submitted
Type: restricted
ImportedBy:
Identity:
Description:
#fix Copy constructor for FMeshReduciton mapped ShadingImportance to SilhouetteImportance
JobStatus:
Jobs:
Files:
//UE4/Dev-Partner-Simplygon/Engine/Source/Runtime/Engine/Classes/Engine/MeshMerging.h#2
Change: 3099199
Date: 24/08/2016 07:47
Client: Mustafa.Tungekar_Dev-Partner-Simplygon
User: Mustafa.Tungekar
Status: submitted
Type: restricted
ImportedBy:
Identity:
Description:
Added Automation Script ZipUtils to zip file and unzip files from SimplygonSwarm.
This will remove any dependency on external zip program and should work across platforms
JobStatus:
Jobs:
Files:
//UE4/Dev-Partner-Simplygon/Engine/Source/Programs/AutomationTool/Scripts/AutomationScripts.Automation.csproj#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Programs/AutomationTool/Scripts/ZipUtils.Automation.cs#1
Change: 3099197
Date: 24/08/2016 07:40
Client: Mustafa.Tungekar_Dev-Partner-Simplygon
User: Mustafa.Tungekar
Status: submitted
Type: restricted
ImportedBy:
Identity:
Description:
*Speed improvements for FBX Scene Importer
*Added a static method to compute Hash.
JobStatus:
Jobs:
Files:
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Classes/Factories/Factory.h#3
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Private/Factories/Factory.cpp#3
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Private/Fbx/FbxStaticMeshImport.cpp#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Runtime/Engine/Classes/EditorFramework/AssetImportData.h#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Runtime/Engine/Private/EditorFramework/AssetImportData.cpp#2
Change 3151664 on 2016/10/05 by Richard.Hinckley
Fixing ACharacter template for "New C++ Class" feature. Avoiding naming a function parameter the same as an existing class member.
Change 3151729 on 2016/10/05 by Thomas.Sarkanen
Audit of remaining NaN checks
Some checks remain on in shipping (generally those called from blueprint):
- AActor::TeleportTo
- AActor::SetActorRelativeScale3D
#jira UE-30999 - Optimize ⌠ContainsNaN÷ and ⌠ContainsNaNOrInfinite÷, audit those still in shipping/test
Change 3151742 on 2016/10/05 by Ori.Cohen
Make sure that if physical animation component doesn't find a body and bone it doesn't crash.
#JIRA UE-36839
Change 3151756 on 2016/10/05 by Jurre.deBaare
Fixing d3dcompiler_47.dll missing issue
#fix added runtime dependency and dll name to build.cs file
#fix now load the d3dcompiler_47.dll from the Binaries/ThirdParty/Windows folder before loading the simplygon DLL
Change 3151761 on 2016/10/05 by Thomas.Sarkanen
Fix deprecation warning from last integration
Moved Preview to EditorPreview in FEditorWorldManager::OnWorldContextAdd.
#jira UE-36858 - Compile UE4Editor* completed with 1 warning
Change 3151782 on 2016/10/05 by Jurre.deBaare
Simplygon patch up
#misc linker errors popping up from JSONCPP
#misc incorporated emissive material property fix from other shelve
#misc static analysis fix
Change 3151804 on 2016/10/05 by Marc.Audy
Clear need end of frame update when unregistering a component
Change 3151928 on 2016/10/05 by Ori.Cohen
Fix runtime DLLs not including all delay loaded physx dll files.
#JIRA UE-36816
Change 3151977 on 2016/10/05 by Martin.Wilson
Notifies can no longer occupy the same time on the same track.
#jira UE-30658
Change 3151989 on 2016/10/05 by Jon.Nabozny
Fix ArchVis character rotation pitch when looking up/down.
#jira UE-35706
Change 3152083 on 2016/10/05 by Marc.Audy
Ensure that pending kill components get their marked for end of frame state cleared.
Change 3152086 on 2016/10/05 by Ben.Zeigler
#jira UE-36169 Fix it so missing linker errors that point to Blueprint CDOs are skipped, the same way it skips linker errors going to the actual class. Fixes a lot of spurious warnings from deleting components from blueprints or native classes
Clean up the VerifyImport error handling so it also displays in -game and cook, and fix the missing class warning to work properly, previously it would happen 0% in development 100% in debug even if the class was valid
Change 3152093 on 2016/10/05 by Marc.Audy
Change logic for when location cannot be changed for a static component to be independent of has begun play and have to do with whether construction script is running or the level is in the process of loading (mostly for backwards compatibility adjustments in post load).
#jira UE-36146
#jira UE-24647
Change 3152100 on 2016/10/05 by Ben.Zeigler
Remove pragma optmize
Change 3152112 on 2016/10/05 by Marc.Audy
Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3152072
Change 3152134 on 2016/10/05 by Jurre.deBaare
Simplygon/Merge actor issues
#fix for emissive output on meshes that do not have emissive properties
#fix for texture binning, not removing invalid split area causing overlapped textures
Change 3152136 on 2016/10/05 by James.Golding
UE-36859 Fix tooltip saying you can click to stop recording
Change 3152169 on 2016/10/05 by James.Golding
UE-31209 UE-30935 : Expose bDeformableMesh and bFastCook options in FTriMeshCollisionData
ProceduralMeshComponent will now cook using 'fast' and 'deformable' options, so updating collision on sections should work correctly
Change ERuntimePhysxCookOptimizationFlags to EPhysXMeshCookFlags and use that to pass options to CookConvex and CookTriMesh
Change 3152202 on 2016/10/05 by Jurre.deBaare
Mac/Linux fix
Change 3152303 on 2016/10/05 by Marc.Audy
Fix deprecation warning post merge from main
Change 3152320 on 2016/10/05 by Martin.Wilson
Fix root motion from everything calculating incorrect root motion when animations haven't been ticking
#jira UE-35364
Change 3152354 on 2016/10/05 by James.Golding
PoseDriver should pass through if no poses activated
Change 3152357 on 2016/10/05 by James.Golding
UE-36844 Remove unused OnAssetModifiedNotifier delegate from PoseAsset, ensure OnPoseListChanged is called when updating PoseAsset from anim.
Change 3152556 on 2016/10/05 by Marc.Audy
Remove autos
Change 3152560 on 2016/10/05 by Marc.Audy
Don't allow child actor references to be dragged from the outliner to a level script
#jira UE-16700
Change 3152568 on 2016/10/05 by Marc.Audy
Don't allow non-networking code to set bRemoteOwned in the actor spawn parameters
Remove deprecated bNoCollisionFail
#jira UE-35928
Change 3152575 on 2016/10/05 by Marc.Audy
Allow construction script to run post move for native classes. Actor can determine whether it should only occur on finish or every call to post edit move
Change 3153101 on 2016/10/06 by Thomas.Sarkanen
Fix crash re-opening the viewport in Persona-based editors
#jira UE-36775 - Editor crashes when re-opening viewport in Persona
Change 3153139 on 2016/10/06 by James.Golding
UE-36908 Remove GetRuntimeOnlyCookOptimizationFlags if cooking is not supported
Change 3153160 on 2016/10/06 by Thomas.Sarkanen
Fix for crash when deleting additive layer track
Code had not been updated to use the new delgate system (was still using reciprocal FPersona ptr).
#jira UE-36740 - Crash when removing or disabling an additive layer track in Persona
Change 3153175 on 2016/10/06 by Benn.Gallagher
Fixed crashes when using subinstances in non-default states. we previously initialized the anim instances in the node initialize, but in states that haven't been hit by an initialize this will happen off the game thread which is not allowed.
#jira UE-36900
Change 3153223 on 2016/10/06 by Thomas.Sarkanen
Fixed crash when opening an asset from the blend space editor
Code was still trying to open 'old' Persona when it was disabled.
Also fix other call sites where this was being done outside of asset type actions.
#jira UE-36766 - Crash attempting to open an asset from Aim Offset graph in Persona
Change 3153324 on 2016/10/06 by Thomas.Sarkanen
Prevented invalid GUIDs from being saved into smart name containers
AddOrFindName now checks to see if existing GUIDs are valid before using them.
AddName now requires a valid GUID to be passed in.
Also added Modify() call to the skeleton when FindOrAddSmartName is called from VerifySmartNameInternal, as without this the skeleton might not get saved.
Also add Laurent's fix for fixing up already-saved invalid GUIDs (CL 3138068).
#jira UE-36367 - It is possible for curves with an invalid GUID to be saved into the USkeleton asset
Change 3153348 on 2016/10/06 by Martin.Wilson
Re add ticking code so all Persona editors viewports tick during drag events (went missing in Persona refactor)
#jira UE-36751
Change 3153426 on 2016/10/06 by Mieszko.Zielinski
Added missing elements of block comments support in BT editor #UE4
Change 3153454 on 2016/10/06 by Benn.Gallagher
Fixed crash using anim debug with subinstances that are preceded by branching nodes.
#jira UE-36935
[CL 3153517 by Ori Cohen in Main branch]
2016-10-06 12:11:11 -04:00
# if ENABLE_DRAW_DEBUG
2018-02-22 11:25:06 -05:00
if ( IKChain . bInitialized & & IKChain . MyAnimInstanceProxy )
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
{
for ( int32 Index = 0 ; Index < IKChain . NumLinks - 1 ; Index + + )
{
2018-02-22 11:25:06 -05:00
const FVector CurrentBoneWorldLoc = GetBoneWorldLocation ( FTransform ( IKChain . Links [ Index ] . Location ) , IKChain . MyAnimInstanceProxy ) ;
const FVector ParentBoneWorldLoc = GetBoneWorldLocation ( FTransform ( IKChain . Links [ Index + 1 ] . Location ) , IKChain . MyAnimInstanceProxy ) ;
IKChain . MyAnimInstanceProxy - > AnimDrawDebugLine ( CurrentBoneWorldLoc , ParentBoneWorldLoc , InColor , false , - 1.f , 1.f ) ;
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
}
}
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3153514)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3050254 on 2016/07/14 by Marc.Audy
Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3049614
Change 3136629 on 2016/09/22 by Marc.Audy
bye bye auto
Change 3136631 on 2016/09/22 by Marc.Audy
Allow objects to be marked as duplicate transient or non PIE duplicate transient
ChildActors are not marked consistent with the property that references them as text export transient and non PIE duplicate transient
#jira UE-35680
Change 3136636 on 2016/09/22 by Marc.Audy
ParticleSystem and Audio Components now route Activate/Deactivate events to blueprints
Component Activate/Deactivate events now provide component as a property
#jira UE-35191
Change 3136640 on 2016/09/22 by Marc.Audy
Expose bReplicates to blueprint component properties
#jira UE-34433
Change 3136709 on 2016/09/22 by Ori.Cohen
Fix GetBodyInstance returning incorrect bodies when welded kinematics are attached.
#JIRA UE-36234
Change 3136710 on 2016/09/22 by Ori.Cohen
Fix defer actors not working when the physics scene is simulating. We now flush when the scene is not simulating, as well as a lazy flush that goes through the slow path when needed. This allows us to batch multiple components together.
#JIRA UE-35899
Change 3136770 on 2016/09/22 by Marc.Audy
Fix compile error
Change 3136854 on 2016/09/22 by Marc.Audy
Sprite components need to be text export transient
#jira UE-36064
Change 3136926 on 2016/09/22 by Ori.Cohen
Fix ensure when skeletal mesh bodies have no collision.
Change 3137054 on 2016/09/22 by Aaron.McLeran
PR #2628: Fix UAudioComponent SubtitlePriority not being initialised (Contributed by alanedwardes)
Change 3137058 on 2016/09/22 by Aaron.McLeran
PR #2562: ReadCompressedInfo calculates duration for ADPCM audio (Contributed by derekvanvliet)
Change 3137060 on 2016/09/22 by Aaron.McLeran
UE-36336 Fixing A3D for mono/2D sounds
- Making it so if A3D is being loaded but not enabled, we can not have reverb on 2D sounds
- Fixing A3D mono sources from failing after a time
Change 3137066 on 2016/09/22 by Aaron.McLeran
Checking in Ngs2.Build.cs with A3D and USING_A3D set to 0
Change 3137098 on 2016/09/22 by dan.reynolds
AEOverview Update: EQ Map, Reverb Map plus improvements on Main array cleanup process.
Change 3137132 on 2016/09/22 by Aaron.McLeran
PR #2789: Fixed signature of FActiveSound::GetIntParameter (Contributed by Laurie-Hedge)
Change 3137175 on 2016/09/22 by Aaron.McLeran
Fixing compile error with PhysXCollision.cpp from CL 3136710
Change 3137540 on 2016/09/23 by Thomas.Sarkanen
Fixed crash when generating LODs automatically for skeletal meshes
Quadric error reduction does not support skeletal meshes, so fails. Client code assumes that it cannot fail so crashed. This guards against immediatly assuming that LODs are valid after simplification.
#jira UE-36253 - Crash applying LOD changes in Persona
Change 3137720 on 2016/09/23 by Thomas.Sarkanen
Changed asset shortcut bar to display asset names & reworked padding
#jira UE-36347 - Anim asset shortcut bar has difficult to read/cut-off text
Change 3137761 on 2016/09/23 by Martin.Wilson
Fix typo in root motion from everything accumulation code
Change 3137877 on 2016/09/23 by Thomas.Sarkanen
Fixed undo/redo forcing skeletal meshes into t-pose
Re-populated AnimationData in InitAnim for UDebugSkelMeshComponent.
#jira UE-35579 - If you undo an animation change to any animation asset (for single preview), the playback controls will no longer function
Change 3137885 on 2016/09/23 by Benn.Gallagher
Fixed APEX clothing disappearing when time dilation results in a dt of 0. After simulating an actor with 0 APEX will fill positions and normals with NaNs, causing the disappearance. The fix in this case is to not schedule the evaluation task if we're not wanting to do any work. The simulation then freezes as we would expect.
#jira UE-35151
Change 3137888 on 2016/09/23 by Benn.Gallagher
Fixed transition nodes being able to be pasted or duplicated without 2 valid pin links
#jira UE-24860
Change 3137889 on 2016/09/23 by Benn.Gallagher
Fixed transform and widget inconsistencies in IK edit mode
#jira UE-20628
Change 3137890 on 2016/09/23 by Jurre.deBaare
Alembic Cached Geometry Does Not Display in Stand Alone Game
#fix required to force load the GeometryCache module during runtime
#jira UE-36187
Change 3137892 on 2016/09/23 by Jurre.deBaare
Geometry cache playback should work in sequencer
#fix add Interp UProperty tag to specific properties used for playing back the cache, future fix is having same approach as skeletal mesh animation for sequencer (depends on needs, -> skeletal mesh import has better compression anyway)
#jira UE-35447
Change 3137893 on 2016/09/23 by Jurre.deBaare
Alembic Cache Importer option for Hard Edge Angle Threshold does not work for objects with no normals
#fix adhere to the assumed 'standard' no normals in ABC file means completely smooth normals throughout the sequence
#jira UE-35091
Change 3137894 on 2016/09/23 by Jurre.deBaare
Importing an Alembic File While mesh Distance Fields are Enabled Crashes Editor
#fix Needed to save the raw mesh before building the mesh to ensure a LOD resource was created
#misc added a new check + message in case this occurs again
#jira UE-36059
Change 3137938 on 2016/09/23 by Jurre.deBaare
Alembic Importing with Incorrect UV's
#fix adding option for flipping UVs on import
#jira UE-36190
Alembic import axis not aligned correctly
#fix also added option to specify scale and rotation to be applied during import (with preset for Maya and Max)
#jira UE-35510
Change 3137949 on 2016/09/23 by Jurre.deBaare
Frame range importing causes confusion during Alembic importing
#fix this required storing information per Alembic object at which frame index it actual has stored frames, using this data we can determine which frames are empty, and at which frame there is data. This allows us to skip empty frames if we want to import data-only frames, or to import all frames in the sequence including empty (pre-roll) frames.
#misc changed settings UI listview layout (extra columns and resized old ones)
#jira UE-35498
Change 3137994 on 2016/09/23 by Martin.Wilson
Fix for creating an empty state when dragging a montage into a state machine graph
#jira UE-33371
Change 3138103 on 2016/09/23 by Aaron.McLeran
UE-36312 Fixing sound node distance cross fade for case of looping sounds
Change 3138104 on 2016/09/23 by Aaron.McLeran
UE-35392 Copy pasting local node into separate project crashes the engine
Change 3138224 on 2016/09/23 by Aaron.McLeran
UE-36312 Fixing sound node distance cross fade for case of looping sounds
- Adding a check for wave instance count to account for virtualized sounds (one-shots)
Change 3138666 on 2016/09/23 by Ben.Zeigler
#UEFW-204 Add more comprehensive gameplay tag tests
Fix issue with HasTag(Tag, IncludeParent, IncludeParent) revealed by tests, this was not returning true correctly in some cases. This use case is weird and will be deprecated soon
Change 3138779 on 2016/09/23 by Marc.Audy
Get rid of pointless casts
Change 3138782 on 2016/09/23 by Marc.Audy
remove some GWorlds
Change 3139701 on 2016/09/26 by Jurre.deBaare
Assert failed on GemetryCache for PS4 package
#fix add GeometryCache reference in engine build.cs and fix the serialization of geometry cache files
#jira UE-36392
Change 3139704 on 2016/09/26 by Jurre.deBaare
Fix for -1 begin frame
#fix do the max as an signed int, to make sure we don't wrap around
Change 3139748 on 2016/09/26 by Benn.Gallagher
PR #2784: Make sure that SceneScratchBufferSize is a multiple of 16K as requested by PhysX (Contributed by DenizPiri)
Moved the definition of the boundary to a FPhysScene class static
Changed comments on original user settings property to communicate the fact that the value is now rounded to the next 16K boundary
#jira UE-35736
Change 3139903 on 2016/09/26 by Benn.Gallagher
Fixed exposing subinstance pins stomping over class defaults and setting to uninitialized values
#jira UE-34366
Change 3140409 on 2016/09/26 by Lukasz.Furman
fixed uninitialized configs of gameplay debugger
copy of CL# 3140399
Change 3140516 on 2016/09/26 by dan.reynolds
AEOverview Map Update - Ambient Zone + Focus Test
Change 3140526 on 2016/09/26 by Jon.Nabozny
#rn Fixed CanJump inconsistencies with previous versions.
Deferred JumpCurrentCount increment until after jump, made bWasJumping a member variable, and updated how
jump count and hold time were compared in CanJump.
#jira UE-35524, UE-35582
Change 3140745 on 2016/09/26 by dan.reynolds
AEOverview Test Map Update + Occlusion Test
Change 3140839 on 2016/09/26 by dan.reynolds
AEOverview - minor updates
Change 3141101 on 2016/09/27 by Thomas.Sarkanen
Preview scene worlds now render correctly
Split "Preview" type into "EditorPreview" (the default) and "GamePreview". Deprecated the old "Preview" world type (but kept its index).
In-game hidden flags now apply to GamePreview, but not EditorPreview worlds.
Deprecated old bHack_Force_UsesGameHiddenFlags_True boolean. GamePReview now serves this purpose.
Fixed up UT cases where this was being used.
FPreviewScenes now use the editor mode by default, but can be set to non-editor if needed (as is the case with the still-experimental UViewport).
Custom depth pass is not enabled for EditorPreview (as before) but is for GamePreview.
Fixed erroneous use of TEnumAsByte for non-uproperty WorldType.
#jira UE-22883 - Using FPreviewScenes in-game for scene captures
Change 3141106 on 2016/09/27 by Thomas.Sarkanen
Column toggling improvements
Column toggle menu now does not close when items are selected.
This requries some Slate changes to how submenus are built to allow for sumbenus to specify whether they close after selection.
Also allowed columns to be hidden by default for specific use cases (like the sequence browser).
#jira UE-35818 - Anim asset browser column picker should stay up
Change 3141131 on 2016/09/27 by Thomas.Sarkanen
Fix CIS warnings
Fallout from preview world changes
Change 3141143 on 2016/09/27 by Jurre.deBaare
Fix for CIS errors
Change 3141235 on 2016/09/27 by Thomas.Sarkanen
Fix offset of Persona floor mesh when auto-alignment is enabled
When auto alignment was disabled, the offset wasnt getting taken into account.
#jira UE-35544 - In Persona, Floor Height Offset does nothing with Auto Align Floor to Mesh disabled
Change 3141327 on 2016/09/27 by Marc.Audy
Ensure that the client side AttachChildren array remains accurate
#jira UE-26025
Change 3141474 on 2016/09/27 by mason.seay
Updating test map name and moving PlayerStart
Change 3141501 on 2016/09/27 by Benn.Gallagher
Loading time improvements for destructibles from Nvidia
Updated to use new framework custom version instead of global object version
Fixed usage of TArray to enable correct loading and saving of the cached data.
#jira UE-29680
Change 3141889 on 2016/09/27 by Marc.Audy
Fix DestructibleMesh when WITH_APEX is 0
#jira UE-36484
Change 3142034 on 2016/09/27 by Marc.Audy
Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3141971
Change 3142131 on 2016/09/27 by Ori.Cohen
Make sure we return eTouch to physx during an overlap query. Fixes bad behavior when multiple objects blocked in an overlap query.
#JIRA UE-36381
Change 3142154 on 2016/09/27 by Ori.Cohen
Fix build, ModuleCachedData instead of NxApexModuleCachedData
Change 3142159 on 2016/09/27 by mason.seay
Blueprint for testing Child Actor Templates
Change 3142255 on 2016/09/27 by Jon.Nabozny
Fix crashes in QAMeshMerge component by making it a UObject, exposing it's method statically, and taking QASkeletalMeshMergeParams as an argument.
#jira UE-35199, UE-35197, UE-35201
Change 3142717 on 2016/09/27 by dan.reynolds
AEOverview Update + Sound Class Test
Change 3142764 on 2016/09/27 by Marc.Audy
Fix Ocean deprecation warnings
Change 3142962 on 2016/09/28 by Thomas.Sarkanen
Fixed bounds calculations for local camera animations
Correctly calculated bounds as local to the initial transform in the track.
Implemented suggested fixes from UDN user chhaddon (The Coalition).
#jira UE-29594 - CameraAnim bounds are incorrect when bRelativeToInitialTransform == true
Change 3143007 on 2016/09/28 by Martin.Wilson
Added virtual bones to USkeleton
API Breaking change:
-Added USkeleton pointer to RemoveBonesByName
-FReferenceSkeleton::UpdateRefPoseTransform & FReferenceSkeleton::Add made private. Must use FReferenceSkeletonModifier instead
#jira UEFW-81
Change 3143040 on 2016/09/28 by James.Golding
Strip DrawDebug.. functions from Shipping and Test builds, controlled by new define ENABLE_DRAW_DEBUG
Fix up game projects to compile in Shipping/Test after this change
PR #2757: (Contributed by projectgheist)
#jira UE-35488
Change 3143046 on 2016/09/28 by James.Golding
Fix OrionEnvironmentPerfTest.cpp compiling in Shipping (optimizations were not being re-enabled at end of file)
Change 3143047 on 2016/09/28 by James.Golding
PR #2731: Capsule primitive drawing fix (Contributed by kamrann)
#jira UE-35142
Change 3143050 on 2016/09/28 by Martin.Wilson
Update DDC key as some animation have stale data
Change 3143088 on 2016/09/28 by Martin.Wilson
CIS Fixes for Ocean after FReferenceSkeleton changes
Change 3143090 on 2016/09/28 by Benn.Gallagher
Fixed split pins in animation blueprints losing their pin links on editor restart. The anim nodes had opted out of the Super version of reconstruct, but that's where split pin restoration was added so we were skipping it.
#jira UE-36482
Change 3143091 on 2016/09/28 by Thomas.Sarkanen
Fix play/pause keyboard shortcut toggle in Persona based editors
Correctly handled widget mode switching in the skeleton selection edit mode (previously it was manually handling this rather than hooking into the correct level viewport callbacks).
Added the ability for FEdModes to specify whether they can use a widget mode.
Added a common set of commands that all Persona-based editors can opt into (only contains TogglePlay for now).
#jira UE-35163 - Cannot use Play/Pause shortcut in Persona if viewport is focused
Change 3143100 on 2016/09/28 by James.Golding
UE-32275 Fix Anim Curve entries losing Auto state when hidden/reshown
Change 3143107 on 2016/09/28 by Martin.Wilson
Add check to IsRunningParallelEvaluation to verify that the skeletal mesh component in question still references us
#jira UE-34431
Change 3143125 on 2016/09/28 by Jurre.deBaare
PR #2749: Fix blend space triangulation (Contributed by tmiv)
Change 3143225 on 2016/09/28 by Jurre.deBaare
Mesh/material merging basic test files
Change 3143235 on 2016/09/28 by Martin.Wilson
Fix issue where montage wrong section was updated with changes from details panel when clicking on a new section
#jira UE-35929
Change 3143312 on 2016/09/28 by Marc.Audy
Don't globally reregister components, globally recreate render state instead when force deleting assets
Fixes crash force deleting a blueprint with a child actor component in it from the content browser
Change 3143340 on 2016/09/28 by Mieszko.Zielinski
Improved consistency of loudness usage in AISense_Hearing #UE4
Change 3143359 on 2016/09/28 by Marc.Audy
Fix spelling error in comment
Change 3143372 on 2016/09/28 by Jurre.deBaare
HLOD meshes are causing degenerate triangles
#fix Setting flag to ignore degenerate triangles when building the meshes vertex/index buffers
#jira UE-34336
Change 3143420 on 2016/09/28 by Mieszko.Zielinski
Fix to BlackboardData initialization's dependency on parent asset's initialization #UE4
Change 3143421 on 2016/09/28 by Martin.Wilson
Allow reading on animation sequence length in blueprints
#jira UE-34168
Change 3143455 on 2016/09/28 by James.Golding
Add 'noop' versions of DrawDebug function, so you will not get compile errors by default for calling them in Shipping/Test builds.
Added optional SHIPPING_DRAW_DEBUG_ERROR define, which will give compile errors in Shipping/Test if still calling DrawDebug functions
Change 3143518 on 2016/09/28 by Jurre.deBaare
Meshes with no UV Coordinates will break the UVs of other meshes contained in the same HLOD if they share a material
#fix calculate UV bounds and check whether they occupy any space (if not do not use them for baking out the material)
#misc set texture sampling for HLOD proxy base material to clamp
#jira UE-35221
Change 3143542 on 2016/09/28 by James.Golding
Change SHIPPING_DRAW_DEBUG_ERROR define from ifdef to if
Fix comment
Enable by default for FN
Change 3143543 on 2016/09/28 by Benn.Gallagher
Changed branch + early return into an ensure during FPxQueryFilterCallback::preFilter. We were checking for invalid shapes in preFilter but that shouldn't happen. More likely to get some information as an ensure instead of earlying out on the funciton.
Change 3143556 on 2016/09/28 by Aaron.McLeran
UE-36540 Editor Preferences 'Enable Sound' option causes Real Time Audio to Stop Working after PIE
Change 3143566 on 2016/09/28 by Benn.Gallagher
Readded early out alongside new ensure for catching bad preFilter shapes
Change 3143568 on 2016/09/28 by Marc.Audy
Fix deprecation warnings in UT
Change 3143572 on 2016/09/28 by Jurre.deBaare
More test content for mesh/material merging
Change 3143581 on 2016/09/28 by Jurre.deBaare
More content :D
Change 3143585 on 2016/09/28 by Jurre.deBaare
Geometry cache cleaning
#misc fix for missing materials, not serialized (facepalm) as they were added later on (required custom version bump)
#misc cleaning out unecessary code
Change 3143594 on 2016/09/28 by Marc.Audy
Creating a child actor component by dragging an actor blueprint in to another blueprint now properly creates the template
#jira UE-36511
Change 3143658 on 2016/09/28 by Marc.Audy
RootComponent can be null by the time we hit PostUnregisterAllComponents so need to protect against the dereference
#jira UE-36553
Change 3143776 on 2016/09/28 by Marc.Audy
Properly reinstance child actor templates when using the fast reinstancing path
#jira UE-36516
Change 3143896 on 2016/09/28 by Ori.Cohen
Remove UPROPERTY on aggregate threshold which is always read from the physics settings.
Change 3144022 on 2016/09/28 by Ben.Zeigler
Move AIMoveTo node from BlueprintGraph to AIGraph and remove BlueprintGraph->AIModule dependency in build system
Change 3144252 on 2016/09/28 by mason.seay
More blueprints for child actor template testing
Change 3144262 on 2016/09/28 by Mason.Seay
Deleting assets
Change 3144283 on 2016/09/28 by dan.reynolds
AEOverview update + Sound Priority Test
Change 3144411 on 2016/09/28 by dan.reynolds
AEOverview end of day update and tweaks
Change 3144679 on 2016/09/29 by Benn.Gallagher
Changed skeletal bounds calculation to not consider clothing assets that aren't simulating in the current LOD. In this case we're not rendering the clothing, we're only rendering the skeletal geometry for that section in that LOD which isn't bound to cloth.
Change 3144856 on 2016/09/29 by Jurre.deBaare
HLOD Outliner scrolls back to the top when generating proxy meshes
#fix OnLevelActorsAdded was getting called for actors in the thumbnail worlds, which forced a refresh on the listview
#jira UE-30384
Change 3144864 on 2016/09/29 by Thomas.Sarkanen
Preview mesh fixes
Animation preview meshes are now respected (and saved). Mesh is displayed as empty if none is set (but a default is chosen).
Skeleton preview meshes are now shown as empty if none is set (but a default is chosen).
#jira UE-36582 - Cannot set preview mesh per-animation
Change 3144865 on 2016/09/29 by Jurre.deBaare
More test content
Change 3144885 on 2016/09/29 by James.Golding
UE-35307 Move 'invalid scale' warning to Message Log to be more visible in editor
Change scale clamping in UpdateBodyScale to catch cases like (1,0,1)
Change 3144903 on 2016/09/29 by Thomas.Sarkanen
Deprecating StaticMesh in UStaticMeshComponent
Added GetStaticMesh to access the value as read-only.
SetStaticMesh is now called in all locations that used to call "StaticMesh =".
Lots of fixups.
#jira UE-24859 - Deprecate public access to StaticMesh property in UStaticMeshComponent
Change 3145020 on 2016/09/29 by Thomas.Sarkanen
Fix bounds calculations that include bones to respect LOD (and other requried bones)
Sometimes bones would not be updated if we LOD switched, extending the bounds.
#jira UE-36525 - UDebugSkelMeshComponent::CalcBounds should filter by LOD
Change 3145041 on 2016/09/29 by Jurre.deBaare
Setting the Target Lightmap UV Channel to an incorrect value leads to inconsistent results
#fix removed target light map channel, we now determine according to the UV channels which are unused in the final mesh
#misc ignore the source lightmap uv channels to reduce data
#jira UE-36595
Change 3145219 on 2016/09/29 by Benn.Gallagher
Fixed clothing actors not casting shadows in editor, after the material editing change the copy of the shadow flag was missed from the clothing association code, which runs on again on older clothing assets to use the new render data skinning. Also added some fix up for assets that have be saved in the mean time.
#jira UE-36552
Change 3145222 on 2016/09/29 by Jurre.deBaare
Exporting Alembic Skeletal mesh from UE4 to FBX causes a crash
#fix on import set _all_ bone influence to 0
#jira UE-36602
Change 3145267 on 2016/09/29 by Ori.Cohen
Move OnConstraintBreak delegate so that it fires outside of fetchResults. Fixes crash from user doing unsafe things during fetchResults.
#JIRA UE-36483
Change 3145306 on 2016/09/29 by Jon.Nabozny
Fixed PhAT so multiple constraints can be selected and edited properly at the same time.
#JIRA: UE-31493
Change 3145342 on 2016/09/29 by Marc.Audy
Do not update cull distance volumes whenever any property changes
* Any movement or property change of a cull distance volume still does a global update
* Any movement of a component belong to any other Actor updates only the components of that Actor
* Any property change of a primitive component only updates that component
#jira UE-36399
Change 3145958 on 2016/09/29 by Marc.Audy
In game worlds don't auto activate components until the actor is ready to process them
#jira UE-35189
Change 3146110 on 2016/09/29 by dan.reynolds
AEOverview update + Soundwave Procedural Test Map
Change 3146375 on 2016/09/30 by Benn.Gallagher
Fixed crash saving newly created destructible mesh after material refactor.
#jira UE-36619
Change 3146378 on 2016/09/30 by James.Golding
UE-35908 Line trace against a BodyInstance now returns closest hit for trimesh (was any hit before)
Also add stat for FBodyInstance::LineTrace
Change 3146379 on 2016/09/30 by James.Golding
Add test assets for creating procmesh collision in non-editor builds
Change 3146386 on 2016/09/30 by Thomas.Sarkanen
Fixed ensures (and functionality) of 'show uncompressed animation' option in Persona viewports
Made sure that PreEvaluateAnimation is called for th einstance in use, rather than only the preview instance.
This unearthed another issuye where each of the calls to GenSpaceBAses was causing the animation to run faster. Fixed this by resetting the update flag in the update context after it is used.
#jira UE-36251 - Ensures showing uncompressed animations in anim blueprints
Change 3146464 on 2016/09/30 by Thomas.Sarkanen
Fix layered blend per bone odd/even connection counts alternately working/not working
Older hacky fix for multi-property to array copies flip-flipped between using fast path and not, when it really should have disabled fast path after the first array pin. Now it disables fast path based on whether this is a new handler or not, rather than looking at the SimpleCopyPropertyName.
#jira UE-35648 - Layered Blend Per Bone doesn't work correctly with 3+ inputs
Change 3146652 on 2016/09/30 by Benn.Gallagher
Fixed subinstance properties appearing in the caller's details panel as oddly named properties.
#jira UE-34141
Change 3146673 on 2016/09/30 by Martin.Wilson
Make RawAnimationData (and associated anim sequence data) private
#jira ue-25869
Change 3146680 on 2016/09/30 by Benn.Gallagher
Fixed errant asterisks in tooltips for source and target bone on rotation multiplier controller node
#jira UE-29847
Change 3146681 on 2016/09/30 by Benn.Gallagher
Fixed incorrect tooltip on left hand IK bone in hand ik retargetting node
#jira UE-30885
Change 3146711 on 2016/09/30 by Jon.Nabozny
Fix PhAT SnapConstraintToBone.
#jira UE-31491
Change 3146717 on 2016/09/30 by Danny.Bouimad
Adding Jurres really useful merge actor test assets to somewhere QA can get em.
Change 3146738 on 2016/09/30 by Martin.Wilson
Fix pose blending for on non-additive pose blending + remove normalising of weights for weights less than 1
#tests Editor tests with mambo pose asset
#jira UE-36189
Change 3146750 on 2016/09/30 by Jurre.deBaare
Material baking issue
#misc Removed the renderer initialization which causes issue the first time you would render out a material (gradient from top left to bottom right over the texture)
#misc Replaced incorrect masks with _way_ better approach thanks to Martin
Change 3146755 on 2016/09/30 by Jurre.deBaare
Need better progress bar for HLOD
#fix replaced the progress updates with new more 'correct' ones according to the actual workload and fixed up the Simplygon progress callback
#jira UE-34334
Change 3147085 on 2016/09/30 by Marc.Audy
PR #2815: GetNextViewablePlayer now checking and returning correct PlayerState. (Contributed by joshkay)
#jira UE-36632
Change 3147224 on 2016/09/30 by Martin.Wilson
CIS Fix
Change 3147280 on 2016/09/30 by Marc.Audy
Mouse smoothing should use application frame rate, not the dilated game frame rate
#jira UE-31040
Change 3147446 on 2016/09/30 by Aaron.McLeran
UE-36682 SoundCue Delay Not Consuming Input StartTime Correctly
Change 3147693 on 2016/09/30 by Ben.Zeigler
#jira UE-36657
If a player has an existing Pawn during RestartPlayer, use that pawn's rotation instead of the start spot, because we were already keeping the pawn's location
Change 3147697 on 2016/09/30 by Jon.Nabozny
Add rotation parameter to FBodyInstance::Sweep and FBodyInstance::InternalSweepPhysX
#jira UE-30486
Change 3147761 on 2016/09/30 by Jon.Nabozny
Fix AUTRepulsorBubble UPrimitiveComponent::SweepComponent usage.
Change 3148533 on 2016/10/03 by Thomas.Sarkanen
Fix new deprecation warnings introduced by the pull from main
Change 3148567 on 2016/10/03 by Marc.Audy
Fix crash when exiting PIE while a panoramic screenshot is being taken
Make stereo panorama tick with the world it is operating on
#jira UE-36492
Change 3148571 on 2016/10/03 by Marc.Audy
Allow modification of components that are EditAnywhere but don't exist in the CDO
#jira UE-36694
Change 3148607 on 2016/10/03 by Martin.Wilson
Properly end notify states when we clear the anim instance on a skeletal mesh.
#jira UE-32488
Change 3148711 on 2016/10/03 by Martin.Wilson
Fix type in virtual bone tooltip
#jira UE-36703
Change 3148746 on 2016/10/03 by Benn.Gallagher
Fixed a few cases where post process and sub instance anim calls weren't being made correctly.
#jira UE-36529
Change 3148807 on 2016/10/03 by Martin.Wilson
Fix mismatch skeleton error when undoing virtual bone changes
#jira UE-36705
Change 3148812 on 2016/10/03 by Martin.Wilson
Add undo support to removing virtual bones
#jira UE-36706
Change 3148975 on 2016/10/03 by Jurre.deBaare
Issue with combining meshes both with/without normal maps
#fix make sure we always output atleast the default normal value when baking out materials, this to ensure we output non-black values for meshes without normal maps (this would cause the normal to be incorrect)
#misc fixed issue in function to set texture rectangle to a single colour
#misc spotted comparison error
Change 3148976 on 2016/10/03 by Ori.Cohen
Make sure that shape queries that we pass into physx are never size 0. Fixes some NaNs
#JIRA UE-36639
Change 3148991 on 2016/10/03 by Jurre.deBaare
Changing LOD materials on Merged Actors Crashes Editor
#fix take into account LOD that is using the material when remapping (removing duplicate) materials
#jira UE-35883
Change 3148997 on 2016/10/03 by Jurre.deBaare
Make sure we remove matrix samples that fall outside of the import range and remap those that are in range
Change 3149002 on 2016/10/03 by Jurre.deBaare
Issues with importing Alembic caches using matrix transformations
#fix Apply conversion matrix to imported matrix samples to make them match the DCC package they were exported from
Change 3149030 on 2016/10/03 by Martin.Wilson
Dont show save warning on animations when we have curve data
#jira UE-34145
Change 3149115 on 2016/10/03 by Mieszko.Zielinski
Made PathfollowingComponent distinct between patrial and full paths in terms of acceptance radius used, when trying to determin if pathing agent is at goal location #UE4
#jira UE-35153
Change 3149186 on 2016/10/03 by Ben.Zeigler
#UE-36722 Fix failure to spawn when trying to spawn 4 capsules in the exact same location
There's no "Correct" direction to move out of a penetrating capsule, but old PhysX appeared to be consistent. New PhysX is not, so now we save and restore the adjustment instead of letting previous iterations modify it.
This code is weird but this solution is better than the old version and handles inconsistent results
Change 3149235 on 2016/10/03 by Martin.Wilson
Change inline curve name editing to only change the name of that specific curve, instead of renaming the smart name itself.
#jira UE-20005
Change 3149245 on 2016/10/03 by Marc.Audy
Remove duplicate entries from AttachChildren caused by lack of atomic cross-object updates.
Change 3149397 on 2016/10/03 by Ori.Cohen
Fix collision profile writing out response values to channels that don't exist.
#JIRA UE-36359
Change 3149679 on 2016/10/03 by Zak.Middleton
#ue4 - Don't mark CharacterMovementComponent::bUseControllerDesiredRotation as an advanced property. Consolidate rotation settings (RotationRate, bUseControllerDesiredRotation, bOrientRotationToMovement) in a new "Rotation Settings" category.
Change 3149929 on 2016/10/04 by Jurre.deBaare
Fix for CIS errors
#fix Mac didn't like undefined struct
Change 3149977 on 2016/10/04 by danny.bouimad
Massive update to Merge Actor test files
Change 3150014 on 2016/10/04 by James.Golding
UE-36686 Fix crash when slicing and not creating other section
Change 3150016 on 2016/10/04 by James.Golding
UE-35335 MergeActors now converts box collision to convex, so collision scales correctly after merging
Change 3150019 on 2016/10/04 by James.Golding
UE-36737 Fix LineTraceComponent not returning face index
Change 3150020 on 2016/10/04 by James.Golding
UE-36672 Export PhysicsContstraintComponent class so it can be subclassed outside Engine module
Change 3150027 on 2016/10/04 by Ben.Marsh
Add PhysX build option into Dev-Framework.
Change 3150042 on 2016/10/04 by Benn.Gallagher
Fixed clothing example 1.3 collision glitches
Change 3150172 on 2016/10/04 by Benn.Gallagher
Made Skeletal Mesh LOD reimports clear any existing simplification flag so we don't show "generated" next to LOD entries for them.
#jira UE-36589
Change 3150319 on 2016/10/04 by Ori.Cohen
Go back to only deferring body creation per component. This can now use the slow path when needed. Can't support deferring of multiple components without changing locking API so we'll do that in the future.
#JIRA UE-36535, UE-36504
Change 3150355 on 2016/10/04 by Zak.Middleton
#ue4 - Change checkSlow() to check() in GetDefaultObject<> because this is potentially an unsafe static cast.
Change 3150370 on 2016/10/04 by Ori.Cohen
Fix deferred actors not getting flushed.
Change 3150386 on 2016/10/04 by Martin.Wilson
Fix additive animation check failing in cooked builds when using virtual bones
#jira UE-36743
Change 3150424 on 2016/10/04 by Ori.Cohen
Exclude kinematic actors from active transforms generation.
Change 3150613 on 2016/10/04 by Zak.Middleton
#ue4 - Fix bad GetDefaultObject<> in AbilitySystemGlobals. Turned up since changing checkSlow() to check() in GetDefaultObject.
(Mirror CL 3138304 in Orion-DevGeneral)
#jira UE-36810
#tests compiled
Change 3150679 on 2016/10/04 by Ben.Zeigler
Crash fix with no async scene
Change 3150765 on 2016/10/04 by Ben.Zeigler
Deprecate UStructProperty::ExportTextItem_Static and ImportItem_Static, and add ExportText and ImportText directly to UScriptStruct
Add bAllowNativeOverride to specify rather to call the native override. For unclear reasons the static export skipped the native override while the static import included it
This allows calling the generic ImportText from inside a native ImportTextItem and then doing some post processing
Change 3150796 on 2016/10/04 by Marc.Audy
Fix LOCTEXT warnings related to blueprint class menu options
Change 3150806 on 2016/10/04 by Ben.Zeigler
Fix bad text format in import error message, lead to double error
Change 3150891 on 2016/10/04 by Ben.Zeigler
#jira UE-36170 Fix duplicate GUID spam when async loading levels during PIE by checking the package flag instead of the runtime global
Change 3150914 on 2016/10/04 by Marc.Audy
Don't try to recreate render state if it has already been recreated while the recreate context was active
#jira UE-36590
Change 3151195 on 2016/10/04 by Dan.Reynolds
Updates to QASoundWaveProcedural
QASoundWaveProcedural edited to be a GameplayStatic which spawns an Audio Component Handler as well as a Procedural Sound Wave. Support for envelope shaping (Attack, Sustain, Release) as well as multiple waveforms (Sine, Triangle, Sawtooth, Square). Blueprint API expanded to include separate functions for setting QASoundWaveProcedural settings and Playing.
Change 3151233 on 2016/10/04 by Ben.Zeigler
#jira UE-36836 Fix variable shadowing warnings
Change 3151328 on 2016/10/04 by dan.reynolds
AEOverview Update - Added Sound Wave Procedural test map and added support for mobile (tested on Android) menu selection - Still a WIP
Change 3151461 on 2016/10/05 by Thomas.Sarkanen
Fix localization warnings
#jira UE-36720 - //UE4/Main: Step 'Build Engine Localization' - 2 Warnings
Change 3151546 on 2016/10/05 by Martin.Wilson
Fix pose watch regression due to persona refactor changes.
#jira UE-36851
Change 3151587 on 2016/10/05 by Jurre.deBaare
Updating Simplygon to SDK version 8.0
#misc removed redundant files
#misc fixed landscape culling in merge actor path
#misc added support for volume culling using simplygon
#misc fixed when or not to use mesh data for material baking
#notes
Change: 3137650
Date: 23/09/2016 07:57
Client: Mustafa.Tungekar_Dev-Partner-Simplygon
User: Mustafa.Tungekar
Status: submitted
Type: restricted
ImportedBy:
Identity:
Description:
-Renamed commandline variables for ZipUtils AutomationScript
-Implemented Execute instead of ExecuteBuild
-Updated commandline arguments in SimplygonSwarm
JobStatus:
Jobs:
Files:
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Private/SimplygonSwarm.cpp#4
//UE4/Dev-Partner-Simplygon/Engine/Source/Programs/AutomationTool/Scripts/ZipUtils.Automation.cs#2
Change: 3137649
Date: 23/09/2016 07:56
Client: Mustafa.Tungekar_Dev-Partner-Simplygon
User: Mustafa.Tungekar
Status: submitted
Type: restricted
ImportedBy:
Identity:
Description:
Moved file hash computation to ImportObject
JobStatus:
Jobs:
Files:
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Classes/Factories/Factory.h#4
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Private/Factories/Factory.cpp#4
Change: 3137646
Date: 23/09/2016 07:55
Client: Mustafa.Tungekar_Dev-Partner-Simplygon
User: Mustafa.Tungekar
Status: submitted
Type: restricted
ImportedBy:
Identity:
Description:
Fixes CL3099204
EditorPerProjectUserSetting
Removed ConfigRestartRequired attribute from properties where it was not required
MeshUtilities
-Added FProxyFailedDelegate
-Extended IMeshMerging to include FProxyFailed delegate
-Added ProxyGenerationFailed method to FProxyGenerationProcessor class
-Setup FailedDelegate for both MeshMerging and DistributedMeshMerging
SimplygonMeshReduction
-Added check for invalid texture id
-Updated notes and removed commented code that is not required.
-Setup failed delegate
-Fixed issue where image data was never hooked into the texture.
-Fixed issue where texture table was never passed into casters
SimplygonSwarm
-Setup failed delegate
-Fixed RawMesh pointer usage.
-Move helper method into SimplygonSwarmHelpers.h.
-Added SimplygonSwarmHelpers
-Removed redundant constant path to 7-zip
-Removed GetSimplygonDirectory instead using inplace.
-Removed commented code that is currently not required.
-Fixed Typos
JobStatus:
Jobs:
Files:
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/MeshUtilities/Private/MeshUtilities.cpp#3
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/MeshUtilities/Public/MeshUtilities.h#3
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonMeshReduction/Private/SimplygonMeshReduction.cpp#4
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Private/SimplygonSwarm.cpp#3
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Public/SimplygonSwarmHelpers.h#1
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Classes/Editor/EditorPerProjectUserSettings.h#3
Change: 3099204
Date: 24/08/2016 07:56
Client: Mustafa.Tungekar_Dev-Partner-Simplygon
User: Mustafa.Tungekar
Status: submitted
Type: restricted
ImportedBy:
Identity:
Description:
Simplygon 8.0 Updates
Deprecated support for 7.0 and updated SimplygonSwarm and SimplygonMeshReduction to use 8.0
EditorPerProjectSettings
*SwarmMaxUploadChunkSizeInMB for limiting the max upload size for swarm. Note the Simplygon Grid has a limitation of 2GB
*SwarmNumOfConcurrentJobs for executing number of concurrent jobs
*Fixed issue where SG_MATERIAL_CHANNEL_METALLIC to SG_MATERIAL_CHANNEL_METALNESS (Chage in 8.0 SDK)
SPL, SimplygonSwarm, RESTClient
*Bumped up SPL Version to 8
*Fixed code paths to use ZipUtils UAT script for zipping and unzipping CL3094374
*Removed SPL Templates for version 7.0
*Added conditional logging to REST methods
*Added multi part upload. The RESTClient automatically decided if large files need to be split up before uploading to simplygon grid.
*Updated method to take in texturepath
SimplygonMeshReduction
*Removed minimum version requirement.
*Bumped up minimum version
*Chagned license file name to refelect 8.0 changes
*MaterialBaking related method now take in TextureTable as an extra parameter. This is due to 8.0 move away from old way of setting up materials and using SimplygonShadingNetowrk based appraoch.
JobStatus:
Jobs:
Files:
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonMeshReduction/Private/SimplygonMeshReduction.cpp#3
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonMeshReduction/Public/SimplygonTypes.h#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Private/SimplygonRESTClient.cpp#3
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Private/SimplygonSwarm.cpp#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Public/SimplygonRESTClient.h#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Developer/SimplygonSwarm/Public/SimplygonSwarmPrivatePCH.h#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Classes/Editor/EditorPerProjectUserSettings.h#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Private/Settings/EditorPerProjectUserSettings.cpp#2
Change: 3099200
Date: 24/08/2016 07:48
Client: Mustafa.Tungekar_Dev-Partner-Simplygon
User: Mustafa.Tungekar
Status: submitted
Type: restricted
ImportedBy:
Identity:
Description:
#fix Copy constructor for FMeshReduciton mapped ShadingImportance to SilhouetteImportance
JobStatus:
Jobs:
Files:
//UE4/Dev-Partner-Simplygon/Engine/Source/Runtime/Engine/Classes/Engine/MeshMerging.h#2
Change: 3099199
Date: 24/08/2016 07:47
Client: Mustafa.Tungekar_Dev-Partner-Simplygon
User: Mustafa.Tungekar
Status: submitted
Type: restricted
ImportedBy:
Identity:
Description:
Added Automation Script ZipUtils to zip file and unzip files from SimplygonSwarm.
This will remove any dependency on external zip program and should work across platforms
JobStatus:
Jobs:
Files:
//UE4/Dev-Partner-Simplygon/Engine/Source/Programs/AutomationTool/Scripts/AutomationScripts.Automation.csproj#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Programs/AutomationTool/Scripts/ZipUtils.Automation.cs#1
Change: 3099197
Date: 24/08/2016 07:40
Client: Mustafa.Tungekar_Dev-Partner-Simplygon
User: Mustafa.Tungekar
Status: submitted
Type: restricted
ImportedBy:
Identity:
Description:
*Speed improvements for FBX Scene Importer
*Added a static method to compute Hash.
JobStatus:
Jobs:
Files:
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Classes/Factories/Factory.h#3
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Private/Factories/Factory.cpp#3
//UE4/Dev-Partner-Simplygon/Engine/Source/Editor/UnrealEd/Private/Fbx/FbxStaticMeshImport.cpp#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Runtime/Engine/Classes/EditorFramework/AssetImportData.h#2
//UE4/Dev-Partner-Simplygon/Engine/Source/Runtime/Engine/Private/EditorFramework/AssetImportData.cpp#2
Change 3151664 on 2016/10/05 by Richard.Hinckley
Fixing ACharacter template for "New C++ Class" feature. Avoiding naming a function parameter the same as an existing class member.
Change 3151729 on 2016/10/05 by Thomas.Sarkanen
Audit of remaining NaN checks
Some checks remain on in shipping (generally those called from blueprint):
- AActor::TeleportTo
- AActor::SetActorRelativeScale3D
#jira UE-30999 - Optimize ⌠ContainsNaN÷ and ⌠ContainsNaNOrInfinite÷, audit those still in shipping/test
Change 3151742 on 2016/10/05 by Ori.Cohen
Make sure that if physical animation component doesn't find a body and bone it doesn't crash.
#JIRA UE-36839
Change 3151756 on 2016/10/05 by Jurre.deBaare
Fixing d3dcompiler_47.dll missing issue
#fix added runtime dependency and dll name to build.cs file
#fix now load the d3dcompiler_47.dll from the Binaries/ThirdParty/Windows folder before loading the simplygon DLL
Change 3151761 on 2016/10/05 by Thomas.Sarkanen
Fix deprecation warning from last integration
Moved Preview to EditorPreview in FEditorWorldManager::OnWorldContextAdd.
#jira UE-36858 - Compile UE4Editor* completed with 1 warning
Change 3151782 on 2016/10/05 by Jurre.deBaare
Simplygon patch up
#misc linker errors popping up from JSONCPP
#misc incorporated emissive material property fix from other shelve
#misc static analysis fix
Change 3151804 on 2016/10/05 by Marc.Audy
Clear need end of frame update when unregistering a component
Change 3151928 on 2016/10/05 by Ori.Cohen
Fix runtime DLLs not including all delay loaded physx dll files.
#JIRA UE-36816
Change 3151977 on 2016/10/05 by Martin.Wilson
Notifies can no longer occupy the same time on the same track.
#jira UE-30658
Change 3151989 on 2016/10/05 by Jon.Nabozny
Fix ArchVis character rotation pitch when looking up/down.
#jira UE-35706
Change 3152083 on 2016/10/05 by Marc.Audy
Ensure that pending kill components get their marked for end of frame state cleared.
Change 3152086 on 2016/10/05 by Ben.Zeigler
#jira UE-36169 Fix it so missing linker errors that point to Blueprint CDOs are skipped, the same way it skips linker errors going to the actual class. Fixes a lot of spurious warnings from deleting components from blueprints or native classes
Clean up the VerifyImport error handling so it also displays in -game and cook, and fix the missing class warning to work properly, previously it would happen 0% in development 100% in debug even if the class was valid
Change 3152093 on 2016/10/05 by Marc.Audy
Change logic for when location cannot be changed for a static component to be independent of has begun play and have to do with whether construction script is running or the level is in the process of loading (mostly for backwards compatibility adjustments in post load).
#jira UE-36146
#jira UE-24647
Change 3152100 on 2016/10/05 by Ben.Zeigler
Remove pragma optmize
Change 3152112 on 2016/10/05 by Marc.Audy
Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3152072
Change 3152134 on 2016/10/05 by Jurre.deBaare
Simplygon/Merge actor issues
#fix for emissive output on meshes that do not have emissive properties
#fix for texture binning, not removing invalid split area causing overlapped textures
Change 3152136 on 2016/10/05 by James.Golding
UE-36859 Fix tooltip saying you can click to stop recording
Change 3152169 on 2016/10/05 by James.Golding
UE-31209 UE-30935 : Expose bDeformableMesh and bFastCook options in FTriMeshCollisionData
ProceduralMeshComponent will now cook using 'fast' and 'deformable' options, so updating collision on sections should work correctly
Change ERuntimePhysxCookOptimizationFlags to EPhysXMeshCookFlags and use that to pass options to CookConvex and CookTriMesh
Change 3152202 on 2016/10/05 by Jurre.deBaare
Mac/Linux fix
Change 3152303 on 2016/10/05 by Marc.Audy
Fix deprecation warning post merge from main
Change 3152320 on 2016/10/05 by Martin.Wilson
Fix root motion from everything calculating incorrect root motion when animations haven't been ticking
#jira UE-35364
Change 3152354 on 2016/10/05 by James.Golding
PoseDriver should pass through if no poses activated
Change 3152357 on 2016/10/05 by James.Golding
UE-36844 Remove unused OnAssetModifiedNotifier delegate from PoseAsset, ensure OnPoseListChanged is called when updating PoseAsset from anim.
Change 3152556 on 2016/10/05 by Marc.Audy
Remove autos
Change 3152560 on 2016/10/05 by Marc.Audy
Don't allow child actor references to be dragged from the outliner to a level script
#jira UE-16700
Change 3152568 on 2016/10/05 by Marc.Audy
Don't allow non-networking code to set bRemoteOwned in the actor spawn parameters
Remove deprecated bNoCollisionFail
#jira UE-35928
Change 3152575 on 2016/10/05 by Marc.Audy
Allow construction script to run post move for native classes. Actor can determine whether it should only occur on finish or every call to post edit move
Change 3153101 on 2016/10/06 by Thomas.Sarkanen
Fix crash re-opening the viewport in Persona-based editors
#jira UE-36775 - Editor crashes when re-opening viewport in Persona
Change 3153139 on 2016/10/06 by James.Golding
UE-36908 Remove GetRuntimeOnlyCookOptimizationFlags if cooking is not supported
Change 3153160 on 2016/10/06 by Thomas.Sarkanen
Fix for crash when deleting additive layer track
Code had not been updated to use the new delgate system (was still using reciprocal FPersona ptr).
#jira UE-36740 - Crash when removing or disabling an additive layer track in Persona
Change 3153175 on 2016/10/06 by Benn.Gallagher
Fixed crashes when using subinstances in non-default states. we previously initialized the anim instances in the node initialize, but in states that haven't been hit by an initialize this will happen off the game thread which is not allowed.
#jira UE-36900
Change 3153223 on 2016/10/06 by Thomas.Sarkanen
Fixed crash when opening an asset from the blend space editor
Code was still trying to open 'old' Persona when it was disabled.
Also fix other call sites where this was being done outside of asset type actions.
#jira UE-36766 - Crash attempting to open an asset from Aim Offset graph in Persona
Change 3153324 on 2016/10/06 by Thomas.Sarkanen
Prevented invalid GUIDs from being saved into smart name containers
AddOrFindName now checks to see if existing GUIDs are valid before using them.
AddName now requires a valid GUID to be passed in.
Also added Modify() call to the skeleton when FindOrAddSmartName is called from VerifySmartNameInternal, as without this the skeleton might not get saved.
Also add Laurent's fix for fixing up already-saved invalid GUIDs (CL 3138068).
#jira UE-36367 - It is possible for curves with an invalid GUID to be saved into the USkeleton asset
Change 3153348 on 2016/10/06 by Martin.Wilson
Re add ticking code so all Persona editors viewports tick during drag events (went missing in Persona refactor)
#jira UE-36751
Change 3153426 on 2016/10/06 by Mieszko.Zielinski
Added missing elements of block comments support in BT editor #UE4
Change 3153454 on 2016/10/06 by Benn.Gallagher
Fixed crash using anim debug with subinstances that are preceded by branching nodes.
#jira UE-36935
[CL 3153517 by Ori Cohen in Main branch]
2016-10-06 12:11:11 -04:00
# endif // ENABLE_DRAW_DEBUG
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
}
void FIKChain : : FABRIK_ApplyLinkConstraints_Forward ( FIKChain & IKChain , int32 LinkIndex )
{
if ( ( LinkIndex < = 0 ) | | ( LinkIndex > = IKChain . NumLinks - 1 ) )
{
return ;
}
const FIKChainLink & ChildLink = IKChain . Links [ LinkIndex - 1 ] ;
const FIKChainLink & CurrentLink = IKChain . Links [ LinkIndex ] ;
FIKChainLink & ParentLink = IKChain . Links [ LinkIndex + 1 ] ;
const FVector ChildAxisX = ( ChildLink . Location - CurrentLink . Location ) . GetSafeNormal ( ) ;
const FVector ChildAxisY = CurrentLink . LinkAxisZ ^ ChildAxisX ;
const FVector ParentAxisX = ( ParentLink . Location - CurrentLink . Location ) . GetSafeNormal ( ) ;
2022-10-26 07:34:18 -04:00
const double ParentCos = ( ParentAxisX | ChildAxisX ) ;
const double ParentSin = ( ParentAxisX | ChildAxisY ) ;
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
2022-10-26 07:34:18 -04:00
const bool bNeedsReorient = ( ParentSin < 0.0 ) | | ( ParentCos > FMath : : Cos ( IKChain . MinRotationAngleRadians ) ) ;
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
// Parent Link needs to be reoriented.
if ( bNeedsReorient )
{
// folding over itself.
if ( ParentCos > 0.f )
{
// Enforce minimum angle.
ParentLink . Location = CurrentLink . Location + CurrentLink . Length * ( FMath : : Cos ( IKChain . MinRotationAngleRadians ) * ChildAxisX + FMath : : Sin ( IKChain . MinRotationAngleRadians ) * ChildAxisY ) ;
}
else
{
// When opening up leg, allow it to extend in a full straight line.
ParentLink . Location = CurrentLink . Location - ChildAxisX * CurrentLink . Length ;
}
}
}
void FIKChain : : FABRIK_ApplyLinkConstraints_Backward ( FIKChain & IKChain , int32 LinkIndex )
{
if ( ( LinkIndex < = 0 ) | | ( LinkIndex > = IKChain . NumLinks - 1 ) )
{
return ;
}
FIKChainLink & ChildLink = IKChain . Links [ LinkIndex - 1 ] ;
const FIKChainLink & CurrentLink = IKChain . Links [ LinkIndex ] ;
const FIKChainLink & ParentLink = IKChain . Links [ LinkIndex + 1 ] ;
const FVector ParentAxisX = ( ParentLink . Location - CurrentLink . Location ) . GetSafeNormal ( ) ;
const FVector ParentAxisY = CurrentLink . LinkAxisZ ^ ParentAxisX ;
const FVector ChildAxisX = ( ChildLink . Location - CurrentLink . Location ) . GetSafeNormal ( ) ;
2022-10-26 07:34:18 -04:00
const double ChildCos = ( ChildAxisX | ParentAxisX ) ;
const double ChildSin = ( ChildAxisX | ParentAxisY ) ;
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
const bool bNeedsReorient = ( ChildSin > 0.f ) | | ( ChildCos > FMath : : Cos ( IKChain . MinRotationAngleRadians ) ) ;
// Parent Link needs to be reoriented.
if ( bNeedsReorient )
{
// folding over itself.
if ( ChildCos > 0.f )
{
// Enforce minimum angle.
ChildLink . Location = CurrentLink . Location + ChildLink . Length * ( FMath : : Cos ( IKChain . MinRotationAngleRadians ) * ParentAxisX - FMath : : Sin ( IKChain . MinRotationAngleRadians ) * ParentAxisY ) ;
}
else
{
// When opening up leg, allow it to extend in a full straight line.
ChildLink . Location = CurrentLink . Location - ParentAxisX * ChildLink . Length ;
}
}
}
void FIKChain : : FABRIK_ForwardReach ( const FVector & InTargetLocation , FIKChain & IKChain )
{
// Move end effector towards target
// If we are compressing the chain, limit displacement.
// Due to how FABRIK works, if we push the target past the parent's joint, we flip the bone.
{
FVector EndEffectorToTarget = InTargetLocation - IKChain . Links [ 0 ] . Location ;
FVector EndEffectorToTargetDir ;
2022-10-26 07:34:18 -04:00
double EndEffectToTargetSize ;
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
EndEffectorToTarget . ToDirectionAndLength ( EndEffectorToTargetDir , EndEffectToTargetSize ) ;
2022-10-26 07:34:18 -04:00
const double ReachStepAlpha = FMath : : Clamp ( CVarAnimLegIKTargetReachStepPercent . GetValueOnAnyThread ( ) , 0.01 , 0.99 ) ;
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
2022-10-26 07:34:18 -04:00
double Displacement = EndEffectToTargetSize ;
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
for ( int32 LinkIndex = 1 ; LinkIndex < IKChain . NumLinks ; LinkIndex + + )
{
FVector EndEffectorToParent = IKChain . Links [ LinkIndex ] . Location - IKChain . Links [ 0 ] . Location ;
2022-10-26 07:34:18 -04:00
double ParentDisplacement = ( EndEffectorToParent | EndEffectorToTargetDir ) ;
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
2022-10-26 07:34:18 -04:00
Displacement = ( ParentDisplacement > 0.0 ) ? FMath : : Min ( Displacement , ParentDisplacement * ReachStepAlpha ) : Displacement ;
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
}
IKChain . Links [ 0 ] . Location + = EndEffectorToTargetDir * Displacement ;
}
// "Forward Reaching" stage - adjust bones from end effector.
for ( int32 LinkIndex = 1 ; LinkIndex < IKChain . NumLinks ; LinkIndex + + )
{
FIKChainLink & ChildLink = IKChain . Links [ LinkIndex - 1 ] ;
FIKChainLink & CurrentLink = IKChain . Links [ LinkIndex ] ;
CurrentLink . Location = ChildLink . Location + ( CurrentLink . Location - ChildLink . Location ) . GetSafeNormal ( ) * ChildLink . Length ;
if ( IKChain . bEnableRotationLimit )
{
FABRIK_ApplyLinkConstraints_Forward ( IKChain , LinkIndex ) ;
}
}
}
void FIKChain : : FABRIK_BackwardReach ( const FVector & InRootTargetLocation , FIKChain & IKChain )
{
// Move Root back towards RootTarget
// If we are compressing the chain, limit displacement.
// Due to how FABRIK works, if we push the target past the parent's joint, we flip the bone.
{
FVector RootToRootTarget = InRootTargetLocation - IKChain . Links . Last ( ) . Location ;
FVector RootToRootTargetDir ;
float RootToRootTargetSize ;
RootToRootTarget . ToDirectionAndLength ( RootToRootTargetDir , RootToRootTargetSize ) ;
2022-10-26 07:34:18 -04:00
const double ReachStepAlpha = FMath : : Clamp ( CVarAnimLegIKTargetReachStepPercent . GetValueOnAnyThread ( ) , 0.01 , 0.99 ) ;
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
2022-10-26 07:34:18 -04:00
double Displacement = RootToRootTargetSize ;
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
for ( int32 LinkIndex = IKChain . NumLinks - 2 ; LinkIndex > = 0 ; LinkIndex - - )
{
FVector RootToChild = IKChain . Links [ IKChain . NumLinks - 2 ] . Location - IKChain . Links . Last ( ) . Location ;
2022-10-26 07:34:18 -04:00
double ChildDisplacement = ( RootToChild | RootToRootTargetDir ) ;
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
2022-10-26 07:34:18 -04:00
Displacement = ( ChildDisplacement > 0.0 ) ? FMath : : Min ( Displacement , ChildDisplacement * ReachStepAlpha ) : Displacement ;
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
}
IKChain . Links . Last ( ) . Location + = RootToRootTargetDir * Displacement ;
}
// "Backward Reaching" stage - adjust bones from root.
for ( int32 LinkIndex = IKChain . NumLinks - 1 ; LinkIndex > = 1 ; LinkIndex - - )
{
FIKChainLink & CurrentLink = IKChain . Links [ LinkIndex ] ;
FIKChainLink & ChildLink = IKChain . Links [ LinkIndex - 1 ] ;
ChildLink . Location = CurrentLink . Location + ( ChildLink . Location - CurrentLink . Location ) . GetSafeNormal ( ) * ChildLink . Length ;
if ( IKChain . bEnableRotationLimit )
{
FABRIK_ApplyLinkConstraints_Backward ( IKChain , LinkIndex ) ;
}
}
}
static FVector FindPlaneNormal ( const TArray < FIKChainLink > & Links , const FVector & RootLocation , const FVector & TargetLocation )
{
const FVector AxisX = ( TargetLocation - RootLocation ) . GetSafeNormal ( ) ;
for ( int32 LinkIndex = Links . Num ( ) - 2 ; LinkIndex > = 0 ; LinkIndex - - )
{
const FVector AxisY = ( Links [ LinkIndex ] . Location - RootLocation ) . GetSafeNormal ( ) ;
const FVector PlaneNormal = AxisX ^ AxisY ;
// Make sure we have a valid normal (Axes were not coplanar).
if ( PlaneNormal . SizeSquared ( ) > SMALL_NUMBER )
{
return PlaneNormal . GetUnsafeNormal ( ) ;
}
}
// All links are co-planar?
return FVector : : UpVector ;
}
TAutoConsoleVariable < int32 > CVarAnimLegIKAveragePull ( TEXT ( " a.AnimNode.LegIK.AveragePull " ) , 1 , TEXT ( " Leg IK AveragePull " ) ) ;
2022-10-26 07:34:18 -04:00
void FIKChain : : SolveFABRIK ( const FVector & InTargetLocation , double InReachPrecision , int32 InMaxIterations )
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
{
// Make sure precision is not too small.
2022-10-26 07:34:18 -04:00
const double ReachPrecision = FMath : : Max ( InReachPrecision , DOUBLE_KINDA_SMALL_NUMBER ) ;
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
const FVector RootTargetLocation = Links . Last ( ) . Location ;
2022-10-26 07:34:18 -04:00
const double PullDistributionAlpha = FMath : : Clamp ( CVarAnimLegIKPullDistribution . GetValueOnAnyThread ( ) , 0.0 , 1.0 ) ;
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
// Check distance between foot and foot target location
2022-10-26 07:34:18 -04:00
double Slop = FVector : : Dist ( Links [ 0 ] . Location , InTargetLocation ) ;
2020-11-18 22:26:08 -04:00
if ( Slop > ReachPrecision | | bEnableRotationLimit )
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
{
if ( bEnableRotationLimit )
{
// Since we've previously aligned the foot with the IK Target, we're solving IK in 2D space on a single plane.
// Find Plane Normal, to use in rotation constraints.
const FVector PlaneNormal = FindPlaneNormal ( Links , RootTargetLocation , InTargetLocation ) ;
for ( int32 LinkIndex = 1 ; LinkIndex < ( NumLinks - 1 ) ; LinkIndex + + )
{
const FIKChainLink & ChildLink = Links [ LinkIndex - 1 ] ;
FIKChainLink & CurrentLink = Links [ LinkIndex ] ;
const FIKChainLink & ParentLink = Links [ LinkIndex + 1 ] ;
const FVector ChildAxisX = ( ChildLink . Location - CurrentLink . Location ) . GetSafeNormal ( ) ;
const FVector ChildAxisY = PlaneNormal ^ ChildAxisX ;
const FVector ParentAxisX = ( ParentLink . Location - CurrentLink . Location ) . GetSafeNormal ( ) ;
// Orient Z, so that ChildAxisY points 'up' and produces positive Sin values.
CurrentLink . LinkAxisZ = ( ParentAxisX | ChildAxisY ) > 0.f ? PlaneNormal : - PlaneNormal ;
}
}
# if ENABLE_ANIM_DEBUG
const bool bShowDebug = ( CVarAnimNodeLegIKDebug . GetValueOnAnyThread ( ) = = 1 ) ;
if ( bShowDebug )
{
DrawDebugIKChain ( * this , FColor : : Magenta ) ;
}
# endif
// Re-position limb to distribute pull
const FVector PullDistributionOffset = PullDistributionAlpha * ( InTargetLocation - Links [ 0 ] . Location ) + ( 1.f - PullDistributionAlpha ) * ( RootTargetLocation - Links . Last ( ) . Location ) ;
for ( int32 LinkIndex = 0 ; LinkIndex < NumLinks ; LinkIndex + + )
{
Links [ LinkIndex ] . Location + = PullDistributionOffset ;
}
int32 IterationCount = 1 ;
const int32 MaxIterations = FMath : : Max ( InMaxIterations , 1 ) ;
do
{
2022-10-26 07:34:18 -04:00
const double PreviousSlop = Slop ;
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
# if ENABLE_ANIM_DEBUG
bool bDrawDebug = bShowDebug & & ( IterationCount = = ( MaxIterations - 1 ) ) ;
if ( bDrawDebug ) { DrawDebugIKChain ( * this , FColor : : Red ) ; }
# endif
2018-02-22 11:25:06 -05:00
// Pull averaging only has a visual impact when we have more than 2 bones (3 links).
if ( ( NumLinks > 3 ) & & ( CVarAnimLegIKAveragePull . GetValueOnAnyThread ( ) = = 1 ) & & ( Slop > 1.f ) )
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
{
FIKChain ForwardPull = * this ;
FABRIK_ForwardReach ( InTargetLocation , ForwardPull ) ;
FIKChain BackwardPull = * this ;
FABRIK_BackwardReach ( RootTargetLocation , BackwardPull ) ;
// Average pulls
for ( int32 LinkIndex = 0 ; LinkIndex < NumLinks ; LinkIndex + + )
{
Links [ LinkIndex ] . Location = 0.5f * ( ForwardPull . Links [ LinkIndex ] . Location + BackwardPull . Links [ LinkIndex ] . Location ) ;
}
# if ENABLE_ANIM_DEBUG
if ( bDrawDebug )
{
DrawDebugIKChain ( ForwardPull , FColor : : Green ) ;
DrawDebugIKChain ( BackwardPull , FColor : : Blue ) ;
}
# endif
}
else
{
FABRIK_ForwardReach ( InTargetLocation , * this ) ;
# if ENABLE_ANIM_DEBUG
if ( bDrawDebug ) { DrawDebugIKChain ( * this , FColor : : Green ) ; }
# endif
FABRIK_BackwardReach ( RootTargetLocation , * this ) ;
# if ENABLE_ANIM_DEBUG
if ( bDrawDebug ) { DrawDebugIKChain ( * this , FColor : : Blue ) ; }
# endif
}
Slop = FVector : : Dist ( Links [ 0 ] . Location , InTargetLocation ) + FVector : : Dist ( Links . Last ( ) . Location , RootTargetLocation ) ;
// Abort if we're not getting closer and enter a deadlock.
if ( Slop > PreviousSlop )
{
break ;
}
} while ( ( Slop > ReachPrecision ) & & ( + + IterationCount < MaxIterations ) ) ;
// Make sure our root is back at our root target.
if ( ! Links . Last ( ) . Location . Equals ( RootTargetLocation ) )
{
FABRIK_BackwardReach ( RootTargetLocation , * this ) ;
}
// If we reached, set target precisely
if ( Slop < = ReachPrecision )
{
Links [ 0 ] . Location = InTargetLocation ;
}
# if ENABLE_ANIM_DEBUG
if ( bShowDebug )
{
DrawDebugIKChain ( * this , FColor : : Yellow ) ;
FString DebugString = FString : : Printf ( TEXT ( " FABRIK IterationCount: [%d]/[%d], Slop: [%f]/[%f] " )
, IterationCount , MaxIterations , Slop , ReachPrecision ) ;
2018-02-22 11:25:06 -05:00
MyAnimInstanceProxy - > AnimDrawDebugOnScreenMessage ( DebugString , FColor : : Red ) ;
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
}
# endif
}
}
2018-05-23 21:04:31 -04:00
bool FAnimNode_LegIK : : AdjustKneeTwist ( FAnimLegIKData & InLegData )
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
{
const FVector FootFKLocation = InLegData . FKLegBoneTransforms [ 0 ] . GetLocation ( ) ;
const FVector FootIKLocation = InLegData . IKFootTransform . GetLocation ( ) ;
const FVector HipLocation = InLegData . FKLegBoneTransforms . Last ( ) . GetLocation ( ) ;
const FVector FootAxisZ = ( FootIKLocation - HipLocation ) . GetSafeNormal ( ) ;
FVector FootFKAxisX = InLegData . FKLegBoneTransforms [ 0 ] . GetUnitAxis ( InLegData . LegDefPtr - > FootBoneForwardAxis ) ;
FVector FootIKAxisX = InLegData . IKFootTransform . GetUnitAxis ( InLegData . LegDefPtr - > FootBoneForwardAxis ) ;
// Reorient X Axis to be perpendicular with FootAxisZ
FootFKAxisX = ( ( FootAxisZ ^ FootFKAxisX ) ^ FootAxisZ ) ;
FootIKAxisX = ( ( FootAxisZ ^ FootIKAxisX ) ^ FootAxisZ ) ;
// Compare Axis X to see if we need a rotation to be performed
if ( RotateLegByDeltaNormals ( FootFKAxisX , FootIKAxisX , InLegData ) )
{
# if ENABLE_ANIM_DEBUG
const bool bShowDebug = ( CVarAnimNodeLegIKDebug . GetValueOnAnyThread ( ) = = 1 ) ;
if ( bShowDebug )
{
2018-02-22 11:25:06 -05:00
DrawDebugLeg ( InLegData , MyAnimInstanceProxy , FColor : : Magenta ) ;
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
}
# endif
2018-05-23 21:04:31 -04:00
return true ;
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
}
2018-05-23 21:04:31 -04:00
return false ;
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
}
bool FAnimNode_LegIK : : IsValidToEvaluate ( const USkeleton * Skeleton , const FBoneContainer & RequiredBones )
{
const bool bIsEnabled = ( CVarAnimLegIKEnable . GetValueOnAnyThread ( ) = = 1 ) ;
return bIsEnabled & & ( LegsData . Num ( ) > 0 ) ;
}
static void PopulateLegBoneIndices ( FAnimLegIKData & InLegData , const FCompactPoseBoneIndex & InFootBoneIndex , const int32 & NumBonesInLimb , const FBoneContainer & RequiredBones )
{
FCompactPoseBoneIndex BoneIndex = InFootBoneIndex ;
if ( BoneIndex ! = INDEX_NONE )
{
InLegData . FKLegBoneIndices . Add ( BoneIndex ) ;
FCompactPoseBoneIndex ParentBoneIndex = RequiredBones . GetParentBoneIndex ( BoneIndex ) ;
int32 NumIterations = NumBonesInLimb ;
while ( ( NumIterations - - > 0 ) & & ( ParentBoneIndex ! = INDEX_NONE ) )
{
BoneIndex = ParentBoneIndex ;
InLegData . FKLegBoneIndices . Add ( BoneIndex ) ;
ParentBoneIndex = RequiredBones . GetParentBoneIndex ( BoneIndex ) ;
} ;
}
}
void FAnimNode_LegIK : : InitializeBoneReferences ( const FBoneContainer & RequiredBones )
{
2019-07-16 11:49:59 -04:00
DECLARE_SCOPE_HIERARCHICAL_COUNTER_ANIMNODE ( InitializeBoneReferences )
2018-05-23 21:04:31 -04:00
// Preserve FIKChain for each leg, as we're trying to maintain CachedBendDir between LOD transitions.
TMap < FName , FIKChain > IKChainLUT ;
for ( const FAnimLegIKData & LegData : LegsData )
{
if ( LegData . LegDefPtr )
{
IKChainLUT . Add ( LegData . LegDefPtr - > FKFootBone . BoneName , LegData . IKChain ) ;
}
}
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
LegsData . Reset ( ) ;
2018-05-23 21:04:31 -04:00
for ( FAnimLegIKDefinition & LegDef : LegsDefinition )
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
{
LegDef . IKFootBone . Initialize ( RequiredBones ) ;
LegDef . FKFootBone . Initialize ( RequiredBones ) ;
FAnimLegIKData LegData ;
Copying //UE4/Dev-AnimPhys to //UE4/Dev-Main (Source: //UE4/Dev-AnimPhys @ 3362413)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3281394 on 2017/02/01 by Chad.Garyet
one more try on the name here, with the extension this time
Change 3286009 on 2017/02/03 by Jon.Nabozny
Fix SkelMeshMerge duplicating Skeleton sockets.
#jira UE-39690
Change 3288374 on 2017/02/06 by Jon.Nabozny
Fix MaterialIndex checks in USkinnedMeshComponent::GetMaterial
Change 3288640 on 2017/02/06 by Jon.Nabozny
#rn Fix UPhysicsConstraintComponent details to allow modification of MaxForce, Stiffness, and Damping for Linear and Angular constraints.
#jira UE-40261
Change 3288978 on 2017/02/06 by Jon.Nabozny
Add code to debug for duplicate sockets in UQAMeshMergeComponent::MergeMeshes.
Change 3290332 on 2017/02/07 by Marc.Audy
Add AnimPhys object version
Change 3290753 on 2017/02/07 by Jon.Nabozny
Update CoM documentation for CoM offset.
#jira UE-40136
Change 3290783 on 2017/02/07 by Jon.Nabozny
Update mass dependent wheel properties in UWheeledVehicleMovementComponent when mass is updated.
#jira UE-39820
Change 3292286 on 2017/02/08 by Jon.Nabozny
Fix OSSNull query filtering.
#codereview: John.Pollard, Josh.Markiewicz, JohnHenry.Carawon
#jira: UE-37512
Change 3294138 on 2017/02/09 by Thomas.Sarkanen
Add more descriptive name for sub-struct members in property tracks
Change 3294139 on 2017/02/09 by Thomas.Sarkanen
Moving to individual structs for limbs
Change 3294140 on 2017/02/09 by Thomas.Sarkanen
Updated base human asset to reflect limb changes
Updated map to just contain the mannequin for now
Updated Sequence to contain some default IK keys
Change 3294178 on 2017/02/09 by Thomas.Sarkanen
Fix shadow variable warning
Change 3294554 on 2017/02/09 by Thomas.Sarkanen
Fixed persistent limb drift issues with non-participant bones
Still have rotational drift with IK chain nodes (still to fix).
Also fixes the addition of initial keys on binding when animating.
Also fixes not being able to pick the widget sometimes when picking nodes in the tree.
Change 3294826 on 2017/02/09 by Chad.Garyet
fixing up busted defaultvalues on physx and precompiled binaries
Change 3294827 on 2017/02/09 by Thomas.Sarkanen
CIS fixes for non-editor and monolithic builds
Change 3296363 on 2017/02/10 by Thomas.Sarkanen
Fix bone drifting
Re-using local transforms then resetting each update pass was accumulating error (via GetRelativeTransform), causing limbs to drift. To address this, simply set the global transform in the case where we know the local transform wont change.
Also optimized the hierarchy API a little & prevented excess work when nothing changes.
Change 3296393 on 2017/02/10 by James.Golding
Add support for clicking on PoseDriver targets in viewport
Change 3296465 on 2017/02/10 by Thomas.Sarkanen
Removed component visualizer (no longer used)
Change 3296467 on 2017/02/10 by Thomas.Sarkanen
Fixed extra keys being made when switching IK/FK mode. Now we only key on user action.
Added ability to hide nodes (advanced setting) and manipualtors (on playback)
Change 3296554 on 2017/02/10 by Thomas.Sarkanen
Fixed up some workflow issues
Widget visibility and the ability to move actors around is now corrected by calling the base FEdMode class functions appropriately.
Added a focus of the chosen actor so orbiting the actor is easier. There is a hitch when we do this (probably because Sequencer is re-initialized the next frame), so we miss the nice transition.
Change 3296621 on 2017/02/10 by Thomas.Sarkanen
Added ability to specify manipulator type when adding
Not exposed in the 'add' UI yet, just enough to allow me to batch-change the ones we have for now
Also tweaked default extents for box manipulators.
Change 3296622 on 2017/02/10 by Thomas.Sarkanen
Changed FK manipulators to boxes
Change 3296740 on 2017/02/10 by James.Golding
Added bOnlyDriveSelectedBones option to PoseDriver
Change 3296957 on 2017/02/10 by James.Golding
Fix AnimNode_PoseHandler using mesh bone index not compact bone index for setting up BoneBlendWeights array
Change 3297092 on 2017/02/10 by Jon.Nabozny
#rn Fix InstancedStaticMesh not properly creating physics state when Stationary.
#JIRA UE-39876
Change 3297160 on 2017/02/10 by Ori.Cohen
Temp fix for physx immediate mode crashing when 0 rows are generated.
Change 3297203 on 2017/02/10 by Ori.Cohen
Temp fix for immediate mode crash when free joints are batched together
#JIRA UE-41026
Change 3297326 on 2017/02/10 by Jon.Nabozny
PR #2965: Update comments in several classes within demo projects to match style present and provide more detail for new users (Contributed by Markyroson)
Changed some of the comment blocks to multiple single line (inside definitions). This is for consistency with our codebase.
#JIRA UE-38981
Change 3297618 on 2017/02/10 by Charles.Anderson
Arcblade - GDC
- Created a new mor polished Phat for this. Probably not gonna use it.
- Created a Ragdoll asset. Need to talk to Ori about getting it working better.
Change 3297799 on 2017/02/10 by mason.seay
Test map for testing audio attenuation
Change 3297940 on 2017/02/10 by Jon.Nabozny
#rn Fix ConstraintComponentVisualizer with AngularOffset.
Needed to apply local transform before world.
#JIRA UE-39597
Change 3297947 on 2017/02/10 by Chad.Garyet
adding automated test build option
Change 3299203 on 2017/02/13 by Thomas.Sarkanen
Fixed local coord system issues with rotation (etc).
Delta transforms are supplied in the space we specify in GetCustomDrawingCoordSystem(), so we now perform our operations in that space, then convert back when applying to the animation.
Fixed up to allow for animating actors with transformed skeletal mesh components.
Also added some proximity scaling to manipulators.
Change 3299220 on 2017/02/13 by Thomas.Sarkanen
Fixed CIS missing include
Change 3299343 on 2017/02/13 by Lina.Halper
Spine twist/roll check in
- control points are disabled
#rb: Thomas.Sarkanen
Change 3299388 on 2017/02/13 by James.Cobbett
Updating QA-Physics map
Change 3299518 on 2017/02/13 by Lina.Halper
fix build issue
#rb: none
Change 3299701 on 2017/02/13 by Ori.Cohen
Add finer grain physx stat information.
Change 3299894 on 2017/02/13 by Ori.Cohen
Added LOD support for immediate mode physics
Change 3299906 on 2017/02/13 by James.Cobbett
Updating QA-Collision map with new test scenarios
Change 3299962 on 2017/02/13 by Ori.Cohen
Fix shadow warning
Change 3300100 on 2017/02/13 by Lina.Halper
- renamed Constraint Axes option to FFilterOptionPerAxis : was going to reuse it for something else but didn't have to but left name changed because it makes more sense
- enable control point reading part
- twist/roll controll is localspace reader - BaseHuman
#rb: none
#code review:Thomas.Sarkanen
Change 3300206 on 2017/02/13 by Ori.Cohen
Rename Ragdoll node to RigidBody node
Change 3300899 on 2017/02/13 by Alan.Noon
Migrating Paragon Origin and Origin Small maps content.
Change 3301279 on 2017/02/14 by Jurre.deBaare
Mesh paint refactor
Change 3301288 on 2017/02/14 by Jurre.deBaare
Incremental CIS fixes
Change 3301290 on 2017/02/14 by Jurre.deBaare
Another CIS fix
Change 3301311 on 2017/02/14 by Thomas.Sarkanen
Fixed non-editor builds
Change 3301313 on 2017/02/14 by Jurre.deBaare
More CIS fixes
Change 3301315 on 2017/02/14 by Jurre.deBaare
Include CIS fix
Change 3301333 on 2017/02/14 by Jurre.deBaare
Non-Unity CIS fixes
Change 3301388 on 2017/02/14 by Benn.Gallagher
CIS fix for cloth create panel
Change 3301445 on 2017/02/14 by Benn.Gallagher
Last few changes over from the mesh paint branch
hooked up LOD dropdown box
Moved asset selection out of details panel
Change 3301527 on 2017/02/14 by mason.seay
Deleting unneeded map
Change 3301531 on 2017/02/14 by mason.seay
Renaming Map to fix naming scheme
Change 3301558 on 2017/02/14 by Ori.Cohen
Fix physx stats not being counted properly as we were not using static data.
Change 3301604 on 2017/02/14 by Ori.Cohen
Fix static analysis warning
Change 3301615 on 2017/02/14 by Jurre.deBaare
All. The. CIS. Fixes
Change 3301630 on 2017/02/14 by mason.seay
Updating Map for testing
Change 3301697 on 2017/02/14 by mason.seay
Final change to map
Change 3301734 on 2017/02/14 by Jurre.deBaare
- Crash CTRL-Z when having cloth painter and paint mode open
- Fill action not being undo-able
- Import vertex colors should default to to-instance
- Paint mode buttons in level painter are now toggle buttons (clarifies UI for user)
Change 3301763 on 2017/02/14 by Jurre.deBaare
- Fix for asset without engine version
- Fix for crash due to missing skeletal mesh permutation in mesh paint view modes
Change 3302421 on 2017/02/14 by Lina.Halper
Fixed issue where spline gets incorrect position when it has many control points.
#rb: Thomas.Sarkanen
Change 3302667 on 2017/02/14 by Lina.Halper
- added spine control points to work
- FK/IK switch isn't working great yet. Don't try
- disabled all twist/roll handling since control point itself can twist also and they were conflicting each other
- added option to add fk nodes, change parnets
- fixed issue with drawing skeleton drawing, when parents weren't added yet.
- Added neck/head/body control
#code review: Thomas.Sarkanen
#rb: none
Change 3303200 on 2017/02/14 by Alan.Noon
Collision shapes for Immediate Mode Ragdolls
Change 3303201 on 2017/02/14 by Alan.Noon
Adding Origin, Full Map
Change 3303477 on 2017/02/15 by James.Golding
Add Get and SetComponentForAxis to FVector and FRotator
Change 3303478 on 2017/02/15 by James.Golding
Add support for multiple source bones to PoseDriver
Change 3303480 on 2017/02/15 by James.Golding
Added per-scene frame number, handles cases like motion blur caching.
Refactored GPUSkinCache to have an explicit frame advance function, called after all viewports have rendered in game/editor, PostRenderAllViewportClients.
(Original author Chris.Bunner)
Change 3303513 on 2017/02/15 by Jurre.deBaare
CIS: Linux file name case fixes and incorrect pragma once
Change 3303576 on 2017/02/15 by Thomas.Sarkanen
Sub-sequence sections can now override how they instance their template
Added UMovieSceneSubSection::GenerateTemplateForSubSequence. This just performs the original call to SubSequenceStore.GetCompiledTemplate in the dcefault case.
Allowed non-const access to FMovieSceneEvaluationTemplate::GetTracks so they can be potentially modified once instanced.
Added access for FMovieSceneEvaluationTrack::ChildTemplates.
Change 3303578 on 2017/02/15 by Thomas.Sarkanen
Rich curves can now be transformed post-copy correctly
Using GetKeyIterator rather than aquiring the iterator directly makes sure we have valid key handles, which we dont if we have just copied the curve.
Change 3303579 on 2017/02/15 by Thomas.Sarkanen
Added GetLinkNode to complement SetLinkNode in FAnimNode_Base
Change 3303580 on 2017/02/15 by Thomas.Sarkanen
Made the logic around when sub-tracks can be primed for recording more specific
Prevents rig control sub tracks form being able to be primed.
Change 3303581 on 2017/02/15 by Thomas.Sarkanen
Allowing alpha on rig tracks to work
Alpha curve is now pushed down to tracks on template compilation along with bone masks & additive flag.
Sequencer anim instance updated to use new flags. Structure altered to accomodate layered blending for masked body parts (should probably push this to the regulat sequence instance too).
Moved anim node to local space (now it is just derived form FAnimNode_Base).
Also fixed opening/binding order issues - Now you should be able to open a sequence, bind to an actor and create a new rig control in a sequence in any order.
Change 3303582 on 2017/02/15 by Thomas.Sarkanen
Fixed UE4Game CIS - Moved AddConstraint() to non-editor-only
Also fixed crash in property chain iteration (for non-existent array properties)
Change 3303594 on 2017/02/15 by Jurre.deBaare
Fix for crash on deleting painted actors
Change 3303636 on 2017/02/15 by Lina.Halper
-remove temp code to add constraints. - they serialize, so once you add them you don't have to add these anymore.
This will move to editor menu soon.
#rb: none
Change 3303648 on 2017/02/15 by Martin.Wilson
Fix reimport crashes if the animation uses additive transform tracks.
#jira UE-41929
#jira UE-41921
Change 3303652 on 2017/02/15 by Benn.Gallagher
Added merged Ice mesh with new simulation mesh to match mesh from APEX version.
Change 3303660 on 2017/02/15 by Benn.Gallagher
map update for clothing demo
Change 3303662 on 2017/02/15 by Benn.Gallagher
State machine update for Ice anim
Change 3303676 on 2017/02/15 by mason.seay
Adjusted sound actor location
Change 3303689 on 2017/02/15 by Benn.Gallagher
Updated Ice mesh to have clothing present on the back part of the dress
Change 3303691 on 2017/02/15 by Jurre.deBaare
CIS fixes for pose driver details
Change 3303704 on 2017/02/15 by Lina.Halper
Add FK limb links
- enabled temp code to add constraints. It's not serialized from BP editor, so this has to be added everytime. Will fix this in the futre check-ins
#rb:none
Change 3303716 on 2017/02/15 by Thomas.Sarkanen
Updated manipulators to always draw in front of the mesh
Added material & enabled content for the plugin.
Change 3303730 on 2017/02/15 by thomas.sarkanen
Resaving manipulator material with correct engine version
Change 3303754 on 2017/02/15 by Thomas.Sarkanen
Fix manipulators popping to max size when manipulating
Change 3303835 on 2017/02/15 by Thomas.Sarkanen
Fix hitch by not displaying spawned objects if we dont have a sequence focused.
Change 3303843 on 2017/02/15 by Lina.Halper
Added normalize rotation on inputs/outputs
#code review: Thomas.Sarkanen
#rb: none
Change 3303916 on 2017/02/15 by Jurre.deBaare
CIS: Linux incorrect pragma once
Change 3304084 on 2017/02/15 by James.Golding
Update pose driver test after addition of multi-bone input
Change 3304188 on 2017/02/15 by James.Golding
Add custom remap curve option per-target in PoseDriver
Change 3304189 on 2017/02/15 by James.Golding
Fix CIS for ControlManipulator.cpp
Change 3304210 on 2017/02/15 by Alan.Noon
Added hidden collision objects for stairs area. Added brighter lighting on plinth area. Hooked up minion placement randomization. Added 100 minions to minion level for ragdol
Change 3304327 on 2017/02/15 by Alan.Noon
Created new Persistent levels for each Anim Tech demo, which loads in Origin_Small_P
Change 3304337 on 2017/02/15 by Alan.Noon
renamed minion demo level for GDC
Change 3304508 on 2017/02/15 by Lina.Halper
- You can see constraints in the tree view (full edit mode)
- YOu can add or update constraints (using update constraints button)
- You can delete constraints
- Cleaned up constraints interface
#rb: none
#code review: Thomas.Sarkanen
Change 3304537 on 2017/02/15 by chris.evans
!N Initial PSD test [chrise]
Change 3304551 on 2017/02/15 by James.Golding
Fix missing 'break's from SetComponentForAxis in FVector and FRotator
Change 3304570 on 2017/02/15 by Chris.Evans
!N Source assets for psd test
#RB none
Change 3304964 on 2017/02/15 by Lina.Halper
fix build issue
#code review: James.Golding
#rb: none
Change 3304998 on 2017/02/15 by Chris.Evans
!B Checking in correct FBX
#RB none
Change 3305314 on 2017/02/15 by chris.evans
!N Adding materials driven
!N Adding 'simulation' animation which simulates the driven result
Change 3305355 on 2017/02/15 by chris.evans
!N Initial test shoulder pose
Change 3305357 on 2017/02/15 by chris.evans
!N Initial Mambo shoulder ROM
Change 3305446 on 2017/02/15 by Lina.Halper
fixed CIS error
#rb: none
#code review: Thomas.Sarkanen
Change 3305768 on 2017/02/16 by Jurre.deBaare
CIS: Clang compile errors
Change 3305857 on 2017/02/16 by thomas.sarkanen
Removed particle systems from top plinth as they interfere with selection and obscure demo somewhat.
Change 3305907 on 2017/02/16 by Thomas.Sarkanen
Fix hitches on selection of multiple keys
Prevented multiple seleciton callbacks being called for each key (we now just edit the selection then broadcast later).
Dont force the details panel to refresh if nothing has changed.
Make sure we make a list of unique object IDs when processing the selection delegate, as we get an object ID per track.
Change 3305910 on 2017/02/16 by Thomas.Sarkanen
Allow multiple instances ot the same parameterized subsequence to exist and function correctly
Subsequences in the store are now keyed off an optionally specified 'other' object. In the case of parameterized subsequences, this object is the section.
Editor only right now - cooked builds are still to come
Change 3305911 on 2017/02/16 by Thomas.Sarkanen
Fix NaNs from uninitialized poses
Change 3305922 on 2017/02/16 by Thomas.Sarkanen
BuiltData for Origin_Small_P
Change 3305927 on 2017/02/16 by Thomas.Sarkanen
Moved ControlRig->ControlRigDemo in preparation for keeping all assets in one folder
Added some test assets
Change 3305928 on 2017/02/16 by Thomas.Sarkanen
Dont select actors when we bind to them
Selection can sometimes look bad and obscure the character.
Change 3306118 on 2017/02/16 by Thomas.Sarkanen
CIS fix
Change 3306230 on 2017/02/16 by Jurre.deBaare
CIS fix for linking errors on specific platforms
#test compile PS4 OrionGame
Change 3306378 on 2017/02/16 by Martin.Wilson
First pass Live Link system (Initially from //Tasks/UE4/Dev-Causeway)
- Live Link Maya plugin build files (builds a .mll file that can be loaded into Maya)
- Live Link Interface (editor module with interface files)
- Live Link Message Bus Framework (editor module with files needed for building message bus based live link plugins)
- Live Link (experiemental plugin that contains editor part of live link system)
Change 3306388 on 2017/02/16 by Lina.Halper
- build issue fix
- also tweaked display name to display only node name in editing mode
#rb: none
Change 3306455 on 2017/02/16 by Jon.Nabozny
#rn Perf improvements to FAnimNode_RigidBody.
Cache bounds to prevent unnecessary overlap updates.
Move overlaps off game thread.
Change 3306591 on 2017/02/16 by Martin.Wilson
Updates to live link
- Copyright changes (some were still 2016)
- Rename BlankMayaPlugin to LiveLinkMayaPlugin
Change 3306907 on 2017/02/16 by Jon.Nabozny
MinionDemo Content Perf Pass.
Change 3306914 on 2017/02/16 by Thomas.Sarkanen
Back out changelist 3305857 and 3305922
Reverts particle system changes to Origin_Small_P
Change 3306942 on 2017/02/16 by Martin.Wilson
Live link demo content
-Feng mao mesh that matches maya scene
- LiveLinkGDC Map
- Beginning of camera control sequencer
Change 3307154 on 2017/02/16 by Alan.Noon
Merged in new content to fix badly collapsed BP Static meshes deleted ragdoll minions for new posing. Stopped animation on spawn pad materials
Change 3307382 on 2017/02/16 by Martin.Wilson
Fix CIS (Add virtual destructor to ILiveLinkSource)
Change 3307497 on 2017/02/16 by chris.evans
!N Moving mats
Change 3307541 on 2017/02/16 by Chris.Evans
!B Rebuilding test assets with new skeleton
Change 3307873 on 2017/02/16 by Chris.Evans
!N Mambo updates
Change 3307875 on 2017/02/16 by Chris.Evans
!R Update to blueprint
Change 3308030 on 2017/02/16 by Alan.Noon
Changed lighting of Origin_Small_P based on feedback. Placed new objects were previous were exhibiting bad lightmaps.
Change 3308246 on 2017/02/16 by Alan.Noon
Consolidated new lighting content from sublevels into Origin_Small_P. Hooked up Physics asset to ArcBlade Skeletal mesh
Change 3308470 on 2017/02/16 by Lina.Halper
- make sure all are hooked up properly to pelvis and spine_03
- no multiple pelvis anymore. Using one to tweak all of them. all limbs are connected through constraints
- make sure end effector rotation is modifying IK's last chain rotation
- had to hack for saving offset for IK/FK switch mode but it works fine
- fixed lots of constraint issue with deleting node, parent constraints. Added new spine after that fix.
#rb:none
#code review: Thomas.Sarkanen
Change 3308764 on 2017/02/17 by Jurre.deBaare
Fix for non-unity Orion game build
Change 3308774 on 2017/02/17 by Thomas.Sarkanen
Added multi-selection of manipulators
Allowed BoxSelect, FrustumSelect and SelectNone to be overriden by the edit mode. Our edit mode doesnt have a sub-tool, it handles everything itself.
Also fixed manipulators drawing in front of widget
Changed manipualtors to be world-relative rather than screen relative scaled.
Tweaked proximity to be stateful so we only highlight the closest node
Also fixed slow FPS when dragging.
Change 3308802 on 2017/02/17 by James.Golding
Fix 'apply custom curve' for pose driver targets being on by default
Change 3308824 on 2017/02/17 by Lina.Halper
Fix build issue
#code review:Thomas.Sarkanen
#rb: none
Change 3308851 on 2017/02/17 by James.Golding
Add new control manipulator picking UI
Change 3308863 on 2017/02/17 by Martin.Wilson
Enable Live Link plugin in AnimTechDemo
Change 3308880 on 2017/02/17 by Thomas.Sarkanen
Getting instanced subsequences working in cooked builds
Change 3309009 on 2017/02/17 by Benn.Gallagher
Mask support and UI, not hooked up to painter yet
Added clothing tools experimental flag and hooked up
Change 3309016 on 2017/02/17 by Martin.Wilson
Clean up engine provided output devices and supply a Maya one, stops Maya hanging on shutdown
Change 3309108 on 2017/02/17 by Jurre.deBaare
CIS fix: missing definition of FWeakObjectPtr (strangely not part of CoreMinimal)
Change 3309134 on 2017/02/17 by Jurre.deBaare
Crash in texure painting mode
#fix Required some extra checks for new setup (can only paint while having one mesh selected)
Issue with vertex paint propagating to lower LOD levels
#fix There was no setup to propagate colors from source static mesh data so added the path
#misc Re-added flow painting and removed flow-strength property
#misc Added detail customization for texture paint UV channel
Change 3309256 on 2017/02/17 by Benn.Gallagher
CIS fix
Change 3309393 on 2017/02/17 by James.Golding
Set color for kinematic controls
Change 3309410 on 2017/02/17 by Ori.Cohen
PR #3221: Kinematic body interpolation in substepping causes invalid raycasting/sweeping/overlapping (Contributed by PhoenixBlack)
Change 3309469 on 2017/02/17 by Benn.Gallagher
Added ContentExamples cloth assets
Added camera transitions and controls
Cleanup logic
Move characters and materials onto upper plinth
Hid actor mesh from game view.
Change 3309625 on 2017/02/17 by mason.seay
Resaving assets to remove warnings
Change 3309802 on 2017/02/17 by Alan.Noon
Modified Origin_Small_P lighting. Set up ArcBlade for presentation
Change 3309985 on 2017/02/17 by Thomas.Sarkanen
Fixed crash adding multiple rigs to sequence
If a hierarchy is empty, dont attempt to access a non-existent node
#jira UE-42103
Change 3310209 on 2017/02/17 by Lina.Halper
- Fix limbs detaching issues
- added set translation to override translation
- moved joint targets away from the limbs
- Spine FK is on by default
- spnie IK/FK switch should work better. It can still pop depending on your control point can handle or not.
#rb: none
Change 3310389 on 2017/02/17 by Chris.Evans
!N Mambo multi-joint pose demo
Change 3310911 on 2017/02/18 by Lina.Halper
Ice/Mambo mapping fix with BaseHuman
Change 3311138 on 2017/02/19 by James.Golding
- Allow multi-select in control picker
- Clicking on background clears selection
- Add 'Select All' button
- Darken controls that are disabled (is in different kinematic mode)
- Use selection color from control instead of outline
- Center and fit picker to details panel width
- Remove entire Nodes section of edit mode panel (not just tree)
- Fix rig properties not scrolling
- Place picker in expandable area, collapsed when no rig selected
Change 3311147 on 2017/02/19 by Thomas.Sarkanen
Fix spine keying
Add the ablity for array elements to be keyed directly. The spine properties are FTransforms in an array and previously it ignored them because of assumptions about allowed structures.
This should probably be refactored to a more generic 'traverse up my property chain looking for Interp properties' at some point in the future.
Change 3311150 on 2017/02/19 by Thomas.Sarkanen
Synchronizing sequencer selection
Now enter key works for keying selected tracks
Added new way to select sequencer tracks externally via property paths.
Change 3311152 on 2017/02/19 by Thomas.Sarkanen
Missed files
Change 3311153 on 2017/02/19 by Thomas.Sarkanen
CIS fixes
Change 3311154 on 2017/02/19 by Thomas.Sarkanen
File I missed (CIS fix)
Change 3311156 on 2017/02/19 by James.Golding
Change 'ControlRig Edit Mode' icon
Change 3311176 on 2017/02/19 by Lina.Halper
Fix build issue
#rb:none
#code review: Thomas.Sarkanen, Jurre.DeBarre, James.Golding
p.s. not sure who's code, so just adding everybody I can think of
Change 3311261 on 2017/02/19 by Lina.Halper
- Fixed an issue when you don't have parent in the rig
- get all component space, and convert to local
#rb:none
#code review: Thomas.Sarkanen
Change 3311282 on 2017/02/19 by Lina.Halper
Fixed issue where pivot location is incorrect when mapping to other meshes
#rb: none
#code review:Thomas.Sarkanen
Change 3311491 on 2017/02/20 by Thomas.Sarkanen
CIS fix
Change 3311497 on 2017/02/20 by Jurre.deBaare
Game editor compile error
#fix WITH_EDITORONLY_DATA instead of WITH_EDITOR ifdef around UPROPERTY
Change 3311507 on 2017/02/20 by Jurre.deBaare
Cloth paint progress
- Different approach / refactored out paint ray retrieval
- Added key input callback to IMeshPainter and derived classes
- Added toggle for showing invisible vertices
- Added gradient paint tool
- Details customization for brush/gradient tool settings
- Some cleaning
Change 3311527 on 2017/02/20 by Jurre.deBaare
CIS header guard warning
Change 3311530 on 2017/02/20 by Jurre.deBaare
CIS dereferencing possible nullptr warning
Change 3311533 on 2017/02/20 by Jurre.deBaare
CIS dereferencing warning (better fix)
Change 3311543 on 2017/02/20 by James.Golding
Add buttons for switching IK/FK mode of limb/spine to picker
Put picker and details panel in a scroll box
Fix spine manipulators not being hidden when disabled
Change 3311649 on 2017/02/20 by James.Golding
R key now toggles manipulator visibility
Change 3311707 on 2017/02/20 by Lina.Halper
Added Clavicle FK controls
#code review: Danny.Bouimad
Change 3311764 on 2017/02/20 by Martin.Wilson
Update cameras for Live link demo map and turn on recompute tangents on Feng Mao
Change 3311858 on 2017/02/20 by Chris.Evans
!R Updated with pose values
Change 3312043 on 2017/02/20 by Jon.Nabozny
Change SkelMeshMerge logic to fix duplicates (again) and fix crash.
#jira UE-39690, UE-42146
Change 3312046 on 2017/02/20 by Thomas.Sarkanen
Fix crash drag/dropping skeletal mesh
#jira UE-42139 - Crash when adding SK_Mannequin to a Level Sequence in QAGame
Change 3312052 on 2017/02/20 by James.Golding
Change manipulator colors to red for right, blue for left, white for middle
Change IK/FK switch buttons to yellow/purple
Move picker buttons to take up less horizontal space
Move IK/FK switch button positions out of C++
Change 3312137 on 2017/02/20 by Ben.Marsh
Fix settings for using precompiled binaries in Dev-AnimPhys.
Change 3312517 on 2017/02/20 by Alan.Noon
Created new persistent level for Chris E's demo. Placed a few minions for CharlesA to test improved ragdoll asset. Tuned lighting in Origin_Small_P and fixed light leaks.
Change 3312570 on 2017/02/20 by Charles.Anderson
More work on Arcblade Ragdoll for GDC
Change 3312594 on 2017/02/20 by Alan.Noon
MultipleJointPoseDriving_GDC_P_pose_test_level
Change 3312637 on 2017/02/20 by Alan.Noon
Reconciling offline content
Change 3312902 on 2017/02/20 by Charles.Anderson
Minions for GDC
Change 3313206 on 2017/02/20 by Ori.Cohen
Added trimesh support for immediate mode.
Change 3313247 on 2017/02/20 by Chris.Evans
!N updated with both demo assets in one map
Change 3313447 on 2017/02/20 by Ori.Cohen
Fix immediate mode collision not working with convex transforms being baked in
Change 3313472 on 2017/02/20 by Ori.Cohen
Fix crash caused by missing switch case break
Change 3313518 on 2017/02/20 by Lina.Halper
IK knee issue/Twist issue
#code review: Thomas.Sarkanen, James.Golding
#rb: none
Change 3313547 on 2017/02/20 by Lina.Halper
Fixed Body-Ctrl to work with every node.
Change 3313617 on 2017/02/20 by Lina.Halper
- Fix for limbs delaying when moving BodyCtrl
- Fix for additive issue for control rig anim node
#rb: none
#code review: Thomas.Sarkanen
Change 3313618 on 2017/02/20 by Lina.Halper
remove unnecessary calc
#rb:none
Change 3313625 on 2017/02/20 by Lina.Halper
Fixed body ctrl move keys
- all IK keys also have to be in local space (but they're local to body_ctrl)
Change 3313633 on 2017/02/20 by Alan.Noon
Quick laying out of Minions for stress testing. Iterated on Environment collision.Built lighting
Change 3313655 on 2017/02/20 by Lina.Halper
- Fixed so that you can tweak pelvis and move body also
- Fixed mambo mapping
Change 3313897 on 2017/02/21 by James.Golding
Make all FK manipulators smaller (3 instead of 4.5)
Change 3313898 on 2017/02/21 by James.Golding
Integrate CL 3311876 to Dev-AnimPhys (original author Rolando.Caloca)
DR - Expose skin cache cvar r.SkinCache.AccumulationBufferSizeInKB
Change 3313902 on 2017/02/21 by James.Golding
Draw lines from IK target to mid-joint
Change 3313906 on 2017/02/21 by Thomas.Sarkanen
Fix undo/redo/save t-pose and crashes
Binding now only does what it needs to do an no more (i.e. force a reig evaluation and re-select the rig we are looking at).
Object spawner now does not root its objects. Rather it hangs them off of a 'holder' object so that they can exist safely in the transaciton buffer.
Change 3313938 on 2017/02/21 by Benn.Gallagher
Migrated clothing assets
Change 3313982 on 2017/02/21 by James.Golding
Fix static analysis in ClothPainter.cpp
Change 3313985 on 2017/02/21 by Benn.Gallagher
Fixed crash when attempting to create clothing with degenerate triangles. Now a log error and toast warn the user of conincident tri points.
#jira UE-41935
#rnx
Change 3314052 on 2017/02/21 by James.Golding
Fix CIS in ControlRigEditModeSettings.cpp
Change 3314100 on 2017/02/21 by Lina.Halper
IK fix for retargeting
- using rig transform and remapping doesn't work. I'll have to use mesh space for IK at least. It still does blend in rig space, though with FK.
#rb: none
Change 3314160 on 2017/02/21 by Thomas.Sarkanen
Added optional node trajectories
Added trajectory cache which uses similar mechanisms to the thumbnail cache to build trajectories for nodes.
Builds trajectories and their meshes incrementally when relevant things change
Change 3314167 on 2017/02/21 by James.Golding
Fix undo when pushing IK/FK toggle buttons
Change 3314168 on 2017/02/21 by Benn.Gallagher
Disabled skin cache on tech demo project
Change 3314290 on 2017/02/21 by Lina.Halper
- Cleaned up code a bit
- Fixed thigh to rotate to target and fixed a bug that caused jittering
#rb: none
Change 3314418 on 2017/02/21 by Thomas.Sarkanen
Fix CIS issue
Change 3314428 on 2017/02/21 by Thomas.Sarkanen
Fixup anim node to be of correct editor-time type
Caused crash when placed in an anim BP
Change 3314574 on 2017/02/21 by Thomas.Sarkanen
Fixed crash on shutdown
#jira UE-42214
Change 3314705 on 2017/02/21 by Alan.Noon
Iterating on map collision. Made minion weapon joint unbreakable
Change 3314722 on 2017/02/21 by Alan.Noon
Moved minions back into Minion demo Persistent level.
Change 3314778 on 2017/02/21 by Lina.Halper
added neck/ball_r/l control
#code review: Daniel.Bouimad
Change 3314908 on 2017/02/21 by Ori.Cohen
Temp fix for cloth bounds issue.
Change 3314920 on 2017/02/21 by Alan.Noon
Placing minions. Iterating collision
Change 3314970 on 2017/02/21 by Lina.Halper
added bone picker for toes, neck
Change 3315006 on 2017/02/21 by Benn.Gallagher
Fixed clothing bounds issue with empty simulations.
Change 3315017 on 2017/02/21 by Lina.Halper
fix crash on null proxy
#rb: Benn.Gallagher
Change 3315054 on 2017/02/21 by Alan.Noon
Placing minions
Change 3315671 on 2017/02/21 by Chris.Evans
!B Fixed default material
!N Added physics subgraph for Mambo
!N Added third 'gameplay' complex example
Change 3315693 on 2017/02/21 by chris.evans
!N Enabling tangent recompute on Mambo face and arm pits.
Change 3315838 on 2017/02/21 by Alan.Noon
New Orbital Laser Pawn. New ragdoll sublevels for minion demo (400 minions)
Change 3316206 on 2017/02/22 by Thomas.Sarkanen
Fix shadowed variables
Change 3316207 on 2017/02/22 by Thomas.Sarkanen
Manipulators are now transparent
Change 3316258 on 2017/02/22 by Jurre.deBaare
- Fix for changing levels while force painting to a specific LOD
- Brush depth not same as in main
Change 3316259 on 2017/02/22 by Jurre.deBaare
Fix for paint verts being rendered outside of painting area
#misc want to change underlying behaviour for the brush representation but this'll patch it up for now
Change 3316260 on 2017/02/22 by Jurre.deBaare
Changed default paint brush settings
Change 3316267 on 2017/02/22 by Jurre.deBaare
Added channel paint flags to texture painting settings
#misc might want to create base class for common paint settings
Change 3316268 on 2017/02/22 by Jurre.deBaare
Fix for issue with viewport color mode not being reset when exiting mesh paint mode
#jira UE-42221
Change 3316278 on 2017/02/22 by James.Golding
Fix crash when pose asset contains a bone that is not in the mesh
Change 3316304 on 2017/02/22 by Thomas.Sarkanen
Prevent sequencer from reselecting tracks when keys are selected
Also fixed crash concurrently modifying an itterating TSet when removing selection nodes.
Also made manipualtors not grow and shrink when transacting.
Also tweaked sequencer selection to not allow movement of infinite areas - this allows us to start drag-selecting over these tracks rather than trying to move a seciton that cannot be moved.
#jira UE-42164
Change 3316325 on 2017/02/22 by James.Golding
Hook up Mambo physics as 'Pose Process AnimBP'
Change 3316384 on 2017/02/22 by James.Golding
Slow down mambo anim playback rate
Change 3316385 on 2017/02/22 by Jurre.deBaare
CIS: Deprecation warning fix
Change 3316424 on 2017/02/22 by Lina.Halper
#fix : control rig mapping fix for Mambo
#lockdown: James.Golding
Change 3316525 on 2017/02/22 by Lina.Halper
- Fixed so that the mapping happening with retarget base pose, not ref pose
- Added refresh mapping option for all nodes to refresh bone transform - in case you change retarget base pose
- WIP of fingers, don't think we'll make it to demo, but it is still wip going in.
#lockdown: James.Golding
#rb: none
#code review: Thomas.Sarkanen, James.Golding
Change 3316684 on 2017/02/22 by Lina.Halper
fix shadow warning
#rb: none
#lockdown: james.golding
Change 3316748 on 2017/02/22 by Thomas.Sarkanen
Fix t-pose bindings in various demo workflow situations
Fix a crash when clearing actor
Fix t-pose when opening a new sequence over an old one
Fix t-pose on save
Note: Added a couple of 'nuke it from orbit' re-binds to the actor because some code paths were not correctly setting up all of our data. Particularily we were always setting up the anim instance. We should revisit this after GDC.
#jira UE-42136
Change 3316895 on 2017/02/22 by Jurre.deBaare
Incorrect simulation verts getting painted
#fix added an early rejection test
#misc fixed sqrd vs non-sqrd check
#misc level painting already did this in other specific code
Change 3316917 on 2017/02/22 by thomas.sarkanen
Disabling threaded update on Mambo's post process anim BP
We dont support running the main BP non-threaded and the post process threaded right now.
Change 3316933 on 2017/02/22 by Thomas.Sarkanen
Fixed linux shadow variable warning
Change 3317104 on 2017/02/22 by Chris.Evans
!N Initial animation with face
Change 3317483 on 2017/02/22 by Alan.Noon
Added controls to resize the Orbital Laser Impulse in the minion demo
Change 3317592 on 2017/02/22 by Alan.Noon
Tweaking Parameters on orbital Laser Pawn
Change 3317608 on 2017/02/22 by Lina.Halper
Sorry - missed this files from previous check-in
It should have gone with CL 3316525
#rb:none
#code review:Thomas.Sarkanen, James.Golding
#lockdown: James.Golding
Change 3317762 on 2017/02/22 by Lina.Halper
- allow dependency array to be added by IK effectors - but this isn't actual bug in this case
- the bug was property was overriding the value, so we'll have to make sure to update property from code change (bForceUpdatePropertyInTheNextTick)
#rb:none
#code review: Thomas.Sarkanen, James.Golding
#lockdown: James.Golding
Change 3317807 on 2017/02/22 by Martin.Wilson
Update for Live link code
-Rename Maya Source to Message Bus Source
-Fix typo in ReceiveClient function name
Change 3318031 on 2017/02/22 by Alan.Noon
100 more minions in a sublevel. Tuned new pawn. Added sound, particle effects to impulse
Change 3318217 on 2017/02/22 by Jon.Nabozny
Re-enable Dynamic Shadows for minions. Also enable Single Sample Shadow for perf reasons.
Change 3318365 on 2017/02/22 by Alan.Noon
Created new shadow capsule asset for minion. Disabled DOF.
Change 3318421 on 2017/02/22 by Alan.Noon
Adding more minion anims for variety
Change 3318435 on 2017/02/22 by Alan.Noon
Tweak to minion anim BP: minions pick and idle and stay with it.
Change 3318860 on 2017/02/23 by James.Golding
Force update nodes and manipulators when changing IK/FK mode
Better fix for UE-42257
Change 3318869 on 2017/02/23 by James.Golding
Key limb manipulators when switching IK/FK mode
Change 3318870 on 2017/02/23 by James.Golding
Fix head button picker location
Change 3318875 on 2017/02/23 by James.Golding
Add 'T' key shortcut for toggling trajectory drawing
Change 3318907 on 2017/02/23 by Benn.Gallagher
Added rail for clothing sheet examples
Change 3318909 on 2017/02/23 by Thomas.Sarkanen
Fix trajectories jittering as they generate
The rig needs ticking twice because of what looks like some stateful assumptions that were recently made.
Basically to get the rig to a state it needs ticking more than once.
This also means that we need to tick sequencer twice to make sure the rig state gets pushed to the anim instance too.
This may be to do with the latent IK/FK switching, and needs to be investigated.
For now, I'm leaving it like this but its not ideal because it makes the trajectory generation twice as expensive.
Change 3318929 on 2017/02/23 by James.Golding
Make PoseDriver Details not assume there is always a posedrivernode (fix potential crash during demo)
Change 3318930 on 2017/02/23 by James.Golding
Resave pose_test_level with camera in better default position
Change 3318969 on 2017/02/23 by thomas.sarkanen
Added demo map with mannequin and mambo
Change 3318975 on 2017/02/23 by thomas.sarkanen
Improved embededed test sequence
Kept blends away from initial binding because of t-pose issues
Change 3318979 on 2017/02/23 by thomas.sarkanen
Added sequence showing retargeting to multiple skeletons
Change 3318983 on 2017/02/23 by thomas.sarkanen
Improved retargeting sequence so that loop points dont pop animation
Change 3318991 on 2017/02/23 by Thomas.Sarkanen
Prevent division by zero in trajectory generation
Newly created sequences dont have a frame interval set up.
Change 3319013 on 2017/02/23 by Lina.Halper
Fixed twist issue
#lockdown: James.Golding
#rb: none
Change 3319017 on 2017/02/23 by Lina.Halper
Checked in wrong line - disabling optimization
#rb:none
#lockdown:James.Golding
Change 3319034 on 2017/02/23 by Lina.Halper
sorry about that - for some reason p4 reverted the merged changes, and removing function that was merged
#rb: none
#lockdown: James.Golding
Change 3319056 on 2017/02/23 by Lina.Halper
Back out changelist 3319013
#lockdown:James.Golding
Change 3319090 on 2017/02/23 by Thomas.Sarkanen
Added bookmarks to level, fixed up animation sequeces to be used in demo
Cleaned up unused assets from demo folder
Change 3319209 on 2017/02/23 by Chris.Evans
!R Lighting rebuilt
!N cameras added, camera switching functionality
Change 3319219 on 2017/02/23 by Chris.Evans
!R Disabling physics on the snake head on left shoulder
Change 3319268 on 2017/02/23 by Chris.Evans
!R Says it's dirty, could have sworn checked in latest, tested and works fine, sync'd to last rev can't see what changed.
Change 3319290 on 2017/02/23 by James.Golding
Default bShowManipulatorsDuringPlayback to on
Change 3319291 on 2017/02/23 by James.Golding
Add GDC2017 shared collection
Change 3319867 on 2017/02/23 by Alan.Noon
Moved Audio to a level and removed from sublevel list. Deleted particles.
Change 3320056 on 2017/02/23 by Alan.Noon
Built lighting in Clothing_GDC_P
Change 3320067 on 2017/02/23 by Ori.Cohen
Fix rigid body tooltip having the same loctext key as the node name causing bad node name (matters for live demo)
Change 3320085 on 2017/02/23 by Alan.Noon
Changed Origin_Small_P in ControlRigDemoMap to "Always Loaded"
Change 3320098 on 2017/02/23 by Martin.Wilson
Final updates for Live Link GDC Demo
-Add maya scene for demo
-Add binary for maya plugin + installation instructions
-Update actor location from based on latest maya scene and fix cameras in sequencer
-Updates on live link system for demo that I have been running with locally. Should be safe.
Change 3320579 on 2017/02/23 by Alan.Noon
Bound Spacebar to GoRagdoll in ArcBlade map. Built lighting. Killed printing to screen/log in MinionBP.
Change 3321144 on 2017/02/24 by Chris.Evans
!B Lighting was bad in PIE, forced -1.5 exposure bias on all cameras
Change 3321317 on 2017/02/24 by James.Golding
PIE on pose_test_level jumps to first placed camera
Change 3321956 on 2017/02/24 by Alan.Noon
Adding missing minion anims. And Stuff.
Change 3324190 on 2017/02/27 by Lina.Halper
Removed ensure from EvaluateAnimation
- this is invalid because of worker thread but I'll have more conversation over this change.
#rb: none
#code review: Laurent.Delayen, Martin.Wilson
#jira: UE-41731
Change 3324309 on 2017/02/27 by Lina.Halper
fixed issue with skeleton bone not displaying for curve picker
#jira: UE-41909
#rb: Marc.Audy
Change 3324342 on 2017/02/27 by mason.seay
First round of assets for testing root motion with framerate
Change 3324562 on 2017/02/27 by Lina.Halper
Fix build error
#rb: none
Change 3325010 on 2017/02/28 by mason.seay
Finished map
Change 3325124 on 2017/02/28 by mason.seay
Updated test to use trigger instead of delay
Change 3325205 on 2017/02/28 by mason.seay
Deleting old map
Change 3325207 on 2017/02/28 by mason.seay
Deleting old map
Change 3325752 on 2017/02/28 by Lina.Halper
Back out changelist 3319056
- adding upper twist back again
#rb: none
Change 3325759 on 2017/02/28 by James.Cobbett
Moving Weld automated tests to EngineTest project
Change 3326039 on 2017/02/28 by Lina.Halper
Fix spine issues
This is almost like content change as this contains lots of rigging changes from code. So I'm just checking with no review.
#jira: UE-42260, UE-42268
#rb: none
Change 3326246 on 2017/02/28 by mason.seay
Test map and assets for overlap functional tests
Change 3327926 on 2017/03/01 by Lina.Halper
- disabled pelvis animation on WaveAnimationGDC
- added pelvis controls so that you can animate without worring about gmibal lock.
#code review: danny.bouimad
Change 3327971 on 2017/03/01 by Lina.Halper
Moved BaseHuman to ControlRig/Content folder
- checking in redirector for the people who have local contents that want to keep
#code review: Thomas.Sarkanen
Change 3329196 on 2017/03/02 by James.Cobbett
Deleting from QAGame. These maps and assets were migrated over to EngineTest in CL 3325759 and CL 3325802.
Change 3329263 on 2017/03/02 by mason.seay
Temp submission as I reorganize other content
Change 3329321 on 2017/03/02 by mason.seay
Reorganizing content
Change 3329493 on 2017/03/02 by James.Cobbett
Moving/renaming automated tests
Change 3332044 on 2017/03/03 by mason.seay
Procedural Mesh Functional Tests
Change 3332049 on 2017/03/03 by Mason.Seay
Screenshot comparisons for Procedural Mesh Tests
Change 3333080 on 2017/03/06 by Lina.Halper
Fix crash on not sorted OutBoneTransforms from Hand IK Retargeting node
#jira: UE-42460
Change 3333826 on 2017/03/06 by Lina.Halper
Renamed nodes -
- adding rename feature for HumanRig
#rb: none
Change 3333847 on 2017/03/06 by Lina.Halper
Fixed build error
Change 3333865 on 2017/03/06 by Lina.Halper
Fixed build error on shadow warning
Change 3333957 on 2017/03/06 by Lina.Halper
Fixed issue where limb length wasn't applied correctly on human rig
#jira: UE-42307
Change 3335109 on 2017/03/07 by Thomas.Sarkanen
Prevent us from rebuilding node tree in 'view' mode
This means that a rare crash cant occur any more
#jira UE-42568 - Editor crashes when using the eye dropper to switch actor skeleton after deleting sequence
Change 3335110 on 2017/03/07 by Jurre.deBaare
Editor crashes on importing Alembic file
#fix ensure that we generate objects with a valid object name (used to be able to include invalid characters such as periods)
#jira UE-40189
Change 3335117 on 2017/03/07 by Jurre.deBaare
Crash when opening cloth painter with Paint mode open and selecting different actor
#fix ensure that we only initialize static adapter factory data once, now that we have multiple painters
#jira UE-42573
Change 3335119 on 2017/03/07 by Jurre.deBaare
In Persona, the lighting rig rotation changes when switching between profiles
#fix don't know how I wrote this code before, but made it so it makes sense now
#jira UE-40877
Change 3335120 on 2017/03/07 by Jurre.deBaare
Auto-Exposure Overriding Preview Scene Profile Settings
#fix also update showflags when passed property is Name_none, on opening static mesh editor make sure we pick last set profile instead of default 0, and make sure we push propertyt change when changing profiles
#misc made same changes for animation editors
#jira UE-39217
Change 3335121 on 2017/03/07 by Jurre.deBaare
Points not marked as invalid in Aim Offset graph when in invalid positions
#fix ensure that samples which have a valid grid point when checking their animation ptr
#misc whitespace fixes
#jira UE-40715
Change 3335122 on 2017/03/07 by Jurre.deBaare
Cannot right-click a blend point if the green preview point is in the way
#fix changed condition slightly, now do gather highlighted index so it can be used in rightclick instead of not setting it while hovering the preview pin point
#jira UE-39060
Change 3335123 on 2017/03/07 by Jurre.deBaare
It's not clear which Grid Stretch mode in blend space is currently on
#jira UE-39080
#fix added color change on grid stretch type state
Change 3335124 on 2017/03/07 by Jurre.deBaare
Not clear that material baking is only supported for single lod merge actors
#fix extended tooltip to include requirement for material merging
#jira UE-39621
Change 3335125 on 2017/03/07 by Jurre.deBaare
#fix Alembic import fix (indexed UVs) copy-pasta error
Change 3335126 on 2017/03/07 by Jurre.deBaare
Accessor and Modifier for StartTimeOffset in GeometryCacheComponent.h
#jira UE-37080
#feature Added bp exposed get/set-er
#misc Corrected some comments
Change 3335127 on 2017/03/07 by Jurre.deBaare
Blend space interpolation settings do not update until the user reopens the asset
#fix made reintializing of interpolation filter editor only to start with, and update the filter when necessary (this way multiple players, e.g. thumbnail renderer and persona) both give the expected result, before only one of them would be reinitialized see comment on flag in header
#jira UE-40950
Change 3335129 on 2017/03/07 by Jurre.deBaare
Store imported mesh names for Alembic files (makes reimporting easier)
#jira UE-39034
Change 3335161 on 2017/03/07 by Jurre.deBaare
CIS fix: Partial back out changelist 3335129
Change 3335426 on 2017/03/07 by Jurre.deBaare
Crash fix for importing random maya shapes through Alembic
#fix add safety checks for writing material indices
#jira UE-40189
Change 3335427 on 2017/03/07 by Jurre.deBaare
Editor hard locks when adding Profile in Preview Scene Settings
#fix previous change created an infinite loop while adding a new profile, now calling OnAssetViewerSettingsChanged directly and from a different spot
#jira UE-42609
Change 3335448 on 2017/03/07 by Thomas.Sarkanen
Fixed binding (and re-binding) of rig that was broken by main integration
Templates are no longer always regenerated, so re-binding doesnt work if we rely on template regeneration
Moved runtime and compile-time binding into the template (rather than the track).
Removed hacky 'static stack' of binding IDs. This is no longer needed now we have a way to propgate per-instance template data at compile time.
Change 3336018 on 2017/03/07 by Ori.Cohen
Make sure InstantiatePhysicsAsset does not create uninitialized bodies and constraints when it is given a physics asset with inappropriate bone names. Fixes crash in rigid body node when re-targetting.
#JIRA UE-42090
Change 3336508 on 2017/03/07 by Ori.Cohen
PR #3325: Allow Physics Notification Dispatching with Engine API (Contributed by 0lento)
#JIRA UE-42533
Change 3336524 on 2017/03/07 by Ori.Cohen
Added compiler error when component space sim and world collision is used.
#JIRA UE-41402
Change 3336700 on 2017/03/07 by Ben.Marsh
Fix stream name for bulding PhysX.
Change 3336949 on 2017/03/08 by James.Golding
In BindToSkeletalMesh, make sure skel mesh resources are init'd before calling Register on SkelMeshComp
#jira UE-42377
Change 3337008 on 2017/03/08 by Lina.Halper
- Fix for lagging update
- Removed unnecessary update from trajectory cache
#rb: Thomas.Sarkanen
Change 3337190 on 2017/03/08 by James.Golding
Remove defunct PhysX 3.3 libs
Change 3337562 on 2017/03/08 by Ori.Cohen
Touch engine to force re-link of latest PhysX libs. Fixes crash when free joints are used with immediate mode.
#JIRA UE-41026, UE-42628
Change 3337779 on 2017/03/08 by Ori.Cohen
Added skeletal mesh component override for sync vs async scene.
#JIRA UE-39829
Change 3337859 on 2017/03/08 by Ori.Cohen
Fix CIS
Change 3338593 on 2017/03/08 by Ori.Cohen
Remove physx get geometry macro and replace with calls to .any which should be faster.
#JIRA UE-40503
Change 3338614 on 2017/03/08 by Ori.Cohen
Fix warning about missing EditAnywhere
#JIRA UE-41361
Change 3338677 on 2017/03/08 by Ori.Cohen
Fix new generated physics assets not properly setting user settings to default profile.
#JIRA UE-41135
Change 3338683 on 2017/03/08 by Ori.Cohen
PR #3225: UPhysicsConstraintComponent works as expected when target is an UChildActorComponent (Contributed by PhoenixBlack)
#JIRA UE-3225
Change 3338694 on 2017/03/08 by Ori.Cohen
Added a getter to physical animation component (PR #3163)
#JIRA UE-41047
Change 3339131 on 2017/03/09 by James.Golding
Merging Engine changes from //UE4/Private-GDC17-FaceRig
- Set default CurveSourceBindingName on AudioCurveSourceComponent to 'Default' (to match node default)
- Add CurveSyncOffset option to AudioCurveSourceComponent
- Add 'Copy Curves To SoundWave' option to Anim Editor
- Bind possible curve sources by iterating over component properties, rather than owned components
- Add ref-pose override option to SkinnedMeshComponent
- Major fixes for per-instance skin-weights (was not using per-section map)
- Improve warnings for per-instance skin weight problems
Change 3339223 on 2017/03/09 by Thomas.Sarkanen
Exposed preview scene settings in the existing settings tab rather than in a hidden menu in the viewport
Tab is now shown by default
Added default preview scene collection so you dont end up having to create assets all the time just to preview meshes (although this is still possible).
#jira UE-39365 - Make Preview scene setup more discoverable
Change 3339270 on 2017/03/09 by Lina.Halper
Added create animation blueprint back since now we have a separate editor.
#jira: UE-39457
#rb: Martin.Wilson
Change 3339318 on 2017/03/09 by Danny.Bouimad
TM-TangentNormals, Test map for checking tangent recalculation with and without skin cache.
Change 3339431 on 2017/03/09 by James.Golding
Make UDestructibleComponent::SpawnFractureEffectsFromDamageEvent virtual
(UDN request: https://udn.unrealengine.com/questions/335389/custom-destructible-fracture-effects.html)
Change 3339809 on 2017/03/09 by James.Golding
Add support for 'UCP' prefix for importing capsule collision on static meshes via FBX
#jira UE-5262
Change 3339955 on 2017/03/09 by Ori.Cohen
Allow kinematic leaf bodies in immediate mode
Change 3339995 on 2017/03/09 by mason.seay
Collision functional tests
Change 3340085 on 2017/03/09 by Ori.Cohen
Change default contact-gen method to PCM. This is the default in PhysX 3.4
#JIRA UE-40365
Change 3340562 on 2017/03/09 by Ori.Cohen
Added physx simulation shader override.
#JIRA UE-35304
Change 3341155 on 2017/03/10 by Ori.Cohen
Fix CIS warnings
Change 3341295 on 2017/03/10 by Martin.Wilson
Cache compact pose bone index on FBoneReference and remove manual caching in Paragon
#jira UE-42302
Change 3341943 on 2017/03/10 by mason.seay
Cleaned up logic for map blueprints. Worked around delays
Change 3342029 on 2017/03/10 by mason.seay
Cleaned up blueprint logic to remove dependency on delays
Change 3342063 on 2017/03/10 by mason.seay
Disabling tests
Change 3342071 on 2017/03/10 by mason.seay
Updated map to use assertions
Change 3342884 on 2017/03/13 by James.Golding
Expose 'trace by profile' functions to BP
Refactor duplicated code in KismetSystemLibrary collision functions
#jira UE-32912
Change 3342886 on 2017/03/13 by James.Golding
Moving sprite from PhysicsThruster actor to PhysicsThrusterComponent (like light and audio, for example)
#jira UE-6015
Change 3342921 on 2017/03/13 by Benn.Gallagher
Added some checking to anim dynamics pre update to avoid crashes when world isn't available
#jira UE-42729
Change 3342970 on 2017/03/13 by James.Golding
Fix incorrect display names for some ..ByProfile trace funcs
Change 3342972 on 2017/03/13 by James.Golding
PR #3060: Added virtual keyword to DestructibleComponent ApplyDamage, ApplyDamageRadius (Contributed by looterz)
Change 3343032 on 2017/03/13 by Josh.Stoddard
Enable stabilization in PhysX by default
- set PxSceneFlag::eENABLE_STABILIZATION by default
- removed USE_ADAPTIVE_FORCES_FOR_ASYNC_SCENE because eADAPTED_FORCES is incompatible with eENABLE_STABILIZATION
- added FBodyInstance parameter StabilizationThresholdMultiplier to control PxRigidDynamic stabilization threshold
#jira UE-6612 #rb ori.cohen
Change 3343073 on 2017/03/13 by Martin.Wilson
Properly initialize single bone controller bone references
#jira UE-42776
Change 3343074 on 2017/03/13 by Martin.Wilson
Clear raw curve data during cooking
#jira UE-37897
Change 3343317 on 2017/03/13 by Jurre.deBaare
Crash after clearing the animation from a sample point in a 1D Blendspace
#jira UE-42672
#misc made sure that we do not deem empty blend spaces as additive
Change 3343498 on 2017/03/13 by Lina.Halper
Fix on odin cook crash
- fallout from CL 3336018
#rb:Marc.Audy
#code review:Ori.Cohen
Change 3343548 on 2017/03/13 by Lina.Halper
Fix crash on ocean -
#rb: none
#code review: Ori.Cohen
Change 3344764 on 2017/03/14 by Thomas.Sarkanen
Fixed crash right-clicking empty space in the asset shortcut dropdown
#jira UE-42782 - Crash right-clicking in anim blueprint asset picker
#jira UE-42799 - GitHub 3366 : Asset selection null check before Opening Editor
Change 3344776 on 2017/03/14 by James.Golding
Really fix names for BP-expose 'ByProfile' traces
Change 3344780 on 2017/03/14 by James.Golding
PR #3359: UE4.15 Morpheme integration changes (Contributed by NaturalMotionTechnology)
#jira UE-42771
Change 3344781 on 2017/03/14 by James.Golding
PR #3346: Expose URadialForceComponent for inheritance (Contributed by projectgheist)
#jira UE-42610
Change 3344782 on 2017/03/14 by James.Golding
Fix procmesh->staticmesh conversion if only a single triangle
#jira UE-42310
Change 3344783 on 2017/03/14 by James.Golding
PR #3234: Fix the incorrect UIMin value for InitialAverageFrameRate physics setting. (Contributed by 0lento)
#jira UE-41832
Change 3344785 on 2017/03/14 by James.Golding
PR #3196: Improved Constraint warning message (Contributed by projectgheist)
Change 3344790 on 2017/03/14 by James.Golding
PR #3362: Fix NULL pointer dereference when debugging null animation sequence. (Contributed by ill)
Change 3344891 on 2017/03/14 by Jurre.deBaare
Incorporate back list of animations into blendspace editor
#feature added labels toggle to blend space grid
#feature can now override animations when drop on sample
#jira UE-39368
Change 3344921 on 2017/03/14 by Jurre.deBaare
Expose Opacity and Opacity Mask options on material flattening
#feature added support for baking out opacity and opacity masks
#jira UE-39563
Change 3344963 on 2017/03/14 by Jurre.deBaare
Need Simplygon to create LODs on animated pose, vs skeletal mesh pose
#feature added ability to specify an animation sequence from which frame 0 will be baked into the LOD mesh
#jira UE-38909
Change 3345060 on 2017/03/14 by Jurre.deBaare
CIS fix: missing include
Change 3345929 on 2017/03/14 by Jon.Nabozny
Fix Grux skeletal mesh to properly point at Grux Phys Asset (instead of Steel's).
#jira UE-42772
Change 3346970 on 2017/03/15 by Jurre.deBaare
#feature Support importing vertex colours from Alembic files
#jira UE-39032
Change 3346976 on 2017/03/15 by Jurre.deBaare
Missing files from CL 3344921
Change 3346983 on 2017/03/15 by Jurre.deBaare
Static mesh editor crashes when opening
#fix default value for additional settings
Change 3347019 on 2017/03/15 by James.Cobbett
Tidying up blueprint comments
Change 3347128 on 2017/03/15 by mason.seay
Updated descriptions on tests
Change 3347146 on 2017/03/15 by mason.seay
Updated descriptions on tests
Change 3347178 on 2017/03/15 by Martin.Wilson
PR #3358: Actually compress CompressedCurveData during anim compression (Contributed by stefanzimecki)
Change 3347257 on 2017/03/15 by Thomas.Sarkanen
Fixed crash when canceling saving a new preview mesh collection
Change 3347314 on 2017/03/15 by mason.seay
Narrowed collision volumes by half
Change 3347386 on 2017/03/15 by mason.seay
Updated descriptions
Change 3347388 on 2017/03/15 by mason.seay
Forgot to disable tests :P
Change 3347397 on 2017/03/15 by James.Cobbett
Tidying up blueprint comments for WeldingScreenshots.umap automated test
Change 3347433 on 2017/03/15 by Thomas.Sarkanen
Fix IK/FK switch on first frame (clobbering FK data)
Added a 'first frame' flag to limbs etc.
Change 3347436 on 2017/03/15 by Thomas.Sarkanen
Control rig sequences can now be exported to anim sequences
Control rig sequences can now be exported from sequencer and exported, re-exported, imported and re-imported from the content browser.
Added converter function that performs similar logic to the animation recorder.
Fixed binding template in cooked builds.
Exposed anim sequence factory via UNREALED_API to allow for me to derive from it (I force the skeleton to a known value)
#jira UE-42608 - Add "export to anim sequence" to control rig sequences
Change 3347475 on 2017/03/15 by Lina.Halper
#LookAt node refactor
- you can use LookAtLocation based on joint or socket (jira UE-8972)
- improved visualizer (jira UE-2737) - clamp was there but now you can visuzlie it
- GetOnScreenDebugInfo changed parameter - added runtime node
- possibly we could query runtime node only but right now GetOnScrrenDebugInfo belongs to AnimGraphNode
- deprecated previous GetOnScreenDebugInfo
- Added AnimPhys Object version GUID
#rb:Thomas.Sarkanen
Change 3347512 on 2017/03/15 by Thomas.Sarkanen
Filter anim sequences to the correct skeleton when exporting
Feeback from code review of CL 3347436.
Change 3347543 on 2017/03/15 by Thomas.Sarkanen
Fix shadow variable warnings
Change 3347556 on 2017/03/15 by Jurre.deBaare
Unable to select bones in the animation editor viewport
#fix issues came from hit proxies being turned on and always being hit instead of the bone physic shapes
#feature added toggle button to skeletal mesh editor to enable mesh section selection
#jira UE-42893
Change 3347559 on 2017/03/15 by James.Golding
By default, re-use anim editor with correct Skeleton when double clicking anim asset
Add menu option to force a new edtor to open
#jira UE-42912
Change 3347749 on 2017/03/15 by Lina.Halper
Fix build issue.
#rb: none
Change 3347926 on 2017/03/15 by James.Cobbett
Adding new test to Welding.umap for children welding when attached to ragdoll
Change 3347938 on 2017/03/15 by Lina.Halper
Fix build error
#rb: none
Change 3347939 on 2017/03/15 by Mason.Seay
General cleanup of bp logic in maps and blueprint actors
Added scenarios to test actor descriptions
Fixed an error in blueprints (I think I failed to submit changes before)
Change 3348074 on 2017/03/15 by Lina.Halper
build error fix
#rb: none
#code review: martin.wilson
Change 3348154 on 2017/03/15 by Lina.Halper
last fix, hopefully
#rb: none
#code review: MArtin.wilson
Change 3349160 on 2017/03/16 by Thomas.Sarkanen
Adding 'set preview mesh' to toolbar
#jira UE-42910 - Add 'preview mesh' button to toolbar
Change 3349175 on 2017/03/16 by Jurre.deBaare
Notification on reimported animations that might be bad
#fix added two warning messages for different sequence length and missing curve in reimported file (hidden behind editor user setting -> bAnimationReimportWarnings)
#jira UE-34522
Change 3349197 on 2017/03/16 by Martin.Wilson
Add ability to choose slot to preview to montage editor
#jira UE-38910
Change 3349216 on 2017/03/16 by James.Cobbett
Additional Welding tests: static meshes attached to ragdolls and simulated children detaching and retaining welded children
Change 3349217 on 2017/03/16 by James.Cobbett
Disabling new Welding tests pending review
Change 3349314 on 2017/03/16 by Benn.Gallagher
Fixed clothing not running in PS4 packaged builds
#jira UE-42857
Change 3349504 on 2017/03/16 by James.Fox
Enabling RootMotion automation tests. Approved: UEENGQA-12277
Change 3349611 on 2017/03/16 by Lina.Halper
retargeting pose options change
- now reset, import pose, use current pose
#rb: Martin.Wilson
#jira: UE-19768
Change 3349738 on 2017/03/16 by Martin.Wilson
Remove force inline from virtual compression functions.
#jira UE-33070
Change 3349787 on 2017/03/16 by James.Golding
Fix xbox one compile (FControlRigBindingTemplate::ObjectBinding was not all wrapped in WITH_EDITORONLY_DATA)
Change 3349827 on 2017/03/16 by Josh.Stoddard
- Expose PhysX stabilization as project setting, disabled by default
- remove obsolete USE_SPECIAL_FRICTION_MODEL_FOR_ASYNC_SCENE
#jira UE-42868
Change 3349932 on 2017/03/16 by James.Golding
Possible fix for cooking crash - ContentBrowser module not necessarily being loaded
Change 3350011 on 2017/03/16 by Jon.Nabozny
Created AddForceAtLocationLocal function to allow component space forces.
#jira UE-38115
Change 3350134 on 2017/03/16 by Josh.Stoddard
Fix memory leak from GPhysXSDK->createShape()
#jira UE-42733 #rb ori.cohen
Change 3351166 on 2017/03/16 by Lina.Halper
Fixed build issue
#code review:Jon.Nabozny
Change 3351451 on 2017/03/17 by Benn.Gallagher
Fixed clothing reimports not working correctly and possibly leading to editor crash
#jira UE-42953
Change 3351564 on 2017/03/17 by Benn.Gallagher
Xbox NvCloth fix, module rules incorrectly set up and were not actually compiling NvCloth into the binary
#jira UE-42224
Change 3351594 on 2017/03/17 by mason.seay
Updated BP logic to use Set Actor Location (speeds up tests)
Gave actors distinct names
Reworded descriptions
Change 3351629 on 2017/03/17 by Jon.Nabozny
Add methods to determine the WeldParent and WeldChildren of a given component.
#jira UE-40733
Change 3351639 on 2017/03/17 by Jon.Nabozny
Fix StopMovementImmediately for WheeledVehicleMovementComponent.
#jira UE-40078
Change 3351649 on 2017/03/17 by Jon.Nabozny
Update comment on AddForceAtLocationLocal to be explicit that both Force vector and Location are in Body space.
Change 3351663 on 2017/03/17 by Thomas.Sarkanen
Anim notify blueprints now start with a 'received notify' event node (ghosted)
#jira UE-27386 - A new anim notify blueprints should start with a Received Notify override
Change 3351696 on 2017/03/17 by Thomas.Sarkanen
Refactored EvaluateBoneTransforms to prevent usage of skeletal mesh component
Deprecated EvaluateBoneTransforms in favor of new EvaluateSkeletalControl_AnyThread.
Added various useful transforms to the proxy as these were the most used data from the skeletal mesh component.
Some instances still require access to skeletal mesh to access the world for debug rendering. I'm leaving these alone for the moment as they should be addressed for 4.17 with the fixes for multi-threaded debug rendering.
Commented & re-formatted ConvertCSTransformToBoneSpace and ConvertBoneSpaceTransformToCS. Deprecated signatures that take a skeletal mesh component.
Commented FAnimNode_Base interface.
#jira UE-35238 - FAnimNode_SkeletalControlBase::EvaluateBoneTransforms takes in SkeletalMeshComponent which is not safe
Change 3351698 on 2017/03/17 by James.Golding
Add GetMaterialFromFaceIndex to MeshComponent, implement for StaticMeshComponent and ModelComponent
#jira UE-42802
Change 3351701 on 2017/03/17 by James.Golding
Change from Ctrl to Shift for 'open new editor' when double-clicking anim assets
Change 3351703 on 2017/03/17 by James.Golding
Change Box and Sphyl elements to use Rotator instead of Quat, to make them easier to edit via details panel
#jira UE-39664
Change 3351704 on 2017/03/17 by James.Golding
Fix scrubbing curves that aren't selected
#jira UE-39574
Change 3351805 on 2017/03/17 by Thomas.Sarkanen
Prevent crash when trying to implement a function in a child anim blueprint
The assumption that the ubergraph was the zeroth entry in the array didnt hold for child anim BPs with overriden functions. Now we just search for the ubergraph and check it if we find it.
#jira UE-42996 - Editor Crashes when creating a function in Child Anim Blueprint
Change 3352000 on 2017/03/17 by James.Cobbett
Adding VehicleAdvBP assets for use in upcoming Welding tests
Change 3352067 on 2017/03/17 by Lina.Halper
Removed AnimGraph from GraphEditor module
- Created node factory, pin factory, pin connection policy factory
- Moved all anim related files out of GraphEditor
#code review: Michael.Noland
#jira: UE-37976
#rb: Michael.Noland
Change 3352178 on 2017/03/17 by Lina.Halper
Moved to AnimationBlueprintEditor as these are just graph visual nodes
#code review:Michael.Noland
Change 3352753 on 2017/03/17 by James.Fox
Checking in some naming convention changes for Overlap automation test.
Change 3353371 on 2017/03/19 by Lina.Halper
Fix build error
#code review: Bob.Tellez
Change 3353644 on 2017/03/20 by Jurre.deBaare
Animation thumbnails vanishing
#fix ensure that we draw the mesh regardless of whether or not we have dynamic render data
#jira UE-42974
Change 3353654 on 2017/03/20 by James.Golding
Move SGraphNodeK2Default and SGraphNodeK2Event to Public as well, as they are used by Fortnite
Update includes in SFortGrtaphNodeK2ExecuteEvent and HandleEvent to only include parent class header
Change 3353684 on 2017/03/20 by Jurre.deBaare
Separate asset viewer profiles for local / shared
- Split out profiles in local/shared UProperty
- Modifications to ini writing :(
- Extra checks for default ini writing
- Add checkout/make writable for default editor ini file
Change 3353803 on 2017/03/20 by Jurre.deBaare
CIS fixes
Change 3353830 on 2017/03/20 by Martin.Wilson
Fix additives breaking when pose link not connected to anything
#jira ue-39174
Change 3353847 on 2017/03/20 by Martin.Wilson
Add property to blend space player nodes to specify whether the blend space current time is reset when the blend space changes
#jira UE-40446
Change 3353950 on 2017/03/20 by Ori.Cohen
Undo the null entries for invalid body/bodysetup pairs. Instead we check if the body and constraints are valid in the rigid body node.
#JIRA UE-42090
Change 3353956 on 2017/03/20 by Ori.Cohen
Back out changelist 3343498 (this was needed for the null entries on bodies array which has been fixed)
Change 3354003 on 2017/03/20 by Thomas.Sarkanen
Back out changelist 3353914
Change 3354031 on 2017/03/20 by Benn.Gallagher
Speculative fix for clothing crashes using Mambo. It was possible that the skeletal mesh component could have triggered deletion or creation of simulation state objects while the simulation was in flight on another thread, added tracking and waiting for outstanding tasks.
#jira UE-42975
Change 3354151 on 2017/03/20 by Lina.Halper
Make sure nullptr tick function still works
- this is prerequisite for the play and export option
#rb:Ori.Cohen
Change 3354229 on 2017/03/20 by James.Golding
Add 'default camera' options for skel meshes
#jira UE-42762
Change 3354342 on 2017/03/20 by Martin.Wilson
Strip out identity raw tracks when baking additives.
#jira UE-40508
Change 3354388 on 2017/03/20 by Martin.Wilson
Fix false anim blueprint compile errors with aim offset pins
#jira UE-38196
Change 3354494 on 2017/03/20 by Martin.Wilson
Serialize compressed anim data when counting memory
#jira UE-39691
Change 3354515 on 2017/03/20 by Josh.Stoddard
Expose PxSceneFlag::eENABLE_ENHANCED_DETERMINISM
#jira UE-41484 #rb ori.cohen
Change 3355932 on 2017/03/21 by Thomas.Sarkanen
Back out changelist 3354003
Reinstating merge from Main:
Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys)
Change 3355954 on 2017/03/21 by Thomas.Sarkanen
Fixed up CIS issues post merge from Main
Change 3355974 on 2017/03/21 by James.Golding
Fix Mac CIS warning (constructor order of FAnimNode_BlendSpacePlayer)
Change 3355981 on 2017/03/21 by Jurre.deBaare
Whitelisted circular dependencies between meshpaintmode and VR editor modules
Change 3355986 on 2017/03/21 by Jurre.deBaare
Linux CIS file, non-capital M
Change 3356072 on 2017/03/21 by James.Golding
Fix UStaticMeshComponent::GetMaterialFromCollisionFaceIndex to not depend on editor-only data
#jira UE-43117
Change 3356073 on 2017/03/21 by James.Golding
Implement GetMaterialFromCollisionFaceIndex for ProceduralMeshComponent
Change 3356300 on 2017/03/21 by Ori.Cohen
Allow kinematic bodies with simulated parents using the full scene solver
Change 3356362 on 2017/03/21 by Lina.Halper
- Support create animation from Play
- Support export animation from Play
- this allows retargeting, post graph, or anything you see in engine will be baked to the animation
#rb: Thomas.Sarkanen
#jira: UE-19746
Change 3356482 on 2017/03/21 by Martin.Wilson
Fix crash when opening a new montage
#UE-43132
Change 3356709 on 2017/03/21 by James.Golding
Check for NaN when converting rotator->quat (very large inputs can result in nan's, need to handle to avoid hitting asserts elsewhere)
Add clamps when editing rotation of collision shapes, to avoid massive rotation entries
#jira UE-39664
Change 3356968 on 2017/03/21 by Ori.Cohen
Fix physics asset bounds to be as small as 1cm.
This introduces flicker, but passing to rendering to fix that on their end.
Change 3357092 on 2017/03/21 by Josh.Stoddard
Don't update kinematic target if the body isn't moving
#jira UE-42784 #rb ori.cohen
Change 3357194 on 2017/03/21 by Lina.Halper
Fix on vehicle anim instance look at node issue
#rb: Ori.Cohen
#jira: UE-43116
Change 3357298 on 2017/03/21 by Ori.Cohen
Fix invalid warning when dragging actors into the world. This is invalid because we manually disable collision on actors when this happens, and the warning is only needed for actual runtime.
#JIRA UE-42211
Change 3357494 on 2017/03/21 by Jon.Nabozny
Fix FPropertyEditorInlineClassFilter filtering classes incorrectly.
#jira UE-43098
Change 3357892 on 2017/03/21 by Lina.Halper
fix build error
#rb: none
Change 3358078 on 2017/03/22 by James.Golding
Fix CIS - AnimNode_FootPlacement in Platformer game after SkelControl refactor (from CL 3351696)
Change 3358080 on 2017/03/22 by Jurre.deBaare
Updating Alembic importer thirdparty dependencies for Windows and Mac
Change 3358081 on 2017/03/22 by James.Golding
Add comment to help people fix up code after moving many properties in ContraintInstance to ProfileInstance member
Change 3358092 on 2017/03/22 by James.Golding
Fix undo for saving/clearing default cam on mesh (also marks mesh dirty)
Change 3358093 on 2017/03/22 by James.Golding
Panning in orbit mode now takes in account camera speed
#jira UE-43082
Change 3358106 on 2017/03/22 by Thomas.Sarkanen
Fix fallout from Main integration
Change 3358454 on 2017/03/22 by Ori.Cohen
Temporarily disable phat immediate mode previewing to break the dependency on immediate physics plugin. Will be turned back on in later refactor
#JIRA UE-41711
Change 3358886 on 2017/03/22 by Ori.Cohen
Fix AutoWeld not being disabled in blueprint editor when the object is simulated
#JIRA UE-40193
Change 3358950 on 2017/03/22 by Lina.Halper
reverted code asking about asset name when create asset
#rb: none
Change 3359034 on 2017/03/22 by Lina.Halper
#fix fall out from previous revert
- because now export also shows the window. we don't want export to FBX to show name dialog
- it will use asset name as base
#rb: none
#code review:Thomas.Sarkanen
Change 3359165 on 2017/03/22 by Ori.Cohen
Fix welded capsules not using the right rotation
#JIRA UE-41546
Change 3359232 on 2017/03/22 by Ori.Cohen
Bump DDC key for new bvh34.
Change 3359233 on 2017/03/22 by mason.seay
Added a couple more scenarios and updated names. Needs more organization
Change 3359293 on 2017/03/22 by tim.gautier
Submitting MeshPaint test content for QAGame.
Change 3359389 on 2017/03/22 by Ori.Cohen
Back out changelist 3356589
Change 3359402 on 2017/03/22 by Jon.Nabozny
Move GetWeldParent and GetWeldChildren to EngineTest.
Change 3359978 on 2017/03/23 by Jurre.deBaare
Mesh Paint brush disappears when painting in VR
#fix removed conditional clause for painting the interactors
#jira UE-43150
Change 3359980 on 2017/03/23 by Jurre.deBaare
Mesh Paint hotkeys to modify brush size are inconsistent with other Paint modes
#fix reverted to old behavior, paint mode overriding catching key input to viewport
#jira UE-43158
Change 3360052 on 2017/03/23 by James.Golding
Back out changelist 3359165, as it was made after smoke testing. Will re-submit after copy to main.
Change 3360121 on 2017/03/23 by James.Golding
Fix perf regression from testing for NaN's in FRotator::Quaternion in shipping builds
Change 3360177 on 2017/03/23 by Jurre.deBaare
Related to previous brush size check in, early out when the painter has handled the input, that way the rest of the editor can't take the brackets [] input anymore
Change 3360358 on 2017/03/23 by mason.seay
Updated naming and organization of actors in Outliner
Change 3362050 on 2017/03/23 by Lina.Halper
Back out changelist 3343074
#rb:none
#code review: Martin.Wilson, James.Golding
[CL 3362661 by Thomas Sarkanen in Main branch]
2017-03-24 09:53:37 -04:00
LegData . IKFootBoneIndex = LegDef . IKFootBone . GetCompactPoseIndex ( RequiredBones ) ;
const FCompactPoseBoneIndex FKFootBoneIndex = LegDef . FKFootBone . GetCompactPoseIndex ( RequiredBones ) ;
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
if ( ( LegData . IKFootBoneIndex ! = INDEX_NONE ) & & ( FKFootBoneIndex ! = INDEX_NONE ) )
{
PopulateLegBoneIndices ( LegData , FKFootBoneIndex , FMath : : Max ( LegDef . NumBonesInLimb , 1 ) , RequiredBones ) ;
// We need at least three joints for this to work (hip, knee and foot).
if ( LegData . FKLegBoneIndices . Num ( ) > = 3 )
{
LegData . NumBones = LegData . FKLegBoneIndices . Num ( ) ;
2018-05-23 21:04:31 -04:00
if ( FIKChain * IKChainPtr = IKChainLUT . Find ( LegDef . FKFootBone . BoneName ) )
{
LegData . IKChain = * IKChainPtr ;
}
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465)
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107
https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
LegData . LegDefPtr = & LegDef ;
LegsData . Add ( LegData ) ;
}
}
}
Copying //UE4/Dev-Build to //UE4/Dev-Main (Source: //UE4/Dev-Build @ 3209340)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3209340 on 2016/11/23 by Ben.Marsh
Convert UE4 codebase to an "include what you use" model - where every header just includes the dependencies it needs, rather than every source file including large monolithic headers like Engine.h and UnrealEd.h.
Measured full rebuild times around 2x faster using XGE on Windows, and improvements of 25% or more for incremental builds and full rebuilds on most other platforms.
* Every header now includes everything it needs to compile.
* There's a CoreMinimal.h header that gets you a set of ubiquitous types from Core (eg. FString, FName, TArray, FVector, etc...). Most headers now include this first.
* There's a CoreTypes.h header that sets up primitive UE4 types and build macros (int32, PLATFORM_WIN64, etc...). All headers in Core include this first, as does CoreMinimal.h.
* Every .cpp file includes its matching .h file first.
* This helps validate that each header is including everything it needs to compile.
* No engine code includes a monolithic header such as Engine.h or UnrealEd.h any more.
* You will get a warning if you try to include one of these from the engine. They still exist for compatibility with game projects and do not produce warnings when included there.
* There have only been minor changes to our internal games down to accommodate these changes. The intent is for this to be as seamless as possible.
* No engine code explicitly includes a precompiled header any more.
* We still use PCHs, but they're force-included on the compiler command line by UnrealBuildTool instead. This lets us tune what they contain without breaking any existing include dependencies.
* PCHs are generated by a tool to get a statistical amount of coverage for the source files using it, and I've seeded the new shared PCHs to contain any header included by > 15% of source files.
Tool used to generate this transform is at Engine\Source\Programs\IncludeTool.
[CL 3209342 by Ben Marsh in Main branch]
2016-11-23 15:48:37 -05:00
}
2022-09-24 13:57:58 -04:00