2018-01-02 15:30:26 -05:00
// Copyright 1998-2018 Epic Games, Inc. All Rights Reserved.
2014-03-14 14:13:41 -04:00
Copying //UE4/Dev-Build to //UE4/Dev-Main (Source: //UE4/Dev-Build @ 3209340)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3209340 on 2016/11/23 by Ben.Marsh
Convert UE4 codebase to an "include what you use" model - where every header just includes the dependencies it needs, rather than every source file including large monolithic headers like Engine.h and UnrealEd.h.
Measured full rebuild times around 2x faster using XGE on Windows, and improvements of 25% or more for incremental builds and full rebuilds on most other platforms.
* Every header now includes everything it needs to compile.
* There's a CoreMinimal.h header that gets you a set of ubiquitous types from Core (eg. FString, FName, TArray, FVector, etc...). Most headers now include this first.
* There's a CoreTypes.h header that sets up primitive UE4 types and build macros (int32, PLATFORM_WIN64, etc...). All headers in Core include this first, as does CoreMinimal.h.
* Every .cpp file includes its matching .h file first.
* This helps validate that each header is including everything it needs to compile.
* No engine code includes a monolithic header such as Engine.h or UnrealEd.h any more.
* You will get a warning if you try to include one of these from the engine. They still exist for compatibility with game projects and do not produce warnings when included there.
* There have only been minor changes to our internal games down to accommodate these changes. The intent is for this to be as seamless as possible.
* No engine code explicitly includes a precompiled header any more.
* We still use PCHs, but they're force-included on the compiler command line by UnrealBuildTool instead. This lets us tune what they contain without breaking any existing include dependencies.
* PCHs are generated by a tool to get a statistical amount of coverage for the source files using it, and I've seeded the new shared PCHs to contain any header included by > 15% of source files.
Tool used to generate this transform is at Engine\Source\Programs\IncludeTool.
[CL 3209342 by Ben Marsh in Main branch]
2016-11-23 15:48:37 -05:00
# include "CoreMinimal.h"
# include "Misc/MessageDialog.h"
# include "Misc/Paths.h"
# include "ISourceControlOperation.h"
# include "SourceControlOperations.h"
2014-03-14 14:13:41 -04:00
# include "ISourceControlRevision.h"
Copying //UE4/Dev-Build to //UE4/Dev-Main (Source: //UE4/Dev-Build @ 3209340)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3209340 on 2016/11/23 by Ben.Marsh
Convert UE4 codebase to an "include what you use" model - where every header just includes the dependencies it needs, rather than every source file including large monolithic headers like Engine.h and UnrealEd.h.
Measured full rebuild times around 2x faster using XGE on Windows, and improvements of 25% or more for incremental builds and full rebuilds on most other platforms.
* Every header now includes everything it needs to compile.
* There's a CoreMinimal.h header that gets you a set of ubiquitous types from Core (eg. FString, FName, TArray, FVector, etc...). Most headers now include this first.
* There's a CoreTypes.h header that sets up primitive UE4 types and build macros (int32, PLATFORM_WIN64, etc...). All headers in Core include this first, as does CoreMinimal.h.
* Every .cpp file includes its matching .h file first.
* This helps validate that each header is including everything it needs to compile.
* No engine code includes a monolithic header such as Engine.h or UnrealEd.h any more.
* You will get a warning if you try to include one of these from the engine. They still exist for compatibility with game projects and do not produce warnings when included there.
* There have only been minor changes to our internal games down to accommodate these changes. The intent is for this to be as seamless as possible.
* No engine code explicitly includes a precompiled header any more.
* We still use PCHs, but they're force-included on the compiler command line by UnrealBuildTool instead. This lets us tune what they contain without breaking any existing include dependencies.
* PCHs are generated by a tool to get a statistical amount of coverage for the source files using it, and I've seeded the new shared PCHs to contain any header included by > 15% of source files.
Tool used to generate this transform is at Engine\Source\Programs\IncludeTool.
[CL 3209342 by Ben Marsh in Main branch]
2016-11-23 15:48:37 -05:00
# include "SourceControlWindows.h"
# include "Modules/ModuleManager.h"
# include "UObject/Object.h"
# include "UObject/Package.h"
# include "Misc/PackageName.h"
# include "InputCoreTypes.h"
# include "Layout/Visibility.h"
# include "Layout/Geometry.h"
# include "Widgets/SNullWidget.h"
# include "Styling/SlateBrush.h"
# include "Input/Events.h"
# include "Input/DragAndDrop.h"
# include "Input/Reply.h"
# include "Widgets/DeclarativeSyntaxSupport.h"
# include "Widgets/SWidget.h"
# include "Widgets/SCompoundWidget.h"
# include "Widgets/SBoxPanel.h"
# include "Widgets/SWindow.h"
# include "SlateOptMacros.h"
# include "Framework/Application/SlateApplication.h"
# include "Textures/SlateIcon.h"
# include "Framework/Commands/UIAction.h"
# include "Widgets/Layout/SBorder.h"
# include "Widgets/Images/SImage.h"
# include "Widgets/Text/STextBlock.h"
# include "Widgets/Layout/SBox.h"
# include "Framework/MultiBox/MultiBoxBuilder.h"
# include "Widgets/Layout/SSplitter.h"
# include "Widgets/Views/SExpanderArrow.h"
# include "Widgets/Views/SHeaderRow.h"
# include "Widgets/Views/STableViewBase.h"
# include "Widgets/Views/STableRow.h"
# include "Widgets/Views/STreeView.h"
# include "Framework/Docking/TabManager.h"
# include "EditorStyleSet.h"
# include "ISourceControlModule.h"
# include "IAssetTools.h"
# include "IAssetTypeActions.h"
# include "AssetToolsModule.h"
2014-03-14 14:13:41 -04:00
/**
* Wrapper around data from ISourceControlRevision
*/
class FHistoryRevisionListViewItem
{
public :
/** Changelist description */
FString Description ;
/** User name of submitter */
FString UserName ;
/** Clientspec/workspace of submitter */
FString ClientSpec ;
/** File action for this revision (branch, delete, edit, etc.) */
FString Action ;
2014-06-05 12:10:47 -04:00
/** Source path of branch, if any */
FString BranchSource ;
2014-03-14 14:13:41 -04:00
/** Date of this revision */
FDateTime Date ;
/** Number of this revision */
2015-01-20 05:48:14 -05:00
FString Revision ;
2014-03-14 14:13:41 -04:00
/** Changelist number */
int32 ChangelistNumber ;
/** Filesize for this revision (0 in the event of a deletion) */
int32 FileSize ;
/**
* Constructor
*
* @ param InRevision File revision info . to populate this wrapper with
*/
FHistoryRevisionListViewItem ( const TSharedRef < ISourceControlRevision , ESPMode : : ThreadSafe > & InRevision )
{
Description = InRevision - > GetDescription ( ) ;
UserName = InRevision - > GetUserName ( ) ;
ClientSpec = InRevision - > GetClientSpec ( ) ;
Action = InRevision - > GetAction ( ) ;
2014-06-05 12:10:47 -04:00
BranchSource = InRevision - > GetBranchSource ( ) . IsValid ( ) ? InRevision - > GetBranchSource ( ) - > GetFilename ( ) : TEXT ( " " ) ;
2014-03-14 14:13:41 -04:00
Date = InRevision - > GetDate ( ) ;
2015-01-20 05:48:14 -05:00
Revision = InRevision - > GetRevision ( ) ;
2014-03-14 14:13:41 -04:00
ChangelistNumber = InRevision - > GetCheckInIdentifier ( ) ;
FileSize = InRevision - > GetFileSize ( ) ;
}
} ;
/**
* Managed mirror of FSourceControlFileHistoryInfo . Designed to represent the history of a file in
* a listview .
*/
class FHistoryFileListViewItem
{
public :
/** Depot name of the file */
FString FileName ;
/**
* Constructor
*
2014-06-05 12:10:47 -04:00
* @ param InFileName File name of the list item
2014-03-14 14:13:41 -04:00
*/
2014-06-05 12:10:47 -04:00
FHistoryFileListViewItem ( const FString & InFileName )
: FileName ( InFileName )
2014-03-14 14:13:41 -04:00
{
}
} ;
/**
* A container class to use the tree view to represent a dynamically expandable nested list
*/
struct FHistoryTreeItem
{
// Only one of FileListItem or RevisionListItem should be set
/** Pointer to file info */
TSharedPtr < FHistoryFileListViewItem > FileListItem ;
/** Pointer to revision info */
TSharedPtr < FHistoryRevisionListViewItem > RevisionListItem ;
/** If we are a revision entry, pointer to file entry that owns us */
TWeakPtr < FHistoryTreeItem > Parent ;
/** List of revisions if we are file entry */
TArray < TSharedPtr < FHistoryTreeItem > > Children ;
} ;
/**
* Attempts to get a file list - item that represents the file that specified
* history - tree entry belongs to .
*
* @ param HistoryTreeItemIn The history - tree entry that you want a file item for .
* @ return The file list - item that the specified entry conceptually belongs to ( invalid if HistoryTreeItemIn was invalid ) .
*/
static TSharedPtr < FHistoryFileListViewItem > GetFileListItem ( TSharedPtr < FHistoryTreeItem > HistoryTreeItemIn )
{
TSharedPtr < FHistoryFileListViewItem > FileListItem ;
if ( HistoryTreeItemIn . IsValid ( ) )
{
FileListItem = HistoryTreeItemIn - > FileListItem ;
// if this isn't a file list-item itself
if ( ! FileListItem . IsValid ( ) )
{
// then it should have a parent that is one
TSharedPtr < FHistoryTreeItem > ParentFileItem = HistoryTreeItemIn - > Parent . Pin ( ) ;
check ( ParentFileItem . IsValid ( ) ) ;
check ( ParentFileItem - > FileListItem . IsValid ( ) ) ;
FileListItem = ParentFileItem - > FileListItem ;
}
}
return FileListItem ;
}
/**
* Takes a history - tree entry and attempts to find a corresponding asset object
* for the specified revision . If the specified history item doesn ' t have a valid
* RevisionListItem ( it ' s a file list - item ) , we take that to represent the current
* working version of the asset .
*
* @ param HistoryTreeItemIn The history - tree entry that you want a corresponding object for .
* @ return A UObject that represents the asset at the specified revision ( NULL if we failed to find / create one ) .
*/
static UObject * GetAssetRevisionObject ( TSharedPtr < FHistoryTreeItem > HistoryTreeItemIn )
{
UObject * AssetObject = NULL ;
if ( HistoryTreeItemIn . IsValid ( ) )
{
UPackage * AssetPackage = NULL ; // need a package to find the asset in
TSharedPtr < FHistoryFileListViewItem > FileListItem = GetFileListItem ( HistoryTreeItemIn ) ;
check ( FileListItem . IsValid ( ) ) ;
TSharedPtr < FHistoryRevisionListViewItem > RevisionListItem = HistoryTreeItemIn - > RevisionListItem ;
// if this item is referencing a specific revision (and not the current working version of the asset)
if ( RevisionListItem . IsValid ( ) ) // else,
{
// grab details on this file's state in source control (history, etc.)
ISourceControlProvider & SourceControlProvider = ISourceControlModule : : Get ( ) . GetProvider ( ) ;
FSourceControlStatePtr FileSourceControlState = SourceControlProvider . GetState ( FileListItem - > FileName , EStateCacheUsage : : Use ) ;
if ( FileSourceControlState . IsValid ( ) )
{
// lookup the specific revision we want
2015-01-20 05:48:14 -05:00
TSharedPtr < ISourceControlRevision , ESPMode : : ThreadSafe > FileRevision = FileSourceControlState - > FindHistoryRevision ( RevisionListItem - > Revision ) ;
2014-03-14 14:13:41 -04:00
FString TempPackageName ;
if ( FileRevision . IsValid ( ) & & FileRevision - > Get ( TempPackageName ) ) // grab the path to a temporary package (where the revision item will be stored)
{
// try and load the temporary package
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3431384)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3252833 on 2017/01/10 by Ori.Cohen
Refactor constraint so that it can be used for external solvers. (Copying //Tasks/UE4/Dev-ImmediateModePhysics to Dev-Framework (//UE4/Dev-Framework))
Change 3256288 on 2017/01/12 by Ori.Cohen
Undo constraint refactor as we found a way around it and it made the code much harder to read/debug
Change 3373195 on 2017/03/30 by Mike.Beach
For nativization, changing it so we key off of the target platform-info struct instead of the platform (in preparation for defining the nativized plugin's platform whitelist).
Change 3381178 on 2017/04/05 by Dan.Oconnor
Make sure we don't inherit the NATIVE func flag when generating skeleton functions, also make sure all bojects outer'd to the skeleton class are marked transient
#jira UE-43616
Change 3381532 on 2017/04/05 by Marc.Audy
(4.16) Fix various cases where built lighting on child actors could be lost when loading a level
#jira UE-43553
Change 3381586 on 2017/04/05 by Mike.Beach
Now generating TArrayCaster conversions for nativized UClass arrays that need it (to handle different TSubclassOf arrays).
#jira UE-42676, UE-43257
Change 3381682 on 2017/04/05 by mason.seay
Some more changes to test map
Change 3381844 on 2017/04/05 by Dan.Oconnor
Match existing logic for CPF_ReturnParm/CPF_OutParm. Fixes compilation error in BP_TurbineBlades when using compilation manager
Change 3382054 on 2017/04/05 by Zak.Middleton
#ue4 - Optimize CharacterMovementComponent::GetPredictionData_Client_Character() and GetPredictionData_Server_Character() to remove virtual calls.
#jira UE-30998
Change 3382703 on 2017/04/06 by Lukasz.Furman
fixed missing links between navmesh polys when there are more than 4 neighbor connections
#jira UE-43524
Change 3383357 on 2017/04/06 by Marc.Audy
(4.16) Make SetHiddenInGame propagate consistently with SetVisibility
#jira UE-43709
Change 3383359 on 2017/04/06 by Dan.Oconnor
Fix last errant SKEL reference when cooking Odin
Change 3383591 on 2017/04/06 by Mike.Beach
Prevent users from setting object variables as 'config' properties (disallowed by UHT). This prevents some errors that could happen later when users nativize the Blueprint.
#jira UE-42085
Change 3384762 on 2017/04/07 by Zak.Middleton
#ue4 - Fix SpringArmComponent not restoring relative transform when bUsePawnControlRotation is turned off. Fixes the editor interaction ignoring transform of the component in the viewport after bUsePawnControlRotation is toggled on then off, since by then the world transform had been overwritten (from tick in editor) and nothing would drive transform changes from the editable value.
Toggling bUsePawnControlRotation off at runtime now restores the rotation to the initial relative rotation, not stomping it with the current pawn rotation, allowing toggling between the editable/desired base rotation and the control rotation.
#jira UE-24850
Change 3384948 on 2017/04/07 by Dan.Oconnor
Prevent GForceDisableBlueprintCompileOnLoad from causing all sorts of badness when dependencies are loaded as part of a Diff operation. Instead of setting a global flag we flag the package as LOAD_DisableCompileOnLoad
Change 3385267 on 2017/04/07 by Michael.Noland
Graph Editing: Pushed some node diffing code down from UAIGraphNode into UEdGraphNode so nodes with details panel properties will diff correctly (e.g., various animation nodes and BP switch nodes)
#jira UE-21724
Change 3385473 on 2017/04/07 by Phillip.Kavan
#jira UE-43067 - Fix broken pin wires after an Expand Node operation, along with some misc. cleanup.
Change summary:
- Fixed to use correct string for "Expand Node" transaction name.
- Modified FBlueprintEditor::OnExpandNodes() to consolidate some redundant code.
- Fixed to generate a unique node GUID for cases where the source graph is not removed after expansion.
Change 3385583 on 2017/04/07 by Dan.Oconnor
Handle CreatePropertyOnScope nullptr return values (happens for structs missing a struct property)
#jira UE-43746
Change 3386581 on 2017/04/10 by Michael.Noland
Blueprints: Further hardening FBlueprintActionInfo::GetOwnerClass()
#jira UE-43824
Change 3386615 on 2017/04/10 by Marc.Audy
Instanced properties can now properly be set on a per-instance basis in blueprint added components.
#jira UE-42066
Change 3387000 on 2017/04/10 by Marc.Audy
Fix includes for CIS
Change 3387229 on 2017/04/10 by mason.seay
More changes to TM-Gameplay
Added Save Game test (with blueprint)
Tick Interval test (with blueprint)
BP logic cleanup
Level organization
Change 3388437 on 2017/04/11 by Mike.Beach
Adding support for map/set literals in the backend (so you can use set nodes for structs containing sets/maps, without having to connect a RHS input - resets to struct defaults).
#jira UE-42617
Change 3388532 on 2017/04/11 by mason.seay
Submitting latest changes for crash repro
Change 3389026 on 2017/04/11 by Ben.Zeigler
Performance and bug fixes for incremetal cooking with asset registry, duplicate of several changes made on //Fortnite/Main
Fix it so AssetRegistry.ScanPathsAndFilesSynchronous won't scan subdirectories inside already scanned directories, this cuts down on the number of cache files
Fix 2 second stall when shutting down AssetSourceFilenameCache if it had never been previously created
Change 3389163 on 2017/04/11 by Ben.Zeigler
#jira UE-42922 Fix it so connecting function input node output pins does not clear default value, we only want to clear the value when connecting an input pin. Properly testing this fix depends on UE-43883
Change 3389205 on 2017/04/11 by Marc.Audy
Protect against a handful of GEditor usages that can now be hit in standalone
Change 3389220 on 2017/04/11 by Marc.Audy
Don't borrow ClassWithin to masquerade as ParentClass during compilation and instead just set the super struct immediately
Change 3389222 on 2017/04/11 by Michael.Noland
Framework: Adding a cvar (t.TickComponentLatentActionsWithTheComponent) to allow users to revert to the old behavior on when component latent actions tick
- Non-zero values behave the same way as actors do, ticking pending latent action when the component ticks, instead of later on in the frame (default behavior in 4.16 and beyond)
- Prior to 4.16, components behaved as if the value were 0, which meant their latent actions behaved differently to actors
This CVar will be removed in a future version, defaulting to on
#jira UE-43661
Change 3389276 on 2017/04/11 by Marc.Audy
Spelling fix and NULL to nullptr
Change 3389303 on 2017/04/11 by Mieszko.Zielinski
Made sure AIController::Posses doesn't get called when compiling Pawn BP #UE4
#jira UE-43873
Change 3390215 on 2017/04/12 by mason.seay
Removed some tests, will need further review
Change 3390638 on 2017/04/12 by Mike.Beach
Generalizing the omission of the CoerceProperty (in EmitTerm) - previously we were only omitting properties for our custom array lib. For wildcards, a coerce property should not be used as its type will not match.
NOTE: There is a slight behavior change in UEdGraphSchema_K2::ConvertPropertyToPinType(), as it will return 'wildcard' for params marked as 'ArrayTypeDependentParams' (previously would have returned 'int').
#jira UE-42747
Change 3390774 on 2017/04/12 by Ben.Zeigler
#jira UE-43911 Fix several issues with saving a runtime asset registry containing redirectors that caused crashes in cook on the fly. Don't resolve redirectors on incoming links because it will make a circular link, and fix an issue where chained redirectors would break the for loop iteration and return a bad dependency
Fix it so the asset registry written out at the beginning of CookOnTheFly uses the registry generator, otherwise it will include all of the stripped editor only tags
Change 3390778 on 2017/04/12 by Ben.Zeigler
Fix UCookOnTheFlyServer::CollectFilesToCook to check for initial unsolicited packages up front. This is required in iterative mode because it may skip cooking all explicit packages and thus miss a new startup loaded package
Change 3390782 on 2017/04/12 by Ben.Zeigler
Change RunProjectCommand to not imply -nomcp, and allow reading -clientcmdline to override setting the map parameter to 127.0.0.1 by default
Fix RunProjectCommand to remove ios-specific checks to not pass weird platform parameters, and instead never pass them
Fix PS4Platform to pass along command line when calling build cook run, args needs to be the last parameter so explicitly set -target=
Change 3390859 on 2017/04/12 by Mike.Beach
T3D class fields now export with the class's fully qualified path name (to avoid abiguity). Since we can have multiple classes with the same name (Blueprints in different folders), we have to use the class's fully qualified object path.
#jira UE-28048
Change 3390914 on 2017/04/12 by Lukasz.Furman
fixed missing navlink component's transform in exported navigation data
#jira UE-43688
Change 3391122 on 2017/04/12 by Ben.Zeigler
Add new PreloadPrimaryAssets call to AssetManager that stream the desired assets without modifying the official load/unload state. This is useful if you want to preload things in case the might be used in the future, and it also supports recursion
Fix crash calling GetAssetDataForPath with null path
Change 3391494 on 2017/04/12 by Dan.Oconnor
Fix bad references in deep object (widget) hierarchies
#jira UE-43802
Change 3391529 on 2017/04/12 by Dan.Oconnor
Fix log spam, accidently submitted
#rnx
Change 3391756 on 2017/04/12 by Dan.Oconnor
LinkExternalDependencies needs to be performed before we RefreshVariables
#jira UE-43843
Change 3392542 on 2017/04/13 by Marc.Audy
Ensure that initialized actors get cleaned up when removed from world even if that world hasn't begun play.
#jira UE-43879
Change 3392746 on 2017/04/13 by Marc.Audy
(4.16) When duplicating a blueprint node, correctly make the new node a sibling of the duplicated node, not a child of it (unless duplicating the root component).
Also resets scale of a duplicated root component to 1 to avoid a squaring of the scale for that component.
#jira UE-40218
#jira UE-42086
Change 3393253 on 2017/04/13 by Dan.Oconnor
Make sure calculated meta data is correctly set on functions generated by the compilation manager (SKEL_ class functions)
#jira UE-43883
Change 3393509 on 2017/04/13 by Mike.Beach
Removing hack'ish ResetLoaders() call that was causing undesired side-effects (resetting of a loaded package that other objects were relying on). This was originally intended to release file handles so separate editor processes could make updates and save the file (from CL 1712376). Using ResetLoaders() for this is bad though, as it has too many side effects. Instead we have to wait for GC to run. This also makes sure that GC should run as intended as the CookOnTheFly sever is idling.
#jira UE-37284
Change 3394350 on 2017/04/14 by Michael.Noland
Core: Making FDateTime and FTimespan actually reflected, so they get duplicated properly in CopyPropertiesForUnrelatedObjects, etc...
#jira UE-39921
Change 3395985 on 2017/04/17 by Phillip.Kavan
#jira UE-38280 - Fix invalid custom type selections on member fields in the User-Defined Structure Editor after a reload.
Change summary:
- Ensure that the 'SubCategoryObject' member in a UDS variable descriptor has been loaded when converting to an FEdGraphPinType.
Change 3396152 on 2017/04/17 by Marc.Audy
TickableGameObjects that have IsTickableInEditor false should not tick in the editor
#jira UE-40421
Change 3396279 on 2017/04/17 by Phillip.Kavan
#jira UE-43968 - Fix failed validation of bitmask enum types when serializing bitmask literal nodes.
Change 3396299 on 2017/04/17 by Dan.Oconnor
Fix resintancing issues exposed by running TM-Gameplay with -game. We cannot reinstance actors in levels on load because the scene is not created.
#jira UE-43859
Change 3396712 on 2017/04/17 by Marc.Audy
Call PostLoad on subobjects before copying for unrelated properties to avoid cases where an out of date object patched over in the linker has not been brought up to date
#jira UE-38234
Change 3396718 on 2017/04/17 by Mike.Beach
Adding a search bar to the components tree for Blueprints.
#epicfriday
#jira UE-17620
Change 3396999 on 2017/04/17 by Mike.Beach
In generated code, call event '_Implementation' functions directly for interface functions being invoked on self (avoids a UHT runtime error).
#jira UE-44018
Change 3397700 on 2017/04/18 by Marc.Audy
UT struct BlueprintType fixups
Change 3397701 on 2017/04/18 by Marc.Audy
Odin struct BlueprintType fixups
Change 3397703 on 2017/04/18 by Marc.Audy
Ocean struct BlueprintType fixups
Change 3397704 on 2017/04/18 by Marc.Audy
WEX struct BlueprintType fixups
Change 3397705 on 2017/04/18 by Marc.Audy
Additional UT blueprint type struct fixups
Change 3397706 on 2017/04/18 by Marc.Audy
Fortnite struct BlueprintType fixups
Change 3397708 on 2017/04/18 by Marc.Audy
Fixup Engine BlueprintType markup of structs
Change 3397709 on 2017/04/18 by Marc.Audy
Sample Game struct BlueprintType fixups
Change 3397711 on 2017/04/18 by Marc.Audy
Mark AnimNodes as BlueprintType and BlueprintInternalUseOnly
Change 3397712 on 2017/04/18 by Marc.Audy
Paragon struct BlueprintType fixups
Change 3397735 on 2017/04/18 by Marc.Audy
Definition pieces of BlueprintInternalUseOnly to fix UHT errors with structs already marked to use it
Change 3397912 on 2017/04/18 by Mike.Beach
Fix for CIS warnings about shadowed variables (fallout from CL 3396718).
Change 3398455 on 2017/04/18 by Marc.Audy
Make less critical errors log an error rather than immediately throwing allowing multiple errors to be reported in the same compile
Change 3398491 on 2017/04/18 by Marc.Audy
BPRW/BPRO in a non-BlueprintType is now a UHT error
Change 3398539 on 2017/04/18 by Marc.Audy
Fixup live link struct markups
Change 3399412 on 2017/04/19 by Marc.Audy
Fix Match3 blueprint type struct markups
Change 3399509 on 2017/04/19 by Phillip.Kavan
#jira UE-38574 - Fix AnimBlueprint function graphs marked as 'const' to treat 'self' as read-only when compiling.
Change summary:
- Modified FKismetCompilerContext::ProcessOneFunctionGraph() to use the function graph schema rather than the compiler context schema for both the function context's schema as well as testing the function for 'const'-ness. For AnimBPs, the compiler context and the function graph context can differ, so we need to make sure we are using the right one when making queries for a specific function context during compilation.
- Minor cleanup: changed the function context schema to be 'const' in order to be consistent with the function graph GetSchema() API's result. Added a few 'const' qualifiers where needed to match.
- Added a new object version in order to avoid breaking compilation of existing AnimBP function graphs that may already be violating the 'const' rule (this is the same thing that was done when 'const' was first added to "normal" BP function graphs). Just as with normal function graphs in place before the addition, a warning will be generated for existing AnimBP function graphs if they violate 'const' correctness, and an error will be generated for all new ones.
Change 3399749 on 2017/04/19 by Mike.Beach
Hiding the Nativized Blueprints plugin from the in-editor browser (prevent users from disabling it).
Change 3399774 on 2017/04/19 by Marc.Audy
ConditionalPostLoad is already called on StaticMesh earlier in the function
#rnx
Change 3400313 on 2017/04/19 by Mike.Beach
Mirroring CL 3398673 from 4.16
Now, with ICWYU, making sure that the coresponding header gets included first in nativized Blueprint files (else we get a UHT error). Had to fixup some ShooterGame specific files as a result (they had missing includes and forward declarations).
#jira UE-44124
Change 3400328 on 2017/04/19 by Mike.Beach
Missing file from mirrored change (CL 3400313 - mirroring CL 3398673 from 4.16)
#jira UE-44124
Change 3400415 on 2017/04/19 by Chad.Garyet
adding physx switch build to framework
Change 3400514 on 2017/04/19 by Mike.Beach
Back out changelist 3400313 / 3400328 (mirrored from CL 3398673 in 4.16), as it was producing "include PCH first" errors. Likely, CL 3398673 was a fix for a 4.16 specific change, altering the expected include order. We'll have to wait for this one to be integrated back.
Change 3400552 on 2017/04/19 by Marc.Audy
Undo the calling of post load prior to the CPFUO as dependent objects may not yet be loaded. Instead copy the need load flag to the new CDO subobject, similarly to how the top level CDO object copies its flags over.
#jira UE-44150
Change 3400815 on 2017/04/19 by Marc.Audy
Spelling fix (part of PR #3490)
#rnx
Change 3400918 on 2017/04/19 by Marc.Audy
Partial pull of PR #3490: Improved remapping game controls support (Contributed by projectgheist)
This portion brings in the exposure of the bindings to blueprint
#jira UE-44122
Change 3401550 on 2017/04/20 by Marc.Audy
fix kitedemo blueprint type markup
#rnx
Change 3401702 on 2017/04/20 by Mike.Beach
Make it so plugins added to a project through the .uproject's 'AdditionalPluginDirectories' list get folded into the generated code project (for visual studio, etc.).
Change 3401720 on 2017/04/20 by Mike.Beach
Add white and black lists for target type (game, client, server, etc.) to plugin module descriptors.
Change 3401725 on 2017/04/20 by Mike.Beach
Whitelisting the nativized Blueprint plugin for only the targets it was built for (game, server, or client).
Change 3401800 on 2017/04/20 by Ben.Zeigler
Add Algo::BinarySearch, LowerBound, and UpperBound. These are setup to allow binary searching a presorted array, and allow for specifying projection and sort predicates. Convert some engine code to use it
Add TSortedMap, which is a map data structure that has the same API as TMap, but is backed by a sorted array. It uses half the memory and performance is faster below n=10
Add FName::CompareIndexes so a SortedMap with FNames can be used without doing very slow string compares, and FNameSortIndexes predicate to sort by it
Add code to Algo and Container tests. Split up container tests so the new ones aren't run in smoketest as they are a bit slow
Add RemoveCurrent and SetToEnd to ArrayIterator
Change 3401849 on 2017/04/20 by Marc.Audy
Partial pull of PR #3490: Improved remapping game controls support (Contributed by projectgheist)
This portion brings bug fixes and improvements to InputKeySelector UMG widgets.
#jira UE-44122
Change 3402088 on 2017/04/20 by Marc.Audy
Focus the search box when expanding the map value type
#jira UE-44211
Change 3402251 on 2017/04/20 by Ben.Zeigler
Fix issue where SortedMap needs to be resorted after serialization, because the sorting may have changed from when it was saved out
Change 3402335 on 2017/04/20 by Ben.Zeigler
Significant changes to FAssetData serialization and memory, cuts memory significantly but will break code that was using some of the internal API that was not properly hidden before
Both Editor and Runtime cache now use the same FAssetRegistryVersion, which is now registered as a custom version
Rename FAssetData and FAssetPackage operator<< to SerializeForCache to make it clear that it isn't safe to use for general serialization
Remove GroupNames from FAssetData, it has not been useful since the UE4 package structure changed around 4.0
Rename generic-sounding but not actually generic SharedMapView class to AssetDataTagMapSharedView to indicate what it is actually used for
Change TagsAndValues to use a new array-backed TSortedMap as the base structure instead of a hash map. Also, it only allocates the map on demand, which saves significant memory at runtime as many packages have no tags
Add bFilterAssetDataWithNoTags to [AssetRegistry] ini section, if set it will only save cooked asset data if it has tags, off by default but saves significant memory if your whitelist is set up properly
Fix issue where asset registry tags updated by loading assets during cook were not being reflected in the cooked registry
Add AssetRegistry::GetAllocatedSize and add to MemReport output
Change 3402457 on 2017/04/20 by Ben.Zeigler
Enable asset registry iteration and stripping unused asset data in Fortnite. Registry iteration is already on in //Fortnite/Main, stripping is a new feature I want to test
Change 3402498 on 2017/04/20 by Ben.Zeigler
CIS fix. Why did this compile locally?
Change 3402537 on 2017/04/20 by Ben.Zeigler
Remove ensure for making AssetData for subobjects, the editor does this for thumbnail creation in some cases
Change 3402600 on 2017/04/20 by Ben.Zeigler
Add bShouldGuessTypeAndNameInEditor to manager settings, can be set false for games where type cannot be safely implied and content must be resaved
Fix up some bool setting code inside asset manager, and fix const correctness and for iterator issues
AssetManager can now discover any BlueprintCore type when bHasBlueprintClasses=true
Add AssetManager.DumpAssetRegistryInfo to output detailed asset registry usage stats
Add Primary Name to asset audit window by default
Change 3403556 on 2017/04/21 by Marc.Audy
Fix Orion input key selector override class
#rnx
Change 3404090 on 2017/04/21 by mason.seay
Applying Forcefeedback to test map
Change 3404093 on 2017/04/21 by mason.seay
Changing text in level
Change 3404139 on 2017/04/21 by mason.seay
Added Force Feedback test and made some tweaks.
Change 3404146 on 2017/04/21 by mason.seay
Added source reference to Instanced Variable test
Change 3404154 on 2017/04/21 by mason.seay
More minor tweaks
Change 3404155 on 2017/04/21 by Marc.Audy
Remove auto
#rnx
Change 3404188 on 2017/04/21 by Marc.Audy
Fixed crash changing variable type when any type other than map
#jira UE-44249
#rnx
Change 3404463 on 2017/04/21 by Ben.Zeigler
Fix asset data code to not ensure when loading an object with invalid exports, and instead print warning with name of package that needs to be resaved
Resave a map that had a redirector from a DIFFERENT package saved in it's exports. I do not understand how this happened, but it appears to be related to the lightmap BuiltData transition when old maps are opened
Change 3404465 on 2017/04/21 by Ben.Zeigler
Fix issue with trying to load editor-only asset classes in a cooked build
Fix issues with renaming or changing template Ids of assets from the editor
Always print the Duplicate Asset ID error, as if you have more than one the ensuremsg only goes off once
Change 3404481 on 2017/04/21 by Dan.Oconnor
Remove unneeded walk up hierarchy - prevent stale entries in action database if we compile a BP but don't compile its children
Change 3404510 on 2017/04/21 by Phillip.Kavan
#jira UE-35727 - Collapsed graphs containing a local variable node will no longer cause a compile error when the parent graph is renamed.
Change 3404590 on 2017/04/21 by Michael.Noland
Editor: Fixed incorrect filtering of abstract/deprecated UDeveloperSettings and UContentBrowserFrontEndFilterExtension classes caused by a typo (HasAnyCastFlags versus HasAnyClassFlags)
Change 3404593 on 2017/04/21 by Marc.Audy
Fixed another crash to do with input pin secondary combo box
#jira UE-44269
#rnx
Change 3404600 on 2017/04/21 by Michael.Noland
Core: Allow UE_GC_TRACK_OBJ_AVAILABLE to be set externally
#rnx
Change 3404602 on 2017/04/21 by Michael.Noland
Engine: Switched from an include to a forward declaration of SWidget in UDeveloperSettings to keep it slim
#rnx
Change 3404608 on 2017/04/21 by Michael.Noland
Core: Marked TNumericLimits as constexpr so they can be used in static asserts
Change 3404659 on 2017/04/21 by Michael.Noland
Engine: Adding includes back to two UDeveloperSettings subclasses
Change 3405289 on 2017/04/24 by Marc.Audy
Remove auto
#rnx
Change 3405446 on 2017/04/24 by Marc.Audy
Fix Win32 unsigned compile issue
Change 3405512 on 2017/04/24 by Mike.Beach
Piping through NativizationOptions to filename generation (so we're able to gen different files names per target: client vs. server).
Change 3406080 on 2017/04/24 by Ben.Zeigler
Deprecate UEngine::OnPostEngineInit and move to FCoreDelegates, clean up comments for the initialization delegates
Call OnPostEngineInit from commandlet initialization as well as normal execution. I thought about making a wrapper function, but the commandlet calls EditorInit directly so it wouldn't work
Bind delegate to refresh the AssetRegistry native class hierarchy after engine init so it picks up game/plugin classes. Undo ini change that was required to hack around this
Change 3406381 on 2017/04/24 by Ben.Zeigler
#jira UE-23768 Enable Run Physics With No Controller for montage test pawn. The montage pawn has no controller so wasn't correctly running physics when the root motion stopped. This flag needs to be set to allow it to correctly stop after the montage is over
Change 3406438 on 2017/04/24 by Ben.Zeigler
Fix deprecation warning
Change 3406519 on 2017/04/24 by Phillip.Kavan
#jira UE-43612 - Suppress array "Get" node fixup notifications on load when the BP Compilation Manager is enabled.
Change summary:
- Wrapped BPCM calls to FBlueprintEditorUtils::ReconstructAllNodes() and ReplaceDeprecatedNodes() duirng compile-on-load with bIsRegeneratingOnLoad = true. This matches the BP's state during compile-on-load when the BPCM is not enabled.
Change 3406565 on 2017/04/24 by Dan.Oconnor
Make sure all interface functions are added to skeleton
#jira UE-44152
Change 3407489 on 2017/04/25 by Ben.Zeigler
#jira UE-44317 Fix game-only TickableGameObjects to correctly tick in PIE
Change 3407558 on 2017/04/25 by Ben.Zeigler
Fix Fortnite cook warnings, issue had to do with the CDO being registered as a Primary Asset in conflict with the Class being registered
Fix issue with renaming a BP primary asset not finding the old name
Change 3407701 on 2017/04/25 by Dan.Oconnor
Remove unneeded null check, static analysis doen't like the inconsistency
Change 3407995 on 2017/04/25 by Marc.Audy
Fixed maps and sets not working correctly with split pin.
#jira UE-43857
Change 3408124 on 2017/04/25 by Ben.Zeigler
#jira UE-39586 Change it so the blueprint String/Name/Object to Text node creates culture invariant text, and also have them show as an expanded node with a comment explaining this
Fix Transform to actually return in the format specified in the comment, and fix comments on many text conversions
Change 3408134 on 2017/04/25 by Marc.Audy
Graph pin container type now represented by an enumeration (EPinContainerType) rather than 3 "independent" booleans.
FEdGraphPinType constructor, UEdGraphNode::CreatePin, and FKismetCompilerContext::SpawnInternalVariable that took 3 booleans deprecated and replaced with a version that takes EPinContainerType.
UEdGraphNode::CreatePin parameters reorganized so that PinName is before ContainerType and bIsReference, which default to None and false respectively
Change 3408256 on 2017/04/25 by Michael.Noland
Core: Changed UClass::ClassFlags to be of type EClassFlags for improved type safety
Change 3408282 on 2017/04/25 by Marc.Audy
(4.16) Fix incorrect positioning of instance components after duplication
#jira UE-44314
Change 3408404 on 2017/04/25 by Mike.Beach
Adding and removing the nativized plugin to/from the project when we alter the packaging nativization setting (so it gets picked up by project generation).
Change 3408445 on 2017/04/25 by Marc.Audy
Fix up missed deprecation cases
#rnx
Change 3409354 on 2017/04/26 by Marc.Audy
Fix Linux CIS failure
#rnx
Change 3409487 on 2017/04/26 by Marc.Audy
When dragging assets in to the SCS create them as siblings, not nested
#jira UE-43041
Change 3409776 on 2017/04/26 by Ben.Zeigler
#jira UE-44401 Fix issue with cooking a map containing a reparented component. In that case the child component may think it's not editor only, but it's archetype is editor only. This is not allowed in EDL, so now the child is marked as editor only as well
Change 3410168 on 2017/04/26 by Dan.Oconnor
Avoid calling virtual functions in the middle of compile
#jira UE-44243
Change 3410252 on 2017/04/26 by Lukasz.Furman
adjusted WITH_GAMEPLAY_DEBUGGER checks after IWYU changes
#ue4
Change 3410385 on 2017/04/26 by Marc.Audy
ChildActorComponent SetClass no longer fails when setting at runtime.
#jira UE-43356
Change 3410466 on 2017/04/26 by Michael.Noland
Core: Ensuring EClassFlags is 32 bit in a different way (underlying type of the enum is coming out signed even though all members are unsigned, long term fix is probably to move it to an enum class)
#rnx
Change 3410476 on 2017/04/26 by Michael.Noland
Automation: Deleting some commented out methods
#rnx
Change 3411070 on 2017/04/27 by Marc.Audy
Properly complete deprecation of old attachment API
Change 3411338 on 2017/04/27 by mason.seay
Map for Latent Action Tick Bug
Change 3411637 on 2017/04/27 by Ben.Zeigler
Back out CL #3381532 as it was causing crashes when adding new variables to blueprints, as the transaction array was being recursively modified while it was being added to
Change 3412052 on 2017/04/27 by mason.seay
Updated jump test map and pawn
Change 3412231 on 2017/04/27 by Ben.Zeigler
Fix issue where running SearchAllAssets multiple times after mounting new paths would throw away the asset registry cache, which slowed down incremental cooking substantially because the cooker mounts the autosave folder
Duplicate of CL #3411860
Change 3412233 on 2017/04/27 by Ben.Zeigler
Made FStreamableHandle::GetLoadedCount much faster by taking advantage of existing progress counter
Duplicate of CL #3411778
Change 3412235 on 2017/04/27 by Ben.Zeigler
Add code to FStringAssetReferenceThreadContext and FStringAssetReferenceSerializationScope which allows setting package name and collect options for string asset references serialized via something other than linker load
Make RedirectCollector threadsafe to avoid issues with async loading asset references
Fix it so ProcessStringAssetReferencePackageList will remove entries from the string asset array like resolve did, and rename function to indicate that
Fix it so string asset references created by asset labels do not automatically get cooked, and significantly improve the speed of labels with lots of assets
Add code to cooker and asset manager to explicitly mark non-cookable assets as NeverVook, this stops labels from ending up in the build if set that way
Added option to not recurse package dependency changes more than one level when hashes change. This ended up not being significantly faster in a realistic case so left disabled
Duplicate of CL #3412080
Change 3412352 on 2017/04/27 by Marc.Audy
Refix lighting getting wrong position when getting component instance data
Change 3412426 on 2017/04/27 by Marc.Audy
Take first steps to making ComponentToWorld private and force use of accessor
Make bWorldToComponentUpdated private
Make ComponentToWorld and bWorldToComponentUpdated mutable
Add a SetComponentToWorld function for the (likely ill-advised) places that were setting it directly.
Change 3412468 on 2017/04/27 by Marc.Audy
Remove last remnants of deprecated (4.11) custom location system
Change 3413398 on 2017/04/28 by Marc.Audy
Fix up missed deprecated attachment API uses
Change 3413403 on 2017/04/28 by Marc.Audy
Fix Orion compile error
#rnx
Change 3413448 on 2017/04/28 by Marc.Audy
Fix up kite demo component to world privataization warnings
#rnx
Change 3413792 on 2017/04/28 by Ben.Zeigler
Fix many bugs with blueprint pin default values, and add "Reset to Default Value" option to pin context menu
Deprecate and rename SetPinDefaultValue because it actually sets the Autogenerated default. This was being called in bad places and destroying the stored autogenerated defaults
#jira UE-40101 Fix expose on spawn pins to correctly update when the spawned object's defaults change
#jira UE-21642 Fix struct pin default values to properly update when the struct is changed
#jira UE-39418 Fix changed function/macro default values to properly update in already placed call nodes
Change 3413839 on 2017/04/28 by samuel.proctor
Added some Blueprint focused tests for TM-Gameplay
Change 3414030 on 2017/04/28 by Ben.Zeigler
Enable use of AssetPtr variables with Config, for native and blueprint
This incorporates CL #3302487 but also enables for blueprint usage as that code is new to framework branch
Change 3414229 on 2017/04/28 by Marc.Audy
Fixup virtuals not calling their Super
Remove some autos
#rnx
Change 3414451 on 2017/04/28 by Lukasz.Furman
static analysis fix for gameplay debugger
Change 3414482 on 2017/04/28 by Ben.Zeigler
Fix crash found where changing pin type on ConvertAsset accessed an array while deleting it
Change 3414609 on 2017/04/28 by Ben.Zeigler
#jira UE-18146 Refresh graph when disconnecting a resolve asset id node
Change 3415852 on 2017/05/01 by Marc.Audy
Remove unused code
#rnx
Change 3415856 on 2017/05/01 by Marc.Audy
auto removal
#rnx
Change 3415858 on 2017/05/01 by Marc.Audy
Fix function taking an input as reference when unneeded and causing (still unclear why it suddenly started showing up) error in cooking
#rnx
Change 3415946 on 2017/05/01 by Marc.Audy
Have K2Node_StructOperation skip the K2Node_Variable validation as it doesn't need a property (per CL# 1756451)
#rnx
Change 3415988 on 2017/05/01 by Lukasz.Furman
renamed WorldContext param in AI related static blueprint functions to remove load/cook warnings
#jira UE-44544
Change 3416030 on 2017/05/01 by Ben.Zeigler
Fix issue with WorldContext pins being broken by my pin value refactor, partial paths like "WorldContext" need to be stored as strings and not as broken object references.
Change 3416230 on 2017/05/01 by Marc.Audy
Fix spelling error
#rnx
Change 3416419 on 2017/05/01 by Phillip.Kavan
#jira UE-44213 - Nativizing a Blueprint class with a non-nativized Blueprint class subobject dependency will no longer lead to a crash at load time.
Change summary:
- Modified the FFakeImportTableHelper ctor to inject subobject CDOs into the 'SerializeBeforeCreateCDODependencies' array. This in turn ensures that EDL will serialize those subobject CDOs (if necessary) before we create the subobject's nativized owner's CDO at load time.
- Modified FEmitDefaultValueHelper::GenerateCustomDynamicClassInitialization() to emit MiscConvertedSubobject instantiations AFTER we emit the FillUsedAssetsInDynamicClass() call. This is now consistent with the code emitted for other subobjects (all of which assumes that the UsedAssets array has been initialized).
- Modified FFindAssetsToInclude::HandleObjectReference() to add UField owner CDOs in addition to the owner class to the asset dependency list. This ensures that owner CDOs will be emitted alongside the class to both the nativized asset dependency table as well as to the fake import table associated with the UDynamicClass linker for the nativized BP asset.
Change 3416425 on 2017/05/01 by Phillip.Kavan
#jira UE-44219 - Nativizing a Blueprint class with a nativized DOBP class dependency will no longer lead to a compile error at cook/nativization time.
- Modified the FGatherConvertedClassDependencies ctor to properly handle DOBPs in exclusive mode that have been explicitly enabled for nativization. Previously, this code wasn't taking that possibility into account, and as a result could lead to a missing header file in a dependent nativized class body's include set.
- Modified FGatherConvertedClassDependencies::GetFirstNativeOrConvertedClass() to remove the 'bExcludeBPDataOnly' parameter, as it was primarily just being used for a redundant exclusion check when called from the FGatherConvertedClassDependencies ctor. That call site has now been modified to start searching from the super class instead. Additionally, any DOBPs will already fail the preceding WillClassBeConverted() check if they have not been explicitly enabled for nativization in exclusive mode, and will always fail if nativizing in inclusive mode. The extra check was breaking the explicitly-enabled case, so it was removed to allow explicitly-enabled DOBPs to pass.
Notes:
- Allowing for explicitly-enabled DOBPs in exclusive mode may be removed in a future change, but since it is currently supported, the changes noted above will at least ensure that the generated code will compile properly for now.
Change 3416570 on 2017/05/01 by mason.seay
Added UMG test to map. Tweaked force feedback test
Change 3416580 on 2017/05/01 by mason.seay
Resubmitting sub levels
Change 3416597 on 2017/05/01 by Dan.Oconnor
Compilation manager iteration, adds machinery for individual blueprint compilation, adds comments, cleans up duplicated code
Change 3416636 on 2017/05/01 by Phillip.Kavan
#jira UE-44505 - Potential fix for a low-repro crash tied to the Blueprint graph context menu.
Change summary:
- Switched FBlueprintActionInfo::ActionOwner to be a weak object reference.
Change 3416960 on 2017/05/01 by Dan.Oconnor
Use compilation manager when clicking the compile button, PIE'ing, etc
Change 3417207 on 2017/05/01 by Ben.Zeigler
Fix issue with None strings causing default value parsing failures
Add SetPinDefaultValueAtConstruction needed by some other changes
Change 3417519 on 2017/05/01 by Ben.Zeigler
Fix BP compile errors caused by local variables with invalid default values. There's no reason to set autogenerated here because the nodes are transient and invisible in the UI.
There is still a problem here, local variables are not getting their default values validated when type is changed, so you end up with an integer that has the default value of a struct.
Change 3418659 on 2017/05/02 by Ben.Zeigler
#jira UE-44534 Fix it so animation node pins get properly created autogenerated default values that are based on the node struct defaults. This fixes issues when they are reset to other defaults
#jira UE-44532 Fix it so connecting an animation asset pin on a node player resets the pin value to the autogenerated default instead of the cached asset. This was causing old unused assets to get unnecessarily cooked
Fix it so any animation node with an exposed pin that is an object property will reset that object propery when the pin is exposed. This fixes UE-31015 in a generic way
Change the OptionalPinManager to take a Defaults address as well as a current address, to allow setting autogenerated defaults properly
Remove Import/ExportKismetDefaultValueToProperty as they were redundant with PropertyValueFromString and were using the wrong pin setting functions, replaced with PropertyValueFromString_Direct and calling the schema pin set functions
I need to write some backward compatibility code to fix existing nodes, I'll do that in a later checkin
Change 3418700 on 2017/05/02 by Ben.Zeigler
Actually fix None object paths for real this time. I did not test sufficiently before
Change 3418811 on 2017/05/02 by Ben.Zeigler
Fix existing animation blueprint nodes with dead asset references duplicated by pins. This code can be applied independent of the other change to fix specific games
Change 3419165 on 2017/05/02 by Dan.Oconnor
Add misc. functionality from FKismetEditorUtilities::CompileBlueprint
Change 3419202 on 2017/05/02 by Marc.Audy
Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3417825
#rnx
Change 3419236 on 2017/05/02 by mason.seay
Removed OnPressed event from Widget BP
Change 3419314 on 2017/05/02 by Marc.Audy
Fix bad auto-resolve
#rnx
Change 3419524 on 2017/05/02 by Marc.Audy
PR #3528: Improved Input BP library node display names (Contributed by projectgheist)
#jira UE-44587
#rn Improved Input BP library node display names
Change 3419570 on 2017/05/02 by Zak.Middleton
#ue4 - Fix typo in TFunctionRef comment/example.
Change 3419709 on 2017/05/02 by Dan.Oconnor
Fix missing category metadata on SkeletonGeneratedClass when using compilation manager
Change 3419756 on 2017/05/02 by Dan.Oconnor
Remove unintentional verbosity increase
Change 3420875 on 2017/05/03 by Marc.Audy
Make IsExecPin static
Minor optimization to IsMetaPin
#rnx
Change 3420981 on 2017/05/03 by Marc.Audy
Change tagging temporarily until other changes are done so that we don't have warnings in the meantime
#rnx
Change 3421367 on 2017/05/03 by Marc.Audy
Manually introduce changes from CL# 3398673 in 4.16 that failed to make it to Dev-Framework as a result of the integration submitted as CL# 3401725.
#rnx
Change 3421685 on 2017/05/03 by Ben.Zeigler
#jira UE-23001 Convert literal Asset ID/Class ID pins to store path as string instead of as hard object reference. Old pins are fixed on load, after resaving the hard references will go away
Refactor the way that FStringAssetReference and FAssetPtr are serialized, it now does the various fixups in FStringAssetReference::SerializePath, which is called from archivers
Change it so the asset registry reads in a list of all scanned redirectors and adds them to GRedirectCollector, this means that saving a string asset reference will automatically fix it up to point to the redirector destination
Change the default behavior of FAssetPtr serialize on ArchiveUObject to match what most of it's children want, and remove several special case hacks. It now serializes as asset reference when saving/loading, and as object for other cases
Deprecate StringAssetReferenceLoaded/StringAssetReferenceSaving delegates, replace with PreSavePath and PostLoadPath on FStringAssetReference
Make AssetLongPathname private on FStringAssetReference, it was deprecated in 4.9
Change 3421728 on 2017/05/03 by Phillip.Kavan
Mirror CL 3408285 from //UE4/Release-4.16.
#jira UE-44124
#rnx
Change 3422370 on 2017/05/03 by Dan.Oconnor
Mirror 3422359
Implement UBlueprintGeneratedClass::NeedsLoadForEditorGame to match UBlueprint, also tag a class's CDO as NeedsLoadForEditorGame.
This prevents us from failing to load a UBlueprint's GeneratedClass when running the editor with -server.
#jira UE-44659
Change 3423192 on 2017/05/04 by Ben.Zeigler
CIS Fix
Change 3423305 on 2017/05/04 by Ben.Zeigler
Fix "Missing opening parenthesis" warnings for Vector and Rotator the same way they were fixed for Transform
Change 3423358 on 2017/05/04 by Marc.Audy
Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3422809
#rnx
Change 3423766 on 2017/05/04 by Ben.Zeigler
#jira UE-44680 Delete some corrupted redirectors that are no longer in use
Change 3423804 on 2017/05/04 by Dan.Oconnor
Honor SaveIntermediateCompilerResults when using compilation manager
Change 3424010 on 2017/05/04 by Marc.Audy
Validate that switch string cases are unique
Change 3424011 on 2017/05/04 by Marc.Audy
Re-fix switch node default pin not appearing as an exec output
Remove unused boolean
Change 3424071 on 2017/05/04 by Ben.Zeigler
Delete FixupRedirects commandlet, replace with -FixupRedirects/FixupRedirectors option on ResavePackages. This new method is much faster than the old commandlet as it uses the asset registry vs loading all packages, fixing up all redirectors in Fortnite only took about an hour vs 12+ hours the old way
Removed some hacky bits in Core that only existed to support FixupRedirects
Change it so the AssetRegistry listens to DirectoryWatcher callbacks in commandlets now that commandlets use the asset registry properly. This won't do anything unless you tick directory watcher the way that ResavePackages does
Change 3424313 on 2017/05/04 by Dan.Oconnor
Address missing property flags on SkeletonGeneratedClass when using compilation manager
#jira UE-44705
Change 3424325 on 2017/05/04 by Phillip.Kavan
#jira UE-44222 - Move nativized UDS implementation details into its own .cpp file in order to avoid circular dependencies.
Change summary:
- Modified IKismetCompilerInterface::GenerateCppCodeForStruct() to include an output parameter for CPP source and modified FKismet2CompilerModule to match the updated API.
- Modified IBlueprintCompilerCppBackend::GenerateCodeFromStruct() to include an output parameter for CPP source and modified FBlueprintCompilerCppBackendBase to match the updated API.
- Modified FBlueprintNativeCodeGenUtils::GenerateCppCode() to adjust the call to GenerateCppCodeForStruct() to include CPP source output.
- Modified FGatherConvertedClassDependencies::DependenciesForHeader() to switch UDS property dependencies to be forward declarations rather than includes (for default value init code).
- Modified FEmitDefaultValueHelper::GenerateGetDefaultValue() to emit implementation details to the 'Body' container, and adjust the header content to be a declaration only.
- Modified FIncludeHeaderHelper::EmitInner() to exclude a potentially-redundant line for the module's .h file, for the case when the caller has included the base filename in the 'AlreadyIncluded' set.
- Modified FEmitterLocalContext::FindGloballyMappedObject() to limit the 'TryUsedAssetsList' path to UClass conversions only (since that requires a UDynamicClass target to work).
- Modified FGatherConvertedClassDependencies::DependenciesForHeader() to only include BPGC fields if they are also being converted. Eliminates an issue with missing header files in generated code.
Change 3424359 on 2017/05/04 by Ben.Zeigler
Fix issue where StreamableManager would break when requesting an async load that failed the first time. Because our game supports downloading assets during gameplay it's not safe to assume it will never load again.
Port of CL #3424159
Change 3424367 on 2017/05/04 by Ben.Zeigler
Fix some asset manager warnings to not go off in invalid cases
Change 3425270 on 2017/05/05 by Marc.Audy
Pack booleans/enums in UEdGraphNode and FOptionalPinFromProperty
#rnx
Change 3425696 on 2017/05/05 by Ben.Zeigler
#jira UE-44672 Fix it so select node option pins get populated with default values properly
#jira UE-43927 Fix it so select node opion pin type is correctly maintained accross node recreation, as opposed to deriving from the attached pins
#jira UE-44675 Fix it to correctly refresh select node when switching from bool to integer index
Change 3425833 on 2017/05/05 by Ben.Zeigler
#jira UE-31749 Fix it so Undo works properly when modifying a local variable
#jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value
Change 3425890 on 2017/05/05 by Marc.Audy
Fix Copy/Paste of child actor components losing the template
#jira UE-44566
Change 3425947 on 2017/05/05 by Ben.Zeigler
This was meant to be part of last checkin
Change 3425959 on 2017/05/05 by Ben.Zeigler
#jira UE-44692 Fix it so only the sequentially last node can be removed from a Switch On Int, and for Switch On Name stop it from removing an exec pin if it's the only non-default one
Change 3425979 on 2017/05/05 by Dan.Oconnor
PVS fix
Change 3425985 on 2017/05/05 by Phillip.Kavan
Fix an uninitialized variable.
#rnx
Change 3426043 on 2017/05/05 by Ben.Zeigler
#jira UE-35583 Correctly refresh array node UI when connecting pins that change it away from wildcard
Change 3426174 on 2017/05/05 by Zak.Middleton
#ue4 - Avoid call to virtual getSimulationFilterData() to only use it when needed in PreFilter if we actually have items in the IgnoreComponents list (which is rare). The sim filter data 'word2' stores the component ID.
Change 3426621 on 2017/05/05 by Phillip.Kavan
#jira UE-44708 - Fix an issue that re-introduced component data loss in a non-nativized child Blueprint class with a nativized parent Blueprint class.
Change summary:
- Removed an unnecessary additional check I had for the presence of "-NativizeAssets" switch on the command line in UBlueprint::BeginCacheForCookedPlatformData(). This check was failing because the usage was recently changed to include an optional value. It was not needed anyway so I just removed it.
#rnx
Change 3426906 on 2017/05/05 by Ben.Zeigler
#jira UE-11189 Fix function/macro input default values to show as a pin customization instead of as a broken text box that doesn't work correctly for most types. This fixes enums and provide validation for other types
Types that don't have a customization (most structs) will now show any more, they did not work before either
#jira UE-21754 Hide function default values if pass by reference is set
Fix it so changing input parameter will also reset default value, to avoid having the wrong type value set and to work the same as local variables
Change 3426941 on 2017/05/05 by Dan.Oconnor
Fix determinstic cooking of LoadAssetClass nodes in macros
Change 3427021 on 2017/05/05 by Dan.Oconnor
Build fix, make initialization order in source match artifact
#rnx
Change 3427135 on 2017/05/05 by Phillip.Kavan
#jira UE-44702 - Restore code-based interface classes to Blueprint editor UI.
Change summary:
- Partially backed out CL# 3348513 to return to previous behavior for 4.16. The UI is no longer filtering on the __is_abstract() type trait for interface classes.
- Modified FNativeClassHeaderGenerator::ExportClassFromSourceFileInner() to emit the _getUObject() declaration for native interface types as a default implementation that returns NULL rather than as a pure virtual declaration.
#rnx
Change 3427144 on 2017/05/06 by Marc.Audy
Fix init order
#rnx
Change 3427146 on 2017/05/06 by Marc.Audy
remove stray semicolon
#rnx
Change 3427242 on 2017/05/06 by Phillip.Kavan
#jira UE-44744 - Fix a regression in which a UMG Widget Blueprint property not explicitly marked as a variable would cause Blueprint nativization to fail at package time.
Change summary:
- Modified FWidgetBlueprintCompiler::CreateClassVariablesFromBlueprint() to only add 'Category' metadata when we set the 'CPF_BlueprintVisible' flag on the UProperty, which in is now tied to whether or not the property has been explcitly marked as a variable. This avoids a UHT warning when compiling the nativized codegen that would cause packaging to fail.
#rnx
Change 3427720 on 2017/05/08 by Dan.Oconnor
Backing out 3419202
#rnx
Change 3427725 on 2017/05/08 by Dan.Oconnor
SA fix
#rnx
Change 3427734 on 2017/05/08 by Dan.Oconnor
More exhaustive GEditor null checks, to appease SA
#rnx
Change 3427882 on 2017/05/08 by Marc.Audy
Properly order all booleans in intialization
#rnx
Change 3428049 on 2017/05/08 by Marc.Audy
Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3427804
#rnx
Change 3428523 on 2017/05/08 by Ben.Zeigler
#jira UE-44781 Refresh function input UI when blueprint graph refreshes, needed as pins may have gone away
Change 3428563 on 2017/05/08 by Ben.Zeigler
#jira UE-44783 If setting a hard reference pin type from a string, load the referenced object.
Change 3428595 on 2017/05/08 by Dan.Oconnor
Avoid node reconstruction when we're compiling a blueprint with no linker (e.g., a duplicated blueprint)
#jira UE-44777
Change 3428599 on 2017/05/08 by Ben.Zeigler
#jira UE-44789 Fix string asset renamer to not mark IsPersistent becuase that crashes in lightmap code, change it so the path fixup doesn't require the persistent flag
Change 3428609 on 2017/05/08 by Dan.Oconnor
Improved fix for UE-44777
#jira UE-44777
#rnx
Change 3429176 on 2017/05/08 by Phillip.Kavan
#jira UE-44755 - Fix nativization build errors when packaging a game project that is not IWYU-compliant for a build target that disables PCH files.
- Mirrored from //UE4/Release-4.16 (CL# 3429030).
#rnx
Change 3429198 on 2017/05/08 by Phillip.Kavan
CIS fix.
#rnx
Change 3429583 on 2017/05/08 by Ben.Zeigler
Fix SGraphPinClass to work properly after my changes to allow unloaded assets. For Class pins we need to store separate Runtime and Editor asset data objects, as one has _C and refers to the class, and the other doesn't and refers to the blueprint. The content browser wants the editor path, the pin defaults want the runtime path.
Change default value widgets to look more like properties widgets by forcing them to act as highlighted and disabling black background
Change 3429640 on 2017/05/08 by Marc.Audy
Fix issues with select nodes in macros connected to wildcard pins.
#jira UE-44799
#rnx
Change 3429890 on 2017/05/08 by Ben.Zeigler
Fix function/macro defaults to properly propagate when changed using the new edit UI
Refactor some code out of the details customization into the k2 schema
Disable defaults UI for object/class/interface hard references as it is disabled in KismetCompiler
Change 3429947 on 2017/05/08 by Michael.Noland
Core: Backing out CL# 3394352 (marking FDateTime and FTimespan nonexport member Tick with UPROPERTY()), which will re-break UE-39921 but fix UE-44418
There appears to be a more serious underlying issue with how the CDO is instanced which needs to be addressed
#jira UE-44418
#reimplementing 3411681 from Release 4.16
Change 3429987 on 2017/05/08 by Ben.Zeigler
#jira UE-44798 Do a better job of validating object paths saved as default values, due to an old bug with local variables some object paths are saved as struct exportext
At load time clear invalid default value for local variables
Add IsValidObjectPath to FPackageName that validates the passed in path would be valid to load with LoadObject
Change 3430392 on 2017/05/09 by Marc.Audy
Fix SA CIS error
#rnx
Change 3430747 on 2017/05/09 by Ben.Zeigler
#jira UE-44836 Don't reconstruct node during callback for param value changing, this can happen during a reconstruction and recursive reconstruction is unsafe
Don't call ModifyUserDefinedPinDefaultValue unless the default value has actually changed
Change 3431027 on 2017/05/09 by Marc.Audy
Fix BPRW mark up causing Ocean warnings
#rnx
Change 3431353 on 2017/05/09 by Marc.Audy
Fix UHT error due to exposing FJsonObjectWrapper to blueprints
#rnx
[CL 3431398 by Marc Audy in Main branch]
2017-05-09 17:15:32 -04:00
AssetPackage = LoadPackage ( NULL , * TempPackageName , LOAD_DisableCompileOnLoad ) ;
2014-03-14 14:13:41 -04:00
}
} // if FileSourceControlState.IsValid()
}
else // if we want the current working version of this asset
{
FString AssetPackageName = FPackageName : : FilenameToLongPackageName ( FileListItem - > FileName ) ;
AssetPackage = FindObject < UPackage > ( NULL , * AssetPackageName ) ;
}
// grab the asset from the package - we assume asset name matches file name
FString AssetName = FPaths : : GetBaseFilename ( FileListItem - > FileName ) ;
AssetObject = FindObject < UObject > ( AssetPackage , * AssetName ) ;
} // if HistoryTreeItemIn.IsValid()
return AssetObject ;
}
/**
* Constructs revision info for the specified history - tree entry .
*
* @ param HistoryTreeItemIn The history - tree entry that you want revision info for .
* @ param RevisionInfoOut The resulting revision info ( out ) .
*/
static void GetRevisionInfo ( TSharedPtr < FHistoryTreeItem > HistoryTreeItemIn , FRevisionInfo & RevisionInfoOut )
{
2015-01-20 05:48:14 -05:00
RevisionInfoOut . Revision = TEXT ( " " ) ; // clear the revision info (empty string is used signify the current working version)
2014-03-14 14:13:41 -04:00
// if this is a specific revision item
if ( HistoryTreeItemIn . IsValid ( ) & & HistoryTreeItemIn - > RevisionListItem . IsValid ( ) )
{
TSharedPtr < FHistoryRevisionListViewItem > RevisionListItem = HistoryTreeItemIn - > RevisionListItem ;
// fill out the revision info
2015-01-20 05:48:14 -05:00
RevisionInfoOut . Revision = RevisionListItem - > Revision ;
2014-03-14 14:13:41 -04:00
RevisionInfoOut . Changelist = RevisionListItem - > ChangelistNumber ;
RevisionInfoOut . Date = RevisionListItem - > Date ;
}
}
/**
* Takes a array of FHistoryTreeItems and determines if the entries can all be diffed against each other .
*
* @ param SelectedItems A array of FHistoryTreeItems that you want to diff against each other .
* @ param ErrorTextOut Text explaining why the selected items cannot be diffed ( only valid if the return value was false ) .
* @ return True if the selected items could be diffed against each other , false if not .
*/
static bool CanDiffSelectedItems ( TArray < TSharedPtr < FHistoryTreeItem > > const & SelectedItems , FText & ErrorTextOut )
{
bool bCanDiffSelected = false ;
if ( SelectedItems . Num ( ) > 2 )
{
ErrorTextOut = NSLOCTEXT ( " SourceControlHistory " , " TooManyToDiff " , " Cannot diff more than two revisions. " ) ;
}
else if ( SelectedItems . Num ( ) < 2 )
{
ErrorTextOut = NSLOCTEXT ( " SourceControlHistory " , " NotEnoughToDiff " , " Need to select two revisions in order to compare one against the other. " ) ;
}
else
{
TSharedPtr < FHistoryTreeItem > FirstSelection = SelectedItems [ 0 ] ;
TSharedPtr < FHistoryTreeItem > SecondSelection = SelectedItems [ 1 ] ;
if ( ! FirstSelection . IsValid ( ) | | ! SecondSelection . IsValid ( ) )
{
ErrorTextOut = NSLOCTEXT ( " SourceControlHistory " , " InvalidSelection " , " Invalid revisions selected. " ) ;
}
else if ( FirstSelection = = SecondSelection )
{
ErrorTextOut = NSLOCTEXT ( " SourceControlHistory " , " CannotDiffWithSelf " , " You cannot diff a revision against itself. " ) ;
}
else
{
// @TODO make sure the two selections match type (calling GetAssetRevisionObject() to compare class types is too slow)
bCanDiffSelected = true ;
}
}
return bCanDiffSelected ;
} ;
/**
* Takes two FHistoryTreeItems and attempts to diff them against each other ( bringing up the diff window ) .
*
* @ param FirstSelection The first item you want to diff .
* @ param SecondSelection The second item you want to diff .
* @ return True if a diff was performed , false if not .
*/
static bool DiffHistoryItems ( TSharedPtr < FHistoryTreeItem > const FirstSelection , TSharedPtr < FHistoryTreeItem > const SecondSelection )
{
bool bDiffPerformed = false ;
if ( FirstSelection . IsValid ( ) & & SecondSelection . IsValid ( ) )
{
TSharedPtr < FHistoryFileListViewItem > FirstSelectionFileItem = GetFileListItem ( FirstSelection ) ;
TSharedPtr < FHistoryFileListViewItem > SecondSelectionFileItem = GetFileListItem ( SecondSelection ) ;
// we want to make sure the two selections are presented in a sensible order
UObject * LeftDiffAsset = NULL ;
FRevisionInfo LeftVersionInfo ;
UObject * RightDiffAsset = NULL ;
FRevisionInfo RightVersionInfo ;
bool bIsForSingleAsset = ( FirstSelectionFileItem = = SecondSelectionFileItem ) ;
// if we're comparing two revisions for one asset
if ( bIsForSingleAsset )
{
bool bFirstSelectionIsCurrentVersion = FirstSelection - > FileListItem . IsValid ( ) ;
bool bSecondSelectionIsCurrentVersion = SecondSelection - > FileListItem . IsValid ( ) ;
// the second selection is the newer revision iff the first isn't the current working version, and
// it's either the current working version itself, or a newer revision
bool bSecondSelectionIsNewer = ! bFirstSelectionIsCurrentVersion & &
2015-01-20 05:48:14 -05:00
( bSecondSelectionIsCurrentVersion | | ( SecondSelection - > RevisionListItem - > Date > FirstSelection - > RevisionListItem - > Date ) ) ;
2014-03-14 14:13:41 -04:00
if ( bSecondSelectionIsNewer )
{
RightDiffAsset = GetAssetRevisionObject ( SecondSelection ) ;
GetRevisionInfo ( SecondSelection , RightVersionInfo ) ;
LeftDiffAsset = GetAssetRevisionObject ( FirstSelection ) ;
GetRevisionInfo ( FirstSelection , LeftVersionInfo ) ;
}
else
{
LeftDiffAsset = GetAssetRevisionObject ( SecondSelection ) ;
GetRevisionInfo ( SecondSelection , LeftVersionInfo ) ;
RightDiffAsset = GetAssetRevisionObject ( FirstSelection ) ;
GetRevisionInfo ( FirstSelection , RightVersionInfo ) ;
}
}
else // else, we're comparing revisions from two separate assets
{
// keep them in selection order (left to right)
LeftDiffAsset = GetAssetRevisionObject ( FirstSelection ) ;
GetRevisionInfo ( FirstSelection , LeftVersionInfo ) ;
RightDiffAsset = GetAssetRevisionObject ( SecondSelection ) ;
GetRevisionInfo ( SecondSelection , RightVersionInfo ) ;
}
// if we have an asset object for both selections
if ( ( LeftDiffAsset ! = NULL ) & & ( RightDiffAsset ! = NULL ) )
{
FAssetToolsModule & AssetToolsModule = FModuleManager : : LoadModuleChecked < FAssetToolsModule > ( TEXT ( " AssetTools " ) ) ;
AssetToolsModule . Get ( ) . DiffAssets ( LeftDiffAsset , RightDiffAsset , LeftVersionInfo , RightVersionInfo ) ;
bDiffPerformed = true ;
}
}
return bDiffPerformed ;
}
/**
* A FDragDropOperation that represents dragging a source - control history tree item around .
*/
2014-04-23 17:55:20 -04:00
class FSourceControlHistoryRowDragDropOp : public FDragDropOperation
2014-03-14 14:13:41 -04:00
{
private :
/**
* Stubbed private constructor ( in order to force use of the static New ( ) method ) .
*/
FSourceControlHistoryRowDragDropOp ( )
: PendingDropAction ( EDropAction : : None )
{
}
public :
/**
* Allocates and registers a new FSourceControlHistoryRowDragDropOp for use .
*
* @ return The newly allocated ( and registered ) instance .
*/
static TSharedRef < FSourceControlHistoryRowDragDropOp > New ( )
{
TSharedPtr < FSourceControlHistoryRowDragDropOp > NewOperation = MakeShareable ( new FSourceControlHistoryRowDragDropOp ) ;
NewOperation - > Construct ( ) ;
return NewOperation . ToSharedRef ( ) ;
}
2014-04-02 18:09:23 -04:00
DRAG_DROP_OPERATOR_TYPE ( FSourceControlHistoryRowDragDropOp , FDragDropOperation )
2014-03-14 14:13:41 -04:00
struct EDropAction
{
enum Type
{
None ,
Diff ,
} ;
} ;
/** An enum value detailing what operation is queued to happen (if this item is dropped) */
EDropAction : : Type PendingDropAction ;
/** The items that this operation is conceptually dragging around */
TArray < TSharedPtr < FHistoryTreeItem > > SelectedItems ;
/** Text to display with the widget being dragged around */
FText HoverText ;
/**
* Creates the visual widget that you drag around ( to help visualize the drag / drop operation .
*
* @ return A new slate widget representing the dragged item
*/
2014-06-13 06:14:46 -04:00
virtual TSharedPtr < SWidget > GetDefaultDecorator ( ) const override
2014-03-14 14:13:41 -04:00
{
return SNew ( SBorder )
. BorderImage ( FEditorStyle : : GetBrush ( " Graph.ConnectorFeedback.Border " ) )
[
SNew ( SHorizontalBox )
+ SHorizontalBox : : Slot ( )
. AutoWidth ( )
. Padding ( 0 , 0 , 3 , 0 )
[
SNew ( SImage )
. Image ( this , & FSourceControlHistoryRowDragDropOp : : GetIcon )
]
+ SHorizontalBox : : Slot ( )
. AutoWidth ( )
. VAlign ( VAlign_Center )
[
SNew ( STextBlock )
. Text ( this , & FSourceControlHistoryRowDragDropOp : : GetHoverText )
]
] ;
}
/**
* Easy accessor function for getting at the HoverText variable ( provides a
* default one if HoverText is empty ) .
*
* @ return HoverText if it ' s not empty , otherwise : a default string describing that dropping would result in nothing .
*/
FText GetHoverText ( ) const
{
return ! HoverText . IsEmpty ( )
? HoverText
: NSLOCTEXT ( " SourceControlHistory " , " DropActionToolTip_InvalidDropTarget " , " Cannot drop here. " ) ;
}
/**
* Returns a icon brush corresponding to this operation ' s pending drop action .
*
* @ return An ' error ' icon if there is no pending action , otherwise an ' OK ' icon .
*/
FSlateBrush const * GetIcon ( ) const
{
return PendingDropAction ! = EDropAction : : None
? FEditorStyle : : GetBrush ( TEXT ( " Graph.ConnectorFeedback.OK " ) )
: FEditorStyle : : GetBrush ( TEXT ( " Graph.ConnectorFeedback.Error " ) ) ;
}
} ;
/**
* Class used to construct the ordered row content for revision data
*/
class SHistoryRevisionListRowContent : public SMultiColumnTableRow < TSharedPtr < FHistoryTreeItem > >
{
public :
SLATE_BEGIN_ARGS ( SHistoryRevisionListRowContent )
: _RevisionListItem ( )
{ }
SLATE_EVENT ( FOnDragDetected , OnDragDetected )
SLATE_EVENT ( FOnTableRowDragEnter , OnDragEnter )
SLATE_EVENT ( FOnTableRowDragLeave , OnDragLeave )
SLATE_EVENT ( FOnTableRowDrop , OnDrop )
SLATE_ARGUMENT ( TSharedPtr < FHistoryRevisionListViewItem > , RevisionListItem )
2014-06-05 12:10:47 -04:00
/** Whether we should display the expander for this item as it has children */
SLATE_ARGUMENT ( bool , HasChildren )
2014-03-14 14:13:41 -04:00
SLATE_END_ARGS ( )
/**
* Construct the widget
*
* @ param InArgs A declaration from which to construct the widget
*/
void Construct ( const FArguments & InArgs , const TSharedRef < STableViewBase > & InOwnerTableView )
{
RevisionListItem = InArgs . _RevisionListItem ;
check ( RevisionListItem . IsValid ( ) ) ;
2014-06-05 12:10:47 -04:00
bHasChildren = InArgs . _HasChildren ;
2014-03-14 14:13:41 -04:00
SMultiColumnTableRow < TSharedPtr < FHistoryTreeItem > > : : Construct (
FSuperRowType : : FArguments ( )
. OnDragDetected ( InArgs . _OnDragDetected )
. OnDragEnter ( InArgs . _OnDragEnter )
. OnDragLeave ( InArgs . _OnDragLeave )
. OnDrop ( InArgs . _OnDrop ) ,
InOwnerTableView
) ;
}
2014-06-13 06:14:46 -04:00
virtual TSharedRef < SWidget > GenerateWidgetForColumn ( const FName & ColumnName ) override
2014-03-14 14:13:41 -04:00
{
check ( RevisionListItem . IsValid ( ) ) ;
if ( ColumnName = = TEXT ( " Revision " ) )
{
FString SCCAction = RevisionListItem - > Action ;
FName ResourceKey ;
if ( SCCAction = = FString ( TEXT ( " add " ) ) )
{
ResourceKey = TEXT ( " SourceControl.Add " ) ;
}
else if ( SCCAction = = FString ( TEXT ( " edit " ) ) )
{
ResourceKey = TEXT ( " SourceControl.Edit " ) ;
}
else if ( SCCAction = = FString ( TEXT ( " delete " ) ) )
{
ResourceKey = TEXT ( " SourceControl.Delete " ) ;
}
else if ( SCCAction = = FString ( TEXT ( " branch " ) ) )
{
ResourceKey = TEXT ( " SourceControl.Branch " ) ;
}
else if ( SCCAction = = FString ( TEXT ( " integrate " ) ) )
{
ResourceKey = TEXT ( " SourceControl.Integrate " ) ;
}
else
{
ResourceKey = TEXT ( " SourceControl.Edit " ) ;
}
// Rows in a tree need to show an SExpanderArrow (it also indents!) to give the appearance of being a tree.
return
SNew ( SHorizontalBox )
+ SHorizontalBox : : Slot ( )
. AutoWidth ( )
2014-06-05 12:10:47 -04:00
. HAlign ( HAlign_Right )
. VAlign ( VAlign_Fill )
[
SNew ( SExpanderArrow , SharedThis ( this ) )
. Visibility ( this , & SHistoryRevisionListRowContent : : GetExpanderVisibility )
]
+ SHorizontalBox : : Slot ( )
. AutoWidth ( )
2014-03-14 14:13:41 -04:00
. Padding ( 10 , 0 , 10 , 0 )
. HAlign ( HAlign_Center )
. VAlign ( VAlign_Center )
[
SNew ( SImage )
. Image ( FEditorStyle : : GetBrush ( ResourceKey ) )
]
+ SHorizontalBox : : Slot ( )
. AutoWidth ( )
[
SNew ( STextBlock )
2015-01-20 05:48:14 -05:00
. Text ( FText : : FromString ( RevisionListItem - > Revision ) )
2014-03-14 14:13:41 -04:00
] ;
}
else if ( ColumnName = = TEXT ( " Changelist " ) )
{
return
SNew ( STextBlock )
2014-04-23 18:30:01 -04:00
. Text ( FText : : AsNumber ( RevisionListItem - > ChangelistNumber , NULL , FInternationalization : : Get ( ) . GetInvariantCulture ( ) ) ) ;
2014-03-14 14:13:41 -04:00
}
else if ( ColumnName = = TEXT ( " Date " ) )
{
return
SNew ( STextBlock )
2014-09-02 19:28:15 -04:00
. Text ( RevisionListItem - > Date > FDateTime : : MinValue ( ) = = 0 ? FText ( ) : FText : : AsDateTime ( RevisionListItem - > Date ) ) ;
2014-03-14 14:13:41 -04:00
}
else if ( ColumnName = = TEXT ( " UserName " ) )
{
return
SNew ( STextBlock )
. Text ( FText : : FromString ( RevisionListItem - > UserName ) ) ;
}
else if ( ColumnName = = TEXT ( " Description " ) )
{
2014-09-25 10:21:17 -04:00
// Cut down the description to a single line for the list view
FString SingleLineDescription = RevisionListItem - > Description ;
2014-03-14 14:13:41 -04:00
int32 NewLinePos ;
2014-09-25 10:21:17 -04:00
if ( SingleLineDescription . FindChar ( TCHAR ( ' \n ' ) , NewLinePos ) )
2014-03-14 14:13:41 -04:00
{
2014-09-25 10:21:17 -04:00
SingleLineDescription = SingleLineDescription . Left ( NewLinePos ) ;
}
// Trim any trailing new-line characters from the description for the tooltip
FString TooltipDescription = RevisionListItem - > Description ;
while ( TooltipDescription . Len ( ) & & FChar : : IsLinebreak ( TooltipDescription [ TooltipDescription . Len ( ) - 1 ] ) )
{
TooltipDescription . RemoveAt ( TooltipDescription . Len ( ) - 1 , 1 , false ) ;
2014-03-14 14:13:41 -04:00
}
return
SNew ( STextBlock )
2015-01-07 09:52:40 -05:00
. Text ( FText : : FromString ( SingleLineDescription ) )
. ToolTipText ( FText : : FromString ( TooltipDescription ) ) ;
2014-03-14 14:13:41 -04:00
}
else
{
return
SNew ( STextBlock )
. Text ( FText : : Format ( NSLOCTEXT ( " SourceControlHistory " , " UnsupportedColumn " , " Unsupported Column: {0} " ) , FText : : FromName ( ColumnName ) ) ) ;
}
}
2014-06-05 12:10:47 -04:00
EVisibility GetExpanderVisibility ( ) const
{
return bHasChildren ? EVisibility : : Visible : EVisibility : : Collapsed ;
}
2014-03-14 14:13:41 -04:00
private :
TSharedPtr < FHistoryRevisionListViewItem > RevisionListItem ;
2014-06-05 12:10:47 -04:00
/** Whether we should display the expander for this item as it has children */
bool bHasChildren ;
2014-03-14 14:13:41 -04:00
} ;
/** Panel designed to display the revision history of a package */
class SSourceControlHistoryWidget : public SCompoundWidget
{
public :
SLATE_BEGIN_ARGS ( SSourceControlHistoryWidget )
: _ParentWindow ( )
, _SourceControlStates ( )
{ }
SLATE_ATTRIBUTE ( TSharedPtr < SWindow > , ParentWindow )
SLATE_ATTRIBUTE ( TArray < FSourceControlStateRef > , SourceControlStates )
SLATE_END_ARGS ( )
SSourceControlHistoryWidget ( )
{
}
void Construct ( const FArguments & InArgs )
{
AddHistoryInfo ( InArgs . _SourceControlStates . Get ( ) ) ;
2015-01-20 05:48:14 -05:00
TSharedRef < SHeaderRow > HeaderRow = SNew ( SHeaderRow ) ;
const bool bUsesChangelists = ISourceControlModule : : Get ( ) . GetProvider ( ) . UsesChangelists ( ) ;
HeaderRow - > AddColumn ( SHeaderRow : : FColumn : : FArguments ( ) . ColumnId ( " Revision " ) . DefaultLabel ( NSLOCTEXT ( " SourceControl.HistoryPanel.Header " , " Revision " , " Revision " ) ) . FillWidth ( bUsesChangelists ? 100 : 250 ) ) ;
if ( bUsesChangelists )
{
HeaderRow - > AddColumn ( SHeaderRow : : FColumn : : FArguments ( ) . ColumnId ( " Changelist " ) . DefaultLabel ( NSLOCTEXT ( " SourceControl.HistoryPanel.Header " , " Changelist " , " ChangeList " ) ) . FillWidth ( 150 ) ) ;
}
HeaderRow - > AddColumn ( SHeaderRow : : FColumn : : FArguments ( ) . ColumnId ( " Date " ) . DefaultLabel ( NSLOCTEXT ( " SourceControl.HistoryPanel.Header " , " Date " , " Date Submitted " ) ) . FillWidth ( 250 ) ) ;
HeaderRow - > AddColumn ( SHeaderRow : : FColumn : : FArguments ( ) . ColumnId ( " UserName " ) . DefaultLabel ( NSLOCTEXT ( " SourceControl.HistoryPanel.Header " , " UserName " , " Submitted By " ) ) . FillWidth ( 200 ) ) ;
HeaderRow - > AddColumn ( SHeaderRow : : FColumn : : FArguments ( ) . ColumnId ( " Description " ) . DefaultLabel ( NSLOCTEXT ( " SourceControl.HistoryPanel.Header " , " Description " , " Description " ) ) . FillWidth ( 300 ) ) ;
2014-03-14 14:13:41 -04:00
ChildSlot
[
SNew ( SBorder )
. BorderImage ( FEditorStyle : : GetBrush ( " ToolPanel.GroupBorder " ) )
. BorderBackgroundColor ( FLinearColor ( 0.5f , 0.5f , 0.5f , 1.f ) )
[
SNew ( SSplitter )
. Orientation ( Orient_Vertical )
+ SSplitter : : Slot ( )
. Value ( 0.5f )
[
SNew ( SBorder )
[
SNew ( SBox )
. WidthOverride ( 600 )
[
SAssignNew ( MainHistoryListView , SHistoryFileListType )
. TreeItemsSource ( & HistoryCollection )
. ItemHeight ( 25.f )
. SelectionMode ( ESelectionMode : : Multi )
. OnSelectionChanged ( this , & SSourceControlHistoryWidget : : OnRevisionPropertyChanged )
. OnGenerateRow ( this , & SSourceControlHistoryWidget : : OnGenerateRowForHistoryFileList )
. OnGetChildren ( this , & SSourceControlHistoryWidget : : OnGetChildrenForHistoryFileList )
. OnContextMenuOpening ( this , & SSourceControlHistoryWidget : : OnCreateContextMenu )
. HeaderRow
(
2015-01-20 05:48:14 -05:00
HeaderRow
2014-03-14 14:13:41 -04:00
)
]
]
]
+ SSplitter : : Slot ( )
. Value ( 0.5f )
[
SAssignNew ( AdditionalInfoItemsControl , SBorder )
. BorderImage ( FEditorStyle : : GetBrush ( " ToolPanel.GroupBorder " ) )
[
GetAdditionalInfoItemsControlContent ( )
]
]
]
] ;
//expand the top level nodes...
for ( int32 i = 0 ; i < HistoryCollection . Num ( ) ; i + + )
{
MainHistoryListView - > SetItemExpansion ( HistoryCollection [ i ] , true ) ;
}
}
private :
/**
* Constructs the " Additional Info " panel that displays specific revision info
*/
BEGIN_SLATE_FUNCTION_BUILD_OPTIMIZATION
TSharedRef < SWidget > GetAdditionalInfoItemsControlContent ( )
{
const float Padding = 2.f ;
return
SNew ( SVerticalBox )
+ SVerticalBox : : Slot ( )
. AutoHeight ( )
[
SNew ( SHorizontalBox )
+ SHorizontalBox : : Slot ( )
. FillWidth ( 0.25f )
[
//Text Column
SNew ( SVerticalBox )
+ SVerticalBox : : Slot ( )
. FillHeight ( 0.25f )
. Padding ( Padding )
[
SNew ( STextBlock )
2015-01-07 09:52:40 -05:00
. Text ( NSLOCTEXT ( " SourceControl.HistoryPanel.Info " , " Revision " , " Revision: " ) )
2014-03-14 14:13:41 -04:00
]
+ SVerticalBox : : Slot ( )
. FillHeight ( 0.25f )
. Padding ( Padding )
[
SNew ( STextBlock )
2015-01-07 09:52:40 -05:00
. Text ( NSLOCTEXT ( " SourceControl.HistoryPanel.Info " , " Date " , " Date Submitted: " ) )
2014-03-14 14:13:41 -04:00
]
+ SVerticalBox : : Slot ( )
. FillHeight ( 0.25f )
. Padding ( Padding )
[
SNew ( STextBlock )
2015-01-07 09:52:40 -05:00
. Text ( NSLOCTEXT ( " SourceControl.HistoryPanel.Info " , " SubmittedBy " , " Submitted By: " ) )
2014-03-14 14:13:41 -04:00
]
+ SVerticalBox : : Slot ( )
. FillHeight ( 0.25f )
. Padding ( Padding )
[
SNew ( STextBlock )
2015-01-07 09:52:40 -05:00
. Text ( NSLOCTEXT ( " SourceControl.HistoryPanel.Info " , " Action " , " Action: " ) )
2014-03-14 14:13:41 -04:00
]
]
+ SHorizontalBox : : Slot ( )
. FillWidth ( 0.25f )
. Padding ( 20 , 0 )
[
//Data column
SNew ( SVerticalBox )
+ SVerticalBox : : Slot ( )
. FillHeight ( 0.25f )
. Padding ( Padding )
[
SNew ( STextBlock )
. Text ( this , & SSourceControlHistoryWidget : : GetRevisionNumber )
]
+ SVerticalBox : : Slot ( )
. FillHeight ( 0.25f )
. Padding ( Padding )
[
SNew ( STextBlock )
. Text ( this , & SSourceControlHistoryWidget : : GetDate )
]
+ SVerticalBox : : Slot ( )
. FillHeight ( 0.25f )
. Padding ( Padding )
[
SNew ( STextBlock )
. Text ( this , & SSourceControlHistoryWidget : : GetUserName )
]
+ SVerticalBox : : Slot ( )
. FillHeight ( 0.25f )
. Padding ( Padding )
[
SNew ( STextBlock )
. Text ( this , & SSourceControlHistoryWidget : : GetAction )
]
]
+ SHorizontalBox : : Slot ( )
. FillWidth ( 0.25f )
. Padding ( 50 , 0 )
[
//Text Column
SNew ( SVerticalBox )
+ SVerticalBox : : Slot ( )
. FillHeight ( 0.25f )
. Padding ( Padding )
[
//empty for spacing
SNullWidget : : NullWidget
]
+ SVerticalBox : : Slot ( )
. FillHeight ( 0.25f )
. Padding ( Padding )
[
SNew ( STextBlock )
2015-01-07 09:52:40 -05:00
. Text ( NSLOCTEXT ( " SourceControl.HistoryPanel.Info " , " Changelist " , " Changelist: " ) )
2014-03-14 14:13:41 -04:00
]
+ SVerticalBox : : Slot ( )
. FillHeight ( 0.25f )
. Padding ( Padding )
[
SNew ( STextBlock )
2015-01-07 09:52:40 -05:00
. Text ( NSLOCTEXT ( " SourceControl.HistoryPanel.Info " , " Workspace " , " Workspace: " ) )
2014-03-14 14:13:41 -04:00
]
+ SVerticalBox : : Slot ( )
. FillHeight ( 0.25f )
. Padding ( Padding )
[
SNew ( STextBlock )
2015-01-07 09:52:40 -05:00
. Text ( NSLOCTEXT ( " SourceControl.HistoryPanel.Info " , " FileSize " , " File Size: " ) )
2014-06-05 12:10:47 -04:00
]
+ SVerticalBox : : Slot ( )
. FillHeight ( 0.25f )
. Padding ( Padding )
[
SNew ( STextBlock )
2015-01-07 09:52:40 -05:00
. Text ( NSLOCTEXT ( " SourceControl.HistoryPanel.Info " , " BranchedFrom " , " Branched From: " ) )
2014-06-05 12:10:47 -04:00
]
2014-03-14 14:13:41 -04:00
]
+ SHorizontalBox : : Slot ( )
. FillWidth ( 0.25f )
. Padding ( 20 , 0 )
[
//Data column
SNew ( SVerticalBox )
+ SVerticalBox : : Slot ( )
. FillHeight ( 0.25f )
. Padding ( Padding )
[
//empty for spacing
SNullWidget : : NullWidget
]
+ SVerticalBox : : Slot ( )
. FillHeight ( 0.25f )
. Padding ( Padding )
[
SNew ( STextBlock )
. Text ( this , & SSourceControlHistoryWidget : : GetChangelistNumber )
]
+ SVerticalBox : : Slot ( )
. FillHeight ( 0.25f )
. Padding ( Padding )
[
SNew ( STextBlock )
. Text ( this , & SSourceControlHistoryWidget : : GetClientSpec )
]
+ SVerticalBox : : Slot ( )
. FillHeight ( 0.25f )
. Padding ( Padding )
[
SNew ( STextBlock )
. Text ( this , & SSourceControlHistoryWidget : : GetFileSize )
]
2014-06-05 12:10:47 -04:00
+ SVerticalBox : : Slot ( )
. FillHeight ( 0.25f )
. Padding ( Padding )
[
SNew ( STextBlock )
. Text ( this , & SSourceControlHistoryWidget : : GetBranchedFrom )
]
2014-03-14 14:13:41 -04:00
]
]
+ SVerticalBox : : Slot ( )
. AutoHeight ( )
. Padding ( Padding , 10 , Padding , 5 )
[
SNew ( STextBlock )
2015-01-07 09:52:40 -05:00
. Text ( NSLOCTEXT ( " SourceControl.HistoryPanel.Info " , " Description " , " Description: " ) )
2014-03-14 14:13:41 -04:00
]
+ SVerticalBox : : Slot ( )
. FillHeight ( 1.0f )
[
SNew ( SBorder )
[
SNew ( SVerticalBox )
+ SVerticalBox : : Slot ( )
. AutoHeight ( )
. Padding ( 5 )
[
SNew ( STextBlock )
. Text ( this , & SSourceControlHistoryWidget : : GetDescription )
]
]
]
;
}
END_SLATE_FUNCTION_BUILD_OPTIMIZATION
/** Get the last selected revision's revision number */
2015-01-07 09:52:40 -05:00
FText GetRevisionNumber ( ) const
2014-03-14 14:13:41 -04:00
{
if ( LastSelectedRevisionItem . IsValid ( ) )
{
2015-01-20 05:48:14 -05:00
return FText : : FromString ( LastSelectedRevisionItem . Pin ( ) - > Revision ) ;
2014-03-14 14:13:41 -04:00
}
2015-01-07 09:52:40 -05:00
return FText : : GetEmpty ( ) ;
2014-03-14 14:13:41 -04:00
}
/** Get the last selected revision's date */
2015-01-07 09:52:40 -05:00
FText GetDate ( ) const
2014-03-14 14:13:41 -04:00
{
2014-06-05 12:10:47 -04:00
if ( LastSelectedRevisionItem . IsValid ( ) & & LastSelectedRevisionItem . Pin ( ) - > Date ! = 0 )
2014-03-14 14:13:41 -04:00
{
2015-01-07 09:52:40 -05:00
return FText : : AsDateTime ( LastSelectedRevisionItem . Pin ( ) - > Date ) ;
2014-03-14 14:13:41 -04:00
}
2015-01-07 09:52:40 -05:00
return FText : : GetEmpty ( ) ;
2014-03-14 14:13:41 -04:00
}
/** Get the last selected revision's username */
2015-01-07 09:52:40 -05:00
FText GetUserName ( ) const
2014-03-14 14:13:41 -04:00
{
if ( LastSelectedRevisionItem . IsValid ( ) )
{
2015-01-07 09:52:40 -05:00
return FText : : FromString ( LastSelectedRevisionItem . Pin ( ) - > UserName ) ;
2014-03-14 14:13:41 -04:00
}
2015-01-07 09:52:40 -05:00
return FText : : GetEmpty ( ) ;
2014-03-14 14:13:41 -04:00
}
/** Get the last selected revision's revision number */
2015-01-07 09:52:40 -05:00
FText GetAction ( ) const
2014-03-14 14:13:41 -04:00
{
if ( LastSelectedRevisionItem . IsValid ( ) )
{
2015-01-07 09:52:40 -05:00
return FText : : FromString ( LastSelectedRevisionItem . Pin ( ) - > Action ) ;
2014-03-14 14:13:41 -04:00
}
2015-01-07 09:52:40 -05:00
return FText : : GetEmpty ( ) ;
2014-03-14 14:13:41 -04:00
}
/** Get the last selected revision's changelist number */
2015-01-07 09:52:40 -05:00
FText GetChangelistNumber ( ) const
2014-03-14 14:13:41 -04:00
{
Copying //UE4/Dev-Editor to //UE4/Dev-Main (Source: //UE4/Dev-Editor @ 3341527)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3280282 on 2017/01/31 by Matt.Kuhlenschmidt
GitHub 3171 : fix 'memoreport -full' causes ensure condition fail on particle object
Change 3281111 on 2017/02/01 by Michael.Dupuis
#jira UE-36318 : was'nt notifying that we changed the current level in the case where you add/create new level in the Level window
Change 3281225 on 2017/02/01 by Jamie.Dale
Several improvements to culture switching and LocRes files
- LocRes files now de-duplicate translations when they're generated, which can result in smaller LocRes files.
- The localization compilation step now produces a LocNat file, which contains meta-data specifying the native culture during compile, and where the native LocRes file can be found.
- Changing cultures now loads the native localization data prior to loading the non-native translations to ensure that translations are always applied to a consistent base.
- The "leet" culture (available when localization testing is enabled) is now always applied against the native translation, and correctly restores non-translated text when switching away from the "leet" culture.
- "-culture=leet" now works correctly on the command line ("-leet" also works).
- LoadLocalizationResourcesForCulture is no longer called multiple times during initialization of the text localization manager.
- General clean-up of localization code to favor using LocKeyFuncs with maps and sets, rather than rolling their own key funcs.
Change 3281291 on 2017/02/01 by Alexis.Matte
Make sure the sections material slot assignation is persist correctly for staticmesh and for skeletal mesh
#jira UE-39639
Change 3281718 on 2017/02/01 by Michael.Dupuis
#jira UE-34186: invert processing order of special character, to take into account that key name could be considered a special character and would cause the assumption done to no longer be valid
Change 3281861 on 2017/02/01 by Alexis.Matte
Fix import of morph target when there is no animation
#jira UE-41383
Change 3282791 on 2017/02/02 by Chris.Wood
Split crash analytics methods to fix comment parsing issues.
[UE-32787] - Document Crash Report Client analytics events in code
Change 3283316 on 2017/02/02 by Alexis.Matte
Make sure we do not import more then the maximum allowed node
#jira UE-41405
Change 3283349 on 2017/02/02 by Jamie.Dale
Updated Portal to stage its .locnat files
Change 3283927 on 2017/02/02 by Matt.Kuhlenschmidt
Fix component/actor selection becoming out of sync after undo/redo
#jira UE-41416
Change 3284061 on 2017/02/02 by Alexis.Matte
Fix the scene importer front x axis import
#jira UE-41318
Change 3284280 on 2017/02/02 by Alex.Delesky
#jira UE-41060 - Placing blocking volumes in the level via the Content Menu's "Place Actor" command will now place a blocking volume in the level and not generate an empty warning in the output log
Change 3285053 on 2017/02/03 by Michael.Dupuis
#jira UE-33777: Handle the global landscape editor ui command list so specified shortcut will be treated
Change 3285444 on 2017/02/03 by Jamie.Dale
Updated FastDecimalFormat to support the correct 0-9 numerals for the current locale
These are typically still Latin, but Middle Eastern languages have some variants.
This addresses an inconsistency between FText formatting of numbers and dates (since numbers always used Latin, but dates used the culture correct numerals).
Change 3287422 on 2017/02/06 by Michael.Dupuis
#jira UE-36580: Improved the whole word algo to take into consideration localisation
Change 3287455 on 2017/02/06 by Alexis.Matte
When swaping the mesh point by the mesh component, we noe clean up the override material instead of empty it.
#jira UE-41397
Change 3287745 on 2017/02/06 by Alexis.Matte
Merge from orion dev-general cl:3286668
Fix a crash when importing a LOD containing different material with less sections
Change 3287996 on 2017/02/06 by Michael.Dupuis
#jira UE-37290: fixed naming to be "move to level" instead of "move level"
Change 3288090 on 2017/02/06 by Jamie.Dale
Fixing missing include breaking the FText natvis
Change 3288105 on 2017/02/06 by Jamie.Dale
FTextStringHelper::ReadFromString_ComplexText now only looks at the start of the buffer when matching the complex text macros
Change 3288150 on 2017/02/06 by Jamie.Dale
Fixing display names for tutorial categories so that they can be localized
They were already FText, but the config wasn't defining them in a localizable way.
#jira UE-37926
Change 3288469 on 2017/02/06 by Alex.Delesky
#jira UE-35464 - Enables the editor to parse SubRip Subtitles files to create subtitle assets.
This also introduces the Subtitles module.
Change 3288540 on 2017/02/06 by Alex.Delesky
Backing out changelist 3288469 due to build issue with module includes
#jira none
Change 3289074 on 2017/02/06 by Alex.Delesky
Back out changelist 3288540 - reintroducing Subtitles module to parse SubRip Subtitles files
#jira UE-35464
Change 3289753 on 2017/02/07 by Michael.Dupuis
#jira UE-34599: Take into consideration UMaterialExpressionMaterialFunctionCall when getting the GUID
Change 3290097 on 2017/02/07 by Nick.Darnell
Automation - The automation framework no longer buckets errors, warnings and log statements into a seperate set of buckets. There is now only one log, and all entries go into it to provide some context when things fail. Continued working on the styling of the reports.
Change 3290182 on 2017/02/07 by Michael.Trepka
Added missing initialization for SWindow::bIsMirrorWindow
Change 3290472 on 2017/02/07 by Michael.Dupuis
#jira UE-37358: Add reference list in the dialog for all delete type
Change 3290513 on 2017/02/07 by Michael.Dupuis
#jira UE-37958: was testing the trailing number 0 twice and never testing the 1
Change 3290543 on 2017/02/07 by Michael.Dupuis
#jira UE-35931: Refresh detail panel on selection lost
Change 3290581 on 2017/02/07 by Michael.Dupuis
Fixed possible crash if we have no level blueprint specified (was crashing during the delete of an actor)
Change 3290721 on 2017/02/07 by Michael.Dupuis
#jira UE-40360: Pass the custom spawning struct which contain the level override into to the spawn function
Change 3291958 on 2017/02/08 by Alexis.Matte
Back out revision 26 from //UE4/Dev-Editor/Engine/Source/Developer/AssetTools/Private/AssetTools.cpp
Change 3292017 on 2017/02/08 by Alexis.Matte
Add some fbx automation tests to validate material re-import
Change 3292030 on 2017/02/08 by Michael.Dupuis
#jira UE-37958: was testing the trailing number 0 twice and never testing the 1
Change 3293062 on 2017/02/08 by Jamie.Dale
Reduced the number of allocations that happen when rebuilding text
This change removes the wasteful FTextHistory::ToText function and replaces it with two more specialized functions; FTextHistory::BuildLocalizedDisplayString and FTextHistory::BuildInvariantDisplayString.
These new functions return an FString (for the display string), rather than an FText (which was simply mined for its display string). Simply avoiding going via an FText saves at least two allocations per-rebuild.
Changes:
- Removed FTextHistory::ToText and replaced it with FTextHistory::BuildLocalizedDisplayString and FTextHistory::BuildInvariantDisplayString.
- Moved the localization aware chronological and transformation implementations into FTextChronoFormatter and FTextTransformer. These return an FString which avoids an FText allocation during rebuild, and is simply passed into an FText during normal FText usage.
- Moved FText::AsDate, FText::AsDateTime, FText::AsTime, FText::ToUpper, and FText::ToLower into Text.cpp, and these now use FTextChronoFormatter and FTextTransformer from the common text implementation.
- Moved FText::AsTimespan into Text.cpp. This had no dependency on ICU, so this is now the common text implementation.
- Added FTextFormatter::FormatStr variants. FTextFormatter::Format calls these FTextFormatter::FormatStr versions internally, and they're also used during text rebuilding (saving not only an FText allocation, but also a container copy).
- Removed FText::CreateNumericalText and FText::CreateChronologicalText as they were mostly superfluous.
- General update from using MakeShareable to MakeShared (saving 1 allocation).
- General clean-up of L10N/I18N class friendship.
#jira UE-41533
Change 3293292 on 2017/02/08 by Alex.Delesky
Performing some cleanup in the Subtitles module, and creating a SubtitlesEditor module for the subtitles asset factories since it causes issue in client builds.
Change 3293477 on 2017/02/08 by Jamie.Dale
Fixed TProperty::InitializeValueInternal and TProperty::DestroyValueInternal mismatch when dealing with fixed size arrays
#jira UE-41007
Change 3293571 on 2017/02/08 by Matt.Kuhlenschmidt
Fix lots of outline data being added to the font cache due to wrongly hashing outline material and color data.
Change 3293572 on 2017/02/08 by Matt.Kuhlenschmidt
Fix details panel categories in the static mesh editor
Change 3294216 on 2017/02/09 by Michael.Dupuis
#jira UE-40609: manually position the window based on it'S max possible size
#3128 GitHub
Change 3294430 on 2017/02/09 by Jamie.Dale
Kerning-only text shaping no longer draws characters to get their metrics
It now goes via the low-level FT caches like HarfBuzz does.
Change 3294588 on 2017/02/09 by Alexis.Matte
If we remove a LODGroup from baseengine.ini, the fbx importer UI will now be able to recover in case the last fbx import was done with the just removed LODGroup
Change 3294847 on 2017/02/09 by Matt.Kuhlenschmidt
Merging //UE4/Dev-Main to Dev-Editor (//UE4/Dev-Editor)
Change 3295093 on 2017/02/09 by Arciel.Rekman
Linux: fix Setup.sh not working in paths with space (UE-41819).
Change 3295205 on 2017/02/09 by Matt.Kuhlenschmidt
Fix material UV's no longer working om 9 slice elements
Change 3295816 on 2017/02/09 by Arciel.Rekman
Linux: fix starting programs from a path with space.
Change 3296129 on 2017/02/09 by Arciel.Rekman
Linux i686: changes necessary to compile BlankProgram.
- Added new architecture to UBT.
- Fixed system headers.
- Added third party libs for i686:
- jemalloc
- elftoolchain
- zlib
- SDL2
- libc++
Change 3296564 on 2017/02/10 by Jamie.Dale
Cleaned up PO comment preservation
Change 3296694 on 2017/02/10 by Jamie.Dale
AllocateNameEntry now takes TCharType* rather than void* and cast
Change 3296744 on 2017/02/10 by Jamie.Dale
Moved the PO DOM from UnrealEd to Internationalization
Change 3297250 on 2017/02/10 by Jamie.Dale
Split the PO import/export pipeline out of the commandlet
Change 3297420 on 2017/02/10 by Alexis.Matte
Add Isolate and highlight feature for the material panel in the staticmesh and the skeletal editor.
#jira UE-38985
Change 3297594 on 2017/02/10 by Alexis.Matte
When importing from fbx a static mesh with find material anywhere, the next LODs import by the user will create new material entries instead of using the existing one.
Change 3297752 on 2017/02/10 by Arciel.Rekman
i686 support: more third party libs.
- libcurl
- OpenSSL
- libpng
- libvorbis
- libogg
- libopus
Change 3297754 on 2017/02/10 by Arciel.Rekman
i686 support: PhysX
Change 3297922 on 2017/02/10 by Alexis.Matte
When importing a new LOD to a staticmesh, the data source file is not anymore wipe or change to the last fbx import filename.
Change 3298330 on 2017/02/10 by Arciel.Rekman
i686: missing libcurl.
Change 3298620 on 2017/02/11 by Jamie.Dale
FLocTextHelper improvements
- It can now support non-standard target layouts (where the native and foreign cultures are in different locations - see FLocTextTargetPaths).
- The XForeignArchive functions are now more strict, and *only* accept foreign cultures (use the XArchive functions instead if you're using both native and foreign cultures as parameters).
Change 3299293 on 2017/02/13 by Matt.Kuhlenschmidt
PR #3241: UE-41870: Add quotes when passing through the directory path (Contributed by projectgheist)
Change 3299299 on 2017/02/13 by Matt.Kuhlenschmidt
PR #3224: Git plugin: fix git autodetection and add error message (Contributed by SRombauts)
Change 3299391 on 2017/02/13 by Matt.Kuhlenschmidt
Fix material instances being marked dirty when opening
#jira UE-41721, UE-41719
Change 3299441 on 2017/02/13 by Nick.Darnell
PR #3243: Fix bug that UWidget::GetOwningPlayer doesn't return (Contributed by yeonseok-yi)
Change 3299567 on 2017/02/13 by Nick.Darnell
Slate - The Checkbox no longer just passes visibility down to the internal widgets it creates, that prevents future changes to effect it if it starts collapsed.
#jira UE-41904
Change 3299870 on 2017/02/13 by Jamie.Dale
Added cycle counters for font rendering/shaping
Change 3300116 on 2017/02/13 by Michael.Dupuis
#jira UE-41866: Update cache when performing an undo
Change 3300178 on 2017/02/13 by Alexis.Matte
Fix a crash when re-importing a LOD with more sections then the base LOD
Change 3300191 on 2017/02/13 by Alexis.Matte
Make sure we do not loose castshadow and recomputetangents section flags when we re-import a skeletal mesh.
Change 3300351 on 2017/02/13 by Alexis.Matte
Remove the clean up of unused material for the staticmesh editor. Unused material can be delete manually in the UI
#jira UE-39639
Change 3302138 on 2017/02/14 by Nick.Darnell
Automation - Adding support for -DeveloperReportOutputPath and -DeveloperReportUrl to permit local runs of the automation tool to generate reports on the report server, and launch the browser window to view them.
Change 3302139 on 2017/02/14 by Nick.Darnell
UMG - Additional fixes to the way we migrate changes from the preview to the serialized version of the widget tree. This fixes several issues with edit-inline objects on UWidgets.
Change 3302281 on 2017/02/14 by Nick.Darnell
Slate - Bringing over changes to the invalidation panel from one of the game streams. This fixes issues with animations in volatile widgets, as well as some issues with cache relative offset, and offers a method for enabling a different caching method to preserve batching through a commandline, but at the cost of not being able to use GPU buffers, possibly a better option on mobile in some cases.
Change 3302415 on 2017/02/14 by Nick.Darnell
Disabling the open asset editor test.
Change 3302976 on 2017/02/14 by Nick.Darnell
Automation - Updating one of the tests to open 70 different known asset types, and ensure that they open without dirtying the package. AutomationTestSettings are now defaultengine, not sure why they setup to be user specific previously. Most of these settings need to be removed, or split off into the modules that own them, rather than being in Engine. TODO.
Change 3303724 on 2017/02/15 by Matt.Kuhlenschmidt
Removed hard coded list of thumbnails, preventing objects with valid thumbnails from showing up. Thumbnails are now shown by default. Use meta=(DisplayThumbnail=false) to remove
#jira UE-41958
Change 3303729 on 2017/02/15 by Matt.Kuhlenschmidt
PR #3253: UE-34539: (Bugfix) Allow binary files in git stored via git-fat, git-lfs, etc to be diffed (take 2) (Contributed by rpav)
Change 3303733 on 2017/02/15 by Matt.Kuhlenschmidt
PR #3248: Fix for TAssetSubClassOf properties reset on undo. (Contributed by StefanoProsperi)
Change 3303823 on 2017/02/15 by Nick.Darnell
Automation - Continued improvements on screenshots. Added some fixes to turn off the tonemapper when visualizing buffers. Fixed several screenshots due to this change. Adding lightboxes to the reports. Adding some styling to make things sweeter.
Change 3303937 on 2017/02/15 by Matt.Kuhlenschmidt
Fix build error
Change 3303982 on 2017/02/15 by Nick.Darnell
Automation - Making the opening of the image no longer threaded, not really helpful for the IO operation and just makes it harder to follow.
Change 3304058 on 2017/02/15 by Matt.Kuhlenschmidt
Fix build attempt #2 (not reproducible locally)
Change 3304393 on 2017/02/15 by Matt.Barnes
Submitting test content for UEQATC-3548
Change 3304517 on 2017/02/15 by Nick.Darnell
Slate - Making some fixes to the automatic disabling of the pixel snapping code with render transforms. Sometimes it gets confused, we may want to move to a seperate transform stack for layout and render, and make sure the element drawer has access to both.
Change 3304560 on 2017/02/15 by Nick.Darnell
UMG - SA fix.
Change 3304890 on 2017/02/15 by Matt.Kuhlenschmidt
PR #3220: UE-41243: Force resolution in standalone if large than primary workin. (Contributed by projectgheist)
Change 3305360 on 2017/02/15 by Arciel.Rekman
Linux: fix crash on exit (UE-41907).
- It is not safe to dereference UAnimGraphNode_PoseDriver::StaticClass during the final shutdown sequence since the instance has already been destroyed in StaticExit().
Change 3306023 on 2017/02/16 by Nick.Darnell
Paper2D - Adding a method to create SlateBrushes from PaperSprites the same way we can for materials and textures in blueprints.
Change 3306030 on 2017/02/16 by Nick.Darnell
Slate - Making some additional fixes to invalidation panels from a game branch. Adding a RoundToVector function to FVector2D, fixing the 3 places we defined a RoundToInt (which wasn't a great name since the convention wasn't meant to be used that way).
Change 3306031 on 2017/02/16 by Nick.Darnell
Slate - Retainer widgets no longer tick using PreTick on SlateApplication, they now paint during their normal paint.
Change 3306046 on 2017/02/16 by Nick.Darnell
UMG - Adding CanEditChange to WidgetComponent to gray out the CylinderArcAngle property unless you select the right geometry mode.
Change 3308887 on 2017/02/17 by Matt.Kuhlenschmidt
Fix crash if blurs are rotated
#jira UE-42037
Change 3309114 on 2017/02/17 by Jamie.Dale
Unifying non-shaped text to use the same atlas cache as shaped text
Change 3310044 on 2017/02/17 by Matt.Kuhlenschmidt
Outline color on text elements is now inherited properly
#jira UE-40691
Change 3310268 on 2017/02/17 by Matt.Kuhlenschmidt
Guard against rendering MIDs with potentially no parent in slate.
#jira UE-42047
Change 3311531 on 2017/02/20 by Michael.Dupuis
#jira UETOOL-1100:
Add the possibility to have dynamic min/max slider value
Synchonize all Color vector together when changing the min/max slider value
Change 3311534 on 2017/02/20 by Michael.Dupuis
incremental build fix
Change 3311535 on 2017/02/20 by Michael.Dupuis
incremental build fix take 2...
Change 3311743 on 2017/02/20 by Michael.Dupuis
buildfix lunix incremental
Change 3312496 on 2017/02/20 by Arciel.Rekman
Linux: fix PhysX crash in i686.
- Changed layout to one that works.
Change 3313127 on 2017/02/20 by Jamie.Dale
Fixed crash when performing a non-async cooked package save
It isn't safe to call TotalSize on the BulkArchive when it's not a FBufferArchive (as used during async save) once the archive has been closed.
Change 3313990 on 2017/02/21 by Nick.Darnell
Automation - Added a summary area at the top of the report.
Change 3314034 on 2017/02/21 by Jamie.Dale
Fixed crash when deleting a streamed font
Change 3314942 on 2017/02/21 by Nick.Darnell
Automation - More templating styling work.
Change 3315080 on 2017/02/21 by Nick.Darnell
Automation - Providing a way for users to remove explict events from the event log when automated tests run. Needed for other systems linked into the automation system like google mock.
Change 3315452 on 2017/02/21 by Nick.Darnell
Json - Adding support for Map and Set properties to the JsonObjectConverter. Can now save out map and sets. No support for loading them yet.
Change 3315614 on 2017/02/21 by Nick.Darnell
Json - Adding support for loading sets and map json data.
Change 3315924 on 2017/02/21 by Arciel.Rekman
Vulkan: edigrating various Linux fixes by Josh.
- This is to make Linux Vulkan work in Dev-Editor easier (for the contractor and myself).
Original descriptions:
CL 3313445
- Various Vulkan fixes:
- Compiles in Linux
- Many cubemap bugs squashed
- Changed the scratch reflection cubemap clear to SetRenderTargestsAndClear, instead of SetRenderTarget() / Clear()
- Added compute fences
CL 3314152
- Fixed compile error on Mac, but I am pretty sure we can just remote VulkanRHI from Mac building entirely, but needs to be tested.
Change 3316741 on 2017/02/22 by Jamie.Dale
Ensure that enums used by BP nodes have been PostLoaded so they have the correct display names
#jira UE-42253
Change 3316800 on 2017/02/22 by Matt.Kuhlenschmidt
Merging //UE4/Dev-Main to Dev-Editor (//UE4/Dev-Editor)
Change 3317058 on 2017/02/22 by Alexis.Matte
Fix the scene importer to support correctly the obj file format
#jira UE-35606
Change 3318039 on 2017/02/22 by Arciel.Rekman
i686 support: added missing libwebsockets.
Change 3318095 on 2017/02/22 by Arciel.Rekman
i686 support: Oodle.
Change 3319002 on 2017/02/23 by Michael.Dupuis
#jira UE-41794 : Do not exit the landscape mode when doing undo from the creation of the landscape
Change 3319012 on 2017/02/23 by Alexis.Matte
PR #3066: Improve asset import by permitted relative paths and easing editing of mapped mount points. (Contributed by paulevans)
#jira UE-40039
Change 3319035 on 2017/02/23 by Nick.Darnell
UMG - Adding a note about the font sizes in UE4 in Slate, using 96 dpi.
#jira UE-42170
Change 3319040 on 2017/02/23 by Matt.Kuhlenschmidt
PR #3278: Git plugin: fix revision number for blueprint diff menu (Contributed by SRombauts)
#jira UE-42129
Change 3319072 on 2017/02/23 by Michael.Dupuis
#jira UETOOL-1101: Add support for DetailGroup reset to default
Right now it's only enable for the color grading
Change 3319077 on 2017/02/23 by Nick.Darnell
Automation - Moving away from most of the templating being done in C++. Moving to dust.js to just do it in the browser window. The json report file is now the actual source of the information we use to template the resulting report html. Maaay have to move to doing the templating server side in the future to stream it to the client better, but avoiding that so we don't have to ship a server. Disabling several places we were taking editor screenshots, none of that code was actually comparing screenshots, it was a hold-over from earlier days.
PhysX - Fixing a problem with Physx FillInlinePxShapeArray. Deprecating it, adding FillInlinePxShapeArray_AssumesLocked, and locking places we were assuming it was already locked in the landscape component.
Change 3319088 on 2017/02/23 by Nick.Darnell
PR #3245: UE-41707: Re-order includes correctly (Contributed by projectgheist)
#jira UE-41914
Change 3319104 on 2017/02/23 by Michael.Dupuis
fix incremental build
Change 3319146 on 2017/02/23 by Matt.Kuhlenschmidt
PR #3292: Git plugin: fix update status on directories broken since UE4.12 (Contributed by SRombauts)
#jira UE-42272
Change 3319252 on 2017/02/23 by Michael.Dupuis
fix warning with missing #undef LOCTEXT_NAMESPACE
Change 3319298 on 2017/02/23 by Alex.Delesky
Removing the Subtitles and SubtitlesEditor modules (it'll eventually be brought back as the Overlay and OverlayEditor modules)
Change 3319388 on 2017/02/23 by Alexis.Matte
Fbx Importer now find collision model under fbx LOD Group
#jira UE-42141
Change 3319528 on 2017/02/23 by Michael.Dupuis
Fixed Undo/Redo to be consistent with other vector modifcation behavior
Change 3319583 on 2017/02/23 by Alexis.Matte
Fix the sample rate to use the least common multiplier of all keys
#jira UE-42012
Change 3319705 on 2017/02/23 by Nick.Darnell
Static Analysis - Fixing sonobjectconverter.cpp(460) : warning C6011: Dereferencing NULL pointer 'ArrayProperty'.
Change 3319711 on 2017/02/23 by Nick.Darnell
Editor - Adding some checks to make sure the struct we're accessing is still a valid handle.
#jira UE-42262
Change 3319736 on 2017/02/23 by Alex.Delesky
Adding Subtitles and SubtitlesEditor to the JunkManifest file.
Change 3319919 on 2017/02/23 by Nick.Darnell
Automation - Fixing an issue with moving a location that doesn't exist.
Change 3319932 on 2017/02/23 by Alexis.Matte
Fbx importer, do not apply more then one time the transform option to the scene node.
#jira UE-42277
Change 3320105 on 2017/02/23 by Nick.Darnell
Editor - Adding some additional checks to the margin customization.
#jira UE-42262
Change 3321577 on 2017/02/24 by Jamie.Dale
Moving Internationalization module from Runtime to Developer
Change 3321625 on 2017/02/24 by Jamie.Dale
Moving InternationalizationSettings module from Developer to Editor
Change 3321642 on 2017/02/24 by Jamie.Dale
Moving SCulturePicker from the Localization module to the InternationalizationSettings module
Change 3321734 on 2017/02/24 by Alexis.Matte
PR #2979: Fix extra root bone for Blender exported FBX. (Contributed by manmohanbishnoi)
We fix the extra root only when the file creator is from blender and the root node is named armature. We cannot simply remove all dummy node, since this is use by the rigid mesh workflow.
#jira UE-39050
Change 3321912 on 2017/02/24 by Jamie.Dale
Split LocalizationCommandletExecution out of the Localization module to remove some editor dependencies
Change 3322274 on 2017/02/24 by Jamie.Dale
Moving Localization module from Editor to Developer, and merging the Internationalization module into it
Removed hard-dependency between Engine and Localization/Internationalization via an interface.
Change 3322774 on 2017/02/25 by Jamie.Dale
Unifying LocRes and LocNat file format between generation and loading
This lets the code in Core be shared by Localization, and allows some code that was proxying via archives (due to the code being logically identical, but different C++ types) to use these new types directly.
#tests Built Debug, Shipping, and Editor. Verified that LocNat and LocRes generation and loading worked as before.
Change 3322795 on 2017/02/25 by Jamie.Dale
Fixing mismatch between SOURCE_CONTROL_WITH_SLATE and its .Build.cs file
The define was set to disable Slate for Linux program targets only, but the .Build.cs disabled Slate for all Linux targets.
Since the define was touched most recently (CL# 2534983), I updated the .Build.cs file to match its logic, and moved the definition of the define to the .Build.cs file so that they stay in sync with one another.
Change 3322853 on 2017/02/25 by Jamie.Dale
Moved the conflict and word count reporting to FLocTextHelper
Change 3323089 on 2017/02/26 by Jamie.Dale
Added functions to get the target name and path from FLocTextHelper
Change 3323391 on 2017/02/27 by Ben.Cosh
This fixes an issue with blueprint config variables having their value destroyed by CDO serialization
#Jira UE-40586 Blueprint variable defaults set from config files value are overwritten by CDO serialization
#Proj Engine, CoreUObject
Change 3323406 on 2017/02/27 by Ben.Cosh
Fixed a problem that caused UK2Node::ExpandSplitPin to destroy pins it didn't own in when expanding a collapsed graph during compilation.
#jira UE-41211 - Crash when splitting a UDS pin on a collapsed graph
#Proj BlueprintGraph
Change 3323572 on 2017/02/27 by Nick.Darnell
Automation - Continued itteration on the style of the automation reports, now with attentional info, like where the log came from.
Automation - Fixing a bug in the functional actor tests, navigating to the actors sometimes opened other objects in the package, now it only opens the map. Also improved the way we focus the actor so that the level editor is also brought to the foreground.
Automation - Fixing a bug in how the automation system was registering for capturing logging. It was swapping out GWarn for its own version, but GWarn isn't called for anything that isn't an error or warning, meaning that none of the Display/Logging or analytics capture attempts were actually working. Suddenly a flood of informations started being captured during tests. For now - only going to capture 'Display' logs instead of 'Log' level.
Automation - Successful comparisons now print more information so that the automation logs do a better job of tracking the flow of the test.
Automation - The screenshot comparison test now prints more information even during successful comparisons.
Editor - The message log no longer emits a SetSelection, just because the selection is updated the categoriry view model. This was causing things like the automation tool, which sets the selection every time (which may itself be an issue) to completely rebuild the message log every time a new automation message was emited. The message log now checks if the selection would actually change the viewstate before it does it.
Domino Test - Adding an arrow to visualize the state of the up vector the test is looking for; playing with idea for test visualizers that may help with debugging in the future.
Change 3323580 on 2017/02/27 by Michael.Trepka
Fixed some Xcode 8.3 compile errors
Change 3323634 on 2017/02/27 by Nick.Darnell
Build - Fix incremental build.
Change 3323740 on 2017/02/27 by Jamie.Dale
Adding #error if the SOURCE_CONTROL_WITH_SLATE define is missing
Change 3323865 on 2017/02/27 by Nick.Darnell
Automation - Disabling the screenshot from the small editor icons test, until the editor screenshot method starts comparing things, and the screenshots we take are better / more scoped.
Change 3324228 on 2017/02/27 by Jamie.Dale
Can no longer name assets or folders with a leading underscore
#jira UE-40541
Change 3324429 on 2017/02/27 by Jamie.Dale
Removing FLocTextTargetPaths
It was added to support something that I'm now going to do a different way.
Change 3324473 on 2017/02/27 by Jamie.Dale
Moved the GatherText SCC utils into the Localization module
Change 3324481 on 2017/02/27 by Jamie.Dale
Moving the localized asset utils out of GatherText base
Change 3324485 on 2017/02/27 by Jamie.Dale
Cleaning up some includes now that the localization SCC is no longer in GatherText
Change 3324910 on 2017/02/28 by Nick.Darnell
Slate - Moving the SlateRotatedRect into its own file, and removing FSlateRotatedClipRectType, since there's no longer a difference and we only use FSlateRotatedRect.
Change 3325329 on 2017/02/28 by Michael.Dupuis
#jira UE-42083: Removed various Modify(true) that would force user to save the levels even if they did'nt really modified them
Replace TMap<TLazyObjectPtr,...> as it would dirty the level at every Find performed
Change 3325410 on 2017/02/28 by Michael.Dupuis
missing include for incremental build
Change 3325415 on 2017/02/28 by Nick.Darnell
UMG - Adding some setters and getters for RedrawTime to the WidgetComponent.
Change 3325418 on 2017/02/28 by Nick.Darnell
Automation - Fixing the warnings on startup about smoke tests taking longer than 2s. Had to add an option to disable capturing the callstack when running smokes, it adds a bit too much overhead during startup.
Change 3325698 on 2017/02/28 by Alexis.Matte
Put back the code to isolate material versus section in the skeletal mesh. The code was override by a temporary hack done in paragon branch
Change 3325790 on 2017/02/28 by Michael.Trepka
Copy of CL 3319588
Fixed address sanitizer support in MacToolChain (Apple changed the name of the env variable Xcode uses to enable it) and added support for thread sanitizer
Change 3326118 on 2017/02/28 by Alexis.Matte
Add LOD settings LOD distances to fbx import dialog option. The option are not supported yet by the scene importer
#jira UE-41291
Change 3326183 on 2017/02/28 by Alexis.Matte
PR #3298: Import SpecularFactor for Roughness and Shininess for Metallic textures (Contributed by VladimirPobedinskiy)
#jira UE-42301
Change 3326196 on 2017/02/28 by Jamie.Dale
Force the correct package localization ID when duplicating a BP for nativization
Change 3327037 on 2017/03/01 by Michael.Dupuis
fixed fortnite mac non editor build
Change 3327483 on 2017/03/01 by Jamie.Dale
Renaming LocNat to LocMeta
Change 3327486 on 2017/03/01 by Jamie.Dale
Renaming LocNat to LocMeta
Change 3327541 on 2017/03/01 by Michael.Trepka
Removed Mac OpenGL RHI files and disabled building of OpenGL RHI on Mac
Change 3328000 on 2017/03/01 by Nick.Darnell
Automation - Noisy rendering features are now disabled by default when taking screenshots.
Change 3328323 on 2017/03/01 by Michael.Trepka
Copy of CL 3307526
Fixed mouse position issues in fullscreen mode on Mac
Change 3328410 on 2017/03/01 by Alexis.Matte
Remove unwanted option when importing skeletal mesh
Make the FBX tests uptodate with the new ImportUI options
#jira UE-41291
Change 3329586 on 2017/03/02 by Jamie.Dale
Adding missing includes when running with bUseMallocProfiler enabled
Change 3329999 on 2017/03/02 by Nick.Darnell
UMG - Removing a deprecated 4.8 function to get the label on UWidget.
Change 3330004 on 2017/03/02 by Nick.Darnell
UMG - Adding TargetPlatform to the dependencies of UMGEditor module.
Change 3330021 on 2017/03/02 by Nick.Darnell
UMG - Adding TargetPlatform to the private include path of the UMG module.
Change 3330041 on 2017/03/02 by Nick.Darnell
Engine - Adding a comment to the PreLoadMap call so people know what the string being passed in is.
Change 3330048 on 2017/03/02 by Nick.Darnell
Editor - Don't allow querying the cursor in the editor viewport while saving packages. Depending upon the code that gets triggered, it may cause packages to load, or things to be initialized while saving is occuring.
Change 3330602 on 2017/03/02 by mason.seay
Map for Functional Screenshot Test Bug
Change 3330632 on 2017/03/02 by Alexis.Matte
Fix fbx crash when there is only one UVChannel but using the naming convention to place it further then the first index
Change 3330862 on 2017/03/02 by Jamie.Dale
Adding FPaths::SetExtension
This is like FPaths::ChangeExtension, but also applies the extension if the file doesn't have one.
Change 3331491 on 2017/03/03 by Nick.Darnell
Automation - Fixing a threading issue in the SAsyncImage, it was accessing potentially bogus memory if the Widget had been deleted before the task ran.
Change 3331498 on 2017/03/03 by Nick.Darnell
Build - Fixing a build warning.
Change 3331807 on 2017/03/03 by Nick.Darnell
Automation - Making the Disable Noisy Rendering Features more robust, disabling a few more markers. Adding a better way of rolling back the changes.
Change 3331999 on 2017/03/03 by Michael.Trepka
Fixed a memory leak on texture creation with BulkData in OpenGLTexture.cpp
Change 3332481 on 2017/03/03 by Arciel.Rekman
Fix building lighting in commandlet (UE-42551).
- Process task graph while running as commandlet.
- Also, if for any reason - like the lack of -messaging - local swarm interface fails to initialize or takes too much time to send the message, bail out.
Change 3332606 on 2017/03/04 by Jamie.Dale
Fixing crash reporting loc word counts when the report is starting empty
Change 3332614 on 2017/03/04 by Jamie.Dale
Fixed text namespaces being treated as case-insensitive when export to JSON manifests and archives
Change 3332619 on 2017/03/04 by Jamie.Dale
Fixing CIS error
Change 3333000 on 2017/03/06 by Matt.Kuhlenschmidt
PR #3295: Non-editable FStringAssetReference using VisibleAnywhere (Contributed by projectgheist)
#jira UE-42284
Change 3333039 on 2017/03/06 by Alexis.Matte
Make custom ui for FbxSceneImportData object
#jira UE-37896
Change 3333047 on 2017/03/06 by Nick.Darnell
UMG - Removing an extra assignment in WidgetSwitcher.
Change 3333056 on 2017/03/06 by Alexis.Matte
Build fix
Change 3333073 on 2017/03/06 by Matt.Kuhlenschmidt
Added more logging for when window creation fails due to too many windows.
#jira UE-42478
Change 3333081 on 2017/03/06 by Matt.Kuhlenschmidt
PR #3327: Git Plugin: fix RunDumpToFile() to check git ReturnCode (Contributed by SRombauts)
#jira UE-42535
Change 3333103 on 2017/03/06 by Matt.Kuhlenschmidt
PR #3336: UE-42407: using GetWindowMode instead of switching on IsFullscreenViewport (Contributed by stefanzimecki)
#jira UE-42407, UE-42565
Change 3333142 on 2017/03/06 by Jamie.Dale
Added a way to view/copy a list references (including those that aren't loaded) to the reference viewer
Change 3333443 on 2017/03/06 by Matt.Kuhlenschmidt
Eliminate the usage of SWebBrowser to show viewport controls in level viewports. There is an non-trivial startup cost initializing CEF and is not worth paying that cost on editor startup for one tiny control. The button now opens a web page on click.
#jira UE-42461
PR #3314: Drop UE4Editor -> CEF dependency to 2x speedup Linux UE4Editor startup (Contributed by slonopotamus)
Change 3333914 on 2017/03/06 by Matt.Kuhlenschmidt
Remove double middle mouse click to change to perspective view
#jira UE-42444
Change 3333936 on 2017/03/06 by Matt.Kuhlenschmidt
Fixed excessive fname initialization in these files
Change 3334063 on 2017/03/06 by Alexis.Matte
fix build linux
Change 3334166 on 2017/03/06 by Jamie.Dale
Adding Data Table export/import support for TMap and TSet
#jira UE-42415
Change 3334459 on 2017/03/06 by Alexis.Matte
PR #3334: Respect bForceFrontXAxis option when exporting to FBX (Contributed by rajkosto)
#jira UE-42563
Change 3335132 on 2017/03/07 by Jamie.Dale
Fixing typo
Change 3335140 on 2017/03/07 by Jamie.Dale
Fixing CSV import warnings in GameplayEffects test
Change 3335164 on 2017/03/07 by Alexis.Matte
Avoid selecting skeletal mesh section in the level when high light them in persona editor
#jira UE-20151
Change 3335186 on 2017/03/07 by Jamie.Dale
Fixed CSV parser missing empty cells at the end of the string
Change 3335218 on 2017/03/07 by Arciel.Rekman
SDL2: delete unused project/build files.
Change 3335222 on 2017/03/07 by Arciel.Rekman
SDL2: delete more unused project/build files.
Change 3335230 on 2017/03/07 by Matt.Kuhlenschmidt
Additional fixes for blur and blur slot not propagating padding to each other
#jira UE-42553
Change 3335896 on 2017/03/07 by Jamie.Dale
ToolTips and Engine were double gathering the same meta-data
#jira UE-36480
Change 3336009 on 2017/03/07 by Matt.Kuhlenschmidt
Fix details panels becoming unusable if "Show only Modified Properties" is enabled and there are no modified properties
Change 3336247 on 2017/03/07 by Jamie.Dale
Selection height is now the max of the line height and text height to account for negative line scaling
#jira UE-40673
Change 3336253 on 2017/03/07 by Jamie.Dale
Added a setting to control whether we should use the font metrics or the bounding box when laying out a font
#jira UE-41074
Change 3336303 on 2017/03/07 by Arciel.Rekman
Refactor of OS memory allocation functions.
- Bring PageSize/OSAllocationGranularity in line with the established definitions.
- PageSize is a hardware mapping granularity that is also used for PageProtect() and any other functions that involve setting virtual memory properties.
- OSAllocationGranularity is a virtual address allocation granularity that on some platforms may be applied on top of that (notably VirtualAlloc in Windows only returns addresses that are 16 page aligned).
- BinnedPageSize and BinnedAllocationGranularity are the values expected by Binned and Binned2 for size and the alignment of OS allocations.
- Disable the logic in CachedOSPageAllocator that allowed buffers larger than the requested size to be returned.
- This caused wrong allocation size to be passed in BinnedFreeToOS() from Binned2.
- Make Binned2 work on Linux
- Addresses returned from BinnedAllocFromOS() need to be BinnedPageSize (minimum 64KB) aligned for Binned2 to work. This results in the need to artificially align mmap()'d addresses, at some performance cost.
- The same function can be used on other systems with mmap()/munmap() (Mac, Android, iOS)
- Switch Linux to Binned2 by default.
- Add ability to sanity-check OS memory allocations.
- Debug and Development build will store a descriptor to check that values passed to BinnedFreeToOS() are the same (mmap-based allocation only).
Change 3337098 on 2017/03/08 by Michael.Dupuis
#jira UE-42589: Added a guard if the mesh component is not attached, this can happen when moving a component out of the screen
Change 3337183 on 2017/03/08 by Matt.Kuhlenschmidt
Hide the preview toolbar button, it is not being used
Change 3337801 on 2017/03/08 by Michael.Trepka
Fixed some module dependencies to make sure we don't build OpenGLDrv on Mac
Change 3338373 on 2017/03/08 by Joe.Graf
Fixed external plugin cooking and deployment by remapping plugin directories upon cook & deployment
Tested directory structures:
D:\SomePluginDir
D:\UE4\AnotherPluginDir
D:\UE4\Engine\Plugins
D:\UE4\MyProject\Plugins
Change 3338482 on 2017/03/08 by Alexis.Matte
Remove "BlueprinReadOnly" flag on "WITH_EDITORONLY_DATA" class variable
Change 3338679 on 2017/03/08 by Matt.Kuhlenschmidt
Fixed arrow keys not working to navigate between elements in the details panel
Change 3339086 on 2017/03/09 by Dmitriy.Dyomin
Added: Mobile friendly slate settings
Change 3339366 on 2017/03/09 by Nick.Darnell
Build - Attempting to fix build.
#jira UE-42675
Change 3339506 on 2017/03/09 by Jamie.Dale
Fixing Linux Server build error
#jira UE-42675
Change 3340450 on 2017/03/09 by Cody.Albert
Ensure that the hittest grid is valid before trying to find a focusable widget
Change 3340492 on 2017/03/09 by Arciel.Rekman
Fix IOS compile error (UE-42695).
Change 3340565 on 2017/03/09 by Arciel.Rekman
Fix another compile error (UE-42695).
Change 3341527 on 2017/03/10 by Alexis.Matte
Fix crash when dragging a re-import scene and there is new asset created
#jira UE-42766
[CL 3341914 by Nick Darnell in Main branch]
2017-03-10 15:37:02 -05:00
static const bool bUsesChangelists = ISourceControlModule : : Get ( ) . GetProvider ( ) . UsesChangelists ( ) ;
if ( LastSelectedRevisionItem . IsValid ( ) & & bUsesChangelists )
2014-03-14 14:13:41 -04:00
{
2015-04-21 08:43:22 -04:00
// don't group the CL# as Perforce doesn't display it that way
return FText : : AsNumber ( LastSelectedRevisionItem . Pin ( ) - > ChangelistNumber , & FNumberFormattingOptions : : DefaultNoGrouping ( ) ) ;
2014-03-14 14:13:41 -04:00
}
2015-01-07 09:52:40 -05:00
return FText : : GetEmpty ( ) ;
2014-03-14 14:13:41 -04:00
}
/** Get the last selected revision's client spec */
2015-01-07 09:52:40 -05:00
FText GetClientSpec ( ) const
2014-03-14 14:13:41 -04:00
{
if ( LastSelectedRevisionItem . IsValid ( ) )
{
2015-01-07 09:52:40 -05:00
return FText : : FromString ( LastSelectedRevisionItem . Pin ( ) - > ClientSpec ) ;
2014-03-14 14:13:41 -04:00
}
2015-01-07 09:52:40 -05:00
return FText : : GetEmpty ( ) ;
2014-03-14 14:13:41 -04:00
}
/** Get the last selected revision's file size */
2015-01-07 09:52:40 -05:00
FText GetFileSize ( ) const
2014-03-14 14:13:41 -04:00
{
if ( LastSelectedRevisionItem . IsValid ( ) )
{
2015-01-07 09:52:40 -05:00
static const FNumberFormattingOptions FileSizeFormatOptions = FNumberFormattingOptions ( )
. SetMinimumFractionalDigits ( 1 )
. SetMaximumFractionalDigits ( 1 ) ;
return FText : : Format (
NSLOCTEXT ( " SourceControlHistory " , " FileSizeInMBFmt " , " {0} MB " ) ,
FText : : AsNumber ( ( ( float ) LastSelectedRevisionItem . Pin ( ) - > FileSize ) / ( 1024.f * 1024.f ) , & FileSizeFormatOptions )
) ;
2014-03-14 14:13:41 -04:00
}
2015-01-07 09:52:40 -05:00
return FText : : GetEmpty ( ) ;
2014-03-14 14:13:41 -04:00
}
/** Get the last selected revision's description */
2015-01-07 09:52:40 -05:00
FText GetDescription ( ) const
2014-03-14 14:13:41 -04:00
{
if ( LastSelectedRevisionItem . IsValid ( ) )
{
2015-01-07 09:52:40 -05:00
return FText : : FromString ( LastSelectedRevisionItem . Pin ( ) - > Description ) ;
2014-03-14 14:13:41 -04:00
}
2015-01-07 09:52:40 -05:00
return FText : : GetEmpty ( ) ;
2014-03-14 14:13:41 -04:00
}
2014-06-05 12:10:47 -04:00
/** Get the last selected revision's description */
2015-01-07 09:52:40 -05:00
FText GetBranchedFrom ( ) const
2014-06-05 12:10:47 -04:00
{
if ( LastSelectedRevisionItem . IsValid ( ) )
{
2015-01-07 09:52:40 -05:00
return FText : : FromString ( LastSelectedRevisionItem . Pin ( ) - > BranchSource ) ;
2014-06-05 12:10:47 -04:00
}
2015-01-07 09:52:40 -05:00
return FText : : GetEmpty ( ) ;
2014-06-05 12:10:47 -04:00
}
2014-03-14 14:13:41 -04:00
/**
* Generates the content of each row , displaying a the File or Revision data for its corresponding type
*/
TSharedRef < ITableRow > OnGenerateRowForHistoryFileList ( TSharedPtr < FHistoryTreeItem > TreeItemPtr , const TSharedRef < STableViewBase > & OwnerTable )
{
TSharedPtr < SWidget > RowContent ;
if ( TreeItemPtr - > FileListItem . IsValid ( ) )
{
TSharedPtr < FHistoryFileListViewItem > FileListItem = TreeItemPtr - > FileListItem ;
return
SNew ( STableRow < TSharedPtr < FName > > , OwnerTable )
[
SNew ( SVerticalBox )
+ SVerticalBox : : Slot ( )
. AutoHeight ( )
. Padding ( 5 )
[
SNew ( STextBlock )
. Font ( FEditorStyle : : GetFontStyle ( TEXT ( " BoldFont " ) ) )
2015-01-07 09:52:40 -05:00
. Text ( FText : : FromString ( FileListItem - > FileName ) )
2014-03-14 14:13:41 -04:00
]
]
. OnDragDetected ( this , & SSourceControlHistoryWidget : : OnRowDragDetected )
. OnDragEnter ( this , & SSourceControlHistoryWidget : : OnRowDragEnter , TreeItemPtr )
. OnDragLeave ( this , & SSourceControlHistoryWidget : : OnRowDragLeave )
. OnDrop ( this , & SSourceControlHistoryWidget : : OnRowDrop , TreeItemPtr ) ;
}
else if ( TreeItemPtr - > RevisionListItem . IsValid ( ) )
{
TSharedPtr < FHistoryRevisionListViewItem > RevisionListItem = TreeItemPtr - > RevisionListItem ;
return
SNew ( SHistoryRevisionListRowContent , OwnerTable )
. RevisionListItem ( RevisionListItem )
. OnDragDetected ( this , & SSourceControlHistoryWidget : : OnRowDragDetected )
. OnDragEnter ( this , & SSourceControlHistoryWidget : : OnRowDragEnter , TreeItemPtr )
. OnDragLeave ( this , & SSourceControlHistoryWidget : : OnRowDragLeave )
2014-06-05 12:10:47 -04:00
. OnDrop ( this , & SSourceControlHistoryWidget : : OnRowDrop , TreeItemPtr )
. HasChildren ( TreeItemPtr - > Children . Num ( ) > 0 ) ;
2014-03-14 14:13:41 -04:00
}
//we should never get here...
return
SNew ( STableRow < TSharedPtr < FName > > , OwnerTable )
[
SNew ( STextBlock )
. Text ( NSLOCTEXT ( " SourceControlHistory " , " ErrorMessage " , " ---ERROR--- " ) )
] ;
}
/**
* Fill out the tree structure with the SSC data
*/
void AddHistoryInfo ( const TArray < FSourceControlStateRef > & InStates )
{
// Construct a new observable collection to serve as the items source for the main list view. It will contain each history file item.
for ( TArray < FSourceControlStateRef > : : TConstIterator Iter ( InStates ) ; Iter ; Iter + + )
{
FSourceControlStateRef SourceControlState = * Iter ;
TSharedPtr < FHistoryTreeItem > FileItem = MakeShareable ( new FHistoryTreeItem ( ) ) ;
2014-06-05 12:10:47 -04:00
FileItem - > FileListItem = MakeShareable ( new FHistoryFileListViewItem ( SourceControlState - > GetFilename ( ) ) ) ;
2014-03-14 14:13:41 -04:00
// Add each file revision
for ( int HistoryIndex = 0 ; HistoryIndex < SourceControlState - > GetHistorySize ( ) ; HistoryIndex + + )
{
TSharedPtr < ISourceControlRevision , ESPMode : : ThreadSafe > Revision = SourceControlState - > GetHistoryItem ( HistoryIndex ) ;
check ( Revision . IsValid ( ) ) ;
TSharedPtr < FHistoryTreeItem > RevisionItem = MakeShareable ( new FHistoryTreeItem ( ) ) ;
RevisionItem - > RevisionListItem = MakeShareable ( new FHistoryRevisionListViewItem ( Revision . ToSharedRef ( ) ) ) ;
FileItem - > Children . Add ( RevisionItem ) ;
RevisionItem - > Parent = FileItem ;
2014-06-05 12:10:47 -04:00
// add branch items if we have one
if ( Revision - > GetBranchSource ( ) . IsValid ( ) )
{
TSharedPtr < FHistoryTreeItem > BranchFileItem = MakeShareable ( new FHistoryTreeItem ( ) ) ;
const FString BranchRevisionName = FString : : Printf ( TEXT ( " %s #%d " ) , * Revision - > GetBranchSource ( ) - > GetFilename ( ) , Revision - > GetBranchSource ( ) - > GetRevisionNumber ( ) ) ;
BranchFileItem - > FileListItem = MakeShareable ( new FHistoryFileListViewItem ( BranchRevisionName ) ) ;
RevisionItem - > Children . Add ( BranchFileItem ) ;
BranchFileItem - > Parent = RevisionItem ;
}
2014-03-14 14:13:41 -04:00
}
HistoryCollection . Add ( FileItem ) ;
}
}
/**
* Callback returns the revision history ( Children ) nodes for the file ( InItem ) node
*/
void OnGetChildrenForHistoryFileList ( TSharedPtr < FHistoryTreeItem > InItem , TArray < TSharedPtr < FHistoryTreeItem > > & OutChildren )
{
OutChildren = InItem - > Children ;
}
/**
* Called whenever the IsSelected property on a MHistoryRevisionListViewItem changes . Used to specify the last selected revision item .
*
* @ param Owner Object which triggered the event
* @ param Args Event arguments for the property change
*/
void OnRevisionPropertyChanged ( TSharedPtr < FHistoryTreeItem > Item , ESelectInfo : : Type SelectInfo )
{
LastSelectedRevisionItem . Reset ( ) ;
if ( Item . IsValid ( ) )
{
if ( Item - > RevisionListItem . IsValid ( ) )
{
LastSelectedRevisionItem = Item - > RevisionListItem ;
}
else if ( Item - > Children . Num ( ) > 0 & & Item - > Children [ 0 ] - > RevisionListItem . IsValid ( ) )
{
LastSelectedRevisionItem = Item - > Children [ 0 ] - > RevisionListItem ;
}
}
AdditionalInfoItemsControl - > SetContent ( GetAdditionalInfoItemsControlContent ( ) ) ;
}
/** Called to create a context menu when right-clicking on a history item */
TSharedPtr < SWidget > OnCreateContextMenu ( )
{
FMenuBuilder MenuBuilder ( true , NULL ) ;
MenuBuilder . AddMenuEntry (
NSLOCTEXT ( " SourceControl.HistoryWindow.Menu " , " DiffAgainstPrev " , " Diff Against Previous Revision " ) ,
NSLOCTEXT ( " SourceControl.HistoryWindow.Menu " , " DiffAgainstPrevTooltip " , " See changes between this revision and the previous one. " ) ,
FSlateIcon ( ) ,
FUIAction (
FExecuteAction : : CreateSP ( this , & SSourceControlHistoryWidget : : OnDiffAgainstPreviousRev ) ,
FCanExecuteAction : : CreateSP ( this , & SSourceControlHistoryWidget : : CanDiffAgainstPreviousRev )
)
) ;
if ( CanDiffSelected ( ) )
{
MenuBuilder . AddMenuEntry (
NSLOCTEXT ( " SourceControl.HistoryWindow.Menu " , " DiffSelected " , " Diff Selected " ) ,
NSLOCTEXT ( " SourceControl.HistoryWindow.Menu " , " DiffSelectedTooltip " , " Diff the two assets that you have selected. " ) ,
FSlateIcon ( ) ,
FUIAction (
FExecuteAction : : CreateSP ( this , & SSourceControlHistoryWidget : : OnDiffSelected )
)
) ;
}
return MenuBuilder . MakeWidget ( ) ;
}
/** See if we should enabled the 'diff against previous' option */
bool CanDiffAgainstPreviousRev ( ) const
{
// Only allow option if we selected one item and it was a revision, not a file entry
TArray < TSharedPtr < FHistoryTreeItem > > SelectedRevs = MainHistoryListView - > GetSelectedItems ( ) ;
return ( SelectedRevs . Num ( ) = = 1 & & SelectedRevs [ 0 ] . IsValid ( ) ) ;
}
/** Try and perfom a diff between the selected revision and the previous one */
void OnDiffAgainstPreviousRev ( )
{
TArray < TSharedPtr < FHistoryTreeItem > > SelectedRevs = MainHistoryListView - > GetSelectedItems ( ) ;
if ( SelectedRevs . Num ( ) > 0 & & SelectedRevs [ 0 ] . IsValid ( ) )
{
FAssetToolsModule & AssetToolsModule = FModuleManager : : LoadModuleChecked < FAssetToolsModule > ( TEXT ( " AssetTools " ) ) ;
TSharedPtr < FHistoryTreeItem > SelectedItem = SelectedRevs [ 0 ] ;
UObject * SelectedAsset = GetAssetRevisionObject ( SelectedItem ) ;
if ( SelectedItem - > RevisionListItem . IsValid ( ) )
{
TSharedPtr < FHistoryTreeItem > FileItem = SelectedItem - > Parent . Pin ( ) ;
check ( FileItem . IsValid ( ) ) ;
// Now we need to find previous revision
TSharedPtr < FHistoryTreeItem > PreRevisionItem ;
// First, find index of selected revision in its parent file item
// NB. 0 is newest, increasing index means older
int32 RevIndex = FileItem - > Children . Find ( SelectedItem ) ;
check ( RevIndex ! = INDEX_NONE ) ;
if ( RevIndex = = FileItem - > Children . Num ( ) - 1 ) // If oldest revision of this file
{
// .. see if we have an older file
int32 FileIndex = HistoryCollection . Find ( FileItem ) ;
check ( FileIndex ! = INDEX_NONE ) ;
// Do nothing if we selected the newest revision of the newest file...
if ( FileIndex < HistoryCollection . Num ( ) - 1 )
{
// Previous revision is a different file, so get the newest revision of the older file
TSharedPtr < FHistoryTreeItem > PrevFileItem = HistoryCollection [ FileIndex + 1 ] ;
check ( PrevFileItem . IsValid ( ) ) ;
if ( PrevFileItem - > Children . Num ( ) > 0 )
{
PreRevisionItem = PrevFileItem - > Children [ 0 ] ;
}
}
}
else
{
// Not the oldest revision of this file, grab the older entry and get revision number
PreRevisionItem = FileItem - > Children [ RevIndex + 1 ] ;
}
UObject * PreviousAsset = GetAssetRevisionObject ( PreRevisionItem ) ;
if ( ( SelectedAsset ! = NULL ) & & ( PreviousAsset ! = NULL ) )
{
FRevisionInfo OldRevisionInfo ;
GetRevisionInfo ( PreRevisionItem , OldRevisionInfo ) ;
FRevisionInfo NewRevisionInfo ;
GetRevisionInfo ( SelectedItem , NewRevisionInfo ) ;
AssetToolsModule . Get ( ) . DiffAssets ( PreviousAsset , SelectedAsset , OldRevisionInfo , NewRevisionInfo ) ;
}
else
{
FMessageDialog : : Open ( EAppMsgType : : Ok , NSLOCTEXT ( " SourceControl.HistoryWindow " , " UnableToLoadAssets " , " Unable to load assets to diff. Content may no longer be supported? " ) ) ;
}
}
else if ( SelectedAsset ! = NULL )
{
// this should be a file list-item (representing the current working version)
check ( SelectedItem - > FileListItem . IsValid ( ) ) ;
FString const AssetName = SelectedAsset - > GetName ( ) ;
FString const PackageName = FPackageName : : FilenameToLongPackageName ( SelectedItem - > FileListItem - > FileName ) ;
AssetToolsModule . Get ( ) . DiffAgainstDepot ( SelectedAsset , PackageName , AssetName ) ;
}
}
}
/**
Copying //UE4/Dev-Editor to //UE4/Dev-Main (Source: //UE4/Dev-Editor @ 3082391)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3051464 on 2016/07/15 by Nick.Darnell
Regression Testing - Several upgrades to the functional testing system, better tracking of failure cases, some source line failure detection, trying to make it easier to run a specific test on a map. Some UI improvements, easier access to the automation system. Lots more refactoring to come, lots of improvements are still needed in transmitting screenshots and just generally building a automation report we could dump from the build machines.
Change 3051465 on 2016/07/15 by Nick.Darnell
Adding the "Engine Test" project our one stop shope for running automation tests in the engine to try and reduce regressions.
Change 3051847 on 2016/07/15 by Matt.Kuhlenschmidt
Fixed material editor viewport messages being blocked by viewport toolbar
Change 3052025 on 2016/07/15 by Nick.Darnell
Moving the placement mode hooks out of functional testing module, moving them into the editor automation module.
Change 3053508 on 2016/07/18 by Stephan.Jiang
Copy,Cut,Paste tracks, not for mastertracks yet.
#UE-31808
Change 3054723 on 2016/07/18 by Stephan.Jiang
Small fixes for typo & comments
Change 3055996 on 2016/07/19 by Trung.Le
PIE: No longer auto resume game in PIE on focus received
Change 3056106 on 2016/07/19 by Trung.Le
Back out changelist 3055996. Build break.
Change 3056108 on 2016/07/19 by Stephan.Jiang
Updating "SoundConcurrency" asseticon
Change 3056389 on 2016/07/19 by Trung.Le
PIE: No longer auto resume game in PIE on focus received
#jira UE-33339
Change 3056396 on 2016/07/19 by Matt.Kuhlenschmidt
More perf selection improvements:
- Static meshes now go through the static draw path when rendered for selection outline instead of just rendering using the dynamic path
Change 3056758 on 2016/07/19 by Stephan.Jiang
Update SelectedWidgets in WidgetblueprintEditor to match the selected tracks in sequencer.
Change 3057519 on 2016/07/20 by Matt.Kuhlenschmidt
Another fix for selecting lots of objects taking forever. This one is due to repeated Modify calls if there are groups in the selection. Each group actor selected iterates through each object selected during USelection::Modify!
Change 3057635 on 2016/07/20 by Stephan.Jiang
Updating visual logger icon UI
Change 3057645 on 2016/07/20 by Richard.TalbotWatkin
Fixed single player PIE so the window position is correctly fetched and saved, even when running a dedicated server. This does not interfere with stored positions for multiple PIE, which uses ULevelEditorPlaySettings::MultipleInstancePositions.
#jira UE-33416 - New Editor PIE window does not center to screen when running with a dedicated server
Change 3057868 on 2016/07/20 by Richard.TalbotWatkin
Spline component improvements, both tools and runtime:
- SplineComponentVisualizer now works within the Blueprint editor. This works via a generic extension added to the base ComponentVisualizer class which correctly propagates modified properties from the preview actor to the archetype, and then on to any instances whose properties are at the default value.
- The above feature required a breaking change to USplineComponent - namely, the three FInterpCurve properties have been collected together into a struct and added as a single property. This is so that changes to the length of one of the FInterpCurves marks all three as dirty and needing rebuilding.
- Added a custom version for SplineComponent and provded serialization fixes.
- Added a details customization to SplineComponent to hide the raw FInterpCurve properties.
- Added a custom detail builder category which polls the SplineComponentVisualizer each tick and provides numerical editing for spline points which are selected in the visualizer.
- Relaxed the limitation that SplineComponent keys need to have an increment of 1.0. Now any SplineComponent key can be set. The details customization enforces that the sequence remains strictly ascending.
- Allowed an explicit loop point to be specified for closed splines.
- Allowed discontinuous splines by no longer forcing the ArriveTangent and LeaveTangent to be equal.
- Added some new Blueprintable methods for building splines with an FSplinePoint struct, which allows all of a spline point's properties to be specified, and added to the FInterpCurves sorted by the input key.
- Fixed the logic which determines whether the UCS has modified the spline curves.
- Added UActorComponent::RemoveUCSModifiedProperties, which allows a component to remove any properties from the cached list which it doesn't want to be considered as 'modified'. This is used to distinguish the case of properties preserved by the SplineInstanceDataCache from those genuinely modified by the UCS.
- Fixed "Apply Instance Changes to Blueprint" so that edited spline data can be applied to the archetype.
- Fixed some issues with the spline component visualizer to make it generate appropriate up vectors if scale and rotation are enabled.
#jira UETOOL-766 - Spline tool improvements
#jira UE-33049 - Transform widget visible in blueprint viewport when editing spline points in editor viewport
#jira UE-9062 - Spline editing: It would be nice to be able to type in a specific value for a point
#jira UE-7476 - Add ability to edit SplineComponent in BP editor (not just instance in level)
#jira UE-13082 - Users would like a snapping feature for splines
#jira UE-13568 - Additional Spline Component Functionality
#jira UE-17822 - It would be useful to be able to update a bp spline layout from the editor viewport.
Change 3057895 on 2016/07/20 by Richard.TalbotWatkin
Mesh paint bugfixes and improvements.
Changes to RerunConstructionScript so that OnObjectsReplaced is called correctly on all components, whether they have been created by the SCS or the UCS. Previously, components created by the UCS were not being handled, and components created by the SCS were not always being matched. Now a serialized index is maintained for UCS-created objects, which is matched after the construction scripts have been executed.
This will fix issues with the mesh paint tool, and any other editor tool which hooks into the OnObjectsReplaced callback in order to update its internal cache of component pointers, for example, the component visualizer render list.
#jira UE-33010 - Crash changing mesh paint material in blueprint, then changing to a different mode tab
#jira UE-32279 - Editor crashes when reselecting a mesh in paint mode
#jira UE-31763 - [CrashReport] UE4Editor_MeshPaint!FMulticastDelegateBase<FWeakObjectPtr>::RemoveAll() [multicastdelegatebase.h:75]
#jira UE-30661 - Vertex Painting changes collision complexity if the asset is saved while vertex painting
Change 3057966 on 2016/07/20 by Richard.TalbotWatkin
Renamed IsEditingArchetype to IsVisualizingArchetype in the ComponentVisualizer API.
#jira UE-33049 - Transform widget visible in blueprint viewport when editing spline points in editor viewport
Change 3058009 on 2016/07/20 by Richard.TalbotWatkin
Fixed build failure due to changes to FComponentVisualizer API, as of CL 3057868.
Change 3058047 on 2016/07/20 by Stephan.Jiang
Fixing error on previous CL: 3056758
(extra qualification)
Change 3058266 on 2016/07/20 by Nick.Darnell
Automation - Work continues on automation integrating some ideas form a licensee. Continuing to work on the usability aspects, I've made it possible for tests to provide custom open commands, as well as have complex subclasses that do different things. The functional tests now have a custom open command they emit that makes it so clicking on a test opens not the C++ location where the functional test macro lives, but instead the map, AND focuses the functional test actor.
Change 3058282 on 2016/07/20 by Matt.Kuhlenschmidt
PR #2611: Fix spurious component diff when properties are in subcategories (Contributed by CA-ADuran)
Change 3059214 on 2016/07/21 by Richard.TalbotWatkin
Further fixes to visualizers following Component Visualizer API change.
Change 3059260 on 2016/07/21 by Richard.TalbotWatkin
Template specialization not allowed in class scope, but Visual Studio allows it anyway. Fixed for clang.
Change 3059543 on 2016/07/21 by Stephan.Jiang
Changeing level details icon
Change 3059732 on 2016/07/21 by Stephan.Jiang
Directional Light icon update
Change 3060095 on 2016/07/21 by Stephan.Jiang
Directional Light editor icon asset changed
Change 3060129 on 2016/07/21 by Nick.Darnell
Automation - The session browser now attempts to select the app instance if no other thing is selected when it refreshes. This is to try and make it easier to use when you first bring it up and nothing is selected when most of the time you're going to use it on your own instance.
Change 3061735 on 2016/07/22 by Stephan.Jiang
Improve UMG replace with in HierarchyView function
#UE-33582
Change 3062059 on 2016/07/22 by Stephan.Jiang
Strip off "b" in propertyname in replace with function for tracks.
Change 3062146 on 2016/07/22 by Stephan.Jiang
checkin with CL: 3061735
Change 3062182 on 2016/07/22 by Stephan.Jiang
Change both animation bindings' widget name when renameing the widget so the slot content is still valid
Change 3062257 on 2016/07/22 by Stephan.Jiang
comments
Change 3062381 on 2016/07/22 by Nick.Darnell
Build - Adding #undef LOCTEXT_NAMESPACE to try and fix the build.
Change 3062924 on 2016/07/25 by Chris.Wood
Fix a crash in CrashReportClient that happens when the CrashReportReceiver is not responding to pings and there are no PendingReportDirectories.
This is a change in the UE4 stream depot based on a fix in the Fortnite stream depot -> JIRA FORT-27570
Change 3063017 on 2016/07/25 by Matt.Kuhlenschmidt
PR #2618: DebuggerCommand not recording PlayLocationString (Contributed by ungalyant)
Change 3063021 on 2016/07/25 by Matt.Kuhlenschmidt
PR #2619: added a search box to ModuleUI (Contributed by straymist)
Change 3063084 on 2016/07/25 by Matt.Kuhlenschmidt
Fix "YesToAll" when deleting referenced actors overriding the "YesToAll" state for other referenced messages.
https://jira.ol.epicgames.net/browse/UE-33651
#jira UE-33651
Change 3063091 on 2016/07/25 by Alex.Delesky
#jira UE-32949 - Truncating the hue inside the theme color block tooltip to only display whole numbers, to match how the color picker displays the hue value inside the hue scrubber.
Change 3063388 on 2016/07/25 by Matt.Kuhlenschmidt
Selection Perf:
- Fix large FName creation time when selecting thousands of objects
Change 3063568 on 2016/07/25 by Matt.Kuhlenschmidt
Selection Perf:
- Modified how USelection stores classes. Classes are now in a TSet and can be accessed efficiently using IsClassSelected. The old unused way of checking if a selection has a class by iterating through them is deprecated
- USelection no longer directly checks if an item is already selected with a costly n^2 search. The check is done by using the already existing UObject selected annotation
- Object property nodes no longer perform an n^2 check for object uniqueness when objects are added to details panels. This is now left up to the caller to avoid
- Eliminated useless work on FObjectPropertyNode::GetReadAddressUncached. If a read address list is not passed in we'll not attempt to the work to populate it
- Removed expensive checking for brush actors when any actor is selected
Change 3063749 on 2016/07/25 by Stephan.Jiang
Disallow naming the widgetanimation to the same name with a override function in uuserwidget, because it will trigger a breakpoint in Rename()
#jira UE-33711
Change 3064585 on 2016/07/26 by Matt.Kuhlenschmidt
Merging //UE4/Dev-Main to Dev-Editor (//UE4/Dev-Editor)
Change 3064612 on 2016/07/26 by Alex.Delesky
#jira UE-33712 - Deleting many assets at once will now batch SourceControl commands rather than executing one for each asset.
Change 3064647 on 2016/07/26 by Alexis.Matte
#jira UE-33274 dont hash the same file over and over when importing multiple asset from one fbx file.
Change 3064739 on 2016/07/26 by Matt.Kuhlenschmidt
Fixed typo
Change 3064795 on 2016/07/26 by Jamie.Dale
Fixed typo in FLocalizationModule::GetLocalizationTargetByName
#jira UE-32961
Change 3066461 on 2016/07/27 by Jamie.Dale
Enabled stable localization keys
Change 3066463 on 2016/07/27 by Jamie.Dale
Set "Build Engine Localization" to upload all cultures to ensure we don't lose translation due to the archive keying changes
Change 3066467 on 2016/07/27 by Jamie.Dale
Updated internationalization archives to store translations per-identity
This allows translators to translate each instance of a piece of text based upon their context, rather than requiring a content producer to go back and give the entry a unique namespace. It also allows us to optionally compile out-of-date translations, as they are now mapped to their source identity (namespace + key) rather than their source text.
Major changes:
- Added FLocTextHelper. This acts as a high-level API for uncompiled localized text, and replaces all the old ad-hoc loading/saving of manifests and archives, ensuring that everything is consistently using source control, and that older archives can be upgraded correctly to the new format. It also takes care of some of the quirks of our archives, such as native translations. All major localization commandlets have been updated to use FLocTextHelper.
- Moved FTextLocalizationResourceGenerator from Core to Internationalization. This also allows IJsonInternationalizationManifestSerializer and IJsonInternationalizationArchiveSerializer to be removed, and for FJsonInternationalizationManifestSerializer and FJsonInternationalizationArchiveSerializer to have all their functions become static.
- FTextLocalizationResourceGenerator being moved from Core meant that FTextLocalizationManager::LoadFromManifestAndArchives was also removed. This functionality is now handled by FTextLocalizationResourceGenerator::GenerateAndUpdateLiveEntriesFromConfig.
- The RepairLocalizationData commandlet has been removed. This existed to fix a change that pre-dated 4.0 so no such data should exist in the wild, and the commandlet couldn't be updated to work with the new API (we handle format upgrades in-place now).
- Removed FInternationalizationArchive::FindEntryBySource as it is no-longer safe to use. All existing code has been updated to use FInternationalizationArchive::FindEntryByKey instead.
Workflow changes:
- Archive conditioning now only adds new entries if they don't exist in the archive. This allows us to persist any existing translations, even if they're for old source text (caveat: native archives still update existing entries if the source is changed).
- PO export now sets the msgctx for each entry to be "namespace,key", rather than only doing it when the entry had key meta-data.
- PO import will now update both the source and translation stored in the archive to match the current PO data. This is the primary method by which stale source->translation pairs are updated.
- LocRes compilation may now optionally compile stale translations. There's an option controlling this (defaulted to off) that can be changed via the Localization Dashboard (or added to an existing config file).
Format changes:
- The archive version was bumped to 2.
- Archive entries now use the "Key" entry to store the key from the source text. Previously this "Key" entry was used to store the key meta-data, but that now exists within a "MetaData" sub-object. Loading handles this correctly based upon the archive version.
#jira UETOOL-897
#jira UETOOL-898
#jira UE-29481
Change 3066487 on 2016/07/27 by Matt.Kuhlenschmidt
Attempt to fix linux compilation
Change 3066504 on 2016/07/27 by Matt.Kuhlenschmidt
Fixed data tables with structs crashing due to recent editor selection optimizations
Change 3066886 on 2016/07/27 by Jamie.Dale
Added required data to accurately detect TZ (needed for DST)
#jira UE-28511
Change 3067122 on 2016/07/27 by Jamie.Dale
Added AsTime, AsDateTime, and AsDate overrides to BP to let you format a UTC time in a given timezone (default is the local timezone).
Previously you could only format times using the "invariant" timezone, which assumed that the time was already specified in the correct timezone for display.
Change 3067227 on 2016/07/27 by Jamie.Dale
Added a test to verify that the ICU timezone is set correctly to produce local time (including DST)
Change 3067313 on 2016/07/27 by Richard.TalbotWatkin
Fixed SplineComponent constructor so that old assets (prior to the property changes) load correctly if they had properties at default values.
#jira UE-33669 - Crash in Dev-Editor
Change 3067736 on 2016/07/27 by Stephan.Jiang
Border changes for experimental classes warning
Change 3067769 on 2016/07/27 by Stephan.Jiang
HERE BE DRAGONS
for experimental class warning
#UE-33780
Change 3068192 on 2016/07/28 by Alexis.Matte
#jira UE-33586 make sure we remove any false warning when running fbx automation test.
Change 3068264 on 2016/07/28 by Jamie.Dale
Removed some code that was no longer needed and could cause a crash
#jira UE-33342
Change 3068293 on 2016/07/28 by Alex.Delesky
#jira UE-33620 - Comments on constant and parameter nodes in the Material Editor will now persist when converting them.
Change 3068481 on 2016/07/28 by Stephan.Jiang
Adding Options to show/hide soft & hard references & dependencies in References Viewer
#jira UE-33746
Change 3068585 on 2016/07/28 by Richard.TalbotWatkin
Fix to Spline Mesh collision building so that geometry does not default to being auto-inflated in PhysX.
Change 3068701 on 2016/07/28 by Matt.Kuhlenschmidt
Fixed some issues with the selected classes not updating when objects are deselected
Change 3069335 on 2016/07/28 by Jamie.Dale
Fixed unintended error when trying to load a manifest/archive that didn't exist
Fixed a warning when trying to load a PO file that didn't exist
Change 3069408 on 2016/07/28 by Alex.Delesky
#jira UE-33429 - The editor should no longer hit an ensure if the user attempts to drop a tab into a tab well before the tab well has a chance to acknowledge its been dragged into a tab well.
Change 3069878 on 2016/07/29 by Jamie.Dale
Fixed include casing
#jira UE-33910
Change 3071807 on 2016/08/01 by Matt.Kuhlenschmidt
PR #2654: Fix the spell'ing of "diff'ing" and "diff'd". (Contributed by geary)
Change 3071813 on 2016/08/01 by Jamie.Dale
Fixed include casing
#jira UE-33936
Change 3072043 on 2016/08/01 by Jamie.Dale
Fixed FText formatting of pre-Gregorian dates
We now convert to an ICU UDate via an ICU GregorianCalendar, as UE4 and ICU have a different time scale for pre-Gregorian dates.
#jira UE-14504
Change 3072066 on 2016/08/01 by Jamie.Dale
PR #2590: FEATURE: Collapse/expand folders in the outliner (Contributed by projectgheist)
Change 3072149 on 2016/08/01 by Jamie.Dale
We no longer use the editor culture when running with -game
Change 3072169 on 2016/08/01 by Richard.TalbotWatkin
A couple of changes to the BSP code:
* Fixed longstanding issue where sometimes BSP geometry is not rebuilt correctly after editing it. This was due to poly normals not being recalculated after translating vertices in Geometry Mode.
* Fixed corruption to FPoly::iLink as it is overloaded to have two meanings: when building BSP, it represents the surface index of the next coplanar surface (and adding a new BSP node uses this to determine whether a new surface needs to be added or not). In other operations it represents an FPoly index, in general this is used more in editor geometry operations. This fixes various crashes which arose from rebuilding BSP resulting in invalid FPoly indices.
#jira UE-12157 - BSP brushes break when non-standard subtractive bsp brushes are used
#jira UE-32087 - Crash occurs when creating Static Mesh from Trigger Volume
Change 3072221 on 2016/08/01 by Jamie.Dale
Fixed "Launch On" not providing the correct cultures to StartCookByTheBookInEditor
#jira UE-33001
Change 3073389 on 2016/08/02 by Matt.Kuhlenschmidt
Added ability to vsync the editor. Disabled by default. Set r.VSyncEditor to 1 to enable it.
Reimplemented this change from the siggraph demo stream
Change 3073396 on 2016/08/02 by Matt.Kuhlenschmidt
Removed unused code as suggested by a pull request
Change 3073750 on 2016/08/02 by Richard.TalbotWatkin
Fixed formatting (broken in CL 3057895) in anticipation of merge from Main.
Change 3073789 on 2016/08/02 by Jamie.Dale
Added a way to mark text in text properties as culture invariant
This allows you to flag properties containing text that doesn't need to be gathered.
#jira UE-33713
Change 3073825 on 2016/08/02 by Stephan.Jiang
Material Editor: Highligh all Nodes connect to an input.
#jira UE-32502
Change 3073947 on 2016/08/02 by Stephan.Jiang
UMG Project settings to show/hide different classes and categories in Palette view.
--under Project Settings ->Editor->UMG Editor
Change 3074012 on 2016/08/02 by Stephan.Jiang
Minor changes and comments for CL: 3073947
Change 3074029 on 2016/08/02 by Jamie.Dale
Deleting folders in the Content Browser now removes the folder from disk
#jira UE-24303
Change 3074054 on 2016/08/02 by Matt.Kuhlenschmidt
Added missing stats to track pooled vertex and index buffer cpu memory
A new slate allocator was added to track memory usage for this case.
Change 3074056 on 2016/08/02 by Matt.Kuhlenschmidt
Renamed a few slate stats for consistency
Change 3074810 on 2016/08/02 by Matt.Kuhlenschmidt
Moved geometry cache asset type to the animation category. It is not a basic asset type
Change 3074826 on 2016/08/02 by Matt.Kuhlenschmidt
Fix a few padding and sizing issues
Change 3075322 on 2016/08/03 by Matt.Kuhlenschmidt
Settings UI improvements
* Added the ability to search through all settings at once
* Settings files which are not checked out are no longer grayed out. The editor now attempts to check out the file automatically if connected to source control and if that fails it marks the settings file writiable so it can save the setting properly
-------
* This change adds a refactor to the details panel to support multiple top level objects existing in the details panel at once instead of combining all passed in objects to a single common base class. This is disabled by default but can be turned on setting bAllowMultipleTopLevelObjects to true in FDetailsViewArgs when creating a details panel.
* Each top level object in a details panel will get their own customization instance. This made it necessary to deprecate a IDetailsView::GetBaseClass since there is no longer guaranteed to be one base class.
*Details panels can have their own customization for each "root object header" in order to customize the look of having multiple top level objects in the details panel.
Change 3075369 on 2016/08/03 by Matt.Kuhlenschmidt
Removed FBX scene as a top level option in asset filter menu in the content browser.
Change 3075556 on 2016/08/03 by Matt.Kuhlenschmidt
Mac warning fix
Change 3075603 on 2016/08/03 by Nick.Darnell
Adding two new plugins to engine, one for editor and one for runtime based testing. Currently the only consumer of these plugins is going to be the EngineTest project.
Change 3075605 on 2016/08/03 by Nick.Darnell
Functional Testing - Continued work on cleanup, reorganization, trying to improve the workflow for using the session browser.
Change 3076084 on 2016/08/03 by Jamie.Dale
Added basic support for localizing plugins
You can now localize plugins! There's no localization dashboard integration for this so it has to be done manually.
You need to define the localization targets your plugin uses in its .uplugin file, eg)
"LocalizationTargets": [
{
"Name": "Paper2D",
"LoadingPolicy": "Always"
}
]
"Name" should match a localization config under the Config/Localization folder for your plugin. These configs are set-up the same as any other localization config.
"LoadingPolicy" may be one of Never, Always, Editor, Game, PropertyNames, or ToolTips. This allows you to control under what conditions your localizations should be loaded (eg, if your plugin has both game and editor data, you can separate the editor data off into its own localization target that's only loaded by the editor).
UAT has been updated to support gathering from plugins. You can use the "IncludePlugins" flag to have it gather all plugins, or you can specify a whitelist of plugins to gather as an argument to "IncludePlugins", or alternatively, may blacklist certain plugins via "ExcludePlugins". It can now also support out-of-source gathering via the "UEProjectRoot" argument (previously it assumed that everything would be under the UE4 install/checkout directory).
UAT has been updated to support staging plugin LocRes files. It will stage any plugin targets that are enabled for a game/client build, and are also from a plugin that's enabled for your project.
#jira UE-4217
Change 3076123 on 2016/08/03 by Stephan.Jiang
Extend "Select all input nodes" function to general blueprint editor
Change 3077103 on 2016/08/04 by Jamie.Dale
Added support for underlined text rendering (including with drop-shadows)
FTextBlockStyle can now specify a brush to use to draw an underline for text (a suitable default would be "DefaultTextUnderline" from FCoreStyle). When a brush is specified here, we inject FSlateTextUnderlineLineHighlighter highlights into the text layout to draw the underline under the relevant pieces of text, using the correct color, position, and thickness.
FSlateFontCache::GetUnderlineMetrics and FSlateFontRenderer::GetUnderlineMetrics have been added to handle getting the underline metrics (which are slightly different to the baseline).
This change also adds FTextLayout::RemoveRunRenderer and FTextLayout::RemoveLineHighlight to fix some bad assumptions that FSlateEditableTextLayout and FTextBlockLayout were making about ownership of run renderers and line highlighters that could cause them to remove instances they didn't own (such as the new underline highlighter) when updating things like the cursor position or highlight.
Change 3077842 on 2016/08/04 by Jamie.Dale
Fixed fallout from API changes
Change 3077999 on 2016/08/04 by Jamie.Dale
Ensured that BULKDATA_SingleUse is only set by UFontBulkData::Serialize when loading
This prevents it being incorrectly set by other operations, such as counting memory used by font data.
#jira UE-34252
Change 3078000 on 2016/08/04 by Trung.Le
Categories VREditor-specific UMG widget assets as "VR Editor"
#jira UE-34134
Change 3078056 on 2016/08/04 by Nick.Darnell
Build - Fixing a mac compiler warning, reodering constructor initializers.
Change 3078813 on 2016/08/05 by Nick.Darnell
Reorganizing editor tests, establishing plugins in the EditorTest project that will house the tests.
Change 3078818 on 2016/08/05 by Nick.Darnell
Additional rename and cleanup associated with test moving.
Change 3078819 on 2016/08/05 by Nick.Darnell
Removing the Oculus performance automation test, not running, and was unclaimed.
Change 3078842 on 2016/08/05 by Nick.Darnell
Continued reorganizing tests.
Change 3078897 on 2016/08/05 by Nick.Darnell
Additional changes to get some moved tests compiling
Change 3079157 on 2016/08/05 by Nick.Darnell
Making it possible to browse provider names thorugh the source control module interface.
Change 3079176 on 2016/08/05 by Stephan.Jiang
Add shortcut Ctrl+Shift+Space to rotate through different viewport options
#jira UE-34140
Change 3079208 on 2016/08/05 by Stephan.Jiang
Fix new animation name check in UMG
Change 3079278 on 2016/08/05 by Nick.Darnell
Fixing the build
Change 3080555 on 2016/08/08 by Matt.Kuhlenschmidt
Merging //UE4/Dev-Main to Dev-Editor (//UE4/Dev-Editor)
Change 3081155 on 2016/08/08 by Nick.Darnell
Fixing some issues with the editor tests / runtime tests under certain build configs.
Change 3081243 on 2016/08/08 by Stephan.Jiang
Add gesture in LevelViewport to switch between Top/Bottom...etc.
Change 3082226 on 2016/08/09 by Matt.Kuhlenschmidt
Work around animations not playing in paragon due to bsp rebuilds (UE-34391)
Change 3082254 on 2016/08/09 by Stephan.Jiang
DragTool_ViewportChange init changes
[CL 3082411 by Matt Kuhlenschmidt in Main branch]
2016-08-09 11:28:56 -04:00
* Checks to see if the selected history - tree items can be diffed against each other .
2014-03-14 14:13:41 -04:00
*
Copying //UE4/Dev-Editor to //UE4/Dev-Main (Source: //UE4/Dev-Editor @ 3082391)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3051464 on 2016/07/15 by Nick.Darnell
Regression Testing - Several upgrades to the functional testing system, better tracking of failure cases, some source line failure detection, trying to make it easier to run a specific test on a map. Some UI improvements, easier access to the automation system. Lots more refactoring to come, lots of improvements are still needed in transmitting screenshots and just generally building a automation report we could dump from the build machines.
Change 3051465 on 2016/07/15 by Nick.Darnell
Adding the "Engine Test" project our one stop shope for running automation tests in the engine to try and reduce regressions.
Change 3051847 on 2016/07/15 by Matt.Kuhlenschmidt
Fixed material editor viewport messages being blocked by viewport toolbar
Change 3052025 on 2016/07/15 by Nick.Darnell
Moving the placement mode hooks out of functional testing module, moving them into the editor automation module.
Change 3053508 on 2016/07/18 by Stephan.Jiang
Copy,Cut,Paste tracks, not for mastertracks yet.
#UE-31808
Change 3054723 on 2016/07/18 by Stephan.Jiang
Small fixes for typo & comments
Change 3055996 on 2016/07/19 by Trung.Le
PIE: No longer auto resume game in PIE on focus received
Change 3056106 on 2016/07/19 by Trung.Le
Back out changelist 3055996. Build break.
Change 3056108 on 2016/07/19 by Stephan.Jiang
Updating "SoundConcurrency" asseticon
Change 3056389 on 2016/07/19 by Trung.Le
PIE: No longer auto resume game in PIE on focus received
#jira UE-33339
Change 3056396 on 2016/07/19 by Matt.Kuhlenschmidt
More perf selection improvements:
- Static meshes now go through the static draw path when rendered for selection outline instead of just rendering using the dynamic path
Change 3056758 on 2016/07/19 by Stephan.Jiang
Update SelectedWidgets in WidgetblueprintEditor to match the selected tracks in sequencer.
Change 3057519 on 2016/07/20 by Matt.Kuhlenschmidt
Another fix for selecting lots of objects taking forever. This one is due to repeated Modify calls if there are groups in the selection. Each group actor selected iterates through each object selected during USelection::Modify!
Change 3057635 on 2016/07/20 by Stephan.Jiang
Updating visual logger icon UI
Change 3057645 on 2016/07/20 by Richard.TalbotWatkin
Fixed single player PIE so the window position is correctly fetched and saved, even when running a dedicated server. This does not interfere with stored positions for multiple PIE, which uses ULevelEditorPlaySettings::MultipleInstancePositions.
#jira UE-33416 - New Editor PIE window does not center to screen when running with a dedicated server
Change 3057868 on 2016/07/20 by Richard.TalbotWatkin
Spline component improvements, both tools and runtime:
- SplineComponentVisualizer now works within the Blueprint editor. This works via a generic extension added to the base ComponentVisualizer class which correctly propagates modified properties from the preview actor to the archetype, and then on to any instances whose properties are at the default value.
- The above feature required a breaking change to USplineComponent - namely, the three FInterpCurve properties have been collected together into a struct and added as a single property. This is so that changes to the length of one of the FInterpCurves marks all three as dirty and needing rebuilding.
- Added a custom version for SplineComponent and provded serialization fixes.
- Added a details customization to SplineComponent to hide the raw FInterpCurve properties.
- Added a custom detail builder category which polls the SplineComponentVisualizer each tick and provides numerical editing for spline points which are selected in the visualizer.
- Relaxed the limitation that SplineComponent keys need to have an increment of 1.0. Now any SplineComponent key can be set. The details customization enforces that the sequence remains strictly ascending.
- Allowed an explicit loop point to be specified for closed splines.
- Allowed discontinuous splines by no longer forcing the ArriveTangent and LeaveTangent to be equal.
- Added some new Blueprintable methods for building splines with an FSplinePoint struct, which allows all of a spline point's properties to be specified, and added to the FInterpCurves sorted by the input key.
- Fixed the logic which determines whether the UCS has modified the spline curves.
- Added UActorComponent::RemoveUCSModifiedProperties, which allows a component to remove any properties from the cached list which it doesn't want to be considered as 'modified'. This is used to distinguish the case of properties preserved by the SplineInstanceDataCache from those genuinely modified by the UCS.
- Fixed "Apply Instance Changes to Blueprint" so that edited spline data can be applied to the archetype.
- Fixed some issues with the spline component visualizer to make it generate appropriate up vectors if scale and rotation are enabled.
#jira UETOOL-766 - Spline tool improvements
#jira UE-33049 - Transform widget visible in blueprint viewport when editing spline points in editor viewport
#jira UE-9062 - Spline editing: It would be nice to be able to type in a specific value for a point
#jira UE-7476 - Add ability to edit SplineComponent in BP editor (not just instance in level)
#jira UE-13082 - Users would like a snapping feature for splines
#jira UE-13568 - Additional Spline Component Functionality
#jira UE-17822 - It would be useful to be able to update a bp spline layout from the editor viewport.
Change 3057895 on 2016/07/20 by Richard.TalbotWatkin
Mesh paint bugfixes and improvements.
Changes to RerunConstructionScript so that OnObjectsReplaced is called correctly on all components, whether they have been created by the SCS or the UCS. Previously, components created by the UCS were not being handled, and components created by the SCS were not always being matched. Now a serialized index is maintained for UCS-created objects, which is matched after the construction scripts have been executed.
This will fix issues with the mesh paint tool, and any other editor tool which hooks into the OnObjectsReplaced callback in order to update its internal cache of component pointers, for example, the component visualizer render list.
#jira UE-33010 - Crash changing mesh paint material in blueprint, then changing to a different mode tab
#jira UE-32279 - Editor crashes when reselecting a mesh in paint mode
#jira UE-31763 - [CrashReport] UE4Editor_MeshPaint!FMulticastDelegateBase<FWeakObjectPtr>::RemoveAll() [multicastdelegatebase.h:75]
#jira UE-30661 - Vertex Painting changes collision complexity if the asset is saved while vertex painting
Change 3057966 on 2016/07/20 by Richard.TalbotWatkin
Renamed IsEditingArchetype to IsVisualizingArchetype in the ComponentVisualizer API.
#jira UE-33049 - Transform widget visible in blueprint viewport when editing spline points in editor viewport
Change 3058009 on 2016/07/20 by Richard.TalbotWatkin
Fixed build failure due to changes to FComponentVisualizer API, as of CL 3057868.
Change 3058047 on 2016/07/20 by Stephan.Jiang
Fixing error on previous CL: 3056758
(extra qualification)
Change 3058266 on 2016/07/20 by Nick.Darnell
Automation - Work continues on automation integrating some ideas form a licensee. Continuing to work on the usability aspects, I've made it possible for tests to provide custom open commands, as well as have complex subclasses that do different things. The functional tests now have a custom open command they emit that makes it so clicking on a test opens not the C++ location where the functional test macro lives, but instead the map, AND focuses the functional test actor.
Change 3058282 on 2016/07/20 by Matt.Kuhlenschmidt
PR #2611: Fix spurious component diff when properties are in subcategories (Contributed by CA-ADuran)
Change 3059214 on 2016/07/21 by Richard.TalbotWatkin
Further fixes to visualizers following Component Visualizer API change.
Change 3059260 on 2016/07/21 by Richard.TalbotWatkin
Template specialization not allowed in class scope, but Visual Studio allows it anyway. Fixed for clang.
Change 3059543 on 2016/07/21 by Stephan.Jiang
Changeing level details icon
Change 3059732 on 2016/07/21 by Stephan.Jiang
Directional Light icon update
Change 3060095 on 2016/07/21 by Stephan.Jiang
Directional Light editor icon asset changed
Change 3060129 on 2016/07/21 by Nick.Darnell
Automation - The session browser now attempts to select the app instance if no other thing is selected when it refreshes. This is to try and make it easier to use when you first bring it up and nothing is selected when most of the time you're going to use it on your own instance.
Change 3061735 on 2016/07/22 by Stephan.Jiang
Improve UMG replace with in HierarchyView function
#UE-33582
Change 3062059 on 2016/07/22 by Stephan.Jiang
Strip off "b" in propertyname in replace with function for tracks.
Change 3062146 on 2016/07/22 by Stephan.Jiang
checkin with CL: 3061735
Change 3062182 on 2016/07/22 by Stephan.Jiang
Change both animation bindings' widget name when renameing the widget so the slot content is still valid
Change 3062257 on 2016/07/22 by Stephan.Jiang
comments
Change 3062381 on 2016/07/22 by Nick.Darnell
Build - Adding #undef LOCTEXT_NAMESPACE to try and fix the build.
Change 3062924 on 2016/07/25 by Chris.Wood
Fix a crash in CrashReportClient that happens when the CrashReportReceiver is not responding to pings and there are no PendingReportDirectories.
This is a change in the UE4 stream depot based on a fix in the Fortnite stream depot -> JIRA FORT-27570
Change 3063017 on 2016/07/25 by Matt.Kuhlenschmidt
PR #2618: DebuggerCommand not recording PlayLocationString (Contributed by ungalyant)
Change 3063021 on 2016/07/25 by Matt.Kuhlenschmidt
PR #2619: added a search box to ModuleUI (Contributed by straymist)
Change 3063084 on 2016/07/25 by Matt.Kuhlenschmidt
Fix "YesToAll" when deleting referenced actors overriding the "YesToAll" state for other referenced messages.
https://jira.ol.epicgames.net/browse/UE-33651
#jira UE-33651
Change 3063091 on 2016/07/25 by Alex.Delesky
#jira UE-32949 - Truncating the hue inside the theme color block tooltip to only display whole numbers, to match how the color picker displays the hue value inside the hue scrubber.
Change 3063388 on 2016/07/25 by Matt.Kuhlenschmidt
Selection Perf:
- Fix large FName creation time when selecting thousands of objects
Change 3063568 on 2016/07/25 by Matt.Kuhlenschmidt
Selection Perf:
- Modified how USelection stores classes. Classes are now in a TSet and can be accessed efficiently using IsClassSelected. The old unused way of checking if a selection has a class by iterating through them is deprecated
- USelection no longer directly checks if an item is already selected with a costly n^2 search. The check is done by using the already existing UObject selected annotation
- Object property nodes no longer perform an n^2 check for object uniqueness when objects are added to details panels. This is now left up to the caller to avoid
- Eliminated useless work on FObjectPropertyNode::GetReadAddressUncached. If a read address list is not passed in we'll not attempt to the work to populate it
- Removed expensive checking for brush actors when any actor is selected
Change 3063749 on 2016/07/25 by Stephan.Jiang
Disallow naming the widgetanimation to the same name with a override function in uuserwidget, because it will trigger a breakpoint in Rename()
#jira UE-33711
Change 3064585 on 2016/07/26 by Matt.Kuhlenschmidt
Merging //UE4/Dev-Main to Dev-Editor (//UE4/Dev-Editor)
Change 3064612 on 2016/07/26 by Alex.Delesky
#jira UE-33712 - Deleting many assets at once will now batch SourceControl commands rather than executing one for each asset.
Change 3064647 on 2016/07/26 by Alexis.Matte
#jira UE-33274 dont hash the same file over and over when importing multiple asset from one fbx file.
Change 3064739 on 2016/07/26 by Matt.Kuhlenschmidt
Fixed typo
Change 3064795 on 2016/07/26 by Jamie.Dale
Fixed typo in FLocalizationModule::GetLocalizationTargetByName
#jira UE-32961
Change 3066461 on 2016/07/27 by Jamie.Dale
Enabled stable localization keys
Change 3066463 on 2016/07/27 by Jamie.Dale
Set "Build Engine Localization" to upload all cultures to ensure we don't lose translation due to the archive keying changes
Change 3066467 on 2016/07/27 by Jamie.Dale
Updated internationalization archives to store translations per-identity
This allows translators to translate each instance of a piece of text based upon their context, rather than requiring a content producer to go back and give the entry a unique namespace. It also allows us to optionally compile out-of-date translations, as they are now mapped to their source identity (namespace + key) rather than their source text.
Major changes:
- Added FLocTextHelper. This acts as a high-level API for uncompiled localized text, and replaces all the old ad-hoc loading/saving of manifests and archives, ensuring that everything is consistently using source control, and that older archives can be upgraded correctly to the new format. It also takes care of some of the quirks of our archives, such as native translations. All major localization commandlets have been updated to use FLocTextHelper.
- Moved FTextLocalizationResourceGenerator from Core to Internationalization. This also allows IJsonInternationalizationManifestSerializer and IJsonInternationalizationArchiveSerializer to be removed, and for FJsonInternationalizationManifestSerializer and FJsonInternationalizationArchiveSerializer to have all their functions become static.
- FTextLocalizationResourceGenerator being moved from Core meant that FTextLocalizationManager::LoadFromManifestAndArchives was also removed. This functionality is now handled by FTextLocalizationResourceGenerator::GenerateAndUpdateLiveEntriesFromConfig.
- The RepairLocalizationData commandlet has been removed. This existed to fix a change that pre-dated 4.0 so no such data should exist in the wild, and the commandlet couldn't be updated to work with the new API (we handle format upgrades in-place now).
- Removed FInternationalizationArchive::FindEntryBySource as it is no-longer safe to use. All existing code has been updated to use FInternationalizationArchive::FindEntryByKey instead.
Workflow changes:
- Archive conditioning now only adds new entries if they don't exist in the archive. This allows us to persist any existing translations, even if they're for old source text (caveat: native archives still update existing entries if the source is changed).
- PO export now sets the msgctx for each entry to be "namespace,key", rather than only doing it when the entry had key meta-data.
- PO import will now update both the source and translation stored in the archive to match the current PO data. This is the primary method by which stale source->translation pairs are updated.
- LocRes compilation may now optionally compile stale translations. There's an option controlling this (defaulted to off) that can be changed via the Localization Dashboard (or added to an existing config file).
Format changes:
- The archive version was bumped to 2.
- Archive entries now use the "Key" entry to store the key from the source text. Previously this "Key" entry was used to store the key meta-data, but that now exists within a "MetaData" sub-object. Loading handles this correctly based upon the archive version.
#jira UETOOL-897
#jira UETOOL-898
#jira UE-29481
Change 3066487 on 2016/07/27 by Matt.Kuhlenschmidt
Attempt to fix linux compilation
Change 3066504 on 2016/07/27 by Matt.Kuhlenschmidt
Fixed data tables with structs crashing due to recent editor selection optimizations
Change 3066886 on 2016/07/27 by Jamie.Dale
Added required data to accurately detect TZ (needed for DST)
#jira UE-28511
Change 3067122 on 2016/07/27 by Jamie.Dale
Added AsTime, AsDateTime, and AsDate overrides to BP to let you format a UTC time in a given timezone (default is the local timezone).
Previously you could only format times using the "invariant" timezone, which assumed that the time was already specified in the correct timezone for display.
Change 3067227 on 2016/07/27 by Jamie.Dale
Added a test to verify that the ICU timezone is set correctly to produce local time (including DST)
Change 3067313 on 2016/07/27 by Richard.TalbotWatkin
Fixed SplineComponent constructor so that old assets (prior to the property changes) load correctly if they had properties at default values.
#jira UE-33669 - Crash in Dev-Editor
Change 3067736 on 2016/07/27 by Stephan.Jiang
Border changes for experimental classes warning
Change 3067769 on 2016/07/27 by Stephan.Jiang
HERE BE DRAGONS
for experimental class warning
#UE-33780
Change 3068192 on 2016/07/28 by Alexis.Matte
#jira UE-33586 make sure we remove any false warning when running fbx automation test.
Change 3068264 on 2016/07/28 by Jamie.Dale
Removed some code that was no longer needed and could cause a crash
#jira UE-33342
Change 3068293 on 2016/07/28 by Alex.Delesky
#jira UE-33620 - Comments on constant and parameter nodes in the Material Editor will now persist when converting them.
Change 3068481 on 2016/07/28 by Stephan.Jiang
Adding Options to show/hide soft & hard references & dependencies in References Viewer
#jira UE-33746
Change 3068585 on 2016/07/28 by Richard.TalbotWatkin
Fix to Spline Mesh collision building so that geometry does not default to being auto-inflated in PhysX.
Change 3068701 on 2016/07/28 by Matt.Kuhlenschmidt
Fixed some issues with the selected classes not updating when objects are deselected
Change 3069335 on 2016/07/28 by Jamie.Dale
Fixed unintended error when trying to load a manifest/archive that didn't exist
Fixed a warning when trying to load a PO file that didn't exist
Change 3069408 on 2016/07/28 by Alex.Delesky
#jira UE-33429 - The editor should no longer hit an ensure if the user attempts to drop a tab into a tab well before the tab well has a chance to acknowledge its been dragged into a tab well.
Change 3069878 on 2016/07/29 by Jamie.Dale
Fixed include casing
#jira UE-33910
Change 3071807 on 2016/08/01 by Matt.Kuhlenschmidt
PR #2654: Fix the spell'ing of "diff'ing" and "diff'd". (Contributed by geary)
Change 3071813 on 2016/08/01 by Jamie.Dale
Fixed include casing
#jira UE-33936
Change 3072043 on 2016/08/01 by Jamie.Dale
Fixed FText formatting of pre-Gregorian dates
We now convert to an ICU UDate via an ICU GregorianCalendar, as UE4 and ICU have a different time scale for pre-Gregorian dates.
#jira UE-14504
Change 3072066 on 2016/08/01 by Jamie.Dale
PR #2590: FEATURE: Collapse/expand folders in the outliner (Contributed by projectgheist)
Change 3072149 on 2016/08/01 by Jamie.Dale
We no longer use the editor culture when running with -game
Change 3072169 on 2016/08/01 by Richard.TalbotWatkin
A couple of changes to the BSP code:
* Fixed longstanding issue where sometimes BSP geometry is not rebuilt correctly after editing it. This was due to poly normals not being recalculated after translating vertices in Geometry Mode.
* Fixed corruption to FPoly::iLink as it is overloaded to have two meanings: when building BSP, it represents the surface index of the next coplanar surface (and adding a new BSP node uses this to determine whether a new surface needs to be added or not). In other operations it represents an FPoly index, in general this is used more in editor geometry operations. This fixes various crashes which arose from rebuilding BSP resulting in invalid FPoly indices.
#jira UE-12157 - BSP brushes break when non-standard subtractive bsp brushes are used
#jira UE-32087 - Crash occurs when creating Static Mesh from Trigger Volume
Change 3072221 on 2016/08/01 by Jamie.Dale
Fixed "Launch On" not providing the correct cultures to StartCookByTheBookInEditor
#jira UE-33001
Change 3073389 on 2016/08/02 by Matt.Kuhlenschmidt
Added ability to vsync the editor. Disabled by default. Set r.VSyncEditor to 1 to enable it.
Reimplemented this change from the siggraph demo stream
Change 3073396 on 2016/08/02 by Matt.Kuhlenschmidt
Removed unused code as suggested by a pull request
Change 3073750 on 2016/08/02 by Richard.TalbotWatkin
Fixed formatting (broken in CL 3057895) in anticipation of merge from Main.
Change 3073789 on 2016/08/02 by Jamie.Dale
Added a way to mark text in text properties as culture invariant
This allows you to flag properties containing text that doesn't need to be gathered.
#jira UE-33713
Change 3073825 on 2016/08/02 by Stephan.Jiang
Material Editor: Highligh all Nodes connect to an input.
#jira UE-32502
Change 3073947 on 2016/08/02 by Stephan.Jiang
UMG Project settings to show/hide different classes and categories in Palette view.
--under Project Settings ->Editor->UMG Editor
Change 3074012 on 2016/08/02 by Stephan.Jiang
Minor changes and comments for CL: 3073947
Change 3074029 on 2016/08/02 by Jamie.Dale
Deleting folders in the Content Browser now removes the folder from disk
#jira UE-24303
Change 3074054 on 2016/08/02 by Matt.Kuhlenschmidt
Added missing stats to track pooled vertex and index buffer cpu memory
A new slate allocator was added to track memory usage for this case.
Change 3074056 on 2016/08/02 by Matt.Kuhlenschmidt
Renamed a few slate stats for consistency
Change 3074810 on 2016/08/02 by Matt.Kuhlenschmidt
Moved geometry cache asset type to the animation category. It is not a basic asset type
Change 3074826 on 2016/08/02 by Matt.Kuhlenschmidt
Fix a few padding and sizing issues
Change 3075322 on 2016/08/03 by Matt.Kuhlenschmidt
Settings UI improvements
* Added the ability to search through all settings at once
* Settings files which are not checked out are no longer grayed out. The editor now attempts to check out the file automatically if connected to source control and if that fails it marks the settings file writiable so it can save the setting properly
-------
* This change adds a refactor to the details panel to support multiple top level objects existing in the details panel at once instead of combining all passed in objects to a single common base class. This is disabled by default but can be turned on setting bAllowMultipleTopLevelObjects to true in FDetailsViewArgs when creating a details panel.
* Each top level object in a details panel will get their own customization instance. This made it necessary to deprecate a IDetailsView::GetBaseClass since there is no longer guaranteed to be one base class.
*Details panels can have their own customization for each "root object header" in order to customize the look of having multiple top level objects in the details panel.
Change 3075369 on 2016/08/03 by Matt.Kuhlenschmidt
Removed FBX scene as a top level option in asset filter menu in the content browser.
Change 3075556 on 2016/08/03 by Matt.Kuhlenschmidt
Mac warning fix
Change 3075603 on 2016/08/03 by Nick.Darnell
Adding two new plugins to engine, one for editor and one for runtime based testing. Currently the only consumer of these plugins is going to be the EngineTest project.
Change 3075605 on 2016/08/03 by Nick.Darnell
Functional Testing - Continued work on cleanup, reorganization, trying to improve the workflow for using the session browser.
Change 3076084 on 2016/08/03 by Jamie.Dale
Added basic support for localizing plugins
You can now localize plugins! There's no localization dashboard integration for this so it has to be done manually.
You need to define the localization targets your plugin uses in its .uplugin file, eg)
"LocalizationTargets": [
{
"Name": "Paper2D",
"LoadingPolicy": "Always"
}
]
"Name" should match a localization config under the Config/Localization folder for your plugin. These configs are set-up the same as any other localization config.
"LoadingPolicy" may be one of Never, Always, Editor, Game, PropertyNames, or ToolTips. This allows you to control under what conditions your localizations should be loaded (eg, if your plugin has both game and editor data, you can separate the editor data off into its own localization target that's only loaded by the editor).
UAT has been updated to support gathering from plugins. You can use the "IncludePlugins" flag to have it gather all plugins, or you can specify a whitelist of plugins to gather as an argument to "IncludePlugins", or alternatively, may blacklist certain plugins via "ExcludePlugins". It can now also support out-of-source gathering via the "UEProjectRoot" argument (previously it assumed that everything would be under the UE4 install/checkout directory).
UAT has been updated to support staging plugin LocRes files. It will stage any plugin targets that are enabled for a game/client build, and are also from a plugin that's enabled for your project.
#jira UE-4217
Change 3076123 on 2016/08/03 by Stephan.Jiang
Extend "Select all input nodes" function to general blueprint editor
Change 3077103 on 2016/08/04 by Jamie.Dale
Added support for underlined text rendering (including with drop-shadows)
FTextBlockStyle can now specify a brush to use to draw an underline for text (a suitable default would be "DefaultTextUnderline" from FCoreStyle). When a brush is specified here, we inject FSlateTextUnderlineLineHighlighter highlights into the text layout to draw the underline under the relevant pieces of text, using the correct color, position, and thickness.
FSlateFontCache::GetUnderlineMetrics and FSlateFontRenderer::GetUnderlineMetrics have been added to handle getting the underline metrics (which are slightly different to the baseline).
This change also adds FTextLayout::RemoveRunRenderer and FTextLayout::RemoveLineHighlight to fix some bad assumptions that FSlateEditableTextLayout and FTextBlockLayout were making about ownership of run renderers and line highlighters that could cause them to remove instances they didn't own (such as the new underline highlighter) when updating things like the cursor position or highlight.
Change 3077842 on 2016/08/04 by Jamie.Dale
Fixed fallout from API changes
Change 3077999 on 2016/08/04 by Jamie.Dale
Ensured that BULKDATA_SingleUse is only set by UFontBulkData::Serialize when loading
This prevents it being incorrectly set by other operations, such as counting memory used by font data.
#jira UE-34252
Change 3078000 on 2016/08/04 by Trung.Le
Categories VREditor-specific UMG widget assets as "VR Editor"
#jira UE-34134
Change 3078056 on 2016/08/04 by Nick.Darnell
Build - Fixing a mac compiler warning, reodering constructor initializers.
Change 3078813 on 2016/08/05 by Nick.Darnell
Reorganizing editor tests, establishing plugins in the EditorTest project that will house the tests.
Change 3078818 on 2016/08/05 by Nick.Darnell
Additional rename and cleanup associated with test moving.
Change 3078819 on 2016/08/05 by Nick.Darnell
Removing the Oculus performance automation test, not running, and was unclaimed.
Change 3078842 on 2016/08/05 by Nick.Darnell
Continued reorganizing tests.
Change 3078897 on 2016/08/05 by Nick.Darnell
Additional changes to get some moved tests compiling
Change 3079157 on 2016/08/05 by Nick.Darnell
Making it possible to browse provider names thorugh the source control module interface.
Change 3079176 on 2016/08/05 by Stephan.Jiang
Add shortcut Ctrl+Shift+Space to rotate through different viewport options
#jira UE-34140
Change 3079208 on 2016/08/05 by Stephan.Jiang
Fix new animation name check in UMG
Change 3079278 on 2016/08/05 by Nick.Darnell
Fixing the build
Change 3080555 on 2016/08/08 by Matt.Kuhlenschmidt
Merging //UE4/Dev-Main to Dev-Editor (//UE4/Dev-Editor)
Change 3081155 on 2016/08/08 by Nick.Darnell
Fixing some issues with the editor tests / runtime tests under certain build configs.
Change 3081243 on 2016/08/08 by Stephan.Jiang
Add gesture in LevelViewport to switch between Top/Bottom...etc.
Change 3082226 on 2016/08/09 by Matt.Kuhlenschmidt
Work around animations not playing in paragon due to bsp rebuilds (UE-34391)
Change 3082254 on 2016/08/09 by Stephan.Jiang
DragTool_ViewportChange init changes
[CL 3082411 by Matt Kuhlenschmidt in Main branch]
2016-08-09 11:28:56 -04:00
* @ return True if the selected items can be diffed , false if not .
2014-03-14 14:13:41 -04:00
*/
bool CanDiffSelected ( ) const
{
// throw away text so we can utilize a shared utility method
FText ThrowAwayErrorText ;
TArray < TSharedPtr < FHistoryTreeItem > > SelectedRevs = MainHistoryListView - > GetSelectedItems ( ) ;
return CanDiffSelectedItems ( SelectedRevs , ThrowAwayErrorText ) ;
}
/**
* Takes the two selected history items and finds a UObject asset for each ,
* then attempts to open a diff window to compare them .
*/
void OnDiffSelected ( ) const
{
TArray < TSharedPtr < FHistoryTreeItem > > SelectedRevs = MainHistoryListView - > GetSelectedItems ( ) ;
if ( SelectedRevs . Num ( ) > = 2 )
{
if ( ! DiffHistoryItems ( SelectedRevs [ 0 ] , SelectedRevs [ 1 ] ) )
{
FMessageDialog : : Open ( EAppMsgType : : Ok , NSLOCTEXT ( " SourceControl.HistoryWindow " , " UnableToLoadAssets " , " Unable to load assets to diff. Content may no longer be supported? " ) ) ;
}
}
}
/**
* An event handler for mouse drag detection events . Intended to be used as a delegate for
* history tree rows . Creates a FSourceControlHistoryRowDragDropOp ( if the drag was with
* the left mouse - button ) and assumes that all the selected items are the objects being dragged .
*
* @ param MyGeometry The geometry for the dragged widget .
* @ param MouseEvent Describes the mouse drag action ( from when the drag was detected ) .
* @ return A reply detailing how this event was handled ( " Unhandled " if the click was not a left - click ) .
*/
FReply OnRowDragDetected ( FGeometry const & MyGeometry , FPointerEvent const & MouseEvent ) const
{
if ( MouseEvent . IsMouseButtonDown ( EKeys : : LeftMouseButton ) ) //can only drag when editing
{
TSharedRef < FSourceControlHistoryRowDragDropOp > DragOperation = FSourceControlHistoryRowDragDropOp : : New ( ) ;
// assume that what we're dragging is what we have selected
DragOperation - > SelectedItems = MainHistoryListView - > GetSelectedItems ( ) ;
check ( DragOperation - > SelectedItems . Num ( ) > 0 ) ;
return FReply : : Handled ( ) . BeginDragDrop ( DragOperation ) ;
}
else
{
return FReply : : Unhandled ( ) ;
}
}
/**
* An event handler for mouse drag enter events . Intended to be used as a delegate for
* history tree rows . Only handles FSourceControlHistoryRowDragDropOp drag / drop operations .
* Updates the FSourceControlHistoryRowDragDropOp to reflect if a drop action is doable
* ( when over this item ) .
*
* @ param DragDropEvent The drag / drop operation that triggered this handler .
* @ param HoveredItem The history tree item that is conceptually being hovered over .
*/
void OnRowDragEnter ( FDragDropEvent const & DragDropEvent , TSharedPtr < FHistoryTreeItem > const HoveredItem ) const
{
2014-04-23 18:00:50 -04:00
TSharedPtr < FSourceControlHistoryRowDragDropOp > DragRowOp = DragDropEvent . GetOperationAs < FSourceControlHistoryRowDragDropOp > ( ) ;
if ( DragRowOp . IsValid ( ) )
2014-03-14 14:13:41 -04:00
{
DragRowOp - > PendingDropAction = FSourceControlHistoryRowDragDropOp : : EDropAction : : None ;
TArray < TSharedPtr < FHistoryTreeItem > > DiffingItems = DragRowOp - > SelectedItems ;
check ( HoveredItem . IsValid ( ) ) ;
DiffingItems . Add ( HoveredItem ) ;
if ( CanDiffSelectedItems ( DiffingItems , DragRowOp - > HoverText ) )
{
DragRowOp - > PendingDropAction = FSourceControlHistoryRowDragDropOp : : EDropAction : : Diff ;
FText const RevisionFormatText = NSLOCTEXT ( " SourceControlHistory " , " Revision " , " Revision {0} " ) ;
FText const CurrentRevisionText = NSLOCTEXT ( " SourceControlHistory " , " CurrentRevsion " , " Current Revision " ) ;
check ( DragRowOp - > SelectedItems . Num ( ) > 0 ) ;
TSharedPtr < FHistoryTreeItem > DraggedItem = DiffingItems [ 0 ] ;
// set text identifying the dragged item's revision (current version vs. revision X)
FText DraggedRevisionText = CurrentRevisionText ;
if ( DraggedItem - > RevisionListItem . IsValid ( ) )
{
2015-01-20 05:48:14 -05:00
DraggedRevisionText = FText : : Format ( RevisionFormatText , FText : : FromString ( DraggedItem - > RevisionListItem - > Revision ) ) ;
2014-03-14 14:13:41 -04:00
}
// set text identifying the hovered item's revision (current version vs. revision X)
FText HoveredRevisionText = CurrentRevisionText ;
if ( HoveredItem - > RevisionListItem . IsValid ( ) )
{
2015-01-20 05:48:14 -05:00
HoveredRevisionText = FText : : Format ( RevisionFormatText , FText : : FromString ( HoveredItem - > RevisionListItem - > Revision ) ) ;
2014-03-14 14:13:41 -04:00
}
TSharedPtr < FHistoryFileListViewItem > const DraggedFileItem = GetFileListItem ( DraggedItem ) ;
// convert DraggedRevisionText from the form "revision X" (or "the current version") to
// "revision X of <filename>"
FString const DraggedFileName = FPaths : : GetBaseFilename ( DraggedFileItem - > FileName ) ;
FText const NamedRevisionTextFormat = NSLOCTEXT ( " SourceControlHistory " , " NamedRevision " , " {0} ({1}) " ) ;
DraggedRevisionText = FText : : Format ( NamedRevisionTextFormat , FText : : FromString ( DraggedFileName ) , DraggedRevisionText ) ;
TSharedPtr < FHistoryFileListViewItem > const HoveredFileItem = GetFileListItem ( HoveredItem ) ;
// if we're diffing two separate files against each other
if ( DraggedFileItem ! = HoveredFileItem )
{
// need to separately identify the hovered over item
FString const HoveredFileName = FPaths : : GetBaseFilename ( HoveredFileItem - > FileName ) ;
HoveredRevisionText = FText : : Format ( NamedRevisionTextFormat , FText : : FromString ( HoveredFileName ) , HoveredRevisionText ) ;
}
FText const DropToDiffTextFormat = NSLOCTEXT ( " SourceControlHistory " , " DropToDiff " , " Drop {0} to diff against: {1}. " ) ;
DragRowOp - > HoverText = FText : : Format ( DropToDiffTextFormat , DraggedRevisionText , HoveredRevisionText ) ;
}
}
}
/**
* An event handler for mouse drag leave events . Intended to be used as a delegate for
* history tree rows . Only handles FSourceControlHistoryRowDragDropOp drag / drop operations .
* Clears any pending drop actions from the FSourceControlHistoryRowDragDropOp .
*
* @ param DragDropEvent The drag / drop operation that triggered this handler .
*/
void OnRowDragLeave ( FDragDropEvent const & DragDropEvent ) const
{
2014-04-23 18:00:50 -04:00
TSharedPtr < FSourceControlHistoryRowDragDropOp > DragRowOp = DragDropEvent . GetOperationAs < FSourceControlHistoryRowDragDropOp > ( ) ;
if ( DragRowOp . IsValid ( ) )
2014-03-14 14:13:41 -04:00
{
DragRowOp - > HoverText = FText : : GetEmpty ( ) ;
DragRowOp - > PendingDropAction = FSourceControlHistoryRowDragDropOp : : EDropAction : : None ;
}
}
/**
* An event handler for mouse drop events . Intended to be used as a delegate for
* history tree rows . Only handles FSourceControlHistoryRowDragDropOp drag / drop operations .
* Executes the pending FSourceControlHistoryRowDragDropOp action ( diff , etc . )
*
* @ param DragDropEvent The drag / drop operation that triggered this handler .
* @ param HoveredItem The history tree item that is conceptually being dropped on to .
* @ return A reply detailing how this event was handled ( " Unhandled " if the operation was not a FSourceControlHistoryRowDragDropOp ) .
*/
FReply OnRowDrop ( FDragDropEvent const & DragDropEvent , TSharedPtr < FHistoryTreeItem > const HoveredItem ) const
{
2014-04-23 18:00:50 -04:00
TSharedPtr < FSourceControlHistoryRowDragDropOp > DragRowOp = DragDropEvent . GetOperationAs < FSourceControlHistoryRowDragDropOp > ( ) ;
if ( DragRowOp . IsValid ( ) )
2014-03-14 14:13:41 -04:00
{
if ( DragRowOp - > PendingDropAction = = FSourceControlHistoryRowDragDropOp : : EDropAction : : Diff )
{
check ( DragRowOp - > SelectedItems . Num ( ) > 0 ) ;
DiffHistoryItems ( DragRowOp - > SelectedItems [ 0 ] , HoveredItem ) ;
return FReply : : Handled ( ) ;
}
}
return FReply : : Unhandled ( ) ;
}
/** Main list view of the panel, displays each file history item */
typedef STreeView < TSharedPtr < FHistoryTreeItem > > SHistoryFileListType ;
/** ListBox for selecting which object to consolidate */
TSharedPtr < SHistoryFileListType > MainHistoryListView ;
/** Items control for the "additional information" subpanel */
TSharedPtr < SBorder > AdditionalInfoItemsControl ;
/** All file history items the panel should display */
TArray < TSharedPtr < FHistoryTreeItem > > HistoryCollection ;
/** The last selected revision item; Displayed in the "additional information" subpanel */
TWeakPtr < FHistoryRevisionListViewItem > LastSelectedRevisionItem ;
} ;
void FSourceControlWindows : : DisplayRevisionHistory ( const TArray < FString > & InPackageNames )
{
ISourceControlProvider & SourceControlProvider = ISourceControlModule : : Get ( ) . GetProvider ( ) ;
// Query for the file history for the provided packages
TArray < FString > PackageFilenames = SourceControlHelpers : : PackageFilenames ( InPackageNames ) ;
TSharedRef < FUpdateStatus , ESPMode : : ThreadSafe > UpdateStatusOperation = ISourceControlOperation : : Create < FUpdateStatus > ( ) ;
UpdateStatusOperation - > SetUpdateHistory ( true ) ;
if ( SourceControlProvider . Execute ( UpdateStatusOperation , PackageFilenames ) )
{
TArray < FSourceControlStateRef > SourceControlStates ;
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3967517)
#rb none
#lockdown Nick.Penwarden
#rnx
============================
MAJOR FEATURES & CHANGES
============================
Change 3804281 by Fred.Kimberley
Improve contrast on watches in blueprints.
Change 3804322 by Fred.Kimberley
First pass at adding a watch window for blueprint debugging.
Change 3804737 by mason.seay
Added some Descriptions to tests that didn't have any, and fixed some typos
Change 3806103 by mason.seay
Moved and Renamed Timers test map and content appropriately
Change 3806164 by Fred.Kimberley
Add missing property types to GetDebugInfoInternal.
#jira UE-53355
Change 3806617 by Dan.Oconnor
Function Terminator (and derived types) now use FMemberReference instead of a UClass/FName pair. This fixes various bugs when resolving the UFunction referenced by the function terminator
#jira UE-31754, UE-42431, UE-53315, UE-53172
Change 3808541 by Fred.Kimberley
Add support for redirecting user defined enums.
This is in response to the following UDN thread: https://udn.unrealengine.com/questions/404141/is-is-possible-to-create-a-redirector-from-a-bluep.html
Change 3808565 by mason.seay
Added a few more struct tests
Change 3809840 by mason.seay
Renamed CharacterMovement.umap to CharacterCollision. Fixed up content to reflect this change.
Change 3809847 by mason.seay
Added Object Timer tests. Fixed up existing timer test to remove delay dependency
Change 3811704 by Ben.Zeigler
Fix issue where identical enum redirects registered to different initial names would throw an incorrect error, it's fine if the value change maps are identical
Change 3811946 by Ben.Zeigler
#jira UE-53511 Fix it so it is possible to set a user defined struct value back to it's default. The UDS hack in PropertyValueToString is no longer needed, but this could affect some other user struct editor operations
Change 3812061 by Dan.Oconnor
Stepping over or in to nodes that are expanded at compile time (e.g. event nodes, spawn actor nodes) no longer requires multiple 'steps'
#jira UE-52854
Change 3812259 by Dan.Oconnor
Fix asset broken by removal of an unkown enum
#jira UE-51419
Change 3812904 by Ben.Zeigler
Make ResolveRedirects on StreamableManager public as it can be used to validate things
Change 3812958 by Ben.Zeigler
#jira UE-52977 Fix crashes when binding blueprint editor commands to keys and using from invalid contexts
Change 3812975 by Mieszko.Zielinski
Added contraptions to catch a rare eidtor-time EQS crash #UE4
#jira UE-53468
Change 3818530 by Phillip.Kavan
Fix incorrect access to nested instanced subobjects in nativized Blueprint ctor codegen.
Change summary:
- Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to properly reference the outer and check ptr validity when creating/obtaining nested default subobjects.
- Modified FEmitDefaultValueHelper::HandleClassSubobject() to better guard against code generation based on an invalid local variable name.
#jira UE-52167
Change 3819733 by Mieszko.Zielinski
Marked UAISenseConfig_Blueprint and UAISense_Blueprint as hidedropdown #UE4
#jira UE-15089
Change 3821776 by Marc.Audy
Remove redundent code in SpawnActorFromClass that already exists in ConstructObjectFromClass parent class
Change 3823851 by mason.seay
Moved and renamed blueprints used for Object Reference testing
Change 3824165 by Phillip.Kavan
Ensure that subobject class types are constructed prior to accessing a subobject CDO in a nativized Blueprint class's generated ctor at runtime.
Change summary:
- Modified FFakeImportTableHelper to tag subobject class types as a preload dependency of the outer converted Blueprint class type and not of the CDO.
#jira UE-53111
Change 3830309 by mason.seay
Created Literal Gameplay Tag Container test
Change 3830562 by Phillip.Kavan
Blueprint nativization bug fixes (reviewed/taken from PR).
Change summary:
- Modified FSafeContextScopedEmitter::ValidationChain() to ensure that generated code calls the global IsValid() utility function on objects.
- Modified FBlueprintCompilerCppBackend::EmitCreateArrayStatement() to generate a proper cast on MakeArray node inputs for enum class types.
- Modified FBlueprintCompilerCppBackend::EnimCallStatementInner() to more correctly identify an interface function call site.
- Modified FEmitHelper::GenerateAutomaticCast() to properly handle automatic casts of enum arrays.
- (Modified from PR source) Added new FComponentDataUtils statics to consolidate custom init code generation for converted special-case component types (e.g. BodyInstance). Ties native component DSOs to the same pre/post as converted non-native component templates around the OuterGenerate() loop.
- Modified FExposeOnSpawnValidator::IsSupported() to include CPT_SoftObjectReference property types.
- Modified UBlueprintGeneratedClass::CheckAndApplyComponentTemplateOverrides() to no longer break out of the loop before finding additional ICH override record matches.
#4202
#jira UE-52188
Change 3830579 by Fred.Kimberley
Add support for turning off multiple watches at once in the watch window.
#jira UE-53852
Change 3836047 by Zak.Middleton
#ue4 - Dev test maps for overlaps perf tests.
Change 3836768 by Phillip.Kavan
Fix for a build failure that could occur with Blueprint nativization enabled and EDL disabled. This was a regression introduced in 4.18.
Change summary:
- Modified FEmitDefaultValueHelper::AddStaticFunctionsForDependencies() to emit the correct signature for constructing FBlueprintDependencyData elements when the EDL boot time optimization is disabled.
#jira UE-53908
Change 3838085 by mason.seay
Functional tests around basic blueprint functions
Change 3840489 by Ben.Zeigler
#jira UE-31662 Fix regression with renaming parent inherited function. It was not correctly searching the parent's skeleton class during the child's recompile so it was erroneously detecting the parent function as missing
Change 3840648 by mason.seay
Updated Descriptions on tests
Change 3842914 by Ben.Zeigler
Improve comments around stremable handle cancel/release
Change 3850413 by Ben.Zeigler
Fix asset registry memory reporting, track some newer fields and correctly report the state size instead of static size twice
Copy of CL #3849610
Change 3850426 by Ben.Zeigler
Reduce asset registry memory in cooked build by stripping out searchable names and empty dependency nodes by default
Add option to strip dependency data for asset data with no tags, this was always true before but isn't necessarily safe
Copy of CL #3850389
Change 3853449 by Phillip.Kavan
Fix a scoping issue for local instanced subobject references in nativized Blueprint C++ code. Also, don't emit redundant assignment statements for instanced subobject reference properties.
Change summary:
- Consolidated FComponentDataUtils into FDefaultSubobjectData and extended FNonativeComponentData from it in order to handle both native & non-native DSO initialization codegen through a more common interface.
- Exposed FEmitDefaultValueHelper::HandleInstancedSubobject() as a public API and added a 'SubobjectData' parameter to allow initialization codegen to be deferred until after all default subobjects have been mapped to local variables within the current scope.
- Modified FEmitDefaultValueHelper::GenerateConstructor() to first map all default subobjects to local variables and then emit any delta initialization code for property values.
- Modified FEmitDefaultValueHelper::HandleSpecialTypes() to return an empty string for an instanced reference to a default subobject. This allows us to avoid emitting initialization statements to unnecessarily reassign instances back to the same property.
- Modified FEmitDefaultValueHelper::InnerGenerate() to better handle instanced references to default subobjects, ensuring that we don't emit unnecessary assignment statements and array initialization code to the converted class constructor in C++.
- Fixed a few typos.
#jira UE-53960
Change 3853465 by Phillip.Kavan
Fix plugin module C++ source template to conform to recent public include path changes.
Change 3857599 by Marc.Audy
PR #4438: UE-54281: Make None a valid default value to select (Contributed by projectgheist)
#jira UE-54281
#jira UE-54399
Change 3863259 by Zak.Middleton
#ue4 - Save bandwidth for replicated characters by only replicating 4 byte timestamp value to clients if it's actually needed for Linear smoothing. Added option to always replicate the timestamp ("bNetworkAlwaysReplicateTransformUpdateTimestamp", default off), in case users still want this timestamp for some reason, or if smoothing mode changes dynamically and the server won't know.
#jira UE-46293
Change 3863491 by Zak.Middleton
#ue4 - Reduce network RPC overhead for players that are not moving. Added ClientNetSendMoveDeltaTimeStationary (default 12Hz) to supplement existing ClientNetSendMoveDeltaTime and ClientNetSendMoveDeltaTimeThrottled. UCharacterMovementComponent::GetClientNetSendDeltaTime() now uses this time if Acceleration and Velocity are zero, and the control rotation matches the last ack'd control rotation from the server.
Also fixed up code default for ClientNetSendMoveDeltaTime to match default INI value.
#jira UE-21264
Change 3865325 by Zak.Middleton
#ue4 - Fix static analysis warning about possible null PC pointer.
#jira none
Change 3869828 by Ben.Zeigler
#jira UE-54786 Fix it so -cookonthefly cooperates with -iterate by writing out a development asset registry
Change 3869969 by mason.seay
Character Movement Functional Tests
Change 3870099 by Mason.Seay
Submitted asset deletes
Change 3870105 by mason.seay
Removed link to anim blueprint to fix errors
Change 3870238 by mason.seay
Test map for Async Loading in a Loop
Change 3870479 by Ben.Zeigler
Add code to check CoreRedirects for SoftObjectPaths when saving or resolving in the editor. This is a bit slow so we don't want to do it on load
We don't have any good way to know the type of a path so I check both Object and Class redirectors, which will also pickup Module renames
Change 3875224 by mason.seay
Functional tests for Event BeginPlay execution order
Change 3875409 by mason.seay
Optimized and fixed up character movement tests (because a potential bug in FunctionalTestActor is always passing a test when it can fail)
Change 3878947 by Mieszko.Zielinski
CIS fixes #UE4
Change 3879000 by Mieszko.Zielinski
More CIS fixes #UE4
Change 3879139 by Mieszko.Zielinski
Even moar CIS fixes #UE4
Change 3879742 by mason.seay
Added animation to Nativization Widget asset
Change 3880198 by Zak.Middleton
#ue4 - CanCrouchInCurrentState() returns false when character capsule is simulating physics.
#jira UE-54875
github #4479
Change 3880266 by Zak.Middleton
#ue4 - Optimize UpdateCharacterStateBeforeMovement() to do cheaper tests earlier (avoid CanCrouchInCurrentState() unless necessary, now that it tests IsSimulatingPhysics() which is not trivial).
#jira UE-54875
Change 3881546 by Mieszko.Zielinski
*.Build.cs files clean up - removed redundant dependencies from NavigationSystem and AIModule #UE4
Change 3881547 by Mieszko.Zielinski
Removed a bunch of DEPRECATED functions from the new NavigationSystem module #UE4
Removed all deprecates prior 4.15 (picked this one because I do know some licencees are still using it).
Change 3881742 by mason.seay
Additional crouch test to cover UE-54875
Change 3881794 by Mieszko.Zielinski
Fixed a bug in FVisualLoggerHelpers::GetCategories resulting in losing verbosity information #UE4
Change 3884503 by Mieszko.Zielinski
Fixed TopDown code template to make it compile after navsys refactor #UE4
#jira UE-55039
Change 3884507 by Mieszko.Zielinski
Switched ensures in UNavigationSystemV1:SimpleMoveToX to error-level logs #UE4
It's an error rather than a warning because the functions no longer do anything. Making it work would require a cyclic dependency between NavigationSystem and AIModule.
#jira UE-55033
Change 3884594 by Mieszko.Zielinski
Added a const FNavigationSystem::GetCurrent version #UE4
lack of it was causing KiteDemo to not compile.
Change 3884602 by Mieszko.Zielinski
Mac editor compilation fix #UE4
Change 3884615 by Mieszko.Zielinski
Fixed FAIDataProviderValue::GetRawValuePtr not being accessible from outside of AIModule #UE4
Change 3885254 by Mieszko.Zielinski
Guessfix for UE-55030 #UE4
The name of NavigationSystem module was put in wrong in the IMPLEMENT_MODULE macro
#jira 55030
Change 3885286 by Mieszko.Zielinski
Changed how NavigationSystem module includes DerivedDataCache module #UE4
#jira UE-55035
Change 3885492 by mason.seay
Minor tweaks to animation
Change 3885773 by mason.seay
Resaving assets to clear out warning
Change 3886433 by Mieszko.Zielinski
Fixed TP_TopDownBP's player controller BP to not use deprecated nav functions #UE4
#jira UE-55108
Change 3886783 by Mieszko.Zielinski
Removed silly inclusion of NavigationSystemTypes.h from NavigationSystemTypes.h #UE4
Change 3887019 by Mieszko.Zielinski
Fixed accessing unchecked pointer in ANavigationData::OnNavAreaAdded #UE4
Change 3891031 by Mieszko.Zielinski
Fixed missing includes in NavigationSystem.cpp #UE4
Change 3891037 by Mieszko.Zielinski
ContentEample's navigation fix #UE4
#jira UE-55109
Change 3891044 by Mieszko.Zielinski
PR #4456: Fix bug in UAISense_Sight::OnListenerForgetsActor (Contributed by maxtunel)
#UE4
Change 3891598 by mason.seay
Resaving assets to clear out "empty engine version" spam
Change 3891612 by mason.seay
Fixed deprecated Set Text warnings
Change 3893334 by Mieszko.Zielinski
Fixed a bug in navmesh generation resulting in not removing layers that ended up empty after rebuilding #UE4
#jira UE-55041
Change 3893394 by Mieszko.Zielinski
Fixed navmesh debug drawing to properly display octree elements with "per instance transforms" (like instanced SMs) #UE4
Also, added a more detailed debug drawing of navoctree contents (optional, but on by default).
Change 3893395 by Mieszko.Zielinski
Added a bit of code to navigation system's initialization that checks the enegine ini for sections refering to the moved navigation classes, and complain about it #UE4
The message is printed as an error-level log line and it says what should the offending section be renamed to.
Change 3895563 by Dan.Oconnor
Mirror 3895535
Append history from previous branches in source control history view
#jira none
Change 3896930 by Mieszko.Zielinski
Added an option to tick navigation system while the game is paused #UE4
Controlled via NavigationSystemV1.bTickWhilePaused, ini- and ProjectSettings-configurable.
#jira UE-39275
Change 3897554 by Mieszko.Zielinski
Unified how NavMeshRenderingComponent draws navmesh and octree collision's polys #UE4
Change 3897556 by Mieszko.Zielinski
Fixed what kind of nav tile bounds we're sending to nav-colliding elements when calling 'per-instance transform' delegate #UE4
#jira UE-45261
Change 3898064 by Mieszko.Zielinski
Made SM Editor display AI-navigation-related whenever bHasNavigationData is set to true #UE4
#jira UE-50436
Change 3899004 by Mieszko.Zielinski
Fixed UEnvQueryItemType_Actor::GetItemLocation and UEnvQueryItemType_Actor::GetItemRotation to return FAISystem::InvalidLocation and FAISystem::InvalidRotation respectively instead of '0' when hosted Actor ptr is null #UE4
Note for programmers: this changes the default behavior of this edge case. You might want to go through your code and check if you're comparing UEnvQueryItemType_Actor::GetItem*'s results to 0.
Change 3901733 by Mieszko.Zielinski
Made FEnvQueryInstance::PrepareContext implementations returning vectors and rotators ignore InvalidLocation and InvalidRotation (respectively) #UE4
Change 3901925 by Ben.Zeigler
#jira UE-55395 Fix issue where the cooker could load asset registry caches made in -game that do not have dependency data, leading to broken cooks
Change 3902166 by Marc.Audy
Make ULevel::GetWorld final
Change 3902749 by Ben.Zeigler
Fix it so pressing refresh button in asset audit window actually refreshes the asset management database
Change 3902763 by Ben.Zeigler
#jira UE-55407 Fix it so editor tutorials are not cooked unless referenced, by correctly marking soft object paths imported from editor project settings as editor-only
Change 3905578 by Phillip.Kavan
The UX to add a new parameter on a Blueprint delegate is now at parity with Blueprint functions.
#4392
#jira UE-53779
Change 3905848 by Phillip.Kavan
First pass of the experimental Blueprint graph bookmarks feature.
#jira UE-10052
Change 3906025 by Phillip.Kavan
CIS fix.
Change 3906195 by Phillip.Kavan
Add missing icon file.
Change 3906356 by Phillip.Kavan
Moved Blueprint bookmarks enable flag into EditorExperimentalSettings for consistency with other options.
Change 3910628 by Ben.Zeigler
Partial fix for UE-55363, this allows references to ObjectRedirectors to be switched from parent class to a child class on load as this should always be safe
This does not actually fix UE-55363 because that case is changing from UMaterial to UMaterialInstanceConstant, and those are siblings instead of parent/child
Change 3912470 by Ben.Zeigler
#jira UE-55586 Fix issue with saving redirected soft object paths where the export sort could accidentally cause the parent CDO to get modified between name tagging and writing exports, which is unsafe because due to delta serialization it would try to write names that were not previously tagged
Change 3913045 by Marc.Audy
Fix issues where recursion in to child actors wasn't being handled correctly
Change 3913398 by Fred.Kimberley
Fixes a misspelled name for one of the classes in the ability system.
PR #4430: Fixed spelling of FGameplayAbilityInputBinds. (Contributed by IntegralLee)
#github
#jira UE-54327
Change 3918016 by Fred.Kimberley
Ensure AllocGameplayEffectContext is being used in all cases where FGameplayeEffectContext is being created.
#jira UE-52668
PR #4250: Only create FGameplayEffectContext via AbilitySystemGlobals::.AllocGameplayEffectContext (Contributed by slonopotamus)
#github
Change 3924653 by Mieszko.Zielinski
Fixed LoadEngineClass local to UnrealEngine.cpp to check class redirects before falling back to default class instance #UE4
#jira UE-55378
Change 3925614 by Phillip.Kavan
Fix ForEachEnum node to skip over hidden enum values in new placements by default.
Change summary:
- Added FKismetNodeHelperLibrary::ShouldHideEnumeratorIndex() as an internal-only Blueprint node support API.
- Modified FForExpandNodeHelper::AllocateDefaultPins() to add a "Skip Hidden" input pin (advanced). Pin default value is false.
- Added a UK2Node_ForEachElementInEnum::PostPlacedNewNode() override to set the default value of the "Skip Hidden" input pin to 'true' for all new node placements.
- Modified UK2Node_ForEachElementInEnum::ExpandNode() to include additional expansion logic based on the "Skip Hidden" input pin. For new placements (i.e. when the pin defaults to 'true'), an intermediate branch node will now be inserted into the compiled execution sequence to test for "hidden" metadata on the value before executing the loop body. If the input pin is linked, another intermediate branch will be inserted into the execution sequence prior to the "hidden" metadata test. All existing placements of the node will remain as-is after compilation (i.e. no additional intermediate branch nodes will be included in the expansion).
#jira UE-34563
Change 3925649 by Marc.Audy
Fix up issue post merge from Main with navigation system refactor
Change 3926293 by Phillip.Kavan
Temp fix to unblock CIS.
#jira UE-34563
Change 3926523 by Marc.Audy
Ensure that a renamed Actor is in the correct Actors array
#jira UE-46718
Change 3928732 by Fred.Kimberley
Unshelved from pending changelist '3793298':
#jira UE-53136
PR #4287: virtual additions for AttributeSet extendability (Contributed by TWIDan)
#github
Change 3928780 by Marc.Audy
PR #4309: The display names of the functions. (Contributed by SertacOgan)
#jira UE-53334
Change 3929730 by Joseph.Wysosky
Submitting test assets for the new Blueprint Structure test cases
Change 3931919 by Joseph.Wysosky
Deleting BasicStructure asset to rest MemberVariables back to default settings
Change 3931922 by Joseph.Wysosky
Adding BasicStructure test asset back with default members
Change 3932083 by Phillip.Kavan
Fix Compositing plugin source files to conform to updated relative include path specifications.
- Encountered while testing Blueprint nativization of assets with dependencies on Composure/LensDistortion APIs.
Change 3932196 by Dan.Oconnor
Resetting a property to default now uses the same codepath as assigning the value from the slate control
#jira UE-55909
Change 3932408 by Lukasz.Furman
fixed behavior tree services attached to task nodes being sometimes recognized as root level
#jira nope
Change 3932808 by Marc.Audy
PR #4083: Change to UK2Node_BaseAsyncTask to have pin tooltips on latent nodes (Contributed by dwrpayne)
#jira UE-50871
Change 3934101 by Phillip.Kavan
Revise ForEachEnum node expansion logic to exclude hidden values at compile time.
Change summary:
- Removed UKismetNodeHelperLibrary::ShouldHideEnumeratorIndex() (no longer in use).
- Modified UK2Node_ForEachElementInEnum::ExpandNode() to include an enum switch node in the expansion, which will exclude hidden values when constructed. The additional expansion will occur if the enum type contains at least one hidden value.
#jira UE-34563
Change 3934106 by Phillip.Kavan
Mirrored 4.19 fixes to allow for EngineTest iteration w/ nativization enabled.
Change summary:
- Mirrored CLs 3876918, 3878968, 3883257, 3885566, 3912161 and 3920519.
Change 3934116 by Phillip.Kavan
UBT: Explicitly define the DEPRECATED_FORGAME macro only for non-engine modules.
Change summary:
- Modified UEBuildModule.SetupPrivateCompileEnvironment() to check the 'bTreatAsEngineModule' flag from the rules assembly rather than testing the module's build type.
Change 3934382 by Phillip.Kavan
Avoid inclusion of monolothic engine header files in nativized Blueprint codegen.
Change 3936387 by Mieszko.Zielinski
Added a flag to NavModifierComponent to control whether agent's height is being used while expadning modifier's bounds during navmesh generation #UE4
Change 3936905 by Ben.Marsh
Disable IncludeTool warning for DEPRECATED_FORGAME macro; we expect this to be different for game modules.
Change 3940537 by Marc.Audy
Don't allow maps, sets, or arrays with an actor inner type in user defined structs to select an actor from the currently open level as default value.
#jira UE-55938
Change 3940901 by Marc.Audy
Properly name CVar global to reflect what it is for
Change 3943043 by Marc.Audy
Fix world context functions not being able to be used in CheatManager derived blueprints
#jira UE-55787
Change 3943075 by Mieszko.Zielinski
Moved path-following related delegats' interface from NavigationSystemBase over to a new IPathFollowingManagerInterface #UE4
Change 3943089 by Mieszko.Zielinski
Fixed how WorldSettings.NavigationSystemConfig gets created #UE4
Made it so that there's always a NavigationSystemConfig instance present, but added a 'Null' config - this was required due to issues with creation/serialization of instanced subobjects.
The change required adding copying constructors to FNavAgentProperties and FNavDataConfig.
Also, fixed FNavAgentProperties.IsEquivalent to be symetrical.
Change 3943225 by Marc.Audy
Fix spelling of Implements
Change 3950813 by Marc.Audy
Include owner in attachment mismatch ensure
#jira UE-56148
Change 3950996 by Marc.Audy
Fix cases where bit packed properties used the entire byte not just the bit when interacting with boolean arrays
#jira UE-55482
Change 3952086 by Marc.Audy
PR #4483: Add Missing Radial Damage Multicast Delegate (Contributed by error454)
#jira UE-54974
Change 3952720 by Marc.Audy
PR #4575: Check if *Pawn* is a null Pointer (Contributed by dani9bma)
#jira UE-56248
Change 3952804 by Richard.Hinckley
Changes to BP API export commandlet to support better plugin exporting. Contributed by Harry Wang of Google.
Change 3952962 by Marc.Audy
UHT now validates that ExpandEnumAsExecs references a valid parameter to the function.
#jira UE-49610
Change 3952977 by Phillip.Kavan
Fix EDL cycle at load time in nativized cooked builds when a circular dependency exists between converted and unconverted assets.
Change summary:
- Added FGatherConvertedClassDependencies::MarkUnconvertedClassAsNecessary().
- Modified FFindAssetsToInclude::MaybeIncludeObjectAsDependency() to mark unconverted BPGCs (e.g. DOBPs) as necessary for conversion when the potential for a circular dependency exists so that we generate stub wrappers rather than depend on them directly.
- Fixed a few typos in existing API names.
#jira UE-48233
Change 3953658 by Marc.Audy
(4.19.1) Fix inserting a reroute node causing connections to break on a GetClassDefaults node
#jira UE-56270
Change 3954727 by Marc.Audy
Add friendly name to custom version mismatch message
Change 3954906 by Marc.Audy
(4.19.1) Fix crash when undoing changes related to reroute nodes connected to a GetClassDefaults node
#jira UE-56313
Change 3954997 by Marc.Audy
Ensure and return null if GetOuter<WithinClass> is called on a CDO for uclasses declared as within another so we don't get a UPackage c-style cast to the expected outer type
Change 3955091 by Marc.Audy
Do not register subcomponents that are not auto register
#jira UE-52878
Change 3955943 by Marc.Audy
Make AbilitySystemComponent pass parameters by const& instead of ref as no state is being changed
Change 3956185 by Zak.Middleton
#ue4 - Fix Characters using scoped movement updates (the default) not visually rotating when rotated at small rates at high framerate.
This was caused by FScopedMovementUpdate::IsTransformDirty() using a larger FTransform comparison tolerance than USceneComponent::UpdateComponentToWorldWithParent().
#jira none
Change 3958102 by Marc.Audy
Clean out dead code path from k2node_select
Select node now resets pins to wildcard if none of the pins are in use
Change 3958113 by Lukasz.Furman
added OnSearchStart call to root level behavior tree services
#jira UE-56257
Change 3958361 by Marc.Audy
Fix literal input pins on select being set to wildcard during compilation
Change 3961148 by Dan.Oconnor
Mirror 3961139 from Release 4.19
Fix for placeholder objects being left behind when loading certain UMG assets - this could causea crash when loading UMG assets
#jira UE-55742
Change 3961640 by Marc.Audy
Select node now displays Add Pin button
Undo of changing select node index type now works correctly.
Connections to option pins now maintained across change of index pin type
#jira UE-20742
Change 3962262 by Marc.Audy
Display "Object Reference" instead of "Object Object Reference" and "Soft Object Reference" instead of "Object Soft Object Reference"
Change 3962795 by Phillip.Kavan
Fix for a crash when cooking with Blueprint nativization enabled after encountering a nested instanced editor-only default subobject inherited from a native C++ base class.
- Mirrored from //UE4/Release-4.19 (3962782)
#jira UE-56316
Change 3962991 by Marc.Audy
Modify Negate/Increment/Decrement Int/Float so that the output is always the desired result even if a non-mutable pin is passed in.
Note that this can mean the result being returned and the value of the pin passed in if queried again will not be the same (in the case of pure nodes).
#jira UE-54807
Change 3963114 by Marc.Audy
Fix ensures/crash as a result of UClass expecting to be able to access the UPackage of CDOs via the GetOuterUPackage call.
Change 3963427 by Marc.Audy
Fix initialization order
Initialize bUseBackwardsCompatForEmptyAutogeneratedValue
Change 3963781 by Marc.Audy
Fix without editor compiles
Change 3964576 by Marc.Audy
PR #4599: : Working category for timelines (Contributed by projectgheist)
#jira UE-56460
#jira UE-26053
Change 3964782 by Dan.Oconnor
Mirror 3964772 from Release 4.19
Fix crash when force deleting certain blueprints, we can only check for authoritativeness while reinstancing
#jira UE-56447
Change 3965156 by Mieszko.Zielinski
PR #4592: Visual Logger optimization to fix rapid FPS drop when many items are hidden (Contributed by tstaples)
#jira UE-56435
Change 3965173 by Marc.Audy
(4.19.1) Fix incorrectly switching a cooling down tick to be an enabled tick when marking it enabled.
#jira UE-56431
Change 3966117 by Marc.Audy
Fix select nodes inside macros using wildcard array inputs having issues resolving type.
#jira UE-56484
Change 3878901 by Mieszko.Zielinski
NavigationSystem's code refactored out of the engine and into a new separate module #UE4
The CL contains required changes to all of our internal projects. Fortnite and Paragon have been tested, while the rest have been only compiled.
Change 3879409 by Mieszko.Zielinski
Further fallout fixes after ripping out NavigationSystem out of the engine #UE4
- Fixed bad ini redirects (had NavigationSystem.NavigationSystem instead of NavigationSystem.NavigationSystemV1)
- Added missing FNavigationSystem::GetDefaultNavDataClass binding (resulting in QAGame's func tests failing)
Change 3897655 by Ben.Zeigler
#jira UE-55211 Fix it so literal soft object pins on blueprint nodes get correctly cooked/referenced
It now sets the thread context to skip internal serialize and calls the archive's serialize function instead of bypassing it, which allows it to pick up references
Change 3962780 by Marc.Audy
When preventing a split pin from being orphaned, all sub pins must also be prevented.
#jira UE-56328
Repack members of UEdGraphPin to avoid wasted space (saves 16bytes)
[CL 3967553 by Marc Audy in Main branch]
2018-03-27 14:27:07 -04:00
for ( const FString & PackageFilename : PackageFilenames )
{
TArray < FString > RevisionName ;
RevisionName . Add ( PackageFilename ) ;
while ( RevisionName . Num ( ) ! = 0 )
{
int32 InitialNum = SourceControlStates . Num ( ) ;
SourceControlProvider . GetState ( RevisionName , SourceControlStates , EStateCacheUsage : : Use ) ;
int32 NewNum = SourceControlStates . Num ( ) ;
ensure ( NewNum > = InitialNum ) ;
RevisionName . Empty ( ) ;
// check to see if origin of this file is a branch, append the history from the branch point:
if ( NewNum > InitialNum )
{
int32 HistorySize = SourceControlStates . Last ( ) - > GetHistorySize ( ) ;
if ( HistorySize > 0 )
{
TSharedPtr < class ISourceControlRevision , ESPMode : : ThreadSafe > InitialHistory = SourceControlStates . Last ( ) - > GetHistoryItem ( HistorySize - 1 ) ;
TSharedPtr < ISourceControlRevision , ESPMode : : ThreadSafe > BranchSource = InitialHistory - > GetBranchSource ( ) ;
if ( BranchSource . IsValid ( ) )
{
RevisionName . Add ( BranchSource - > GetFilename ( ) ) ;
}
}
}
}
}
2014-03-14 14:13:41 -04:00
TSharedRef < SWindow > NewWindow = SNew ( SWindow )
. Title ( NSLOCTEXT ( " SourceControl.HistoryWindow " , " Title " , " File History " ) )
. SizingRule ( ESizingRule : : UserSized )
. AutoCenter ( EAutoCenter : : PreferredWorkArea )
. ClientSize ( FVector2D ( 700 , 400 ) ) ;
TSharedRef < SSourceControlHistoryWidget > SourceControlWidget =
SNew ( SSourceControlHistoryWidget )
. ParentWindow ( NewWindow )
. SourceControlStates ( SourceControlStates ) ;
NewWindow - > SetContent ( SourceControlWidget ) ;
TSharedPtr < SWindow > RootWindow = FGlobalTabmanager : : Get ( ) - > GetRootWindow ( ) ;
if ( RootWindow . IsValid ( ) )
{
FSlateApplication : : Get ( ) . AddWindowAsNativeChild ( NewWindow , RootWindow . ToSharedRef ( ) ) ;
}
else
{
FSlateApplication : : Get ( ) . AddWindow ( NewWindow ) ;
}
}
}