2016-01-07 08:17:16 -05:00
|
|
|
// Copyright 1998-2016 Epic Games, Inc. All Rights Reserved.
|
2014-11-19 07:43:07 -05:00
|
|
|
|
|
|
|
|
#include "LogVisualizer.h"
|
|
|
|
|
#include "SDockTab.h"
|
|
|
|
|
#include "VisualLogger/VisualLogger.h"
|
|
|
|
|
#include "VisualLoggerRenderingActor.h"
|
|
|
|
|
#include "VisualLoggerCanvasRenderer.h"
|
|
|
|
|
#include "DesktopPlatformModule.h"
|
|
|
|
|
#include "MainFrame.h"
|
2014-11-21 08:26:27 -05:00
|
|
|
#include "VisualLoggerCameraController.h"
|
2014-11-19 07:43:07 -05:00
|
|
|
#if WITH_EDITOR
|
|
|
|
|
# include "Editor/UnrealEd/Public/EditorComponents.h"
|
|
|
|
|
# include "Editor/UnrealEd/Public/EditorReimportHandler.h"
|
|
|
|
|
# include "Editor/UnrealEd/Public/TexAlignTools.h"
|
|
|
|
|
# include "Editor/UnrealEd/Public/TickableEditorObject.h"
|
|
|
|
|
# include "Editor/UnrealEd/Public/Editor.h"
|
|
|
|
|
# include "Editor/UnrealEd/Public/EditorViewportClient.h"
|
|
|
|
|
#endif
|
2014-12-01 08:40:47 -05:00
|
|
|
#include "ISettingsModule.h"
|
2014-11-19 07:43:07 -05:00
|
|
|
|
|
|
|
|
#include "VisualLogger/VisualLoggerBinaryFileDevice.h"
|
|
|
|
|
|
|
|
|
|
#define LOCTEXT_NAMESPACE "SVisualLogger"
|
|
|
|
|
|
2015-08-27 05:21:28 -04:00
|
|
|
DEFINE_LOG_CATEGORY_STATIC(LogVisualLogger, Log, All);
|
|
|
|
|
|
2014-11-19 07:43:07 -05:00
|
|
|
/* Local constants
|
|
|
|
|
*****************************************************************************/
|
|
|
|
|
static const FName ToolbarTabId("Toolbar");
|
|
|
|
|
static const FName FiltersTabId("Filters");
|
|
|
|
|
static const FName MainViewTabId("MainView");
|
|
|
|
|
static const FName LogsListTabId("LogsList");
|
|
|
|
|
static const FName StatusViewTabId("StatusView");
|
|
|
|
|
|
|
|
|
|
namespace LogVisualizer
|
|
|
|
|
{
|
|
|
|
|
static const FString LogFileDescription = LOCTEXT("FileTypeDescription", "Visual Log File").ToString();
|
2015-02-27 07:26:07 -05:00
|
|
|
static const FString LoadFileTypes = FString::Printf(TEXT("%s (*.bvlog;*.%s)|*.bvlog;*.%s"), *LogFileDescription, VISLOG_FILENAME_EXT, VISLOG_FILENAME_EXT);
|
2014-11-19 07:43:07 -05:00
|
|
|
static const FString SaveFileTypes = FString::Printf(TEXT("%s (*.%s)|*.%s"), *LogFileDescription, VISLOG_FILENAME_EXT, VISLOG_FILENAME_EXT);
|
|
|
|
|
}
|
|
|
|
|
|
2015-08-27 05:21:28 -04:00
|
|
|
DECLARE_DELEGATE_TwoParams(FOnWorldChanged, UWorld*, UWorld*);
|
2014-11-19 07:43:07 -05:00
|
|
|
|
|
|
|
|
/* SMessagingDebugger constructors
|
|
|
|
|
*****************************************************************************/
|
2015-08-27 05:21:28 -04:00
|
|
|
namespace
|
|
|
|
|
{
|
Copying //UE4/Dev-Framework to Dev-Main (//UE4/Dev-Main)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2720406 on 2015/10/07 by Aaron.McLeran
Audio optimization
Don't search for nearest listener if there's only 1 listener.
Change 2720411 on 2015/10/07 by Aaron.McLeran
Fixing HRTF spatialization code with recent changes to stereo spatialization.
HRTF emitter posiition doesn't need to be converted to XAudio2 coordinates.
Change 2723829 on 2015/10/09 by Mieszko.Zielinski
Fixed NavigationSystem trying to set label of newly spawned navigation data #UE4
UE-21880
Change 2723873 on 2015/10/09 by Mieszko.Zielinski
Fixed a bug in FNavAgentProperties::IsEquivalent resulting in failing the test for FNavAgentProperties instances having default AgentStepHeight value (-1) #UE4
UE-21977
Change 2724834 on 2015/10/12 by Ori.Cohen
PR #1634: Add PxVehicleDriveNW support to PhysXVehicleManager.cpp (Contributed by zeduk)
Change 2724850 on 2015/10/12 by Marc.Audy
Fix sound not restarting in matinee preview when jumping back along timeline after reaching end
#codereview Nick.Darnell
Change 2726499 on 2015/10/13 by Ori.Cohen
Fix edge case where sphyl length and radius are 0 and they are not properly clamped to 0.1
Change 2726689 on 2015/10/13 by Marc.Audy
Make UPackage::PackageFlags private
Add debugging for UE-21181 to try and track down when EditorWorld's PackageFlags are getting flagged as PlayInEditor
#codereview Mike.Fricker
Change 2726862 on 2015/10/13 by Lukasz.Furman
removed unused code from DetourNavMeshQuery
#ue4 UE-21988
Change 2726888 on 2015/10/13 by Lukasz.Furman
fixed observer abort: both mode in behavior tree's cone check decorator
#ue4 UE-19375
Change 2726913 on 2015/10/13 by Lukasz.Furman
navmesh raycast will use nearest poly containing ray origin instead of just closest one
#ue4 UE-19334
Change 2726920 on 2015/10/13 by Marc.Audy
Re-unify ULevelStreaming::GetWorldAssetPackageName and GetWorldAssetPackageFName
#codereview Dmitriy.Dyomin, Bob.Tellez
Change 2726931 on 2015/10/13 by Lukasz.Furman
fixed missing Tick event in aborting behavior tree tasks from abandoned subtree
#ue4 UE-21777
Change 2728093 on 2015/10/14 by Ori.Cohen
Fix edge case of sphyl scale take two. The previous approach did double scaling
Change 2728577 on 2015/10/14 by Mieszko.Zielinski
Improved navmesh labeling condition #UE4
Change suggested by github user
#rb Lukasz.Furman
Change 2728587 on 2015/10/14 by Lukasz.Furman
fixed crowd simulation for auto possessed pawns placed on level
#ue4
#rb Mieszko.Zielinski
Change 2728629 on 2015/10/14 by Lukasz.Furman
fixed influence of navmesh edges on crowd simulation near end of path
#ue4 UE-21380
#rb Mieszko.Zielinski
Change 2728678 on 2015/10/14 by Lukasz.Furman
added Z check to detour's crowd avoidance segment gathering
#ue4 UE-20889
#rb Mieszko.Zielinski
Change 2728745 on 2015/10/14 by Lukasz.Furman
fixed copy&paste operation in behavior tree's composite decorators subgraphs
#ue4 UE-18740
Change 2729276 on 2015/10/14 by Stan.Melax
ensure all actors get recreated with new collision shape specification.
this wasn't being done for a couple of editing methods.
todo: this should be merged into 4.10
#UE-20961
#rb ori.cohen
Change 2730709 on 2015/10/15 by Marc.Audy
Prevent memory corruption when an invalid controller ID is passed in to the forcefeedback channel functions
#rb Lina.Halper
Change 2733590 on 2015/10/19 by Benn.Gallagher
Fixed various crashes when using undo and redo while manipulating state machines UE 22088
Change 2735143 on 2015/10/20 by Lukasz.Furman
clearing behavior tree debugger's state when displayed subtree becomes inactive
#ue4
#rb Mieszko.Zielinski
Change 2735144 on 2015/10/20 by Lukasz.Furman
rebuilding behavior tree graph node order when node is being moved
#ue4
#rb Mieszko.Zielinski
Change 2735403 on 2015/10/20 by sebastian.kowalczyk
Integrated fix for issue UE-18594 "Gameplay Debugger is hijacking the Canvas" issue from 4.10 (2735391). Extended previous fix to care about OSX users - it's possible to configure shortcuts in engine config file now (little different ones for osx platform).
Change 2736406 on 2015/10/21 by sebastian.kowalczyk
Added new GameplayDebugger as a plugin. Old gameplay debugger is still here to keep backward compatibility but it's deprecated now. Current projects should be moved to use new plugin soon.
Change 2736436 on 2015/10/21 by sebastian.kowalczyk
Fixed crash in gameplay debugger with player set as debug target.
Change 2736437 on 2015/10/21 by sebastian.kowalczyk
Added visual indicator around selected pawn to fix FORT-10273 issue. (FN is not using new gd plugin yet).
Change 2736489 on 2015/10/21 by sebastian.kowalczyk
Hide internal and debug hud classes from drop down lists.
Change 2736504 on 2015/10/21 by sebastian.kowalczyk
Fix for UE-18548 "EnableGDT does not work correctly in PIE".
Change 2736529 on 2015/10/21 by sebastian.kowalczyk
Fixed UE-18548 "EnableGDT does not work correctly in PIE"
Change 2736588 on 2015/10/21 by sebastian.kowalczyk
Removed old log visualizer classes.
Change 2736700 on 2015/10/21 by sebastian.kowalczyk
Fixed UE-19256 "Perception debug data doesn't get replicated by Gameplay Debuger" for old gameplay debugger module.
Change 2737180 on 2015/10/21 by Zak.Middleton
#ue4 - Fix UPrimitiveComponent::GetCollisionShape not correctly enforcing bounds limits.
#rb Aaron.Mcleran
#jira UE-22436
Change 2738084 on 2015/10/22 by sebastian.kowalczyk
Better indication of selected pawn for Gameplay Debugger.
Change 2738413 on 2015/10/22 by Marc.Audy
Disable duplication of worlds/maps via the content browser
#jira UE-22200
#rb James.Golding
Change 2739743 on 2015/10/23 by bruce.nesbit
UE-18707 - Issue with drawing material triangle on canvas #1387
Added DrawTriangleUsingVertexColor
Change 2739751 on 2015/10/23 by bruce.nesbit
Revised bShowDebugForReticleTarget should not be static #1539
Change 2739788 on 2015/10/23 by bruce.nesbit
Revised the 2 functions that used FTriangleRenderer::DrawTriangle to use FTriangleRenderer::DrawTriangleUsingVertexColor
Fixed compile error
Change 2739870 on 2015/10/23 by Marc.Audy
Avoid issues while detaching child components if OnAttachmentChange were to remove a sibling component itself.
#jira UE-22362
#rb Zak.Middleton
Change 2739882 on 2015/10/23 by sebastian.kowalczyk
Fix for UE-20901 "VisualLog redirections are broken after PIE finishes" issue.
Change 2740140 on 2015/10/23 by Marc.Audy
Ensure that components reregister tick functions after seamless travel
#jira UE-20892
#rb Zak.Middleton
Change 2740614 on 2015/10/23 by Ori.Cohen
Fix linker issues for people wanting to use physics lock lambdas
Change 2740674 on 2015/10/23 by Aaron.McLeran
Sound Focus Feature
Added new parameters to SoundAttenuation settings to allow audio to change behavior based on its angle to the listener
- Define the min/max azimuth angle to establish in-focus and non-focus regions
- Can scale the priority of a sound based on focus angle
- Can attenuate the volume of a sound based on focus angle
- Can scale the listener-emitter distance based on focus angle
- Distance scale is applied when determining max audible distance for USoundBase
- Can opt-out of focus effects for a sound at the USoundBase level
#rb Ryan.Vance
Change 2741542 on 2015/10/26 by Lukasz.Furman
lowered min value clamping in navigation filter properties
#ue4
#rb Mieszko.Zielinski
Change 2743227 on 2015/10/27 by Marc.Audy
Make ASceneCaptureCube subclassable outside of Engine module
#jira UE-22609
Make USceneCaptureComponentCube::UpdateContent callable outside of Engine module
#jira UE-22610
#rb Jeff.Farris
Change 2743255 on 2015/10/27 by Marc.Audy
Wrap FActorSpawnParameters class with deprecation warning disable pragma instead of hand implementing copy constructor
#rb Jeff.Farris
Change 2743729 on 2015/10/27 by Ori.Cohen
Fix case where we spawn and adjust location which gives us implicit velocity.
#codereview Stan.Melax
Change 2746135 on 2015/10/29 by sebastian.kowalczyk
Fixed UE-21668 "Saving log filters selected in LogVisualizer causes insane ini file sizes! And doesn't really work."
Change 2746437 on 2015/10/29 by Lukasz.Furman
pass on verifying behavior tree stack before accessing its elements
#ue4
#rb Mieszko.Zielinski
Change 2748028 on 2015/10/30 by sebastian.kowalczyk
Changed GameplayDebugger's console variable from gd.EQSOnHUD to ai.gd.EQSOnHUD" after suggestion with MieszkoZ.
Change 2748184 on 2015/10/30 by Aaron.McLeran
UE-22693 Fix for streaming bug
- 3rd decoded buffer in initial 3 buffers was not getting submitted to xaudio2 voice resulting in garbled/skipped audio.
- Wasn't able to repro the 'cannot read chunk' part of the bug
#rb ryan.vance
Change 2749255 on 2015/10/31 by sebastian.kowalczyk
Fixed ai.gd.EQSOnHUD console variable after rename from gd.EQSOnHUD.
Change 2749276 on 2015/10/31 by sebastian.kowalczyk
Added switch to toggle highlight of selected actor to GameplayDebugger.
Change 2749318 on 2015/10/31 by sebastian.kowalczyk
New Gameplay Debugger plugin can be used with old module simultaneously. It's best to configure different keyboard binding for plugin when using old module (it can be set in project settings, for new gameplay debugger plugin - when activated for project).
Change 2749337 on 2015/10/31 by sebastian.kowalczyk
Fixed GameplayDebugger compilation in shipping/test builds.
Change 2749376 on 2015/10/31 by sebastian.kowalczyk
Small clean-up in gameplay debugger class for BT.
Change 2749931 on 2015/11/02 by James.Golding
Add stats to ProcMeshComp
Change 2749932 on 2015/11/02 by James.Golding
Remove PhysicsThrusterComponent.h from Engine.h
Change 2749960 on 2015/11/02 by James.Golding
- Fix PS4 compile errors in ActiveSound.cpp
- Constructor order of FActiveSound
- Shadowed AudioComponent var in CheckOcclusion
#RB thomas.sarkanen
#codereview aaron.mcleran
Change 2749961 on 2015/11/02 by James.Golding
Fix PS4 compile errors in GameplayDebuggerBaseObject.cpp
- Shadowed DefaultContext function param, now just Context, which matches declaration
#RB thomas.sarkanen
#codereview sebastian.kowalczyk
Change 2750026 on 2015/11/02 by Thomas.Sarkanen
Anim Multithreading: thread-safety refactor
Segregated access to various parts of anim update data by spitting off a new proxy class (FAnimInstanceProxy) containing all data accessed in Update() and Evaluate() passes. Gated access to the proxy data on the game thread in a number of ways:
- Explicit access via GetValueOnGameThread() - this blocks on any existing task, completes and then allows control to return to the accessing function. This allows stuff like Blueprints to continue to operate as normal.
- Explicit access via GetValueOnAnyThread() - this ensures that in the limited set of circumstances we need this (Blueprint pure functions mostly) that conditions are met about concurrent access.
- Deprecating many APIs on UAnimInstance that should not be used (and in fact are not used at present, happily).
Derived classes of UAnimInstance can override the creation of the proxy class to create their own type. We do this for UAnimSingleNodeInstance etc.
Any API deprecation should continue to function - no functions have been removed yet. The only things that are not backwards-compatible are direct access to some public member variables for which there is no way to support (e.g. via references, for example UngroupedActivePlayerArrays).
Some APIs have been changed to more specifically represent the dependencies involved. For example TickAssetPlayerInstance() used to take a UAnimInstance*, only to use it to simply queue notifies. This has been deprecated and replaced with a new FNotifyQueue API. FNotifyQueue also uses a thread-safe FRandomStream instead of FMath::Rand.
Many changes are due to substituting accessor functions for direct variable access.
Removed 'service' tick group as we no longer need to segregate the running of our parallel update.
Anim nodes that need to do some game thread-side update should register for a pre-update callback delegate in the proxy. See FAnimNode_AnimDynamics for an example of this.
Moved UpdateActiveVertexAnims into FAnimRuntime so I can subsume some of the code that was in USkeletalMeshComponent::EvaluateAnimation into UAnimInstance (and hence keep the proxy access private).
#rb Martin.Wilson,Lina.Halper
#codereview Michael.Noland
Change 2750077 on 2015/11/02 by Marc.Audy
Expose UInputComponent::BindAction that supports WithKey delegate signature
Change 2751767 on 2015/11/03 by Thomas.Sarkanen
Added extra support to Anim Blueprint 'fast-path'
Added support for negated bools (value gets negated during copy).
Added support for copying from struct members (via break struct) and split struct pins.
Removed potentially troublesome references to BP-constructed UProperties, replacing them with the property FName. This adds some extra Initialize() overhead, but prevents various crash-on load issues (one when generating the class CRC). Added guard to prevent multiple initialization to save this more expensive work being done more often.
#rb Martin.Wilson
Change 2752158 on 2015/11/03 by Jeff.Farris
Fixed UGameplayStatics::SpawnEmitterAttached() to register the ParticleSystemComponent after it spawns.
#rb marc.audy
Change 2752159 on 2015/11/03 by Jeff.Farris
Improvements to camera lens effects to (EmitterCameraLensEffectBase)
- can now specify a transform to align the emitter with the camera
- exposed several key parameters to Blueprints
- ENGINE_API now applies to the entire class
#rb marc.audy
Change 2753454 on 2015/11/04 by Thomas.Sarkanen
Fixup deprecation warnings fallout from multithreaded update changes.
Fixed up use of AnimInstance in Vicon plugin.
Fixed up use of AnimInstance in slope warping node.
Un-deprecated some APIs to become warning free (these APIs are safe to call but just a 'bad idea if you want to do it right').
Also an extra API to allow for smoother transition: Allow custom allocation/deallocation (including using a proxy member struct) by providing an override point for proxy destruction.
#rb Martin.Wilson
Change 2754099 on 2015/11/04 by Ori.Cohen
Fix for task threads dropping stats (from Gil)
#rb Gil.Gribb
Change 2754449 on 2015/11/04 by Marc.Audy
Ensure that components created from an Actor's blueprint BeginPlay implementation get BeginPlay called on them and register their component ticks
#jira UE-20853
Reorganize some booleans to get better bit packing
#rb Jeff.Farris
#codereview Mieszko.Zielinski
Change 2754573 on 2015/11/04 by Aaron.McLeran
Fixing audio component PostLoad code to not set all LowPassFilterFrequency values to 0.0f
Change 2755345 on 2015/11/05 by Thomas.Sarkanen
Added deprecated constructors for various animation contexts
Allows existing code to compile if it creates its own contexts from UAnimInstance.
#rb James.Golding
Change 2755348 on 2015/11/05 by James.Golding
Add BP-exposed SetBoundsScale function to PrimitiveComponent
#RB thomas.sarkanen
Change 2755437 on 2015/11/05 by Marc.Audy
Fix compile errors
#codereview Thomas.Sarkanen, Mieszko.Zielinski, Aaron.McLeran
Change 2755982 on 2015/11/05 by Marc.Audy
Move HeaderParse changes for deprecation macro from Core
Fix world settings warning
Change 2756028 on 2015/11/05 by Marc.Audy
Fix shadow variable issue
Change 2756090 on 2015/11/05 by Ori.Cohen
Improve budget tool so that task threads are computed automatically.
#rb Gil.Gribb
Change 2756120 on 2015/11/05 by Mieszko.Zielinski
Fixed AIController::MoveTo not using DefaultQueryExtent of its navigation data #UE4
#rb Lukasz.Furman
Change 2756243 on 2015/11/05 by Mieszko.Zielinski
Fixed AI perception sight's "auto-visibility" mechanism totally skipping distance and vision cone checks #UE4
The old way was resulting in false positives when for example observer teleported somewhere far
#rb Lukasz.Furman
#codereview John.Abercrombie
Change 2756280 on 2015/11/05 by Mieszko.Zielinski
Minor VLog code cleanup and dumb-fixing visual logger accessing timer manager off of game thread #UE4
#rb Lukasz.Furman
Change 2756500 on 2015/11/05 by Mieszko.Zielinski
Added sanity-checking to BlueprintNodeHelpers::HasBlueprintFunction and cleaned up its usage #UE4
Also, refactored its parameters into references over pointers.
#rb Lukasz.Furman
Change 2757041 on 2015/11/06 by Thomas.Sarkanen
Removed check() in UAnimInstance::GetProxyOnAnyThread()
The check was no longer needed as if we are on the game thread we block until tasks are completed below, and if we are on any other thread we are 'safe' anyway.
#rb James.Golding
Change 2757207 on 2015/11/06 by Ori.Cohen
Fix incorrect root body cache which causes a single frame "freak out" when simulating physics from an animation
#rb Lina.Halper
Change 2757238 on 2015/11/06 by Marc.Audy
Force compiler generated functions to be generated for FHierarchicalSimplification in WorldSettings.h so that they are generated while the deprecation warnings are disabled.
#rb Mike.Fricker
Change 2757284 on 2015/11/06 by Stan.Melax
tapered capsule drawing
cloth collision happens with spheres and for the hull or tapered capsule goemetry between any specified pair of spheres.
(this was already code reviewed before, but missed the check-in window before streamtime)
#rb ori.cohen
Change 2757743 on 2015/11/06 by Lukasz.Furman
fixed node memory allocations for injected behavior tree decorators
#ue4 UE-22783
#rb Mieszko.Zielinski
Change 2757772 on 2015/11/06 by Lukasz.Furman
added setters for crowd avoidance
#ue4 UE-22785
#rb Mieszko.Zielinski
Change 2758422 on 2015/11/07 by Lina.Halper
Potential fix for invalid root bone index input
#jira :/UE-23086
#code review: Ori.Cohen
Change 2758429 on 2015/11/07 by Mieszko.Zielinski
Reimplemented a fix for AI Sight's "auto seeing" mechanics in a more flexible way #UE4
#jira UE-23089
Change 2758571 on 2015/11/08 by Mieszko.Zielinski
Modified ensure condition in UAIPerceptionComponent::OnRegister so it doesn't go off when BP does it's magic when components are being added to a BP actor class #UE4
#jira UE-23080
Change 2758821 on 2015/11/09 by Thomas.Sarkanen
Fixed animations no longer playing when using a dedicated server.
Uses correct logic to determine whether we are running as a server or not.
#rb Martin.Wilson
Change 2758920 on 2015/11/09 by Marc.Audy
Don't dereference weak object pointers repeatedly in FBoneContainer::Initialize
#rb Lina.Halper
Change 2758944 on 2015/11/09 by Ori.Cohen
Fix crash when stats are only on one thread and budget mode is used
Change 2758967 on 2015/11/09 by Benn.Gallagher
Fix for crash undoing notify socket changes in Persona, needed to recache the notify track data after the transaction had reserialized the sequence.
#jira UE-22963
Change 2758973 on 2015/11/09 by Benn.Gallagher
Added new 'Random Player' node for anim graphs allowing the user to play a selection of animations in a random order with certain randomised paramers. Also allows 'Shuffle Mode' to act more like a playlist in that it will play everything on the list before repeating.
#rb Bruce.Nesbit
Change 2759219 on 2015/11/09 by Ori.Cohen
Character perf test is now looking at stats directly and sending to analytics
#RB Ben.Salem
Change 2759398 on 2015/11/09 by Lina.Halper
Fix issue where placed montages are not playing.
- the issue is that IsPlaying does not consider montage, but SetPlaying does. It is asymmetry, so I made it same. However, there are other functions that need to be re-looked at wr.t. montage
#code review: Thomas.Sarkanen
#RB: Marc.Audy
Change 2759491 on 2015/11/09 by Lina.Halper
#Anim: Fix not getting input correctly for Copy Pose node
#RB: Marc.Audy
Change 2759602 on 2015/11/09 by Marc.Audy
Fix imporperly named struct
Change 2759795 on 2015/11/09 by Aaron.McLeran
UE-23145 Adding a Priority value to USoundBase to use in concurrency evaluation and sorting wave instances for voice stealing.
#rb zak.middleton
Change 2760081 on 2015/11/09 by Aaron.McLeran
UE-23091 Adding more logging for NaN checks and fixing one source of NaNs for audio.
OmniDirectional Math Explanation:
For XAudio2, because we do our own distance-attenuation calculations, we use the X3dAudio2 API to simply compute a speaker-map for spatialization and force the listener to be at the origin and the emitter to be on the unit-circle. Thus, from XAudio2's perspective, all distances for every listener-emitter pair will be 1.0.
So in order to use the InnerRadius blending feature, we need to trick it into doing a an inner radius blend relative to a distance of 1.0. For example, if OmniRadius and Distance are the same, then the "NormalizedOmniRadius" is 1.0 and XAudio2 will begin its "blend" of the sound to an omni-directional speaker map.
If Emitter-listener distance is less than the OmniRadius, we'll want to do more blending to an omni-directional speaker map, but we need to set the InnerRadius to something greater than 1.0 (i.e. so that the normalized distance of 1.0 will be treated as less than the InnerRadius). To do "full" omni-directional blending, the emitter-listener distance will be 0 or close to zero, and the NormalizedOmniRadius will be very large (i.e. close to infiinity).
The previous math just set the NormalizedOmniRadius to FLT_MAX which is fine but that number is eventually squared before making the API call. FLT_MAX squared is INF.
Note: I do not think we need to square the OmniRadius in:
Emitter.InnerRadius = OmniRadius*OmniRadius;
But I am keeping it t here because of legacy content which depends on that behavior.
#rb zak.middleton
hange 2760401 on 2015/11/10 by Thomas.Sarkanen@Thomas.Sarkanen-Dev-Framework
Re-instated deleted protected functions in UAnimInstance.
Fixed access of UAnimInstance in FAnimNode_StateMachine.
#rb Martin.Wilson
Change 2760407 on 2015/11/10 by Jurre.deBaare
Construct raw meshes for spline meshes now uses the render data instead of original model data (preserves tangents/normals)
Change 2760468 on 2015/11/10 by Benn.Gallagher
Anim Dynamics optimizations, cached iteration independant data to reduce footprint of iteration on limits.
#rb Graeme.Thornton
Change 2760613 on 2015/11/10 by Jeff.Farris
Fixed async collision completion delegate potentially firing repeatedly. (UE-23149)
#cr marc.audy
#codereview lina.halper
Change 2760795 on 2015/11/10 by Marc.Audy
Don't compile in pointless AddReferencedObjects when with editoronly data not defined
Minor coding standard cleanup (NULL and auto)
Change 2760848 on 2015/11/10 by Benn.Gallagher
Fix to anim instance proxy to not rely on state machine initialization to bind native delegates as nested state machines are not guaranteed to be initialized. This was fixed in UAnimInstance originally but broken again by the proxy instance code.
#jira UE-23164
#rb Martin.Wilson
Change 2760866 on 2015/11/10 by Marc.Audy
Manage transient visualization components for camera component in the same way that sprite component for other actor components are
#rb Mike.Beach
Change 2760963 on 2015/11/10 by Marc.Audy
Since construction script can cause actors to be spawned don't use a ranged for to iterate
#jira UE-22639
#rb Jeff.Farris
#codereview Dmitriy.Dyomin
Change 2762297 on 2015/11/11 by James.Golding
UE-23086 Don't ensure in SetRootBodyIndex when Bodies array is empty (ie no physics state created)
#rb martin.wilson
#codereview ori.cohen, lina.halper
Change 2763566 on 2015/11/11 by Lina.Halper
FAnimNode_CopyPoseFromMesh::Evaluate - was accessing skeleton joint, not mesh joint.
#RB: Laurent.Delayen
Change 2763926 on 2015/11/12 by Thomas.Sarkanen
Fix anim notifies not firing from single anim instances
UE-23248 - Anim Notifies are not working for Animation Sequences
UE-23249 - Anim Notifies using Sound Cues do not work
#rb James.Golding
Change 2764039 on 2015/11/12 by Jurre.deBaare
Fix for issue with incorrect material indices after reducing a skeletal mesh with non LOD0 mesh as BaseLOD (OR-9243) #rb Lina.Halper
Change 2764307 on 2015/11/12 by Jurre.deBaare
VS2015 SSF library
Change 2764314 on 2015/11/12 by Stan.Melax
crashfix was putting bad bodies to sleep at start
Fatal error!
Unhandled Exception: EXCEPTION_ACCESS_VIOLATION reading address 0x00000000
UE4Editor-Engine.dll!USkeletalMeshComponent::InitArticulated() [...\\engine\\source\\runtime\\engine\\private\\skeletalmeshcomponentphysics.cpp:875]
On some skeletalmeshcomponent, some bodies aren't getting created correctly. Trying to force them to sleep was causing a crash - it expected instantiated physx bodies. Seems that all the rest of the code is able to tolerate bad bodies.
Added check to ensure physx body exists before trying to force it to sleep.
not sure if bad bodies are the norm or if this fix is just more "kicking the can down the road".
#codereview ori.cohen
Change 2764343 on 2015/11/12 by Jurre.deBaare
- Fixed crash when building a LOD with SubActors.Num < 2
- Force HLOD level slider is now always enabled, however won't show complete image if not all HLODs are build
- LODActor tree view item now scrolls into view if selected in the world
- Set bAllowCullDistanceVolume to false for LODActor's static mesh components by default
- Added 7zip files
- Fixed issue with WinINet complaining about http-request without 'http://' prefix
- Changed % reduced or original triangles display string, now uses float instead of int (for < 1% reductions)
- Override texture sizes and automatic texture bias
- Fixed issue with incorrect material merging, not picking up it required mesh-data during baking. Added extra conditions for rendering with mesh-data.
- Now incorporate static meshes with opague materials into HLOD merging
- Fixed issue with incorrect normals after merging meshes who's owning components had been negatively scaled
- Fixed issue with incorrect texture size being set from MergeActor window (was only changing .X component)
- Fixed issue with material merging when meshes with multiple LODs are merged, right now only merges LOD0's together if we are also merging the materials (otherwise, merge each LOD)
- Added ENUM for texture scaling/resizing type that has to be applied while merging the materials
- Added detail customization class for FMaterialProxySettings
#rb James.Golding
[CL 2765024 by Marc Audy in Main branch]
2015-11-12 18:11:48 -05:00
|
|
|
static UWorld* GetWorldForGivenObject(const UObject* Object)
|
2015-08-27 05:21:28 -04:00
|
|
|
{
|
|
|
|
|
UWorld* World = Object ? GEngine->GetWorldFromContextObject(Object, false) : nullptr;
|
|
|
|
|
#if WITH_EDITOR
|
|
|
|
|
UEditorEngine *EEngine = Cast<UEditorEngine>(GEngine);
|
|
|
|
|
if (GIsEditor && EEngine != nullptr && World == nullptr)
|
|
|
|
|
{
|
|
|
|
|
// lets use PlayWorld during PIE/Simulate and regular world from editor otherwise, to draw debug information
|
|
|
|
|
World = EEngine->PlayWorld != nullptr ? EEngine->PlayWorld : EEngine->GetEditorWorldContext().World();
|
|
|
|
|
}
|
2014-11-19 07:43:07 -05:00
|
|
|
|
2015-08-27 05:21:28 -04:00
|
|
|
#endif
|
|
|
|
|
if (!GIsEditor && World == nullptr)
|
|
|
|
|
{
|
|
|
|
|
World = GEngine->GetWorld();
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return World;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
SVisualLogger::SVisualLogger()
|
|
|
|
|
: SCompoundWidget(), CommandList(MakeShareable(new FUICommandList))
|
2014-11-19 07:43:07 -05:00
|
|
|
{
|
2015-02-24 09:19:13 -05:00
|
|
|
bPausedLogger = false;
|
2015-02-24 10:45:21 -05:00
|
|
|
bGotHistogramData = false;
|
2015-08-27 05:21:28 -04:00
|
|
|
|
|
|
|
|
class FVisualLoggerDevice : public FVisualLogDevice
|
|
|
|
|
{
|
|
|
|
|
public:
|
|
|
|
|
FVisualLoggerDevice(SVisualLogger* InVisualLogger, FOnWorldChanged OnWorldChangedDelegate) : VisualLoggerWidget(InVisualLogger), LastUsedWorld(nullptr), OnWorldChanged(OnWorldChangedDelegate) {}
|
|
|
|
|
|
2015-08-27 08:43:39 -04:00
|
|
|
virtual ~FVisualLoggerDevice(){}
|
Copying //UE4/Dev-Framework to Dev-Main (//UE4/Dev-Main)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2720406 on 2015/10/07 by Aaron.McLeran
Audio optimization
Don't search for nearest listener if there's only 1 listener.
Change 2720411 on 2015/10/07 by Aaron.McLeran
Fixing HRTF spatialization code with recent changes to stereo spatialization.
HRTF emitter posiition doesn't need to be converted to XAudio2 coordinates.
Change 2723829 on 2015/10/09 by Mieszko.Zielinski
Fixed NavigationSystem trying to set label of newly spawned navigation data #UE4
UE-21880
Change 2723873 on 2015/10/09 by Mieszko.Zielinski
Fixed a bug in FNavAgentProperties::IsEquivalent resulting in failing the test for FNavAgentProperties instances having default AgentStepHeight value (-1) #UE4
UE-21977
Change 2724834 on 2015/10/12 by Ori.Cohen
PR #1634: Add PxVehicleDriveNW support to PhysXVehicleManager.cpp (Contributed by zeduk)
Change 2724850 on 2015/10/12 by Marc.Audy
Fix sound not restarting in matinee preview when jumping back along timeline after reaching end
#codereview Nick.Darnell
Change 2726499 on 2015/10/13 by Ori.Cohen
Fix edge case where sphyl length and radius are 0 and they are not properly clamped to 0.1
Change 2726689 on 2015/10/13 by Marc.Audy
Make UPackage::PackageFlags private
Add debugging for UE-21181 to try and track down when EditorWorld's PackageFlags are getting flagged as PlayInEditor
#codereview Mike.Fricker
Change 2726862 on 2015/10/13 by Lukasz.Furman
removed unused code from DetourNavMeshQuery
#ue4 UE-21988
Change 2726888 on 2015/10/13 by Lukasz.Furman
fixed observer abort: both mode in behavior tree's cone check decorator
#ue4 UE-19375
Change 2726913 on 2015/10/13 by Lukasz.Furman
navmesh raycast will use nearest poly containing ray origin instead of just closest one
#ue4 UE-19334
Change 2726920 on 2015/10/13 by Marc.Audy
Re-unify ULevelStreaming::GetWorldAssetPackageName and GetWorldAssetPackageFName
#codereview Dmitriy.Dyomin, Bob.Tellez
Change 2726931 on 2015/10/13 by Lukasz.Furman
fixed missing Tick event in aborting behavior tree tasks from abandoned subtree
#ue4 UE-21777
Change 2728093 on 2015/10/14 by Ori.Cohen
Fix edge case of sphyl scale take two. The previous approach did double scaling
Change 2728577 on 2015/10/14 by Mieszko.Zielinski
Improved navmesh labeling condition #UE4
Change suggested by github user
#rb Lukasz.Furman
Change 2728587 on 2015/10/14 by Lukasz.Furman
fixed crowd simulation for auto possessed pawns placed on level
#ue4
#rb Mieszko.Zielinski
Change 2728629 on 2015/10/14 by Lukasz.Furman
fixed influence of navmesh edges on crowd simulation near end of path
#ue4 UE-21380
#rb Mieszko.Zielinski
Change 2728678 on 2015/10/14 by Lukasz.Furman
added Z check to detour's crowd avoidance segment gathering
#ue4 UE-20889
#rb Mieszko.Zielinski
Change 2728745 on 2015/10/14 by Lukasz.Furman
fixed copy&paste operation in behavior tree's composite decorators subgraphs
#ue4 UE-18740
Change 2729276 on 2015/10/14 by Stan.Melax
ensure all actors get recreated with new collision shape specification.
this wasn't being done for a couple of editing methods.
todo: this should be merged into 4.10
#UE-20961
#rb ori.cohen
Change 2730709 on 2015/10/15 by Marc.Audy
Prevent memory corruption when an invalid controller ID is passed in to the forcefeedback channel functions
#rb Lina.Halper
Change 2733590 on 2015/10/19 by Benn.Gallagher
Fixed various crashes when using undo and redo while manipulating state machines UE 22088
Change 2735143 on 2015/10/20 by Lukasz.Furman
clearing behavior tree debugger's state when displayed subtree becomes inactive
#ue4
#rb Mieszko.Zielinski
Change 2735144 on 2015/10/20 by Lukasz.Furman
rebuilding behavior tree graph node order when node is being moved
#ue4
#rb Mieszko.Zielinski
Change 2735403 on 2015/10/20 by sebastian.kowalczyk
Integrated fix for issue UE-18594 "Gameplay Debugger is hijacking the Canvas" issue from 4.10 (2735391). Extended previous fix to care about OSX users - it's possible to configure shortcuts in engine config file now (little different ones for osx platform).
Change 2736406 on 2015/10/21 by sebastian.kowalczyk
Added new GameplayDebugger as a plugin. Old gameplay debugger is still here to keep backward compatibility but it's deprecated now. Current projects should be moved to use new plugin soon.
Change 2736436 on 2015/10/21 by sebastian.kowalczyk
Fixed crash in gameplay debugger with player set as debug target.
Change 2736437 on 2015/10/21 by sebastian.kowalczyk
Added visual indicator around selected pawn to fix FORT-10273 issue. (FN is not using new gd plugin yet).
Change 2736489 on 2015/10/21 by sebastian.kowalczyk
Hide internal and debug hud classes from drop down lists.
Change 2736504 on 2015/10/21 by sebastian.kowalczyk
Fix for UE-18548 "EnableGDT does not work correctly in PIE".
Change 2736529 on 2015/10/21 by sebastian.kowalczyk
Fixed UE-18548 "EnableGDT does not work correctly in PIE"
Change 2736588 on 2015/10/21 by sebastian.kowalczyk
Removed old log visualizer classes.
Change 2736700 on 2015/10/21 by sebastian.kowalczyk
Fixed UE-19256 "Perception debug data doesn't get replicated by Gameplay Debuger" for old gameplay debugger module.
Change 2737180 on 2015/10/21 by Zak.Middleton
#ue4 - Fix UPrimitiveComponent::GetCollisionShape not correctly enforcing bounds limits.
#rb Aaron.Mcleran
#jira UE-22436
Change 2738084 on 2015/10/22 by sebastian.kowalczyk
Better indication of selected pawn for Gameplay Debugger.
Change 2738413 on 2015/10/22 by Marc.Audy
Disable duplication of worlds/maps via the content browser
#jira UE-22200
#rb James.Golding
Change 2739743 on 2015/10/23 by bruce.nesbit
UE-18707 - Issue with drawing material triangle on canvas #1387
Added DrawTriangleUsingVertexColor
Change 2739751 on 2015/10/23 by bruce.nesbit
Revised bShowDebugForReticleTarget should not be static #1539
Change 2739788 on 2015/10/23 by bruce.nesbit
Revised the 2 functions that used FTriangleRenderer::DrawTriangle to use FTriangleRenderer::DrawTriangleUsingVertexColor
Fixed compile error
Change 2739870 on 2015/10/23 by Marc.Audy
Avoid issues while detaching child components if OnAttachmentChange were to remove a sibling component itself.
#jira UE-22362
#rb Zak.Middleton
Change 2739882 on 2015/10/23 by sebastian.kowalczyk
Fix for UE-20901 "VisualLog redirections are broken after PIE finishes" issue.
Change 2740140 on 2015/10/23 by Marc.Audy
Ensure that components reregister tick functions after seamless travel
#jira UE-20892
#rb Zak.Middleton
Change 2740614 on 2015/10/23 by Ori.Cohen
Fix linker issues for people wanting to use physics lock lambdas
Change 2740674 on 2015/10/23 by Aaron.McLeran
Sound Focus Feature
Added new parameters to SoundAttenuation settings to allow audio to change behavior based on its angle to the listener
- Define the min/max azimuth angle to establish in-focus and non-focus regions
- Can scale the priority of a sound based on focus angle
- Can attenuate the volume of a sound based on focus angle
- Can scale the listener-emitter distance based on focus angle
- Distance scale is applied when determining max audible distance for USoundBase
- Can opt-out of focus effects for a sound at the USoundBase level
#rb Ryan.Vance
Change 2741542 on 2015/10/26 by Lukasz.Furman
lowered min value clamping in navigation filter properties
#ue4
#rb Mieszko.Zielinski
Change 2743227 on 2015/10/27 by Marc.Audy
Make ASceneCaptureCube subclassable outside of Engine module
#jira UE-22609
Make USceneCaptureComponentCube::UpdateContent callable outside of Engine module
#jira UE-22610
#rb Jeff.Farris
Change 2743255 on 2015/10/27 by Marc.Audy
Wrap FActorSpawnParameters class with deprecation warning disable pragma instead of hand implementing copy constructor
#rb Jeff.Farris
Change 2743729 on 2015/10/27 by Ori.Cohen
Fix case where we spawn and adjust location which gives us implicit velocity.
#codereview Stan.Melax
Change 2746135 on 2015/10/29 by sebastian.kowalczyk
Fixed UE-21668 "Saving log filters selected in LogVisualizer causes insane ini file sizes! And doesn't really work."
Change 2746437 on 2015/10/29 by Lukasz.Furman
pass on verifying behavior tree stack before accessing its elements
#ue4
#rb Mieszko.Zielinski
Change 2748028 on 2015/10/30 by sebastian.kowalczyk
Changed GameplayDebugger's console variable from gd.EQSOnHUD to ai.gd.EQSOnHUD" after suggestion with MieszkoZ.
Change 2748184 on 2015/10/30 by Aaron.McLeran
UE-22693 Fix for streaming bug
- 3rd decoded buffer in initial 3 buffers was not getting submitted to xaudio2 voice resulting in garbled/skipped audio.
- Wasn't able to repro the 'cannot read chunk' part of the bug
#rb ryan.vance
Change 2749255 on 2015/10/31 by sebastian.kowalczyk
Fixed ai.gd.EQSOnHUD console variable after rename from gd.EQSOnHUD.
Change 2749276 on 2015/10/31 by sebastian.kowalczyk
Added switch to toggle highlight of selected actor to GameplayDebugger.
Change 2749318 on 2015/10/31 by sebastian.kowalczyk
New Gameplay Debugger plugin can be used with old module simultaneously. It's best to configure different keyboard binding for plugin when using old module (it can be set in project settings, for new gameplay debugger plugin - when activated for project).
Change 2749337 on 2015/10/31 by sebastian.kowalczyk
Fixed GameplayDebugger compilation in shipping/test builds.
Change 2749376 on 2015/10/31 by sebastian.kowalczyk
Small clean-up in gameplay debugger class for BT.
Change 2749931 on 2015/11/02 by James.Golding
Add stats to ProcMeshComp
Change 2749932 on 2015/11/02 by James.Golding
Remove PhysicsThrusterComponent.h from Engine.h
Change 2749960 on 2015/11/02 by James.Golding
- Fix PS4 compile errors in ActiveSound.cpp
- Constructor order of FActiveSound
- Shadowed AudioComponent var in CheckOcclusion
#RB thomas.sarkanen
#codereview aaron.mcleran
Change 2749961 on 2015/11/02 by James.Golding
Fix PS4 compile errors in GameplayDebuggerBaseObject.cpp
- Shadowed DefaultContext function param, now just Context, which matches declaration
#RB thomas.sarkanen
#codereview sebastian.kowalczyk
Change 2750026 on 2015/11/02 by Thomas.Sarkanen
Anim Multithreading: thread-safety refactor
Segregated access to various parts of anim update data by spitting off a new proxy class (FAnimInstanceProxy) containing all data accessed in Update() and Evaluate() passes. Gated access to the proxy data on the game thread in a number of ways:
- Explicit access via GetValueOnGameThread() - this blocks on any existing task, completes and then allows control to return to the accessing function. This allows stuff like Blueprints to continue to operate as normal.
- Explicit access via GetValueOnAnyThread() - this ensures that in the limited set of circumstances we need this (Blueprint pure functions mostly) that conditions are met about concurrent access.
- Deprecating many APIs on UAnimInstance that should not be used (and in fact are not used at present, happily).
Derived classes of UAnimInstance can override the creation of the proxy class to create their own type. We do this for UAnimSingleNodeInstance etc.
Any API deprecation should continue to function - no functions have been removed yet. The only things that are not backwards-compatible are direct access to some public member variables for which there is no way to support (e.g. via references, for example UngroupedActivePlayerArrays).
Some APIs have been changed to more specifically represent the dependencies involved. For example TickAssetPlayerInstance() used to take a UAnimInstance*, only to use it to simply queue notifies. This has been deprecated and replaced with a new FNotifyQueue API. FNotifyQueue also uses a thread-safe FRandomStream instead of FMath::Rand.
Many changes are due to substituting accessor functions for direct variable access.
Removed 'service' tick group as we no longer need to segregate the running of our parallel update.
Anim nodes that need to do some game thread-side update should register for a pre-update callback delegate in the proxy. See FAnimNode_AnimDynamics for an example of this.
Moved UpdateActiveVertexAnims into FAnimRuntime so I can subsume some of the code that was in USkeletalMeshComponent::EvaluateAnimation into UAnimInstance (and hence keep the proxy access private).
#rb Martin.Wilson,Lina.Halper
#codereview Michael.Noland
Change 2750077 on 2015/11/02 by Marc.Audy
Expose UInputComponent::BindAction that supports WithKey delegate signature
Change 2751767 on 2015/11/03 by Thomas.Sarkanen
Added extra support to Anim Blueprint 'fast-path'
Added support for negated bools (value gets negated during copy).
Added support for copying from struct members (via break struct) and split struct pins.
Removed potentially troublesome references to BP-constructed UProperties, replacing them with the property FName. This adds some extra Initialize() overhead, but prevents various crash-on load issues (one when generating the class CRC). Added guard to prevent multiple initialization to save this more expensive work being done more often.
#rb Martin.Wilson
Change 2752158 on 2015/11/03 by Jeff.Farris
Fixed UGameplayStatics::SpawnEmitterAttached() to register the ParticleSystemComponent after it spawns.
#rb marc.audy
Change 2752159 on 2015/11/03 by Jeff.Farris
Improvements to camera lens effects to (EmitterCameraLensEffectBase)
- can now specify a transform to align the emitter with the camera
- exposed several key parameters to Blueprints
- ENGINE_API now applies to the entire class
#rb marc.audy
Change 2753454 on 2015/11/04 by Thomas.Sarkanen
Fixup deprecation warnings fallout from multithreaded update changes.
Fixed up use of AnimInstance in Vicon plugin.
Fixed up use of AnimInstance in slope warping node.
Un-deprecated some APIs to become warning free (these APIs are safe to call but just a 'bad idea if you want to do it right').
Also an extra API to allow for smoother transition: Allow custom allocation/deallocation (including using a proxy member struct) by providing an override point for proxy destruction.
#rb Martin.Wilson
Change 2754099 on 2015/11/04 by Ori.Cohen
Fix for task threads dropping stats (from Gil)
#rb Gil.Gribb
Change 2754449 on 2015/11/04 by Marc.Audy
Ensure that components created from an Actor's blueprint BeginPlay implementation get BeginPlay called on them and register their component ticks
#jira UE-20853
Reorganize some booleans to get better bit packing
#rb Jeff.Farris
#codereview Mieszko.Zielinski
Change 2754573 on 2015/11/04 by Aaron.McLeran
Fixing audio component PostLoad code to not set all LowPassFilterFrequency values to 0.0f
Change 2755345 on 2015/11/05 by Thomas.Sarkanen
Added deprecated constructors for various animation contexts
Allows existing code to compile if it creates its own contexts from UAnimInstance.
#rb James.Golding
Change 2755348 on 2015/11/05 by James.Golding
Add BP-exposed SetBoundsScale function to PrimitiveComponent
#RB thomas.sarkanen
Change 2755437 on 2015/11/05 by Marc.Audy
Fix compile errors
#codereview Thomas.Sarkanen, Mieszko.Zielinski, Aaron.McLeran
Change 2755982 on 2015/11/05 by Marc.Audy
Move HeaderParse changes for deprecation macro from Core
Fix world settings warning
Change 2756028 on 2015/11/05 by Marc.Audy
Fix shadow variable issue
Change 2756090 on 2015/11/05 by Ori.Cohen
Improve budget tool so that task threads are computed automatically.
#rb Gil.Gribb
Change 2756120 on 2015/11/05 by Mieszko.Zielinski
Fixed AIController::MoveTo not using DefaultQueryExtent of its navigation data #UE4
#rb Lukasz.Furman
Change 2756243 on 2015/11/05 by Mieszko.Zielinski
Fixed AI perception sight's "auto-visibility" mechanism totally skipping distance and vision cone checks #UE4
The old way was resulting in false positives when for example observer teleported somewhere far
#rb Lukasz.Furman
#codereview John.Abercrombie
Change 2756280 on 2015/11/05 by Mieszko.Zielinski
Minor VLog code cleanup and dumb-fixing visual logger accessing timer manager off of game thread #UE4
#rb Lukasz.Furman
Change 2756500 on 2015/11/05 by Mieszko.Zielinski
Added sanity-checking to BlueprintNodeHelpers::HasBlueprintFunction and cleaned up its usage #UE4
Also, refactored its parameters into references over pointers.
#rb Lukasz.Furman
Change 2757041 on 2015/11/06 by Thomas.Sarkanen
Removed check() in UAnimInstance::GetProxyOnAnyThread()
The check was no longer needed as if we are on the game thread we block until tasks are completed below, and if we are on any other thread we are 'safe' anyway.
#rb James.Golding
Change 2757207 on 2015/11/06 by Ori.Cohen
Fix incorrect root body cache which causes a single frame "freak out" when simulating physics from an animation
#rb Lina.Halper
Change 2757238 on 2015/11/06 by Marc.Audy
Force compiler generated functions to be generated for FHierarchicalSimplification in WorldSettings.h so that they are generated while the deprecation warnings are disabled.
#rb Mike.Fricker
Change 2757284 on 2015/11/06 by Stan.Melax
tapered capsule drawing
cloth collision happens with spheres and for the hull or tapered capsule goemetry between any specified pair of spheres.
(this was already code reviewed before, but missed the check-in window before streamtime)
#rb ori.cohen
Change 2757743 on 2015/11/06 by Lukasz.Furman
fixed node memory allocations for injected behavior tree decorators
#ue4 UE-22783
#rb Mieszko.Zielinski
Change 2757772 on 2015/11/06 by Lukasz.Furman
added setters for crowd avoidance
#ue4 UE-22785
#rb Mieszko.Zielinski
Change 2758422 on 2015/11/07 by Lina.Halper
Potential fix for invalid root bone index input
#jira :/UE-23086
#code review: Ori.Cohen
Change 2758429 on 2015/11/07 by Mieszko.Zielinski
Reimplemented a fix for AI Sight's "auto seeing" mechanics in a more flexible way #UE4
#jira UE-23089
Change 2758571 on 2015/11/08 by Mieszko.Zielinski
Modified ensure condition in UAIPerceptionComponent::OnRegister so it doesn't go off when BP does it's magic when components are being added to a BP actor class #UE4
#jira UE-23080
Change 2758821 on 2015/11/09 by Thomas.Sarkanen
Fixed animations no longer playing when using a dedicated server.
Uses correct logic to determine whether we are running as a server or not.
#rb Martin.Wilson
Change 2758920 on 2015/11/09 by Marc.Audy
Don't dereference weak object pointers repeatedly in FBoneContainer::Initialize
#rb Lina.Halper
Change 2758944 on 2015/11/09 by Ori.Cohen
Fix crash when stats are only on one thread and budget mode is used
Change 2758967 on 2015/11/09 by Benn.Gallagher
Fix for crash undoing notify socket changes in Persona, needed to recache the notify track data after the transaction had reserialized the sequence.
#jira UE-22963
Change 2758973 on 2015/11/09 by Benn.Gallagher
Added new 'Random Player' node for anim graphs allowing the user to play a selection of animations in a random order with certain randomised paramers. Also allows 'Shuffle Mode' to act more like a playlist in that it will play everything on the list before repeating.
#rb Bruce.Nesbit
Change 2759219 on 2015/11/09 by Ori.Cohen
Character perf test is now looking at stats directly and sending to analytics
#RB Ben.Salem
Change 2759398 on 2015/11/09 by Lina.Halper
Fix issue where placed montages are not playing.
- the issue is that IsPlaying does not consider montage, but SetPlaying does. It is asymmetry, so I made it same. However, there are other functions that need to be re-looked at wr.t. montage
#code review: Thomas.Sarkanen
#RB: Marc.Audy
Change 2759491 on 2015/11/09 by Lina.Halper
#Anim: Fix not getting input correctly for Copy Pose node
#RB: Marc.Audy
Change 2759602 on 2015/11/09 by Marc.Audy
Fix imporperly named struct
Change 2759795 on 2015/11/09 by Aaron.McLeran
UE-23145 Adding a Priority value to USoundBase to use in concurrency evaluation and sorting wave instances for voice stealing.
#rb zak.middleton
Change 2760081 on 2015/11/09 by Aaron.McLeran
UE-23091 Adding more logging for NaN checks and fixing one source of NaNs for audio.
OmniDirectional Math Explanation:
For XAudio2, because we do our own distance-attenuation calculations, we use the X3dAudio2 API to simply compute a speaker-map for spatialization and force the listener to be at the origin and the emitter to be on the unit-circle. Thus, from XAudio2's perspective, all distances for every listener-emitter pair will be 1.0.
So in order to use the InnerRadius blending feature, we need to trick it into doing a an inner radius blend relative to a distance of 1.0. For example, if OmniRadius and Distance are the same, then the "NormalizedOmniRadius" is 1.0 and XAudio2 will begin its "blend" of the sound to an omni-directional speaker map.
If Emitter-listener distance is less than the OmniRadius, we'll want to do more blending to an omni-directional speaker map, but we need to set the InnerRadius to something greater than 1.0 (i.e. so that the normalized distance of 1.0 will be treated as less than the InnerRadius). To do "full" omni-directional blending, the emitter-listener distance will be 0 or close to zero, and the NormalizedOmniRadius will be very large (i.e. close to infiinity).
The previous math just set the NormalizedOmniRadius to FLT_MAX which is fine but that number is eventually squared before making the API call. FLT_MAX squared is INF.
Note: I do not think we need to square the OmniRadius in:
Emitter.InnerRadius = OmniRadius*OmniRadius;
But I am keeping it t here because of legacy content which depends on that behavior.
#rb zak.middleton
hange 2760401 on 2015/11/10 by Thomas.Sarkanen@Thomas.Sarkanen-Dev-Framework
Re-instated deleted protected functions in UAnimInstance.
Fixed access of UAnimInstance in FAnimNode_StateMachine.
#rb Martin.Wilson
Change 2760407 on 2015/11/10 by Jurre.deBaare
Construct raw meshes for spline meshes now uses the render data instead of original model data (preserves tangents/normals)
Change 2760468 on 2015/11/10 by Benn.Gallagher
Anim Dynamics optimizations, cached iteration independant data to reduce footprint of iteration on limits.
#rb Graeme.Thornton
Change 2760613 on 2015/11/10 by Jeff.Farris
Fixed async collision completion delegate potentially firing repeatedly. (UE-23149)
#cr marc.audy
#codereview lina.halper
Change 2760795 on 2015/11/10 by Marc.Audy
Don't compile in pointless AddReferencedObjects when with editoronly data not defined
Minor coding standard cleanup (NULL and auto)
Change 2760848 on 2015/11/10 by Benn.Gallagher
Fix to anim instance proxy to not rely on state machine initialization to bind native delegates as nested state machines are not guaranteed to be initialized. This was fixed in UAnimInstance originally but broken again by the proxy instance code.
#jira UE-23164
#rb Martin.Wilson
Change 2760866 on 2015/11/10 by Marc.Audy
Manage transient visualization components for camera component in the same way that sprite component for other actor components are
#rb Mike.Beach
Change 2760963 on 2015/11/10 by Marc.Audy
Since construction script can cause actors to be spawned don't use a ranged for to iterate
#jira UE-22639
#rb Jeff.Farris
#codereview Dmitriy.Dyomin
Change 2762297 on 2015/11/11 by James.Golding
UE-23086 Don't ensure in SetRootBodyIndex when Bodies array is empty (ie no physics state created)
#rb martin.wilson
#codereview ori.cohen, lina.halper
Change 2763566 on 2015/11/11 by Lina.Halper
FAnimNode_CopyPoseFromMesh::Evaluate - was accessing skeleton joint, not mesh joint.
#RB: Laurent.Delayen
Change 2763926 on 2015/11/12 by Thomas.Sarkanen
Fix anim notifies not firing from single anim instances
UE-23248 - Anim Notifies are not working for Animation Sequences
UE-23249 - Anim Notifies using Sound Cues do not work
#rb James.Golding
Change 2764039 on 2015/11/12 by Jurre.deBaare
Fix for issue with incorrect material indices after reducing a skeletal mesh with non LOD0 mesh as BaseLOD (OR-9243) #rb Lina.Halper
Change 2764307 on 2015/11/12 by Jurre.deBaare
VS2015 SSF library
Change 2764314 on 2015/11/12 by Stan.Melax
crashfix was putting bad bodies to sleep at start
Fatal error!
Unhandled Exception: EXCEPTION_ACCESS_VIOLATION reading address 0x00000000
UE4Editor-Engine.dll!USkeletalMeshComponent::InitArticulated() [...\\engine\\source\\runtime\\engine\\private\\skeletalmeshcomponentphysics.cpp:875]
On some skeletalmeshcomponent, some bodies aren't getting created correctly. Trying to force them to sleep was causing a crash - it expected instantiated physx bodies. Seems that all the rest of the code is able to tolerate bad bodies.
Added check to ensure physx body exists before trying to force it to sleep.
not sure if bad bodies are the norm or if this fix is just more "kicking the can down the road".
#codereview ori.cohen
Change 2764343 on 2015/11/12 by Jurre.deBaare
- Fixed crash when building a LOD with SubActors.Num < 2
- Force HLOD level slider is now always enabled, however won't show complete image if not all HLODs are build
- LODActor tree view item now scrolls into view if selected in the world
- Set bAllowCullDistanceVolume to false for LODActor's static mesh components by default
- Added 7zip files
- Fixed issue with WinINet complaining about http-request without 'http://' prefix
- Changed % reduced or original triangles display string, now uses float instead of int (for < 1% reductions)
- Override texture sizes and automatic texture bias
- Fixed issue with incorrect material merging, not picking up it required mesh-data during baking. Added extra conditions for rendering with mesh-data.
- Now incorporate static meshes with opague materials into HLOD merging
- Fixed issue with incorrect normals after merging meshes who's owning components had been negatively scaled
- Fixed issue with incorrect texture size being set from MergeActor window (was only changing .X component)
- Fixed issue with material merging when meshes with multiple LODs are merged, right now only merges LOD0's together if we are also merging the materials (otherwise, merge each LOD)
- Added ENUM for texture scaling/resizing type that has to be applied while merging the materials
- Added detail customization class for FMaterialProxySettings
#rb James.Golding
[CL 2765024 by Marc Audy in Main branch]
2015-11-12 18:11:48 -05:00
|
|
|
virtual void Serialize(const UObject* LogOwner, FName OwnerName, FName OwnerClassName, const FVisualLogEntry& LogEntry) override
|
2015-08-27 05:21:28 -04:00
|
|
|
{
|
|
|
|
|
VisualLoggerWidget->OnNewLogEntry(FVisualLogDevice::FVisualLogEntryItem(OwnerName, OwnerClassName, LogEntry));
|
Copying //UE4/Dev-Framework to Dev-Main (//UE4/Dev-Main)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2720406 on 2015/10/07 by Aaron.McLeran
Audio optimization
Don't search for nearest listener if there's only 1 listener.
Change 2720411 on 2015/10/07 by Aaron.McLeran
Fixing HRTF spatialization code with recent changes to stereo spatialization.
HRTF emitter posiition doesn't need to be converted to XAudio2 coordinates.
Change 2723829 on 2015/10/09 by Mieszko.Zielinski
Fixed NavigationSystem trying to set label of newly spawned navigation data #UE4
UE-21880
Change 2723873 on 2015/10/09 by Mieszko.Zielinski
Fixed a bug in FNavAgentProperties::IsEquivalent resulting in failing the test for FNavAgentProperties instances having default AgentStepHeight value (-1) #UE4
UE-21977
Change 2724834 on 2015/10/12 by Ori.Cohen
PR #1634: Add PxVehicleDriveNW support to PhysXVehicleManager.cpp (Contributed by zeduk)
Change 2724850 on 2015/10/12 by Marc.Audy
Fix sound not restarting in matinee preview when jumping back along timeline after reaching end
#codereview Nick.Darnell
Change 2726499 on 2015/10/13 by Ori.Cohen
Fix edge case where sphyl length and radius are 0 and they are not properly clamped to 0.1
Change 2726689 on 2015/10/13 by Marc.Audy
Make UPackage::PackageFlags private
Add debugging for UE-21181 to try and track down when EditorWorld's PackageFlags are getting flagged as PlayInEditor
#codereview Mike.Fricker
Change 2726862 on 2015/10/13 by Lukasz.Furman
removed unused code from DetourNavMeshQuery
#ue4 UE-21988
Change 2726888 on 2015/10/13 by Lukasz.Furman
fixed observer abort: both mode in behavior tree's cone check decorator
#ue4 UE-19375
Change 2726913 on 2015/10/13 by Lukasz.Furman
navmesh raycast will use nearest poly containing ray origin instead of just closest one
#ue4 UE-19334
Change 2726920 on 2015/10/13 by Marc.Audy
Re-unify ULevelStreaming::GetWorldAssetPackageName and GetWorldAssetPackageFName
#codereview Dmitriy.Dyomin, Bob.Tellez
Change 2726931 on 2015/10/13 by Lukasz.Furman
fixed missing Tick event in aborting behavior tree tasks from abandoned subtree
#ue4 UE-21777
Change 2728093 on 2015/10/14 by Ori.Cohen
Fix edge case of sphyl scale take two. The previous approach did double scaling
Change 2728577 on 2015/10/14 by Mieszko.Zielinski
Improved navmesh labeling condition #UE4
Change suggested by github user
#rb Lukasz.Furman
Change 2728587 on 2015/10/14 by Lukasz.Furman
fixed crowd simulation for auto possessed pawns placed on level
#ue4
#rb Mieszko.Zielinski
Change 2728629 on 2015/10/14 by Lukasz.Furman
fixed influence of navmesh edges on crowd simulation near end of path
#ue4 UE-21380
#rb Mieszko.Zielinski
Change 2728678 on 2015/10/14 by Lukasz.Furman
added Z check to detour's crowd avoidance segment gathering
#ue4 UE-20889
#rb Mieszko.Zielinski
Change 2728745 on 2015/10/14 by Lukasz.Furman
fixed copy&paste operation in behavior tree's composite decorators subgraphs
#ue4 UE-18740
Change 2729276 on 2015/10/14 by Stan.Melax
ensure all actors get recreated with new collision shape specification.
this wasn't being done for a couple of editing methods.
todo: this should be merged into 4.10
#UE-20961
#rb ori.cohen
Change 2730709 on 2015/10/15 by Marc.Audy
Prevent memory corruption when an invalid controller ID is passed in to the forcefeedback channel functions
#rb Lina.Halper
Change 2733590 on 2015/10/19 by Benn.Gallagher
Fixed various crashes when using undo and redo while manipulating state machines UE 22088
Change 2735143 on 2015/10/20 by Lukasz.Furman
clearing behavior tree debugger's state when displayed subtree becomes inactive
#ue4
#rb Mieszko.Zielinski
Change 2735144 on 2015/10/20 by Lukasz.Furman
rebuilding behavior tree graph node order when node is being moved
#ue4
#rb Mieszko.Zielinski
Change 2735403 on 2015/10/20 by sebastian.kowalczyk
Integrated fix for issue UE-18594 "Gameplay Debugger is hijacking the Canvas" issue from 4.10 (2735391). Extended previous fix to care about OSX users - it's possible to configure shortcuts in engine config file now (little different ones for osx platform).
Change 2736406 on 2015/10/21 by sebastian.kowalczyk
Added new GameplayDebugger as a plugin. Old gameplay debugger is still here to keep backward compatibility but it's deprecated now. Current projects should be moved to use new plugin soon.
Change 2736436 on 2015/10/21 by sebastian.kowalczyk
Fixed crash in gameplay debugger with player set as debug target.
Change 2736437 on 2015/10/21 by sebastian.kowalczyk
Added visual indicator around selected pawn to fix FORT-10273 issue. (FN is not using new gd plugin yet).
Change 2736489 on 2015/10/21 by sebastian.kowalczyk
Hide internal and debug hud classes from drop down lists.
Change 2736504 on 2015/10/21 by sebastian.kowalczyk
Fix for UE-18548 "EnableGDT does not work correctly in PIE".
Change 2736529 on 2015/10/21 by sebastian.kowalczyk
Fixed UE-18548 "EnableGDT does not work correctly in PIE"
Change 2736588 on 2015/10/21 by sebastian.kowalczyk
Removed old log visualizer classes.
Change 2736700 on 2015/10/21 by sebastian.kowalczyk
Fixed UE-19256 "Perception debug data doesn't get replicated by Gameplay Debuger" for old gameplay debugger module.
Change 2737180 on 2015/10/21 by Zak.Middleton
#ue4 - Fix UPrimitiveComponent::GetCollisionShape not correctly enforcing bounds limits.
#rb Aaron.Mcleran
#jira UE-22436
Change 2738084 on 2015/10/22 by sebastian.kowalczyk
Better indication of selected pawn for Gameplay Debugger.
Change 2738413 on 2015/10/22 by Marc.Audy
Disable duplication of worlds/maps via the content browser
#jira UE-22200
#rb James.Golding
Change 2739743 on 2015/10/23 by bruce.nesbit
UE-18707 - Issue with drawing material triangle on canvas #1387
Added DrawTriangleUsingVertexColor
Change 2739751 on 2015/10/23 by bruce.nesbit
Revised bShowDebugForReticleTarget should not be static #1539
Change 2739788 on 2015/10/23 by bruce.nesbit
Revised the 2 functions that used FTriangleRenderer::DrawTriangle to use FTriangleRenderer::DrawTriangleUsingVertexColor
Fixed compile error
Change 2739870 on 2015/10/23 by Marc.Audy
Avoid issues while detaching child components if OnAttachmentChange were to remove a sibling component itself.
#jira UE-22362
#rb Zak.Middleton
Change 2739882 on 2015/10/23 by sebastian.kowalczyk
Fix for UE-20901 "VisualLog redirections are broken after PIE finishes" issue.
Change 2740140 on 2015/10/23 by Marc.Audy
Ensure that components reregister tick functions after seamless travel
#jira UE-20892
#rb Zak.Middleton
Change 2740614 on 2015/10/23 by Ori.Cohen
Fix linker issues for people wanting to use physics lock lambdas
Change 2740674 on 2015/10/23 by Aaron.McLeran
Sound Focus Feature
Added new parameters to SoundAttenuation settings to allow audio to change behavior based on its angle to the listener
- Define the min/max azimuth angle to establish in-focus and non-focus regions
- Can scale the priority of a sound based on focus angle
- Can attenuate the volume of a sound based on focus angle
- Can scale the listener-emitter distance based on focus angle
- Distance scale is applied when determining max audible distance for USoundBase
- Can opt-out of focus effects for a sound at the USoundBase level
#rb Ryan.Vance
Change 2741542 on 2015/10/26 by Lukasz.Furman
lowered min value clamping in navigation filter properties
#ue4
#rb Mieszko.Zielinski
Change 2743227 on 2015/10/27 by Marc.Audy
Make ASceneCaptureCube subclassable outside of Engine module
#jira UE-22609
Make USceneCaptureComponentCube::UpdateContent callable outside of Engine module
#jira UE-22610
#rb Jeff.Farris
Change 2743255 on 2015/10/27 by Marc.Audy
Wrap FActorSpawnParameters class with deprecation warning disable pragma instead of hand implementing copy constructor
#rb Jeff.Farris
Change 2743729 on 2015/10/27 by Ori.Cohen
Fix case where we spawn and adjust location which gives us implicit velocity.
#codereview Stan.Melax
Change 2746135 on 2015/10/29 by sebastian.kowalczyk
Fixed UE-21668 "Saving log filters selected in LogVisualizer causes insane ini file sizes! And doesn't really work."
Change 2746437 on 2015/10/29 by Lukasz.Furman
pass on verifying behavior tree stack before accessing its elements
#ue4
#rb Mieszko.Zielinski
Change 2748028 on 2015/10/30 by sebastian.kowalczyk
Changed GameplayDebugger's console variable from gd.EQSOnHUD to ai.gd.EQSOnHUD" after suggestion with MieszkoZ.
Change 2748184 on 2015/10/30 by Aaron.McLeran
UE-22693 Fix for streaming bug
- 3rd decoded buffer in initial 3 buffers was not getting submitted to xaudio2 voice resulting in garbled/skipped audio.
- Wasn't able to repro the 'cannot read chunk' part of the bug
#rb ryan.vance
Change 2749255 on 2015/10/31 by sebastian.kowalczyk
Fixed ai.gd.EQSOnHUD console variable after rename from gd.EQSOnHUD.
Change 2749276 on 2015/10/31 by sebastian.kowalczyk
Added switch to toggle highlight of selected actor to GameplayDebugger.
Change 2749318 on 2015/10/31 by sebastian.kowalczyk
New Gameplay Debugger plugin can be used with old module simultaneously. It's best to configure different keyboard binding for plugin when using old module (it can be set in project settings, for new gameplay debugger plugin - when activated for project).
Change 2749337 on 2015/10/31 by sebastian.kowalczyk
Fixed GameplayDebugger compilation in shipping/test builds.
Change 2749376 on 2015/10/31 by sebastian.kowalczyk
Small clean-up in gameplay debugger class for BT.
Change 2749931 on 2015/11/02 by James.Golding
Add stats to ProcMeshComp
Change 2749932 on 2015/11/02 by James.Golding
Remove PhysicsThrusterComponent.h from Engine.h
Change 2749960 on 2015/11/02 by James.Golding
- Fix PS4 compile errors in ActiveSound.cpp
- Constructor order of FActiveSound
- Shadowed AudioComponent var in CheckOcclusion
#RB thomas.sarkanen
#codereview aaron.mcleran
Change 2749961 on 2015/11/02 by James.Golding
Fix PS4 compile errors in GameplayDebuggerBaseObject.cpp
- Shadowed DefaultContext function param, now just Context, which matches declaration
#RB thomas.sarkanen
#codereview sebastian.kowalczyk
Change 2750026 on 2015/11/02 by Thomas.Sarkanen
Anim Multithreading: thread-safety refactor
Segregated access to various parts of anim update data by spitting off a new proxy class (FAnimInstanceProxy) containing all data accessed in Update() and Evaluate() passes. Gated access to the proxy data on the game thread in a number of ways:
- Explicit access via GetValueOnGameThread() - this blocks on any existing task, completes and then allows control to return to the accessing function. This allows stuff like Blueprints to continue to operate as normal.
- Explicit access via GetValueOnAnyThread() - this ensures that in the limited set of circumstances we need this (Blueprint pure functions mostly) that conditions are met about concurrent access.
- Deprecating many APIs on UAnimInstance that should not be used (and in fact are not used at present, happily).
Derived classes of UAnimInstance can override the creation of the proxy class to create their own type. We do this for UAnimSingleNodeInstance etc.
Any API deprecation should continue to function - no functions have been removed yet. The only things that are not backwards-compatible are direct access to some public member variables for which there is no way to support (e.g. via references, for example UngroupedActivePlayerArrays).
Some APIs have been changed to more specifically represent the dependencies involved. For example TickAssetPlayerInstance() used to take a UAnimInstance*, only to use it to simply queue notifies. This has been deprecated and replaced with a new FNotifyQueue API. FNotifyQueue also uses a thread-safe FRandomStream instead of FMath::Rand.
Many changes are due to substituting accessor functions for direct variable access.
Removed 'service' tick group as we no longer need to segregate the running of our parallel update.
Anim nodes that need to do some game thread-side update should register for a pre-update callback delegate in the proxy. See FAnimNode_AnimDynamics for an example of this.
Moved UpdateActiveVertexAnims into FAnimRuntime so I can subsume some of the code that was in USkeletalMeshComponent::EvaluateAnimation into UAnimInstance (and hence keep the proxy access private).
#rb Martin.Wilson,Lina.Halper
#codereview Michael.Noland
Change 2750077 on 2015/11/02 by Marc.Audy
Expose UInputComponent::BindAction that supports WithKey delegate signature
Change 2751767 on 2015/11/03 by Thomas.Sarkanen
Added extra support to Anim Blueprint 'fast-path'
Added support for negated bools (value gets negated during copy).
Added support for copying from struct members (via break struct) and split struct pins.
Removed potentially troublesome references to BP-constructed UProperties, replacing them with the property FName. This adds some extra Initialize() overhead, but prevents various crash-on load issues (one when generating the class CRC). Added guard to prevent multiple initialization to save this more expensive work being done more often.
#rb Martin.Wilson
Change 2752158 on 2015/11/03 by Jeff.Farris
Fixed UGameplayStatics::SpawnEmitterAttached() to register the ParticleSystemComponent after it spawns.
#rb marc.audy
Change 2752159 on 2015/11/03 by Jeff.Farris
Improvements to camera lens effects to (EmitterCameraLensEffectBase)
- can now specify a transform to align the emitter with the camera
- exposed several key parameters to Blueprints
- ENGINE_API now applies to the entire class
#rb marc.audy
Change 2753454 on 2015/11/04 by Thomas.Sarkanen
Fixup deprecation warnings fallout from multithreaded update changes.
Fixed up use of AnimInstance in Vicon plugin.
Fixed up use of AnimInstance in slope warping node.
Un-deprecated some APIs to become warning free (these APIs are safe to call but just a 'bad idea if you want to do it right').
Also an extra API to allow for smoother transition: Allow custom allocation/deallocation (including using a proxy member struct) by providing an override point for proxy destruction.
#rb Martin.Wilson
Change 2754099 on 2015/11/04 by Ori.Cohen
Fix for task threads dropping stats (from Gil)
#rb Gil.Gribb
Change 2754449 on 2015/11/04 by Marc.Audy
Ensure that components created from an Actor's blueprint BeginPlay implementation get BeginPlay called on them and register their component ticks
#jira UE-20853
Reorganize some booleans to get better bit packing
#rb Jeff.Farris
#codereview Mieszko.Zielinski
Change 2754573 on 2015/11/04 by Aaron.McLeran
Fixing audio component PostLoad code to not set all LowPassFilterFrequency values to 0.0f
Change 2755345 on 2015/11/05 by Thomas.Sarkanen
Added deprecated constructors for various animation contexts
Allows existing code to compile if it creates its own contexts from UAnimInstance.
#rb James.Golding
Change 2755348 on 2015/11/05 by James.Golding
Add BP-exposed SetBoundsScale function to PrimitiveComponent
#RB thomas.sarkanen
Change 2755437 on 2015/11/05 by Marc.Audy
Fix compile errors
#codereview Thomas.Sarkanen, Mieszko.Zielinski, Aaron.McLeran
Change 2755982 on 2015/11/05 by Marc.Audy
Move HeaderParse changes for deprecation macro from Core
Fix world settings warning
Change 2756028 on 2015/11/05 by Marc.Audy
Fix shadow variable issue
Change 2756090 on 2015/11/05 by Ori.Cohen
Improve budget tool so that task threads are computed automatically.
#rb Gil.Gribb
Change 2756120 on 2015/11/05 by Mieszko.Zielinski
Fixed AIController::MoveTo not using DefaultQueryExtent of its navigation data #UE4
#rb Lukasz.Furman
Change 2756243 on 2015/11/05 by Mieszko.Zielinski
Fixed AI perception sight's "auto-visibility" mechanism totally skipping distance and vision cone checks #UE4
The old way was resulting in false positives when for example observer teleported somewhere far
#rb Lukasz.Furman
#codereview John.Abercrombie
Change 2756280 on 2015/11/05 by Mieszko.Zielinski
Minor VLog code cleanup and dumb-fixing visual logger accessing timer manager off of game thread #UE4
#rb Lukasz.Furman
Change 2756500 on 2015/11/05 by Mieszko.Zielinski
Added sanity-checking to BlueprintNodeHelpers::HasBlueprintFunction and cleaned up its usage #UE4
Also, refactored its parameters into references over pointers.
#rb Lukasz.Furman
Change 2757041 on 2015/11/06 by Thomas.Sarkanen
Removed check() in UAnimInstance::GetProxyOnAnyThread()
The check was no longer needed as if we are on the game thread we block until tasks are completed below, and if we are on any other thread we are 'safe' anyway.
#rb James.Golding
Change 2757207 on 2015/11/06 by Ori.Cohen
Fix incorrect root body cache which causes a single frame "freak out" when simulating physics from an animation
#rb Lina.Halper
Change 2757238 on 2015/11/06 by Marc.Audy
Force compiler generated functions to be generated for FHierarchicalSimplification in WorldSettings.h so that they are generated while the deprecation warnings are disabled.
#rb Mike.Fricker
Change 2757284 on 2015/11/06 by Stan.Melax
tapered capsule drawing
cloth collision happens with spheres and for the hull or tapered capsule goemetry between any specified pair of spheres.
(this was already code reviewed before, but missed the check-in window before streamtime)
#rb ori.cohen
Change 2757743 on 2015/11/06 by Lukasz.Furman
fixed node memory allocations for injected behavior tree decorators
#ue4 UE-22783
#rb Mieszko.Zielinski
Change 2757772 on 2015/11/06 by Lukasz.Furman
added setters for crowd avoidance
#ue4 UE-22785
#rb Mieszko.Zielinski
Change 2758422 on 2015/11/07 by Lina.Halper
Potential fix for invalid root bone index input
#jira :/UE-23086
#code review: Ori.Cohen
Change 2758429 on 2015/11/07 by Mieszko.Zielinski
Reimplemented a fix for AI Sight's "auto seeing" mechanics in a more flexible way #UE4
#jira UE-23089
Change 2758571 on 2015/11/08 by Mieszko.Zielinski
Modified ensure condition in UAIPerceptionComponent::OnRegister so it doesn't go off when BP does it's magic when components are being added to a BP actor class #UE4
#jira UE-23080
Change 2758821 on 2015/11/09 by Thomas.Sarkanen
Fixed animations no longer playing when using a dedicated server.
Uses correct logic to determine whether we are running as a server or not.
#rb Martin.Wilson
Change 2758920 on 2015/11/09 by Marc.Audy
Don't dereference weak object pointers repeatedly in FBoneContainer::Initialize
#rb Lina.Halper
Change 2758944 on 2015/11/09 by Ori.Cohen
Fix crash when stats are only on one thread and budget mode is used
Change 2758967 on 2015/11/09 by Benn.Gallagher
Fix for crash undoing notify socket changes in Persona, needed to recache the notify track data after the transaction had reserialized the sequence.
#jira UE-22963
Change 2758973 on 2015/11/09 by Benn.Gallagher
Added new 'Random Player' node for anim graphs allowing the user to play a selection of animations in a random order with certain randomised paramers. Also allows 'Shuffle Mode' to act more like a playlist in that it will play everything on the list before repeating.
#rb Bruce.Nesbit
Change 2759219 on 2015/11/09 by Ori.Cohen
Character perf test is now looking at stats directly and sending to analytics
#RB Ben.Salem
Change 2759398 on 2015/11/09 by Lina.Halper
Fix issue where placed montages are not playing.
- the issue is that IsPlaying does not consider montage, but SetPlaying does. It is asymmetry, so I made it same. However, there are other functions that need to be re-looked at wr.t. montage
#code review: Thomas.Sarkanen
#RB: Marc.Audy
Change 2759491 on 2015/11/09 by Lina.Halper
#Anim: Fix not getting input correctly for Copy Pose node
#RB: Marc.Audy
Change 2759602 on 2015/11/09 by Marc.Audy
Fix imporperly named struct
Change 2759795 on 2015/11/09 by Aaron.McLeran
UE-23145 Adding a Priority value to USoundBase to use in concurrency evaluation and sorting wave instances for voice stealing.
#rb zak.middleton
Change 2760081 on 2015/11/09 by Aaron.McLeran
UE-23091 Adding more logging for NaN checks and fixing one source of NaNs for audio.
OmniDirectional Math Explanation:
For XAudio2, because we do our own distance-attenuation calculations, we use the X3dAudio2 API to simply compute a speaker-map for spatialization and force the listener to be at the origin and the emitter to be on the unit-circle. Thus, from XAudio2's perspective, all distances for every listener-emitter pair will be 1.0.
So in order to use the InnerRadius blending feature, we need to trick it into doing a an inner radius blend relative to a distance of 1.0. For example, if OmniRadius and Distance are the same, then the "NormalizedOmniRadius" is 1.0 and XAudio2 will begin its "blend" of the sound to an omni-directional speaker map.
If Emitter-listener distance is less than the OmniRadius, we'll want to do more blending to an omni-directional speaker map, but we need to set the InnerRadius to something greater than 1.0 (i.e. so that the normalized distance of 1.0 will be treated as less than the InnerRadius). To do "full" omni-directional blending, the emitter-listener distance will be 0 or close to zero, and the NormalizedOmniRadius will be very large (i.e. close to infiinity).
The previous math just set the NormalizedOmniRadius to FLT_MAX which is fine but that number is eventually squared before making the API call. FLT_MAX squared is INF.
Note: I do not think we need to square the OmniRadius in:
Emitter.InnerRadius = OmniRadius*OmniRadius;
But I am keeping it t here because of legacy content which depends on that behavior.
#rb zak.middleton
hange 2760401 on 2015/11/10 by Thomas.Sarkanen@Thomas.Sarkanen-Dev-Framework
Re-instated deleted protected functions in UAnimInstance.
Fixed access of UAnimInstance in FAnimNode_StateMachine.
#rb Martin.Wilson
Change 2760407 on 2015/11/10 by Jurre.deBaare
Construct raw meshes for spline meshes now uses the render data instead of original model data (preserves tangents/normals)
Change 2760468 on 2015/11/10 by Benn.Gallagher
Anim Dynamics optimizations, cached iteration independant data to reduce footprint of iteration on limits.
#rb Graeme.Thornton
Change 2760613 on 2015/11/10 by Jeff.Farris
Fixed async collision completion delegate potentially firing repeatedly. (UE-23149)
#cr marc.audy
#codereview lina.halper
Change 2760795 on 2015/11/10 by Marc.Audy
Don't compile in pointless AddReferencedObjects when with editoronly data not defined
Minor coding standard cleanup (NULL and auto)
Change 2760848 on 2015/11/10 by Benn.Gallagher
Fix to anim instance proxy to not rely on state machine initialization to bind native delegates as nested state machines are not guaranteed to be initialized. This was fixed in UAnimInstance originally but broken again by the proxy instance code.
#jira UE-23164
#rb Martin.Wilson
Change 2760866 on 2015/11/10 by Marc.Audy
Manage transient visualization components for camera component in the same way that sprite component for other actor components are
#rb Mike.Beach
Change 2760963 on 2015/11/10 by Marc.Audy
Since construction script can cause actors to be spawned don't use a ranged for to iterate
#jira UE-22639
#rb Jeff.Farris
#codereview Dmitriy.Dyomin
Change 2762297 on 2015/11/11 by James.Golding
UE-23086 Don't ensure in SetRootBodyIndex when Bodies array is empty (ie no physics state created)
#rb martin.wilson
#codereview ori.cohen, lina.halper
Change 2763566 on 2015/11/11 by Lina.Halper
FAnimNode_CopyPoseFromMesh::Evaluate - was accessing skeleton joint, not mesh joint.
#RB: Laurent.Delayen
Change 2763926 on 2015/11/12 by Thomas.Sarkanen
Fix anim notifies not firing from single anim instances
UE-23248 - Anim Notifies are not working for Animation Sequences
UE-23249 - Anim Notifies using Sound Cues do not work
#rb James.Golding
Change 2764039 on 2015/11/12 by Jurre.deBaare
Fix for issue with incorrect material indices after reducing a skeletal mesh with non LOD0 mesh as BaseLOD (OR-9243) #rb Lina.Halper
Change 2764307 on 2015/11/12 by Jurre.deBaare
VS2015 SSF library
Change 2764314 on 2015/11/12 by Stan.Melax
crashfix was putting bad bodies to sleep at start
Fatal error!
Unhandled Exception: EXCEPTION_ACCESS_VIOLATION reading address 0x00000000
UE4Editor-Engine.dll!USkeletalMeshComponent::InitArticulated() [...\\engine\\source\\runtime\\engine\\private\\skeletalmeshcomponentphysics.cpp:875]
On some skeletalmeshcomponent, some bodies aren't getting created correctly. Trying to force them to sleep was causing a crash - it expected instantiated physx bodies. Seems that all the rest of the code is able to tolerate bad bodies.
Added check to ensure physx body exists before trying to force it to sleep.
not sure if bad bodies are the norm or if this fix is just more "kicking the can down the road".
#codereview ori.cohen
Change 2764343 on 2015/11/12 by Jurre.deBaare
- Fixed crash when building a LOD with SubActors.Num < 2
- Force HLOD level slider is now always enabled, however won't show complete image if not all HLODs are build
- LODActor tree view item now scrolls into view if selected in the world
- Set bAllowCullDistanceVolume to false for LODActor's static mesh components by default
- Added 7zip files
- Fixed issue with WinINet complaining about http-request without 'http://' prefix
- Changed % reduced or original triangles display string, now uses float instead of int (for < 1% reductions)
- Override texture sizes and automatic texture bias
- Fixed issue with incorrect material merging, not picking up it required mesh-data during baking. Added extra conditions for rendering with mesh-data.
- Now incorporate static meshes with opague materials into HLOD merging
- Fixed issue with incorrect normals after merging meshes who's owning components had been negatively scaled
- Fixed issue with incorrect texture size being set from MergeActor window (was only changing .X component)
- Fixed issue with material merging when meshes with multiple LODs are merged, right now only merges LOD0's together if we are also merging the materials (otherwise, merge each LOD)
- Added ENUM for texture scaling/resizing type that has to be applied while merging the materials
- Added detail customization class for FMaterialProxySettings
#rb James.Golding
[CL 2765024 by Marc Audy in Main branch]
2015-11-12 18:11:48 -05:00
|
|
|
UWorld* CurrentWorld = nullptr;
|
|
|
|
|
if (FVisualLogger::Get().GetObjectToWorldMap().Contains(LogOwner))
|
|
|
|
|
{
|
|
|
|
|
CurrentWorld = const_cast<UWorld*>(FVisualLogger::Get().GetObjectToWorldMap()[LogOwner].Get());
|
|
|
|
|
}
|
Copying //UE4/Dev-Frame to //UE4/Main
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2775736 on 2015/11/20 by Richard.Hinckley
Fix for Paper2D issue with repeated imports in one edutor session. Paper2D import process now creates a new importer at the end. This prevents the sprite sheet import process from leaving frame data around, causing subsequent imports (including imports of different sprite sheets) to include this data inappropriately.
#codereview michael.noland
Change 2776352 on 2015/11/20 by Zak.Middleton
#ue4 - Avoid useless DetachFromParent() for the same pending AttachParent during registration. Added missing UpdateOverlaps() when detaching from object simulating physics.
#rb Marc.Audy, Ori.Cohen
#codereview James.Golding
Change 2776401 on 2015/11/20 by Mieszko.Zielinski
Implemented a way to do batched points projection to navmesh, where every point can declare a custom projection box #UE4
The biggest advantage here is that projection box is independent from projected point - no more manual offsetting of projected point to achieve "100uu up and 500uu down"-like functionality
#jira UE-23705
#rb Lukasz.Furman
Change 2777450 on 2015/11/23 by Martin.Wilson
Bake additive data into animations during cooking to avoid doing additive calculations and extra pose extraction and blending at runtime
#rb Thomas.Sarkanen
Change 2777698 on 2015/11/23 by Mieszko.Zielinski
Gameplay debugging tools fixes #UE4
Fixes:
- made newly added logs respect Log Visualizer's filters
- added handling of invalid data when trying to draw EGameplayDebuggerShapeElement::Cylinder in AGameplayDebuggingHUDComponent::DrawPerception. This is a patch, root cause to be found.
- fixed Log Visualizer resetting it's data while trying to serialize invalid objects. This is a patch, root cause to be addressed.
In addition
- while at it removed bunch of 'auto' and 'class' keywords from the files I've touched
#rb Lukasz.Furman
Change 2777762 on 2015/11/23 by Mieszko.Zielinski
Removed BlackboardComponent's functionality deprecated since 4.7 #UE4
#rb Lukasz.Furman
Change 2777839 on 2015/11/23 by Zak.Middleton
#ue4 - Wrap all vector library calls to math functions through our FMath versions, so they benefit from fixes or improvements therein. Added Exp2() function.
#rb Laurent.Delayen
Change 2777840 on 2015/11/23 by Zak.Middleton
#ue4 - Fix up uses of library math functions to go through our FMath namespace.
#rb Laurent.Delayen
Change 2778287 on 2015/11/23 by Stan.Melax
deprecation of FCollisionQueryParams(bool)
See 2774707 description for the whole story
#OR-9936
#codereview marc.audy
Changes to kite will have to be in a separate check-in
I couldn't submit to all files from the framework branch addition fixes have their files are shelved in cl 2778299
Change 2778507 on 2015/11/23 by Marc.Audy
Eliminate spurious cook warnings for known missing packages
#rb Michael.Noland
Change 2778546 on 2015/11/23 by Aaron.McLeran
Moving occlusion feature settings from audio component to sound attenuation settings struct.
- Sound attenuation setting struct is used for all sounds that do 3d spatialization so it make sense for the occlusion feature settings to be there.
- Kept old low-pass frequency filter setting values on audio component (where HighFrequencyAttenuation used to be)
#rb Zak.Middleton
Change 2778664 on 2015/11/23 by Zak.Middleton
#ue4 - Clarify some comparison functions (IsZero, IsNearlyZero, Equals) in FRotator to explain that they compare as orientations, not other interpretations such as rotational speed, winding, etc.
#rb Aaron.Mcleran
#codereview Frank.Gigliotti
Change 2779335 on 2015/11/24 by Mieszko.Zielinski
Another VisualLog patch to avoid crashing due to a core bug that remains to be investigated #UE4
Again, the core bug here is related visual log trying to serialize invalid objects on a regular basis.
#rb Lukasz.Furman
Change 2779338 on 2015/11/24 by Benn.Gallagher
Fixed crash in Persona when focus is taken from a different window
#jira UE-22516
#rb Ben.Cosh
Change 2779375 on 2015/11/24 by Benn.Gallagher
Fix for deadlock in destructibles. Aquiring actor buffer without releasing causes an infinite wait on next aquire.
#rb Ori.Cohen
Change 2779753 on 2015/11/24 by Zak.Middleton
#ue4 - FMath::Atan2() no longer calls atan2f() because of some compiler or library bugs causing it to randomly return NaN for valid input. It now uses a high-precision minimax approximation instead, measured to be 2x faster than the stock C version.
#rb Brian.Karis
Change 2779853 on 2015/11/24 by Marc.Audy
2015-12-02 16:42:06 -05:00
|
|
|
if (LastUsedWorld != CurrentWorld && CurrentWorld != nullptr)
|
2015-08-27 05:21:28 -04:00
|
|
|
{
|
|
|
|
|
OnWorldChanged.ExecuteIfBound(LastUsedWorld, CurrentWorld);
|
|
|
|
|
LastUsedWorld = CurrentWorld;
|
|
|
|
|
}
|
|
|
|
|
}
|
2015-08-27 08:43:39 -04:00
|
|
|
|
|
|
|
|
SVisualLogger* VisualLoggerWidget;
|
2015-08-27 05:21:28 -04:00
|
|
|
UWorld* LastUsedWorld;
|
|
|
|
|
FOnWorldChanged OnWorldChanged;
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
InternalDevice = MakeShareable(new FVisualLoggerDevice(this, FOnWorldChanged::CreateLambda([this](UWorld* PreviousWorld, UWorld* CurrentWorld){ OnNewWorld(CurrentWorld); })));
|
2014-11-19 07:43:07 -05:00
|
|
|
FVisualLogger::Get().AddDevice(InternalDevice.Get());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
SVisualLogger::~SVisualLogger()
|
2014-12-11 06:23:59 -05:00
|
|
|
{
|
2015-08-27 05:21:28 -04:00
|
|
|
GEngine->OnWorldAdded().RemoveAll(this);
|
|
|
|
|
|
|
|
|
|
FVisualLogger::Get().RemoveDevice(InternalDevice.Get());
|
|
|
|
|
InternalDevice.Reset();
|
|
|
|
|
|
2014-12-18 08:37:06 -05:00
|
|
|
UWorld* World = NULL;
|
|
|
|
|
#if WITH_EDITOR
|
2015-08-27 05:21:28 -04:00
|
|
|
ULogVisualizerSettings::StaticClass()->GetDefaultObject<ULogVisualizerSettings>()->SavePresistentData();
|
2014-12-18 08:37:06 -05:00
|
|
|
#endif
|
|
|
|
|
|
2015-08-27 05:21:28 -04:00
|
|
|
if (LastUsedWorld.IsValid())
|
2014-12-18 08:37:06 -05:00
|
|
|
{
|
2015-08-27 05:21:28 -04:00
|
|
|
for (TActorIterator<AVisualLoggerRenderingActor> It(LastUsedWorld.Get()); It; ++It)
|
2014-12-18 08:37:06 -05:00
|
|
|
{
|
2015-08-27 05:21:28 -04:00
|
|
|
LastUsedWorld->DestroyActor(*It);
|
2014-12-18 08:37:06 -05:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2015-08-27 05:21:28 -04:00
|
|
|
|
2015-01-08 09:29:27 -05:00
|
|
|
UDebugDrawService::Unregister(DrawOnCanvasDelegateHandle);
|
2014-12-18 08:37:06 -05:00
|
|
|
VisualLoggerCanvasRenderer.Reset();
|
|
|
|
|
|
2015-08-27 05:21:28 -04:00
|
|
|
FVisualLoggerDatabase::Get().GetEvents().OnRowSelectionChanged.RemoveAll(this);
|
|
|
|
|
FVisualLoggerDatabase::Get().GetEvents().OnNewItem.RemoveAll(this);
|
|
|
|
|
FVisualLoggerDatabase::Get().GetEvents().OnItemSelectionChanged.RemoveAll(this);
|
|
|
|
|
|
|
|
|
|
FLogVisualizer::Get().GetEvents().OnFiltersChanged.RemoveAll(this);
|
|
|
|
|
FLogVisualizer::Get().GetEvents().OnLogLineSelectionChanged.Unbind();
|
|
|
|
|
FLogVisualizer::Get().GetEvents().OnKeyboardEvent.Unbind();
|
|
|
|
|
|
|
|
|
|
FVisualLoggerDatabase::Get().Reset();
|
2014-12-11 06:23:59 -05:00
|
|
|
}
|
|
|
|
|
|
2014-11-19 07:43:07 -05:00
|
|
|
/* SMessagingDebugger interface
|
|
|
|
|
*****************************************************************************/
|
|
|
|
|
|
|
|
|
|
void SVisualLogger::Construct(const FArguments& InArgs, const TSharedRef<SDockTab>& ConstructUnderMajorTab, const TSharedPtr<SWindow>& ConstructUnderWindow)
|
|
|
|
|
{
|
2015-02-24 09:19:13 -05:00
|
|
|
bPausedLogger = false;
|
2015-02-24 10:45:21 -05:00
|
|
|
bGotHistogramData = false;
|
2015-02-24 09:19:13 -05:00
|
|
|
|
2015-01-15 06:19:24 -05:00
|
|
|
FLogVisualizer::Get().SetCurrentVisualizer(SharedThis(this));
|
2014-11-19 07:43:07 -05:00
|
|
|
//////////////////////////////////////////////////////////////////////////
|
|
|
|
|
// Visual Logger Events
|
2015-08-27 05:21:28 -04:00
|
|
|
FLogVisualizer::Get().GetEvents().OnFiltersChanged.AddRaw(this, &SVisualLogger::OnFiltersChanged);
|
|
|
|
|
FLogVisualizer::Get().GetEvents().OnLogLineSelectionChanged = FOnLogLineSelectionChanged::CreateRaw(this, &SVisualLogger::OnLogLineSelectionChanged);
|
|
|
|
|
FLogVisualizer::Get().GetEvents().OnKeyboardEvent = FOnKeyboardEvent::CreateRaw(this, &SVisualLogger::OnKeyboaedRedirection);
|
|
|
|
|
FLogVisualizer::Get().GetTimeSliderController().Get()->GetTimeSliderArgs().OnScrubPositionChanged = FOnScrubPositionChanged::CreateRaw(this, &SVisualLogger::OnScrubPositionChanged);
|
|
|
|
|
|
|
|
|
|
FVisualLoggerDatabase::Get().GetEvents().OnRowSelectionChanged.AddRaw(this, &SVisualLogger::OnObjectSelectionChanged);
|
|
|
|
|
FVisualLoggerDatabase::Get().GetEvents().OnNewItem.AddRaw(this, &SVisualLogger::OnNewItemHandler);
|
|
|
|
|
FVisualLoggerDatabase::Get().GetEvents().OnItemSelectionChanged.AddRaw(this, &SVisualLogger::OnItemsSelectionChanged);
|
|
|
|
|
|
|
|
|
|
GEngine->OnWorldAdded().AddRaw(this, &SVisualLogger::OnNewWorld);
|
|
|
|
|
|
2014-11-19 07:43:07 -05:00
|
|
|
//////////////////////////////////////////////////////////////////////////
|
|
|
|
|
// Command Action Lists
|
|
|
|
|
const FVisualLoggerCommands& Commands = FVisualLoggerCommands::Get();
|
|
|
|
|
FUICommandList& ActionList = *CommandList;
|
|
|
|
|
|
2014-12-18 08:37:06 -05:00
|
|
|
ULogVisualizerSettings* Settings = ULogVisualizerSettings::StaticClass()->GetDefaultObject<ULogVisualizerSettings>();
|
2015-08-27 05:21:28 -04:00
|
|
|
Settings->LoadPresistentData();
|
2014-12-18 08:37:06 -05:00
|
|
|
|
2014-11-19 07:43:07 -05:00
|
|
|
ActionList.MapAction(Commands.StartRecording, FExecuteAction::CreateRaw(this, &SVisualLogger::HandleStartRecordingCommandExecute), FCanExecuteAction::CreateRaw(this, &SVisualLogger::HandleStartRecordingCommandCanExecute), FIsActionChecked(), FIsActionButtonVisible::CreateRaw(this, &SVisualLogger::HandleStartRecordingCommandIsVisible));
|
|
|
|
|
ActionList.MapAction(Commands.StopRecording, FExecuteAction::CreateRaw(this, &SVisualLogger::HandleStopRecordingCommandExecute), FCanExecuteAction::CreateRaw(this, &SVisualLogger::HandleStopRecordingCommandCanExecute), FIsActionChecked(), FIsActionButtonVisible::CreateRaw(this, &SVisualLogger::HandleStopRecordingCommandIsVisible));
|
|
|
|
|
ActionList.MapAction(Commands.Pause, FExecuteAction::CreateRaw(this, &SVisualLogger::HandlePauseCommandExecute), FCanExecuteAction::CreateRaw(this, &SVisualLogger::HandlePauseCommandCanExecute), FIsActionChecked(), FIsActionButtonVisible::CreateRaw(this, &SVisualLogger::HandlePauseCommandIsVisible));
|
|
|
|
|
ActionList.MapAction(Commands.Resume, FExecuteAction::CreateRaw(this, &SVisualLogger::HandleResumeCommandExecute), FCanExecuteAction::CreateRaw(this, &SVisualLogger::HandleResumeCommandCanExecute), FIsActionChecked(), FIsActionButtonVisible::CreateRaw(this, &SVisualLogger::HandleResumeCommandIsVisible));
|
2015-01-07 13:24:58 -05:00
|
|
|
ActionList.MapAction(Commands.LoadFromVLog, FExecuteAction::CreateRaw(this, &SVisualLogger::HandleLoadCommandExecute), FCanExecuteAction::CreateRaw(this, &SVisualLogger::HandleLoadCommandCanExecute), FIsActionChecked(), FIsActionButtonVisible::CreateRaw(this, &SVisualLogger::HandleLoadCommandCanExecute));
|
|
|
|
|
ActionList.MapAction(Commands.SaveToVLog, FExecuteAction::CreateRaw(this, &SVisualLogger::HandleSaveCommandExecute), FCanExecuteAction::CreateRaw(this, &SVisualLogger::HandleSaveCommandCanExecute), FIsActionChecked(), FIsActionButtonVisible::CreateRaw(this, &SVisualLogger::HandleSaveCommandCanExecute));
|
2015-05-27 09:20:05 -04:00
|
|
|
ActionList.MapAction(Commands.SaveAllToVLog, FExecuteAction::CreateRaw(this, &SVisualLogger::HandleSaveAllCommandExecute), FCanExecuteAction::CreateRaw(this, &SVisualLogger::HandleSaveCommandCanExecute), FIsActionChecked(), FIsActionButtonVisible::CreateRaw(this, &SVisualLogger::HandleSaveCommandCanExecute));
|
|
|
|
|
ActionList.MapAction(Commands.FreeCamera,
|
2014-11-21 09:01:15 -05:00
|
|
|
FExecuteAction::CreateRaw(this, &SVisualLogger::HandleCameraCommandExecute),
|
|
|
|
|
FCanExecuteAction::CreateRaw(this, &SVisualLogger::HandleCameraCommandCanExecute),
|
|
|
|
|
FIsActionChecked::CreateRaw(this, &SVisualLogger::HandleCameraCommandIsChecked),
|
|
|
|
|
FIsActionButtonVisible::CreateRaw(this, &SVisualLogger::HandleCameraCommandCanExecute));
|
2014-12-10 09:28:26 -05:00
|
|
|
ActionList.MapAction(Commands.ToggleGraphs,
|
|
|
|
|
FExecuteAction::CreateLambda([](){bool& bEnableGraphsVisualization = ULogVisualizerSessionSettings::StaticClass()->GetDefaultObject<ULogVisualizerSessionSettings>()->bEnableGraphsVisualization; bEnableGraphsVisualization = !bEnableGraphsVisualization; }),
|
2015-08-27 05:21:28 -04:00
|
|
|
FCanExecuteAction::CreateLambda([this]()->bool{return FVisualLoggerGraphsDatabase::Get().ContainsHistogramGraphs(); }),
|
2014-12-10 09:28:26 -05:00
|
|
|
FIsActionChecked::CreateLambda([]()->bool{return ULogVisualizerSessionSettings::StaticClass()->GetDefaultObject<ULogVisualizerSessionSettings>()->bEnableGraphsVisualization; }),
|
2015-08-27 05:21:28 -04:00
|
|
|
FIsActionButtonVisible::CreateLambda([this]()->bool{return FVisualLoggerGraphsDatabase::Get().ContainsHistogramGraphs(); }));
|
2015-01-07 08:06:36 -05:00
|
|
|
ActionList.MapAction(Commands.ResetData,
|
|
|
|
|
FExecuteAction::CreateRaw(this, &SVisualLogger::ResetData),
|
|
|
|
|
FCanExecuteAction::CreateRaw(this, &SVisualLogger::HandleSaveCommandCanExecute),
|
|
|
|
|
FIsActionChecked(),
|
|
|
|
|
FIsActionButtonVisible::CreateRaw(this, &SVisualLogger::HandleSaveCommandCanExecute));
|
2014-12-10 09:28:26 -05:00
|
|
|
|
2014-11-19 07:43:07 -05:00
|
|
|
|
|
|
|
|
// Tab Spawners
|
|
|
|
|
TabManager = FGlobalTabmanager::Get()->NewTabManager(ConstructUnderMajorTab);
|
|
|
|
|
TSharedRef<FWorkspaceItem> AppMenuGroup = TabManager->AddLocalWorkspaceMenuCategory(LOCTEXT("VisualLoggerGroupName", "Visual Logger"));
|
|
|
|
|
|
|
|
|
|
TabManager->RegisterTabSpawner(ToolbarTabId, FOnSpawnTab::CreateRaw(this, &SVisualLogger::HandleTabManagerSpawnTab, ToolbarTabId))
|
|
|
|
|
.SetDisplayName(LOCTEXT("ToolbarTabTitle", "Toolbar"))
|
|
|
|
|
.SetGroup(AppMenuGroup)
|
|
|
|
|
.SetIcon(FSlateIcon(FLogVisualizerStyle::Get().GetStyleSetName(), "ToolbarTabIcon"));
|
|
|
|
|
|
|
|
|
|
TabManager->RegisterTabSpawner(FiltersTabId, FOnSpawnTab::CreateRaw(this, &SVisualLogger::HandleTabManagerSpawnTab, FiltersTabId))
|
|
|
|
|
.SetDisplayName(LOCTEXT("FiltersTabTitle", "Filters"))
|
|
|
|
|
.SetGroup(AppMenuGroup)
|
|
|
|
|
.SetIcon(FSlateIcon(FLogVisualizerStyle::Get().GetStyleSetName(), "FiltersTabIcon"));
|
|
|
|
|
|
|
|
|
|
TabManager->RegisterTabSpawner(MainViewTabId, FOnSpawnTab::CreateRaw(this, &SVisualLogger::HandleTabManagerSpawnTab, MainViewTabId))
|
|
|
|
|
.SetDisplayName(LOCTEXT("MainViewTabTitle", "MainView"))
|
|
|
|
|
.SetGroup(AppMenuGroup)
|
|
|
|
|
.SetIcon(FSlateIcon(FLogVisualizerStyle::Get().GetStyleSetName(), "MainViewTabIcon"));
|
|
|
|
|
|
|
|
|
|
TabManager->RegisterTabSpawner(LogsListTabId, FOnSpawnTab::CreateRaw(this, &SVisualLogger::HandleTabManagerSpawnTab, LogsListTabId))
|
|
|
|
|
.SetDisplayName(LOCTEXT("LogsListTabTitle", "LogsList"))
|
|
|
|
|
.SetGroup(AppMenuGroup)
|
|
|
|
|
.SetIcon(FSlateIcon(FLogVisualizerStyle::Get().GetStyleSetName(), "LogsListTabIcon"));
|
|
|
|
|
|
|
|
|
|
TabManager->RegisterTabSpawner(StatusViewTabId, FOnSpawnTab::CreateRaw(this, &SVisualLogger::HandleTabManagerSpawnTab, StatusViewTabId))
|
|
|
|
|
.SetDisplayName(LOCTEXT("StatusViewTabTitle", "StatusView"))
|
|
|
|
|
.SetGroup(AppMenuGroup)
|
|
|
|
|
.SetIcon(FSlateIcon(FLogVisualizerStyle::Get().GetStyleSetName(), "StatusViewTabIcon"));
|
|
|
|
|
|
|
|
|
|
// Default Layout
|
|
|
|
|
const TSharedRef<FTabManager::FLayout> Layout = FTabManager::NewLayout("VisualLoggerLayout_v1.0")
|
|
|
|
|
->AddArea
|
|
|
|
|
(
|
|
|
|
|
FTabManager::NewPrimaryArea()
|
|
|
|
|
->SetOrientation(Orient_Vertical)
|
|
|
|
|
->Split
|
|
|
|
|
(
|
|
|
|
|
FTabManager::NewStack()
|
|
|
|
|
->AddTab(ToolbarTabId, ETabState::OpenedTab)
|
|
|
|
|
->SetHideTabWell(true)
|
|
|
|
|
)
|
|
|
|
|
->Split
|
|
|
|
|
(
|
|
|
|
|
FTabManager::NewStack()
|
|
|
|
|
->AddTab(FiltersTabId, ETabState::OpenedTab)
|
|
|
|
|
->SetHideTabWell(true)
|
|
|
|
|
)
|
|
|
|
|
->Split
|
|
|
|
|
(
|
|
|
|
|
FTabManager::NewStack()
|
|
|
|
|
->AddTab(MainViewTabId, ETabState::OpenedTab)
|
|
|
|
|
->SetHideTabWell(true)
|
|
|
|
|
)
|
|
|
|
|
->Split
|
|
|
|
|
(
|
|
|
|
|
FTabManager::NewSplitter()
|
|
|
|
|
->SetOrientation(Orient_Horizontal)
|
|
|
|
|
->SetSizeCoefficient(0.6f)
|
|
|
|
|
->Split
|
|
|
|
|
(
|
|
|
|
|
FTabManager::NewStack()
|
|
|
|
|
->AddTab(StatusViewTabId, ETabState::OpenedTab)
|
|
|
|
|
->SetHideTabWell(true)
|
|
|
|
|
->SetSizeCoefficient(0.3f)
|
|
|
|
|
)
|
|
|
|
|
->Split
|
|
|
|
|
(
|
|
|
|
|
FTabManager::NewStack()
|
|
|
|
|
->AddTab(LogsListTabId, ETabState::OpenedTab)
|
|
|
|
|
->SetHideTabWell(true)
|
|
|
|
|
->SetSizeCoefficient(0.7f)
|
|
|
|
|
)
|
|
|
|
|
)
|
|
|
|
|
);
|
2014-12-01 08:44:16 -05:00
|
|
|
TabManager->SetOnPersistLayout(FTabManager::FOnPersistLayout::CreateRaw(this, &SVisualLogger::HandleTabManagerPersistLayout));
|
|
|
|
|
|
2014-11-19 07:43:07 -05:00
|
|
|
// Window Menu
|
|
|
|
|
FMenuBarBuilder MenuBarBuilder = FMenuBarBuilder(TSharedPtr<FUICommandList>());
|
|
|
|
|
MenuBarBuilder.AddPullDownMenu(
|
|
|
|
|
LOCTEXT("WindowMenuLabel", "Window"),
|
|
|
|
|
FText::GetEmpty(),
|
|
|
|
|
FNewMenuDelegate::CreateStatic(&SVisualLogger::FillWindowMenu, TabManager),
|
|
|
|
|
"Window"
|
|
|
|
|
);
|
|
|
|
|
|
2014-11-28 09:26:40 -05:00
|
|
|
MenuBarBuilder.AddMenuEntry(
|
|
|
|
|
LOCTEXT("SettingsMenuLabel", "Settings"),
|
|
|
|
|
FText::GetEmpty(),
|
|
|
|
|
FSlateIcon(),
|
|
|
|
|
FUIAction(
|
|
|
|
|
FExecuteAction::CreateLambda(
|
|
|
|
|
[this](){
|
|
|
|
|
ISettingsModule* SettingsModule = FModuleManager::GetModulePtr<ISettingsModule>("Settings");
|
|
|
|
|
if (SettingsModule != nullptr)
|
|
|
|
|
{
|
|
|
|
|
SettingsModule->ShowViewer("Editor", "General", "VisualLogger");
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
)),
|
|
|
|
|
"Settings"
|
|
|
|
|
);
|
|
|
|
|
|
2014-11-19 07:43:07 -05:00
|
|
|
|
|
|
|
|
ChildSlot
|
|
|
|
|
[
|
|
|
|
|
SNew(SVerticalBox)
|
|
|
|
|
+ SVerticalBox::Slot()
|
|
|
|
|
.AutoHeight()
|
|
|
|
|
[
|
|
|
|
|
MenuBarBuilder.MakeWidget()
|
|
|
|
|
]
|
|
|
|
|
+ SVerticalBox::Slot()
|
|
|
|
|
.FillHeight(1.0f)
|
|
|
|
|
[
|
|
|
|
|
TabManager->RestoreFrom(Layout, ConstructUnderWindow).ToSharedRef()
|
|
|
|
|
]
|
|
|
|
|
];
|
|
|
|
|
|
2015-01-15 06:19:24 -05:00
|
|
|
VisualLoggerCanvasRenderer = MakeShareable(new FVisualLoggerCanvasRenderer());
|
2014-11-19 07:43:07 -05:00
|
|
|
|
2015-01-08 09:29:27 -05:00
|
|
|
DrawOnCanvasDelegateHandle = UDebugDrawService::Register(TEXT("VisLog"), FDebugDrawDelegate::CreateRaw(VisualLoggerCanvasRenderer.Get(), &FVisualLoggerCanvasRenderer::DrawOnCanvas));
|
2015-08-27 05:21:28 -04:00
|
|
|
|
2015-09-11 09:02:06 -04:00
|
|
|
Cast<AVisualLoggerRenderingActor>(FVisualLoggerEditorInterface::Get()->GetHelperActor(LastUsedWorld.Get()));
|
2015-08-27 05:21:28 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void SVisualLogger::OnNewLogEntry(const FVisualLogDevice::FVisualLogEntryItem& Entry)
|
|
|
|
|
{
|
|
|
|
|
if (bPausedLogger)
|
|
|
|
|
{
|
|
|
|
|
OnPauseCacheForEntries.Add(Entry);
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
FVisualLoggerDatabase::Get().AddItem(Entry);
|
|
|
|
|
|
|
|
|
|
if (ULogVisualizerSettings::StaticClass()->GetDefaultObject<ULogVisualizerSettings>()->bStickToRecentData)
|
|
|
|
|
{
|
|
|
|
|
FLogVisualizer::Get().GetTimeSliderController()->CommitScrubPosition(Entry.Entry.TimeStamp, false);
|
|
|
|
|
}
|
2014-11-19 07:43:07 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void SVisualLogger::HandleMajorTabPersistVisualState()
|
|
|
|
|
{
|
|
|
|
|
// save any settings here
|
|
|
|
|
}
|
|
|
|
|
|
2014-12-01 08:44:16 -05:00
|
|
|
void SVisualLogger::HandleTabManagerPersistLayout(const TSharedRef<FTabManager::FLayout>& LayoutToSave)
|
|
|
|
|
{
|
2015-08-27 05:21:28 -04:00
|
|
|
// save any layout here
|
2014-12-18 08:37:06 -05:00
|
|
|
}
|
|
|
|
|
|
2014-11-19 07:43:07 -05:00
|
|
|
void SVisualLogger::FillWindowMenu(FMenuBuilder& MenuBuilder, const TSharedPtr<FTabManager> TabManager)
|
|
|
|
|
{
|
|
|
|
|
if (!TabManager.IsValid())
|
|
|
|
|
{
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
TabManager->PopulateLocalTabSpawnerMenu(MenuBuilder);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
TSharedRef<SDockTab> SVisualLogger::HandleTabManagerSpawnTab(const FSpawnTabArgs& Args, FName TabIdentifier) const
|
|
|
|
|
{
|
|
|
|
|
TSharedPtr<SWidget> TabWidget = SNullWidget::NullWidget;
|
|
|
|
|
bool AutoSizeTab = false;
|
|
|
|
|
|
|
|
|
|
if (TabIdentifier == ToolbarTabId)
|
2015-06-11 09:51:31 -04:00
|
|
|
{
|
2014-11-19 07:43:07 -05:00
|
|
|
TabWidget = SNew(SVisualLoggerToolbar, CommandList);
|
|
|
|
|
AutoSizeTab = true;
|
|
|
|
|
}
|
|
|
|
|
else if (TabIdentifier == FiltersTabId)
|
|
|
|
|
{
|
2015-01-15 06:19:24 -05:00
|
|
|
TabWidget = SAssignNew(VisualLoggerFilters, SVisualLoggerFilters, CommandList);
|
2014-11-19 07:43:07 -05:00
|
|
|
AutoSizeTab = true;
|
|
|
|
|
}
|
|
|
|
|
else if (TabIdentifier == MainViewTabId)
|
|
|
|
|
{
|
2015-01-15 06:19:24 -05:00
|
|
|
TabWidget = SAssignNew(MainView, SVisualLoggerView, CommandList).OnFiltersSearchChanged(this, &SVisualLogger::OnFiltersSearchChanged);
|
2014-11-19 07:43:07 -05:00
|
|
|
AutoSizeTab = false;
|
|
|
|
|
}
|
|
|
|
|
else if (TabIdentifier == LogsListTabId)
|
|
|
|
|
{
|
2015-01-15 06:19:24 -05:00
|
|
|
TabWidget = SAssignNew(LogsList, SVisualLoggerLogsList, CommandList);
|
2014-11-19 07:43:07 -05:00
|
|
|
AutoSizeTab = false;
|
|
|
|
|
}
|
|
|
|
|
else if (TabIdentifier == StatusViewTabId)
|
|
|
|
|
{
|
|
|
|
|
TabWidget = SAssignNew(StatusView, SVisualLoggerStatusView, CommandList);
|
|
|
|
|
AutoSizeTab = false;
|
|
|
|
|
}
|
2015-06-11 09:51:31 -04:00
|
|
|
|
2015-08-27 05:21:28 -04:00
|
|
|
check(TabWidget.IsValid());
|
2015-06-11 09:51:31 -04:00
|
|
|
return SNew(SVisualLoggerTab)
|
2014-11-19 07:43:07 -05:00
|
|
|
.ShouldAutosize(AutoSizeTab)
|
2015-06-11 09:51:31 -04:00
|
|
|
.TabRole(ETabRole::DocumentTab)
|
2014-11-19 07:43:07 -05:00
|
|
|
[
|
|
|
|
|
TabWidget.ToSharedRef()
|
|
|
|
|
];
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
bool SVisualLogger::HandleStartRecordingCommandCanExecute() const
|
|
|
|
|
{
|
|
|
|
|
return !FVisualLogger::Get().IsRecording();
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
void SVisualLogger::HandleStartRecordingCommandExecute()
|
|
|
|
|
{
|
|
|
|
|
FVisualLogger::Get().SetIsRecording(true);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
bool SVisualLogger::HandleStartRecordingCommandIsVisible() const
|
|
|
|
|
{
|
|
|
|
|
return !FVisualLogger::Get().IsRecording();
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
bool SVisualLogger::HandleStopRecordingCommandCanExecute() const
|
|
|
|
|
{
|
|
|
|
|
return FVisualLogger::Get().IsRecording();
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
void SVisualLogger::HandleStopRecordingCommandExecute()
|
|
|
|
|
{
|
2015-05-29 09:56:45 -04:00
|
|
|
UWorld* World = FLogVisualizer::Get().GetWorld();
|
|
|
|
|
|
2015-08-27 05:21:28 -04:00
|
|
|
if (FParse::Param(FCommandLine::Get(), TEXT("LogNavOctree")) == true && ULogVisualizerSettings::StaticClass()->GetDefaultObject<ULogVisualizerSettings>()->bLogNavOctreeOnStop)
|
2015-05-29 09:56:45 -04:00
|
|
|
{
|
2016-02-24 14:23:53 -05:00
|
|
|
FVisualLogger::NavigationDataDump(World, LogNavigation, ELogVerbosity::Log, FBox());
|
2015-05-29 09:56:45 -04:00
|
|
|
}
|
|
|
|
|
|
2014-11-19 07:43:07 -05:00
|
|
|
FVisualLogger::Get().SetIsRecording(false);
|
2014-11-21 09:01:15 -05:00
|
|
|
|
|
|
|
|
if (AVisualLoggerCameraController::IsEnabled(World))
|
|
|
|
|
{
|
|
|
|
|
AVisualLoggerCameraController::DisableCamera(World);
|
|
|
|
|
}
|
2015-08-27 05:21:28 -04:00
|
|
|
|
|
|
|
|
if (bPausedLogger)
|
|
|
|
|
{
|
|
|
|
|
HandleResumeCommandExecute();
|
|
|
|
|
}
|
2014-11-19 07:43:07 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
bool SVisualLogger::HandleStopRecordingCommandIsVisible() const
|
|
|
|
|
{
|
|
|
|
|
return FVisualLogger::Get().IsRecording();
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
bool SVisualLogger::HandlePauseCommandCanExecute() const
|
|
|
|
|
{
|
2015-02-24 09:19:13 -05:00
|
|
|
return !bPausedLogger;
|
2014-11-19 07:43:07 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void SVisualLogger::HandlePauseCommandExecute()
|
|
|
|
|
{
|
2015-02-24 09:19:13 -05:00
|
|
|
if (ULogVisualizerSettings::StaticClass()->GetDefaultObject<ULogVisualizerSettings>()->bUsePlayersOnlyForPause)
|
2014-11-19 07:43:07 -05:00
|
|
|
{
|
2015-02-24 09:19:13 -05:00
|
|
|
const TIndirectArray<FWorldContext>& WorldContexts = GEngine->GetWorldContexts();
|
|
|
|
|
for (const FWorldContext& Context : WorldContexts)
|
|
|
|
|
{
|
|
|
|
|
if (Context.World() != nullptr)
|
|
|
|
|
{
|
|
|
|
|
Context.World()->bPlayersOnlyPending = true;
|
|
|
|
|
}
|
|
|
|
|
}
|
2014-11-19 07:43:07 -05:00
|
|
|
}
|
2015-02-24 09:19:13 -05:00
|
|
|
|
|
|
|
|
bPausedLogger = true;
|
2014-11-19 07:43:07 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
bool SVisualLogger::HandlePauseCommandIsVisible() const
|
|
|
|
|
{
|
|
|
|
|
return HandlePauseCommandCanExecute();
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
bool SVisualLogger::HandleResumeCommandCanExecute() const
|
|
|
|
|
{
|
2015-02-24 09:19:13 -05:00
|
|
|
return bPausedLogger;
|
2014-11-19 07:43:07 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void SVisualLogger::HandleResumeCommandExecute()
|
|
|
|
|
{
|
2015-02-24 09:19:13 -05:00
|
|
|
if (ULogVisualizerSettings::StaticClass()->GetDefaultObject<ULogVisualizerSettings>()->bUsePlayersOnlyForPause)
|
2014-11-19 07:43:07 -05:00
|
|
|
{
|
2015-02-24 09:19:13 -05:00
|
|
|
const TIndirectArray<FWorldContext>& WorldContexts = GEngine->GetWorldContexts();
|
|
|
|
|
for (const FWorldContext& Context : WorldContexts)
|
|
|
|
|
{
|
|
|
|
|
if (Context.World() != nullptr)
|
|
|
|
|
{
|
|
|
|
|
Context.World()->bPlayersOnly = false;
|
|
|
|
|
Context.World()->bPlayersOnlyPending = false;
|
|
|
|
|
}
|
|
|
|
|
}
|
2014-11-19 07:43:07 -05:00
|
|
|
}
|
2015-02-24 09:19:13 -05:00
|
|
|
|
|
|
|
|
bPausedLogger = false;
|
|
|
|
|
for (const auto& CurrentEntry : OnPauseCacheForEntries)
|
|
|
|
|
{
|
|
|
|
|
OnNewLogEntry(CurrentEntry);
|
|
|
|
|
}
|
|
|
|
|
OnPauseCacheForEntries.Reset();
|
|
|
|
|
|
2014-11-19 07:43:07 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
bool SVisualLogger::HandleResumeCommandIsVisible() const
|
|
|
|
|
{
|
|
|
|
|
return HandleResumeCommandCanExecute();
|
|
|
|
|
}
|
|
|
|
|
|
2014-11-21 09:01:15 -05:00
|
|
|
bool SVisualLogger::HandleCameraCommandIsChecked() const
|
|
|
|
|
{
|
2015-01-15 06:19:24 -05:00
|
|
|
UWorld* World = FLogVisualizer::Get().GetWorld();
|
2014-11-21 09:01:15 -05:00
|
|
|
return World && AVisualLoggerCameraController::IsEnabled(World);
|
|
|
|
|
}
|
|
|
|
|
|
2014-11-21 08:26:27 -05:00
|
|
|
bool SVisualLogger::HandleCameraCommandCanExecute() const
|
|
|
|
|
{
|
2015-01-15 06:19:24 -05:00
|
|
|
UWorld* World = FLogVisualizer::Get().GetWorld();
|
2014-11-24 12:52:06 -05:00
|
|
|
return FVisualLogger::Get().IsRecording() && World && (World->bPlayersOnly || World->bPlayersOnlyPending) && World->IsPlayInEditor() && (GEditor && !GEditor->bIsSimulatingInEditor);
|
2014-11-21 08:26:27 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void SVisualLogger::HandleCameraCommandExecute()
|
|
|
|
|
{
|
2015-01-15 06:19:24 -05:00
|
|
|
UWorld* World = FLogVisualizer::Get().GetWorld();
|
2014-11-21 08:26:27 -05:00
|
|
|
if (AVisualLoggerCameraController::IsEnabled(World))
|
|
|
|
|
{
|
|
|
|
|
AVisualLoggerCameraController::DisableCamera(World);
|
|
|
|
|
}
|
|
|
|
|
else
|
|
|
|
|
{
|
|
|
|
|
// switch debug cam on
|
|
|
|
|
CameraController = AVisualLoggerCameraController::EnableCamera(World);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2014-11-19 07:43:07 -05:00
|
|
|
bool SVisualLogger::HandleLoadCommandCanExecute() const
|
|
|
|
|
{
|
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void SVisualLogger::HandleLoadCommandExecute()
|
|
|
|
|
{
|
|
|
|
|
FArchive Ar;
|
|
|
|
|
TArray<FVisualLogDevice::FVisualLogEntryItem> RecordedLogs;
|
|
|
|
|
|
|
|
|
|
TArray<FString> OpenFilenames;
|
|
|
|
|
IDesktopPlatform* DesktopPlatform = FDesktopPlatformModule::Get();
|
|
|
|
|
bool bOpened = false;
|
|
|
|
|
if (DesktopPlatform)
|
|
|
|
|
{
|
|
|
|
|
const FString DefaultBrowsePath = FString::Printf(TEXT("%slogs/"), *FPaths::GameSavedDir());
|
|
|
|
|
|
|
|
|
|
bOpened = DesktopPlatform->OpenFileDialog(
|
Copying //UE4/Dev-Editor to //UE4/Dev-Main (Source: //UE4/Dev-Editor @ 3133954)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3077573 on 2016/08/04 by Nick.Darnell
Removing some unused code, adding additional needed modules to editor tests.
#rb none
Change 3077580 on 2016/08/04 by Nick.Darnell
Removing the test plugins, going to be recreating them in EngineTest.
Change 3082659 on 2016/08/09 by Nick.Darnell
Automation - Presets are now stored in json files stored in Config so they can be shared, and human readable. Working on screenshot automation, getting it where it needs to be to permit us to have repeatable tests for comarison. Removing the option to not take full size screenshots, that defeats the purpose of being able to compare them.
#rb none
Change 3082766 on 2016/08/09 by Jamie.Dale
Fixed crashes when dealing with code-points outside the BMP on platforms with UTF-32 FStrings
ICU always deals with its offsets as UTF-16 (as it always uses UTF-16 internally with icu::UnicodeString), so there were a couple of places in code (break iteration, and bidi detection) where we needed to adjust those UTF-16 offsets to UTF-32 offsets in the case where FString is UTF-32.
#jira UE-33971
#rb James.Hopkin
Change 3083067 on 2016/08/09 by Nick.Darnell
Automation - Working on screenshot support, system now allows a lot more customization in terms of how large the shot is.
#rb none
Change 3084475 on 2016/08/10 by Richard.TalbotWatkin
Fixed issue with ModelComponent replication in client/server PIE if BSP is rebuilt. ModelComponent now implements IsNameStableForNetworking and always returns true, as a level's model components will never be rebuilt during a game session. Brush poly normals are now only fixed up in Editor builds.
#jira UE-34391 - No run animation on client that is not focused when running 2 player and dedicated server
#codereview Matt.Kuhlenschmidt
#rb none
Change 3084661 on 2016/08/10 by Matt.Kuhlenschmidt
Added grayscale texture importing support
#rb none
Change 3084774 on 2016/08/10 by Cody.Albert
Adding controller support for ComboBox widget
#jira UE-33826
#rb nick.darnell
Change 3085716 on 2016/08/11 by Nick.Darnell
UMG - Taking the Widget Component and Widget Interaction Components out of experimental. Removed old importing support for upgrading ancient versions of widget components. Removing parbola distortion, as users can now do whatever they want in their custom MID they can override the widget with.
#rb none
Change 3085733 on 2016/08/11 by Nick.Darnell
UMG - Documenting the meta parameters allowed on widgets, like we do for regular UObjects. For binding widgets from blueprints you can now do BindWidget (unchanged), and to simplify binding widgets optionally, you can now just do (BindWidgetOptional), rather than the combination of BindWidget + OptionalWidget=true. Made generating the Design time wrapper call a little more efficent, by optimizing it away by force inlining a noop. Also added some additional checking when we forcefully set focus in UMG, to help people catch cases where they set focus, but didn't make the widget focusable.
#rb none
Change 3085734 on 2016/08/11 by Nick.Darnell
Texture - Making GetDefaultMipMapBias a bit more efficent in the common case.
#rb none
Change 3085736 on 2016/08/11 by Nick.Darnell
Static Lighting - Warning the user when they build lighting, but have bForceNoPrecomputedLighting set to true on the world settings.
#rb none
Change 3085737 on 2016/08/11 by Nick.Darnell
Editor - code organization.
#rb none
Change 3085875 on 2016/08/11 by Nick.Darnell
UMG - You can now use 'G' to toggle game mode on the designer so that you can disable and enable the dashed lines around containers. The option in the settings is now used as the default when you startup a designer.
#rb none
Change 3086209 on 2016/08/11 by Ben.Salem
Make our automated test pass reporting more robust and pipe out to JSON in \saved\automation\logs\AutomationReport-{CL}-{Timestamp}.json format.
#rb adric.worley, william.ewen
Change 3086515 on 2016/08/11 by Nick.Darnell
Editor - Fixing a crash in the curve table customization. If the row doesn't exist, it would crash, we now protect against that case.
#rb Matt.Kuhlenschmidt
Change 3087216 on 2016/08/12 by Jamie.Dale
Fixed an issue where re-scanning a package file may leave old assets in the asset registry
We didn't used to clear out anything associated with the old package before scanning the file, which could result in old assets being left if they'd since been removed from the package.
This also exposes a PackageDeleted function to allow people to manually clear anything associated with a package (if doing some custom asset work).
#rb Andrew.Rodham
Change 3087219 on 2016/08/12 by Jamie.Dale
Updated TextRenderComponent to support multiple font pages
It used to use the correct UV data, but wouldn't set the correct texture page when rendering. It now creates MIDs for all of the texture pages used by the font, and will use these MIDs (which override the font page on the material) when rendering the text (batched on sequential index/vertex buffer data with the same texture page).
#rb Matt.Kuhlenschmidt
Change 3087308 on 2016/08/12 by Alex.Delesky
#jira UE-14727 - Support for editing TSet properties in the editor's Details panel has been added.
#rb Matt.Kuhlenschmidt
Change 3089140 on 2016/08/15 by Jamie.Dale
We now abort a directory watch if we lose access to the directory in question
This prevents an infinite loop in the call to MsgWaitForMultipleObjectsEx if a watched directory is deleted.
#jira UE-30172
#rb Andrew.Rodham
Change 3089148 on 2016/08/15 by Alexis.Matte
Allow fbx export of any actor type.
#rb none
#codereview dmitriy.dyomin
Change 3089211 on 2016/08/15 by Jamie.Dale
Unified access to the parent window for external dialogs
A lot of places used to ad-hoc use the MainFrame window, even when they had access to a widget that may be belong to a different window. This could cause issues where an external dialog could appear behind a modal UE4 window (as it would appear above the MainFrame), and be inaccessible.
You can now use IMainFrameModule::GetBestParentWindowHandleForDialogs to get the best window handle to use for an external dialog. This will either be the parent window for the given widget (if known), or failing that, the MainFrame window.
#rb Andrew.Rodham
Change 3089640 on 2016/08/15 by Jamie.Dale
Wrapped UMaterialExpression::MenuCategories in WITH_EDITORONLY_DATA to avoid gathering it for game-only loc
#rb none
Change 3089661 on 2016/08/15 by Nick.Darnell
Editor - There's a new view option "Show C++ Classes" in the content browser. Lets you hide all those C++ folders most folks probably don't care to see.
#rb none
Change 3089667 on 2016/08/15 by Cody.Albert
Updating RoutePointerUpEvent to call OnDrop for touch events when dragging
#jira UE-34709
#rb nick.darnell
Change 3089694 on 2016/08/15 by Jamie.Dale
Applied a fix to the ExcludeClasses setting in the loc gather
#rb none
Change 3089889 on 2016/08/15 by Nick.Darnell
Automation - Continued work on the screenshot portion of the automation system. Going to start using the adapter information in the screenshots taken, otherwise we can't accurately test a plethora of devices sharing the same OS, with different capabilities.
#rb none
Change 3090256 on 2016/08/16 by Nick.Darnell
Automation - working on screenshots.
#rb none
Change 3090322 on 2016/08/16 by Nick.Darnell
Automation - Adding modified screenshot function.
#rb none
Change 3090335 on 2016/08/16 by Nick.Darnell
Automation - The tests were determined to need to be shared afterall, but at least keeping them as plugins. Moved to Engine plugins.
#rb none
Change 3090881 on 2016/08/16 by Nick.Darnell
Automation - Moving the content over and fixing up some code so that the AutoRimport tests work as expected.
#rb none
Change 3090884 on 2016/08/16 by Nick.Darnell
Plugins - There's now support for generating a Content Only plugin from the new plugin wizard.
#rb none
Change 3090911 on 2016/08/16 by Nick.Darnell
Feature Packs - If there's an error loading a manifest, it's now an error, not a warning.
#rb none
Change 3090913 on 2016/08/16 by Jamie.Dale
Optimization and usability improvements of the MemoryProfiler2 tool
- Optimized the processing of the Callgraph, Histogram, and Short lived allocations views.
- The callgraph view is now using a virtualized tree view mapped to our own internal tree. This allows us to amortize the cost of adding nodes to the TreeView as the user views the nodes in the tree. In my own test, this took callgraph generation from ~45 seconds to ~5 seconds.
- The Histogram view was vastly optimized via the use of a HashSet on the callstack filter, and the batch addition of unsorted callstacks that are sorted once at the end. In my own test, this took histogram generation from ~15 minutes to ~2 seconds.
- The Short lived allocations view was optimized by avoiding redundant sorting, including maintaining a sorted order while inserting items, and instead doing a final sort at the end. The column selection was also optimized by avoiding copying the entire dataset just to resort it. In my own test, this took short lived allocation generation from ~1 minute to ~3 seconds.
- Added a user-configurable list of allocator functions to trim (which now includes FMemory and operator new by default, and produces much cleaner callstacks).
#jira UETOOL-948
#jira UETOOL-949
#rb James.Hopkin
Change 3090962 on 2016/08/16 by Jamie.Dale
Fixed double assignment of filter functions
#rb none
Change 3090989 on 2016/08/16 by Nick.Darnell
Editor - Attempting to fix the build, non-unity issue I suspect.
#rb none
Change 3091754 on 2016/08/17 by Nick.Darnell
FbxAutomationTestBuilder is now a plugin. Users won't see it unless they've enabled the plugin (so primarily internal QA). Reorganized the automation tools and testing menu to be a bit lower in the main menu, and gave them a more test sounding name. Additionally made some modifications to the workspace menu structure to allow generating just a subset of a workplace menu so that I could target where I wanted to insert all of the automation tool menu items, rather than just allowing the general placement of them under developer tools...etc.
#rb none
#codereview Alexis.Matte
Change 3091758 on 2016/08/17 by Nick.Darnell
Slate / Editor - Trying to make the editor less focus greedy. Now when there are notification popups and tabs attempt to grab your attention we now do a few activation ownership checks to ensure that it or a parent window actually owns activation. Not doing this has the nasty side effect of things like notifications and message log errors that popup while playing the game (if the game is in new window PIE), causing the game to be hidden, and focus returned to the editor. Ran into this a lot running the automation tests, the new PIE window that's launched to run tests is immediately hidden as soon as the tests log a warning or error or a notification about high res screenshots happens.
#rb none
#codereview Nick.Atamas,Matt.Kuhlenschmidt
Change 3091829 on 2016/08/17 by Nick.Darnell
Build - Attempting to repair the build.
#rb none
Change 3091920 on 2016/08/17 by Nick.Darnell
Build - Another attempt at fixing the mac build.
#rb none
Change 3093380 on 2016/08/18 by Matt.Kuhlenschmidt
Ignore group actors when checking for references to other actors when deleting. The check for references is designed for gameplay affecting references which groups are not. Having this show up for groups is annoying
#rb none
Change 3094474 on 2016/08/19 by Jamie.Dale
Fixed PS4 error when building with USE_MALLOC_PROFILER, and optimized symbol name resolution for a build with USE_MALLOC_PROFILER enabled
#jira UETOOL-951
#rb James.Hopkin
Change 3094581 on 2016/08/19 by Jamie.Dale
Added missing allocator filter needed by PS4 profiles
#rb none
Change 3094681 on 2016/08/19 by Richard.TalbotWatkin
Fixed issue where painting override vertex colors on a SpeedTree mesh would cause its wind animation to cease. The OverrideVertexColors vertex factory needed to be registered with the SpeedTree renderer.
#jira UE-32762 - Custom VertexPaint on SpeedTrees interferes with wind animation
#rb none
Change 3095163 on 2016/08/19 by Trung.Le
#jira UE-20849: Added tooltips to the inputs of the Material final result node
#rb matt.kuhlenschmidt
Change 3095285 on 2016/08/19 by Trung.Le
#jira UE-20849 In SGraphNodeMaterialResult, renamed ToolTip to ToolTipWidget so we're not hiding class member
#rb none
Change 3095344 on 2016/08/19 by Alexis.Matte
#jira UE-34690 When using the optionnal matrix to change the scene root node, we have to flush the fbx evaluation engine.
Add also a new option to allow the user to automatically convert the fbx scene to unreal unit (centimeter).
#rb none
#codereview matt.kuhlenschmidt
Change 3096162 on 2016/08/22 by Alexis.Matte
#jira UE-34763 Remove offending no-action combo box entry when the json file is readonly. Also clean up other combo box menu.
#rb none
#codereview matt.kuhlenschmidt
Change 3096261 on 2016/08/22 by Alexis.Matte
#jira UE-33121 Make sure re-import all and import all fix all the issue before starting the job. So it get not interrupt during the process.
#rb lina.halper
#codereview lina.halper
Change 3096344 on 2016/08/22 by Jamie.Dale
NSString conversion fix for UTF-32 strings containing characters outside of the BMP
#jira UE-33971
#rb Peter.Sauerbrei, James.Hopkin
Change 3096605 on 2016/08/22 by Alex.Delesky
#jira UE-34787 - Dropdown menus in standalone programs will now correctly display tooltips if they have any.
#rb Matt.Kuhlenschmidt
Change 3096615 on 2016/08/22 by Alex.Delesky
#jira UE-33334 - Scrolling up on the mouse wheel when using the orbit camera should no longer move away from the orbit point when the camera moves too close to the orbit origin.
#rb Matt.Kuhlenschmidt
Change 3096619 on 2016/08/22 by Alex.Delesky
#jira UE-34084 - Structs containing an enum with a value that contains a whitespace character will now serialize correctly when copied from the Details Panel.
#rb Matt.Kuhlenschmidt
Change 3097644 on 2016/08/23 by Matt.Kuhlenschmidt
PR #2729: Fix a typo in the comment (Contributed by adcentury)
#rb none
Change 3097648 on 2016/08/23 by Matt.Kuhlenschmidt
PR #2726: Undef unused macros (Contributed by shrimpy56)
#rb none
Change 3097697 on 2016/08/23 by Matt.Kuhlenschmidt
Guard against crash when details panels rebuild when their customizations have been torn down
https://jira.ol.epicgames.net/browse/UE-35048
#rb none
Change 3097757 on 2016/08/23 by Alex.Delesky
#jira UE-14727 - Support for editing TMap properties in the editor's Details panel has been added. This change also removes the Duplicate option from TSet elements, and disallows entry of duplicates elements into a TSet or duplicate keys into a TMap
#rb Matt.Kuhlenschmidt
Change 3098164 on 2016/08/23 by Alexis.Matte
#jira UE-34686 Fbx importer bImportMeshesInBoneHierarchy is used also by the animation.
#rb none
#codereview matt.kuhlenschmidt
Change 3098502 on 2016/08/23 by Alexis.Matte
#jira UE-30951 Fbx option dialog, we disable the option to bake pivot if transform vertex position is true
#rb none
#codereview matt.kuhlenschmidt
Change 3099986 on 2016/08/24 by Jamie.Dale
Fixing non-editor builds
#rb none
Change 3101138 on 2016/08/25 by Matt.Kuhlenschmidt
Fixed viewport redraw callback not being called when certian property modifications occur in the details panel (reset to default, array size changes, etc)
#rb none
Change 3101280 on 2016/08/25 by Jamie.Dale
Fixed crash when counting memory over internationalization meta-data
- The serialization code only used to handle loading or saving, now it handles loading or not loading.
- The Type of the meta-data wasn't set by all constructors. For safety it has been removed and replaced with a virtual function that the derived types override.
#rb James.Hopkin
Change 3101283 on 2016/08/25 by Jamie.Dale
MProf2 platform and symbol parsing improvements
- Updated ISymbolParser to work with lazy symbol resolution (handled via the UI when looking at full callstacks).
- Added a PS4 symbol parser which handles performing full file/line resolution for symbols.
- Removed all the V3 file format support and legacy platform handling.
- Optimized FStreamInfo.GetNameIndex so it can be used by the lazy symbol fixup.
#rb James.Hopkin
Change 3101586 on 2016/08/25 by Jamie.Dale
Small code cleanup and path normalization
#rb James.Hopkin
Change 3101837 on 2016/08/25 by Alexis.Matte
#jira UE-35101 we now store the sourceanimationname to retrieve the correct animtrack when re-importing animations
#rb none
#codereview matt.kuhlenschmidt
Change 3102537 on 2016/08/26 by Jamie.Dale
Fix for potential crash in FICUCamelCaseBreakIterator
In platforms with UTF-32 strings, the index returned by FICUTextCharacterIterator may not be in the same range as FString, so we need to call InternalIndexToSourceIndex to ensure that it is.
#rb James.Hopkin
Change 3102582 on 2016/08/26 by Matt.Kuhlenschmidt
Log the freetype version when it starts up (for debugging purposes)
#rb none
Change 3102657 on 2016/08/26 by Alexis.Matte
#jira UE-29177 When re-importing a texture we want to notify materials using this texture so they can recompile the shader.
#review-3101585 @uriel.doyon
#rb matt.kuhlenschmidt
Change 3102704 on 2016/08/26 by Jamie.Dale
Added symbol meta-data support to MProf2
You can now define platform specific meta-data using FPlatformStackWalk::GetSymbolMetaData, which is then stored within the generated .mprof file.
PS4 uses this meta-data to say where the original .self file can be found, so that MProf2 can usually automatically load the .self file without having to bother the user.
#rb James.Hopkin
Change 3102878 on 2016/08/26 by Matt.Kuhlenschmidt
Added support for outline fonts
- An outline size (in slate units), optional material and optional fill color can be specified with each font info.
- Outlines do not contribute to measurement directly so the text measuring and shaping methods have been modified to account for outlines
- Fixed a bug where font materials do not work properly if part of the font's rendered glyphs were in a different atlas
#rb jamie.dale
Change 3102879 on 2016/08/26 by Jamie.Dale
Bumped the MProf2 version so we can tell which build of the tool can load v6 mprof files
#rb none
Change 3102960 on 2016/08/26 by Alexis.Matte
build fix
#rb none
Change 3103032 on 2016/08/26 by Jamie.Dale
Fixed SEditableText and SMultiLineEditableText not setting the correct foreground color when painting
#jira UE-34936
#rb Matt.Kuhlenschmidt
Change 3103278 on 2016/08/26 by Jamie.Dale
Fixing Clang warnings
#rb none
Change 3104211 on 2016/08/29 by Ben.Marsh
Add build script for automated tests, and create settings file for Dev-Editor which adds an agent pool for running them.
#rb none
Change 3104290 on 2016/08/29 by Alex.Delesky
Adding additional documentation accessible from the editor for TSet and TMap properties, along with a quick clarification on container properties to let the user know what kind of container they're working with.
#rb Matt.Kuhlenschmidt
Change 3104292 on 2016/08/29 by Alex.Delesky
#jira UE-35039 - Command/Control user keybindings will no longer flip-flop when the editor is opened on Mac.
#rb Matt.Kuhlenschmidt
Change 3104294 on 2016/08/29 by Alex.Delesky
#jira UE-34952 - The user will no longer encounter an ensure when setting the value of Period equal to or less than 0 on the circular throbber widget
#rb Matt.Kuhlenschmidt
Change 3104295 on 2016/08/29 by Matt.Kuhlenschmidt
PR #2682: Remove unused bUseDesktopResolutionForFullscreen (Contributed by stfx)
#rb none
Change 3104296 on 2016/08/29 by Alex.Delesky
#jira UE-35160 - The Auto Distance Error for LOD meshes can now be set to any value larger than zero.
#rb Matt.Kuhlenschmidt
Change 3104348 on 2016/08/29 by Matt.Kuhlenschmidt
Added the ability to clear the preview mesh on a material instance. Previously there was no way to null it out.
#rb none
Change 3104355 on 2016/08/29 by Matt.Kuhlenschmidt
Guard against crash with invalid path to the default physical material. Just create a new one if it doesnt exist and warn about it.
#rb none
#jira UE-31865
Change 3104396 on 2016/08/29 by Ben.Marsh
Fix incrorrect agent names for running automated tests
Change 3104610 on 2016/08/29 by Alex.Delesky
Fix for AutomationTool compile editor from changes introduced today.
#rb None
Change 3104611 on 2016/08/29 by Michael.Dupuis
#jira UETOOL-253
#rb Alexis.Matte
Change 3105826 on 2016/08/30 by Gareth.Martin
Added console variables to discard grass and/or scalable foliage data on load
#jira UE-35086
#rb Benn
Change 3106126 on 2016/08/30 by Matt.Kuhlenschmidt
Eliminated bad code duplication between retainer widgets and element batcher
#rb none
#codereview nick.darnell
Change 3106449 on 2016/08/30 by Michael.Dupuis
#jira UETOOL-229 Added generic command icons used in Edit Menu (including contextual menu)
#rb Alexis.Matte
Change 3106966 on 2016/08/30 by Jamie.Dale
Fixed FApp::IsAuthorizedUser not considering the SessionOwner override
#rb Max.Preussner
Change 3107687 on 2016/08/31 by Michael.Dupuis
Checkout/Make Writable on proper config file
#rb Matt Kuhlenschmidt
Change 3107736 on 2016/08/31 by Matt.Kuhlenschmidt
Fixed mode typos in the lerp instruction
#rb none
Change 3107830 on 2016/08/31 by Matt.Kuhlenschmidt
Logging and guard against UEditorEngine::TeardownPlaySession crash.
#rb none
https://jira.ol.epicgames.net/browse/UE-35325
Change 3107912 on 2016/08/31 by Alex.Delesky
#jira UE-35181 - Normalizing paths when retrieving absolute filenames for source control operations.
#rb Matt.Kuhlenschmidt
Change 3107986 on 2016/08/31 by Matt.Kuhlenschmidt
Removed PropertyTestObject.h out of UnrealEd.h so you dont have to compile the entire editor when changing this one file.
#rb none
Change 3108027 on 2016/08/31 by Chris.Wood
Re-added lost doc comment for analytics event "Engine.AbnormalShutdown".
#rb none - just a comment in a cpp file
#codereview wes.hunt
Change 3108580 on 2016/08/31 by Mike.Fricker
Deleted the "Live Editor" plugins from UE4
- These were undocumented, buggy and never finished, and we have no plans to complete them
- Both the "LiveEditor" and "LiveEditorListenServer" plugins were deleted, along with related icon files
#codereview matt.kuhlenschmidt
#rb matt.kuhlenschmidt
Change 3108604 on 2016/08/31 by Mike.Fricker
Added new "MIDI Device" plugin (disabled by default)
- This is a simple MIDI interface that allows you to receive MIDI events from devices connected to your computer
- Currently only input is supported. In the future we might allow for output, as well.
- In Blueprints, here's how to use it:
- Look for "MIDI Device Manager" in the Blueprint RMB menu
- Call "Find MIDI Devices" to choose your favorite device. Break the "Found MIDI Device" struct to see what's available.
- Then call "Create MIDI Device Controller" for the device you want. Store that in a variable.
- On your MIDI Device Controller, bind your own Event to the "On MIDI Event" event. This will be called every game Tick when there is at least one new MIDI event to receive.
- Process the data passed into the Event to make your project do stuff!
- This plugin makes use of the "PortMidi" third party library (which already existed in UE4 -- it was used by the now-deprecated 'LiveEditor' plugin)
#codereview matt.kuhlenschmidt
#rb none
Change 3108760 on 2016/08/31 by Alexis.Matte
#jira UE-25840 Fbx export collision mesh, we now export collision: box, sphere, capsule and convex mesh. There is an option in the editor preference to enable the export of collisions, default value is false.
#rb none
#codereview matt.kuhlenschmidt
Change 3109006 on 2016/08/31 by Alex.Delesky
#ignore Source Control rename test - initial commit
Change 3109044 on 2016/08/31 by Alex.Delesky
#ignore Testing asset rename from P4 to observe correct behavior.
#rb none
Change 3109048 on 2016/08/31 by Alex.Delesky
#ignore Testing P4 rename to identify correct behavior
#rb none
Change 3110044 on 2016/09/01 by Gareth.Martin
Fixed painting foliage on blocking "query" actors not working
#jira UE-33852
#rb Allan.Bentham
Change 3110133 on 2016/09/01 by Alexis.Matte
Fix crash in function GetForceRecompileTextureIdsHash
#rb none
#codereview jamie.dale
Change 3111848 on 2016/09/02 by Mike.Fricker
MIDI Device plugin: Fixed compilation error on Clang compilers (Mac, Linux)
- Fixed bad enum cast
#rb none
Change 3111995 on 2016/09/02 by Michael.Dupuis
#jira UE-35263
Do not try selecting the actor if the actor is in the blueprint
Properly Refresh the ToopTip & Hyper Link to take into account blueprint recreation process
#rb Alexis Matte
Change 3112280 on 2016/09/02 by Michael.Dupuis
Call MakeWritable if source control fail
#rb Alexis Matte
Change 3112335 on 2016/09/02 by Cody.Albert
Updating cursor hiding logic to not improperly hide cursor when left clicking in ortho mode
#jira UE-35306
#rb none
Change 3112478 on 2016/09/02 by Alexis.Matte
#jira UE-20059 Use a base material to import fbx material.
#rb uriel.doyon
#codereview matt.kuhlenschmidt
#1468 Github pull request number
Change 3113912 on 2016/09/06 by Michael.Dupuis
#jira UE-32288 Fixed Console params display
#rb Alexis Matte
Change 3114026 on 2016/09/06 by Alex.Delesky
#jira UE-35123 - The Details panel in a Texture editor or Simple Asset editor window will no longer disappear when the inspected asset is imported again.
#rb Matt.Kuhlenschmidt
Change 3114032 on 2016/09/06 by Alex.Delesky
PR #2733: Improved the project launcher progress page (Contributed by projectgheist)
#jira UE-34027
#rb Matt.Kuhlenschmidt
Change 3114034 on 2016/09/06 by Alex.Delesky
#jira UE-35265 - Copying a comment node from a Material Function and pasting it inside a Material will no longer render the Material unsaveable
#rb Matt.Kuhlenschmidt
Change 3114071 on 2016/09/06 by Nick.Darnell
[AUTOMATED TEST] Automatic checkin, testing functionality.
Change 3114109 on 2016/09/06 by Nick.Darnell
[AUTOMATED TEST] Automatic checkin, testing functionality.
Change 3114562 on 2016/09/06 by Nick.Darnell
Adding LevelEditor to the FbxAutomationTestBuilder to fix a compiler issue.
#rb none
Change 3114701 on 2016/09/06 by Michael.Dupuis
#jira UE-31988 add const to all usage of TArray<ItemType>* as it was done in SListView
#rb Alexis Matte
Change 3114861 on 2016/09/06 by Matt.Kuhlenschmidt
Prevent non-thread safe slate code from running on the slate loading thread
#rb none
Change 3115698 on 2016/09/07 by Nick.Darnell
Make sure the commands are available - during functional testing that was found to not always be the case.
#rb none
Change 3115719 on 2016/09/07 by Nick.Darnell
Adding an IsRegistered command to commands.
#rb none
Change 3115721 on 2016/09/07 by Nick.Darnell
Adding a new built VirtualReality feature pack, this new one contains the update manifest that will parse correctly.
#rb none
Change 3115722 on 2016/09/07 by Nick.Darnell
IsBindWidgetProperty now returns false if the property passed in is null.
#rb none
Change 3115734 on 2016/09/07 by Alexis.Matte
#jira UE-30166 Support fbx sdk 2017
#rb none
Change 3115737 on 2016/09/07 by Nick.Darnell
Adding an image comparer for screenshots. Removing some content from EngineTest.
#rb none
Change 3115743 on 2016/09/07 by Nick.Darnell
Checkpointing a bunch of progress towards a screenshot comparison workflow that allows us to diff screenshots taken on various platforms and hardware. Disabling many tests that are not passing. Updating a few tests to log better errors, and fixed a few tests with easy bugs in them so they would start passing again. All editor tests currently passing!
#rb none
Change 3115748 on 2016/09/07 by Nick.Darnell
Making the RuntimeTests plugin a Developer module, so that it doesn't get included in shipping builds.
#rb none
Change 3115789 on 2016/09/07 by Jamie.Dale
We now favor Traditional Chinese for Hong Kong and Macau
#rb James.Hopkin
Change 3115799 on 2016/09/07 by Jamie.Dale
Removed validity check on source cultures when remapping, as platforms may use invalid cultures that need to be remapped
#rb James.Hopkin
Change 3115826 on 2016/09/07 by Nick.Darnell
Adding missing files.
#rb none
Change 3115838 on 2016/09/07 by Nick.Darnell
Back out revision 6 from //UE4/Dev-Editor/Engine/Source/Runtime/UMG/Public/Components/WidgetInteractionComponent.h
#rb none
Change 3116007 on 2016/09/07 by Alexis.Matte
build fix
#rb none
Change 3116057 on 2016/09/07 by Jamie.Dale
Fixed widget snapshot messages so they appear in the message debugger
#rb none
Change 3116112 on 2016/09/07 by Nick.Darnell
Removing the FbxAutomationBuilder file that go recreated on a merge from main.
#rb none
Change 3116365 on 2016/09/07 by Michael.Dupuis
#jira UE-20765 Added missing class flag to test (CLASS_CONFIG) and change a bit how the checkout/make writable work.
#codereview Matt.Kuhlenschmidt
#rb Alexis.Matte
Change 3116622 on 2016/09/07 by Alexis.Matte
#jira UE-35608 Use the same naming convention when trying to retrieve uv channel by name.
#rb matt.kuhlenschmidt
Change 3116638 on 2016/09/07 by Jamie.Dale
Ensured that manifests and archives don't try and load data that they can't parse
#rb none
Change 3117397 on 2016/09/08 by Gareth.Martin
Added rotate and blend support to the landscape mirror tool
#jira UE-34829
#rb Jack.Porter
Change 3117459 on 2016/09/08 by Gareth.Martin
Fixed crash saving a hidden landscape level with an offset (cloned from 4.13.1)
#jira UE-35301
#rb Jack.Porter
Change 3117462 on 2016/09/08 by Gareth.Martin
Fixed invisible landscape components and crashes when tessellation is enabled (cloned from 4.13.1)
#jira UE-35494
#rb Benn.Gallagher
Change 3117583 on 2016/09/08 by Nick.Darnell
Continued work on automation support for screenshot comparison, stubbing in a commandlet that can be run after automation tests that would perform the diffing. Need to finish rigging it up so that deltas and results can be dumped out somewhere and consumed by a tool to approve shots.
#rb none
Change 3117595 on 2016/09/08 by Nick.Darnell
Updating the build script for AutomatedTests, going to see if this works!
#rb none
Change 3117808 on 2016/09/08 by Nick.Darnell
Adding header includes for async.
#rb none
Change 3117812 on 2016/09/08 by Matt.Kuhlenschmidt
Partially taken from Pr 2381
Fixed Array Properties to handle duplicates properly and fixed Material Parameter Collection duplicate Guid problem.
#rb none
Change 3117851 on 2016/09/08 by Jamie.Dale
Silenced some redundant P4 errors that could be generated when running a stat update on a file
Some of the options produced errors when working with newly added files. These errors are now downgraded to infos like they are for the main stat command.
#rb Ben.Marsh
#codereview Thomas.Sarkanen
Change 3117853 on 2016/09/08 by Gareth.Martin
Clean up landscape includes and PCH
#rb steve.robb
Change 3117859 on 2016/09/08 by Alex.Delesky
#jira UE-35321 - Minimized windows will no longer act like they are visible when determining what widgets are currently underneath the mouse.
#rb Nick.Darnell
Change 3117997 on 2016/09/08 by Nick.Darnell
Updating the automation tests build script to use Editor-Cmd
#rb none
Change 3118005 on 2016/09/08 by Matt.Kuhlenschmidt
Properly reference graph node on material expressions so they are not GC'd while an expression still uses them
#jira UE-35362
#rb none
Change 3118043 on 2016/09/08 by Alex.Delesky
#jira UE-30649 - Removed unnecessary returns from UWidget API.
PR #2377: fix widget bug. (Contributed by dorgonman)
#rb none
Change 3118045 on 2016/09/08 by Matt.Kuhlenschmidt
Guard against crash saving config during level editor shutdown
#rb none
#jira UE-35605
Change 3118074 on 2016/09/08 by Matt.Kuhlenschmidt
PR #2783: Removed #pragme once from CPP files (Contributed by projectgheist)
#rb none
Change 3118078 on 2016/09/08 by Michael.Dupuis
#jira UE-32065 Removed the -windows that was added as a default option and add it simply if fullscreen is not specified
#rb Alexis.Matte
Change 3118080 on 2016/09/08 by Michael.Dupuis
#jira UE-31131 Do not show a contextual menu if the menu is empty
#rb Alexis.Matte
Change 3118087 on 2016/09/08 by Matt.Kuhlenschmidt
Constify this method
#rb none
Change 3118166 on 2016/09/08 by Nick.Darnell
Trying additional command options for the build machine for automation.
#rb none
Change 3118222 on 2016/09/08 by Matt.Kuhlenschmidt
Fix actor delete during mesh paint not working during undo
#rb none
#jira UE-35684
Change 3118298 on 2016/09/08 by Alexis.Matte
#jira UE-35302 Export all LODs for static mesh when there is no force LOD
#rb uriel.doyon
Change 3118325 on 2016/09/08 by Matt.Kuhlenschmidt
Fixed reset to default not appearing for slate brushes
#rb none
#jira UE-34958
Change 3119321 on 2016/09/09 by Matt.Kuhlenschmidt
Guard against crash with an invalid world trying to be opened from the content browser
#rb none
https://jira.ol.epicgames.net/browse/UE-35712
Change 3119433 on 2016/09/09 by Nick.Darnell
Removing a hack added by Paragon that prevents applications from resizing in real time as the user drags the size of the window around.
#rb Matt.Kuklenschmidt
#jira UE-35789
Change 3119448 on 2016/09/09 by Alex.Delesky
When simulating touch events using the mouse, clicking the mouse will no longer let a drag operation continue. This should also allow the finger that started a drag to continue dragging items until it is released from the surface.
#rb Nick.Darnell
Change 3119522 on 2016/09/09 by Jamie.Dale
Fixed FDetailCategoryImpl::ShouldBeExpanded not honoring bShouldBeInitiallyCollapsed when bRestoreExpansionState was true
#rb Matt.Kuhlenschmidt
Change 3119528 on 2016/09/09 by Jamie.Dale
Some UI re-work to the localization dashboard
This makes a better use of the available space, and will make it easier to make some other planned changes in the future.
#rb James.Hopkin
Change 3119861 on 2016/09/09 by Michael.Dupuis
#jira UE-9284 Added the Play/Stop button on the thumbnail
#rb Alexis.Matte
Change 3120027 on 2016/09/09 by Alexis.Matte
incorporate some fixes from licensee for LOD group re-import workflow
#jira UE-32268
#rb uriel.doyon
#codereview matt.kuhlenschmidt
Change 3120845 on 2016/09/12 by Gareth.Martin
Fixed crash in landscape editor when "Early Z" is enabled (cloned from 4.13.1)
#jira UE-35850
#rb Allan.Bentham
Change 3120980 on 2016/09/12 by Nick.Darnell
Adding a commandlet that is runnable for comparing screenshots. Adding comparing and exporting capability to the screenshot manager.
#rb none
Change 3120992 on 2016/09/12 by Alex.Delesky
#jira UE-35575 - TScriptInterface UProperties now have asset picker support.
#rb Matt.Kuhlenschmidt
Change 3121074 on 2016/09/12 by Michael.Dupuis
#jira UE-30092
Added path length in error message when typing
Added display of current filepath lenght for cooking
#rb Alexis.Matte
Change 3121113 on 2016/09/12 by Nick.Darnell
Adding some placeholder examples to show people how to author tests in EngineTest.
#rb none
Change 3121152 on 2016/09/12 by Gareth.Martin
Added TElementType, TIsContiguousContainer traits
Added GetData(), GetNum() generic functions
#rb Steve.Robb
Change 3121702 on 2016/09/12 by Jamie.Dale
Optimized a loop over a sorted list to instead use a binary search
This speeds up the short-lived allocation view generation.
We also now dump the exception information to the Trace log when in a non-debug build.
#rb James.Hopkin
Change 3121721 on 2016/09/12 by Jamie.Dale
We now set the window mode first when resizing the game viewport to ensure that the work area is correct
Fullscreen windows can affect the available work area size, which can break centering when moving between fullscreen and windowed mode.
#jira UE-32842
#rb Matt.Kuhlenschmidt
Change 3122578 on 2016/09/13 by Jamie.Dale
Small code clean up
Removed a use of the placement new style array addition.
#rb none
Change 3122634 on 2016/09/13 by Jamie.Dale
We now immediately update DefaultConfigCheckOutNeeded when checking out/making writable the config file, rather than wait for the text tick
#jira UE-34865
#rb James.Hopkin
Change 3122656 on 2016/09/13 by Jamie.Dale
Fixed array combo button not focusing its contents, which prevented the menu closing correctly
#jira UE-33667
#rb none
Change 3122661 on 2016/09/13 by Nick.Darnell
Checkpointing additional work on the screenshot compare dialog, moving some Directory path picker widget into a more common area. Moving some "Find the best top level window handle for this widget for dialogs' code out of the main frame module and into Slate Application where it probably belongs.
#rb none
Change 3122678 on 2016/09/13 by Jamie.Dale
Fixing CIS error on Clang
CoreUObject needs to be included before USTRUCT can be used.
#rb none
Change 3122686 on 2016/09/13 by Jamie.Dale
Fixing CIS error on Clang
CoreUObject needs to be included before UCLASS can be used.
#rb none
Change 3122728 on 2016/09/13 by Nick.Darnell
UMG - Exposing a trace channel for the WIC, defaults to Visibility. Improving how the WIC handles the cursor moving off the widget, it now maintains the last hit location rather than 0,0 which would cause things like dragged Sliders to reset to the left. Ideally - the WIC would know the underlying widget has capture and continue to fake collision against an imaginary plane to simulate a continuous surface.
#jira UE-35167
#rb none
Change 3122775 on 2016/09/13 by Nick.Darnell
Automation - Fixing an error with the ScreenshotTools plugin, needed to add an the include for Engine.h to the PCH.
#rb none
Change 3122779 on 2016/09/13 by Nick.Darnell
Widgetnimation - Exposing more of the class to C++.
#rb none
Change 3122793 on 2016/09/13 by Nick.Darnell
Fixing a crash in UWidgetComponent::UpdateRenderTarget updating a null material instance.
#jira UE-35796
#rb none
Change 3122834 on 2016/09/13 by Matt.Kuhlenschmidt
Fixed crash undoing moves after bsp creation
https://jira.ol.epicgames.net/browse/UE-35880
#rb none
Change 3122835 on 2016/09/13 by Nick.Darnell
Reverting changes to WIdgetAnimation
#rb none
Change 3122897 on 2016/09/13 by Matt.Kuhlenschmidt
Fixed non-editor compile error
#rb none
Change 3122988 on 2016/09/13 by Alexis.Matte
Material workflow refactor
#jira UETOOL-774
#rb matt.kuhlenschmidt
Change 3123006 on 2016/09/13 by Jamie.Dale
Fixed dynamic collections not returning anything
#jira UE-35869
#rb James.Hopkin
Change 3123145 on 2016/09/13 by Alexis.Matte
Fix fbx automation test. The test found a regression cause by CL: 3120027. In the case where we dont have a LODGroup we dont want to add LODs before the build.
#jira UE-32268
#rb none
#codereview matt.kuhlenschmidt
Change 3123148 on 2016/09/13 by Matt.Kuhlenschmidt
Fix fortnite compile error
#rb alexis.matte
Change 3123208 on 2016/09/13 by Jamie.Dale
The 'find culprit' dialog now honors the user choice
#rb RichTW
Change 3123545 on 2016/09/13 by Nick.Darnell
Slate - Adjusting the window dialog host finding code to do a better job of searching for slate windows and excluding popups and non-regular windows.
#rb none
Change 3124494 on 2016/09/14 by Jamie.Dale
Added ~ to the list of invalid characters for object/package names
#jira UE-12908
#rb Matt.Kuhlenschmidt
Change 3124513 on 2016/09/14 by Gareth.Martin
Implemented filter to allow painting foliage on other foliage
- Altered foliage filters so it will no longer paint on object types which don't have a filter, e.g. skeletal meshes
#rb Allan.Bentham
#2472
Change 3124523 on 2016/09/14 by Jamie.Dale
PR #2724: Fix ScrollBox right mouse/touch grab scrolling functionality (Contributed by aarmbruster)
#jira UE-34811
#jira UE-32082
#rb none
Change 3124607 on 2016/09/14 by Nick.Darnell
UMG - Adding BoundsScale support to the WidgetComponent's CalcBounds function.
#jira UE-35667
#rb none
Change 3124785 on 2016/09/14 by Gareth.Martin
Made some foliage functions editor-only to fix non-editor build
#rb none
Change 3124795 on 2016/09/14 by Gareth.Martin
Saved/loaded the new foliage filter
#rb Allan.Bentham
#2472
Change 3124915 on 2016/09/14 by Michael.Dupuis
#jira UE-19511
Add support for Add to source control on DefaultEditorPerProjectUserSettings file
Remove CheckoutNotice when not editing a DefaultXXXX.ini file
Edit proper config file either we're modifying settings from a Default file or Local user file
#codereview Matt.Kuhlenschmidt Max.Preussner
#rb Alexis.Matte
Change 3125266 on 2016/09/14 by Jamie.Dale
Fixed ULocalizationTarget::DeleteFiles not deleting cultures, and using SCC wrong
#rb none
Change 3125385 on 2016/09/14 by Matt.Kuhlenschmidt
Fix crash when using SaveAs to save over top of an existing level
#rb none
https://jira.ol.epicgames.net/browse/UE-35919
https://jira.ol.epicgames.net/browse/UE-35921
Change 3125487 on 2016/09/14 by Alexis.Matte
Fix cook content, regression induce by the material workflow refactor
#rb matt.kuhlenschmidt
Change 3126217 on 2016/09/15 by Gareth.Martin
Unset bHasPerInstanceHitProxies on landscape grass components, as they don't have individually editable instances
#rb Allan.Bentham
Change 3126311 on 2016/09/15 by Jamie.Dale
Placement mode fixes
- The display name is now cached correctly on construction, and the FPlaceableItem instance used with SPlacementAssetEntry is now const.
- Ensured that the ID used by FPlaceableItem could never overflow.
- Fixed some types being missing from the "All Classes" list.
- Fixed the escape key not cancelling the search.
#jira UE-35972
#rb James.Hopkin
Change 3126325 on 2016/09/15 by Jamie.Dale
Made sure that UWorld::GetAssetRegistryTags called its Super function so that properties tagged as AssetRegistrySearchable will be added.
#rb Andrew.Rodham
Change 3126403 on 2016/09/15 by Gareth.Martin
Added Find and Contains functions to TBitArray
#rb Steve.Robb
Change 3126405 on 2016/09/15 by Gareth.Martin
Allowed instances of Hierarchical Instanced Mesh Components to be moved around with the transform widget in the blueprint editor
- Just like regular instanced mesh components!
Also fixed not being able to move instances of an instanced mesh component when it is the root component
Also also fixed Hierarchical Instanced Mesh Components not flushing their async tree build on saving (this was causing log spam from PostLoad when dragging instances around as the blueprint would constantly reinstance the component before the async tree build had finished)
#jira UE-29357
#rb Allan.Bentham
Change 3126444 on 2016/09/15 by Jamie.Dale
Fixed the loc dashboard configs not working with SCC
This isn't a great solution, but the whole way the loc dashboard manages its config data is in need of an overhaul.
#rb none
Change 3126446 on 2016/09/15 by Jamie.Dale
Fixed loc dashboard game and engine targets sharing the same expansion settting
#rb none
Change 3126555 on 2016/09/15 by Chris.Wood
Removed WER from Windows crash handling. Crashes saved to log folder and passed to CRC with explicit path.
[UE-34470] - Investigate WER settings and if they can conflict with CRC on Windows
#rb Steve.Robb
Change 3126586 on 2016/09/15 by Gareth.Martin
Fixed missing landscape components when using a LODBias (cloned from 4.13.1)
#jira UE-35873
#rb Jack.Porter
Change 3126610 on 2016/09/15 by Jamie.Dale
Stopped PS4 from always staging all ICU data files
#rb Marcus.Wassmer
Change 3126779 on 2016/09/15 by Michael.Dupuis
#jira UE-32914 Improve the help text to provide usage examples and params
#rb Alexis.Matte
Change 3126849 on 2016/09/15 by Matt.Kuhlenschmidt
Fix font material and outline font material not being animatable in sequencer
#rb frank.fella
Change 3126858 on 2016/09/15 by Matt.Kuhlenschmidt
File not saved
#rb none
Change 3127001 on 2016/09/15 by Matt.Kuhlenschmidt
Fixed reset to default state still not appearing in all cases after changing a property.
#rb none
Change 3127038 on 2016/09/15 by Nick.Darnell
UMG - Improving focus setting for users on widgets. If we're unable to set the focus immediately, possibly because the user is setting focus in the Construct callback before the widget is in the tree, we now update the SlateOperations FReply on LocalPlayer to set focus next frame when it's more likely the widget will become focusable.
#rb none
Change 3127061 on 2016/09/15 by Nick.Darnell
Slate - We now have a reentrancy guard in TPanelChildren to avoid the broad cases where users might attempt to remove children while all children are being removed. Which is an easy case to engineer if you've got widgets spawning children managed by another widget, that all go away at the same time, thus causing the parent to attempt to cleanup children. The end result is a delete while deleting. So now TPanelChildren prevents adds/removes while emptying the list of children.
#jira UE-35726
#rb Matt.Kuchlenschmidt
Change 3127205 on 2016/09/15 by Alex.Delesky
#jira UE-18013 - Users can now add Textures, Materials, or Sprites to a Widget Blueprint directly from the content browser. This also fixes a few issues with adding Widget Blueprints to another Widget BP from the content browser, such as adding a widget to itself or creating a circular dependency.
#rb Nick.Darnell
Change 3127971 on 2016/09/16 by Matt.Kuhlenschmidt
Fix crash in scene outliner if actors become invalid
#rb none
https://jira.ol.epicgames.net/browse/UE-35932
Change 3128011 on 2016/09/16 by Matt.Kuhlenschmidt
Added guards for crashes accessing slate resources for deleted uobjects
#rb nick.darnell
Change 3128067 on 2016/09/16 by Michael.Dupuis
#jira UE-34158 Add an option to auto expand advanced details
#rb Alexis.Matte
Change 3128073 on 2016/09/16 by Michael.Dupuis
#jira UE-1145
Set Save As to Ctrl + Alt + S
Set Save All to Ctrl + Shift + S
Set Save Current to Ctrl + S
#rb Alexis.Matte
Change 3128117 on 2016/09/16 by Jamie.Dale
Updated the pin-type filter combo to filter on both the localized and source type descriptions
#jira UE-36081
#rb none
Change 3128177 on 2016/09/16 by Alexis.Matte
#jira UE-35946 Remove unnecessary GetReadValue call with bad parameter. The read value call is cache so subsequent call was returning the bad cache value.
#rb michael.dupuis
#codereview matt.kuhlenschmidt
Change 3128387 on 2016/09/16 by Gareth.Martin
Fixed location and rotation of arrow widget in the landscape mirror tool when using one of the new "Rotate" modes
#jira UE-36093
#rb none
Change 3128445 on 2016/09/16 by Matt.Kuhlenschmidt
Guard against scene outliner crash. Print out tree when items appear twice.
https://jira.ol.epicgames.net/browse/UE-35935
#rb none
Change 3128454 on 2016/09/16 by Matt.Kuhlenschmidt
Remove category for WindowTitleBarArea. It is very custom for internal use and should not be a top level widget
#rb none
Change 3128482 on 2016/09/16 by Michael.Dupuis
Added new key binding for generic Save, Save As
Added new key binding for Save All for the content browser
#rb Alexis.Matte (approved by MattK)
Change 3128560 on 2016/09/16 by Matt.Kuhlenschmidt
Fix build warning
#codereview nick.darnell
#rb none
Change 3128642 on 2016/09/16 by Alexis.Matte
#jira UE-36047 We now convert the light color correctly when importing and exporting fbx files. UE4 is sRGB and FBX is linear
#rb none
#codereview matt.kuhlenschmidt
Change 3128733 on 2016/09/16 by Nick.Darnell
UMG - Fixing a bad merge, some code was removed causing all BindWidget statements to fail to compile correctly.
#jira UE-36105
#rb none
Change 3128768 on 2016/09/16 by Matt.Kuhlenschmidt
Fix selection outline showing around edges of all internal mesh sections of a component instead of around the entire actor
#rb none
Change 3128779 on 2016/09/16 by Matt.Kuhlenschmidt
Fix offset characters on some small fonts
#rb none
Change 3130057 on 2016/09/19 by Jamie.Dale
Fixing volatility and invalidation issues for text widgets
#jira UE-33988
#rb Nick.Darnell
Change 3130064 on 2016/09/19 by Jamie.Dale
Changed mprof meta-data to allow unicode strings and updated ReadString to deal with them correctly
#rb James.Hopkin
Change 3130233 on 2016/09/19 by Michael.Dupuis
#jira UE-32914 Added missing args that the UI supported
#rb Alexis.Matte
Change 3130265 on 2016/09/19 by Nick.Darnell
Automation - Cleaning up some API items.
#rb none
Change 3130378 on 2016/09/19 by Matt.Kuhlenschmidt
Fix reentrancy saving assets while a prompt for checkout dialog is open
#rb none
Change 3130398 on 2016/09/19 by Jamie.Dale
Fixing UHT error when building
#rb none
Change 3132101 on 2016/09/20 by Nick.Darnell
UMG - Adding a toolbar option in the designer for the 'G' command, similar to 'Game View' in the level editor, it disables all the dashed lines / future editor visuals.
#rb none
Change 3132110 on 2016/09/20 by Nick.Darnell
PR #2792: ShowFlags for WidgetComponents (Contributed by projectgheist)
#jira UE-13770
#rb Nick.Darnell
Change 3132111 on 2016/09/20 by Nick.Darnell
UMG - The retainer now embeds a virtual window into the focus path so that paths are resolved correctly.
#rb none
Change 3132138 on 2016/09/20 by Michael.Dupuis
#jira UE-30945 Added missing PostEditComponentMove after drag is finished
#rb Alexis.Matte
Change 3132147 on 2016/09/20 by Michael.Dupuis
#jira UE-30866 Fixed the filter to work properly
#rb Alexis.Matte
Change 3132190 on 2016/09/20 by Matt.Kuhlenschmidt
Fix static analysis warnings in this file
#rb none
Change 3132231 on 2016/09/20 by Nick.Darnell
Slate - Updating the material blend states to match what is expected of Slate rendering, which differs a lot from the scene renderer with the way it treats alpha. This fixes translucent rendering with the retainer widget, users will need to set their materials to Alpha Composite though for it to behave as expected.
#jira UE-33285
#rb none
Change 3132255 on 2016/09/20 by Alex.Delesky
#jira UE-36048 - TMap and TSet properties are now disallowed from adding more children through the Details panel when they contain the dfault value for a key or element. Reset to Default is also no longer allowed on a Map or Set child when it will result in a second default value existing within the container.
#rb Matt.Kuhlenschmidt
Change 3132587 on 2016/09/20 by Mike.Fricker
MIDI Plugin: Fixed a CIS error in shipping configuration (introduced in CL 3108604)
#rb none
#lockdown matt.kuhlenschmidt
Change 3132623 on 2016/09/20 by Matt.Kuhlenschmidt
Fix crash opening the cooker settings
https://jira.it.epicgames.net/browse/UE-36197
#rb none
#lockdown nick.darnell
Change 3133144 on 2016/09/20 by Nick.Darnell
Build configuration for automation tests.
#rb none
#lockdown matt.kuhlenschmidt
Change 3133206 on 2016/09/20 by Matt.Kuhlenschmidt
Fix default material on odin text
#rb none
#lockdown nick.darnell
Change 3133913 on 2016/09/21 by Nick.Darnell
Back out revision 17 from //UE4/Dev-Editor/Engine/Source/Runtime/UMG/Private/Slate/SRetainerWidget.cpp
#rb none
#jira UE-36231
#lockdown matt.kuhlenschmidt
[CL 3133983 by Matt Kuhlenschmidt in Main branch]
2016-09-21 10:07:18 -04:00
|
|
|
FSlateApplication::Get().FindBestParentWindowHandleForDialogs(AsShared()),
|
2014-11-19 07:43:07 -05:00
|
|
|
LOCTEXT("OpenProjectBrowseTitle", "Open Project").ToString(),
|
|
|
|
|
DefaultBrowsePath,
|
|
|
|
|
TEXT(""),
|
|
|
|
|
LogVisualizer::LoadFileTypes,
|
|
|
|
|
EFileDialogFlags::None,
|
|
|
|
|
OpenFilenames
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (bOpened && OpenFilenames.Num() > 0)
|
|
|
|
|
{
|
2015-08-27 05:21:28 -04:00
|
|
|
OnNewWorld(GetWorldForGivenObject(nullptr));
|
2014-11-19 07:43:07 -05:00
|
|
|
for (int FilenameIndex = 0; FilenameIndex < OpenFilenames.Num(); ++FilenameIndex)
|
|
|
|
|
{
|
|
|
|
|
FString CurrentFileName = OpenFilenames[FilenameIndex];
|
|
|
|
|
const bool bIsBinaryFile = CurrentFileName.Find(TEXT(".bvlog")) != INDEX_NONE;
|
|
|
|
|
if (bIsBinaryFile)
|
|
|
|
|
{
|
|
|
|
|
FArchive* FileAr = IFileManager::Get().CreateFileReader(*CurrentFileName);
|
|
|
|
|
FVisualLoggerHelpers::Serialize(*FileAr, RecordedLogs);
|
|
|
|
|
FileAr->Close();
|
|
|
|
|
delete FileAr;
|
|
|
|
|
FileAr = NULL;
|
|
|
|
|
|
|
|
|
|
for (FVisualLogDevice::FVisualLogEntryItem& CurrentItem : RecordedLogs)
|
|
|
|
|
{
|
|
|
|
|
OnNewLogEntry(CurrentItem);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
bool SVisualLogger::HandleSaveCommandCanExecute() const
|
|
|
|
|
{
|
2015-08-27 05:21:28 -04:00
|
|
|
return FVisualLoggerDatabase::Get().NumberOfRows() > 0;
|
2014-11-19 07:43:07 -05:00
|
|
|
}
|
|
|
|
|
|
2015-05-27 09:20:05 -04:00
|
|
|
void SVisualLogger::HandleSaveAllCommandExecute()
|
|
|
|
|
{
|
|
|
|
|
HandleSaveCommand(true);
|
|
|
|
|
}
|
|
|
|
|
|
2014-11-19 07:43:07 -05:00
|
|
|
void SVisualLogger::HandleSaveCommandExecute()
|
2015-05-27 09:20:05 -04:00
|
|
|
{
|
|
|
|
|
HandleSaveCommand(false);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void SVisualLogger::HandleSaveCommand(bool bSaveAllData)
|
2014-11-19 07:43:07 -05:00
|
|
|
{
|
2015-08-27 05:21:28 -04:00
|
|
|
TArray<FName> SelectedRows;
|
|
|
|
|
if (!bSaveAllData)
|
2014-11-19 07:43:07 -05:00
|
|
|
{
|
2015-08-27 05:21:28 -04:00
|
|
|
SelectedRows = FVisualLoggerDatabase::Get().GetSelectedRows();
|
|
|
|
|
}
|
|
|
|
|
else
|
|
|
|
|
{
|
|
|
|
|
for (auto Iter(FVisualLoggerDatabase::Get().GetConstRowIterator()); Iter; ++Iter)
|
|
|
|
|
{
|
|
|
|
|
SelectedRows.Add((*Iter).GetOwnerName());
|
|
|
|
|
}
|
2014-11-19 07:43:07 -05:00
|
|
|
}
|
|
|
|
|
|
2015-08-27 05:21:28 -04:00
|
|
|
if (SelectedRows.Num())
|
2014-11-19 07:43:07 -05:00
|
|
|
{
|
|
|
|
|
// Prompt the user for the filenames
|
|
|
|
|
TArray<FString> SaveFilenames;
|
|
|
|
|
IDesktopPlatform* DesktopPlatform = FDesktopPlatformModule::Get();
|
|
|
|
|
bool bSaved = false;
|
|
|
|
|
if (DesktopPlatform)
|
|
|
|
|
{
|
|
|
|
|
const FString DefaultBrowsePath = FString::Printf(TEXT("%slogs/"), *FPaths::GameSavedDir());
|
|
|
|
|
bSaved = DesktopPlatform->SaveFileDialog(
|
Copying //UE4/Dev-Editor to //UE4/Dev-Main (Source: //UE4/Dev-Editor @ 3133954)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3077573 on 2016/08/04 by Nick.Darnell
Removing some unused code, adding additional needed modules to editor tests.
#rb none
Change 3077580 on 2016/08/04 by Nick.Darnell
Removing the test plugins, going to be recreating them in EngineTest.
Change 3082659 on 2016/08/09 by Nick.Darnell
Automation - Presets are now stored in json files stored in Config so they can be shared, and human readable. Working on screenshot automation, getting it where it needs to be to permit us to have repeatable tests for comarison. Removing the option to not take full size screenshots, that defeats the purpose of being able to compare them.
#rb none
Change 3082766 on 2016/08/09 by Jamie.Dale
Fixed crashes when dealing with code-points outside the BMP on platforms with UTF-32 FStrings
ICU always deals with its offsets as UTF-16 (as it always uses UTF-16 internally with icu::UnicodeString), so there were a couple of places in code (break iteration, and bidi detection) where we needed to adjust those UTF-16 offsets to UTF-32 offsets in the case where FString is UTF-32.
#jira UE-33971
#rb James.Hopkin
Change 3083067 on 2016/08/09 by Nick.Darnell
Automation - Working on screenshot support, system now allows a lot more customization in terms of how large the shot is.
#rb none
Change 3084475 on 2016/08/10 by Richard.TalbotWatkin
Fixed issue with ModelComponent replication in client/server PIE if BSP is rebuilt. ModelComponent now implements IsNameStableForNetworking and always returns true, as a level's model components will never be rebuilt during a game session. Brush poly normals are now only fixed up in Editor builds.
#jira UE-34391 - No run animation on client that is not focused when running 2 player and dedicated server
#codereview Matt.Kuhlenschmidt
#rb none
Change 3084661 on 2016/08/10 by Matt.Kuhlenschmidt
Added grayscale texture importing support
#rb none
Change 3084774 on 2016/08/10 by Cody.Albert
Adding controller support for ComboBox widget
#jira UE-33826
#rb nick.darnell
Change 3085716 on 2016/08/11 by Nick.Darnell
UMG - Taking the Widget Component and Widget Interaction Components out of experimental. Removed old importing support for upgrading ancient versions of widget components. Removing parbola distortion, as users can now do whatever they want in their custom MID they can override the widget with.
#rb none
Change 3085733 on 2016/08/11 by Nick.Darnell
UMG - Documenting the meta parameters allowed on widgets, like we do for regular UObjects. For binding widgets from blueprints you can now do BindWidget (unchanged), and to simplify binding widgets optionally, you can now just do (BindWidgetOptional), rather than the combination of BindWidget + OptionalWidget=true. Made generating the Design time wrapper call a little more efficent, by optimizing it away by force inlining a noop. Also added some additional checking when we forcefully set focus in UMG, to help people catch cases where they set focus, but didn't make the widget focusable.
#rb none
Change 3085734 on 2016/08/11 by Nick.Darnell
Texture - Making GetDefaultMipMapBias a bit more efficent in the common case.
#rb none
Change 3085736 on 2016/08/11 by Nick.Darnell
Static Lighting - Warning the user when they build lighting, but have bForceNoPrecomputedLighting set to true on the world settings.
#rb none
Change 3085737 on 2016/08/11 by Nick.Darnell
Editor - code organization.
#rb none
Change 3085875 on 2016/08/11 by Nick.Darnell
UMG - You can now use 'G' to toggle game mode on the designer so that you can disable and enable the dashed lines around containers. The option in the settings is now used as the default when you startup a designer.
#rb none
Change 3086209 on 2016/08/11 by Ben.Salem
Make our automated test pass reporting more robust and pipe out to JSON in \saved\automation\logs\AutomationReport-{CL}-{Timestamp}.json format.
#rb adric.worley, william.ewen
Change 3086515 on 2016/08/11 by Nick.Darnell
Editor - Fixing a crash in the curve table customization. If the row doesn't exist, it would crash, we now protect against that case.
#rb Matt.Kuhlenschmidt
Change 3087216 on 2016/08/12 by Jamie.Dale
Fixed an issue where re-scanning a package file may leave old assets in the asset registry
We didn't used to clear out anything associated with the old package before scanning the file, which could result in old assets being left if they'd since been removed from the package.
This also exposes a PackageDeleted function to allow people to manually clear anything associated with a package (if doing some custom asset work).
#rb Andrew.Rodham
Change 3087219 on 2016/08/12 by Jamie.Dale
Updated TextRenderComponent to support multiple font pages
It used to use the correct UV data, but wouldn't set the correct texture page when rendering. It now creates MIDs for all of the texture pages used by the font, and will use these MIDs (which override the font page on the material) when rendering the text (batched on sequential index/vertex buffer data with the same texture page).
#rb Matt.Kuhlenschmidt
Change 3087308 on 2016/08/12 by Alex.Delesky
#jira UE-14727 - Support for editing TSet properties in the editor's Details panel has been added.
#rb Matt.Kuhlenschmidt
Change 3089140 on 2016/08/15 by Jamie.Dale
We now abort a directory watch if we lose access to the directory in question
This prevents an infinite loop in the call to MsgWaitForMultipleObjectsEx if a watched directory is deleted.
#jira UE-30172
#rb Andrew.Rodham
Change 3089148 on 2016/08/15 by Alexis.Matte
Allow fbx export of any actor type.
#rb none
#codereview dmitriy.dyomin
Change 3089211 on 2016/08/15 by Jamie.Dale
Unified access to the parent window for external dialogs
A lot of places used to ad-hoc use the MainFrame window, even when they had access to a widget that may be belong to a different window. This could cause issues where an external dialog could appear behind a modal UE4 window (as it would appear above the MainFrame), and be inaccessible.
You can now use IMainFrameModule::GetBestParentWindowHandleForDialogs to get the best window handle to use for an external dialog. This will either be the parent window for the given widget (if known), or failing that, the MainFrame window.
#rb Andrew.Rodham
Change 3089640 on 2016/08/15 by Jamie.Dale
Wrapped UMaterialExpression::MenuCategories in WITH_EDITORONLY_DATA to avoid gathering it for game-only loc
#rb none
Change 3089661 on 2016/08/15 by Nick.Darnell
Editor - There's a new view option "Show C++ Classes" in the content browser. Lets you hide all those C++ folders most folks probably don't care to see.
#rb none
Change 3089667 on 2016/08/15 by Cody.Albert
Updating RoutePointerUpEvent to call OnDrop for touch events when dragging
#jira UE-34709
#rb nick.darnell
Change 3089694 on 2016/08/15 by Jamie.Dale
Applied a fix to the ExcludeClasses setting in the loc gather
#rb none
Change 3089889 on 2016/08/15 by Nick.Darnell
Automation - Continued work on the screenshot portion of the automation system. Going to start using the adapter information in the screenshots taken, otherwise we can't accurately test a plethora of devices sharing the same OS, with different capabilities.
#rb none
Change 3090256 on 2016/08/16 by Nick.Darnell
Automation - working on screenshots.
#rb none
Change 3090322 on 2016/08/16 by Nick.Darnell
Automation - Adding modified screenshot function.
#rb none
Change 3090335 on 2016/08/16 by Nick.Darnell
Automation - The tests were determined to need to be shared afterall, but at least keeping them as plugins. Moved to Engine plugins.
#rb none
Change 3090881 on 2016/08/16 by Nick.Darnell
Automation - Moving the content over and fixing up some code so that the AutoRimport tests work as expected.
#rb none
Change 3090884 on 2016/08/16 by Nick.Darnell
Plugins - There's now support for generating a Content Only plugin from the new plugin wizard.
#rb none
Change 3090911 on 2016/08/16 by Nick.Darnell
Feature Packs - If there's an error loading a manifest, it's now an error, not a warning.
#rb none
Change 3090913 on 2016/08/16 by Jamie.Dale
Optimization and usability improvements of the MemoryProfiler2 tool
- Optimized the processing of the Callgraph, Histogram, and Short lived allocations views.
- The callgraph view is now using a virtualized tree view mapped to our own internal tree. This allows us to amortize the cost of adding nodes to the TreeView as the user views the nodes in the tree. In my own test, this took callgraph generation from ~45 seconds to ~5 seconds.
- The Histogram view was vastly optimized via the use of a HashSet on the callstack filter, and the batch addition of unsorted callstacks that are sorted once at the end. In my own test, this took histogram generation from ~15 minutes to ~2 seconds.
- The Short lived allocations view was optimized by avoiding redundant sorting, including maintaining a sorted order while inserting items, and instead doing a final sort at the end. The column selection was also optimized by avoiding copying the entire dataset just to resort it. In my own test, this took short lived allocation generation from ~1 minute to ~3 seconds.
- Added a user-configurable list of allocator functions to trim (which now includes FMemory and operator new by default, and produces much cleaner callstacks).
#jira UETOOL-948
#jira UETOOL-949
#rb James.Hopkin
Change 3090962 on 2016/08/16 by Jamie.Dale
Fixed double assignment of filter functions
#rb none
Change 3090989 on 2016/08/16 by Nick.Darnell
Editor - Attempting to fix the build, non-unity issue I suspect.
#rb none
Change 3091754 on 2016/08/17 by Nick.Darnell
FbxAutomationTestBuilder is now a plugin. Users won't see it unless they've enabled the plugin (so primarily internal QA). Reorganized the automation tools and testing menu to be a bit lower in the main menu, and gave them a more test sounding name. Additionally made some modifications to the workspace menu structure to allow generating just a subset of a workplace menu so that I could target where I wanted to insert all of the automation tool menu items, rather than just allowing the general placement of them under developer tools...etc.
#rb none
#codereview Alexis.Matte
Change 3091758 on 2016/08/17 by Nick.Darnell
Slate / Editor - Trying to make the editor less focus greedy. Now when there are notification popups and tabs attempt to grab your attention we now do a few activation ownership checks to ensure that it or a parent window actually owns activation. Not doing this has the nasty side effect of things like notifications and message log errors that popup while playing the game (if the game is in new window PIE), causing the game to be hidden, and focus returned to the editor. Ran into this a lot running the automation tests, the new PIE window that's launched to run tests is immediately hidden as soon as the tests log a warning or error or a notification about high res screenshots happens.
#rb none
#codereview Nick.Atamas,Matt.Kuhlenschmidt
Change 3091829 on 2016/08/17 by Nick.Darnell
Build - Attempting to repair the build.
#rb none
Change 3091920 on 2016/08/17 by Nick.Darnell
Build - Another attempt at fixing the mac build.
#rb none
Change 3093380 on 2016/08/18 by Matt.Kuhlenschmidt
Ignore group actors when checking for references to other actors when deleting. The check for references is designed for gameplay affecting references which groups are not. Having this show up for groups is annoying
#rb none
Change 3094474 on 2016/08/19 by Jamie.Dale
Fixed PS4 error when building with USE_MALLOC_PROFILER, and optimized symbol name resolution for a build with USE_MALLOC_PROFILER enabled
#jira UETOOL-951
#rb James.Hopkin
Change 3094581 on 2016/08/19 by Jamie.Dale
Added missing allocator filter needed by PS4 profiles
#rb none
Change 3094681 on 2016/08/19 by Richard.TalbotWatkin
Fixed issue where painting override vertex colors on a SpeedTree mesh would cause its wind animation to cease. The OverrideVertexColors vertex factory needed to be registered with the SpeedTree renderer.
#jira UE-32762 - Custom VertexPaint on SpeedTrees interferes with wind animation
#rb none
Change 3095163 on 2016/08/19 by Trung.Le
#jira UE-20849: Added tooltips to the inputs of the Material final result node
#rb matt.kuhlenschmidt
Change 3095285 on 2016/08/19 by Trung.Le
#jira UE-20849 In SGraphNodeMaterialResult, renamed ToolTip to ToolTipWidget so we're not hiding class member
#rb none
Change 3095344 on 2016/08/19 by Alexis.Matte
#jira UE-34690 When using the optionnal matrix to change the scene root node, we have to flush the fbx evaluation engine.
Add also a new option to allow the user to automatically convert the fbx scene to unreal unit (centimeter).
#rb none
#codereview matt.kuhlenschmidt
Change 3096162 on 2016/08/22 by Alexis.Matte
#jira UE-34763 Remove offending no-action combo box entry when the json file is readonly. Also clean up other combo box menu.
#rb none
#codereview matt.kuhlenschmidt
Change 3096261 on 2016/08/22 by Alexis.Matte
#jira UE-33121 Make sure re-import all and import all fix all the issue before starting the job. So it get not interrupt during the process.
#rb lina.halper
#codereview lina.halper
Change 3096344 on 2016/08/22 by Jamie.Dale
NSString conversion fix for UTF-32 strings containing characters outside of the BMP
#jira UE-33971
#rb Peter.Sauerbrei, James.Hopkin
Change 3096605 on 2016/08/22 by Alex.Delesky
#jira UE-34787 - Dropdown menus in standalone programs will now correctly display tooltips if they have any.
#rb Matt.Kuhlenschmidt
Change 3096615 on 2016/08/22 by Alex.Delesky
#jira UE-33334 - Scrolling up on the mouse wheel when using the orbit camera should no longer move away from the orbit point when the camera moves too close to the orbit origin.
#rb Matt.Kuhlenschmidt
Change 3096619 on 2016/08/22 by Alex.Delesky
#jira UE-34084 - Structs containing an enum with a value that contains a whitespace character will now serialize correctly when copied from the Details Panel.
#rb Matt.Kuhlenschmidt
Change 3097644 on 2016/08/23 by Matt.Kuhlenschmidt
PR #2729: Fix a typo in the comment (Contributed by adcentury)
#rb none
Change 3097648 on 2016/08/23 by Matt.Kuhlenschmidt
PR #2726: Undef unused macros (Contributed by shrimpy56)
#rb none
Change 3097697 on 2016/08/23 by Matt.Kuhlenschmidt
Guard against crash when details panels rebuild when their customizations have been torn down
https://jira.ol.epicgames.net/browse/UE-35048
#rb none
Change 3097757 on 2016/08/23 by Alex.Delesky
#jira UE-14727 - Support for editing TMap properties in the editor's Details panel has been added. This change also removes the Duplicate option from TSet elements, and disallows entry of duplicates elements into a TSet or duplicate keys into a TMap
#rb Matt.Kuhlenschmidt
Change 3098164 on 2016/08/23 by Alexis.Matte
#jira UE-34686 Fbx importer bImportMeshesInBoneHierarchy is used also by the animation.
#rb none
#codereview matt.kuhlenschmidt
Change 3098502 on 2016/08/23 by Alexis.Matte
#jira UE-30951 Fbx option dialog, we disable the option to bake pivot if transform vertex position is true
#rb none
#codereview matt.kuhlenschmidt
Change 3099986 on 2016/08/24 by Jamie.Dale
Fixing non-editor builds
#rb none
Change 3101138 on 2016/08/25 by Matt.Kuhlenschmidt
Fixed viewport redraw callback not being called when certian property modifications occur in the details panel (reset to default, array size changes, etc)
#rb none
Change 3101280 on 2016/08/25 by Jamie.Dale
Fixed crash when counting memory over internationalization meta-data
- The serialization code only used to handle loading or saving, now it handles loading or not loading.
- The Type of the meta-data wasn't set by all constructors. For safety it has been removed and replaced with a virtual function that the derived types override.
#rb James.Hopkin
Change 3101283 on 2016/08/25 by Jamie.Dale
MProf2 platform and symbol parsing improvements
- Updated ISymbolParser to work with lazy symbol resolution (handled via the UI when looking at full callstacks).
- Added a PS4 symbol parser which handles performing full file/line resolution for symbols.
- Removed all the V3 file format support and legacy platform handling.
- Optimized FStreamInfo.GetNameIndex so it can be used by the lazy symbol fixup.
#rb James.Hopkin
Change 3101586 on 2016/08/25 by Jamie.Dale
Small code cleanup and path normalization
#rb James.Hopkin
Change 3101837 on 2016/08/25 by Alexis.Matte
#jira UE-35101 we now store the sourceanimationname to retrieve the correct animtrack when re-importing animations
#rb none
#codereview matt.kuhlenschmidt
Change 3102537 on 2016/08/26 by Jamie.Dale
Fix for potential crash in FICUCamelCaseBreakIterator
In platforms with UTF-32 strings, the index returned by FICUTextCharacterIterator may not be in the same range as FString, so we need to call InternalIndexToSourceIndex to ensure that it is.
#rb James.Hopkin
Change 3102582 on 2016/08/26 by Matt.Kuhlenschmidt
Log the freetype version when it starts up (for debugging purposes)
#rb none
Change 3102657 on 2016/08/26 by Alexis.Matte
#jira UE-29177 When re-importing a texture we want to notify materials using this texture so they can recompile the shader.
#review-3101585 @uriel.doyon
#rb matt.kuhlenschmidt
Change 3102704 on 2016/08/26 by Jamie.Dale
Added symbol meta-data support to MProf2
You can now define platform specific meta-data using FPlatformStackWalk::GetSymbolMetaData, which is then stored within the generated .mprof file.
PS4 uses this meta-data to say where the original .self file can be found, so that MProf2 can usually automatically load the .self file without having to bother the user.
#rb James.Hopkin
Change 3102878 on 2016/08/26 by Matt.Kuhlenschmidt
Added support for outline fonts
- An outline size (in slate units), optional material and optional fill color can be specified with each font info.
- Outlines do not contribute to measurement directly so the text measuring and shaping methods have been modified to account for outlines
- Fixed a bug where font materials do not work properly if part of the font's rendered glyphs were in a different atlas
#rb jamie.dale
Change 3102879 on 2016/08/26 by Jamie.Dale
Bumped the MProf2 version so we can tell which build of the tool can load v6 mprof files
#rb none
Change 3102960 on 2016/08/26 by Alexis.Matte
build fix
#rb none
Change 3103032 on 2016/08/26 by Jamie.Dale
Fixed SEditableText and SMultiLineEditableText not setting the correct foreground color when painting
#jira UE-34936
#rb Matt.Kuhlenschmidt
Change 3103278 on 2016/08/26 by Jamie.Dale
Fixing Clang warnings
#rb none
Change 3104211 on 2016/08/29 by Ben.Marsh
Add build script for automated tests, and create settings file for Dev-Editor which adds an agent pool for running them.
#rb none
Change 3104290 on 2016/08/29 by Alex.Delesky
Adding additional documentation accessible from the editor for TSet and TMap properties, along with a quick clarification on container properties to let the user know what kind of container they're working with.
#rb Matt.Kuhlenschmidt
Change 3104292 on 2016/08/29 by Alex.Delesky
#jira UE-35039 - Command/Control user keybindings will no longer flip-flop when the editor is opened on Mac.
#rb Matt.Kuhlenschmidt
Change 3104294 on 2016/08/29 by Alex.Delesky
#jira UE-34952 - The user will no longer encounter an ensure when setting the value of Period equal to or less than 0 on the circular throbber widget
#rb Matt.Kuhlenschmidt
Change 3104295 on 2016/08/29 by Matt.Kuhlenschmidt
PR #2682: Remove unused bUseDesktopResolutionForFullscreen (Contributed by stfx)
#rb none
Change 3104296 on 2016/08/29 by Alex.Delesky
#jira UE-35160 - The Auto Distance Error for LOD meshes can now be set to any value larger than zero.
#rb Matt.Kuhlenschmidt
Change 3104348 on 2016/08/29 by Matt.Kuhlenschmidt
Added the ability to clear the preview mesh on a material instance. Previously there was no way to null it out.
#rb none
Change 3104355 on 2016/08/29 by Matt.Kuhlenschmidt
Guard against crash with invalid path to the default physical material. Just create a new one if it doesnt exist and warn about it.
#rb none
#jira UE-31865
Change 3104396 on 2016/08/29 by Ben.Marsh
Fix incrorrect agent names for running automated tests
Change 3104610 on 2016/08/29 by Alex.Delesky
Fix for AutomationTool compile editor from changes introduced today.
#rb None
Change 3104611 on 2016/08/29 by Michael.Dupuis
#jira UETOOL-253
#rb Alexis.Matte
Change 3105826 on 2016/08/30 by Gareth.Martin
Added console variables to discard grass and/or scalable foliage data on load
#jira UE-35086
#rb Benn
Change 3106126 on 2016/08/30 by Matt.Kuhlenschmidt
Eliminated bad code duplication between retainer widgets and element batcher
#rb none
#codereview nick.darnell
Change 3106449 on 2016/08/30 by Michael.Dupuis
#jira UETOOL-229 Added generic command icons used in Edit Menu (including contextual menu)
#rb Alexis.Matte
Change 3106966 on 2016/08/30 by Jamie.Dale
Fixed FApp::IsAuthorizedUser not considering the SessionOwner override
#rb Max.Preussner
Change 3107687 on 2016/08/31 by Michael.Dupuis
Checkout/Make Writable on proper config file
#rb Matt Kuhlenschmidt
Change 3107736 on 2016/08/31 by Matt.Kuhlenschmidt
Fixed mode typos in the lerp instruction
#rb none
Change 3107830 on 2016/08/31 by Matt.Kuhlenschmidt
Logging and guard against UEditorEngine::TeardownPlaySession crash.
#rb none
https://jira.ol.epicgames.net/browse/UE-35325
Change 3107912 on 2016/08/31 by Alex.Delesky
#jira UE-35181 - Normalizing paths when retrieving absolute filenames for source control operations.
#rb Matt.Kuhlenschmidt
Change 3107986 on 2016/08/31 by Matt.Kuhlenschmidt
Removed PropertyTestObject.h out of UnrealEd.h so you dont have to compile the entire editor when changing this one file.
#rb none
Change 3108027 on 2016/08/31 by Chris.Wood
Re-added lost doc comment for analytics event "Engine.AbnormalShutdown".
#rb none - just a comment in a cpp file
#codereview wes.hunt
Change 3108580 on 2016/08/31 by Mike.Fricker
Deleted the "Live Editor" plugins from UE4
- These were undocumented, buggy and never finished, and we have no plans to complete them
- Both the "LiveEditor" and "LiveEditorListenServer" plugins were deleted, along with related icon files
#codereview matt.kuhlenschmidt
#rb matt.kuhlenschmidt
Change 3108604 on 2016/08/31 by Mike.Fricker
Added new "MIDI Device" plugin (disabled by default)
- This is a simple MIDI interface that allows you to receive MIDI events from devices connected to your computer
- Currently only input is supported. In the future we might allow for output, as well.
- In Blueprints, here's how to use it:
- Look for "MIDI Device Manager" in the Blueprint RMB menu
- Call "Find MIDI Devices" to choose your favorite device. Break the "Found MIDI Device" struct to see what's available.
- Then call "Create MIDI Device Controller" for the device you want. Store that in a variable.
- On your MIDI Device Controller, bind your own Event to the "On MIDI Event" event. This will be called every game Tick when there is at least one new MIDI event to receive.
- Process the data passed into the Event to make your project do stuff!
- This plugin makes use of the "PortMidi" third party library (which already existed in UE4 -- it was used by the now-deprecated 'LiveEditor' plugin)
#codereview matt.kuhlenschmidt
#rb none
Change 3108760 on 2016/08/31 by Alexis.Matte
#jira UE-25840 Fbx export collision mesh, we now export collision: box, sphere, capsule and convex mesh. There is an option in the editor preference to enable the export of collisions, default value is false.
#rb none
#codereview matt.kuhlenschmidt
Change 3109006 on 2016/08/31 by Alex.Delesky
#ignore Source Control rename test - initial commit
Change 3109044 on 2016/08/31 by Alex.Delesky
#ignore Testing asset rename from P4 to observe correct behavior.
#rb none
Change 3109048 on 2016/08/31 by Alex.Delesky
#ignore Testing P4 rename to identify correct behavior
#rb none
Change 3110044 on 2016/09/01 by Gareth.Martin
Fixed painting foliage on blocking "query" actors not working
#jira UE-33852
#rb Allan.Bentham
Change 3110133 on 2016/09/01 by Alexis.Matte
Fix crash in function GetForceRecompileTextureIdsHash
#rb none
#codereview jamie.dale
Change 3111848 on 2016/09/02 by Mike.Fricker
MIDI Device plugin: Fixed compilation error on Clang compilers (Mac, Linux)
- Fixed bad enum cast
#rb none
Change 3111995 on 2016/09/02 by Michael.Dupuis
#jira UE-35263
Do not try selecting the actor if the actor is in the blueprint
Properly Refresh the ToopTip & Hyper Link to take into account blueprint recreation process
#rb Alexis Matte
Change 3112280 on 2016/09/02 by Michael.Dupuis
Call MakeWritable if source control fail
#rb Alexis Matte
Change 3112335 on 2016/09/02 by Cody.Albert
Updating cursor hiding logic to not improperly hide cursor when left clicking in ortho mode
#jira UE-35306
#rb none
Change 3112478 on 2016/09/02 by Alexis.Matte
#jira UE-20059 Use a base material to import fbx material.
#rb uriel.doyon
#codereview matt.kuhlenschmidt
#1468 Github pull request number
Change 3113912 on 2016/09/06 by Michael.Dupuis
#jira UE-32288 Fixed Console params display
#rb Alexis Matte
Change 3114026 on 2016/09/06 by Alex.Delesky
#jira UE-35123 - The Details panel in a Texture editor or Simple Asset editor window will no longer disappear when the inspected asset is imported again.
#rb Matt.Kuhlenschmidt
Change 3114032 on 2016/09/06 by Alex.Delesky
PR #2733: Improved the project launcher progress page (Contributed by projectgheist)
#jira UE-34027
#rb Matt.Kuhlenschmidt
Change 3114034 on 2016/09/06 by Alex.Delesky
#jira UE-35265 - Copying a comment node from a Material Function and pasting it inside a Material will no longer render the Material unsaveable
#rb Matt.Kuhlenschmidt
Change 3114071 on 2016/09/06 by Nick.Darnell
[AUTOMATED TEST] Automatic checkin, testing functionality.
Change 3114109 on 2016/09/06 by Nick.Darnell
[AUTOMATED TEST] Automatic checkin, testing functionality.
Change 3114562 on 2016/09/06 by Nick.Darnell
Adding LevelEditor to the FbxAutomationTestBuilder to fix a compiler issue.
#rb none
Change 3114701 on 2016/09/06 by Michael.Dupuis
#jira UE-31988 add const to all usage of TArray<ItemType>* as it was done in SListView
#rb Alexis Matte
Change 3114861 on 2016/09/06 by Matt.Kuhlenschmidt
Prevent non-thread safe slate code from running on the slate loading thread
#rb none
Change 3115698 on 2016/09/07 by Nick.Darnell
Make sure the commands are available - during functional testing that was found to not always be the case.
#rb none
Change 3115719 on 2016/09/07 by Nick.Darnell
Adding an IsRegistered command to commands.
#rb none
Change 3115721 on 2016/09/07 by Nick.Darnell
Adding a new built VirtualReality feature pack, this new one contains the update manifest that will parse correctly.
#rb none
Change 3115722 on 2016/09/07 by Nick.Darnell
IsBindWidgetProperty now returns false if the property passed in is null.
#rb none
Change 3115734 on 2016/09/07 by Alexis.Matte
#jira UE-30166 Support fbx sdk 2017
#rb none
Change 3115737 on 2016/09/07 by Nick.Darnell
Adding an image comparer for screenshots. Removing some content from EngineTest.
#rb none
Change 3115743 on 2016/09/07 by Nick.Darnell
Checkpointing a bunch of progress towards a screenshot comparison workflow that allows us to diff screenshots taken on various platforms and hardware. Disabling many tests that are not passing. Updating a few tests to log better errors, and fixed a few tests with easy bugs in them so they would start passing again. All editor tests currently passing!
#rb none
Change 3115748 on 2016/09/07 by Nick.Darnell
Making the RuntimeTests plugin a Developer module, so that it doesn't get included in shipping builds.
#rb none
Change 3115789 on 2016/09/07 by Jamie.Dale
We now favor Traditional Chinese for Hong Kong and Macau
#rb James.Hopkin
Change 3115799 on 2016/09/07 by Jamie.Dale
Removed validity check on source cultures when remapping, as platforms may use invalid cultures that need to be remapped
#rb James.Hopkin
Change 3115826 on 2016/09/07 by Nick.Darnell
Adding missing files.
#rb none
Change 3115838 on 2016/09/07 by Nick.Darnell
Back out revision 6 from //UE4/Dev-Editor/Engine/Source/Runtime/UMG/Public/Components/WidgetInteractionComponent.h
#rb none
Change 3116007 on 2016/09/07 by Alexis.Matte
build fix
#rb none
Change 3116057 on 2016/09/07 by Jamie.Dale
Fixed widget snapshot messages so they appear in the message debugger
#rb none
Change 3116112 on 2016/09/07 by Nick.Darnell
Removing the FbxAutomationBuilder file that go recreated on a merge from main.
#rb none
Change 3116365 on 2016/09/07 by Michael.Dupuis
#jira UE-20765 Added missing class flag to test (CLASS_CONFIG) and change a bit how the checkout/make writable work.
#codereview Matt.Kuhlenschmidt
#rb Alexis.Matte
Change 3116622 on 2016/09/07 by Alexis.Matte
#jira UE-35608 Use the same naming convention when trying to retrieve uv channel by name.
#rb matt.kuhlenschmidt
Change 3116638 on 2016/09/07 by Jamie.Dale
Ensured that manifests and archives don't try and load data that they can't parse
#rb none
Change 3117397 on 2016/09/08 by Gareth.Martin
Added rotate and blend support to the landscape mirror tool
#jira UE-34829
#rb Jack.Porter
Change 3117459 on 2016/09/08 by Gareth.Martin
Fixed crash saving a hidden landscape level with an offset (cloned from 4.13.1)
#jira UE-35301
#rb Jack.Porter
Change 3117462 on 2016/09/08 by Gareth.Martin
Fixed invisible landscape components and crashes when tessellation is enabled (cloned from 4.13.1)
#jira UE-35494
#rb Benn.Gallagher
Change 3117583 on 2016/09/08 by Nick.Darnell
Continued work on automation support for screenshot comparison, stubbing in a commandlet that can be run after automation tests that would perform the diffing. Need to finish rigging it up so that deltas and results can be dumped out somewhere and consumed by a tool to approve shots.
#rb none
Change 3117595 on 2016/09/08 by Nick.Darnell
Updating the build script for AutomatedTests, going to see if this works!
#rb none
Change 3117808 on 2016/09/08 by Nick.Darnell
Adding header includes for async.
#rb none
Change 3117812 on 2016/09/08 by Matt.Kuhlenschmidt
Partially taken from Pr 2381
Fixed Array Properties to handle duplicates properly and fixed Material Parameter Collection duplicate Guid problem.
#rb none
Change 3117851 on 2016/09/08 by Jamie.Dale
Silenced some redundant P4 errors that could be generated when running a stat update on a file
Some of the options produced errors when working with newly added files. These errors are now downgraded to infos like they are for the main stat command.
#rb Ben.Marsh
#codereview Thomas.Sarkanen
Change 3117853 on 2016/09/08 by Gareth.Martin
Clean up landscape includes and PCH
#rb steve.robb
Change 3117859 on 2016/09/08 by Alex.Delesky
#jira UE-35321 - Minimized windows will no longer act like they are visible when determining what widgets are currently underneath the mouse.
#rb Nick.Darnell
Change 3117997 on 2016/09/08 by Nick.Darnell
Updating the automation tests build script to use Editor-Cmd
#rb none
Change 3118005 on 2016/09/08 by Matt.Kuhlenschmidt
Properly reference graph node on material expressions so they are not GC'd while an expression still uses them
#jira UE-35362
#rb none
Change 3118043 on 2016/09/08 by Alex.Delesky
#jira UE-30649 - Removed unnecessary returns from UWidget API.
PR #2377: fix widget bug. (Contributed by dorgonman)
#rb none
Change 3118045 on 2016/09/08 by Matt.Kuhlenschmidt
Guard against crash saving config during level editor shutdown
#rb none
#jira UE-35605
Change 3118074 on 2016/09/08 by Matt.Kuhlenschmidt
PR #2783: Removed #pragme once from CPP files (Contributed by projectgheist)
#rb none
Change 3118078 on 2016/09/08 by Michael.Dupuis
#jira UE-32065 Removed the -windows that was added as a default option and add it simply if fullscreen is not specified
#rb Alexis.Matte
Change 3118080 on 2016/09/08 by Michael.Dupuis
#jira UE-31131 Do not show a contextual menu if the menu is empty
#rb Alexis.Matte
Change 3118087 on 2016/09/08 by Matt.Kuhlenschmidt
Constify this method
#rb none
Change 3118166 on 2016/09/08 by Nick.Darnell
Trying additional command options for the build machine for automation.
#rb none
Change 3118222 on 2016/09/08 by Matt.Kuhlenschmidt
Fix actor delete during mesh paint not working during undo
#rb none
#jira UE-35684
Change 3118298 on 2016/09/08 by Alexis.Matte
#jira UE-35302 Export all LODs for static mesh when there is no force LOD
#rb uriel.doyon
Change 3118325 on 2016/09/08 by Matt.Kuhlenschmidt
Fixed reset to default not appearing for slate brushes
#rb none
#jira UE-34958
Change 3119321 on 2016/09/09 by Matt.Kuhlenschmidt
Guard against crash with an invalid world trying to be opened from the content browser
#rb none
https://jira.ol.epicgames.net/browse/UE-35712
Change 3119433 on 2016/09/09 by Nick.Darnell
Removing a hack added by Paragon that prevents applications from resizing in real time as the user drags the size of the window around.
#rb Matt.Kuklenschmidt
#jira UE-35789
Change 3119448 on 2016/09/09 by Alex.Delesky
When simulating touch events using the mouse, clicking the mouse will no longer let a drag operation continue. This should also allow the finger that started a drag to continue dragging items until it is released from the surface.
#rb Nick.Darnell
Change 3119522 on 2016/09/09 by Jamie.Dale
Fixed FDetailCategoryImpl::ShouldBeExpanded not honoring bShouldBeInitiallyCollapsed when bRestoreExpansionState was true
#rb Matt.Kuhlenschmidt
Change 3119528 on 2016/09/09 by Jamie.Dale
Some UI re-work to the localization dashboard
This makes a better use of the available space, and will make it easier to make some other planned changes in the future.
#rb James.Hopkin
Change 3119861 on 2016/09/09 by Michael.Dupuis
#jira UE-9284 Added the Play/Stop button on the thumbnail
#rb Alexis.Matte
Change 3120027 on 2016/09/09 by Alexis.Matte
incorporate some fixes from licensee for LOD group re-import workflow
#jira UE-32268
#rb uriel.doyon
#codereview matt.kuhlenschmidt
Change 3120845 on 2016/09/12 by Gareth.Martin
Fixed crash in landscape editor when "Early Z" is enabled (cloned from 4.13.1)
#jira UE-35850
#rb Allan.Bentham
Change 3120980 on 2016/09/12 by Nick.Darnell
Adding a commandlet that is runnable for comparing screenshots. Adding comparing and exporting capability to the screenshot manager.
#rb none
Change 3120992 on 2016/09/12 by Alex.Delesky
#jira UE-35575 - TScriptInterface UProperties now have asset picker support.
#rb Matt.Kuhlenschmidt
Change 3121074 on 2016/09/12 by Michael.Dupuis
#jira UE-30092
Added path length in error message when typing
Added display of current filepath lenght for cooking
#rb Alexis.Matte
Change 3121113 on 2016/09/12 by Nick.Darnell
Adding some placeholder examples to show people how to author tests in EngineTest.
#rb none
Change 3121152 on 2016/09/12 by Gareth.Martin
Added TElementType, TIsContiguousContainer traits
Added GetData(), GetNum() generic functions
#rb Steve.Robb
Change 3121702 on 2016/09/12 by Jamie.Dale
Optimized a loop over a sorted list to instead use a binary search
This speeds up the short-lived allocation view generation.
We also now dump the exception information to the Trace log when in a non-debug build.
#rb James.Hopkin
Change 3121721 on 2016/09/12 by Jamie.Dale
We now set the window mode first when resizing the game viewport to ensure that the work area is correct
Fullscreen windows can affect the available work area size, which can break centering when moving between fullscreen and windowed mode.
#jira UE-32842
#rb Matt.Kuhlenschmidt
Change 3122578 on 2016/09/13 by Jamie.Dale
Small code clean up
Removed a use of the placement new style array addition.
#rb none
Change 3122634 on 2016/09/13 by Jamie.Dale
We now immediately update DefaultConfigCheckOutNeeded when checking out/making writable the config file, rather than wait for the text tick
#jira UE-34865
#rb James.Hopkin
Change 3122656 on 2016/09/13 by Jamie.Dale
Fixed array combo button not focusing its contents, which prevented the menu closing correctly
#jira UE-33667
#rb none
Change 3122661 on 2016/09/13 by Nick.Darnell
Checkpointing additional work on the screenshot compare dialog, moving some Directory path picker widget into a more common area. Moving some "Find the best top level window handle for this widget for dialogs' code out of the main frame module and into Slate Application where it probably belongs.
#rb none
Change 3122678 on 2016/09/13 by Jamie.Dale
Fixing CIS error on Clang
CoreUObject needs to be included before USTRUCT can be used.
#rb none
Change 3122686 on 2016/09/13 by Jamie.Dale
Fixing CIS error on Clang
CoreUObject needs to be included before UCLASS can be used.
#rb none
Change 3122728 on 2016/09/13 by Nick.Darnell
UMG - Exposing a trace channel for the WIC, defaults to Visibility. Improving how the WIC handles the cursor moving off the widget, it now maintains the last hit location rather than 0,0 which would cause things like dragged Sliders to reset to the left. Ideally - the WIC would know the underlying widget has capture and continue to fake collision against an imaginary plane to simulate a continuous surface.
#jira UE-35167
#rb none
Change 3122775 on 2016/09/13 by Nick.Darnell
Automation - Fixing an error with the ScreenshotTools plugin, needed to add an the include for Engine.h to the PCH.
#rb none
Change 3122779 on 2016/09/13 by Nick.Darnell
Widgetnimation - Exposing more of the class to C++.
#rb none
Change 3122793 on 2016/09/13 by Nick.Darnell
Fixing a crash in UWidgetComponent::UpdateRenderTarget updating a null material instance.
#jira UE-35796
#rb none
Change 3122834 on 2016/09/13 by Matt.Kuhlenschmidt
Fixed crash undoing moves after bsp creation
https://jira.ol.epicgames.net/browse/UE-35880
#rb none
Change 3122835 on 2016/09/13 by Nick.Darnell
Reverting changes to WIdgetAnimation
#rb none
Change 3122897 on 2016/09/13 by Matt.Kuhlenschmidt
Fixed non-editor compile error
#rb none
Change 3122988 on 2016/09/13 by Alexis.Matte
Material workflow refactor
#jira UETOOL-774
#rb matt.kuhlenschmidt
Change 3123006 on 2016/09/13 by Jamie.Dale
Fixed dynamic collections not returning anything
#jira UE-35869
#rb James.Hopkin
Change 3123145 on 2016/09/13 by Alexis.Matte
Fix fbx automation test. The test found a regression cause by CL: 3120027. In the case where we dont have a LODGroup we dont want to add LODs before the build.
#jira UE-32268
#rb none
#codereview matt.kuhlenschmidt
Change 3123148 on 2016/09/13 by Matt.Kuhlenschmidt
Fix fortnite compile error
#rb alexis.matte
Change 3123208 on 2016/09/13 by Jamie.Dale
The 'find culprit' dialog now honors the user choice
#rb RichTW
Change 3123545 on 2016/09/13 by Nick.Darnell
Slate - Adjusting the window dialog host finding code to do a better job of searching for slate windows and excluding popups and non-regular windows.
#rb none
Change 3124494 on 2016/09/14 by Jamie.Dale
Added ~ to the list of invalid characters for object/package names
#jira UE-12908
#rb Matt.Kuhlenschmidt
Change 3124513 on 2016/09/14 by Gareth.Martin
Implemented filter to allow painting foliage on other foliage
- Altered foliage filters so it will no longer paint on object types which don't have a filter, e.g. skeletal meshes
#rb Allan.Bentham
#2472
Change 3124523 on 2016/09/14 by Jamie.Dale
PR #2724: Fix ScrollBox right mouse/touch grab scrolling functionality (Contributed by aarmbruster)
#jira UE-34811
#jira UE-32082
#rb none
Change 3124607 on 2016/09/14 by Nick.Darnell
UMG - Adding BoundsScale support to the WidgetComponent's CalcBounds function.
#jira UE-35667
#rb none
Change 3124785 on 2016/09/14 by Gareth.Martin
Made some foliage functions editor-only to fix non-editor build
#rb none
Change 3124795 on 2016/09/14 by Gareth.Martin
Saved/loaded the new foliage filter
#rb Allan.Bentham
#2472
Change 3124915 on 2016/09/14 by Michael.Dupuis
#jira UE-19511
Add support for Add to source control on DefaultEditorPerProjectUserSettings file
Remove CheckoutNotice when not editing a DefaultXXXX.ini file
Edit proper config file either we're modifying settings from a Default file or Local user file
#codereview Matt.Kuhlenschmidt Max.Preussner
#rb Alexis.Matte
Change 3125266 on 2016/09/14 by Jamie.Dale
Fixed ULocalizationTarget::DeleteFiles not deleting cultures, and using SCC wrong
#rb none
Change 3125385 on 2016/09/14 by Matt.Kuhlenschmidt
Fix crash when using SaveAs to save over top of an existing level
#rb none
https://jira.ol.epicgames.net/browse/UE-35919
https://jira.ol.epicgames.net/browse/UE-35921
Change 3125487 on 2016/09/14 by Alexis.Matte
Fix cook content, regression induce by the material workflow refactor
#rb matt.kuhlenschmidt
Change 3126217 on 2016/09/15 by Gareth.Martin
Unset bHasPerInstanceHitProxies on landscape grass components, as they don't have individually editable instances
#rb Allan.Bentham
Change 3126311 on 2016/09/15 by Jamie.Dale
Placement mode fixes
- The display name is now cached correctly on construction, and the FPlaceableItem instance used with SPlacementAssetEntry is now const.
- Ensured that the ID used by FPlaceableItem could never overflow.
- Fixed some types being missing from the "All Classes" list.
- Fixed the escape key not cancelling the search.
#jira UE-35972
#rb James.Hopkin
Change 3126325 on 2016/09/15 by Jamie.Dale
Made sure that UWorld::GetAssetRegistryTags called its Super function so that properties tagged as AssetRegistrySearchable will be added.
#rb Andrew.Rodham
Change 3126403 on 2016/09/15 by Gareth.Martin
Added Find and Contains functions to TBitArray
#rb Steve.Robb
Change 3126405 on 2016/09/15 by Gareth.Martin
Allowed instances of Hierarchical Instanced Mesh Components to be moved around with the transform widget in the blueprint editor
- Just like regular instanced mesh components!
Also fixed not being able to move instances of an instanced mesh component when it is the root component
Also also fixed Hierarchical Instanced Mesh Components not flushing their async tree build on saving (this was causing log spam from PostLoad when dragging instances around as the blueprint would constantly reinstance the component before the async tree build had finished)
#jira UE-29357
#rb Allan.Bentham
Change 3126444 on 2016/09/15 by Jamie.Dale
Fixed the loc dashboard configs not working with SCC
This isn't a great solution, but the whole way the loc dashboard manages its config data is in need of an overhaul.
#rb none
Change 3126446 on 2016/09/15 by Jamie.Dale
Fixed loc dashboard game and engine targets sharing the same expansion settting
#rb none
Change 3126555 on 2016/09/15 by Chris.Wood
Removed WER from Windows crash handling. Crashes saved to log folder and passed to CRC with explicit path.
[UE-34470] - Investigate WER settings and if they can conflict with CRC on Windows
#rb Steve.Robb
Change 3126586 on 2016/09/15 by Gareth.Martin
Fixed missing landscape components when using a LODBias (cloned from 4.13.1)
#jira UE-35873
#rb Jack.Porter
Change 3126610 on 2016/09/15 by Jamie.Dale
Stopped PS4 from always staging all ICU data files
#rb Marcus.Wassmer
Change 3126779 on 2016/09/15 by Michael.Dupuis
#jira UE-32914 Improve the help text to provide usage examples and params
#rb Alexis.Matte
Change 3126849 on 2016/09/15 by Matt.Kuhlenschmidt
Fix font material and outline font material not being animatable in sequencer
#rb frank.fella
Change 3126858 on 2016/09/15 by Matt.Kuhlenschmidt
File not saved
#rb none
Change 3127001 on 2016/09/15 by Matt.Kuhlenschmidt
Fixed reset to default state still not appearing in all cases after changing a property.
#rb none
Change 3127038 on 2016/09/15 by Nick.Darnell
UMG - Improving focus setting for users on widgets. If we're unable to set the focus immediately, possibly because the user is setting focus in the Construct callback before the widget is in the tree, we now update the SlateOperations FReply on LocalPlayer to set focus next frame when it's more likely the widget will become focusable.
#rb none
Change 3127061 on 2016/09/15 by Nick.Darnell
Slate - We now have a reentrancy guard in TPanelChildren to avoid the broad cases where users might attempt to remove children while all children are being removed. Which is an easy case to engineer if you've got widgets spawning children managed by another widget, that all go away at the same time, thus causing the parent to attempt to cleanup children. The end result is a delete while deleting. So now TPanelChildren prevents adds/removes while emptying the list of children.
#jira UE-35726
#rb Matt.Kuchlenschmidt
Change 3127205 on 2016/09/15 by Alex.Delesky
#jira UE-18013 - Users can now add Textures, Materials, or Sprites to a Widget Blueprint directly from the content browser. This also fixes a few issues with adding Widget Blueprints to another Widget BP from the content browser, such as adding a widget to itself or creating a circular dependency.
#rb Nick.Darnell
Change 3127971 on 2016/09/16 by Matt.Kuhlenschmidt
Fix crash in scene outliner if actors become invalid
#rb none
https://jira.ol.epicgames.net/browse/UE-35932
Change 3128011 on 2016/09/16 by Matt.Kuhlenschmidt
Added guards for crashes accessing slate resources for deleted uobjects
#rb nick.darnell
Change 3128067 on 2016/09/16 by Michael.Dupuis
#jira UE-34158 Add an option to auto expand advanced details
#rb Alexis.Matte
Change 3128073 on 2016/09/16 by Michael.Dupuis
#jira UE-1145
Set Save As to Ctrl + Alt + S
Set Save All to Ctrl + Shift + S
Set Save Current to Ctrl + S
#rb Alexis.Matte
Change 3128117 on 2016/09/16 by Jamie.Dale
Updated the pin-type filter combo to filter on both the localized and source type descriptions
#jira UE-36081
#rb none
Change 3128177 on 2016/09/16 by Alexis.Matte
#jira UE-35946 Remove unnecessary GetReadValue call with bad parameter. The read value call is cache so subsequent call was returning the bad cache value.
#rb michael.dupuis
#codereview matt.kuhlenschmidt
Change 3128387 on 2016/09/16 by Gareth.Martin
Fixed location and rotation of arrow widget in the landscape mirror tool when using one of the new "Rotate" modes
#jira UE-36093
#rb none
Change 3128445 on 2016/09/16 by Matt.Kuhlenschmidt
Guard against scene outliner crash. Print out tree when items appear twice.
https://jira.ol.epicgames.net/browse/UE-35935
#rb none
Change 3128454 on 2016/09/16 by Matt.Kuhlenschmidt
Remove category for WindowTitleBarArea. It is very custom for internal use and should not be a top level widget
#rb none
Change 3128482 on 2016/09/16 by Michael.Dupuis
Added new key binding for generic Save, Save As
Added new key binding for Save All for the content browser
#rb Alexis.Matte (approved by MattK)
Change 3128560 on 2016/09/16 by Matt.Kuhlenschmidt
Fix build warning
#codereview nick.darnell
#rb none
Change 3128642 on 2016/09/16 by Alexis.Matte
#jira UE-36047 We now convert the light color correctly when importing and exporting fbx files. UE4 is sRGB and FBX is linear
#rb none
#codereview matt.kuhlenschmidt
Change 3128733 on 2016/09/16 by Nick.Darnell
UMG - Fixing a bad merge, some code was removed causing all BindWidget statements to fail to compile correctly.
#jira UE-36105
#rb none
Change 3128768 on 2016/09/16 by Matt.Kuhlenschmidt
Fix selection outline showing around edges of all internal mesh sections of a component instead of around the entire actor
#rb none
Change 3128779 on 2016/09/16 by Matt.Kuhlenschmidt
Fix offset characters on some small fonts
#rb none
Change 3130057 on 2016/09/19 by Jamie.Dale
Fixing volatility and invalidation issues for text widgets
#jira UE-33988
#rb Nick.Darnell
Change 3130064 on 2016/09/19 by Jamie.Dale
Changed mprof meta-data to allow unicode strings and updated ReadString to deal with them correctly
#rb James.Hopkin
Change 3130233 on 2016/09/19 by Michael.Dupuis
#jira UE-32914 Added missing args that the UI supported
#rb Alexis.Matte
Change 3130265 on 2016/09/19 by Nick.Darnell
Automation - Cleaning up some API items.
#rb none
Change 3130378 on 2016/09/19 by Matt.Kuhlenschmidt
Fix reentrancy saving assets while a prompt for checkout dialog is open
#rb none
Change 3130398 on 2016/09/19 by Jamie.Dale
Fixing UHT error when building
#rb none
Change 3132101 on 2016/09/20 by Nick.Darnell
UMG - Adding a toolbar option in the designer for the 'G' command, similar to 'Game View' in the level editor, it disables all the dashed lines / future editor visuals.
#rb none
Change 3132110 on 2016/09/20 by Nick.Darnell
PR #2792: ShowFlags for WidgetComponents (Contributed by projectgheist)
#jira UE-13770
#rb Nick.Darnell
Change 3132111 on 2016/09/20 by Nick.Darnell
UMG - The retainer now embeds a virtual window into the focus path so that paths are resolved correctly.
#rb none
Change 3132138 on 2016/09/20 by Michael.Dupuis
#jira UE-30945 Added missing PostEditComponentMove after drag is finished
#rb Alexis.Matte
Change 3132147 on 2016/09/20 by Michael.Dupuis
#jira UE-30866 Fixed the filter to work properly
#rb Alexis.Matte
Change 3132190 on 2016/09/20 by Matt.Kuhlenschmidt
Fix static analysis warnings in this file
#rb none
Change 3132231 on 2016/09/20 by Nick.Darnell
Slate - Updating the material blend states to match what is expected of Slate rendering, which differs a lot from the scene renderer with the way it treats alpha. This fixes translucent rendering with the retainer widget, users will need to set their materials to Alpha Composite though for it to behave as expected.
#jira UE-33285
#rb none
Change 3132255 on 2016/09/20 by Alex.Delesky
#jira UE-36048 - TMap and TSet properties are now disallowed from adding more children through the Details panel when they contain the dfault value for a key or element. Reset to Default is also no longer allowed on a Map or Set child when it will result in a second default value existing within the container.
#rb Matt.Kuhlenschmidt
Change 3132587 on 2016/09/20 by Mike.Fricker
MIDI Plugin: Fixed a CIS error in shipping configuration (introduced in CL 3108604)
#rb none
#lockdown matt.kuhlenschmidt
Change 3132623 on 2016/09/20 by Matt.Kuhlenschmidt
Fix crash opening the cooker settings
https://jira.it.epicgames.net/browse/UE-36197
#rb none
#lockdown nick.darnell
Change 3133144 on 2016/09/20 by Nick.Darnell
Build configuration for automation tests.
#rb none
#lockdown matt.kuhlenschmidt
Change 3133206 on 2016/09/20 by Matt.Kuhlenschmidt
Fix default material on odin text
#rb none
#lockdown nick.darnell
Change 3133913 on 2016/09/21 by Nick.Darnell
Back out revision 17 from //UE4/Dev-Editor/Engine/Source/Runtime/UMG/Private/Slate/SRetainerWidget.cpp
#rb none
#jira UE-36231
#lockdown matt.kuhlenschmidt
[CL 3133983 by Matt Kuhlenschmidt in Main branch]
2016-09-21 10:07:18 -04:00
|
|
|
FSlateApplication::Get().FindBestParentWindowHandleForDialogs(AsShared()),
|
2014-11-19 07:43:07 -05:00
|
|
|
LOCTEXT("NewProjectBrowseTitle", "Choose a project location").ToString(),
|
|
|
|
|
DefaultBrowsePath,
|
|
|
|
|
TEXT(""),
|
|
|
|
|
LogVisualizer::SaveFileTypes,
|
|
|
|
|
EFileDialogFlags::None,
|
|
|
|
|
SaveFilenames
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (bSaved)
|
|
|
|
|
{
|
Copying //UE4/Dev-Framework to //UE4/Main @ 2830052
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2807479 on 2015/12/17 by Zak.Middleton
#ue4 - Optimize allocations in FFinalPostProcessSettings. Fix bug skipping an element when updating the ContributingCubemaps array if one is removed during an iteration.
#rb Aaron.Mcleran
#codereview Martin.Mittring
#jira UE-24485
Change 2807695 on 2015/12/17 by Aaron.McLeran
Changing the VolumeScale sound concurrency implementation to be a volume scalar on older sounds in a concurrency group rather than scale new sounds.
#rb zak.middleton
Change 2808628 on 2015/12/18 by Thomas.Sarkanen
Minor optimization: Dont call GetWorld() 3 times in a row in USceneComponent::ShouldRender()
#rb Martin.Wilson
Change 2810090 on 2015/12/21 by Ori.Cohen
Allow collision and trail particles to run off the game thread.
Clean up missing marshelled AsyncComponentToWorld
Change 2814518 on 2016/01/04 by Marc.Audy
Use Reset instead of Empty
Change 2814530 on 2016/01/04 by James.Golding
UE-2689 Hook up lots of new icons for component classes
#rb thomas.sarkanen
Change 2814665 on 2016/01/04 by Marc.Audy
PR #1860:Fix ChildActorComponent linking issue when extended from game (Contributed by lion03)
Change 2814686 on 2016/01/04 by Benn.Gallagher
Fix for radial force components applying impulses multiple times to destructible components
#rb Ori.Cohen
Change 2815221 on 2016/01/04 by Aaron.McLeran
UE-24528 Fixing focus-distance scaling and focus priority scaling working with concurrency settings.
USoundAttenuation:
- Added methods to SoundAttenuation to get focus, attenuation, and distance scale based on focus factor.
- Added NonFocusDistanceScale parameter to attenuation settings customization so its setable by users
USoundBase:
- Added function on USoundBase which checks IsLooping, which checks the duration
- Removed functions IsAudible and IsAudibleSimple from USoundBase since that functionality is accomplished differently and takes into account focus-distance scaling now.
FActiveSound:
- Caching values of FocusPriorityScale and FocusDistanceScale to Active sound so that can be used for audibility checks
- Included FocusDistanceScale when computing bIsAudible in Active sound
- Moved GetAttenuationListenerData and the accompanying private struct FAttenuationListenerData to FAudioDevice since the audio device and moved code which computes focus factor and geometry into FAudioDevice::GetFocusFactor since it needs to be computed before an active sound exist
FAudioDevice:
- Added SoundIsAudible function which queries a particular sound if its audible based on attenuation settings, focus factor, etc. Will optionally return computed MaxDistance to avoid recomputing it in certain cases.
- Added a few helper functions: FindClosestListenerIndex, GetAttenuationListenerData
- Added GetFocusFactor, which performs the vector math to determine focus factor (0.0 is in-focus, 1.0 is out of focus) for a given sound and listener and attenuation focus settings.
- Updated CreateComponent and PlaySoundAtLocation functions to use the new SoundIsAudible function rather than the old IsAudibleSimple
#rb zak.middleton
Change 2815694 on 2016/01/05 by thomas.sarkanen
Added test texture
Change 2815695 on 2016/01/05 by thomas.sarkanen
Modified test texture
Change 2815709 on 2016/01/05 by James.Golding
PR #1778 : New BP-callablle function AActor::WasRecentlyRendered, with optional tolerance in seconds
https://github.com/EpicGames/UnrealEngine/pull/1778
#github 1778
#jira UE-23674
#rb jurre.debaare
Change 2815711 on 2016/01/05 by James.Golding
PR #1534 : Add missing default tolerance value for FVector2D::Equal
https://github.com/EpicGames/UnrealEngine/pull/1534
#github 1534
#jira UE-20838
#rb jurre.debaare
Change 2815714 on 2016/01/05 by James.Golding
PR #1887 : Added 'Thickness' Parameter to all valid options in Draw Debug Helper
https://github.com/EpicGames/UnrealEngine/pull/1887
#github 1887
#jira UE-24802
#rb jurre.debaare
Change 2815725 on 2016/01/05 by James.Golding
Added comment that USkeletalMeshComponent::bEnablePhysicsOnDedicatedServer cannot be changed at runtime
#jira UE-20439
Change 2815813 on 2016/01/05 by Marc.Audy
Move dispatch of transition functions to new OnMatchStateSet virtual which is called from SetMatchState allowing subclasses to insert their own handling between the set of the variable and dispatch to GameState and Blueprints rather than having to override the entire function.
#codereview Peter.Knepley
Change 2815884 on 2016/01/05 by James.Golding
- Avoid PSC iterating over all particle emitters each tick to check for changes in DetailMode. Now remember global DetailMode when we last checked, and only iterate again if that has changed.
- Add 'WarmupTime' and 'CPUCollision' to Asset Registry Tags for Particle Systems
#rb simon.tovey
#codereview gil.gribb
Change 2816306 on 2016/01/05 by Marc.Audy
(4.11) Pass boolean to OnComponentDestroyed that indicates if the entire Actor's hierarchy is being destroyed. If so we can avoid doing a lot of expensive tear down, particularly detaching each component one at a time from the hierarchy and causing massive position/bounds updates.
#rb Zak.Middleton, James.Golding
2016-01-15 13:01:30 -05:00
|
|
|
if (SaveFilenames.Num() > 0 && SaveFilenames[0].IsEmpty() == false)
|
2014-11-19 07:43:07 -05:00
|
|
|
{
|
|
|
|
|
TArray<FVisualLogDevice::FVisualLogEntryItem> FrameCache;
|
Copying //UE4/Dev-Framework to //UE4/Main @ 2830052
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2807479 on 2015/12/17 by Zak.Middleton
#ue4 - Optimize allocations in FFinalPostProcessSettings. Fix bug skipping an element when updating the ContributingCubemaps array if one is removed during an iteration.
#rb Aaron.Mcleran
#codereview Martin.Mittring
#jira UE-24485
Change 2807695 on 2015/12/17 by Aaron.McLeran
Changing the VolumeScale sound concurrency implementation to be a volume scalar on older sounds in a concurrency group rather than scale new sounds.
#rb zak.middleton
Change 2808628 on 2015/12/18 by Thomas.Sarkanen
Minor optimization: Dont call GetWorld() 3 times in a row in USceneComponent::ShouldRender()
#rb Martin.Wilson
Change 2810090 on 2015/12/21 by Ori.Cohen
Allow collision and trail particles to run off the game thread.
Clean up missing marshelled AsyncComponentToWorld
Change 2814518 on 2016/01/04 by Marc.Audy
Use Reset instead of Empty
Change 2814530 on 2016/01/04 by James.Golding
UE-2689 Hook up lots of new icons for component classes
#rb thomas.sarkanen
Change 2814665 on 2016/01/04 by Marc.Audy
PR #1860:Fix ChildActorComponent linking issue when extended from game (Contributed by lion03)
Change 2814686 on 2016/01/04 by Benn.Gallagher
Fix for radial force components applying impulses multiple times to destructible components
#rb Ori.Cohen
Change 2815221 on 2016/01/04 by Aaron.McLeran
UE-24528 Fixing focus-distance scaling and focus priority scaling working with concurrency settings.
USoundAttenuation:
- Added methods to SoundAttenuation to get focus, attenuation, and distance scale based on focus factor.
- Added NonFocusDistanceScale parameter to attenuation settings customization so its setable by users
USoundBase:
- Added function on USoundBase which checks IsLooping, which checks the duration
- Removed functions IsAudible and IsAudibleSimple from USoundBase since that functionality is accomplished differently and takes into account focus-distance scaling now.
FActiveSound:
- Caching values of FocusPriorityScale and FocusDistanceScale to Active sound so that can be used for audibility checks
- Included FocusDistanceScale when computing bIsAudible in Active sound
- Moved GetAttenuationListenerData and the accompanying private struct FAttenuationListenerData to FAudioDevice since the audio device and moved code which computes focus factor and geometry into FAudioDevice::GetFocusFactor since it needs to be computed before an active sound exist
FAudioDevice:
- Added SoundIsAudible function which queries a particular sound if its audible based on attenuation settings, focus factor, etc. Will optionally return computed MaxDistance to avoid recomputing it in certain cases.
- Added a few helper functions: FindClosestListenerIndex, GetAttenuationListenerData
- Added GetFocusFactor, which performs the vector math to determine focus factor (0.0 is in-focus, 1.0 is out of focus) for a given sound and listener and attenuation focus settings.
- Updated CreateComponent and PlaySoundAtLocation functions to use the new SoundIsAudible function rather than the old IsAudibleSimple
#rb zak.middleton
Change 2815694 on 2016/01/05 by thomas.sarkanen
Added test texture
Change 2815695 on 2016/01/05 by thomas.sarkanen
Modified test texture
Change 2815709 on 2016/01/05 by James.Golding
PR #1778 : New BP-callablle function AActor::WasRecentlyRendered, with optional tolerance in seconds
https://github.com/EpicGames/UnrealEngine/pull/1778
#github 1778
#jira UE-23674
#rb jurre.debaare
Change 2815711 on 2016/01/05 by James.Golding
PR #1534 : Add missing default tolerance value for FVector2D::Equal
https://github.com/EpicGames/UnrealEngine/pull/1534
#github 1534
#jira UE-20838
#rb jurre.debaare
Change 2815714 on 2016/01/05 by James.Golding
PR #1887 : Added 'Thickness' Parameter to all valid options in Draw Debug Helper
https://github.com/EpicGames/UnrealEngine/pull/1887
#github 1887
#jira UE-24802
#rb jurre.debaare
Change 2815725 on 2016/01/05 by James.Golding
Added comment that USkeletalMeshComponent::bEnablePhysicsOnDedicatedServer cannot be changed at runtime
#jira UE-20439
Change 2815813 on 2016/01/05 by Marc.Audy
Move dispatch of transition functions to new OnMatchStateSet virtual which is called from SetMatchState allowing subclasses to insert their own handling between the set of the variable and dispatch to GameState and Blueprints rather than having to override the entire function.
#codereview Peter.Knepley
Change 2815884 on 2016/01/05 by James.Golding
- Avoid PSC iterating over all particle emitters each tick to check for changes in DetailMode. Now remember global DetailMode when we last checked, and only iterate again if that has changed.
- Add 'WarmupTime' and 'CPUCollision' to Asset Registry Tags for Particle Systems
#rb simon.tovey
#codereview gil.gribb
Change 2816306 on 2016/01/05 by Marc.Audy
(4.11) Pass boolean to OnComponentDestroyed that indicates if the entire Actor's hierarchy is being destroyed. If so we can avoid doing a lot of expensive tear down, particularly detaching each component one at a time from the hierarchy and causing massive position/bounds updates.
#rb Zak.Middleton, James.Golding
2016-01-15 13:01:30 -05:00
|
|
|
for (const FName& CurrentName : SelectedRows)
|
2014-11-19 07:43:07 -05:00
|
|
|
{
|
2015-08-27 05:21:28 -04:00
|
|
|
FVisualLoggerDBRow& DataRow = FVisualLoggerDatabase::Get().GetRowByName(CurrentName);
|
|
|
|
|
FrameCache.Append(DataRow.GetItems());
|
2014-11-19 07:43:07 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (FrameCache.Num())
|
|
|
|
|
{
|
|
|
|
|
FArchive* FileArchive = IFileManager::Get().CreateFileWriter(*SaveFilenames[0]);
|
Copying //UE4/Dev-Framework to //UE4/Main @ 2830052
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2807479 on 2015/12/17 by Zak.Middleton
#ue4 - Optimize allocations in FFinalPostProcessSettings. Fix bug skipping an element when updating the ContributingCubemaps array if one is removed during an iteration.
#rb Aaron.Mcleran
#codereview Martin.Mittring
#jira UE-24485
Change 2807695 on 2015/12/17 by Aaron.McLeran
Changing the VolumeScale sound concurrency implementation to be a volume scalar on older sounds in a concurrency group rather than scale new sounds.
#rb zak.middleton
Change 2808628 on 2015/12/18 by Thomas.Sarkanen
Minor optimization: Dont call GetWorld() 3 times in a row in USceneComponent::ShouldRender()
#rb Martin.Wilson
Change 2810090 on 2015/12/21 by Ori.Cohen
Allow collision and trail particles to run off the game thread.
Clean up missing marshelled AsyncComponentToWorld
Change 2814518 on 2016/01/04 by Marc.Audy
Use Reset instead of Empty
Change 2814530 on 2016/01/04 by James.Golding
UE-2689 Hook up lots of new icons for component classes
#rb thomas.sarkanen
Change 2814665 on 2016/01/04 by Marc.Audy
PR #1860:Fix ChildActorComponent linking issue when extended from game (Contributed by lion03)
Change 2814686 on 2016/01/04 by Benn.Gallagher
Fix for radial force components applying impulses multiple times to destructible components
#rb Ori.Cohen
Change 2815221 on 2016/01/04 by Aaron.McLeran
UE-24528 Fixing focus-distance scaling and focus priority scaling working with concurrency settings.
USoundAttenuation:
- Added methods to SoundAttenuation to get focus, attenuation, and distance scale based on focus factor.
- Added NonFocusDistanceScale parameter to attenuation settings customization so its setable by users
USoundBase:
- Added function on USoundBase which checks IsLooping, which checks the duration
- Removed functions IsAudible and IsAudibleSimple from USoundBase since that functionality is accomplished differently and takes into account focus-distance scaling now.
FActiveSound:
- Caching values of FocusPriorityScale and FocusDistanceScale to Active sound so that can be used for audibility checks
- Included FocusDistanceScale when computing bIsAudible in Active sound
- Moved GetAttenuationListenerData and the accompanying private struct FAttenuationListenerData to FAudioDevice since the audio device and moved code which computes focus factor and geometry into FAudioDevice::GetFocusFactor since it needs to be computed before an active sound exist
FAudioDevice:
- Added SoundIsAudible function which queries a particular sound if its audible based on attenuation settings, focus factor, etc. Will optionally return computed MaxDistance to avoid recomputing it in certain cases.
- Added a few helper functions: FindClosestListenerIndex, GetAttenuationListenerData
- Added GetFocusFactor, which performs the vector math to determine focus factor (0.0 is in-focus, 1.0 is out of focus) for a given sound and listener and attenuation focus settings.
- Updated CreateComponent and PlaySoundAtLocation functions to use the new SoundIsAudible function rather than the old IsAudibleSimple
#rb zak.middleton
Change 2815694 on 2016/01/05 by thomas.sarkanen
Added test texture
Change 2815695 on 2016/01/05 by thomas.sarkanen
Modified test texture
Change 2815709 on 2016/01/05 by James.Golding
PR #1778 : New BP-callablle function AActor::WasRecentlyRendered, with optional tolerance in seconds
https://github.com/EpicGames/UnrealEngine/pull/1778
#github 1778
#jira UE-23674
#rb jurre.debaare
Change 2815711 on 2016/01/05 by James.Golding
PR #1534 : Add missing default tolerance value for FVector2D::Equal
https://github.com/EpicGames/UnrealEngine/pull/1534
#github 1534
#jira UE-20838
#rb jurre.debaare
Change 2815714 on 2016/01/05 by James.Golding
PR #1887 : Added 'Thickness' Parameter to all valid options in Draw Debug Helper
https://github.com/EpicGames/UnrealEngine/pull/1887
#github 1887
#jira UE-24802
#rb jurre.debaare
Change 2815725 on 2016/01/05 by James.Golding
Added comment that USkeletalMeshComponent::bEnablePhysicsOnDedicatedServer cannot be changed at runtime
#jira UE-20439
Change 2815813 on 2016/01/05 by Marc.Audy
Move dispatch of transition functions to new OnMatchStateSet virtual which is called from SetMatchState allowing subclasses to insert their own handling between the set of the variable and dispatch to GameState and Blueprints rather than having to override the entire function.
#codereview Peter.Knepley
Change 2815884 on 2016/01/05 by James.Golding
- Avoid PSC iterating over all particle emitters each tick to check for changes in DetailMode. Now remember global DetailMode when we last checked, and only iterate again if that has changed.
- Add 'WarmupTime' and 'CPUCollision' to Asset Registry Tags for Particle Systems
#rb simon.tovey
#codereview gil.gribb
Change 2816306 on 2016/01/05 by Marc.Audy
(4.11) Pass boolean to OnComponentDestroyed that indicates if the entire Actor's hierarchy is being destroyed. If so we can avoid doing a lot of expensive tear down, particularly detaching each component one at a time from the hierarchy and causing massive position/bounds updates.
#rb Zak.Middleton, James.Golding
2016-01-15 13:01:30 -05:00
|
|
|
if (ensure(FileArchive))
|
|
|
|
|
{
|
|
|
|
|
FVisualLoggerHelpers::Serialize(*FileArchive, FrameCache);
|
|
|
|
|
FileArchive->Close();
|
|
|
|
|
delete FileArchive;
|
|
|
|
|
FileArchive = NULL;
|
|
|
|
|
}
|
|
|
|
|
else
|
|
|
|
|
{
|
|
|
|
|
UE_LOG(LogVisualLogger, Error, TEXT("Failed to create file \"%s\""), *SaveFilenames[0]);
|
|
|
|
|
}
|
2014-11-19 07:43:07 -05:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2015-01-07 08:06:36 -05:00
|
|
|
void SVisualLogger::ResetData()
|
|
|
|
|
{
|
2015-08-27 05:21:28 -04:00
|
|
|
bGotHistogramData = false;
|
|
|
|
|
OnPauseCacheForEntries.Reset();
|
|
|
|
|
|
|
|
|
|
FLogVisualizer::Get().Reset();
|
|
|
|
|
FVisualLoggerDatabase::Get().Reset();
|
Copying //UE4/Dev-Framework to Dev-Main (//UE4/Dev-Main)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2720406 on 2015/10/07 by Aaron.McLeran
Audio optimization
Don't search for nearest listener if there's only 1 listener.
Change 2720411 on 2015/10/07 by Aaron.McLeran
Fixing HRTF spatialization code with recent changes to stereo spatialization.
HRTF emitter posiition doesn't need to be converted to XAudio2 coordinates.
Change 2723829 on 2015/10/09 by Mieszko.Zielinski
Fixed NavigationSystem trying to set label of newly spawned navigation data #UE4
UE-21880
Change 2723873 on 2015/10/09 by Mieszko.Zielinski
Fixed a bug in FNavAgentProperties::IsEquivalent resulting in failing the test for FNavAgentProperties instances having default AgentStepHeight value (-1) #UE4
UE-21977
Change 2724834 on 2015/10/12 by Ori.Cohen
PR #1634: Add PxVehicleDriveNW support to PhysXVehicleManager.cpp (Contributed by zeduk)
Change 2724850 on 2015/10/12 by Marc.Audy
Fix sound not restarting in matinee preview when jumping back along timeline after reaching end
#codereview Nick.Darnell
Change 2726499 on 2015/10/13 by Ori.Cohen
Fix edge case where sphyl length and radius are 0 and they are not properly clamped to 0.1
Change 2726689 on 2015/10/13 by Marc.Audy
Make UPackage::PackageFlags private
Add debugging for UE-21181 to try and track down when EditorWorld's PackageFlags are getting flagged as PlayInEditor
#codereview Mike.Fricker
Change 2726862 on 2015/10/13 by Lukasz.Furman
removed unused code from DetourNavMeshQuery
#ue4 UE-21988
Change 2726888 on 2015/10/13 by Lukasz.Furman
fixed observer abort: both mode in behavior tree's cone check decorator
#ue4 UE-19375
Change 2726913 on 2015/10/13 by Lukasz.Furman
navmesh raycast will use nearest poly containing ray origin instead of just closest one
#ue4 UE-19334
Change 2726920 on 2015/10/13 by Marc.Audy
Re-unify ULevelStreaming::GetWorldAssetPackageName and GetWorldAssetPackageFName
#codereview Dmitriy.Dyomin, Bob.Tellez
Change 2726931 on 2015/10/13 by Lukasz.Furman
fixed missing Tick event in aborting behavior tree tasks from abandoned subtree
#ue4 UE-21777
Change 2728093 on 2015/10/14 by Ori.Cohen
Fix edge case of sphyl scale take two. The previous approach did double scaling
Change 2728577 on 2015/10/14 by Mieszko.Zielinski
Improved navmesh labeling condition #UE4
Change suggested by github user
#rb Lukasz.Furman
Change 2728587 on 2015/10/14 by Lukasz.Furman
fixed crowd simulation for auto possessed pawns placed on level
#ue4
#rb Mieszko.Zielinski
Change 2728629 on 2015/10/14 by Lukasz.Furman
fixed influence of navmesh edges on crowd simulation near end of path
#ue4 UE-21380
#rb Mieszko.Zielinski
Change 2728678 on 2015/10/14 by Lukasz.Furman
added Z check to detour's crowd avoidance segment gathering
#ue4 UE-20889
#rb Mieszko.Zielinski
Change 2728745 on 2015/10/14 by Lukasz.Furman
fixed copy&paste operation in behavior tree's composite decorators subgraphs
#ue4 UE-18740
Change 2729276 on 2015/10/14 by Stan.Melax
ensure all actors get recreated with new collision shape specification.
this wasn't being done for a couple of editing methods.
todo: this should be merged into 4.10
#UE-20961
#rb ori.cohen
Change 2730709 on 2015/10/15 by Marc.Audy
Prevent memory corruption when an invalid controller ID is passed in to the forcefeedback channel functions
#rb Lina.Halper
Change 2733590 on 2015/10/19 by Benn.Gallagher
Fixed various crashes when using undo and redo while manipulating state machines UE 22088
Change 2735143 on 2015/10/20 by Lukasz.Furman
clearing behavior tree debugger's state when displayed subtree becomes inactive
#ue4
#rb Mieszko.Zielinski
Change 2735144 on 2015/10/20 by Lukasz.Furman
rebuilding behavior tree graph node order when node is being moved
#ue4
#rb Mieszko.Zielinski
Change 2735403 on 2015/10/20 by sebastian.kowalczyk
Integrated fix for issue UE-18594 "Gameplay Debugger is hijacking the Canvas" issue from 4.10 (2735391). Extended previous fix to care about OSX users - it's possible to configure shortcuts in engine config file now (little different ones for osx platform).
Change 2736406 on 2015/10/21 by sebastian.kowalczyk
Added new GameplayDebugger as a plugin. Old gameplay debugger is still here to keep backward compatibility but it's deprecated now. Current projects should be moved to use new plugin soon.
Change 2736436 on 2015/10/21 by sebastian.kowalczyk
Fixed crash in gameplay debugger with player set as debug target.
Change 2736437 on 2015/10/21 by sebastian.kowalczyk
Added visual indicator around selected pawn to fix FORT-10273 issue. (FN is not using new gd plugin yet).
Change 2736489 on 2015/10/21 by sebastian.kowalczyk
Hide internal and debug hud classes from drop down lists.
Change 2736504 on 2015/10/21 by sebastian.kowalczyk
Fix for UE-18548 "EnableGDT does not work correctly in PIE".
Change 2736529 on 2015/10/21 by sebastian.kowalczyk
Fixed UE-18548 "EnableGDT does not work correctly in PIE"
Change 2736588 on 2015/10/21 by sebastian.kowalczyk
Removed old log visualizer classes.
Change 2736700 on 2015/10/21 by sebastian.kowalczyk
Fixed UE-19256 "Perception debug data doesn't get replicated by Gameplay Debuger" for old gameplay debugger module.
Change 2737180 on 2015/10/21 by Zak.Middleton
#ue4 - Fix UPrimitiveComponent::GetCollisionShape not correctly enforcing bounds limits.
#rb Aaron.Mcleran
#jira UE-22436
Change 2738084 on 2015/10/22 by sebastian.kowalczyk
Better indication of selected pawn for Gameplay Debugger.
Change 2738413 on 2015/10/22 by Marc.Audy
Disable duplication of worlds/maps via the content browser
#jira UE-22200
#rb James.Golding
Change 2739743 on 2015/10/23 by bruce.nesbit
UE-18707 - Issue with drawing material triangle on canvas #1387
Added DrawTriangleUsingVertexColor
Change 2739751 on 2015/10/23 by bruce.nesbit
Revised bShowDebugForReticleTarget should not be static #1539
Change 2739788 on 2015/10/23 by bruce.nesbit
Revised the 2 functions that used FTriangleRenderer::DrawTriangle to use FTriangleRenderer::DrawTriangleUsingVertexColor
Fixed compile error
Change 2739870 on 2015/10/23 by Marc.Audy
Avoid issues while detaching child components if OnAttachmentChange were to remove a sibling component itself.
#jira UE-22362
#rb Zak.Middleton
Change 2739882 on 2015/10/23 by sebastian.kowalczyk
Fix for UE-20901 "VisualLog redirections are broken after PIE finishes" issue.
Change 2740140 on 2015/10/23 by Marc.Audy
Ensure that components reregister tick functions after seamless travel
#jira UE-20892
#rb Zak.Middleton
Change 2740614 on 2015/10/23 by Ori.Cohen
Fix linker issues for people wanting to use physics lock lambdas
Change 2740674 on 2015/10/23 by Aaron.McLeran
Sound Focus Feature
Added new parameters to SoundAttenuation settings to allow audio to change behavior based on its angle to the listener
- Define the min/max azimuth angle to establish in-focus and non-focus regions
- Can scale the priority of a sound based on focus angle
- Can attenuate the volume of a sound based on focus angle
- Can scale the listener-emitter distance based on focus angle
- Distance scale is applied when determining max audible distance for USoundBase
- Can opt-out of focus effects for a sound at the USoundBase level
#rb Ryan.Vance
Change 2741542 on 2015/10/26 by Lukasz.Furman
lowered min value clamping in navigation filter properties
#ue4
#rb Mieszko.Zielinski
Change 2743227 on 2015/10/27 by Marc.Audy
Make ASceneCaptureCube subclassable outside of Engine module
#jira UE-22609
Make USceneCaptureComponentCube::UpdateContent callable outside of Engine module
#jira UE-22610
#rb Jeff.Farris
Change 2743255 on 2015/10/27 by Marc.Audy
Wrap FActorSpawnParameters class with deprecation warning disable pragma instead of hand implementing copy constructor
#rb Jeff.Farris
Change 2743729 on 2015/10/27 by Ori.Cohen
Fix case where we spawn and adjust location which gives us implicit velocity.
#codereview Stan.Melax
Change 2746135 on 2015/10/29 by sebastian.kowalczyk
Fixed UE-21668 "Saving log filters selected in LogVisualizer causes insane ini file sizes! And doesn't really work."
Change 2746437 on 2015/10/29 by Lukasz.Furman
pass on verifying behavior tree stack before accessing its elements
#ue4
#rb Mieszko.Zielinski
Change 2748028 on 2015/10/30 by sebastian.kowalczyk
Changed GameplayDebugger's console variable from gd.EQSOnHUD to ai.gd.EQSOnHUD" after suggestion with MieszkoZ.
Change 2748184 on 2015/10/30 by Aaron.McLeran
UE-22693 Fix for streaming bug
- 3rd decoded buffer in initial 3 buffers was not getting submitted to xaudio2 voice resulting in garbled/skipped audio.
- Wasn't able to repro the 'cannot read chunk' part of the bug
#rb ryan.vance
Change 2749255 on 2015/10/31 by sebastian.kowalczyk
Fixed ai.gd.EQSOnHUD console variable after rename from gd.EQSOnHUD.
Change 2749276 on 2015/10/31 by sebastian.kowalczyk
Added switch to toggle highlight of selected actor to GameplayDebugger.
Change 2749318 on 2015/10/31 by sebastian.kowalczyk
New Gameplay Debugger plugin can be used with old module simultaneously. It's best to configure different keyboard binding for plugin when using old module (it can be set in project settings, for new gameplay debugger plugin - when activated for project).
Change 2749337 on 2015/10/31 by sebastian.kowalczyk
Fixed GameplayDebugger compilation in shipping/test builds.
Change 2749376 on 2015/10/31 by sebastian.kowalczyk
Small clean-up in gameplay debugger class for BT.
Change 2749931 on 2015/11/02 by James.Golding
Add stats to ProcMeshComp
Change 2749932 on 2015/11/02 by James.Golding
Remove PhysicsThrusterComponent.h from Engine.h
Change 2749960 on 2015/11/02 by James.Golding
- Fix PS4 compile errors in ActiveSound.cpp
- Constructor order of FActiveSound
- Shadowed AudioComponent var in CheckOcclusion
#RB thomas.sarkanen
#codereview aaron.mcleran
Change 2749961 on 2015/11/02 by James.Golding
Fix PS4 compile errors in GameplayDebuggerBaseObject.cpp
- Shadowed DefaultContext function param, now just Context, which matches declaration
#RB thomas.sarkanen
#codereview sebastian.kowalczyk
Change 2750026 on 2015/11/02 by Thomas.Sarkanen
Anim Multithreading: thread-safety refactor
Segregated access to various parts of anim update data by spitting off a new proxy class (FAnimInstanceProxy) containing all data accessed in Update() and Evaluate() passes. Gated access to the proxy data on the game thread in a number of ways:
- Explicit access via GetValueOnGameThread() - this blocks on any existing task, completes and then allows control to return to the accessing function. This allows stuff like Blueprints to continue to operate as normal.
- Explicit access via GetValueOnAnyThread() - this ensures that in the limited set of circumstances we need this (Blueprint pure functions mostly) that conditions are met about concurrent access.
- Deprecating many APIs on UAnimInstance that should not be used (and in fact are not used at present, happily).
Derived classes of UAnimInstance can override the creation of the proxy class to create their own type. We do this for UAnimSingleNodeInstance etc.
Any API deprecation should continue to function - no functions have been removed yet. The only things that are not backwards-compatible are direct access to some public member variables for which there is no way to support (e.g. via references, for example UngroupedActivePlayerArrays).
Some APIs have been changed to more specifically represent the dependencies involved. For example TickAssetPlayerInstance() used to take a UAnimInstance*, only to use it to simply queue notifies. This has been deprecated and replaced with a new FNotifyQueue API. FNotifyQueue also uses a thread-safe FRandomStream instead of FMath::Rand.
Many changes are due to substituting accessor functions for direct variable access.
Removed 'service' tick group as we no longer need to segregate the running of our parallel update.
Anim nodes that need to do some game thread-side update should register for a pre-update callback delegate in the proxy. See FAnimNode_AnimDynamics for an example of this.
Moved UpdateActiveVertexAnims into FAnimRuntime so I can subsume some of the code that was in USkeletalMeshComponent::EvaluateAnimation into UAnimInstance (and hence keep the proxy access private).
#rb Martin.Wilson,Lina.Halper
#codereview Michael.Noland
Change 2750077 on 2015/11/02 by Marc.Audy
Expose UInputComponent::BindAction that supports WithKey delegate signature
Change 2751767 on 2015/11/03 by Thomas.Sarkanen
Added extra support to Anim Blueprint 'fast-path'
Added support for negated bools (value gets negated during copy).
Added support for copying from struct members (via break struct) and split struct pins.
Removed potentially troublesome references to BP-constructed UProperties, replacing them with the property FName. This adds some extra Initialize() overhead, but prevents various crash-on load issues (one when generating the class CRC). Added guard to prevent multiple initialization to save this more expensive work being done more often.
#rb Martin.Wilson
Change 2752158 on 2015/11/03 by Jeff.Farris
Fixed UGameplayStatics::SpawnEmitterAttached() to register the ParticleSystemComponent after it spawns.
#rb marc.audy
Change 2752159 on 2015/11/03 by Jeff.Farris
Improvements to camera lens effects to (EmitterCameraLensEffectBase)
- can now specify a transform to align the emitter with the camera
- exposed several key parameters to Blueprints
- ENGINE_API now applies to the entire class
#rb marc.audy
Change 2753454 on 2015/11/04 by Thomas.Sarkanen
Fixup deprecation warnings fallout from multithreaded update changes.
Fixed up use of AnimInstance in Vicon plugin.
Fixed up use of AnimInstance in slope warping node.
Un-deprecated some APIs to become warning free (these APIs are safe to call but just a 'bad idea if you want to do it right').
Also an extra API to allow for smoother transition: Allow custom allocation/deallocation (including using a proxy member struct) by providing an override point for proxy destruction.
#rb Martin.Wilson
Change 2754099 on 2015/11/04 by Ori.Cohen
Fix for task threads dropping stats (from Gil)
#rb Gil.Gribb
Change 2754449 on 2015/11/04 by Marc.Audy
Ensure that components created from an Actor's blueprint BeginPlay implementation get BeginPlay called on them and register their component ticks
#jira UE-20853
Reorganize some booleans to get better bit packing
#rb Jeff.Farris
#codereview Mieszko.Zielinski
Change 2754573 on 2015/11/04 by Aaron.McLeran
Fixing audio component PostLoad code to not set all LowPassFilterFrequency values to 0.0f
Change 2755345 on 2015/11/05 by Thomas.Sarkanen
Added deprecated constructors for various animation contexts
Allows existing code to compile if it creates its own contexts from UAnimInstance.
#rb James.Golding
Change 2755348 on 2015/11/05 by James.Golding
Add BP-exposed SetBoundsScale function to PrimitiveComponent
#RB thomas.sarkanen
Change 2755437 on 2015/11/05 by Marc.Audy
Fix compile errors
#codereview Thomas.Sarkanen, Mieszko.Zielinski, Aaron.McLeran
Change 2755982 on 2015/11/05 by Marc.Audy
Move HeaderParse changes for deprecation macro from Core
Fix world settings warning
Change 2756028 on 2015/11/05 by Marc.Audy
Fix shadow variable issue
Change 2756090 on 2015/11/05 by Ori.Cohen
Improve budget tool so that task threads are computed automatically.
#rb Gil.Gribb
Change 2756120 on 2015/11/05 by Mieszko.Zielinski
Fixed AIController::MoveTo not using DefaultQueryExtent of its navigation data #UE4
#rb Lukasz.Furman
Change 2756243 on 2015/11/05 by Mieszko.Zielinski
Fixed AI perception sight's "auto-visibility" mechanism totally skipping distance and vision cone checks #UE4
The old way was resulting in false positives when for example observer teleported somewhere far
#rb Lukasz.Furman
#codereview John.Abercrombie
Change 2756280 on 2015/11/05 by Mieszko.Zielinski
Minor VLog code cleanup and dumb-fixing visual logger accessing timer manager off of game thread #UE4
#rb Lukasz.Furman
Change 2756500 on 2015/11/05 by Mieszko.Zielinski
Added sanity-checking to BlueprintNodeHelpers::HasBlueprintFunction and cleaned up its usage #UE4
Also, refactored its parameters into references over pointers.
#rb Lukasz.Furman
Change 2757041 on 2015/11/06 by Thomas.Sarkanen
Removed check() in UAnimInstance::GetProxyOnAnyThread()
The check was no longer needed as if we are on the game thread we block until tasks are completed below, and if we are on any other thread we are 'safe' anyway.
#rb James.Golding
Change 2757207 on 2015/11/06 by Ori.Cohen
Fix incorrect root body cache which causes a single frame "freak out" when simulating physics from an animation
#rb Lina.Halper
Change 2757238 on 2015/11/06 by Marc.Audy
Force compiler generated functions to be generated for FHierarchicalSimplification in WorldSettings.h so that they are generated while the deprecation warnings are disabled.
#rb Mike.Fricker
Change 2757284 on 2015/11/06 by Stan.Melax
tapered capsule drawing
cloth collision happens with spheres and for the hull or tapered capsule goemetry between any specified pair of spheres.
(this was already code reviewed before, but missed the check-in window before streamtime)
#rb ori.cohen
Change 2757743 on 2015/11/06 by Lukasz.Furman
fixed node memory allocations for injected behavior tree decorators
#ue4 UE-22783
#rb Mieszko.Zielinski
Change 2757772 on 2015/11/06 by Lukasz.Furman
added setters for crowd avoidance
#ue4 UE-22785
#rb Mieszko.Zielinski
Change 2758422 on 2015/11/07 by Lina.Halper
Potential fix for invalid root bone index input
#jira :/UE-23086
#code review: Ori.Cohen
Change 2758429 on 2015/11/07 by Mieszko.Zielinski
Reimplemented a fix for AI Sight's "auto seeing" mechanics in a more flexible way #UE4
#jira UE-23089
Change 2758571 on 2015/11/08 by Mieszko.Zielinski
Modified ensure condition in UAIPerceptionComponent::OnRegister so it doesn't go off when BP does it's magic when components are being added to a BP actor class #UE4
#jira UE-23080
Change 2758821 on 2015/11/09 by Thomas.Sarkanen
Fixed animations no longer playing when using a dedicated server.
Uses correct logic to determine whether we are running as a server or not.
#rb Martin.Wilson
Change 2758920 on 2015/11/09 by Marc.Audy
Don't dereference weak object pointers repeatedly in FBoneContainer::Initialize
#rb Lina.Halper
Change 2758944 on 2015/11/09 by Ori.Cohen
Fix crash when stats are only on one thread and budget mode is used
Change 2758967 on 2015/11/09 by Benn.Gallagher
Fix for crash undoing notify socket changes in Persona, needed to recache the notify track data after the transaction had reserialized the sequence.
#jira UE-22963
Change 2758973 on 2015/11/09 by Benn.Gallagher
Added new 'Random Player' node for anim graphs allowing the user to play a selection of animations in a random order with certain randomised paramers. Also allows 'Shuffle Mode' to act more like a playlist in that it will play everything on the list before repeating.
#rb Bruce.Nesbit
Change 2759219 on 2015/11/09 by Ori.Cohen
Character perf test is now looking at stats directly and sending to analytics
#RB Ben.Salem
Change 2759398 on 2015/11/09 by Lina.Halper
Fix issue where placed montages are not playing.
- the issue is that IsPlaying does not consider montage, but SetPlaying does. It is asymmetry, so I made it same. However, there are other functions that need to be re-looked at wr.t. montage
#code review: Thomas.Sarkanen
#RB: Marc.Audy
Change 2759491 on 2015/11/09 by Lina.Halper
#Anim: Fix not getting input correctly for Copy Pose node
#RB: Marc.Audy
Change 2759602 on 2015/11/09 by Marc.Audy
Fix imporperly named struct
Change 2759795 on 2015/11/09 by Aaron.McLeran
UE-23145 Adding a Priority value to USoundBase to use in concurrency evaluation and sorting wave instances for voice stealing.
#rb zak.middleton
Change 2760081 on 2015/11/09 by Aaron.McLeran
UE-23091 Adding more logging for NaN checks and fixing one source of NaNs for audio.
OmniDirectional Math Explanation:
For XAudio2, because we do our own distance-attenuation calculations, we use the X3dAudio2 API to simply compute a speaker-map for spatialization and force the listener to be at the origin and the emitter to be on the unit-circle. Thus, from XAudio2's perspective, all distances for every listener-emitter pair will be 1.0.
So in order to use the InnerRadius blending feature, we need to trick it into doing a an inner radius blend relative to a distance of 1.0. For example, if OmniRadius and Distance are the same, then the "NormalizedOmniRadius" is 1.0 and XAudio2 will begin its "blend" of the sound to an omni-directional speaker map.
If Emitter-listener distance is less than the OmniRadius, we'll want to do more blending to an omni-directional speaker map, but we need to set the InnerRadius to something greater than 1.0 (i.e. so that the normalized distance of 1.0 will be treated as less than the InnerRadius). To do "full" omni-directional blending, the emitter-listener distance will be 0 or close to zero, and the NormalizedOmniRadius will be very large (i.e. close to infiinity).
The previous math just set the NormalizedOmniRadius to FLT_MAX which is fine but that number is eventually squared before making the API call. FLT_MAX squared is INF.
Note: I do not think we need to square the OmniRadius in:
Emitter.InnerRadius = OmniRadius*OmniRadius;
But I am keeping it t here because of legacy content which depends on that behavior.
#rb zak.middleton
hange 2760401 on 2015/11/10 by Thomas.Sarkanen@Thomas.Sarkanen-Dev-Framework
Re-instated deleted protected functions in UAnimInstance.
Fixed access of UAnimInstance in FAnimNode_StateMachine.
#rb Martin.Wilson
Change 2760407 on 2015/11/10 by Jurre.deBaare
Construct raw meshes for spline meshes now uses the render data instead of original model data (preserves tangents/normals)
Change 2760468 on 2015/11/10 by Benn.Gallagher
Anim Dynamics optimizations, cached iteration independant data to reduce footprint of iteration on limits.
#rb Graeme.Thornton
Change 2760613 on 2015/11/10 by Jeff.Farris
Fixed async collision completion delegate potentially firing repeatedly. (UE-23149)
#cr marc.audy
#codereview lina.halper
Change 2760795 on 2015/11/10 by Marc.Audy
Don't compile in pointless AddReferencedObjects when with editoronly data not defined
Minor coding standard cleanup (NULL and auto)
Change 2760848 on 2015/11/10 by Benn.Gallagher
Fix to anim instance proxy to not rely on state machine initialization to bind native delegates as nested state machines are not guaranteed to be initialized. This was fixed in UAnimInstance originally but broken again by the proxy instance code.
#jira UE-23164
#rb Martin.Wilson
Change 2760866 on 2015/11/10 by Marc.Audy
Manage transient visualization components for camera component in the same way that sprite component for other actor components are
#rb Mike.Beach
Change 2760963 on 2015/11/10 by Marc.Audy
Since construction script can cause actors to be spawned don't use a ranged for to iterate
#jira UE-22639
#rb Jeff.Farris
#codereview Dmitriy.Dyomin
Change 2762297 on 2015/11/11 by James.Golding
UE-23086 Don't ensure in SetRootBodyIndex when Bodies array is empty (ie no physics state created)
#rb martin.wilson
#codereview ori.cohen, lina.halper
Change 2763566 on 2015/11/11 by Lina.Halper
FAnimNode_CopyPoseFromMesh::Evaluate - was accessing skeleton joint, not mesh joint.
#RB: Laurent.Delayen
Change 2763926 on 2015/11/12 by Thomas.Sarkanen
Fix anim notifies not firing from single anim instances
UE-23248 - Anim Notifies are not working for Animation Sequences
UE-23249 - Anim Notifies using Sound Cues do not work
#rb James.Golding
Change 2764039 on 2015/11/12 by Jurre.deBaare
Fix for issue with incorrect material indices after reducing a skeletal mesh with non LOD0 mesh as BaseLOD (OR-9243) #rb Lina.Halper
Change 2764307 on 2015/11/12 by Jurre.deBaare
VS2015 SSF library
Change 2764314 on 2015/11/12 by Stan.Melax
crashfix was putting bad bodies to sleep at start
Fatal error!
Unhandled Exception: EXCEPTION_ACCESS_VIOLATION reading address 0x00000000
UE4Editor-Engine.dll!USkeletalMeshComponent::InitArticulated() [...\\engine\\source\\runtime\\engine\\private\\skeletalmeshcomponentphysics.cpp:875]
On some skeletalmeshcomponent, some bodies aren't getting created correctly. Trying to force them to sleep was causing a crash - it expected instantiated physx bodies. Seems that all the rest of the code is able to tolerate bad bodies.
Added check to ensure physx body exists before trying to force it to sleep.
not sure if bad bodies are the norm or if this fix is just more "kicking the can down the road".
#codereview ori.cohen
Change 2764343 on 2015/11/12 by Jurre.deBaare
- Fixed crash when building a LOD with SubActors.Num < 2
- Force HLOD level slider is now always enabled, however won't show complete image if not all HLODs are build
- LODActor tree view item now scrolls into view if selected in the world
- Set bAllowCullDistanceVolume to false for LODActor's static mesh components by default
- Added 7zip files
- Fixed issue with WinINet complaining about http-request without 'http://' prefix
- Changed % reduced or original triangles display string, now uses float instead of int (for < 1% reductions)
- Override texture sizes and automatic texture bias
- Fixed issue with incorrect material merging, not picking up it required mesh-data during baking. Added extra conditions for rendering with mesh-data.
- Now incorporate static meshes with opague materials into HLOD merging
- Fixed issue with incorrect normals after merging meshes who's owning components had been negatively scaled
- Fixed issue with incorrect texture size being set from MergeActor window (was only changing .X component)
- Fixed issue with material merging when meshes with multiple LODs are merged, right now only merges LOD0's together if we are also merging the materials (otherwise, merge each LOD)
- Added ENUM for texture scaling/resizing type that has to be applied while merging the materials
- Added detail customization class for FMaterialProxySettings
#rb James.Golding
[CL 2765024 by Marc Audy in Main branch]
2015-11-12 18:11:48 -05:00
|
|
|
|
2015-08-27 05:21:28 -04:00
|
|
|
FVisualLoggerFilters::Get().Reset();
|
|
|
|
|
|
2015-01-07 08:06:36 -05:00
|
|
|
if (MainView.IsValid())
|
|
|
|
|
{
|
|
|
|
|
MainView->ResetData();
|
|
|
|
|
}
|
|
|
|
|
|
Copying //UE4/Dev-Framework to Dev-Main (//UE4/Dev-Main)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2720406 on 2015/10/07 by Aaron.McLeran
Audio optimization
Don't search for nearest listener if there's only 1 listener.
Change 2720411 on 2015/10/07 by Aaron.McLeran
Fixing HRTF spatialization code with recent changes to stereo spatialization.
HRTF emitter posiition doesn't need to be converted to XAudio2 coordinates.
Change 2723829 on 2015/10/09 by Mieszko.Zielinski
Fixed NavigationSystem trying to set label of newly spawned navigation data #UE4
UE-21880
Change 2723873 on 2015/10/09 by Mieszko.Zielinski
Fixed a bug in FNavAgentProperties::IsEquivalent resulting in failing the test for FNavAgentProperties instances having default AgentStepHeight value (-1) #UE4
UE-21977
Change 2724834 on 2015/10/12 by Ori.Cohen
PR #1634: Add PxVehicleDriveNW support to PhysXVehicleManager.cpp (Contributed by zeduk)
Change 2724850 on 2015/10/12 by Marc.Audy
Fix sound not restarting in matinee preview when jumping back along timeline after reaching end
#codereview Nick.Darnell
Change 2726499 on 2015/10/13 by Ori.Cohen
Fix edge case where sphyl length and radius are 0 and they are not properly clamped to 0.1
Change 2726689 on 2015/10/13 by Marc.Audy
Make UPackage::PackageFlags private
Add debugging for UE-21181 to try and track down when EditorWorld's PackageFlags are getting flagged as PlayInEditor
#codereview Mike.Fricker
Change 2726862 on 2015/10/13 by Lukasz.Furman
removed unused code from DetourNavMeshQuery
#ue4 UE-21988
Change 2726888 on 2015/10/13 by Lukasz.Furman
fixed observer abort: both mode in behavior tree's cone check decorator
#ue4 UE-19375
Change 2726913 on 2015/10/13 by Lukasz.Furman
navmesh raycast will use nearest poly containing ray origin instead of just closest one
#ue4 UE-19334
Change 2726920 on 2015/10/13 by Marc.Audy
Re-unify ULevelStreaming::GetWorldAssetPackageName and GetWorldAssetPackageFName
#codereview Dmitriy.Dyomin, Bob.Tellez
Change 2726931 on 2015/10/13 by Lukasz.Furman
fixed missing Tick event in aborting behavior tree tasks from abandoned subtree
#ue4 UE-21777
Change 2728093 on 2015/10/14 by Ori.Cohen
Fix edge case of sphyl scale take two. The previous approach did double scaling
Change 2728577 on 2015/10/14 by Mieszko.Zielinski
Improved navmesh labeling condition #UE4
Change suggested by github user
#rb Lukasz.Furman
Change 2728587 on 2015/10/14 by Lukasz.Furman
fixed crowd simulation for auto possessed pawns placed on level
#ue4
#rb Mieszko.Zielinski
Change 2728629 on 2015/10/14 by Lukasz.Furman
fixed influence of navmesh edges on crowd simulation near end of path
#ue4 UE-21380
#rb Mieszko.Zielinski
Change 2728678 on 2015/10/14 by Lukasz.Furman
added Z check to detour's crowd avoidance segment gathering
#ue4 UE-20889
#rb Mieszko.Zielinski
Change 2728745 on 2015/10/14 by Lukasz.Furman
fixed copy&paste operation in behavior tree's composite decorators subgraphs
#ue4 UE-18740
Change 2729276 on 2015/10/14 by Stan.Melax
ensure all actors get recreated with new collision shape specification.
this wasn't being done for a couple of editing methods.
todo: this should be merged into 4.10
#UE-20961
#rb ori.cohen
Change 2730709 on 2015/10/15 by Marc.Audy
Prevent memory corruption when an invalid controller ID is passed in to the forcefeedback channel functions
#rb Lina.Halper
Change 2733590 on 2015/10/19 by Benn.Gallagher
Fixed various crashes when using undo and redo while manipulating state machines UE 22088
Change 2735143 on 2015/10/20 by Lukasz.Furman
clearing behavior tree debugger's state when displayed subtree becomes inactive
#ue4
#rb Mieszko.Zielinski
Change 2735144 on 2015/10/20 by Lukasz.Furman
rebuilding behavior tree graph node order when node is being moved
#ue4
#rb Mieszko.Zielinski
Change 2735403 on 2015/10/20 by sebastian.kowalczyk
Integrated fix for issue UE-18594 "Gameplay Debugger is hijacking the Canvas" issue from 4.10 (2735391). Extended previous fix to care about OSX users - it's possible to configure shortcuts in engine config file now (little different ones for osx platform).
Change 2736406 on 2015/10/21 by sebastian.kowalczyk
Added new GameplayDebugger as a plugin. Old gameplay debugger is still here to keep backward compatibility but it's deprecated now. Current projects should be moved to use new plugin soon.
Change 2736436 on 2015/10/21 by sebastian.kowalczyk
Fixed crash in gameplay debugger with player set as debug target.
Change 2736437 on 2015/10/21 by sebastian.kowalczyk
Added visual indicator around selected pawn to fix FORT-10273 issue. (FN is not using new gd plugin yet).
Change 2736489 on 2015/10/21 by sebastian.kowalczyk
Hide internal and debug hud classes from drop down lists.
Change 2736504 on 2015/10/21 by sebastian.kowalczyk
Fix for UE-18548 "EnableGDT does not work correctly in PIE".
Change 2736529 on 2015/10/21 by sebastian.kowalczyk
Fixed UE-18548 "EnableGDT does not work correctly in PIE"
Change 2736588 on 2015/10/21 by sebastian.kowalczyk
Removed old log visualizer classes.
Change 2736700 on 2015/10/21 by sebastian.kowalczyk
Fixed UE-19256 "Perception debug data doesn't get replicated by Gameplay Debuger" for old gameplay debugger module.
Change 2737180 on 2015/10/21 by Zak.Middleton
#ue4 - Fix UPrimitiveComponent::GetCollisionShape not correctly enforcing bounds limits.
#rb Aaron.Mcleran
#jira UE-22436
Change 2738084 on 2015/10/22 by sebastian.kowalczyk
Better indication of selected pawn for Gameplay Debugger.
Change 2738413 on 2015/10/22 by Marc.Audy
Disable duplication of worlds/maps via the content browser
#jira UE-22200
#rb James.Golding
Change 2739743 on 2015/10/23 by bruce.nesbit
UE-18707 - Issue with drawing material triangle on canvas #1387
Added DrawTriangleUsingVertexColor
Change 2739751 on 2015/10/23 by bruce.nesbit
Revised bShowDebugForReticleTarget should not be static #1539
Change 2739788 on 2015/10/23 by bruce.nesbit
Revised the 2 functions that used FTriangleRenderer::DrawTriangle to use FTriangleRenderer::DrawTriangleUsingVertexColor
Fixed compile error
Change 2739870 on 2015/10/23 by Marc.Audy
Avoid issues while detaching child components if OnAttachmentChange were to remove a sibling component itself.
#jira UE-22362
#rb Zak.Middleton
Change 2739882 on 2015/10/23 by sebastian.kowalczyk
Fix for UE-20901 "VisualLog redirections are broken after PIE finishes" issue.
Change 2740140 on 2015/10/23 by Marc.Audy
Ensure that components reregister tick functions after seamless travel
#jira UE-20892
#rb Zak.Middleton
Change 2740614 on 2015/10/23 by Ori.Cohen
Fix linker issues for people wanting to use physics lock lambdas
Change 2740674 on 2015/10/23 by Aaron.McLeran
Sound Focus Feature
Added new parameters to SoundAttenuation settings to allow audio to change behavior based on its angle to the listener
- Define the min/max azimuth angle to establish in-focus and non-focus regions
- Can scale the priority of a sound based on focus angle
- Can attenuate the volume of a sound based on focus angle
- Can scale the listener-emitter distance based on focus angle
- Distance scale is applied when determining max audible distance for USoundBase
- Can opt-out of focus effects for a sound at the USoundBase level
#rb Ryan.Vance
Change 2741542 on 2015/10/26 by Lukasz.Furman
lowered min value clamping in navigation filter properties
#ue4
#rb Mieszko.Zielinski
Change 2743227 on 2015/10/27 by Marc.Audy
Make ASceneCaptureCube subclassable outside of Engine module
#jira UE-22609
Make USceneCaptureComponentCube::UpdateContent callable outside of Engine module
#jira UE-22610
#rb Jeff.Farris
Change 2743255 on 2015/10/27 by Marc.Audy
Wrap FActorSpawnParameters class with deprecation warning disable pragma instead of hand implementing copy constructor
#rb Jeff.Farris
Change 2743729 on 2015/10/27 by Ori.Cohen
Fix case where we spawn and adjust location which gives us implicit velocity.
#codereview Stan.Melax
Change 2746135 on 2015/10/29 by sebastian.kowalczyk
Fixed UE-21668 "Saving log filters selected in LogVisualizer causes insane ini file sizes! And doesn't really work."
Change 2746437 on 2015/10/29 by Lukasz.Furman
pass on verifying behavior tree stack before accessing its elements
#ue4
#rb Mieszko.Zielinski
Change 2748028 on 2015/10/30 by sebastian.kowalczyk
Changed GameplayDebugger's console variable from gd.EQSOnHUD to ai.gd.EQSOnHUD" after suggestion with MieszkoZ.
Change 2748184 on 2015/10/30 by Aaron.McLeran
UE-22693 Fix for streaming bug
- 3rd decoded buffer in initial 3 buffers was not getting submitted to xaudio2 voice resulting in garbled/skipped audio.
- Wasn't able to repro the 'cannot read chunk' part of the bug
#rb ryan.vance
Change 2749255 on 2015/10/31 by sebastian.kowalczyk
Fixed ai.gd.EQSOnHUD console variable after rename from gd.EQSOnHUD.
Change 2749276 on 2015/10/31 by sebastian.kowalczyk
Added switch to toggle highlight of selected actor to GameplayDebugger.
Change 2749318 on 2015/10/31 by sebastian.kowalczyk
New Gameplay Debugger plugin can be used with old module simultaneously. It's best to configure different keyboard binding for plugin when using old module (it can be set in project settings, for new gameplay debugger plugin - when activated for project).
Change 2749337 on 2015/10/31 by sebastian.kowalczyk
Fixed GameplayDebugger compilation in shipping/test builds.
Change 2749376 on 2015/10/31 by sebastian.kowalczyk
Small clean-up in gameplay debugger class for BT.
Change 2749931 on 2015/11/02 by James.Golding
Add stats to ProcMeshComp
Change 2749932 on 2015/11/02 by James.Golding
Remove PhysicsThrusterComponent.h from Engine.h
Change 2749960 on 2015/11/02 by James.Golding
- Fix PS4 compile errors in ActiveSound.cpp
- Constructor order of FActiveSound
- Shadowed AudioComponent var in CheckOcclusion
#RB thomas.sarkanen
#codereview aaron.mcleran
Change 2749961 on 2015/11/02 by James.Golding
Fix PS4 compile errors in GameplayDebuggerBaseObject.cpp
- Shadowed DefaultContext function param, now just Context, which matches declaration
#RB thomas.sarkanen
#codereview sebastian.kowalczyk
Change 2750026 on 2015/11/02 by Thomas.Sarkanen
Anim Multithreading: thread-safety refactor
Segregated access to various parts of anim update data by spitting off a new proxy class (FAnimInstanceProxy) containing all data accessed in Update() and Evaluate() passes. Gated access to the proxy data on the game thread in a number of ways:
- Explicit access via GetValueOnGameThread() - this blocks on any existing task, completes and then allows control to return to the accessing function. This allows stuff like Blueprints to continue to operate as normal.
- Explicit access via GetValueOnAnyThread() - this ensures that in the limited set of circumstances we need this (Blueprint pure functions mostly) that conditions are met about concurrent access.
- Deprecating many APIs on UAnimInstance that should not be used (and in fact are not used at present, happily).
Derived classes of UAnimInstance can override the creation of the proxy class to create their own type. We do this for UAnimSingleNodeInstance etc.
Any API deprecation should continue to function - no functions have been removed yet. The only things that are not backwards-compatible are direct access to some public member variables for which there is no way to support (e.g. via references, for example UngroupedActivePlayerArrays).
Some APIs have been changed to more specifically represent the dependencies involved. For example TickAssetPlayerInstance() used to take a UAnimInstance*, only to use it to simply queue notifies. This has been deprecated and replaced with a new FNotifyQueue API. FNotifyQueue also uses a thread-safe FRandomStream instead of FMath::Rand.
Many changes are due to substituting accessor functions for direct variable access.
Removed 'service' tick group as we no longer need to segregate the running of our parallel update.
Anim nodes that need to do some game thread-side update should register for a pre-update callback delegate in the proxy. See FAnimNode_AnimDynamics for an example of this.
Moved UpdateActiveVertexAnims into FAnimRuntime so I can subsume some of the code that was in USkeletalMeshComponent::EvaluateAnimation into UAnimInstance (and hence keep the proxy access private).
#rb Martin.Wilson,Lina.Halper
#codereview Michael.Noland
Change 2750077 on 2015/11/02 by Marc.Audy
Expose UInputComponent::BindAction that supports WithKey delegate signature
Change 2751767 on 2015/11/03 by Thomas.Sarkanen
Added extra support to Anim Blueprint 'fast-path'
Added support for negated bools (value gets negated during copy).
Added support for copying from struct members (via break struct) and split struct pins.
Removed potentially troublesome references to BP-constructed UProperties, replacing them with the property FName. This adds some extra Initialize() overhead, but prevents various crash-on load issues (one when generating the class CRC). Added guard to prevent multiple initialization to save this more expensive work being done more often.
#rb Martin.Wilson
Change 2752158 on 2015/11/03 by Jeff.Farris
Fixed UGameplayStatics::SpawnEmitterAttached() to register the ParticleSystemComponent after it spawns.
#rb marc.audy
Change 2752159 on 2015/11/03 by Jeff.Farris
Improvements to camera lens effects to (EmitterCameraLensEffectBase)
- can now specify a transform to align the emitter with the camera
- exposed several key parameters to Blueprints
- ENGINE_API now applies to the entire class
#rb marc.audy
Change 2753454 on 2015/11/04 by Thomas.Sarkanen
Fixup deprecation warnings fallout from multithreaded update changes.
Fixed up use of AnimInstance in Vicon plugin.
Fixed up use of AnimInstance in slope warping node.
Un-deprecated some APIs to become warning free (these APIs are safe to call but just a 'bad idea if you want to do it right').
Also an extra API to allow for smoother transition: Allow custom allocation/deallocation (including using a proxy member struct) by providing an override point for proxy destruction.
#rb Martin.Wilson
Change 2754099 on 2015/11/04 by Ori.Cohen
Fix for task threads dropping stats (from Gil)
#rb Gil.Gribb
Change 2754449 on 2015/11/04 by Marc.Audy
Ensure that components created from an Actor's blueprint BeginPlay implementation get BeginPlay called on them and register their component ticks
#jira UE-20853
Reorganize some booleans to get better bit packing
#rb Jeff.Farris
#codereview Mieszko.Zielinski
Change 2754573 on 2015/11/04 by Aaron.McLeran
Fixing audio component PostLoad code to not set all LowPassFilterFrequency values to 0.0f
Change 2755345 on 2015/11/05 by Thomas.Sarkanen
Added deprecated constructors for various animation contexts
Allows existing code to compile if it creates its own contexts from UAnimInstance.
#rb James.Golding
Change 2755348 on 2015/11/05 by James.Golding
Add BP-exposed SetBoundsScale function to PrimitiveComponent
#RB thomas.sarkanen
Change 2755437 on 2015/11/05 by Marc.Audy
Fix compile errors
#codereview Thomas.Sarkanen, Mieszko.Zielinski, Aaron.McLeran
Change 2755982 on 2015/11/05 by Marc.Audy
Move HeaderParse changes for deprecation macro from Core
Fix world settings warning
Change 2756028 on 2015/11/05 by Marc.Audy
Fix shadow variable issue
Change 2756090 on 2015/11/05 by Ori.Cohen
Improve budget tool so that task threads are computed automatically.
#rb Gil.Gribb
Change 2756120 on 2015/11/05 by Mieszko.Zielinski
Fixed AIController::MoveTo not using DefaultQueryExtent of its navigation data #UE4
#rb Lukasz.Furman
Change 2756243 on 2015/11/05 by Mieszko.Zielinski
Fixed AI perception sight's "auto-visibility" mechanism totally skipping distance and vision cone checks #UE4
The old way was resulting in false positives when for example observer teleported somewhere far
#rb Lukasz.Furman
#codereview John.Abercrombie
Change 2756280 on 2015/11/05 by Mieszko.Zielinski
Minor VLog code cleanup and dumb-fixing visual logger accessing timer manager off of game thread #UE4
#rb Lukasz.Furman
Change 2756500 on 2015/11/05 by Mieszko.Zielinski
Added sanity-checking to BlueprintNodeHelpers::HasBlueprintFunction and cleaned up its usage #UE4
Also, refactored its parameters into references over pointers.
#rb Lukasz.Furman
Change 2757041 on 2015/11/06 by Thomas.Sarkanen
Removed check() in UAnimInstance::GetProxyOnAnyThread()
The check was no longer needed as if we are on the game thread we block until tasks are completed below, and if we are on any other thread we are 'safe' anyway.
#rb James.Golding
Change 2757207 on 2015/11/06 by Ori.Cohen
Fix incorrect root body cache which causes a single frame "freak out" when simulating physics from an animation
#rb Lina.Halper
Change 2757238 on 2015/11/06 by Marc.Audy
Force compiler generated functions to be generated for FHierarchicalSimplification in WorldSettings.h so that they are generated while the deprecation warnings are disabled.
#rb Mike.Fricker
Change 2757284 on 2015/11/06 by Stan.Melax
tapered capsule drawing
cloth collision happens with spheres and for the hull or tapered capsule goemetry between any specified pair of spheres.
(this was already code reviewed before, but missed the check-in window before streamtime)
#rb ori.cohen
Change 2757743 on 2015/11/06 by Lukasz.Furman
fixed node memory allocations for injected behavior tree decorators
#ue4 UE-22783
#rb Mieszko.Zielinski
Change 2757772 on 2015/11/06 by Lukasz.Furman
added setters for crowd avoidance
#ue4 UE-22785
#rb Mieszko.Zielinski
Change 2758422 on 2015/11/07 by Lina.Halper
Potential fix for invalid root bone index input
#jira :/UE-23086
#code review: Ori.Cohen
Change 2758429 on 2015/11/07 by Mieszko.Zielinski
Reimplemented a fix for AI Sight's "auto seeing" mechanics in a more flexible way #UE4
#jira UE-23089
Change 2758571 on 2015/11/08 by Mieszko.Zielinski
Modified ensure condition in UAIPerceptionComponent::OnRegister so it doesn't go off when BP does it's magic when components are being added to a BP actor class #UE4
#jira UE-23080
Change 2758821 on 2015/11/09 by Thomas.Sarkanen
Fixed animations no longer playing when using a dedicated server.
Uses correct logic to determine whether we are running as a server or not.
#rb Martin.Wilson
Change 2758920 on 2015/11/09 by Marc.Audy
Don't dereference weak object pointers repeatedly in FBoneContainer::Initialize
#rb Lina.Halper
Change 2758944 on 2015/11/09 by Ori.Cohen
Fix crash when stats are only on one thread and budget mode is used
Change 2758967 on 2015/11/09 by Benn.Gallagher
Fix for crash undoing notify socket changes in Persona, needed to recache the notify track data after the transaction had reserialized the sequence.
#jira UE-22963
Change 2758973 on 2015/11/09 by Benn.Gallagher
Added new 'Random Player' node for anim graphs allowing the user to play a selection of animations in a random order with certain randomised paramers. Also allows 'Shuffle Mode' to act more like a playlist in that it will play everything on the list before repeating.
#rb Bruce.Nesbit
Change 2759219 on 2015/11/09 by Ori.Cohen
Character perf test is now looking at stats directly and sending to analytics
#RB Ben.Salem
Change 2759398 on 2015/11/09 by Lina.Halper
Fix issue where placed montages are not playing.
- the issue is that IsPlaying does not consider montage, but SetPlaying does. It is asymmetry, so I made it same. However, there are other functions that need to be re-looked at wr.t. montage
#code review: Thomas.Sarkanen
#RB: Marc.Audy
Change 2759491 on 2015/11/09 by Lina.Halper
#Anim: Fix not getting input correctly for Copy Pose node
#RB: Marc.Audy
Change 2759602 on 2015/11/09 by Marc.Audy
Fix imporperly named struct
Change 2759795 on 2015/11/09 by Aaron.McLeran
UE-23145 Adding a Priority value to USoundBase to use in concurrency evaluation and sorting wave instances for voice stealing.
#rb zak.middleton
Change 2760081 on 2015/11/09 by Aaron.McLeran
UE-23091 Adding more logging for NaN checks and fixing one source of NaNs for audio.
OmniDirectional Math Explanation:
For XAudio2, because we do our own distance-attenuation calculations, we use the X3dAudio2 API to simply compute a speaker-map for spatialization and force the listener to be at the origin and the emitter to be on the unit-circle. Thus, from XAudio2's perspective, all distances for every listener-emitter pair will be 1.0.
So in order to use the InnerRadius blending feature, we need to trick it into doing a an inner radius blend relative to a distance of 1.0. For example, if OmniRadius and Distance are the same, then the "NormalizedOmniRadius" is 1.0 and XAudio2 will begin its "blend" of the sound to an omni-directional speaker map.
If Emitter-listener distance is less than the OmniRadius, we'll want to do more blending to an omni-directional speaker map, but we need to set the InnerRadius to something greater than 1.0 (i.e. so that the normalized distance of 1.0 will be treated as less than the InnerRadius). To do "full" omni-directional blending, the emitter-listener distance will be 0 or close to zero, and the NormalizedOmniRadius will be very large (i.e. close to infiinity).
The previous math just set the NormalizedOmniRadius to FLT_MAX which is fine but that number is eventually squared before making the API call. FLT_MAX squared is INF.
Note: I do not think we need to square the OmniRadius in:
Emitter.InnerRadius = OmniRadius*OmniRadius;
But I am keeping it t here because of legacy content which depends on that behavior.
#rb zak.middleton
hange 2760401 on 2015/11/10 by Thomas.Sarkanen@Thomas.Sarkanen-Dev-Framework
Re-instated deleted protected functions in UAnimInstance.
Fixed access of UAnimInstance in FAnimNode_StateMachine.
#rb Martin.Wilson
Change 2760407 on 2015/11/10 by Jurre.deBaare
Construct raw meshes for spline meshes now uses the render data instead of original model data (preserves tangents/normals)
Change 2760468 on 2015/11/10 by Benn.Gallagher
Anim Dynamics optimizations, cached iteration independant data to reduce footprint of iteration on limits.
#rb Graeme.Thornton
Change 2760613 on 2015/11/10 by Jeff.Farris
Fixed async collision completion delegate potentially firing repeatedly. (UE-23149)
#cr marc.audy
#codereview lina.halper
Change 2760795 on 2015/11/10 by Marc.Audy
Don't compile in pointless AddReferencedObjects when with editoronly data not defined
Minor coding standard cleanup (NULL and auto)
Change 2760848 on 2015/11/10 by Benn.Gallagher
Fix to anim instance proxy to not rely on state machine initialization to bind native delegates as nested state machines are not guaranteed to be initialized. This was fixed in UAnimInstance originally but broken again by the proxy instance code.
#jira UE-23164
#rb Martin.Wilson
Change 2760866 on 2015/11/10 by Marc.Audy
Manage transient visualization components for camera component in the same way that sprite component for other actor components are
#rb Mike.Beach
Change 2760963 on 2015/11/10 by Marc.Audy
Since construction script can cause actors to be spawned don't use a ranged for to iterate
#jira UE-22639
#rb Jeff.Farris
#codereview Dmitriy.Dyomin
Change 2762297 on 2015/11/11 by James.Golding
UE-23086 Don't ensure in SetRootBodyIndex when Bodies array is empty (ie no physics state created)
#rb martin.wilson
#codereview ori.cohen, lina.halper
Change 2763566 on 2015/11/11 by Lina.Halper
FAnimNode_CopyPoseFromMesh::Evaluate - was accessing skeleton joint, not mesh joint.
#RB: Laurent.Delayen
Change 2763926 on 2015/11/12 by Thomas.Sarkanen
Fix anim notifies not firing from single anim instances
UE-23248 - Anim Notifies are not working for Animation Sequences
UE-23249 - Anim Notifies using Sound Cues do not work
#rb James.Golding
Change 2764039 on 2015/11/12 by Jurre.deBaare
Fix for issue with incorrect material indices after reducing a skeletal mesh with non LOD0 mesh as BaseLOD (OR-9243) #rb Lina.Halper
Change 2764307 on 2015/11/12 by Jurre.deBaare
VS2015 SSF library
Change 2764314 on 2015/11/12 by Stan.Melax
crashfix was putting bad bodies to sleep at start
Fatal error!
Unhandled Exception: EXCEPTION_ACCESS_VIOLATION reading address 0x00000000
UE4Editor-Engine.dll!USkeletalMeshComponent::InitArticulated() [...\\engine\\source\\runtime\\engine\\private\\skeletalmeshcomponentphysics.cpp:875]
On some skeletalmeshcomponent, some bodies aren't getting created correctly. Trying to force them to sleep was causing a crash - it expected instantiated physx bodies. Seems that all the rest of the code is able to tolerate bad bodies.
Added check to ensure physx body exists before trying to force it to sleep.
not sure if bad bodies are the norm or if this fix is just more "kicking the can down the road".
#codereview ori.cohen
Change 2764343 on 2015/11/12 by Jurre.deBaare
- Fixed crash when building a LOD with SubActors.Num < 2
- Force HLOD level slider is now always enabled, however won't show complete image if not all HLODs are build
- LODActor tree view item now scrolls into view if selected in the world
- Set bAllowCullDistanceVolume to false for LODActor's static mesh components by default
- Added 7zip files
- Fixed issue with WinINet complaining about http-request without 'http://' prefix
- Changed % reduced or original triangles display string, now uses float instead of int (for < 1% reductions)
- Override texture sizes and automatic texture bias
- Fixed issue with incorrect material merging, not picking up it required mesh-data during baking. Added extra conditions for rendering with mesh-data.
- Now incorporate static meshes with opague materials into HLOD merging
- Fixed issue with incorrect normals after merging meshes who's owning components had been negatively scaled
- Fixed issue with incorrect texture size being set from MergeActor window (was only changing .X component)
- Fixed issue with material merging when meshes with multiple LODs are merged, right now only merges LOD0's together if we are also merging the materials (otherwise, merge each LOD)
- Added ENUM for texture scaling/resizing type that has to be applied while merging the materials
- Added detail customization class for FMaterialProxySettings
#rb James.Golding
[CL 2765024 by Marc Audy in Main branch]
2015-11-12 18:11:48 -05:00
|
|
|
if (VisualLoggerFilters.IsValid() && ULogVisualizerSettings::StaticClass()->GetDefaultObject<ULogVisualizerSettings>()->bResetDataWithNewSession)
|
2015-01-07 08:06:36 -05:00
|
|
|
{
|
|
|
|
|
VisualLoggerFilters->ResetData();
|
|
|
|
|
}
|
2015-01-16 06:25:10 -05:00
|
|
|
|
|
|
|
|
if (LogsList.IsValid())
|
|
|
|
|
{
|
2015-08-27 05:21:28 -04:00
|
|
|
LogsList->ResetData();
|
2015-01-16 06:25:10 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (StatusView.IsValid())
|
|
|
|
|
{
|
2015-08-27 05:21:28 -04:00
|
|
|
StatusView->ResetData();
|
2015-01-16 06:25:10 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (VisualLoggerCanvasRenderer.IsValid())
|
|
|
|
|
{
|
2015-08-27 05:21:28 -04:00
|
|
|
VisualLoggerCanvasRenderer->ResetData();
|
2015-01-16 06:25:10 -05:00
|
|
|
}
|
|
|
|
|
|
2015-09-11 09:02:06 -04:00
|
|
|
if (AVisualLoggerRenderingActor* HelperActor = Cast<AVisualLoggerRenderingActor>(FVisualLoggerEditorInterface::Get()->GetHelperActor(LastUsedWorld.Get())))
|
2015-01-16 06:25:10 -05:00
|
|
|
{
|
2015-08-27 05:21:28 -04:00
|
|
|
HelperActor->ResetRendering();
|
2015-01-16 06:25:10 -05:00
|
|
|
}
|
|
|
|
|
|
2015-08-27 05:21:28 -04:00
|
|
|
const TMap<FName, FVisualLogExtensionInterface*>& AllExtensions = FVisualLogger::Get().GetAllExtensions();
|
|
|
|
|
for (auto Iterator = AllExtensions.CreateConstIterator(); Iterator; ++Iterator)
|
|
|
|
|
{
|
|
|
|
|
FVisualLogExtensionInterface* Extension = (*Iterator).Value;
|
|
|
|
|
if (Extension != NULL)
|
|
|
|
|
{
|
|
|
|
|
Extension->ResetData(FVisualLoggerEditorInterface::Get());
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
FLogVisualizer::Get().GetEvents().OnLogLineSelectionChanged = FOnLogLineSelectionChanged::CreateRaw(this, &SVisualLogger::OnLogLineSelectionChanged);
|
|
|
|
|
FLogVisualizer::Get().GetEvents().OnKeyboardEvent = FOnKeyboardEvent::CreateRaw(this, &SVisualLogger::OnKeyboaedRedirection);
|
|
|
|
|
FLogVisualizer::Get().GetTimeSliderController().Get()->GetTimeSliderArgs().OnScrubPositionChanged = FOnScrubPositionChanged::CreateRaw(this, &SVisualLogger::OnScrubPositionChanged);
|
2015-01-07 08:06:36 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void SVisualLogger::OnNewWorld(UWorld* NewWorld)
|
|
|
|
|
{
|
2015-08-27 05:21:28 -04:00
|
|
|
if (LastUsedWorld.IsValid() && LastUsedWorld != NewWorld)
|
|
|
|
|
{
|
|
|
|
|
for (TActorIterator<AVisualLoggerRenderingActor> It(LastUsedWorld.Get()); It; ++It)
|
|
|
|
|
{
|
|
|
|
|
LastUsedWorld->DestroyActor(*It);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
LastUsedWorld = NewWorld;
|
|
|
|
|
|
2015-09-11 09:02:06 -04:00
|
|
|
AVisualLoggerRenderingActor* HelperActor = Cast<AVisualLoggerRenderingActor>(FVisualLoggerEditorInterface::Get()->GetHelperActor(LastUsedWorld.Get()));
|
Copying //UE4/Dev-Frame to //UE4/Main
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2775736 on 2015/11/20 by Richard.Hinckley
Fix for Paper2D issue with repeated imports in one edutor session. Paper2D import process now creates a new importer at the end. This prevents the sprite sheet import process from leaving frame data around, causing subsequent imports (including imports of different sprite sheets) to include this data inappropriately.
#codereview michael.noland
Change 2776352 on 2015/11/20 by Zak.Middleton
#ue4 - Avoid useless DetachFromParent() for the same pending AttachParent during registration. Added missing UpdateOverlaps() when detaching from object simulating physics.
#rb Marc.Audy, Ori.Cohen
#codereview James.Golding
Change 2776401 on 2015/11/20 by Mieszko.Zielinski
Implemented a way to do batched points projection to navmesh, where every point can declare a custom projection box #UE4
The biggest advantage here is that projection box is independent from projected point - no more manual offsetting of projected point to achieve "100uu up and 500uu down"-like functionality
#jira UE-23705
#rb Lukasz.Furman
Change 2777450 on 2015/11/23 by Martin.Wilson
Bake additive data into animations during cooking to avoid doing additive calculations and extra pose extraction and blending at runtime
#rb Thomas.Sarkanen
Change 2777698 on 2015/11/23 by Mieszko.Zielinski
Gameplay debugging tools fixes #UE4
Fixes:
- made newly added logs respect Log Visualizer's filters
- added handling of invalid data when trying to draw EGameplayDebuggerShapeElement::Cylinder in AGameplayDebuggingHUDComponent::DrawPerception. This is a patch, root cause to be found.
- fixed Log Visualizer resetting it's data while trying to serialize invalid objects. This is a patch, root cause to be addressed.
In addition
- while at it removed bunch of 'auto' and 'class' keywords from the files I've touched
#rb Lukasz.Furman
Change 2777762 on 2015/11/23 by Mieszko.Zielinski
Removed BlackboardComponent's functionality deprecated since 4.7 #UE4
#rb Lukasz.Furman
Change 2777839 on 2015/11/23 by Zak.Middleton
#ue4 - Wrap all vector library calls to math functions through our FMath versions, so they benefit from fixes or improvements therein. Added Exp2() function.
#rb Laurent.Delayen
Change 2777840 on 2015/11/23 by Zak.Middleton
#ue4 - Fix up uses of library math functions to go through our FMath namespace.
#rb Laurent.Delayen
Change 2778287 on 2015/11/23 by Stan.Melax
deprecation of FCollisionQueryParams(bool)
See 2774707 description for the whole story
#OR-9936
#codereview marc.audy
Changes to kite will have to be in a separate check-in
I couldn't submit to all files from the framework branch addition fixes have their files are shelved in cl 2778299
Change 2778507 on 2015/11/23 by Marc.Audy
Eliminate spurious cook warnings for known missing packages
#rb Michael.Noland
Change 2778546 on 2015/11/23 by Aaron.McLeran
Moving occlusion feature settings from audio component to sound attenuation settings struct.
- Sound attenuation setting struct is used for all sounds that do 3d spatialization so it make sense for the occlusion feature settings to be there.
- Kept old low-pass frequency filter setting values on audio component (where HighFrequencyAttenuation used to be)
#rb Zak.Middleton
Change 2778664 on 2015/11/23 by Zak.Middleton
#ue4 - Clarify some comparison functions (IsZero, IsNearlyZero, Equals) in FRotator to explain that they compare as orientations, not other interpretations such as rotational speed, winding, etc.
#rb Aaron.Mcleran
#codereview Frank.Gigliotti
Change 2779335 on 2015/11/24 by Mieszko.Zielinski
Another VisualLog patch to avoid crashing due to a core bug that remains to be investigated #UE4
Again, the core bug here is related visual log trying to serialize invalid objects on a regular basis.
#rb Lukasz.Furman
Change 2779338 on 2015/11/24 by Benn.Gallagher
Fixed crash in Persona when focus is taken from a different window
#jira UE-22516
#rb Ben.Cosh
Change 2779375 on 2015/11/24 by Benn.Gallagher
Fix for deadlock in destructibles. Aquiring actor buffer without releasing causes an infinite wait on next aquire.
#rb Ori.Cohen
Change 2779753 on 2015/11/24 by Zak.Middleton
#ue4 - FMath::Atan2() no longer calls atan2f() because of some compiler or library bugs causing it to randomly return NaN for valid input. It now uses a high-precision minimax approximation instead, measured to be 2x faster than the stock C version.
#rb Brian.Karis
Change 2779853 on 2015/11/24 by Marc.Audy
2015-12-02 16:42:06 -05:00
|
|
|
if (ensure(HelperActor))
|
2015-01-12 07:48:45 -05:00
|
|
|
{
|
Copying //UE4/Dev-Frame to //UE4/Main
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2775736 on 2015/11/20 by Richard.Hinckley
Fix for Paper2D issue with repeated imports in one edutor session. Paper2D import process now creates a new importer at the end. This prevents the sprite sheet import process from leaving frame data around, causing subsequent imports (including imports of different sprite sheets) to include this data inappropriately.
#codereview michael.noland
Change 2776352 on 2015/11/20 by Zak.Middleton
#ue4 - Avoid useless DetachFromParent() for the same pending AttachParent during registration. Added missing UpdateOverlaps() when detaching from object simulating physics.
#rb Marc.Audy, Ori.Cohen
#codereview James.Golding
Change 2776401 on 2015/11/20 by Mieszko.Zielinski
Implemented a way to do batched points projection to navmesh, where every point can declare a custom projection box #UE4
The biggest advantage here is that projection box is independent from projected point - no more manual offsetting of projected point to achieve "100uu up and 500uu down"-like functionality
#jira UE-23705
#rb Lukasz.Furman
Change 2777450 on 2015/11/23 by Martin.Wilson
Bake additive data into animations during cooking to avoid doing additive calculations and extra pose extraction and blending at runtime
#rb Thomas.Sarkanen
Change 2777698 on 2015/11/23 by Mieszko.Zielinski
Gameplay debugging tools fixes #UE4
Fixes:
- made newly added logs respect Log Visualizer's filters
- added handling of invalid data when trying to draw EGameplayDebuggerShapeElement::Cylinder in AGameplayDebuggingHUDComponent::DrawPerception. This is a patch, root cause to be found.
- fixed Log Visualizer resetting it's data while trying to serialize invalid objects. This is a patch, root cause to be addressed.
In addition
- while at it removed bunch of 'auto' and 'class' keywords from the files I've touched
#rb Lukasz.Furman
Change 2777762 on 2015/11/23 by Mieszko.Zielinski
Removed BlackboardComponent's functionality deprecated since 4.7 #UE4
#rb Lukasz.Furman
Change 2777839 on 2015/11/23 by Zak.Middleton
#ue4 - Wrap all vector library calls to math functions through our FMath versions, so they benefit from fixes or improvements therein. Added Exp2() function.
#rb Laurent.Delayen
Change 2777840 on 2015/11/23 by Zak.Middleton
#ue4 - Fix up uses of library math functions to go through our FMath namespace.
#rb Laurent.Delayen
Change 2778287 on 2015/11/23 by Stan.Melax
deprecation of FCollisionQueryParams(bool)
See 2774707 description for the whole story
#OR-9936
#codereview marc.audy
Changes to kite will have to be in a separate check-in
I couldn't submit to all files from the framework branch addition fixes have their files are shelved in cl 2778299
Change 2778507 on 2015/11/23 by Marc.Audy
Eliminate spurious cook warnings for known missing packages
#rb Michael.Noland
Change 2778546 on 2015/11/23 by Aaron.McLeran
Moving occlusion feature settings from audio component to sound attenuation settings struct.
- Sound attenuation setting struct is used for all sounds that do 3d spatialization so it make sense for the occlusion feature settings to be there.
- Kept old low-pass frequency filter setting values on audio component (where HighFrequencyAttenuation used to be)
#rb Zak.Middleton
Change 2778664 on 2015/11/23 by Zak.Middleton
#ue4 - Clarify some comparison functions (IsZero, IsNearlyZero, Equals) in FRotator to explain that they compare as orientations, not other interpretations such as rotational speed, winding, etc.
#rb Aaron.Mcleran
#codereview Frank.Gigliotti
Change 2779335 on 2015/11/24 by Mieszko.Zielinski
Another VisualLog patch to avoid crashing due to a core bug that remains to be investigated #UE4
Again, the core bug here is related visual log trying to serialize invalid objects on a regular basis.
#rb Lukasz.Furman
Change 2779338 on 2015/11/24 by Benn.Gallagher
Fixed crash in Persona when focus is taken from a different window
#jira UE-22516
#rb Ben.Cosh
Change 2779375 on 2015/11/24 by Benn.Gallagher
Fix for deadlock in destructibles. Aquiring actor buffer without releasing causes an infinite wait on next aquire.
#rb Ori.Cohen
Change 2779753 on 2015/11/24 by Zak.Middleton
#ue4 - FMath::Atan2() no longer calls atan2f() because of some compiler or library bugs causing it to randomly return NaN for valid input. It now uses a high-precision minimax approximation instead, measured to be 2x faster than the stock C version.
#rb Brian.Karis
Change 2779853 on 2015/11/24 by Marc.Audy
2015-12-02 16:42:06 -05:00
|
|
|
if (LastUsedWorld.IsValid() == false || ULogVisualizerSettings::StaticClass()->GetDefaultObject<ULogVisualizerSettings>()->bResetDataWithNewSession)
|
|
|
|
|
{
|
|
|
|
|
ResetData();
|
|
|
|
|
}
|
2015-08-27 05:21:28 -04:00
|
|
|
|
Copying //UE4/Dev-Frame to //UE4/Main
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2775736 on 2015/11/20 by Richard.Hinckley
Fix for Paper2D issue with repeated imports in one edutor session. Paper2D import process now creates a new importer at the end. This prevents the sprite sheet import process from leaving frame data around, causing subsequent imports (including imports of different sprite sheets) to include this data inappropriately.
#codereview michael.noland
Change 2776352 on 2015/11/20 by Zak.Middleton
#ue4 - Avoid useless DetachFromParent() for the same pending AttachParent during registration. Added missing UpdateOverlaps() when detaching from object simulating physics.
#rb Marc.Audy, Ori.Cohen
#codereview James.Golding
Change 2776401 on 2015/11/20 by Mieszko.Zielinski
Implemented a way to do batched points projection to navmesh, where every point can declare a custom projection box #UE4
The biggest advantage here is that projection box is independent from projected point - no more manual offsetting of projected point to achieve "100uu up and 500uu down"-like functionality
#jira UE-23705
#rb Lukasz.Furman
Change 2777450 on 2015/11/23 by Martin.Wilson
Bake additive data into animations during cooking to avoid doing additive calculations and extra pose extraction and blending at runtime
#rb Thomas.Sarkanen
Change 2777698 on 2015/11/23 by Mieszko.Zielinski
Gameplay debugging tools fixes #UE4
Fixes:
- made newly added logs respect Log Visualizer's filters
- added handling of invalid data when trying to draw EGameplayDebuggerShapeElement::Cylinder in AGameplayDebuggingHUDComponent::DrawPerception. This is a patch, root cause to be found.
- fixed Log Visualizer resetting it's data while trying to serialize invalid objects. This is a patch, root cause to be addressed.
In addition
- while at it removed bunch of 'auto' and 'class' keywords from the files I've touched
#rb Lukasz.Furman
Change 2777762 on 2015/11/23 by Mieszko.Zielinski
Removed BlackboardComponent's functionality deprecated since 4.7 #UE4
#rb Lukasz.Furman
Change 2777839 on 2015/11/23 by Zak.Middleton
#ue4 - Wrap all vector library calls to math functions through our FMath versions, so they benefit from fixes or improvements therein. Added Exp2() function.
#rb Laurent.Delayen
Change 2777840 on 2015/11/23 by Zak.Middleton
#ue4 - Fix up uses of library math functions to go through our FMath namespace.
#rb Laurent.Delayen
Change 2778287 on 2015/11/23 by Stan.Melax
deprecation of FCollisionQueryParams(bool)
See 2774707 description for the whole story
#OR-9936
#codereview marc.audy
Changes to kite will have to be in a separate check-in
I couldn't submit to all files from the framework branch addition fixes have their files are shelved in cl 2778299
Change 2778507 on 2015/11/23 by Marc.Audy
Eliminate spurious cook warnings for known missing packages
#rb Michael.Noland
Change 2778546 on 2015/11/23 by Aaron.McLeran
Moving occlusion feature settings from audio component to sound attenuation settings struct.
- Sound attenuation setting struct is used for all sounds that do 3d spatialization so it make sense for the occlusion feature settings to be there.
- Kept old low-pass frequency filter setting values on audio component (where HighFrequencyAttenuation used to be)
#rb Zak.Middleton
Change 2778664 on 2015/11/23 by Zak.Middleton
#ue4 - Clarify some comparison functions (IsZero, IsNearlyZero, Equals) in FRotator to explain that they compare as orientations, not other interpretations such as rotational speed, winding, etc.
#rb Aaron.Mcleran
#codereview Frank.Gigliotti
Change 2779335 on 2015/11/24 by Mieszko.Zielinski
Another VisualLog patch to avoid crashing due to a core bug that remains to be investigated #UE4
Again, the core bug here is related visual log trying to serialize invalid objects on a regular basis.
#rb Lukasz.Furman
Change 2779338 on 2015/11/24 by Benn.Gallagher
Fixed crash in Persona when focus is taken from a different window
#jira UE-22516
#rb Ben.Cosh
Change 2779375 on 2015/11/24 by Benn.Gallagher
Fix for deadlock in destructibles. Aquiring actor buffer without releasing causes an infinite wait on next aquire.
#rb Ori.Cohen
Change 2779753 on 2015/11/24 by Zak.Middleton
#ue4 - FMath::Atan2() no longer calls atan2f() because of some compiler or library bugs causing it to randomly return NaN for valid input. It now uses a high-precision minimax approximation instead, measured to be 2x faster than the stock C version.
#rb Brian.Karis
Change 2779853 on 2015/11/24 by Marc.Audy
2015-12-02 16:42:06 -05:00
|
|
|
// reset data and simulate row/item selection to recreate rendering proxy with correct data
|
|
|
|
|
HelperActor->ResetRendering();
|
|
|
|
|
const TArray<FName>& SelectedRows = FVisualLoggerDatabase::Get().GetSelectedRows();
|
|
|
|
|
HelperActor->ObjectSelectionChanged(SelectedRows);
|
|
|
|
|
for (auto& RowName : SelectedRows)
|
|
|
|
|
{
|
|
|
|
|
FVisualLoggerDBRow& DBRow = FVisualLoggerDatabase::Get().GetRowByName(RowName);
|
|
|
|
|
HelperActor->OnItemSelectionChanged(DBRow, DBRow.GetCurrentItemIndex());
|
|
|
|
|
}
|
2015-08-27 05:21:28 -04:00
|
|
|
}
|
2015-01-07 08:06:36 -05:00
|
|
|
}
|
|
|
|
|
|
2015-08-27 05:21:28 -04:00
|
|
|
void SVisualLogger::OnObjectSelectionChanged(const TArray<FName>& RowNames)
|
2014-11-19 07:43:07 -05:00
|
|
|
{
|
2015-08-27 05:21:28 -04:00
|
|
|
const float ScrubTime = FLogVisualizer::Get().GetTimeSliderController().Get()->GetTimeSliderArgs().ScrubPosition.Get();
|
|
|
|
|
for (auto RowName : RowNames)
|
2015-02-24 09:19:13 -05:00
|
|
|
{
|
2015-08-27 05:21:28 -04:00
|
|
|
FVisualLoggerDBRow& DBRow = FVisualLoggerDatabase::Get().GetRowByName(RowName);
|
|
|
|
|
if (DBRow.GetCurrentItemIndex() == INDEX_NONE)
|
2014-11-19 07:43:07 -05:00
|
|
|
{
|
2015-08-27 05:21:28 -04:00
|
|
|
DBRow.MoveTo(DBRow.GetClosestItem(ScrubTime, ScrubTime));
|
2014-11-19 07:43:07 -05:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2015-08-27 05:21:28 -04:00
|
|
|
void SVisualLogger::OnItemsSelectionChanged(const FVisualLoggerDBRow& ChangedRow, int32 SelectedItemIndex)
|
2014-11-19 07:43:07 -05:00
|
|
|
{
|
2015-08-27 05:21:28 -04:00
|
|
|
const TMap<FName, FVisualLogExtensionInterface*>& AllExtensions = FVisualLogger::Get().GetAllExtensions();
|
|
|
|
|
for (auto Iterator = AllExtensions.CreateConstIterator(); Iterator; ++Iterator)
|
2014-11-19 07:43:07 -05:00
|
|
|
{
|
2015-08-27 05:21:28 -04:00
|
|
|
FVisualLogExtensionInterface* Extension = (*Iterator).Value;
|
|
|
|
|
if (Extension != NULL)
|
|
|
|
|
{
|
|
|
|
|
Extension->OnItemsSelectionChanged(FVisualLoggerEditorInterface::Get());
|
|
|
|
|
}
|
2014-11-19 07:43:07 -05:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void SVisualLogger::OnFiltersChanged()
|
|
|
|
|
{
|
2015-08-27 05:21:28 -04:00
|
|
|
const uint32 StartCycles = FPlatformTime::Cycles();
|
|
|
|
|
|
|
|
|
|
ULogVisualizerSettings* Settings = ULogVisualizerSettings::StaticClass()->GetDefaultObject<ULogVisualizerSettings>();
|
|
|
|
|
const FString QuickSearchStrng = FVisualLoggerFilters::Get().GetSearchString();
|
|
|
|
|
|
|
|
|
|
TArray<TFuture<void> > AllFutures;
|
|
|
|
|
for (auto Iterator = FVisualLoggerDatabase::Get().GetRowIterator(); Iterator; ++Iterator)
|
2015-05-20 05:30:24 -04:00
|
|
|
{
|
2015-08-27 05:21:28 -04:00
|
|
|
FVisualLoggerDBRow* DBRow = &(*Iterator);
|
|
|
|
|
AllFutures.Add(
|
|
|
|
|
Async<void>(EAsyncExecution::TaskGraph, [this, DBRow]()
|
|
|
|
|
{
|
|
|
|
|
const TArray<FVisualLogDevice::FVisualLogEntryItem>& Entries = DBRow->GetItems();
|
|
|
|
|
for (int32 Index = 0; Index < Entries.Num(); ++Index)
|
|
|
|
|
{
|
|
|
|
|
UpdateVisibilityForEntry(*DBRow, Index);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
));
|
2015-05-20 05:30:24 -04:00
|
|
|
}
|
2014-11-19 07:43:07 -05:00
|
|
|
|
2015-08-27 05:21:28 -04:00
|
|
|
bool bAllFuturesReady = false;
|
|
|
|
|
do
|
2014-11-19 07:43:07 -05:00
|
|
|
{
|
2015-08-27 05:21:28 -04:00
|
|
|
bAllFuturesReady = true;
|
|
|
|
|
for (TFuture<void>& CurrentFuture : AllFutures)
|
|
|
|
|
{
|
|
|
|
|
bAllFuturesReady &= CurrentFuture.IsReady();
|
|
|
|
|
if (bAllFuturesReady == false)
|
|
|
|
|
{
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
if (bAllFuturesReady == false)
|
|
|
|
|
{
|
|
|
|
|
FPlatformProcess::Sleep(0.01);
|
|
|
|
|
}
|
|
|
|
|
} while (bAllFuturesReady != true);
|
2015-06-02 06:51:31 -04:00
|
|
|
|
2015-08-27 05:21:28 -04:00
|
|
|
for (auto Iterator = FVisualLoggerDatabase::Get().GetRowIterator(); Iterator; ++Iterator)
|
|
|
|
|
{
|
|
|
|
|
FVisualLoggerDBRow& DBRow = *Iterator;
|
|
|
|
|
FVisualLoggerDatabase::Get().SetRowVisibility(DBRow.GetOwnerName(), DBRow.GetNumberOfHiddenItems() != DBRow.GetItems().Num());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
const uint32 EndCycles = FPlatformTime::Cycles();
|
|
|
|
|
const int32 BlockingCycles = int32(FPlatformTime::Cycles() - StartCycles);
|
|
|
|
|
{
|
|
|
|
|
const TArray<FName>& SelectedRows = FVisualLoggerDatabase::Get().GetSelectedRows();
|
|
|
|
|
const float ScrubTime = FLogVisualizer::Get().GetTimeSliderController()->GetTimeSliderArgs().ScrubPosition.Get();
|
|
|
|
|
{
|
|
|
|
|
for (auto RowName : SelectedRows)
|
|
|
|
|
{
|
|
|
|
|
auto& DBRow = FVisualLoggerDatabase::Get().GetRowByName(RowName);
|
|
|
|
|
const int32 ClosestItem = DBRow.GetClosestItem(ScrubTime, ScrubTime);
|
|
|
|
|
const TArray<FVisualLogDevice::FVisualLogEntryItem>& Items = DBRow.GetItems();
|
|
|
|
|
if (Items.IsValidIndex(ClosestItem) && Items[ClosestItem].Entry.TimeStamp <= ScrubTime)
|
|
|
|
|
{
|
|
|
|
|
DBRow.MoveTo(ClosestItem);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
UE_LOG(LogVisualLogger, Display, TEXT("SVisualLogger::OnFiltersChanged: %5.2fms"), FPlatformTime::ToMilliseconds(BlockingCycles));
|
2014-11-19 07:43:07 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void SVisualLogger::OnFiltersSearchChanged(const FText& Filter)
|
|
|
|
|
{
|
2015-08-27 05:21:28 -04:00
|
|
|
const uint32 StartCycles = FPlatformTime::Cycles();
|
2014-12-18 08:37:06 -05:00
|
|
|
|
2015-08-27 05:21:28 -04:00
|
|
|
FVisualLoggerFilters::Get().SetSearchString(Filter.ToString());
|
|
|
|
|
|
|
|
|
|
ULogVisualizerSettings* Settings = ULogVisualizerSettings::StaticClass()->GetDefaultObject<ULogVisualizerSettings>();
|
|
|
|
|
const FString QuickSearchStrng = FVisualLoggerFilters::Get().GetSearchString();
|
|
|
|
|
|
|
|
|
|
TArray<TFuture<void> > AllFutures;
|
|
|
|
|
for (auto Iterator = FVisualLoggerDatabase::Get().GetRowIterator(); Iterator; ++Iterator)
|
2014-12-18 08:37:06 -05:00
|
|
|
{
|
2015-08-27 05:21:28 -04:00
|
|
|
FVisualLoggerDBRow* DBRow = &(*Iterator);
|
|
|
|
|
AllFutures.Add(
|
|
|
|
|
Async<void>(EAsyncExecution::TaskGraph, [this, DBRow]()
|
|
|
|
|
{
|
|
|
|
|
const TArray<FVisualLogDevice::FVisualLogEntryItem>& Entries = DBRow->GetItems();
|
|
|
|
|
for (int32 Index = 0; Index < Entries.Num(); ++Index)
|
|
|
|
|
{
|
|
|
|
|
UpdateVisibilityForEntry(*DBRow, Index);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
)
|
|
|
|
|
);
|
2014-12-18 08:37:06 -05:00
|
|
|
}
|
2015-08-27 05:21:28 -04:00
|
|
|
|
|
|
|
|
bool bAllFuturesReady = false;
|
|
|
|
|
do
|
|
|
|
|
{
|
|
|
|
|
bAllFuturesReady = true;
|
|
|
|
|
for (TFuture<void>& CurrentFuture : AllFutures)
|
|
|
|
|
{
|
|
|
|
|
bAllFuturesReady &= CurrentFuture.IsReady();
|
|
|
|
|
if (bAllFuturesReady == false)
|
|
|
|
|
{
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
if (bAllFuturesReady == false)
|
|
|
|
|
{
|
|
|
|
|
FPlatformProcess::Sleep(0.01);
|
|
|
|
|
}
|
|
|
|
|
} while (bAllFuturesReady != true);
|
|
|
|
|
|
|
|
|
|
for (auto Iterator = FVisualLoggerDatabase::Get().GetRowIterator(); Iterator; ++Iterator)
|
|
|
|
|
{
|
|
|
|
|
FVisualLoggerDBRow& DBRow = *Iterator;
|
|
|
|
|
FVisualLoggerDatabase::Get().SetRowVisibility(DBRow.GetOwnerName(), DBRow.GetNumberOfHiddenItems() != DBRow.GetItems().Num());
|
|
|
|
|
}
|
|
|
|
|
|
2014-12-18 08:37:06 -05:00
|
|
|
if (LogsList.IsValid())
|
|
|
|
|
{
|
2015-08-27 05:21:28 -04:00
|
|
|
// it depends on rows visibility so it have to be called here, manually after changes to rows visibilities
|
2014-12-18 08:37:06 -05:00
|
|
|
LogsList->OnFiltersSearchChanged(Filter);
|
|
|
|
|
}
|
2015-08-27 05:21:28 -04:00
|
|
|
|
|
|
|
|
if (VisualLoggerCanvasRenderer.IsValid())
|
2014-12-18 08:37:06 -05:00
|
|
|
{
|
2015-08-27 05:21:28 -04:00
|
|
|
VisualLoggerCanvasRenderer->DirtyCachedData();
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
const uint32 EndCycles = FPlatformTime::Cycles();
|
|
|
|
|
const int32 BlockingCycles = int32(FPlatformTime::Cycles() - StartCycles);
|
|
|
|
|
UE_LOG(LogVisualLogger, Display, TEXT("SVisualLogger::OnFiltersSearchChanged: %5.2fms"), FPlatformTime::ToMilliseconds(BlockingCycles));
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void SVisualLogger::OnNewItemHandler(const FVisualLoggerDBRow& DBRow, int32 ItemIndex)
|
|
|
|
|
{
|
|
|
|
|
UpdateVisibilityForEntry(DBRow, ItemIndex);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void SVisualLogger::UpdateVisibilityForEntry(const FVisualLoggerDBRow& DBRow, int32 ItemIndex)
|
|
|
|
|
{
|
|
|
|
|
ULogVisualizerSettings* Settings = ULogVisualizerSettings::StaticClass()->GetDefaultObject<ULogVisualizerSettings>();
|
|
|
|
|
const FVisualLogDevice::FVisualLogEntryItem& CurrentEntry = DBRow.GetItems()[ItemIndex];
|
|
|
|
|
FString SearchString = FVisualLoggerFilters::Get().GetSearchString();
|
|
|
|
|
|
|
|
|
|
TArray<FVisualLoggerCategoryVerbosityPair> OutCategories;
|
|
|
|
|
FVisualLoggerHelpers::GetCategories(CurrentEntry.Entry, OutCategories);
|
|
|
|
|
bool bHasValidCategories = false;
|
2016-02-24 14:23:53 -05:00
|
|
|
for (FVisualLoggerCategoryVerbosityPair& CategoryPair : OutCategories)
|
2015-08-27 05:21:28 -04:00
|
|
|
{
|
2016-02-24 14:23:53 -05:00
|
|
|
if (FVisualLoggerFilters::Get().MatchCategoryFilters(CategoryPair.CategoryName.ToString(), CategoryPair.Verbosity))
|
|
|
|
|
{
|
|
|
|
|
bHasValidCategories = true;
|
|
|
|
|
break;
|
|
|
|
|
}
|
2015-08-27 05:21:28 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (Settings->bSearchInsideLogs && bHasValidCategories && SearchString.Len() > 0)
|
|
|
|
|
{
|
|
|
|
|
bool bMatchSearchString = false;
|
|
|
|
|
for (const FVisualLogLine& CurrentLine : CurrentEntry.Entry.LogLines)
|
|
|
|
|
{
|
|
|
|
|
if (CurrentLine.Line.Find(SearchString) != INDEX_NONE || CurrentLine.Category.ToString().Find(SearchString) != INDEX_NONE)
|
|
|
|
|
{
|
|
|
|
|
bMatchSearchString = true;
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
if (!bMatchSearchString)
|
|
|
|
|
{
|
|
|
|
|
for (const FVisualLogEvent& CurrentEvent : CurrentEntry.Entry.Events)
|
|
|
|
|
{
|
|
|
|
|
if (CurrentEvent.Name.Find(SearchString) != INDEX_NONE)
|
|
|
|
|
{
|
|
|
|
|
bMatchSearchString = true;
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
FVisualLoggerDatabase::Get().GetRowByName(DBRow.GetOwnerName()).SetItemVisibility(ItemIndex, bMatchSearchString);
|
|
|
|
|
}
|
|
|
|
|
else
|
|
|
|
|
{
|
|
|
|
|
FVisualLoggerDatabase::Get().GetRowByName(DBRow.GetOwnerName()).SetItemVisibility(ItemIndex, bHasValidCategories);
|
2014-12-18 08:37:06 -05:00
|
|
|
}
|
2014-11-19 07:43:07 -05:00
|
|
|
}
|
2015-01-15 06:19:24 -05:00
|
|
|
|
2015-04-24 07:10:23 -04:00
|
|
|
void SVisualLogger::OnLogLineSelectionChanged(TSharedPtr<struct FLogEntryItem> SelectedItem, int64 UserData, FName TagName)
|
|
|
|
|
{
|
2015-05-20 05:30:24 -04:00
|
|
|
const TMap<FName, FVisualLogExtensionInterface*>& AllExtensions = FVisualLogger::Get().GetAllExtensions();
|
|
|
|
|
for (auto Iterator = AllExtensions.CreateConstIterator(); Iterator; ++Iterator)
|
2015-04-24 07:10:23 -04:00
|
|
|
{
|
|
|
|
|
FVisualLogExtensionInterface* Extension = (*Iterator).Value;
|
|
|
|
|
if (Extension != NULL)
|
|
|
|
|
{
|
2015-08-27 05:21:28 -04:00
|
|
|
Extension->OnLogLineSelectionChanged(FVisualLoggerEditorInterface::Get(), SelectedItem, UserData);
|
2015-04-24 07:10:23 -04:00
|
|
|
}
|
|
|
|
|
}
|
2015-08-27 05:21:28 -04:00
|
|
|
}
|
2015-04-24 07:10:23 -04:00
|
|
|
|
2015-08-27 05:21:28 -04:00
|
|
|
void SVisualLogger::OnScrubPositionChanged(float NewScrubPosition, bool bScrubbing)
|
|
|
|
|
{
|
|
|
|
|
const TArray<FName> &SelectedRows = FVisualLoggerDatabase::Get().GetSelectedRows();
|
|
|
|
|
const float ScrubTime = FLogVisualizer::Get().GetTimeSliderController()->GetTimeSliderArgs().ScrubPosition.Get();
|
|
|
|
|
for (auto RowName : SelectedRows)
|
2015-04-24 07:10:23 -04:00
|
|
|
{
|
2015-08-27 05:21:28 -04:00
|
|
|
auto& DBRow = FVisualLoggerDatabase::Get().GetRowByName(RowName);
|
|
|
|
|
const int32 ClosestItem = SelectedRows.Num() > 1 ? DBRow.GetClosestItem(NewScrubPosition, ScrubTime) : DBRow.GetClosestItem(NewScrubPosition);
|
|
|
|
|
const TArray<FVisualLogDevice::FVisualLogEntryItem>& Items = DBRow.GetItems();
|
|
|
|
|
if (Items.IsValidIndex(ClosestItem) && Items[ClosestItem].Entry.TimeStamp <= NewScrubPosition)
|
|
|
|
|
{
|
|
|
|
|
DBRow.MoveTo(ClosestItem);
|
|
|
|
|
}
|
2015-04-24 07:10:23 -04:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2015-06-11 09:51:31 -04:00
|
|
|
FReply SVisualLogger::OnKeyboaedRedirection(const FGeometry& MyGeometry, const FKeyEvent& InKeyEvent)
|
|
|
|
|
{
|
|
|
|
|
FReply ReturnValue = FReply::Unhandled();
|
|
|
|
|
|
2015-08-27 05:21:28 -04:00
|
|
|
const TArray<FName>& SelectedRows = FVisualLoggerDatabase::Get().GetSelectedRows();
|
|
|
|
|
if (SelectedRows.Num() == 0)
|
2015-06-11 09:51:31 -04:00
|
|
|
{
|
2015-08-27 05:21:28 -04:00
|
|
|
return ReturnValue;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// find time to move by
|
|
|
|
|
const FKey Key = InKeyEvent.GetKey();
|
|
|
|
|
if (Key == EKeys::Left || Key == EKeys::Right)
|
|
|
|
|
{
|
|
|
|
|
const float ScrubTime = FLogVisualizer::Get().GetTimeSliderController()->GetTimeSliderArgs().ScrubPosition.Get();
|
|
|
|
|
float NewTimeToSet = ScrubTime;
|
|
|
|
|
float BestTimeDifference = FLT_MAX;
|
|
|
|
|
|
|
|
|
|
const int32 MoveDist = InKeyEvent.IsLeftControlDown() ? InKeyEvent.IsLeftShiftDown() ? 20 : 10 : 1;
|
|
|
|
|
for (auto RowName : SelectedRows)
|
|
|
|
|
{
|
|
|
|
|
const FVisualLoggerDBRow& DBRow = FVisualLoggerDatabase::Get().GetRowByName(RowName);
|
|
|
|
|
const int32 CurrentItemIndex = DBRow.GetCurrentItemIndex();
|
|
|
|
|
if (CurrentItemIndex == INDEX_NONE)
|
|
|
|
|
{
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (Key == EKeys::Right)
|
|
|
|
|
{
|
|
|
|
|
float TimeDifference = DBRow.GetCurrentItem().Entry.TimeStamp - ScrubTime;
|
|
|
|
|
if (TimeDifference > 0 && FMath::Abs(TimeDifference) < FMath::Abs(BestTimeDifference))
|
|
|
|
|
{
|
|
|
|
|
BestTimeDifference = TimeDifference;
|
|
|
|
|
NewTimeToSet = DBRow.GetCurrentItem().Entry.TimeStamp;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
const int32 NextItemIndex = FLogVisualizer::Get().GetNextItem(RowName, MoveDist);
|
|
|
|
|
TimeDifference = DBRow.GetItems()[NextItemIndex].Entry.TimeStamp - ScrubTime;
|
|
|
|
|
if (TimeDifference > 0 && FMath::Abs(TimeDifference) < FMath::Abs(BestTimeDifference))
|
|
|
|
|
{
|
|
|
|
|
BestTimeDifference = TimeDifference;
|
|
|
|
|
NewTimeToSet = DBRow.GetItems()[NextItemIndex].Entry.TimeStamp;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
else if (Key == EKeys::Left)
|
|
|
|
|
{
|
|
|
|
|
float TimeDifference = DBRow.GetCurrentItem().Entry.TimeStamp - ScrubTime;
|
|
|
|
|
if (TimeDifference < 0 && FMath::Abs(TimeDifference) < FMath::Abs(BestTimeDifference))
|
|
|
|
|
{
|
|
|
|
|
BestTimeDifference = TimeDifference;
|
|
|
|
|
NewTimeToSet = DBRow.GetCurrentItem().Entry.TimeStamp;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
const int32 PrevItemIndex = FLogVisualizer::Get().GetPreviousItem(RowName, MoveDist);
|
|
|
|
|
TimeDifference = DBRow.GetItems()[PrevItemIndex].Entry.TimeStamp - ScrubTime;
|
|
|
|
|
if (TimeDifference < 0 && FMath::Abs(TimeDifference) > 0 && FMath::Abs(TimeDifference) < FMath::Abs(BestTimeDifference))
|
|
|
|
|
{
|
|
|
|
|
BestTimeDifference = TimeDifference;
|
|
|
|
|
NewTimeToSet = DBRow.GetItems()[PrevItemIndex].Entry.TimeStamp;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
FLogVisualizer::Get().GetTimeSliderController()->CommitScrubPosition(NewTimeToSet, false);
|
2015-06-11 09:51:31 -04:00
|
|
|
ReturnValue = FReply::Handled();
|
|
|
|
|
}
|
2015-08-27 05:21:28 -04:00
|
|
|
|
|
|
|
|
FName OwnerName = SelectedRows[SelectedRows.Num() - 1];
|
|
|
|
|
const FVisualLoggerDBRow& DBRow = FVisualLoggerDatabase::Get().GetRowByName(OwnerName);
|
|
|
|
|
if (DBRow.GetCurrentItemIndex() != INDEX_NONE)
|
2015-06-11 09:51:31 -04:00
|
|
|
{
|
2015-08-27 05:21:28 -04:00
|
|
|
if (Key == EKeys::Home)
|
|
|
|
|
{
|
|
|
|
|
FLogVisualizer::Get().GotoFirstItem(OwnerName);
|
|
|
|
|
ReturnValue = FReply::Handled();
|
|
|
|
|
}
|
|
|
|
|
else if (Key == EKeys::End)
|
|
|
|
|
{
|
|
|
|
|
FLogVisualizer::Get().GotoLastItem(OwnerName);
|
|
|
|
|
ReturnValue = FReply::Handled();
|
|
|
|
|
}
|
|
|
|
|
else if (Key == EKeys::Enter)
|
|
|
|
|
{
|
|
|
|
|
FLogVisualizer::Get().UpdateCameraPosition(OwnerName, DBRow.GetCurrentItemIndex());
|
|
|
|
|
ReturnValue = FReply::Handled();
|
|
|
|
|
}
|
2015-06-11 09:51:31 -04:00
|
|
|
}
|
2015-08-27 05:21:28 -04:00
|
|
|
|
2015-06-11 09:51:31 -04:00
|
|
|
return ReturnValue;
|
2015-01-15 06:19:24 -05:00
|
|
|
}
|
|
|
|
|
|
2014-11-19 09:04:58 -05:00
|
|
|
#undef LOCTEXT_NAMESPACE
|