Files
UnrealEngineUWP/Engine/Source/Programs/AutomationTool/Scripts/RunProjectCommand.Automation.cs

1100 lines
34 KiB
C#
Raw Normal View History

// Copyright 1998-2019 Epic Games, Inc. All Rights Reserved.
using System;
using System.Collections.Generic;
using System.IO;
using System.Text.RegularExpressions;
using System.Threading;
using System.Reflection;
using System.Linq;
using System.Net.NetworkInformation;
using System.Collections;
using AutomationTool;
using UnrealBuildTool;
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 3620134) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3550452 by Ben.Marsh UAT: Improve readability of error message when an editor commandlet fails with an error code. Change 3551179 by Ben.Marsh Add methods for reading text files into an array of strings. Change 3551260 by Ben.Marsh Core: Change FFileHelper routines to use enum classes for flags. Change 3555697 by Gil.Gribb Fixed a rare crash when the asset registry scanner found old cooked files with package level compression. #jira UE-47668 Change 3556464 by Ben.Marsh UGS: If working in a virtual stream, use the name of the first non-virtual ancestor for writing version files. Change 3557630 by Ben.Marsh Allow the network version to be set via Build.version if it's not overriden from Version.h. Change 3561357 by Gil.Gribb Fixed crashes related to loading old unversioned files in the editor. #jira UE-47806 Change 3565711 by Graeme.Thornton PR #3839: Make non-encoding specific Base64 functions accessible (Contributed by stfx) Change 3565864 by Robert.Manuszewski Temp fix for a race condition with the async loading thread enabled - caching the linker in case it gets removed (but not deleted) from super class object. Change 3569022 by Ben.Marsh PR #3849: Update gitignore (Contributed by mhutch) Change 3569113 by Ben.Marsh Fix Japanese errors not displaying correctly in the cook output log. #jira UE-47746 Change 3569486 by Ben.Marsh UGS: Always sync the Enterprise folder if the selected .uproject file has the "Enterprise" flag set. Change 3570483 by Graeme.Thornton Minor C# cleanups. Removing some redundant "using" calls which also cause dotnetcore compile errors Change 3570513 by Robert.Manuszewski Fix for a race condition with async loading thread enabled. Change 3570664 by Ben.Marsh UBT: Use P/Invoke to determine number of physical processors on Windows rather than using WMI. Starting up WMIC adds 2.5 seconds to build times, and is not compatible with .NET core. Change 3570708 by Robert.Manuszewski Added ENABLE_GC_OBJECT_CHECKS macro to be able to quickly toggle UObject pointer checks in shipping builds when the garbage collector is running. Change 3571592 by Ben.Marsh UBT: Allow running with -installed without creating [InstalledPlatforms] entries in BaseEngine.ini. If there is no HasInstalledPlatformInfo=true setting, assume that all platforms are still available. Change 3572215 by Graeme.Thornton UBT - Remove some unnecessary using directives - Point SN-DBS code at the new Utils.GetPhysicalProcessorCount call, rather than trying to calculate it itself Change 3572437 by Robert.Manuszewski Game-specific fix for lazy object pointer issues in one of the test levels. The previous fix had to be partially reverted due to side-effects. #jira UE-44996 Change 3572480 by Robert.Manuszewski MaterialInstanceCollections will no longer be added to GC clusters to prevent materials staying around in memory for too long Change 3573547 by Ben.Marsh Add support for displaying log timestamps in local time. Set LogTimes=Local in *Engine.ini, or pass -LocalLogTimes on the command line. Change 3574562 by Robert.Manuszewski PR #3847: Add GC callbacks for script integrations (Contributed by mhutch) Change 3575017 by Ben.Marsh Move some functions related to generating window resolutions out of Core (FParse::Resolution, GenerateConvenientWindowedResolutions). Also remove a few headers from shared PCHs prior to splitting application functionality out of Core. Change 3575689 by Ben.Marsh Add a fixed URL for opening the API documentation, so it works correctly in "internal" and "perforce" builds. Change 3575934 by Steve.Robb Fix for nested preprocessor definitions. Change 3575961 by Steve.Robb Fix for nested zeros. Change 3576297 by Robert.Manuszewski Material resources will now be discarded in PostLoad (Game Thread) instead of in Serialize (potentially Async Loading Thread) so that shader deregistration doesn't assert when done from a different thread than the game thread. #jira FORT-38977 Change 3576366 by Ben.Marsh Add shim functions to allow redirecting FPlatformMisc::ClipboardCopy()/ClipboardPaste() to FPlatformApplicationMisc::ClipboardCopy()/ClipboardPaste() while they are deprecated. Change 3578290 by Graeme.Thornton Changes to Ionic zip library to allow building on dot net core Change 3578291 by Graeme.Thornton Ionic zip library binaries built for .NET Core Change 3578354 by Graeme.Thornton Added FBase64::GetDecodedDataSize() to determine the size of bytes of a decoded base64 string Change 3578674 by Robert.Manuszewski After loading packages flush linker cache on uncooked platforms to free precache memory Change 3579068 by Steve.Robb Fix for CLASS_Intrinsic getting stomped. Fix to EClassFlags so that they are visible in the debugger. Re-added mysteriously-removed comments. Change 3579228 by Steve.Robb BOM removed. Change 3579297 by Ben.Marsh Fix exception if a plugin lists the same module twice. #jira UE-48232 Change 3579898 by Robert.Manuszewski When creating GC clusters and asserting due to objects still being pending load, the object name and cluster name will now be logged with the assert. Change 3579983 by Robert.Manuszewski More fixes for freeing linker cache memory in the editor. Change 3580012 by Graeme.Thornton Remove redundant copy of FileReference.cs Change 3580408 by Ben.Marsh Validate that arguments passed to the checkf macro are valid sprintf types, and fix up a few places which are currently incorrect. Change 3582104 by Graeme.Thornton Added a dynamic compilation path that uses the latest roslyn apis. Currently only used by the .NET Core path. Change 3582131 by Graeme.Thornton #define out some PerformanceCounter calls that don't exist in .NET Core. They're only used by mono-specific calls anyway. Change 3582645 by Ben.Marsh PR #3879: fix bug when creating a new VS2017 C++ project (Contributed by mnannola) #jira UE-48192 Change 3583955 by Robert.Manuszewski Support for EDL cooked packages in the editor Change 3584035 by Graeme.Thornton Split RunExternalExecutable into RunExternaNativelExecutable and RunExternalDotNETExecutable. When running under .NET Core, externally launched DotNET utilities must be launched via the 'dotnet' proxy to work correctly. Change 3584177 by Robert.Manuszewski Removed unused member variable (FArchiveAsync2::bKeepRestOfFilePrecached) Change 3584315 by Ben.Marsh Move Android JNI accessor functions into separate header, to decouple it from the FAndroidApplication class. Change 3584370 by Ben.Marsh Move hooks which allow platforms to load any modules into the FPlatformApplicationMisc classes. Change 3584498 by Ben.Marsh Move functions for getting and setting the hardware window pointer onto the appropriate platform window classes. Change 3585003 by Steve.Robb Fix for TChunkedArray ranged-for iteration. #jira UE-48297 Change 3585235 by Ben.Marsh Remove LogEngine extern from Core; use the platform log channels instead. Change 3585942 by Ben.Marsh Move MessageBoxExt() implementation into application layer for platforms that require it. Change 3587071 by Ben.Marsh Move Linux's UngrabAllInput() function into a callback, so DebugBreak still works without SDL. Change 3587161 by Ben.Marsh Remove headers which will be stripped out of the Core module from Core.h and PlatformIncludes.h. Change 3587579 by Steve.Robb Fix for Children list not being rebuilt after hot reload. Change 3587584 by Graeme.Thornton Logging improvements for pak signature check failures - Added "PakCorrupt" console command which corrupts the master signature table - Added some extra log information about which block failed - Re-hash the master signature table and to make sure that it hasn't changed since startup - Moved the ensure around so that some extra logging messages can make it out before the ensure is hit - Added PAK_SIGNATURE_CHECK_FAILS_ARE_FATAL to IPlatformFilePak.h so we have a single place to make signature check failures fatal again Change 3587586 by Graeme.Thornton Changes to make UBT build and run on .NET Core - Added *_DNC csproj files for DotNETUtilities and UnrealBuildTool projects which contain the .NET Core build setups - VCSharpProjectFile can no be asked for the CsProjectInfo for a particular configuration, which is cached for future use - After loading VCSharpProjectFiles, .NET Core based projects will be excluded unless generating VSCode projects Change 3587953 by Steve.Robb Allow arbitrary UENUM initializers for enumerators. Editor-only data UENUM support. Enumerators named MAX are now treated as the UENUM's maximum, and will not cause a MAX+1 value to be generated. #jira UE-46274 Change 3589827 by Graeme.Thornton More fixes for VSCode project generation and for UBT running on .NET Core - Use a different file extension for rules assemblies when build on .NET Core, so they never get used by their counterparts - UEConsoleTraceListener supports stdout/stderror constructor parameter and outputs to the appropriate channel - Added documentation for UEConsoleTraceListener - All platforms .NET project compilation tasks/launch configs now use "dotnet" and not the normal batch files - Restored the default UBT log verbosity to "Log" rather than "VeryVeryVerbose" - Renamed assemblies for .NETCore versions of DotNETUtilities and UnrealBuildTool so they don't conflict with the output of the existing .NET Desktop Framework stuff Change 3589868 by Graeme.Thornton Separate .NET Core projects for UBT and DotNETCommon out into their own directories so that their intermediates don't overlap with the standard .NET builds, causing failures. UBT registers ONLY .NET Core C# projects when generating VSCode solutions, and ONLY standard C# projects in all other cases Change 3589919 by Robert.Manuszewski Fixing crash when cooking textures that have already been cooked for EDL (support for cooked content in the editor) Change 3589940 by Graeme.Thornton Force UBT to think it's running on mono when actually running on .NET Core. Disables a lot of windows specific code paths. Change 3590078 by Graeme.Thornton Fully disable automatic assembly info generation in .NET Core projects Change 3590534 by Robert.Manuszewski Marking UObject as intrinsic clas to fix a crash on UFE startup. Change 3591498 by Gil.Gribb UE4 - Fixed several edge cases in the low level async loading code, especially around cancellation. Also PakFileTest is a console command which can be used to stress test pak file loading. Change 3591605 by Gil.Gribb UE4 - Follow up to fixing several edge cases in the low level async loading code. Change 3592577 by Graeme.Thornton .NET Core C# projects now reference source files explicitly, to stop it accidentally compiling various intermediates Change 3592684 by Steve.Robb Fix for EObjectFlags being passed as the wrong argument to csgCopyBrush. Change 3592710 by Steve.Robb Fix for invalid casts in ListProps command. Some name changes in command output. Change 3592715 by Ben.Marsh Move Windows event log code into cpp file, and expose it to other modules even if it's not enabled by default. Change 3592767 by Gil.Gribb UE4 - Changed the logic so that engine UObjects boot before anything else. The engine classes are known to be cycle-free, so we will get them done before moving onto game modules. Change 3592770 by Gil.Gribb UE4 - Fixed a race condition with async read completion in the prescence of cancels. Change 3593090 by Steve.Robb Better error message when there two clashing type names are found. Change 3593697 by Steve.Robb VisitTupleElements function, which calls a functor for each element in the tuple. Change 3595206 by Ben.Marsh Include additional diagnostics for missing imports when a module load fails. Change 3596140 by Graeme.Thornton Batch file for running MSBuild Change 3596267 by Steve.Robb Thread safety fix to FPaths::GetProjectFilePath(). Change 3596271 by Robert.Manuszewski Added code to verify compression flags in package file summary to avoid cases where corrupt packages are crashing the editor #jira UE-47535 Change 3596283 by Steve.Robb Redundant casts removed from UHT. Change 3596303 by Ben.Marsh EC: Improve parsing of Android Clang errors and warnings, which are formatted as MSVC diagnostics to allow go-to-line clicking in the Output Window. Change 3596337 by Ben.Marsh UBT: Format messages about incorrect headers in a way that makes them clickable from Visual Studio. Change 3596367 by Steve.Robb Iterator checks in ranged-for on TMap, TSet and TSparseArray. Change 3596410 by Gil.Gribb UE4 - Improved some error messages on runtime failures in the EDL. Change 3596532 by Ben.Marsh UnrealVS: Fix setting command line to empty not affecting property sheet. Also remove support for VS2013. #jira UE-48119 Change 3596631 by Steve.Robb Tool which takes a .map file and a .objmap file (from UBT) and creates a report which shows the size of all the symbols contributed by the source code per-folder. Change 3596807 by Ben.Marsh Improve Intellisense when generated headers are missing or out of date (eg. line numbers changed, etc...). These errors seem to be masked by VAX, but are present when using the default Visual Studio Intellisense. * UCLASS macro is defined to empty when __INTELLISENSE__ is defined. Previous macro was preventing any following class declaration being parsed correctly if generated code was out of date, causing squiggles over all class methods/variables. * Insert a semicolon after each expanded GENERATED_BODY macro, so that if it parses incorrectly, the compiler can still continue parsing the next declaration. Change 3596957 by Steve.Robb UBT can be used to write out an .objsrcmap file for use with the MapFileParser. Renaming of ObjMap to ObjSrcMap in MapFileParser. Change 3597213 by Ben.Marsh Remove AutoReporter. We don't support this any more. Change 3597558 by Ben.Marsh UGS: Allow adding custom actions to the context menu for right clicking on a changelist. Actions are specified in the project's UnrealEngine.ini file, with the following syntax: +ContextMenu=(Label="This is the menu item", Execute="foo.exe", Arguments="bar") The standard set of variables for custom tools is expanded in each parameter (eg. $(ProjectDir), $(EditorConfig), etc...), plus the $(Change) variable. Change 3597982 by Ben.Marsh Add an option to allow overriding the local DDC path from the editor (under Editor Preferences > Global > Local Derived Data Cache). #jira UE-47173 Change 3598045 by Ben.Marsh UGS: Add variables for stream and client name, and the ability to escape any variables for URIs using the syntax $(VariableName:URI). Change 3599214 by Ben.Marsh Avoid string duplication when comparing extensions. Change 3600038 by Steve.Robb Fix for maps being modified during iteration in cache compaction. Change 3600136 by Steve.Robb GitHub #3538 : Fixed a bug with the handling of 'TMap' key/value types in the UnrealHeaderTool Change 3600214 by Steve.Robb More accurate error message when unsupported template parameters are provided in a TSet property. Change 3600232 by Ben.Marsh UBT: Force UHT to run again if the .build.cs file for a module has changed. #jira UE-46119 Change 3600246 by Steve.Robb GitHub #3045 : allow multiple interface definition in a file Change 3600645 by Ben.Marsh Convert QAGame to Include-What-You-Use. Change 3600897 by Ben.Marsh Fix invalid path (multiple slashes) in LibCurl.build.cs. Causes exception when scanning for includes. Change 3601558 by Graeme.Thornton Simple first pass VSCode editor integration plugin Change 3601658 by Graeme.Thornton Enable intellisense generation for VS Code project files and setup include paths properly Change 3601762 by Ben.Marsh UBT: Add support for adaptive non-unity builds when working from a Git repository. The ISourceFileWorkingSet interface is now used to query files belonging to the working set, and has separate implementations for Perforce (PerforceSourceFileWorkingSet) and Git (GitSourceFileWorkingSet). The Git implementation is used if a .git directory is found in the directory containing the Engine folder, the directory containing the project file, or the parent directory of the project file, and spawns a "git status" process in the background to determine which files are untracked or staged. Several new settings are supported in BuildConfiguration.xml to allow modifying default behavior: <SourceFileWorkingSet> <Provider>Default</Provider> <!-- May be None, Default, Git or Perforce --> <RepositoryPath></RepositoryPath> <!-- Specifies the path to the repository, relative to the directory containing the Engine folder. If not set, tries to find a .git directory in the locations listed above. --> <GitPath>git</GitPath> <!-- Specifies the path to the Git executable. Defaults to "git", which assumes that it will be on the PATH --> </SourceFileWorkingSet> Change 3604032 by Graeme.Thornton First attempt at automatically detecting the existance and location of visual studio code in the source code accessor module. Only works for windows. Change 3604038 by Graeme.Thornton Added FSourceCodeNavigation::GetSelectedSourceCodeIDE() which returns the name of the selected source code accessor. Replaced all usages of FSourceCodeNavigation::GetSuggestedSourceCodeIDE() with GetSelectedSourceCodeIDE(), where the message is referring to the opening or editing of code. Change 3604106 by Steve.Robb GitHub #3561 : UE-44950: Don't see all caps struct constructor as macro Change 3604192 by Steve.Robb GitHub #3911 : Improving ToUpper/ToLower efficiency Change 3604273 by Graeme.Thornton IWYU build fixes when malloc profiler is enabled Change 3605457 by Ben.Marsh Fix race for intiialization of ThreadID variable on FRunnableThreadWin, and restore a previous check that was working around it. Change 3606720 by James.Hopkin Dave Ratti's fix to character base recursion protection code - was missing a GetOwner call, instead attempting to cast a component to a pawn. Change 3606807 by Graeme.Thornton Disabled optimizations around FShooterStyle::Create(), which was crashing in Win64 shipping game builds due to some known compiler issue. Same variety of fix as BenZ did in CL 3567741. Change 3607026 by James.Hopkin Fixed incorrect ABrush cast - was attempting to cast a UModel to ABrush, which can never succeed Change 3607142 by Graeme.Thornton UBT - Minor refactor of BackgroundProcess shutdown in SourceFileWorkingSet. Check whether the process has already exited before trying to kill it during Dispose. Change 3607146 by Ben.Marsh UGS: Fix exception due to formatting string when Perforce throws an error. Change 3607147 by Steve.Robb Efficiency fix for integer properties, which were causing a property mismatch and thus a tag lookup every time. Float and double conversion support added to int properties. NAME_DoubleProperty added. Fix for converting enum class enumerators > 255 to int properties. Change 3607516 by Ben.Marsh PR #3935: Fix DECLARE_DELEGATE_NineParams, DECLARE_MULTICAST_DELEGATE_NineParams. (Contributed by enginevividgames) Change 3610421 by Ben.Marsh UAT: Move help for RebuildLightMapsCommand into attributes, so they display when running with -help. Change 3610657 by Ben.Marsh UAT: Unify initialization of command environment for build machines and local execution. Always derive parameters which aren't manually set via environment variables. Change 3611000 by Ben.Marsh UAT: Remove the -ForceLocal command line option. Settings are now determined automatically, independently of the -Buildmachine argument. Change 3612471 by Ben.Marsh UBT: Move FastJSON into DotNETUtilities. Change 3613479 by Ben.Marsh UBT: Remove the bIsCodeProject flag from UProjectInfo. This was only really being used to determine which projects to generate an IDE project for, so it is now checked in the project file generator. Change 3613910 by Ben.Marsh UBT: Remove unnecessary code to guess a project from the target name; doesn't work due to init order, actual project is determined later. Change 3614075 by Ben.Marsh UBT: Remove hacks for testing project file attributes by name. Change 3614090 by Ben.Marsh UBT: Remove global lookup of project by name. Projects should be explicitly specified by path when necessary. Change 3614488 by Ben.Marsh UBT: Prevent annoying (but handled) exception when constructing SQLiteModuleSupport objects with -precompile enabled. Change 3614490 by Ben.Marsh UBT: Simplify generation of arguments for building intellisense; determine the platform/configuration to build from the project file generation code, rather than inside the target itself. Change 3614962 by Ben.Marsh UBT: Move the VS2017 strict conformance mode (/permissive-) behind a command line option (-Strict), and disable it by default. Building with this mode is not guaranteed to work correctly without updated Windows headers. Change 3615416 by Ben.Marsh EC: Include an icon showing the overall status of a build in the grid view. Change 3615713 by Ben.Marsh UBT: Delete any files in output directories which match output files in other directories. Allows automatically deleting build products which are moved into another folder. #jira UE-48987 Change 3616652 by Ben.Marsh Plugins: Fix incorrect dialog when binaries for a plugin are missing. Should only prompt to disable if starting a content-only project. #jira UE-49007 Change 3616680 by Ben.Marsh Add the CodeAPI-HTML.tgz file into the installed engine build. Change 3616767 by Ben.Marsh Plugins: Tweak error message if the FModuleManager::IsUpToDate() function returns false for a plugin module; the module may be missing, not just incompatible. Change 3616864 by Ben.Marsh Cap the length of the temporary package name during save, to prevent excessively long filenames going over the limit once a GUID is appended. #jira UE-48711 Change 3619964 by Ben.Marsh UnrealVS: Fix single file compile for foreign projects, where the command line contains $(SolutionDir) and $(ProjectName) variables. Change 3548930 by Ben.Marsh UBT: Remove UEBuildModuleCSDLL; there is no codepath that still supports creating them. Remove the remaining UEBuildModule/UEBuildModuleCPP abstraction. Change 3558056 by Ben.Marsh Deprecate FString::Trim() and FString::TrimTrailing(), and replace them with separate versions to mutate (TrimStartInline(), TrimEndInline()) or return by copy (TrimStart(), TrimEnd()). Also add a functions to trim whitespace from both ends of a string (TrimStartAndEnd(), TrimStartAndEndInline()). Change 3563309 by Graeme.Thornton Moved some common C# classes into the DotNETCommon assembly Change 3570283 by Graeme.Thornton Move some code out of RPCUtility and into DotNETCommon, removing the dependency between the two projects Added UEConsoleTraceListener to replace ConsoleTraceListener, which doesn't exist in DotNetCore Change 3572811 by Ben.Marsh UBT: Add -enableasan / -enabletsan command line options and bEnableAddressSanitizer / bEnableThreadSanitizer settings in BuildConfiguration.xml (and remove environment variables). Change 3573397 by Ben.Marsh UBT: Create a <ExeName>.version file for every target built by UBT, in the same JSON format as Engine/Build/Build.version. This allows monolithic targets to read a version number at runtime, unlike when it's embedded in a modules file, and allows creating versioned client executables that will work with versioned servers when syncing through UGS. Change 3575659 by Ben.Marsh Remove CHM API documentation. Change 3582103 by Graeme.Thornton Simple ResX writer implemetation that the xbox deloyment code can use instead of the one from the windows forms assembly, which isn't supported on .NET Core Removed reference to System.Windows.Form from UBT. Change 3584113 by Ben.Marsh Move key-mapping functionality into the InputCore module. Change 3584278 by Ben.Marsh Move FPlatformMisc::RequestMinimize() into FPlatformApplicationMisc. Change 3584453 by Ben.Marsh Move functionality for querying device display density to FApplicationMisc, due to dependence on application-level functionality on mobile platforms. Change 3585301 by Ben.Marsh Move PlatformPostInit() into an FPlatformApplicationMisc function. Change 3587050 by Ben.Marsh Move IsThisApplicationForeground() into FPlatformApplicationMisc. Change 3587059 by Ben.Marsh Move RequiresVirtualKeyboard() into FPlatformApplicationMisc. Change 3587119 by Ben.Marsh Move GetAbsoluteLogFilename() into FPlatformMisc. Change 3587800 by Steve.Robb Fixes to container visualizers for types whose pointer type isn't simply Type*. Change 3588393 by Ben.Marsh Move platform output devices into their own headers. Change 3588868 by Ben.Marsh Move creation of console, error and warning output devices int PlatformApplicationMisc. Change 3589879 by Graeme.Thornton All automation projects now have a reference to DotNETUtilities Fixed a build error in the WEX automation library Change 3590034 by Ben.Marsh Move functionality related to windowing and input out of the Core module and into an ApplicationCore module, so it is possible to build utilities with Core without adding dependencies on XInput (Windows), SDL (Linux), and OpenGL (Mac). Change 3593754 by Steve.Robb Fix for tuple debugger visualization. Change 3597208 by Ben.Marsh Move CrashReporter out of a public folder; it's not in a form that is usable by subscribers and licensees. Change 3600163 by Ben.Marsh UBT: Simplify how targets are cleaned. Delete all intermediate folders for a platform/configuration, and delete any build products matching the UE4 naming convention for that target, rather than relying on the current build configuration or list of previous build products. This will ensure that build products which are no longer being generated will also be cleaned. #jira UE-46725 Change 3604279 by Graeme.Thornton Move pre/post garbage collection delegates into accessor functions so they can be used by globally constructed objects Change 3606685 by James.Hopkin Removed redundant 'Cast's (casting to either the same type or a base). In SClassViewer, replaced cast with TAssetPtr::operator* call to get the wrapped UClass. Also removed redundant 'IsA's from AnimationRetargetContent::AddRemappedAsset in EditorAnimUtils.cpp. Change 3610950 by Ben.Marsh UAT: Simplify logic for detecting Perforce settings, using environment variables if they are set, otherwise falling back to detecting them. Removes special cases for build machines, and makes it simpler to set up UAT commands on builders outside Epic. Change 3610991 by Ben.Marsh UAT: Use the correct P4 settings to detect settings if only some parameters are specified on the command line. Change 3612342 by Ben.Marsh UBT: Change JsonObject.Read() to take a FileReference parameter. Change 3612362 by Ben.Marsh UBT: Remove some more cases of paths being passed as strings rather than using FileReference objects. Change 3619128 by Ben.Marsh Include builder warnings and errors in the notification emails for automated tests, otherwise it's difficult to track down non-test failures. [CL 3620189 by Ben Marsh in Main branch]
2017-08-31 12:08:38 -04:00
using Tools.DotNETCommon;
/// <summary>
/// Helper command to run a game.
/// </summary>
/// <remarks>
/// Uses the following command line params:
/// -cooked
/// -cookonthefly
/// -dedicatedserver
/// -win32
/// -noclient
/// -logwindow
/// </remarks>
public partial class Project : CommandUtils
{
#region Fields
/// <summary>
/// Thread used to read client log file.
/// </summary>
private static Thread ClientLogReaderThread = null;
/// <summary>
/// Process for the server, can be set by the cook command when a cook on the fly server is used
/// </summary>
Copying //UE4/Dev-Platform to //UE4/Dev-Main (Source: //UE4/Dev-Platform @ 3120366) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 2714591 on 2015/10/02 by Ben.Marsh Initial branch of files from Engine-Main (//UE4/Engine-Main) to Dev-Platform (//UE4/Dev-Platform) Change 2916715 on 2016/03/21 by Daniel.Lamb First pass at splitting out build cook run into into seperate scripts. Change 2948322 on 2016/04/19 by Nick.Shin update libwebsockets to v1.7.4 part 4 of 4 - doing this in stages for tracking purposes #jira UEPLAT-1246 - Update libWebsockets #jira UEPLAT-1221 - update websocket library #jira UEPLAT-1204 - Rebuild libwebsockets with SSL Change 2970016 on 2016/05/07 by Nick.Shin undo all of the following upgrades: - zlib - openssl - libcurl - libwebsockets and reset webrtc #jira UE-30298 - Fortnite and Orion crash on login Change 3059693 on 2016/07/21 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3061151 on 2016/07/22 by Niklas.Smedberg Fast ASTC texture compression, using ISPC. #jira UE-32308 Change 3061428 on 2016/07/22 by Peter.Sauerbrei Back out changelist 3061151 as it wasn't approved for submission Change 3061970 on 2016/07/22 by Steve.Cano Adding AdMob interstitital ad support for Android, including Blueprint functions #jira UE-33286 #ue4 #android Change 3062160 on 2016/07/22 by Mark.Satterthwaite Fix the fix for handling RHISetStreamSource overriding stride on Metal - not all MTLVertexDescriptors are equally hashable so do this ourselves. #jira UE-33355 Change 3062770 on 2016/07/24 by Brent.Pease UE-32397 Error Message displays as Unknown Error when failing to supply a Remote Build server for ios on Windows Change 3063227 on 2016/07/25 by Dmitry.Rekman Update hlslcc cross-compile after libc++ change. Change 3063314 on 2016/07/25 by Jeff.Campeau Xbox One DLL loading Receipts can be read back by request for target info Change 3063329 on 2016/07/25 by Mark.Satterthwaite CL #3046743 was breaking other samples in unexpected ways after a recent Main merge, so make a Metal-specific change to the shader instead and amend the MetalBackend to better match HLSL's handling of NaN/inf with common single-precision float intrinsics. This is sufficient to fix the AtmosphericFog and the recent regressions. #jira UE-33600 #jira UE-33028 #jira UE-27879 #jira UE-25802 Change 3063492 on 2016/07/25 by Brent.Pease UE-23846 - iOS Movie Player can't handle videos at resolutions that aren't multiples of 16 UE-33200 - A movie isn't played on iOS occasionally. Change 3063729 on 2016/07/25 by Dmitry.Rekman Linux: enable XGE on all platforms. #tests Cross-compiled a number of Linux targets on Windows. Change 3063732 on 2016/07/25 by Dmitry.Rekman Fixed formatting (spaces->tabs) in previous change. Change 3063750 on 2016/07/25 by Daniel.Lamb Added code to dump the cook modification delegate loads to log. Fixed the memory usage output log. #test cook paragon. Change 3063804 on 2016/07/25 by Daniel.Lamb Added cookpartialgc additional commandline option to uat. #test UFE Change 3064008 on 2016/07/25 by Mark.Satterthwaite For non-shipping builds conditionally bind a default uniform buffer in Metal and report an error if the slot was unbound, if our validation layer is enabled attempt to report the shader source in question. This relies on the shader compiler providing accurate information about uniform buffer bindings and won't fix all occurances of bad uniform usage (if a buffer is bound but too short the result will be GPU restarts or an error in Apple's validation layer - we can't detect this case) but will help debug the typical error of leaving an active slot unbound. #jira FORT-27685 Change 3064141 on 2016/07/25 by Jeff.Campeau Rebuild vpxmd.lib with delayed codegen disabled (fixes linker warning building Win64). Change 3065024 on 2016/07/26 by Nick.Shin Change filetype remove exclusive check out bit requested by or.coheni & nick.penwarden Change 3065274 on 2016/07/26 by Jonathan.Fitzpatrick DirectoriesToAlwaysStageAsUFS now properly filters out *.uasset and *.umap files This prevents the bug where cooked assets get trampled by staging their uncooked version on top of them during the UFS step Added a file filter to DirectoriesToAlwaysStageAsUFS for uasset and umap. Change 3066338 on 2016/07/27 by Mark.Satterthwaite Handle releasing an SRV/UAV & the source object within a single Metal command-buffer. #jira UE-33779 Change 3066789 on 2016/07/27 by Daniel.Lamb Realtime mode does not save any packages anymore unless they are ready. #test cookontheside, cookbythebook shooter game Change 3066847 on 2016/07/27 by Jeff.Campeau Fix define #2634 #jira UE-33813 Change 3068868 on 2016/07/28 by Mark.Satterthwaite Extend hlslcc's handling of switch-statements to allow implict casts from scalar bool, half & float as HLSL itself permits while also making sure it errors if the expression input is not scalar. This fixes shader compile errors in UT. Change 3070040 on 2016/07/29 by Dmitry.Rekman Delete Nadzorca. Change 3070947 on 2016/07/29 by Jeff.Campeau Perforce C++ API 2015.2 (includes debug libraries) Change 3073707 on 2016/08/02 by Daniel.Lamb Derived data cache commandlet runs resolve string asset references to load any string asset refereced packages from the map. Also process async results from shaders being compiled so they can have their memory resources released. #test DerivedDataCache commandlet shootergame. Change 3076613 on 2016/08/03 by Brent.Pease + UnrealTargetConfiguration is now passed into deploy and package methods + The UIRequiredDeviceCapabilities plist key now only considers the architectures from the corresponding target configuration (shipping or development) Change 3076668 on 2016/08/03 by Brent.Pease Back out changelist 3076613 Change 3077157 on 2016/08/04 by Daniel.Lamb Fixed up DLC staging so that it stages to the proper mount point. Fixes up include engine content in DLC staging paths. #test Made up shooter game DLC Change 3077191 on 2016/08/04 by Daniel.Lamb More smartly process async shader compilation if we are waiting for it. #test cook on the side shooter game cook by the book shooter game. Change 3077412 on 2016/08/04 by Mark.Satterthwaite Fix "iOS Metal-based build crashes at launch with sub-levels": - Slate should not bind the null RHI texture from an unitialised texture atlas - atlases only have a valid texture pointer once an entry has been added to them and in the template projects an empty sub-level doesn't add anything. - To prevent this kind of bug resurfacing and being so hard to track down add Metal shader binding validation to our validation layer as Apple's is incomplete on iOS and won't warn us about nil texture usage which causes these GPU restarts. This requires reworking our vertex declaration handling to be more efficient so that we can cache the pipeline reflection data as well as the pipeline objects. - Fix validation error of texture reallocation on loading template projects under Metal. #jira UE-30847 Change 3077958 on 2016/08/04 by Brent.Pease + UnrealTargetConfiguration is now passed into deploy and package methods + The UIRequiredDeviceCapabilities plist key now only considers the architectures from the corresponding target configuration (shipping or development) Change 3079503 on 2016/08/05 by Mark.Satterthwaite Initialise more variable types to 0 in Metal shaders to workaround Xcode 8 toolchain no longer doing this for us for "threadgroup shared" variables. Everything but structs and atomic's will now be initialised. #jira UE-33856 Change 3079737 on 2016/08/05 by Jeff.Campeau Add support for delay load DLLs on Xbox One Turn off warnging for missing PDBs to match VCToolchain.cs Change 3081005 on 2016/08/08 by Mark.Satterthwaite Fix-up Metal device name on AMD for macOS 10.12 which reports it correctly and enable tiled reflections on Intel from macOS 10.12 too as they now work. Change 3081557 on 2016/08/08 by Daniel.Lamb File-> Package saves all packages before starting packaging. #test File package first person template Change 3082215 on 2016/08/09 by Lee.Clark PS4 - Added 4k profile Change 3082412 on 2016/08/09 by Daniel.Lamb Fixed cook on the fly server not handling cook requests. #test Cook on the fly shooter game. Change 3082955 on 2016/08/09 by Dmitry.Rekman Linux: convert existing Strcat() uses to Strncat(). - Strcat() does not check destination size so can silently corrupt memory. While this was not observed, this conversion removes this concern altogether. Change 3083772 on 2016/08/10 by Luke.Thatcher [PLATFORM] [PS4] [+] Checking in PS4CrashHandler files so we have a copy in Perforce rather than just on the server. - Taken from \\devweb-02 and removed all the unused files/dependencies. - Created a publish profile pointing to \\devweb-02\Sites\PS4Services\PS4CrashHandlerDev so I'm not writing over the existing deployed crash handler. - Moved all code in the Page_Load event to inside the check for the HTTP method (POST) otherwise GET'ing the page from a browser will generate crash folders that hang around forever. Change 3085450 on 2016/08/11 by Lee.Clark PS4 - Fix mediaplayer pipeline allocation Change 3086360 on 2016/08/11 by Michael.Trepka Fixed a non-unity build error in Mac UnrealFrontend Change 3087224 on 2016/08/12 by Luke.Thatcher [PLATFORM] [PS4] [~] Refactor PS4 Crash Handler site - Removed CoreDumpHandler. Processing dump files is handled directly by an async thread within the aspx process. - Separated configuration values into their own class. Currently set to output to a testing directory, rather than the actual crash reporter landing zone. - Added a debug upload page to allow manual submission of .orbisdmp/.txt settings files, accessible by GET'ing Default.aspx. - Added logging. Logs self-delete after 30 days. Testing required before we switch to the new system. #jira UE-34504 #jira OR-26886 Change 3087626 on 2016/08/12 by Dmitry.Rekman PR #2689: Fix copying/duplicating failing on Linux (UE-34586). - Contributed by Web-eWorks. Change 3087991 on 2016/08/12 by Mark.Satterthwaite Initial AVFoundation implementation of Media Framework for Mac, iOS & tvOS. - Video playback occurs via AVPlayerItemVideoOutput's attached to the AVPlayerItem's output. This means gathering video samples is trivial. - Metal texture updates occur by wrapping the texture object provided by AVF - for Mac this is simple as it can bind to the IOSurface directly, for iOS/tvOS we have to create a CVMetalTextureCache and allocate our texture from there. - OpenGL and OpenGLES currently have to lock the pixel buffer and upload to a texture the old fashioned way - this should be revisited when there is time. - Subtitles/Captions are captured using AVPlayerItemLegibleOutput which also connects to the AVPlayerItem's output. - On Mac audio samples are returned by manually reading from the stream using an AVAssetReaderTrackOutput, including manual seeking and synching. - On iOS/tvOS the audio is played directly by AVPlayer because the IOSAudio system can't handle procedural buffers - otherwise it could reuse the Mac code. - AVFoundation does not support AVI - that's an obsolete Microsoft/Windows file-format. - Only 'file://' URLs are supported - streaming would require a totally different audio solution (using MTAudioProcessingTap) and has many more edge and failure cases that would need to be handled. #jira UE-34315 Change 3088790 on 2016/08/15 by Luke.Thatcher [PLATFORM] [PS4] [~] Hook new PS4 crash handler up to the crash reporter website. - Removed indentation from generated crash context XML file. The crash reporter process does manual XML parsing which doesn't correctly handle whitespace at the start of lines. - Switched the final output folder to match the one the crash reporter process is watching. - Hide upload form on a config variable. #jira UE-34504 #jira OR-26886 Change 3089060 on 2016/08/15 by Luke.Thatcher [PLATFORM] [PS4] [!] Change PS4 crash handler log file extension to ".ps4chlog", otherwise the crash reporter site attaches the wrong log file to the crash report. Allowed showing of debug upload form via "Default.aspx?showform=1" query string. #jira UE-34504 #jira OR-26886 Change 3089089 on 2016/08/15 by Mark.Satterthwaite Duplicated changes to AppleMovieStreamer from CL #3088149. #jira UE-34315 Change 3089460 on 2016/08/15 by Mark.Satterthwaite Duplicate CL #3080971: Workaround a macOS 10.12 Beta bug on some Metal drivers that can't initialise temporary/local variable arrays, only those that are marked threadgroup shared. #jira UE-34355 Change 3089465 on 2016/08/15 by Mark.Satterthwaite For Metal shader translation retain more precision for float constants -1.0f >< 1.0f by emitting them in scientific notation - prevents Hammersley constant amongst others from being flushed to 0. Change 3089902 on 2016/08/15 by Daniel.Lamb Changed the next compiling ID to the correct compiling ID. #test Cook Change 3089903 on 2016/08/15 by Daniel.Lamb Cooker monitors config useage during cook and uses those settings to invalidate cooked content instead of all config settings. Change 3090114 on 2016/08/16 by Luke.Thatcher [PLATFORM] [PS4] [~] Minor change to PS4 settings text on crash handler site. Change 3090949 on 2016/08/16 by Nick.Shin WebSocketNetDriver crash fix filled in missing chunk of code that calls PacketHandler's "packet modifiers" #jira UE-25492 HTML5 Client cannot connect to Windows Server #jira UE-30880 WinServer crashes when NetDriver is set to WebSocket and Client attempts to connect via websocket #code.review john.pollard john.barrett Change 3091265 on 2016/08/16 by Brent.Pease Add IOS support to HarfBuzz Change 3091267 on 2016/08/16 by Brent.Pease Add references to fix mono build Change 3091291 on 2016/08/16 by Nick.Shin CIS warning fix #jira UE-25492 HTML5 Client cannot connect to Windows Server #jira UE-30880 WinServer crashes when NetDriver is set to WebSocket and Client attempts to connect via websocket Change 3091781 on 2016/08/17 by Joe.Barnes UE-33640: Exposed UPrimitiveComponent::IsAnyRigidBodyAwake() to Blueprints. Change 3092687 on 2016/08/17 by Daniel.Lamb Added support for using binned allocator in cooker instead of tbb. #test Cook shootergame. Change 3093867 on 2016/08/18 by Mark.Satterthwaite Use a read/write mutex to protect access to Metal's internal shader pipeline caches so that parallel threads can progress in the common case where new shaders are not being compiled. Change 3093950 on 2016/08/18 by Mark.Satterthwaite Change the Mac GPU identification code to cope with AMD's new naming scheme on 10.12. Change 3093951 on 2016/08/18 by Mark.Satterthwaite More SCW threads on Mac - they work now. Change 3093960 on 2016/08/18 by Mark.Satterthwaite Increase the default number of command-buffers on Mac because bigger games overflow the current limit of 64 per queue. Change 3096493 on 2016/08/22 by Jeff.Campeau Use Xbox version of DirectX include. Change 3097509 on 2016/08/23 by Luke.Thatcher [PLATFORM] [PS4] [+] Refactor PS4 Symbol Publish - Moved the SymStore task from Win.Automation to BuildGraph.Automation, and made it more generic. - The specifics of uploading symbols are now implemented in the platform tool chain, alongside StripSymbols(). - Re-generated the build graph schema file. - Removed the old PS4 symbols upload path in the package step. Modified OrionBuild.xml to publish symbols for all PS4 dev, test and shipping config builds of OrionClient. Change 3097635 on 2016/08/23 by Luke.Thatcher [PLATFORM] [PS4] [+] Refactor Age Symbols task in UAT. - Moved the AgeStore task from Win.Automation to BuildGraph.Automation and made it more generic. - Symbol server directory structure is now defined by the platform tool chain, which the common task uses to clean out old symbols. - Added a "filter" parameter to prevent age tasks deleting symbols from unrelated builds in shared symbol servers. Modified OrionBuild.xml to age both the Windows and PS4 symbol stores. Change 3097713 on 2016/08/23 by Luke.Thatcher [PLATFORM] [PS4] [+] Enable new PS4 crash handler server - Created live deployment profile and applied the required config file changes. Change 3099214 on 2016/08/24 by Luke.Thatcher [PLATFORM] [PS4] [!] Fix compile error in PS4 tool chain. For some reason, this only breaks ocassionally. Maybe we're alternating between the 2013 and 2015 C# compilers depending on what initiates the build (e.g. Visual Studio vs GenerateProjectFiles)? Change 3099222 on 2016/08/24 by Luke.Thatcher [PLATFORM] [PS4] [+] Added PS4 support for FPlatformMisc::MessageBoxExt using the MsgDialog library. - Note, only one and two button message dialogs are supported (limitation of MsgDialog). Change 3099260 on 2016/08/24 by Luke.Thatcher [PLATFORM] [PS4] [~] Better PS4 exit function. Calls quick_exit instead of abort when we've not asserted. Allows for a "cleaner" forced exit without generating a crash dump. Change 3101192 on 2016/08/25 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3101944 on 2016/08/25 by Daniel.Lamb Ask to save the current level when we are using launch on. Change 3102036 on 2016/08/25 by Nick.Shin check for minimum expected size upon data received from network #jira UE-13657 - HTML5 plugin OnRawRecieve overflow Change 3102115 on 2016/08/25 by Brent.Pease - Fix small errors that probably only show up in the mac mono build #code.review peter.sauerbrei Change 3102747 on 2016/08/26 by Jeremiah.Waldron Re-submitting OnlineSubsystemGameCircle with TPS permission for Amazon SDK - Also fixed the plugin to remove any related files from the final package when IAP is disabled or GameCircle support itself is disabled with the plugin still enabled - Added support for new AlreadyOwned IAP response code as well which is already used for GooglePlay and IOS Change 3102900 on 2016/08/26 by Nick.Shin since last checkin (CL: 2981945) - prints are crashing the browser - this change will allow browser to print the details via console.log() #jira UE-26047 - HTML5 HTTP Response Headers not implemented Change 3103130 on 2016/08/26 by Brent.Pease UE-24679 - Enable the ability to change ports for a firewall to pass them through rsync Change 3103225 on 2016/08/26 by Daniel.Lamb Fixed issue with warning which would cause crash. Change 3103425 on 2016/08/26 by Dmitry.Rekman Enable offscreen GL rendering without X. - Added new video subsystem to SDL that is uses EGL to initialize the context. - Most windoing functions stubbed. - Also added a new test case to TestPAL for easier debugging. Change 3104743 on 2016/08/29 by Brent.Pease Support remote offline metal shader compilation Change 3105051 on 2016/08/29 by Brent.Pease UE-2382 - TASK: MobleMVP: iOS: Add ability to view iOS device console output in the editor UFE - IOS Automation will now create a thread to collect the console logs from the device and send them to C# Console output while the app is running on device - Made ProcessResult an interface (IProcessResult) which ProcessResult implements. This allows platforms to provide their own implementation if needed. - Moved the RunLoop related parts of CoreFoundation into MobileDevice.cs Change 3105053 on 2016/08/29 by Brent.Pease - IOS dll's as part of the last check-in Change 3106853 on 2016/08/30 by Jeff.Campeau Implement FD3D11DynamicRHI::RHICreateComputeFence to prevent memory overwrite Change 3107361 on 2016/08/30 by Dmitry.Rekman Renderer: changes to allow postproc delegates. Change 3107362 on 2016/08/30 by Dmitry.Rekman Plugin with a CUDA postproc example. - Linux version only. Runs under a headless GL too (without X). - Disabled during cross-compilation, can be compiled natively only. - CUDA kernel should be compiled separately, CMakefile with compilation attached (can be used to generate VStudio projects as well). - To test the output, run under the debugger, interrupt and set global variable GSaveTheOutput to 50 (this will write out kernel output buffer 50 times as .bmp files into working directory). Change 3107913 on 2016/08/31 by Daniel.Lamb Fixed loading of cooked content in the editor. Change 3107916 on 2016/08/31 by Daniel.Lamb Added error case when shader compilation fails to notify shader. #test Cook shooter game. Change 3108080 on 2016/08/31 by Josh.Adams - Fixed PS4Automation compile errors Change 3109077 on 2016/08/31 by Brent.Pease Fix C# debug builds by specifying x64 and add reference to MobileDeviceInterface Change 3110086 on 2016/09/01 by Dmitry.Rekman Fix race condition in PThread runnable (UE-35074). - Instead of relying on busy-wait, join the threads. This prevents race between PostRun() (executed in the context of the thread) and FPThreadRunnableThread() destructor (see UE-34909). - Do not use an invalid value for pthread_t, since there's none. Change 3110172 on 2016/09/01 by Dmitry.Rekman Fixed a crash exiting VR Preview on Windows GL4 (UE-28708). - PR #2188 submitted by ardneran. Change 3110313 on 2016/09/01 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3111134 on 2016/09/01 by Dmitry.Rekman UBT: prevent mono from hanging on Ctrl-C. - Sometimes Ctrl-C can cause thread creation to fail. Without this change, UBT would lock up. Change 3111171 on 2016/09/01 by Brent.Pease Move all C# projects to use the x64 Platform for consistency with other changes made to move to the x64 Platform Change 3111177 on 2016/09/01 by Dmitry.Rekman Fix Linux build on systems without CUDA (UE-35460). Change 3111548 on 2016/09/02 by Luke.Thatcher [PLATFORM] [PS4] [!] Fix for PS4 iterative deployment. - Changes in Dev-Mobile broke the deployment manifests, as PS4 was now using the wrong filename when creating delta and obsolete file lists. Change 3111863 on 2016/09/02 by Dmitry.Rekman Better fix for build without CUDA (UE-35460). Change 3112738 on 2016/09/02 by Mark.Satterthwaite Fix the pausing particles on Metal - one line bug in the Metal query implementation meant that the first query wouldn't return the correct result for no good reason. #jira UE-34989 Change 3114579 on 2016/09/06 by Chris.Babcock Fix Vulkan include path in NDK check (contributed by geediiiiky) #jira UE-35490 #github #2758 #ue4 #android Change 3115115 on 2016/09/06 by Jeff.Campeau Calculate buffer size for paks using the bitwindow override as needed Change 3115600 on 2016/09/07 by Luke.Thatcher [PLATFORM] [PS4] [~] Make the crash dump handler registration much earlier, to catch crashes in early engine init. - Fixed up places in FGenericCrashContext::SerializeContentToBuffer which used the command line. If we crash early, the command line may not have been initialized yet. - Added a GetNoInit function to FThreadHeartBeat to avoid creating the heart beat thread if we crash early, and the thread doesn't exist yet. Tested by calling abort() immediately inside int main(), and we get a valid crash dump that the crash handler service can consume. Change 3115676 on 2016/09/07 by Luke.Thatcher [PLATFORM] [~] Dev-Platform integration fix for original CL 3064888 in //Orion/Release-29.1 Add .exe and .dll to windows symbol upload file filters. Change 3115811 on 2016/09/07 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3115944 on 2016/09/07 by Michael.Trepka Implemented IsGamepadAttached() for Mac Change 3115948 on 2016/09/07 by Michael.Trepka Don't try to restore Help menu item on Mac if MenuBlock does not contain it Change 3116200 on 2016/09/07 by Jeff.Campeau Fix parameter ordering Change 3117660 on 2016/09/08 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3117728 on 2016/09/08 by Michael.Trepka Copy of CL 3117698 by Mike.Fricker Fixed regression with editor's Simulate mode where cursor would teleport back to the center of the viewport after every click - This bug was introduced in CL 3075932 from a borderless window cursor handling fix that was needed for games that capture the cursor Change 3117797 on 2016/09/08 by Peter.Sauerbrei Shader Resource compression Change 3117988 on 2016/09/08 by Brent.Pease - Solutiion generator will now pick x64 instead of AnyCPU for the default platform configuration - Fix what I think was a merge error in BuildGraph.cs Change 3118296 on 2016/09/08 by Daniel.Lamb Fixed crash with launch on. Couldnt' correctly detect previous generated ini settings. #test launch on QA game #jira UE-35741 Change 3118438 on 2016/09/08 by JohnHenry.Carawon Fix UAT compilation on Linux #UE-35745 Change 3118934 on 2016/09/08 by Jeff.Campeau Shader compression setting based on target platform instead of cooking host platform. #jira UE-35753 Change 3120190 on 2016/09/09 by Ben.Marsh Add missing Platform attribute to build script for Dev-Platform. [CL 3120378 by Josh Adams in Main branch]
2016-09-09 20:13:41 -04:00
public static IProcessResult ServerProcess;
#endregion
#region Run Command
// debug commands for the engine to crash
public static string[] CrashCommands =
{
"crash",
"CHECK",
"GPF",
"ASSERT",
"ENSURE",
"RENDERCRASH",
"RENDERCHECK",
"RENDERGPF",
"THREADCRASH",
"THREADCHECK",
"THREADGPF",
};
/// <summary>
/// For not-installed runs, returns a temp log folder to make sure it doesn't fall into sandbox paths
/// </summary>
/// <returns></returns>
private static string GetLogFolderOutsideOfSandbox()
{
return CommandUtils.IsEngineInstalled() ?
CmdEnv.LogFolder :
CombinePaths(Path.GetTempPath(), CommandUtils.EscapePath(CmdEnv.LocalRoot), "Logs");
}
/// <summary>
/// Fot not-installed runs, copies all logs from the temp log folder back to the UAT log folder.
/// </summary>
private static void CopyLogsBackToLogFolder()
{
if (!CommandUtils.IsEngineInstalled())
{
var LogFolderOutsideOfSandbox = GetLogFolderOutsideOfSandbox();
var TempLogFiles = FindFiles_NoExceptions("*", false, LogFolderOutsideOfSandbox);
foreach (var LogFilename in TempLogFiles)
{
var DestFilename = CombinePaths(CmdEnv.LogFolder, Path.GetFileName(LogFilename));
CopyFile_NoExceptions(LogFilename, DestFilename);
}
}
}
public static void Run(ProjectParams Params)
{
Params.ValidateAndLog();
if (!Params.Run)
{
return;
}
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 4285612) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3836829 by Ben.Marsh UBT: Fix ability to precompile plugins from installed engine builds. Change 3839519 by Ben.Marsh UBT: Simplify configuring bPrecompile and bUsePrecompile settings for modules. Each rules assembly can now be configured as installed, which defaults the module rules it creates to use precompiled data. Change 4042043 by Steve.Robb GitHub #4705 : Added weak lambda's for delegates and multicast delegates. Change 4042056 by Robert.Manuszewski Optimized Mark Phase of GC by up to 10ms by making it run in parallel and removing a huge array presize which we didn't need. Change 4042104 by Robert.Manuszewski Set the minimum GC cluster size to 5 so that GC doesn't have to process micro clusters which are more expensive than processing individual objects + Exposed the minimum cluster size to ini and project settings as gc.MinGCClusterSize + Added the ability to sort clusters by name/object count/mutable object count/referenced clusters count when dumping them with gc.ListClusters command Change 4042377 by Robert.Manuszewski Reworked how GC and other threads (ALT specifically) interact - GC will now notify the ALT it wants to run and ALT will immediately try to finish its current work to allow that. Also the entire ALT tick is now protected against GC running at the same time to improve ALT stability. + added gc.ForceCollectGarbageEveryFrame console variable that triggers a forced GC every frame Change 4042427 by Robert.Manuszewski Changed FGCCSyncObject to use events when waiting for GC to finish so that it doesn't spin on non-game threads when GC is running Change 4042482 by Robert.Manuszewski Unhashing unreachable objects (ConditionalBeginDestroy) will now also be done incrementally, just like the purge phase of Garbage Collection Change 4042635 by Robert.Manuszewski Fix for a potential assert when incremental purge garbage is pending and something forces a full purge Change 4044092 by Steve.Robb Fix for forward declared CoreUObject weakobject types in delegates when building in Clang. Change 4044102 by Robert.Manuszewski Fix for a possible hang when worker threads are preventing GC from running and something is later trying to FlushAsyncLoading with the Async Loading Thread enabled Change 4044113 by Steve.Robb Another Clang fix. Change 4044160 by Robert.Manuszewski Disregard For GC pool will now be enabled by default in cooked builds Change 4044287 by Steve.Robb Typo fix. Change 4047723 by Graeme.Thornton TBA: Fixes for import/export name cache and object resolving Change 4048015 by Graeme.Thornton TBA: Weak/Soft/Lazy pointer serialization changes * Remove FWeakObjectPtr::Serialize, move it's logic into, and replace usages of with calls to, FArchiveUObject::SerializeWeakObjectPtr(). Ensures that something is always sent to the archive so that structured archives can be kept happy in the future. * Added Weak/Soft/Lazy pointer handling to the structured archive slot interface and all the formatters. Binary formatters just forward the call onto their inner and text archives store as a string path reference. * FArchiveUObjectFromStructuredArchive caches all these pointer types and stores indices in the binary block, same as with a UObject*. All pointers are then forwarded to the underlying formatter in one go on finalization. Change 4048021 by Steve.Robb Fix for binding an unbound TFunction to another TFunction with a different signature. Also all null pointers now count as unbindings, not just nullptr. TIsMemberPointer added. TIsATFunction and TIsATFunctionRef renamed to remove the 'A's. Change 4048544 by Robert.Manuszewski Fixing ConditionalBeginDestroy profiling after changes to incremental CBD. Change 4051028 by Graeme.Thornton TBA: ArchiveFromStructuredArchive adapter uses Inner to determine if it is outputting to text, and sets it's own ArIsTextFormat to false Change 4051056 by Graeme.Thornton TBA: High level tagged property / UObject base class text serialization - UObject serialize converted to structured archive - Properties written to text individually with text tags, and then binary adapted values - Only saves, doesn't load Change 4051111 by Graeme.Thornton TBA: Temporarily disable loading of text assets until tagged property serialization path is fixed up Change 4051154 by Graeme.Thornton TBA: Convert a few uobject serializers to structured archive format for example purposes Change 4051181 by Graeme.Thornton TBA: Added default structured archive implementation of SerializeItem to UProperty, which just calls the FArchive version on an FArchiveUObjectFromStructuredArchive adapter. Implemented structured archive SerializeItem for UArrayProperty Change 4051197 by Graeme.Thornton TBA: ObjectProperty text serialization Change 4051216 by Graeme.Thornton Restored a modified FWeakObjectPtr::Serialize function to keep backwards compatibility in code I don't have access to. Change 4051261 by Graeme.Thornton TBA: Convert UMetaData to structured archive Change 4051374 by Steve.Robb Incorrect assert removed. Change 4051562 by Robert.Manuszewski Adding stats for the new GC internal functions Change 4051614 by Graeme.Thornton TBA: Removed UProperty::SerializeItem(FArchive, ...) and replaced with UProperty::SerializeItem(FStructuredArchive::FSlot, ...). Fixed up most of them to work properly and added adapters in for any that were non-trivial. Change 4052512 by Graeme.Thornton TBA: Temporary workaround for softobjectptr and lazyobjectptr uproperties not serialization anything when they know the archive is a reference collector. They should always be serializing their pointers and letting the underlying archive itself ignore them. Change 4053917 by Robert.Manuszewski Clustered objects from clusters that are no longer reachable will now be marked as unreachable immediately when gathering unreachable objects Change 4053919 by Robert.Manuszewski Added the ability to disable incremental BeginDestroy in ini/project settings Change 4055518 by Daniel.Lamb Fixup for deterministic audio generation issue. Submitted on behalf of Rich.Whitehouse #jira nojira #test prefilght automated test. Change 4056854 by Graeme.Thornton TBA: Added a test asset to EngineTest which contains all the different property types and test cases. Change 4056858 by Graeme.Thornton TBA: Updated USetProperty to proper structured archive usage Change 4056872 by Graeme.Thornton TBA: Add map property field to test object Change 4056873 by Graeme.Thornton TBA: Convert UMapProperty to full structured archive Change 4056994 by Graeme.Thornton TBA: Converted FText over to structured archive. Implemented saving, but not loading. Change 4059728 by Ben.Marsh UBT: Add support for using adaptive non-unity builds when the engine and project are in separate repositories. Change 4059805 by Graeme.Thornton Fixed typo in text serialization. Fixes CIS automation test errors Change 4060007 by Graeme.Thornton TBA: FArchiveFromStructuredArchive will now access it's host slot lazily, i.e. only when a value is actually written to the archive. Change 4060092 by Stefan.Boberg Added optimized Windows console window output path to GenericConsoleOutput since this slowed down cooking considerably (2 minutes spent in wprintf alone for one large dataset) When stdout is attached to a console we use the WriteConsoleW function instead of wprintf since the latter is very slow especially in unbuffered mode which the engine currently configures for stdout (see setvbuf call in LaunchEngineLoop.cpp). At some point we should reconsider this buffering policy since it's likely to slow down other platforms as well but I wanted to do a safe change for now as I don't yet fully understand why the setvbuf call is there in the first place. Change 4060108 by Stefan.Boberg Introduced some additional target platform utilities to help with asset cook optimizations * We now assign each ITargetPlatform a zero-based ordinal value * Introduced FTargetPlatform and FTargetPlatformSet types to help store platform references and platform sets efficiently. These are not currently used in the engine but are designed to replace the existing ITargetPlatform/string/FName representations in the cooking data structures. Change 4060143 by Graeme.Thornton Undo //UE4/Dev-Core/Engine/Source/Runtime/... changelist 4060007 Needs some other changes that I haven't checked in yet... Change 4062432 by Ben.Marsh Fix error message when enumerating P4 changes. Change 4062648 by Ben.Marsh Add missing p4 integration action. Change 4063620 by Graeme.Thornton Integrated a fix from UDN where the engine would crash when trying to load a very small encrypted file (<16bytes) from a pak file, where the read address wasn't already aligned to the AES block size. (https://udn.unrealengine.com/questions/431989/crash-while-reading-a-very-small-file-in-encrypted.html) Change 4066963 by Robert.Manuszewski Fixing GC cluster verification code reporting false positives when a cluster is referencing another cluster through 'mutable' objects list. Change 4067133 by Robert.Manuszewski Changed log verbosity when reporting individual cases of GC cluster assumption violations as they are followed by an asser anyway and this way we get the chance to see all issues before we assert at the end of these checks. Change 4067443 by Steve.Robb FString can now be constructed from any char pointer type and length. Change 4068156 by Steve.Robb Fix necessary because of FString constructor change in CL# 4067443. Change 4070258 by Graeme.Thornton Fixes for VSCode Change 4070372 by Graeme.Thornton TBA: Script struct serialization to structured archives Change 4071913 by Ben.Marsh Move bulk of the code for UnrealPak into an engine developer module, so it can be used in the editor. Change 4071914 by Ben.Marsh Missing files. Change 4071937 by Ben.Marsh Missing header. Change 4072015 by Ben.Marsh Fixes for compiling PakFileUtilities as part of the editor. Change 4072826 by Steve.Robb TBitArray::Reserve() added. TBitArray::Add() overloaded to allow adding multiple bits. TSparseArray::Reserve() optimized to call the overloaded Add(). Change 4073271 by Daniel.Lamb Fixed add patch tier in project launcher passing the wrong commandline option to UAT. #test none Change 4074708 by James.Hopkin #core Removed redundant Casts Change 4074763 by Steve.Robb Fix for TSparseArray::Reserve() size. Change 4076063 by Ben.Marsh Add an "UnrealPak" commandlet with the same functionality as the standalone UnrealPak program. Invoke by running the editor with -run=UnrealPak and the standard UnrealPak commandline options. Change 4077064 by Robert.Manuszewski Fixing compile error in PakFileUtilities Change 4077144 by Graeme.Thornton TBA: TextAssetCommandlet improvements * Collect lists of broken assets during roundtrip tests and print a summary of packages that failed each phase at the end * After resaving as text, load the file back as a plain JSON hierarchy to ensure the output was valid Change 4077412 by Ben.Marsh Set the correct exit code for UnrealPak. Should return 0 on success, not 1. Change 4077760 by Graeme.Thornton TBA: Loading fixed for tagged property serialization Includes conversion of all UProperty::ConvertFromType() and SerializeFromMismatchedTag() functions to use structured archives Lazy initialization of FArchiveFromStructruredArchive when loading, to support the possibility of an adapter being create around an object property serialize call to its inner UStruct, which then decides not to do anything and return false. Stops the ArchiveFromStructuredArchive from consuming the slot and getting upset later on when we try to serialize normal tagged properties from it. Disabled lazy bulk data loading from text assets. Requires a bigger change to make it work. Added some debug checks to json input formatter which track the current value stack size when a new object is pushed onto the stack, and makes sure that the stack has returned to the same size when the object is popped. Catches cases where we unpack an array/stream to the value stack but then don't consume all the items. Change 4078800 by Ben.Marsh Change UAT to using the editor's UnrealPak commandlet rather than invoking the standalone UnrealPak executable. To improve performance when building several PAK files, also add a new -batch=<file> command which reads commands to execute in parallel from a text file. Change 4079745 by Graeme.Thornton TBA: Migrated a couple of UObject Serialize functions to FStructuredArchive (SoundCue / MaterialExpressions / Editor strip flags) Change 4079847 by Graeme.Thornton TBA: Add 'FindMismatchedSerializers' mode to text asset commandlet, which dumps out a list of all UClasses which don't have the CLASS_MatchedSerializers flag, meaning we can't guarantee the have Serialize functions for FArchive AND FStructuredArchive, therefore we can't use the new structured archive based serialize path. Should only ever be native instrinsic classes as UHT takes care of all other cases. Change 4079925 by Ben.Marsh Fix incorrect assignment when deriving name for chunked pak file. Change 4080214 by Ben.Marsh Move the ThreadPoolWorkQueue class into DotNETUtilities so it can be used by other projects. Change 4082394 by Graeme.Thornton CIS fix for variable shadowing warning Change 4082583 by Ben.Marsh Add a IBinarySerializable interface for types that support reading from a BinaryReader and writing to a BinaryWriter. Implementing IBinarySerializable implies a constructor taking a BinaryReader argument is available for deserializing. Change 4082652 by Ben.Marsh Fix FileReference.Directory not returning a directory with a trailing backslash for files in the root directory. Change 4082755 by Graeme.Thornton Fixed an erroneous usage of TUniquePtr<uint8>as a pointer to a uint8 array when creating pak files. Caused a crash when compression was enabled, and has probably surfaced because pak generation is now done by an editor commandlet rather than a standalone program. Change 4082756 by Graeme.Thornton Fixed some incorrect documentation for pakfile compressed chunk headers Change 4082883 by Graeme.Thornton Static analysis warning fix Change 4082912 by Ben.Marsh Move ExceptionUtils into DotNETUtilities. Change 4085291 by Graeme.Thornton TBA: In the Json output formatter, write float and double values out with enough precision for successful roundtripping. Added some debug only code which will immediately reconvert the string back to its original value and compare the the input Change 4085523 by Graeme.Thornton TBA: Remove only explicit usage of DECLARE_FSTRUCTUREDARCHIVE_SERIALIZER. Should only be used from UHT generated code. Change 4086037 by Robert.Manuszewski Fix for a potential race condition when two threads want to acquire GC lock Change 4088655 by Graeme.Thornton Pak creation now uses the bEnablePakSigning setting from the crypto config json file Change 4091474 by Steve.Robb Fix for TStaticBitArray::FindFirstSetBit() and TStaticBitArray::FindFirstClearBit(). Unused variables removed. Change 4093632 by Steve.Robb CIS fixes. Change 4093656 by Graeme.Thornton Build fix Change 4093744 by Ben.Marsh Allow per-chunk settings for whether to enable compression in UnrealPak. Change 4099712 by Gil.Gribb UE4 - Fixed rare case where insufficient space was preallocated for cooldown ticks. #jira UE-59686 Change 4099912 by Stefan.Boberg Cooking timer optimizations: - Replaced data structures for FScopeTimer and FHierarchicalTimerInfo. Previous implementation used FString for many things and caused *lots* of heap and string concatenation activity. Replaced with a compile-time node id (using __COUNTER__) and raw string literals. - Removed PERPACKAGE_TIMER support (was disabled by default and was difficult to test) - Made it possible to toggle OUTPUT_TIMING and ENABLE_COOK_STATS independently - Removed some extremely tight timers because the overhead from calling QPC significantly exceeded the measured code This change shaved some 15% off a clean cook of Fortnite WindowsClient (en) with fully populated local DDC Change 4100519 by Stefan.Boberg Quick fix for Linux build issue introduced in 4099927 Change 4105327 by Stefan.Boberg Cooker: Changed FHierarchicalTimerInfo so it uses a linked list for tracking child nodes, to be able to deal with any child count. Previously we assumed there would never be more than 9 children but it turns out there are cooker modes that need more. Fixes check when using -FullLoadAndSave to cook Change 4105448 by Stefan.Boberg - Fixed Linux build warning re: member initialization order - Also eliminated OUTPUT_HIERARCHYTIMERS/CLEAR_HIEARCHYTIMERS macros (plain functions are fine) - Moved finishing-up code for FullLoadAndSave() to TickCookOnTheSide() call site to improve timer output. Previously some of the scopes would not have been closed before printing and thus the output was misleading. Change 4109031 by Ben.Marsh Attribute-driven Perforce wrapper (old Epic Friday project). Offers a more complete implementation than the current P4 wrapper in UAT without requiring any platform-specific libraries. Uses the Python binary output for parsing. Change 4109588 by Ben.Marsh UBT: Add extension methods for serializing a nullable type to a BinaryReader/BinaryWriter. Change 4109595 by Ben.Marsh Missing project file for DotNETUtilities. Change 4110724 by Stefan.Boberg Removed annotation map locking in UObjectMarks, eliminating around one minute (~3.5%) from Fortnite cook time. The locking was redundant since the annotation maps are managed per thread anyway. Change 4111304 by Ben.Marsh UAT: Add support for setting a status message through the log class. Allows writing transient messages (eg. progress messages) which will be cleared out before writing other messages. Best used through the LogStatusScope class, which can set a status message for the duration of a using() block. As part of this change, the console no longer has to be added as a dedicated trace listener. Since we already special-case this listener when formatting log output, it's easier to just keep the implementation separate to the other trace listeners. Change 4112708 by Steve.Robb Fix for TBitArray::MaxBits in assignment. Change 4114133 by Stefan.Boberg Tweaked how low-level memory (LLM) tracker is implemented to reduce overheads. Previously FMemory functions would acquire the LLM singleton and call OnLowLevelFree/OnLowLevelAlloc etc which would check the bIsDisabled flag and early out if it was set. Due to how frequently these functions were called this ended up costing quite a bit. - This change makes the flag a static member variable instead of a member variable and therefore enables a simpler early-out to be implemented. - The singleton getter is also simplified to avoid hitting the threadsafe singleton construction path on every call. - The enable flag is no longer TAtomic - this also incurs extra overhead for no clear benefit Shaves approximately 3.5% (one minute) off a Fortnite cook test scenario (using -FullLoadAndSave) Change 4115010 by Robert.Manuszewski Fixing CIS Change 4115249 by Robert.Manuszewski Fixing async loading code asserts when exiting game very early due to an error #jira UE-56267 Change 4117091 by Ben.Marsh Prevent doubled-up lines when writing status updates with console log verbosity. Change 4117207 by Ben.Marsh UGS: Do not include executables in diagnostics zip file, and ignore "no such files" error when cleaning workspace. Change 4119175 by Ben.Marsh UGS: Fix crash writing version files when directory does not already exist. Change 4119987 by Ben.Marsh UGS: Show a dialog box while the launcher is updating executables from Perforce, which allows cancelling the operation if necessary. Allow setting the username on the settings window, and prompt for login credentials if necessary. Should prevent situations where users have to update settings from the command prompt. Holding down shift during launch now shows the settings dialog rather than an immediate prompt to launch the unstable version (unstable version is shown as a checkbox on this dialog). Change 4119991 by Ben.Marsh Update version number for UGS launcher to 1.13. Change 4121943 by Robert.Manuszewski Don't use FArchiveAsync2 for reading packages with non-async path in editor builds as its performance is worse than the standard archive's (saves about 1 minute when doing larger cooks and 7 seconds when loading into PIE) Change 4122592 by Steve.Robb GitHub #4762 : Improve wording and grammar of Math comments Also includes improved accuracy in FMath::ComputeBoundingSphereForCone(). Change 4122819 by Stefan.Boberg Don't call CreateDirectory redundantly when opening files for writing using FFileManagerGeneric::CreateFileWriter This change avoids calling IPlatformFile::CreateDirectoryTree if possible since this is a very expensive function especially for deep hierarchies as it performs directory creation from the root directory onwards instead of from the leaf downwards. That function should also be fixed but this change improves performance in the meantime. Change 4122872 by Stefan.Boberg CreateDirectoryTree now creates directories leaf-to-root instead of the other way around. This is much more efficient since we don't spend time on system API calls for directories which already exist. This accounted for a very large amount of CPU time in cooking as the full target file directory hierarchy would be "created" for every single output file. Change 4123109 by Stefan.Boberg - Disable overlapped I/O in editor / cooker. Synchronous I/O reduces the number of syscalls and Windows performs prefetching on our behalf anyway for sequential reads - Eliminated syscall which was issued for every write to update cached file size -- since we're the only writers to the file (file access allows read sharing at most) we can authoritatively update the file size on write completion Change 4123455 by Ben.Marsh PR #4775: New build param PCHMemoryAllocationFactor to set /Zm VS build param. (Contributed by lucaswall) Change 4124207 by Ben.Marsh UBT: Remove some unnecessary indirection for generated code paths. Change 4124217 by Ben.Marsh UBT: Remove another unused variable from UEBuildModuleCPP. Change 4124377 by Stefan.Boberg In IPlatformFile::DeleteDirectoryRecursively, attempt to delete file first and if it fails clear the readonly flag and try again Previously there was a call to clear the readonly flag for every deleted file and this is a waste of resources 99% of the time. The SetFileAttributes call accounted for a significant amount of time during cooker sandbox directory deletion Change 4125071 by Stefan.Boberg Some tweaks to FQueuedThreadPoolBase scheduling and memory management - Explicitly pass in false for TArray::RemoveAt(..., bool bAllowShrinking) argument to prevent memory reallocation when arrays are drained and inevitably repopulated shortly afterwards - Use a MRU strategy instead of LRU when picking a thread to wake up. The MRU thread is the most likely to have a 'hot' cache for the stack etc. Picking from the back of the array also happens to be cheaper since no memory movement is necessary when RemoveAt is called. (This was the strategy in place before CL2600362 which seems to have changed it unintentionally) - Release lock as soon as a thread has been chosen, before asking the worker thread to wake up and do the work Change 4126132 by Ben.Marsh UAT: Detect when stdout is redirected and prevent using backspace characters to move the cursor. Change 4126867 by Graeme.Thornton TBA: Fix tagged binary formatter Change 4127010 by Robert.Manuszewski AnimScriptInstances created at runtime will now also be added to the owning omponent's cluster to avoid GC issues. Change 4127932 by Ben.Marsh WorkspaceTool: Reduce unnecessary logging of status messages when console output is not redirected. Change 4129050 by Ben.Marsh UGS: Check for NET Framework 4.5 being installed before running the installer. Also fix warning trying to kill existing UGS instances before upgrade. Change 4129459 by Graeme.Thornton TBA: TextAssetCommandlet - When outputting converted assets to an output path, replicate the workspace relative path in the output directory Change 4129515 by Graeme.Thornton TBA: Add EnterRecord overload that allows outputting of available field names when loading. Change 4129517 by Graeme.Thornton TBA: Tagged properties are written out as named fields on the "Properties" record, rather than as a stream with a null tag at the end Change 4129518 by Graeme.Thornton TBA: Added a local const bool to allow easy hacking out of text asset loading support Change 4129558 by Graeme.Thornton TBA: Build fix for textasset-less configs Change 4129614 by Ben.Marsh UGS: Main window is now restored to normal size when activated by clicking on the tray icon. #jira UE-60490 Change 4129618 by Ben.Marsh UGS: Speculative fix for unreproduced exception accessing disposed window while shutting down. Change 4131936 by Robert.Manuszewski Removing some WIP code accidentally checked in with CL #4121943 Change 4133490 by Ben.Marsh UGS: Allow the $(Change) variable to be used in more places than just the context menu. #jira UE-60573 Change 4133550 by Ben.Marsh UGS: Setting for whether or not to use incremental builds is now exposed through the variable "$(UseIncrementalBuilds)" for use by custom build steps. #jira UE-60554 Change 4133681 by Ben.Marsh UGS: A per-project list of folders and extensions to be deleted by default when running the 'clean workspace' tool can now be specified through the <ProjectDir>/Build/UnrealGameSync.ini file. Settings may be specified for an individual branch (via a category with the depot path to the project) or for wherever the project is currently open (via the [Default] category). The SafeToDeleteFolders list specifies a substring that will be checked against folder paths. Anything containing this folder will be marked as safe for delete by default. The SafeToDeleteExtensions list specifies a list of extensions for files that can always be deleted. Example: [Default] +SafeToDeleteFolders=/MyGame/Test/ +SafeToDeleteFolders=/DataService/ +SafeToDeleteExtensions=.xx1 +SafeToDeleteExtensions=.xx2 #jira UE-60575 Change 4135449 by Ben.Marsh Fix allowing use of Job objects on Windows platforms (debug code submitted by mistake) Change 4135730 by Ben.Marsh UBT: Plugins can now be enabled and disabled from the .target.cs file (for targets that do not use the shared compile environment), by compiling the list of enabled/disabled plugin names into the Projects module. Change 4135823 by Ben.Marsh UBT: Remove legacy code to handle disabling optional plugins; now that this is compiled into the target, it will work for any plugins we choose. Change 4135945 by Ben.Marsh UBT: Fix error running programs with no explicitly enabled or disabled plugins. Change 4137207 by Ben.Marsh UGS: Align all badges with the same name, to make it easier to see which CIS steps are being run. Allow overriding the slot taken by a particular badge by calling it "SlotName:LabelName". Change 4137311 by Stefan.Boberg Removed child cooker support. In practice it is not a useful feature as it provides no performance improvement (quite the opposite in fact) and adds testing and maintenance complexity. Change 4137393 by Ben.Marsh UGS: Fix display of multiline errors in the status panel. Change 4141708 by Steve.Robb GitHub #3631 : Incorrect default argument in WeakObjectPtrTemplate #jira UE-45490 Change 4146655 by Stefan.Boberg Removed FullGCAssetClasses logic - no longer necessary nor useful Change 4147318 by Ben.Marsh UGS: Compress build badges in a column if it shrinks below the size that they would be visible. Change 4148207 by Ben.Marsh UGS: Added support for showing the latest completed build from a specific list of badges in the status panel. To declare a badge as one that should appear in the status panel rather than the CIS column, add it to the project's UnrealGameSync.ini in the project or [Default] section like so: +ServiceBadges=RoboMerge Change 4148282 by Stefan.Boberg Fixed bug in UCookOnTheFlyServer::GetCookOnTheFlyUnsolicitedFiles - UnsolicitedFiles should be passed by reference not by value Change 4148344 by Stefan.Boberg Fixed minor indentation error (most likely caused by sloppy merge) Change 4148521 by Stefan.Boberg Removed accidentally checked in PRAGMA_DISABLE_OPTIMIZATION from CookOnTheFlyServer.cpp Change 4148639 by Ben.Marsh UGS: Fix tooltips not showing for changes that have description badges. Change 4149373 by Ben.Marsh UGS: Allow adding additional columns to display particular badges by adding entries from the project config file. Example syntax: +Columns=(Name="Desktop",MinWidth=50,DesiredWidth=100,Weight=3,Badges="Editor") +Columns=(Name="Mobile",MinWidth=50,DesiredWidth=100,Weight=3,Badges="IOS,Android") Same form can be used to control how default columns are displayed (though badge settings are ignored). Also allow PerforceMonitor to detect local changes to project config files and update settings automatically. Change 4149399 by Ben.Marsh UGS: Update version to 1.143. Change 4155660 by Steve.Robb PROJECTION and PROJECTION_MEMBER macros which provide the correct behavior when creating projections using functions which are overloaded or use default arguments. Change 4157117 by Ben.Marsh Fix warning due to plugins disabled in .target.cs file. Change 4158011 by Ben.Marsh UBT: Add a check that the UnrealHeaderTool target file exists, rather than throwing an exception when reading it fails. Change 4158646 by Ben.Marsh UGS: Fix exception when login is discovered to have expired during a workspace update. Change 4158678 by Ben.Marsh UGS: Fix an exception on shutdown due to the icon being hidden after it's already been disposed. Change 4158683 by Ben.Marsh UGS: Add an unhandled exception filter which sends the exception data to the backend. Change 4159131 by Ben.Marsh UGS: Reduce the number of characters displayed for build badges based on the available space. Change 4159194 by Graeme.Thornton TBA: Fix incorrect map property conversion code when converting an old property that contains a map with different key/value types Change 4159239 by Steve.Robb Improved readability and compliance with coding standards. Change 4159246 by Ben.Marsh UGS: Allow syncing projects where source code is not available (and various version files don't exist). #jira UE-60985 Change 4159286 by Ben.Marsh UGS: Remove requirement for UE4Editor.target.cs to be visible in the depot in order to open a project. #jira UE-60986 Change 4159302 by Ben.Marsh UGS: Update version to 1.144. Change 4160308 by Ben.Marsh All staging client executables for blueprint projects. #jira UE-60983 Change 4161567 by Steve.Robb GitHub #4816 : UE-60771: Handle escaped double quote in FParse::LineExtended Change 4162641 by Ben.Marsh UGS: Allow customizing the position of custom columns, via the Index=N attribute. Change 4162647 by Ben.Marsh UGS: Update version to 1.145. Change 4165319 by Robert.Manuszewski PR #4812: Fix inconsistent command-line argument handling under Windows (Contributed by adamrehn) Change 4166150 by Ben.Marsh UGS: Include *.inl when looking for code changes. Change 4166551 by Steve.Robb Whitespace fixes caused by a bad merge. Change 4168483 by Ben.Marsh UGS: Add a more useful error if a file to be synced exceeds the max allowed path length. Change 4168490 by Ben.Marsh UGS: Update version to 1.146. Change 4168551 by Ben.Marsh UBT: Move bBuildLargeAddressAwareBinary into an exposed setting. Change 4168560 by Ben.Marsh UBT: Remove static config variable for controlling which configuration of UHT to use. Change 4171296 by Ben.Marsh UGS: Move the check for overlong paths earlier. Change 4171531 by Ben.Marsh UBT: Fix exception if BuildConfiguration.xml contains an unknown category. Change 4183371 by Robert.Manuszewski Fix for a crash in Async Loading Graph's CheckCycles when GC kicks in on the game thread and forces ALT to exit early Change 4184312 by Ben.Marsh UGS: Update version to 1.148 Change 4184480 by Robert.Manuszewski Removing unused async loading stat Change 4186390 by Ben.Marsh UBT: Format XML validation errors in a format that allows double-clicking on the message in Visual Studio. Change 4188644 by Ben.Marsh UBT: Add the MakePathSafeToUseWithCommandLine() function to UBT. Change 4188647 by Ben.Marsh UBT: Fix exception in target receipt when architecture is null. Change 4189617 by Ben.Marsh Change FileSystemReference, FileReference and DirectoryReference objects to use OrdinalIgnoreCase comparisons without creating a separate copy of the string to compare. The filesystem does not use the invariant culture, and it can produce the wrong results in some cases (the ordinal comparison is faster, too). Change 4189740 by Ben.Marsh UAT: Remote code to build UnrealPak when packaging; we use the editor now. Change 4189860 by Ben.Marsh UGS: Make the filter for excluding automated lighting rebuilds more explicit. Change 4190082 by Ben.Marsh Fixes to allow enabling edit and continue for Windows builds. Have experienced quite a few VS crashes when testing it in editor; not yet recommended for general use. - Allow edit and continue for any configuration, not just debug. - Fixed PDB errors compiling files that use a shared PCH with edit and continue enabled. Path to the generated PDB file was using the wrong directory. - Removed code that tracks PDB output files, since they're modified multiple times during a build. - Enable debug information when compiling generated CPP files, since it causes errors if the shared PCH PDB doesn't have the same option. - Disable support for remote execution of steps that modify the PDB, since the same file has to be modified many times. Remote execution causes the PDB files to be corrupted. Unfortunately, this makes E&C builds significantly slower. #jira Change 4192949 by Ben.Marsh UBT: Minor tidy-up (merging UEBuildBinary.Build and UEBuildBinary.SetupOutputFiles) Change 4193218 by Ben.Marsh Fix formatting. Change 4197252 by Mike.Erwin UAT: Fix log output w/ correct count of non-code projects. #jira none Change 4197941 by Ben.Marsh UGS: Add support for DebugGame editors that have an executable with a DebugGame suffix. Change 4197964 by Ben.Marsh UGS: Prevent attempts to automatically reopen projects while a modal dialog is up, or the workspace is syncing. Change 4198144 by Ben.Marsh UGS: Prevent modal dialogs when login expires in P4, and prompt for password when hitting "retry". Change 4198413 by Ben.Marsh UGS: Always show the main window when launched manually, and run with -RestoreState when launched at startup. Also add a couple more places that save the visibility state, since logging off seems like it can terminate the process abrubtly. Change 4198779 by Ben.Marsh UBT: Allow generating manifests to any arbitrary locations with the -Manifest=<Path> argument. Change 4198825 by Ben.Marsh UBT: Move code to enumerate Slate runtime dependencies into the Slate module. Doesn't need to be done inside core UBT. Change 4199341 by Ben.Marsh UGS: Update version to 1.149 Change 4199642 by Chad.Garyet - Deprecate CISController - Add BuildController to replace CIS GET/POST for builds - Add LatestController, GET does what CIS/GET used to do - Change Latest/GET to return the last 25 builds filtered by project, rather than the last 5000 individual Ids - Latest/GET now returns "LatestData" object instead of array of longs - Updated EventMonitor to match all API changes - Fixed bug where IDs were getting reset to initial startup values every update loop Change 4199663 by Chad.Garyet CIS controller still needs to return an array of longs #jira none Change 4199680 by Ben.Marsh UGS: Update version to 1.150 Change 4200457 by Ben.Marsh Merging CIS fix for non-development configurations. Change 4200472 by Mike.Erwin UAT: fix -skipbuildclient param default It was defaulting to skipbuildeditor's value, likely a copy-paste error. #jira none Change 4202595 by Ben.Marsh Fix static analysis warning due to constant comparison against macro. Change 4203250 by Ben.Marsh UGS: Always show the "Sync Precompiled Editor" option, but disable it and show a tooltip explaining why if it is not available. Change 4206191 by Ben.Marsh Exclude editor target files from installed builds, since they leak info about DLLs that have been stripped out. Change 4213011 by Ben.Marsh UBT: Include contents of modified intermediate files in the log, to make it easier to debug hidden dependencies. Change 4213487 by Ben.Marsh UBT: Fix assumption that bPrecompile is equivalent to bBuildAllModules. This is no longer the case; they are now controlled by separate options. Should fix CIS errors building the editor. Change 4213609 by Ben.Marsh Ensure that strings formatted using FMicrosoftPlatformString::GetVarArgs() are always null terminated, whether we use the secure CRT or not. Change 4215971 by Ben.Marsh UBT: Remove action graph visualization code; no longer used. Change 4215996 by Ben.Marsh UBT: Remove unqiue id from all actions in the action graph. This is only used for printing debug info in the case of a (rare) cycle in the action graph, so just look it up when needed. Change 4216022 by Ben.Marsh UBT: Rename Crypto.cs to EncryptionAndSigning.cs to match the name of the class inside it, and move it under the System folder. Change 4216031 by Ben.Marsh UBT: Move all the action executors into their own folder in the project. Change 4216526 by Ben.Marsh Fix CIS warnings. Change 4216544 by Ben.Marsh Replace custom code to ensure FMicrosoftPlatformString::GetVarArgs() null terminates its buffer with Microsoft's standards-compliant implementation. Change 4216633 by Ben.Marsh Add support for UnrealPak plugins. * Project and plugin modules can now specify an array of supported programs in the "WhitelistPrograms" field of their module descriptors, to allow modules to be loaded by programs. * Programs can now load any runtime modules, as long as they are whitelisted. * Programs under the engine directory can now use a shared build environment, so that building with a project file does not cause output binaries to be output to the project directory. * UnrealPak is now always built by default when packaging * Convert UnrealPak to a modular configuration Change 4216736 by Ben.Marsh UnrealPak: Move "ExportDependencies" command into an editor commandlet, since it relies on the UObject system, asset registry, etc... Change 4217447 by Ben.Marsh Back out revision 50 from //UE4/Dev-Core/Engine/Build/InstalledEngineBuild.xml Change 4217451 by Ben.Marsh Back out revision 11 from //UE4/Dev-Core/Engine/Plugins/Developer/VisualStudioSourceCodeAccess/Source/VisualStudioSourceCodeAccess/VisualStudioSourceCodeAccess.Build.cs Change 4217617 by Ben.Marsh Back out changelist 4217451 Change 4222552 by Ben.Marsh Don't use #import <TypeLib> for VS source code accessor when building with Clang; it's not supported. Change 4222630 by Ben.Marsh UBT: Fix spam while generating project files if Clang isn't installed. Change 4223316 by Ben.Marsh UBT: Change the order in which Visual C++ toolchains are enumerated to prefer full releases over preview releases. Change 4223318 by Ben.Marsh UBT: Add a build setting which allows creating a dedicated PCH for every file that's excluded from the unity working set (disabled by default). Improves iteration times when working on individual cpp files, but slows down iterating on header changes (and can take a lot of disk space for large changes). Dedicated PCH contains all includes scraped from the top of each cpp file, until a non-#include directive is encountered. Change 4223401 by Ben.Marsh UBT: Add an option to automatically enable edit and continue for files in the adaptive non-unity working set. E&C doesn't seem very useful for UE4 projects right now; compile time is comparable to regular build times, but it can take several minutes to apply code changes for large projects. Change 4223899 by Ben.Marsh UBT: Fix loading XML config files on Mono; Type.GetField(Name) does not seem to return values unless binding flags are specified. Change 4224637 by Ben.Marsh Add a "SupportedPrograms" field to plugin descriptors, which allows plugins to declare which plugins they support independently of individual modules. Programs now respect the "bEnabledByDefault" setting in plugins. Plugins that are compatible with a program now need to list that program in the SupportedPrograms list, and whitelist any modules that should load for that program. Change 4224710 by Ben.Marsh UBT: Don't add import libraries as final build products unless the target is being precompiled. Prevents the need for building them for leaf nodes in the action graph. Change 4224715 by Ben.Marsh UBT: Remove hack to allow Stats2.cpp to not follow IWYU convention. Change 4224726 by Ben.Marsh Remove commented out line. Change 4224903 by Ben.Marsh Fix non-unity compile error in Stats2.h. Change 4225051 by Ben.Marsh Back out changelist 4224710; causing CIS errors due to receipts not matching. Change 4225134 by Ben.Marsh Fixing non-unity errors. Change 4225203 by Ben.Marsh Another non-unity fix. Change 4225249 by Ben.Marsh Fix Linux dependencies being copied for the Windows editor; they can be added as requirements for the Linux target platform on Windows instead, so it respects the user's chosen platforms. #jira UE-62001 Change 4225512 by Ben.Marsh BuildGraph: Allow setting the target to build when using the <CsCompile> task. Change 4228815 by Ben.Marsh UBT: Always add the generated code directory to the list of include paths when generating project files. It may only be created after UHT has been run. Change 4228944 by Ben.Marsh UBT: Remove legacy CppCompileEnvironment and LinkEnvironment wrappers from TargetRules that were deprecated in 4.19. Change 4229028 by Ben.Marsh UBT: Fix editor targets with unique build environment having the wrong executable path in generated project files. Move move logic to configure target rules post-construction by the rules assembly to ensure it's valid. Change 4229065 by Ben.Marsh UBT: Move another target setting into the rules assembly. Change 4229105 by Ben.Marsh Fix BPT exception when generating project files. Change 4229311 by Ben.Marsh UBT: Store the module rules file location on the ModuleRules instance, as well as the plugin that it was created from. Also expose the plugin directory as a property on the ModuleRules instance. Change 4229421 by Ben.Marsh UBT: Consolidate functionality for UHT module setup in ExternalExecution.cs. Change 4229817 by Ben.Marsh UBT: Modules must now explicitly specify the path to the header used to generate a PCH if one is desired, rather than the header being determined automatically by attempting to parse the source code. Now that PCHs are force-included anyway, this removes a lot of dependencies inside UBT. Change 4229824 by Ben.Marsh UBT: Remove unused lists inside UEBuildModuleCPP.SourceFilesClass. Change 4229841 by Ben.Marsh UBT: Remove some legacy code from auto-detecting PCHs. Change 4230521 by Ben.Marsh UBT: Add utility functions to the log class to allow formatting errors and warnings in Visual Studio output format (eg. File(Line): warning: Message) Change 4230871 by Ben.Marsh UAT: Remove StreamUtilis utility class; there is a simpler way to implement the one place it's used. Change 4230882 by Ben.Marsh UAT: Add StreamUtils back into UAT, seems like it's still used there. Change 4230896 by Ben.Marsh UBT: Remove some redundant parameters from UEBuildModule/UEBuildModuleCPP/UEBuildModuleExternal constructors. Change 4231014 by Ben.Marsh WorkspaceTool: Include a dump of raw bytes when garbage is read from the P4 process, for diagnostic purposes. Change 4231032 by Ben.Marsh Fix CIS. Change 4231096 by Ben.Marsh Bump the FlatCPPIncludeDependencyCache version, to prevent errors trying to load old files. Change 4231446 by Ben.Marsh UBT: Added support for expanding UE-specific variables in include paths and library paths: $(EngineDir), $(ProjectDir), $(PluginDir), $(ModuleDir). Change 4231460 by Ben.Marsh Modules may now explicitly specify rpaths on Linux via the PublicRuntimeLibraryPaths and PrivateRuntimeLibraryPaths properties. Change 4233909 by Robert.Manuszewski PR #4779: Reason fails as the supplied variable is incorrect (Contributed by projectgheist) Change 4233910 by Ben.Marsh Enable PCHs on IOS. Reduces build time by ~25%. Change 4234176 by Ben.Marsh UBT: Add better messaging for modules that need to have a private PCH set. Now detects the likely PCH using the same method as legacy code and includes it as a suggestion. Change 4234193 by Ben.Marsh Add the Delete command to Perforce wrapper in DotNETUtilities. Change 4234688 by Ben.Marsh UBT: Simplify handling of installed/precompiled builds. Settings for whether a folder is installed/read-only or not is now stored on the RulesAssembly instance, allowing multiple things to be configured separately and stacked together (eg. engine/enterprise/project). RulesAssembly.IsReadOnly() allows determining if a flie can be modified or not and replaces many previous IsXXXInstalledCalls(), and traverses the chain of assemblies. Change 4234711 by Ben.Marsh UBT: Runtime dependencies can now be copied to output directories as part of the build. When adding a runtime dependency, an optional source location can be specified to copy from. Both the source and target paths can use variables can be used as part of the path, eg. $(OutputDir), $(ModuleDir), $(PluginDir). Example usage (from a .build.cs file): RuntimeDependencies.Add("$(OutputDir)/Foo.dll", "$(PluginDir)/Source/ThirdParty/Foo.dll", StagedFileType.NonUFS); Change 4234872 by Ben.Marsh Expose a flag for whether the engine is installed, to fix issues generating project files. Change 4234929 by Ben.Marsh Fix null reference generating receipts when UBT makefiles are active. Change 4235883 by Chad.Garyet Merging 4231245 to core Giving Coordinator its own sln. This should fix what 4158155 was supposed to. #jira UE-61955 Change 4236075 by Ben.Marsh CIS fix Change 4237066 by Robert.Manuszewski Fix for a potential crash when terminating the engine while it's being initialized #jira UE-60545 Change 4237078 by Robert.Manuszewski The engine will no longer be resetting all linkers causing massive load times when renaming the world package when entering Play In Editor Change 4237116 by Ben.Marsh Rewrite some Windows utility functions to support paths longer than MAX_PATH. Change 4237158 by Ben.Marsh Add const TCHAR* overloads of FString::RemoveFromStart() and FString::RemoveFromEnd(). Change 4237159 by Ben.Marsh Fix FWindowsPlatformFile::GetFilenameOnDisk() support for paths longer than MAX_PATH, and simplify some of the other long path functions to avoid copying string buffers. Change 4239050 by Ben.Marsh Missing file Change 4239318 by Ben.Marsh Linux CIS fix. Change 4239685 by Ben.Marsh Static analysis CIS fix. Change 4240800 by Ben.Marsh WorkspaceTool: Include the full command line in the log for any P4 commands. Change 4240903 by Ben.Marsh PR #4909: Update copyright notices to 2018 (Contributed by projectgheist) Change 4241025 by Ben.Marsh UBT: Exclude mobile pipeline caches from generated project files. Causes huge slowdown when using 'Find in Files' through the IDE. Change 4241770 by Ben.Marsh UBT: Include action number in parallel executor output. #jira UE-62032 Change 4243469 by Ben.Marsh TBA: Merge FAnnotatedStructuredArchiveFormatter with FStructuredArchiveFormatter. Any functions that are only implemented for text archives now have a _TextOnly suffix, and are exposed through the FStructuredArchive interface. Change 4245723 by Robert.Manuszewski Fixing another creash when terminating the engine while initializing. #jira UE-60545 Change 4245862 by Steve.Robb VectorLoadFloat2(Ptr) added, which loads { Ptr[0], Ptr[1], Ptr[0], Ptr[1] } into a VectorRegister. Change 4246412 by Robert.Manuszewski The warning 'Calling StaticLoadObject during PostLoad may result in hitches during streaming' will now also report the object which had the PostLoad called on it when StaticLoadObject call happened. Change 4246612 by Ben.Marsh UBT: Fix spelling of "Intellisense". Change 4249454 by Robert.Manuszewski Added extra checks to catch scenarios where the EDL Precache Buffer is flushed before a package header is fully read Change 4249513 by Robert.Manuszewski Made sure the Async Loading Thread doesn't continue running after creating new async packages when garbage collector wants to run on the game thread Change 4255207 by Ben.Marsh UGS: Add additional logging whenever a P4 command fails, and when the user is logged out. Change 4255288 by Ben.Marsh PR #4921: Honor ModuleRules' bEnableExceptions flag when creating precompiled h. (Contributed by surakin) Change 4256422 by Ben.Marsh UBT: Add an error if a module referenced by a plugin descriptor doesn't exist. Change 4257385 by Robert.Manuszewski Creating new objects from within ForEachObjectWithOuter will now result in a fatal error as it's unsafe to change internal UObject hash tables when iterating over them. Change 4257454 by Robert.Manuszewski Added the option to filter clusters listed with gc.ListClusters by objects within them. Usage: gc.ListClusters Hierachy With=ObjectName1,ObjectName2... Change 4257526 by Robert.Manuszewski It's now possible to filter clusters that get logged with verbose cluster logging enabled (UE_GCCLUSTER_VERBOSE_LOGGING=1) by objects within them by specifying -DumpClustersWithObjects=ObjectName1,ObjectName2 in the command line Change 4257822 by Ben.Marsh Fixes for PlatformShowcase compile errors. Change 4258771 by Ben.Marsh UBT: Fix project files not being generated for foreign projects when creating .stub files. #jira UE-62462 Change 4258790 by Ben.Marsh UBT: Clean up the logic around generating project files before creating a stub IPA, so that it fails loudly if project files do not exist, and can accept target names not matching project names. Change 4259276 by Ben.Marsh UBT: Make it an error if a framework doesn't exist, rather than failing silently. Also remove some remote toolchain stuff that's no longer necessary. Change 4259280 by Ben.Marsh UBT: Fix embedded framework zips not being uploaded for plugins. #jira UE-62485 Change 4260236 by Ben.Marsh UBT: Fix path to generated engine project file. Change 4260334 by Ben.Marsh UGS: Fix custom build steps dialog inadvertantly modifying config file settings in-place. Change 4260361 by Ben.Marsh UGS: Allow for p4 login commands to fail, even though the user is logged in (due to a bad connection, etc...) Change 4260559 by Ben.Marsh UGS: Update version. Change 4261160 by Robert.Manuszewski MediaPlaylist will now be added to root set if the owning MediaPlayer is in the disregard for GC set (fixes GC assumption violation crash) #jira UE-62495 Change 4261421 by Ben.Marsh Force-sync files for building documentation, to fix issues with files not being updated. #jira UE-62413 Change 4261425 by Ben.Marsh UBT: Remove some leftover functions for handling the remote toolchain. Change 4261530 by Ben.Marsh UBT: Speculative fix (and better error reporting) for IOS mobile provision not being found in CIS. Change 4261611 by Ben.Marsh UBT: Downgrade warning to a log message, since it appears when generating project files. Change 4261710 by Ben.Marsh Remove assert that GLogConsole is set; it won't be for command line utilities that don't depend on ApplicationCore. #jira UE-62545 Change 4261831 by Ben.Marsh Fix compile errors due to missing include path when hot-reloading a module from the editor. There are not necessarily source files to compile when -modulewithsuffix is specified on the command line, which was results in GeneratedCodeWildcard not being set. #jira UE-62463, UE-62384 Change 4262723 by Ben.Marsh Whitelist plugins that need to be loaded by UFE. #jira UE-62564 Change 4265444 by Ben.Marsh Fix incorrect executable name for DebugGame configurations in Xcode. #jira UE-62574 Change 4265892 by Ben.Marsh Fix incremental compile failures due to dependency checking for unity files. CachedIncludePaths was not correctly being set on file items, so dependencies were being ignored. #jira UE-62575, UE-62603, UE-62597 Change 4266019 by Josh.Adams - Fixed the CopyAction for runtime dependencies that need to be copied to different location, on non-XGE Change 4266264 by Ben.Marsh Remove override for the __IPHONE_OS_VERSION_MIN_REQUIRED macro on TVOS. This macro is already defined by system headers (in <AvailabilityInternal.h>). Now that we support PCHs on IOS and TVOS, manually defining this macro results in it being defined three times (once for the PCH, once by AvailabilityInternal.h, and once by the force-included list of definitions for the source file being built). The errors for redefining the macro in AvailabilityInternal.h are suppressed due to it being a system header, but the error for redefining it for the source file being compiled are not. #jira UE-62578 Change 4266273 by Ben.Marsh Fixes incremental build failure when compile arguments for PCH have changed on IOS/TVOS. Compile action needs to have a dependency on PCH build action. Change 4266614 by Graeme.Thornton Fix crash when cooking nativized blueprints due to removal of child cooker system. Change 4266763 by Ben.Marsh Always build UnrealPak when building client targets. The ProjectParams.Pak option is not reliable, because it can be forced on later by the target platform. #jira UE-62584 Change 4267985 by Robert.Manuszewski When iterating with ForEachObjectWithouter, don't lock the entire has table but only the hash bucket that is currently being iterated #jira UE-62600 Change 4268558 by Robert.Manuszewski PurgeLegacyBlueprints will no longer be called from within ForEachObjectWithOuter is it renames objects that reside in hash tables that are being iterated over which may lead to undefined behavior. #jira UE-62600 Change 4269011 by Chad.Garyet - Fixing Wildcard match issue, the change to ugsapi sends projects as //Depot/Stream instead of //Depot/Stream/ Wildcard match was only substringing to 3 chars. - Checking in the change a while back that increases the number of queried jobs up to 432 based on some maths from Bob about how many builds we want to grab Published to ugsapi server 8/8/17 #jira none Change 4270788 by Ben.Marsh Fix IOS provisioning data being using when remote compiling on TVOS. #jira UE-62705 Change 4271916 by Ben.Marsh Tag the XGEControlWorker executable as a build product after compiling SCW, to make sure it's included in the UGS zip file. Change 4271934 by Ben.Marsh Upload all static libraries in plugin folders as part of remote builds. #jira UE-62694 Change 4273368 by Ben.Marsh Fix Slate dependencies not being enumerated, and rules assembly not being rebuilt when building remotely. #jira UE-62705 Change 4274049 by Ben.Marsh Always parse the team UUID out of the mobile provision when doing a remote compile. The provision installed on the remote Mac (and selected for signing) may be different. #jira UE-62751 Change 4274823 by Ben.Marsh Add the -VersionCookedContent argument to disable the -unversioned parameter on the cooker command line. Change 4275838 by Ben.Marsh Fix BuildVersion string not being passed through from <SetVersion> task. Also add a -BuildVersion command line argument to UBT to override it for a particular build. Change 4275913 by Ben.Marsh Add a dummy exported symbol to the XGEController module, to fix build errors due to missing .lib file when it's built with WITH_XGE_CONTROLLER = 0. Change 4284161 by Ben.Marsh Allow mirroring Oodle files to remote Mac. Change 4074774 by Steve.Robb Vast simplification of TFunction, making it smaller in footprint, easier to follow and extend, and more correct. TUniqueFunction added, which is a move-only TFunction which can hold move-only functors. Fix for UWidgetBlueprint::ForEachSourceWidget() which should never have compiled but did. FFunctionGraphTask and TFuture<> updated to use TUniqueFunction to make them more general. TArray::HeapPop() made to work with move-only types. Change 4082591 by Ben.Marsh Move the Log class from UBT to DotNetUtilities. Change 4083236 by Ben.Marsh Add a Log.WriteException() method to dump an exception message to the console (and write the exception trace to the log) Change 4084107 by Ben.Marsh UAT: Remove the unused -SkipHeader argument to UE4Build. Change 4089771 by Steve.Robb GitHub #4743 : modified VirtualAlloc function flag https://blogs.msdn.microsoft.com/oldnewthing/20151008-00/?p=91411 Change 4091456 by Steve.Robb Unification of all platforms' FMath::CountTrailingZeros() and FMath::CountLeadingZeros() for both 32-bit and 64-bit. Change 4156437 by Ben.Marsh Lots and lots of fixes compiling for Clang on Windows. Editor now compiles cleanly without warnings, but crashes on startup due to error in intrinsics test. Disabling that runs further, but crashes accessing freed memory. Switching to the ANSI allocator runs further, but crashes in Slate after the splash screen and before the editor window opens. // TODO! * Switching between Clang/ICL/VS2015/VS2017 is now supported through the same mechanism as switching Visual Studio versions, without requiring any source level changes. To use Clang, set WindowsPlatform.Compiler = WindowsCompiler.Clang from a .target.cs file, or set <WindowsPlatform><Compiler>Clang</Compiler></WindowsPlatform> from BuildConfiguration.xml. To pick a specific toolchain version, set WindowsPlatform.CompilerVersion. * Clang is now supported through AutoSDKs; will be added to CIS. * The Samples/Sandbox/Clang project forces Clang to be used from its target.cs file, and allows easily building all editor modules and plugins with Clang on Windows. * UnrealMathSSE intrinsics have been re-enabled for Clang due to missing functions from the UnrealMathFPU implementation, but causes failure in tests at startup. * SSE4_CRC32() is disabled in D3D12Pipelinestate.cpp, since intrinsics are only allowed if enabled for the whole target (rather than being used in specific functions due to runtime checks) Change 4157389 by Ben.Marsh Few more fixes for compiling the editor with Clang. Change 4183911 by Ben.Marsh Fixes to support incremental linking on Windows. Does not seem to have any net benefit right now; may improve once minimal rebuild is enabled. * Incremental linking no longer forces PDB files to be enabled for source files. * Actions can specify specific files to be deleted before each build. Code to forcibly delete PDB files has been moved to the MSVC toolchain. * Unused libraries produced by the cross-referenced link are no longer added as build products, since (a) deleting them breaks dependency checking for incremental linking and causes a full link, and (b) not deleting them breaks UBT dependency checking and causes actions to be run over and over again. * Icon update is disabled for Windows when incremental linking is enabled. * Removed rarely-used setting to always delete produced items before each build. Change 4184311 by Ben.Marsh UGS: Added a dialog which shows all the required platform SDKs for a branch, linked from the status panel in UGS. The llist is configured via the UGS config file submitted to Engine/Programs/UnrealGameSync/UnrealGameSync.ini (and may be overridden by the project config file if necessary): [Default] ; Set this to a network share which contains the SDK installers for your site SdkInstallerDir= ; All the required SDKs for the current version of the engine +SdkInfo=(Category="Android", Description="NDK r21", Browse="$(SdkInstallerDir)\\Android") +SdkInfo=(Category="Windows", Description="Visual Studio 2017") +SdkInfo=(Category="Windows", Description="Visual C++ Toolchain 14.13.26128") +SdkInfo=(Category="Windows", Description="Windows SDK 10.0.16299.0") Similar entries for console platforms are added in console subdirectories. Each entry may contain an Install="Foo.exe" and/or Browse="C:\Foo" style attribute, specifying the path to an installer to run or directory to open in explorer respectively. The SdkInstallerDir setting is used as a base directory for the default installers, seen above for Android. Licensees may override this with a network path specific to the site that UGS is being deployed to (either in this file, in a project specific config file, or in a Engine/Programs/UnrealGameSync/NotForLicensees/UnrealGameSync.ini file). Change 4200452 by Ben.Marsh UBT: Change DebugGame configurations to output a separate executable rather than requiring a -Debug argument at runtime. Previous behavior was a common source of errors. Engine modules are still shared between Development and DebugGame, but the launch module sets a flag in Core on startup indicating the game configuration. Change 4206189 by Ben.Marsh UBT: Simplify logic for precompiling binaries. * Target no longer has separate list of "precompile only" binaries or modules. New -AllModules option allows adding every module to a target, which can be used with -Precompile and -NoLink to precompile object files for monolithic builds. * Precompiled file lists have been removed from target receipts. * The manifest now includes all generated headers and precompiled files when run with the -Precompile option. * Separate -DependencyList=Foo.txt has been added to write a list of all dependencies required to use precompiled binaries. This file list can be read using the <Tag> task in buildgraph. Change 4215466 by Ben.Marsh UBT: Remove indirect calls to determine extensions for object files and precompiled headers. The toolchain knows the correct convention for the platform. Change 4215975 by Ben.Marsh UBT: Remove telemetry code. This has never proved useful for analyzing performance due to the number of incidental factors that affect build times (eg. number of files being compiled). Change 4220154 by Ben.Marsh Move text-only implementations of FOutputDeviceError back into Core, so we can build command-line applications that don't depend on ApplicationCore. Change 4224708 by Ben.Marsh Add a bCompileAgainstApplicationCore setting to the target rules, which allows compiling out references to the ApplicationCore module (which should only be necessary for applications with a GUI). Removed ApplicationCore from several engine tools and utilities. Change 4224958 by Ben.Marsh Remove CoreMinimal.h includes from Core. Change 4229059 by Ben.Marsh UBT: Remove the UEBuildPlatform.ShouldNotBuildEditor() hook for target platforms. We shouldn't be modifying a target's build environment to disable the editor; it is invalid to build the editor for these target platforms at all, and this is already enforced by the GetSupportedPlatforms() function. Change 4230508 by Ben.Marsh Fixup precompiled header setting for samples and games. Change 4231457 by Ben.Marsh Fix exceptions in log messages having trailing newlines. Change 4232406 by Ben.Marsh UBT: Always force include a PCH for generated code if there's one set; the code may depend on it to compile. Change 4234177 by Ben.Marsh Set up private PCH files everywhere that previously used them. Change 4235973 by Ben.Marsh Change FPlatformMisc::GetEnvironmentVariable() to return an FString() rather than requiring a fixed size buffer to be passed in. Removes references to MAX_PATH. Change 4238842 by Ben.Marsh Add support for paths longer than MAX_PATH in the editor. Requires Windows 10 version 1607, and the functionality to be enabled via a registry key or group policy (see https://docs.microsoft.com/en-us/windows/desktop/FileIO/naming-a-file). Only a subset of Win32 functions support long paths (executables can only be started from paths shorter than MAX_PATH, for example). * Added a FPlatformMisc::GetMaxPathLength() function to return the maximum length of a path on the current system. On Windows, this returns a different value for systems with long paths enabled to those without. * The MAX_PATH define is no longer set by non-Windows platforms. Instead, there is a MAC_MAX_PATH, UNIX_MAX_PATH, etc... for any platform-specific code that still relies on the previous macro. * The MAX_UNREAL_FILENAME_LENGTH macro has been renamed to MAX_UNREAL_FILENAME_LENGTH_DEPRECATED * The PLATFORM_MAX_FILEPATH_LENGTH macro has been renamed to PLATFORM_MAX_FILEPATH_LENGTH_DEPRECATED. * Removed custom resource files for programs, since they are just copies of the base UE4 one (which is used by default anyway). The base UE4 manifest declares support for long paths. * Fix 512 character maximum length on editor commands. 260 character limit remains in place for cooking at the moment (see ContentBrowserUtils.h), until C# staging code supports long paths. Change 4255042 by Ben.Marsh UBT: Remote compilation now uploads the entire workspace to the remote Mac and executes a separate remote instance of UBT rather than synchronizing individual actions. This makes the remote compile codepath much simpler, and removes a lot of special cases that exist to support it previously. The list of files to be transferred to the remote are listed as rsync filter rules in Engine/Build/Rsync/RsyncEngine.txt and RsyncProject.txt, which are applied to the root engine directory and project directory respectively. Projects that need to customize which files are uploaded can add their own <ProjectDir>/Build/Rsync/RsyncProject.txt file, which will be included in the filter before the default version. Change 4260567 by Ben.Marsh UAT: Rename CommandUtils.Log to CommandUtils.LogInformation, to avoid conflicts with the underlying Tools.DotNETCommon.Log class. #rb none [CL 4285673 by Ben Marsh in Main branch]
2018-08-14 18:32:34 -04:00
LogInformation("********** RUN COMMAND STARTED **********");
var LogFolderOutsideOfSandbox = GetLogFolderOutsideOfSandbox();
if (!CommandUtils.IsEngineInstalled() && ServerProcess == null)
{
// In the installed runs, this is the same folder as CmdEnv.LogFolder so delete only in not-installed
DeleteDirectory(LogFolderOutsideOfSandbox);
CreateDirectory(LogFolderOutsideOfSandbox);
}
var ServerLogFile = CombinePaths(LogFolderOutsideOfSandbox, "Server.log");
var ClientLogFile = CombinePaths(LogFolderOutsideOfSandbox, Params.EditorTest ? "Editor.log" : "Client.log");
try
{
RunInternal(Params, ServerLogFile, ClientLogFile);
}
catch
{
throw;
}
finally
{
CopyLogsBackToLogFolder();
}
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 4285612) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3836829 by Ben.Marsh UBT: Fix ability to precompile plugins from installed engine builds. Change 3839519 by Ben.Marsh UBT: Simplify configuring bPrecompile and bUsePrecompile settings for modules. Each rules assembly can now be configured as installed, which defaults the module rules it creates to use precompiled data. Change 4042043 by Steve.Robb GitHub #4705 : Added weak lambda's for delegates and multicast delegates. Change 4042056 by Robert.Manuszewski Optimized Mark Phase of GC by up to 10ms by making it run in parallel and removing a huge array presize which we didn't need. Change 4042104 by Robert.Manuszewski Set the minimum GC cluster size to 5 so that GC doesn't have to process micro clusters which are more expensive than processing individual objects + Exposed the minimum cluster size to ini and project settings as gc.MinGCClusterSize + Added the ability to sort clusters by name/object count/mutable object count/referenced clusters count when dumping them with gc.ListClusters command Change 4042377 by Robert.Manuszewski Reworked how GC and other threads (ALT specifically) interact - GC will now notify the ALT it wants to run and ALT will immediately try to finish its current work to allow that. Also the entire ALT tick is now protected against GC running at the same time to improve ALT stability. + added gc.ForceCollectGarbageEveryFrame console variable that triggers a forced GC every frame Change 4042427 by Robert.Manuszewski Changed FGCCSyncObject to use events when waiting for GC to finish so that it doesn't spin on non-game threads when GC is running Change 4042482 by Robert.Manuszewski Unhashing unreachable objects (ConditionalBeginDestroy) will now also be done incrementally, just like the purge phase of Garbage Collection Change 4042635 by Robert.Manuszewski Fix for a potential assert when incremental purge garbage is pending and something forces a full purge Change 4044092 by Steve.Robb Fix for forward declared CoreUObject weakobject types in delegates when building in Clang. Change 4044102 by Robert.Manuszewski Fix for a possible hang when worker threads are preventing GC from running and something is later trying to FlushAsyncLoading with the Async Loading Thread enabled Change 4044113 by Steve.Robb Another Clang fix. Change 4044160 by Robert.Manuszewski Disregard For GC pool will now be enabled by default in cooked builds Change 4044287 by Steve.Robb Typo fix. Change 4047723 by Graeme.Thornton TBA: Fixes for import/export name cache and object resolving Change 4048015 by Graeme.Thornton TBA: Weak/Soft/Lazy pointer serialization changes * Remove FWeakObjectPtr::Serialize, move it's logic into, and replace usages of with calls to, FArchiveUObject::SerializeWeakObjectPtr(). Ensures that something is always sent to the archive so that structured archives can be kept happy in the future. * Added Weak/Soft/Lazy pointer handling to the structured archive slot interface and all the formatters. Binary formatters just forward the call onto their inner and text archives store as a string path reference. * FArchiveUObjectFromStructuredArchive caches all these pointer types and stores indices in the binary block, same as with a UObject*. All pointers are then forwarded to the underlying formatter in one go on finalization. Change 4048021 by Steve.Robb Fix for binding an unbound TFunction to another TFunction with a different signature. Also all null pointers now count as unbindings, not just nullptr. TIsMemberPointer added. TIsATFunction and TIsATFunctionRef renamed to remove the 'A's. Change 4048544 by Robert.Manuszewski Fixing ConditionalBeginDestroy profiling after changes to incremental CBD. Change 4051028 by Graeme.Thornton TBA: ArchiveFromStructuredArchive adapter uses Inner to determine if it is outputting to text, and sets it's own ArIsTextFormat to false Change 4051056 by Graeme.Thornton TBA: High level tagged property / UObject base class text serialization - UObject serialize converted to structured archive - Properties written to text individually with text tags, and then binary adapted values - Only saves, doesn't load Change 4051111 by Graeme.Thornton TBA: Temporarily disable loading of text assets until tagged property serialization path is fixed up Change 4051154 by Graeme.Thornton TBA: Convert a few uobject serializers to structured archive format for example purposes Change 4051181 by Graeme.Thornton TBA: Added default structured archive implementation of SerializeItem to UProperty, which just calls the FArchive version on an FArchiveUObjectFromStructuredArchive adapter. Implemented structured archive SerializeItem for UArrayProperty Change 4051197 by Graeme.Thornton TBA: ObjectProperty text serialization Change 4051216 by Graeme.Thornton Restored a modified FWeakObjectPtr::Serialize function to keep backwards compatibility in code I don't have access to. Change 4051261 by Graeme.Thornton TBA: Convert UMetaData to structured archive Change 4051374 by Steve.Robb Incorrect assert removed. Change 4051562 by Robert.Manuszewski Adding stats for the new GC internal functions Change 4051614 by Graeme.Thornton TBA: Removed UProperty::SerializeItem(FArchive, ...) and replaced with UProperty::SerializeItem(FStructuredArchive::FSlot, ...). Fixed up most of them to work properly and added adapters in for any that were non-trivial. Change 4052512 by Graeme.Thornton TBA: Temporary workaround for softobjectptr and lazyobjectptr uproperties not serialization anything when they know the archive is a reference collector. They should always be serializing their pointers and letting the underlying archive itself ignore them. Change 4053917 by Robert.Manuszewski Clustered objects from clusters that are no longer reachable will now be marked as unreachable immediately when gathering unreachable objects Change 4053919 by Robert.Manuszewski Added the ability to disable incremental BeginDestroy in ini/project settings Change 4055518 by Daniel.Lamb Fixup for deterministic audio generation issue. Submitted on behalf of Rich.Whitehouse #jira nojira #test prefilght automated test. Change 4056854 by Graeme.Thornton TBA: Added a test asset to EngineTest which contains all the different property types and test cases. Change 4056858 by Graeme.Thornton TBA: Updated USetProperty to proper structured archive usage Change 4056872 by Graeme.Thornton TBA: Add map property field to test object Change 4056873 by Graeme.Thornton TBA: Convert UMapProperty to full structured archive Change 4056994 by Graeme.Thornton TBA: Converted FText over to structured archive. Implemented saving, but not loading. Change 4059728 by Ben.Marsh UBT: Add support for using adaptive non-unity builds when the engine and project are in separate repositories. Change 4059805 by Graeme.Thornton Fixed typo in text serialization. Fixes CIS automation test errors Change 4060007 by Graeme.Thornton TBA: FArchiveFromStructuredArchive will now access it's host slot lazily, i.e. only when a value is actually written to the archive. Change 4060092 by Stefan.Boberg Added optimized Windows console window output path to GenericConsoleOutput since this slowed down cooking considerably (2 minutes spent in wprintf alone for one large dataset) When stdout is attached to a console we use the WriteConsoleW function instead of wprintf since the latter is very slow especially in unbuffered mode which the engine currently configures for stdout (see setvbuf call in LaunchEngineLoop.cpp). At some point we should reconsider this buffering policy since it's likely to slow down other platforms as well but I wanted to do a safe change for now as I don't yet fully understand why the setvbuf call is there in the first place. Change 4060108 by Stefan.Boberg Introduced some additional target platform utilities to help with asset cook optimizations * We now assign each ITargetPlatform a zero-based ordinal value * Introduced FTargetPlatform and FTargetPlatformSet types to help store platform references and platform sets efficiently. These are not currently used in the engine but are designed to replace the existing ITargetPlatform/string/FName representations in the cooking data structures. Change 4060143 by Graeme.Thornton Undo //UE4/Dev-Core/Engine/Source/Runtime/... changelist 4060007 Needs some other changes that I haven't checked in yet... Change 4062432 by Ben.Marsh Fix error message when enumerating P4 changes. Change 4062648 by Ben.Marsh Add missing p4 integration action. Change 4063620 by Graeme.Thornton Integrated a fix from UDN where the engine would crash when trying to load a very small encrypted file (<16bytes) from a pak file, where the read address wasn't already aligned to the AES block size. (https://udn.unrealengine.com/questions/431989/crash-while-reading-a-very-small-file-in-encrypted.html) Change 4066963 by Robert.Manuszewski Fixing GC cluster verification code reporting false positives when a cluster is referencing another cluster through 'mutable' objects list. Change 4067133 by Robert.Manuszewski Changed log verbosity when reporting individual cases of GC cluster assumption violations as they are followed by an asser anyway and this way we get the chance to see all issues before we assert at the end of these checks. Change 4067443 by Steve.Robb FString can now be constructed from any char pointer type and length. Change 4068156 by Steve.Robb Fix necessary because of FString constructor change in CL# 4067443. Change 4070258 by Graeme.Thornton Fixes for VSCode Change 4070372 by Graeme.Thornton TBA: Script struct serialization to structured archives Change 4071913 by Ben.Marsh Move bulk of the code for UnrealPak into an engine developer module, so it can be used in the editor. Change 4071914 by Ben.Marsh Missing files. Change 4071937 by Ben.Marsh Missing header. Change 4072015 by Ben.Marsh Fixes for compiling PakFileUtilities as part of the editor. Change 4072826 by Steve.Robb TBitArray::Reserve() added. TBitArray::Add() overloaded to allow adding multiple bits. TSparseArray::Reserve() optimized to call the overloaded Add(). Change 4073271 by Daniel.Lamb Fixed add patch tier in project launcher passing the wrong commandline option to UAT. #test none Change 4074708 by James.Hopkin #core Removed redundant Casts Change 4074763 by Steve.Robb Fix for TSparseArray::Reserve() size. Change 4076063 by Ben.Marsh Add an "UnrealPak" commandlet with the same functionality as the standalone UnrealPak program. Invoke by running the editor with -run=UnrealPak and the standard UnrealPak commandline options. Change 4077064 by Robert.Manuszewski Fixing compile error in PakFileUtilities Change 4077144 by Graeme.Thornton TBA: TextAssetCommandlet improvements * Collect lists of broken assets during roundtrip tests and print a summary of packages that failed each phase at the end * After resaving as text, load the file back as a plain JSON hierarchy to ensure the output was valid Change 4077412 by Ben.Marsh Set the correct exit code for UnrealPak. Should return 0 on success, not 1. Change 4077760 by Graeme.Thornton TBA: Loading fixed for tagged property serialization Includes conversion of all UProperty::ConvertFromType() and SerializeFromMismatchedTag() functions to use structured archives Lazy initialization of FArchiveFromStructruredArchive when loading, to support the possibility of an adapter being create around an object property serialize call to its inner UStruct, which then decides not to do anything and return false. Stops the ArchiveFromStructuredArchive from consuming the slot and getting upset later on when we try to serialize normal tagged properties from it. Disabled lazy bulk data loading from text assets. Requires a bigger change to make it work. Added some debug checks to json input formatter which track the current value stack size when a new object is pushed onto the stack, and makes sure that the stack has returned to the same size when the object is popped. Catches cases where we unpack an array/stream to the value stack but then don't consume all the items. Change 4078800 by Ben.Marsh Change UAT to using the editor's UnrealPak commandlet rather than invoking the standalone UnrealPak executable. To improve performance when building several PAK files, also add a new -batch=<file> command which reads commands to execute in parallel from a text file. Change 4079745 by Graeme.Thornton TBA: Migrated a couple of UObject Serialize functions to FStructuredArchive (SoundCue / MaterialExpressions / Editor strip flags) Change 4079847 by Graeme.Thornton TBA: Add 'FindMismatchedSerializers' mode to text asset commandlet, which dumps out a list of all UClasses which don't have the CLASS_MatchedSerializers flag, meaning we can't guarantee the have Serialize functions for FArchive AND FStructuredArchive, therefore we can't use the new structured archive based serialize path. Should only ever be native instrinsic classes as UHT takes care of all other cases. Change 4079925 by Ben.Marsh Fix incorrect assignment when deriving name for chunked pak file. Change 4080214 by Ben.Marsh Move the ThreadPoolWorkQueue class into DotNETUtilities so it can be used by other projects. Change 4082394 by Graeme.Thornton CIS fix for variable shadowing warning Change 4082583 by Ben.Marsh Add a IBinarySerializable interface for types that support reading from a BinaryReader and writing to a BinaryWriter. Implementing IBinarySerializable implies a constructor taking a BinaryReader argument is available for deserializing. Change 4082652 by Ben.Marsh Fix FileReference.Directory not returning a directory with a trailing backslash for files in the root directory. Change 4082755 by Graeme.Thornton Fixed an erroneous usage of TUniquePtr<uint8>as a pointer to a uint8 array when creating pak files. Caused a crash when compression was enabled, and has probably surfaced because pak generation is now done by an editor commandlet rather than a standalone program. Change 4082756 by Graeme.Thornton Fixed some incorrect documentation for pakfile compressed chunk headers Change 4082883 by Graeme.Thornton Static analysis warning fix Change 4082912 by Ben.Marsh Move ExceptionUtils into DotNETUtilities. Change 4085291 by Graeme.Thornton TBA: In the Json output formatter, write float and double values out with enough precision for successful roundtripping. Added some debug only code which will immediately reconvert the string back to its original value and compare the the input Change 4085523 by Graeme.Thornton TBA: Remove only explicit usage of DECLARE_FSTRUCTUREDARCHIVE_SERIALIZER. Should only be used from UHT generated code. Change 4086037 by Robert.Manuszewski Fix for a potential race condition when two threads want to acquire GC lock Change 4088655 by Graeme.Thornton Pak creation now uses the bEnablePakSigning setting from the crypto config json file Change 4091474 by Steve.Robb Fix for TStaticBitArray::FindFirstSetBit() and TStaticBitArray::FindFirstClearBit(). Unused variables removed. Change 4093632 by Steve.Robb CIS fixes. Change 4093656 by Graeme.Thornton Build fix Change 4093744 by Ben.Marsh Allow per-chunk settings for whether to enable compression in UnrealPak. Change 4099712 by Gil.Gribb UE4 - Fixed rare case where insufficient space was preallocated for cooldown ticks. #jira UE-59686 Change 4099912 by Stefan.Boberg Cooking timer optimizations: - Replaced data structures for FScopeTimer and FHierarchicalTimerInfo. Previous implementation used FString for many things and caused *lots* of heap and string concatenation activity. Replaced with a compile-time node id (using __COUNTER__) and raw string literals. - Removed PERPACKAGE_TIMER support (was disabled by default and was difficult to test) - Made it possible to toggle OUTPUT_TIMING and ENABLE_COOK_STATS independently - Removed some extremely tight timers because the overhead from calling QPC significantly exceeded the measured code This change shaved some 15% off a clean cook of Fortnite WindowsClient (en) with fully populated local DDC Change 4100519 by Stefan.Boberg Quick fix for Linux build issue introduced in 4099927 Change 4105327 by Stefan.Boberg Cooker: Changed FHierarchicalTimerInfo so it uses a linked list for tracking child nodes, to be able to deal with any child count. Previously we assumed there would never be more than 9 children but it turns out there are cooker modes that need more. Fixes check when using -FullLoadAndSave to cook Change 4105448 by Stefan.Boberg - Fixed Linux build warning re: member initialization order - Also eliminated OUTPUT_HIERARCHYTIMERS/CLEAR_HIEARCHYTIMERS macros (plain functions are fine) - Moved finishing-up code for FullLoadAndSave() to TickCookOnTheSide() call site to improve timer output. Previously some of the scopes would not have been closed before printing and thus the output was misleading. Change 4109031 by Ben.Marsh Attribute-driven Perforce wrapper (old Epic Friday project). Offers a more complete implementation than the current P4 wrapper in UAT without requiring any platform-specific libraries. Uses the Python binary output for parsing. Change 4109588 by Ben.Marsh UBT: Add extension methods for serializing a nullable type to a BinaryReader/BinaryWriter. Change 4109595 by Ben.Marsh Missing project file for DotNETUtilities. Change 4110724 by Stefan.Boberg Removed annotation map locking in UObjectMarks, eliminating around one minute (~3.5%) from Fortnite cook time. The locking was redundant since the annotation maps are managed per thread anyway. Change 4111304 by Ben.Marsh UAT: Add support for setting a status message through the log class. Allows writing transient messages (eg. progress messages) which will be cleared out before writing other messages. Best used through the LogStatusScope class, which can set a status message for the duration of a using() block. As part of this change, the console no longer has to be added as a dedicated trace listener. Since we already special-case this listener when formatting log output, it's easier to just keep the implementation separate to the other trace listeners. Change 4112708 by Steve.Robb Fix for TBitArray::MaxBits in assignment. Change 4114133 by Stefan.Boberg Tweaked how low-level memory (LLM) tracker is implemented to reduce overheads. Previously FMemory functions would acquire the LLM singleton and call OnLowLevelFree/OnLowLevelAlloc etc which would check the bIsDisabled flag and early out if it was set. Due to how frequently these functions were called this ended up costing quite a bit. - This change makes the flag a static member variable instead of a member variable and therefore enables a simpler early-out to be implemented. - The singleton getter is also simplified to avoid hitting the threadsafe singleton construction path on every call. - The enable flag is no longer TAtomic - this also incurs extra overhead for no clear benefit Shaves approximately 3.5% (one minute) off a Fortnite cook test scenario (using -FullLoadAndSave) Change 4115010 by Robert.Manuszewski Fixing CIS Change 4115249 by Robert.Manuszewski Fixing async loading code asserts when exiting game very early due to an error #jira UE-56267 Change 4117091 by Ben.Marsh Prevent doubled-up lines when writing status updates with console log verbosity. Change 4117207 by Ben.Marsh UGS: Do not include executables in diagnostics zip file, and ignore "no such files" error when cleaning workspace. Change 4119175 by Ben.Marsh UGS: Fix crash writing version files when directory does not already exist. Change 4119987 by Ben.Marsh UGS: Show a dialog box while the launcher is updating executables from Perforce, which allows cancelling the operation if necessary. Allow setting the username on the settings window, and prompt for login credentials if necessary. Should prevent situations where users have to update settings from the command prompt. Holding down shift during launch now shows the settings dialog rather than an immediate prompt to launch the unstable version (unstable version is shown as a checkbox on this dialog). Change 4119991 by Ben.Marsh Update version number for UGS launcher to 1.13. Change 4121943 by Robert.Manuszewski Don't use FArchiveAsync2 for reading packages with non-async path in editor builds as its performance is worse than the standard archive's (saves about 1 minute when doing larger cooks and 7 seconds when loading into PIE) Change 4122592 by Steve.Robb GitHub #4762 : Improve wording and grammar of Math comments Also includes improved accuracy in FMath::ComputeBoundingSphereForCone(). Change 4122819 by Stefan.Boberg Don't call CreateDirectory redundantly when opening files for writing using FFileManagerGeneric::CreateFileWriter This change avoids calling IPlatformFile::CreateDirectoryTree if possible since this is a very expensive function especially for deep hierarchies as it performs directory creation from the root directory onwards instead of from the leaf downwards. That function should also be fixed but this change improves performance in the meantime. Change 4122872 by Stefan.Boberg CreateDirectoryTree now creates directories leaf-to-root instead of the other way around. This is much more efficient since we don't spend time on system API calls for directories which already exist. This accounted for a very large amount of CPU time in cooking as the full target file directory hierarchy would be "created" for every single output file. Change 4123109 by Stefan.Boberg - Disable overlapped I/O in editor / cooker. Synchronous I/O reduces the number of syscalls and Windows performs prefetching on our behalf anyway for sequential reads - Eliminated syscall which was issued for every write to update cached file size -- since we're the only writers to the file (file access allows read sharing at most) we can authoritatively update the file size on write completion Change 4123455 by Ben.Marsh PR #4775: New build param PCHMemoryAllocationFactor to set /Zm VS build param. (Contributed by lucaswall) Change 4124207 by Ben.Marsh UBT: Remove some unnecessary indirection for generated code paths. Change 4124217 by Ben.Marsh UBT: Remove another unused variable from UEBuildModuleCPP. Change 4124377 by Stefan.Boberg In IPlatformFile::DeleteDirectoryRecursively, attempt to delete file first and if it fails clear the readonly flag and try again Previously there was a call to clear the readonly flag for every deleted file and this is a waste of resources 99% of the time. The SetFileAttributes call accounted for a significant amount of time during cooker sandbox directory deletion Change 4125071 by Stefan.Boberg Some tweaks to FQueuedThreadPoolBase scheduling and memory management - Explicitly pass in false for TArray::RemoveAt(..., bool bAllowShrinking) argument to prevent memory reallocation when arrays are drained and inevitably repopulated shortly afterwards - Use a MRU strategy instead of LRU when picking a thread to wake up. The MRU thread is the most likely to have a 'hot' cache for the stack etc. Picking from the back of the array also happens to be cheaper since no memory movement is necessary when RemoveAt is called. (This was the strategy in place before CL2600362 which seems to have changed it unintentionally) - Release lock as soon as a thread has been chosen, before asking the worker thread to wake up and do the work Change 4126132 by Ben.Marsh UAT: Detect when stdout is redirected and prevent using backspace characters to move the cursor. Change 4126867 by Graeme.Thornton TBA: Fix tagged binary formatter Change 4127010 by Robert.Manuszewski AnimScriptInstances created at runtime will now also be added to the owning omponent's cluster to avoid GC issues. Change 4127932 by Ben.Marsh WorkspaceTool: Reduce unnecessary logging of status messages when console output is not redirected. Change 4129050 by Ben.Marsh UGS: Check for NET Framework 4.5 being installed before running the installer. Also fix warning trying to kill existing UGS instances before upgrade. Change 4129459 by Graeme.Thornton TBA: TextAssetCommandlet - When outputting converted assets to an output path, replicate the workspace relative path in the output directory Change 4129515 by Graeme.Thornton TBA: Add EnterRecord overload that allows outputting of available field names when loading. Change 4129517 by Graeme.Thornton TBA: Tagged properties are written out as named fields on the "Properties" record, rather than as a stream with a null tag at the end Change 4129518 by Graeme.Thornton TBA: Added a local const bool to allow easy hacking out of text asset loading support Change 4129558 by Graeme.Thornton TBA: Build fix for textasset-less configs Change 4129614 by Ben.Marsh UGS: Main window is now restored to normal size when activated by clicking on the tray icon. #jira UE-60490 Change 4129618 by Ben.Marsh UGS: Speculative fix for unreproduced exception accessing disposed window while shutting down. Change 4131936 by Robert.Manuszewski Removing some WIP code accidentally checked in with CL #4121943 Change 4133490 by Ben.Marsh UGS: Allow the $(Change) variable to be used in more places than just the context menu. #jira UE-60573 Change 4133550 by Ben.Marsh UGS: Setting for whether or not to use incremental builds is now exposed through the variable "$(UseIncrementalBuilds)" for use by custom build steps. #jira UE-60554 Change 4133681 by Ben.Marsh UGS: A per-project list of folders and extensions to be deleted by default when running the 'clean workspace' tool can now be specified through the <ProjectDir>/Build/UnrealGameSync.ini file. Settings may be specified for an individual branch (via a category with the depot path to the project) or for wherever the project is currently open (via the [Default] category). The SafeToDeleteFolders list specifies a substring that will be checked against folder paths. Anything containing this folder will be marked as safe for delete by default. The SafeToDeleteExtensions list specifies a list of extensions for files that can always be deleted. Example: [Default] +SafeToDeleteFolders=/MyGame/Test/ +SafeToDeleteFolders=/DataService/ +SafeToDeleteExtensions=.xx1 +SafeToDeleteExtensions=.xx2 #jira UE-60575 Change 4135449 by Ben.Marsh Fix allowing use of Job objects on Windows platforms (debug code submitted by mistake) Change 4135730 by Ben.Marsh UBT: Plugins can now be enabled and disabled from the .target.cs file (for targets that do not use the shared compile environment), by compiling the list of enabled/disabled plugin names into the Projects module. Change 4135823 by Ben.Marsh UBT: Remove legacy code to handle disabling optional plugins; now that this is compiled into the target, it will work for any plugins we choose. Change 4135945 by Ben.Marsh UBT: Fix error running programs with no explicitly enabled or disabled plugins. Change 4137207 by Ben.Marsh UGS: Align all badges with the same name, to make it easier to see which CIS steps are being run. Allow overriding the slot taken by a particular badge by calling it "SlotName:LabelName". Change 4137311 by Stefan.Boberg Removed child cooker support. In practice it is not a useful feature as it provides no performance improvement (quite the opposite in fact) and adds testing and maintenance complexity. Change 4137393 by Ben.Marsh UGS: Fix display of multiline errors in the status panel. Change 4141708 by Steve.Robb GitHub #3631 : Incorrect default argument in WeakObjectPtrTemplate #jira UE-45490 Change 4146655 by Stefan.Boberg Removed FullGCAssetClasses logic - no longer necessary nor useful Change 4147318 by Ben.Marsh UGS: Compress build badges in a column if it shrinks below the size that they would be visible. Change 4148207 by Ben.Marsh UGS: Added support for showing the latest completed build from a specific list of badges in the status panel. To declare a badge as one that should appear in the status panel rather than the CIS column, add it to the project's UnrealGameSync.ini in the project or [Default] section like so: +ServiceBadges=RoboMerge Change 4148282 by Stefan.Boberg Fixed bug in UCookOnTheFlyServer::GetCookOnTheFlyUnsolicitedFiles - UnsolicitedFiles should be passed by reference not by value Change 4148344 by Stefan.Boberg Fixed minor indentation error (most likely caused by sloppy merge) Change 4148521 by Stefan.Boberg Removed accidentally checked in PRAGMA_DISABLE_OPTIMIZATION from CookOnTheFlyServer.cpp Change 4148639 by Ben.Marsh UGS: Fix tooltips not showing for changes that have description badges. Change 4149373 by Ben.Marsh UGS: Allow adding additional columns to display particular badges by adding entries from the project config file. Example syntax: +Columns=(Name="Desktop",MinWidth=50,DesiredWidth=100,Weight=3,Badges="Editor") +Columns=(Name="Mobile",MinWidth=50,DesiredWidth=100,Weight=3,Badges="IOS,Android") Same form can be used to control how default columns are displayed (though badge settings are ignored). Also allow PerforceMonitor to detect local changes to project config files and update settings automatically. Change 4149399 by Ben.Marsh UGS: Update version to 1.143. Change 4155660 by Steve.Robb PROJECTION and PROJECTION_MEMBER macros which provide the correct behavior when creating projections using functions which are overloaded or use default arguments. Change 4157117 by Ben.Marsh Fix warning due to plugins disabled in .target.cs file. Change 4158011 by Ben.Marsh UBT: Add a check that the UnrealHeaderTool target file exists, rather than throwing an exception when reading it fails. Change 4158646 by Ben.Marsh UGS: Fix exception when login is discovered to have expired during a workspace update. Change 4158678 by Ben.Marsh UGS: Fix an exception on shutdown due to the icon being hidden after it's already been disposed. Change 4158683 by Ben.Marsh UGS: Add an unhandled exception filter which sends the exception data to the backend. Change 4159131 by Ben.Marsh UGS: Reduce the number of characters displayed for build badges based on the available space. Change 4159194 by Graeme.Thornton TBA: Fix incorrect map property conversion code when converting an old property that contains a map with different key/value types Change 4159239 by Steve.Robb Improved readability and compliance with coding standards. Change 4159246 by Ben.Marsh UGS: Allow syncing projects where source code is not available (and various version files don't exist). #jira UE-60985 Change 4159286 by Ben.Marsh UGS: Remove requirement for UE4Editor.target.cs to be visible in the depot in order to open a project. #jira UE-60986 Change 4159302 by Ben.Marsh UGS: Update version to 1.144. Change 4160308 by Ben.Marsh All staging client executables for blueprint projects. #jira UE-60983 Change 4161567 by Steve.Robb GitHub #4816 : UE-60771: Handle escaped double quote in FParse::LineExtended Change 4162641 by Ben.Marsh UGS: Allow customizing the position of custom columns, via the Index=N attribute. Change 4162647 by Ben.Marsh UGS: Update version to 1.145. Change 4165319 by Robert.Manuszewski PR #4812: Fix inconsistent command-line argument handling under Windows (Contributed by adamrehn) Change 4166150 by Ben.Marsh UGS: Include *.inl when looking for code changes. Change 4166551 by Steve.Robb Whitespace fixes caused by a bad merge. Change 4168483 by Ben.Marsh UGS: Add a more useful error if a file to be synced exceeds the max allowed path length. Change 4168490 by Ben.Marsh UGS: Update version to 1.146. Change 4168551 by Ben.Marsh UBT: Move bBuildLargeAddressAwareBinary into an exposed setting. Change 4168560 by Ben.Marsh UBT: Remove static config variable for controlling which configuration of UHT to use. Change 4171296 by Ben.Marsh UGS: Move the check for overlong paths earlier. Change 4171531 by Ben.Marsh UBT: Fix exception if BuildConfiguration.xml contains an unknown category. Change 4183371 by Robert.Manuszewski Fix for a crash in Async Loading Graph's CheckCycles when GC kicks in on the game thread and forces ALT to exit early Change 4184312 by Ben.Marsh UGS: Update version to 1.148 Change 4184480 by Robert.Manuszewski Removing unused async loading stat Change 4186390 by Ben.Marsh UBT: Format XML validation errors in a format that allows double-clicking on the message in Visual Studio. Change 4188644 by Ben.Marsh UBT: Add the MakePathSafeToUseWithCommandLine() function to UBT. Change 4188647 by Ben.Marsh UBT: Fix exception in target receipt when architecture is null. Change 4189617 by Ben.Marsh Change FileSystemReference, FileReference and DirectoryReference objects to use OrdinalIgnoreCase comparisons without creating a separate copy of the string to compare. The filesystem does not use the invariant culture, and it can produce the wrong results in some cases (the ordinal comparison is faster, too). Change 4189740 by Ben.Marsh UAT: Remote code to build UnrealPak when packaging; we use the editor now. Change 4189860 by Ben.Marsh UGS: Make the filter for excluding automated lighting rebuilds more explicit. Change 4190082 by Ben.Marsh Fixes to allow enabling edit and continue for Windows builds. Have experienced quite a few VS crashes when testing it in editor; not yet recommended for general use. - Allow edit and continue for any configuration, not just debug. - Fixed PDB errors compiling files that use a shared PCH with edit and continue enabled. Path to the generated PDB file was using the wrong directory. - Removed code that tracks PDB output files, since they're modified multiple times during a build. - Enable debug information when compiling generated CPP files, since it causes errors if the shared PCH PDB doesn't have the same option. - Disable support for remote execution of steps that modify the PDB, since the same file has to be modified many times. Remote execution causes the PDB files to be corrupted. Unfortunately, this makes E&C builds significantly slower. #jira Change 4192949 by Ben.Marsh UBT: Minor tidy-up (merging UEBuildBinary.Build and UEBuildBinary.SetupOutputFiles) Change 4193218 by Ben.Marsh Fix formatting. Change 4197252 by Mike.Erwin UAT: Fix log output w/ correct count of non-code projects. #jira none Change 4197941 by Ben.Marsh UGS: Add support for DebugGame editors that have an executable with a DebugGame suffix. Change 4197964 by Ben.Marsh UGS: Prevent attempts to automatically reopen projects while a modal dialog is up, or the workspace is syncing. Change 4198144 by Ben.Marsh UGS: Prevent modal dialogs when login expires in P4, and prompt for password when hitting "retry". Change 4198413 by Ben.Marsh UGS: Always show the main window when launched manually, and run with -RestoreState when launched at startup. Also add a couple more places that save the visibility state, since logging off seems like it can terminate the process abrubtly. Change 4198779 by Ben.Marsh UBT: Allow generating manifests to any arbitrary locations with the -Manifest=<Path> argument. Change 4198825 by Ben.Marsh UBT: Move code to enumerate Slate runtime dependencies into the Slate module. Doesn't need to be done inside core UBT. Change 4199341 by Ben.Marsh UGS: Update version to 1.149 Change 4199642 by Chad.Garyet - Deprecate CISController - Add BuildController to replace CIS GET/POST for builds - Add LatestController, GET does what CIS/GET used to do - Change Latest/GET to return the last 25 builds filtered by project, rather than the last 5000 individual Ids - Latest/GET now returns "LatestData" object instead of array of longs - Updated EventMonitor to match all API changes - Fixed bug where IDs were getting reset to initial startup values every update loop Change 4199663 by Chad.Garyet CIS controller still needs to return an array of longs #jira none Change 4199680 by Ben.Marsh UGS: Update version to 1.150 Change 4200457 by Ben.Marsh Merging CIS fix for non-development configurations. Change 4200472 by Mike.Erwin UAT: fix -skipbuildclient param default It was defaulting to skipbuildeditor's value, likely a copy-paste error. #jira none Change 4202595 by Ben.Marsh Fix static analysis warning due to constant comparison against macro. Change 4203250 by Ben.Marsh UGS: Always show the "Sync Precompiled Editor" option, but disable it and show a tooltip explaining why if it is not available. Change 4206191 by Ben.Marsh Exclude editor target files from installed builds, since they leak info about DLLs that have been stripped out. Change 4213011 by Ben.Marsh UBT: Include contents of modified intermediate files in the log, to make it easier to debug hidden dependencies. Change 4213487 by Ben.Marsh UBT: Fix assumption that bPrecompile is equivalent to bBuildAllModules. This is no longer the case; they are now controlled by separate options. Should fix CIS errors building the editor. Change 4213609 by Ben.Marsh Ensure that strings formatted using FMicrosoftPlatformString::GetVarArgs() are always null terminated, whether we use the secure CRT or not. Change 4215971 by Ben.Marsh UBT: Remove action graph visualization code; no longer used. Change 4215996 by Ben.Marsh UBT: Remove unqiue id from all actions in the action graph. This is only used for printing debug info in the case of a (rare) cycle in the action graph, so just look it up when needed. Change 4216022 by Ben.Marsh UBT: Rename Crypto.cs to EncryptionAndSigning.cs to match the name of the class inside it, and move it under the System folder. Change 4216031 by Ben.Marsh UBT: Move all the action executors into their own folder in the project. Change 4216526 by Ben.Marsh Fix CIS warnings. Change 4216544 by Ben.Marsh Replace custom code to ensure FMicrosoftPlatformString::GetVarArgs() null terminates its buffer with Microsoft's standards-compliant implementation. Change 4216633 by Ben.Marsh Add support for UnrealPak plugins. * Project and plugin modules can now specify an array of supported programs in the "WhitelistPrograms" field of their module descriptors, to allow modules to be loaded by programs. * Programs can now load any runtime modules, as long as they are whitelisted. * Programs under the engine directory can now use a shared build environment, so that building with a project file does not cause output binaries to be output to the project directory. * UnrealPak is now always built by default when packaging * Convert UnrealPak to a modular configuration Change 4216736 by Ben.Marsh UnrealPak: Move "ExportDependencies" command into an editor commandlet, since it relies on the UObject system, asset registry, etc... Change 4217447 by Ben.Marsh Back out revision 50 from //UE4/Dev-Core/Engine/Build/InstalledEngineBuild.xml Change 4217451 by Ben.Marsh Back out revision 11 from //UE4/Dev-Core/Engine/Plugins/Developer/VisualStudioSourceCodeAccess/Source/VisualStudioSourceCodeAccess/VisualStudioSourceCodeAccess.Build.cs Change 4217617 by Ben.Marsh Back out changelist 4217451 Change 4222552 by Ben.Marsh Don't use #import <TypeLib> for VS source code accessor when building with Clang; it's not supported. Change 4222630 by Ben.Marsh UBT: Fix spam while generating project files if Clang isn't installed. Change 4223316 by Ben.Marsh UBT: Change the order in which Visual C++ toolchains are enumerated to prefer full releases over preview releases. Change 4223318 by Ben.Marsh UBT: Add a build setting which allows creating a dedicated PCH for every file that's excluded from the unity working set (disabled by default). Improves iteration times when working on individual cpp files, but slows down iterating on header changes (and can take a lot of disk space for large changes). Dedicated PCH contains all includes scraped from the top of each cpp file, until a non-#include directive is encountered. Change 4223401 by Ben.Marsh UBT: Add an option to automatically enable edit and continue for files in the adaptive non-unity working set. E&C doesn't seem very useful for UE4 projects right now; compile time is comparable to regular build times, but it can take several minutes to apply code changes for large projects. Change 4223899 by Ben.Marsh UBT: Fix loading XML config files on Mono; Type.GetField(Name) does not seem to return values unless binding flags are specified. Change 4224637 by Ben.Marsh Add a "SupportedPrograms" field to plugin descriptors, which allows plugins to declare which plugins they support independently of individual modules. Programs now respect the "bEnabledByDefault" setting in plugins. Plugins that are compatible with a program now need to list that program in the SupportedPrograms list, and whitelist any modules that should load for that program. Change 4224710 by Ben.Marsh UBT: Don't add import libraries as final build products unless the target is being precompiled. Prevents the need for building them for leaf nodes in the action graph. Change 4224715 by Ben.Marsh UBT: Remove hack to allow Stats2.cpp to not follow IWYU convention. Change 4224726 by Ben.Marsh Remove commented out line. Change 4224903 by Ben.Marsh Fix non-unity compile error in Stats2.h. Change 4225051 by Ben.Marsh Back out changelist 4224710; causing CIS errors due to receipts not matching. Change 4225134 by Ben.Marsh Fixing non-unity errors. Change 4225203 by Ben.Marsh Another non-unity fix. Change 4225249 by Ben.Marsh Fix Linux dependencies being copied for the Windows editor; they can be added as requirements for the Linux target platform on Windows instead, so it respects the user's chosen platforms. #jira UE-62001 Change 4225512 by Ben.Marsh BuildGraph: Allow setting the target to build when using the <CsCompile> task. Change 4228815 by Ben.Marsh UBT: Always add the generated code directory to the list of include paths when generating project files. It may only be created after UHT has been run. Change 4228944 by Ben.Marsh UBT: Remove legacy CppCompileEnvironment and LinkEnvironment wrappers from TargetRules that were deprecated in 4.19. Change 4229028 by Ben.Marsh UBT: Fix editor targets with unique build environment having the wrong executable path in generated project files. Move move logic to configure target rules post-construction by the rules assembly to ensure it's valid. Change 4229065 by Ben.Marsh UBT: Move another target setting into the rules assembly. Change 4229105 by Ben.Marsh Fix BPT exception when generating project files. Change 4229311 by Ben.Marsh UBT: Store the module rules file location on the ModuleRules instance, as well as the plugin that it was created from. Also expose the plugin directory as a property on the ModuleRules instance. Change 4229421 by Ben.Marsh UBT: Consolidate functionality for UHT module setup in ExternalExecution.cs. Change 4229817 by Ben.Marsh UBT: Modules must now explicitly specify the path to the header used to generate a PCH if one is desired, rather than the header being determined automatically by attempting to parse the source code. Now that PCHs are force-included anyway, this removes a lot of dependencies inside UBT. Change 4229824 by Ben.Marsh UBT: Remove unused lists inside UEBuildModuleCPP.SourceFilesClass. Change 4229841 by Ben.Marsh UBT: Remove some legacy code from auto-detecting PCHs. Change 4230521 by Ben.Marsh UBT: Add utility functions to the log class to allow formatting errors and warnings in Visual Studio output format (eg. File(Line): warning: Message) Change 4230871 by Ben.Marsh UAT: Remove StreamUtilis utility class; there is a simpler way to implement the one place it's used. Change 4230882 by Ben.Marsh UAT: Add StreamUtils back into UAT, seems like it's still used there. Change 4230896 by Ben.Marsh UBT: Remove some redundant parameters from UEBuildModule/UEBuildModuleCPP/UEBuildModuleExternal constructors. Change 4231014 by Ben.Marsh WorkspaceTool: Include a dump of raw bytes when garbage is read from the P4 process, for diagnostic purposes. Change 4231032 by Ben.Marsh Fix CIS. Change 4231096 by Ben.Marsh Bump the FlatCPPIncludeDependencyCache version, to prevent errors trying to load old files. Change 4231446 by Ben.Marsh UBT: Added support for expanding UE-specific variables in include paths and library paths: $(EngineDir), $(ProjectDir), $(PluginDir), $(ModuleDir). Change 4231460 by Ben.Marsh Modules may now explicitly specify rpaths on Linux via the PublicRuntimeLibraryPaths and PrivateRuntimeLibraryPaths properties. Change 4233909 by Robert.Manuszewski PR #4779: Reason fails as the supplied variable is incorrect (Contributed by projectgheist) Change 4233910 by Ben.Marsh Enable PCHs on IOS. Reduces build time by ~25%. Change 4234176 by Ben.Marsh UBT: Add better messaging for modules that need to have a private PCH set. Now detects the likely PCH using the same method as legacy code and includes it as a suggestion. Change 4234193 by Ben.Marsh Add the Delete command to Perforce wrapper in DotNETUtilities. Change 4234688 by Ben.Marsh UBT: Simplify handling of installed/precompiled builds. Settings for whether a folder is installed/read-only or not is now stored on the RulesAssembly instance, allowing multiple things to be configured separately and stacked together (eg. engine/enterprise/project). RulesAssembly.IsReadOnly() allows determining if a flie can be modified or not and replaces many previous IsXXXInstalledCalls(), and traverses the chain of assemblies. Change 4234711 by Ben.Marsh UBT: Runtime dependencies can now be copied to output directories as part of the build. When adding a runtime dependency, an optional source location can be specified to copy from. Both the source and target paths can use variables can be used as part of the path, eg. $(OutputDir), $(ModuleDir), $(PluginDir). Example usage (from a .build.cs file): RuntimeDependencies.Add("$(OutputDir)/Foo.dll", "$(PluginDir)/Source/ThirdParty/Foo.dll", StagedFileType.NonUFS); Change 4234872 by Ben.Marsh Expose a flag for whether the engine is installed, to fix issues generating project files. Change 4234929 by Ben.Marsh Fix null reference generating receipts when UBT makefiles are active. Change 4235883 by Chad.Garyet Merging 4231245 to core Giving Coordinator its own sln. This should fix what 4158155 was supposed to. #jira UE-61955 Change 4236075 by Ben.Marsh CIS fix Change 4237066 by Robert.Manuszewski Fix for a potential crash when terminating the engine while it's being initialized #jira UE-60545 Change 4237078 by Robert.Manuszewski The engine will no longer be resetting all linkers causing massive load times when renaming the world package when entering Play In Editor Change 4237116 by Ben.Marsh Rewrite some Windows utility functions to support paths longer than MAX_PATH. Change 4237158 by Ben.Marsh Add const TCHAR* overloads of FString::RemoveFromStart() and FString::RemoveFromEnd(). Change 4237159 by Ben.Marsh Fix FWindowsPlatformFile::GetFilenameOnDisk() support for paths longer than MAX_PATH, and simplify some of the other long path functions to avoid copying string buffers. Change 4239050 by Ben.Marsh Missing file Change 4239318 by Ben.Marsh Linux CIS fix. Change 4239685 by Ben.Marsh Static analysis CIS fix. Change 4240800 by Ben.Marsh WorkspaceTool: Include the full command line in the log for any P4 commands. Change 4240903 by Ben.Marsh PR #4909: Update copyright notices to 2018 (Contributed by projectgheist) Change 4241025 by Ben.Marsh UBT: Exclude mobile pipeline caches from generated project files. Causes huge slowdown when using 'Find in Files' through the IDE. Change 4241770 by Ben.Marsh UBT: Include action number in parallel executor output. #jira UE-62032 Change 4243469 by Ben.Marsh TBA: Merge FAnnotatedStructuredArchiveFormatter with FStructuredArchiveFormatter. Any functions that are only implemented for text archives now have a _TextOnly suffix, and are exposed through the FStructuredArchive interface. Change 4245723 by Robert.Manuszewski Fixing another creash when terminating the engine while initializing. #jira UE-60545 Change 4245862 by Steve.Robb VectorLoadFloat2(Ptr) added, which loads { Ptr[0], Ptr[1], Ptr[0], Ptr[1] } into a VectorRegister. Change 4246412 by Robert.Manuszewski The warning 'Calling StaticLoadObject during PostLoad may result in hitches during streaming' will now also report the object which had the PostLoad called on it when StaticLoadObject call happened. Change 4246612 by Ben.Marsh UBT: Fix spelling of "Intellisense". Change 4249454 by Robert.Manuszewski Added extra checks to catch scenarios where the EDL Precache Buffer is flushed before a package header is fully read Change 4249513 by Robert.Manuszewski Made sure the Async Loading Thread doesn't continue running after creating new async packages when garbage collector wants to run on the game thread Change 4255207 by Ben.Marsh UGS: Add additional logging whenever a P4 command fails, and when the user is logged out. Change 4255288 by Ben.Marsh PR #4921: Honor ModuleRules' bEnableExceptions flag when creating precompiled h. (Contributed by surakin) Change 4256422 by Ben.Marsh UBT: Add an error if a module referenced by a plugin descriptor doesn't exist. Change 4257385 by Robert.Manuszewski Creating new objects from within ForEachObjectWithOuter will now result in a fatal error as it's unsafe to change internal UObject hash tables when iterating over them. Change 4257454 by Robert.Manuszewski Added the option to filter clusters listed with gc.ListClusters by objects within them. Usage: gc.ListClusters Hierachy With=ObjectName1,ObjectName2... Change 4257526 by Robert.Manuszewski It's now possible to filter clusters that get logged with verbose cluster logging enabled (UE_GCCLUSTER_VERBOSE_LOGGING=1) by objects within them by specifying -DumpClustersWithObjects=ObjectName1,ObjectName2 in the command line Change 4257822 by Ben.Marsh Fixes for PlatformShowcase compile errors. Change 4258771 by Ben.Marsh UBT: Fix project files not being generated for foreign projects when creating .stub files. #jira UE-62462 Change 4258790 by Ben.Marsh UBT: Clean up the logic around generating project files before creating a stub IPA, so that it fails loudly if project files do not exist, and can accept target names not matching project names. Change 4259276 by Ben.Marsh UBT: Make it an error if a framework doesn't exist, rather than failing silently. Also remove some remote toolchain stuff that's no longer necessary. Change 4259280 by Ben.Marsh UBT: Fix embedded framework zips not being uploaded for plugins. #jira UE-62485 Change 4260236 by Ben.Marsh UBT: Fix path to generated engine project file. Change 4260334 by Ben.Marsh UGS: Fix custom build steps dialog inadvertantly modifying config file settings in-place. Change 4260361 by Ben.Marsh UGS: Allow for p4 login commands to fail, even though the user is logged in (due to a bad connection, etc...) Change 4260559 by Ben.Marsh UGS: Update version. Change 4261160 by Robert.Manuszewski MediaPlaylist will now be added to root set if the owning MediaPlayer is in the disregard for GC set (fixes GC assumption violation crash) #jira UE-62495 Change 4261421 by Ben.Marsh Force-sync files for building documentation, to fix issues with files not being updated. #jira UE-62413 Change 4261425 by Ben.Marsh UBT: Remove some leftover functions for handling the remote toolchain. Change 4261530 by Ben.Marsh UBT: Speculative fix (and better error reporting) for IOS mobile provision not being found in CIS. Change 4261611 by Ben.Marsh UBT: Downgrade warning to a log message, since it appears when generating project files. Change 4261710 by Ben.Marsh Remove assert that GLogConsole is set; it won't be for command line utilities that don't depend on ApplicationCore. #jira UE-62545 Change 4261831 by Ben.Marsh Fix compile errors due to missing include path when hot-reloading a module from the editor. There are not necessarily source files to compile when -modulewithsuffix is specified on the command line, which was results in GeneratedCodeWildcard not being set. #jira UE-62463, UE-62384 Change 4262723 by Ben.Marsh Whitelist plugins that need to be loaded by UFE. #jira UE-62564 Change 4265444 by Ben.Marsh Fix incorrect executable name for DebugGame configurations in Xcode. #jira UE-62574 Change 4265892 by Ben.Marsh Fix incremental compile failures due to dependency checking for unity files. CachedIncludePaths was not correctly being set on file items, so dependencies were being ignored. #jira UE-62575, UE-62603, UE-62597 Change 4266019 by Josh.Adams - Fixed the CopyAction for runtime dependencies that need to be copied to different location, on non-XGE Change 4266264 by Ben.Marsh Remove override for the __IPHONE_OS_VERSION_MIN_REQUIRED macro on TVOS. This macro is already defined by system headers (in <AvailabilityInternal.h>). Now that we support PCHs on IOS and TVOS, manually defining this macro results in it being defined three times (once for the PCH, once by AvailabilityInternal.h, and once by the force-included list of definitions for the source file being built). The errors for redefining the macro in AvailabilityInternal.h are suppressed due to it being a system header, but the error for redefining it for the source file being compiled are not. #jira UE-62578 Change 4266273 by Ben.Marsh Fixes incremental build failure when compile arguments for PCH have changed on IOS/TVOS. Compile action needs to have a dependency on PCH build action. Change 4266614 by Graeme.Thornton Fix crash when cooking nativized blueprints due to removal of child cooker system. Change 4266763 by Ben.Marsh Always build UnrealPak when building client targets. The ProjectParams.Pak option is not reliable, because it can be forced on later by the target platform. #jira UE-62584 Change 4267985 by Robert.Manuszewski When iterating with ForEachObjectWithouter, don't lock the entire has table but only the hash bucket that is currently being iterated #jira UE-62600 Change 4268558 by Robert.Manuszewski PurgeLegacyBlueprints will no longer be called from within ForEachObjectWithOuter is it renames objects that reside in hash tables that are being iterated over which may lead to undefined behavior. #jira UE-62600 Change 4269011 by Chad.Garyet - Fixing Wildcard match issue, the change to ugsapi sends projects as //Depot/Stream instead of //Depot/Stream/ Wildcard match was only substringing to 3 chars. - Checking in the change a while back that increases the number of queried jobs up to 432 based on some maths from Bob about how many builds we want to grab Published to ugsapi server 8/8/17 #jira none Change 4270788 by Ben.Marsh Fix IOS provisioning data being using when remote compiling on TVOS. #jira UE-62705 Change 4271916 by Ben.Marsh Tag the XGEControlWorker executable as a build product after compiling SCW, to make sure it's included in the UGS zip file. Change 4271934 by Ben.Marsh Upload all static libraries in plugin folders as part of remote builds. #jira UE-62694 Change 4273368 by Ben.Marsh Fix Slate dependencies not being enumerated, and rules assembly not being rebuilt when building remotely. #jira UE-62705 Change 4274049 by Ben.Marsh Always parse the team UUID out of the mobile provision when doing a remote compile. The provision installed on the remote Mac (and selected for signing) may be different. #jira UE-62751 Change 4274823 by Ben.Marsh Add the -VersionCookedContent argument to disable the -unversioned parameter on the cooker command line. Change 4275838 by Ben.Marsh Fix BuildVersion string not being passed through from <SetVersion> task. Also add a -BuildVersion command line argument to UBT to override it for a particular build. Change 4275913 by Ben.Marsh Add a dummy exported symbol to the XGEController module, to fix build errors due to missing .lib file when it's built with WITH_XGE_CONTROLLER = 0. Change 4284161 by Ben.Marsh Allow mirroring Oodle files to remote Mac. Change 4074774 by Steve.Robb Vast simplification of TFunction, making it smaller in footprint, easier to follow and extend, and more correct. TUniqueFunction added, which is a move-only TFunction which can hold move-only functors. Fix for UWidgetBlueprint::ForEachSourceWidget() which should never have compiled but did. FFunctionGraphTask and TFuture<> updated to use TUniqueFunction to make them more general. TArray::HeapPop() made to work with move-only types. Change 4082591 by Ben.Marsh Move the Log class from UBT to DotNetUtilities. Change 4083236 by Ben.Marsh Add a Log.WriteException() method to dump an exception message to the console (and write the exception trace to the log) Change 4084107 by Ben.Marsh UAT: Remove the unused -SkipHeader argument to UE4Build. Change 4089771 by Steve.Robb GitHub #4743 : modified VirtualAlloc function flag https://blogs.msdn.microsoft.com/oldnewthing/20151008-00/?p=91411 Change 4091456 by Steve.Robb Unification of all platforms' FMath::CountTrailingZeros() and FMath::CountLeadingZeros() for both 32-bit and 64-bit. Change 4156437 by Ben.Marsh Lots and lots of fixes compiling for Clang on Windows. Editor now compiles cleanly without warnings, but crashes on startup due to error in intrinsics test. Disabling that runs further, but crashes accessing freed memory. Switching to the ANSI allocator runs further, but crashes in Slate after the splash screen and before the editor window opens. // TODO! * Switching between Clang/ICL/VS2015/VS2017 is now supported through the same mechanism as switching Visual Studio versions, without requiring any source level changes. To use Clang, set WindowsPlatform.Compiler = WindowsCompiler.Clang from a .target.cs file, or set <WindowsPlatform><Compiler>Clang</Compiler></WindowsPlatform> from BuildConfiguration.xml. To pick a specific toolchain version, set WindowsPlatform.CompilerVersion. * Clang is now supported through AutoSDKs; will be added to CIS. * The Samples/Sandbox/Clang project forces Clang to be used from its target.cs file, and allows easily building all editor modules and plugins with Clang on Windows. * UnrealMathSSE intrinsics have been re-enabled for Clang due to missing functions from the UnrealMathFPU implementation, but causes failure in tests at startup. * SSE4_CRC32() is disabled in D3D12Pipelinestate.cpp, since intrinsics are only allowed if enabled for the whole target (rather than being used in specific functions due to runtime checks) Change 4157389 by Ben.Marsh Few more fixes for compiling the editor with Clang. Change 4183911 by Ben.Marsh Fixes to support incremental linking on Windows. Does not seem to have any net benefit right now; may improve once minimal rebuild is enabled. * Incremental linking no longer forces PDB files to be enabled for source files. * Actions can specify specific files to be deleted before each build. Code to forcibly delete PDB files has been moved to the MSVC toolchain. * Unused libraries produced by the cross-referenced link are no longer added as build products, since (a) deleting them breaks dependency checking for incremental linking and causes a full link, and (b) not deleting them breaks UBT dependency checking and causes actions to be run over and over again. * Icon update is disabled for Windows when incremental linking is enabled. * Removed rarely-used setting to always delete produced items before each build. Change 4184311 by Ben.Marsh UGS: Added a dialog which shows all the required platform SDKs for a branch, linked from the status panel in UGS. The llist is configured via the UGS config file submitted to Engine/Programs/UnrealGameSync/UnrealGameSync.ini (and may be overridden by the project config file if necessary): [Default] ; Set this to a network share which contains the SDK installers for your site SdkInstallerDir= ; All the required SDKs for the current version of the engine +SdkInfo=(Category="Android", Description="NDK r21", Browse="$(SdkInstallerDir)\\Android") +SdkInfo=(Category="Windows", Description="Visual Studio 2017") +SdkInfo=(Category="Windows", Description="Visual C++ Toolchain 14.13.26128") +SdkInfo=(Category="Windows", Description="Windows SDK 10.0.16299.0") Similar entries for console platforms are added in console subdirectories. Each entry may contain an Install="Foo.exe" and/or Browse="C:\Foo" style attribute, specifying the path to an installer to run or directory to open in explorer respectively. The SdkInstallerDir setting is used as a base directory for the default installers, seen above for Android. Licensees may override this with a network path specific to the site that UGS is being deployed to (either in this file, in a project specific config file, or in a Engine/Programs/UnrealGameSync/NotForLicensees/UnrealGameSync.ini file). Change 4200452 by Ben.Marsh UBT: Change DebugGame configurations to output a separate executable rather than requiring a -Debug argument at runtime. Previous behavior was a common source of errors. Engine modules are still shared between Development and DebugGame, but the launch module sets a flag in Core on startup indicating the game configuration. Change 4206189 by Ben.Marsh UBT: Simplify logic for precompiling binaries. * Target no longer has separate list of "precompile only" binaries or modules. New -AllModules option allows adding every module to a target, which can be used with -Precompile and -NoLink to precompile object files for monolithic builds. * Precompiled file lists have been removed from target receipts. * The manifest now includes all generated headers and precompiled files when run with the -Precompile option. * Separate -DependencyList=Foo.txt has been added to write a list of all dependencies required to use precompiled binaries. This file list can be read using the <Tag> task in buildgraph. Change 4215466 by Ben.Marsh UBT: Remove indirect calls to determine extensions for object files and precompiled headers. The toolchain knows the correct convention for the platform. Change 4215975 by Ben.Marsh UBT: Remove telemetry code. This has never proved useful for analyzing performance due to the number of incidental factors that affect build times (eg. number of files being compiled). Change 4220154 by Ben.Marsh Move text-only implementations of FOutputDeviceError back into Core, so we can build command-line applications that don't depend on ApplicationCore. Change 4224708 by Ben.Marsh Add a bCompileAgainstApplicationCore setting to the target rules, which allows compiling out references to the ApplicationCore module (which should only be necessary for applications with a GUI). Removed ApplicationCore from several engine tools and utilities. Change 4224958 by Ben.Marsh Remove CoreMinimal.h includes from Core. Change 4229059 by Ben.Marsh UBT: Remove the UEBuildPlatform.ShouldNotBuildEditor() hook for target platforms. We shouldn't be modifying a target's build environment to disable the editor; it is invalid to build the editor for these target platforms at all, and this is already enforced by the GetSupportedPlatforms() function. Change 4230508 by Ben.Marsh Fixup precompiled header setting for samples and games. Change 4231457 by Ben.Marsh Fix exceptions in log messages having trailing newlines. Change 4232406 by Ben.Marsh UBT: Always force include a PCH for generated code if there's one set; the code may depend on it to compile. Change 4234177 by Ben.Marsh Set up private PCH files everywhere that previously used them. Change 4235973 by Ben.Marsh Change FPlatformMisc::GetEnvironmentVariable() to return an FString() rather than requiring a fixed size buffer to be passed in. Removes references to MAX_PATH. Change 4238842 by Ben.Marsh Add support for paths longer than MAX_PATH in the editor. Requires Windows 10 version 1607, and the functionality to be enabled via a registry key or group policy (see https://docs.microsoft.com/en-us/windows/desktop/FileIO/naming-a-file). Only a subset of Win32 functions support long paths (executables can only be started from paths shorter than MAX_PATH, for example). * Added a FPlatformMisc::GetMaxPathLength() function to return the maximum length of a path on the current system. On Windows, this returns a different value for systems with long paths enabled to those without. * The MAX_PATH define is no longer set by non-Windows platforms. Instead, there is a MAC_MAX_PATH, UNIX_MAX_PATH, etc... for any platform-specific code that still relies on the previous macro. * The MAX_UNREAL_FILENAME_LENGTH macro has been renamed to MAX_UNREAL_FILENAME_LENGTH_DEPRECATED * The PLATFORM_MAX_FILEPATH_LENGTH macro has been renamed to PLATFORM_MAX_FILEPATH_LENGTH_DEPRECATED. * Removed custom resource files for programs, since they are just copies of the base UE4 one (which is used by default anyway). The base UE4 manifest declares support for long paths. * Fix 512 character maximum length on editor commands. 260 character limit remains in place for cooking at the moment (see ContentBrowserUtils.h), until C# staging code supports long paths. Change 4255042 by Ben.Marsh UBT: Remote compilation now uploads the entire workspace to the remote Mac and executes a separate remote instance of UBT rather than synchronizing individual actions. This makes the remote compile codepath much simpler, and removes a lot of special cases that exist to support it previously. The list of files to be transferred to the remote are listed as rsync filter rules in Engine/Build/Rsync/RsyncEngine.txt and RsyncProject.txt, which are applied to the root engine directory and project directory respectively. Projects that need to customize which files are uploaded can add their own <ProjectDir>/Build/Rsync/RsyncProject.txt file, which will be included in the filter before the default version. Change 4260567 by Ben.Marsh UAT: Rename CommandUtils.Log to CommandUtils.LogInformation, to avoid conflicts with the underlying Tools.DotNETCommon.Log class. #rb none [CL 4285673 by Ben Marsh in Main branch]
2018-08-14 18:32:34 -04:00
LogInformation("********** RUN COMMAND COMPLETED **********");
}
private static void RunInternal(ProjectParams Params, string ServerLogFile, string ClientLogFile)
{
// Setup server process if required.
if (Params.DedicatedServer && !Params.SkipServer)
{
if (Params.ServerTargetPlatforms.Count > 0)
{
Copying //UE4/Dev-Mobile to //UE4/Dev-Main (Source: //UE4/Dev-Mobile @ 3056055) #lockdown Nick.Penwarden #rb None ========================== MAJOR FEATURES + CHANGES ========================== Change 3011102 on 2016/06/13 by Steve.Cano After taking a screenshot using glReadPixels, transfer the data to the target buffer from bottom row up to fix the "upside-down" render that OpenGL does. Confirmed with QA (owen.stupka_volt) that this does not appear to be happening on iOS (non-metal devices, inclusion of iOS in write-up was a mistake), verified on an ipod touch 5. Also confirmed that this does not happen on html5, and that Mobile HDR flag does not make a difference in function. #jira UE-26421 #ue4 #android Change 3015801 on 2016/06/16 by Dmitriy.Dyomin Probbably fix for UE-30878, was not able to repro an actual crash(FFoliageInstanceBaseCache::AddInstanceBaseId). Added even more logging in case fix does not work. #jira UE-30878 Change 3015903 on 2016/06/16 by Dmitriy.Dyomin Fixed: Levels window has Refresh/UI issues when World Composition is active #jira UE-26160 Change 3018352 on 2016/06/17 by Chris.Babcock Handle Android media prepare failure (URL without internet for example) #jira UE-32029 #ue4 #android Change 3026387 on 2016/06/24 by Jack.Porter Remove FFuncTestManager warning about PIE when running on a standalone game binary Change 3026398 on 2016/06/24 by Jack.Porter Prevent FSocketBSD::Recv returning false on SE_EWOULDBLOCK Change 3027553 on 2016/06/25 by Niklas.Smedberg OpenGL: Made some block size calculation work for arbitrary block sizes (e.g. not pow-of-two). Change 3027554 on 2016/06/25 by Niklas.Smedberg Metal: copyFromTexture now gets block-aligned size parameter (e.g. used for texture streaming) Change 3028061 on 2016/06/26 by Jack.Porter Fixed a problem where newly discovered instances were not added to an existing session in the Session Browser. Fixed a problem where selecting an instance in a session with multiple instances didn't deselect the previously selected instance correctly. Change 3029220 on 2016/06/27 by Steve.Cano Change Android Tilt values to use GetRotationMatrix/GetOrientation logic, same as java-side android would use, and adjust slightly to match as closely as possible to iOS values for tilt. There is drift and some differences in the "Y" value but the same sort of inconsistencies are also seen on iOS. #jira UE-6135 #ue4 #android Change 3030420 on 2016/06/28 by Jack.Porter Fix crash with RenderOutputValidation when running with cooked content Change 3030426 on 2016/06/28 by Jack.Porter Fix to CL 3026398 - make FSocketBSD(IPv6)::Recv(From) return false when recv returns 0. A return value of 0 indicates the connection was shutdown in an orderly manner. Change 3030973 on 2016/06/28 by Steve.Cano Added a landscape downloader background along with the options to change it from within Android settings #ue4 #android #jira UE-32318 Change 3031757 on 2016/06/28 by Chris.Babcock Remove unused methods from AndroidJNI header #ue4 #android Change 3032387 on 2016/06/29 by Allan.Bentham Rename android es31+aep -> glesdeferred. Change 3032711 on 2016/06/29 by Allan.Bentham Rename GLSL_310_ES_EXT shader define: ES31_AEP_PROFILE -> ESDEFERRED_PROFILE bumped UE_SHADER_GLSL_310_ES_EXT_VER version number. Change 3033698 on 2016/06/29 by Jack.Porter Merging //UE4/Dev-Main to Dev-Mobile (//UE4/Dev-Mobile) Change 3034210 on 2016/06/30 by Steve.Cano Added a new AndroidRuntimeSettings variable that allows creation of installers for both Windows and Mac/Linux if set to true. #jira UE-32302 #ue4 #android Change 3034530 on 2016/06/30 by Chris.Babcock Rename FManifestReader to FAndroidFileManifestReader in AndroidFile #jira UE-32679 #ue4 #android Change 3034612 on 2016/06/30 by Steve.Cano Change Alpha from being set to a range of 0-255 to being in a range of 0-1 (which is the correct range of values) #jira UE-25325 #ue4 #android Change 3034679 on 2016/06/30 by Chris.Babcock Fix tooltip (.command for mac, not .sh) #jira UE-32302 #ue4 #android Change 3038881 on 2016/07/05 by Jack.Porter Package and launch on multiple Android devices simultaneously using the -Device=xxxxxxx+yyyyyyyy+zzzzzzzz format generated by a Project Launcher profile when you select multiple devices #jira UEMOB-115 Change 3039240 on 2016/07/06 by Jack.Porter TcpMessageTransport - connection-based message bus transport. #jira UEMOB-112 #jira UEMOB-113 Change 3039252 on 2016/07/06 by Jack.Porter Enable messaging and session services and functional testing on Android when launched with -messaging Android device detection module support for adding port forwarding and connection announcement for TcpMessageTransport #jira UEMOB-112 #jira UEMOB-113 Change 3039264 on 2016/07/06 by Jack.Porter Merging //UE4/Dev-Main to Dev-Mobile (//UE4/Dev-Mobile) Change 3040041 on 2016/07/06 by Chris.Babcock Pass proper value to script generator functions #jira UE-32861 #ue4 #android Change 3040890 on 2016/07/07 by Allan.Bentham Fix shadow crash #jira UE-32884 Change 3041458 on 2016/07/07 by Peter.Sauerbrei fix for IOS launch on failures Change 3041542 on 2016/07/07 by Peter.Sauerbrei better fix for the multi-device deployment issue Change 3041774 on 2016/07/07 by Steve.Cano Fixing crash that occurs when a games app id for Google Play is set before configuring the apk packaging. Also validating the value that is inserted and using it to override any values that have been hand-inserted into the GooglePlayAppID.xml #jira UE-16992 #android #ue4 Change 3042222 on 2016/07/08 by Dmitriy.Dyomin Mobile packaging scenarious Added a wizard for creating launcher profiles (Android & IOS) for scenario: Minimal App + Downloadable content Added Archive step to launcher profiles to be able to store build product into specified directory Changes to a cooker to be able to pack DLC based with a different flavor to a release App Changes to DLC packaging to be able to build streaming data without chunking pak files #jira UEMOB-119 Change 3042244 on 2016/07/08 by Dmitriy.Dyomin Fixed crash in FTcpMessageTransportConnection::Stop Change 3042270 on 2016/07/08 by Dmitriy.Dyomin GitHub #2320 : [ULevelStreamingKismet] Load Level Instance, Enables UE4 Users to create multiple transformed instances of a .umap without having to include in persistent level's list ? Rama contributed by: EverNewJoy #jira UE-29867 Change 3042449 on 2016/07/08 by Dmitriy.Dyomin Fixing Mac Editor build erros from CL# 3042222 Change 3042480 on 2016/07/08 by Allan.Bentham Add ES3.1 profile & compiler_glsl_es3_1 to shaders. Change 3042481 on 2016/07/08 by Allan.Bentham hlslcc - ES3.1 changes. set ES3.1 version number to 310 Do not use ES2 keywords for ES3.1. Generate Layout Locations for ES3.1 bump version. Change 3042483 on 2016/07/08 by Allan.Bentham Add mobile ES3.1 support. Recreates EGL and ES3.1 context during PlatformInitOpenGL if ES3.1 is required. Change 3042485 on 2016/07/08 by Allan.Bentham Undo android XGE change. Change 3042506 on 2016/07/08 by Dmitriy.Dyomin One more compile fix from CL# 3042222 Change 3044173 on 2016/07/10 by Dmitriy.Dyomin UAT: Added support for building target platforms with multiple cook flavors ex: -targetplatform=Android -cookflavor=ETC1+ETC2 Change 3044213 on 2016/07/11 by Dmitriy.Dyomin Fixed: Can't stream in a level whose name is a substring of another streaming level #jira UE-32999 Change 3044221 on 2016/07/11 by Jack.Porter Merging //UE4/Dev-Main to Dev-Mobile (//UE4/Dev-Mobile) Change 3044815 on 2016/07/11 by Allan.Bentham Corrected NAME_GLSL_ES3_1_ANDROID format string. Change 3046911 on 2016/07/12 by Chris.Babcock Add handling of OnTextChanged for virtual keyboard input on Android #jira UE-32348 #ue4 #android Change 3046958 on 2016/07/12 by Chris.Babcock Rename some functions with Error in the name to prevent false coloring in the logs #jira UE-30541 #ue4 #android Change 3047169 on 2016/07/12 by Chris.Babcock Return player ID and handle auth token for Google Play Games on Android (contributed by gameDNAstudio) #jira UE-30610 #pr #2372 #ue4 #android Change 3047406 on 2016/07/12 by Jack.Porter Add missing import to GameActivity.java Change 3047442 on 2016/07/13 by Dmitriy.Dyomin Added: Mobile custom post-process Limitations: can fetch only from PostProcessInput0 (SceneColor) other scene textures are not supported. Does not support "Replacing the Tonemapper" blendable location. #jira UEMOB-147 Change 3047466 on 2016/07/13 by Dmitriy.Dyomin Disabled engine crash handler on Android, system crash handler works more reliably across different os versions/devices Change 3047746 on 2016/07/13 by Jack.Porter Rename FBasePassFowardDynamicPointLightInfo Change 3047778 on 2016/07/13 by Jack.Porter Missing file for rename FBasePassFowardDynamicPointLightInfo Change 3047788 on 2016/07/13 by Allan.Bentham Fix incorrect TargetPlatformDescriptor string generation. Change 3047790 on 2016/07/13 by Allan.Bentham Fixed half3x3 matrix use with ES3.1 glsl Fixed couple of interpolator precision mismatch. Fixed ES3.1 support detection issues Change 3047816 on 2016/07/13 by Allan.Bentham Remove AndroidGL4 remnants. Change 3048926 on 2016/07/13 by Chris.Babcock Added detection of Amazon Fire TV to disable requiring virtual joysticks #ue4 #android Change 3049335 on 2016/07/14 by Dmitriy.Dyomin Fixing UAT crash when packaging project for iOS Change 3049390 on 2016/07/14 by Jack.Porter Disabled error for warning 4819 "The file contains a character that cannot be represented in the current code page (xxx). Save the file in Unicode format to prevent data loss" This is triggered by European characters and copyright symbols in source saved as latin-1 when compiling on non-US windows. Seen often in 3rd party headers, eg nvapi. #code_review: Ben.Marsh Change 3049391 on 2016/07/14 by Jack.Porter Fixed incorrect comment order in CL 3049390 Change 3049545 on 2016/07/14 by Dmitriy.Dyomin Reworking some code from CL#3047442 to make static analizer happy Change 3049626 on 2016/07/14 by Allan.Bentham Automatic CSM shader toggling #jira UE-27429 Change 3051574 on 2016/07/15 by Jack.Porter Support for lighting channels on Mobile - Multiple directional lights are supported in different channels but primitives are only affected by the directional light in the first channel they have set - CSM shadows from stationary or movable directional lights correctly follow their lighting channels - No channel limitations for dynamic point lights Notes: Removed mobile-specific directional light shadowing fields from View uniform buffer and mobile no longers uses SimpleDirectionalLight. Separate uniform buffers for mobile directional light are generated for each lighting channel. CSM culling information is now stored in FViewInfo and not per FVisibleLightViewInfo as the visibility bits are per view. #code_review Daniel.Wright #jira UEMOB-110 Change 3051699 on 2016/07/15 by Steve.Cano Preserve the original, pre-transformed input vertices for Slate shaders, which is required to properly do anti-aliasing (the ViewProjection-transformed values were causing the lines to not be drawn). #jira UE-20320 #ue4 #android Change 3051744 on 2016/07/15 by Chris.Babcock Fix Android Vulkan include path checks (contributed by kodomastro) #jira UE-33311 #PR #2602 #ue4 #android Change 3052023 on 2016/07/15 by Chris.Babcock Fix shadowed variables Change 3052110 on 2016/07/15 by Chris.Babcock Compile fixes for light channel support on mobile - missing template - accessor function for MobileDirectionalLights from scene Change 3052242 on 2016/07/15 by Chris.Babcock Compile fixes for light channel support on mobile - removed dependency on C++14 feature Change 3052730 on 2016/07/16 by Dmitriy.Dyomin Win32 build fix Change 3053041 on 2016/07/17 by Jack.Porter Merging //UE4/Dev-Main to Dev-Mobile (//UE4/Dev-Mobile) Change 3053054 on 2016/07/17 by Jack.Porter Changed use of old function ShouldUseDeferredRenderer() to new GetShadingPath() Change 3053055 on 2016/07/17 by Jack.Porter Fixed local variable aliasing in unity build Change 3053206 on 2016/07/18 by Jack.Porter Support ExecuteJavascript on iOS and Android Expose ExecuteJavascript to widget blueprint Fix ExecuteJavascript unicode string support on desktop platforms #jira UEMOB-152 Change 3053323 on 2016/07/18 by Dmitriy.Dyomin Added: Ability to set thread affinity for a device in Device Profiles (ex: +CVars=android.SetThreadAffinity=RT 0x02 GT 0x01) #jira UEMOB-107 Change 3053723 on 2016/07/18 by Jack.Porter Fix for UnrealTournamentProto.Automation.cs build errors Change 3055090 on 2016/07/19 by Dmitriy.Dyomin Junk OnlineBlueprintSupport module binaries [CL 3056789 by Jack Porter in Main branch]
2016-07-19 19:13:01 -04:00
TargetPlatformDescriptor ServerPlatformDesc = Params.ServerTargetPlatforms[0];
ServerProcess = RunDedicatedServer(Params, ServerLogFile, Params.RunCommandline);
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3431384) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3252833 on 2017/01/10 by Ori.Cohen Refactor constraint so that it can be used for external solvers. (Copying //Tasks/UE4/Dev-ImmediateModePhysics to Dev-Framework (//UE4/Dev-Framework)) Change 3256288 on 2017/01/12 by Ori.Cohen Undo constraint refactor as we found a way around it and it made the code much harder to read/debug Change 3373195 on 2017/03/30 by Mike.Beach For nativization, changing it so we key off of the target platform-info struct instead of the platform (in preparation for defining the nativized plugin's platform whitelist). Change 3381178 on 2017/04/05 by Dan.Oconnor Make sure we don't inherit the NATIVE func flag when generating skeleton functions, also make sure all bojects outer'd to the skeleton class are marked transient #jira UE-43616 Change 3381532 on 2017/04/05 by Marc.Audy (4.16) Fix various cases where built lighting on child actors could be lost when loading a level #jira UE-43553 Change 3381586 on 2017/04/05 by Mike.Beach Now generating TArrayCaster conversions for nativized UClass arrays that need it (to handle different TSubclassOf arrays). #jira UE-42676, UE-43257 Change 3381682 on 2017/04/05 by mason.seay Some more changes to test map Change 3381844 on 2017/04/05 by Dan.Oconnor Match existing logic for CPF_ReturnParm/CPF_OutParm. Fixes compilation error in BP_TurbineBlades when using compilation manager Change 3382054 on 2017/04/05 by Zak.Middleton #ue4 - Optimize CharacterMovementComponent::GetPredictionData_Client_Character() and GetPredictionData_Server_Character() to remove virtual calls. #jira UE-30998 Change 3382703 on 2017/04/06 by Lukasz.Furman fixed missing links between navmesh polys when there are more than 4 neighbor connections #jira UE-43524 Change 3383357 on 2017/04/06 by Marc.Audy (4.16) Make SetHiddenInGame propagate consistently with SetVisibility #jira UE-43709 Change 3383359 on 2017/04/06 by Dan.Oconnor Fix last errant SKEL reference when cooking Odin Change 3383591 on 2017/04/06 by Mike.Beach Prevent users from setting object variables as 'config' properties (disallowed by UHT). This prevents some errors that could happen later when users nativize the Blueprint. #jira UE-42085 Change 3384762 on 2017/04/07 by Zak.Middleton #ue4 - Fix SpringArmComponent not restoring relative transform when bUsePawnControlRotation is turned off. Fixes the editor interaction ignoring transform of the component in the viewport after bUsePawnControlRotation is toggled on then off, since by then the world transform had been overwritten (from tick in editor) and nothing would drive transform changes from the editable value. Toggling bUsePawnControlRotation off at runtime now restores the rotation to the initial relative rotation, not stomping it with the current pawn rotation, allowing toggling between the editable/desired base rotation and the control rotation. #jira UE-24850 Change 3384948 on 2017/04/07 by Dan.Oconnor Prevent GForceDisableBlueprintCompileOnLoad from causing all sorts of badness when dependencies are loaded as part of a Diff operation. Instead of setting a global flag we flag the package as LOAD_DisableCompileOnLoad Change 3385267 on 2017/04/07 by Michael.Noland Graph Editing: Pushed some node diffing code down from UAIGraphNode into UEdGraphNode so nodes with details panel properties will diff correctly (e.g., various animation nodes and BP switch nodes) #jira UE-21724 Change 3385473 on 2017/04/07 by Phillip.Kavan #jira UE-43067 - Fix broken pin wires after an Expand Node operation, along with some misc. cleanup. Change summary: - Fixed to use correct string for "Expand Node" transaction name. - Modified FBlueprintEditor::OnExpandNodes() to consolidate some redundant code. - Fixed to generate a unique node GUID for cases where the source graph is not removed after expansion. Change 3385583 on 2017/04/07 by Dan.Oconnor Handle CreatePropertyOnScope nullptr return values (happens for structs missing a struct property) #jira UE-43746 Change 3386581 on 2017/04/10 by Michael.Noland Blueprints: Further hardening FBlueprintActionInfo::GetOwnerClass() #jira UE-43824 Change 3386615 on 2017/04/10 by Marc.Audy Instanced properties can now properly be set on a per-instance basis in blueprint added components. #jira UE-42066 Change 3387000 on 2017/04/10 by Marc.Audy Fix includes for CIS Change 3387229 on 2017/04/10 by mason.seay More changes to TM-Gameplay Added Save Game test (with blueprint) Tick Interval test (with blueprint) BP logic cleanup Level organization Change 3388437 on 2017/04/11 by Mike.Beach Adding support for map/set literals in the backend (so you can use set nodes for structs containing sets/maps, without having to connect a RHS input - resets to struct defaults). #jira UE-42617 Change 3388532 on 2017/04/11 by mason.seay Submitting latest changes for crash repro Change 3389026 on 2017/04/11 by Ben.Zeigler Performance and bug fixes for incremetal cooking with asset registry, duplicate of several changes made on //Fortnite/Main Fix it so AssetRegistry.ScanPathsAndFilesSynchronous won't scan subdirectories inside already scanned directories, this cuts down on the number of cache files Fix 2 second stall when shutting down AssetSourceFilenameCache if it had never been previously created Change 3389163 on 2017/04/11 by Ben.Zeigler #jira UE-42922 Fix it so connecting function input node output pins does not clear default value, we only want to clear the value when connecting an input pin. Properly testing this fix depends on UE-43883 Change 3389205 on 2017/04/11 by Marc.Audy Protect against a handful of GEditor usages that can now be hit in standalone Change 3389220 on 2017/04/11 by Marc.Audy Don't borrow ClassWithin to masquerade as ParentClass during compilation and instead just set the super struct immediately Change 3389222 on 2017/04/11 by Michael.Noland Framework: Adding a cvar (t.TickComponentLatentActionsWithTheComponent) to allow users to revert to the old behavior on when component latent actions tick - Non-zero values behave the same way as actors do, ticking pending latent action when the component ticks, instead of later on in the frame (default behavior in 4.16 and beyond) - Prior to 4.16, components behaved as if the value were 0, which meant their latent actions behaved differently to actors This CVar will be removed in a future version, defaulting to on #jira UE-43661 Change 3389276 on 2017/04/11 by Marc.Audy Spelling fix and NULL to nullptr Change 3389303 on 2017/04/11 by Mieszko.Zielinski Made sure AIController::Posses doesn't get called when compiling Pawn BP #UE4 #jira UE-43873 Change 3390215 on 2017/04/12 by mason.seay Removed some tests, will need further review Change 3390638 on 2017/04/12 by Mike.Beach Generalizing the omission of the CoerceProperty (in EmitTerm) - previously we were only omitting properties for our custom array lib. For wildcards, a coerce property should not be used as its type will not match. NOTE: There is a slight behavior change in UEdGraphSchema_K2::ConvertPropertyToPinType(), as it will return 'wildcard' for params marked as 'ArrayTypeDependentParams' (previously would have returned 'int'). #jira UE-42747 Change 3390774 on 2017/04/12 by Ben.Zeigler #jira UE-43911 Fix several issues with saving a runtime asset registry containing redirectors that caused crashes in cook on the fly. Don't resolve redirectors on incoming links because it will make a circular link, and fix an issue where chained redirectors would break the for loop iteration and return a bad dependency Fix it so the asset registry written out at the beginning of CookOnTheFly uses the registry generator, otherwise it will include all of the stripped editor only tags Change 3390778 on 2017/04/12 by Ben.Zeigler Fix UCookOnTheFlyServer::CollectFilesToCook to check for initial unsolicited packages up front. This is required in iterative mode because it may skip cooking all explicit packages and thus miss a new startup loaded package Change 3390782 on 2017/04/12 by Ben.Zeigler Change RunProjectCommand to not imply -nomcp, and allow reading -clientcmdline to override setting the map parameter to 127.0.0.1 by default Fix RunProjectCommand to remove ios-specific checks to not pass weird platform parameters, and instead never pass them Fix PS4Platform to pass along command line when calling build cook run, args needs to be the last parameter so explicitly set -target= Change 3390859 on 2017/04/12 by Mike.Beach T3D class fields now export with the class's fully qualified path name (to avoid abiguity). Since we can have multiple classes with the same name (Blueprints in different folders), we have to use the class's fully qualified object path. #jira UE-28048 Change 3390914 on 2017/04/12 by Lukasz.Furman fixed missing navlink component's transform in exported navigation data #jira UE-43688 Change 3391122 on 2017/04/12 by Ben.Zeigler Add new PreloadPrimaryAssets call to AssetManager that stream the desired assets without modifying the official load/unload state. This is useful if you want to preload things in case the might be used in the future, and it also supports recursion Fix crash calling GetAssetDataForPath with null path Change 3391494 on 2017/04/12 by Dan.Oconnor Fix bad references in deep object (widget) hierarchies #jira UE-43802 Change 3391529 on 2017/04/12 by Dan.Oconnor Fix log spam, accidently submitted #rnx Change 3391756 on 2017/04/12 by Dan.Oconnor LinkExternalDependencies needs to be performed before we RefreshVariables #jira UE-43843 Change 3392542 on 2017/04/13 by Marc.Audy Ensure that initialized actors get cleaned up when removed from world even if that world hasn't begun play. #jira UE-43879 Change 3392746 on 2017/04/13 by Marc.Audy (4.16) When duplicating a blueprint node, correctly make the new node a sibling of the duplicated node, not a child of it (unless duplicating the root component). Also resets scale of a duplicated root component to 1 to avoid a squaring of the scale for that component. #jira UE-40218 #jira UE-42086 Change 3393253 on 2017/04/13 by Dan.Oconnor Make sure calculated meta data is correctly set on functions generated by the compilation manager (SKEL_ class functions) #jira UE-43883 Change 3393509 on 2017/04/13 by Mike.Beach Removing hack'ish ResetLoaders() call that was causing undesired side-effects (resetting of a loaded package that other objects were relying on). This was originally intended to release file handles so separate editor processes could make updates and save the file (from CL 1712376). Using ResetLoaders() for this is bad though, as it has too many side effects. Instead we have to wait for GC to run. This also makes sure that GC should run as intended as the CookOnTheFly sever is idling. #jira UE-37284 Change 3394350 on 2017/04/14 by Michael.Noland Core: Making FDateTime and FTimespan actually reflected, so they get duplicated properly in CopyPropertiesForUnrelatedObjects, etc... #jira UE-39921 Change 3395985 on 2017/04/17 by Phillip.Kavan #jira UE-38280 - Fix invalid custom type selections on member fields in the User-Defined Structure Editor after a reload. Change summary: - Ensure that the 'SubCategoryObject' member in a UDS variable descriptor has been loaded when converting to an FEdGraphPinType. Change 3396152 on 2017/04/17 by Marc.Audy TickableGameObjects that have IsTickableInEditor false should not tick in the editor #jira UE-40421 Change 3396279 on 2017/04/17 by Phillip.Kavan #jira UE-43968 - Fix failed validation of bitmask enum types when serializing bitmask literal nodes. Change 3396299 on 2017/04/17 by Dan.Oconnor Fix resintancing issues exposed by running TM-Gameplay with -game. We cannot reinstance actors in levels on load because the scene is not created. #jira UE-43859 Change 3396712 on 2017/04/17 by Marc.Audy Call PostLoad on subobjects before copying for unrelated properties to avoid cases where an out of date object patched over in the linker has not been brought up to date #jira UE-38234 Change 3396718 on 2017/04/17 by Mike.Beach Adding a search bar to the components tree for Blueprints. #epicfriday #jira UE-17620 Change 3396999 on 2017/04/17 by Mike.Beach In generated code, call event '_Implementation' functions directly for interface functions being invoked on self (avoids a UHT runtime error). #jira UE-44018 Change 3397700 on 2017/04/18 by Marc.Audy UT struct BlueprintType fixups Change 3397701 on 2017/04/18 by Marc.Audy Odin struct BlueprintType fixups Change 3397703 on 2017/04/18 by Marc.Audy Ocean struct BlueprintType fixups Change 3397704 on 2017/04/18 by Marc.Audy WEX struct BlueprintType fixups Change 3397705 on 2017/04/18 by Marc.Audy Additional UT blueprint type struct fixups Change 3397706 on 2017/04/18 by Marc.Audy Fortnite struct BlueprintType fixups Change 3397708 on 2017/04/18 by Marc.Audy Fixup Engine BlueprintType markup of structs Change 3397709 on 2017/04/18 by Marc.Audy Sample Game struct BlueprintType fixups Change 3397711 on 2017/04/18 by Marc.Audy Mark AnimNodes as BlueprintType and BlueprintInternalUseOnly Change 3397712 on 2017/04/18 by Marc.Audy Paragon struct BlueprintType fixups Change 3397735 on 2017/04/18 by Marc.Audy Definition pieces of BlueprintInternalUseOnly to fix UHT errors with structs already marked to use it Change 3397912 on 2017/04/18 by Mike.Beach Fix for CIS warnings about shadowed variables (fallout from CL 3396718). Change 3398455 on 2017/04/18 by Marc.Audy Make less critical errors log an error rather than immediately throwing allowing multiple errors to be reported in the same compile Change 3398491 on 2017/04/18 by Marc.Audy BPRW/BPRO in a non-BlueprintType is now a UHT error Change 3398539 on 2017/04/18 by Marc.Audy Fixup live link struct markups Change 3399412 on 2017/04/19 by Marc.Audy Fix Match3 blueprint type struct markups Change 3399509 on 2017/04/19 by Phillip.Kavan #jira UE-38574 - Fix AnimBlueprint function graphs marked as 'const' to treat 'self' as read-only when compiling. Change summary: - Modified FKismetCompilerContext::ProcessOneFunctionGraph() to use the function graph schema rather than the compiler context schema for both the function context's schema as well as testing the function for 'const'-ness. For AnimBPs, the compiler context and the function graph context can differ, so we need to make sure we are using the right one when making queries for a specific function context during compilation. - Minor cleanup: changed the function context schema to be 'const' in order to be consistent with the function graph GetSchema() API's result. Added a few 'const' qualifiers where needed to match. - Added a new object version in order to avoid breaking compilation of existing AnimBP function graphs that may already be violating the 'const' rule (this is the same thing that was done when 'const' was first added to "normal" BP function graphs). Just as with normal function graphs in place before the addition, a warning will be generated for existing AnimBP function graphs if they violate 'const' correctness, and an error will be generated for all new ones. Change 3399749 on 2017/04/19 by Mike.Beach Hiding the Nativized Blueprints plugin from the in-editor browser (prevent users from disabling it). Change 3399774 on 2017/04/19 by Marc.Audy ConditionalPostLoad is already called on StaticMesh earlier in the function #rnx Change 3400313 on 2017/04/19 by Mike.Beach Mirroring CL 3398673 from 4.16 Now, with ICWYU, making sure that the coresponding header gets included first in nativized Blueprint files (else we get a UHT error). Had to fixup some ShooterGame specific files as a result (they had missing includes and forward declarations). #jira UE-44124 Change 3400328 on 2017/04/19 by Mike.Beach Missing file from mirrored change (CL 3400313 - mirroring CL 3398673 from 4.16) #jira UE-44124 Change 3400415 on 2017/04/19 by Chad.Garyet adding physx switch build to framework Change 3400514 on 2017/04/19 by Mike.Beach Back out changelist 3400313 / 3400328 (mirrored from CL 3398673 in 4.16), as it was producing "include PCH first" errors. Likely, CL 3398673 was a fix for a 4.16 specific change, altering the expected include order. We'll have to wait for this one to be integrated back. Change 3400552 on 2017/04/19 by Marc.Audy Undo the calling of post load prior to the CPFUO as dependent objects may not yet be loaded. Instead copy the need load flag to the new CDO subobject, similarly to how the top level CDO object copies its flags over. #jira UE-44150 Change 3400815 on 2017/04/19 by Marc.Audy Spelling fix (part of PR #3490) #rnx Change 3400918 on 2017/04/19 by Marc.Audy Partial pull of PR #3490: Improved remapping game controls support (Contributed by projectgheist) This portion brings in the exposure of the bindings to blueprint #jira UE-44122 Change 3401550 on 2017/04/20 by Marc.Audy fix kitedemo blueprint type markup #rnx Change 3401702 on 2017/04/20 by Mike.Beach Make it so plugins added to a project through the .uproject's 'AdditionalPluginDirectories' list get folded into the generated code project (for visual studio, etc.). Change 3401720 on 2017/04/20 by Mike.Beach Add white and black lists for target type (game, client, server, etc.) to plugin module descriptors. Change 3401725 on 2017/04/20 by Mike.Beach Whitelisting the nativized Blueprint plugin for only the targets it was built for (game, server, or client). Change 3401800 on 2017/04/20 by Ben.Zeigler Add Algo::BinarySearch, LowerBound, and UpperBound. These are setup to allow binary searching a presorted array, and allow for specifying projection and sort predicates. Convert some engine code to use it Add TSortedMap, which is a map data structure that has the same API as TMap, but is backed by a sorted array. It uses half the memory and performance is faster below n=10 Add FName::CompareIndexes so a SortedMap with FNames can be used without doing very slow string compares, and FNameSortIndexes predicate to sort by it Add code to Algo and Container tests. Split up container tests so the new ones aren't run in smoketest as they are a bit slow Add RemoveCurrent and SetToEnd to ArrayIterator Change 3401849 on 2017/04/20 by Marc.Audy Partial pull of PR #3490: Improved remapping game controls support (Contributed by projectgheist) This portion brings bug fixes and improvements to InputKeySelector UMG widgets. #jira UE-44122 Change 3402088 on 2017/04/20 by Marc.Audy Focus the search box when expanding the map value type #jira UE-44211 Change 3402251 on 2017/04/20 by Ben.Zeigler Fix issue where SortedMap needs to be resorted after serialization, because the sorting may have changed from when it was saved out Change 3402335 on 2017/04/20 by Ben.Zeigler Significant changes to FAssetData serialization and memory, cuts memory significantly but will break code that was using some of the internal API that was not properly hidden before Both Editor and Runtime cache now use the same FAssetRegistryVersion, which is now registered as a custom version Rename FAssetData and FAssetPackage operator<< to SerializeForCache to make it clear that it isn't safe to use for general serialization Remove GroupNames from FAssetData, it has not been useful since the UE4 package structure changed around 4.0 Rename generic-sounding but not actually generic SharedMapView class to AssetDataTagMapSharedView to indicate what it is actually used for Change TagsAndValues to use a new array-backed TSortedMap as the base structure instead of a hash map. Also, it only allocates the map on demand, which saves significant memory at runtime as many packages have no tags Add bFilterAssetDataWithNoTags to [AssetRegistry] ini section, if set it will only save cooked asset data if it has tags, off by default but saves significant memory if your whitelist is set up properly Fix issue where asset registry tags updated by loading assets during cook were not being reflected in the cooked registry Add AssetRegistry::GetAllocatedSize and add to MemReport output Change 3402457 on 2017/04/20 by Ben.Zeigler Enable asset registry iteration and stripping unused asset data in Fortnite. Registry iteration is already on in //Fortnite/Main, stripping is a new feature I want to test Change 3402498 on 2017/04/20 by Ben.Zeigler CIS fix. Why did this compile locally? Change 3402537 on 2017/04/20 by Ben.Zeigler Remove ensure for making AssetData for subobjects, the editor does this for thumbnail creation in some cases Change 3402600 on 2017/04/20 by Ben.Zeigler Add bShouldGuessTypeAndNameInEditor to manager settings, can be set false for games where type cannot be safely implied and content must be resaved Fix up some bool setting code inside asset manager, and fix const correctness and for iterator issues AssetManager can now discover any BlueprintCore type when bHasBlueprintClasses=true Add AssetManager.DumpAssetRegistryInfo to output detailed asset registry usage stats Add Primary Name to asset audit window by default Change 3403556 on 2017/04/21 by Marc.Audy Fix Orion input key selector override class #rnx Change 3404090 on 2017/04/21 by mason.seay Applying Forcefeedback to test map Change 3404093 on 2017/04/21 by mason.seay Changing text in level Change 3404139 on 2017/04/21 by mason.seay Added Force Feedback test and made some tweaks. Change 3404146 on 2017/04/21 by mason.seay Added source reference to Instanced Variable test Change 3404154 on 2017/04/21 by mason.seay More minor tweaks Change 3404155 on 2017/04/21 by Marc.Audy Remove auto #rnx Change 3404188 on 2017/04/21 by Marc.Audy Fixed crash changing variable type when any type other than map #jira UE-44249 #rnx Change 3404463 on 2017/04/21 by Ben.Zeigler Fix asset data code to not ensure when loading an object with invalid exports, and instead print warning with name of package that needs to be resaved Resave a map that had a redirector from a DIFFERENT package saved in it's exports. I do not understand how this happened, but it appears to be related to the lightmap BuiltData transition when old maps are opened Change 3404465 on 2017/04/21 by Ben.Zeigler Fix issue with trying to load editor-only asset classes in a cooked build Fix issues with renaming or changing template Ids of assets from the editor Always print the Duplicate Asset ID error, as if you have more than one the ensuremsg only goes off once Change 3404481 on 2017/04/21 by Dan.Oconnor Remove unneeded walk up hierarchy - prevent stale entries in action database if we compile a BP but don't compile its children Change 3404510 on 2017/04/21 by Phillip.Kavan #jira UE-35727 - Collapsed graphs containing a local variable node will no longer cause a compile error when the parent graph is renamed. Change 3404590 on 2017/04/21 by Michael.Noland Editor: Fixed incorrect filtering of abstract/deprecated UDeveloperSettings and UContentBrowserFrontEndFilterExtension classes caused by a typo (HasAnyCastFlags versus HasAnyClassFlags) Change 3404593 on 2017/04/21 by Marc.Audy Fixed another crash to do with input pin secondary combo box #jira UE-44269 #rnx Change 3404600 on 2017/04/21 by Michael.Noland Core: Allow UE_GC_TRACK_OBJ_AVAILABLE to be set externally #rnx Change 3404602 on 2017/04/21 by Michael.Noland Engine: Switched from an include to a forward declaration of SWidget in UDeveloperSettings to keep it slim #rnx Change 3404608 on 2017/04/21 by Michael.Noland Core: Marked TNumericLimits as constexpr so they can be used in static asserts Change 3404659 on 2017/04/21 by Michael.Noland Engine: Adding includes back to two UDeveloperSettings subclasses Change 3405289 on 2017/04/24 by Marc.Audy Remove auto #rnx Change 3405446 on 2017/04/24 by Marc.Audy Fix Win32 unsigned compile issue Change 3405512 on 2017/04/24 by Mike.Beach Piping through NativizationOptions to filename generation (so we're able to gen different files names per target: client vs. server). Change 3406080 on 2017/04/24 by Ben.Zeigler Deprecate UEngine::OnPostEngineInit and move to FCoreDelegates, clean up comments for the initialization delegates Call OnPostEngineInit from commandlet initialization as well as normal execution. I thought about making a wrapper function, but the commandlet calls EditorInit directly so it wouldn't work Bind delegate to refresh the AssetRegistry native class hierarchy after engine init so it picks up game/plugin classes. Undo ini change that was required to hack around this Change 3406381 on 2017/04/24 by Ben.Zeigler #jira UE-23768 Enable Run Physics With No Controller for montage test pawn. The montage pawn has no controller so wasn't correctly running physics when the root motion stopped. This flag needs to be set to allow it to correctly stop after the montage is over Change 3406438 on 2017/04/24 by Ben.Zeigler Fix deprecation warning Change 3406519 on 2017/04/24 by Phillip.Kavan #jira UE-43612 - Suppress array "Get" node fixup notifications on load when the BP Compilation Manager is enabled. Change summary: - Wrapped BPCM calls to FBlueprintEditorUtils::ReconstructAllNodes() and ReplaceDeprecatedNodes() duirng compile-on-load with bIsRegeneratingOnLoad = true. This matches the BP's state during compile-on-load when the BPCM is not enabled. Change 3406565 on 2017/04/24 by Dan.Oconnor Make sure all interface functions are added to skeleton #jira UE-44152 Change 3407489 on 2017/04/25 by Ben.Zeigler #jira UE-44317 Fix game-only TickableGameObjects to correctly tick in PIE Change 3407558 on 2017/04/25 by Ben.Zeigler Fix Fortnite cook warnings, issue had to do with the CDO being registered as a Primary Asset in conflict with the Class being registered Fix issue with renaming a BP primary asset not finding the old name Change 3407701 on 2017/04/25 by Dan.Oconnor Remove unneeded null check, static analysis doen't like the inconsistency Change 3407995 on 2017/04/25 by Marc.Audy Fixed maps and sets not working correctly with split pin. #jira UE-43857 Change 3408124 on 2017/04/25 by Ben.Zeigler #jira UE-39586 Change it so the blueprint String/Name/Object to Text node creates culture invariant text, and also have them show as an expanded node with a comment explaining this Fix Transform to actually return in the format specified in the comment, and fix comments on many text conversions Change 3408134 on 2017/04/25 by Marc.Audy Graph pin container type now represented by an enumeration (EPinContainerType) rather than 3 "independent" booleans. FEdGraphPinType constructor, UEdGraphNode::CreatePin, and FKismetCompilerContext::SpawnInternalVariable that took 3 booleans deprecated and replaced with a version that takes EPinContainerType. UEdGraphNode::CreatePin parameters reorganized so that PinName is before ContainerType and bIsReference, which default to None and false respectively Change 3408256 on 2017/04/25 by Michael.Noland Core: Changed UClass::ClassFlags to be of type EClassFlags for improved type safety Change 3408282 on 2017/04/25 by Marc.Audy (4.16) Fix incorrect positioning of instance components after duplication #jira UE-44314 Change 3408404 on 2017/04/25 by Mike.Beach Adding and removing the nativized plugin to/from the project when we alter the packaging nativization setting (so it gets picked up by project generation). Change 3408445 on 2017/04/25 by Marc.Audy Fix up missed deprecation cases #rnx Change 3409354 on 2017/04/26 by Marc.Audy Fix Linux CIS failure #rnx Change 3409487 on 2017/04/26 by Marc.Audy When dragging assets in to the SCS create them as siblings, not nested #jira UE-43041 Change 3409776 on 2017/04/26 by Ben.Zeigler #jira UE-44401 Fix issue with cooking a map containing a reparented component. In that case the child component may think it's not editor only, but it's archetype is editor only. This is not allowed in EDL, so now the child is marked as editor only as well Change 3410168 on 2017/04/26 by Dan.Oconnor Avoid calling virtual functions in the middle of compile #jira UE-44243 Change 3410252 on 2017/04/26 by Lukasz.Furman adjusted WITH_GAMEPLAY_DEBUGGER checks after IWYU changes #ue4 Change 3410385 on 2017/04/26 by Marc.Audy ChildActorComponent SetClass no longer fails when setting at runtime. #jira UE-43356 Change 3410466 on 2017/04/26 by Michael.Noland Core: Ensuring EClassFlags is 32 bit in a different way (underlying type of the enum is coming out signed even though all members are unsigned, long term fix is probably to move it to an enum class) #rnx Change 3410476 on 2017/04/26 by Michael.Noland Automation: Deleting some commented out methods #rnx Change 3411070 on 2017/04/27 by Marc.Audy Properly complete deprecation of old attachment API Change 3411338 on 2017/04/27 by mason.seay Map for Latent Action Tick Bug Change 3411637 on 2017/04/27 by Ben.Zeigler Back out CL #3381532 as it was causing crashes when adding new variables to blueprints, as the transaction array was being recursively modified while it was being added to Change 3412052 on 2017/04/27 by mason.seay Updated jump test map and pawn Change 3412231 on 2017/04/27 by Ben.Zeigler Fix issue where running SearchAllAssets multiple times after mounting new paths would throw away the asset registry cache, which slowed down incremental cooking substantially because the cooker mounts the autosave folder Duplicate of CL #3411860 Change 3412233 on 2017/04/27 by Ben.Zeigler Made FStreamableHandle::GetLoadedCount much faster by taking advantage of existing progress counter Duplicate of CL #3411778 Change 3412235 on 2017/04/27 by Ben.Zeigler Add code to FStringAssetReferenceThreadContext and FStringAssetReferenceSerializationScope which allows setting package name and collect options for string asset references serialized via something other than linker load Make RedirectCollector threadsafe to avoid issues with async loading asset references Fix it so ProcessStringAssetReferencePackageList will remove entries from the string asset array like resolve did, and rename function to indicate that Fix it so string asset references created by asset labels do not automatically get cooked, and significantly improve the speed of labels with lots of assets Add code to cooker and asset manager to explicitly mark non-cookable assets as NeverVook, this stops labels from ending up in the build if set that way Added option to not recurse package dependency changes more than one level when hashes change. This ended up not being significantly faster in a realistic case so left disabled Duplicate of CL #3412080 Change 3412352 on 2017/04/27 by Marc.Audy Refix lighting getting wrong position when getting component instance data Change 3412426 on 2017/04/27 by Marc.Audy Take first steps to making ComponentToWorld private and force use of accessor Make bWorldToComponentUpdated private Make ComponentToWorld and bWorldToComponentUpdated mutable Add a SetComponentToWorld function for the (likely ill-advised) places that were setting it directly. Change 3412468 on 2017/04/27 by Marc.Audy Remove last remnants of deprecated (4.11) custom location system Change 3413398 on 2017/04/28 by Marc.Audy Fix up missed deprecated attachment API uses Change 3413403 on 2017/04/28 by Marc.Audy Fix Orion compile error #rnx Change 3413448 on 2017/04/28 by Marc.Audy Fix up kite demo component to world privataization warnings #rnx Change 3413792 on 2017/04/28 by Ben.Zeigler Fix many bugs with blueprint pin default values, and add "Reset to Default Value" option to pin context menu Deprecate and rename SetPinDefaultValue because it actually sets the Autogenerated default. This was being called in bad places and destroying the stored autogenerated defaults #jira UE-40101 Fix expose on spawn pins to correctly update when the spawned object's defaults change #jira UE-21642 Fix struct pin default values to properly update when the struct is changed #jira UE-39418 Fix changed function/macro default values to properly update in already placed call nodes Change 3413839 on 2017/04/28 by samuel.proctor Added some Blueprint focused tests for TM-Gameplay Change 3414030 on 2017/04/28 by Ben.Zeigler Enable use of AssetPtr variables with Config, for native and blueprint This incorporates CL #3302487 but also enables for blueprint usage as that code is new to framework branch Change 3414229 on 2017/04/28 by Marc.Audy Fixup virtuals not calling their Super Remove some autos #rnx Change 3414451 on 2017/04/28 by Lukasz.Furman static analysis fix for gameplay debugger Change 3414482 on 2017/04/28 by Ben.Zeigler Fix crash found where changing pin type on ConvertAsset accessed an array while deleting it Change 3414609 on 2017/04/28 by Ben.Zeigler #jira UE-18146 Refresh graph when disconnecting a resolve asset id node Change 3415852 on 2017/05/01 by Marc.Audy Remove unused code #rnx Change 3415856 on 2017/05/01 by Marc.Audy auto removal #rnx Change 3415858 on 2017/05/01 by Marc.Audy Fix function taking an input as reference when unneeded and causing (still unclear why it suddenly started showing up) error in cooking #rnx Change 3415946 on 2017/05/01 by Marc.Audy Have K2Node_StructOperation skip the K2Node_Variable validation as it doesn't need a property (per CL# 1756451) #rnx Change 3415988 on 2017/05/01 by Lukasz.Furman renamed WorldContext param in AI related static blueprint functions to remove load/cook warnings #jira UE-44544 Change 3416030 on 2017/05/01 by Ben.Zeigler Fix issue with WorldContext pins being broken by my pin value refactor, partial paths like "WorldContext" need to be stored as strings and not as broken object references. Change 3416230 on 2017/05/01 by Marc.Audy Fix spelling error #rnx Change 3416419 on 2017/05/01 by Phillip.Kavan #jira UE-44213 - Nativizing a Blueprint class with a non-nativized Blueprint class subobject dependency will no longer lead to a crash at load time. Change summary: - Modified the FFakeImportTableHelper ctor to inject subobject CDOs into the 'SerializeBeforeCreateCDODependencies' array. This in turn ensures that EDL will serialize those subobject CDOs (if necessary) before we create the subobject's nativized owner's CDO at load time. - Modified FEmitDefaultValueHelper::GenerateCustomDynamicClassInitialization() to emit MiscConvertedSubobject instantiations AFTER we emit the FillUsedAssetsInDynamicClass() call. This is now consistent with the code emitted for other subobjects (all of which assumes that the UsedAssets array has been initialized). - Modified FFindAssetsToInclude::HandleObjectReference() to add UField owner CDOs in addition to the owner class to the asset dependency list. This ensures that owner CDOs will be emitted alongside the class to both the nativized asset dependency table as well as to the fake import table associated with the UDynamicClass linker for the nativized BP asset. Change 3416425 on 2017/05/01 by Phillip.Kavan #jira UE-44219 - Nativizing a Blueprint class with a nativized DOBP class dependency will no longer lead to a compile error at cook/nativization time. - Modified the FGatherConvertedClassDependencies ctor to properly handle DOBPs in exclusive mode that have been explicitly enabled for nativization. Previously, this code wasn't taking that possibility into account, and as a result could lead to a missing header file in a dependent nativized class body's include set. - Modified FGatherConvertedClassDependencies::GetFirstNativeOrConvertedClass() to remove the 'bExcludeBPDataOnly' parameter, as it was primarily just being used for a redundant exclusion check when called from the FGatherConvertedClassDependencies ctor. That call site has now been modified to start searching from the super class instead. Additionally, any DOBPs will already fail the preceding WillClassBeConverted() check if they have not been explicitly enabled for nativization in exclusive mode, and will always fail if nativizing in inclusive mode. The extra check was breaking the explicitly-enabled case, so it was removed to allow explicitly-enabled DOBPs to pass. Notes: - Allowing for explicitly-enabled DOBPs in exclusive mode may be removed in a future change, but since it is currently supported, the changes noted above will at least ensure that the generated code will compile properly for now. Change 3416570 on 2017/05/01 by mason.seay Added UMG test to map. Tweaked force feedback test Change 3416580 on 2017/05/01 by mason.seay Resubmitting sub levels Change 3416597 on 2017/05/01 by Dan.Oconnor Compilation manager iteration, adds machinery for individual blueprint compilation, adds comments, cleans up duplicated code Change 3416636 on 2017/05/01 by Phillip.Kavan #jira UE-44505 - Potential fix for a low-repro crash tied to the Blueprint graph context menu. Change summary: - Switched FBlueprintActionInfo::ActionOwner to be a weak object reference. Change 3416960 on 2017/05/01 by Dan.Oconnor Use compilation manager when clicking the compile button, PIE'ing, etc Change 3417207 on 2017/05/01 by Ben.Zeigler Fix issue with None strings causing default value parsing failures Add SetPinDefaultValueAtConstruction needed by some other changes Change 3417519 on 2017/05/01 by Ben.Zeigler Fix BP compile errors caused by local variables with invalid default values. There's no reason to set autogenerated here because the nodes are transient and invisible in the UI. There is still a problem here, local variables are not getting their default values validated when type is changed, so you end up with an integer that has the default value of a struct. Change 3418659 on 2017/05/02 by Ben.Zeigler #jira UE-44534 Fix it so animation node pins get properly created autogenerated default values that are based on the node struct defaults. This fixes issues when they are reset to other defaults #jira UE-44532 Fix it so connecting an animation asset pin on a node player resets the pin value to the autogenerated default instead of the cached asset. This was causing old unused assets to get unnecessarily cooked Fix it so any animation node with an exposed pin that is an object property will reset that object propery when the pin is exposed. This fixes UE-31015 in a generic way Change the OptionalPinManager to take a Defaults address as well as a current address, to allow setting autogenerated defaults properly Remove Import/ExportKismetDefaultValueToProperty as they were redundant with PropertyValueFromString and were using the wrong pin setting functions, replaced with PropertyValueFromString_Direct and calling the schema pin set functions I need to write some backward compatibility code to fix existing nodes, I'll do that in a later checkin Change 3418700 on 2017/05/02 by Ben.Zeigler Actually fix None object paths for real this time. I did not test sufficiently before Change 3418811 on 2017/05/02 by Ben.Zeigler Fix existing animation blueprint nodes with dead asset references duplicated by pins. This code can be applied independent of the other change to fix specific games Change 3419165 on 2017/05/02 by Dan.Oconnor Add misc. functionality from FKismetEditorUtilities::CompileBlueprint Change 3419202 on 2017/05/02 by Marc.Audy Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3417825 #rnx Change 3419236 on 2017/05/02 by mason.seay Removed OnPressed event from Widget BP Change 3419314 on 2017/05/02 by Marc.Audy Fix bad auto-resolve #rnx Change 3419524 on 2017/05/02 by Marc.Audy PR #3528: Improved Input BP library node display names (Contributed by projectgheist) #jira UE-44587 #rn Improved Input BP library node display names Change 3419570 on 2017/05/02 by Zak.Middleton #ue4 - Fix typo in TFunctionRef comment/example. Change 3419709 on 2017/05/02 by Dan.Oconnor Fix missing category metadata on SkeletonGeneratedClass when using compilation manager Change 3419756 on 2017/05/02 by Dan.Oconnor Remove unintentional verbosity increase Change 3420875 on 2017/05/03 by Marc.Audy Make IsExecPin static Minor optimization to IsMetaPin #rnx Change 3420981 on 2017/05/03 by Marc.Audy Change tagging temporarily until other changes are done so that we don't have warnings in the meantime #rnx Change 3421367 on 2017/05/03 by Marc.Audy Manually introduce changes from CL# 3398673 in 4.16 that failed to make it to Dev-Framework as a result of the integration submitted as CL# 3401725. #rnx Change 3421685 on 2017/05/03 by Ben.Zeigler #jira UE-23001 Convert literal Asset ID/Class ID pins to store path as string instead of as hard object reference. Old pins are fixed on load, after resaving the hard references will go away Refactor the way that FStringAssetReference and FAssetPtr are serialized, it now does the various fixups in FStringAssetReference::SerializePath, which is called from archivers Change it so the asset registry reads in a list of all scanned redirectors and adds them to GRedirectCollector, this means that saving a string asset reference will automatically fix it up to point to the redirector destination Change the default behavior of FAssetPtr serialize on ArchiveUObject to match what most of it's children want, and remove several special case hacks. It now serializes as asset reference when saving/loading, and as object for other cases Deprecate StringAssetReferenceLoaded/StringAssetReferenceSaving delegates, replace with PreSavePath and PostLoadPath on FStringAssetReference Make AssetLongPathname private on FStringAssetReference, it was deprecated in 4.9 Change 3421728 on 2017/05/03 by Phillip.Kavan Mirror CL 3408285 from //UE4/Release-4.16. #jira UE-44124 #rnx Change 3422370 on 2017/05/03 by Dan.Oconnor Mirror 3422359 Implement UBlueprintGeneratedClass::NeedsLoadForEditorGame to match UBlueprint, also tag a class's CDO as NeedsLoadForEditorGame. This prevents us from failing to load a UBlueprint's GeneratedClass when running the editor with -server. #jira UE-44659 Change 3423192 on 2017/05/04 by Ben.Zeigler CIS Fix Change 3423305 on 2017/05/04 by Ben.Zeigler Fix "Missing opening parenthesis" warnings for Vector and Rotator the same way they were fixed for Transform Change 3423358 on 2017/05/04 by Marc.Audy Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3422809 #rnx Change 3423766 on 2017/05/04 by Ben.Zeigler #jira UE-44680 Delete some corrupted redirectors that are no longer in use Change 3423804 on 2017/05/04 by Dan.Oconnor Honor SaveIntermediateCompilerResults when using compilation manager Change 3424010 on 2017/05/04 by Marc.Audy Validate that switch string cases are unique Change 3424011 on 2017/05/04 by Marc.Audy Re-fix switch node default pin not appearing as an exec output Remove unused boolean Change 3424071 on 2017/05/04 by Ben.Zeigler Delete FixupRedirects commandlet, replace with -FixupRedirects/FixupRedirectors option on ResavePackages. This new method is much faster than the old commandlet as it uses the asset registry vs loading all packages, fixing up all redirectors in Fortnite only took about an hour vs 12+ hours the old way Removed some hacky bits in Core that only existed to support FixupRedirects Change it so the AssetRegistry listens to DirectoryWatcher callbacks in commandlets now that commandlets use the asset registry properly. This won't do anything unless you tick directory watcher the way that ResavePackages does Change 3424313 on 2017/05/04 by Dan.Oconnor Address missing property flags on SkeletonGeneratedClass when using compilation manager #jira UE-44705 Change 3424325 on 2017/05/04 by Phillip.Kavan #jira UE-44222 - Move nativized UDS implementation details into its own .cpp file in order to avoid circular dependencies. Change summary: - Modified IKismetCompilerInterface::GenerateCppCodeForStruct() to include an output parameter for CPP source and modified FKismet2CompilerModule to match the updated API. - Modified IBlueprintCompilerCppBackend::GenerateCodeFromStruct() to include an output parameter for CPP source and modified FBlueprintCompilerCppBackendBase to match the updated API. - Modified FBlueprintNativeCodeGenUtils::GenerateCppCode() to adjust the call to GenerateCppCodeForStruct() to include CPP source output. - Modified FGatherConvertedClassDependencies::DependenciesForHeader() to switch UDS property dependencies to be forward declarations rather than includes (for default value init code). - Modified FEmitDefaultValueHelper::GenerateGetDefaultValue() to emit implementation details to the 'Body' container, and adjust the header content to be a declaration only. - Modified FIncludeHeaderHelper::EmitInner() to exclude a potentially-redundant line for the module's .h file, for the case when the caller has included the base filename in the 'AlreadyIncluded' set. - Modified FEmitterLocalContext::FindGloballyMappedObject() to limit the 'TryUsedAssetsList' path to UClass conversions only (since that requires a UDynamicClass target to work). - Modified FGatherConvertedClassDependencies::DependenciesForHeader() to only include BPGC fields if they are also being converted. Eliminates an issue with missing header files in generated code. Change 3424359 on 2017/05/04 by Ben.Zeigler Fix issue where StreamableManager would break when requesting an async load that failed the first time. Because our game supports downloading assets during gameplay it's not safe to assume it will never load again. Port of CL #3424159 Change 3424367 on 2017/05/04 by Ben.Zeigler Fix some asset manager warnings to not go off in invalid cases Change 3425270 on 2017/05/05 by Marc.Audy Pack booleans/enums in UEdGraphNode and FOptionalPinFromProperty #rnx Change 3425696 on 2017/05/05 by Ben.Zeigler #jira UE-44672 Fix it so select node option pins get populated with default values properly #jira UE-43927 Fix it so select node opion pin type is correctly maintained accross node recreation, as opposed to deriving from the attached pins #jira UE-44675 Fix it to correctly refresh select node when switching from bool to integer index Change 3425833 on 2017/05/05 by Ben.Zeigler #jira UE-31749 Fix it so Undo works properly when modifying a local variable #jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value Change 3425890 on 2017/05/05 by Marc.Audy Fix Copy/Paste of child actor components losing the template #jira UE-44566 Change 3425947 on 2017/05/05 by Ben.Zeigler This was meant to be part of last checkin Change 3425959 on 2017/05/05 by Ben.Zeigler #jira UE-44692 Fix it so only the sequentially last node can be removed from a Switch On Int, and for Switch On Name stop it from removing an exec pin if it's the only non-default one Change 3425979 on 2017/05/05 by Dan.Oconnor PVS fix Change 3425985 on 2017/05/05 by Phillip.Kavan Fix an uninitialized variable. #rnx Change 3426043 on 2017/05/05 by Ben.Zeigler #jira UE-35583 Correctly refresh array node UI when connecting pins that change it away from wildcard Change 3426174 on 2017/05/05 by Zak.Middleton #ue4 - Avoid call to virtual getSimulationFilterData() to only use it when needed in PreFilter if we actually have items in the IgnoreComponents list (which is rare). The sim filter data 'word2' stores the component ID. Change 3426621 on 2017/05/05 by Phillip.Kavan #jira UE-44708 - Fix an issue that re-introduced component data loss in a non-nativized child Blueprint class with a nativized parent Blueprint class. Change summary: - Removed an unnecessary additional check I had for the presence of "-NativizeAssets" switch on the command line in UBlueprint::BeginCacheForCookedPlatformData(). This check was failing because the usage was recently changed to include an optional value. It was not needed anyway so I just removed it. #rnx Change 3426906 on 2017/05/05 by Ben.Zeigler #jira UE-11189 Fix function/macro input default values to show as a pin customization instead of as a broken text box that doesn't work correctly for most types. This fixes enums and provide validation for other types Types that don't have a customization (most structs) will now show any more, they did not work before either #jira UE-21754 Hide function default values if pass by reference is set Fix it so changing input parameter will also reset default value, to avoid having the wrong type value set and to work the same as local variables Change 3426941 on 2017/05/05 by Dan.Oconnor Fix determinstic cooking of LoadAssetClass nodes in macros Change 3427021 on 2017/05/05 by Dan.Oconnor Build fix, make initialization order in source match artifact #rnx Change 3427135 on 2017/05/05 by Phillip.Kavan #jira UE-44702 - Restore code-based interface classes to Blueprint editor UI. Change summary: - Partially backed out CL# 3348513 to return to previous behavior for 4.16. The UI is no longer filtering on the __is_abstract() type trait for interface classes. - Modified FNativeClassHeaderGenerator::ExportClassFromSourceFileInner() to emit the _getUObject() declaration for native interface types as a default implementation that returns NULL rather than as a pure virtual declaration. #rnx Change 3427144 on 2017/05/06 by Marc.Audy Fix init order #rnx Change 3427146 on 2017/05/06 by Marc.Audy remove stray semicolon #rnx Change 3427242 on 2017/05/06 by Phillip.Kavan #jira UE-44744 - Fix a regression in which a UMG Widget Blueprint property not explicitly marked as a variable would cause Blueprint nativization to fail at package time. Change summary: - Modified FWidgetBlueprintCompiler::CreateClassVariablesFromBlueprint() to only add 'Category' metadata when we set the 'CPF_BlueprintVisible' flag on the UProperty, which in is now tied to whether or not the property has been explcitly marked as a variable. This avoids a UHT warning when compiling the nativized codegen that would cause packaging to fail. #rnx Change 3427720 on 2017/05/08 by Dan.Oconnor Backing out 3419202 #rnx Change 3427725 on 2017/05/08 by Dan.Oconnor SA fix #rnx Change 3427734 on 2017/05/08 by Dan.Oconnor More exhaustive GEditor null checks, to appease SA #rnx Change 3427882 on 2017/05/08 by Marc.Audy Properly order all booleans in intialization #rnx Change 3428049 on 2017/05/08 by Marc.Audy Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3427804 #rnx Change 3428523 on 2017/05/08 by Ben.Zeigler #jira UE-44781 Refresh function input UI when blueprint graph refreshes, needed as pins may have gone away Change 3428563 on 2017/05/08 by Ben.Zeigler #jira UE-44783 If setting a hard reference pin type from a string, load the referenced object. Change 3428595 on 2017/05/08 by Dan.Oconnor Avoid node reconstruction when we're compiling a blueprint with no linker (e.g., a duplicated blueprint) #jira UE-44777 Change 3428599 on 2017/05/08 by Ben.Zeigler #jira UE-44789 Fix string asset renamer to not mark IsPersistent becuase that crashes in lightmap code, change it so the path fixup doesn't require the persistent flag Change 3428609 on 2017/05/08 by Dan.Oconnor Improved fix for UE-44777 #jira UE-44777 #rnx Change 3429176 on 2017/05/08 by Phillip.Kavan #jira UE-44755 - Fix nativization build errors when packaging a game project that is not IWYU-compliant for a build target that disables PCH files. - Mirrored from //UE4/Release-4.16 (CL# 3429030). #rnx Change 3429198 on 2017/05/08 by Phillip.Kavan CIS fix. #rnx Change 3429583 on 2017/05/08 by Ben.Zeigler Fix SGraphPinClass to work properly after my changes to allow unloaded assets. For Class pins we need to store separate Runtime and Editor asset data objects, as one has _C and refers to the class, and the other doesn't and refers to the blueprint. The content browser wants the editor path, the pin defaults want the runtime path. Change default value widgets to look more like properties widgets by forcing them to act as highlighted and disabling black background Change 3429640 on 2017/05/08 by Marc.Audy Fix issues with select nodes in macros connected to wildcard pins. #jira UE-44799 #rnx Change 3429890 on 2017/05/08 by Ben.Zeigler Fix function/macro defaults to properly propagate when changed using the new edit UI Refactor some code out of the details customization into the k2 schema Disable defaults UI for object/class/interface hard references as it is disabled in KismetCompiler Change 3429947 on 2017/05/08 by Michael.Noland Core: Backing out CL# 3394352 (marking FDateTime and FTimespan nonexport member Tick with UPROPERTY()), which will re-break UE-39921 but fix UE-44418 There appears to be a more serious underlying issue with how the CDO is instanced which needs to be addressed #jira UE-44418 #reimplementing 3411681 from Release 4.16 Change 3429987 on 2017/05/08 by Ben.Zeigler #jira UE-44798 Do a better job of validating object paths saved as default values, due to an old bug with local variables some object paths are saved as struct exportext At load time clear invalid default value for local variables Add IsValidObjectPath to FPackageName that validates the passed in path would be valid to load with LoadObject Change 3430392 on 2017/05/09 by Marc.Audy Fix SA CIS error #rnx Change 3430747 on 2017/05/09 by Ben.Zeigler #jira UE-44836 Don't reconstruct node during callback for param value changing, this can happen during a reconstruction and recursive reconstruction is unsafe Don't call ModifyUserDefinedPinDefaultValue unless the default value has actually changed Change 3431027 on 2017/05/09 by Marc.Audy Fix BPRW mark up causing Ocean warnings #rnx Change 3431353 on 2017/05/09 by Marc.Audy Fix UHT error due to exposing FJsonObjectWrapper to blueprints #rnx [CL 3431398 by Marc Audy in Main branch]
2017-05-09 17:15:32 -04:00
// With dedicated server, the client connects to local host to load a map, unless client parameters are already specified
if (String.IsNullOrEmpty(Params.ClientCommandline))
{
if (!String.IsNullOrEmpty(Params.ServerDeviceAddress))
{
Params.ClientCommandline = Params.ServerDeviceAddress;
}
else
{
Params.ClientCommandline = "127.0.0.1";
}
}
}
else
{
throw new AutomationException("Failed to run, server target platform not specified");
}
}
else if (Params.FileServer && !Params.SkipServer)
{
ServerProcess = RunFileServer(Params, ServerLogFile, Params.RunCommandline);
}
if (ServerProcess != null)
{
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 4285612) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3836829 by Ben.Marsh UBT: Fix ability to precompile plugins from installed engine builds. Change 3839519 by Ben.Marsh UBT: Simplify configuring bPrecompile and bUsePrecompile settings for modules. Each rules assembly can now be configured as installed, which defaults the module rules it creates to use precompiled data. Change 4042043 by Steve.Robb GitHub #4705 : Added weak lambda's for delegates and multicast delegates. Change 4042056 by Robert.Manuszewski Optimized Mark Phase of GC by up to 10ms by making it run in parallel and removing a huge array presize which we didn't need. Change 4042104 by Robert.Manuszewski Set the minimum GC cluster size to 5 so that GC doesn't have to process micro clusters which are more expensive than processing individual objects + Exposed the minimum cluster size to ini and project settings as gc.MinGCClusterSize + Added the ability to sort clusters by name/object count/mutable object count/referenced clusters count when dumping them with gc.ListClusters command Change 4042377 by Robert.Manuszewski Reworked how GC and other threads (ALT specifically) interact - GC will now notify the ALT it wants to run and ALT will immediately try to finish its current work to allow that. Also the entire ALT tick is now protected against GC running at the same time to improve ALT stability. + added gc.ForceCollectGarbageEveryFrame console variable that triggers a forced GC every frame Change 4042427 by Robert.Manuszewski Changed FGCCSyncObject to use events when waiting for GC to finish so that it doesn't spin on non-game threads when GC is running Change 4042482 by Robert.Manuszewski Unhashing unreachable objects (ConditionalBeginDestroy) will now also be done incrementally, just like the purge phase of Garbage Collection Change 4042635 by Robert.Manuszewski Fix for a potential assert when incremental purge garbage is pending and something forces a full purge Change 4044092 by Steve.Robb Fix for forward declared CoreUObject weakobject types in delegates when building in Clang. Change 4044102 by Robert.Manuszewski Fix for a possible hang when worker threads are preventing GC from running and something is later trying to FlushAsyncLoading with the Async Loading Thread enabled Change 4044113 by Steve.Robb Another Clang fix. Change 4044160 by Robert.Manuszewski Disregard For GC pool will now be enabled by default in cooked builds Change 4044287 by Steve.Robb Typo fix. Change 4047723 by Graeme.Thornton TBA: Fixes for import/export name cache and object resolving Change 4048015 by Graeme.Thornton TBA: Weak/Soft/Lazy pointer serialization changes * Remove FWeakObjectPtr::Serialize, move it's logic into, and replace usages of with calls to, FArchiveUObject::SerializeWeakObjectPtr(). Ensures that something is always sent to the archive so that structured archives can be kept happy in the future. * Added Weak/Soft/Lazy pointer handling to the structured archive slot interface and all the formatters. Binary formatters just forward the call onto their inner and text archives store as a string path reference. * FArchiveUObjectFromStructuredArchive caches all these pointer types and stores indices in the binary block, same as with a UObject*. All pointers are then forwarded to the underlying formatter in one go on finalization. Change 4048021 by Steve.Robb Fix for binding an unbound TFunction to another TFunction with a different signature. Also all null pointers now count as unbindings, not just nullptr. TIsMemberPointer added. TIsATFunction and TIsATFunctionRef renamed to remove the 'A's. Change 4048544 by Robert.Manuszewski Fixing ConditionalBeginDestroy profiling after changes to incremental CBD. Change 4051028 by Graeme.Thornton TBA: ArchiveFromStructuredArchive adapter uses Inner to determine if it is outputting to text, and sets it's own ArIsTextFormat to false Change 4051056 by Graeme.Thornton TBA: High level tagged property / UObject base class text serialization - UObject serialize converted to structured archive - Properties written to text individually with text tags, and then binary adapted values - Only saves, doesn't load Change 4051111 by Graeme.Thornton TBA: Temporarily disable loading of text assets until tagged property serialization path is fixed up Change 4051154 by Graeme.Thornton TBA: Convert a few uobject serializers to structured archive format for example purposes Change 4051181 by Graeme.Thornton TBA: Added default structured archive implementation of SerializeItem to UProperty, which just calls the FArchive version on an FArchiveUObjectFromStructuredArchive adapter. Implemented structured archive SerializeItem for UArrayProperty Change 4051197 by Graeme.Thornton TBA: ObjectProperty text serialization Change 4051216 by Graeme.Thornton Restored a modified FWeakObjectPtr::Serialize function to keep backwards compatibility in code I don't have access to. Change 4051261 by Graeme.Thornton TBA: Convert UMetaData to structured archive Change 4051374 by Steve.Robb Incorrect assert removed. Change 4051562 by Robert.Manuszewski Adding stats for the new GC internal functions Change 4051614 by Graeme.Thornton TBA: Removed UProperty::SerializeItem(FArchive, ...) and replaced with UProperty::SerializeItem(FStructuredArchive::FSlot, ...). Fixed up most of them to work properly and added adapters in for any that were non-trivial. Change 4052512 by Graeme.Thornton TBA: Temporary workaround for softobjectptr and lazyobjectptr uproperties not serialization anything when they know the archive is a reference collector. They should always be serializing their pointers and letting the underlying archive itself ignore them. Change 4053917 by Robert.Manuszewski Clustered objects from clusters that are no longer reachable will now be marked as unreachable immediately when gathering unreachable objects Change 4053919 by Robert.Manuszewski Added the ability to disable incremental BeginDestroy in ini/project settings Change 4055518 by Daniel.Lamb Fixup for deterministic audio generation issue. Submitted on behalf of Rich.Whitehouse #jira nojira #test prefilght automated test. Change 4056854 by Graeme.Thornton TBA: Added a test asset to EngineTest which contains all the different property types and test cases. Change 4056858 by Graeme.Thornton TBA: Updated USetProperty to proper structured archive usage Change 4056872 by Graeme.Thornton TBA: Add map property field to test object Change 4056873 by Graeme.Thornton TBA: Convert UMapProperty to full structured archive Change 4056994 by Graeme.Thornton TBA: Converted FText over to structured archive. Implemented saving, but not loading. Change 4059728 by Ben.Marsh UBT: Add support for using adaptive non-unity builds when the engine and project are in separate repositories. Change 4059805 by Graeme.Thornton Fixed typo in text serialization. Fixes CIS automation test errors Change 4060007 by Graeme.Thornton TBA: FArchiveFromStructuredArchive will now access it's host slot lazily, i.e. only when a value is actually written to the archive. Change 4060092 by Stefan.Boberg Added optimized Windows console window output path to GenericConsoleOutput since this slowed down cooking considerably (2 minutes spent in wprintf alone for one large dataset) When stdout is attached to a console we use the WriteConsoleW function instead of wprintf since the latter is very slow especially in unbuffered mode which the engine currently configures for stdout (see setvbuf call in LaunchEngineLoop.cpp). At some point we should reconsider this buffering policy since it's likely to slow down other platforms as well but I wanted to do a safe change for now as I don't yet fully understand why the setvbuf call is there in the first place. Change 4060108 by Stefan.Boberg Introduced some additional target platform utilities to help with asset cook optimizations * We now assign each ITargetPlatform a zero-based ordinal value * Introduced FTargetPlatform and FTargetPlatformSet types to help store platform references and platform sets efficiently. These are not currently used in the engine but are designed to replace the existing ITargetPlatform/string/FName representations in the cooking data structures. Change 4060143 by Graeme.Thornton Undo //UE4/Dev-Core/Engine/Source/Runtime/... changelist 4060007 Needs some other changes that I haven't checked in yet... Change 4062432 by Ben.Marsh Fix error message when enumerating P4 changes. Change 4062648 by Ben.Marsh Add missing p4 integration action. Change 4063620 by Graeme.Thornton Integrated a fix from UDN where the engine would crash when trying to load a very small encrypted file (<16bytes) from a pak file, where the read address wasn't already aligned to the AES block size. (https://udn.unrealengine.com/questions/431989/crash-while-reading-a-very-small-file-in-encrypted.html) Change 4066963 by Robert.Manuszewski Fixing GC cluster verification code reporting false positives when a cluster is referencing another cluster through 'mutable' objects list. Change 4067133 by Robert.Manuszewski Changed log verbosity when reporting individual cases of GC cluster assumption violations as they are followed by an asser anyway and this way we get the chance to see all issues before we assert at the end of these checks. Change 4067443 by Steve.Robb FString can now be constructed from any char pointer type and length. Change 4068156 by Steve.Robb Fix necessary because of FString constructor change in CL# 4067443. Change 4070258 by Graeme.Thornton Fixes for VSCode Change 4070372 by Graeme.Thornton TBA: Script struct serialization to structured archives Change 4071913 by Ben.Marsh Move bulk of the code for UnrealPak into an engine developer module, so it can be used in the editor. Change 4071914 by Ben.Marsh Missing files. Change 4071937 by Ben.Marsh Missing header. Change 4072015 by Ben.Marsh Fixes for compiling PakFileUtilities as part of the editor. Change 4072826 by Steve.Robb TBitArray::Reserve() added. TBitArray::Add() overloaded to allow adding multiple bits. TSparseArray::Reserve() optimized to call the overloaded Add(). Change 4073271 by Daniel.Lamb Fixed add patch tier in project launcher passing the wrong commandline option to UAT. #test none Change 4074708 by James.Hopkin #core Removed redundant Casts Change 4074763 by Steve.Robb Fix for TSparseArray::Reserve() size. Change 4076063 by Ben.Marsh Add an "UnrealPak" commandlet with the same functionality as the standalone UnrealPak program. Invoke by running the editor with -run=UnrealPak and the standard UnrealPak commandline options. Change 4077064 by Robert.Manuszewski Fixing compile error in PakFileUtilities Change 4077144 by Graeme.Thornton TBA: TextAssetCommandlet improvements * Collect lists of broken assets during roundtrip tests and print a summary of packages that failed each phase at the end * After resaving as text, load the file back as a plain JSON hierarchy to ensure the output was valid Change 4077412 by Ben.Marsh Set the correct exit code for UnrealPak. Should return 0 on success, not 1. Change 4077760 by Graeme.Thornton TBA: Loading fixed for tagged property serialization Includes conversion of all UProperty::ConvertFromType() and SerializeFromMismatchedTag() functions to use structured archives Lazy initialization of FArchiveFromStructruredArchive when loading, to support the possibility of an adapter being create around an object property serialize call to its inner UStruct, which then decides not to do anything and return false. Stops the ArchiveFromStructuredArchive from consuming the slot and getting upset later on when we try to serialize normal tagged properties from it. Disabled lazy bulk data loading from text assets. Requires a bigger change to make it work. Added some debug checks to json input formatter which track the current value stack size when a new object is pushed onto the stack, and makes sure that the stack has returned to the same size when the object is popped. Catches cases where we unpack an array/stream to the value stack but then don't consume all the items. Change 4078800 by Ben.Marsh Change UAT to using the editor's UnrealPak commandlet rather than invoking the standalone UnrealPak executable. To improve performance when building several PAK files, also add a new -batch=<file> command which reads commands to execute in parallel from a text file. Change 4079745 by Graeme.Thornton TBA: Migrated a couple of UObject Serialize functions to FStructuredArchive (SoundCue / MaterialExpressions / Editor strip flags) Change 4079847 by Graeme.Thornton TBA: Add 'FindMismatchedSerializers' mode to text asset commandlet, which dumps out a list of all UClasses which don't have the CLASS_MatchedSerializers flag, meaning we can't guarantee the have Serialize functions for FArchive AND FStructuredArchive, therefore we can't use the new structured archive based serialize path. Should only ever be native instrinsic classes as UHT takes care of all other cases. Change 4079925 by Ben.Marsh Fix incorrect assignment when deriving name for chunked pak file. Change 4080214 by Ben.Marsh Move the ThreadPoolWorkQueue class into DotNETUtilities so it can be used by other projects. Change 4082394 by Graeme.Thornton CIS fix for variable shadowing warning Change 4082583 by Ben.Marsh Add a IBinarySerializable interface for types that support reading from a BinaryReader and writing to a BinaryWriter. Implementing IBinarySerializable implies a constructor taking a BinaryReader argument is available for deserializing. Change 4082652 by Ben.Marsh Fix FileReference.Directory not returning a directory with a trailing backslash for files in the root directory. Change 4082755 by Graeme.Thornton Fixed an erroneous usage of TUniquePtr<uint8>as a pointer to a uint8 array when creating pak files. Caused a crash when compression was enabled, and has probably surfaced because pak generation is now done by an editor commandlet rather than a standalone program. Change 4082756 by Graeme.Thornton Fixed some incorrect documentation for pakfile compressed chunk headers Change 4082883 by Graeme.Thornton Static analysis warning fix Change 4082912 by Ben.Marsh Move ExceptionUtils into DotNETUtilities. Change 4085291 by Graeme.Thornton TBA: In the Json output formatter, write float and double values out with enough precision for successful roundtripping. Added some debug only code which will immediately reconvert the string back to its original value and compare the the input Change 4085523 by Graeme.Thornton TBA: Remove only explicit usage of DECLARE_FSTRUCTUREDARCHIVE_SERIALIZER. Should only be used from UHT generated code. Change 4086037 by Robert.Manuszewski Fix for a potential race condition when two threads want to acquire GC lock Change 4088655 by Graeme.Thornton Pak creation now uses the bEnablePakSigning setting from the crypto config json file Change 4091474 by Steve.Robb Fix for TStaticBitArray::FindFirstSetBit() and TStaticBitArray::FindFirstClearBit(). Unused variables removed. Change 4093632 by Steve.Robb CIS fixes. Change 4093656 by Graeme.Thornton Build fix Change 4093744 by Ben.Marsh Allow per-chunk settings for whether to enable compression in UnrealPak. Change 4099712 by Gil.Gribb UE4 - Fixed rare case where insufficient space was preallocated for cooldown ticks. #jira UE-59686 Change 4099912 by Stefan.Boberg Cooking timer optimizations: - Replaced data structures for FScopeTimer and FHierarchicalTimerInfo. Previous implementation used FString for many things and caused *lots* of heap and string concatenation activity. Replaced with a compile-time node id (using __COUNTER__) and raw string literals. - Removed PERPACKAGE_TIMER support (was disabled by default and was difficult to test) - Made it possible to toggle OUTPUT_TIMING and ENABLE_COOK_STATS independently - Removed some extremely tight timers because the overhead from calling QPC significantly exceeded the measured code This change shaved some 15% off a clean cook of Fortnite WindowsClient (en) with fully populated local DDC Change 4100519 by Stefan.Boberg Quick fix for Linux build issue introduced in 4099927 Change 4105327 by Stefan.Boberg Cooker: Changed FHierarchicalTimerInfo so it uses a linked list for tracking child nodes, to be able to deal with any child count. Previously we assumed there would never be more than 9 children but it turns out there are cooker modes that need more. Fixes check when using -FullLoadAndSave to cook Change 4105448 by Stefan.Boberg - Fixed Linux build warning re: member initialization order - Also eliminated OUTPUT_HIERARCHYTIMERS/CLEAR_HIEARCHYTIMERS macros (plain functions are fine) - Moved finishing-up code for FullLoadAndSave() to TickCookOnTheSide() call site to improve timer output. Previously some of the scopes would not have been closed before printing and thus the output was misleading. Change 4109031 by Ben.Marsh Attribute-driven Perforce wrapper (old Epic Friday project). Offers a more complete implementation than the current P4 wrapper in UAT without requiring any platform-specific libraries. Uses the Python binary output for parsing. Change 4109588 by Ben.Marsh UBT: Add extension methods for serializing a nullable type to a BinaryReader/BinaryWriter. Change 4109595 by Ben.Marsh Missing project file for DotNETUtilities. Change 4110724 by Stefan.Boberg Removed annotation map locking in UObjectMarks, eliminating around one minute (~3.5%) from Fortnite cook time. The locking was redundant since the annotation maps are managed per thread anyway. Change 4111304 by Ben.Marsh UAT: Add support for setting a status message through the log class. Allows writing transient messages (eg. progress messages) which will be cleared out before writing other messages. Best used through the LogStatusScope class, which can set a status message for the duration of a using() block. As part of this change, the console no longer has to be added as a dedicated trace listener. Since we already special-case this listener when formatting log output, it's easier to just keep the implementation separate to the other trace listeners. Change 4112708 by Steve.Robb Fix for TBitArray::MaxBits in assignment. Change 4114133 by Stefan.Boberg Tweaked how low-level memory (LLM) tracker is implemented to reduce overheads. Previously FMemory functions would acquire the LLM singleton and call OnLowLevelFree/OnLowLevelAlloc etc which would check the bIsDisabled flag and early out if it was set. Due to how frequently these functions were called this ended up costing quite a bit. - This change makes the flag a static member variable instead of a member variable and therefore enables a simpler early-out to be implemented. - The singleton getter is also simplified to avoid hitting the threadsafe singleton construction path on every call. - The enable flag is no longer TAtomic - this also incurs extra overhead for no clear benefit Shaves approximately 3.5% (one minute) off a Fortnite cook test scenario (using -FullLoadAndSave) Change 4115010 by Robert.Manuszewski Fixing CIS Change 4115249 by Robert.Manuszewski Fixing async loading code asserts when exiting game very early due to an error #jira UE-56267 Change 4117091 by Ben.Marsh Prevent doubled-up lines when writing status updates with console log verbosity. Change 4117207 by Ben.Marsh UGS: Do not include executables in diagnostics zip file, and ignore "no such files" error when cleaning workspace. Change 4119175 by Ben.Marsh UGS: Fix crash writing version files when directory does not already exist. Change 4119987 by Ben.Marsh UGS: Show a dialog box while the launcher is updating executables from Perforce, which allows cancelling the operation if necessary. Allow setting the username on the settings window, and prompt for login credentials if necessary. Should prevent situations where users have to update settings from the command prompt. Holding down shift during launch now shows the settings dialog rather than an immediate prompt to launch the unstable version (unstable version is shown as a checkbox on this dialog). Change 4119991 by Ben.Marsh Update version number for UGS launcher to 1.13. Change 4121943 by Robert.Manuszewski Don't use FArchiveAsync2 for reading packages with non-async path in editor builds as its performance is worse than the standard archive's (saves about 1 minute when doing larger cooks and 7 seconds when loading into PIE) Change 4122592 by Steve.Robb GitHub #4762 : Improve wording and grammar of Math comments Also includes improved accuracy in FMath::ComputeBoundingSphereForCone(). Change 4122819 by Stefan.Boberg Don't call CreateDirectory redundantly when opening files for writing using FFileManagerGeneric::CreateFileWriter This change avoids calling IPlatformFile::CreateDirectoryTree if possible since this is a very expensive function especially for deep hierarchies as it performs directory creation from the root directory onwards instead of from the leaf downwards. That function should also be fixed but this change improves performance in the meantime. Change 4122872 by Stefan.Boberg CreateDirectoryTree now creates directories leaf-to-root instead of the other way around. This is much more efficient since we don't spend time on system API calls for directories which already exist. This accounted for a very large amount of CPU time in cooking as the full target file directory hierarchy would be "created" for every single output file. Change 4123109 by Stefan.Boberg - Disable overlapped I/O in editor / cooker. Synchronous I/O reduces the number of syscalls and Windows performs prefetching on our behalf anyway for sequential reads - Eliminated syscall which was issued for every write to update cached file size -- since we're the only writers to the file (file access allows read sharing at most) we can authoritatively update the file size on write completion Change 4123455 by Ben.Marsh PR #4775: New build param PCHMemoryAllocationFactor to set /Zm VS build param. (Contributed by lucaswall) Change 4124207 by Ben.Marsh UBT: Remove some unnecessary indirection for generated code paths. Change 4124217 by Ben.Marsh UBT: Remove another unused variable from UEBuildModuleCPP. Change 4124377 by Stefan.Boberg In IPlatformFile::DeleteDirectoryRecursively, attempt to delete file first and if it fails clear the readonly flag and try again Previously there was a call to clear the readonly flag for every deleted file and this is a waste of resources 99% of the time. The SetFileAttributes call accounted for a significant amount of time during cooker sandbox directory deletion Change 4125071 by Stefan.Boberg Some tweaks to FQueuedThreadPoolBase scheduling and memory management - Explicitly pass in false for TArray::RemoveAt(..., bool bAllowShrinking) argument to prevent memory reallocation when arrays are drained and inevitably repopulated shortly afterwards - Use a MRU strategy instead of LRU when picking a thread to wake up. The MRU thread is the most likely to have a 'hot' cache for the stack etc. Picking from the back of the array also happens to be cheaper since no memory movement is necessary when RemoveAt is called. (This was the strategy in place before CL2600362 which seems to have changed it unintentionally) - Release lock as soon as a thread has been chosen, before asking the worker thread to wake up and do the work Change 4126132 by Ben.Marsh UAT: Detect when stdout is redirected and prevent using backspace characters to move the cursor. Change 4126867 by Graeme.Thornton TBA: Fix tagged binary formatter Change 4127010 by Robert.Manuszewski AnimScriptInstances created at runtime will now also be added to the owning omponent's cluster to avoid GC issues. Change 4127932 by Ben.Marsh WorkspaceTool: Reduce unnecessary logging of status messages when console output is not redirected. Change 4129050 by Ben.Marsh UGS: Check for NET Framework 4.5 being installed before running the installer. Also fix warning trying to kill existing UGS instances before upgrade. Change 4129459 by Graeme.Thornton TBA: TextAssetCommandlet - When outputting converted assets to an output path, replicate the workspace relative path in the output directory Change 4129515 by Graeme.Thornton TBA: Add EnterRecord overload that allows outputting of available field names when loading. Change 4129517 by Graeme.Thornton TBA: Tagged properties are written out as named fields on the "Properties" record, rather than as a stream with a null tag at the end Change 4129518 by Graeme.Thornton TBA: Added a local const bool to allow easy hacking out of text asset loading support Change 4129558 by Graeme.Thornton TBA: Build fix for textasset-less configs Change 4129614 by Ben.Marsh UGS: Main window is now restored to normal size when activated by clicking on the tray icon. #jira UE-60490 Change 4129618 by Ben.Marsh UGS: Speculative fix for unreproduced exception accessing disposed window while shutting down. Change 4131936 by Robert.Manuszewski Removing some WIP code accidentally checked in with CL #4121943 Change 4133490 by Ben.Marsh UGS: Allow the $(Change) variable to be used in more places than just the context menu. #jira UE-60573 Change 4133550 by Ben.Marsh UGS: Setting for whether or not to use incremental builds is now exposed through the variable "$(UseIncrementalBuilds)" for use by custom build steps. #jira UE-60554 Change 4133681 by Ben.Marsh UGS: A per-project list of folders and extensions to be deleted by default when running the 'clean workspace' tool can now be specified through the <ProjectDir>/Build/UnrealGameSync.ini file. Settings may be specified for an individual branch (via a category with the depot path to the project) or for wherever the project is currently open (via the [Default] category). The SafeToDeleteFolders list specifies a substring that will be checked against folder paths. Anything containing this folder will be marked as safe for delete by default. The SafeToDeleteExtensions list specifies a list of extensions for files that can always be deleted. Example: [Default] +SafeToDeleteFolders=/MyGame/Test/ +SafeToDeleteFolders=/DataService/ +SafeToDeleteExtensions=.xx1 +SafeToDeleteExtensions=.xx2 #jira UE-60575 Change 4135449 by Ben.Marsh Fix allowing use of Job objects on Windows platforms (debug code submitted by mistake) Change 4135730 by Ben.Marsh UBT: Plugins can now be enabled and disabled from the .target.cs file (for targets that do not use the shared compile environment), by compiling the list of enabled/disabled plugin names into the Projects module. Change 4135823 by Ben.Marsh UBT: Remove legacy code to handle disabling optional plugins; now that this is compiled into the target, it will work for any plugins we choose. Change 4135945 by Ben.Marsh UBT: Fix error running programs with no explicitly enabled or disabled plugins. Change 4137207 by Ben.Marsh UGS: Align all badges with the same name, to make it easier to see which CIS steps are being run. Allow overriding the slot taken by a particular badge by calling it "SlotName:LabelName". Change 4137311 by Stefan.Boberg Removed child cooker support. In practice it is not a useful feature as it provides no performance improvement (quite the opposite in fact) and adds testing and maintenance complexity. Change 4137393 by Ben.Marsh UGS: Fix display of multiline errors in the status panel. Change 4141708 by Steve.Robb GitHub #3631 : Incorrect default argument in WeakObjectPtrTemplate #jira UE-45490 Change 4146655 by Stefan.Boberg Removed FullGCAssetClasses logic - no longer necessary nor useful Change 4147318 by Ben.Marsh UGS: Compress build badges in a column if it shrinks below the size that they would be visible. Change 4148207 by Ben.Marsh UGS: Added support for showing the latest completed build from a specific list of badges in the status panel. To declare a badge as one that should appear in the status panel rather than the CIS column, add it to the project's UnrealGameSync.ini in the project or [Default] section like so: +ServiceBadges=RoboMerge Change 4148282 by Stefan.Boberg Fixed bug in UCookOnTheFlyServer::GetCookOnTheFlyUnsolicitedFiles - UnsolicitedFiles should be passed by reference not by value Change 4148344 by Stefan.Boberg Fixed minor indentation error (most likely caused by sloppy merge) Change 4148521 by Stefan.Boberg Removed accidentally checked in PRAGMA_DISABLE_OPTIMIZATION from CookOnTheFlyServer.cpp Change 4148639 by Ben.Marsh UGS: Fix tooltips not showing for changes that have description badges. Change 4149373 by Ben.Marsh UGS: Allow adding additional columns to display particular badges by adding entries from the project config file. Example syntax: +Columns=(Name="Desktop",MinWidth=50,DesiredWidth=100,Weight=3,Badges="Editor") +Columns=(Name="Mobile",MinWidth=50,DesiredWidth=100,Weight=3,Badges="IOS,Android") Same form can be used to control how default columns are displayed (though badge settings are ignored). Also allow PerforceMonitor to detect local changes to project config files and update settings automatically. Change 4149399 by Ben.Marsh UGS: Update version to 1.143. Change 4155660 by Steve.Robb PROJECTION and PROJECTION_MEMBER macros which provide the correct behavior when creating projections using functions which are overloaded or use default arguments. Change 4157117 by Ben.Marsh Fix warning due to plugins disabled in .target.cs file. Change 4158011 by Ben.Marsh UBT: Add a check that the UnrealHeaderTool target file exists, rather than throwing an exception when reading it fails. Change 4158646 by Ben.Marsh UGS: Fix exception when login is discovered to have expired during a workspace update. Change 4158678 by Ben.Marsh UGS: Fix an exception on shutdown due to the icon being hidden after it's already been disposed. Change 4158683 by Ben.Marsh UGS: Add an unhandled exception filter which sends the exception data to the backend. Change 4159131 by Ben.Marsh UGS: Reduce the number of characters displayed for build badges based on the available space. Change 4159194 by Graeme.Thornton TBA: Fix incorrect map property conversion code when converting an old property that contains a map with different key/value types Change 4159239 by Steve.Robb Improved readability and compliance with coding standards. Change 4159246 by Ben.Marsh UGS: Allow syncing projects where source code is not available (and various version files don't exist). #jira UE-60985 Change 4159286 by Ben.Marsh UGS: Remove requirement for UE4Editor.target.cs to be visible in the depot in order to open a project. #jira UE-60986 Change 4159302 by Ben.Marsh UGS: Update version to 1.144. Change 4160308 by Ben.Marsh All staging client executables for blueprint projects. #jira UE-60983 Change 4161567 by Steve.Robb GitHub #4816 : UE-60771: Handle escaped double quote in FParse::LineExtended Change 4162641 by Ben.Marsh UGS: Allow customizing the position of custom columns, via the Index=N attribute. Change 4162647 by Ben.Marsh UGS: Update version to 1.145. Change 4165319 by Robert.Manuszewski PR #4812: Fix inconsistent command-line argument handling under Windows (Contributed by adamrehn) Change 4166150 by Ben.Marsh UGS: Include *.inl when looking for code changes. Change 4166551 by Steve.Robb Whitespace fixes caused by a bad merge. Change 4168483 by Ben.Marsh UGS: Add a more useful error if a file to be synced exceeds the max allowed path length. Change 4168490 by Ben.Marsh UGS: Update version to 1.146. Change 4168551 by Ben.Marsh UBT: Move bBuildLargeAddressAwareBinary into an exposed setting. Change 4168560 by Ben.Marsh UBT: Remove static config variable for controlling which configuration of UHT to use. Change 4171296 by Ben.Marsh UGS: Move the check for overlong paths earlier. Change 4171531 by Ben.Marsh UBT: Fix exception if BuildConfiguration.xml contains an unknown category. Change 4183371 by Robert.Manuszewski Fix for a crash in Async Loading Graph's CheckCycles when GC kicks in on the game thread and forces ALT to exit early Change 4184312 by Ben.Marsh UGS: Update version to 1.148 Change 4184480 by Robert.Manuszewski Removing unused async loading stat Change 4186390 by Ben.Marsh UBT: Format XML validation errors in a format that allows double-clicking on the message in Visual Studio. Change 4188644 by Ben.Marsh UBT: Add the MakePathSafeToUseWithCommandLine() function to UBT. Change 4188647 by Ben.Marsh UBT: Fix exception in target receipt when architecture is null. Change 4189617 by Ben.Marsh Change FileSystemReference, FileReference and DirectoryReference objects to use OrdinalIgnoreCase comparisons without creating a separate copy of the string to compare. The filesystem does not use the invariant culture, and it can produce the wrong results in some cases (the ordinal comparison is faster, too). Change 4189740 by Ben.Marsh UAT: Remote code to build UnrealPak when packaging; we use the editor now. Change 4189860 by Ben.Marsh UGS: Make the filter for excluding automated lighting rebuilds more explicit. Change 4190082 by Ben.Marsh Fixes to allow enabling edit and continue for Windows builds. Have experienced quite a few VS crashes when testing it in editor; not yet recommended for general use. - Allow edit and continue for any configuration, not just debug. - Fixed PDB errors compiling files that use a shared PCH with edit and continue enabled. Path to the generated PDB file was using the wrong directory. - Removed code that tracks PDB output files, since they're modified multiple times during a build. - Enable debug information when compiling generated CPP files, since it causes errors if the shared PCH PDB doesn't have the same option. - Disable support for remote execution of steps that modify the PDB, since the same file has to be modified many times. Remote execution causes the PDB files to be corrupted. Unfortunately, this makes E&C builds significantly slower. #jira Change 4192949 by Ben.Marsh UBT: Minor tidy-up (merging UEBuildBinary.Build and UEBuildBinary.SetupOutputFiles) Change 4193218 by Ben.Marsh Fix formatting. Change 4197252 by Mike.Erwin UAT: Fix log output w/ correct count of non-code projects. #jira none Change 4197941 by Ben.Marsh UGS: Add support for DebugGame editors that have an executable with a DebugGame suffix. Change 4197964 by Ben.Marsh UGS: Prevent attempts to automatically reopen projects while a modal dialog is up, or the workspace is syncing. Change 4198144 by Ben.Marsh UGS: Prevent modal dialogs when login expires in P4, and prompt for password when hitting "retry". Change 4198413 by Ben.Marsh UGS: Always show the main window when launched manually, and run with -RestoreState when launched at startup. Also add a couple more places that save the visibility state, since logging off seems like it can terminate the process abrubtly. Change 4198779 by Ben.Marsh UBT: Allow generating manifests to any arbitrary locations with the -Manifest=<Path> argument. Change 4198825 by Ben.Marsh UBT: Move code to enumerate Slate runtime dependencies into the Slate module. Doesn't need to be done inside core UBT. Change 4199341 by Ben.Marsh UGS: Update version to 1.149 Change 4199642 by Chad.Garyet - Deprecate CISController - Add BuildController to replace CIS GET/POST for builds - Add LatestController, GET does what CIS/GET used to do - Change Latest/GET to return the last 25 builds filtered by project, rather than the last 5000 individual Ids - Latest/GET now returns "LatestData" object instead of array of longs - Updated EventMonitor to match all API changes - Fixed bug where IDs were getting reset to initial startup values every update loop Change 4199663 by Chad.Garyet CIS controller still needs to return an array of longs #jira none Change 4199680 by Ben.Marsh UGS: Update version to 1.150 Change 4200457 by Ben.Marsh Merging CIS fix for non-development configurations. Change 4200472 by Mike.Erwin UAT: fix -skipbuildclient param default It was defaulting to skipbuildeditor's value, likely a copy-paste error. #jira none Change 4202595 by Ben.Marsh Fix static analysis warning due to constant comparison against macro. Change 4203250 by Ben.Marsh UGS: Always show the "Sync Precompiled Editor" option, but disable it and show a tooltip explaining why if it is not available. Change 4206191 by Ben.Marsh Exclude editor target files from installed builds, since they leak info about DLLs that have been stripped out. Change 4213011 by Ben.Marsh UBT: Include contents of modified intermediate files in the log, to make it easier to debug hidden dependencies. Change 4213487 by Ben.Marsh UBT: Fix assumption that bPrecompile is equivalent to bBuildAllModules. This is no longer the case; they are now controlled by separate options. Should fix CIS errors building the editor. Change 4213609 by Ben.Marsh Ensure that strings formatted using FMicrosoftPlatformString::GetVarArgs() are always null terminated, whether we use the secure CRT or not. Change 4215971 by Ben.Marsh UBT: Remove action graph visualization code; no longer used. Change 4215996 by Ben.Marsh UBT: Remove unqiue id from all actions in the action graph. This is only used for printing debug info in the case of a (rare) cycle in the action graph, so just look it up when needed. Change 4216022 by Ben.Marsh UBT: Rename Crypto.cs to EncryptionAndSigning.cs to match the name of the class inside it, and move it under the System folder. Change 4216031 by Ben.Marsh UBT: Move all the action executors into their own folder in the project. Change 4216526 by Ben.Marsh Fix CIS warnings. Change 4216544 by Ben.Marsh Replace custom code to ensure FMicrosoftPlatformString::GetVarArgs() null terminates its buffer with Microsoft's standards-compliant implementation. Change 4216633 by Ben.Marsh Add support for UnrealPak plugins. * Project and plugin modules can now specify an array of supported programs in the "WhitelistPrograms" field of their module descriptors, to allow modules to be loaded by programs. * Programs can now load any runtime modules, as long as they are whitelisted. * Programs under the engine directory can now use a shared build environment, so that building with a project file does not cause output binaries to be output to the project directory. * UnrealPak is now always built by default when packaging * Convert UnrealPak to a modular configuration Change 4216736 by Ben.Marsh UnrealPak: Move "ExportDependencies" command into an editor commandlet, since it relies on the UObject system, asset registry, etc... Change 4217447 by Ben.Marsh Back out revision 50 from //UE4/Dev-Core/Engine/Build/InstalledEngineBuild.xml Change 4217451 by Ben.Marsh Back out revision 11 from //UE4/Dev-Core/Engine/Plugins/Developer/VisualStudioSourceCodeAccess/Source/VisualStudioSourceCodeAccess/VisualStudioSourceCodeAccess.Build.cs Change 4217617 by Ben.Marsh Back out changelist 4217451 Change 4222552 by Ben.Marsh Don't use #import <TypeLib> for VS source code accessor when building with Clang; it's not supported. Change 4222630 by Ben.Marsh UBT: Fix spam while generating project files if Clang isn't installed. Change 4223316 by Ben.Marsh UBT: Change the order in which Visual C++ toolchains are enumerated to prefer full releases over preview releases. Change 4223318 by Ben.Marsh UBT: Add a build setting which allows creating a dedicated PCH for every file that's excluded from the unity working set (disabled by default). Improves iteration times when working on individual cpp files, but slows down iterating on header changes (and can take a lot of disk space for large changes). Dedicated PCH contains all includes scraped from the top of each cpp file, until a non-#include directive is encountered. Change 4223401 by Ben.Marsh UBT: Add an option to automatically enable edit and continue for files in the adaptive non-unity working set. E&C doesn't seem very useful for UE4 projects right now; compile time is comparable to regular build times, but it can take several minutes to apply code changes for large projects. Change 4223899 by Ben.Marsh UBT: Fix loading XML config files on Mono; Type.GetField(Name) does not seem to return values unless binding flags are specified. Change 4224637 by Ben.Marsh Add a "SupportedPrograms" field to plugin descriptors, which allows plugins to declare which plugins they support independently of individual modules. Programs now respect the "bEnabledByDefault" setting in plugins. Plugins that are compatible with a program now need to list that program in the SupportedPrograms list, and whitelist any modules that should load for that program. Change 4224710 by Ben.Marsh UBT: Don't add import libraries as final build products unless the target is being precompiled. Prevents the need for building them for leaf nodes in the action graph. Change 4224715 by Ben.Marsh UBT: Remove hack to allow Stats2.cpp to not follow IWYU convention. Change 4224726 by Ben.Marsh Remove commented out line. Change 4224903 by Ben.Marsh Fix non-unity compile error in Stats2.h. Change 4225051 by Ben.Marsh Back out changelist 4224710; causing CIS errors due to receipts not matching. Change 4225134 by Ben.Marsh Fixing non-unity errors. Change 4225203 by Ben.Marsh Another non-unity fix. Change 4225249 by Ben.Marsh Fix Linux dependencies being copied for the Windows editor; they can be added as requirements for the Linux target platform on Windows instead, so it respects the user's chosen platforms. #jira UE-62001 Change 4225512 by Ben.Marsh BuildGraph: Allow setting the target to build when using the <CsCompile> task. Change 4228815 by Ben.Marsh UBT: Always add the generated code directory to the list of include paths when generating project files. It may only be created after UHT has been run. Change 4228944 by Ben.Marsh UBT: Remove legacy CppCompileEnvironment and LinkEnvironment wrappers from TargetRules that were deprecated in 4.19. Change 4229028 by Ben.Marsh UBT: Fix editor targets with unique build environment having the wrong executable path in generated project files. Move move logic to configure target rules post-construction by the rules assembly to ensure it's valid. Change 4229065 by Ben.Marsh UBT: Move another target setting into the rules assembly. Change 4229105 by Ben.Marsh Fix BPT exception when generating project files. Change 4229311 by Ben.Marsh UBT: Store the module rules file location on the ModuleRules instance, as well as the plugin that it was created from. Also expose the plugin directory as a property on the ModuleRules instance. Change 4229421 by Ben.Marsh UBT: Consolidate functionality for UHT module setup in ExternalExecution.cs. Change 4229817 by Ben.Marsh UBT: Modules must now explicitly specify the path to the header used to generate a PCH if one is desired, rather than the header being determined automatically by attempting to parse the source code. Now that PCHs are force-included anyway, this removes a lot of dependencies inside UBT. Change 4229824 by Ben.Marsh UBT: Remove unused lists inside UEBuildModuleCPP.SourceFilesClass. Change 4229841 by Ben.Marsh UBT: Remove some legacy code from auto-detecting PCHs. Change 4230521 by Ben.Marsh UBT: Add utility functions to the log class to allow formatting errors and warnings in Visual Studio output format (eg. File(Line): warning: Message) Change 4230871 by Ben.Marsh UAT: Remove StreamUtilis utility class; there is a simpler way to implement the one place it's used. Change 4230882 by Ben.Marsh UAT: Add StreamUtils back into UAT, seems like it's still used there. Change 4230896 by Ben.Marsh UBT: Remove some redundant parameters from UEBuildModule/UEBuildModuleCPP/UEBuildModuleExternal constructors. Change 4231014 by Ben.Marsh WorkspaceTool: Include a dump of raw bytes when garbage is read from the P4 process, for diagnostic purposes. Change 4231032 by Ben.Marsh Fix CIS. Change 4231096 by Ben.Marsh Bump the FlatCPPIncludeDependencyCache version, to prevent errors trying to load old files. Change 4231446 by Ben.Marsh UBT: Added support for expanding UE-specific variables in include paths and library paths: $(EngineDir), $(ProjectDir), $(PluginDir), $(ModuleDir). Change 4231460 by Ben.Marsh Modules may now explicitly specify rpaths on Linux via the PublicRuntimeLibraryPaths and PrivateRuntimeLibraryPaths properties. Change 4233909 by Robert.Manuszewski PR #4779: Reason fails as the supplied variable is incorrect (Contributed by projectgheist) Change 4233910 by Ben.Marsh Enable PCHs on IOS. Reduces build time by ~25%. Change 4234176 by Ben.Marsh UBT: Add better messaging for modules that need to have a private PCH set. Now detects the likely PCH using the same method as legacy code and includes it as a suggestion. Change 4234193 by Ben.Marsh Add the Delete command to Perforce wrapper in DotNETUtilities. Change 4234688 by Ben.Marsh UBT: Simplify handling of installed/precompiled builds. Settings for whether a folder is installed/read-only or not is now stored on the RulesAssembly instance, allowing multiple things to be configured separately and stacked together (eg. engine/enterprise/project). RulesAssembly.IsReadOnly() allows determining if a flie can be modified or not and replaces many previous IsXXXInstalledCalls(), and traverses the chain of assemblies. Change 4234711 by Ben.Marsh UBT: Runtime dependencies can now be copied to output directories as part of the build. When adding a runtime dependency, an optional source location can be specified to copy from. Both the source and target paths can use variables can be used as part of the path, eg. $(OutputDir), $(ModuleDir), $(PluginDir). Example usage (from a .build.cs file): RuntimeDependencies.Add("$(OutputDir)/Foo.dll", "$(PluginDir)/Source/ThirdParty/Foo.dll", StagedFileType.NonUFS); Change 4234872 by Ben.Marsh Expose a flag for whether the engine is installed, to fix issues generating project files. Change 4234929 by Ben.Marsh Fix null reference generating receipts when UBT makefiles are active. Change 4235883 by Chad.Garyet Merging 4231245 to core Giving Coordinator its own sln. This should fix what 4158155 was supposed to. #jira UE-61955 Change 4236075 by Ben.Marsh CIS fix Change 4237066 by Robert.Manuszewski Fix for a potential crash when terminating the engine while it's being initialized #jira UE-60545 Change 4237078 by Robert.Manuszewski The engine will no longer be resetting all linkers causing massive load times when renaming the world package when entering Play In Editor Change 4237116 by Ben.Marsh Rewrite some Windows utility functions to support paths longer than MAX_PATH. Change 4237158 by Ben.Marsh Add const TCHAR* overloads of FString::RemoveFromStart() and FString::RemoveFromEnd(). Change 4237159 by Ben.Marsh Fix FWindowsPlatformFile::GetFilenameOnDisk() support for paths longer than MAX_PATH, and simplify some of the other long path functions to avoid copying string buffers. Change 4239050 by Ben.Marsh Missing file Change 4239318 by Ben.Marsh Linux CIS fix. Change 4239685 by Ben.Marsh Static analysis CIS fix. Change 4240800 by Ben.Marsh WorkspaceTool: Include the full command line in the log for any P4 commands. Change 4240903 by Ben.Marsh PR #4909: Update copyright notices to 2018 (Contributed by projectgheist) Change 4241025 by Ben.Marsh UBT: Exclude mobile pipeline caches from generated project files. Causes huge slowdown when using 'Find in Files' through the IDE. Change 4241770 by Ben.Marsh UBT: Include action number in parallel executor output. #jira UE-62032 Change 4243469 by Ben.Marsh TBA: Merge FAnnotatedStructuredArchiveFormatter with FStructuredArchiveFormatter. Any functions that are only implemented for text archives now have a _TextOnly suffix, and are exposed through the FStructuredArchive interface. Change 4245723 by Robert.Manuszewski Fixing another creash when terminating the engine while initializing. #jira UE-60545 Change 4245862 by Steve.Robb VectorLoadFloat2(Ptr) added, which loads { Ptr[0], Ptr[1], Ptr[0], Ptr[1] } into a VectorRegister. Change 4246412 by Robert.Manuszewski The warning 'Calling StaticLoadObject during PostLoad may result in hitches during streaming' will now also report the object which had the PostLoad called on it when StaticLoadObject call happened. Change 4246612 by Ben.Marsh UBT: Fix spelling of "Intellisense". Change 4249454 by Robert.Manuszewski Added extra checks to catch scenarios where the EDL Precache Buffer is flushed before a package header is fully read Change 4249513 by Robert.Manuszewski Made sure the Async Loading Thread doesn't continue running after creating new async packages when garbage collector wants to run on the game thread Change 4255207 by Ben.Marsh UGS: Add additional logging whenever a P4 command fails, and when the user is logged out. Change 4255288 by Ben.Marsh PR #4921: Honor ModuleRules' bEnableExceptions flag when creating precompiled h. (Contributed by surakin) Change 4256422 by Ben.Marsh UBT: Add an error if a module referenced by a plugin descriptor doesn't exist. Change 4257385 by Robert.Manuszewski Creating new objects from within ForEachObjectWithOuter will now result in a fatal error as it's unsafe to change internal UObject hash tables when iterating over them. Change 4257454 by Robert.Manuszewski Added the option to filter clusters listed with gc.ListClusters by objects within them. Usage: gc.ListClusters Hierachy With=ObjectName1,ObjectName2... Change 4257526 by Robert.Manuszewski It's now possible to filter clusters that get logged with verbose cluster logging enabled (UE_GCCLUSTER_VERBOSE_LOGGING=1) by objects within them by specifying -DumpClustersWithObjects=ObjectName1,ObjectName2 in the command line Change 4257822 by Ben.Marsh Fixes for PlatformShowcase compile errors. Change 4258771 by Ben.Marsh UBT: Fix project files not being generated for foreign projects when creating .stub files. #jira UE-62462 Change 4258790 by Ben.Marsh UBT: Clean up the logic around generating project files before creating a stub IPA, so that it fails loudly if project files do not exist, and can accept target names not matching project names. Change 4259276 by Ben.Marsh UBT: Make it an error if a framework doesn't exist, rather than failing silently. Also remove some remote toolchain stuff that's no longer necessary. Change 4259280 by Ben.Marsh UBT: Fix embedded framework zips not being uploaded for plugins. #jira UE-62485 Change 4260236 by Ben.Marsh UBT: Fix path to generated engine project file. Change 4260334 by Ben.Marsh UGS: Fix custom build steps dialog inadvertantly modifying config file settings in-place. Change 4260361 by Ben.Marsh UGS: Allow for p4 login commands to fail, even though the user is logged in (due to a bad connection, etc...) Change 4260559 by Ben.Marsh UGS: Update version. Change 4261160 by Robert.Manuszewski MediaPlaylist will now be added to root set if the owning MediaPlayer is in the disregard for GC set (fixes GC assumption violation crash) #jira UE-62495 Change 4261421 by Ben.Marsh Force-sync files for building documentation, to fix issues with files not being updated. #jira UE-62413 Change 4261425 by Ben.Marsh UBT: Remove some leftover functions for handling the remote toolchain. Change 4261530 by Ben.Marsh UBT: Speculative fix (and better error reporting) for IOS mobile provision not being found in CIS. Change 4261611 by Ben.Marsh UBT: Downgrade warning to a log message, since it appears when generating project files. Change 4261710 by Ben.Marsh Remove assert that GLogConsole is set; it won't be for command line utilities that don't depend on ApplicationCore. #jira UE-62545 Change 4261831 by Ben.Marsh Fix compile errors due to missing include path when hot-reloading a module from the editor. There are not necessarily source files to compile when -modulewithsuffix is specified on the command line, which was results in GeneratedCodeWildcard not being set. #jira UE-62463, UE-62384 Change 4262723 by Ben.Marsh Whitelist plugins that need to be loaded by UFE. #jira UE-62564 Change 4265444 by Ben.Marsh Fix incorrect executable name for DebugGame configurations in Xcode. #jira UE-62574 Change 4265892 by Ben.Marsh Fix incremental compile failures due to dependency checking for unity files. CachedIncludePaths was not correctly being set on file items, so dependencies were being ignored. #jira UE-62575, UE-62603, UE-62597 Change 4266019 by Josh.Adams - Fixed the CopyAction for runtime dependencies that need to be copied to different location, on non-XGE Change 4266264 by Ben.Marsh Remove override for the __IPHONE_OS_VERSION_MIN_REQUIRED macro on TVOS. This macro is already defined by system headers (in <AvailabilityInternal.h>). Now that we support PCHs on IOS and TVOS, manually defining this macro results in it being defined three times (once for the PCH, once by AvailabilityInternal.h, and once by the force-included list of definitions for the source file being built). The errors for redefining the macro in AvailabilityInternal.h are suppressed due to it being a system header, but the error for redefining it for the source file being compiled are not. #jira UE-62578 Change 4266273 by Ben.Marsh Fixes incremental build failure when compile arguments for PCH have changed on IOS/TVOS. Compile action needs to have a dependency on PCH build action. Change 4266614 by Graeme.Thornton Fix crash when cooking nativized blueprints due to removal of child cooker system. Change 4266763 by Ben.Marsh Always build UnrealPak when building client targets. The ProjectParams.Pak option is not reliable, because it can be forced on later by the target platform. #jira UE-62584 Change 4267985 by Robert.Manuszewski When iterating with ForEachObjectWithouter, don't lock the entire has table but only the hash bucket that is currently being iterated #jira UE-62600 Change 4268558 by Robert.Manuszewski PurgeLegacyBlueprints will no longer be called from within ForEachObjectWithOuter is it renames objects that reside in hash tables that are being iterated over which may lead to undefined behavior. #jira UE-62600 Change 4269011 by Chad.Garyet - Fixing Wildcard match issue, the change to ugsapi sends projects as //Depot/Stream instead of //Depot/Stream/ Wildcard match was only substringing to 3 chars. - Checking in the change a while back that increases the number of queried jobs up to 432 based on some maths from Bob about how many builds we want to grab Published to ugsapi server 8/8/17 #jira none Change 4270788 by Ben.Marsh Fix IOS provisioning data being using when remote compiling on TVOS. #jira UE-62705 Change 4271916 by Ben.Marsh Tag the XGEControlWorker executable as a build product after compiling SCW, to make sure it's included in the UGS zip file. Change 4271934 by Ben.Marsh Upload all static libraries in plugin folders as part of remote builds. #jira UE-62694 Change 4273368 by Ben.Marsh Fix Slate dependencies not being enumerated, and rules assembly not being rebuilt when building remotely. #jira UE-62705 Change 4274049 by Ben.Marsh Always parse the team UUID out of the mobile provision when doing a remote compile. The provision installed on the remote Mac (and selected for signing) may be different. #jira UE-62751 Change 4274823 by Ben.Marsh Add the -VersionCookedContent argument to disable the -unversioned parameter on the cooker command line. Change 4275838 by Ben.Marsh Fix BuildVersion string not being passed through from <SetVersion> task. Also add a -BuildVersion command line argument to UBT to override it for a particular build. Change 4275913 by Ben.Marsh Add a dummy exported symbol to the XGEController module, to fix build errors due to missing .lib file when it's built with WITH_XGE_CONTROLLER = 0. Change 4284161 by Ben.Marsh Allow mirroring Oodle files to remote Mac. Change 4074774 by Steve.Robb Vast simplification of TFunction, making it smaller in footprint, easier to follow and extend, and more correct. TUniqueFunction added, which is a move-only TFunction which can hold move-only functors. Fix for UWidgetBlueprint::ForEachSourceWidget() which should never have compiled but did. FFunctionGraphTask and TFuture<> updated to use TUniqueFunction to make them more general. TArray::HeapPop() made to work with move-only types. Change 4082591 by Ben.Marsh Move the Log class from UBT to DotNetUtilities. Change 4083236 by Ben.Marsh Add a Log.WriteException() method to dump an exception message to the console (and write the exception trace to the log) Change 4084107 by Ben.Marsh UAT: Remove the unused -SkipHeader argument to UE4Build. Change 4089771 by Steve.Robb GitHub #4743 : modified VirtualAlloc function flag https://blogs.msdn.microsoft.com/oldnewthing/20151008-00/?p=91411 Change 4091456 by Steve.Robb Unification of all platforms' FMath::CountTrailingZeros() and FMath::CountLeadingZeros() for both 32-bit and 64-bit. Change 4156437 by Ben.Marsh Lots and lots of fixes compiling for Clang on Windows. Editor now compiles cleanly without warnings, but crashes on startup due to error in intrinsics test. Disabling that runs further, but crashes accessing freed memory. Switching to the ANSI allocator runs further, but crashes in Slate after the splash screen and before the editor window opens. // TODO! * Switching between Clang/ICL/VS2015/VS2017 is now supported through the same mechanism as switching Visual Studio versions, without requiring any source level changes. To use Clang, set WindowsPlatform.Compiler = WindowsCompiler.Clang from a .target.cs file, or set <WindowsPlatform><Compiler>Clang</Compiler></WindowsPlatform> from BuildConfiguration.xml. To pick a specific toolchain version, set WindowsPlatform.CompilerVersion. * Clang is now supported through AutoSDKs; will be added to CIS. * The Samples/Sandbox/Clang project forces Clang to be used from its target.cs file, and allows easily building all editor modules and plugins with Clang on Windows. * UnrealMathSSE intrinsics have been re-enabled for Clang due to missing functions from the UnrealMathFPU implementation, but causes failure in tests at startup. * SSE4_CRC32() is disabled in D3D12Pipelinestate.cpp, since intrinsics are only allowed if enabled for the whole target (rather than being used in specific functions due to runtime checks) Change 4157389 by Ben.Marsh Few more fixes for compiling the editor with Clang. Change 4183911 by Ben.Marsh Fixes to support incremental linking on Windows. Does not seem to have any net benefit right now; may improve once minimal rebuild is enabled. * Incremental linking no longer forces PDB files to be enabled for source files. * Actions can specify specific files to be deleted before each build. Code to forcibly delete PDB files has been moved to the MSVC toolchain. * Unused libraries produced by the cross-referenced link are no longer added as build products, since (a) deleting them breaks dependency checking for incremental linking and causes a full link, and (b) not deleting them breaks UBT dependency checking and causes actions to be run over and over again. * Icon update is disabled for Windows when incremental linking is enabled. * Removed rarely-used setting to always delete produced items before each build. Change 4184311 by Ben.Marsh UGS: Added a dialog which shows all the required platform SDKs for a branch, linked from the status panel in UGS. The llist is configured via the UGS config file submitted to Engine/Programs/UnrealGameSync/UnrealGameSync.ini (and may be overridden by the project config file if necessary): [Default] ; Set this to a network share which contains the SDK installers for your site SdkInstallerDir= ; All the required SDKs for the current version of the engine +SdkInfo=(Category="Android", Description="NDK r21", Browse="$(SdkInstallerDir)\\Android") +SdkInfo=(Category="Windows", Description="Visual Studio 2017") +SdkInfo=(Category="Windows", Description="Visual C++ Toolchain 14.13.26128") +SdkInfo=(Category="Windows", Description="Windows SDK 10.0.16299.0") Similar entries for console platforms are added in console subdirectories. Each entry may contain an Install="Foo.exe" and/or Browse="C:\Foo" style attribute, specifying the path to an installer to run or directory to open in explorer respectively. The SdkInstallerDir setting is used as a base directory for the default installers, seen above for Android. Licensees may override this with a network path specific to the site that UGS is being deployed to (either in this file, in a project specific config file, or in a Engine/Programs/UnrealGameSync/NotForLicensees/UnrealGameSync.ini file). Change 4200452 by Ben.Marsh UBT: Change DebugGame configurations to output a separate executable rather than requiring a -Debug argument at runtime. Previous behavior was a common source of errors. Engine modules are still shared between Development and DebugGame, but the launch module sets a flag in Core on startup indicating the game configuration. Change 4206189 by Ben.Marsh UBT: Simplify logic for precompiling binaries. * Target no longer has separate list of "precompile only" binaries or modules. New -AllModules option allows adding every module to a target, which can be used with -Precompile and -NoLink to precompile object files for monolithic builds. * Precompiled file lists have been removed from target receipts. * The manifest now includes all generated headers and precompiled files when run with the -Precompile option. * Separate -DependencyList=Foo.txt has been added to write a list of all dependencies required to use precompiled binaries. This file list can be read using the <Tag> task in buildgraph. Change 4215466 by Ben.Marsh UBT: Remove indirect calls to determine extensions for object files and precompiled headers. The toolchain knows the correct convention for the platform. Change 4215975 by Ben.Marsh UBT: Remove telemetry code. This has never proved useful for analyzing performance due to the number of incidental factors that affect build times (eg. number of files being compiled). Change 4220154 by Ben.Marsh Move text-only implementations of FOutputDeviceError back into Core, so we can build command-line applications that don't depend on ApplicationCore. Change 4224708 by Ben.Marsh Add a bCompileAgainstApplicationCore setting to the target rules, which allows compiling out references to the ApplicationCore module (which should only be necessary for applications with a GUI). Removed ApplicationCore from several engine tools and utilities. Change 4224958 by Ben.Marsh Remove CoreMinimal.h includes from Core. Change 4229059 by Ben.Marsh UBT: Remove the UEBuildPlatform.ShouldNotBuildEditor() hook for target platforms. We shouldn't be modifying a target's build environment to disable the editor; it is invalid to build the editor for these target platforms at all, and this is already enforced by the GetSupportedPlatforms() function. Change 4230508 by Ben.Marsh Fixup precompiled header setting for samples and games. Change 4231457 by Ben.Marsh Fix exceptions in log messages having trailing newlines. Change 4232406 by Ben.Marsh UBT: Always force include a PCH for generated code if there's one set; the code may depend on it to compile. Change 4234177 by Ben.Marsh Set up private PCH files everywhere that previously used them. Change 4235973 by Ben.Marsh Change FPlatformMisc::GetEnvironmentVariable() to return an FString() rather than requiring a fixed size buffer to be passed in. Removes references to MAX_PATH. Change 4238842 by Ben.Marsh Add support for paths longer than MAX_PATH in the editor. Requires Windows 10 version 1607, and the functionality to be enabled via a registry key or group policy (see https://docs.microsoft.com/en-us/windows/desktop/FileIO/naming-a-file). Only a subset of Win32 functions support long paths (executables can only be started from paths shorter than MAX_PATH, for example). * Added a FPlatformMisc::GetMaxPathLength() function to return the maximum length of a path on the current system. On Windows, this returns a different value for systems with long paths enabled to those without. * The MAX_PATH define is no longer set by non-Windows platforms. Instead, there is a MAC_MAX_PATH, UNIX_MAX_PATH, etc... for any platform-specific code that still relies on the previous macro. * The MAX_UNREAL_FILENAME_LENGTH macro has been renamed to MAX_UNREAL_FILENAME_LENGTH_DEPRECATED * The PLATFORM_MAX_FILEPATH_LENGTH macro has been renamed to PLATFORM_MAX_FILEPATH_LENGTH_DEPRECATED. * Removed custom resource files for programs, since they are just copies of the base UE4 one (which is used by default anyway). The base UE4 manifest declares support for long paths. * Fix 512 character maximum length on editor commands. 260 character limit remains in place for cooking at the moment (see ContentBrowserUtils.h), until C# staging code supports long paths. Change 4255042 by Ben.Marsh UBT: Remote compilation now uploads the entire workspace to the remote Mac and executes a separate remote instance of UBT rather than synchronizing individual actions. This makes the remote compile codepath much simpler, and removes a lot of special cases that exist to support it previously. The list of files to be transferred to the remote are listed as rsync filter rules in Engine/Build/Rsync/RsyncEngine.txt and RsyncProject.txt, which are applied to the root engine directory and project directory respectively. Projects that need to customize which files are uploaded can add their own <ProjectDir>/Build/Rsync/RsyncProject.txt file, which will be included in the filter before the default version. Change 4260567 by Ben.Marsh UAT: Rename CommandUtils.Log to CommandUtils.LogInformation, to avoid conflicts with the underlying Tools.DotNETCommon.Log class. #rb none [CL 4285673 by Ben Marsh in Main branch]
2018-08-14 18:32:34 -04:00
LogInformation("Waiting a few seconds for the server to start...");
Thread.Sleep(5000);
}
if (!Params.NoClient)
{
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 4285612) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3836829 by Ben.Marsh UBT: Fix ability to precompile plugins from installed engine builds. Change 3839519 by Ben.Marsh UBT: Simplify configuring bPrecompile and bUsePrecompile settings for modules. Each rules assembly can now be configured as installed, which defaults the module rules it creates to use precompiled data. Change 4042043 by Steve.Robb GitHub #4705 : Added weak lambda's for delegates and multicast delegates. Change 4042056 by Robert.Manuszewski Optimized Mark Phase of GC by up to 10ms by making it run in parallel and removing a huge array presize which we didn't need. Change 4042104 by Robert.Manuszewski Set the minimum GC cluster size to 5 so that GC doesn't have to process micro clusters which are more expensive than processing individual objects + Exposed the minimum cluster size to ini and project settings as gc.MinGCClusterSize + Added the ability to sort clusters by name/object count/mutable object count/referenced clusters count when dumping them with gc.ListClusters command Change 4042377 by Robert.Manuszewski Reworked how GC and other threads (ALT specifically) interact - GC will now notify the ALT it wants to run and ALT will immediately try to finish its current work to allow that. Also the entire ALT tick is now protected against GC running at the same time to improve ALT stability. + added gc.ForceCollectGarbageEveryFrame console variable that triggers a forced GC every frame Change 4042427 by Robert.Manuszewski Changed FGCCSyncObject to use events when waiting for GC to finish so that it doesn't spin on non-game threads when GC is running Change 4042482 by Robert.Manuszewski Unhashing unreachable objects (ConditionalBeginDestroy) will now also be done incrementally, just like the purge phase of Garbage Collection Change 4042635 by Robert.Manuszewski Fix for a potential assert when incremental purge garbage is pending and something forces a full purge Change 4044092 by Steve.Robb Fix for forward declared CoreUObject weakobject types in delegates when building in Clang. Change 4044102 by Robert.Manuszewski Fix for a possible hang when worker threads are preventing GC from running and something is later trying to FlushAsyncLoading with the Async Loading Thread enabled Change 4044113 by Steve.Robb Another Clang fix. Change 4044160 by Robert.Manuszewski Disregard For GC pool will now be enabled by default in cooked builds Change 4044287 by Steve.Robb Typo fix. Change 4047723 by Graeme.Thornton TBA: Fixes for import/export name cache and object resolving Change 4048015 by Graeme.Thornton TBA: Weak/Soft/Lazy pointer serialization changes * Remove FWeakObjectPtr::Serialize, move it's logic into, and replace usages of with calls to, FArchiveUObject::SerializeWeakObjectPtr(). Ensures that something is always sent to the archive so that structured archives can be kept happy in the future. * Added Weak/Soft/Lazy pointer handling to the structured archive slot interface and all the formatters. Binary formatters just forward the call onto their inner and text archives store as a string path reference. * FArchiveUObjectFromStructuredArchive caches all these pointer types and stores indices in the binary block, same as with a UObject*. All pointers are then forwarded to the underlying formatter in one go on finalization. Change 4048021 by Steve.Robb Fix for binding an unbound TFunction to another TFunction with a different signature. Also all null pointers now count as unbindings, not just nullptr. TIsMemberPointer added. TIsATFunction and TIsATFunctionRef renamed to remove the 'A's. Change 4048544 by Robert.Manuszewski Fixing ConditionalBeginDestroy profiling after changes to incremental CBD. Change 4051028 by Graeme.Thornton TBA: ArchiveFromStructuredArchive adapter uses Inner to determine if it is outputting to text, and sets it's own ArIsTextFormat to false Change 4051056 by Graeme.Thornton TBA: High level tagged property / UObject base class text serialization - UObject serialize converted to structured archive - Properties written to text individually with text tags, and then binary adapted values - Only saves, doesn't load Change 4051111 by Graeme.Thornton TBA: Temporarily disable loading of text assets until tagged property serialization path is fixed up Change 4051154 by Graeme.Thornton TBA: Convert a few uobject serializers to structured archive format for example purposes Change 4051181 by Graeme.Thornton TBA: Added default structured archive implementation of SerializeItem to UProperty, which just calls the FArchive version on an FArchiveUObjectFromStructuredArchive adapter. Implemented structured archive SerializeItem for UArrayProperty Change 4051197 by Graeme.Thornton TBA: ObjectProperty text serialization Change 4051216 by Graeme.Thornton Restored a modified FWeakObjectPtr::Serialize function to keep backwards compatibility in code I don't have access to. Change 4051261 by Graeme.Thornton TBA: Convert UMetaData to structured archive Change 4051374 by Steve.Robb Incorrect assert removed. Change 4051562 by Robert.Manuszewski Adding stats for the new GC internal functions Change 4051614 by Graeme.Thornton TBA: Removed UProperty::SerializeItem(FArchive, ...) and replaced with UProperty::SerializeItem(FStructuredArchive::FSlot, ...). Fixed up most of them to work properly and added adapters in for any that were non-trivial. Change 4052512 by Graeme.Thornton TBA: Temporary workaround for softobjectptr and lazyobjectptr uproperties not serialization anything when they know the archive is a reference collector. They should always be serializing their pointers and letting the underlying archive itself ignore them. Change 4053917 by Robert.Manuszewski Clustered objects from clusters that are no longer reachable will now be marked as unreachable immediately when gathering unreachable objects Change 4053919 by Robert.Manuszewski Added the ability to disable incremental BeginDestroy in ini/project settings Change 4055518 by Daniel.Lamb Fixup for deterministic audio generation issue. Submitted on behalf of Rich.Whitehouse #jira nojira #test prefilght automated test. Change 4056854 by Graeme.Thornton TBA: Added a test asset to EngineTest which contains all the different property types and test cases. Change 4056858 by Graeme.Thornton TBA: Updated USetProperty to proper structured archive usage Change 4056872 by Graeme.Thornton TBA: Add map property field to test object Change 4056873 by Graeme.Thornton TBA: Convert UMapProperty to full structured archive Change 4056994 by Graeme.Thornton TBA: Converted FText over to structured archive. Implemented saving, but not loading. Change 4059728 by Ben.Marsh UBT: Add support for using adaptive non-unity builds when the engine and project are in separate repositories. Change 4059805 by Graeme.Thornton Fixed typo in text serialization. Fixes CIS automation test errors Change 4060007 by Graeme.Thornton TBA: FArchiveFromStructuredArchive will now access it's host slot lazily, i.e. only when a value is actually written to the archive. Change 4060092 by Stefan.Boberg Added optimized Windows console window output path to GenericConsoleOutput since this slowed down cooking considerably (2 minutes spent in wprintf alone for one large dataset) When stdout is attached to a console we use the WriteConsoleW function instead of wprintf since the latter is very slow especially in unbuffered mode which the engine currently configures for stdout (see setvbuf call in LaunchEngineLoop.cpp). At some point we should reconsider this buffering policy since it's likely to slow down other platforms as well but I wanted to do a safe change for now as I don't yet fully understand why the setvbuf call is there in the first place. Change 4060108 by Stefan.Boberg Introduced some additional target platform utilities to help with asset cook optimizations * We now assign each ITargetPlatform a zero-based ordinal value * Introduced FTargetPlatform and FTargetPlatformSet types to help store platform references and platform sets efficiently. These are not currently used in the engine but are designed to replace the existing ITargetPlatform/string/FName representations in the cooking data structures. Change 4060143 by Graeme.Thornton Undo //UE4/Dev-Core/Engine/Source/Runtime/... changelist 4060007 Needs some other changes that I haven't checked in yet... Change 4062432 by Ben.Marsh Fix error message when enumerating P4 changes. Change 4062648 by Ben.Marsh Add missing p4 integration action. Change 4063620 by Graeme.Thornton Integrated a fix from UDN where the engine would crash when trying to load a very small encrypted file (<16bytes) from a pak file, where the read address wasn't already aligned to the AES block size. (https://udn.unrealengine.com/questions/431989/crash-while-reading-a-very-small-file-in-encrypted.html) Change 4066963 by Robert.Manuszewski Fixing GC cluster verification code reporting false positives when a cluster is referencing another cluster through 'mutable' objects list. Change 4067133 by Robert.Manuszewski Changed log verbosity when reporting individual cases of GC cluster assumption violations as they are followed by an asser anyway and this way we get the chance to see all issues before we assert at the end of these checks. Change 4067443 by Steve.Robb FString can now be constructed from any char pointer type and length. Change 4068156 by Steve.Robb Fix necessary because of FString constructor change in CL# 4067443. Change 4070258 by Graeme.Thornton Fixes for VSCode Change 4070372 by Graeme.Thornton TBA: Script struct serialization to structured archives Change 4071913 by Ben.Marsh Move bulk of the code for UnrealPak into an engine developer module, so it can be used in the editor. Change 4071914 by Ben.Marsh Missing files. Change 4071937 by Ben.Marsh Missing header. Change 4072015 by Ben.Marsh Fixes for compiling PakFileUtilities as part of the editor. Change 4072826 by Steve.Robb TBitArray::Reserve() added. TBitArray::Add() overloaded to allow adding multiple bits. TSparseArray::Reserve() optimized to call the overloaded Add(). Change 4073271 by Daniel.Lamb Fixed add patch tier in project launcher passing the wrong commandline option to UAT. #test none Change 4074708 by James.Hopkin #core Removed redundant Casts Change 4074763 by Steve.Robb Fix for TSparseArray::Reserve() size. Change 4076063 by Ben.Marsh Add an "UnrealPak" commandlet with the same functionality as the standalone UnrealPak program. Invoke by running the editor with -run=UnrealPak and the standard UnrealPak commandline options. Change 4077064 by Robert.Manuszewski Fixing compile error in PakFileUtilities Change 4077144 by Graeme.Thornton TBA: TextAssetCommandlet improvements * Collect lists of broken assets during roundtrip tests and print a summary of packages that failed each phase at the end * After resaving as text, load the file back as a plain JSON hierarchy to ensure the output was valid Change 4077412 by Ben.Marsh Set the correct exit code for UnrealPak. Should return 0 on success, not 1. Change 4077760 by Graeme.Thornton TBA: Loading fixed for tagged property serialization Includes conversion of all UProperty::ConvertFromType() and SerializeFromMismatchedTag() functions to use structured archives Lazy initialization of FArchiveFromStructruredArchive when loading, to support the possibility of an adapter being create around an object property serialize call to its inner UStruct, which then decides not to do anything and return false. Stops the ArchiveFromStructuredArchive from consuming the slot and getting upset later on when we try to serialize normal tagged properties from it. Disabled lazy bulk data loading from text assets. Requires a bigger change to make it work. Added some debug checks to json input formatter which track the current value stack size when a new object is pushed onto the stack, and makes sure that the stack has returned to the same size when the object is popped. Catches cases where we unpack an array/stream to the value stack but then don't consume all the items. Change 4078800 by Ben.Marsh Change UAT to using the editor's UnrealPak commandlet rather than invoking the standalone UnrealPak executable. To improve performance when building several PAK files, also add a new -batch=<file> command which reads commands to execute in parallel from a text file. Change 4079745 by Graeme.Thornton TBA: Migrated a couple of UObject Serialize functions to FStructuredArchive (SoundCue / MaterialExpressions / Editor strip flags) Change 4079847 by Graeme.Thornton TBA: Add 'FindMismatchedSerializers' mode to text asset commandlet, which dumps out a list of all UClasses which don't have the CLASS_MatchedSerializers flag, meaning we can't guarantee the have Serialize functions for FArchive AND FStructuredArchive, therefore we can't use the new structured archive based serialize path. Should only ever be native instrinsic classes as UHT takes care of all other cases. Change 4079925 by Ben.Marsh Fix incorrect assignment when deriving name for chunked pak file. Change 4080214 by Ben.Marsh Move the ThreadPoolWorkQueue class into DotNETUtilities so it can be used by other projects. Change 4082394 by Graeme.Thornton CIS fix for variable shadowing warning Change 4082583 by Ben.Marsh Add a IBinarySerializable interface for types that support reading from a BinaryReader and writing to a BinaryWriter. Implementing IBinarySerializable implies a constructor taking a BinaryReader argument is available for deserializing. Change 4082652 by Ben.Marsh Fix FileReference.Directory not returning a directory with a trailing backslash for files in the root directory. Change 4082755 by Graeme.Thornton Fixed an erroneous usage of TUniquePtr<uint8>as a pointer to a uint8 array when creating pak files. Caused a crash when compression was enabled, and has probably surfaced because pak generation is now done by an editor commandlet rather than a standalone program. Change 4082756 by Graeme.Thornton Fixed some incorrect documentation for pakfile compressed chunk headers Change 4082883 by Graeme.Thornton Static analysis warning fix Change 4082912 by Ben.Marsh Move ExceptionUtils into DotNETUtilities. Change 4085291 by Graeme.Thornton TBA: In the Json output formatter, write float and double values out with enough precision for successful roundtripping. Added some debug only code which will immediately reconvert the string back to its original value and compare the the input Change 4085523 by Graeme.Thornton TBA: Remove only explicit usage of DECLARE_FSTRUCTUREDARCHIVE_SERIALIZER. Should only be used from UHT generated code. Change 4086037 by Robert.Manuszewski Fix for a potential race condition when two threads want to acquire GC lock Change 4088655 by Graeme.Thornton Pak creation now uses the bEnablePakSigning setting from the crypto config json file Change 4091474 by Steve.Robb Fix for TStaticBitArray::FindFirstSetBit() and TStaticBitArray::FindFirstClearBit(). Unused variables removed. Change 4093632 by Steve.Robb CIS fixes. Change 4093656 by Graeme.Thornton Build fix Change 4093744 by Ben.Marsh Allow per-chunk settings for whether to enable compression in UnrealPak. Change 4099712 by Gil.Gribb UE4 - Fixed rare case where insufficient space was preallocated for cooldown ticks. #jira UE-59686 Change 4099912 by Stefan.Boberg Cooking timer optimizations: - Replaced data structures for FScopeTimer and FHierarchicalTimerInfo. Previous implementation used FString for many things and caused *lots* of heap and string concatenation activity. Replaced with a compile-time node id (using __COUNTER__) and raw string literals. - Removed PERPACKAGE_TIMER support (was disabled by default and was difficult to test) - Made it possible to toggle OUTPUT_TIMING and ENABLE_COOK_STATS independently - Removed some extremely tight timers because the overhead from calling QPC significantly exceeded the measured code This change shaved some 15% off a clean cook of Fortnite WindowsClient (en) with fully populated local DDC Change 4100519 by Stefan.Boberg Quick fix for Linux build issue introduced in 4099927 Change 4105327 by Stefan.Boberg Cooker: Changed FHierarchicalTimerInfo so it uses a linked list for tracking child nodes, to be able to deal with any child count. Previously we assumed there would never be more than 9 children but it turns out there are cooker modes that need more. Fixes check when using -FullLoadAndSave to cook Change 4105448 by Stefan.Boberg - Fixed Linux build warning re: member initialization order - Also eliminated OUTPUT_HIERARCHYTIMERS/CLEAR_HIEARCHYTIMERS macros (plain functions are fine) - Moved finishing-up code for FullLoadAndSave() to TickCookOnTheSide() call site to improve timer output. Previously some of the scopes would not have been closed before printing and thus the output was misleading. Change 4109031 by Ben.Marsh Attribute-driven Perforce wrapper (old Epic Friday project). Offers a more complete implementation than the current P4 wrapper in UAT without requiring any platform-specific libraries. Uses the Python binary output for parsing. Change 4109588 by Ben.Marsh UBT: Add extension methods for serializing a nullable type to a BinaryReader/BinaryWriter. Change 4109595 by Ben.Marsh Missing project file for DotNETUtilities. Change 4110724 by Stefan.Boberg Removed annotation map locking in UObjectMarks, eliminating around one minute (~3.5%) from Fortnite cook time. The locking was redundant since the annotation maps are managed per thread anyway. Change 4111304 by Ben.Marsh UAT: Add support for setting a status message through the log class. Allows writing transient messages (eg. progress messages) which will be cleared out before writing other messages. Best used through the LogStatusScope class, which can set a status message for the duration of a using() block. As part of this change, the console no longer has to be added as a dedicated trace listener. Since we already special-case this listener when formatting log output, it's easier to just keep the implementation separate to the other trace listeners. Change 4112708 by Steve.Robb Fix for TBitArray::MaxBits in assignment. Change 4114133 by Stefan.Boberg Tweaked how low-level memory (LLM) tracker is implemented to reduce overheads. Previously FMemory functions would acquire the LLM singleton and call OnLowLevelFree/OnLowLevelAlloc etc which would check the bIsDisabled flag and early out if it was set. Due to how frequently these functions were called this ended up costing quite a bit. - This change makes the flag a static member variable instead of a member variable and therefore enables a simpler early-out to be implemented. - The singleton getter is also simplified to avoid hitting the threadsafe singleton construction path on every call. - The enable flag is no longer TAtomic - this also incurs extra overhead for no clear benefit Shaves approximately 3.5% (one minute) off a Fortnite cook test scenario (using -FullLoadAndSave) Change 4115010 by Robert.Manuszewski Fixing CIS Change 4115249 by Robert.Manuszewski Fixing async loading code asserts when exiting game very early due to an error #jira UE-56267 Change 4117091 by Ben.Marsh Prevent doubled-up lines when writing status updates with console log verbosity. Change 4117207 by Ben.Marsh UGS: Do not include executables in diagnostics zip file, and ignore "no such files" error when cleaning workspace. Change 4119175 by Ben.Marsh UGS: Fix crash writing version files when directory does not already exist. Change 4119987 by Ben.Marsh UGS: Show a dialog box while the launcher is updating executables from Perforce, which allows cancelling the operation if necessary. Allow setting the username on the settings window, and prompt for login credentials if necessary. Should prevent situations where users have to update settings from the command prompt. Holding down shift during launch now shows the settings dialog rather than an immediate prompt to launch the unstable version (unstable version is shown as a checkbox on this dialog). Change 4119991 by Ben.Marsh Update version number for UGS launcher to 1.13. Change 4121943 by Robert.Manuszewski Don't use FArchiveAsync2 for reading packages with non-async path in editor builds as its performance is worse than the standard archive's (saves about 1 minute when doing larger cooks and 7 seconds when loading into PIE) Change 4122592 by Steve.Robb GitHub #4762 : Improve wording and grammar of Math comments Also includes improved accuracy in FMath::ComputeBoundingSphereForCone(). Change 4122819 by Stefan.Boberg Don't call CreateDirectory redundantly when opening files for writing using FFileManagerGeneric::CreateFileWriter This change avoids calling IPlatformFile::CreateDirectoryTree if possible since this is a very expensive function especially for deep hierarchies as it performs directory creation from the root directory onwards instead of from the leaf downwards. That function should also be fixed but this change improves performance in the meantime. Change 4122872 by Stefan.Boberg CreateDirectoryTree now creates directories leaf-to-root instead of the other way around. This is much more efficient since we don't spend time on system API calls for directories which already exist. This accounted for a very large amount of CPU time in cooking as the full target file directory hierarchy would be "created" for every single output file. Change 4123109 by Stefan.Boberg - Disable overlapped I/O in editor / cooker. Synchronous I/O reduces the number of syscalls and Windows performs prefetching on our behalf anyway for sequential reads - Eliminated syscall which was issued for every write to update cached file size -- since we're the only writers to the file (file access allows read sharing at most) we can authoritatively update the file size on write completion Change 4123455 by Ben.Marsh PR #4775: New build param PCHMemoryAllocationFactor to set /Zm VS build param. (Contributed by lucaswall) Change 4124207 by Ben.Marsh UBT: Remove some unnecessary indirection for generated code paths. Change 4124217 by Ben.Marsh UBT: Remove another unused variable from UEBuildModuleCPP. Change 4124377 by Stefan.Boberg In IPlatformFile::DeleteDirectoryRecursively, attempt to delete file first and if it fails clear the readonly flag and try again Previously there was a call to clear the readonly flag for every deleted file and this is a waste of resources 99% of the time. The SetFileAttributes call accounted for a significant amount of time during cooker sandbox directory deletion Change 4125071 by Stefan.Boberg Some tweaks to FQueuedThreadPoolBase scheduling and memory management - Explicitly pass in false for TArray::RemoveAt(..., bool bAllowShrinking) argument to prevent memory reallocation when arrays are drained and inevitably repopulated shortly afterwards - Use a MRU strategy instead of LRU when picking a thread to wake up. The MRU thread is the most likely to have a 'hot' cache for the stack etc. Picking from the back of the array also happens to be cheaper since no memory movement is necessary when RemoveAt is called. (This was the strategy in place before CL2600362 which seems to have changed it unintentionally) - Release lock as soon as a thread has been chosen, before asking the worker thread to wake up and do the work Change 4126132 by Ben.Marsh UAT: Detect when stdout is redirected and prevent using backspace characters to move the cursor. Change 4126867 by Graeme.Thornton TBA: Fix tagged binary formatter Change 4127010 by Robert.Manuszewski AnimScriptInstances created at runtime will now also be added to the owning omponent's cluster to avoid GC issues. Change 4127932 by Ben.Marsh WorkspaceTool: Reduce unnecessary logging of status messages when console output is not redirected. Change 4129050 by Ben.Marsh UGS: Check for NET Framework 4.5 being installed before running the installer. Also fix warning trying to kill existing UGS instances before upgrade. Change 4129459 by Graeme.Thornton TBA: TextAssetCommandlet - When outputting converted assets to an output path, replicate the workspace relative path in the output directory Change 4129515 by Graeme.Thornton TBA: Add EnterRecord overload that allows outputting of available field names when loading. Change 4129517 by Graeme.Thornton TBA: Tagged properties are written out as named fields on the "Properties" record, rather than as a stream with a null tag at the end Change 4129518 by Graeme.Thornton TBA: Added a local const bool to allow easy hacking out of text asset loading support Change 4129558 by Graeme.Thornton TBA: Build fix for textasset-less configs Change 4129614 by Ben.Marsh UGS: Main window is now restored to normal size when activated by clicking on the tray icon. #jira UE-60490 Change 4129618 by Ben.Marsh UGS: Speculative fix for unreproduced exception accessing disposed window while shutting down. Change 4131936 by Robert.Manuszewski Removing some WIP code accidentally checked in with CL #4121943 Change 4133490 by Ben.Marsh UGS: Allow the $(Change) variable to be used in more places than just the context menu. #jira UE-60573 Change 4133550 by Ben.Marsh UGS: Setting for whether or not to use incremental builds is now exposed through the variable "$(UseIncrementalBuilds)" for use by custom build steps. #jira UE-60554 Change 4133681 by Ben.Marsh UGS: A per-project list of folders and extensions to be deleted by default when running the 'clean workspace' tool can now be specified through the <ProjectDir>/Build/UnrealGameSync.ini file. Settings may be specified for an individual branch (via a category with the depot path to the project) or for wherever the project is currently open (via the [Default] category). The SafeToDeleteFolders list specifies a substring that will be checked against folder paths. Anything containing this folder will be marked as safe for delete by default. The SafeToDeleteExtensions list specifies a list of extensions for files that can always be deleted. Example: [Default] +SafeToDeleteFolders=/MyGame/Test/ +SafeToDeleteFolders=/DataService/ +SafeToDeleteExtensions=.xx1 +SafeToDeleteExtensions=.xx2 #jira UE-60575 Change 4135449 by Ben.Marsh Fix allowing use of Job objects on Windows platforms (debug code submitted by mistake) Change 4135730 by Ben.Marsh UBT: Plugins can now be enabled and disabled from the .target.cs file (for targets that do not use the shared compile environment), by compiling the list of enabled/disabled plugin names into the Projects module. Change 4135823 by Ben.Marsh UBT: Remove legacy code to handle disabling optional plugins; now that this is compiled into the target, it will work for any plugins we choose. Change 4135945 by Ben.Marsh UBT: Fix error running programs with no explicitly enabled or disabled plugins. Change 4137207 by Ben.Marsh UGS: Align all badges with the same name, to make it easier to see which CIS steps are being run. Allow overriding the slot taken by a particular badge by calling it "SlotName:LabelName". Change 4137311 by Stefan.Boberg Removed child cooker support. In practice it is not a useful feature as it provides no performance improvement (quite the opposite in fact) and adds testing and maintenance complexity. Change 4137393 by Ben.Marsh UGS: Fix display of multiline errors in the status panel. Change 4141708 by Steve.Robb GitHub #3631 : Incorrect default argument in WeakObjectPtrTemplate #jira UE-45490 Change 4146655 by Stefan.Boberg Removed FullGCAssetClasses logic - no longer necessary nor useful Change 4147318 by Ben.Marsh UGS: Compress build badges in a column if it shrinks below the size that they would be visible. Change 4148207 by Ben.Marsh UGS: Added support for showing the latest completed build from a specific list of badges in the status panel. To declare a badge as one that should appear in the status panel rather than the CIS column, add it to the project's UnrealGameSync.ini in the project or [Default] section like so: +ServiceBadges=RoboMerge Change 4148282 by Stefan.Boberg Fixed bug in UCookOnTheFlyServer::GetCookOnTheFlyUnsolicitedFiles - UnsolicitedFiles should be passed by reference not by value Change 4148344 by Stefan.Boberg Fixed minor indentation error (most likely caused by sloppy merge) Change 4148521 by Stefan.Boberg Removed accidentally checked in PRAGMA_DISABLE_OPTIMIZATION from CookOnTheFlyServer.cpp Change 4148639 by Ben.Marsh UGS: Fix tooltips not showing for changes that have description badges. Change 4149373 by Ben.Marsh UGS: Allow adding additional columns to display particular badges by adding entries from the project config file. Example syntax: +Columns=(Name="Desktop",MinWidth=50,DesiredWidth=100,Weight=3,Badges="Editor") +Columns=(Name="Mobile",MinWidth=50,DesiredWidth=100,Weight=3,Badges="IOS,Android") Same form can be used to control how default columns are displayed (though badge settings are ignored). Also allow PerforceMonitor to detect local changes to project config files and update settings automatically. Change 4149399 by Ben.Marsh UGS: Update version to 1.143. Change 4155660 by Steve.Robb PROJECTION and PROJECTION_MEMBER macros which provide the correct behavior when creating projections using functions which are overloaded or use default arguments. Change 4157117 by Ben.Marsh Fix warning due to plugins disabled in .target.cs file. Change 4158011 by Ben.Marsh UBT: Add a check that the UnrealHeaderTool target file exists, rather than throwing an exception when reading it fails. Change 4158646 by Ben.Marsh UGS: Fix exception when login is discovered to have expired during a workspace update. Change 4158678 by Ben.Marsh UGS: Fix an exception on shutdown due to the icon being hidden after it's already been disposed. Change 4158683 by Ben.Marsh UGS: Add an unhandled exception filter which sends the exception data to the backend. Change 4159131 by Ben.Marsh UGS: Reduce the number of characters displayed for build badges based on the available space. Change 4159194 by Graeme.Thornton TBA: Fix incorrect map property conversion code when converting an old property that contains a map with different key/value types Change 4159239 by Steve.Robb Improved readability and compliance with coding standards. Change 4159246 by Ben.Marsh UGS: Allow syncing projects where source code is not available (and various version files don't exist). #jira UE-60985 Change 4159286 by Ben.Marsh UGS: Remove requirement for UE4Editor.target.cs to be visible in the depot in order to open a project. #jira UE-60986 Change 4159302 by Ben.Marsh UGS: Update version to 1.144. Change 4160308 by Ben.Marsh All staging client executables for blueprint projects. #jira UE-60983 Change 4161567 by Steve.Robb GitHub #4816 : UE-60771: Handle escaped double quote in FParse::LineExtended Change 4162641 by Ben.Marsh UGS: Allow customizing the position of custom columns, via the Index=N attribute. Change 4162647 by Ben.Marsh UGS: Update version to 1.145. Change 4165319 by Robert.Manuszewski PR #4812: Fix inconsistent command-line argument handling under Windows (Contributed by adamrehn) Change 4166150 by Ben.Marsh UGS: Include *.inl when looking for code changes. Change 4166551 by Steve.Robb Whitespace fixes caused by a bad merge. Change 4168483 by Ben.Marsh UGS: Add a more useful error if a file to be synced exceeds the max allowed path length. Change 4168490 by Ben.Marsh UGS: Update version to 1.146. Change 4168551 by Ben.Marsh UBT: Move bBuildLargeAddressAwareBinary into an exposed setting. Change 4168560 by Ben.Marsh UBT: Remove static config variable for controlling which configuration of UHT to use. Change 4171296 by Ben.Marsh UGS: Move the check for overlong paths earlier. Change 4171531 by Ben.Marsh UBT: Fix exception if BuildConfiguration.xml contains an unknown category. Change 4183371 by Robert.Manuszewski Fix for a crash in Async Loading Graph's CheckCycles when GC kicks in on the game thread and forces ALT to exit early Change 4184312 by Ben.Marsh UGS: Update version to 1.148 Change 4184480 by Robert.Manuszewski Removing unused async loading stat Change 4186390 by Ben.Marsh UBT: Format XML validation errors in a format that allows double-clicking on the message in Visual Studio. Change 4188644 by Ben.Marsh UBT: Add the MakePathSafeToUseWithCommandLine() function to UBT. Change 4188647 by Ben.Marsh UBT: Fix exception in target receipt when architecture is null. Change 4189617 by Ben.Marsh Change FileSystemReference, FileReference and DirectoryReference objects to use OrdinalIgnoreCase comparisons without creating a separate copy of the string to compare. The filesystem does not use the invariant culture, and it can produce the wrong results in some cases (the ordinal comparison is faster, too). Change 4189740 by Ben.Marsh UAT: Remote code to build UnrealPak when packaging; we use the editor now. Change 4189860 by Ben.Marsh UGS: Make the filter for excluding automated lighting rebuilds more explicit. Change 4190082 by Ben.Marsh Fixes to allow enabling edit and continue for Windows builds. Have experienced quite a few VS crashes when testing it in editor; not yet recommended for general use. - Allow edit and continue for any configuration, not just debug. - Fixed PDB errors compiling files that use a shared PCH with edit and continue enabled. Path to the generated PDB file was using the wrong directory. - Removed code that tracks PDB output files, since they're modified multiple times during a build. - Enable debug information when compiling generated CPP files, since it causes errors if the shared PCH PDB doesn't have the same option. - Disable support for remote execution of steps that modify the PDB, since the same file has to be modified many times. Remote execution causes the PDB files to be corrupted. Unfortunately, this makes E&C builds significantly slower. #jira Change 4192949 by Ben.Marsh UBT: Minor tidy-up (merging UEBuildBinary.Build and UEBuildBinary.SetupOutputFiles) Change 4193218 by Ben.Marsh Fix formatting. Change 4197252 by Mike.Erwin UAT: Fix log output w/ correct count of non-code projects. #jira none Change 4197941 by Ben.Marsh UGS: Add support for DebugGame editors that have an executable with a DebugGame suffix. Change 4197964 by Ben.Marsh UGS: Prevent attempts to automatically reopen projects while a modal dialog is up, or the workspace is syncing. Change 4198144 by Ben.Marsh UGS: Prevent modal dialogs when login expires in P4, and prompt for password when hitting "retry". Change 4198413 by Ben.Marsh UGS: Always show the main window when launched manually, and run with -RestoreState when launched at startup. Also add a couple more places that save the visibility state, since logging off seems like it can terminate the process abrubtly. Change 4198779 by Ben.Marsh UBT: Allow generating manifests to any arbitrary locations with the -Manifest=<Path> argument. Change 4198825 by Ben.Marsh UBT: Move code to enumerate Slate runtime dependencies into the Slate module. Doesn't need to be done inside core UBT. Change 4199341 by Ben.Marsh UGS: Update version to 1.149 Change 4199642 by Chad.Garyet - Deprecate CISController - Add BuildController to replace CIS GET/POST for builds - Add LatestController, GET does what CIS/GET used to do - Change Latest/GET to return the last 25 builds filtered by project, rather than the last 5000 individual Ids - Latest/GET now returns "LatestData" object instead of array of longs - Updated EventMonitor to match all API changes - Fixed bug where IDs were getting reset to initial startup values every update loop Change 4199663 by Chad.Garyet CIS controller still needs to return an array of longs #jira none Change 4199680 by Ben.Marsh UGS: Update version to 1.150 Change 4200457 by Ben.Marsh Merging CIS fix for non-development configurations. Change 4200472 by Mike.Erwin UAT: fix -skipbuildclient param default It was defaulting to skipbuildeditor's value, likely a copy-paste error. #jira none Change 4202595 by Ben.Marsh Fix static analysis warning due to constant comparison against macro. Change 4203250 by Ben.Marsh UGS: Always show the "Sync Precompiled Editor" option, but disable it and show a tooltip explaining why if it is not available. Change 4206191 by Ben.Marsh Exclude editor target files from installed builds, since they leak info about DLLs that have been stripped out. Change 4213011 by Ben.Marsh UBT: Include contents of modified intermediate files in the log, to make it easier to debug hidden dependencies. Change 4213487 by Ben.Marsh UBT: Fix assumption that bPrecompile is equivalent to bBuildAllModules. This is no longer the case; they are now controlled by separate options. Should fix CIS errors building the editor. Change 4213609 by Ben.Marsh Ensure that strings formatted using FMicrosoftPlatformString::GetVarArgs() are always null terminated, whether we use the secure CRT or not. Change 4215971 by Ben.Marsh UBT: Remove action graph visualization code; no longer used. Change 4215996 by Ben.Marsh UBT: Remove unqiue id from all actions in the action graph. This is only used for printing debug info in the case of a (rare) cycle in the action graph, so just look it up when needed. Change 4216022 by Ben.Marsh UBT: Rename Crypto.cs to EncryptionAndSigning.cs to match the name of the class inside it, and move it under the System folder. Change 4216031 by Ben.Marsh UBT: Move all the action executors into their own folder in the project. Change 4216526 by Ben.Marsh Fix CIS warnings. Change 4216544 by Ben.Marsh Replace custom code to ensure FMicrosoftPlatformString::GetVarArgs() null terminates its buffer with Microsoft's standards-compliant implementation. Change 4216633 by Ben.Marsh Add support for UnrealPak plugins. * Project and plugin modules can now specify an array of supported programs in the "WhitelistPrograms" field of their module descriptors, to allow modules to be loaded by programs. * Programs can now load any runtime modules, as long as they are whitelisted. * Programs under the engine directory can now use a shared build environment, so that building with a project file does not cause output binaries to be output to the project directory. * UnrealPak is now always built by default when packaging * Convert UnrealPak to a modular configuration Change 4216736 by Ben.Marsh UnrealPak: Move "ExportDependencies" command into an editor commandlet, since it relies on the UObject system, asset registry, etc... Change 4217447 by Ben.Marsh Back out revision 50 from //UE4/Dev-Core/Engine/Build/InstalledEngineBuild.xml Change 4217451 by Ben.Marsh Back out revision 11 from //UE4/Dev-Core/Engine/Plugins/Developer/VisualStudioSourceCodeAccess/Source/VisualStudioSourceCodeAccess/VisualStudioSourceCodeAccess.Build.cs Change 4217617 by Ben.Marsh Back out changelist 4217451 Change 4222552 by Ben.Marsh Don't use #import <TypeLib> for VS source code accessor when building with Clang; it's not supported. Change 4222630 by Ben.Marsh UBT: Fix spam while generating project files if Clang isn't installed. Change 4223316 by Ben.Marsh UBT: Change the order in which Visual C++ toolchains are enumerated to prefer full releases over preview releases. Change 4223318 by Ben.Marsh UBT: Add a build setting which allows creating a dedicated PCH for every file that's excluded from the unity working set (disabled by default). Improves iteration times when working on individual cpp files, but slows down iterating on header changes (and can take a lot of disk space for large changes). Dedicated PCH contains all includes scraped from the top of each cpp file, until a non-#include directive is encountered. Change 4223401 by Ben.Marsh UBT: Add an option to automatically enable edit and continue for files in the adaptive non-unity working set. E&C doesn't seem very useful for UE4 projects right now; compile time is comparable to regular build times, but it can take several minutes to apply code changes for large projects. Change 4223899 by Ben.Marsh UBT: Fix loading XML config files on Mono; Type.GetField(Name) does not seem to return values unless binding flags are specified. Change 4224637 by Ben.Marsh Add a "SupportedPrograms" field to plugin descriptors, which allows plugins to declare which plugins they support independently of individual modules. Programs now respect the "bEnabledByDefault" setting in plugins. Plugins that are compatible with a program now need to list that program in the SupportedPrograms list, and whitelist any modules that should load for that program. Change 4224710 by Ben.Marsh UBT: Don't add import libraries as final build products unless the target is being precompiled. Prevents the need for building them for leaf nodes in the action graph. Change 4224715 by Ben.Marsh UBT: Remove hack to allow Stats2.cpp to not follow IWYU convention. Change 4224726 by Ben.Marsh Remove commented out line. Change 4224903 by Ben.Marsh Fix non-unity compile error in Stats2.h. Change 4225051 by Ben.Marsh Back out changelist 4224710; causing CIS errors due to receipts not matching. Change 4225134 by Ben.Marsh Fixing non-unity errors. Change 4225203 by Ben.Marsh Another non-unity fix. Change 4225249 by Ben.Marsh Fix Linux dependencies being copied for the Windows editor; they can be added as requirements for the Linux target platform on Windows instead, so it respects the user's chosen platforms. #jira UE-62001 Change 4225512 by Ben.Marsh BuildGraph: Allow setting the target to build when using the <CsCompile> task. Change 4228815 by Ben.Marsh UBT: Always add the generated code directory to the list of include paths when generating project files. It may only be created after UHT has been run. Change 4228944 by Ben.Marsh UBT: Remove legacy CppCompileEnvironment and LinkEnvironment wrappers from TargetRules that were deprecated in 4.19. Change 4229028 by Ben.Marsh UBT: Fix editor targets with unique build environment having the wrong executable path in generated project files. Move move logic to configure target rules post-construction by the rules assembly to ensure it's valid. Change 4229065 by Ben.Marsh UBT: Move another target setting into the rules assembly. Change 4229105 by Ben.Marsh Fix BPT exception when generating project files. Change 4229311 by Ben.Marsh UBT: Store the module rules file location on the ModuleRules instance, as well as the plugin that it was created from. Also expose the plugin directory as a property on the ModuleRules instance. Change 4229421 by Ben.Marsh UBT: Consolidate functionality for UHT module setup in ExternalExecution.cs. Change 4229817 by Ben.Marsh UBT: Modules must now explicitly specify the path to the header used to generate a PCH if one is desired, rather than the header being determined automatically by attempting to parse the source code. Now that PCHs are force-included anyway, this removes a lot of dependencies inside UBT. Change 4229824 by Ben.Marsh UBT: Remove unused lists inside UEBuildModuleCPP.SourceFilesClass. Change 4229841 by Ben.Marsh UBT: Remove some legacy code from auto-detecting PCHs. Change 4230521 by Ben.Marsh UBT: Add utility functions to the log class to allow formatting errors and warnings in Visual Studio output format (eg. File(Line): warning: Message) Change 4230871 by Ben.Marsh UAT: Remove StreamUtilis utility class; there is a simpler way to implement the one place it's used. Change 4230882 by Ben.Marsh UAT: Add StreamUtils back into UAT, seems like it's still used there. Change 4230896 by Ben.Marsh UBT: Remove some redundant parameters from UEBuildModule/UEBuildModuleCPP/UEBuildModuleExternal constructors. Change 4231014 by Ben.Marsh WorkspaceTool: Include a dump of raw bytes when garbage is read from the P4 process, for diagnostic purposes. Change 4231032 by Ben.Marsh Fix CIS. Change 4231096 by Ben.Marsh Bump the FlatCPPIncludeDependencyCache version, to prevent errors trying to load old files. Change 4231446 by Ben.Marsh UBT: Added support for expanding UE-specific variables in include paths and library paths: $(EngineDir), $(ProjectDir), $(PluginDir), $(ModuleDir). Change 4231460 by Ben.Marsh Modules may now explicitly specify rpaths on Linux via the PublicRuntimeLibraryPaths and PrivateRuntimeLibraryPaths properties. Change 4233909 by Robert.Manuszewski PR #4779: Reason fails as the supplied variable is incorrect (Contributed by projectgheist) Change 4233910 by Ben.Marsh Enable PCHs on IOS. Reduces build time by ~25%. Change 4234176 by Ben.Marsh UBT: Add better messaging for modules that need to have a private PCH set. Now detects the likely PCH using the same method as legacy code and includes it as a suggestion. Change 4234193 by Ben.Marsh Add the Delete command to Perforce wrapper in DotNETUtilities. Change 4234688 by Ben.Marsh UBT: Simplify handling of installed/precompiled builds. Settings for whether a folder is installed/read-only or not is now stored on the RulesAssembly instance, allowing multiple things to be configured separately and stacked together (eg. engine/enterprise/project). RulesAssembly.IsReadOnly() allows determining if a flie can be modified or not and replaces many previous IsXXXInstalledCalls(), and traverses the chain of assemblies. Change 4234711 by Ben.Marsh UBT: Runtime dependencies can now be copied to output directories as part of the build. When adding a runtime dependency, an optional source location can be specified to copy from. Both the source and target paths can use variables can be used as part of the path, eg. $(OutputDir), $(ModuleDir), $(PluginDir). Example usage (from a .build.cs file): RuntimeDependencies.Add("$(OutputDir)/Foo.dll", "$(PluginDir)/Source/ThirdParty/Foo.dll", StagedFileType.NonUFS); Change 4234872 by Ben.Marsh Expose a flag for whether the engine is installed, to fix issues generating project files. Change 4234929 by Ben.Marsh Fix null reference generating receipts when UBT makefiles are active. Change 4235883 by Chad.Garyet Merging 4231245 to core Giving Coordinator its own sln. This should fix what 4158155 was supposed to. #jira UE-61955 Change 4236075 by Ben.Marsh CIS fix Change 4237066 by Robert.Manuszewski Fix for a potential crash when terminating the engine while it's being initialized #jira UE-60545 Change 4237078 by Robert.Manuszewski The engine will no longer be resetting all linkers causing massive load times when renaming the world package when entering Play In Editor Change 4237116 by Ben.Marsh Rewrite some Windows utility functions to support paths longer than MAX_PATH. Change 4237158 by Ben.Marsh Add const TCHAR* overloads of FString::RemoveFromStart() and FString::RemoveFromEnd(). Change 4237159 by Ben.Marsh Fix FWindowsPlatformFile::GetFilenameOnDisk() support for paths longer than MAX_PATH, and simplify some of the other long path functions to avoid copying string buffers. Change 4239050 by Ben.Marsh Missing file Change 4239318 by Ben.Marsh Linux CIS fix. Change 4239685 by Ben.Marsh Static analysis CIS fix. Change 4240800 by Ben.Marsh WorkspaceTool: Include the full command line in the log for any P4 commands. Change 4240903 by Ben.Marsh PR #4909: Update copyright notices to 2018 (Contributed by projectgheist) Change 4241025 by Ben.Marsh UBT: Exclude mobile pipeline caches from generated project files. Causes huge slowdown when using 'Find in Files' through the IDE. Change 4241770 by Ben.Marsh UBT: Include action number in parallel executor output. #jira UE-62032 Change 4243469 by Ben.Marsh TBA: Merge FAnnotatedStructuredArchiveFormatter with FStructuredArchiveFormatter. Any functions that are only implemented for text archives now have a _TextOnly suffix, and are exposed through the FStructuredArchive interface. Change 4245723 by Robert.Manuszewski Fixing another creash when terminating the engine while initializing. #jira UE-60545 Change 4245862 by Steve.Robb VectorLoadFloat2(Ptr) added, which loads { Ptr[0], Ptr[1], Ptr[0], Ptr[1] } into a VectorRegister. Change 4246412 by Robert.Manuszewski The warning 'Calling StaticLoadObject during PostLoad may result in hitches during streaming' will now also report the object which had the PostLoad called on it when StaticLoadObject call happened. Change 4246612 by Ben.Marsh UBT: Fix spelling of "Intellisense". Change 4249454 by Robert.Manuszewski Added extra checks to catch scenarios where the EDL Precache Buffer is flushed before a package header is fully read Change 4249513 by Robert.Manuszewski Made sure the Async Loading Thread doesn't continue running after creating new async packages when garbage collector wants to run on the game thread Change 4255207 by Ben.Marsh UGS: Add additional logging whenever a P4 command fails, and when the user is logged out. Change 4255288 by Ben.Marsh PR #4921: Honor ModuleRules' bEnableExceptions flag when creating precompiled h. (Contributed by surakin) Change 4256422 by Ben.Marsh UBT: Add an error if a module referenced by a plugin descriptor doesn't exist. Change 4257385 by Robert.Manuszewski Creating new objects from within ForEachObjectWithOuter will now result in a fatal error as it's unsafe to change internal UObject hash tables when iterating over them. Change 4257454 by Robert.Manuszewski Added the option to filter clusters listed with gc.ListClusters by objects within them. Usage: gc.ListClusters Hierachy With=ObjectName1,ObjectName2... Change 4257526 by Robert.Manuszewski It's now possible to filter clusters that get logged with verbose cluster logging enabled (UE_GCCLUSTER_VERBOSE_LOGGING=1) by objects within them by specifying -DumpClustersWithObjects=ObjectName1,ObjectName2 in the command line Change 4257822 by Ben.Marsh Fixes for PlatformShowcase compile errors. Change 4258771 by Ben.Marsh UBT: Fix project files not being generated for foreign projects when creating .stub files. #jira UE-62462 Change 4258790 by Ben.Marsh UBT: Clean up the logic around generating project files before creating a stub IPA, so that it fails loudly if project files do not exist, and can accept target names not matching project names. Change 4259276 by Ben.Marsh UBT: Make it an error if a framework doesn't exist, rather than failing silently. Also remove some remote toolchain stuff that's no longer necessary. Change 4259280 by Ben.Marsh UBT: Fix embedded framework zips not being uploaded for plugins. #jira UE-62485 Change 4260236 by Ben.Marsh UBT: Fix path to generated engine project file. Change 4260334 by Ben.Marsh UGS: Fix custom build steps dialog inadvertantly modifying config file settings in-place. Change 4260361 by Ben.Marsh UGS: Allow for p4 login commands to fail, even though the user is logged in (due to a bad connection, etc...) Change 4260559 by Ben.Marsh UGS: Update version. Change 4261160 by Robert.Manuszewski MediaPlaylist will now be added to root set if the owning MediaPlayer is in the disregard for GC set (fixes GC assumption violation crash) #jira UE-62495 Change 4261421 by Ben.Marsh Force-sync files for building documentation, to fix issues with files not being updated. #jira UE-62413 Change 4261425 by Ben.Marsh UBT: Remove some leftover functions for handling the remote toolchain. Change 4261530 by Ben.Marsh UBT: Speculative fix (and better error reporting) for IOS mobile provision not being found in CIS. Change 4261611 by Ben.Marsh UBT: Downgrade warning to a log message, since it appears when generating project files. Change 4261710 by Ben.Marsh Remove assert that GLogConsole is set; it won't be for command line utilities that don't depend on ApplicationCore. #jira UE-62545 Change 4261831 by Ben.Marsh Fix compile errors due to missing include path when hot-reloading a module from the editor. There are not necessarily source files to compile when -modulewithsuffix is specified on the command line, which was results in GeneratedCodeWildcard not being set. #jira UE-62463, UE-62384 Change 4262723 by Ben.Marsh Whitelist plugins that need to be loaded by UFE. #jira UE-62564 Change 4265444 by Ben.Marsh Fix incorrect executable name for DebugGame configurations in Xcode. #jira UE-62574 Change 4265892 by Ben.Marsh Fix incremental compile failures due to dependency checking for unity files. CachedIncludePaths was not correctly being set on file items, so dependencies were being ignored. #jira UE-62575, UE-62603, UE-62597 Change 4266019 by Josh.Adams - Fixed the CopyAction for runtime dependencies that need to be copied to different location, on non-XGE Change 4266264 by Ben.Marsh Remove override for the __IPHONE_OS_VERSION_MIN_REQUIRED macro on TVOS. This macro is already defined by system headers (in <AvailabilityInternal.h>). Now that we support PCHs on IOS and TVOS, manually defining this macro results in it being defined three times (once for the PCH, once by AvailabilityInternal.h, and once by the force-included list of definitions for the source file being built). The errors for redefining the macro in AvailabilityInternal.h are suppressed due to it being a system header, but the error for redefining it for the source file being compiled are not. #jira UE-62578 Change 4266273 by Ben.Marsh Fixes incremental build failure when compile arguments for PCH have changed on IOS/TVOS. Compile action needs to have a dependency on PCH build action. Change 4266614 by Graeme.Thornton Fix crash when cooking nativized blueprints due to removal of child cooker system. Change 4266763 by Ben.Marsh Always build UnrealPak when building client targets. The ProjectParams.Pak option is not reliable, because it can be forced on later by the target platform. #jira UE-62584 Change 4267985 by Robert.Manuszewski When iterating with ForEachObjectWithouter, don't lock the entire has table but only the hash bucket that is currently being iterated #jira UE-62600 Change 4268558 by Robert.Manuszewski PurgeLegacyBlueprints will no longer be called from within ForEachObjectWithOuter is it renames objects that reside in hash tables that are being iterated over which may lead to undefined behavior. #jira UE-62600 Change 4269011 by Chad.Garyet - Fixing Wildcard match issue, the change to ugsapi sends projects as //Depot/Stream instead of //Depot/Stream/ Wildcard match was only substringing to 3 chars. - Checking in the change a while back that increases the number of queried jobs up to 432 based on some maths from Bob about how many builds we want to grab Published to ugsapi server 8/8/17 #jira none Change 4270788 by Ben.Marsh Fix IOS provisioning data being using when remote compiling on TVOS. #jira UE-62705 Change 4271916 by Ben.Marsh Tag the XGEControlWorker executable as a build product after compiling SCW, to make sure it's included in the UGS zip file. Change 4271934 by Ben.Marsh Upload all static libraries in plugin folders as part of remote builds. #jira UE-62694 Change 4273368 by Ben.Marsh Fix Slate dependencies not being enumerated, and rules assembly not being rebuilt when building remotely. #jira UE-62705 Change 4274049 by Ben.Marsh Always parse the team UUID out of the mobile provision when doing a remote compile. The provision installed on the remote Mac (and selected for signing) may be different. #jira UE-62751 Change 4274823 by Ben.Marsh Add the -VersionCookedContent argument to disable the -unversioned parameter on the cooker command line. Change 4275838 by Ben.Marsh Fix BuildVersion string not being passed through from <SetVersion> task. Also add a -BuildVersion command line argument to UBT to override it for a particular build. Change 4275913 by Ben.Marsh Add a dummy exported symbol to the XGEController module, to fix build errors due to missing .lib file when it's built with WITH_XGE_CONTROLLER = 0. Change 4284161 by Ben.Marsh Allow mirroring Oodle files to remote Mac. Change 4074774 by Steve.Robb Vast simplification of TFunction, making it smaller in footprint, easier to follow and extend, and more correct. TUniqueFunction added, which is a move-only TFunction which can hold move-only functors. Fix for UWidgetBlueprint::ForEachSourceWidget() which should never have compiled but did. FFunctionGraphTask and TFuture<> updated to use TUniqueFunction to make them more general. TArray::HeapPop() made to work with move-only types. Change 4082591 by Ben.Marsh Move the Log class from UBT to DotNetUtilities. Change 4083236 by Ben.Marsh Add a Log.WriteException() method to dump an exception message to the console (and write the exception trace to the log) Change 4084107 by Ben.Marsh UAT: Remove the unused -SkipHeader argument to UE4Build. Change 4089771 by Steve.Robb GitHub #4743 : modified VirtualAlloc function flag https://blogs.msdn.microsoft.com/oldnewthing/20151008-00/?p=91411 Change 4091456 by Steve.Robb Unification of all platforms' FMath::CountTrailingZeros() and FMath::CountLeadingZeros() for both 32-bit and 64-bit. Change 4156437 by Ben.Marsh Lots and lots of fixes compiling for Clang on Windows. Editor now compiles cleanly without warnings, but crashes on startup due to error in intrinsics test. Disabling that runs further, but crashes accessing freed memory. Switching to the ANSI allocator runs further, but crashes in Slate after the splash screen and before the editor window opens. // TODO! * Switching between Clang/ICL/VS2015/VS2017 is now supported through the same mechanism as switching Visual Studio versions, without requiring any source level changes. To use Clang, set WindowsPlatform.Compiler = WindowsCompiler.Clang from a .target.cs file, or set <WindowsPlatform><Compiler>Clang</Compiler></WindowsPlatform> from BuildConfiguration.xml. To pick a specific toolchain version, set WindowsPlatform.CompilerVersion. * Clang is now supported through AutoSDKs; will be added to CIS. * The Samples/Sandbox/Clang project forces Clang to be used from its target.cs file, and allows easily building all editor modules and plugins with Clang on Windows. * UnrealMathSSE intrinsics have been re-enabled for Clang due to missing functions from the UnrealMathFPU implementation, but causes failure in tests at startup. * SSE4_CRC32() is disabled in D3D12Pipelinestate.cpp, since intrinsics are only allowed if enabled for the whole target (rather than being used in specific functions due to runtime checks) Change 4157389 by Ben.Marsh Few more fixes for compiling the editor with Clang. Change 4183911 by Ben.Marsh Fixes to support incremental linking on Windows. Does not seem to have any net benefit right now; may improve once minimal rebuild is enabled. * Incremental linking no longer forces PDB files to be enabled for source files. * Actions can specify specific files to be deleted before each build. Code to forcibly delete PDB files has been moved to the MSVC toolchain. * Unused libraries produced by the cross-referenced link are no longer added as build products, since (a) deleting them breaks dependency checking for incremental linking and causes a full link, and (b) not deleting them breaks UBT dependency checking and causes actions to be run over and over again. * Icon update is disabled for Windows when incremental linking is enabled. * Removed rarely-used setting to always delete produced items before each build. Change 4184311 by Ben.Marsh UGS: Added a dialog which shows all the required platform SDKs for a branch, linked from the status panel in UGS. The llist is configured via the UGS config file submitted to Engine/Programs/UnrealGameSync/UnrealGameSync.ini (and may be overridden by the project config file if necessary): [Default] ; Set this to a network share which contains the SDK installers for your site SdkInstallerDir= ; All the required SDKs for the current version of the engine +SdkInfo=(Category="Android", Description="NDK r21", Browse="$(SdkInstallerDir)\\Android") +SdkInfo=(Category="Windows", Description="Visual Studio 2017") +SdkInfo=(Category="Windows", Description="Visual C++ Toolchain 14.13.26128") +SdkInfo=(Category="Windows", Description="Windows SDK 10.0.16299.0") Similar entries for console platforms are added in console subdirectories. Each entry may contain an Install="Foo.exe" and/or Browse="C:\Foo" style attribute, specifying the path to an installer to run or directory to open in explorer respectively. The SdkInstallerDir setting is used as a base directory for the default installers, seen above for Android. Licensees may override this with a network path specific to the site that UGS is being deployed to (either in this file, in a project specific config file, or in a Engine/Programs/UnrealGameSync/NotForLicensees/UnrealGameSync.ini file). Change 4200452 by Ben.Marsh UBT: Change DebugGame configurations to output a separate executable rather than requiring a -Debug argument at runtime. Previous behavior was a common source of errors. Engine modules are still shared between Development and DebugGame, but the launch module sets a flag in Core on startup indicating the game configuration. Change 4206189 by Ben.Marsh UBT: Simplify logic for precompiling binaries. * Target no longer has separate list of "precompile only" binaries or modules. New -AllModules option allows adding every module to a target, which can be used with -Precompile and -NoLink to precompile object files for monolithic builds. * Precompiled file lists have been removed from target receipts. * The manifest now includes all generated headers and precompiled files when run with the -Precompile option. * Separate -DependencyList=Foo.txt has been added to write a list of all dependencies required to use precompiled binaries. This file list can be read using the <Tag> task in buildgraph. Change 4215466 by Ben.Marsh UBT: Remove indirect calls to determine extensions for object files and precompiled headers. The toolchain knows the correct convention for the platform. Change 4215975 by Ben.Marsh UBT: Remove telemetry code. This has never proved useful for analyzing performance due to the number of incidental factors that affect build times (eg. number of files being compiled). Change 4220154 by Ben.Marsh Move text-only implementations of FOutputDeviceError back into Core, so we can build command-line applications that don't depend on ApplicationCore. Change 4224708 by Ben.Marsh Add a bCompileAgainstApplicationCore setting to the target rules, which allows compiling out references to the ApplicationCore module (which should only be necessary for applications with a GUI). Removed ApplicationCore from several engine tools and utilities. Change 4224958 by Ben.Marsh Remove CoreMinimal.h includes from Core. Change 4229059 by Ben.Marsh UBT: Remove the UEBuildPlatform.ShouldNotBuildEditor() hook for target platforms. We shouldn't be modifying a target's build environment to disable the editor; it is invalid to build the editor for these target platforms at all, and this is already enforced by the GetSupportedPlatforms() function. Change 4230508 by Ben.Marsh Fixup precompiled header setting for samples and games. Change 4231457 by Ben.Marsh Fix exceptions in log messages having trailing newlines. Change 4232406 by Ben.Marsh UBT: Always force include a PCH for generated code if there's one set; the code may depend on it to compile. Change 4234177 by Ben.Marsh Set up private PCH files everywhere that previously used them. Change 4235973 by Ben.Marsh Change FPlatformMisc::GetEnvironmentVariable() to return an FString() rather than requiring a fixed size buffer to be passed in. Removes references to MAX_PATH. Change 4238842 by Ben.Marsh Add support for paths longer than MAX_PATH in the editor. Requires Windows 10 version 1607, and the functionality to be enabled via a registry key or group policy (see https://docs.microsoft.com/en-us/windows/desktop/FileIO/naming-a-file). Only a subset of Win32 functions support long paths (executables can only be started from paths shorter than MAX_PATH, for example). * Added a FPlatformMisc::GetMaxPathLength() function to return the maximum length of a path on the current system. On Windows, this returns a different value for systems with long paths enabled to those without. * The MAX_PATH define is no longer set by non-Windows platforms. Instead, there is a MAC_MAX_PATH, UNIX_MAX_PATH, etc... for any platform-specific code that still relies on the previous macro. * The MAX_UNREAL_FILENAME_LENGTH macro has been renamed to MAX_UNREAL_FILENAME_LENGTH_DEPRECATED * The PLATFORM_MAX_FILEPATH_LENGTH macro has been renamed to PLATFORM_MAX_FILEPATH_LENGTH_DEPRECATED. * Removed custom resource files for programs, since they are just copies of the base UE4 one (which is used by default anyway). The base UE4 manifest declares support for long paths. * Fix 512 character maximum length on editor commands. 260 character limit remains in place for cooking at the moment (see ContentBrowserUtils.h), until C# staging code supports long paths. Change 4255042 by Ben.Marsh UBT: Remote compilation now uploads the entire workspace to the remote Mac and executes a separate remote instance of UBT rather than synchronizing individual actions. This makes the remote compile codepath much simpler, and removes a lot of special cases that exist to support it previously. The list of files to be transferred to the remote are listed as rsync filter rules in Engine/Build/Rsync/RsyncEngine.txt and RsyncProject.txt, which are applied to the root engine directory and project directory respectively. Projects that need to customize which files are uploaded can add their own <ProjectDir>/Build/Rsync/RsyncProject.txt file, which will be included in the filter before the default version. Change 4260567 by Ben.Marsh UAT: Rename CommandUtils.Log to CommandUtils.LogInformation, to avoid conflicts with the underlying Tools.DotNETCommon.Log class. #rb none [CL 4285673 by Ben Marsh in Main branch]
2018-08-14 18:32:34 -04:00
LogInformation("Starting Client....");
var SC = CreateDeploymentContext(Params, false);
ERunOptions ClientRunFlags;
string ClientApp;
string ClientCmdLine;
SetupClientParams(SC, Params, ClientLogFile, out ClientRunFlags, out ClientApp, out ClientCmdLine);
// Run the client.
if (ServerProcess != null)
{
RunClientWithServer(SC, ServerLogFile, ServerProcess, ClientApp, ClientCmdLine, ClientRunFlags, ClientLogFile, Params);
}
else
{
RunStandaloneClient(SC, ClientLogFile, ClientRunFlags, ClientApp, ClientCmdLine, Params);
}
}
}
#endregion
#region Client
private static void RunStandaloneClient(List<DeploymentContext> DeployContextList, string ClientLogFile, ERunOptions ClientRunFlags, string ClientApp, string ClientCmdLine, ProjectParams Params)
{
if (Params.Unattended)
{
string LookFor = "Bringing up level for play took";
bool bCommandlet = false;
if (Params.RunAutomationTest != "")
{
LookFor = "Automation Test Succeeded";
}
else if (Params.RunAutomationTests)
{
LookFor = "Automation Test Queue Empty";
}
else if (Params.EditorTest)
{
LookFor = "Asset discovery search completed in";
}
// If running a commandlet, just detect a normal exit
else if (ClientCmdLine.IndexOf("-run=", StringComparison.InvariantCultureIgnoreCase) >= 0)
{
LookFor = "Game engine shut down";
bCommandlet = true;
}
{
string AllClientOutput = "";
int LastAutoFailIndex = -1;
Copying //UE4/Dev-Platform to //UE4/Dev-Main (Source: //UE4/Dev-Platform @ 3120366) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 2714591 on 2015/10/02 by Ben.Marsh Initial branch of files from Engine-Main (//UE4/Engine-Main) to Dev-Platform (//UE4/Dev-Platform) Change 2916715 on 2016/03/21 by Daniel.Lamb First pass at splitting out build cook run into into seperate scripts. Change 2948322 on 2016/04/19 by Nick.Shin update libwebsockets to v1.7.4 part 4 of 4 - doing this in stages for tracking purposes #jira UEPLAT-1246 - Update libWebsockets #jira UEPLAT-1221 - update websocket library #jira UEPLAT-1204 - Rebuild libwebsockets with SSL Change 2970016 on 2016/05/07 by Nick.Shin undo all of the following upgrades: - zlib - openssl - libcurl - libwebsockets and reset webrtc #jira UE-30298 - Fortnite and Orion crash on login Change 3059693 on 2016/07/21 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3061151 on 2016/07/22 by Niklas.Smedberg Fast ASTC texture compression, using ISPC. #jira UE-32308 Change 3061428 on 2016/07/22 by Peter.Sauerbrei Back out changelist 3061151 as it wasn't approved for submission Change 3061970 on 2016/07/22 by Steve.Cano Adding AdMob interstitital ad support for Android, including Blueprint functions #jira UE-33286 #ue4 #android Change 3062160 on 2016/07/22 by Mark.Satterthwaite Fix the fix for handling RHISetStreamSource overriding stride on Metal - not all MTLVertexDescriptors are equally hashable so do this ourselves. #jira UE-33355 Change 3062770 on 2016/07/24 by Brent.Pease UE-32397 Error Message displays as Unknown Error when failing to supply a Remote Build server for ios on Windows Change 3063227 on 2016/07/25 by Dmitry.Rekman Update hlslcc cross-compile after libc++ change. Change 3063314 on 2016/07/25 by Jeff.Campeau Xbox One DLL loading Receipts can be read back by request for target info Change 3063329 on 2016/07/25 by Mark.Satterthwaite CL #3046743 was breaking other samples in unexpected ways after a recent Main merge, so make a Metal-specific change to the shader instead and amend the MetalBackend to better match HLSL's handling of NaN/inf with common single-precision float intrinsics. This is sufficient to fix the AtmosphericFog and the recent regressions. #jira UE-33600 #jira UE-33028 #jira UE-27879 #jira UE-25802 Change 3063492 on 2016/07/25 by Brent.Pease UE-23846 - iOS Movie Player can't handle videos at resolutions that aren't multiples of 16 UE-33200 - A movie isn't played on iOS occasionally. Change 3063729 on 2016/07/25 by Dmitry.Rekman Linux: enable XGE on all platforms. #tests Cross-compiled a number of Linux targets on Windows. Change 3063732 on 2016/07/25 by Dmitry.Rekman Fixed formatting (spaces->tabs) in previous change. Change 3063750 on 2016/07/25 by Daniel.Lamb Added code to dump the cook modification delegate loads to log. Fixed the memory usage output log. #test cook paragon. Change 3063804 on 2016/07/25 by Daniel.Lamb Added cookpartialgc additional commandline option to uat. #test UFE Change 3064008 on 2016/07/25 by Mark.Satterthwaite For non-shipping builds conditionally bind a default uniform buffer in Metal and report an error if the slot was unbound, if our validation layer is enabled attempt to report the shader source in question. This relies on the shader compiler providing accurate information about uniform buffer bindings and won't fix all occurances of bad uniform usage (if a buffer is bound but too short the result will be GPU restarts or an error in Apple's validation layer - we can't detect this case) but will help debug the typical error of leaving an active slot unbound. #jira FORT-27685 Change 3064141 on 2016/07/25 by Jeff.Campeau Rebuild vpxmd.lib with delayed codegen disabled (fixes linker warning building Win64). Change 3065024 on 2016/07/26 by Nick.Shin Change filetype remove exclusive check out bit requested by or.coheni & nick.penwarden Change 3065274 on 2016/07/26 by Jonathan.Fitzpatrick DirectoriesToAlwaysStageAsUFS now properly filters out *.uasset and *.umap files This prevents the bug where cooked assets get trampled by staging their uncooked version on top of them during the UFS step Added a file filter to DirectoriesToAlwaysStageAsUFS for uasset and umap. Change 3066338 on 2016/07/27 by Mark.Satterthwaite Handle releasing an SRV/UAV & the source object within a single Metal command-buffer. #jira UE-33779 Change 3066789 on 2016/07/27 by Daniel.Lamb Realtime mode does not save any packages anymore unless they are ready. #test cookontheside, cookbythebook shooter game Change 3066847 on 2016/07/27 by Jeff.Campeau Fix define #2634 #jira UE-33813 Change 3068868 on 2016/07/28 by Mark.Satterthwaite Extend hlslcc's handling of switch-statements to allow implict casts from scalar bool, half & float as HLSL itself permits while also making sure it errors if the expression input is not scalar. This fixes shader compile errors in UT. Change 3070040 on 2016/07/29 by Dmitry.Rekman Delete Nadzorca. Change 3070947 on 2016/07/29 by Jeff.Campeau Perforce C++ API 2015.2 (includes debug libraries) Change 3073707 on 2016/08/02 by Daniel.Lamb Derived data cache commandlet runs resolve string asset references to load any string asset refereced packages from the map. Also process async results from shaders being compiled so they can have their memory resources released. #test DerivedDataCache commandlet shootergame. Change 3076613 on 2016/08/03 by Brent.Pease + UnrealTargetConfiguration is now passed into deploy and package methods + The UIRequiredDeviceCapabilities plist key now only considers the architectures from the corresponding target configuration (shipping or development) Change 3076668 on 2016/08/03 by Brent.Pease Back out changelist 3076613 Change 3077157 on 2016/08/04 by Daniel.Lamb Fixed up DLC staging so that it stages to the proper mount point. Fixes up include engine content in DLC staging paths. #test Made up shooter game DLC Change 3077191 on 2016/08/04 by Daniel.Lamb More smartly process async shader compilation if we are waiting for it. #test cook on the side shooter game cook by the book shooter game. Change 3077412 on 2016/08/04 by Mark.Satterthwaite Fix "iOS Metal-based build crashes at launch with sub-levels": - Slate should not bind the null RHI texture from an unitialised texture atlas - atlases only have a valid texture pointer once an entry has been added to them and in the template projects an empty sub-level doesn't add anything. - To prevent this kind of bug resurfacing and being so hard to track down add Metal shader binding validation to our validation layer as Apple's is incomplete on iOS and won't warn us about nil texture usage which causes these GPU restarts. This requires reworking our vertex declaration handling to be more efficient so that we can cache the pipeline reflection data as well as the pipeline objects. - Fix validation error of texture reallocation on loading template projects under Metal. #jira UE-30847 Change 3077958 on 2016/08/04 by Brent.Pease + UnrealTargetConfiguration is now passed into deploy and package methods + The UIRequiredDeviceCapabilities plist key now only considers the architectures from the corresponding target configuration (shipping or development) Change 3079503 on 2016/08/05 by Mark.Satterthwaite Initialise more variable types to 0 in Metal shaders to workaround Xcode 8 toolchain no longer doing this for us for "threadgroup shared" variables. Everything but structs and atomic's will now be initialised. #jira UE-33856 Change 3079737 on 2016/08/05 by Jeff.Campeau Add support for delay load DLLs on Xbox One Turn off warnging for missing PDBs to match VCToolchain.cs Change 3081005 on 2016/08/08 by Mark.Satterthwaite Fix-up Metal device name on AMD for macOS 10.12 which reports it correctly and enable tiled reflections on Intel from macOS 10.12 too as they now work. Change 3081557 on 2016/08/08 by Daniel.Lamb File-> Package saves all packages before starting packaging. #test File package first person template Change 3082215 on 2016/08/09 by Lee.Clark PS4 - Added 4k profile Change 3082412 on 2016/08/09 by Daniel.Lamb Fixed cook on the fly server not handling cook requests. #test Cook on the fly shooter game. Change 3082955 on 2016/08/09 by Dmitry.Rekman Linux: convert existing Strcat() uses to Strncat(). - Strcat() does not check destination size so can silently corrupt memory. While this was not observed, this conversion removes this concern altogether. Change 3083772 on 2016/08/10 by Luke.Thatcher [PLATFORM] [PS4] [+] Checking in PS4CrashHandler files so we have a copy in Perforce rather than just on the server. - Taken from \\devweb-02 and removed all the unused files/dependencies. - Created a publish profile pointing to \\devweb-02\Sites\PS4Services\PS4CrashHandlerDev so I'm not writing over the existing deployed crash handler. - Moved all code in the Page_Load event to inside the check for the HTTP method (POST) otherwise GET'ing the page from a browser will generate crash folders that hang around forever. Change 3085450 on 2016/08/11 by Lee.Clark PS4 - Fix mediaplayer pipeline allocation Change 3086360 on 2016/08/11 by Michael.Trepka Fixed a non-unity build error in Mac UnrealFrontend Change 3087224 on 2016/08/12 by Luke.Thatcher [PLATFORM] [PS4] [~] Refactor PS4 Crash Handler site - Removed CoreDumpHandler. Processing dump files is handled directly by an async thread within the aspx process. - Separated configuration values into their own class. Currently set to output to a testing directory, rather than the actual crash reporter landing zone. - Added a debug upload page to allow manual submission of .orbisdmp/.txt settings files, accessible by GET'ing Default.aspx. - Added logging. Logs self-delete after 30 days. Testing required before we switch to the new system. #jira UE-34504 #jira OR-26886 Change 3087626 on 2016/08/12 by Dmitry.Rekman PR #2689: Fix copying/duplicating failing on Linux (UE-34586). - Contributed by Web-eWorks. Change 3087991 on 2016/08/12 by Mark.Satterthwaite Initial AVFoundation implementation of Media Framework for Mac, iOS & tvOS. - Video playback occurs via AVPlayerItemVideoOutput's attached to the AVPlayerItem's output. This means gathering video samples is trivial. - Metal texture updates occur by wrapping the texture object provided by AVF - for Mac this is simple as it can bind to the IOSurface directly, for iOS/tvOS we have to create a CVMetalTextureCache and allocate our texture from there. - OpenGL and OpenGLES currently have to lock the pixel buffer and upload to a texture the old fashioned way - this should be revisited when there is time. - Subtitles/Captions are captured using AVPlayerItemLegibleOutput which also connects to the AVPlayerItem's output. - On Mac audio samples are returned by manually reading from the stream using an AVAssetReaderTrackOutput, including manual seeking and synching. - On iOS/tvOS the audio is played directly by AVPlayer because the IOSAudio system can't handle procedural buffers - otherwise it could reuse the Mac code. - AVFoundation does not support AVI - that's an obsolete Microsoft/Windows file-format. - Only 'file://' URLs are supported - streaming would require a totally different audio solution (using MTAudioProcessingTap) and has many more edge and failure cases that would need to be handled. #jira UE-34315 Change 3088790 on 2016/08/15 by Luke.Thatcher [PLATFORM] [PS4] [~] Hook new PS4 crash handler up to the crash reporter website. - Removed indentation from generated crash context XML file. The crash reporter process does manual XML parsing which doesn't correctly handle whitespace at the start of lines. - Switched the final output folder to match the one the crash reporter process is watching. - Hide upload form on a config variable. #jira UE-34504 #jira OR-26886 Change 3089060 on 2016/08/15 by Luke.Thatcher [PLATFORM] [PS4] [!] Change PS4 crash handler log file extension to ".ps4chlog", otherwise the crash reporter site attaches the wrong log file to the crash report. Allowed showing of debug upload form via "Default.aspx?showform=1" query string. #jira UE-34504 #jira OR-26886 Change 3089089 on 2016/08/15 by Mark.Satterthwaite Duplicated changes to AppleMovieStreamer from CL #3088149. #jira UE-34315 Change 3089460 on 2016/08/15 by Mark.Satterthwaite Duplicate CL #3080971: Workaround a macOS 10.12 Beta bug on some Metal drivers that can't initialise temporary/local variable arrays, only those that are marked threadgroup shared. #jira UE-34355 Change 3089465 on 2016/08/15 by Mark.Satterthwaite For Metal shader translation retain more precision for float constants -1.0f >< 1.0f by emitting them in scientific notation - prevents Hammersley constant amongst others from being flushed to 0. Change 3089902 on 2016/08/15 by Daniel.Lamb Changed the next compiling ID to the correct compiling ID. #test Cook Change 3089903 on 2016/08/15 by Daniel.Lamb Cooker monitors config useage during cook and uses those settings to invalidate cooked content instead of all config settings. Change 3090114 on 2016/08/16 by Luke.Thatcher [PLATFORM] [PS4] [~] Minor change to PS4 settings text on crash handler site. Change 3090949 on 2016/08/16 by Nick.Shin WebSocketNetDriver crash fix filled in missing chunk of code that calls PacketHandler's "packet modifiers" #jira UE-25492 HTML5 Client cannot connect to Windows Server #jira UE-30880 WinServer crashes when NetDriver is set to WebSocket and Client attempts to connect via websocket #code.review john.pollard john.barrett Change 3091265 on 2016/08/16 by Brent.Pease Add IOS support to HarfBuzz Change 3091267 on 2016/08/16 by Brent.Pease Add references to fix mono build Change 3091291 on 2016/08/16 by Nick.Shin CIS warning fix #jira UE-25492 HTML5 Client cannot connect to Windows Server #jira UE-30880 WinServer crashes when NetDriver is set to WebSocket and Client attempts to connect via websocket Change 3091781 on 2016/08/17 by Joe.Barnes UE-33640: Exposed UPrimitiveComponent::IsAnyRigidBodyAwake() to Blueprints. Change 3092687 on 2016/08/17 by Daniel.Lamb Added support for using binned allocator in cooker instead of tbb. #test Cook shootergame. Change 3093867 on 2016/08/18 by Mark.Satterthwaite Use a read/write mutex to protect access to Metal's internal shader pipeline caches so that parallel threads can progress in the common case where new shaders are not being compiled. Change 3093950 on 2016/08/18 by Mark.Satterthwaite Change the Mac GPU identification code to cope with AMD's new naming scheme on 10.12. Change 3093951 on 2016/08/18 by Mark.Satterthwaite More SCW threads on Mac - they work now. Change 3093960 on 2016/08/18 by Mark.Satterthwaite Increase the default number of command-buffers on Mac because bigger games overflow the current limit of 64 per queue. Change 3096493 on 2016/08/22 by Jeff.Campeau Use Xbox version of DirectX include. Change 3097509 on 2016/08/23 by Luke.Thatcher [PLATFORM] [PS4] [+] Refactor PS4 Symbol Publish - Moved the SymStore task from Win.Automation to BuildGraph.Automation, and made it more generic. - The specifics of uploading symbols are now implemented in the platform tool chain, alongside StripSymbols(). - Re-generated the build graph schema file. - Removed the old PS4 symbols upload path in the package step. Modified OrionBuild.xml to publish symbols for all PS4 dev, test and shipping config builds of OrionClient. Change 3097635 on 2016/08/23 by Luke.Thatcher [PLATFORM] [PS4] [+] Refactor Age Symbols task in UAT. - Moved the AgeStore task from Win.Automation to BuildGraph.Automation and made it more generic. - Symbol server directory structure is now defined by the platform tool chain, which the common task uses to clean out old symbols. - Added a "filter" parameter to prevent age tasks deleting symbols from unrelated builds in shared symbol servers. Modified OrionBuild.xml to age both the Windows and PS4 symbol stores. Change 3097713 on 2016/08/23 by Luke.Thatcher [PLATFORM] [PS4] [+] Enable new PS4 crash handler server - Created live deployment profile and applied the required config file changes. Change 3099214 on 2016/08/24 by Luke.Thatcher [PLATFORM] [PS4] [!] Fix compile error in PS4 tool chain. For some reason, this only breaks ocassionally. Maybe we're alternating between the 2013 and 2015 C# compilers depending on what initiates the build (e.g. Visual Studio vs GenerateProjectFiles)? Change 3099222 on 2016/08/24 by Luke.Thatcher [PLATFORM] [PS4] [+] Added PS4 support for FPlatformMisc::MessageBoxExt using the MsgDialog library. - Note, only one and two button message dialogs are supported (limitation of MsgDialog). Change 3099260 on 2016/08/24 by Luke.Thatcher [PLATFORM] [PS4] [~] Better PS4 exit function. Calls quick_exit instead of abort when we've not asserted. Allows for a "cleaner" forced exit without generating a crash dump. Change 3101192 on 2016/08/25 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3101944 on 2016/08/25 by Daniel.Lamb Ask to save the current level when we are using launch on. Change 3102036 on 2016/08/25 by Nick.Shin check for minimum expected size upon data received from network #jira UE-13657 - HTML5 plugin OnRawRecieve overflow Change 3102115 on 2016/08/25 by Brent.Pease - Fix small errors that probably only show up in the mac mono build #code.review peter.sauerbrei Change 3102747 on 2016/08/26 by Jeremiah.Waldron Re-submitting OnlineSubsystemGameCircle with TPS permission for Amazon SDK - Also fixed the plugin to remove any related files from the final package when IAP is disabled or GameCircle support itself is disabled with the plugin still enabled - Added support for new AlreadyOwned IAP response code as well which is already used for GooglePlay and IOS Change 3102900 on 2016/08/26 by Nick.Shin since last checkin (CL: 2981945) - prints are crashing the browser - this change will allow browser to print the details via console.log() #jira UE-26047 - HTML5 HTTP Response Headers not implemented Change 3103130 on 2016/08/26 by Brent.Pease UE-24679 - Enable the ability to change ports for a firewall to pass them through rsync Change 3103225 on 2016/08/26 by Daniel.Lamb Fixed issue with warning which would cause crash. Change 3103425 on 2016/08/26 by Dmitry.Rekman Enable offscreen GL rendering without X. - Added new video subsystem to SDL that is uses EGL to initialize the context. - Most windoing functions stubbed. - Also added a new test case to TestPAL for easier debugging. Change 3104743 on 2016/08/29 by Brent.Pease Support remote offline metal shader compilation Change 3105051 on 2016/08/29 by Brent.Pease UE-2382 - TASK: MobleMVP: iOS: Add ability to view iOS device console output in the editor UFE - IOS Automation will now create a thread to collect the console logs from the device and send them to C# Console output while the app is running on device - Made ProcessResult an interface (IProcessResult) which ProcessResult implements. This allows platforms to provide their own implementation if needed. - Moved the RunLoop related parts of CoreFoundation into MobileDevice.cs Change 3105053 on 2016/08/29 by Brent.Pease - IOS dll's as part of the last check-in Change 3106853 on 2016/08/30 by Jeff.Campeau Implement FD3D11DynamicRHI::RHICreateComputeFence to prevent memory overwrite Change 3107361 on 2016/08/30 by Dmitry.Rekman Renderer: changes to allow postproc delegates. Change 3107362 on 2016/08/30 by Dmitry.Rekman Plugin with a CUDA postproc example. - Linux version only. Runs under a headless GL too (without X). - Disabled during cross-compilation, can be compiled natively only. - CUDA kernel should be compiled separately, CMakefile with compilation attached (can be used to generate VStudio projects as well). - To test the output, run under the debugger, interrupt and set global variable GSaveTheOutput to 50 (this will write out kernel output buffer 50 times as .bmp files into working directory). Change 3107913 on 2016/08/31 by Daniel.Lamb Fixed loading of cooked content in the editor. Change 3107916 on 2016/08/31 by Daniel.Lamb Added error case when shader compilation fails to notify shader. #test Cook shooter game. Change 3108080 on 2016/08/31 by Josh.Adams - Fixed PS4Automation compile errors Change 3109077 on 2016/08/31 by Brent.Pease Fix C# debug builds by specifying x64 and add reference to MobileDeviceInterface Change 3110086 on 2016/09/01 by Dmitry.Rekman Fix race condition in PThread runnable (UE-35074). - Instead of relying on busy-wait, join the threads. This prevents race between PostRun() (executed in the context of the thread) and FPThreadRunnableThread() destructor (see UE-34909). - Do not use an invalid value for pthread_t, since there's none. Change 3110172 on 2016/09/01 by Dmitry.Rekman Fixed a crash exiting VR Preview on Windows GL4 (UE-28708). - PR #2188 submitted by ardneran. Change 3110313 on 2016/09/01 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3111134 on 2016/09/01 by Dmitry.Rekman UBT: prevent mono from hanging on Ctrl-C. - Sometimes Ctrl-C can cause thread creation to fail. Without this change, UBT would lock up. Change 3111171 on 2016/09/01 by Brent.Pease Move all C# projects to use the x64 Platform for consistency with other changes made to move to the x64 Platform Change 3111177 on 2016/09/01 by Dmitry.Rekman Fix Linux build on systems without CUDA (UE-35460). Change 3111548 on 2016/09/02 by Luke.Thatcher [PLATFORM] [PS4] [!] Fix for PS4 iterative deployment. - Changes in Dev-Mobile broke the deployment manifests, as PS4 was now using the wrong filename when creating delta and obsolete file lists. Change 3111863 on 2016/09/02 by Dmitry.Rekman Better fix for build without CUDA (UE-35460). Change 3112738 on 2016/09/02 by Mark.Satterthwaite Fix the pausing particles on Metal - one line bug in the Metal query implementation meant that the first query wouldn't return the correct result for no good reason. #jira UE-34989 Change 3114579 on 2016/09/06 by Chris.Babcock Fix Vulkan include path in NDK check (contributed by geediiiiky) #jira UE-35490 #github #2758 #ue4 #android Change 3115115 on 2016/09/06 by Jeff.Campeau Calculate buffer size for paks using the bitwindow override as needed Change 3115600 on 2016/09/07 by Luke.Thatcher [PLATFORM] [PS4] [~] Make the crash dump handler registration much earlier, to catch crashes in early engine init. - Fixed up places in FGenericCrashContext::SerializeContentToBuffer which used the command line. If we crash early, the command line may not have been initialized yet. - Added a GetNoInit function to FThreadHeartBeat to avoid creating the heart beat thread if we crash early, and the thread doesn't exist yet. Tested by calling abort() immediately inside int main(), and we get a valid crash dump that the crash handler service can consume. Change 3115676 on 2016/09/07 by Luke.Thatcher [PLATFORM] [~] Dev-Platform integration fix for original CL 3064888 in //Orion/Release-29.1 Add .exe and .dll to windows symbol upload file filters. Change 3115811 on 2016/09/07 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3115944 on 2016/09/07 by Michael.Trepka Implemented IsGamepadAttached() for Mac Change 3115948 on 2016/09/07 by Michael.Trepka Don't try to restore Help menu item on Mac if MenuBlock does not contain it Change 3116200 on 2016/09/07 by Jeff.Campeau Fix parameter ordering Change 3117660 on 2016/09/08 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3117728 on 2016/09/08 by Michael.Trepka Copy of CL 3117698 by Mike.Fricker Fixed regression with editor's Simulate mode where cursor would teleport back to the center of the viewport after every click - This bug was introduced in CL 3075932 from a borderless window cursor handling fix that was needed for games that capture the cursor Change 3117797 on 2016/09/08 by Peter.Sauerbrei Shader Resource compression Change 3117988 on 2016/09/08 by Brent.Pease - Solutiion generator will now pick x64 instead of AnyCPU for the default platform configuration - Fix what I think was a merge error in BuildGraph.cs Change 3118296 on 2016/09/08 by Daniel.Lamb Fixed crash with launch on. Couldnt' correctly detect previous generated ini settings. #test launch on QA game #jira UE-35741 Change 3118438 on 2016/09/08 by JohnHenry.Carawon Fix UAT compilation on Linux #UE-35745 Change 3118934 on 2016/09/08 by Jeff.Campeau Shader compression setting based on target platform instead of cooking host platform. #jira UE-35753 Change 3120190 on 2016/09/09 by Ben.Marsh Add missing Platform attribute to build script for Dev-Platform. [CL 3120378 by Josh Adams in Main branch]
2016-09-09 20:13:41 -04:00
IProcessResult ClientProcess = null;
FileStream ClientProcessLog = null;
StreamReader ClientLogReader = null;
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 4285612) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3836829 by Ben.Marsh UBT: Fix ability to precompile plugins from installed engine builds. Change 3839519 by Ben.Marsh UBT: Simplify configuring bPrecompile and bUsePrecompile settings for modules. Each rules assembly can now be configured as installed, which defaults the module rules it creates to use precompiled data. Change 4042043 by Steve.Robb GitHub #4705 : Added weak lambda's for delegates and multicast delegates. Change 4042056 by Robert.Manuszewski Optimized Mark Phase of GC by up to 10ms by making it run in parallel and removing a huge array presize which we didn't need. Change 4042104 by Robert.Manuszewski Set the minimum GC cluster size to 5 so that GC doesn't have to process micro clusters which are more expensive than processing individual objects + Exposed the minimum cluster size to ini and project settings as gc.MinGCClusterSize + Added the ability to sort clusters by name/object count/mutable object count/referenced clusters count when dumping them with gc.ListClusters command Change 4042377 by Robert.Manuszewski Reworked how GC and other threads (ALT specifically) interact - GC will now notify the ALT it wants to run and ALT will immediately try to finish its current work to allow that. Also the entire ALT tick is now protected against GC running at the same time to improve ALT stability. + added gc.ForceCollectGarbageEveryFrame console variable that triggers a forced GC every frame Change 4042427 by Robert.Manuszewski Changed FGCCSyncObject to use events when waiting for GC to finish so that it doesn't spin on non-game threads when GC is running Change 4042482 by Robert.Manuszewski Unhashing unreachable objects (ConditionalBeginDestroy) will now also be done incrementally, just like the purge phase of Garbage Collection Change 4042635 by Robert.Manuszewski Fix for a potential assert when incremental purge garbage is pending and something forces a full purge Change 4044092 by Steve.Robb Fix for forward declared CoreUObject weakobject types in delegates when building in Clang. Change 4044102 by Robert.Manuszewski Fix for a possible hang when worker threads are preventing GC from running and something is later trying to FlushAsyncLoading with the Async Loading Thread enabled Change 4044113 by Steve.Robb Another Clang fix. Change 4044160 by Robert.Manuszewski Disregard For GC pool will now be enabled by default in cooked builds Change 4044287 by Steve.Robb Typo fix. Change 4047723 by Graeme.Thornton TBA: Fixes for import/export name cache and object resolving Change 4048015 by Graeme.Thornton TBA: Weak/Soft/Lazy pointer serialization changes * Remove FWeakObjectPtr::Serialize, move it's logic into, and replace usages of with calls to, FArchiveUObject::SerializeWeakObjectPtr(). Ensures that something is always sent to the archive so that structured archives can be kept happy in the future. * Added Weak/Soft/Lazy pointer handling to the structured archive slot interface and all the formatters. Binary formatters just forward the call onto their inner and text archives store as a string path reference. * FArchiveUObjectFromStructuredArchive caches all these pointer types and stores indices in the binary block, same as with a UObject*. All pointers are then forwarded to the underlying formatter in one go on finalization. Change 4048021 by Steve.Robb Fix for binding an unbound TFunction to another TFunction with a different signature. Also all null pointers now count as unbindings, not just nullptr. TIsMemberPointer added. TIsATFunction and TIsATFunctionRef renamed to remove the 'A's. Change 4048544 by Robert.Manuszewski Fixing ConditionalBeginDestroy profiling after changes to incremental CBD. Change 4051028 by Graeme.Thornton TBA: ArchiveFromStructuredArchive adapter uses Inner to determine if it is outputting to text, and sets it's own ArIsTextFormat to false Change 4051056 by Graeme.Thornton TBA: High level tagged property / UObject base class text serialization - UObject serialize converted to structured archive - Properties written to text individually with text tags, and then binary adapted values - Only saves, doesn't load Change 4051111 by Graeme.Thornton TBA: Temporarily disable loading of text assets until tagged property serialization path is fixed up Change 4051154 by Graeme.Thornton TBA: Convert a few uobject serializers to structured archive format for example purposes Change 4051181 by Graeme.Thornton TBA: Added default structured archive implementation of SerializeItem to UProperty, which just calls the FArchive version on an FArchiveUObjectFromStructuredArchive adapter. Implemented structured archive SerializeItem for UArrayProperty Change 4051197 by Graeme.Thornton TBA: ObjectProperty text serialization Change 4051216 by Graeme.Thornton Restored a modified FWeakObjectPtr::Serialize function to keep backwards compatibility in code I don't have access to. Change 4051261 by Graeme.Thornton TBA: Convert UMetaData to structured archive Change 4051374 by Steve.Robb Incorrect assert removed. Change 4051562 by Robert.Manuszewski Adding stats for the new GC internal functions Change 4051614 by Graeme.Thornton TBA: Removed UProperty::SerializeItem(FArchive, ...) and replaced with UProperty::SerializeItem(FStructuredArchive::FSlot, ...). Fixed up most of them to work properly and added adapters in for any that were non-trivial. Change 4052512 by Graeme.Thornton TBA: Temporary workaround for softobjectptr and lazyobjectptr uproperties not serialization anything when they know the archive is a reference collector. They should always be serializing their pointers and letting the underlying archive itself ignore them. Change 4053917 by Robert.Manuszewski Clustered objects from clusters that are no longer reachable will now be marked as unreachable immediately when gathering unreachable objects Change 4053919 by Robert.Manuszewski Added the ability to disable incremental BeginDestroy in ini/project settings Change 4055518 by Daniel.Lamb Fixup for deterministic audio generation issue. Submitted on behalf of Rich.Whitehouse #jira nojira #test prefilght automated test. Change 4056854 by Graeme.Thornton TBA: Added a test asset to EngineTest which contains all the different property types and test cases. Change 4056858 by Graeme.Thornton TBA: Updated USetProperty to proper structured archive usage Change 4056872 by Graeme.Thornton TBA: Add map property field to test object Change 4056873 by Graeme.Thornton TBA: Convert UMapProperty to full structured archive Change 4056994 by Graeme.Thornton TBA: Converted FText over to structured archive. Implemented saving, but not loading. Change 4059728 by Ben.Marsh UBT: Add support for using adaptive non-unity builds when the engine and project are in separate repositories. Change 4059805 by Graeme.Thornton Fixed typo in text serialization. Fixes CIS automation test errors Change 4060007 by Graeme.Thornton TBA: FArchiveFromStructuredArchive will now access it's host slot lazily, i.e. only when a value is actually written to the archive. Change 4060092 by Stefan.Boberg Added optimized Windows console window output path to GenericConsoleOutput since this slowed down cooking considerably (2 minutes spent in wprintf alone for one large dataset) When stdout is attached to a console we use the WriteConsoleW function instead of wprintf since the latter is very slow especially in unbuffered mode which the engine currently configures for stdout (see setvbuf call in LaunchEngineLoop.cpp). At some point we should reconsider this buffering policy since it's likely to slow down other platforms as well but I wanted to do a safe change for now as I don't yet fully understand why the setvbuf call is there in the first place. Change 4060108 by Stefan.Boberg Introduced some additional target platform utilities to help with asset cook optimizations * We now assign each ITargetPlatform a zero-based ordinal value * Introduced FTargetPlatform and FTargetPlatformSet types to help store platform references and platform sets efficiently. These are not currently used in the engine but are designed to replace the existing ITargetPlatform/string/FName representations in the cooking data structures. Change 4060143 by Graeme.Thornton Undo //UE4/Dev-Core/Engine/Source/Runtime/... changelist 4060007 Needs some other changes that I haven't checked in yet... Change 4062432 by Ben.Marsh Fix error message when enumerating P4 changes. Change 4062648 by Ben.Marsh Add missing p4 integration action. Change 4063620 by Graeme.Thornton Integrated a fix from UDN where the engine would crash when trying to load a very small encrypted file (<16bytes) from a pak file, where the read address wasn't already aligned to the AES block size. (https://udn.unrealengine.com/questions/431989/crash-while-reading-a-very-small-file-in-encrypted.html) Change 4066963 by Robert.Manuszewski Fixing GC cluster verification code reporting false positives when a cluster is referencing another cluster through 'mutable' objects list. Change 4067133 by Robert.Manuszewski Changed log verbosity when reporting individual cases of GC cluster assumption violations as they are followed by an asser anyway and this way we get the chance to see all issues before we assert at the end of these checks. Change 4067443 by Steve.Robb FString can now be constructed from any char pointer type and length. Change 4068156 by Steve.Robb Fix necessary because of FString constructor change in CL# 4067443. Change 4070258 by Graeme.Thornton Fixes for VSCode Change 4070372 by Graeme.Thornton TBA: Script struct serialization to structured archives Change 4071913 by Ben.Marsh Move bulk of the code for UnrealPak into an engine developer module, so it can be used in the editor. Change 4071914 by Ben.Marsh Missing files. Change 4071937 by Ben.Marsh Missing header. Change 4072015 by Ben.Marsh Fixes for compiling PakFileUtilities as part of the editor. Change 4072826 by Steve.Robb TBitArray::Reserve() added. TBitArray::Add() overloaded to allow adding multiple bits. TSparseArray::Reserve() optimized to call the overloaded Add(). Change 4073271 by Daniel.Lamb Fixed add patch tier in project launcher passing the wrong commandline option to UAT. #test none Change 4074708 by James.Hopkin #core Removed redundant Casts Change 4074763 by Steve.Robb Fix for TSparseArray::Reserve() size. Change 4076063 by Ben.Marsh Add an "UnrealPak" commandlet with the same functionality as the standalone UnrealPak program. Invoke by running the editor with -run=UnrealPak and the standard UnrealPak commandline options. Change 4077064 by Robert.Manuszewski Fixing compile error in PakFileUtilities Change 4077144 by Graeme.Thornton TBA: TextAssetCommandlet improvements * Collect lists of broken assets during roundtrip tests and print a summary of packages that failed each phase at the end * After resaving as text, load the file back as a plain JSON hierarchy to ensure the output was valid Change 4077412 by Ben.Marsh Set the correct exit code for UnrealPak. Should return 0 on success, not 1. Change 4077760 by Graeme.Thornton TBA: Loading fixed for tagged property serialization Includes conversion of all UProperty::ConvertFromType() and SerializeFromMismatchedTag() functions to use structured archives Lazy initialization of FArchiveFromStructruredArchive when loading, to support the possibility of an adapter being create around an object property serialize call to its inner UStruct, which then decides not to do anything and return false. Stops the ArchiveFromStructuredArchive from consuming the slot and getting upset later on when we try to serialize normal tagged properties from it. Disabled lazy bulk data loading from text assets. Requires a bigger change to make it work. Added some debug checks to json input formatter which track the current value stack size when a new object is pushed onto the stack, and makes sure that the stack has returned to the same size when the object is popped. Catches cases where we unpack an array/stream to the value stack but then don't consume all the items. Change 4078800 by Ben.Marsh Change UAT to using the editor's UnrealPak commandlet rather than invoking the standalone UnrealPak executable. To improve performance when building several PAK files, also add a new -batch=<file> command which reads commands to execute in parallel from a text file. Change 4079745 by Graeme.Thornton TBA: Migrated a couple of UObject Serialize functions to FStructuredArchive (SoundCue / MaterialExpressions / Editor strip flags) Change 4079847 by Graeme.Thornton TBA: Add 'FindMismatchedSerializers' mode to text asset commandlet, which dumps out a list of all UClasses which don't have the CLASS_MatchedSerializers flag, meaning we can't guarantee the have Serialize functions for FArchive AND FStructuredArchive, therefore we can't use the new structured archive based serialize path. Should only ever be native instrinsic classes as UHT takes care of all other cases. Change 4079925 by Ben.Marsh Fix incorrect assignment when deriving name for chunked pak file. Change 4080214 by Ben.Marsh Move the ThreadPoolWorkQueue class into DotNETUtilities so it can be used by other projects. Change 4082394 by Graeme.Thornton CIS fix for variable shadowing warning Change 4082583 by Ben.Marsh Add a IBinarySerializable interface for types that support reading from a BinaryReader and writing to a BinaryWriter. Implementing IBinarySerializable implies a constructor taking a BinaryReader argument is available for deserializing. Change 4082652 by Ben.Marsh Fix FileReference.Directory not returning a directory with a trailing backslash for files in the root directory. Change 4082755 by Graeme.Thornton Fixed an erroneous usage of TUniquePtr<uint8>as a pointer to a uint8 array when creating pak files. Caused a crash when compression was enabled, and has probably surfaced because pak generation is now done by an editor commandlet rather than a standalone program. Change 4082756 by Graeme.Thornton Fixed some incorrect documentation for pakfile compressed chunk headers Change 4082883 by Graeme.Thornton Static analysis warning fix Change 4082912 by Ben.Marsh Move ExceptionUtils into DotNETUtilities. Change 4085291 by Graeme.Thornton TBA: In the Json output formatter, write float and double values out with enough precision for successful roundtripping. Added some debug only code which will immediately reconvert the string back to its original value and compare the the input Change 4085523 by Graeme.Thornton TBA: Remove only explicit usage of DECLARE_FSTRUCTUREDARCHIVE_SERIALIZER. Should only be used from UHT generated code. Change 4086037 by Robert.Manuszewski Fix for a potential race condition when two threads want to acquire GC lock Change 4088655 by Graeme.Thornton Pak creation now uses the bEnablePakSigning setting from the crypto config json file Change 4091474 by Steve.Robb Fix for TStaticBitArray::FindFirstSetBit() and TStaticBitArray::FindFirstClearBit(). Unused variables removed. Change 4093632 by Steve.Robb CIS fixes. Change 4093656 by Graeme.Thornton Build fix Change 4093744 by Ben.Marsh Allow per-chunk settings for whether to enable compression in UnrealPak. Change 4099712 by Gil.Gribb UE4 - Fixed rare case where insufficient space was preallocated for cooldown ticks. #jira UE-59686 Change 4099912 by Stefan.Boberg Cooking timer optimizations: - Replaced data structures for FScopeTimer and FHierarchicalTimerInfo. Previous implementation used FString for many things and caused *lots* of heap and string concatenation activity. Replaced with a compile-time node id (using __COUNTER__) and raw string literals. - Removed PERPACKAGE_TIMER support (was disabled by default and was difficult to test) - Made it possible to toggle OUTPUT_TIMING and ENABLE_COOK_STATS independently - Removed some extremely tight timers because the overhead from calling QPC significantly exceeded the measured code This change shaved some 15% off a clean cook of Fortnite WindowsClient (en) with fully populated local DDC Change 4100519 by Stefan.Boberg Quick fix for Linux build issue introduced in 4099927 Change 4105327 by Stefan.Boberg Cooker: Changed FHierarchicalTimerInfo so it uses a linked list for tracking child nodes, to be able to deal with any child count. Previously we assumed there would never be more than 9 children but it turns out there are cooker modes that need more. Fixes check when using -FullLoadAndSave to cook Change 4105448 by Stefan.Boberg - Fixed Linux build warning re: member initialization order - Also eliminated OUTPUT_HIERARCHYTIMERS/CLEAR_HIEARCHYTIMERS macros (plain functions are fine) - Moved finishing-up code for FullLoadAndSave() to TickCookOnTheSide() call site to improve timer output. Previously some of the scopes would not have been closed before printing and thus the output was misleading. Change 4109031 by Ben.Marsh Attribute-driven Perforce wrapper (old Epic Friday project). Offers a more complete implementation than the current P4 wrapper in UAT without requiring any platform-specific libraries. Uses the Python binary output for parsing. Change 4109588 by Ben.Marsh UBT: Add extension methods for serializing a nullable type to a BinaryReader/BinaryWriter. Change 4109595 by Ben.Marsh Missing project file for DotNETUtilities. Change 4110724 by Stefan.Boberg Removed annotation map locking in UObjectMarks, eliminating around one minute (~3.5%) from Fortnite cook time. The locking was redundant since the annotation maps are managed per thread anyway. Change 4111304 by Ben.Marsh UAT: Add support for setting a status message through the log class. Allows writing transient messages (eg. progress messages) which will be cleared out before writing other messages. Best used through the LogStatusScope class, which can set a status message for the duration of a using() block. As part of this change, the console no longer has to be added as a dedicated trace listener. Since we already special-case this listener when formatting log output, it's easier to just keep the implementation separate to the other trace listeners. Change 4112708 by Steve.Robb Fix for TBitArray::MaxBits in assignment. Change 4114133 by Stefan.Boberg Tweaked how low-level memory (LLM) tracker is implemented to reduce overheads. Previously FMemory functions would acquire the LLM singleton and call OnLowLevelFree/OnLowLevelAlloc etc which would check the bIsDisabled flag and early out if it was set. Due to how frequently these functions were called this ended up costing quite a bit. - This change makes the flag a static member variable instead of a member variable and therefore enables a simpler early-out to be implemented. - The singleton getter is also simplified to avoid hitting the threadsafe singleton construction path on every call. - The enable flag is no longer TAtomic - this also incurs extra overhead for no clear benefit Shaves approximately 3.5% (one minute) off a Fortnite cook test scenario (using -FullLoadAndSave) Change 4115010 by Robert.Manuszewski Fixing CIS Change 4115249 by Robert.Manuszewski Fixing async loading code asserts when exiting game very early due to an error #jira UE-56267 Change 4117091 by Ben.Marsh Prevent doubled-up lines when writing status updates with console log verbosity. Change 4117207 by Ben.Marsh UGS: Do not include executables in diagnostics zip file, and ignore "no such files" error when cleaning workspace. Change 4119175 by Ben.Marsh UGS: Fix crash writing version files when directory does not already exist. Change 4119987 by Ben.Marsh UGS: Show a dialog box while the launcher is updating executables from Perforce, which allows cancelling the operation if necessary. Allow setting the username on the settings window, and prompt for login credentials if necessary. Should prevent situations where users have to update settings from the command prompt. Holding down shift during launch now shows the settings dialog rather than an immediate prompt to launch the unstable version (unstable version is shown as a checkbox on this dialog). Change 4119991 by Ben.Marsh Update version number for UGS launcher to 1.13. Change 4121943 by Robert.Manuszewski Don't use FArchiveAsync2 for reading packages with non-async path in editor builds as its performance is worse than the standard archive's (saves about 1 minute when doing larger cooks and 7 seconds when loading into PIE) Change 4122592 by Steve.Robb GitHub #4762 : Improve wording and grammar of Math comments Also includes improved accuracy in FMath::ComputeBoundingSphereForCone(). Change 4122819 by Stefan.Boberg Don't call CreateDirectory redundantly when opening files for writing using FFileManagerGeneric::CreateFileWriter This change avoids calling IPlatformFile::CreateDirectoryTree if possible since this is a very expensive function especially for deep hierarchies as it performs directory creation from the root directory onwards instead of from the leaf downwards. That function should also be fixed but this change improves performance in the meantime. Change 4122872 by Stefan.Boberg CreateDirectoryTree now creates directories leaf-to-root instead of the other way around. This is much more efficient since we don't spend time on system API calls for directories which already exist. This accounted for a very large amount of CPU time in cooking as the full target file directory hierarchy would be "created" for every single output file. Change 4123109 by Stefan.Boberg - Disable overlapped I/O in editor / cooker. Synchronous I/O reduces the number of syscalls and Windows performs prefetching on our behalf anyway for sequential reads - Eliminated syscall which was issued for every write to update cached file size -- since we're the only writers to the file (file access allows read sharing at most) we can authoritatively update the file size on write completion Change 4123455 by Ben.Marsh PR #4775: New build param PCHMemoryAllocationFactor to set /Zm VS build param. (Contributed by lucaswall) Change 4124207 by Ben.Marsh UBT: Remove some unnecessary indirection for generated code paths. Change 4124217 by Ben.Marsh UBT: Remove another unused variable from UEBuildModuleCPP. Change 4124377 by Stefan.Boberg In IPlatformFile::DeleteDirectoryRecursively, attempt to delete file first and if it fails clear the readonly flag and try again Previously there was a call to clear the readonly flag for every deleted file and this is a waste of resources 99% of the time. The SetFileAttributes call accounted for a significant amount of time during cooker sandbox directory deletion Change 4125071 by Stefan.Boberg Some tweaks to FQueuedThreadPoolBase scheduling and memory management - Explicitly pass in false for TArray::RemoveAt(..., bool bAllowShrinking) argument to prevent memory reallocation when arrays are drained and inevitably repopulated shortly afterwards - Use a MRU strategy instead of LRU when picking a thread to wake up. The MRU thread is the most likely to have a 'hot' cache for the stack etc. Picking from the back of the array also happens to be cheaper since no memory movement is necessary when RemoveAt is called. (This was the strategy in place before CL2600362 which seems to have changed it unintentionally) - Release lock as soon as a thread has been chosen, before asking the worker thread to wake up and do the work Change 4126132 by Ben.Marsh UAT: Detect when stdout is redirected and prevent using backspace characters to move the cursor. Change 4126867 by Graeme.Thornton TBA: Fix tagged binary formatter Change 4127010 by Robert.Manuszewski AnimScriptInstances created at runtime will now also be added to the owning omponent's cluster to avoid GC issues. Change 4127932 by Ben.Marsh WorkspaceTool: Reduce unnecessary logging of status messages when console output is not redirected. Change 4129050 by Ben.Marsh UGS: Check for NET Framework 4.5 being installed before running the installer. Also fix warning trying to kill existing UGS instances before upgrade. Change 4129459 by Graeme.Thornton TBA: TextAssetCommandlet - When outputting converted assets to an output path, replicate the workspace relative path in the output directory Change 4129515 by Graeme.Thornton TBA: Add EnterRecord overload that allows outputting of available field names when loading. Change 4129517 by Graeme.Thornton TBA: Tagged properties are written out as named fields on the "Properties" record, rather than as a stream with a null tag at the end Change 4129518 by Graeme.Thornton TBA: Added a local const bool to allow easy hacking out of text asset loading support Change 4129558 by Graeme.Thornton TBA: Build fix for textasset-less configs Change 4129614 by Ben.Marsh UGS: Main window is now restored to normal size when activated by clicking on the tray icon. #jira UE-60490 Change 4129618 by Ben.Marsh UGS: Speculative fix for unreproduced exception accessing disposed window while shutting down. Change 4131936 by Robert.Manuszewski Removing some WIP code accidentally checked in with CL #4121943 Change 4133490 by Ben.Marsh UGS: Allow the $(Change) variable to be used in more places than just the context menu. #jira UE-60573 Change 4133550 by Ben.Marsh UGS: Setting for whether or not to use incremental builds is now exposed through the variable "$(UseIncrementalBuilds)" for use by custom build steps. #jira UE-60554 Change 4133681 by Ben.Marsh UGS: A per-project list of folders and extensions to be deleted by default when running the 'clean workspace' tool can now be specified through the <ProjectDir>/Build/UnrealGameSync.ini file. Settings may be specified for an individual branch (via a category with the depot path to the project) or for wherever the project is currently open (via the [Default] category). The SafeToDeleteFolders list specifies a substring that will be checked against folder paths. Anything containing this folder will be marked as safe for delete by default. The SafeToDeleteExtensions list specifies a list of extensions for files that can always be deleted. Example: [Default] +SafeToDeleteFolders=/MyGame/Test/ +SafeToDeleteFolders=/DataService/ +SafeToDeleteExtensions=.xx1 +SafeToDeleteExtensions=.xx2 #jira UE-60575 Change 4135449 by Ben.Marsh Fix allowing use of Job objects on Windows platforms (debug code submitted by mistake) Change 4135730 by Ben.Marsh UBT: Plugins can now be enabled and disabled from the .target.cs file (for targets that do not use the shared compile environment), by compiling the list of enabled/disabled plugin names into the Projects module. Change 4135823 by Ben.Marsh UBT: Remove legacy code to handle disabling optional plugins; now that this is compiled into the target, it will work for any plugins we choose. Change 4135945 by Ben.Marsh UBT: Fix error running programs with no explicitly enabled or disabled plugins. Change 4137207 by Ben.Marsh UGS: Align all badges with the same name, to make it easier to see which CIS steps are being run. Allow overriding the slot taken by a particular badge by calling it "SlotName:LabelName". Change 4137311 by Stefan.Boberg Removed child cooker support. In practice it is not a useful feature as it provides no performance improvement (quite the opposite in fact) and adds testing and maintenance complexity. Change 4137393 by Ben.Marsh UGS: Fix display of multiline errors in the status panel. Change 4141708 by Steve.Robb GitHub #3631 : Incorrect default argument in WeakObjectPtrTemplate #jira UE-45490 Change 4146655 by Stefan.Boberg Removed FullGCAssetClasses logic - no longer necessary nor useful Change 4147318 by Ben.Marsh UGS: Compress build badges in a column if it shrinks below the size that they would be visible. Change 4148207 by Ben.Marsh UGS: Added support for showing the latest completed build from a specific list of badges in the status panel. To declare a badge as one that should appear in the status panel rather than the CIS column, add it to the project's UnrealGameSync.ini in the project or [Default] section like so: +ServiceBadges=RoboMerge Change 4148282 by Stefan.Boberg Fixed bug in UCookOnTheFlyServer::GetCookOnTheFlyUnsolicitedFiles - UnsolicitedFiles should be passed by reference not by value Change 4148344 by Stefan.Boberg Fixed minor indentation error (most likely caused by sloppy merge) Change 4148521 by Stefan.Boberg Removed accidentally checked in PRAGMA_DISABLE_OPTIMIZATION from CookOnTheFlyServer.cpp Change 4148639 by Ben.Marsh UGS: Fix tooltips not showing for changes that have description badges. Change 4149373 by Ben.Marsh UGS: Allow adding additional columns to display particular badges by adding entries from the project config file. Example syntax: +Columns=(Name="Desktop",MinWidth=50,DesiredWidth=100,Weight=3,Badges="Editor") +Columns=(Name="Mobile",MinWidth=50,DesiredWidth=100,Weight=3,Badges="IOS,Android") Same form can be used to control how default columns are displayed (though badge settings are ignored). Also allow PerforceMonitor to detect local changes to project config files and update settings automatically. Change 4149399 by Ben.Marsh UGS: Update version to 1.143. Change 4155660 by Steve.Robb PROJECTION and PROJECTION_MEMBER macros which provide the correct behavior when creating projections using functions which are overloaded or use default arguments. Change 4157117 by Ben.Marsh Fix warning due to plugins disabled in .target.cs file. Change 4158011 by Ben.Marsh UBT: Add a check that the UnrealHeaderTool target file exists, rather than throwing an exception when reading it fails. Change 4158646 by Ben.Marsh UGS: Fix exception when login is discovered to have expired during a workspace update. Change 4158678 by Ben.Marsh UGS: Fix an exception on shutdown due to the icon being hidden after it's already been disposed. Change 4158683 by Ben.Marsh UGS: Add an unhandled exception filter which sends the exception data to the backend. Change 4159131 by Ben.Marsh UGS: Reduce the number of characters displayed for build badges based on the available space. Change 4159194 by Graeme.Thornton TBA: Fix incorrect map property conversion code when converting an old property that contains a map with different key/value types Change 4159239 by Steve.Robb Improved readability and compliance with coding standards. Change 4159246 by Ben.Marsh UGS: Allow syncing projects where source code is not available (and various version files don't exist). #jira UE-60985 Change 4159286 by Ben.Marsh UGS: Remove requirement for UE4Editor.target.cs to be visible in the depot in order to open a project. #jira UE-60986 Change 4159302 by Ben.Marsh UGS: Update version to 1.144. Change 4160308 by Ben.Marsh All staging client executables for blueprint projects. #jira UE-60983 Change 4161567 by Steve.Robb GitHub #4816 : UE-60771: Handle escaped double quote in FParse::LineExtended Change 4162641 by Ben.Marsh UGS: Allow customizing the position of custom columns, via the Index=N attribute. Change 4162647 by Ben.Marsh UGS: Update version to 1.145. Change 4165319 by Robert.Manuszewski PR #4812: Fix inconsistent command-line argument handling under Windows (Contributed by adamrehn) Change 4166150 by Ben.Marsh UGS: Include *.inl when looking for code changes. Change 4166551 by Steve.Robb Whitespace fixes caused by a bad merge. Change 4168483 by Ben.Marsh UGS: Add a more useful error if a file to be synced exceeds the max allowed path length. Change 4168490 by Ben.Marsh UGS: Update version to 1.146. Change 4168551 by Ben.Marsh UBT: Move bBuildLargeAddressAwareBinary into an exposed setting. Change 4168560 by Ben.Marsh UBT: Remove static config variable for controlling which configuration of UHT to use. Change 4171296 by Ben.Marsh UGS: Move the check for overlong paths earlier. Change 4171531 by Ben.Marsh UBT: Fix exception if BuildConfiguration.xml contains an unknown category. Change 4183371 by Robert.Manuszewski Fix for a crash in Async Loading Graph's CheckCycles when GC kicks in on the game thread and forces ALT to exit early Change 4184312 by Ben.Marsh UGS: Update version to 1.148 Change 4184480 by Robert.Manuszewski Removing unused async loading stat Change 4186390 by Ben.Marsh UBT: Format XML validation errors in a format that allows double-clicking on the message in Visual Studio. Change 4188644 by Ben.Marsh UBT: Add the MakePathSafeToUseWithCommandLine() function to UBT. Change 4188647 by Ben.Marsh UBT: Fix exception in target receipt when architecture is null. Change 4189617 by Ben.Marsh Change FileSystemReference, FileReference and DirectoryReference objects to use OrdinalIgnoreCase comparisons without creating a separate copy of the string to compare. The filesystem does not use the invariant culture, and it can produce the wrong results in some cases (the ordinal comparison is faster, too). Change 4189740 by Ben.Marsh UAT: Remote code to build UnrealPak when packaging; we use the editor now. Change 4189860 by Ben.Marsh UGS: Make the filter for excluding automated lighting rebuilds more explicit. Change 4190082 by Ben.Marsh Fixes to allow enabling edit and continue for Windows builds. Have experienced quite a few VS crashes when testing it in editor; not yet recommended for general use. - Allow edit and continue for any configuration, not just debug. - Fixed PDB errors compiling files that use a shared PCH with edit and continue enabled. Path to the generated PDB file was using the wrong directory. - Removed code that tracks PDB output files, since they're modified multiple times during a build. - Enable debug information when compiling generated CPP files, since it causes errors if the shared PCH PDB doesn't have the same option. - Disable support for remote execution of steps that modify the PDB, since the same file has to be modified many times. Remote execution causes the PDB files to be corrupted. Unfortunately, this makes E&C builds significantly slower. #jira Change 4192949 by Ben.Marsh UBT: Minor tidy-up (merging UEBuildBinary.Build and UEBuildBinary.SetupOutputFiles) Change 4193218 by Ben.Marsh Fix formatting. Change 4197252 by Mike.Erwin UAT: Fix log output w/ correct count of non-code projects. #jira none Change 4197941 by Ben.Marsh UGS: Add support for DebugGame editors that have an executable with a DebugGame suffix. Change 4197964 by Ben.Marsh UGS: Prevent attempts to automatically reopen projects while a modal dialog is up, or the workspace is syncing. Change 4198144 by Ben.Marsh UGS: Prevent modal dialogs when login expires in P4, and prompt for password when hitting "retry". Change 4198413 by Ben.Marsh UGS: Always show the main window when launched manually, and run with -RestoreState when launched at startup. Also add a couple more places that save the visibility state, since logging off seems like it can terminate the process abrubtly. Change 4198779 by Ben.Marsh UBT: Allow generating manifests to any arbitrary locations with the -Manifest=<Path> argument. Change 4198825 by Ben.Marsh UBT: Move code to enumerate Slate runtime dependencies into the Slate module. Doesn't need to be done inside core UBT. Change 4199341 by Ben.Marsh UGS: Update version to 1.149 Change 4199642 by Chad.Garyet - Deprecate CISController - Add BuildController to replace CIS GET/POST for builds - Add LatestController, GET does what CIS/GET used to do - Change Latest/GET to return the last 25 builds filtered by project, rather than the last 5000 individual Ids - Latest/GET now returns "LatestData" object instead of array of longs - Updated EventMonitor to match all API changes - Fixed bug where IDs were getting reset to initial startup values every update loop Change 4199663 by Chad.Garyet CIS controller still needs to return an array of longs #jira none Change 4199680 by Ben.Marsh UGS: Update version to 1.150 Change 4200457 by Ben.Marsh Merging CIS fix for non-development configurations. Change 4200472 by Mike.Erwin UAT: fix -skipbuildclient param default It was defaulting to skipbuildeditor's value, likely a copy-paste error. #jira none Change 4202595 by Ben.Marsh Fix static analysis warning due to constant comparison against macro. Change 4203250 by Ben.Marsh UGS: Always show the "Sync Precompiled Editor" option, but disable it and show a tooltip explaining why if it is not available. Change 4206191 by Ben.Marsh Exclude editor target files from installed builds, since they leak info about DLLs that have been stripped out. Change 4213011 by Ben.Marsh UBT: Include contents of modified intermediate files in the log, to make it easier to debug hidden dependencies. Change 4213487 by Ben.Marsh UBT: Fix assumption that bPrecompile is equivalent to bBuildAllModules. This is no longer the case; they are now controlled by separate options. Should fix CIS errors building the editor. Change 4213609 by Ben.Marsh Ensure that strings formatted using FMicrosoftPlatformString::GetVarArgs() are always null terminated, whether we use the secure CRT or not. Change 4215971 by Ben.Marsh UBT: Remove action graph visualization code; no longer used. Change 4215996 by Ben.Marsh UBT: Remove unqiue id from all actions in the action graph. This is only used for printing debug info in the case of a (rare) cycle in the action graph, so just look it up when needed. Change 4216022 by Ben.Marsh UBT: Rename Crypto.cs to EncryptionAndSigning.cs to match the name of the class inside it, and move it under the System folder. Change 4216031 by Ben.Marsh UBT: Move all the action executors into their own folder in the project. Change 4216526 by Ben.Marsh Fix CIS warnings. Change 4216544 by Ben.Marsh Replace custom code to ensure FMicrosoftPlatformString::GetVarArgs() null terminates its buffer with Microsoft's standards-compliant implementation. Change 4216633 by Ben.Marsh Add support for UnrealPak plugins. * Project and plugin modules can now specify an array of supported programs in the "WhitelistPrograms" field of their module descriptors, to allow modules to be loaded by programs. * Programs can now load any runtime modules, as long as they are whitelisted. * Programs under the engine directory can now use a shared build environment, so that building with a project file does not cause output binaries to be output to the project directory. * UnrealPak is now always built by default when packaging * Convert UnrealPak to a modular configuration Change 4216736 by Ben.Marsh UnrealPak: Move "ExportDependencies" command into an editor commandlet, since it relies on the UObject system, asset registry, etc... Change 4217447 by Ben.Marsh Back out revision 50 from //UE4/Dev-Core/Engine/Build/InstalledEngineBuild.xml Change 4217451 by Ben.Marsh Back out revision 11 from //UE4/Dev-Core/Engine/Plugins/Developer/VisualStudioSourceCodeAccess/Source/VisualStudioSourceCodeAccess/VisualStudioSourceCodeAccess.Build.cs Change 4217617 by Ben.Marsh Back out changelist 4217451 Change 4222552 by Ben.Marsh Don't use #import <TypeLib> for VS source code accessor when building with Clang; it's not supported. Change 4222630 by Ben.Marsh UBT: Fix spam while generating project files if Clang isn't installed. Change 4223316 by Ben.Marsh UBT: Change the order in which Visual C++ toolchains are enumerated to prefer full releases over preview releases. Change 4223318 by Ben.Marsh UBT: Add a build setting which allows creating a dedicated PCH for every file that's excluded from the unity working set (disabled by default). Improves iteration times when working on individual cpp files, but slows down iterating on header changes (and can take a lot of disk space for large changes). Dedicated PCH contains all includes scraped from the top of each cpp file, until a non-#include directive is encountered. Change 4223401 by Ben.Marsh UBT: Add an option to automatically enable edit and continue for files in the adaptive non-unity working set. E&C doesn't seem very useful for UE4 projects right now; compile time is comparable to regular build times, but it can take several minutes to apply code changes for large projects. Change 4223899 by Ben.Marsh UBT: Fix loading XML config files on Mono; Type.GetField(Name) does not seem to return values unless binding flags are specified. Change 4224637 by Ben.Marsh Add a "SupportedPrograms" field to plugin descriptors, which allows plugins to declare which plugins they support independently of individual modules. Programs now respect the "bEnabledByDefault" setting in plugins. Plugins that are compatible with a program now need to list that program in the SupportedPrograms list, and whitelist any modules that should load for that program. Change 4224710 by Ben.Marsh UBT: Don't add import libraries as final build products unless the target is being precompiled. Prevents the need for building them for leaf nodes in the action graph. Change 4224715 by Ben.Marsh UBT: Remove hack to allow Stats2.cpp to not follow IWYU convention. Change 4224726 by Ben.Marsh Remove commented out line. Change 4224903 by Ben.Marsh Fix non-unity compile error in Stats2.h. Change 4225051 by Ben.Marsh Back out changelist 4224710; causing CIS errors due to receipts not matching. Change 4225134 by Ben.Marsh Fixing non-unity errors. Change 4225203 by Ben.Marsh Another non-unity fix. Change 4225249 by Ben.Marsh Fix Linux dependencies being copied for the Windows editor; they can be added as requirements for the Linux target platform on Windows instead, so it respects the user's chosen platforms. #jira UE-62001 Change 4225512 by Ben.Marsh BuildGraph: Allow setting the target to build when using the <CsCompile> task. Change 4228815 by Ben.Marsh UBT: Always add the generated code directory to the list of include paths when generating project files. It may only be created after UHT has been run. Change 4228944 by Ben.Marsh UBT: Remove legacy CppCompileEnvironment and LinkEnvironment wrappers from TargetRules that were deprecated in 4.19. Change 4229028 by Ben.Marsh UBT: Fix editor targets with unique build environment having the wrong executable path in generated project files. Move move logic to configure target rules post-construction by the rules assembly to ensure it's valid. Change 4229065 by Ben.Marsh UBT: Move another target setting into the rules assembly. Change 4229105 by Ben.Marsh Fix BPT exception when generating project files. Change 4229311 by Ben.Marsh UBT: Store the module rules file location on the ModuleRules instance, as well as the plugin that it was created from. Also expose the plugin directory as a property on the ModuleRules instance. Change 4229421 by Ben.Marsh UBT: Consolidate functionality for UHT module setup in ExternalExecution.cs. Change 4229817 by Ben.Marsh UBT: Modules must now explicitly specify the path to the header used to generate a PCH if one is desired, rather than the header being determined automatically by attempting to parse the source code. Now that PCHs are force-included anyway, this removes a lot of dependencies inside UBT. Change 4229824 by Ben.Marsh UBT: Remove unused lists inside UEBuildModuleCPP.SourceFilesClass. Change 4229841 by Ben.Marsh UBT: Remove some legacy code from auto-detecting PCHs. Change 4230521 by Ben.Marsh UBT: Add utility functions to the log class to allow formatting errors and warnings in Visual Studio output format (eg. File(Line): warning: Message) Change 4230871 by Ben.Marsh UAT: Remove StreamUtilis utility class; there is a simpler way to implement the one place it's used. Change 4230882 by Ben.Marsh UAT: Add StreamUtils back into UAT, seems like it's still used there. Change 4230896 by Ben.Marsh UBT: Remove some redundant parameters from UEBuildModule/UEBuildModuleCPP/UEBuildModuleExternal constructors. Change 4231014 by Ben.Marsh WorkspaceTool: Include a dump of raw bytes when garbage is read from the P4 process, for diagnostic purposes. Change 4231032 by Ben.Marsh Fix CIS. Change 4231096 by Ben.Marsh Bump the FlatCPPIncludeDependencyCache version, to prevent errors trying to load old files. Change 4231446 by Ben.Marsh UBT: Added support for expanding UE-specific variables in include paths and library paths: $(EngineDir), $(ProjectDir), $(PluginDir), $(ModuleDir). Change 4231460 by Ben.Marsh Modules may now explicitly specify rpaths on Linux via the PublicRuntimeLibraryPaths and PrivateRuntimeLibraryPaths properties. Change 4233909 by Robert.Manuszewski PR #4779: Reason fails as the supplied variable is incorrect (Contributed by projectgheist) Change 4233910 by Ben.Marsh Enable PCHs on IOS. Reduces build time by ~25%. Change 4234176 by Ben.Marsh UBT: Add better messaging for modules that need to have a private PCH set. Now detects the likely PCH using the same method as legacy code and includes it as a suggestion. Change 4234193 by Ben.Marsh Add the Delete command to Perforce wrapper in DotNETUtilities. Change 4234688 by Ben.Marsh UBT: Simplify handling of installed/precompiled builds. Settings for whether a folder is installed/read-only or not is now stored on the RulesAssembly instance, allowing multiple things to be configured separately and stacked together (eg. engine/enterprise/project). RulesAssembly.IsReadOnly() allows determining if a flie can be modified or not and replaces many previous IsXXXInstalledCalls(), and traverses the chain of assemblies. Change 4234711 by Ben.Marsh UBT: Runtime dependencies can now be copied to output directories as part of the build. When adding a runtime dependency, an optional source location can be specified to copy from. Both the source and target paths can use variables can be used as part of the path, eg. $(OutputDir), $(ModuleDir), $(PluginDir). Example usage (from a .build.cs file): RuntimeDependencies.Add("$(OutputDir)/Foo.dll", "$(PluginDir)/Source/ThirdParty/Foo.dll", StagedFileType.NonUFS); Change 4234872 by Ben.Marsh Expose a flag for whether the engine is installed, to fix issues generating project files. Change 4234929 by Ben.Marsh Fix null reference generating receipts when UBT makefiles are active. Change 4235883 by Chad.Garyet Merging 4231245 to core Giving Coordinator its own sln. This should fix what 4158155 was supposed to. #jira UE-61955 Change 4236075 by Ben.Marsh CIS fix Change 4237066 by Robert.Manuszewski Fix for a potential crash when terminating the engine while it's being initialized #jira UE-60545 Change 4237078 by Robert.Manuszewski The engine will no longer be resetting all linkers causing massive load times when renaming the world package when entering Play In Editor Change 4237116 by Ben.Marsh Rewrite some Windows utility functions to support paths longer than MAX_PATH. Change 4237158 by Ben.Marsh Add const TCHAR* overloads of FString::RemoveFromStart() and FString::RemoveFromEnd(). Change 4237159 by Ben.Marsh Fix FWindowsPlatformFile::GetFilenameOnDisk() support for paths longer than MAX_PATH, and simplify some of the other long path functions to avoid copying string buffers. Change 4239050 by Ben.Marsh Missing file Change 4239318 by Ben.Marsh Linux CIS fix. Change 4239685 by Ben.Marsh Static analysis CIS fix. Change 4240800 by Ben.Marsh WorkspaceTool: Include the full command line in the log for any P4 commands. Change 4240903 by Ben.Marsh PR #4909: Update copyright notices to 2018 (Contributed by projectgheist) Change 4241025 by Ben.Marsh UBT: Exclude mobile pipeline caches from generated project files. Causes huge slowdown when using 'Find in Files' through the IDE. Change 4241770 by Ben.Marsh UBT: Include action number in parallel executor output. #jira UE-62032 Change 4243469 by Ben.Marsh TBA: Merge FAnnotatedStructuredArchiveFormatter with FStructuredArchiveFormatter. Any functions that are only implemented for text archives now have a _TextOnly suffix, and are exposed through the FStructuredArchive interface. Change 4245723 by Robert.Manuszewski Fixing another creash when terminating the engine while initializing. #jira UE-60545 Change 4245862 by Steve.Robb VectorLoadFloat2(Ptr) added, which loads { Ptr[0], Ptr[1], Ptr[0], Ptr[1] } into a VectorRegister. Change 4246412 by Robert.Manuszewski The warning 'Calling StaticLoadObject during PostLoad may result in hitches during streaming' will now also report the object which had the PostLoad called on it when StaticLoadObject call happened. Change 4246612 by Ben.Marsh UBT: Fix spelling of "Intellisense". Change 4249454 by Robert.Manuszewski Added extra checks to catch scenarios where the EDL Precache Buffer is flushed before a package header is fully read Change 4249513 by Robert.Manuszewski Made sure the Async Loading Thread doesn't continue running after creating new async packages when garbage collector wants to run on the game thread Change 4255207 by Ben.Marsh UGS: Add additional logging whenever a P4 command fails, and when the user is logged out. Change 4255288 by Ben.Marsh PR #4921: Honor ModuleRules' bEnableExceptions flag when creating precompiled h. (Contributed by surakin) Change 4256422 by Ben.Marsh UBT: Add an error if a module referenced by a plugin descriptor doesn't exist. Change 4257385 by Robert.Manuszewski Creating new objects from within ForEachObjectWithOuter will now result in a fatal error as it's unsafe to change internal UObject hash tables when iterating over them. Change 4257454 by Robert.Manuszewski Added the option to filter clusters listed with gc.ListClusters by objects within them. Usage: gc.ListClusters Hierachy With=ObjectName1,ObjectName2... Change 4257526 by Robert.Manuszewski It's now possible to filter clusters that get logged with verbose cluster logging enabled (UE_GCCLUSTER_VERBOSE_LOGGING=1) by objects within them by specifying -DumpClustersWithObjects=ObjectName1,ObjectName2 in the command line Change 4257822 by Ben.Marsh Fixes for PlatformShowcase compile errors. Change 4258771 by Ben.Marsh UBT: Fix project files not being generated for foreign projects when creating .stub files. #jira UE-62462 Change 4258790 by Ben.Marsh UBT: Clean up the logic around generating project files before creating a stub IPA, so that it fails loudly if project files do not exist, and can accept target names not matching project names. Change 4259276 by Ben.Marsh UBT: Make it an error if a framework doesn't exist, rather than failing silently. Also remove some remote toolchain stuff that's no longer necessary. Change 4259280 by Ben.Marsh UBT: Fix embedded framework zips not being uploaded for plugins. #jira UE-62485 Change 4260236 by Ben.Marsh UBT: Fix path to generated engine project file. Change 4260334 by Ben.Marsh UGS: Fix custom build steps dialog inadvertantly modifying config file settings in-place. Change 4260361 by Ben.Marsh UGS: Allow for p4 login commands to fail, even though the user is logged in (due to a bad connection, etc...) Change 4260559 by Ben.Marsh UGS: Update version. Change 4261160 by Robert.Manuszewski MediaPlaylist will now be added to root set if the owning MediaPlayer is in the disregard for GC set (fixes GC assumption violation crash) #jira UE-62495 Change 4261421 by Ben.Marsh Force-sync files for building documentation, to fix issues with files not being updated. #jira UE-62413 Change 4261425 by Ben.Marsh UBT: Remove some leftover functions for handling the remote toolchain. Change 4261530 by Ben.Marsh UBT: Speculative fix (and better error reporting) for IOS mobile provision not being found in CIS. Change 4261611 by Ben.Marsh UBT: Downgrade warning to a log message, since it appears when generating project files. Change 4261710 by Ben.Marsh Remove assert that GLogConsole is set; it won't be for command line utilities that don't depend on ApplicationCore. #jira UE-62545 Change 4261831 by Ben.Marsh Fix compile errors due to missing include path when hot-reloading a module from the editor. There are not necessarily source files to compile when -modulewithsuffix is specified on the command line, which was results in GeneratedCodeWildcard not being set. #jira UE-62463, UE-62384 Change 4262723 by Ben.Marsh Whitelist plugins that need to be loaded by UFE. #jira UE-62564 Change 4265444 by Ben.Marsh Fix incorrect executable name for DebugGame configurations in Xcode. #jira UE-62574 Change 4265892 by Ben.Marsh Fix incremental compile failures due to dependency checking for unity files. CachedIncludePaths was not correctly being set on file items, so dependencies were being ignored. #jira UE-62575, UE-62603, UE-62597 Change 4266019 by Josh.Adams - Fixed the CopyAction for runtime dependencies that need to be copied to different location, on non-XGE Change 4266264 by Ben.Marsh Remove override for the __IPHONE_OS_VERSION_MIN_REQUIRED macro on TVOS. This macro is already defined by system headers (in <AvailabilityInternal.h>). Now that we support PCHs on IOS and TVOS, manually defining this macro results in it being defined three times (once for the PCH, once by AvailabilityInternal.h, and once by the force-included list of definitions for the source file being built). The errors for redefining the macro in AvailabilityInternal.h are suppressed due to it being a system header, but the error for redefining it for the source file being compiled are not. #jira UE-62578 Change 4266273 by Ben.Marsh Fixes incremental build failure when compile arguments for PCH have changed on IOS/TVOS. Compile action needs to have a dependency on PCH build action. Change 4266614 by Graeme.Thornton Fix crash when cooking nativized blueprints due to removal of child cooker system. Change 4266763 by Ben.Marsh Always build UnrealPak when building client targets. The ProjectParams.Pak option is not reliable, because it can be forced on later by the target platform. #jira UE-62584 Change 4267985 by Robert.Manuszewski When iterating with ForEachObjectWithouter, don't lock the entire has table but only the hash bucket that is currently being iterated #jira UE-62600 Change 4268558 by Robert.Manuszewski PurgeLegacyBlueprints will no longer be called from within ForEachObjectWithOuter is it renames objects that reside in hash tables that are being iterated over which may lead to undefined behavior. #jira UE-62600 Change 4269011 by Chad.Garyet - Fixing Wildcard match issue, the change to ugsapi sends projects as //Depot/Stream instead of //Depot/Stream/ Wildcard match was only substringing to 3 chars. - Checking in the change a while back that increases the number of queried jobs up to 432 based on some maths from Bob about how many builds we want to grab Published to ugsapi server 8/8/17 #jira none Change 4270788 by Ben.Marsh Fix IOS provisioning data being using when remote compiling on TVOS. #jira UE-62705 Change 4271916 by Ben.Marsh Tag the XGEControlWorker executable as a build product after compiling SCW, to make sure it's included in the UGS zip file. Change 4271934 by Ben.Marsh Upload all static libraries in plugin folders as part of remote builds. #jira UE-62694 Change 4273368 by Ben.Marsh Fix Slate dependencies not being enumerated, and rules assembly not being rebuilt when building remotely. #jira UE-62705 Change 4274049 by Ben.Marsh Always parse the team UUID out of the mobile provision when doing a remote compile. The provision installed on the remote Mac (and selected for signing) may be different. #jira UE-62751 Change 4274823 by Ben.Marsh Add the -VersionCookedContent argument to disable the -unversioned parameter on the cooker command line. Change 4275838 by Ben.Marsh Fix BuildVersion string not being passed through from <SetVersion> task. Also add a -BuildVersion command line argument to UBT to override it for a particular build. Change 4275913 by Ben.Marsh Add a dummy exported symbol to the XGEController module, to fix build errors due to missing .lib file when it's built with WITH_XGE_CONTROLLER = 0. Change 4284161 by Ben.Marsh Allow mirroring Oodle files to remote Mac. Change 4074774 by Steve.Robb Vast simplification of TFunction, making it smaller in footprint, easier to follow and extend, and more correct. TUniqueFunction added, which is a move-only TFunction which can hold move-only functors. Fix for UWidgetBlueprint::ForEachSourceWidget() which should never have compiled but did. FFunctionGraphTask and TFuture<> updated to use TUniqueFunction to make them more general. TArray::HeapPop() made to work with move-only types. Change 4082591 by Ben.Marsh Move the Log class from UBT to DotNetUtilities. Change 4083236 by Ben.Marsh Add a Log.WriteException() method to dump an exception message to the console (and write the exception trace to the log) Change 4084107 by Ben.Marsh UAT: Remove the unused -SkipHeader argument to UE4Build. Change 4089771 by Steve.Robb GitHub #4743 : modified VirtualAlloc function flag https://blogs.msdn.microsoft.com/oldnewthing/20151008-00/?p=91411 Change 4091456 by Steve.Robb Unification of all platforms' FMath::CountTrailingZeros() and FMath::CountLeadingZeros() for both 32-bit and 64-bit. Change 4156437 by Ben.Marsh Lots and lots of fixes compiling for Clang on Windows. Editor now compiles cleanly without warnings, but crashes on startup due to error in intrinsics test. Disabling that runs further, but crashes accessing freed memory. Switching to the ANSI allocator runs further, but crashes in Slate after the splash screen and before the editor window opens. // TODO! * Switching between Clang/ICL/VS2015/VS2017 is now supported through the same mechanism as switching Visual Studio versions, without requiring any source level changes. To use Clang, set WindowsPlatform.Compiler = WindowsCompiler.Clang from a .target.cs file, or set <WindowsPlatform><Compiler>Clang</Compiler></WindowsPlatform> from BuildConfiguration.xml. To pick a specific toolchain version, set WindowsPlatform.CompilerVersion. * Clang is now supported through AutoSDKs; will be added to CIS. * The Samples/Sandbox/Clang project forces Clang to be used from its target.cs file, and allows easily building all editor modules and plugins with Clang on Windows. * UnrealMathSSE intrinsics have been re-enabled for Clang due to missing functions from the UnrealMathFPU implementation, but causes failure in tests at startup. * SSE4_CRC32() is disabled in D3D12Pipelinestate.cpp, since intrinsics are only allowed if enabled for the whole target (rather than being used in specific functions due to runtime checks) Change 4157389 by Ben.Marsh Few more fixes for compiling the editor with Clang. Change 4183911 by Ben.Marsh Fixes to support incremental linking on Windows. Does not seem to have any net benefit right now; may improve once minimal rebuild is enabled. * Incremental linking no longer forces PDB files to be enabled for source files. * Actions can specify specific files to be deleted before each build. Code to forcibly delete PDB files has been moved to the MSVC toolchain. * Unused libraries produced by the cross-referenced link are no longer added as build products, since (a) deleting them breaks dependency checking for incremental linking and causes a full link, and (b) not deleting them breaks UBT dependency checking and causes actions to be run over and over again. * Icon update is disabled for Windows when incremental linking is enabled. * Removed rarely-used setting to always delete produced items before each build. Change 4184311 by Ben.Marsh UGS: Added a dialog which shows all the required platform SDKs for a branch, linked from the status panel in UGS. The llist is configured via the UGS config file submitted to Engine/Programs/UnrealGameSync/UnrealGameSync.ini (and may be overridden by the project config file if necessary): [Default] ; Set this to a network share which contains the SDK installers for your site SdkInstallerDir= ; All the required SDKs for the current version of the engine +SdkInfo=(Category="Android", Description="NDK r21", Browse="$(SdkInstallerDir)\\Android") +SdkInfo=(Category="Windows", Description="Visual Studio 2017") +SdkInfo=(Category="Windows", Description="Visual C++ Toolchain 14.13.26128") +SdkInfo=(Category="Windows", Description="Windows SDK 10.0.16299.0") Similar entries for console platforms are added in console subdirectories. Each entry may contain an Install="Foo.exe" and/or Browse="C:\Foo" style attribute, specifying the path to an installer to run or directory to open in explorer respectively. The SdkInstallerDir setting is used as a base directory for the default installers, seen above for Android. Licensees may override this with a network path specific to the site that UGS is being deployed to (either in this file, in a project specific config file, or in a Engine/Programs/UnrealGameSync/NotForLicensees/UnrealGameSync.ini file). Change 4200452 by Ben.Marsh UBT: Change DebugGame configurations to output a separate executable rather than requiring a -Debug argument at runtime. Previous behavior was a common source of errors. Engine modules are still shared between Development and DebugGame, but the launch module sets a flag in Core on startup indicating the game configuration. Change 4206189 by Ben.Marsh UBT: Simplify logic for precompiling binaries. * Target no longer has separate list of "precompile only" binaries or modules. New -AllModules option allows adding every module to a target, which can be used with -Precompile and -NoLink to precompile object files for monolithic builds. * Precompiled file lists have been removed from target receipts. * The manifest now includes all generated headers and precompiled files when run with the -Precompile option. * Separate -DependencyList=Foo.txt has been added to write a list of all dependencies required to use precompiled binaries. This file list can be read using the <Tag> task in buildgraph. Change 4215466 by Ben.Marsh UBT: Remove indirect calls to determine extensions for object files and precompiled headers. The toolchain knows the correct convention for the platform. Change 4215975 by Ben.Marsh UBT: Remove telemetry code. This has never proved useful for analyzing performance due to the number of incidental factors that affect build times (eg. number of files being compiled). Change 4220154 by Ben.Marsh Move text-only implementations of FOutputDeviceError back into Core, so we can build command-line applications that don't depend on ApplicationCore. Change 4224708 by Ben.Marsh Add a bCompileAgainstApplicationCore setting to the target rules, which allows compiling out references to the ApplicationCore module (which should only be necessary for applications with a GUI). Removed ApplicationCore from several engine tools and utilities. Change 4224958 by Ben.Marsh Remove CoreMinimal.h includes from Core. Change 4229059 by Ben.Marsh UBT: Remove the UEBuildPlatform.ShouldNotBuildEditor() hook for target platforms. We shouldn't be modifying a target's build environment to disable the editor; it is invalid to build the editor for these target platforms at all, and this is already enforced by the GetSupportedPlatforms() function. Change 4230508 by Ben.Marsh Fixup precompiled header setting for samples and games. Change 4231457 by Ben.Marsh Fix exceptions in log messages having trailing newlines. Change 4232406 by Ben.Marsh UBT: Always force include a PCH for generated code if there's one set; the code may depend on it to compile. Change 4234177 by Ben.Marsh Set up private PCH files everywhere that previously used them. Change 4235973 by Ben.Marsh Change FPlatformMisc::GetEnvironmentVariable() to return an FString() rather than requiring a fixed size buffer to be passed in. Removes references to MAX_PATH. Change 4238842 by Ben.Marsh Add support for paths longer than MAX_PATH in the editor. Requires Windows 10 version 1607, and the functionality to be enabled via a registry key or group policy (see https://docs.microsoft.com/en-us/windows/desktop/FileIO/naming-a-file). Only a subset of Win32 functions support long paths (executables can only be started from paths shorter than MAX_PATH, for example). * Added a FPlatformMisc::GetMaxPathLength() function to return the maximum length of a path on the current system. On Windows, this returns a different value for systems with long paths enabled to those without. * The MAX_PATH define is no longer set by non-Windows platforms. Instead, there is a MAC_MAX_PATH, UNIX_MAX_PATH, etc... for any platform-specific code that still relies on the previous macro. * The MAX_UNREAL_FILENAME_LENGTH macro has been renamed to MAX_UNREAL_FILENAME_LENGTH_DEPRECATED * The PLATFORM_MAX_FILEPATH_LENGTH macro has been renamed to PLATFORM_MAX_FILEPATH_LENGTH_DEPRECATED. * Removed custom resource files for programs, since they are just copies of the base UE4 one (which is used by default anyway). The base UE4 manifest declares support for long paths. * Fix 512 character maximum length on editor commands. 260 character limit remains in place for cooking at the moment (see ContentBrowserUtils.h), until C# staging code supports long paths. Change 4255042 by Ben.Marsh UBT: Remote compilation now uploads the entire workspace to the remote Mac and executes a separate remote instance of UBT rather than synchronizing individual actions. This makes the remote compile codepath much simpler, and removes a lot of special cases that exist to support it previously. The list of files to be transferred to the remote are listed as rsync filter rules in Engine/Build/Rsync/RsyncEngine.txt and RsyncProject.txt, which are applied to the root engine directory and project directory respectively. Projects that need to customize which files are uploaded can add their own <ProjectDir>/Build/Rsync/RsyncProject.txt file, which will be included in the filter before the default version. Change 4260567 by Ben.Marsh UAT: Rename CommandUtils.Log to CommandUtils.LogInformation, to avoid conflicts with the underlying Tools.DotNETCommon.Log class. #rb none [CL 4285673 by Ben Marsh in Main branch]
2018-08-14 18:32:34 -04:00
LogInformation("Starting Client for unattended test....");
ClientProcess = Run(ClientApp, ClientCmdLine + " -testexit=\"" + LookFor + "\"", null, ClientRunFlags | ERunOptions.NoWaitForExit);
while (!FileExists(ClientLogFile) && !ClientProcess.HasExited)
{
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 4285612) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3836829 by Ben.Marsh UBT: Fix ability to precompile plugins from installed engine builds. Change 3839519 by Ben.Marsh UBT: Simplify configuring bPrecompile and bUsePrecompile settings for modules. Each rules assembly can now be configured as installed, which defaults the module rules it creates to use precompiled data. Change 4042043 by Steve.Robb GitHub #4705 : Added weak lambda's for delegates and multicast delegates. Change 4042056 by Robert.Manuszewski Optimized Mark Phase of GC by up to 10ms by making it run in parallel and removing a huge array presize which we didn't need. Change 4042104 by Robert.Manuszewski Set the minimum GC cluster size to 5 so that GC doesn't have to process micro clusters which are more expensive than processing individual objects + Exposed the minimum cluster size to ini and project settings as gc.MinGCClusterSize + Added the ability to sort clusters by name/object count/mutable object count/referenced clusters count when dumping them with gc.ListClusters command Change 4042377 by Robert.Manuszewski Reworked how GC and other threads (ALT specifically) interact - GC will now notify the ALT it wants to run and ALT will immediately try to finish its current work to allow that. Also the entire ALT tick is now protected against GC running at the same time to improve ALT stability. + added gc.ForceCollectGarbageEveryFrame console variable that triggers a forced GC every frame Change 4042427 by Robert.Manuszewski Changed FGCCSyncObject to use events when waiting for GC to finish so that it doesn't spin on non-game threads when GC is running Change 4042482 by Robert.Manuszewski Unhashing unreachable objects (ConditionalBeginDestroy) will now also be done incrementally, just like the purge phase of Garbage Collection Change 4042635 by Robert.Manuszewski Fix for a potential assert when incremental purge garbage is pending and something forces a full purge Change 4044092 by Steve.Robb Fix for forward declared CoreUObject weakobject types in delegates when building in Clang. Change 4044102 by Robert.Manuszewski Fix for a possible hang when worker threads are preventing GC from running and something is later trying to FlushAsyncLoading with the Async Loading Thread enabled Change 4044113 by Steve.Robb Another Clang fix. Change 4044160 by Robert.Manuszewski Disregard For GC pool will now be enabled by default in cooked builds Change 4044287 by Steve.Robb Typo fix. Change 4047723 by Graeme.Thornton TBA: Fixes for import/export name cache and object resolving Change 4048015 by Graeme.Thornton TBA: Weak/Soft/Lazy pointer serialization changes * Remove FWeakObjectPtr::Serialize, move it's logic into, and replace usages of with calls to, FArchiveUObject::SerializeWeakObjectPtr(). Ensures that something is always sent to the archive so that structured archives can be kept happy in the future. * Added Weak/Soft/Lazy pointer handling to the structured archive slot interface and all the formatters. Binary formatters just forward the call onto their inner and text archives store as a string path reference. * FArchiveUObjectFromStructuredArchive caches all these pointer types and stores indices in the binary block, same as with a UObject*. All pointers are then forwarded to the underlying formatter in one go on finalization. Change 4048021 by Steve.Robb Fix for binding an unbound TFunction to another TFunction with a different signature. Also all null pointers now count as unbindings, not just nullptr. TIsMemberPointer added. TIsATFunction and TIsATFunctionRef renamed to remove the 'A's. Change 4048544 by Robert.Manuszewski Fixing ConditionalBeginDestroy profiling after changes to incremental CBD. Change 4051028 by Graeme.Thornton TBA: ArchiveFromStructuredArchive adapter uses Inner to determine if it is outputting to text, and sets it's own ArIsTextFormat to false Change 4051056 by Graeme.Thornton TBA: High level tagged property / UObject base class text serialization - UObject serialize converted to structured archive - Properties written to text individually with text tags, and then binary adapted values - Only saves, doesn't load Change 4051111 by Graeme.Thornton TBA: Temporarily disable loading of text assets until tagged property serialization path is fixed up Change 4051154 by Graeme.Thornton TBA: Convert a few uobject serializers to structured archive format for example purposes Change 4051181 by Graeme.Thornton TBA: Added default structured archive implementation of SerializeItem to UProperty, which just calls the FArchive version on an FArchiveUObjectFromStructuredArchive adapter. Implemented structured archive SerializeItem for UArrayProperty Change 4051197 by Graeme.Thornton TBA: ObjectProperty text serialization Change 4051216 by Graeme.Thornton Restored a modified FWeakObjectPtr::Serialize function to keep backwards compatibility in code I don't have access to. Change 4051261 by Graeme.Thornton TBA: Convert UMetaData to structured archive Change 4051374 by Steve.Robb Incorrect assert removed. Change 4051562 by Robert.Manuszewski Adding stats for the new GC internal functions Change 4051614 by Graeme.Thornton TBA: Removed UProperty::SerializeItem(FArchive, ...) and replaced with UProperty::SerializeItem(FStructuredArchive::FSlot, ...). Fixed up most of them to work properly and added adapters in for any that were non-trivial. Change 4052512 by Graeme.Thornton TBA: Temporary workaround for softobjectptr and lazyobjectptr uproperties not serialization anything when they know the archive is a reference collector. They should always be serializing their pointers and letting the underlying archive itself ignore them. Change 4053917 by Robert.Manuszewski Clustered objects from clusters that are no longer reachable will now be marked as unreachable immediately when gathering unreachable objects Change 4053919 by Robert.Manuszewski Added the ability to disable incremental BeginDestroy in ini/project settings Change 4055518 by Daniel.Lamb Fixup for deterministic audio generation issue. Submitted on behalf of Rich.Whitehouse #jira nojira #test prefilght automated test. Change 4056854 by Graeme.Thornton TBA: Added a test asset to EngineTest which contains all the different property types and test cases. Change 4056858 by Graeme.Thornton TBA: Updated USetProperty to proper structured archive usage Change 4056872 by Graeme.Thornton TBA: Add map property field to test object Change 4056873 by Graeme.Thornton TBA: Convert UMapProperty to full structured archive Change 4056994 by Graeme.Thornton TBA: Converted FText over to structured archive. Implemented saving, but not loading. Change 4059728 by Ben.Marsh UBT: Add support for using adaptive non-unity builds when the engine and project are in separate repositories. Change 4059805 by Graeme.Thornton Fixed typo in text serialization. Fixes CIS automation test errors Change 4060007 by Graeme.Thornton TBA: FArchiveFromStructuredArchive will now access it's host slot lazily, i.e. only when a value is actually written to the archive. Change 4060092 by Stefan.Boberg Added optimized Windows console window output path to GenericConsoleOutput since this slowed down cooking considerably (2 minutes spent in wprintf alone for one large dataset) When stdout is attached to a console we use the WriteConsoleW function instead of wprintf since the latter is very slow especially in unbuffered mode which the engine currently configures for stdout (see setvbuf call in LaunchEngineLoop.cpp). At some point we should reconsider this buffering policy since it's likely to slow down other platforms as well but I wanted to do a safe change for now as I don't yet fully understand why the setvbuf call is there in the first place. Change 4060108 by Stefan.Boberg Introduced some additional target platform utilities to help with asset cook optimizations * We now assign each ITargetPlatform a zero-based ordinal value * Introduced FTargetPlatform and FTargetPlatformSet types to help store platform references and platform sets efficiently. These are not currently used in the engine but are designed to replace the existing ITargetPlatform/string/FName representations in the cooking data structures. Change 4060143 by Graeme.Thornton Undo //UE4/Dev-Core/Engine/Source/Runtime/... changelist 4060007 Needs some other changes that I haven't checked in yet... Change 4062432 by Ben.Marsh Fix error message when enumerating P4 changes. Change 4062648 by Ben.Marsh Add missing p4 integration action. Change 4063620 by Graeme.Thornton Integrated a fix from UDN where the engine would crash when trying to load a very small encrypted file (<16bytes) from a pak file, where the read address wasn't already aligned to the AES block size. (https://udn.unrealengine.com/questions/431989/crash-while-reading-a-very-small-file-in-encrypted.html) Change 4066963 by Robert.Manuszewski Fixing GC cluster verification code reporting false positives when a cluster is referencing another cluster through 'mutable' objects list. Change 4067133 by Robert.Manuszewski Changed log verbosity when reporting individual cases of GC cluster assumption violations as they are followed by an asser anyway and this way we get the chance to see all issues before we assert at the end of these checks. Change 4067443 by Steve.Robb FString can now be constructed from any char pointer type and length. Change 4068156 by Steve.Robb Fix necessary because of FString constructor change in CL# 4067443. Change 4070258 by Graeme.Thornton Fixes for VSCode Change 4070372 by Graeme.Thornton TBA: Script struct serialization to structured archives Change 4071913 by Ben.Marsh Move bulk of the code for UnrealPak into an engine developer module, so it can be used in the editor. Change 4071914 by Ben.Marsh Missing files. Change 4071937 by Ben.Marsh Missing header. Change 4072015 by Ben.Marsh Fixes for compiling PakFileUtilities as part of the editor. Change 4072826 by Steve.Robb TBitArray::Reserve() added. TBitArray::Add() overloaded to allow adding multiple bits. TSparseArray::Reserve() optimized to call the overloaded Add(). Change 4073271 by Daniel.Lamb Fixed add patch tier in project launcher passing the wrong commandline option to UAT. #test none Change 4074708 by James.Hopkin #core Removed redundant Casts Change 4074763 by Steve.Robb Fix for TSparseArray::Reserve() size. Change 4076063 by Ben.Marsh Add an "UnrealPak" commandlet with the same functionality as the standalone UnrealPak program. Invoke by running the editor with -run=UnrealPak and the standard UnrealPak commandline options. Change 4077064 by Robert.Manuszewski Fixing compile error in PakFileUtilities Change 4077144 by Graeme.Thornton TBA: TextAssetCommandlet improvements * Collect lists of broken assets during roundtrip tests and print a summary of packages that failed each phase at the end * After resaving as text, load the file back as a plain JSON hierarchy to ensure the output was valid Change 4077412 by Ben.Marsh Set the correct exit code for UnrealPak. Should return 0 on success, not 1. Change 4077760 by Graeme.Thornton TBA: Loading fixed for tagged property serialization Includes conversion of all UProperty::ConvertFromType() and SerializeFromMismatchedTag() functions to use structured archives Lazy initialization of FArchiveFromStructruredArchive when loading, to support the possibility of an adapter being create around an object property serialize call to its inner UStruct, which then decides not to do anything and return false. Stops the ArchiveFromStructuredArchive from consuming the slot and getting upset later on when we try to serialize normal tagged properties from it. Disabled lazy bulk data loading from text assets. Requires a bigger change to make it work. Added some debug checks to json input formatter which track the current value stack size when a new object is pushed onto the stack, and makes sure that the stack has returned to the same size when the object is popped. Catches cases where we unpack an array/stream to the value stack but then don't consume all the items. Change 4078800 by Ben.Marsh Change UAT to using the editor's UnrealPak commandlet rather than invoking the standalone UnrealPak executable. To improve performance when building several PAK files, also add a new -batch=<file> command which reads commands to execute in parallel from a text file. Change 4079745 by Graeme.Thornton TBA: Migrated a couple of UObject Serialize functions to FStructuredArchive (SoundCue / MaterialExpressions / Editor strip flags) Change 4079847 by Graeme.Thornton TBA: Add 'FindMismatchedSerializers' mode to text asset commandlet, which dumps out a list of all UClasses which don't have the CLASS_MatchedSerializers flag, meaning we can't guarantee the have Serialize functions for FArchive AND FStructuredArchive, therefore we can't use the new structured archive based serialize path. Should only ever be native instrinsic classes as UHT takes care of all other cases. Change 4079925 by Ben.Marsh Fix incorrect assignment when deriving name for chunked pak file. Change 4080214 by Ben.Marsh Move the ThreadPoolWorkQueue class into DotNETUtilities so it can be used by other projects. Change 4082394 by Graeme.Thornton CIS fix for variable shadowing warning Change 4082583 by Ben.Marsh Add a IBinarySerializable interface for types that support reading from a BinaryReader and writing to a BinaryWriter. Implementing IBinarySerializable implies a constructor taking a BinaryReader argument is available for deserializing. Change 4082652 by Ben.Marsh Fix FileReference.Directory not returning a directory with a trailing backslash for files in the root directory. Change 4082755 by Graeme.Thornton Fixed an erroneous usage of TUniquePtr<uint8>as a pointer to a uint8 array when creating pak files. Caused a crash when compression was enabled, and has probably surfaced because pak generation is now done by an editor commandlet rather than a standalone program. Change 4082756 by Graeme.Thornton Fixed some incorrect documentation for pakfile compressed chunk headers Change 4082883 by Graeme.Thornton Static analysis warning fix Change 4082912 by Ben.Marsh Move ExceptionUtils into DotNETUtilities. Change 4085291 by Graeme.Thornton TBA: In the Json output formatter, write float and double values out with enough precision for successful roundtripping. Added some debug only code which will immediately reconvert the string back to its original value and compare the the input Change 4085523 by Graeme.Thornton TBA: Remove only explicit usage of DECLARE_FSTRUCTUREDARCHIVE_SERIALIZER. Should only be used from UHT generated code. Change 4086037 by Robert.Manuszewski Fix for a potential race condition when two threads want to acquire GC lock Change 4088655 by Graeme.Thornton Pak creation now uses the bEnablePakSigning setting from the crypto config json file Change 4091474 by Steve.Robb Fix for TStaticBitArray::FindFirstSetBit() and TStaticBitArray::FindFirstClearBit(). Unused variables removed. Change 4093632 by Steve.Robb CIS fixes. Change 4093656 by Graeme.Thornton Build fix Change 4093744 by Ben.Marsh Allow per-chunk settings for whether to enable compression in UnrealPak. Change 4099712 by Gil.Gribb UE4 - Fixed rare case where insufficient space was preallocated for cooldown ticks. #jira UE-59686 Change 4099912 by Stefan.Boberg Cooking timer optimizations: - Replaced data structures for FScopeTimer and FHierarchicalTimerInfo. Previous implementation used FString for many things and caused *lots* of heap and string concatenation activity. Replaced with a compile-time node id (using __COUNTER__) and raw string literals. - Removed PERPACKAGE_TIMER support (was disabled by default and was difficult to test) - Made it possible to toggle OUTPUT_TIMING and ENABLE_COOK_STATS independently - Removed some extremely tight timers because the overhead from calling QPC significantly exceeded the measured code This change shaved some 15% off a clean cook of Fortnite WindowsClient (en) with fully populated local DDC Change 4100519 by Stefan.Boberg Quick fix for Linux build issue introduced in 4099927 Change 4105327 by Stefan.Boberg Cooker: Changed FHierarchicalTimerInfo so it uses a linked list for tracking child nodes, to be able to deal with any child count. Previously we assumed there would never be more than 9 children but it turns out there are cooker modes that need more. Fixes check when using -FullLoadAndSave to cook Change 4105448 by Stefan.Boberg - Fixed Linux build warning re: member initialization order - Also eliminated OUTPUT_HIERARCHYTIMERS/CLEAR_HIEARCHYTIMERS macros (plain functions are fine) - Moved finishing-up code for FullLoadAndSave() to TickCookOnTheSide() call site to improve timer output. Previously some of the scopes would not have been closed before printing and thus the output was misleading. Change 4109031 by Ben.Marsh Attribute-driven Perforce wrapper (old Epic Friday project). Offers a more complete implementation than the current P4 wrapper in UAT without requiring any platform-specific libraries. Uses the Python binary output for parsing. Change 4109588 by Ben.Marsh UBT: Add extension methods for serializing a nullable type to a BinaryReader/BinaryWriter. Change 4109595 by Ben.Marsh Missing project file for DotNETUtilities. Change 4110724 by Stefan.Boberg Removed annotation map locking in UObjectMarks, eliminating around one minute (~3.5%) from Fortnite cook time. The locking was redundant since the annotation maps are managed per thread anyway. Change 4111304 by Ben.Marsh UAT: Add support for setting a status message through the log class. Allows writing transient messages (eg. progress messages) which will be cleared out before writing other messages. Best used through the LogStatusScope class, which can set a status message for the duration of a using() block. As part of this change, the console no longer has to be added as a dedicated trace listener. Since we already special-case this listener when formatting log output, it's easier to just keep the implementation separate to the other trace listeners. Change 4112708 by Steve.Robb Fix for TBitArray::MaxBits in assignment. Change 4114133 by Stefan.Boberg Tweaked how low-level memory (LLM) tracker is implemented to reduce overheads. Previously FMemory functions would acquire the LLM singleton and call OnLowLevelFree/OnLowLevelAlloc etc which would check the bIsDisabled flag and early out if it was set. Due to how frequently these functions were called this ended up costing quite a bit. - This change makes the flag a static member variable instead of a member variable and therefore enables a simpler early-out to be implemented. - The singleton getter is also simplified to avoid hitting the threadsafe singleton construction path on every call. - The enable flag is no longer TAtomic - this also incurs extra overhead for no clear benefit Shaves approximately 3.5% (one minute) off a Fortnite cook test scenario (using -FullLoadAndSave) Change 4115010 by Robert.Manuszewski Fixing CIS Change 4115249 by Robert.Manuszewski Fixing async loading code asserts when exiting game very early due to an error #jira UE-56267 Change 4117091 by Ben.Marsh Prevent doubled-up lines when writing status updates with console log verbosity. Change 4117207 by Ben.Marsh UGS: Do not include executables in diagnostics zip file, and ignore "no such files" error when cleaning workspace. Change 4119175 by Ben.Marsh UGS: Fix crash writing version files when directory does not already exist. Change 4119987 by Ben.Marsh UGS: Show a dialog box while the launcher is updating executables from Perforce, which allows cancelling the operation if necessary. Allow setting the username on the settings window, and prompt for login credentials if necessary. Should prevent situations where users have to update settings from the command prompt. Holding down shift during launch now shows the settings dialog rather than an immediate prompt to launch the unstable version (unstable version is shown as a checkbox on this dialog). Change 4119991 by Ben.Marsh Update version number for UGS launcher to 1.13. Change 4121943 by Robert.Manuszewski Don't use FArchiveAsync2 for reading packages with non-async path in editor builds as its performance is worse than the standard archive's (saves about 1 minute when doing larger cooks and 7 seconds when loading into PIE) Change 4122592 by Steve.Robb GitHub #4762 : Improve wording and grammar of Math comments Also includes improved accuracy in FMath::ComputeBoundingSphereForCone(). Change 4122819 by Stefan.Boberg Don't call CreateDirectory redundantly when opening files for writing using FFileManagerGeneric::CreateFileWriter This change avoids calling IPlatformFile::CreateDirectoryTree if possible since this is a very expensive function especially for deep hierarchies as it performs directory creation from the root directory onwards instead of from the leaf downwards. That function should also be fixed but this change improves performance in the meantime. Change 4122872 by Stefan.Boberg CreateDirectoryTree now creates directories leaf-to-root instead of the other way around. This is much more efficient since we don't spend time on system API calls for directories which already exist. This accounted for a very large amount of CPU time in cooking as the full target file directory hierarchy would be "created" for every single output file. Change 4123109 by Stefan.Boberg - Disable overlapped I/O in editor / cooker. Synchronous I/O reduces the number of syscalls and Windows performs prefetching on our behalf anyway for sequential reads - Eliminated syscall which was issued for every write to update cached file size -- since we're the only writers to the file (file access allows read sharing at most) we can authoritatively update the file size on write completion Change 4123455 by Ben.Marsh PR #4775: New build param PCHMemoryAllocationFactor to set /Zm VS build param. (Contributed by lucaswall) Change 4124207 by Ben.Marsh UBT: Remove some unnecessary indirection for generated code paths. Change 4124217 by Ben.Marsh UBT: Remove another unused variable from UEBuildModuleCPP. Change 4124377 by Stefan.Boberg In IPlatformFile::DeleteDirectoryRecursively, attempt to delete file first and if it fails clear the readonly flag and try again Previously there was a call to clear the readonly flag for every deleted file and this is a waste of resources 99% of the time. The SetFileAttributes call accounted for a significant amount of time during cooker sandbox directory deletion Change 4125071 by Stefan.Boberg Some tweaks to FQueuedThreadPoolBase scheduling and memory management - Explicitly pass in false for TArray::RemoveAt(..., bool bAllowShrinking) argument to prevent memory reallocation when arrays are drained and inevitably repopulated shortly afterwards - Use a MRU strategy instead of LRU when picking a thread to wake up. The MRU thread is the most likely to have a 'hot' cache for the stack etc. Picking from the back of the array also happens to be cheaper since no memory movement is necessary when RemoveAt is called. (This was the strategy in place before CL2600362 which seems to have changed it unintentionally) - Release lock as soon as a thread has been chosen, before asking the worker thread to wake up and do the work Change 4126132 by Ben.Marsh UAT: Detect when stdout is redirected and prevent using backspace characters to move the cursor. Change 4126867 by Graeme.Thornton TBA: Fix tagged binary formatter Change 4127010 by Robert.Manuszewski AnimScriptInstances created at runtime will now also be added to the owning omponent's cluster to avoid GC issues. Change 4127932 by Ben.Marsh WorkspaceTool: Reduce unnecessary logging of status messages when console output is not redirected. Change 4129050 by Ben.Marsh UGS: Check for NET Framework 4.5 being installed before running the installer. Also fix warning trying to kill existing UGS instances before upgrade. Change 4129459 by Graeme.Thornton TBA: TextAssetCommandlet - When outputting converted assets to an output path, replicate the workspace relative path in the output directory Change 4129515 by Graeme.Thornton TBA: Add EnterRecord overload that allows outputting of available field names when loading. Change 4129517 by Graeme.Thornton TBA: Tagged properties are written out as named fields on the "Properties" record, rather than as a stream with a null tag at the end Change 4129518 by Graeme.Thornton TBA: Added a local const bool to allow easy hacking out of text asset loading support Change 4129558 by Graeme.Thornton TBA: Build fix for textasset-less configs Change 4129614 by Ben.Marsh UGS: Main window is now restored to normal size when activated by clicking on the tray icon. #jira UE-60490 Change 4129618 by Ben.Marsh UGS: Speculative fix for unreproduced exception accessing disposed window while shutting down. Change 4131936 by Robert.Manuszewski Removing some WIP code accidentally checked in with CL #4121943 Change 4133490 by Ben.Marsh UGS: Allow the $(Change) variable to be used in more places than just the context menu. #jira UE-60573 Change 4133550 by Ben.Marsh UGS: Setting for whether or not to use incremental builds is now exposed through the variable "$(UseIncrementalBuilds)" for use by custom build steps. #jira UE-60554 Change 4133681 by Ben.Marsh UGS: A per-project list of folders and extensions to be deleted by default when running the 'clean workspace' tool can now be specified through the <ProjectDir>/Build/UnrealGameSync.ini file. Settings may be specified for an individual branch (via a category with the depot path to the project) or for wherever the project is currently open (via the [Default] category). The SafeToDeleteFolders list specifies a substring that will be checked against folder paths. Anything containing this folder will be marked as safe for delete by default. The SafeToDeleteExtensions list specifies a list of extensions for files that can always be deleted. Example: [Default] +SafeToDeleteFolders=/MyGame/Test/ +SafeToDeleteFolders=/DataService/ +SafeToDeleteExtensions=.xx1 +SafeToDeleteExtensions=.xx2 #jira UE-60575 Change 4135449 by Ben.Marsh Fix allowing use of Job objects on Windows platforms (debug code submitted by mistake) Change 4135730 by Ben.Marsh UBT: Plugins can now be enabled and disabled from the .target.cs file (for targets that do not use the shared compile environment), by compiling the list of enabled/disabled plugin names into the Projects module. Change 4135823 by Ben.Marsh UBT: Remove legacy code to handle disabling optional plugins; now that this is compiled into the target, it will work for any plugins we choose. Change 4135945 by Ben.Marsh UBT: Fix error running programs with no explicitly enabled or disabled plugins. Change 4137207 by Ben.Marsh UGS: Align all badges with the same name, to make it easier to see which CIS steps are being run. Allow overriding the slot taken by a particular badge by calling it "SlotName:LabelName". Change 4137311 by Stefan.Boberg Removed child cooker support. In practice it is not a useful feature as it provides no performance improvement (quite the opposite in fact) and adds testing and maintenance complexity. Change 4137393 by Ben.Marsh UGS: Fix display of multiline errors in the status panel. Change 4141708 by Steve.Robb GitHub #3631 : Incorrect default argument in WeakObjectPtrTemplate #jira UE-45490 Change 4146655 by Stefan.Boberg Removed FullGCAssetClasses logic - no longer necessary nor useful Change 4147318 by Ben.Marsh UGS: Compress build badges in a column if it shrinks below the size that they would be visible. Change 4148207 by Ben.Marsh UGS: Added support for showing the latest completed build from a specific list of badges in the status panel. To declare a badge as one that should appear in the status panel rather than the CIS column, add it to the project's UnrealGameSync.ini in the project or [Default] section like so: +ServiceBadges=RoboMerge Change 4148282 by Stefan.Boberg Fixed bug in UCookOnTheFlyServer::GetCookOnTheFlyUnsolicitedFiles - UnsolicitedFiles should be passed by reference not by value Change 4148344 by Stefan.Boberg Fixed minor indentation error (most likely caused by sloppy merge) Change 4148521 by Stefan.Boberg Removed accidentally checked in PRAGMA_DISABLE_OPTIMIZATION from CookOnTheFlyServer.cpp Change 4148639 by Ben.Marsh UGS: Fix tooltips not showing for changes that have description badges. Change 4149373 by Ben.Marsh UGS: Allow adding additional columns to display particular badges by adding entries from the project config file. Example syntax: +Columns=(Name="Desktop",MinWidth=50,DesiredWidth=100,Weight=3,Badges="Editor") +Columns=(Name="Mobile",MinWidth=50,DesiredWidth=100,Weight=3,Badges="IOS,Android") Same form can be used to control how default columns are displayed (though badge settings are ignored). Also allow PerforceMonitor to detect local changes to project config files and update settings automatically. Change 4149399 by Ben.Marsh UGS: Update version to 1.143. Change 4155660 by Steve.Robb PROJECTION and PROJECTION_MEMBER macros which provide the correct behavior when creating projections using functions which are overloaded or use default arguments. Change 4157117 by Ben.Marsh Fix warning due to plugins disabled in .target.cs file. Change 4158011 by Ben.Marsh UBT: Add a check that the UnrealHeaderTool target file exists, rather than throwing an exception when reading it fails. Change 4158646 by Ben.Marsh UGS: Fix exception when login is discovered to have expired during a workspace update. Change 4158678 by Ben.Marsh UGS: Fix an exception on shutdown due to the icon being hidden after it's already been disposed. Change 4158683 by Ben.Marsh UGS: Add an unhandled exception filter which sends the exception data to the backend. Change 4159131 by Ben.Marsh UGS: Reduce the number of characters displayed for build badges based on the available space. Change 4159194 by Graeme.Thornton TBA: Fix incorrect map property conversion code when converting an old property that contains a map with different key/value types Change 4159239 by Steve.Robb Improved readability and compliance with coding standards. Change 4159246 by Ben.Marsh UGS: Allow syncing projects where source code is not available (and various version files don't exist). #jira UE-60985 Change 4159286 by Ben.Marsh UGS: Remove requirement for UE4Editor.target.cs to be visible in the depot in order to open a project. #jira UE-60986 Change 4159302 by Ben.Marsh UGS: Update version to 1.144. Change 4160308 by Ben.Marsh All staging client executables for blueprint projects. #jira UE-60983 Change 4161567 by Steve.Robb GitHub #4816 : UE-60771: Handle escaped double quote in FParse::LineExtended Change 4162641 by Ben.Marsh UGS: Allow customizing the position of custom columns, via the Index=N attribute. Change 4162647 by Ben.Marsh UGS: Update version to 1.145. Change 4165319 by Robert.Manuszewski PR #4812: Fix inconsistent command-line argument handling under Windows (Contributed by adamrehn) Change 4166150 by Ben.Marsh UGS: Include *.inl when looking for code changes. Change 4166551 by Steve.Robb Whitespace fixes caused by a bad merge. Change 4168483 by Ben.Marsh UGS: Add a more useful error if a file to be synced exceeds the max allowed path length. Change 4168490 by Ben.Marsh UGS: Update version to 1.146. Change 4168551 by Ben.Marsh UBT: Move bBuildLargeAddressAwareBinary into an exposed setting. Change 4168560 by Ben.Marsh UBT: Remove static config variable for controlling which configuration of UHT to use. Change 4171296 by Ben.Marsh UGS: Move the check for overlong paths earlier. Change 4171531 by Ben.Marsh UBT: Fix exception if BuildConfiguration.xml contains an unknown category. Change 4183371 by Robert.Manuszewski Fix for a crash in Async Loading Graph's CheckCycles when GC kicks in on the game thread and forces ALT to exit early Change 4184312 by Ben.Marsh UGS: Update version to 1.148 Change 4184480 by Robert.Manuszewski Removing unused async loading stat Change 4186390 by Ben.Marsh UBT: Format XML validation errors in a format that allows double-clicking on the message in Visual Studio. Change 4188644 by Ben.Marsh UBT: Add the MakePathSafeToUseWithCommandLine() function to UBT. Change 4188647 by Ben.Marsh UBT: Fix exception in target receipt when architecture is null. Change 4189617 by Ben.Marsh Change FileSystemReference, FileReference and DirectoryReference objects to use OrdinalIgnoreCase comparisons without creating a separate copy of the string to compare. The filesystem does not use the invariant culture, and it can produce the wrong results in some cases (the ordinal comparison is faster, too). Change 4189740 by Ben.Marsh UAT: Remote code to build UnrealPak when packaging; we use the editor now. Change 4189860 by Ben.Marsh UGS: Make the filter for excluding automated lighting rebuilds more explicit. Change 4190082 by Ben.Marsh Fixes to allow enabling edit and continue for Windows builds. Have experienced quite a few VS crashes when testing it in editor; not yet recommended for general use. - Allow edit and continue for any configuration, not just debug. - Fixed PDB errors compiling files that use a shared PCH with edit and continue enabled. Path to the generated PDB file was using the wrong directory. - Removed code that tracks PDB output files, since they're modified multiple times during a build. - Enable debug information when compiling generated CPP files, since it causes errors if the shared PCH PDB doesn't have the same option. - Disable support for remote execution of steps that modify the PDB, since the same file has to be modified many times. Remote execution causes the PDB files to be corrupted. Unfortunately, this makes E&C builds significantly slower. #jira Change 4192949 by Ben.Marsh UBT: Minor tidy-up (merging UEBuildBinary.Build and UEBuildBinary.SetupOutputFiles) Change 4193218 by Ben.Marsh Fix formatting. Change 4197252 by Mike.Erwin UAT: Fix log output w/ correct count of non-code projects. #jira none Change 4197941 by Ben.Marsh UGS: Add support for DebugGame editors that have an executable with a DebugGame suffix. Change 4197964 by Ben.Marsh UGS: Prevent attempts to automatically reopen projects while a modal dialog is up, or the workspace is syncing. Change 4198144 by Ben.Marsh UGS: Prevent modal dialogs when login expires in P4, and prompt for password when hitting "retry". Change 4198413 by Ben.Marsh UGS: Always show the main window when launched manually, and run with -RestoreState when launched at startup. Also add a couple more places that save the visibility state, since logging off seems like it can terminate the process abrubtly. Change 4198779 by Ben.Marsh UBT: Allow generating manifests to any arbitrary locations with the -Manifest=<Path> argument. Change 4198825 by Ben.Marsh UBT: Move code to enumerate Slate runtime dependencies into the Slate module. Doesn't need to be done inside core UBT. Change 4199341 by Ben.Marsh UGS: Update version to 1.149 Change 4199642 by Chad.Garyet - Deprecate CISController - Add BuildController to replace CIS GET/POST for builds - Add LatestController, GET does what CIS/GET used to do - Change Latest/GET to return the last 25 builds filtered by project, rather than the last 5000 individual Ids - Latest/GET now returns "LatestData" object instead of array of longs - Updated EventMonitor to match all API changes - Fixed bug where IDs were getting reset to initial startup values every update loop Change 4199663 by Chad.Garyet CIS controller still needs to return an array of longs #jira none Change 4199680 by Ben.Marsh UGS: Update version to 1.150 Change 4200457 by Ben.Marsh Merging CIS fix for non-development configurations. Change 4200472 by Mike.Erwin UAT: fix -skipbuildclient param default It was defaulting to skipbuildeditor's value, likely a copy-paste error. #jira none Change 4202595 by Ben.Marsh Fix static analysis warning due to constant comparison against macro. Change 4203250 by Ben.Marsh UGS: Always show the "Sync Precompiled Editor" option, but disable it and show a tooltip explaining why if it is not available. Change 4206191 by Ben.Marsh Exclude editor target files from installed builds, since they leak info about DLLs that have been stripped out. Change 4213011 by Ben.Marsh UBT: Include contents of modified intermediate files in the log, to make it easier to debug hidden dependencies. Change 4213487 by Ben.Marsh UBT: Fix assumption that bPrecompile is equivalent to bBuildAllModules. This is no longer the case; they are now controlled by separate options. Should fix CIS errors building the editor. Change 4213609 by Ben.Marsh Ensure that strings formatted using FMicrosoftPlatformString::GetVarArgs() are always null terminated, whether we use the secure CRT or not. Change 4215971 by Ben.Marsh UBT: Remove action graph visualization code; no longer used. Change 4215996 by Ben.Marsh UBT: Remove unqiue id from all actions in the action graph. This is only used for printing debug info in the case of a (rare) cycle in the action graph, so just look it up when needed. Change 4216022 by Ben.Marsh UBT: Rename Crypto.cs to EncryptionAndSigning.cs to match the name of the class inside it, and move it under the System folder. Change 4216031 by Ben.Marsh UBT: Move all the action executors into their own folder in the project. Change 4216526 by Ben.Marsh Fix CIS warnings. Change 4216544 by Ben.Marsh Replace custom code to ensure FMicrosoftPlatformString::GetVarArgs() null terminates its buffer with Microsoft's standards-compliant implementation. Change 4216633 by Ben.Marsh Add support for UnrealPak plugins. * Project and plugin modules can now specify an array of supported programs in the "WhitelistPrograms" field of their module descriptors, to allow modules to be loaded by programs. * Programs can now load any runtime modules, as long as they are whitelisted. * Programs under the engine directory can now use a shared build environment, so that building with a project file does not cause output binaries to be output to the project directory. * UnrealPak is now always built by default when packaging * Convert UnrealPak to a modular configuration Change 4216736 by Ben.Marsh UnrealPak: Move "ExportDependencies" command into an editor commandlet, since it relies on the UObject system, asset registry, etc... Change 4217447 by Ben.Marsh Back out revision 50 from //UE4/Dev-Core/Engine/Build/InstalledEngineBuild.xml Change 4217451 by Ben.Marsh Back out revision 11 from //UE4/Dev-Core/Engine/Plugins/Developer/VisualStudioSourceCodeAccess/Source/VisualStudioSourceCodeAccess/VisualStudioSourceCodeAccess.Build.cs Change 4217617 by Ben.Marsh Back out changelist 4217451 Change 4222552 by Ben.Marsh Don't use #import <TypeLib> for VS source code accessor when building with Clang; it's not supported. Change 4222630 by Ben.Marsh UBT: Fix spam while generating project files if Clang isn't installed. Change 4223316 by Ben.Marsh UBT: Change the order in which Visual C++ toolchains are enumerated to prefer full releases over preview releases. Change 4223318 by Ben.Marsh UBT: Add a build setting which allows creating a dedicated PCH for every file that's excluded from the unity working set (disabled by default). Improves iteration times when working on individual cpp files, but slows down iterating on header changes (and can take a lot of disk space for large changes). Dedicated PCH contains all includes scraped from the top of each cpp file, until a non-#include directive is encountered. Change 4223401 by Ben.Marsh UBT: Add an option to automatically enable edit and continue for files in the adaptive non-unity working set. E&C doesn't seem very useful for UE4 projects right now; compile time is comparable to regular build times, but it can take several minutes to apply code changes for large projects. Change 4223899 by Ben.Marsh UBT: Fix loading XML config files on Mono; Type.GetField(Name) does not seem to return values unless binding flags are specified. Change 4224637 by Ben.Marsh Add a "SupportedPrograms" field to plugin descriptors, which allows plugins to declare which plugins they support independently of individual modules. Programs now respect the "bEnabledByDefault" setting in plugins. Plugins that are compatible with a program now need to list that program in the SupportedPrograms list, and whitelist any modules that should load for that program. Change 4224710 by Ben.Marsh UBT: Don't add import libraries as final build products unless the target is being precompiled. Prevents the need for building them for leaf nodes in the action graph. Change 4224715 by Ben.Marsh UBT: Remove hack to allow Stats2.cpp to not follow IWYU convention. Change 4224726 by Ben.Marsh Remove commented out line. Change 4224903 by Ben.Marsh Fix non-unity compile error in Stats2.h. Change 4225051 by Ben.Marsh Back out changelist 4224710; causing CIS errors due to receipts not matching. Change 4225134 by Ben.Marsh Fixing non-unity errors. Change 4225203 by Ben.Marsh Another non-unity fix. Change 4225249 by Ben.Marsh Fix Linux dependencies being copied for the Windows editor; they can be added as requirements for the Linux target platform on Windows instead, so it respects the user's chosen platforms. #jira UE-62001 Change 4225512 by Ben.Marsh BuildGraph: Allow setting the target to build when using the <CsCompile> task. Change 4228815 by Ben.Marsh UBT: Always add the generated code directory to the list of include paths when generating project files. It may only be created after UHT has been run. Change 4228944 by Ben.Marsh UBT: Remove legacy CppCompileEnvironment and LinkEnvironment wrappers from TargetRules that were deprecated in 4.19. Change 4229028 by Ben.Marsh UBT: Fix editor targets with unique build environment having the wrong executable path in generated project files. Move move logic to configure target rules post-construction by the rules assembly to ensure it's valid. Change 4229065 by Ben.Marsh UBT: Move another target setting into the rules assembly. Change 4229105 by Ben.Marsh Fix BPT exception when generating project files. Change 4229311 by Ben.Marsh UBT: Store the module rules file location on the ModuleRules instance, as well as the plugin that it was created from. Also expose the plugin directory as a property on the ModuleRules instance. Change 4229421 by Ben.Marsh UBT: Consolidate functionality for UHT module setup in ExternalExecution.cs. Change 4229817 by Ben.Marsh UBT: Modules must now explicitly specify the path to the header used to generate a PCH if one is desired, rather than the header being determined automatically by attempting to parse the source code. Now that PCHs are force-included anyway, this removes a lot of dependencies inside UBT. Change 4229824 by Ben.Marsh UBT: Remove unused lists inside UEBuildModuleCPP.SourceFilesClass. Change 4229841 by Ben.Marsh UBT: Remove some legacy code from auto-detecting PCHs. Change 4230521 by Ben.Marsh UBT: Add utility functions to the log class to allow formatting errors and warnings in Visual Studio output format (eg. File(Line): warning: Message) Change 4230871 by Ben.Marsh UAT: Remove StreamUtilis utility class; there is a simpler way to implement the one place it's used. Change 4230882 by Ben.Marsh UAT: Add StreamUtils back into UAT, seems like it's still used there. Change 4230896 by Ben.Marsh UBT: Remove some redundant parameters from UEBuildModule/UEBuildModuleCPP/UEBuildModuleExternal constructors. Change 4231014 by Ben.Marsh WorkspaceTool: Include a dump of raw bytes when garbage is read from the P4 process, for diagnostic purposes. Change 4231032 by Ben.Marsh Fix CIS. Change 4231096 by Ben.Marsh Bump the FlatCPPIncludeDependencyCache version, to prevent errors trying to load old files. Change 4231446 by Ben.Marsh UBT: Added support for expanding UE-specific variables in include paths and library paths: $(EngineDir), $(ProjectDir), $(PluginDir), $(ModuleDir). Change 4231460 by Ben.Marsh Modules may now explicitly specify rpaths on Linux via the PublicRuntimeLibraryPaths and PrivateRuntimeLibraryPaths properties. Change 4233909 by Robert.Manuszewski PR #4779: Reason fails as the supplied variable is incorrect (Contributed by projectgheist) Change 4233910 by Ben.Marsh Enable PCHs on IOS. Reduces build time by ~25%. Change 4234176 by Ben.Marsh UBT: Add better messaging for modules that need to have a private PCH set. Now detects the likely PCH using the same method as legacy code and includes it as a suggestion. Change 4234193 by Ben.Marsh Add the Delete command to Perforce wrapper in DotNETUtilities. Change 4234688 by Ben.Marsh UBT: Simplify handling of installed/precompiled builds. Settings for whether a folder is installed/read-only or not is now stored on the RulesAssembly instance, allowing multiple things to be configured separately and stacked together (eg. engine/enterprise/project). RulesAssembly.IsReadOnly() allows determining if a flie can be modified or not and replaces many previous IsXXXInstalledCalls(), and traverses the chain of assemblies. Change 4234711 by Ben.Marsh UBT: Runtime dependencies can now be copied to output directories as part of the build. When adding a runtime dependency, an optional source location can be specified to copy from. Both the source and target paths can use variables can be used as part of the path, eg. $(OutputDir), $(ModuleDir), $(PluginDir). Example usage (from a .build.cs file): RuntimeDependencies.Add("$(OutputDir)/Foo.dll", "$(PluginDir)/Source/ThirdParty/Foo.dll", StagedFileType.NonUFS); Change 4234872 by Ben.Marsh Expose a flag for whether the engine is installed, to fix issues generating project files. Change 4234929 by Ben.Marsh Fix null reference generating receipts when UBT makefiles are active. Change 4235883 by Chad.Garyet Merging 4231245 to core Giving Coordinator its own sln. This should fix what 4158155 was supposed to. #jira UE-61955 Change 4236075 by Ben.Marsh CIS fix Change 4237066 by Robert.Manuszewski Fix for a potential crash when terminating the engine while it's being initialized #jira UE-60545 Change 4237078 by Robert.Manuszewski The engine will no longer be resetting all linkers causing massive load times when renaming the world package when entering Play In Editor Change 4237116 by Ben.Marsh Rewrite some Windows utility functions to support paths longer than MAX_PATH. Change 4237158 by Ben.Marsh Add const TCHAR* overloads of FString::RemoveFromStart() and FString::RemoveFromEnd(). Change 4237159 by Ben.Marsh Fix FWindowsPlatformFile::GetFilenameOnDisk() support for paths longer than MAX_PATH, and simplify some of the other long path functions to avoid copying string buffers. Change 4239050 by Ben.Marsh Missing file Change 4239318 by Ben.Marsh Linux CIS fix. Change 4239685 by Ben.Marsh Static analysis CIS fix. Change 4240800 by Ben.Marsh WorkspaceTool: Include the full command line in the log for any P4 commands. Change 4240903 by Ben.Marsh PR #4909: Update copyright notices to 2018 (Contributed by projectgheist) Change 4241025 by Ben.Marsh UBT: Exclude mobile pipeline caches from generated project files. Causes huge slowdown when using 'Find in Files' through the IDE. Change 4241770 by Ben.Marsh UBT: Include action number in parallel executor output. #jira UE-62032 Change 4243469 by Ben.Marsh TBA: Merge FAnnotatedStructuredArchiveFormatter with FStructuredArchiveFormatter. Any functions that are only implemented for text archives now have a _TextOnly suffix, and are exposed through the FStructuredArchive interface. Change 4245723 by Robert.Manuszewski Fixing another creash when terminating the engine while initializing. #jira UE-60545 Change 4245862 by Steve.Robb VectorLoadFloat2(Ptr) added, which loads { Ptr[0], Ptr[1], Ptr[0], Ptr[1] } into a VectorRegister. Change 4246412 by Robert.Manuszewski The warning 'Calling StaticLoadObject during PostLoad may result in hitches during streaming' will now also report the object which had the PostLoad called on it when StaticLoadObject call happened. Change 4246612 by Ben.Marsh UBT: Fix spelling of "Intellisense". Change 4249454 by Robert.Manuszewski Added extra checks to catch scenarios where the EDL Precache Buffer is flushed before a package header is fully read Change 4249513 by Robert.Manuszewski Made sure the Async Loading Thread doesn't continue running after creating new async packages when garbage collector wants to run on the game thread Change 4255207 by Ben.Marsh UGS: Add additional logging whenever a P4 command fails, and when the user is logged out. Change 4255288 by Ben.Marsh PR #4921: Honor ModuleRules' bEnableExceptions flag when creating precompiled h. (Contributed by surakin) Change 4256422 by Ben.Marsh UBT: Add an error if a module referenced by a plugin descriptor doesn't exist. Change 4257385 by Robert.Manuszewski Creating new objects from within ForEachObjectWithOuter will now result in a fatal error as it's unsafe to change internal UObject hash tables when iterating over them. Change 4257454 by Robert.Manuszewski Added the option to filter clusters listed with gc.ListClusters by objects within them. Usage: gc.ListClusters Hierachy With=ObjectName1,ObjectName2... Change 4257526 by Robert.Manuszewski It's now possible to filter clusters that get logged with verbose cluster logging enabled (UE_GCCLUSTER_VERBOSE_LOGGING=1) by objects within them by specifying -DumpClustersWithObjects=ObjectName1,ObjectName2 in the command line Change 4257822 by Ben.Marsh Fixes for PlatformShowcase compile errors. Change 4258771 by Ben.Marsh UBT: Fix project files not being generated for foreign projects when creating .stub files. #jira UE-62462 Change 4258790 by Ben.Marsh UBT: Clean up the logic around generating project files before creating a stub IPA, so that it fails loudly if project files do not exist, and can accept target names not matching project names. Change 4259276 by Ben.Marsh UBT: Make it an error if a framework doesn't exist, rather than failing silently. Also remove some remote toolchain stuff that's no longer necessary. Change 4259280 by Ben.Marsh UBT: Fix embedded framework zips not being uploaded for plugins. #jira UE-62485 Change 4260236 by Ben.Marsh UBT: Fix path to generated engine project file. Change 4260334 by Ben.Marsh UGS: Fix custom build steps dialog inadvertantly modifying config file settings in-place. Change 4260361 by Ben.Marsh UGS: Allow for p4 login commands to fail, even though the user is logged in (due to a bad connection, etc...) Change 4260559 by Ben.Marsh UGS: Update version. Change 4261160 by Robert.Manuszewski MediaPlaylist will now be added to root set if the owning MediaPlayer is in the disregard for GC set (fixes GC assumption violation crash) #jira UE-62495 Change 4261421 by Ben.Marsh Force-sync files for building documentation, to fix issues with files not being updated. #jira UE-62413 Change 4261425 by Ben.Marsh UBT: Remove some leftover functions for handling the remote toolchain. Change 4261530 by Ben.Marsh UBT: Speculative fix (and better error reporting) for IOS mobile provision not being found in CIS. Change 4261611 by Ben.Marsh UBT: Downgrade warning to a log message, since it appears when generating project files. Change 4261710 by Ben.Marsh Remove assert that GLogConsole is set; it won't be for command line utilities that don't depend on ApplicationCore. #jira UE-62545 Change 4261831 by Ben.Marsh Fix compile errors due to missing include path when hot-reloading a module from the editor. There are not necessarily source files to compile when -modulewithsuffix is specified on the command line, which was results in GeneratedCodeWildcard not being set. #jira UE-62463, UE-62384 Change 4262723 by Ben.Marsh Whitelist plugins that need to be loaded by UFE. #jira UE-62564 Change 4265444 by Ben.Marsh Fix incorrect executable name for DebugGame configurations in Xcode. #jira UE-62574 Change 4265892 by Ben.Marsh Fix incremental compile failures due to dependency checking for unity files. CachedIncludePaths was not correctly being set on file items, so dependencies were being ignored. #jira UE-62575, UE-62603, UE-62597 Change 4266019 by Josh.Adams - Fixed the CopyAction for runtime dependencies that need to be copied to different location, on non-XGE Change 4266264 by Ben.Marsh Remove override for the __IPHONE_OS_VERSION_MIN_REQUIRED macro on TVOS. This macro is already defined by system headers (in <AvailabilityInternal.h>). Now that we support PCHs on IOS and TVOS, manually defining this macro results in it being defined three times (once for the PCH, once by AvailabilityInternal.h, and once by the force-included list of definitions for the source file being built). The errors for redefining the macro in AvailabilityInternal.h are suppressed due to it being a system header, but the error for redefining it for the source file being compiled are not. #jira UE-62578 Change 4266273 by Ben.Marsh Fixes incremental build failure when compile arguments for PCH have changed on IOS/TVOS. Compile action needs to have a dependency on PCH build action. Change 4266614 by Graeme.Thornton Fix crash when cooking nativized blueprints due to removal of child cooker system. Change 4266763 by Ben.Marsh Always build UnrealPak when building client targets. The ProjectParams.Pak option is not reliable, because it can be forced on later by the target platform. #jira UE-62584 Change 4267985 by Robert.Manuszewski When iterating with ForEachObjectWithouter, don't lock the entire has table but only the hash bucket that is currently being iterated #jira UE-62600 Change 4268558 by Robert.Manuszewski PurgeLegacyBlueprints will no longer be called from within ForEachObjectWithOuter is it renames objects that reside in hash tables that are being iterated over which may lead to undefined behavior. #jira UE-62600 Change 4269011 by Chad.Garyet - Fixing Wildcard match issue, the change to ugsapi sends projects as //Depot/Stream instead of //Depot/Stream/ Wildcard match was only substringing to 3 chars. - Checking in the change a while back that increases the number of queried jobs up to 432 based on some maths from Bob about how many builds we want to grab Published to ugsapi server 8/8/17 #jira none Change 4270788 by Ben.Marsh Fix IOS provisioning data being using when remote compiling on TVOS. #jira UE-62705 Change 4271916 by Ben.Marsh Tag the XGEControlWorker executable as a build product after compiling SCW, to make sure it's included in the UGS zip file. Change 4271934 by Ben.Marsh Upload all static libraries in plugin folders as part of remote builds. #jira UE-62694 Change 4273368 by Ben.Marsh Fix Slate dependencies not being enumerated, and rules assembly not being rebuilt when building remotely. #jira UE-62705 Change 4274049 by Ben.Marsh Always parse the team UUID out of the mobile provision when doing a remote compile. The provision installed on the remote Mac (and selected for signing) may be different. #jira UE-62751 Change 4274823 by Ben.Marsh Add the -VersionCookedContent argument to disable the -unversioned parameter on the cooker command line. Change 4275838 by Ben.Marsh Fix BuildVersion string not being passed through from <SetVersion> task. Also add a -BuildVersion command line argument to UBT to override it for a particular build. Change 4275913 by Ben.Marsh Add a dummy exported symbol to the XGEController module, to fix build errors due to missing .lib file when it's built with WITH_XGE_CONTROLLER = 0. Change 4284161 by Ben.Marsh Allow mirroring Oodle files to remote Mac. Change 4074774 by Steve.Robb Vast simplification of TFunction, making it smaller in footprint, easier to follow and extend, and more correct. TUniqueFunction added, which is a move-only TFunction which can hold move-only functors. Fix for UWidgetBlueprint::ForEachSourceWidget() which should never have compiled but did. FFunctionGraphTask and TFuture<> updated to use TUniqueFunction to make them more general. TArray::HeapPop() made to work with move-only types. Change 4082591 by Ben.Marsh Move the Log class from UBT to DotNetUtilities. Change 4083236 by Ben.Marsh Add a Log.WriteException() method to dump an exception message to the console (and write the exception trace to the log) Change 4084107 by Ben.Marsh UAT: Remove the unused -SkipHeader argument to UE4Build. Change 4089771 by Steve.Robb GitHub #4743 : modified VirtualAlloc function flag https://blogs.msdn.microsoft.com/oldnewthing/20151008-00/?p=91411 Change 4091456 by Steve.Robb Unification of all platforms' FMath::CountTrailingZeros() and FMath::CountLeadingZeros() for both 32-bit and 64-bit. Change 4156437 by Ben.Marsh Lots and lots of fixes compiling for Clang on Windows. Editor now compiles cleanly without warnings, but crashes on startup due to error in intrinsics test. Disabling that runs further, but crashes accessing freed memory. Switching to the ANSI allocator runs further, but crashes in Slate after the splash screen and before the editor window opens. // TODO! * Switching between Clang/ICL/VS2015/VS2017 is now supported through the same mechanism as switching Visual Studio versions, without requiring any source level changes. To use Clang, set WindowsPlatform.Compiler = WindowsCompiler.Clang from a .target.cs file, or set <WindowsPlatform><Compiler>Clang</Compiler></WindowsPlatform> from BuildConfiguration.xml. To pick a specific toolchain version, set WindowsPlatform.CompilerVersion. * Clang is now supported through AutoSDKs; will be added to CIS. * The Samples/Sandbox/Clang project forces Clang to be used from its target.cs file, and allows easily building all editor modules and plugins with Clang on Windows. * UnrealMathSSE intrinsics have been re-enabled for Clang due to missing functions from the UnrealMathFPU implementation, but causes failure in tests at startup. * SSE4_CRC32() is disabled in D3D12Pipelinestate.cpp, since intrinsics are only allowed if enabled for the whole target (rather than being used in specific functions due to runtime checks) Change 4157389 by Ben.Marsh Few more fixes for compiling the editor with Clang. Change 4183911 by Ben.Marsh Fixes to support incremental linking on Windows. Does not seem to have any net benefit right now; may improve once minimal rebuild is enabled. * Incremental linking no longer forces PDB files to be enabled for source files. * Actions can specify specific files to be deleted before each build. Code to forcibly delete PDB files has been moved to the MSVC toolchain. * Unused libraries produced by the cross-referenced link are no longer added as build products, since (a) deleting them breaks dependency checking for incremental linking and causes a full link, and (b) not deleting them breaks UBT dependency checking and causes actions to be run over and over again. * Icon update is disabled for Windows when incremental linking is enabled. * Removed rarely-used setting to always delete produced items before each build. Change 4184311 by Ben.Marsh UGS: Added a dialog which shows all the required platform SDKs for a branch, linked from the status panel in UGS. The llist is configured via the UGS config file submitted to Engine/Programs/UnrealGameSync/UnrealGameSync.ini (and may be overridden by the project config file if necessary): [Default] ; Set this to a network share which contains the SDK installers for your site SdkInstallerDir= ; All the required SDKs for the current version of the engine +SdkInfo=(Category="Android", Description="NDK r21", Browse="$(SdkInstallerDir)\\Android") +SdkInfo=(Category="Windows", Description="Visual Studio 2017") +SdkInfo=(Category="Windows", Description="Visual C++ Toolchain 14.13.26128") +SdkInfo=(Category="Windows", Description="Windows SDK 10.0.16299.0") Similar entries for console platforms are added in console subdirectories. Each entry may contain an Install="Foo.exe" and/or Browse="C:\Foo" style attribute, specifying the path to an installer to run or directory to open in explorer respectively. The SdkInstallerDir setting is used as a base directory for the default installers, seen above for Android. Licensees may override this with a network path specific to the site that UGS is being deployed to (either in this file, in a project specific config file, or in a Engine/Programs/UnrealGameSync/NotForLicensees/UnrealGameSync.ini file). Change 4200452 by Ben.Marsh UBT: Change DebugGame configurations to output a separate executable rather than requiring a -Debug argument at runtime. Previous behavior was a common source of errors. Engine modules are still shared between Development and DebugGame, but the launch module sets a flag in Core on startup indicating the game configuration. Change 4206189 by Ben.Marsh UBT: Simplify logic for precompiling binaries. * Target no longer has separate list of "precompile only" binaries or modules. New -AllModules option allows adding every module to a target, which can be used with -Precompile and -NoLink to precompile object files for monolithic builds. * Precompiled file lists have been removed from target receipts. * The manifest now includes all generated headers and precompiled files when run with the -Precompile option. * Separate -DependencyList=Foo.txt has been added to write a list of all dependencies required to use precompiled binaries. This file list can be read using the <Tag> task in buildgraph. Change 4215466 by Ben.Marsh UBT: Remove indirect calls to determine extensions for object files and precompiled headers. The toolchain knows the correct convention for the platform. Change 4215975 by Ben.Marsh UBT: Remove telemetry code. This has never proved useful for analyzing performance due to the number of incidental factors that affect build times (eg. number of files being compiled). Change 4220154 by Ben.Marsh Move text-only implementations of FOutputDeviceError back into Core, so we can build command-line applications that don't depend on ApplicationCore. Change 4224708 by Ben.Marsh Add a bCompileAgainstApplicationCore setting to the target rules, which allows compiling out references to the ApplicationCore module (which should only be necessary for applications with a GUI). Removed ApplicationCore from several engine tools and utilities. Change 4224958 by Ben.Marsh Remove CoreMinimal.h includes from Core. Change 4229059 by Ben.Marsh UBT: Remove the UEBuildPlatform.ShouldNotBuildEditor() hook for target platforms. We shouldn't be modifying a target's build environment to disable the editor; it is invalid to build the editor for these target platforms at all, and this is already enforced by the GetSupportedPlatforms() function. Change 4230508 by Ben.Marsh Fixup precompiled header setting for samples and games. Change 4231457 by Ben.Marsh Fix exceptions in log messages having trailing newlines. Change 4232406 by Ben.Marsh UBT: Always force include a PCH for generated code if there's one set; the code may depend on it to compile. Change 4234177 by Ben.Marsh Set up private PCH files everywhere that previously used them. Change 4235973 by Ben.Marsh Change FPlatformMisc::GetEnvironmentVariable() to return an FString() rather than requiring a fixed size buffer to be passed in. Removes references to MAX_PATH. Change 4238842 by Ben.Marsh Add support for paths longer than MAX_PATH in the editor. Requires Windows 10 version 1607, and the functionality to be enabled via a registry key or group policy (see https://docs.microsoft.com/en-us/windows/desktop/FileIO/naming-a-file). Only a subset of Win32 functions support long paths (executables can only be started from paths shorter than MAX_PATH, for example). * Added a FPlatformMisc::GetMaxPathLength() function to return the maximum length of a path on the current system. On Windows, this returns a different value for systems with long paths enabled to those without. * The MAX_PATH define is no longer set by non-Windows platforms. Instead, there is a MAC_MAX_PATH, UNIX_MAX_PATH, etc... for any platform-specific code that still relies on the previous macro. * The MAX_UNREAL_FILENAME_LENGTH macro has been renamed to MAX_UNREAL_FILENAME_LENGTH_DEPRECATED * The PLATFORM_MAX_FILEPATH_LENGTH macro has been renamed to PLATFORM_MAX_FILEPATH_LENGTH_DEPRECATED. * Removed custom resource files for programs, since they are just copies of the base UE4 one (which is used by default anyway). The base UE4 manifest declares support for long paths. * Fix 512 character maximum length on editor commands. 260 character limit remains in place for cooking at the moment (see ContentBrowserUtils.h), until C# staging code supports long paths. Change 4255042 by Ben.Marsh UBT: Remote compilation now uploads the entire workspace to the remote Mac and executes a separate remote instance of UBT rather than synchronizing individual actions. This makes the remote compile codepath much simpler, and removes a lot of special cases that exist to support it previously. The list of files to be transferred to the remote are listed as rsync filter rules in Engine/Build/Rsync/RsyncEngine.txt and RsyncProject.txt, which are applied to the root engine directory and project directory respectively. Projects that need to customize which files are uploaded can add their own <ProjectDir>/Build/Rsync/RsyncProject.txt file, which will be included in the filter before the default version. Change 4260567 by Ben.Marsh UAT: Rename CommandUtils.Log to CommandUtils.LogInformation, to avoid conflicts with the underlying Tools.DotNETCommon.Log class. #rb none [CL 4285673 by Ben Marsh in Main branch]
2018-08-14 18:32:34 -04:00
LogInformation("Waiting for client logging process to start...{0}", ClientLogFile);
Thread.Sleep(2000);
}
if (FileExists(ClientLogFile))
{
Thread.Sleep(2000);
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 4285612) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3836829 by Ben.Marsh UBT: Fix ability to precompile plugins from installed engine builds. Change 3839519 by Ben.Marsh UBT: Simplify configuring bPrecompile and bUsePrecompile settings for modules. Each rules assembly can now be configured as installed, which defaults the module rules it creates to use precompiled data. Change 4042043 by Steve.Robb GitHub #4705 : Added weak lambda's for delegates and multicast delegates. Change 4042056 by Robert.Manuszewski Optimized Mark Phase of GC by up to 10ms by making it run in parallel and removing a huge array presize which we didn't need. Change 4042104 by Robert.Manuszewski Set the minimum GC cluster size to 5 so that GC doesn't have to process micro clusters which are more expensive than processing individual objects + Exposed the minimum cluster size to ini and project settings as gc.MinGCClusterSize + Added the ability to sort clusters by name/object count/mutable object count/referenced clusters count when dumping them with gc.ListClusters command Change 4042377 by Robert.Manuszewski Reworked how GC and other threads (ALT specifically) interact - GC will now notify the ALT it wants to run and ALT will immediately try to finish its current work to allow that. Also the entire ALT tick is now protected against GC running at the same time to improve ALT stability. + added gc.ForceCollectGarbageEveryFrame console variable that triggers a forced GC every frame Change 4042427 by Robert.Manuszewski Changed FGCCSyncObject to use events when waiting for GC to finish so that it doesn't spin on non-game threads when GC is running Change 4042482 by Robert.Manuszewski Unhashing unreachable objects (ConditionalBeginDestroy) will now also be done incrementally, just like the purge phase of Garbage Collection Change 4042635 by Robert.Manuszewski Fix for a potential assert when incremental purge garbage is pending and something forces a full purge Change 4044092 by Steve.Robb Fix for forward declared CoreUObject weakobject types in delegates when building in Clang. Change 4044102 by Robert.Manuszewski Fix for a possible hang when worker threads are preventing GC from running and something is later trying to FlushAsyncLoading with the Async Loading Thread enabled Change 4044113 by Steve.Robb Another Clang fix. Change 4044160 by Robert.Manuszewski Disregard For GC pool will now be enabled by default in cooked builds Change 4044287 by Steve.Robb Typo fix. Change 4047723 by Graeme.Thornton TBA: Fixes for import/export name cache and object resolving Change 4048015 by Graeme.Thornton TBA: Weak/Soft/Lazy pointer serialization changes * Remove FWeakObjectPtr::Serialize, move it's logic into, and replace usages of with calls to, FArchiveUObject::SerializeWeakObjectPtr(). Ensures that something is always sent to the archive so that structured archives can be kept happy in the future. * Added Weak/Soft/Lazy pointer handling to the structured archive slot interface and all the formatters. Binary formatters just forward the call onto their inner and text archives store as a string path reference. * FArchiveUObjectFromStructuredArchive caches all these pointer types and stores indices in the binary block, same as with a UObject*. All pointers are then forwarded to the underlying formatter in one go on finalization. Change 4048021 by Steve.Robb Fix for binding an unbound TFunction to another TFunction with a different signature. Also all null pointers now count as unbindings, not just nullptr. TIsMemberPointer added. TIsATFunction and TIsATFunctionRef renamed to remove the 'A's. Change 4048544 by Robert.Manuszewski Fixing ConditionalBeginDestroy profiling after changes to incremental CBD. Change 4051028 by Graeme.Thornton TBA: ArchiveFromStructuredArchive adapter uses Inner to determine if it is outputting to text, and sets it's own ArIsTextFormat to false Change 4051056 by Graeme.Thornton TBA: High level tagged property / UObject base class text serialization - UObject serialize converted to structured archive - Properties written to text individually with text tags, and then binary adapted values - Only saves, doesn't load Change 4051111 by Graeme.Thornton TBA: Temporarily disable loading of text assets until tagged property serialization path is fixed up Change 4051154 by Graeme.Thornton TBA: Convert a few uobject serializers to structured archive format for example purposes Change 4051181 by Graeme.Thornton TBA: Added default structured archive implementation of SerializeItem to UProperty, which just calls the FArchive version on an FArchiveUObjectFromStructuredArchive adapter. Implemented structured archive SerializeItem for UArrayProperty Change 4051197 by Graeme.Thornton TBA: ObjectProperty text serialization Change 4051216 by Graeme.Thornton Restored a modified FWeakObjectPtr::Serialize function to keep backwards compatibility in code I don't have access to. Change 4051261 by Graeme.Thornton TBA: Convert UMetaData to structured archive Change 4051374 by Steve.Robb Incorrect assert removed. Change 4051562 by Robert.Manuszewski Adding stats for the new GC internal functions Change 4051614 by Graeme.Thornton TBA: Removed UProperty::SerializeItem(FArchive, ...) and replaced with UProperty::SerializeItem(FStructuredArchive::FSlot, ...). Fixed up most of them to work properly and added adapters in for any that were non-trivial. Change 4052512 by Graeme.Thornton TBA: Temporary workaround for softobjectptr and lazyobjectptr uproperties not serialization anything when they know the archive is a reference collector. They should always be serializing their pointers and letting the underlying archive itself ignore them. Change 4053917 by Robert.Manuszewski Clustered objects from clusters that are no longer reachable will now be marked as unreachable immediately when gathering unreachable objects Change 4053919 by Robert.Manuszewski Added the ability to disable incremental BeginDestroy in ini/project settings Change 4055518 by Daniel.Lamb Fixup for deterministic audio generation issue. Submitted on behalf of Rich.Whitehouse #jira nojira #test prefilght automated test. Change 4056854 by Graeme.Thornton TBA: Added a test asset to EngineTest which contains all the different property types and test cases. Change 4056858 by Graeme.Thornton TBA: Updated USetProperty to proper structured archive usage Change 4056872 by Graeme.Thornton TBA: Add map property field to test object Change 4056873 by Graeme.Thornton TBA: Convert UMapProperty to full structured archive Change 4056994 by Graeme.Thornton TBA: Converted FText over to structured archive. Implemented saving, but not loading. Change 4059728 by Ben.Marsh UBT: Add support for using adaptive non-unity builds when the engine and project are in separate repositories. Change 4059805 by Graeme.Thornton Fixed typo in text serialization. Fixes CIS automation test errors Change 4060007 by Graeme.Thornton TBA: FArchiveFromStructuredArchive will now access it's host slot lazily, i.e. only when a value is actually written to the archive. Change 4060092 by Stefan.Boberg Added optimized Windows console window output path to GenericConsoleOutput since this slowed down cooking considerably (2 minutes spent in wprintf alone for one large dataset) When stdout is attached to a console we use the WriteConsoleW function instead of wprintf since the latter is very slow especially in unbuffered mode which the engine currently configures for stdout (see setvbuf call in LaunchEngineLoop.cpp). At some point we should reconsider this buffering policy since it's likely to slow down other platforms as well but I wanted to do a safe change for now as I don't yet fully understand why the setvbuf call is there in the first place. Change 4060108 by Stefan.Boberg Introduced some additional target platform utilities to help with asset cook optimizations * We now assign each ITargetPlatform a zero-based ordinal value * Introduced FTargetPlatform and FTargetPlatformSet types to help store platform references and platform sets efficiently. These are not currently used in the engine but are designed to replace the existing ITargetPlatform/string/FName representations in the cooking data structures. Change 4060143 by Graeme.Thornton Undo //UE4/Dev-Core/Engine/Source/Runtime/... changelist 4060007 Needs some other changes that I haven't checked in yet... Change 4062432 by Ben.Marsh Fix error message when enumerating P4 changes. Change 4062648 by Ben.Marsh Add missing p4 integration action. Change 4063620 by Graeme.Thornton Integrated a fix from UDN where the engine would crash when trying to load a very small encrypted file (<16bytes) from a pak file, where the read address wasn't already aligned to the AES block size. (https://udn.unrealengine.com/questions/431989/crash-while-reading-a-very-small-file-in-encrypted.html) Change 4066963 by Robert.Manuszewski Fixing GC cluster verification code reporting false positives when a cluster is referencing another cluster through 'mutable' objects list. Change 4067133 by Robert.Manuszewski Changed log verbosity when reporting individual cases of GC cluster assumption violations as they are followed by an asser anyway and this way we get the chance to see all issues before we assert at the end of these checks. Change 4067443 by Steve.Robb FString can now be constructed from any char pointer type and length. Change 4068156 by Steve.Robb Fix necessary because of FString constructor change in CL# 4067443. Change 4070258 by Graeme.Thornton Fixes for VSCode Change 4070372 by Graeme.Thornton TBA: Script struct serialization to structured archives Change 4071913 by Ben.Marsh Move bulk of the code for UnrealPak into an engine developer module, so it can be used in the editor. Change 4071914 by Ben.Marsh Missing files. Change 4071937 by Ben.Marsh Missing header. Change 4072015 by Ben.Marsh Fixes for compiling PakFileUtilities as part of the editor. Change 4072826 by Steve.Robb TBitArray::Reserve() added. TBitArray::Add() overloaded to allow adding multiple bits. TSparseArray::Reserve() optimized to call the overloaded Add(). Change 4073271 by Daniel.Lamb Fixed add patch tier in project launcher passing the wrong commandline option to UAT. #test none Change 4074708 by James.Hopkin #core Removed redundant Casts Change 4074763 by Steve.Robb Fix for TSparseArray::Reserve() size. Change 4076063 by Ben.Marsh Add an "UnrealPak" commandlet with the same functionality as the standalone UnrealPak program. Invoke by running the editor with -run=UnrealPak and the standard UnrealPak commandline options. Change 4077064 by Robert.Manuszewski Fixing compile error in PakFileUtilities Change 4077144 by Graeme.Thornton TBA: TextAssetCommandlet improvements * Collect lists of broken assets during roundtrip tests and print a summary of packages that failed each phase at the end * After resaving as text, load the file back as a plain JSON hierarchy to ensure the output was valid Change 4077412 by Ben.Marsh Set the correct exit code for UnrealPak. Should return 0 on success, not 1. Change 4077760 by Graeme.Thornton TBA: Loading fixed for tagged property serialization Includes conversion of all UProperty::ConvertFromType() and SerializeFromMismatchedTag() functions to use structured archives Lazy initialization of FArchiveFromStructruredArchive when loading, to support the possibility of an adapter being create around an object property serialize call to its inner UStruct, which then decides not to do anything and return false. Stops the ArchiveFromStructuredArchive from consuming the slot and getting upset later on when we try to serialize normal tagged properties from it. Disabled lazy bulk data loading from text assets. Requires a bigger change to make it work. Added some debug checks to json input formatter which track the current value stack size when a new object is pushed onto the stack, and makes sure that the stack has returned to the same size when the object is popped. Catches cases where we unpack an array/stream to the value stack but then don't consume all the items. Change 4078800 by Ben.Marsh Change UAT to using the editor's UnrealPak commandlet rather than invoking the standalone UnrealPak executable. To improve performance when building several PAK files, also add a new -batch=<file> command which reads commands to execute in parallel from a text file. Change 4079745 by Graeme.Thornton TBA: Migrated a couple of UObject Serialize functions to FStructuredArchive (SoundCue / MaterialExpressions / Editor strip flags) Change 4079847 by Graeme.Thornton TBA: Add 'FindMismatchedSerializers' mode to text asset commandlet, which dumps out a list of all UClasses which don't have the CLASS_MatchedSerializers flag, meaning we can't guarantee the have Serialize functions for FArchive AND FStructuredArchive, therefore we can't use the new structured archive based serialize path. Should only ever be native instrinsic classes as UHT takes care of all other cases. Change 4079925 by Ben.Marsh Fix incorrect assignment when deriving name for chunked pak file. Change 4080214 by Ben.Marsh Move the ThreadPoolWorkQueue class into DotNETUtilities so it can be used by other projects. Change 4082394 by Graeme.Thornton CIS fix for variable shadowing warning Change 4082583 by Ben.Marsh Add a IBinarySerializable interface for types that support reading from a BinaryReader and writing to a BinaryWriter. Implementing IBinarySerializable implies a constructor taking a BinaryReader argument is available for deserializing. Change 4082652 by Ben.Marsh Fix FileReference.Directory not returning a directory with a trailing backslash for files in the root directory. Change 4082755 by Graeme.Thornton Fixed an erroneous usage of TUniquePtr<uint8>as a pointer to a uint8 array when creating pak files. Caused a crash when compression was enabled, and has probably surfaced because pak generation is now done by an editor commandlet rather than a standalone program. Change 4082756 by Graeme.Thornton Fixed some incorrect documentation for pakfile compressed chunk headers Change 4082883 by Graeme.Thornton Static analysis warning fix Change 4082912 by Ben.Marsh Move ExceptionUtils into DotNETUtilities. Change 4085291 by Graeme.Thornton TBA: In the Json output formatter, write float and double values out with enough precision for successful roundtripping. Added some debug only code which will immediately reconvert the string back to its original value and compare the the input Change 4085523 by Graeme.Thornton TBA: Remove only explicit usage of DECLARE_FSTRUCTUREDARCHIVE_SERIALIZER. Should only be used from UHT generated code. Change 4086037 by Robert.Manuszewski Fix for a potential race condition when two threads want to acquire GC lock Change 4088655 by Graeme.Thornton Pak creation now uses the bEnablePakSigning setting from the crypto config json file Change 4091474 by Steve.Robb Fix for TStaticBitArray::FindFirstSetBit() and TStaticBitArray::FindFirstClearBit(). Unused variables removed. Change 4093632 by Steve.Robb CIS fixes. Change 4093656 by Graeme.Thornton Build fix Change 4093744 by Ben.Marsh Allow per-chunk settings for whether to enable compression in UnrealPak. Change 4099712 by Gil.Gribb UE4 - Fixed rare case where insufficient space was preallocated for cooldown ticks. #jira UE-59686 Change 4099912 by Stefan.Boberg Cooking timer optimizations: - Replaced data structures for FScopeTimer and FHierarchicalTimerInfo. Previous implementation used FString for many things and caused *lots* of heap and string concatenation activity. Replaced with a compile-time node id (using __COUNTER__) and raw string literals. - Removed PERPACKAGE_TIMER support (was disabled by default and was difficult to test) - Made it possible to toggle OUTPUT_TIMING and ENABLE_COOK_STATS independently - Removed some extremely tight timers because the overhead from calling QPC significantly exceeded the measured code This change shaved some 15% off a clean cook of Fortnite WindowsClient (en) with fully populated local DDC Change 4100519 by Stefan.Boberg Quick fix for Linux build issue introduced in 4099927 Change 4105327 by Stefan.Boberg Cooker: Changed FHierarchicalTimerInfo so it uses a linked list for tracking child nodes, to be able to deal with any child count. Previously we assumed there would never be more than 9 children but it turns out there are cooker modes that need more. Fixes check when using -FullLoadAndSave to cook Change 4105448 by Stefan.Boberg - Fixed Linux build warning re: member initialization order - Also eliminated OUTPUT_HIERARCHYTIMERS/CLEAR_HIEARCHYTIMERS macros (plain functions are fine) - Moved finishing-up code for FullLoadAndSave() to TickCookOnTheSide() call site to improve timer output. Previously some of the scopes would not have been closed before printing and thus the output was misleading. Change 4109031 by Ben.Marsh Attribute-driven Perforce wrapper (old Epic Friday project). Offers a more complete implementation than the current P4 wrapper in UAT without requiring any platform-specific libraries. Uses the Python binary output for parsing. Change 4109588 by Ben.Marsh UBT: Add extension methods for serializing a nullable type to a BinaryReader/BinaryWriter. Change 4109595 by Ben.Marsh Missing project file for DotNETUtilities. Change 4110724 by Stefan.Boberg Removed annotation map locking in UObjectMarks, eliminating around one minute (~3.5%) from Fortnite cook time. The locking was redundant since the annotation maps are managed per thread anyway. Change 4111304 by Ben.Marsh UAT: Add support for setting a status message through the log class. Allows writing transient messages (eg. progress messages) which will be cleared out before writing other messages. Best used through the LogStatusScope class, which can set a status message for the duration of a using() block. As part of this change, the console no longer has to be added as a dedicated trace listener. Since we already special-case this listener when formatting log output, it's easier to just keep the implementation separate to the other trace listeners. Change 4112708 by Steve.Robb Fix for TBitArray::MaxBits in assignment. Change 4114133 by Stefan.Boberg Tweaked how low-level memory (LLM) tracker is implemented to reduce overheads. Previously FMemory functions would acquire the LLM singleton and call OnLowLevelFree/OnLowLevelAlloc etc which would check the bIsDisabled flag and early out if it was set. Due to how frequently these functions were called this ended up costing quite a bit. - This change makes the flag a static member variable instead of a member variable and therefore enables a simpler early-out to be implemented. - The singleton getter is also simplified to avoid hitting the threadsafe singleton construction path on every call. - The enable flag is no longer TAtomic - this also incurs extra overhead for no clear benefit Shaves approximately 3.5% (one minute) off a Fortnite cook test scenario (using -FullLoadAndSave) Change 4115010 by Robert.Manuszewski Fixing CIS Change 4115249 by Robert.Manuszewski Fixing async loading code asserts when exiting game very early due to an error #jira UE-56267 Change 4117091 by Ben.Marsh Prevent doubled-up lines when writing status updates with console log verbosity. Change 4117207 by Ben.Marsh UGS: Do not include executables in diagnostics zip file, and ignore "no such files" error when cleaning workspace. Change 4119175 by Ben.Marsh UGS: Fix crash writing version files when directory does not already exist. Change 4119987 by Ben.Marsh UGS: Show a dialog box while the launcher is updating executables from Perforce, which allows cancelling the operation if necessary. Allow setting the username on the settings window, and prompt for login credentials if necessary. Should prevent situations where users have to update settings from the command prompt. Holding down shift during launch now shows the settings dialog rather than an immediate prompt to launch the unstable version (unstable version is shown as a checkbox on this dialog). Change 4119991 by Ben.Marsh Update version number for UGS launcher to 1.13. Change 4121943 by Robert.Manuszewski Don't use FArchiveAsync2 for reading packages with non-async path in editor builds as its performance is worse than the standard archive's (saves about 1 minute when doing larger cooks and 7 seconds when loading into PIE) Change 4122592 by Steve.Robb GitHub #4762 : Improve wording and grammar of Math comments Also includes improved accuracy in FMath::ComputeBoundingSphereForCone(). Change 4122819 by Stefan.Boberg Don't call CreateDirectory redundantly when opening files for writing using FFileManagerGeneric::CreateFileWriter This change avoids calling IPlatformFile::CreateDirectoryTree if possible since this is a very expensive function especially for deep hierarchies as it performs directory creation from the root directory onwards instead of from the leaf downwards. That function should also be fixed but this change improves performance in the meantime. Change 4122872 by Stefan.Boberg CreateDirectoryTree now creates directories leaf-to-root instead of the other way around. This is much more efficient since we don't spend time on system API calls for directories which already exist. This accounted for a very large amount of CPU time in cooking as the full target file directory hierarchy would be "created" for every single output file. Change 4123109 by Stefan.Boberg - Disable overlapped I/O in editor / cooker. Synchronous I/O reduces the number of syscalls and Windows performs prefetching on our behalf anyway for sequential reads - Eliminated syscall which was issued for every write to update cached file size -- since we're the only writers to the file (file access allows read sharing at most) we can authoritatively update the file size on write completion Change 4123455 by Ben.Marsh PR #4775: New build param PCHMemoryAllocationFactor to set /Zm VS build param. (Contributed by lucaswall) Change 4124207 by Ben.Marsh UBT: Remove some unnecessary indirection for generated code paths. Change 4124217 by Ben.Marsh UBT: Remove another unused variable from UEBuildModuleCPP. Change 4124377 by Stefan.Boberg In IPlatformFile::DeleteDirectoryRecursively, attempt to delete file first and if it fails clear the readonly flag and try again Previously there was a call to clear the readonly flag for every deleted file and this is a waste of resources 99% of the time. The SetFileAttributes call accounted for a significant amount of time during cooker sandbox directory deletion Change 4125071 by Stefan.Boberg Some tweaks to FQueuedThreadPoolBase scheduling and memory management - Explicitly pass in false for TArray::RemoveAt(..., bool bAllowShrinking) argument to prevent memory reallocation when arrays are drained and inevitably repopulated shortly afterwards - Use a MRU strategy instead of LRU when picking a thread to wake up. The MRU thread is the most likely to have a 'hot' cache for the stack etc. Picking from the back of the array also happens to be cheaper since no memory movement is necessary when RemoveAt is called. (This was the strategy in place before CL2600362 which seems to have changed it unintentionally) - Release lock as soon as a thread has been chosen, before asking the worker thread to wake up and do the work Change 4126132 by Ben.Marsh UAT: Detect when stdout is redirected and prevent using backspace characters to move the cursor. Change 4126867 by Graeme.Thornton TBA: Fix tagged binary formatter Change 4127010 by Robert.Manuszewski AnimScriptInstances created at runtime will now also be added to the owning omponent's cluster to avoid GC issues. Change 4127932 by Ben.Marsh WorkspaceTool: Reduce unnecessary logging of status messages when console output is not redirected. Change 4129050 by Ben.Marsh UGS: Check for NET Framework 4.5 being installed before running the installer. Also fix warning trying to kill existing UGS instances before upgrade. Change 4129459 by Graeme.Thornton TBA: TextAssetCommandlet - When outputting converted assets to an output path, replicate the workspace relative path in the output directory Change 4129515 by Graeme.Thornton TBA: Add EnterRecord overload that allows outputting of available field names when loading. Change 4129517 by Graeme.Thornton TBA: Tagged properties are written out as named fields on the "Properties" record, rather than as a stream with a null tag at the end Change 4129518 by Graeme.Thornton TBA: Added a local const bool to allow easy hacking out of text asset loading support Change 4129558 by Graeme.Thornton TBA: Build fix for textasset-less configs Change 4129614 by Ben.Marsh UGS: Main window is now restored to normal size when activated by clicking on the tray icon. #jira UE-60490 Change 4129618 by Ben.Marsh UGS: Speculative fix for unreproduced exception accessing disposed window while shutting down. Change 4131936 by Robert.Manuszewski Removing some WIP code accidentally checked in with CL #4121943 Change 4133490 by Ben.Marsh UGS: Allow the $(Change) variable to be used in more places than just the context menu. #jira UE-60573 Change 4133550 by Ben.Marsh UGS: Setting for whether or not to use incremental builds is now exposed through the variable "$(UseIncrementalBuilds)" for use by custom build steps. #jira UE-60554 Change 4133681 by Ben.Marsh UGS: A per-project list of folders and extensions to be deleted by default when running the 'clean workspace' tool can now be specified through the <ProjectDir>/Build/UnrealGameSync.ini file. Settings may be specified for an individual branch (via a category with the depot path to the project) or for wherever the project is currently open (via the [Default] category). The SafeToDeleteFolders list specifies a substring that will be checked against folder paths. Anything containing this folder will be marked as safe for delete by default. The SafeToDeleteExtensions list specifies a list of extensions for files that can always be deleted. Example: [Default] +SafeToDeleteFolders=/MyGame/Test/ +SafeToDeleteFolders=/DataService/ +SafeToDeleteExtensions=.xx1 +SafeToDeleteExtensions=.xx2 #jira UE-60575 Change 4135449 by Ben.Marsh Fix allowing use of Job objects on Windows platforms (debug code submitted by mistake) Change 4135730 by Ben.Marsh UBT: Plugins can now be enabled and disabled from the .target.cs file (for targets that do not use the shared compile environment), by compiling the list of enabled/disabled plugin names into the Projects module. Change 4135823 by Ben.Marsh UBT: Remove legacy code to handle disabling optional plugins; now that this is compiled into the target, it will work for any plugins we choose. Change 4135945 by Ben.Marsh UBT: Fix error running programs with no explicitly enabled or disabled plugins. Change 4137207 by Ben.Marsh UGS: Align all badges with the same name, to make it easier to see which CIS steps are being run. Allow overriding the slot taken by a particular badge by calling it "SlotName:LabelName". Change 4137311 by Stefan.Boberg Removed child cooker support. In practice it is not a useful feature as it provides no performance improvement (quite the opposite in fact) and adds testing and maintenance complexity. Change 4137393 by Ben.Marsh UGS: Fix display of multiline errors in the status panel. Change 4141708 by Steve.Robb GitHub #3631 : Incorrect default argument in WeakObjectPtrTemplate #jira UE-45490 Change 4146655 by Stefan.Boberg Removed FullGCAssetClasses logic - no longer necessary nor useful Change 4147318 by Ben.Marsh UGS: Compress build badges in a column if it shrinks below the size that they would be visible. Change 4148207 by Ben.Marsh UGS: Added support for showing the latest completed build from a specific list of badges in the status panel. To declare a badge as one that should appear in the status panel rather than the CIS column, add it to the project's UnrealGameSync.ini in the project or [Default] section like so: +ServiceBadges=RoboMerge Change 4148282 by Stefan.Boberg Fixed bug in UCookOnTheFlyServer::GetCookOnTheFlyUnsolicitedFiles - UnsolicitedFiles should be passed by reference not by value Change 4148344 by Stefan.Boberg Fixed minor indentation error (most likely caused by sloppy merge) Change 4148521 by Stefan.Boberg Removed accidentally checked in PRAGMA_DISABLE_OPTIMIZATION from CookOnTheFlyServer.cpp Change 4148639 by Ben.Marsh UGS: Fix tooltips not showing for changes that have description badges. Change 4149373 by Ben.Marsh UGS: Allow adding additional columns to display particular badges by adding entries from the project config file. Example syntax: +Columns=(Name="Desktop",MinWidth=50,DesiredWidth=100,Weight=3,Badges="Editor") +Columns=(Name="Mobile",MinWidth=50,DesiredWidth=100,Weight=3,Badges="IOS,Android") Same form can be used to control how default columns are displayed (though badge settings are ignored). Also allow PerforceMonitor to detect local changes to project config files and update settings automatically. Change 4149399 by Ben.Marsh UGS: Update version to 1.143. Change 4155660 by Steve.Robb PROJECTION and PROJECTION_MEMBER macros which provide the correct behavior when creating projections using functions which are overloaded or use default arguments. Change 4157117 by Ben.Marsh Fix warning due to plugins disabled in .target.cs file. Change 4158011 by Ben.Marsh UBT: Add a check that the UnrealHeaderTool target file exists, rather than throwing an exception when reading it fails. Change 4158646 by Ben.Marsh UGS: Fix exception when login is discovered to have expired during a workspace update. Change 4158678 by Ben.Marsh UGS: Fix an exception on shutdown due to the icon being hidden after it's already been disposed. Change 4158683 by Ben.Marsh UGS: Add an unhandled exception filter which sends the exception data to the backend. Change 4159131 by Ben.Marsh UGS: Reduce the number of characters displayed for build badges based on the available space. Change 4159194 by Graeme.Thornton TBA: Fix incorrect map property conversion code when converting an old property that contains a map with different key/value types Change 4159239 by Steve.Robb Improved readability and compliance with coding standards. Change 4159246 by Ben.Marsh UGS: Allow syncing projects where source code is not available (and various version files don't exist). #jira UE-60985 Change 4159286 by Ben.Marsh UGS: Remove requirement for UE4Editor.target.cs to be visible in the depot in order to open a project. #jira UE-60986 Change 4159302 by Ben.Marsh UGS: Update version to 1.144. Change 4160308 by Ben.Marsh All staging client executables for blueprint projects. #jira UE-60983 Change 4161567 by Steve.Robb GitHub #4816 : UE-60771: Handle escaped double quote in FParse::LineExtended Change 4162641 by Ben.Marsh UGS: Allow customizing the position of custom columns, via the Index=N attribute. Change 4162647 by Ben.Marsh UGS: Update version to 1.145. Change 4165319 by Robert.Manuszewski PR #4812: Fix inconsistent command-line argument handling under Windows (Contributed by adamrehn) Change 4166150 by Ben.Marsh UGS: Include *.inl when looking for code changes. Change 4166551 by Steve.Robb Whitespace fixes caused by a bad merge. Change 4168483 by Ben.Marsh UGS: Add a more useful error if a file to be synced exceeds the max allowed path length. Change 4168490 by Ben.Marsh UGS: Update version to 1.146. Change 4168551 by Ben.Marsh UBT: Move bBuildLargeAddressAwareBinary into an exposed setting. Change 4168560 by Ben.Marsh UBT: Remove static config variable for controlling which configuration of UHT to use. Change 4171296 by Ben.Marsh UGS: Move the check for overlong paths earlier. Change 4171531 by Ben.Marsh UBT: Fix exception if BuildConfiguration.xml contains an unknown category. Change 4183371 by Robert.Manuszewski Fix for a crash in Async Loading Graph's CheckCycles when GC kicks in on the game thread and forces ALT to exit early Change 4184312 by Ben.Marsh UGS: Update version to 1.148 Change 4184480 by Robert.Manuszewski Removing unused async loading stat Change 4186390 by Ben.Marsh UBT: Format XML validation errors in a format that allows double-clicking on the message in Visual Studio. Change 4188644 by Ben.Marsh UBT: Add the MakePathSafeToUseWithCommandLine() function to UBT. Change 4188647 by Ben.Marsh UBT: Fix exception in target receipt when architecture is null. Change 4189617 by Ben.Marsh Change FileSystemReference, FileReference and DirectoryReference objects to use OrdinalIgnoreCase comparisons without creating a separate copy of the string to compare. The filesystem does not use the invariant culture, and it can produce the wrong results in some cases (the ordinal comparison is faster, too). Change 4189740 by Ben.Marsh UAT: Remote code to build UnrealPak when packaging; we use the editor now. Change 4189860 by Ben.Marsh UGS: Make the filter for excluding automated lighting rebuilds more explicit. Change 4190082 by Ben.Marsh Fixes to allow enabling edit and continue for Windows builds. Have experienced quite a few VS crashes when testing it in editor; not yet recommended for general use. - Allow edit and continue for any configuration, not just debug. - Fixed PDB errors compiling files that use a shared PCH with edit and continue enabled. Path to the generated PDB file was using the wrong directory. - Removed code that tracks PDB output files, since they're modified multiple times during a build. - Enable debug information when compiling generated CPP files, since it causes errors if the shared PCH PDB doesn't have the same option. - Disable support for remote execution of steps that modify the PDB, since the same file has to be modified many times. Remote execution causes the PDB files to be corrupted. Unfortunately, this makes E&C builds significantly slower. #jira Change 4192949 by Ben.Marsh UBT: Minor tidy-up (merging UEBuildBinary.Build and UEBuildBinary.SetupOutputFiles) Change 4193218 by Ben.Marsh Fix formatting. Change 4197252 by Mike.Erwin UAT: Fix log output w/ correct count of non-code projects. #jira none Change 4197941 by Ben.Marsh UGS: Add support for DebugGame editors that have an executable with a DebugGame suffix. Change 4197964 by Ben.Marsh UGS: Prevent attempts to automatically reopen projects while a modal dialog is up, or the workspace is syncing. Change 4198144 by Ben.Marsh UGS: Prevent modal dialogs when login expires in P4, and prompt for password when hitting "retry". Change 4198413 by Ben.Marsh UGS: Always show the main window when launched manually, and run with -RestoreState when launched at startup. Also add a couple more places that save the visibility state, since logging off seems like it can terminate the process abrubtly. Change 4198779 by Ben.Marsh UBT: Allow generating manifests to any arbitrary locations with the -Manifest=<Path> argument. Change 4198825 by Ben.Marsh UBT: Move code to enumerate Slate runtime dependencies into the Slate module. Doesn't need to be done inside core UBT. Change 4199341 by Ben.Marsh UGS: Update version to 1.149 Change 4199642 by Chad.Garyet - Deprecate CISController - Add BuildController to replace CIS GET/POST for builds - Add LatestController, GET does what CIS/GET used to do - Change Latest/GET to return the last 25 builds filtered by project, rather than the last 5000 individual Ids - Latest/GET now returns "LatestData" object instead of array of longs - Updated EventMonitor to match all API changes - Fixed bug where IDs were getting reset to initial startup values every update loop Change 4199663 by Chad.Garyet CIS controller still needs to return an array of longs #jira none Change 4199680 by Ben.Marsh UGS: Update version to 1.150 Change 4200457 by Ben.Marsh Merging CIS fix for non-development configurations. Change 4200472 by Mike.Erwin UAT: fix -skipbuildclient param default It was defaulting to skipbuildeditor's value, likely a copy-paste error. #jira none Change 4202595 by Ben.Marsh Fix static analysis warning due to constant comparison against macro. Change 4203250 by Ben.Marsh UGS: Always show the "Sync Precompiled Editor" option, but disable it and show a tooltip explaining why if it is not available. Change 4206191 by Ben.Marsh Exclude editor target files from installed builds, since they leak info about DLLs that have been stripped out. Change 4213011 by Ben.Marsh UBT: Include contents of modified intermediate files in the log, to make it easier to debug hidden dependencies. Change 4213487 by Ben.Marsh UBT: Fix assumption that bPrecompile is equivalent to bBuildAllModules. This is no longer the case; they are now controlled by separate options. Should fix CIS errors building the editor. Change 4213609 by Ben.Marsh Ensure that strings formatted using FMicrosoftPlatformString::GetVarArgs() are always null terminated, whether we use the secure CRT or not. Change 4215971 by Ben.Marsh UBT: Remove action graph visualization code; no longer used. Change 4215996 by Ben.Marsh UBT: Remove unqiue id from all actions in the action graph. This is only used for printing debug info in the case of a (rare) cycle in the action graph, so just look it up when needed. Change 4216022 by Ben.Marsh UBT: Rename Crypto.cs to EncryptionAndSigning.cs to match the name of the class inside it, and move it under the System folder. Change 4216031 by Ben.Marsh UBT: Move all the action executors into their own folder in the project. Change 4216526 by Ben.Marsh Fix CIS warnings. Change 4216544 by Ben.Marsh Replace custom code to ensure FMicrosoftPlatformString::GetVarArgs() null terminates its buffer with Microsoft's standards-compliant implementation. Change 4216633 by Ben.Marsh Add support for UnrealPak plugins. * Project and plugin modules can now specify an array of supported programs in the "WhitelistPrograms" field of their module descriptors, to allow modules to be loaded by programs. * Programs can now load any runtime modules, as long as they are whitelisted. * Programs under the engine directory can now use a shared build environment, so that building with a project file does not cause output binaries to be output to the project directory. * UnrealPak is now always built by default when packaging * Convert UnrealPak to a modular configuration Change 4216736 by Ben.Marsh UnrealPak: Move "ExportDependencies" command into an editor commandlet, since it relies on the UObject system, asset registry, etc... Change 4217447 by Ben.Marsh Back out revision 50 from //UE4/Dev-Core/Engine/Build/InstalledEngineBuild.xml Change 4217451 by Ben.Marsh Back out revision 11 from //UE4/Dev-Core/Engine/Plugins/Developer/VisualStudioSourceCodeAccess/Source/VisualStudioSourceCodeAccess/VisualStudioSourceCodeAccess.Build.cs Change 4217617 by Ben.Marsh Back out changelist 4217451 Change 4222552 by Ben.Marsh Don't use #import <TypeLib> for VS source code accessor when building with Clang; it's not supported. Change 4222630 by Ben.Marsh UBT: Fix spam while generating project files if Clang isn't installed. Change 4223316 by Ben.Marsh UBT: Change the order in which Visual C++ toolchains are enumerated to prefer full releases over preview releases. Change 4223318 by Ben.Marsh UBT: Add a build setting which allows creating a dedicated PCH for every file that's excluded from the unity working set (disabled by default). Improves iteration times when working on individual cpp files, but slows down iterating on header changes (and can take a lot of disk space for large changes). Dedicated PCH contains all includes scraped from the top of each cpp file, until a non-#include directive is encountered. Change 4223401 by Ben.Marsh UBT: Add an option to automatically enable edit and continue for files in the adaptive non-unity working set. E&C doesn't seem very useful for UE4 projects right now; compile time is comparable to regular build times, but it can take several minutes to apply code changes for large projects. Change 4223899 by Ben.Marsh UBT: Fix loading XML config files on Mono; Type.GetField(Name) does not seem to return values unless binding flags are specified. Change 4224637 by Ben.Marsh Add a "SupportedPrograms" field to plugin descriptors, which allows plugins to declare which plugins they support independently of individual modules. Programs now respect the "bEnabledByDefault" setting in plugins. Plugins that are compatible with a program now need to list that program in the SupportedPrograms list, and whitelist any modules that should load for that program. Change 4224710 by Ben.Marsh UBT: Don't add import libraries as final build products unless the target is being precompiled. Prevents the need for building them for leaf nodes in the action graph. Change 4224715 by Ben.Marsh UBT: Remove hack to allow Stats2.cpp to not follow IWYU convention. Change 4224726 by Ben.Marsh Remove commented out line. Change 4224903 by Ben.Marsh Fix non-unity compile error in Stats2.h. Change 4225051 by Ben.Marsh Back out changelist 4224710; causing CIS errors due to receipts not matching. Change 4225134 by Ben.Marsh Fixing non-unity errors. Change 4225203 by Ben.Marsh Another non-unity fix. Change 4225249 by Ben.Marsh Fix Linux dependencies being copied for the Windows editor; they can be added as requirements for the Linux target platform on Windows instead, so it respects the user's chosen platforms. #jira UE-62001 Change 4225512 by Ben.Marsh BuildGraph: Allow setting the target to build when using the <CsCompile> task. Change 4228815 by Ben.Marsh UBT: Always add the generated code directory to the list of include paths when generating project files. It may only be created after UHT has been run. Change 4228944 by Ben.Marsh UBT: Remove legacy CppCompileEnvironment and LinkEnvironment wrappers from TargetRules that were deprecated in 4.19. Change 4229028 by Ben.Marsh UBT: Fix editor targets with unique build environment having the wrong executable path in generated project files. Move move logic to configure target rules post-construction by the rules assembly to ensure it's valid. Change 4229065 by Ben.Marsh UBT: Move another target setting into the rules assembly. Change 4229105 by Ben.Marsh Fix BPT exception when generating project files. Change 4229311 by Ben.Marsh UBT: Store the module rules file location on the ModuleRules instance, as well as the plugin that it was created from. Also expose the plugin directory as a property on the ModuleRules instance. Change 4229421 by Ben.Marsh UBT: Consolidate functionality for UHT module setup in ExternalExecution.cs. Change 4229817 by Ben.Marsh UBT: Modules must now explicitly specify the path to the header used to generate a PCH if one is desired, rather than the header being determined automatically by attempting to parse the source code. Now that PCHs are force-included anyway, this removes a lot of dependencies inside UBT. Change 4229824 by Ben.Marsh UBT: Remove unused lists inside UEBuildModuleCPP.SourceFilesClass. Change 4229841 by Ben.Marsh UBT: Remove some legacy code from auto-detecting PCHs. Change 4230521 by Ben.Marsh UBT: Add utility functions to the log class to allow formatting errors and warnings in Visual Studio output format (eg. File(Line): warning: Message) Change 4230871 by Ben.Marsh UAT: Remove StreamUtilis utility class; there is a simpler way to implement the one place it's used. Change 4230882 by Ben.Marsh UAT: Add StreamUtils back into UAT, seems like it's still used there. Change 4230896 by Ben.Marsh UBT: Remove some redundant parameters from UEBuildModule/UEBuildModuleCPP/UEBuildModuleExternal constructors. Change 4231014 by Ben.Marsh WorkspaceTool: Include a dump of raw bytes when garbage is read from the P4 process, for diagnostic purposes. Change 4231032 by Ben.Marsh Fix CIS. Change 4231096 by Ben.Marsh Bump the FlatCPPIncludeDependencyCache version, to prevent errors trying to load old files. Change 4231446 by Ben.Marsh UBT: Added support for expanding UE-specific variables in include paths and library paths: $(EngineDir), $(ProjectDir), $(PluginDir), $(ModuleDir). Change 4231460 by Ben.Marsh Modules may now explicitly specify rpaths on Linux via the PublicRuntimeLibraryPaths and PrivateRuntimeLibraryPaths properties. Change 4233909 by Robert.Manuszewski PR #4779: Reason fails as the supplied variable is incorrect (Contributed by projectgheist) Change 4233910 by Ben.Marsh Enable PCHs on IOS. Reduces build time by ~25%. Change 4234176 by Ben.Marsh UBT: Add better messaging for modules that need to have a private PCH set. Now detects the likely PCH using the same method as legacy code and includes it as a suggestion. Change 4234193 by Ben.Marsh Add the Delete command to Perforce wrapper in DotNETUtilities. Change 4234688 by Ben.Marsh UBT: Simplify handling of installed/precompiled builds. Settings for whether a folder is installed/read-only or not is now stored on the RulesAssembly instance, allowing multiple things to be configured separately and stacked together (eg. engine/enterprise/project). RulesAssembly.IsReadOnly() allows determining if a flie can be modified or not and replaces many previous IsXXXInstalledCalls(), and traverses the chain of assemblies. Change 4234711 by Ben.Marsh UBT: Runtime dependencies can now be copied to output directories as part of the build. When adding a runtime dependency, an optional source location can be specified to copy from. Both the source and target paths can use variables can be used as part of the path, eg. $(OutputDir), $(ModuleDir), $(PluginDir). Example usage (from a .build.cs file): RuntimeDependencies.Add("$(OutputDir)/Foo.dll", "$(PluginDir)/Source/ThirdParty/Foo.dll", StagedFileType.NonUFS); Change 4234872 by Ben.Marsh Expose a flag for whether the engine is installed, to fix issues generating project files. Change 4234929 by Ben.Marsh Fix null reference generating receipts when UBT makefiles are active. Change 4235883 by Chad.Garyet Merging 4231245 to core Giving Coordinator its own sln. This should fix what 4158155 was supposed to. #jira UE-61955 Change 4236075 by Ben.Marsh CIS fix Change 4237066 by Robert.Manuszewski Fix for a potential crash when terminating the engine while it's being initialized #jira UE-60545 Change 4237078 by Robert.Manuszewski The engine will no longer be resetting all linkers causing massive load times when renaming the world package when entering Play In Editor Change 4237116 by Ben.Marsh Rewrite some Windows utility functions to support paths longer than MAX_PATH. Change 4237158 by Ben.Marsh Add const TCHAR* overloads of FString::RemoveFromStart() and FString::RemoveFromEnd(). Change 4237159 by Ben.Marsh Fix FWindowsPlatformFile::GetFilenameOnDisk() support for paths longer than MAX_PATH, and simplify some of the other long path functions to avoid copying string buffers. Change 4239050 by Ben.Marsh Missing file Change 4239318 by Ben.Marsh Linux CIS fix. Change 4239685 by Ben.Marsh Static analysis CIS fix. Change 4240800 by Ben.Marsh WorkspaceTool: Include the full command line in the log for any P4 commands. Change 4240903 by Ben.Marsh PR #4909: Update copyright notices to 2018 (Contributed by projectgheist) Change 4241025 by Ben.Marsh UBT: Exclude mobile pipeline caches from generated project files. Causes huge slowdown when using 'Find in Files' through the IDE. Change 4241770 by Ben.Marsh UBT: Include action number in parallel executor output. #jira UE-62032 Change 4243469 by Ben.Marsh TBA: Merge FAnnotatedStructuredArchiveFormatter with FStructuredArchiveFormatter. Any functions that are only implemented for text archives now have a _TextOnly suffix, and are exposed through the FStructuredArchive interface. Change 4245723 by Robert.Manuszewski Fixing another creash when terminating the engine while initializing. #jira UE-60545 Change 4245862 by Steve.Robb VectorLoadFloat2(Ptr) added, which loads { Ptr[0], Ptr[1], Ptr[0], Ptr[1] } into a VectorRegister. Change 4246412 by Robert.Manuszewski The warning 'Calling StaticLoadObject during PostLoad may result in hitches during streaming' will now also report the object which had the PostLoad called on it when StaticLoadObject call happened. Change 4246612 by Ben.Marsh UBT: Fix spelling of "Intellisense". Change 4249454 by Robert.Manuszewski Added extra checks to catch scenarios where the EDL Precache Buffer is flushed before a package header is fully read Change 4249513 by Robert.Manuszewski Made sure the Async Loading Thread doesn't continue running after creating new async packages when garbage collector wants to run on the game thread Change 4255207 by Ben.Marsh UGS: Add additional logging whenever a P4 command fails, and when the user is logged out. Change 4255288 by Ben.Marsh PR #4921: Honor ModuleRules' bEnableExceptions flag when creating precompiled h. (Contributed by surakin) Change 4256422 by Ben.Marsh UBT: Add an error if a module referenced by a plugin descriptor doesn't exist. Change 4257385 by Robert.Manuszewski Creating new objects from within ForEachObjectWithOuter will now result in a fatal error as it's unsafe to change internal UObject hash tables when iterating over them. Change 4257454 by Robert.Manuszewski Added the option to filter clusters listed with gc.ListClusters by objects within them. Usage: gc.ListClusters Hierachy With=ObjectName1,ObjectName2... Change 4257526 by Robert.Manuszewski It's now possible to filter clusters that get logged with verbose cluster logging enabled (UE_GCCLUSTER_VERBOSE_LOGGING=1) by objects within them by specifying -DumpClustersWithObjects=ObjectName1,ObjectName2 in the command line Change 4257822 by Ben.Marsh Fixes for PlatformShowcase compile errors. Change 4258771 by Ben.Marsh UBT: Fix project files not being generated for foreign projects when creating .stub files. #jira UE-62462 Change 4258790 by Ben.Marsh UBT: Clean up the logic around generating project files before creating a stub IPA, so that it fails loudly if project files do not exist, and can accept target names not matching project names. Change 4259276 by Ben.Marsh UBT: Make it an error if a framework doesn't exist, rather than failing silently. Also remove some remote toolchain stuff that's no longer necessary. Change 4259280 by Ben.Marsh UBT: Fix embedded framework zips not being uploaded for plugins. #jira UE-62485 Change 4260236 by Ben.Marsh UBT: Fix path to generated engine project file. Change 4260334 by Ben.Marsh UGS: Fix custom build steps dialog inadvertantly modifying config file settings in-place. Change 4260361 by Ben.Marsh UGS: Allow for p4 login commands to fail, even though the user is logged in (due to a bad connection, etc...) Change 4260559 by Ben.Marsh UGS: Update version. Change 4261160 by Robert.Manuszewski MediaPlaylist will now be added to root set if the owning MediaPlayer is in the disregard for GC set (fixes GC assumption violation crash) #jira UE-62495 Change 4261421 by Ben.Marsh Force-sync files for building documentation, to fix issues with files not being updated. #jira UE-62413 Change 4261425 by Ben.Marsh UBT: Remove some leftover functions for handling the remote toolchain. Change 4261530 by Ben.Marsh UBT: Speculative fix (and better error reporting) for IOS mobile provision not being found in CIS. Change 4261611 by Ben.Marsh UBT: Downgrade warning to a log message, since it appears when generating project files. Change 4261710 by Ben.Marsh Remove assert that GLogConsole is set; it won't be for command line utilities that don't depend on ApplicationCore. #jira UE-62545 Change 4261831 by Ben.Marsh Fix compile errors due to missing include path when hot-reloading a module from the editor. There are not necessarily source files to compile when -modulewithsuffix is specified on the command line, which was results in GeneratedCodeWildcard not being set. #jira UE-62463, UE-62384 Change 4262723 by Ben.Marsh Whitelist plugins that need to be loaded by UFE. #jira UE-62564 Change 4265444 by Ben.Marsh Fix incorrect executable name for DebugGame configurations in Xcode. #jira UE-62574 Change 4265892 by Ben.Marsh Fix incremental compile failures due to dependency checking for unity files. CachedIncludePaths was not correctly being set on file items, so dependencies were being ignored. #jira UE-62575, UE-62603, UE-62597 Change 4266019 by Josh.Adams - Fixed the CopyAction for runtime dependencies that need to be copied to different location, on non-XGE Change 4266264 by Ben.Marsh Remove override for the __IPHONE_OS_VERSION_MIN_REQUIRED macro on TVOS. This macro is already defined by system headers (in <AvailabilityInternal.h>). Now that we support PCHs on IOS and TVOS, manually defining this macro results in it being defined three times (once for the PCH, once by AvailabilityInternal.h, and once by the force-included list of definitions for the source file being built). The errors for redefining the macro in AvailabilityInternal.h are suppressed due to it being a system header, but the error for redefining it for the source file being compiled are not. #jira UE-62578 Change 4266273 by Ben.Marsh Fixes incremental build failure when compile arguments for PCH have changed on IOS/TVOS. Compile action needs to have a dependency on PCH build action. Change 4266614 by Graeme.Thornton Fix crash when cooking nativized blueprints due to removal of child cooker system. Change 4266763 by Ben.Marsh Always build UnrealPak when building client targets. The ProjectParams.Pak option is not reliable, because it can be forced on later by the target platform. #jira UE-62584 Change 4267985 by Robert.Manuszewski When iterating with ForEachObjectWithouter, don't lock the entire has table but only the hash bucket that is currently being iterated #jira UE-62600 Change 4268558 by Robert.Manuszewski PurgeLegacyBlueprints will no longer be called from within ForEachObjectWithOuter is it renames objects that reside in hash tables that are being iterated over which may lead to undefined behavior. #jira UE-62600 Change 4269011 by Chad.Garyet - Fixing Wildcard match issue, the change to ugsapi sends projects as //Depot/Stream instead of //Depot/Stream/ Wildcard match was only substringing to 3 chars. - Checking in the change a while back that increases the number of queried jobs up to 432 based on some maths from Bob about how many builds we want to grab Published to ugsapi server 8/8/17 #jira none Change 4270788 by Ben.Marsh Fix IOS provisioning data being using when remote compiling on TVOS. #jira UE-62705 Change 4271916 by Ben.Marsh Tag the XGEControlWorker executable as a build product after compiling SCW, to make sure it's included in the UGS zip file. Change 4271934 by Ben.Marsh Upload all static libraries in plugin folders as part of remote builds. #jira UE-62694 Change 4273368 by Ben.Marsh Fix Slate dependencies not being enumerated, and rules assembly not being rebuilt when building remotely. #jira UE-62705 Change 4274049 by Ben.Marsh Always parse the team UUID out of the mobile provision when doing a remote compile. The provision installed on the remote Mac (and selected for signing) may be different. #jira UE-62751 Change 4274823 by Ben.Marsh Add the -VersionCookedContent argument to disable the -unversioned parameter on the cooker command line. Change 4275838 by Ben.Marsh Fix BuildVersion string not being passed through from <SetVersion> task. Also add a -BuildVersion command line argument to UBT to override it for a particular build. Change 4275913 by Ben.Marsh Add a dummy exported symbol to the XGEController module, to fix build errors due to missing .lib file when it's built with WITH_XGE_CONTROLLER = 0. Change 4284161 by Ben.Marsh Allow mirroring Oodle files to remote Mac. Change 4074774 by Steve.Robb Vast simplification of TFunction, making it smaller in footprint, easier to follow and extend, and more correct. TUniqueFunction added, which is a move-only TFunction which can hold move-only functors. Fix for UWidgetBlueprint::ForEachSourceWidget() which should never have compiled but did. FFunctionGraphTask and TFuture<> updated to use TUniqueFunction to make them more general. TArray::HeapPop() made to work with move-only types. Change 4082591 by Ben.Marsh Move the Log class from UBT to DotNetUtilities. Change 4083236 by Ben.Marsh Add a Log.WriteException() method to dump an exception message to the console (and write the exception trace to the log) Change 4084107 by Ben.Marsh UAT: Remove the unused -SkipHeader argument to UE4Build. Change 4089771 by Steve.Robb GitHub #4743 : modified VirtualAlloc function flag https://blogs.msdn.microsoft.com/oldnewthing/20151008-00/?p=91411 Change 4091456 by Steve.Robb Unification of all platforms' FMath::CountTrailingZeros() and FMath::CountLeadingZeros() for both 32-bit and 64-bit. Change 4156437 by Ben.Marsh Lots and lots of fixes compiling for Clang on Windows. Editor now compiles cleanly without warnings, but crashes on startup due to error in intrinsics test. Disabling that runs further, but crashes accessing freed memory. Switching to the ANSI allocator runs further, but crashes in Slate after the splash screen and before the editor window opens. // TODO! * Switching between Clang/ICL/VS2015/VS2017 is now supported through the same mechanism as switching Visual Studio versions, without requiring any source level changes. To use Clang, set WindowsPlatform.Compiler = WindowsCompiler.Clang from a .target.cs file, or set <WindowsPlatform><Compiler>Clang</Compiler></WindowsPlatform> from BuildConfiguration.xml. To pick a specific toolchain version, set WindowsPlatform.CompilerVersion. * Clang is now supported through AutoSDKs; will be added to CIS. * The Samples/Sandbox/Clang project forces Clang to be used from its target.cs file, and allows easily building all editor modules and plugins with Clang on Windows. * UnrealMathSSE intrinsics have been re-enabled for Clang due to missing functions from the UnrealMathFPU implementation, but causes failure in tests at startup. * SSE4_CRC32() is disabled in D3D12Pipelinestate.cpp, since intrinsics are only allowed if enabled for the whole target (rather than being used in specific functions due to runtime checks) Change 4157389 by Ben.Marsh Few more fixes for compiling the editor with Clang. Change 4183911 by Ben.Marsh Fixes to support incremental linking on Windows. Does not seem to have any net benefit right now; may improve once minimal rebuild is enabled. * Incremental linking no longer forces PDB files to be enabled for source files. * Actions can specify specific files to be deleted before each build. Code to forcibly delete PDB files has been moved to the MSVC toolchain. * Unused libraries produced by the cross-referenced link are no longer added as build products, since (a) deleting them breaks dependency checking for incremental linking and causes a full link, and (b) not deleting them breaks UBT dependency checking and causes actions to be run over and over again. * Icon update is disabled for Windows when incremental linking is enabled. * Removed rarely-used setting to always delete produced items before each build. Change 4184311 by Ben.Marsh UGS: Added a dialog which shows all the required platform SDKs for a branch, linked from the status panel in UGS. The llist is configured via the UGS config file submitted to Engine/Programs/UnrealGameSync/UnrealGameSync.ini (and may be overridden by the project config file if necessary): [Default] ; Set this to a network share which contains the SDK installers for your site SdkInstallerDir= ; All the required SDKs for the current version of the engine +SdkInfo=(Category="Android", Description="NDK r21", Browse="$(SdkInstallerDir)\\Android") +SdkInfo=(Category="Windows", Description="Visual Studio 2017") +SdkInfo=(Category="Windows", Description="Visual C++ Toolchain 14.13.26128") +SdkInfo=(Category="Windows", Description="Windows SDK 10.0.16299.0") Similar entries for console platforms are added in console subdirectories. Each entry may contain an Install="Foo.exe" and/or Browse="C:\Foo" style attribute, specifying the path to an installer to run or directory to open in explorer respectively. The SdkInstallerDir setting is used as a base directory for the default installers, seen above for Android. Licensees may override this with a network path specific to the site that UGS is being deployed to (either in this file, in a project specific config file, or in a Engine/Programs/UnrealGameSync/NotForLicensees/UnrealGameSync.ini file). Change 4200452 by Ben.Marsh UBT: Change DebugGame configurations to output a separate executable rather than requiring a -Debug argument at runtime. Previous behavior was a common source of errors. Engine modules are still shared between Development and DebugGame, but the launch module sets a flag in Core on startup indicating the game configuration. Change 4206189 by Ben.Marsh UBT: Simplify logic for precompiling binaries. * Target no longer has separate list of "precompile only" binaries or modules. New -AllModules option allows adding every module to a target, which can be used with -Precompile and -NoLink to precompile object files for monolithic builds. * Precompiled file lists have been removed from target receipts. * The manifest now includes all generated headers and precompiled files when run with the -Precompile option. * Separate -DependencyList=Foo.txt has been added to write a list of all dependencies required to use precompiled binaries. This file list can be read using the <Tag> task in buildgraph. Change 4215466 by Ben.Marsh UBT: Remove indirect calls to determine extensions for object files and precompiled headers. The toolchain knows the correct convention for the platform. Change 4215975 by Ben.Marsh UBT: Remove telemetry code. This has never proved useful for analyzing performance due to the number of incidental factors that affect build times (eg. number of files being compiled). Change 4220154 by Ben.Marsh Move text-only implementations of FOutputDeviceError back into Core, so we can build command-line applications that don't depend on ApplicationCore. Change 4224708 by Ben.Marsh Add a bCompileAgainstApplicationCore setting to the target rules, which allows compiling out references to the ApplicationCore module (which should only be necessary for applications with a GUI). Removed ApplicationCore from several engine tools and utilities. Change 4224958 by Ben.Marsh Remove CoreMinimal.h includes from Core. Change 4229059 by Ben.Marsh UBT: Remove the UEBuildPlatform.ShouldNotBuildEditor() hook for target platforms. We shouldn't be modifying a target's build environment to disable the editor; it is invalid to build the editor for these target platforms at all, and this is already enforced by the GetSupportedPlatforms() function. Change 4230508 by Ben.Marsh Fixup precompiled header setting for samples and games. Change 4231457 by Ben.Marsh Fix exceptions in log messages having trailing newlines. Change 4232406 by Ben.Marsh UBT: Always force include a PCH for generated code if there's one set; the code may depend on it to compile. Change 4234177 by Ben.Marsh Set up private PCH files everywhere that previously used them. Change 4235973 by Ben.Marsh Change FPlatformMisc::GetEnvironmentVariable() to return an FString() rather than requiring a fixed size buffer to be passed in. Removes references to MAX_PATH. Change 4238842 by Ben.Marsh Add support for paths longer than MAX_PATH in the editor. Requires Windows 10 version 1607, and the functionality to be enabled via a registry key or group policy (see https://docs.microsoft.com/en-us/windows/desktop/FileIO/naming-a-file). Only a subset of Win32 functions support long paths (executables can only be started from paths shorter than MAX_PATH, for example). * Added a FPlatformMisc::GetMaxPathLength() function to return the maximum length of a path on the current system. On Windows, this returns a different value for systems with long paths enabled to those without. * The MAX_PATH define is no longer set by non-Windows platforms. Instead, there is a MAC_MAX_PATH, UNIX_MAX_PATH, etc... for any platform-specific code that still relies on the previous macro. * The MAX_UNREAL_FILENAME_LENGTH macro has been renamed to MAX_UNREAL_FILENAME_LENGTH_DEPRECATED * The PLATFORM_MAX_FILEPATH_LENGTH macro has been renamed to PLATFORM_MAX_FILEPATH_LENGTH_DEPRECATED. * Removed custom resource files for programs, since they are just copies of the base UE4 one (which is used by default anyway). The base UE4 manifest declares support for long paths. * Fix 512 character maximum length on editor commands. 260 character limit remains in place for cooking at the moment (see ContentBrowserUtils.h), until C# staging code supports long paths. Change 4255042 by Ben.Marsh UBT: Remote compilation now uploads the entire workspace to the remote Mac and executes a separate remote instance of UBT rather than synchronizing individual actions. This makes the remote compile codepath much simpler, and removes a lot of special cases that exist to support it previously. The list of files to be transferred to the remote are listed as rsync filter rules in Engine/Build/Rsync/RsyncEngine.txt and RsyncProject.txt, which are applied to the root engine directory and project directory respectively. Projects that need to customize which files are uploaded can add their own <ProjectDir>/Build/Rsync/RsyncProject.txt file, which will be included in the filter before the default version. Change 4260567 by Ben.Marsh UAT: Rename CommandUtils.Log to CommandUtils.LogInformation, to avoid conflicts with the underlying Tools.DotNETCommon.Log class. #rb none [CL 4285673 by Ben Marsh in Main branch]
2018-08-14 18:32:34 -04:00
LogInformation("Client logging process started...{0}", ClientLogFile);
ClientProcessLog = File.Open(ClientLogFile, FileMode.Open, FileAccess.Read, FileShare.ReadWrite);
ClientLogReader = new StreamReader(ClientProcessLog);
}
if (ClientLogReader == null)
{
throw new AutomationException("Client exited without creating a log file.");
}
bool bKeepReading = true;
bool WelcomedCorrectly = false;
bool bClientExited = false;
DateTime ExitTime = DateTime.UtcNow;
while (bKeepReading)
{
if (!bClientExited && ClientProcess.HasExited)
{
ExitTime = DateTime.UtcNow;
bClientExited = true;
}
string ClientOutput = ClientLogReader.ReadToEnd();
if (!String.IsNullOrEmpty(ClientOutput))
{
if (bClientExited)
{
ExitTime = DateTime.UtcNow; // as long as it is spewing, we reset the timer
}
AllClientOutput += ClientOutput;
Console.Write(ClientOutput);
if (AllClientOutput.LastIndexOf(LookFor) > AllClientOutput.IndexOf(LookFor))
{
WelcomedCorrectly = true;
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 4285612) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3836829 by Ben.Marsh UBT: Fix ability to precompile plugins from installed engine builds. Change 3839519 by Ben.Marsh UBT: Simplify configuring bPrecompile and bUsePrecompile settings for modules. Each rules assembly can now be configured as installed, which defaults the module rules it creates to use precompiled data. Change 4042043 by Steve.Robb GitHub #4705 : Added weak lambda's for delegates and multicast delegates. Change 4042056 by Robert.Manuszewski Optimized Mark Phase of GC by up to 10ms by making it run in parallel and removing a huge array presize which we didn't need. Change 4042104 by Robert.Manuszewski Set the minimum GC cluster size to 5 so that GC doesn't have to process micro clusters which are more expensive than processing individual objects + Exposed the minimum cluster size to ini and project settings as gc.MinGCClusterSize + Added the ability to sort clusters by name/object count/mutable object count/referenced clusters count when dumping them with gc.ListClusters command Change 4042377 by Robert.Manuszewski Reworked how GC and other threads (ALT specifically) interact - GC will now notify the ALT it wants to run and ALT will immediately try to finish its current work to allow that. Also the entire ALT tick is now protected against GC running at the same time to improve ALT stability. + added gc.ForceCollectGarbageEveryFrame console variable that triggers a forced GC every frame Change 4042427 by Robert.Manuszewski Changed FGCCSyncObject to use events when waiting for GC to finish so that it doesn't spin on non-game threads when GC is running Change 4042482 by Robert.Manuszewski Unhashing unreachable objects (ConditionalBeginDestroy) will now also be done incrementally, just like the purge phase of Garbage Collection Change 4042635 by Robert.Manuszewski Fix for a potential assert when incremental purge garbage is pending and something forces a full purge Change 4044092 by Steve.Robb Fix for forward declared CoreUObject weakobject types in delegates when building in Clang. Change 4044102 by Robert.Manuszewski Fix for a possible hang when worker threads are preventing GC from running and something is later trying to FlushAsyncLoading with the Async Loading Thread enabled Change 4044113 by Steve.Robb Another Clang fix. Change 4044160 by Robert.Manuszewski Disregard For GC pool will now be enabled by default in cooked builds Change 4044287 by Steve.Robb Typo fix. Change 4047723 by Graeme.Thornton TBA: Fixes for import/export name cache and object resolving Change 4048015 by Graeme.Thornton TBA: Weak/Soft/Lazy pointer serialization changes * Remove FWeakObjectPtr::Serialize, move it's logic into, and replace usages of with calls to, FArchiveUObject::SerializeWeakObjectPtr(). Ensures that something is always sent to the archive so that structured archives can be kept happy in the future. * Added Weak/Soft/Lazy pointer handling to the structured archive slot interface and all the formatters. Binary formatters just forward the call onto their inner and text archives store as a string path reference. * FArchiveUObjectFromStructuredArchive caches all these pointer types and stores indices in the binary block, same as with a UObject*. All pointers are then forwarded to the underlying formatter in one go on finalization. Change 4048021 by Steve.Robb Fix for binding an unbound TFunction to another TFunction with a different signature. Also all null pointers now count as unbindings, not just nullptr. TIsMemberPointer added. TIsATFunction and TIsATFunctionRef renamed to remove the 'A's. Change 4048544 by Robert.Manuszewski Fixing ConditionalBeginDestroy profiling after changes to incremental CBD. Change 4051028 by Graeme.Thornton TBA: ArchiveFromStructuredArchive adapter uses Inner to determine if it is outputting to text, and sets it's own ArIsTextFormat to false Change 4051056 by Graeme.Thornton TBA: High level tagged property / UObject base class text serialization - UObject serialize converted to structured archive - Properties written to text individually with text tags, and then binary adapted values - Only saves, doesn't load Change 4051111 by Graeme.Thornton TBA: Temporarily disable loading of text assets until tagged property serialization path is fixed up Change 4051154 by Graeme.Thornton TBA: Convert a few uobject serializers to structured archive format for example purposes Change 4051181 by Graeme.Thornton TBA: Added default structured archive implementation of SerializeItem to UProperty, which just calls the FArchive version on an FArchiveUObjectFromStructuredArchive adapter. Implemented structured archive SerializeItem for UArrayProperty Change 4051197 by Graeme.Thornton TBA: ObjectProperty text serialization Change 4051216 by Graeme.Thornton Restored a modified FWeakObjectPtr::Serialize function to keep backwards compatibility in code I don't have access to. Change 4051261 by Graeme.Thornton TBA: Convert UMetaData to structured archive Change 4051374 by Steve.Robb Incorrect assert removed. Change 4051562 by Robert.Manuszewski Adding stats for the new GC internal functions Change 4051614 by Graeme.Thornton TBA: Removed UProperty::SerializeItem(FArchive, ...) and replaced with UProperty::SerializeItem(FStructuredArchive::FSlot, ...). Fixed up most of them to work properly and added adapters in for any that were non-trivial. Change 4052512 by Graeme.Thornton TBA: Temporary workaround for softobjectptr and lazyobjectptr uproperties not serialization anything when they know the archive is a reference collector. They should always be serializing their pointers and letting the underlying archive itself ignore them. Change 4053917 by Robert.Manuszewski Clustered objects from clusters that are no longer reachable will now be marked as unreachable immediately when gathering unreachable objects Change 4053919 by Robert.Manuszewski Added the ability to disable incremental BeginDestroy in ini/project settings Change 4055518 by Daniel.Lamb Fixup for deterministic audio generation issue. Submitted on behalf of Rich.Whitehouse #jira nojira #test prefilght automated test. Change 4056854 by Graeme.Thornton TBA: Added a test asset to EngineTest which contains all the different property types and test cases. Change 4056858 by Graeme.Thornton TBA: Updated USetProperty to proper structured archive usage Change 4056872 by Graeme.Thornton TBA: Add map property field to test object Change 4056873 by Graeme.Thornton TBA: Convert UMapProperty to full structured archive Change 4056994 by Graeme.Thornton TBA: Converted FText over to structured archive. Implemented saving, but not loading. Change 4059728 by Ben.Marsh UBT: Add support for using adaptive non-unity builds when the engine and project are in separate repositories. Change 4059805 by Graeme.Thornton Fixed typo in text serialization. Fixes CIS automation test errors Change 4060007 by Graeme.Thornton TBA: FArchiveFromStructuredArchive will now access it's host slot lazily, i.e. only when a value is actually written to the archive. Change 4060092 by Stefan.Boberg Added optimized Windows console window output path to GenericConsoleOutput since this slowed down cooking considerably (2 minutes spent in wprintf alone for one large dataset) When stdout is attached to a console we use the WriteConsoleW function instead of wprintf since the latter is very slow especially in unbuffered mode which the engine currently configures for stdout (see setvbuf call in LaunchEngineLoop.cpp). At some point we should reconsider this buffering policy since it's likely to slow down other platforms as well but I wanted to do a safe change for now as I don't yet fully understand why the setvbuf call is there in the first place. Change 4060108 by Stefan.Boberg Introduced some additional target platform utilities to help with asset cook optimizations * We now assign each ITargetPlatform a zero-based ordinal value * Introduced FTargetPlatform and FTargetPlatformSet types to help store platform references and platform sets efficiently. These are not currently used in the engine but are designed to replace the existing ITargetPlatform/string/FName representations in the cooking data structures. Change 4060143 by Graeme.Thornton Undo //UE4/Dev-Core/Engine/Source/Runtime/... changelist 4060007 Needs some other changes that I haven't checked in yet... Change 4062432 by Ben.Marsh Fix error message when enumerating P4 changes. Change 4062648 by Ben.Marsh Add missing p4 integration action. Change 4063620 by Graeme.Thornton Integrated a fix from UDN where the engine would crash when trying to load a very small encrypted file (<16bytes) from a pak file, where the read address wasn't already aligned to the AES block size. (https://udn.unrealengine.com/questions/431989/crash-while-reading-a-very-small-file-in-encrypted.html) Change 4066963 by Robert.Manuszewski Fixing GC cluster verification code reporting false positives when a cluster is referencing another cluster through 'mutable' objects list. Change 4067133 by Robert.Manuszewski Changed log verbosity when reporting individual cases of GC cluster assumption violations as they are followed by an asser anyway and this way we get the chance to see all issues before we assert at the end of these checks. Change 4067443 by Steve.Robb FString can now be constructed from any char pointer type and length. Change 4068156 by Steve.Robb Fix necessary because of FString constructor change in CL# 4067443. Change 4070258 by Graeme.Thornton Fixes for VSCode Change 4070372 by Graeme.Thornton TBA: Script struct serialization to structured archives Change 4071913 by Ben.Marsh Move bulk of the code for UnrealPak into an engine developer module, so it can be used in the editor. Change 4071914 by Ben.Marsh Missing files. Change 4071937 by Ben.Marsh Missing header. Change 4072015 by Ben.Marsh Fixes for compiling PakFileUtilities as part of the editor. Change 4072826 by Steve.Robb TBitArray::Reserve() added. TBitArray::Add() overloaded to allow adding multiple bits. TSparseArray::Reserve() optimized to call the overloaded Add(). Change 4073271 by Daniel.Lamb Fixed add patch tier in project launcher passing the wrong commandline option to UAT. #test none Change 4074708 by James.Hopkin #core Removed redundant Casts Change 4074763 by Steve.Robb Fix for TSparseArray::Reserve() size. Change 4076063 by Ben.Marsh Add an "UnrealPak" commandlet with the same functionality as the standalone UnrealPak program. Invoke by running the editor with -run=UnrealPak and the standard UnrealPak commandline options. Change 4077064 by Robert.Manuszewski Fixing compile error in PakFileUtilities Change 4077144 by Graeme.Thornton TBA: TextAssetCommandlet improvements * Collect lists of broken assets during roundtrip tests and print a summary of packages that failed each phase at the end * After resaving as text, load the file back as a plain JSON hierarchy to ensure the output was valid Change 4077412 by Ben.Marsh Set the correct exit code for UnrealPak. Should return 0 on success, not 1. Change 4077760 by Graeme.Thornton TBA: Loading fixed for tagged property serialization Includes conversion of all UProperty::ConvertFromType() and SerializeFromMismatchedTag() functions to use structured archives Lazy initialization of FArchiveFromStructruredArchive when loading, to support the possibility of an adapter being create around an object property serialize call to its inner UStruct, which then decides not to do anything and return false. Stops the ArchiveFromStructuredArchive from consuming the slot and getting upset later on when we try to serialize normal tagged properties from it. Disabled lazy bulk data loading from text assets. Requires a bigger change to make it work. Added some debug checks to json input formatter which track the current value stack size when a new object is pushed onto the stack, and makes sure that the stack has returned to the same size when the object is popped. Catches cases where we unpack an array/stream to the value stack but then don't consume all the items. Change 4078800 by Ben.Marsh Change UAT to using the editor's UnrealPak commandlet rather than invoking the standalone UnrealPak executable. To improve performance when building several PAK files, also add a new -batch=<file> command which reads commands to execute in parallel from a text file. Change 4079745 by Graeme.Thornton TBA: Migrated a couple of UObject Serialize functions to FStructuredArchive (SoundCue / MaterialExpressions / Editor strip flags) Change 4079847 by Graeme.Thornton TBA: Add 'FindMismatchedSerializers' mode to text asset commandlet, which dumps out a list of all UClasses which don't have the CLASS_MatchedSerializers flag, meaning we can't guarantee the have Serialize functions for FArchive AND FStructuredArchive, therefore we can't use the new structured archive based serialize path. Should only ever be native instrinsic classes as UHT takes care of all other cases. Change 4079925 by Ben.Marsh Fix incorrect assignment when deriving name for chunked pak file. Change 4080214 by Ben.Marsh Move the ThreadPoolWorkQueue class into DotNETUtilities so it can be used by other projects. Change 4082394 by Graeme.Thornton CIS fix for variable shadowing warning Change 4082583 by Ben.Marsh Add a IBinarySerializable interface for types that support reading from a BinaryReader and writing to a BinaryWriter. Implementing IBinarySerializable implies a constructor taking a BinaryReader argument is available for deserializing. Change 4082652 by Ben.Marsh Fix FileReference.Directory not returning a directory with a trailing backslash for files in the root directory. Change 4082755 by Graeme.Thornton Fixed an erroneous usage of TUniquePtr<uint8>as a pointer to a uint8 array when creating pak files. Caused a crash when compression was enabled, and has probably surfaced because pak generation is now done by an editor commandlet rather than a standalone program. Change 4082756 by Graeme.Thornton Fixed some incorrect documentation for pakfile compressed chunk headers Change 4082883 by Graeme.Thornton Static analysis warning fix Change 4082912 by Ben.Marsh Move ExceptionUtils into DotNETUtilities. Change 4085291 by Graeme.Thornton TBA: In the Json output formatter, write float and double values out with enough precision for successful roundtripping. Added some debug only code which will immediately reconvert the string back to its original value and compare the the input Change 4085523 by Graeme.Thornton TBA: Remove only explicit usage of DECLARE_FSTRUCTUREDARCHIVE_SERIALIZER. Should only be used from UHT generated code. Change 4086037 by Robert.Manuszewski Fix for a potential race condition when two threads want to acquire GC lock Change 4088655 by Graeme.Thornton Pak creation now uses the bEnablePakSigning setting from the crypto config json file Change 4091474 by Steve.Robb Fix for TStaticBitArray::FindFirstSetBit() and TStaticBitArray::FindFirstClearBit(). Unused variables removed. Change 4093632 by Steve.Robb CIS fixes. Change 4093656 by Graeme.Thornton Build fix Change 4093744 by Ben.Marsh Allow per-chunk settings for whether to enable compression in UnrealPak. Change 4099712 by Gil.Gribb UE4 - Fixed rare case where insufficient space was preallocated for cooldown ticks. #jira UE-59686 Change 4099912 by Stefan.Boberg Cooking timer optimizations: - Replaced data structures for FScopeTimer and FHierarchicalTimerInfo. Previous implementation used FString for many things and caused *lots* of heap and string concatenation activity. Replaced with a compile-time node id (using __COUNTER__) and raw string literals. - Removed PERPACKAGE_TIMER support (was disabled by default and was difficult to test) - Made it possible to toggle OUTPUT_TIMING and ENABLE_COOK_STATS independently - Removed some extremely tight timers because the overhead from calling QPC significantly exceeded the measured code This change shaved some 15% off a clean cook of Fortnite WindowsClient (en) with fully populated local DDC Change 4100519 by Stefan.Boberg Quick fix for Linux build issue introduced in 4099927 Change 4105327 by Stefan.Boberg Cooker: Changed FHierarchicalTimerInfo so it uses a linked list for tracking child nodes, to be able to deal with any child count. Previously we assumed there would never be more than 9 children but it turns out there are cooker modes that need more. Fixes check when using -FullLoadAndSave to cook Change 4105448 by Stefan.Boberg - Fixed Linux build warning re: member initialization order - Also eliminated OUTPUT_HIERARCHYTIMERS/CLEAR_HIEARCHYTIMERS macros (plain functions are fine) - Moved finishing-up code for FullLoadAndSave() to TickCookOnTheSide() call site to improve timer output. Previously some of the scopes would not have been closed before printing and thus the output was misleading. Change 4109031 by Ben.Marsh Attribute-driven Perforce wrapper (old Epic Friday project). Offers a more complete implementation than the current P4 wrapper in UAT without requiring any platform-specific libraries. Uses the Python binary output for parsing. Change 4109588 by Ben.Marsh UBT: Add extension methods for serializing a nullable type to a BinaryReader/BinaryWriter. Change 4109595 by Ben.Marsh Missing project file for DotNETUtilities. Change 4110724 by Stefan.Boberg Removed annotation map locking in UObjectMarks, eliminating around one minute (~3.5%) from Fortnite cook time. The locking was redundant since the annotation maps are managed per thread anyway. Change 4111304 by Ben.Marsh UAT: Add support for setting a status message through the log class. Allows writing transient messages (eg. progress messages) which will be cleared out before writing other messages. Best used through the LogStatusScope class, which can set a status message for the duration of a using() block. As part of this change, the console no longer has to be added as a dedicated trace listener. Since we already special-case this listener when formatting log output, it's easier to just keep the implementation separate to the other trace listeners. Change 4112708 by Steve.Robb Fix for TBitArray::MaxBits in assignment. Change 4114133 by Stefan.Boberg Tweaked how low-level memory (LLM) tracker is implemented to reduce overheads. Previously FMemory functions would acquire the LLM singleton and call OnLowLevelFree/OnLowLevelAlloc etc which would check the bIsDisabled flag and early out if it was set. Due to how frequently these functions were called this ended up costing quite a bit. - This change makes the flag a static member variable instead of a member variable and therefore enables a simpler early-out to be implemented. - The singleton getter is also simplified to avoid hitting the threadsafe singleton construction path on every call. - The enable flag is no longer TAtomic - this also incurs extra overhead for no clear benefit Shaves approximately 3.5% (one minute) off a Fortnite cook test scenario (using -FullLoadAndSave) Change 4115010 by Robert.Manuszewski Fixing CIS Change 4115249 by Robert.Manuszewski Fixing async loading code asserts when exiting game very early due to an error #jira UE-56267 Change 4117091 by Ben.Marsh Prevent doubled-up lines when writing status updates with console log verbosity. Change 4117207 by Ben.Marsh UGS: Do not include executables in diagnostics zip file, and ignore "no such files" error when cleaning workspace. Change 4119175 by Ben.Marsh UGS: Fix crash writing version files when directory does not already exist. Change 4119987 by Ben.Marsh UGS: Show a dialog box while the launcher is updating executables from Perforce, which allows cancelling the operation if necessary. Allow setting the username on the settings window, and prompt for login credentials if necessary. Should prevent situations where users have to update settings from the command prompt. Holding down shift during launch now shows the settings dialog rather than an immediate prompt to launch the unstable version (unstable version is shown as a checkbox on this dialog). Change 4119991 by Ben.Marsh Update version number for UGS launcher to 1.13. Change 4121943 by Robert.Manuszewski Don't use FArchiveAsync2 for reading packages with non-async path in editor builds as its performance is worse than the standard archive's (saves about 1 minute when doing larger cooks and 7 seconds when loading into PIE) Change 4122592 by Steve.Robb GitHub #4762 : Improve wording and grammar of Math comments Also includes improved accuracy in FMath::ComputeBoundingSphereForCone(). Change 4122819 by Stefan.Boberg Don't call CreateDirectory redundantly when opening files for writing using FFileManagerGeneric::CreateFileWriter This change avoids calling IPlatformFile::CreateDirectoryTree if possible since this is a very expensive function especially for deep hierarchies as it performs directory creation from the root directory onwards instead of from the leaf downwards. That function should also be fixed but this change improves performance in the meantime. Change 4122872 by Stefan.Boberg CreateDirectoryTree now creates directories leaf-to-root instead of the other way around. This is much more efficient since we don't spend time on system API calls for directories which already exist. This accounted for a very large amount of CPU time in cooking as the full target file directory hierarchy would be "created" for every single output file. Change 4123109 by Stefan.Boberg - Disable overlapped I/O in editor / cooker. Synchronous I/O reduces the number of syscalls and Windows performs prefetching on our behalf anyway for sequential reads - Eliminated syscall which was issued for every write to update cached file size -- since we're the only writers to the file (file access allows read sharing at most) we can authoritatively update the file size on write completion Change 4123455 by Ben.Marsh PR #4775: New build param PCHMemoryAllocationFactor to set /Zm VS build param. (Contributed by lucaswall) Change 4124207 by Ben.Marsh UBT: Remove some unnecessary indirection for generated code paths. Change 4124217 by Ben.Marsh UBT: Remove another unused variable from UEBuildModuleCPP. Change 4124377 by Stefan.Boberg In IPlatformFile::DeleteDirectoryRecursively, attempt to delete file first and if it fails clear the readonly flag and try again Previously there was a call to clear the readonly flag for every deleted file and this is a waste of resources 99% of the time. The SetFileAttributes call accounted for a significant amount of time during cooker sandbox directory deletion Change 4125071 by Stefan.Boberg Some tweaks to FQueuedThreadPoolBase scheduling and memory management - Explicitly pass in false for TArray::RemoveAt(..., bool bAllowShrinking) argument to prevent memory reallocation when arrays are drained and inevitably repopulated shortly afterwards - Use a MRU strategy instead of LRU when picking a thread to wake up. The MRU thread is the most likely to have a 'hot' cache for the stack etc. Picking from the back of the array also happens to be cheaper since no memory movement is necessary when RemoveAt is called. (This was the strategy in place before CL2600362 which seems to have changed it unintentionally) - Release lock as soon as a thread has been chosen, before asking the worker thread to wake up and do the work Change 4126132 by Ben.Marsh UAT: Detect when stdout is redirected and prevent using backspace characters to move the cursor. Change 4126867 by Graeme.Thornton TBA: Fix tagged binary formatter Change 4127010 by Robert.Manuszewski AnimScriptInstances created at runtime will now also be added to the owning omponent's cluster to avoid GC issues. Change 4127932 by Ben.Marsh WorkspaceTool: Reduce unnecessary logging of status messages when console output is not redirected. Change 4129050 by Ben.Marsh UGS: Check for NET Framework 4.5 being installed before running the installer. Also fix warning trying to kill existing UGS instances before upgrade. Change 4129459 by Graeme.Thornton TBA: TextAssetCommandlet - When outputting converted assets to an output path, replicate the workspace relative path in the output directory Change 4129515 by Graeme.Thornton TBA: Add EnterRecord overload that allows outputting of available field names when loading. Change 4129517 by Graeme.Thornton TBA: Tagged properties are written out as named fields on the "Properties" record, rather than as a stream with a null tag at the end Change 4129518 by Graeme.Thornton TBA: Added a local const bool to allow easy hacking out of text asset loading support Change 4129558 by Graeme.Thornton TBA: Build fix for textasset-less configs Change 4129614 by Ben.Marsh UGS: Main window is now restored to normal size when activated by clicking on the tray icon. #jira UE-60490 Change 4129618 by Ben.Marsh UGS: Speculative fix for unreproduced exception accessing disposed window while shutting down. Change 4131936 by Robert.Manuszewski Removing some WIP code accidentally checked in with CL #4121943 Change 4133490 by Ben.Marsh UGS: Allow the $(Change) variable to be used in more places than just the context menu. #jira UE-60573 Change 4133550 by Ben.Marsh UGS: Setting for whether or not to use incremental builds is now exposed through the variable "$(UseIncrementalBuilds)" for use by custom build steps. #jira UE-60554 Change 4133681 by Ben.Marsh UGS: A per-project list of folders and extensions to be deleted by default when running the 'clean workspace' tool can now be specified through the <ProjectDir>/Build/UnrealGameSync.ini file. Settings may be specified for an individual branch (via a category with the depot path to the project) or for wherever the project is currently open (via the [Default] category). The SafeToDeleteFolders list specifies a substring that will be checked against folder paths. Anything containing this folder will be marked as safe for delete by default. The SafeToDeleteExtensions list specifies a list of extensions for files that can always be deleted. Example: [Default] +SafeToDeleteFolders=/MyGame/Test/ +SafeToDeleteFolders=/DataService/ +SafeToDeleteExtensions=.xx1 +SafeToDeleteExtensions=.xx2 #jira UE-60575 Change 4135449 by Ben.Marsh Fix allowing use of Job objects on Windows platforms (debug code submitted by mistake) Change 4135730 by Ben.Marsh UBT: Plugins can now be enabled and disabled from the .target.cs file (for targets that do not use the shared compile environment), by compiling the list of enabled/disabled plugin names into the Projects module. Change 4135823 by Ben.Marsh UBT: Remove legacy code to handle disabling optional plugins; now that this is compiled into the target, it will work for any plugins we choose. Change 4135945 by Ben.Marsh UBT: Fix error running programs with no explicitly enabled or disabled plugins. Change 4137207 by Ben.Marsh UGS: Align all badges with the same name, to make it easier to see which CIS steps are being run. Allow overriding the slot taken by a particular badge by calling it "SlotName:LabelName". Change 4137311 by Stefan.Boberg Removed child cooker support. In practice it is not a useful feature as it provides no performance improvement (quite the opposite in fact) and adds testing and maintenance complexity. Change 4137393 by Ben.Marsh UGS: Fix display of multiline errors in the status panel. Change 4141708 by Steve.Robb GitHub #3631 : Incorrect default argument in WeakObjectPtrTemplate #jira UE-45490 Change 4146655 by Stefan.Boberg Removed FullGCAssetClasses logic - no longer necessary nor useful Change 4147318 by Ben.Marsh UGS: Compress build badges in a column if it shrinks below the size that they would be visible. Change 4148207 by Ben.Marsh UGS: Added support for showing the latest completed build from a specific list of badges in the status panel. To declare a badge as one that should appear in the status panel rather than the CIS column, add it to the project's UnrealGameSync.ini in the project or [Default] section like so: +ServiceBadges=RoboMerge Change 4148282 by Stefan.Boberg Fixed bug in UCookOnTheFlyServer::GetCookOnTheFlyUnsolicitedFiles - UnsolicitedFiles should be passed by reference not by value Change 4148344 by Stefan.Boberg Fixed minor indentation error (most likely caused by sloppy merge) Change 4148521 by Stefan.Boberg Removed accidentally checked in PRAGMA_DISABLE_OPTIMIZATION from CookOnTheFlyServer.cpp Change 4148639 by Ben.Marsh UGS: Fix tooltips not showing for changes that have description badges. Change 4149373 by Ben.Marsh UGS: Allow adding additional columns to display particular badges by adding entries from the project config file. Example syntax: +Columns=(Name="Desktop",MinWidth=50,DesiredWidth=100,Weight=3,Badges="Editor") +Columns=(Name="Mobile",MinWidth=50,DesiredWidth=100,Weight=3,Badges="IOS,Android") Same form can be used to control how default columns are displayed (though badge settings are ignored). Also allow PerforceMonitor to detect local changes to project config files and update settings automatically. Change 4149399 by Ben.Marsh UGS: Update version to 1.143. Change 4155660 by Steve.Robb PROJECTION and PROJECTION_MEMBER macros which provide the correct behavior when creating projections using functions which are overloaded or use default arguments. Change 4157117 by Ben.Marsh Fix warning due to plugins disabled in .target.cs file. Change 4158011 by Ben.Marsh UBT: Add a check that the UnrealHeaderTool target file exists, rather than throwing an exception when reading it fails. Change 4158646 by Ben.Marsh UGS: Fix exception when login is discovered to have expired during a workspace update. Change 4158678 by Ben.Marsh UGS: Fix an exception on shutdown due to the icon being hidden after it's already been disposed. Change 4158683 by Ben.Marsh UGS: Add an unhandled exception filter which sends the exception data to the backend. Change 4159131 by Ben.Marsh UGS: Reduce the number of characters displayed for build badges based on the available space. Change 4159194 by Graeme.Thornton TBA: Fix incorrect map property conversion code when converting an old property that contains a map with different key/value types Change 4159239 by Steve.Robb Improved readability and compliance with coding standards. Change 4159246 by Ben.Marsh UGS: Allow syncing projects where source code is not available (and various version files don't exist). #jira UE-60985 Change 4159286 by Ben.Marsh UGS: Remove requirement for UE4Editor.target.cs to be visible in the depot in order to open a project. #jira UE-60986 Change 4159302 by Ben.Marsh UGS: Update version to 1.144. Change 4160308 by Ben.Marsh All staging client executables for blueprint projects. #jira UE-60983 Change 4161567 by Steve.Robb GitHub #4816 : UE-60771: Handle escaped double quote in FParse::LineExtended Change 4162641 by Ben.Marsh UGS: Allow customizing the position of custom columns, via the Index=N attribute. Change 4162647 by Ben.Marsh UGS: Update version to 1.145. Change 4165319 by Robert.Manuszewski PR #4812: Fix inconsistent command-line argument handling under Windows (Contributed by adamrehn) Change 4166150 by Ben.Marsh UGS: Include *.inl when looking for code changes. Change 4166551 by Steve.Robb Whitespace fixes caused by a bad merge. Change 4168483 by Ben.Marsh UGS: Add a more useful error if a file to be synced exceeds the max allowed path length. Change 4168490 by Ben.Marsh UGS: Update version to 1.146. Change 4168551 by Ben.Marsh UBT: Move bBuildLargeAddressAwareBinary into an exposed setting. Change 4168560 by Ben.Marsh UBT: Remove static config variable for controlling which configuration of UHT to use. Change 4171296 by Ben.Marsh UGS: Move the check for overlong paths earlier. Change 4171531 by Ben.Marsh UBT: Fix exception if BuildConfiguration.xml contains an unknown category. Change 4183371 by Robert.Manuszewski Fix for a crash in Async Loading Graph's CheckCycles when GC kicks in on the game thread and forces ALT to exit early Change 4184312 by Ben.Marsh UGS: Update version to 1.148 Change 4184480 by Robert.Manuszewski Removing unused async loading stat Change 4186390 by Ben.Marsh UBT: Format XML validation errors in a format that allows double-clicking on the message in Visual Studio. Change 4188644 by Ben.Marsh UBT: Add the MakePathSafeToUseWithCommandLine() function to UBT. Change 4188647 by Ben.Marsh UBT: Fix exception in target receipt when architecture is null. Change 4189617 by Ben.Marsh Change FileSystemReference, FileReference and DirectoryReference objects to use OrdinalIgnoreCase comparisons without creating a separate copy of the string to compare. The filesystem does not use the invariant culture, and it can produce the wrong results in some cases (the ordinal comparison is faster, too). Change 4189740 by Ben.Marsh UAT: Remote code to build UnrealPak when packaging; we use the editor now. Change 4189860 by Ben.Marsh UGS: Make the filter for excluding automated lighting rebuilds more explicit. Change 4190082 by Ben.Marsh Fixes to allow enabling edit and continue for Windows builds. Have experienced quite a few VS crashes when testing it in editor; not yet recommended for general use. - Allow edit and continue for any configuration, not just debug. - Fixed PDB errors compiling files that use a shared PCH with edit and continue enabled. Path to the generated PDB file was using the wrong directory. - Removed code that tracks PDB output files, since they're modified multiple times during a build. - Enable debug information when compiling generated CPP files, since it causes errors if the shared PCH PDB doesn't have the same option. - Disable support for remote execution of steps that modify the PDB, since the same file has to be modified many times. Remote execution causes the PDB files to be corrupted. Unfortunately, this makes E&C builds significantly slower. #jira Change 4192949 by Ben.Marsh UBT: Minor tidy-up (merging UEBuildBinary.Build and UEBuildBinary.SetupOutputFiles) Change 4193218 by Ben.Marsh Fix formatting. Change 4197252 by Mike.Erwin UAT: Fix log output w/ correct count of non-code projects. #jira none Change 4197941 by Ben.Marsh UGS: Add support for DebugGame editors that have an executable with a DebugGame suffix. Change 4197964 by Ben.Marsh UGS: Prevent attempts to automatically reopen projects while a modal dialog is up, or the workspace is syncing. Change 4198144 by Ben.Marsh UGS: Prevent modal dialogs when login expires in P4, and prompt for password when hitting "retry". Change 4198413 by Ben.Marsh UGS: Always show the main window when launched manually, and run with -RestoreState when launched at startup. Also add a couple more places that save the visibility state, since logging off seems like it can terminate the process abrubtly. Change 4198779 by Ben.Marsh UBT: Allow generating manifests to any arbitrary locations with the -Manifest=<Path> argument. Change 4198825 by Ben.Marsh UBT: Move code to enumerate Slate runtime dependencies into the Slate module. Doesn't need to be done inside core UBT. Change 4199341 by Ben.Marsh UGS: Update version to 1.149 Change 4199642 by Chad.Garyet - Deprecate CISController - Add BuildController to replace CIS GET/POST for builds - Add LatestController, GET does what CIS/GET used to do - Change Latest/GET to return the last 25 builds filtered by project, rather than the last 5000 individual Ids - Latest/GET now returns "LatestData" object instead of array of longs - Updated EventMonitor to match all API changes - Fixed bug where IDs were getting reset to initial startup values every update loop Change 4199663 by Chad.Garyet CIS controller still needs to return an array of longs #jira none Change 4199680 by Ben.Marsh UGS: Update version to 1.150 Change 4200457 by Ben.Marsh Merging CIS fix for non-development configurations. Change 4200472 by Mike.Erwin UAT: fix -skipbuildclient param default It was defaulting to skipbuildeditor's value, likely a copy-paste error. #jira none Change 4202595 by Ben.Marsh Fix static analysis warning due to constant comparison against macro. Change 4203250 by Ben.Marsh UGS: Always show the "Sync Precompiled Editor" option, but disable it and show a tooltip explaining why if it is not available. Change 4206191 by Ben.Marsh Exclude editor target files from installed builds, since they leak info about DLLs that have been stripped out. Change 4213011 by Ben.Marsh UBT: Include contents of modified intermediate files in the log, to make it easier to debug hidden dependencies. Change 4213487 by Ben.Marsh UBT: Fix assumption that bPrecompile is equivalent to bBuildAllModules. This is no longer the case; they are now controlled by separate options. Should fix CIS errors building the editor. Change 4213609 by Ben.Marsh Ensure that strings formatted using FMicrosoftPlatformString::GetVarArgs() are always null terminated, whether we use the secure CRT or not. Change 4215971 by Ben.Marsh UBT: Remove action graph visualization code; no longer used. Change 4215996 by Ben.Marsh UBT: Remove unqiue id from all actions in the action graph. This is only used for printing debug info in the case of a (rare) cycle in the action graph, so just look it up when needed. Change 4216022 by Ben.Marsh UBT: Rename Crypto.cs to EncryptionAndSigning.cs to match the name of the class inside it, and move it under the System folder. Change 4216031 by Ben.Marsh UBT: Move all the action executors into their own folder in the project. Change 4216526 by Ben.Marsh Fix CIS warnings. Change 4216544 by Ben.Marsh Replace custom code to ensure FMicrosoftPlatformString::GetVarArgs() null terminates its buffer with Microsoft's standards-compliant implementation. Change 4216633 by Ben.Marsh Add support for UnrealPak plugins. * Project and plugin modules can now specify an array of supported programs in the "WhitelistPrograms" field of their module descriptors, to allow modules to be loaded by programs. * Programs can now load any runtime modules, as long as they are whitelisted. * Programs under the engine directory can now use a shared build environment, so that building with a project file does not cause output binaries to be output to the project directory. * UnrealPak is now always built by default when packaging * Convert UnrealPak to a modular configuration Change 4216736 by Ben.Marsh UnrealPak: Move "ExportDependencies" command into an editor commandlet, since it relies on the UObject system, asset registry, etc... Change 4217447 by Ben.Marsh Back out revision 50 from //UE4/Dev-Core/Engine/Build/InstalledEngineBuild.xml Change 4217451 by Ben.Marsh Back out revision 11 from //UE4/Dev-Core/Engine/Plugins/Developer/VisualStudioSourceCodeAccess/Source/VisualStudioSourceCodeAccess/VisualStudioSourceCodeAccess.Build.cs Change 4217617 by Ben.Marsh Back out changelist 4217451 Change 4222552 by Ben.Marsh Don't use #import <TypeLib> for VS source code accessor when building with Clang; it's not supported. Change 4222630 by Ben.Marsh UBT: Fix spam while generating project files if Clang isn't installed. Change 4223316 by Ben.Marsh UBT: Change the order in which Visual C++ toolchains are enumerated to prefer full releases over preview releases. Change 4223318 by Ben.Marsh UBT: Add a build setting which allows creating a dedicated PCH for every file that's excluded from the unity working set (disabled by default). Improves iteration times when working on individual cpp files, but slows down iterating on header changes (and can take a lot of disk space for large changes). Dedicated PCH contains all includes scraped from the top of each cpp file, until a non-#include directive is encountered. Change 4223401 by Ben.Marsh UBT: Add an option to automatically enable edit and continue for files in the adaptive non-unity working set. E&C doesn't seem very useful for UE4 projects right now; compile time is comparable to regular build times, but it can take several minutes to apply code changes for large projects. Change 4223899 by Ben.Marsh UBT: Fix loading XML config files on Mono; Type.GetField(Name) does not seem to return values unless binding flags are specified. Change 4224637 by Ben.Marsh Add a "SupportedPrograms" field to plugin descriptors, which allows plugins to declare which plugins they support independently of individual modules. Programs now respect the "bEnabledByDefault" setting in plugins. Plugins that are compatible with a program now need to list that program in the SupportedPrograms list, and whitelist any modules that should load for that program. Change 4224710 by Ben.Marsh UBT: Don't add import libraries as final build products unless the target is being precompiled. Prevents the need for building them for leaf nodes in the action graph. Change 4224715 by Ben.Marsh UBT: Remove hack to allow Stats2.cpp to not follow IWYU convention. Change 4224726 by Ben.Marsh Remove commented out line. Change 4224903 by Ben.Marsh Fix non-unity compile error in Stats2.h. Change 4225051 by Ben.Marsh Back out changelist 4224710; causing CIS errors due to receipts not matching. Change 4225134 by Ben.Marsh Fixing non-unity errors. Change 4225203 by Ben.Marsh Another non-unity fix. Change 4225249 by Ben.Marsh Fix Linux dependencies being copied for the Windows editor; they can be added as requirements for the Linux target platform on Windows instead, so it respects the user's chosen platforms. #jira UE-62001 Change 4225512 by Ben.Marsh BuildGraph: Allow setting the target to build when using the <CsCompile> task. Change 4228815 by Ben.Marsh UBT: Always add the generated code directory to the list of include paths when generating project files. It may only be created after UHT has been run. Change 4228944 by Ben.Marsh UBT: Remove legacy CppCompileEnvironment and LinkEnvironment wrappers from TargetRules that were deprecated in 4.19. Change 4229028 by Ben.Marsh UBT: Fix editor targets with unique build environment having the wrong executable path in generated project files. Move move logic to configure target rules post-construction by the rules assembly to ensure it's valid. Change 4229065 by Ben.Marsh UBT: Move another target setting into the rules assembly. Change 4229105 by Ben.Marsh Fix BPT exception when generating project files. Change 4229311 by Ben.Marsh UBT: Store the module rules file location on the ModuleRules instance, as well as the plugin that it was created from. Also expose the plugin directory as a property on the ModuleRules instance. Change 4229421 by Ben.Marsh UBT: Consolidate functionality for UHT module setup in ExternalExecution.cs. Change 4229817 by Ben.Marsh UBT: Modules must now explicitly specify the path to the header used to generate a PCH if one is desired, rather than the header being determined automatically by attempting to parse the source code. Now that PCHs are force-included anyway, this removes a lot of dependencies inside UBT. Change 4229824 by Ben.Marsh UBT: Remove unused lists inside UEBuildModuleCPP.SourceFilesClass. Change 4229841 by Ben.Marsh UBT: Remove some legacy code from auto-detecting PCHs. Change 4230521 by Ben.Marsh UBT: Add utility functions to the log class to allow formatting errors and warnings in Visual Studio output format (eg. File(Line): warning: Message) Change 4230871 by Ben.Marsh UAT: Remove StreamUtilis utility class; there is a simpler way to implement the one place it's used. Change 4230882 by Ben.Marsh UAT: Add StreamUtils back into UAT, seems like it's still used there. Change 4230896 by Ben.Marsh UBT: Remove some redundant parameters from UEBuildModule/UEBuildModuleCPP/UEBuildModuleExternal constructors. Change 4231014 by Ben.Marsh WorkspaceTool: Include a dump of raw bytes when garbage is read from the P4 process, for diagnostic purposes. Change 4231032 by Ben.Marsh Fix CIS. Change 4231096 by Ben.Marsh Bump the FlatCPPIncludeDependencyCache version, to prevent errors trying to load old files. Change 4231446 by Ben.Marsh UBT: Added support for expanding UE-specific variables in include paths and library paths: $(EngineDir), $(ProjectDir), $(PluginDir), $(ModuleDir). Change 4231460 by Ben.Marsh Modules may now explicitly specify rpaths on Linux via the PublicRuntimeLibraryPaths and PrivateRuntimeLibraryPaths properties. Change 4233909 by Robert.Manuszewski PR #4779: Reason fails as the supplied variable is incorrect (Contributed by projectgheist) Change 4233910 by Ben.Marsh Enable PCHs on IOS. Reduces build time by ~25%. Change 4234176 by Ben.Marsh UBT: Add better messaging for modules that need to have a private PCH set. Now detects the likely PCH using the same method as legacy code and includes it as a suggestion. Change 4234193 by Ben.Marsh Add the Delete command to Perforce wrapper in DotNETUtilities. Change 4234688 by Ben.Marsh UBT: Simplify handling of installed/precompiled builds. Settings for whether a folder is installed/read-only or not is now stored on the RulesAssembly instance, allowing multiple things to be configured separately and stacked together (eg. engine/enterprise/project). RulesAssembly.IsReadOnly() allows determining if a flie can be modified or not and replaces many previous IsXXXInstalledCalls(), and traverses the chain of assemblies. Change 4234711 by Ben.Marsh UBT: Runtime dependencies can now be copied to output directories as part of the build. When adding a runtime dependency, an optional source location can be specified to copy from. Both the source and target paths can use variables can be used as part of the path, eg. $(OutputDir), $(ModuleDir), $(PluginDir). Example usage (from a .build.cs file): RuntimeDependencies.Add("$(OutputDir)/Foo.dll", "$(PluginDir)/Source/ThirdParty/Foo.dll", StagedFileType.NonUFS); Change 4234872 by Ben.Marsh Expose a flag for whether the engine is installed, to fix issues generating project files. Change 4234929 by Ben.Marsh Fix null reference generating receipts when UBT makefiles are active. Change 4235883 by Chad.Garyet Merging 4231245 to core Giving Coordinator its own sln. This should fix what 4158155 was supposed to. #jira UE-61955 Change 4236075 by Ben.Marsh CIS fix Change 4237066 by Robert.Manuszewski Fix for a potential crash when terminating the engine while it's being initialized #jira UE-60545 Change 4237078 by Robert.Manuszewski The engine will no longer be resetting all linkers causing massive load times when renaming the world package when entering Play In Editor Change 4237116 by Ben.Marsh Rewrite some Windows utility functions to support paths longer than MAX_PATH. Change 4237158 by Ben.Marsh Add const TCHAR* overloads of FString::RemoveFromStart() and FString::RemoveFromEnd(). Change 4237159 by Ben.Marsh Fix FWindowsPlatformFile::GetFilenameOnDisk() support for paths longer than MAX_PATH, and simplify some of the other long path functions to avoid copying string buffers. Change 4239050 by Ben.Marsh Missing file Change 4239318 by Ben.Marsh Linux CIS fix. Change 4239685 by Ben.Marsh Static analysis CIS fix. Change 4240800 by Ben.Marsh WorkspaceTool: Include the full command line in the log for any P4 commands. Change 4240903 by Ben.Marsh PR #4909: Update copyright notices to 2018 (Contributed by projectgheist) Change 4241025 by Ben.Marsh UBT: Exclude mobile pipeline caches from generated project files. Causes huge slowdown when using 'Find in Files' through the IDE. Change 4241770 by Ben.Marsh UBT: Include action number in parallel executor output. #jira UE-62032 Change 4243469 by Ben.Marsh TBA: Merge FAnnotatedStructuredArchiveFormatter with FStructuredArchiveFormatter. Any functions that are only implemented for text archives now have a _TextOnly suffix, and are exposed through the FStructuredArchive interface. Change 4245723 by Robert.Manuszewski Fixing another creash when terminating the engine while initializing. #jira UE-60545 Change 4245862 by Steve.Robb VectorLoadFloat2(Ptr) added, which loads { Ptr[0], Ptr[1], Ptr[0], Ptr[1] } into a VectorRegister. Change 4246412 by Robert.Manuszewski The warning 'Calling StaticLoadObject during PostLoad may result in hitches during streaming' will now also report the object which had the PostLoad called on it when StaticLoadObject call happened. Change 4246612 by Ben.Marsh UBT: Fix spelling of "Intellisense". Change 4249454 by Robert.Manuszewski Added extra checks to catch scenarios where the EDL Precache Buffer is flushed before a package header is fully read Change 4249513 by Robert.Manuszewski Made sure the Async Loading Thread doesn't continue running after creating new async packages when garbage collector wants to run on the game thread Change 4255207 by Ben.Marsh UGS: Add additional logging whenever a P4 command fails, and when the user is logged out. Change 4255288 by Ben.Marsh PR #4921: Honor ModuleRules' bEnableExceptions flag when creating precompiled h. (Contributed by surakin) Change 4256422 by Ben.Marsh UBT: Add an error if a module referenced by a plugin descriptor doesn't exist. Change 4257385 by Robert.Manuszewski Creating new objects from within ForEachObjectWithOuter will now result in a fatal error as it's unsafe to change internal UObject hash tables when iterating over them. Change 4257454 by Robert.Manuszewski Added the option to filter clusters listed with gc.ListClusters by objects within them. Usage: gc.ListClusters Hierachy With=ObjectName1,ObjectName2... Change 4257526 by Robert.Manuszewski It's now possible to filter clusters that get logged with verbose cluster logging enabled (UE_GCCLUSTER_VERBOSE_LOGGING=1) by objects within them by specifying -DumpClustersWithObjects=ObjectName1,ObjectName2 in the command line Change 4257822 by Ben.Marsh Fixes for PlatformShowcase compile errors. Change 4258771 by Ben.Marsh UBT: Fix project files not being generated for foreign projects when creating .stub files. #jira UE-62462 Change 4258790 by Ben.Marsh UBT: Clean up the logic around generating project files before creating a stub IPA, so that it fails loudly if project files do not exist, and can accept target names not matching project names. Change 4259276 by Ben.Marsh UBT: Make it an error if a framework doesn't exist, rather than failing silently. Also remove some remote toolchain stuff that's no longer necessary. Change 4259280 by Ben.Marsh UBT: Fix embedded framework zips not being uploaded for plugins. #jira UE-62485 Change 4260236 by Ben.Marsh UBT: Fix path to generated engine project file. Change 4260334 by Ben.Marsh UGS: Fix custom build steps dialog inadvertantly modifying config file settings in-place. Change 4260361 by Ben.Marsh UGS: Allow for p4 login commands to fail, even though the user is logged in (due to a bad connection, etc...) Change 4260559 by Ben.Marsh UGS: Update version. Change 4261160 by Robert.Manuszewski MediaPlaylist will now be added to root set if the owning MediaPlayer is in the disregard for GC set (fixes GC assumption violation crash) #jira UE-62495 Change 4261421 by Ben.Marsh Force-sync files for building documentation, to fix issues with files not being updated. #jira UE-62413 Change 4261425 by Ben.Marsh UBT: Remove some leftover functions for handling the remote toolchain. Change 4261530 by Ben.Marsh UBT: Speculative fix (and better error reporting) for IOS mobile provision not being found in CIS. Change 4261611 by Ben.Marsh UBT: Downgrade warning to a log message, since it appears when generating project files. Change 4261710 by Ben.Marsh Remove assert that GLogConsole is set; it won't be for command line utilities that don't depend on ApplicationCore. #jira UE-62545 Change 4261831 by Ben.Marsh Fix compile errors due to missing include path when hot-reloading a module from the editor. There are not necessarily source files to compile when -modulewithsuffix is specified on the command line, which was results in GeneratedCodeWildcard not being set. #jira UE-62463, UE-62384 Change 4262723 by Ben.Marsh Whitelist plugins that need to be loaded by UFE. #jira UE-62564 Change 4265444 by Ben.Marsh Fix incorrect executable name for DebugGame configurations in Xcode. #jira UE-62574 Change 4265892 by Ben.Marsh Fix incremental compile failures due to dependency checking for unity files. CachedIncludePaths was not correctly being set on file items, so dependencies were being ignored. #jira UE-62575, UE-62603, UE-62597 Change 4266019 by Josh.Adams - Fixed the CopyAction for runtime dependencies that need to be copied to different location, on non-XGE Change 4266264 by Ben.Marsh Remove override for the __IPHONE_OS_VERSION_MIN_REQUIRED macro on TVOS. This macro is already defined by system headers (in <AvailabilityInternal.h>). Now that we support PCHs on IOS and TVOS, manually defining this macro results in it being defined three times (once for the PCH, once by AvailabilityInternal.h, and once by the force-included list of definitions for the source file being built). The errors for redefining the macro in AvailabilityInternal.h are suppressed due to it being a system header, but the error for redefining it for the source file being compiled are not. #jira UE-62578 Change 4266273 by Ben.Marsh Fixes incremental build failure when compile arguments for PCH have changed on IOS/TVOS. Compile action needs to have a dependency on PCH build action. Change 4266614 by Graeme.Thornton Fix crash when cooking nativized blueprints due to removal of child cooker system. Change 4266763 by Ben.Marsh Always build UnrealPak when building client targets. The ProjectParams.Pak option is not reliable, because it can be forced on later by the target platform. #jira UE-62584 Change 4267985 by Robert.Manuszewski When iterating with ForEachObjectWithouter, don't lock the entire has table but only the hash bucket that is currently being iterated #jira UE-62600 Change 4268558 by Robert.Manuszewski PurgeLegacyBlueprints will no longer be called from within ForEachObjectWithOuter is it renames objects that reside in hash tables that are being iterated over which may lead to undefined behavior. #jira UE-62600 Change 4269011 by Chad.Garyet - Fixing Wildcard match issue, the change to ugsapi sends projects as //Depot/Stream instead of //Depot/Stream/ Wildcard match was only substringing to 3 chars. - Checking in the change a while back that increases the number of queried jobs up to 432 based on some maths from Bob about how many builds we want to grab Published to ugsapi server 8/8/17 #jira none Change 4270788 by Ben.Marsh Fix IOS provisioning data being using when remote compiling on TVOS. #jira UE-62705 Change 4271916 by Ben.Marsh Tag the XGEControlWorker executable as a build product after compiling SCW, to make sure it's included in the UGS zip file. Change 4271934 by Ben.Marsh Upload all static libraries in plugin folders as part of remote builds. #jira UE-62694 Change 4273368 by Ben.Marsh Fix Slate dependencies not being enumerated, and rules assembly not being rebuilt when building remotely. #jira UE-62705 Change 4274049 by Ben.Marsh Always parse the team UUID out of the mobile provision when doing a remote compile. The provision installed on the remote Mac (and selected for signing) may be different. #jira UE-62751 Change 4274823 by Ben.Marsh Add the -VersionCookedContent argument to disable the -unversioned parameter on the cooker command line. Change 4275838 by Ben.Marsh Fix BuildVersion string not being passed through from <SetVersion> task. Also add a -BuildVersion command line argument to UBT to override it for a particular build. Change 4275913 by Ben.Marsh Add a dummy exported symbol to the XGEController module, to fix build errors due to missing .lib file when it's built with WITH_XGE_CONTROLLER = 0. Change 4284161 by Ben.Marsh Allow mirroring Oodle files to remote Mac. Change 4074774 by Steve.Robb Vast simplification of TFunction, making it smaller in footprint, easier to follow and extend, and more correct. TUniqueFunction added, which is a move-only TFunction which can hold move-only functors. Fix for UWidgetBlueprint::ForEachSourceWidget() which should never have compiled but did. FFunctionGraphTask and TFuture<> updated to use TUniqueFunction to make them more general. TArray::HeapPop() made to work with move-only types. Change 4082591 by Ben.Marsh Move the Log class from UBT to DotNetUtilities. Change 4083236 by Ben.Marsh Add a Log.WriteException() method to dump an exception message to the console (and write the exception trace to the log) Change 4084107 by Ben.Marsh UAT: Remove the unused -SkipHeader argument to UE4Build. Change 4089771 by Steve.Robb GitHub #4743 : modified VirtualAlloc function flag https://blogs.msdn.microsoft.com/oldnewthing/20151008-00/?p=91411 Change 4091456 by Steve.Robb Unification of all platforms' FMath::CountTrailingZeros() and FMath::CountLeadingZeros() for both 32-bit and 64-bit. Change 4156437 by Ben.Marsh Lots and lots of fixes compiling for Clang on Windows. Editor now compiles cleanly without warnings, but crashes on startup due to error in intrinsics test. Disabling that runs further, but crashes accessing freed memory. Switching to the ANSI allocator runs further, but crashes in Slate after the splash screen and before the editor window opens. // TODO! * Switching between Clang/ICL/VS2015/VS2017 is now supported through the same mechanism as switching Visual Studio versions, without requiring any source level changes. To use Clang, set WindowsPlatform.Compiler = WindowsCompiler.Clang from a .target.cs file, or set <WindowsPlatform><Compiler>Clang</Compiler></WindowsPlatform> from BuildConfiguration.xml. To pick a specific toolchain version, set WindowsPlatform.CompilerVersion. * Clang is now supported through AutoSDKs; will be added to CIS. * The Samples/Sandbox/Clang project forces Clang to be used from its target.cs file, and allows easily building all editor modules and plugins with Clang on Windows. * UnrealMathSSE intrinsics have been re-enabled for Clang due to missing functions from the UnrealMathFPU implementation, but causes failure in tests at startup. * SSE4_CRC32() is disabled in D3D12Pipelinestate.cpp, since intrinsics are only allowed if enabled for the whole target (rather than being used in specific functions due to runtime checks) Change 4157389 by Ben.Marsh Few more fixes for compiling the editor with Clang. Change 4183911 by Ben.Marsh Fixes to support incremental linking on Windows. Does not seem to have any net benefit right now; may improve once minimal rebuild is enabled. * Incremental linking no longer forces PDB files to be enabled for source files. * Actions can specify specific files to be deleted before each build. Code to forcibly delete PDB files has been moved to the MSVC toolchain. * Unused libraries produced by the cross-referenced link are no longer added as build products, since (a) deleting them breaks dependency checking for incremental linking and causes a full link, and (b) not deleting them breaks UBT dependency checking and causes actions to be run over and over again. * Icon update is disabled for Windows when incremental linking is enabled. * Removed rarely-used setting to always delete produced items before each build. Change 4184311 by Ben.Marsh UGS: Added a dialog which shows all the required platform SDKs for a branch, linked from the status panel in UGS. The llist is configured via the UGS config file submitted to Engine/Programs/UnrealGameSync/UnrealGameSync.ini (and may be overridden by the project config file if necessary): [Default] ; Set this to a network share which contains the SDK installers for your site SdkInstallerDir= ; All the required SDKs for the current version of the engine +SdkInfo=(Category="Android", Description="NDK r21", Browse="$(SdkInstallerDir)\\Android") +SdkInfo=(Category="Windows", Description="Visual Studio 2017") +SdkInfo=(Category="Windows", Description="Visual C++ Toolchain 14.13.26128") +SdkInfo=(Category="Windows", Description="Windows SDK 10.0.16299.0") Similar entries for console platforms are added in console subdirectories. Each entry may contain an Install="Foo.exe" and/or Browse="C:\Foo" style attribute, specifying the path to an installer to run or directory to open in explorer respectively. The SdkInstallerDir setting is used as a base directory for the default installers, seen above for Android. Licensees may override this with a network path specific to the site that UGS is being deployed to (either in this file, in a project specific config file, or in a Engine/Programs/UnrealGameSync/NotForLicensees/UnrealGameSync.ini file). Change 4200452 by Ben.Marsh UBT: Change DebugGame configurations to output a separate executable rather than requiring a -Debug argument at runtime. Previous behavior was a common source of errors. Engine modules are still shared between Development and DebugGame, but the launch module sets a flag in Core on startup indicating the game configuration. Change 4206189 by Ben.Marsh UBT: Simplify logic for precompiling binaries. * Target no longer has separate list of "precompile only" binaries or modules. New -AllModules option allows adding every module to a target, which can be used with -Precompile and -NoLink to precompile object files for monolithic builds. * Precompiled file lists have been removed from target receipts. * The manifest now includes all generated headers and precompiled files when run with the -Precompile option. * Separate -DependencyList=Foo.txt has been added to write a list of all dependencies required to use precompiled binaries. This file list can be read using the <Tag> task in buildgraph. Change 4215466 by Ben.Marsh UBT: Remove indirect calls to determine extensions for object files and precompiled headers. The toolchain knows the correct convention for the platform. Change 4215975 by Ben.Marsh UBT: Remove telemetry code. This has never proved useful for analyzing performance due to the number of incidental factors that affect build times (eg. number of files being compiled). Change 4220154 by Ben.Marsh Move text-only implementations of FOutputDeviceError back into Core, so we can build command-line applications that don't depend on ApplicationCore. Change 4224708 by Ben.Marsh Add a bCompileAgainstApplicationCore setting to the target rules, which allows compiling out references to the ApplicationCore module (which should only be necessary for applications with a GUI). Removed ApplicationCore from several engine tools and utilities. Change 4224958 by Ben.Marsh Remove CoreMinimal.h includes from Core. Change 4229059 by Ben.Marsh UBT: Remove the UEBuildPlatform.ShouldNotBuildEditor() hook for target platforms. We shouldn't be modifying a target's build environment to disable the editor; it is invalid to build the editor for these target platforms at all, and this is already enforced by the GetSupportedPlatforms() function. Change 4230508 by Ben.Marsh Fixup precompiled header setting for samples and games. Change 4231457 by Ben.Marsh Fix exceptions in log messages having trailing newlines. Change 4232406 by Ben.Marsh UBT: Always force include a PCH for generated code if there's one set; the code may depend on it to compile. Change 4234177 by Ben.Marsh Set up private PCH files everywhere that previously used them. Change 4235973 by Ben.Marsh Change FPlatformMisc::GetEnvironmentVariable() to return an FString() rather than requiring a fixed size buffer to be passed in. Removes references to MAX_PATH. Change 4238842 by Ben.Marsh Add support for paths longer than MAX_PATH in the editor. Requires Windows 10 version 1607, and the functionality to be enabled via a registry key or group policy (see https://docs.microsoft.com/en-us/windows/desktop/FileIO/naming-a-file). Only a subset of Win32 functions support long paths (executables can only be started from paths shorter than MAX_PATH, for example). * Added a FPlatformMisc::GetMaxPathLength() function to return the maximum length of a path on the current system. On Windows, this returns a different value for systems with long paths enabled to those without. * The MAX_PATH define is no longer set by non-Windows platforms. Instead, there is a MAC_MAX_PATH, UNIX_MAX_PATH, etc... for any platform-specific code that still relies on the previous macro. * The MAX_UNREAL_FILENAME_LENGTH macro has been renamed to MAX_UNREAL_FILENAME_LENGTH_DEPRECATED * The PLATFORM_MAX_FILEPATH_LENGTH macro has been renamed to PLATFORM_MAX_FILEPATH_LENGTH_DEPRECATED. * Removed custom resource files for programs, since they are just copies of the base UE4 one (which is used by default anyway). The base UE4 manifest declares support for long paths. * Fix 512 character maximum length on editor commands. 260 character limit remains in place for cooking at the moment (see ContentBrowserUtils.h), until C# staging code supports long paths. Change 4255042 by Ben.Marsh UBT: Remote compilation now uploads the entire workspace to the remote Mac and executes a separate remote instance of UBT rather than synchronizing individual actions. This makes the remote compile codepath much simpler, and removes a lot of special cases that exist to support it previously. The list of files to be transferred to the remote are listed as rsync filter rules in Engine/Build/Rsync/RsyncEngine.txt and RsyncProject.txt, which are applied to the root engine directory and project directory respectively. Projects that need to customize which files are uploaded can add their own <ProjectDir>/Build/Rsync/RsyncProject.txt file, which will be included in the filter before the default version. Change 4260567 by Ben.Marsh UAT: Rename CommandUtils.Log to CommandUtils.LogInformation, to avoid conflicts with the underlying Tools.DotNETCommon.Log class. #rb none [CL 4285673 by Ben Marsh in Main branch]
2018-08-14 18:32:34 -04:00
LogInformation("Test complete...");
bKeepReading = false;
}
else if (Params.RunAutomationTests)
{
int FailIndex = AllClientOutput.LastIndexOf("Automation Test Failed");
int ParenIndex = AllClientOutput.LastIndexOf(")");
if (FailIndex >= 0 && ParenIndex > FailIndex && FailIndex > LastAutoFailIndex)
{
string Tail = AllClientOutput.Substring(FailIndex);
int CloseParenIndex = Tail.IndexOf(")");
int OpenParenIndex = Tail.IndexOf("(");
string Test = "";
if (OpenParenIndex >= 0 && CloseParenIndex > OpenParenIndex)
{
Test = Tail.Substring(OpenParenIndex + 1, CloseParenIndex - OpenParenIndex - 1);
LogError("Automated test failed ({0}).", Test);
LastAutoFailIndex = FailIndex;
}
}
}
// Detect commandlet failure
else if (bCommandlet)
{
const string ResultLog = "Commandlet->Main return this error code: ";
int ResultStart = AllClientOutput.LastIndexOf(ResultLog);
int ResultValIdx = ResultStart + ResultLog.Length;
if (ResultStart >= 0 && ResultValIdx < AllClientOutput.Length &&
AllClientOutput.Substring(ResultValIdx, 1) == "1")
{
// Parse the full commandlet warning/error summary
string FullSummary = "";
int SummaryStart = AllClientOutput.LastIndexOf("Warning/Error Summary");
if (SummaryStart >= 0 && SummaryStart < ResultStart)
{
FullSummary = AllClientOutput.Substring(SummaryStart, ResultStart - SummaryStart);
}
if (FullSummary.Length > 0)
{
LogError("Commandlet failed, summary:" + Environment.NewLine +
FullSummary);
}
else
{
LogError("Commandlet failed.");
}
}
}
}
else if (bClientExited && (DateTime.UtcNow - ExitTime).TotalSeconds > 30)
{
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 4285612) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3836829 by Ben.Marsh UBT: Fix ability to precompile plugins from installed engine builds. Change 3839519 by Ben.Marsh UBT: Simplify configuring bPrecompile and bUsePrecompile settings for modules. Each rules assembly can now be configured as installed, which defaults the module rules it creates to use precompiled data. Change 4042043 by Steve.Robb GitHub #4705 : Added weak lambda's for delegates and multicast delegates. Change 4042056 by Robert.Manuszewski Optimized Mark Phase of GC by up to 10ms by making it run in parallel and removing a huge array presize which we didn't need. Change 4042104 by Robert.Manuszewski Set the minimum GC cluster size to 5 so that GC doesn't have to process micro clusters which are more expensive than processing individual objects + Exposed the minimum cluster size to ini and project settings as gc.MinGCClusterSize + Added the ability to sort clusters by name/object count/mutable object count/referenced clusters count when dumping them with gc.ListClusters command Change 4042377 by Robert.Manuszewski Reworked how GC and other threads (ALT specifically) interact - GC will now notify the ALT it wants to run and ALT will immediately try to finish its current work to allow that. Also the entire ALT tick is now protected against GC running at the same time to improve ALT stability. + added gc.ForceCollectGarbageEveryFrame console variable that triggers a forced GC every frame Change 4042427 by Robert.Manuszewski Changed FGCCSyncObject to use events when waiting for GC to finish so that it doesn't spin on non-game threads when GC is running Change 4042482 by Robert.Manuszewski Unhashing unreachable objects (ConditionalBeginDestroy) will now also be done incrementally, just like the purge phase of Garbage Collection Change 4042635 by Robert.Manuszewski Fix for a potential assert when incremental purge garbage is pending and something forces a full purge Change 4044092 by Steve.Robb Fix for forward declared CoreUObject weakobject types in delegates when building in Clang. Change 4044102 by Robert.Manuszewski Fix for a possible hang when worker threads are preventing GC from running and something is later trying to FlushAsyncLoading with the Async Loading Thread enabled Change 4044113 by Steve.Robb Another Clang fix. Change 4044160 by Robert.Manuszewski Disregard For GC pool will now be enabled by default in cooked builds Change 4044287 by Steve.Robb Typo fix. Change 4047723 by Graeme.Thornton TBA: Fixes for import/export name cache and object resolving Change 4048015 by Graeme.Thornton TBA: Weak/Soft/Lazy pointer serialization changes * Remove FWeakObjectPtr::Serialize, move it's logic into, and replace usages of with calls to, FArchiveUObject::SerializeWeakObjectPtr(). Ensures that something is always sent to the archive so that structured archives can be kept happy in the future. * Added Weak/Soft/Lazy pointer handling to the structured archive slot interface and all the formatters. Binary formatters just forward the call onto their inner and text archives store as a string path reference. * FArchiveUObjectFromStructuredArchive caches all these pointer types and stores indices in the binary block, same as with a UObject*. All pointers are then forwarded to the underlying formatter in one go on finalization. Change 4048021 by Steve.Robb Fix for binding an unbound TFunction to another TFunction with a different signature. Also all null pointers now count as unbindings, not just nullptr. TIsMemberPointer added. TIsATFunction and TIsATFunctionRef renamed to remove the 'A's. Change 4048544 by Robert.Manuszewski Fixing ConditionalBeginDestroy profiling after changes to incremental CBD. Change 4051028 by Graeme.Thornton TBA: ArchiveFromStructuredArchive adapter uses Inner to determine if it is outputting to text, and sets it's own ArIsTextFormat to false Change 4051056 by Graeme.Thornton TBA: High level tagged property / UObject base class text serialization - UObject serialize converted to structured archive - Properties written to text individually with text tags, and then binary adapted values - Only saves, doesn't load Change 4051111 by Graeme.Thornton TBA: Temporarily disable loading of text assets until tagged property serialization path is fixed up Change 4051154 by Graeme.Thornton TBA: Convert a few uobject serializers to structured archive format for example purposes Change 4051181 by Graeme.Thornton TBA: Added default structured archive implementation of SerializeItem to UProperty, which just calls the FArchive version on an FArchiveUObjectFromStructuredArchive adapter. Implemented structured archive SerializeItem for UArrayProperty Change 4051197 by Graeme.Thornton TBA: ObjectProperty text serialization Change 4051216 by Graeme.Thornton Restored a modified FWeakObjectPtr::Serialize function to keep backwards compatibility in code I don't have access to. Change 4051261 by Graeme.Thornton TBA: Convert UMetaData to structured archive Change 4051374 by Steve.Robb Incorrect assert removed. Change 4051562 by Robert.Manuszewski Adding stats for the new GC internal functions Change 4051614 by Graeme.Thornton TBA: Removed UProperty::SerializeItem(FArchive, ...) and replaced with UProperty::SerializeItem(FStructuredArchive::FSlot, ...). Fixed up most of them to work properly and added adapters in for any that were non-trivial. Change 4052512 by Graeme.Thornton TBA: Temporary workaround for softobjectptr and lazyobjectptr uproperties not serialization anything when they know the archive is a reference collector. They should always be serializing their pointers and letting the underlying archive itself ignore them. Change 4053917 by Robert.Manuszewski Clustered objects from clusters that are no longer reachable will now be marked as unreachable immediately when gathering unreachable objects Change 4053919 by Robert.Manuszewski Added the ability to disable incremental BeginDestroy in ini/project settings Change 4055518 by Daniel.Lamb Fixup for deterministic audio generation issue. Submitted on behalf of Rich.Whitehouse #jira nojira #test prefilght automated test. Change 4056854 by Graeme.Thornton TBA: Added a test asset to EngineTest which contains all the different property types and test cases. Change 4056858 by Graeme.Thornton TBA: Updated USetProperty to proper structured archive usage Change 4056872 by Graeme.Thornton TBA: Add map property field to test object Change 4056873 by Graeme.Thornton TBA: Convert UMapProperty to full structured archive Change 4056994 by Graeme.Thornton TBA: Converted FText over to structured archive. Implemented saving, but not loading. Change 4059728 by Ben.Marsh UBT: Add support for using adaptive non-unity builds when the engine and project are in separate repositories. Change 4059805 by Graeme.Thornton Fixed typo in text serialization. Fixes CIS automation test errors Change 4060007 by Graeme.Thornton TBA: FArchiveFromStructuredArchive will now access it's host slot lazily, i.e. only when a value is actually written to the archive. Change 4060092 by Stefan.Boberg Added optimized Windows console window output path to GenericConsoleOutput since this slowed down cooking considerably (2 minutes spent in wprintf alone for one large dataset) When stdout is attached to a console we use the WriteConsoleW function instead of wprintf since the latter is very slow especially in unbuffered mode which the engine currently configures for stdout (see setvbuf call in LaunchEngineLoop.cpp). At some point we should reconsider this buffering policy since it's likely to slow down other platforms as well but I wanted to do a safe change for now as I don't yet fully understand why the setvbuf call is there in the first place. Change 4060108 by Stefan.Boberg Introduced some additional target platform utilities to help with asset cook optimizations * We now assign each ITargetPlatform a zero-based ordinal value * Introduced FTargetPlatform and FTargetPlatformSet types to help store platform references and platform sets efficiently. These are not currently used in the engine but are designed to replace the existing ITargetPlatform/string/FName representations in the cooking data structures. Change 4060143 by Graeme.Thornton Undo //UE4/Dev-Core/Engine/Source/Runtime/... changelist 4060007 Needs some other changes that I haven't checked in yet... Change 4062432 by Ben.Marsh Fix error message when enumerating P4 changes. Change 4062648 by Ben.Marsh Add missing p4 integration action. Change 4063620 by Graeme.Thornton Integrated a fix from UDN where the engine would crash when trying to load a very small encrypted file (<16bytes) from a pak file, where the read address wasn't already aligned to the AES block size. (https://udn.unrealengine.com/questions/431989/crash-while-reading-a-very-small-file-in-encrypted.html) Change 4066963 by Robert.Manuszewski Fixing GC cluster verification code reporting false positives when a cluster is referencing another cluster through 'mutable' objects list. Change 4067133 by Robert.Manuszewski Changed log verbosity when reporting individual cases of GC cluster assumption violations as they are followed by an asser anyway and this way we get the chance to see all issues before we assert at the end of these checks. Change 4067443 by Steve.Robb FString can now be constructed from any char pointer type and length. Change 4068156 by Steve.Robb Fix necessary because of FString constructor change in CL# 4067443. Change 4070258 by Graeme.Thornton Fixes for VSCode Change 4070372 by Graeme.Thornton TBA: Script struct serialization to structured archives Change 4071913 by Ben.Marsh Move bulk of the code for UnrealPak into an engine developer module, so it can be used in the editor. Change 4071914 by Ben.Marsh Missing files. Change 4071937 by Ben.Marsh Missing header. Change 4072015 by Ben.Marsh Fixes for compiling PakFileUtilities as part of the editor. Change 4072826 by Steve.Robb TBitArray::Reserve() added. TBitArray::Add() overloaded to allow adding multiple bits. TSparseArray::Reserve() optimized to call the overloaded Add(). Change 4073271 by Daniel.Lamb Fixed add patch tier in project launcher passing the wrong commandline option to UAT. #test none Change 4074708 by James.Hopkin #core Removed redundant Casts Change 4074763 by Steve.Robb Fix for TSparseArray::Reserve() size. Change 4076063 by Ben.Marsh Add an "UnrealPak" commandlet with the same functionality as the standalone UnrealPak program. Invoke by running the editor with -run=UnrealPak and the standard UnrealPak commandline options. Change 4077064 by Robert.Manuszewski Fixing compile error in PakFileUtilities Change 4077144 by Graeme.Thornton TBA: TextAssetCommandlet improvements * Collect lists of broken assets during roundtrip tests and print a summary of packages that failed each phase at the end * After resaving as text, load the file back as a plain JSON hierarchy to ensure the output was valid Change 4077412 by Ben.Marsh Set the correct exit code for UnrealPak. Should return 0 on success, not 1. Change 4077760 by Graeme.Thornton TBA: Loading fixed for tagged property serialization Includes conversion of all UProperty::ConvertFromType() and SerializeFromMismatchedTag() functions to use structured archives Lazy initialization of FArchiveFromStructruredArchive when loading, to support the possibility of an adapter being create around an object property serialize call to its inner UStruct, which then decides not to do anything and return false. Stops the ArchiveFromStructuredArchive from consuming the slot and getting upset later on when we try to serialize normal tagged properties from it. Disabled lazy bulk data loading from text assets. Requires a bigger change to make it work. Added some debug checks to json input formatter which track the current value stack size when a new object is pushed onto the stack, and makes sure that the stack has returned to the same size when the object is popped. Catches cases where we unpack an array/stream to the value stack but then don't consume all the items. Change 4078800 by Ben.Marsh Change UAT to using the editor's UnrealPak commandlet rather than invoking the standalone UnrealPak executable. To improve performance when building several PAK files, also add a new -batch=<file> command which reads commands to execute in parallel from a text file. Change 4079745 by Graeme.Thornton TBA: Migrated a couple of UObject Serialize functions to FStructuredArchive (SoundCue / MaterialExpressions / Editor strip flags) Change 4079847 by Graeme.Thornton TBA: Add 'FindMismatchedSerializers' mode to text asset commandlet, which dumps out a list of all UClasses which don't have the CLASS_MatchedSerializers flag, meaning we can't guarantee the have Serialize functions for FArchive AND FStructuredArchive, therefore we can't use the new structured archive based serialize path. Should only ever be native instrinsic classes as UHT takes care of all other cases. Change 4079925 by Ben.Marsh Fix incorrect assignment when deriving name for chunked pak file. Change 4080214 by Ben.Marsh Move the ThreadPoolWorkQueue class into DotNETUtilities so it can be used by other projects. Change 4082394 by Graeme.Thornton CIS fix for variable shadowing warning Change 4082583 by Ben.Marsh Add a IBinarySerializable interface for types that support reading from a BinaryReader and writing to a BinaryWriter. Implementing IBinarySerializable implies a constructor taking a BinaryReader argument is available for deserializing. Change 4082652 by Ben.Marsh Fix FileReference.Directory not returning a directory with a trailing backslash for files in the root directory. Change 4082755 by Graeme.Thornton Fixed an erroneous usage of TUniquePtr<uint8>as a pointer to a uint8 array when creating pak files. Caused a crash when compression was enabled, and has probably surfaced because pak generation is now done by an editor commandlet rather than a standalone program. Change 4082756 by Graeme.Thornton Fixed some incorrect documentation for pakfile compressed chunk headers Change 4082883 by Graeme.Thornton Static analysis warning fix Change 4082912 by Ben.Marsh Move ExceptionUtils into DotNETUtilities. Change 4085291 by Graeme.Thornton TBA: In the Json output formatter, write float and double values out with enough precision for successful roundtripping. Added some debug only code which will immediately reconvert the string back to its original value and compare the the input Change 4085523 by Graeme.Thornton TBA: Remove only explicit usage of DECLARE_FSTRUCTUREDARCHIVE_SERIALIZER. Should only be used from UHT generated code. Change 4086037 by Robert.Manuszewski Fix for a potential race condition when two threads want to acquire GC lock Change 4088655 by Graeme.Thornton Pak creation now uses the bEnablePakSigning setting from the crypto config json file Change 4091474 by Steve.Robb Fix for TStaticBitArray::FindFirstSetBit() and TStaticBitArray::FindFirstClearBit(). Unused variables removed. Change 4093632 by Steve.Robb CIS fixes. Change 4093656 by Graeme.Thornton Build fix Change 4093744 by Ben.Marsh Allow per-chunk settings for whether to enable compression in UnrealPak. Change 4099712 by Gil.Gribb UE4 - Fixed rare case where insufficient space was preallocated for cooldown ticks. #jira UE-59686 Change 4099912 by Stefan.Boberg Cooking timer optimizations: - Replaced data structures for FScopeTimer and FHierarchicalTimerInfo. Previous implementation used FString for many things and caused *lots* of heap and string concatenation activity. Replaced with a compile-time node id (using __COUNTER__) and raw string literals. - Removed PERPACKAGE_TIMER support (was disabled by default and was difficult to test) - Made it possible to toggle OUTPUT_TIMING and ENABLE_COOK_STATS independently - Removed some extremely tight timers because the overhead from calling QPC significantly exceeded the measured code This change shaved some 15% off a clean cook of Fortnite WindowsClient (en) with fully populated local DDC Change 4100519 by Stefan.Boberg Quick fix for Linux build issue introduced in 4099927 Change 4105327 by Stefan.Boberg Cooker: Changed FHierarchicalTimerInfo so it uses a linked list for tracking child nodes, to be able to deal with any child count. Previously we assumed there would never be more than 9 children but it turns out there are cooker modes that need more. Fixes check when using -FullLoadAndSave to cook Change 4105448 by Stefan.Boberg - Fixed Linux build warning re: member initialization order - Also eliminated OUTPUT_HIERARCHYTIMERS/CLEAR_HIEARCHYTIMERS macros (plain functions are fine) - Moved finishing-up code for FullLoadAndSave() to TickCookOnTheSide() call site to improve timer output. Previously some of the scopes would not have been closed before printing and thus the output was misleading. Change 4109031 by Ben.Marsh Attribute-driven Perforce wrapper (old Epic Friday project). Offers a more complete implementation than the current P4 wrapper in UAT without requiring any platform-specific libraries. Uses the Python binary output for parsing. Change 4109588 by Ben.Marsh UBT: Add extension methods for serializing a nullable type to a BinaryReader/BinaryWriter. Change 4109595 by Ben.Marsh Missing project file for DotNETUtilities. Change 4110724 by Stefan.Boberg Removed annotation map locking in UObjectMarks, eliminating around one minute (~3.5%) from Fortnite cook time. The locking was redundant since the annotation maps are managed per thread anyway. Change 4111304 by Ben.Marsh UAT: Add support for setting a status message through the log class. Allows writing transient messages (eg. progress messages) which will be cleared out before writing other messages. Best used through the LogStatusScope class, which can set a status message for the duration of a using() block. As part of this change, the console no longer has to be added as a dedicated trace listener. Since we already special-case this listener when formatting log output, it's easier to just keep the implementation separate to the other trace listeners. Change 4112708 by Steve.Robb Fix for TBitArray::MaxBits in assignment. Change 4114133 by Stefan.Boberg Tweaked how low-level memory (LLM) tracker is implemented to reduce overheads. Previously FMemory functions would acquire the LLM singleton and call OnLowLevelFree/OnLowLevelAlloc etc which would check the bIsDisabled flag and early out if it was set. Due to how frequently these functions were called this ended up costing quite a bit. - This change makes the flag a static member variable instead of a member variable and therefore enables a simpler early-out to be implemented. - The singleton getter is also simplified to avoid hitting the threadsafe singleton construction path on every call. - The enable flag is no longer TAtomic - this also incurs extra overhead for no clear benefit Shaves approximately 3.5% (one minute) off a Fortnite cook test scenario (using -FullLoadAndSave) Change 4115010 by Robert.Manuszewski Fixing CIS Change 4115249 by Robert.Manuszewski Fixing async loading code asserts when exiting game very early due to an error #jira UE-56267 Change 4117091 by Ben.Marsh Prevent doubled-up lines when writing status updates with console log verbosity. Change 4117207 by Ben.Marsh UGS: Do not include executables in diagnostics zip file, and ignore "no such files" error when cleaning workspace. Change 4119175 by Ben.Marsh UGS: Fix crash writing version files when directory does not already exist. Change 4119987 by Ben.Marsh UGS: Show a dialog box while the launcher is updating executables from Perforce, which allows cancelling the operation if necessary. Allow setting the username on the settings window, and prompt for login credentials if necessary. Should prevent situations where users have to update settings from the command prompt. Holding down shift during launch now shows the settings dialog rather than an immediate prompt to launch the unstable version (unstable version is shown as a checkbox on this dialog). Change 4119991 by Ben.Marsh Update version number for UGS launcher to 1.13. Change 4121943 by Robert.Manuszewski Don't use FArchiveAsync2 for reading packages with non-async path in editor builds as its performance is worse than the standard archive's (saves about 1 minute when doing larger cooks and 7 seconds when loading into PIE) Change 4122592 by Steve.Robb GitHub #4762 : Improve wording and grammar of Math comments Also includes improved accuracy in FMath::ComputeBoundingSphereForCone(). Change 4122819 by Stefan.Boberg Don't call CreateDirectory redundantly when opening files for writing using FFileManagerGeneric::CreateFileWriter This change avoids calling IPlatformFile::CreateDirectoryTree if possible since this is a very expensive function especially for deep hierarchies as it performs directory creation from the root directory onwards instead of from the leaf downwards. That function should also be fixed but this change improves performance in the meantime. Change 4122872 by Stefan.Boberg CreateDirectoryTree now creates directories leaf-to-root instead of the other way around. This is much more efficient since we don't spend time on system API calls for directories which already exist. This accounted for a very large amount of CPU time in cooking as the full target file directory hierarchy would be "created" for every single output file. Change 4123109 by Stefan.Boberg - Disable overlapped I/O in editor / cooker. Synchronous I/O reduces the number of syscalls and Windows performs prefetching on our behalf anyway for sequential reads - Eliminated syscall which was issued for every write to update cached file size -- since we're the only writers to the file (file access allows read sharing at most) we can authoritatively update the file size on write completion Change 4123455 by Ben.Marsh PR #4775: New build param PCHMemoryAllocationFactor to set /Zm VS build param. (Contributed by lucaswall) Change 4124207 by Ben.Marsh UBT: Remove some unnecessary indirection for generated code paths. Change 4124217 by Ben.Marsh UBT: Remove another unused variable from UEBuildModuleCPP. Change 4124377 by Stefan.Boberg In IPlatformFile::DeleteDirectoryRecursively, attempt to delete file first and if it fails clear the readonly flag and try again Previously there was a call to clear the readonly flag for every deleted file and this is a waste of resources 99% of the time. The SetFileAttributes call accounted for a significant amount of time during cooker sandbox directory deletion Change 4125071 by Stefan.Boberg Some tweaks to FQueuedThreadPoolBase scheduling and memory management - Explicitly pass in false for TArray::RemoveAt(..., bool bAllowShrinking) argument to prevent memory reallocation when arrays are drained and inevitably repopulated shortly afterwards - Use a MRU strategy instead of LRU when picking a thread to wake up. The MRU thread is the most likely to have a 'hot' cache for the stack etc. Picking from the back of the array also happens to be cheaper since no memory movement is necessary when RemoveAt is called. (This was the strategy in place before CL2600362 which seems to have changed it unintentionally) - Release lock as soon as a thread has been chosen, before asking the worker thread to wake up and do the work Change 4126132 by Ben.Marsh UAT: Detect when stdout is redirected and prevent using backspace characters to move the cursor. Change 4126867 by Graeme.Thornton TBA: Fix tagged binary formatter Change 4127010 by Robert.Manuszewski AnimScriptInstances created at runtime will now also be added to the owning omponent's cluster to avoid GC issues. Change 4127932 by Ben.Marsh WorkspaceTool: Reduce unnecessary logging of status messages when console output is not redirected. Change 4129050 by Ben.Marsh UGS: Check for NET Framework 4.5 being installed before running the installer. Also fix warning trying to kill existing UGS instances before upgrade. Change 4129459 by Graeme.Thornton TBA: TextAssetCommandlet - When outputting converted assets to an output path, replicate the workspace relative path in the output directory Change 4129515 by Graeme.Thornton TBA: Add EnterRecord overload that allows outputting of available field names when loading. Change 4129517 by Graeme.Thornton TBA: Tagged properties are written out as named fields on the "Properties" record, rather than as a stream with a null tag at the end Change 4129518 by Graeme.Thornton TBA: Added a local const bool to allow easy hacking out of text asset loading support Change 4129558 by Graeme.Thornton TBA: Build fix for textasset-less configs Change 4129614 by Ben.Marsh UGS: Main window is now restored to normal size when activated by clicking on the tray icon. #jira UE-60490 Change 4129618 by Ben.Marsh UGS: Speculative fix for unreproduced exception accessing disposed window while shutting down. Change 4131936 by Robert.Manuszewski Removing some WIP code accidentally checked in with CL #4121943 Change 4133490 by Ben.Marsh UGS: Allow the $(Change) variable to be used in more places than just the context menu. #jira UE-60573 Change 4133550 by Ben.Marsh UGS: Setting for whether or not to use incremental builds is now exposed through the variable "$(UseIncrementalBuilds)" for use by custom build steps. #jira UE-60554 Change 4133681 by Ben.Marsh UGS: A per-project list of folders and extensions to be deleted by default when running the 'clean workspace' tool can now be specified through the <ProjectDir>/Build/UnrealGameSync.ini file. Settings may be specified for an individual branch (via a category with the depot path to the project) or for wherever the project is currently open (via the [Default] category). The SafeToDeleteFolders list specifies a substring that will be checked against folder paths. Anything containing this folder will be marked as safe for delete by default. The SafeToDeleteExtensions list specifies a list of extensions for files that can always be deleted. Example: [Default] +SafeToDeleteFolders=/MyGame/Test/ +SafeToDeleteFolders=/DataService/ +SafeToDeleteExtensions=.xx1 +SafeToDeleteExtensions=.xx2 #jira UE-60575 Change 4135449 by Ben.Marsh Fix allowing use of Job objects on Windows platforms (debug code submitted by mistake) Change 4135730 by Ben.Marsh UBT: Plugins can now be enabled and disabled from the .target.cs file (for targets that do not use the shared compile environment), by compiling the list of enabled/disabled plugin names into the Projects module. Change 4135823 by Ben.Marsh UBT: Remove legacy code to handle disabling optional plugins; now that this is compiled into the target, it will work for any plugins we choose. Change 4135945 by Ben.Marsh UBT: Fix error running programs with no explicitly enabled or disabled plugins. Change 4137207 by Ben.Marsh UGS: Align all badges with the same name, to make it easier to see which CIS steps are being run. Allow overriding the slot taken by a particular badge by calling it "SlotName:LabelName". Change 4137311 by Stefan.Boberg Removed child cooker support. In practice it is not a useful feature as it provides no performance improvement (quite the opposite in fact) and adds testing and maintenance complexity. Change 4137393 by Ben.Marsh UGS: Fix display of multiline errors in the status panel. Change 4141708 by Steve.Robb GitHub #3631 : Incorrect default argument in WeakObjectPtrTemplate #jira UE-45490 Change 4146655 by Stefan.Boberg Removed FullGCAssetClasses logic - no longer necessary nor useful Change 4147318 by Ben.Marsh UGS: Compress build badges in a column if it shrinks below the size that they would be visible. Change 4148207 by Ben.Marsh UGS: Added support for showing the latest completed build from a specific list of badges in the status panel. To declare a badge as one that should appear in the status panel rather than the CIS column, add it to the project's UnrealGameSync.ini in the project or [Default] section like so: +ServiceBadges=RoboMerge Change 4148282 by Stefan.Boberg Fixed bug in UCookOnTheFlyServer::GetCookOnTheFlyUnsolicitedFiles - UnsolicitedFiles should be passed by reference not by value Change 4148344 by Stefan.Boberg Fixed minor indentation error (most likely caused by sloppy merge) Change 4148521 by Stefan.Boberg Removed accidentally checked in PRAGMA_DISABLE_OPTIMIZATION from CookOnTheFlyServer.cpp Change 4148639 by Ben.Marsh UGS: Fix tooltips not showing for changes that have description badges. Change 4149373 by Ben.Marsh UGS: Allow adding additional columns to display particular badges by adding entries from the project config file. Example syntax: +Columns=(Name="Desktop",MinWidth=50,DesiredWidth=100,Weight=3,Badges="Editor") +Columns=(Name="Mobile",MinWidth=50,DesiredWidth=100,Weight=3,Badges="IOS,Android") Same form can be used to control how default columns are displayed (though badge settings are ignored). Also allow PerforceMonitor to detect local changes to project config files and update settings automatically. Change 4149399 by Ben.Marsh UGS: Update version to 1.143. Change 4155660 by Steve.Robb PROJECTION and PROJECTION_MEMBER macros which provide the correct behavior when creating projections using functions which are overloaded or use default arguments. Change 4157117 by Ben.Marsh Fix warning due to plugins disabled in .target.cs file. Change 4158011 by Ben.Marsh UBT: Add a check that the UnrealHeaderTool target file exists, rather than throwing an exception when reading it fails. Change 4158646 by Ben.Marsh UGS: Fix exception when login is discovered to have expired during a workspace update. Change 4158678 by Ben.Marsh UGS: Fix an exception on shutdown due to the icon being hidden after it's already been disposed. Change 4158683 by Ben.Marsh UGS: Add an unhandled exception filter which sends the exception data to the backend. Change 4159131 by Ben.Marsh UGS: Reduce the number of characters displayed for build badges based on the available space. Change 4159194 by Graeme.Thornton TBA: Fix incorrect map property conversion code when converting an old property that contains a map with different key/value types Change 4159239 by Steve.Robb Improved readability and compliance with coding standards. Change 4159246 by Ben.Marsh UGS: Allow syncing projects where source code is not available (and various version files don't exist). #jira UE-60985 Change 4159286 by Ben.Marsh UGS: Remove requirement for UE4Editor.target.cs to be visible in the depot in order to open a project. #jira UE-60986 Change 4159302 by Ben.Marsh UGS: Update version to 1.144. Change 4160308 by Ben.Marsh All staging client executables for blueprint projects. #jira UE-60983 Change 4161567 by Steve.Robb GitHub #4816 : UE-60771: Handle escaped double quote in FParse::LineExtended Change 4162641 by Ben.Marsh UGS: Allow customizing the position of custom columns, via the Index=N attribute. Change 4162647 by Ben.Marsh UGS: Update version to 1.145. Change 4165319 by Robert.Manuszewski PR #4812: Fix inconsistent command-line argument handling under Windows (Contributed by adamrehn) Change 4166150 by Ben.Marsh UGS: Include *.inl when looking for code changes. Change 4166551 by Steve.Robb Whitespace fixes caused by a bad merge. Change 4168483 by Ben.Marsh UGS: Add a more useful error if a file to be synced exceeds the max allowed path length. Change 4168490 by Ben.Marsh UGS: Update version to 1.146. Change 4168551 by Ben.Marsh UBT: Move bBuildLargeAddressAwareBinary into an exposed setting. Change 4168560 by Ben.Marsh UBT: Remove static config variable for controlling which configuration of UHT to use. Change 4171296 by Ben.Marsh UGS: Move the check for overlong paths earlier. Change 4171531 by Ben.Marsh UBT: Fix exception if BuildConfiguration.xml contains an unknown category. Change 4183371 by Robert.Manuszewski Fix for a crash in Async Loading Graph's CheckCycles when GC kicks in on the game thread and forces ALT to exit early Change 4184312 by Ben.Marsh UGS: Update version to 1.148 Change 4184480 by Robert.Manuszewski Removing unused async loading stat Change 4186390 by Ben.Marsh UBT: Format XML validation errors in a format that allows double-clicking on the message in Visual Studio. Change 4188644 by Ben.Marsh UBT: Add the MakePathSafeToUseWithCommandLine() function to UBT. Change 4188647 by Ben.Marsh UBT: Fix exception in target receipt when architecture is null. Change 4189617 by Ben.Marsh Change FileSystemReference, FileReference and DirectoryReference objects to use OrdinalIgnoreCase comparisons without creating a separate copy of the string to compare. The filesystem does not use the invariant culture, and it can produce the wrong results in some cases (the ordinal comparison is faster, too). Change 4189740 by Ben.Marsh UAT: Remote code to build UnrealPak when packaging; we use the editor now. Change 4189860 by Ben.Marsh UGS: Make the filter for excluding automated lighting rebuilds more explicit. Change 4190082 by Ben.Marsh Fixes to allow enabling edit and continue for Windows builds. Have experienced quite a few VS crashes when testing it in editor; not yet recommended for general use. - Allow edit and continue for any configuration, not just debug. - Fixed PDB errors compiling files that use a shared PCH with edit and continue enabled. Path to the generated PDB file was using the wrong directory. - Removed code that tracks PDB output files, since they're modified multiple times during a build. - Enable debug information when compiling generated CPP files, since it causes errors if the shared PCH PDB doesn't have the same option. - Disable support for remote execution of steps that modify the PDB, since the same file has to be modified many times. Remote execution causes the PDB files to be corrupted. Unfortunately, this makes E&C builds significantly slower. #jira Change 4192949 by Ben.Marsh UBT: Minor tidy-up (merging UEBuildBinary.Build and UEBuildBinary.SetupOutputFiles) Change 4193218 by Ben.Marsh Fix formatting. Change 4197252 by Mike.Erwin UAT: Fix log output w/ correct count of non-code projects. #jira none Change 4197941 by Ben.Marsh UGS: Add support for DebugGame editors that have an executable with a DebugGame suffix. Change 4197964 by Ben.Marsh UGS: Prevent attempts to automatically reopen projects while a modal dialog is up, or the workspace is syncing. Change 4198144 by Ben.Marsh UGS: Prevent modal dialogs when login expires in P4, and prompt for password when hitting "retry". Change 4198413 by Ben.Marsh UGS: Always show the main window when launched manually, and run with -RestoreState when launched at startup. Also add a couple more places that save the visibility state, since logging off seems like it can terminate the process abrubtly. Change 4198779 by Ben.Marsh UBT: Allow generating manifests to any arbitrary locations with the -Manifest=<Path> argument. Change 4198825 by Ben.Marsh UBT: Move code to enumerate Slate runtime dependencies into the Slate module. Doesn't need to be done inside core UBT. Change 4199341 by Ben.Marsh UGS: Update version to 1.149 Change 4199642 by Chad.Garyet - Deprecate CISController - Add BuildController to replace CIS GET/POST for builds - Add LatestController, GET does what CIS/GET used to do - Change Latest/GET to return the last 25 builds filtered by project, rather than the last 5000 individual Ids - Latest/GET now returns "LatestData" object instead of array of longs - Updated EventMonitor to match all API changes - Fixed bug where IDs were getting reset to initial startup values every update loop Change 4199663 by Chad.Garyet CIS controller still needs to return an array of longs #jira none Change 4199680 by Ben.Marsh UGS: Update version to 1.150 Change 4200457 by Ben.Marsh Merging CIS fix for non-development configurations. Change 4200472 by Mike.Erwin UAT: fix -skipbuildclient param default It was defaulting to skipbuildeditor's value, likely a copy-paste error. #jira none Change 4202595 by Ben.Marsh Fix static analysis warning due to constant comparison against macro. Change 4203250 by Ben.Marsh UGS: Always show the "Sync Precompiled Editor" option, but disable it and show a tooltip explaining why if it is not available. Change 4206191 by Ben.Marsh Exclude editor target files from installed builds, since they leak info about DLLs that have been stripped out. Change 4213011 by Ben.Marsh UBT: Include contents of modified intermediate files in the log, to make it easier to debug hidden dependencies. Change 4213487 by Ben.Marsh UBT: Fix assumption that bPrecompile is equivalent to bBuildAllModules. This is no longer the case; they are now controlled by separate options. Should fix CIS errors building the editor. Change 4213609 by Ben.Marsh Ensure that strings formatted using FMicrosoftPlatformString::GetVarArgs() are always null terminated, whether we use the secure CRT or not. Change 4215971 by Ben.Marsh UBT: Remove action graph visualization code; no longer used. Change 4215996 by Ben.Marsh UBT: Remove unqiue id from all actions in the action graph. This is only used for printing debug info in the case of a (rare) cycle in the action graph, so just look it up when needed. Change 4216022 by Ben.Marsh UBT: Rename Crypto.cs to EncryptionAndSigning.cs to match the name of the class inside it, and move it under the System folder. Change 4216031 by Ben.Marsh UBT: Move all the action executors into their own folder in the project. Change 4216526 by Ben.Marsh Fix CIS warnings. Change 4216544 by Ben.Marsh Replace custom code to ensure FMicrosoftPlatformString::GetVarArgs() null terminates its buffer with Microsoft's standards-compliant implementation. Change 4216633 by Ben.Marsh Add support for UnrealPak plugins. * Project and plugin modules can now specify an array of supported programs in the "WhitelistPrograms" field of their module descriptors, to allow modules to be loaded by programs. * Programs can now load any runtime modules, as long as they are whitelisted. * Programs under the engine directory can now use a shared build environment, so that building with a project file does not cause output binaries to be output to the project directory. * UnrealPak is now always built by default when packaging * Convert UnrealPak to a modular configuration Change 4216736 by Ben.Marsh UnrealPak: Move "ExportDependencies" command into an editor commandlet, since it relies on the UObject system, asset registry, etc... Change 4217447 by Ben.Marsh Back out revision 50 from //UE4/Dev-Core/Engine/Build/InstalledEngineBuild.xml Change 4217451 by Ben.Marsh Back out revision 11 from //UE4/Dev-Core/Engine/Plugins/Developer/VisualStudioSourceCodeAccess/Source/VisualStudioSourceCodeAccess/VisualStudioSourceCodeAccess.Build.cs Change 4217617 by Ben.Marsh Back out changelist 4217451 Change 4222552 by Ben.Marsh Don't use #import <TypeLib> for VS source code accessor when building with Clang; it's not supported. Change 4222630 by Ben.Marsh UBT: Fix spam while generating project files if Clang isn't installed. Change 4223316 by Ben.Marsh UBT: Change the order in which Visual C++ toolchains are enumerated to prefer full releases over preview releases. Change 4223318 by Ben.Marsh UBT: Add a build setting which allows creating a dedicated PCH for every file that's excluded from the unity working set (disabled by default). Improves iteration times when working on individual cpp files, but slows down iterating on header changes (and can take a lot of disk space for large changes). Dedicated PCH contains all includes scraped from the top of each cpp file, until a non-#include directive is encountered. Change 4223401 by Ben.Marsh UBT: Add an option to automatically enable edit and continue for files in the adaptive non-unity working set. E&C doesn't seem very useful for UE4 projects right now; compile time is comparable to regular build times, but it can take several minutes to apply code changes for large projects. Change 4223899 by Ben.Marsh UBT: Fix loading XML config files on Mono; Type.GetField(Name) does not seem to return values unless binding flags are specified. Change 4224637 by Ben.Marsh Add a "SupportedPrograms" field to plugin descriptors, which allows plugins to declare which plugins they support independently of individual modules. Programs now respect the "bEnabledByDefault" setting in plugins. Plugins that are compatible with a program now need to list that program in the SupportedPrograms list, and whitelist any modules that should load for that program. Change 4224710 by Ben.Marsh UBT: Don't add import libraries as final build products unless the target is being precompiled. Prevents the need for building them for leaf nodes in the action graph. Change 4224715 by Ben.Marsh UBT: Remove hack to allow Stats2.cpp to not follow IWYU convention. Change 4224726 by Ben.Marsh Remove commented out line. Change 4224903 by Ben.Marsh Fix non-unity compile error in Stats2.h. Change 4225051 by Ben.Marsh Back out changelist 4224710; causing CIS errors due to receipts not matching. Change 4225134 by Ben.Marsh Fixing non-unity errors. Change 4225203 by Ben.Marsh Another non-unity fix. Change 4225249 by Ben.Marsh Fix Linux dependencies being copied for the Windows editor; they can be added as requirements for the Linux target platform on Windows instead, so it respects the user's chosen platforms. #jira UE-62001 Change 4225512 by Ben.Marsh BuildGraph: Allow setting the target to build when using the <CsCompile> task. Change 4228815 by Ben.Marsh UBT: Always add the generated code directory to the list of include paths when generating project files. It may only be created after UHT has been run. Change 4228944 by Ben.Marsh UBT: Remove legacy CppCompileEnvironment and LinkEnvironment wrappers from TargetRules that were deprecated in 4.19. Change 4229028 by Ben.Marsh UBT: Fix editor targets with unique build environment having the wrong executable path in generated project files. Move move logic to configure target rules post-construction by the rules assembly to ensure it's valid. Change 4229065 by Ben.Marsh UBT: Move another target setting into the rules assembly. Change 4229105 by Ben.Marsh Fix BPT exception when generating project files. Change 4229311 by Ben.Marsh UBT: Store the module rules file location on the ModuleRules instance, as well as the plugin that it was created from. Also expose the plugin directory as a property on the ModuleRules instance. Change 4229421 by Ben.Marsh UBT: Consolidate functionality for UHT module setup in ExternalExecution.cs. Change 4229817 by Ben.Marsh UBT: Modules must now explicitly specify the path to the header used to generate a PCH if one is desired, rather than the header being determined automatically by attempting to parse the source code. Now that PCHs are force-included anyway, this removes a lot of dependencies inside UBT. Change 4229824 by Ben.Marsh UBT: Remove unused lists inside UEBuildModuleCPP.SourceFilesClass. Change 4229841 by Ben.Marsh UBT: Remove some legacy code from auto-detecting PCHs. Change 4230521 by Ben.Marsh UBT: Add utility functions to the log class to allow formatting errors and warnings in Visual Studio output format (eg. File(Line): warning: Message) Change 4230871 by Ben.Marsh UAT: Remove StreamUtilis utility class; there is a simpler way to implement the one place it's used. Change 4230882 by Ben.Marsh UAT: Add StreamUtils back into UAT, seems like it's still used there. Change 4230896 by Ben.Marsh UBT: Remove some redundant parameters from UEBuildModule/UEBuildModuleCPP/UEBuildModuleExternal constructors. Change 4231014 by Ben.Marsh WorkspaceTool: Include a dump of raw bytes when garbage is read from the P4 process, for diagnostic purposes. Change 4231032 by Ben.Marsh Fix CIS. Change 4231096 by Ben.Marsh Bump the FlatCPPIncludeDependencyCache version, to prevent errors trying to load old files. Change 4231446 by Ben.Marsh UBT: Added support for expanding UE-specific variables in include paths and library paths: $(EngineDir), $(ProjectDir), $(PluginDir), $(ModuleDir). Change 4231460 by Ben.Marsh Modules may now explicitly specify rpaths on Linux via the PublicRuntimeLibraryPaths and PrivateRuntimeLibraryPaths properties. Change 4233909 by Robert.Manuszewski PR #4779: Reason fails as the supplied variable is incorrect (Contributed by projectgheist) Change 4233910 by Ben.Marsh Enable PCHs on IOS. Reduces build time by ~25%. Change 4234176 by Ben.Marsh UBT: Add better messaging for modules that need to have a private PCH set. Now detects the likely PCH using the same method as legacy code and includes it as a suggestion. Change 4234193 by Ben.Marsh Add the Delete command to Perforce wrapper in DotNETUtilities. Change 4234688 by Ben.Marsh UBT: Simplify handling of installed/precompiled builds. Settings for whether a folder is installed/read-only or not is now stored on the RulesAssembly instance, allowing multiple things to be configured separately and stacked together (eg. engine/enterprise/project). RulesAssembly.IsReadOnly() allows determining if a flie can be modified or not and replaces many previous IsXXXInstalledCalls(), and traverses the chain of assemblies. Change 4234711 by Ben.Marsh UBT: Runtime dependencies can now be copied to output directories as part of the build. When adding a runtime dependency, an optional source location can be specified to copy from. Both the source and target paths can use variables can be used as part of the path, eg. $(OutputDir), $(ModuleDir), $(PluginDir). Example usage (from a .build.cs file): RuntimeDependencies.Add("$(OutputDir)/Foo.dll", "$(PluginDir)/Source/ThirdParty/Foo.dll", StagedFileType.NonUFS); Change 4234872 by Ben.Marsh Expose a flag for whether the engine is installed, to fix issues generating project files. Change 4234929 by Ben.Marsh Fix null reference generating receipts when UBT makefiles are active. Change 4235883 by Chad.Garyet Merging 4231245 to core Giving Coordinator its own sln. This should fix what 4158155 was supposed to. #jira UE-61955 Change 4236075 by Ben.Marsh CIS fix Change 4237066 by Robert.Manuszewski Fix for a potential crash when terminating the engine while it's being initialized #jira UE-60545 Change 4237078 by Robert.Manuszewski The engine will no longer be resetting all linkers causing massive load times when renaming the world package when entering Play In Editor Change 4237116 by Ben.Marsh Rewrite some Windows utility functions to support paths longer than MAX_PATH. Change 4237158 by Ben.Marsh Add const TCHAR* overloads of FString::RemoveFromStart() and FString::RemoveFromEnd(). Change 4237159 by Ben.Marsh Fix FWindowsPlatformFile::GetFilenameOnDisk() support for paths longer than MAX_PATH, and simplify some of the other long path functions to avoid copying string buffers. Change 4239050 by Ben.Marsh Missing file Change 4239318 by Ben.Marsh Linux CIS fix. Change 4239685 by Ben.Marsh Static analysis CIS fix. Change 4240800 by Ben.Marsh WorkspaceTool: Include the full command line in the log for any P4 commands. Change 4240903 by Ben.Marsh PR #4909: Update copyright notices to 2018 (Contributed by projectgheist) Change 4241025 by Ben.Marsh UBT: Exclude mobile pipeline caches from generated project files. Causes huge slowdown when using 'Find in Files' through the IDE. Change 4241770 by Ben.Marsh UBT: Include action number in parallel executor output. #jira UE-62032 Change 4243469 by Ben.Marsh TBA: Merge FAnnotatedStructuredArchiveFormatter with FStructuredArchiveFormatter. Any functions that are only implemented for text archives now have a _TextOnly suffix, and are exposed through the FStructuredArchive interface. Change 4245723 by Robert.Manuszewski Fixing another creash when terminating the engine while initializing. #jira UE-60545 Change 4245862 by Steve.Robb VectorLoadFloat2(Ptr) added, which loads { Ptr[0], Ptr[1], Ptr[0], Ptr[1] } into a VectorRegister. Change 4246412 by Robert.Manuszewski The warning 'Calling StaticLoadObject during PostLoad may result in hitches during streaming' will now also report the object which had the PostLoad called on it when StaticLoadObject call happened. Change 4246612 by Ben.Marsh UBT: Fix spelling of "Intellisense". Change 4249454 by Robert.Manuszewski Added extra checks to catch scenarios where the EDL Precache Buffer is flushed before a package header is fully read Change 4249513 by Robert.Manuszewski Made sure the Async Loading Thread doesn't continue running after creating new async packages when garbage collector wants to run on the game thread Change 4255207 by Ben.Marsh UGS: Add additional logging whenever a P4 command fails, and when the user is logged out. Change 4255288 by Ben.Marsh PR #4921: Honor ModuleRules' bEnableExceptions flag when creating precompiled h. (Contributed by surakin) Change 4256422 by Ben.Marsh UBT: Add an error if a module referenced by a plugin descriptor doesn't exist. Change 4257385 by Robert.Manuszewski Creating new objects from within ForEachObjectWithOuter will now result in a fatal error as it's unsafe to change internal UObject hash tables when iterating over them. Change 4257454 by Robert.Manuszewski Added the option to filter clusters listed with gc.ListClusters by objects within them. Usage: gc.ListClusters Hierachy With=ObjectName1,ObjectName2... Change 4257526 by Robert.Manuszewski It's now possible to filter clusters that get logged with verbose cluster logging enabled (UE_GCCLUSTER_VERBOSE_LOGGING=1) by objects within them by specifying -DumpClustersWithObjects=ObjectName1,ObjectName2 in the command line Change 4257822 by Ben.Marsh Fixes for PlatformShowcase compile errors. Change 4258771 by Ben.Marsh UBT: Fix project files not being generated for foreign projects when creating .stub files. #jira UE-62462 Change 4258790 by Ben.Marsh UBT: Clean up the logic around generating project files before creating a stub IPA, so that it fails loudly if project files do not exist, and can accept target names not matching project names. Change 4259276 by Ben.Marsh UBT: Make it an error if a framework doesn't exist, rather than failing silently. Also remove some remote toolchain stuff that's no longer necessary. Change 4259280 by Ben.Marsh UBT: Fix embedded framework zips not being uploaded for plugins. #jira UE-62485 Change 4260236 by Ben.Marsh UBT: Fix path to generated engine project file. Change 4260334 by Ben.Marsh UGS: Fix custom build steps dialog inadvertantly modifying config file settings in-place. Change 4260361 by Ben.Marsh UGS: Allow for p4 login commands to fail, even though the user is logged in (due to a bad connection, etc...) Change 4260559 by Ben.Marsh UGS: Update version. Change 4261160 by Robert.Manuszewski MediaPlaylist will now be added to root set if the owning MediaPlayer is in the disregard for GC set (fixes GC assumption violation crash) #jira UE-62495 Change 4261421 by Ben.Marsh Force-sync files for building documentation, to fix issues with files not being updated. #jira UE-62413 Change 4261425 by Ben.Marsh UBT: Remove some leftover functions for handling the remote toolchain. Change 4261530 by Ben.Marsh UBT: Speculative fix (and better error reporting) for IOS mobile provision not being found in CIS. Change 4261611 by Ben.Marsh UBT: Downgrade warning to a log message, since it appears when generating project files. Change 4261710 by Ben.Marsh Remove assert that GLogConsole is set; it won't be for command line utilities that don't depend on ApplicationCore. #jira UE-62545 Change 4261831 by Ben.Marsh Fix compile errors due to missing include path when hot-reloading a module from the editor. There are not necessarily source files to compile when -modulewithsuffix is specified on the command line, which was results in GeneratedCodeWildcard not being set. #jira UE-62463, UE-62384 Change 4262723 by Ben.Marsh Whitelist plugins that need to be loaded by UFE. #jira UE-62564 Change 4265444 by Ben.Marsh Fix incorrect executable name for DebugGame configurations in Xcode. #jira UE-62574 Change 4265892 by Ben.Marsh Fix incremental compile failures due to dependency checking for unity files. CachedIncludePaths was not correctly being set on file items, so dependencies were being ignored. #jira UE-62575, UE-62603, UE-62597 Change 4266019 by Josh.Adams - Fixed the CopyAction for runtime dependencies that need to be copied to different location, on non-XGE Change 4266264 by Ben.Marsh Remove override for the __IPHONE_OS_VERSION_MIN_REQUIRED macro on TVOS. This macro is already defined by system headers (in <AvailabilityInternal.h>). Now that we support PCHs on IOS and TVOS, manually defining this macro results in it being defined three times (once for the PCH, once by AvailabilityInternal.h, and once by the force-included list of definitions for the source file being built). The errors for redefining the macro in AvailabilityInternal.h are suppressed due to it being a system header, but the error for redefining it for the source file being compiled are not. #jira UE-62578 Change 4266273 by Ben.Marsh Fixes incremental build failure when compile arguments for PCH have changed on IOS/TVOS. Compile action needs to have a dependency on PCH build action. Change 4266614 by Graeme.Thornton Fix crash when cooking nativized blueprints due to removal of child cooker system. Change 4266763 by Ben.Marsh Always build UnrealPak when building client targets. The ProjectParams.Pak option is not reliable, because it can be forced on later by the target platform. #jira UE-62584 Change 4267985 by Robert.Manuszewski When iterating with ForEachObjectWithouter, don't lock the entire has table but only the hash bucket that is currently being iterated #jira UE-62600 Change 4268558 by Robert.Manuszewski PurgeLegacyBlueprints will no longer be called from within ForEachObjectWithOuter is it renames objects that reside in hash tables that are being iterated over which may lead to undefined behavior. #jira UE-62600 Change 4269011 by Chad.Garyet - Fixing Wildcard match issue, the change to ugsapi sends projects as //Depot/Stream instead of //Depot/Stream/ Wildcard match was only substringing to 3 chars. - Checking in the change a while back that increases the number of queried jobs up to 432 based on some maths from Bob about how many builds we want to grab Published to ugsapi server 8/8/17 #jira none Change 4270788 by Ben.Marsh Fix IOS provisioning data being using when remote compiling on TVOS. #jira UE-62705 Change 4271916 by Ben.Marsh Tag the XGEControlWorker executable as a build product after compiling SCW, to make sure it's included in the UGS zip file. Change 4271934 by Ben.Marsh Upload all static libraries in plugin folders as part of remote builds. #jira UE-62694 Change 4273368 by Ben.Marsh Fix Slate dependencies not being enumerated, and rules assembly not being rebuilt when building remotely. #jira UE-62705 Change 4274049 by Ben.Marsh Always parse the team UUID out of the mobile provision when doing a remote compile. The provision installed on the remote Mac (and selected for signing) may be different. #jira UE-62751 Change 4274823 by Ben.Marsh Add the -VersionCookedContent argument to disable the -unversioned parameter on the cooker command line. Change 4275838 by Ben.Marsh Fix BuildVersion string not being passed through from <SetVersion> task. Also add a -BuildVersion command line argument to UBT to override it for a particular build. Change 4275913 by Ben.Marsh Add a dummy exported symbol to the XGEController module, to fix build errors due to missing .lib file when it's built with WITH_XGE_CONTROLLER = 0. Change 4284161 by Ben.Marsh Allow mirroring Oodle files to remote Mac. Change 4074774 by Steve.Robb Vast simplification of TFunction, making it smaller in footprint, easier to follow and extend, and more correct. TUniqueFunction added, which is a move-only TFunction which can hold move-only functors. Fix for UWidgetBlueprint::ForEachSourceWidget() which should never have compiled but did. FFunctionGraphTask and TFuture<> updated to use TUniqueFunction to make them more general. TArray::HeapPop() made to work with move-only types. Change 4082591 by Ben.Marsh Move the Log class from UBT to DotNetUtilities. Change 4083236 by Ben.Marsh Add a Log.WriteException() method to dump an exception message to the console (and write the exception trace to the log) Change 4084107 by Ben.Marsh UAT: Remove the unused -SkipHeader argument to UE4Build. Change 4089771 by Steve.Robb GitHub #4743 : modified VirtualAlloc function flag https://blogs.msdn.microsoft.com/oldnewthing/20151008-00/?p=91411 Change 4091456 by Steve.Robb Unification of all platforms' FMath::CountTrailingZeros() and FMath::CountLeadingZeros() for both 32-bit and 64-bit. Change 4156437 by Ben.Marsh Lots and lots of fixes compiling for Clang on Windows. Editor now compiles cleanly without warnings, but crashes on startup due to error in intrinsics test. Disabling that runs further, but crashes accessing freed memory. Switching to the ANSI allocator runs further, but crashes in Slate after the splash screen and before the editor window opens. // TODO! * Switching between Clang/ICL/VS2015/VS2017 is now supported through the same mechanism as switching Visual Studio versions, without requiring any source level changes. To use Clang, set WindowsPlatform.Compiler = WindowsCompiler.Clang from a .target.cs file, or set <WindowsPlatform><Compiler>Clang</Compiler></WindowsPlatform> from BuildConfiguration.xml. To pick a specific toolchain version, set WindowsPlatform.CompilerVersion. * Clang is now supported through AutoSDKs; will be added to CIS. * The Samples/Sandbox/Clang project forces Clang to be used from its target.cs file, and allows easily building all editor modules and plugins with Clang on Windows. * UnrealMathSSE intrinsics have been re-enabled for Clang due to missing functions from the UnrealMathFPU implementation, but causes failure in tests at startup. * SSE4_CRC32() is disabled in D3D12Pipelinestate.cpp, since intrinsics are only allowed if enabled for the whole target (rather than being used in specific functions due to runtime checks) Change 4157389 by Ben.Marsh Few more fixes for compiling the editor with Clang. Change 4183911 by Ben.Marsh Fixes to support incremental linking on Windows. Does not seem to have any net benefit right now; may improve once minimal rebuild is enabled. * Incremental linking no longer forces PDB files to be enabled for source files. * Actions can specify specific files to be deleted before each build. Code to forcibly delete PDB files has been moved to the MSVC toolchain. * Unused libraries produced by the cross-referenced link are no longer added as build products, since (a) deleting them breaks dependency checking for incremental linking and causes a full link, and (b) not deleting them breaks UBT dependency checking and causes actions to be run over and over again. * Icon update is disabled for Windows when incremental linking is enabled. * Removed rarely-used setting to always delete produced items before each build. Change 4184311 by Ben.Marsh UGS: Added a dialog which shows all the required platform SDKs for a branch, linked from the status panel in UGS. The llist is configured via the UGS config file submitted to Engine/Programs/UnrealGameSync/UnrealGameSync.ini (and may be overridden by the project config file if necessary): [Default] ; Set this to a network share which contains the SDK installers for your site SdkInstallerDir= ; All the required SDKs for the current version of the engine +SdkInfo=(Category="Android", Description="NDK r21", Browse="$(SdkInstallerDir)\\Android") +SdkInfo=(Category="Windows", Description="Visual Studio 2017") +SdkInfo=(Category="Windows", Description="Visual C++ Toolchain 14.13.26128") +SdkInfo=(Category="Windows", Description="Windows SDK 10.0.16299.0") Similar entries for console platforms are added in console subdirectories. Each entry may contain an Install="Foo.exe" and/or Browse="C:\Foo" style attribute, specifying the path to an installer to run or directory to open in explorer respectively. The SdkInstallerDir setting is used as a base directory for the default installers, seen above for Android. Licensees may override this with a network path specific to the site that UGS is being deployed to (either in this file, in a project specific config file, or in a Engine/Programs/UnrealGameSync/NotForLicensees/UnrealGameSync.ini file). Change 4200452 by Ben.Marsh UBT: Change DebugGame configurations to output a separate executable rather than requiring a -Debug argument at runtime. Previous behavior was a common source of errors. Engine modules are still shared between Development and DebugGame, but the launch module sets a flag in Core on startup indicating the game configuration. Change 4206189 by Ben.Marsh UBT: Simplify logic for precompiling binaries. * Target no longer has separate list of "precompile only" binaries or modules. New -AllModules option allows adding every module to a target, which can be used with -Precompile and -NoLink to precompile object files for monolithic builds. * Precompiled file lists have been removed from target receipts. * The manifest now includes all generated headers and precompiled files when run with the -Precompile option. * Separate -DependencyList=Foo.txt has been added to write a list of all dependencies required to use precompiled binaries. This file list can be read using the <Tag> task in buildgraph. Change 4215466 by Ben.Marsh UBT: Remove indirect calls to determine extensions for object files and precompiled headers. The toolchain knows the correct convention for the platform. Change 4215975 by Ben.Marsh UBT: Remove telemetry code. This has never proved useful for analyzing performance due to the number of incidental factors that affect build times (eg. number of files being compiled). Change 4220154 by Ben.Marsh Move text-only implementations of FOutputDeviceError back into Core, so we can build command-line applications that don't depend on ApplicationCore. Change 4224708 by Ben.Marsh Add a bCompileAgainstApplicationCore setting to the target rules, which allows compiling out references to the ApplicationCore module (which should only be necessary for applications with a GUI). Removed ApplicationCore from several engine tools and utilities. Change 4224958 by Ben.Marsh Remove CoreMinimal.h includes from Core. Change 4229059 by Ben.Marsh UBT: Remove the UEBuildPlatform.ShouldNotBuildEditor() hook for target platforms. We shouldn't be modifying a target's build environment to disable the editor; it is invalid to build the editor for these target platforms at all, and this is already enforced by the GetSupportedPlatforms() function. Change 4230508 by Ben.Marsh Fixup precompiled header setting for samples and games. Change 4231457 by Ben.Marsh Fix exceptions in log messages having trailing newlines. Change 4232406 by Ben.Marsh UBT: Always force include a PCH for generated code if there's one set; the code may depend on it to compile. Change 4234177 by Ben.Marsh Set up private PCH files everywhere that previously used them. Change 4235973 by Ben.Marsh Change FPlatformMisc::GetEnvironmentVariable() to return an FString() rather than requiring a fixed size buffer to be passed in. Removes references to MAX_PATH. Change 4238842 by Ben.Marsh Add support for paths longer than MAX_PATH in the editor. Requires Windows 10 version 1607, and the functionality to be enabled via a registry key or group policy (see https://docs.microsoft.com/en-us/windows/desktop/FileIO/naming-a-file). Only a subset of Win32 functions support long paths (executables can only be started from paths shorter than MAX_PATH, for example). * Added a FPlatformMisc::GetMaxPathLength() function to return the maximum length of a path on the current system. On Windows, this returns a different value for systems with long paths enabled to those without. * The MAX_PATH define is no longer set by non-Windows platforms. Instead, there is a MAC_MAX_PATH, UNIX_MAX_PATH, etc... for any platform-specific code that still relies on the previous macro. * The MAX_UNREAL_FILENAME_LENGTH macro has been renamed to MAX_UNREAL_FILENAME_LENGTH_DEPRECATED * The PLATFORM_MAX_FILEPATH_LENGTH macro has been renamed to PLATFORM_MAX_FILEPATH_LENGTH_DEPRECATED. * Removed custom resource files for programs, since they are just copies of the base UE4 one (which is used by default anyway). The base UE4 manifest declares support for long paths. * Fix 512 character maximum length on editor commands. 260 character limit remains in place for cooking at the moment (see ContentBrowserUtils.h), until C# staging code supports long paths. Change 4255042 by Ben.Marsh UBT: Remote compilation now uploads the entire workspace to the remote Mac and executes a separate remote instance of UBT rather than synchronizing individual actions. This makes the remote compile codepath much simpler, and removes a lot of special cases that exist to support it previously. The list of files to be transferred to the remote are listed as rsync filter rules in Engine/Build/Rsync/RsyncEngine.txt and RsyncProject.txt, which are applied to the root engine directory and project directory respectively. Projects that need to customize which files are uploaded can add their own <ProjectDir>/Build/Rsync/RsyncProject.txt file, which will be included in the filter before the default version. Change 4260567 by Ben.Marsh UAT: Rename CommandUtils.Log to CommandUtils.LogInformation, to avoid conflicts with the underlying Tools.DotNETCommon.Log class. #rb none [CL 4285673 by Ben Marsh in Main branch]
2018-08-14 18:32:34 -04:00
LogInformation("Client exited and has been quiet for 30 seconds...exiting");
bKeepReading = false;
}
}
if (ClientProcess != null && !ClientProcess.HasExited)
{
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 4285612) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3836829 by Ben.Marsh UBT: Fix ability to precompile plugins from installed engine builds. Change 3839519 by Ben.Marsh UBT: Simplify configuring bPrecompile and bUsePrecompile settings for modules. Each rules assembly can now be configured as installed, which defaults the module rules it creates to use precompiled data. Change 4042043 by Steve.Robb GitHub #4705 : Added weak lambda's for delegates and multicast delegates. Change 4042056 by Robert.Manuszewski Optimized Mark Phase of GC by up to 10ms by making it run in parallel and removing a huge array presize which we didn't need. Change 4042104 by Robert.Manuszewski Set the minimum GC cluster size to 5 so that GC doesn't have to process micro clusters which are more expensive than processing individual objects + Exposed the minimum cluster size to ini and project settings as gc.MinGCClusterSize + Added the ability to sort clusters by name/object count/mutable object count/referenced clusters count when dumping them with gc.ListClusters command Change 4042377 by Robert.Manuszewski Reworked how GC and other threads (ALT specifically) interact - GC will now notify the ALT it wants to run and ALT will immediately try to finish its current work to allow that. Also the entire ALT tick is now protected against GC running at the same time to improve ALT stability. + added gc.ForceCollectGarbageEveryFrame console variable that triggers a forced GC every frame Change 4042427 by Robert.Manuszewski Changed FGCCSyncObject to use events when waiting for GC to finish so that it doesn't spin on non-game threads when GC is running Change 4042482 by Robert.Manuszewski Unhashing unreachable objects (ConditionalBeginDestroy) will now also be done incrementally, just like the purge phase of Garbage Collection Change 4042635 by Robert.Manuszewski Fix for a potential assert when incremental purge garbage is pending and something forces a full purge Change 4044092 by Steve.Robb Fix for forward declared CoreUObject weakobject types in delegates when building in Clang. Change 4044102 by Robert.Manuszewski Fix for a possible hang when worker threads are preventing GC from running and something is later trying to FlushAsyncLoading with the Async Loading Thread enabled Change 4044113 by Steve.Robb Another Clang fix. Change 4044160 by Robert.Manuszewski Disregard For GC pool will now be enabled by default in cooked builds Change 4044287 by Steve.Robb Typo fix. Change 4047723 by Graeme.Thornton TBA: Fixes for import/export name cache and object resolving Change 4048015 by Graeme.Thornton TBA: Weak/Soft/Lazy pointer serialization changes * Remove FWeakObjectPtr::Serialize, move it's logic into, and replace usages of with calls to, FArchiveUObject::SerializeWeakObjectPtr(). Ensures that something is always sent to the archive so that structured archives can be kept happy in the future. * Added Weak/Soft/Lazy pointer handling to the structured archive slot interface and all the formatters. Binary formatters just forward the call onto their inner and text archives store as a string path reference. * FArchiveUObjectFromStructuredArchive caches all these pointer types and stores indices in the binary block, same as with a UObject*. All pointers are then forwarded to the underlying formatter in one go on finalization. Change 4048021 by Steve.Robb Fix for binding an unbound TFunction to another TFunction with a different signature. Also all null pointers now count as unbindings, not just nullptr. TIsMemberPointer added. TIsATFunction and TIsATFunctionRef renamed to remove the 'A's. Change 4048544 by Robert.Manuszewski Fixing ConditionalBeginDestroy profiling after changes to incremental CBD. Change 4051028 by Graeme.Thornton TBA: ArchiveFromStructuredArchive adapter uses Inner to determine if it is outputting to text, and sets it's own ArIsTextFormat to false Change 4051056 by Graeme.Thornton TBA: High level tagged property / UObject base class text serialization - UObject serialize converted to structured archive - Properties written to text individually with text tags, and then binary adapted values - Only saves, doesn't load Change 4051111 by Graeme.Thornton TBA: Temporarily disable loading of text assets until tagged property serialization path is fixed up Change 4051154 by Graeme.Thornton TBA: Convert a few uobject serializers to structured archive format for example purposes Change 4051181 by Graeme.Thornton TBA: Added default structured archive implementation of SerializeItem to UProperty, which just calls the FArchive version on an FArchiveUObjectFromStructuredArchive adapter. Implemented structured archive SerializeItem for UArrayProperty Change 4051197 by Graeme.Thornton TBA: ObjectProperty text serialization Change 4051216 by Graeme.Thornton Restored a modified FWeakObjectPtr::Serialize function to keep backwards compatibility in code I don't have access to. Change 4051261 by Graeme.Thornton TBA: Convert UMetaData to structured archive Change 4051374 by Steve.Robb Incorrect assert removed. Change 4051562 by Robert.Manuszewski Adding stats for the new GC internal functions Change 4051614 by Graeme.Thornton TBA: Removed UProperty::SerializeItem(FArchive, ...) and replaced with UProperty::SerializeItem(FStructuredArchive::FSlot, ...). Fixed up most of them to work properly and added adapters in for any that were non-trivial. Change 4052512 by Graeme.Thornton TBA: Temporary workaround for softobjectptr and lazyobjectptr uproperties not serialization anything when they know the archive is a reference collector. They should always be serializing their pointers and letting the underlying archive itself ignore them. Change 4053917 by Robert.Manuszewski Clustered objects from clusters that are no longer reachable will now be marked as unreachable immediately when gathering unreachable objects Change 4053919 by Robert.Manuszewski Added the ability to disable incremental BeginDestroy in ini/project settings Change 4055518 by Daniel.Lamb Fixup for deterministic audio generation issue. Submitted on behalf of Rich.Whitehouse #jira nojira #test prefilght automated test. Change 4056854 by Graeme.Thornton TBA: Added a test asset to EngineTest which contains all the different property types and test cases. Change 4056858 by Graeme.Thornton TBA: Updated USetProperty to proper structured archive usage Change 4056872 by Graeme.Thornton TBA: Add map property field to test object Change 4056873 by Graeme.Thornton TBA: Convert UMapProperty to full structured archive Change 4056994 by Graeme.Thornton TBA: Converted FText over to structured archive. Implemented saving, but not loading. Change 4059728 by Ben.Marsh UBT: Add support for using adaptive non-unity builds when the engine and project are in separate repositories. Change 4059805 by Graeme.Thornton Fixed typo in text serialization. Fixes CIS automation test errors Change 4060007 by Graeme.Thornton TBA: FArchiveFromStructuredArchive will now access it's host slot lazily, i.e. only when a value is actually written to the archive. Change 4060092 by Stefan.Boberg Added optimized Windows console window output path to GenericConsoleOutput since this slowed down cooking considerably (2 minutes spent in wprintf alone for one large dataset) When stdout is attached to a console we use the WriteConsoleW function instead of wprintf since the latter is very slow especially in unbuffered mode which the engine currently configures for stdout (see setvbuf call in LaunchEngineLoop.cpp). At some point we should reconsider this buffering policy since it's likely to slow down other platforms as well but I wanted to do a safe change for now as I don't yet fully understand why the setvbuf call is there in the first place. Change 4060108 by Stefan.Boberg Introduced some additional target platform utilities to help with asset cook optimizations * We now assign each ITargetPlatform a zero-based ordinal value * Introduced FTargetPlatform and FTargetPlatformSet types to help store platform references and platform sets efficiently. These are not currently used in the engine but are designed to replace the existing ITargetPlatform/string/FName representations in the cooking data structures. Change 4060143 by Graeme.Thornton Undo //UE4/Dev-Core/Engine/Source/Runtime/... changelist 4060007 Needs some other changes that I haven't checked in yet... Change 4062432 by Ben.Marsh Fix error message when enumerating P4 changes. Change 4062648 by Ben.Marsh Add missing p4 integration action. Change 4063620 by Graeme.Thornton Integrated a fix from UDN where the engine would crash when trying to load a very small encrypted file (<16bytes) from a pak file, where the read address wasn't already aligned to the AES block size. (https://udn.unrealengine.com/questions/431989/crash-while-reading-a-very-small-file-in-encrypted.html) Change 4066963 by Robert.Manuszewski Fixing GC cluster verification code reporting false positives when a cluster is referencing another cluster through 'mutable' objects list. Change 4067133 by Robert.Manuszewski Changed log verbosity when reporting individual cases of GC cluster assumption violations as they are followed by an asser anyway and this way we get the chance to see all issues before we assert at the end of these checks. Change 4067443 by Steve.Robb FString can now be constructed from any char pointer type and length. Change 4068156 by Steve.Robb Fix necessary because of FString constructor change in CL# 4067443. Change 4070258 by Graeme.Thornton Fixes for VSCode Change 4070372 by Graeme.Thornton TBA: Script struct serialization to structured archives Change 4071913 by Ben.Marsh Move bulk of the code for UnrealPak into an engine developer module, so it can be used in the editor. Change 4071914 by Ben.Marsh Missing files. Change 4071937 by Ben.Marsh Missing header. Change 4072015 by Ben.Marsh Fixes for compiling PakFileUtilities as part of the editor. Change 4072826 by Steve.Robb TBitArray::Reserve() added. TBitArray::Add() overloaded to allow adding multiple bits. TSparseArray::Reserve() optimized to call the overloaded Add(). Change 4073271 by Daniel.Lamb Fixed add patch tier in project launcher passing the wrong commandline option to UAT. #test none Change 4074708 by James.Hopkin #core Removed redundant Casts Change 4074763 by Steve.Robb Fix for TSparseArray::Reserve() size. Change 4076063 by Ben.Marsh Add an "UnrealPak" commandlet with the same functionality as the standalone UnrealPak program. Invoke by running the editor with -run=UnrealPak and the standard UnrealPak commandline options. Change 4077064 by Robert.Manuszewski Fixing compile error in PakFileUtilities Change 4077144 by Graeme.Thornton TBA: TextAssetCommandlet improvements * Collect lists of broken assets during roundtrip tests and print a summary of packages that failed each phase at the end * After resaving as text, load the file back as a plain JSON hierarchy to ensure the output was valid Change 4077412 by Ben.Marsh Set the correct exit code for UnrealPak. Should return 0 on success, not 1. Change 4077760 by Graeme.Thornton TBA: Loading fixed for tagged property serialization Includes conversion of all UProperty::ConvertFromType() and SerializeFromMismatchedTag() functions to use structured archives Lazy initialization of FArchiveFromStructruredArchive when loading, to support the possibility of an adapter being create around an object property serialize call to its inner UStruct, which then decides not to do anything and return false. Stops the ArchiveFromStructuredArchive from consuming the slot and getting upset later on when we try to serialize normal tagged properties from it. Disabled lazy bulk data loading from text assets. Requires a bigger change to make it work. Added some debug checks to json input formatter which track the current value stack size when a new object is pushed onto the stack, and makes sure that the stack has returned to the same size when the object is popped. Catches cases where we unpack an array/stream to the value stack but then don't consume all the items. Change 4078800 by Ben.Marsh Change UAT to using the editor's UnrealPak commandlet rather than invoking the standalone UnrealPak executable. To improve performance when building several PAK files, also add a new -batch=<file> command which reads commands to execute in parallel from a text file. Change 4079745 by Graeme.Thornton TBA: Migrated a couple of UObject Serialize functions to FStructuredArchive (SoundCue / MaterialExpressions / Editor strip flags) Change 4079847 by Graeme.Thornton TBA: Add 'FindMismatchedSerializers' mode to text asset commandlet, which dumps out a list of all UClasses which don't have the CLASS_MatchedSerializers flag, meaning we can't guarantee the have Serialize functions for FArchive AND FStructuredArchive, therefore we can't use the new structured archive based serialize path. Should only ever be native instrinsic classes as UHT takes care of all other cases. Change 4079925 by Ben.Marsh Fix incorrect assignment when deriving name for chunked pak file. Change 4080214 by Ben.Marsh Move the ThreadPoolWorkQueue class into DotNETUtilities so it can be used by other projects. Change 4082394 by Graeme.Thornton CIS fix for variable shadowing warning Change 4082583 by Ben.Marsh Add a IBinarySerializable interface for types that support reading from a BinaryReader and writing to a BinaryWriter. Implementing IBinarySerializable implies a constructor taking a BinaryReader argument is available for deserializing. Change 4082652 by Ben.Marsh Fix FileReference.Directory not returning a directory with a trailing backslash for files in the root directory. Change 4082755 by Graeme.Thornton Fixed an erroneous usage of TUniquePtr<uint8>as a pointer to a uint8 array when creating pak files. Caused a crash when compression was enabled, and has probably surfaced because pak generation is now done by an editor commandlet rather than a standalone program. Change 4082756 by Graeme.Thornton Fixed some incorrect documentation for pakfile compressed chunk headers Change 4082883 by Graeme.Thornton Static analysis warning fix Change 4082912 by Ben.Marsh Move ExceptionUtils into DotNETUtilities. Change 4085291 by Graeme.Thornton TBA: In the Json output formatter, write float and double values out with enough precision for successful roundtripping. Added some debug only code which will immediately reconvert the string back to its original value and compare the the input Change 4085523 by Graeme.Thornton TBA: Remove only explicit usage of DECLARE_FSTRUCTUREDARCHIVE_SERIALIZER. Should only be used from UHT generated code. Change 4086037 by Robert.Manuszewski Fix for a potential race condition when two threads want to acquire GC lock Change 4088655 by Graeme.Thornton Pak creation now uses the bEnablePakSigning setting from the crypto config json file Change 4091474 by Steve.Robb Fix for TStaticBitArray::FindFirstSetBit() and TStaticBitArray::FindFirstClearBit(). Unused variables removed. Change 4093632 by Steve.Robb CIS fixes. Change 4093656 by Graeme.Thornton Build fix Change 4093744 by Ben.Marsh Allow per-chunk settings for whether to enable compression in UnrealPak. Change 4099712 by Gil.Gribb UE4 - Fixed rare case where insufficient space was preallocated for cooldown ticks. #jira UE-59686 Change 4099912 by Stefan.Boberg Cooking timer optimizations: - Replaced data structures for FScopeTimer and FHierarchicalTimerInfo. Previous implementation used FString for many things and caused *lots* of heap and string concatenation activity. Replaced with a compile-time node id (using __COUNTER__) and raw string literals. - Removed PERPACKAGE_TIMER support (was disabled by default and was difficult to test) - Made it possible to toggle OUTPUT_TIMING and ENABLE_COOK_STATS independently - Removed some extremely tight timers because the overhead from calling QPC significantly exceeded the measured code This change shaved some 15% off a clean cook of Fortnite WindowsClient (en) with fully populated local DDC Change 4100519 by Stefan.Boberg Quick fix for Linux build issue introduced in 4099927 Change 4105327 by Stefan.Boberg Cooker: Changed FHierarchicalTimerInfo so it uses a linked list for tracking child nodes, to be able to deal with any child count. Previously we assumed there would never be more than 9 children but it turns out there are cooker modes that need more. Fixes check when using -FullLoadAndSave to cook Change 4105448 by Stefan.Boberg - Fixed Linux build warning re: member initialization order - Also eliminated OUTPUT_HIERARCHYTIMERS/CLEAR_HIEARCHYTIMERS macros (plain functions are fine) - Moved finishing-up code for FullLoadAndSave() to TickCookOnTheSide() call site to improve timer output. Previously some of the scopes would not have been closed before printing and thus the output was misleading. Change 4109031 by Ben.Marsh Attribute-driven Perforce wrapper (old Epic Friday project). Offers a more complete implementation than the current P4 wrapper in UAT without requiring any platform-specific libraries. Uses the Python binary output for parsing. Change 4109588 by Ben.Marsh UBT: Add extension methods for serializing a nullable type to a BinaryReader/BinaryWriter. Change 4109595 by Ben.Marsh Missing project file for DotNETUtilities. Change 4110724 by Stefan.Boberg Removed annotation map locking in UObjectMarks, eliminating around one minute (~3.5%) from Fortnite cook time. The locking was redundant since the annotation maps are managed per thread anyway. Change 4111304 by Ben.Marsh UAT: Add support for setting a status message through the log class. Allows writing transient messages (eg. progress messages) which will be cleared out before writing other messages. Best used through the LogStatusScope class, which can set a status message for the duration of a using() block. As part of this change, the console no longer has to be added as a dedicated trace listener. Since we already special-case this listener when formatting log output, it's easier to just keep the implementation separate to the other trace listeners. Change 4112708 by Steve.Robb Fix for TBitArray::MaxBits in assignment. Change 4114133 by Stefan.Boberg Tweaked how low-level memory (LLM) tracker is implemented to reduce overheads. Previously FMemory functions would acquire the LLM singleton and call OnLowLevelFree/OnLowLevelAlloc etc which would check the bIsDisabled flag and early out if it was set. Due to how frequently these functions were called this ended up costing quite a bit. - This change makes the flag a static member variable instead of a member variable and therefore enables a simpler early-out to be implemented. - The singleton getter is also simplified to avoid hitting the threadsafe singleton construction path on every call. - The enable flag is no longer TAtomic - this also incurs extra overhead for no clear benefit Shaves approximately 3.5% (one minute) off a Fortnite cook test scenario (using -FullLoadAndSave) Change 4115010 by Robert.Manuszewski Fixing CIS Change 4115249 by Robert.Manuszewski Fixing async loading code asserts when exiting game very early due to an error #jira UE-56267 Change 4117091 by Ben.Marsh Prevent doubled-up lines when writing status updates with console log verbosity. Change 4117207 by Ben.Marsh UGS: Do not include executables in diagnostics zip file, and ignore "no such files" error when cleaning workspace. Change 4119175 by Ben.Marsh UGS: Fix crash writing version files when directory does not already exist. Change 4119987 by Ben.Marsh UGS: Show a dialog box while the launcher is updating executables from Perforce, which allows cancelling the operation if necessary. Allow setting the username on the settings window, and prompt for login credentials if necessary. Should prevent situations where users have to update settings from the command prompt. Holding down shift during launch now shows the settings dialog rather than an immediate prompt to launch the unstable version (unstable version is shown as a checkbox on this dialog). Change 4119991 by Ben.Marsh Update version number for UGS launcher to 1.13. Change 4121943 by Robert.Manuszewski Don't use FArchiveAsync2 for reading packages with non-async path in editor builds as its performance is worse than the standard archive's (saves about 1 minute when doing larger cooks and 7 seconds when loading into PIE) Change 4122592 by Steve.Robb GitHub #4762 : Improve wording and grammar of Math comments Also includes improved accuracy in FMath::ComputeBoundingSphereForCone(). Change 4122819 by Stefan.Boberg Don't call CreateDirectory redundantly when opening files for writing using FFileManagerGeneric::CreateFileWriter This change avoids calling IPlatformFile::CreateDirectoryTree if possible since this is a very expensive function especially for deep hierarchies as it performs directory creation from the root directory onwards instead of from the leaf downwards. That function should also be fixed but this change improves performance in the meantime. Change 4122872 by Stefan.Boberg CreateDirectoryTree now creates directories leaf-to-root instead of the other way around. This is much more efficient since we don't spend time on system API calls for directories which already exist. This accounted for a very large amount of CPU time in cooking as the full target file directory hierarchy would be "created" for every single output file. Change 4123109 by Stefan.Boberg - Disable overlapped I/O in editor / cooker. Synchronous I/O reduces the number of syscalls and Windows performs prefetching on our behalf anyway for sequential reads - Eliminated syscall which was issued for every write to update cached file size -- since we're the only writers to the file (file access allows read sharing at most) we can authoritatively update the file size on write completion Change 4123455 by Ben.Marsh PR #4775: New build param PCHMemoryAllocationFactor to set /Zm VS build param. (Contributed by lucaswall) Change 4124207 by Ben.Marsh UBT: Remove some unnecessary indirection for generated code paths. Change 4124217 by Ben.Marsh UBT: Remove another unused variable from UEBuildModuleCPP. Change 4124377 by Stefan.Boberg In IPlatformFile::DeleteDirectoryRecursively, attempt to delete file first and if it fails clear the readonly flag and try again Previously there was a call to clear the readonly flag for every deleted file and this is a waste of resources 99% of the time. The SetFileAttributes call accounted for a significant amount of time during cooker sandbox directory deletion Change 4125071 by Stefan.Boberg Some tweaks to FQueuedThreadPoolBase scheduling and memory management - Explicitly pass in false for TArray::RemoveAt(..., bool bAllowShrinking) argument to prevent memory reallocation when arrays are drained and inevitably repopulated shortly afterwards - Use a MRU strategy instead of LRU when picking a thread to wake up. The MRU thread is the most likely to have a 'hot' cache for the stack etc. Picking from the back of the array also happens to be cheaper since no memory movement is necessary when RemoveAt is called. (This was the strategy in place before CL2600362 which seems to have changed it unintentionally) - Release lock as soon as a thread has been chosen, before asking the worker thread to wake up and do the work Change 4126132 by Ben.Marsh UAT: Detect when stdout is redirected and prevent using backspace characters to move the cursor. Change 4126867 by Graeme.Thornton TBA: Fix tagged binary formatter Change 4127010 by Robert.Manuszewski AnimScriptInstances created at runtime will now also be added to the owning omponent's cluster to avoid GC issues. Change 4127932 by Ben.Marsh WorkspaceTool: Reduce unnecessary logging of status messages when console output is not redirected. Change 4129050 by Ben.Marsh UGS: Check for NET Framework 4.5 being installed before running the installer. Also fix warning trying to kill existing UGS instances before upgrade. Change 4129459 by Graeme.Thornton TBA: TextAssetCommandlet - When outputting converted assets to an output path, replicate the workspace relative path in the output directory Change 4129515 by Graeme.Thornton TBA: Add EnterRecord overload that allows outputting of available field names when loading. Change 4129517 by Graeme.Thornton TBA: Tagged properties are written out as named fields on the "Properties" record, rather than as a stream with a null tag at the end Change 4129518 by Graeme.Thornton TBA: Added a local const bool to allow easy hacking out of text asset loading support Change 4129558 by Graeme.Thornton TBA: Build fix for textasset-less configs Change 4129614 by Ben.Marsh UGS: Main window is now restored to normal size when activated by clicking on the tray icon. #jira UE-60490 Change 4129618 by Ben.Marsh UGS: Speculative fix for unreproduced exception accessing disposed window while shutting down. Change 4131936 by Robert.Manuszewski Removing some WIP code accidentally checked in with CL #4121943 Change 4133490 by Ben.Marsh UGS: Allow the $(Change) variable to be used in more places than just the context menu. #jira UE-60573 Change 4133550 by Ben.Marsh UGS: Setting for whether or not to use incremental builds is now exposed through the variable "$(UseIncrementalBuilds)" for use by custom build steps. #jira UE-60554 Change 4133681 by Ben.Marsh UGS: A per-project list of folders and extensions to be deleted by default when running the 'clean workspace' tool can now be specified through the <ProjectDir>/Build/UnrealGameSync.ini file. Settings may be specified for an individual branch (via a category with the depot path to the project) or for wherever the project is currently open (via the [Default] category). The SafeToDeleteFolders list specifies a substring that will be checked against folder paths. Anything containing this folder will be marked as safe for delete by default. The SafeToDeleteExtensions list specifies a list of extensions for files that can always be deleted. Example: [Default] +SafeToDeleteFolders=/MyGame/Test/ +SafeToDeleteFolders=/DataService/ +SafeToDeleteExtensions=.xx1 +SafeToDeleteExtensions=.xx2 #jira UE-60575 Change 4135449 by Ben.Marsh Fix allowing use of Job objects on Windows platforms (debug code submitted by mistake) Change 4135730 by Ben.Marsh UBT: Plugins can now be enabled and disabled from the .target.cs file (for targets that do not use the shared compile environment), by compiling the list of enabled/disabled plugin names into the Projects module. Change 4135823 by Ben.Marsh UBT: Remove legacy code to handle disabling optional plugins; now that this is compiled into the target, it will work for any plugins we choose. Change 4135945 by Ben.Marsh UBT: Fix error running programs with no explicitly enabled or disabled plugins. Change 4137207 by Ben.Marsh UGS: Align all badges with the same name, to make it easier to see which CIS steps are being run. Allow overriding the slot taken by a particular badge by calling it "SlotName:LabelName". Change 4137311 by Stefan.Boberg Removed child cooker support. In practice it is not a useful feature as it provides no performance improvement (quite the opposite in fact) and adds testing and maintenance complexity. Change 4137393 by Ben.Marsh UGS: Fix display of multiline errors in the status panel. Change 4141708 by Steve.Robb GitHub #3631 : Incorrect default argument in WeakObjectPtrTemplate #jira UE-45490 Change 4146655 by Stefan.Boberg Removed FullGCAssetClasses logic - no longer necessary nor useful Change 4147318 by Ben.Marsh UGS: Compress build badges in a column if it shrinks below the size that they would be visible. Change 4148207 by Ben.Marsh UGS: Added support for showing the latest completed build from a specific list of badges in the status panel. To declare a badge as one that should appear in the status panel rather than the CIS column, add it to the project's UnrealGameSync.ini in the project or [Default] section like so: +ServiceBadges=RoboMerge Change 4148282 by Stefan.Boberg Fixed bug in UCookOnTheFlyServer::GetCookOnTheFlyUnsolicitedFiles - UnsolicitedFiles should be passed by reference not by value Change 4148344 by Stefan.Boberg Fixed minor indentation error (most likely caused by sloppy merge) Change 4148521 by Stefan.Boberg Removed accidentally checked in PRAGMA_DISABLE_OPTIMIZATION from CookOnTheFlyServer.cpp Change 4148639 by Ben.Marsh UGS: Fix tooltips not showing for changes that have description badges. Change 4149373 by Ben.Marsh UGS: Allow adding additional columns to display particular badges by adding entries from the project config file. Example syntax: +Columns=(Name="Desktop",MinWidth=50,DesiredWidth=100,Weight=3,Badges="Editor") +Columns=(Name="Mobile",MinWidth=50,DesiredWidth=100,Weight=3,Badges="IOS,Android") Same form can be used to control how default columns are displayed (though badge settings are ignored). Also allow PerforceMonitor to detect local changes to project config files and update settings automatically. Change 4149399 by Ben.Marsh UGS: Update version to 1.143. Change 4155660 by Steve.Robb PROJECTION and PROJECTION_MEMBER macros which provide the correct behavior when creating projections using functions which are overloaded or use default arguments. Change 4157117 by Ben.Marsh Fix warning due to plugins disabled in .target.cs file. Change 4158011 by Ben.Marsh UBT: Add a check that the UnrealHeaderTool target file exists, rather than throwing an exception when reading it fails. Change 4158646 by Ben.Marsh UGS: Fix exception when login is discovered to have expired during a workspace update. Change 4158678 by Ben.Marsh UGS: Fix an exception on shutdown due to the icon being hidden after it's already been disposed. Change 4158683 by Ben.Marsh UGS: Add an unhandled exception filter which sends the exception data to the backend. Change 4159131 by Ben.Marsh UGS: Reduce the number of characters displayed for build badges based on the available space. Change 4159194 by Graeme.Thornton TBA: Fix incorrect map property conversion code when converting an old property that contains a map with different key/value types Change 4159239 by Steve.Robb Improved readability and compliance with coding standards. Change 4159246 by Ben.Marsh UGS: Allow syncing projects where source code is not available (and various version files don't exist). #jira UE-60985 Change 4159286 by Ben.Marsh UGS: Remove requirement for UE4Editor.target.cs to be visible in the depot in order to open a project. #jira UE-60986 Change 4159302 by Ben.Marsh UGS: Update version to 1.144. Change 4160308 by Ben.Marsh All staging client executables for blueprint projects. #jira UE-60983 Change 4161567 by Steve.Robb GitHub #4816 : UE-60771: Handle escaped double quote in FParse::LineExtended Change 4162641 by Ben.Marsh UGS: Allow customizing the position of custom columns, via the Index=N attribute. Change 4162647 by Ben.Marsh UGS: Update version to 1.145. Change 4165319 by Robert.Manuszewski PR #4812: Fix inconsistent command-line argument handling under Windows (Contributed by adamrehn) Change 4166150 by Ben.Marsh UGS: Include *.inl when looking for code changes. Change 4166551 by Steve.Robb Whitespace fixes caused by a bad merge. Change 4168483 by Ben.Marsh UGS: Add a more useful error if a file to be synced exceeds the max allowed path length. Change 4168490 by Ben.Marsh UGS: Update version to 1.146. Change 4168551 by Ben.Marsh UBT: Move bBuildLargeAddressAwareBinary into an exposed setting. Change 4168560 by Ben.Marsh UBT: Remove static config variable for controlling which configuration of UHT to use. Change 4171296 by Ben.Marsh UGS: Move the check for overlong paths earlier. Change 4171531 by Ben.Marsh UBT: Fix exception if BuildConfiguration.xml contains an unknown category. Change 4183371 by Robert.Manuszewski Fix for a crash in Async Loading Graph's CheckCycles when GC kicks in on the game thread and forces ALT to exit early Change 4184312 by Ben.Marsh UGS: Update version to 1.148 Change 4184480 by Robert.Manuszewski Removing unused async loading stat Change 4186390 by Ben.Marsh UBT: Format XML validation errors in a format that allows double-clicking on the message in Visual Studio. Change 4188644 by Ben.Marsh UBT: Add the MakePathSafeToUseWithCommandLine() function to UBT. Change 4188647 by Ben.Marsh UBT: Fix exception in target receipt when architecture is null. Change 4189617 by Ben.Marsh Change FileSystemReference, FileReference and DirectoryReference objects to use OrdinalIgnoreCase comparisons without creating a separate copy of the string to compare. The filesystem does not use the invariant culture, and it can produce the wrong results in some cases (the ordinal comparison is faster, too). Change 4189740 by Ben.Marsh UAT: Remote code to build UnrealPak when packaging; we use the editor now. Change 4189860 by Ben.Marsh UGS: Make the filter for excluding automated lighting rebuilds more explicit. Change 4190082 by Ben.Marsh Fixes to allow enabling edit and continue for Windows builds. Have experienced quite a few VS crashes when testing it in editor; not yet recommended for general use. - Allow edit and continue for any configuration, not just debug. - Fixed PDB errors compiling files that use a shared PCH with edit and continue enabled. Path to the generated PDB file was using the wrong directory. - Removed code that tracks PDB output files, since they're modified multiple times during a build. - Enable debug information when compiling generated CPP files, since it causes errors if the shared PCH PDB doesn't have the same option. - Disable support for remote execution of steps that modify the PDB, since the same file has to be modified many times. Remote execution causes the PDB files to be corrupted. Unfortunately, this makes E&C builds significantly slower. #jira Change 4192949 by Ben.Marsh UBT: Minor tidy-up (merging UEBuildBinary.Build and UEBuildBinary.SetupOutputFiles) Change 4193218 by Ben.Marsh Fix formatting. Change 4197252 by Mike.Erwin UAT: Fix log output w/ correct count of non-code projects. #jira none Change 4197941 by Ben.Marsh UGS: Add support for DebugGame editors that have an executable with a DebugGame suffix. Change 4197964 by Ben.Marsh UGS: Prevent attempts to automatically reopen projects while a modal dialog is up, or the workspace is syncing. Change 4198144 by Ben.Marsh UGS: Prevent modal dialogs when login expires in P4, and prompt for password when hitting "retry". Change 4198413 by Ben.Marsh UGS: Always show the main window when launched manually, and run with -RestoreState when launched at startup. Also add a couple more places that save the visibility state, since logging off seems like it can terminate the process abrubtly. Change 4198779 by Ben.Marsh UBT: Allow generating manifests to any arbitrary locations with the -Manifest=<Path> argument. Change 4198825 by Ben.Marsh UBT: Move code to enumerate Slate runtime dependencies into the Slate module. Doesn't need to be done inside core UBT. Change 4199341 by Ben.Marsh UGS: Update version to 1.149 Change 4199642 by Chad.Garyet - Deprecate CISController - Add BuildController to replace CIS GET/POST for builds - Add LatestController, GET does what CIS/GET used to do - Change Latest/GET to return the last 25 builds filtered by project, rather than the last 5000 individual Ids - Latest/GET now returns "LatestData" object instead of array of longs - Updated EventMonitor to match all API changes - Fixed bug where IDs were getting reset to initial startup values every update loop Change 4199663 by Chad.Garyet CIS controller still needs to return an array of longs #jira none Change 4199680 by Ben.Marsh UGS: Update version to 1.150 Change 4200457 by Ben.Marsh Merging CIS fix for non-development configurations. Change 4200472 by Mike.Erwin UAT: fix -skipbuildclient param default It was defaulting to skipbuildeditor's value, likely a copy-paste error. #jira none Change 4202595 by Ben.Marsh Fix static analysis warning due to constant comparison against macro. Change 4203250 by Ben.Marsh UGS: Always show the "Sync Precompiled Editor" option, but disable it and show a tooltip explaining why if it is not available. Change 4206191 by Ben.Marsh Exclude editor target files from installed builds, since they leak info about DLLs that have been stripped out. Change 4213011 by Ben.Marsh UBT: Include contents of modified intermediate files in the log, to make it easier to debug hidden dependencies. Change 4213487 by Ben.Marsh UBT: Fix assumption that bPrecompile is equivalent to bBuildAllModules. This is no longer the case; they are now controlled by separate options. Should fix CIS errors building the editor. Change 4213609 by Ben.Marsh Ensure that strings formatted using FMicrosoftPlatformString::GetVarArgs() are always null terminated, whether we use the secure CRT or not. Change 4215971 by Ben.Marsh UBT: Remove action graph visualization code; no longer used. Change 4215996 by Ben.Marsh UBT: Remove unqiue id from all actions in the action graph. This is only used for printing debug info in the case of a (rare) cycle in the action graph, so just look it up when needed. Change 4216022 by Ben.Marsh UBT: Rename Crypto.cs to EncryptionAndSigning.cs to match the name of the class inside it, and move it under the System folder. Change 4216031 by Ben.Marsh UBT: Move all the action executors into their own folder in the project. Change 4216526 by Ben.Marsh Fix CIS warnings. Change 4216544 by Ben.Marsh Replace custom code to ensure FMicrosoftPlatformString::GetVarArgs() null terminates its buffer with Microsoft's standards-compliant implementation. Change 4216633 by Ben.Marsh Add support for UnrealPak plugins. * Project and plugin modules can now specify an array of supported programs in the "WhitelistPrograms" field of their module descriptors, to allow modules to be loaded by programs. * Programs can now load any runtime modules, as long as they are whitelisted. * Programs under the engine directory can now use a shared build environment, so that building with a project file does not cause output binaries to be output to the project directory. * UnrealPak is now always built by default when packaging * Convert UnrealPak to a modular configuration Change 4216736 by Ben.Marsh UnrealPak: Move "ExportDependencies" command into an editor commandlet, since it relies on the UObject system, asset registry, etc... Change 4217447 by Ben.Marsh Back out revision 50 from //UE4/Dev-Core/Engine/Build/InstalledEngineBuild.xml Change 4217451 by Ben.Marsh Back out revision 11 from //UE4/Dev-Core/Engine/Plugins/Developer/VisualStudioSourceCodeAccess/Source/VisualStudioSourceCodeAccess/VisualStudioSourceCodeAccess.Build.cs Change 4217617 by Ben.Marsh Back out changelist 4217451 Change 4222552 by Ben.Marsh Don't use #import <TypeLib> for VS source code accessor when building with Clang; it's not supported. Change 4222630 by Ben.Marsh UBT: Fix spam while generating project files if Clang isn't installed. Change 4223316 by Ben.Marsh UBT: Change the order in which Visual C++ toolchains are enumerated to prefer full releases over preview releases. Change 4223318 by Ben.Marsh UBT: Add a build setting which allows creating a dedicated PCH for every file that's excluded from the unity working set (disabled by default). Improves iteration times when working on individual cpp files, but slows down iterating on header changes (and can take a lot of disk space for large changes). Dedicated PCH contains all includes scraped from the top of each cpp file, until a non-#include directive is encountered. Change 4223401 by Ben.Marsh UBT: Add an option to automatically enable edit and continue for files in the adaptive non-unity working set. E&C doesn't seem very useful for UE4 projects right now; compile time is comparable to regular build times, but it can take several minutes to apply code changes for large projects. Change 4223899 by Ben.Marsh UBT: Fix loading XML config files on Mono; Type.GetField(Name) does not seem to return values unless binding flags are specified. Change 4224637 by Ben.Marsh Add a "SupportedPrograms" field to plugin descriptors, which allows plugins to declare which plugins they support independently of individual modules. Programs now respect the "bEnabledByDefault" setting in plugins. Plugins that are compatible with a program now need to list that program in the SupportedPrograms list, and whitelist any modules that should load for that program. Change 4224710 by Ben.Marsh UBT: Don't add import libraries as final build products unless the target is being precompiled. Prevents the need for building them for leaf nodes in the action graph. Change 4224715 by Ben.Marsh UBT: Remove hack to allow Stats2.cpp to not follow IWYU convention. Change 4224726 by Ben.Marsh Remove commented out line. Change 4224903 by Ben.Marsh Fix non-unity compile error in Stats2.h. Change 4225051 by Ben.Marsh Back out changelist 4224710; causing CIS errors due to receipts not matching. Change 4225134 by Ben.Marsh Fixing non-unity errors. Change 4225203 by Ben.Marsh Another non-unity fix. Change 4225249 by Ben.Marsh Fix Linux dependencies being copied for the Windows editor; they can be added as requirements for the Linux target platform on Windows instead, so it respects the user's chosen platforms. #jira UE-62001 Change 4225512 by Ben.Marsh BuildGraph: Allow setting the target to build when using the <CsCompile> task. Change 4228815 by Ben.Marsh UBT: Always add the generated code directory to the list of include paths when generating project files. It may only be created after UHT has been run. Change 4228944 by Ben.Marsh UBT: Remove legacy CppCompileEnvironment and LinkEnvironment wrappers from TargetRules that were deprecated in 4.19. Change 4229028 by Ben.Marsh UBT: Fix editor targets with unique build environment having the wrong executable path in generated project files. Move move logic to configure target rules post-construction by the rules assembly to ensure it's valid. Change 4229065 by Ben.Marsh UBT: Move another target setting into the rules assembly. Change 4229105 by Ben.Marsh Fix BPT exception when generating project files. Change 4229311 by Ben.Marsh UBT: Store the module rules file location on the ModuleRules instance, as well as the plugin that it was created from. Also expose the plugin directory as a property on the ModuleRules instance. Change 4229421 by Ben.Marsh UBT: Consolidate functionality for UHT module setup in ExternalExecution.cs. Change 4229817 by Ben.Marsh UBT: Modules must now explicitly specify the path to the header used to generate a PCH if one is desired, rather than the header being determined automatically by attempting to parse the source code. Now that PCHs are force-included anyway, this removes a lot of dependencies inside UBT. Change 4229824 by Ben.Marsh UBT: Remove unused lists inside UEBuildModuleCPP.SourceFilesClass. Change 4229841 by Ben.Marsh UBT: Remove some legacy code from auto-detecting PCHs. Change 4230521 by Ben.Marsh UBT: Add utility functions to the log class to allow formatting errors and warnings in Visual Studio output format (eg. File(Line): warning: Message) Change 4230871 by Ben.Marsh UAT: Remove StreamUtilis utility class; there is a simpler way to implement the one place it's used. Change 4230882 by Ben.Marsh UAT: Add StreamUtils back into UAT, seems like it's still used there. Change 4230896 by Ben.Marsh UBT: Remove some redundant parameters from UEBuildModule/UEBuildModuleCPP/UEBuildModuleExternal constructors. Change 4231014 by Ben.Marsh WorkspaceTool: Include a dump of raw bytes when garbage is read from the P4 process, for diagnostic purposes. Change 4231032 by Ben.Marsh Fix CIS. Change 4231096 by Ben.Marsh Bump the FlatCPPIncludeDependencyCache version, to prevent errors trying to load old files. Change 4231446 by Ben.Marsh UBT: Added support for expanding UE-specific variables in include paths and library paths: $(EngineDir), $(ProjectDir), $(PluginDir), $(ModuleDir). Change 4231460 by Ben.Marsh Modules may now explicitly specify rpaths on Linux via the PublicRuntimeLibraryPaths and PrivateRuntimeLibraryPaths properties. Change 4233909 by Robert.Manuszewski PR #4779: Reason fails as the supplied variable is incorrect (Contributed by projectgheist) Change 4233910 by Ben.Marsh Enable PCHs on IOS. Reduces build time by ~25%. Change 4234176 by Ben.Marsh UBT: Add better messaging for modules that need to have a private PCH set. Now detects the likely PCH using the same method as legacy code and includes it as a suggestion. Change 4234193 by Ben.Marsh Add the Delete command to Perforce wrapper in DotNETUtilities. Change 4234688 by Ben.Marsh UBT: Simplify handling of installed/precompiled builds. Settings for whether a folder is installed/read-only or not is now stored on the RulesAssembly instance, allowing multiple things to be configured separately and stacked together (eg. engine/enterprise/project). RulesAssembly.IsReadOnly() allows determining if a flie can be modified or not and replaces many previous IsXXXInstalledCalls(), and traverses the chain of assemblies. Change 4234711 by Ben.Marsh UBT: Runtime dependencies can now be copied to output directories as part of the build. When adding a runtime dependency, an optional source location can be specified to copy from. Both the source and target paths can use variables can be used as part of the path, eg. $(OutputDir), $(ModuleDir), $(PluginDir). Example usage (from a .build.cs file): RuntimeDependencies.Add("$(OutputDir)/Foo.dll", "$(PluginDir)/Source/ThirdParty/Foo.dll", StagedFileType.NonUFS); Change 4234872 by Ben.Marsh Expose a flag for whether the engine is installed, to fix issues generating project files. Change 4234929 by Ben.Marsh Fix null reference generating receipts when UBT makefiles are active. Change 4235883 by Chad.Garyet Merging 4231245 to core Giving Coordinator its own sln. This should fix what 4158155 was supposed to. #jira UE-61955 Change 4236075 by Ben.Marsh CIS fix Change 4237066 by Robert.Manuszewski Fix for a potential crash when terminating the engine while it's being initialized #jira UE-60545 Change 4237078 by Robert.Manuszewski The engine will no longer be resetting all linkers causing massive load times when renaming the world package when entering Play In Editor Change 4237116 by Ben.Marsh Rewrite some Windows utility functions to support paths longer than MAX_PATH. Change 4237158 by Ben.Marsh Add const TCHAR* overloads of FString::RemoveFromStart() and FString::RemoveFromEnd(). Change 4237159 by Ben.Marsh Fix FWindowsPlatformFile::GetFilenameOnDisk() support for paths longer than MAX_PATH, and simplify some of the other long path functions to avoid copying string buffers. Change 4239050 by Ben.Marsh Missing file Change 4239318 by Ben.Marsh Linux CIS fix. Change 4239685 by Ben.Marsh Static analysis CIS fix. Change 4240800 by Ben.Marsh WorkspaceTool: Include the full command line in the log for any P4 commands. Change 4240903 by Ben.Marsh PR #4909: Update copyright notices to 2018 (Contributed by projectgheist) Change 4241025 by Ben.Marsh UBT: Exclude mobile pipeline caches from generated project files. Causes huge slowdown when using 'Find in Files' through the IDE. Change 4241770 by Ben.Marsh UBT: Include action number in parallel executor output. #jira UE-62032 Change 4243469 by Ben.Marsh TBA: Merge FAnnotatedStructuredArchiveFormatter with FStructuredArchiveFormatter. Any functions that are only implemented for text archives now have a _TextOnly suffix, and are exposed through the FStructuredArchive interface. Change 4245723 by Robert.Manuszewski Fixing another creash when terminating the engine while initializing. #jira UE-60545 Change 4245862 by Steve.Robb VectorLoadFloat2(Ptr) added, which loads { Ptr[0], Ptr[1], Ptr[0], Ptr[1] } into a VectorRegister. Change 4246412 by Robert.Manuszewski The warning 'Calling StaticLoadObject during PostLoad may result in hitches during streaming' will now also report the object which had the PostLoad called on it when StaticLoadObject call happened. Change 4246612 by Ben.Marsh UBT: Fix spelling of "Intellisense". Change 4249454 by Robert.Manuszewski Added extra checks to catch scenarios where the EDL Precache Buffer is flushed before a package header is fully read Change 4249513 by Robert.Manuszewski Made sure the Async Loading Thread doesn't continue running after creating new async packages when garbage collector wants to run on the game thread Change 4255207 by Ben.Marsh UGS: Add additional logging whenever a P4 command fails, and when the user is logged out. Change 4255288 by Ben.Marsh PR #4921: Honor ModuleRules' bEnableExceptions flag when creating precompiled h. (Contributed by surakin) Change 4256422 by Ben.Marsh UBT: Add an error if a module referenced by a plugin descriptor doesn't exist. Change 4257385 by Robert.Manuszewski Creating new objects from within ForEachObjectWithOuter will now result in a fatal error as it's unsafe to change internal UObject hash tables when iterating over them. Change 4257454 by Robert.Manuszewski Added the option to filter clusters listed with gc.ListClusters by objects within them. Usage: gc.ListClusters Hierachy With=ObjectName1,ObjectName2... Change 4257526 by Robert.Manuszewski It's now possible to filter clusters that get logged with verbose cluster logging enabled (UE_GCCLUSTER_VERBOSE_LOGGING=1) by objects within them by specifying -DumpClustersWithObjects=ObjectName1,ObjectName2 in the command line Change 4257822 by Ben.Marsh Fixes for PlatformShowcase compile errors. Change 4258771 by Ben.Marsh UBT: Fix project files not being generated for foreign projects when creating .stub files. #jira UE-62462 Change 4258790 by Ben.Marsh UBT: Clean up the logic around generating project files before creating a stub IPA, so that it fails loudly if project files do not exist, and can accept target names not matching project names. Change 4259276 by Ben.Marsh UBT: Make it an error if a framework doesn't exist, rather than failing silently. Also remove some remote toolchain stuff that's no longer necessary. Change 4259280 by Ben.Marsh UBT: Fix embedded framework zips not being uploaded for plugins. #jira UE-62485 Change 4260236 by Ben.Marsh UBT: Fix path to generated engine project file. Change 4260334 by Ben.Marsh UGS: Fix custom build steps dialog inadvertantly modifying config file settings in-place. Change 4260361 by Ben.Marsh UGS: Allow for p4 login commands to fail, even though the user is logged in (due to a bad connection, etc...) Change 4260559 by Ben.Marsh UGS: Update version. Change 4261160 by Robert.Manuszewski MediaPlaylist will now be added to root set if the owning MediaPlayer is in the disregard for GC set (fixes GC assumption violation crash) #jira UE-62495 Change 4261421 by Ben.Marsh Force-sync files for building documentation, to fix issues with files not being updated. #jira UE-62413 Change 4261425 by Ben.Marsh UBT: Remove some leftover functions for handling the remote toolchain. Change 4261530 by Ben.Marsh UBT: Speculative fix (and better error reporting) for IOS mobile provision not being found in CIS. Change 4261611 by Ben.Marsh UBT: Downgrade warning to a log message, since it appears when generating project files. Change 4261710 by Ben.Marsh Remove assert that GLogConsole is set; it won't be for command line utilities that don't depend on ApplicationCore. #jira UE-62545 Change 4261831 by Ben.Marsh Fix compile errors due to missing include path when hot-reloading a module from the editor. There are not necessarily source files to compile when -modulewithsuffix is specified on the command line, which was results in GeneratedCodeWildcard not being set. #jira UE-62463, UE-62384 Change 4262723 by Ben.Marsh Whitelist plugins that need to be loaded by UFE. #jira UE-62564 Change 4265444 by Ben.Marsh Fix incorrect executable name for DebugGame configurations in Xcode. #jira UE-62574 Change 4265892 by Ben.Marsh Fix incremental compile failures due to dependency checking for unity files. CachedIncludePaths was not correctly being set on file items, so dependencies were being ignored. #jira UE-62575, UE-62603, UE-62597 Change 4266019 by Josh.Adams - Fixed the CopyAction for runtime dependencies that need to be copied to different location, on non-XGE Change 4266264 by Ben.Marsh Remove override for the __IPHONE_OS_VERSION_MIN_REQUIRED macro on TVOS. This macro is already defined by system headers (in <AvailabilityInternal.h>). Now that we support PCHs on IOS and TVOS, manually defining this macro results in it being defined three times (once for the PCH, once by AvailabilityInternal.h, and once by the force-included list of definitions for the source file being built). The errors for redefining the macro in AvailabilityInternal.h are suppressed due to it being a system header, but the error for redefining it for the source file being compiled are not. #jira UE-62578 Change 4266273 by Ben.Marsh Fixes incremental build failure when compile arguments for PCH have changed on IOS/TVOS. Compile action needs to have a dependency on PCH build action. Change 4266614 by Graeme.Thornton Fix crash when cooking nativized blueprints due to removal of child cooker system. Change 4266763 by Ben.Marsh Always build UnrealPak when building client targets. The ProjectParams.Pak option is not reliable, because it can be forced on later by the target platform. #jira UE-62584 Change 4267985 by Robert.Manuszewski When iterating with ForEachObjectWithouter, don't lock the entire has table but only the hash bucket that is currently being iterated #jira UE-62600 Change 4268558 by Robert.Manuszewski PurgeLegacyBlueprints will no longer be called from within ForEachObjectWithOuter is it renames objects that reside in hash tables that are being iterated over which may lead to undefined behavior. #jira UE-62600 Change 4269011 by Chad.Garyet - Fixing Wildcard match issue, the change to ugsapi sends projects as //Depot/Stream instead of //Depot/Stream/ Wildcard match was only substringing to 3 chars. - Checking in the change a while back that increases the number of queried jobs up to 432 based on some maths from Bob about how many builds we want to grab Published to ugsapi server 8/8/17 #jira none Change 4270788 by Ben.Marsh Fix IOS provisioning data being using when remote compiling on TVOS. #jira UE-62705 Change 4271916 by Ben.Marsh Tag the XGEControlWorker executable as a build product after compiling SCW, to make sure it's included in the UGS zip file. Change 4271934 by Ben.Marsh Upload all static libraries in plugin folders as part of remote builds. #jira UE-62694 Change 4273368 by Ben.Marsh Fix Slate dependencies not being enumerated, and rules assembly not being rebuilt when building remotely. #jira UE-62705 Change 4274049 by Ben.Marsh Always parse the team UUID out of the mobile provision when doing a remote compile. The provision installed on the remote Mac (and selected for signing) may be different. #jira UE-62751 Change 4274823 by Ben.Marsh Add the -VersionCookedContent argument to disable the -unversioned parameter on the cooker command line. Change 4275838 by Ben.Marsh Fix BuildVersion string not being passed through from <SetVersion> task. Also add a -BuildVersion command line argument to UBT to override it for a particular build. Change 4275913 by Ben.Marsh Add a dummy exported symbol to the XGEController module, to fix build errors due to missing .lib file when it's built with WITH_XGE_CONTROLLER = 0. Change 4284161 by Ben.Marsh Allow mirroring Oodle files to remote Mac. Change 4074774 by Steve.Robb Vast simplification of TFunction, making it smaller in footprint, easier to follow and extend, and more correct. TUniqueFunction added, which is a move-only TFunction which can hold move-only functors. Fix for UWidgetBlueprint::ForEachSourceWidget() which should never have compiled but did. FFunctionGraphTask and TFuture<> updated to use TUniqueFunction to make them more general. TArray::HeapPop() made to work with move-only types. Change 4082591 by Ben.Marsh Move the Log class from UBT to DotNetUtilities. Change 4083236 by Ben.Marsh Add a Log.WriteException() method to dump an exception message to the console (and write the exception trace to the log) Change 4084107 by Ben.Marsh UAT: Remove the unused -SkipHeader argument to UE4Build. Change 4089771 by Steve.Robb GitHub #4743 : modified VirtualAlloc function flag https://blogs.msdn.microsoft.com/oldnewthing/20151008-00/?p=91411 Change 4091456 by Steve.Robb Unification of all platforms' FMath::CountTrailingZeros() and FMath::CountLeadingZeros() for both 32-bit and 64-bit. Change 4156437 by Ben.Marsh Lots and lots of fixes compiling for Clang on Windows. Editor now compiles cleanly without warnings, but crashes on startup due to error in intrinsics test. Disabling that runs further, but crashes accessing freed memory. Switching to the ANSI allocator runs further, but crashes in Slate after the splash screen and before the editor window opens. // TODO! * Switching between Clang/ICL/VS2015/VS2017 is now supported through the same mechanism as switching Visual Studio versions, without requiring any source level changes. To use Clang, set WindowsPlatform.Compiler = WindowsCompiler.Clang from a .target.cs file, or set <WindowsPlatform><Compiler>Clang</Compiler></WindowsPlatform> from BuildConfiguration.xml. To pick a specific toolchain version, set WindowsPlatform.CompilerVersion. * Clang is now supported through AutoSDKs; will be added to CIS. * The Samples/Sandbox/Clang project forces Clang to be used from its target.cs file, and allows easily building all editor modules and plugins with Clang on Windows. * UnrealMathSSE intrinsics have been re-enabled for Clang due to missing functions from the UnrealMathFPU implementation, but causes failure in tests at startup. * SSE4_CRC32() is disabled in D3D12Pipelinestate.cpp, since intrinsics are only allowed if enabled for the whole target (rather than being used in specific functions due to runtime checks) Change 4157389 by Ben.Marsh Few more fixes for compiling the editor with Clang. Change 4183911 by Ben.Marsh Fixes to support incremental linking on Windows. Does not seem to have any net benefit right now; may improve once minimal rebuild is enabled. * Incremental linking no longer forces PDB files to be enabled for source files. * Actions can specify specific files to be deleted before each build. Code to forcibly delete PDB files has been moved to the MSVC toolchain. * Unused libraries produced by the cross-referenced link are no longer added as build products, since (a) deleting them breaks dependency checking for incremental linking and causes a full link, and (b) not deleting them breaks UBT dependency checking and causes actions to be run over and over again. * Icon update is disabled for Windows when incremental linking is enabled. * Removed rarely-used setting to always delete produced items before each build. Change 4184311 by Ben.Marsh UGS: Added a dialog which shows all the required platform SDKs for a branch, linked from the status panel in UGS. The llist is configured via the UGS config file submitted to Engine/Programs/UnrealGameSync/UnrealGameSync.ini (and may be overridden by the project config file if necessary): [Default] ; Set this to a network share which contains the SDK installers for your site SdkInstallerDir= ; All the required SDKs for the current version of the engine +SdkInfo=(Category="Android", Description="NDK r21", Browse="$(SdkInstallerDir)\\Android") +SdkInfo=(Category="Windows", Description="Visual Studio 2017") +SdkInfo=(Category="Windows", Description="Visual C++ Toolchain 14.13.26128") +SdkInfo=(Category="Windows", Description="Windows SDK 10.0.16299.0") Similar entries for console platforms are added in console subdirectories. Each entry may contain an Install="Foo.exe" and/or Browse="C:\Foo" style attribute, specifying the path to an installer to run or directory to open in explorer respectively. The SdkInstallerDir setting is used as a base directory for the default installers, seen above for Android. Licensees may override this with a network path specific to the site that UGS is being deployed to (either in this file, in a project specific config file, or in a Engine/Programs/UnrealGameSync/NotForLicensees/UnrealGameSync.ini file). Change 4200452 by Ben.Marsh UBT: Change DebugGame configurations to output a separate executable rather than requiring a -Debug argument at runtime. Previous behavior was a common source of errors. Engine modules are still shared between Development and DebugGame, but the launch module sets a flag in Core on startup indicating the game configuration. Change 4206189 by Ben.Marsh UBT: Simplify logic for precompiling binaries. * Target no longer has separate list of "precompile only" binaries or modules. New -AllModules option allows adding every module to a target, which can be used with -Precompile and -NoLink to precompile object files for monolithic builds. * Precompiled file lists have been removed from target receipts. * The manifest now includes all generated headers and precompiled files when run with the -Precompile option. * Separate -DependencyList=Foo.txt has been added to write a list of all dependencies required to use precompiled binaries. This file list can be read using the <Tag> task in buildgraph. Change 4215466 by Ben.Marsh UBT: Remove indirect calls to determine extensions for object files and precompiled headers. The toolchain knows the correct convention for the platform. Change 4215975 by Ben.Marsh UBT: Remove telemetry code. This has never proved useful for analyzing performance due to the number of incidental factors that affect build times (eg. number of files being compiled). Change 4220154 by Ben.Marsh Move text-only implementations of FOutputDeviceError back into Core, so we can build command-line applications that don't depend on ApplicationCore. Change 4224708 by Ben.Marsh Add a bCompileAgainstApplicationCore setting to the target rules, which allows compiling out references to the ApplicationCore module (which should only be necessary for applications with a GUI). Removed ApplicationCore from several engine tools and utilities. Change 4224958 by Ben.Marsh Remove CoreMinimal.h includes from Core. Change 4229059 by Ben.Marsh UBT: Remove the UEBuildPlatform.ShouldNotBuildEditor() hook for target platforms. We shouldn't be modifying a target's build environment to disable the editor; it is invalid to build the editor for these target platforms at all, and this is already enforced by the GetSupportedPlatforms() function. Change 4230508 by Ben.Marsh Fixup precompiled header setting for samples and games. Change 4231457 by Ben.Marsh Fix exceptions in log messages having trailing newlines. Change 4232406 by Ben.Marsh UBT: Always force include a PCH for generated code if there's one set; the code may depend on it to compile. Change 4234177 by Ben.Marsh Set up private PCH files everywhere that previously used them. Change 4235973 by Ben.Marsh Change FPlatformMisc::GetEnvironmentVariable() to return an FString() rather than requiring a fixed size buffer to be passed in. Removes references to MAX_PATH. Change 4238842 by Ben.Marsh Add support for paths longer than MAX_PATH in the editor. Requires Windows 10 version 1607, and the functionality to be enabled via a registry key or group policy (see https://docs.microsoft.com/en-us/windows/desktop/FileIO/naming-a-file). Only a subset of Win32 functions support long paths (executables can only be started from paths shorter than MAX_PATH, for example). * Added a FPlatformMisc::GetMaxPathLength() function to return the maximum length of a path on the current system. On Windows, this returns a different value for systems with long paths enabled to those without. * The MAX_PATH define is no longer set by non-Windows platforms. Instead, there is a MAC_MAX_PATH, UNIX_MAX_PATH, etc... for any platform-specific code that still relies on the previous macro. * The MAX_UNREAL_FILENAME_LENGTH macro has been renamed to MAX_UNREAL_FILENAME_LENGTH_DEPRECATED * The PLATFORM_MAX_FILEPATH_LENGTH macro has been renamed to PLATFORM_MAX_FILEPATH_LENGTH_DEPRECATED. * Removed custom resource files for programs, since they are just copies of the base UE4 one (which is used by default anyway). The base UE4 manifest declares support for long paths. * Fix 512 character maximum length on editor commands. 260 character limit remains in place for cooking at the moment (see ContentBrowserUtils.h), until C# staging code supports long paths. Change 4255042 by Ben.Marsh UBT: Remote compilation now uploads the entire workspace to the remote Mac and executes a separate remote instance of UBT rather than synchronizing individual actions. This makes the remote compile codepath much simpler, and removes a lot of special cases that exist to support it previously. The list of files to be transferred to the remote are listed as rsync filter rules in Engine/Build/Rsync/RsyncEngine.txt and RsyncProject.txt, which are applied to the root engine directory and project directory respectively. Projects that need to customize which files are uploaded can add their own <ProjectDir>/Build/Rsync/RsyncProject.txt file, which will be included in the filter before the default version. Change 4260567 by Ben.Marsh UAT: Rename CommandUtils.Log to CommandUtils.LogInformation, to avoid conflicts with the underlying Tools.DotNETCommon.Log class. #rb none [CL 4285673 by Ben Marsh in Main branch]
2018-08-14 18:32:34 -04:00
LogInformation("Client is supposed to exit, lets wait a while for it to exit naturally...");
for (int i = 0; i < 120 && !ClientProcess.HasExited; i++)
{
Thread.Sleep(1000);
}
}
if (ClientProcess != null && !ClientProcess.HasExited)
{
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 4285612) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3836829 by Ben.Marsh UBT: Fix ability to precompile plugins from installed engine builds. Change 3839519 by Ben.Marsh UBT: Simplify configuring bPrecompile and bUsePrecompile settings for modules. Each rules assembly can now be configured as installed, which defaults the module rules it creates to use precompiled data. Change 4042043 by Steve.Robb GitHub #4705 : Added weak lambda's for delegates and multicast delegates. Change 4042056 by Robert.Manuszewski Optimized Mark Phase of GC by up to 10ms by making it run in parallel and removing a huge array presize which we didn't need. Change 4042104 by Robert.Manuszewski Set the minimum GC cluster size to 5 so that GC doesn't have to process micro clusters which are more expensive than processing individual objects + Exposed the minimum cluster size to ini and project settings as gc.MinGCClusterSize + Added the ability to sort clusters by name/object count/mutable object count/referenced clusters count when dumping them with gc.ListClusters command Change 4042377 by Robert.Manuszewski Reworked how GC and other threads (ALT specifically) interact - GC will now notify the ALT it wants to run and ALT will immediately try to finish its current work to allow that. Also the entire ALT tick is now protected against GC running at the same time to improve ALT stability. + added gc.ForceCollectGarbageEveryFrame console variable that triggers a forced GC every frame Change 4042427 by Robert.Manuszewski Changed FGCCSyncObject to use events when waiting for GC to finish so that it doesn't spin on non-game threads when GC is running Change 4042482 by Robert.Manuszewski Unhashing unreachable objects (ConditionalBeginDestroy) will now also be done incrementally, just like the purge phase of Garbage Collection Change 4042635 by Robert.Manuszewski Fix for a potential assert when incremental purge garbage is pending and something forces a full purge Change 4044092 by Steve.Robb Fix for forward declared CoreUObject weakobject types in delegates when building in Clang. Change 4044102 by Robert.Manuszewski Fix for a possible hang when worker threads are preventing GC from running and something is later trying to FlushAsyncLoading with the Async Loading Thread enabled Change 4044113 by Steve.Robb Another Clang fix. Change 4044160 by Robert.Manuszewski Disregard For GC pool will now be enabled by default in cooked builds Change 4044287 by Steve.Robb Typo fix. Change 4047723 by Graeme.Thornton TBA: Fixes for import/export name cache and object resolving Change 4048015 by Graeme.Thornton TBA: Weak/Soft/Lazy pointer serialization changes * Remove FWeakObjectPtr::Serialize, move it's logic into, and replace usages of with calls to, FArchiveUObject::SerializeWeakObjectPtr(). Ensures that something is always sent to the archive so that structured archives can be kept happy in the future. * Added Weak/Soft/Lazy pointer handling to the structured archive slot interface and all the formatters. Binary formatters just forward the call onto their inner and text archives store as a string path reference. * FArchiveUObjectFromStructuredArchive caches all these pointer types and stores indices in the binary block, same as with a UObject*. All pointers are then forwarded to the underlying formatter in one go on finalization. Change 4048021 by Steve.Robb Fix for binding an unbound TFunction to another TFunction with a different signature. Also all null pointers now count as unbindings, not just nullptr. TIsMemberPointer added. TIsATFunction and TIsATFunctionRef renamed to remove the 'A's. Change 4048544 by Robert.Manuszewski Fixing ConditionalBeginDestroy profiling after changes to incremental CBD. Change 4051028 by Graeme.Thornton TBA: ArchiveFromStructuredArchive adapter uses Inner to determine if it is outputting to text, and sets it's own ArIsTextFormat to false Change 4051056 by Graeme.Thornton TBA: High level tagged property / UObject base class text serialization - UObject serialize converted to structured archive - Properties written to text individually with text tags, and then binary adapted values - Only saves, doesn't load Change 4051111 by Graeme.Thornton TBA: Temporarily disable loading of text assets until tagged property serialization path is fixed up Change 4051154 by Graeme.Thornton TBA: Convert a few uobject serializers to structured archive format for example purposes Change 4051181 by Graeme.Thornton TBA: Added default structured archive implementation of SerializeItem to UProperty, which just calls the FArchive version on an FArchiveUObjectFromStructuredArchive adapter. Implemented structured archive SerializeItem for UArrayProperty Change 4051197 by Graeme.Thornton TBA: ObjectProperty text serialization Change 4051216 by Graeme.Thornton Restored a modified FWeakObjectPtr::Serialize function to keep backwards compatibility in code I don't have access to. Change 4051261 by Graeme.Thornton TBA: Convert UMetaData to structured archive Change 4051374 by Steve.Robb Incorrect assert removed. Change 4051562 by Robert.Manuszewski Adding stats for the new GC internal functions Change 4051614 by Graeme.Thornton TBA: Removed UProperty::SerializeItem(FArchive, ...) and replaced with UProperty::SerializeItem(FStructuredArchive::FSlot, ...). Fixed up most of them to work properly and added adapters in for any that were non-trivial. Change 4052512 by Graeme.Thornton TBA: Temporary workaround for softobjectptr and lazyobjectptr uproperties not serialization anything when they know the archive is a reference collector. They should always be serializing their pointers and letting the underlying archive itself ignore them. Change 4053917 by Robert.Manuszewski Clustered objects from clusters that are no longer reachable will now be marked as unreachable immediately when gathering unreachable objects Change 4053919 by Robert.Manuszewski Added the ability to disable incremental BeginDestroy in ini/project settings Change 4055518 by Daniel.Lamb Fixup for deterministic audio generation issue. Submitted on behalf of Rich.Whitehouse #jira nojira #test prefilght automated test. Change 4056854 by Graeme.Thornton TBA: Added a test asset to EngineTest which contains all the different property types and test cases. Change 4056858 by Graeme.Thornton TBA: Updated USetProperty to proper structured archive usage Change 4056872 by Graeme.Thornton TBA: Add map property field to test object Change 4056873 by Graeme.Thornton TBA: Convert UMapProperty to full structured archive Change 4056994 by Graeme.Thornton TBA: Converted FText over to structured archive. Implemented saving, but not loading. Change 4059728 by Ben.Marsh UBT: Add support for using adaptive non-unity builds when the engine and project are in separate repositories. Change 4059805 by Graeme.Thornton Fixed typo in text serialization. Fixes CIS automation test errors Change 4060007 by Graeme.Thornton TBA: FArchiveFromStructuredArchive will now access it's host slot lazily, i.e. only when a value is actually written to the archive. Change 4060092 by Stefan.Boberg Added optimized Windows console window output path to GenericConsoleOutput since this slowed down cooking considerably (2 minutes spent in wprintf alone for one large dataset) When stdout is attached to a console we use the WriteConsoleW function instead of wprintf since the latter is very slow especially in unbuffered mode which the engine currently configures for stdout (see setvbuf call in LaunchEngineLoop.cpp). At some point we should reconsider this buffering policy since it's likely to slow down other platforms as well but I wanted to do a safe change for now as I don't yet fully understand why the setvbuf call is there in the first place. Change 4060108 by Stefan.Boberg Introduced some additional target platform utilities to help with asset cook optimizations * We now assign each ITargetPlatform a zero-based ordinal value * Introduced FTargetPlatform and FTargetPlatformSet types to help store platform references and platform sets efficiently. These are not currently used in the engine but are designed to replace the existing ITargetPlatform/string/FName representations in the cooking data structures. Change 4060143 by Graeme.Thornton Undo //UE4/Dev-Core/Engine/Source/Runtime/... changelist 4060007 Needs some other changes that I haven't checked in yet... Change 4062432 by Ben.Marsh Fix error message when enumerating P4 changes. Change 4062648 by Ben.Marsh Add missing p4 integration action. Change 4063620 by Graeme.Thornton Integrated a fix from UDN where the engine would crash when trying to load a very small encrypted file (<16bytes) from a pak file, where the read address wasn't already aligned to the AES block size. (https://udn.unrealengine.com/questions/431989/crash-while-reading-a-very-small-file-in-encrypted.html) Change 4066963 by Robert.Manuszewski Fixing GC cluster verification code reporting false positives when a cluster is referencing another cluster through 'mutable' objects list. Change 4067133 by Robert.Manuszewski Changed log verbosity when reporting individual cases of GC cluster assumption violations as they are followed by an asser anyway and this way we get the chance to see all issues before we assert at the end of these checks. Change 4067443 by Steve.Robb FString can now be constructed from any char pointer type and length. Change 4068156 by Steve.Robb Fix necessary because of FString constructor change in CL# 4067443. Change 4070258 by Graeme.Thornton Fixes for VSCode Change 4070372 by Graeme.Thornton TBA: Script struct serialization to structured archives Change 4071913 by Ben.Marsh Move bulk of the code for UnrealPak into an engine developer module, so it can be used in the editor. Change 4071914 by Ben.Marsh Missing files. Change 4071937 by Ben.Marsh Missing header. Change 4072015 by Ben.Marsh Fixes for compiling PakFileUtilities as part of the editor. Change 4072826 by Steve.Robb TBitArray::Reserve() added. TBitArray::Add() overloaded to allow adding multiple bits. TSparseArray::Reserve() optimized to call the overloaded Add(). Change 4073271 by Daniel.Lamb Fixed add patch tier in project launcher passing the wrong commandline option to UAT. #test none Change 4074708 by James.Hopkin #core Removed redundant Casts Change 4074763 by Steve.Robb Fix for TSparseArray::Reserve() size. Change 4076063 by Ben.Marsh Add an "UnrealPak" commandlet with the same functionality as the standalone UnrealPak program. Invoke by running the editor with -run=UnrealPak and the standard UnrealPak commandline options. Change 4077064 by Robert.Manuszewski Fixing compile error in PakFileUtilities Change 4077144 by Graeme.Thornton TBA: TextAssetCommandlet improvements * Collect lists of broken assets during roundtrip tests and print a summary of packages that failed each phase at the end * After resaving as text, load the file back as a plain JSON hierarchy to ensure the output was valid Change 4077412 by Ben.Marsh Set the correct exit code for UnrealPak. Should return 0 on success, not 1. Change 4077760 by Graeme.Thornton TBA: Loading fixed for tagged property serialization Includes conversion of all UProperty::ConvertFromType() and SerializeFromMismatchedTag() functions to use structured archives Lazy initialization of FArchiveFromStructruredArchive when loading, to support the possibility of an adapter being create around an object property serialize call to its inner UStruct, which then decides not to do anything and return false. Stops the ArchiveFromStructuredArchive from consuming the slot and getting upset later on when we try to serialize normal tagged properties from it. Disabled lazy bulk data loading from text assets. Requires a bigger change to make it work. Added some debug checks to json input formatter which track the current value stack size when a new object is pushed onto the stack, and makes sure that the stack has returned to the same size when the object is popped. Catches cases where we unpack an array/stream to the value stack but then don't consume all the items. Change 4078800 by Ben.Marsh Change UAT to using the editor's UnrealPak commandlet rather than invoking the standalone UnrealPak executable. To improve performance when building several PAK files, also add a new -batch=<file> command which reads commands to execute in parallel from a text file. Change 4079745 by Graeme.Thornton TBA: Migrated a couple of UObject Serialize functions to FStructuredArchive (SoundCue / MaterialExpressions / Editor strip flags) Change 4079847 by Graeme.Thornton TBA: Add 'FindMismatchedSerializers' mode to text asset commandlet, which dumps out a list of all UClasses which don't have the CLASS_MatchedSerializers flag, meaning we can't guarantee the have Serialize functions for FArchive AND FStructuredArchive, therefore we can't use the new structured archive based serialize path. Should only ever be native instrinsic classes as UHT takes care of all other cases. Change 4079925 by Ben.Marsh Fix incorrect assignment when deriving name for chunked pak file. Change 4080214 by Ben.Marsh Move the ThreadPoolWorkQueue class into DotNETUtilities so it can be used by other projects. Change 4082394 by Graeme.Thornton CIS fix for variable shadowing warning Change 4082583 by Ben.Marsh Add a IBinarySerializable interface for types that support reading from a BinaryReader and writing to a BinaryWriter. Implementing IBinarySerializable implies a constructor taking a BinaryReader argument is available for deserializing. Change 4082652 by Ben.Marsh Fix FileReference.Directory not returning a directory with a trailing backslash for files in the root directory. Change 4082755 by Graeme.Thornton Fixed an erroneous usage of TUniquePtr<uint8>as a pointer to a uint8 array when creating pak files. Caused a crash when compression was enabled, and has probably surfaced because pak generation is now done by an editor commandlet rather than a standalone program. Change 4082756 by Graeme.Thornton Fixed some incorrect documentation for pakfile compressed chunk headers Change 4082883 by Graeme.Thornton Static analysis warning fix Change 4082912 by Ben.Marsh Move ExceptionUtils into DotNETUtilities. Change 4085291 by Graeme.Thornton TBA: In the Json output formatter, write float and double values out with enough precision for successful roundtripping. Added some debug only code which will immediately reconvert the string back to its original value and compare the the input Change 4085523 by Graeme.Thornton TBA: Remove only explicit usage of DECLARE_FSTRUCTUREDARCHIVE_SERIALIZER. Should only be used from UHT generated code. Change 4086037 by Robert.Manuszewski Fix for a potential race condition when two threads want to acquire GC lock Change 4088655 by Graeme.Thornton Pak creation now uses the bEnablePakSigning setting from the crypto config json file Change 4091474 by Steve.Robb Fix for TStaticBitArray::FindFirstSetBit() and TStaticBitArray::FindFirstClearBit(). Unused variables removed. Change 4093632 by Steve.Robb CIS fixes. Change 4093656 by Graeme.Thornton Build fix Change 4093744 by Ben.Marsh Allow per-chunk settings for whether to enable compression in UnrealPak. Change 4099712 by Gil.Gribb UE4 - Fixed rare case where insufficient space was preallocated for cooldown ticks. #jira UE-59686 Change 4099912 by Stefan.Boberg Cooking timer optimizations: - Replaced data structures for FScopeTimer and FHierarchicalTimerInfo. Previous implementation used FString for many things and caused *lots* of heap and string concatenation activity. Replaced with a compile-time node id (using __COUNTER__) and raw string literals. - Removed PERPACKAGE_TIMER support (was disabled by default and was difficult to test) - Made it possible to toggle OUTPUT_TIMING and ENABLE_COOK_STATS independently - Removed some extremely tight timers because the overhead from calling QPC significantly exceeded the measured code This change shaved some 15% off a clean cook of Fortnite WindowsClient (en) with fully populated local DDC Change 4100519 by Stefan.Boberg Quick fix for Linux build issue introduced in 4099927 Change 4105327 by Stefan.Boberg Cooker: Changed FHierarchicalTimerInfo so it uses a linked list for tracking child nodes, to be able to deal with any child count. Previously we assumed there would never be more than 9 children but it turns out there are cooker modes that need more. Fixes check when using -FullLoadAndSave to cook Change 4105448 by Stefan.Boberg - Fixed Linux build warning re: member initialization order - Also eliminated OUTPUT_HIERARCHYTIMERS/CLEAR_HIEARCHYTIMERS macros (plain functions are fine) - Moved finishing-up code for FullLoadAndSave() to TickCookOnTheSide() call site to improve timer output. Previously some of the scopes would not have been closed before printing and thus the output was misleading. Change 4109031 by Ben.Marsh Attribute-driven Perforce wrapper (old Epic Friday project). Offers a more complete implementation than the current P4 wrapper in UAT without requiring any platform-specific libraries. Uses the Python binary output for parsing. Change 4109588 by Ben.Marsh UBT: Add extension methods for serializing a nullable type to a BinaryReader/BinaryWriter. Change 4109595 by Ben.Marsh Missing project file for DotNETUtilities. Change 4110724 by Stefan.Boberg Removed annotation map locking in UObjectMarks, eliminating around one minute (~3.5%) from Fortnite cook time. The locking was redundant since the annotation maps are managed per thread anyway. Change 4111304 by Ben.Marsh UAT: Add support for setting a status message through the log class. Allows writing transient messages (eg. progress messages) which will be cleared out before writing other messages. Best used through the LogStatusScope class, which can set a status message for the duration of a using() block. As part of this change, the console no longer has to be added as a dedicated trace listener. Since we already special-case this listener when formatting log output, it's easier to just keep the implementation separate to the other trace listeners. Change 4112708 by Steve.Robb Fix for TBitArray::MaxBits in assignment. Change 4114133 by Stefan.Boberg Tweaked how low-level memory (LLM) tracker is implemented to reduce overheads. Previously FMemory functions would acquire the LLM singleton and call OnLowLevelFree/OnLowLevelAlloc etc which would check the bIsDisabled flag and early out if it was set. Due to how frequently these functions were called this ended up costing quite a bit. - This change makes the flag a static member variable instead of a member variable and therefore enables a simpler early-out to be implemented. - The singleton getter is also simplified to avoid hitting the threadsafe singleton construction path on every call. - The enable flag is no longer TAtomic - this also incurs extra overhead for no clear benefit Shaves approximately 3.5% (one minute) off a Fortnite cook test scenario (using -FullLoadAndSave) Change 4115010 by Robert.Manuszewski Fixing CIS Change 4115249 by Robert.Manuszewski Fixing async loading code asserts when exiting game very early due to an error #jira UE-56267 Change 4117091 by Ben.Marsh Prevent doubled-up lines when writing status updates with console log verbosity. Change 4117207 by Ben.Marsh UGS: Do not include executables in diagnostics zip file, and ignore "no such files" error when cleaning workspace. Change 4119175 by Ben.Marsh UGS: Fix crash writing version files when directory does not already exist. Change 4119987 by Ben.Marsh UGS: Show a dialog box while the launcher is updating executables from Perforce, which allows cancelling the operation if necessary. Allow setting the username on the settings window, and prompt for login credentials if necessary. Should prevent situations where users have to update settings from the command prompt. Holding down shift during launch now shows the settings dialog rather than an immediate prompt to launch the unstable version (unstable version is shown as a checkbox on this dialog). Change 4119991 by Ben.Marsh Update version number for UGS launcher to 1.13. Change 4121943 by Robert.Manuszewski Don't use FArchiveAsync2 for reading packages with non-async path in editor builds as its performance is worse than the standard archive's (saves about 1 minute when doing larger cooks and 7 seconds when loading into PIE) Change 4122592 by Steve.Robb GitHub #4762 : Improve wording and grammar of Math comments Also includes improved accuracy in FMath::ComputeBoundingSphereForCone(). Change 4122819 by Stefan.Boberg Don't call CreateDirectory redundantly when opening files for writing using FFileManagerGeneric::CreateFileWriter This change avoids calling IPlatformFile::CreateDirectoryTree if possible since this is a very expensive function especially for deep hierarchies as it performs directory creation from the root directory onwards instead of from the leaf downwards. That function should also be fixed but this change improves performance in the meantime. Change 4122872 by Stefan.Boberg CreateDirectoryTree now creates directories leaf-to-root instead of the other way around. This is much more efficient since we don't spend time on system API calls for directories which already exist. This accounted for a very large amount of CPU time in cooking as the full target file directory hierarchy would be "created" for every single output file. Change 4123109 by Stefan.Boberg - Disable overlapped I/O in editor / cooker. Synchronous I/O reduces the number of syscalls and Windows performs prefetching on our behalf anyway for sequential reads - Eliminated syscall which was issued for every write to update cached file size -- since we're the only writers to the file (file access allows read sharing at most) we can authoritatively update the file size on write completion Change 4123455 by Ben.Marsh PR #4775: New build param PCHMemoryAllocationFactor to set /Zm VS build param. (Contributed by lucaswall) Change 4124207 by Ben.Marsh UBT: Remove some unnecessary indirection for generated code paths. Change 4124217 by Ben.Marsh UBT: Remove another unused variable from UEBuildModuleCPP. Change 4124377 by Stefan.Boberg In IPlatformFile::DeleteDirectoryRecursively, attempt to delete file first and if it fails clear the readonly flag and try again Previously there was a call to clear the readonly flag for every deleted file and this is a waste of resources 99% of the time. The SetFileAttributes call accounted for a significant amount of time during cooker sandbox directory deletion Change 4125071 by Stefan.Boberg Some tweaks to FQueuedThreadPoolBase scheduling and memory management - Explicitly pass in false for TArray::RemoveAt(..., bool bAllowShrinking) argument to prevent memory reallocation when arrays are drained and inevitably repopulated shortly afterwards - Use a MRU strategy instead of LRU when picking a thread to wake up. The MRU thread is the most likely to have a 'hot' cache for the stack etc. Picking from the back of the array also happens to be cheaper since no memory movement is necessary when RemoveAt is called. (This was the strategy in place before CL2600362 which seems to have changed it unintentionally) - Release lock as soon as a thread has been chosen, before asking the worker thread to wake up and do the work Change 4126132 by Ben.Marsh UAT: Detect when stdout is redirected and prevent using backspace characters to move the cursor. Change 4126867 by Graeme.Thornton TBA: Fix tagged binary formatter Change 4127010 by Robert.Manuszewski AnimScriptInstances created at runtime will now also be added to the owning omponent's cluster to avoid GC issues. Change 4127932 by Ben.Marsh WorkspaceTool: Reduce unnecessary logging of status messages when console output is not redirected. Change 4129050 by Ben.Marsh UGS: Check for NET Framework 4.5 being installed before running the installer. Also fix warning trying to kill existing UGS instances before upgrade. Change 4129459 by Graeme.Thornton TBA: TextAssetCommandlet - When outputting converted assets to an output path, replicate the workspace relative path in the output directory Change 4129515 by Graeme.Thornton TBA: Add EnterRecord overload that allows outputting of available field names when loading. Change 4129517 by Graeme.Thornton TBA: Tagged properties are written out as named fields on the "Properties" record, rather than as a stream with a null tag at the end Change 4129518 by Graeme.Thornton TBA: Added a local const bool to allow easy hacking out of text asset loading support Change 4129558 by Graeme.Thornton TBA: Build fix for textasset-less configs Change 4129614 by Ben.Marsh UGS: Main window is now restored to normal size when activated by clicking on the tray icon. #jira UE-60490 Change 4129618 by Ben.Marsh UGS: Speculative fix for unreproduced exception accessing disposed window while shutting down. Change 4131936 by Robert.Manuszewski Removing some WIP code accidentally checked in with CL #4121943 Change 4133490 by Ben.Marsh UGS: Allow the $(Change) variable to be used in more places than just the context menu. #jira UE-60573 Change 4133550 by Ben.Marsh UGS: Setting for whether or not to use incremental builds is now exposed through the variable "$(UseIncrementalBuilds)" for use by custom build steps. #jira UE-60554 Change 4133681 by Ben.Marsh UGS: A per-project list of folders and extensions to be deleted by default when running the 'clean workspace' tool can now be specified through the <ProjectDir>/Build/UnrealGameSync.ini file. Settings may be specified for an individual branch (via a category with the depot path to the project) or for wherever the project is currently open (via the [Default] category). The SafeToDeleteFolders list specifies a substring that will be checked against folder paths. Anything containing this folder will be marked as safe for delete by default. The SafeToDeleteExtensions list specifies a list of extensions for files that can always be deleted. Example: [Default] +SafeToDeleteFolders=/MyGame/Test/ +SafeToDeleteFolders=/DataService/ +SafeToDeleteExtensions=.xx1 +SafeToDeleteExtensions=.xx2 #jira UE-60575 Change 4135449 by Ben.Marsh Fix allowing use of Job objects on Windows platforms (debug code submitted by mistake) Change 4135730 by Ben.Marsh UBT: Plugins can now be enabled and disabled from the .target.cs file (for targets that do not use the shared compile environment), by compiling the list of enabled/disabled plugin names into the Projects module. Change 4135823 by Ben.Marsh UBT: Remove legacy code to handle disabling optional plugins; now that this is compiled into the target, it will work for any plugins we choose. Change 4135945 by Ben.Marsh UBT: Fix error running programs with no explicitly enabled or disabled plugins. Change 4137207 by Ben.Marsh UGS: Align all badges with the same name, to make it easier to see which CIS steps are being run. Allow overriding the slot taken by a particular badge by calling it "SlotName:LabelName". Change 4137311 by Stefan.Boberg Removed child cooker support. In practice it is not a useful feature as it provides no performance improvement (quite the opposite in fact) and adds testing and maintenance complexity. Change 4137393 by Ben.Marsh UGS: Fix display of multiline errors in the status panel. Change 4141708 by Steve.Robb GitHub #3631 : Incorrect default argument in WeakObjectPtrTemplate #jira UE-45490 Change 4146655 by Stefan.Boberg Removed FullGCAssetClasses logic - no longer necessary nor useful Change 4147318 by Ben.Marsh UGS: Compress build badges in a column if it shrinks below the size that they would be visible. Change 4148207 by Ben.Marsh UGS: Added support for showing the latest completed build from a specific list of badges in the status panel. To declare a badge as one that should appear in the status panel rather than the CIS column, add it to the project's UnrealGameSync.ini in the project or [Default] section like so: +ServiceBadges=RoboMerge Change 4148282 by Stefan.Boberg Fixed bug in UCookOnTheFlyServer::GetCookOnTheFlyUnsolicitedFiles - UnsolicitedFiles should be passed by reference not by value Change 4148344 by Stefan.Boberg Fixed minor indentation error (most likely caused by sloppy merge) Change 4148521 by Stefan.Boberg Removed accidentally checked in PRAGMA_DISABLE_OPTIMIZATION from CookOnTheFlyServer.cpp Change 4148639 by Ben.Marsh UGS: Fix tooltips not showing for changes that have description badges. Change 4149373 by Ben.Marsh UGS: Allow adding additional columns to display particular badges by adding entries from the project config file. Example syntax: +Columns=(Name="Desktop",MinWidth=50,DesiredWidth=100,Weight=3,Badges="Editor") +Columns=(Name="Mobile",MinWidth=50,DesiredWidth=100,Weight=3,Badges="IOS,Android") Same form can be used to control how default columns are displayed (though badge settings are ignored). Also allow PerforceMonitor to detect local changes to project config files and update settings automatically. Change 4149399 by Ben.Marsh UGS: Update version to 1.143. Change 4155660 by Steve.Robb PROJECTION and PROJECTION_MEMBER macros which provide the correct behavior when creating projections using functions which are overloaded or use default arguments. Change 4157117 by Ben.Marsh Fix warning due to plugins disabled in .target.cs file. Change 4158011 by Ben.Marsh UBT: Add a check that the UnrealHeaderTool target file exists, rather than throwing an exception when reading it fails. Change 4158646 by Ben.Marsh UGS: Fix exception when login is discovered to have expired during a workspace update. Change 4158678 by Ben.Marsh UGS: Fix an exception on shutdown due to the icon being hidden after it's already been disposed. Change 4158683 by Ben.Marsh UGS: Add an unhandled exception filter which sends the exception data to the backend. Change 4159131 by Ben.Marsh UGS: Reduce the number of characters displayed for build badges based on the available space. Change 4159194 by Graeme.Thornton TBA: Fix incorrect map property conversion code when converting an old property that contains a map with different key/value types Change 4159239 by Steve.Robb Improved readability and compliance with coding standards. Change 4159246 by Ben.Marsh UGS: Allow syncing projects where source code is not available (and various version files don't exist). #jira UE-60985 Change 4159286 by Ben.Marsh UGS: Remove requirement for UE4Editor.target.cs to be visible in the depot in order to open a project. #jira UE-60986 Change 4159302 by Ben.Marsh UGS: Update version to 1.144. Change 4160308 by Ben.Marsh All staging client executables for blueprint projects. #jira UE-60983 Change 4161567 by Steve.Robb GitHub #4816 : UE-60771: Handle escaped double quote in FParse::LineExtended Change 4162641 by Ben.Marsh UGS: Allow customizing the position of custom columns, via the Index=N attribute. Change 4162647 by Ben.Marsh UGS: Update version to 1.145. Change 4165319 by Robert.Manuszewski PR #4812: Fix inconsistent command-line argument handling under Windows (Contributed by adamrehn) Change 4166150 by Ben.Marsh UGS: Include *.inl when looking for code changes. Change 4166551 by Steve.Robb Whitespace fixes caused by a bad merge. Change 4168483 by Ben.Marsh UGS: Add a more useful error if a file to be synced exceeds the max allowed path length. Change 4168490 by Ben.Marsh UGS: Update version to 1.146. Change 4168551 by Ben.Marsh UBT: Move bBuildLargeAddressAwareBinary into an exposed setting. Change 4168560 by Ben.Marsh UBT: Remove static config variable for controlling which configuration of UHT to use. Change 4171296 by Ben.Marsh UGS: Move the check for overlong paths earlier. Change 4171531 by Ben.Marsh UBT: Fix exception if BuildConfiguration.xml contains an unknown category. Change 4183371 by Robert.Manuszewski Fix for a crash in Async Loading Graph's CheckCycles when GC kicks in on the game thread and forces ALT to exit early Change 4184312 by Ben.Marsh UGS: Update version to 1.148 Change 4184480 by Robert.Manuszewski Removing unused async loading stat Change 4186390 by Ben.Marsh UBT: Format XML validation errors in a format that allows double-clicking on the message in Visual Studio. Change 4188644 by Ben.Marsh UBT: Add the MakePathSafeToUseWithCommandLine() function to UBT. Change 4188647 by Ben.Marsh UBT: Fix exception in target receipt when architecture is null. Change 4189617 by Ben.Marsh Change FileSystemReference, FileReference and DirectoryReference objects to use OrdinalIgnoreCase comparisons without creating a separate copy of the string to compare. The filesystem does not use the invariant culture, and it can produce the wrong results in some cases (the ordinal comparison is faster, too). Change 4189740 by Ben.Marsh UAT: Remote code to build UnrealPak when packaging; we use the editor now. Change 4189860 by Ben.Marsh UGS: Make the filter for excluding automated lighting rebuilds more explicit. Change 4190082 by Ben.Marsh Fixes to allow enabling edit and continue for Windows builds. Have experienced quite a few VS crashes when testing it in editor; not yet recommended for general use. - Allow edit and continue for any configuration, not just debug. - Fixed PDB errors compiling files that use a shared PCH with edit and continue enabled. Path to the generated PDB file was using the wrong directory. - Removed code that tracks PDB output files, since they're modified multiple times during a build. - Enable debug information when compiling generated CPP files, since it causes errors if the shared PCH PDB doesn't have the same option. - Disable support for remote execution of steps that modify the PDB, since the same file has to be modified many times. Remote execution causes the PDB files to be corrupted. Unfortunately, this makes E&C builds significantly slower. #jira Change 4192949 by Ben.Marsh UBT: Minor tidy-up (merging UEBuildBinary.Build and UEBuildBinary.SetupOutputFiles) Change 4193218 by Ben.Marsh Fix formatting. Change 4197252 by Mike.Erwin UAT: Fix log output w/ correct count of non-code projects. #jira none Change 4197941 by Ben.Marsh UGS: Add support for DebugGame editors that have an executable with a DebugGame suffix. Change 4197964 by Ben.Marsh UGS: Prevent attempts to automatically reopen projects while a modal dialog is up, or the workspace is syncing. Change 4198144 by Ben.Marsh UGS: Prevent modal dialogs when login expires in P4, and prompt for password when hitting "retry". Change 4198413 by Ben.Marsh UGS: Always show the main window when launched manually, and run with -RestoreState when launched at startup. Also add a couple more places that save the visibility state, since logging off seems like it can terminate the process abrubtly. Change 4198779 by Ben.Marsh UBT: Allow generating manifests to any arbitrary locations with the -Manifest=<Path> argument. Change 4198825 by Ben.Marsh UBT: Move code to enumerate Slate runtime dependencies into the Slate module. Doesn't need to be done inside core UBT. Change 4199341 by Ben.Marsh UGS: Update version to 1.149 Change 4199642 by Chad.Garyet - Deprecate CISController - Add BuildController to replace CIS GET/POST for builds - Add LatestController, GET does what CIS/GET used to do - Change Latest/GET to return the last 25 builds filtered by project, rather than the last 5000 individual Ids - Latest/GET now returns "LatestData" object instead of array of longs - Updated EventMonitor to match all API changes - Fixed bug where IDs were getting reset to initial startup values every update loop Change 4199663 by Chad.Garyet CIS controller still needs to return an array of longs #jira none Change 4199680 by Ben.Marsh UGS: Update version to 1.150 Change 4200457 by Ben.Marsh Merging CIS fix for non-development configurations. Change 4200472 by Mike.Erwin UAT: fix -skipbuildclient param default It was defaulting to skipbuildeditor's value, likely a copy-paste error. #jira none Change 4202595 by Ben.Marsh Fix static analysis warning due to constant comparison against macro. Change 4203250 by Ben.Marsh UGS: Always show the "Sync Precompiled Editor" option, but disable it and show a tooltip explaining why if it is not available. Change 4206191 by Ben.Marsh Exclude editor target files from installed builds, since they leak info about DLLs that have been stripped out. Change 4213011 by Ben.Marsh UBT: Include contents of modified intermediate files in the log, to make it easier to debug hidden dependencies. Change 4213487 by Ben.Marsh UBT: Fix assumption that bPrecompile is equivalent to bBuildAllModules. This is no longer the case; they are now controlled by separate options. Should fix CIS errors building the editor. Change 4213609 by Ben.Marsh Ensure that strings formatted using FMicrosoftPlatformString::GetVarArgs() are always null terminated, whether we use the secure CRT or not. Change 4215971 by Ben.Marsh UBT: Remove action graph visualization code; no longer used. Change 4215996 by Ben.Marsh UBT: Remove unqiue id from all actions in the action graph. This is only used for printing debug info in the case of a (rare) cycle in the action graph, so just look it up when needed. Change 4216022 by Ben.Marsh UBT: Rename Crypto.cs to EncryptionAndSigning.cs to match the name of the class inside it, and move it under the System folder. Change 4216031 by Ben.Marsh UBT: Move all the action executors into their own folder in the project. Change 4216526 by Ben.Marsh Fix CIS warnings. Change 4216544 by Ben.Marsh Replace custom code to ensure FMicrosoftPlatformString::GetVarArgs() null terminates its buffer with Microsoft's standards-compliant implementation. Change 4216633 by Ben.Marsh Add support for UnrealPak plugins. * Project and plugin modules can now specify an array of supported programs in the "WhitelistPrograms" field of their module descriptors, to allow modules to be loaded by programs. * Programs can now load any runtime modules, as long as they are whitelisted. * Programs under the engine directory can now use a shared build environment, so that building with a project file does not cause output binaries to be output to the project directory. * UnrealPak is now always built by default when packaging * Convert UnrealPak to a modular configuration Change 4216736 by Ben.Marsh UnrealPak: Move "ExportDependencies" command into an editor commandlet, since it relies on the UObject system, asset registry, etc... Change 4217447 by Ben.Marsh Back out revision 50 from //UE4/Dev-Core/Engine/Build/InstalledEngineBuild.xml Change 4217451 by Ben.Marsh Back out revision 11 from //UE4/Dev-Core/Engine/Plugins/Developer/VisualStudioSourceCodeAccess/Source/VisualStudioSourceCodeAccess/VisualStudioSourceCodeAccess.Build.cs Change 4217617 by Ben.Marsh Back out changelist 4217451 Change 4222552 by Ben.Marsh Don't use #import <TypeLib> for VS source code accessor when building with Clang; it's not supported. Change 4222630 by Ben.Marsh UBT: Fix spam while generating project files if Clang isn't installed. Change 4223316 by Ben.Marsh UBT: Change the order in which Visual C++ toolchains are enumerated to prefer full releases over preview releases. Change 4223318 by Ben.Marsh UBT: Add a build setting which allows creating a dedicated PCH for every file that's excluded from the unity working set (disabled by default). Improves iteration times when working on individual cpp files, but slows down iterating on header changes (and can take a lot of disk space for large changes). Dedicated PCH contains all includes scraped from the top of each cpp file, until a non-#include directive is encountered. Change 4223401 by Ben.Marsh UBT: Add an option to automatically enable edit and continue for files in the adaptive non-unity working set. E&C doesn't seem very useful for UE4 projects right now; compile time is comparable to regular build times, but it can take several minutes to apply code changes for large projects. Change 4223899 by Ben.Marsh UBT: Fix loading XML config files on Mono; Type.GetField(Name) does not seem to return values unless binding flags are specified. Change 4224637 by Ben.Marsh Add a "SupportedPrograms" field to plugin descriptors, which allows plugins to declare which plugins they support independently of individual modules. Programs now respect the "bEnabledByDefault" setting in plugins. Plugins that are compatible with a program now need to list that program in the SupportedPrograms list, and whitelist any modules that should load for that program. Change 4224710 by Ben.Marsh UBT: Don't add import libraries as final build products unless the target is being precompiled. Prevents the need for building them for leaf nodes in the action graph. Change 4224715 by Ben.Marsh UBT: Remove hack to allow Stats2.cpp to not follow IWYU convention. Change 4224726 by Ben.Marsh Remove commented out line. Change 4224903 by Ben.Marsh Fix non-unity compile error in Stats2.h. Change 4225051 by Ben.Marsh Back out changelist 4224710; causing CIS errors due to receipts not matching. Change 4225134 by Ben.Marsh Fixing non-unity errors. Change 4225203 by Ben.Marsh Another non-unity fix. Change 4225249 by Ben.Marsh Fix Linux dependencies being copied for the Windows editor; they can be added as requirements for the Linux target platform on Windows instead, so it respects the user's chosen platforms. #jira UE-62001 Change 4225512 by Ben.Marsh BuildGraph: Allow setting the target to build when using the <CsCompile> task. Change 4228815 by Ben.Marsh UBT: Always add the generated code directory to the list of include paths when generating project files. It may only be created after UHT has been run. Change 4228944 by Ben.Marsh UBT: Remove legacy CppCompileEnvironment and LinkEnvironment wrappers from TargetRules that were deprecated in 4.19. Change 4229028 by Ben.Marsh UBT: Fix editor targets with unique build environment having the wrong executable path in generated project files. Move move logic to configure target rules post-construction by the rules assembly to ensure it's valid. Change 4229065 by Ben.Marsh UBT: Move another target setting into the rules assembly. Change 4229105 by Ben.Marsh Fix BPT exception when generating project files. Change 4229311 by Ben.Marsh UBT: Store the module rules file location on the ModuleRules instance, as well as the plugin that it was created from. Also expose the plugin directory as a property on the ModuleRules instance. Change 4229421 by Ben.Marsh UBT: Consolidate functionality for UHT module setup in ExternalExecution.cs. Change 4229817 by Ben.Marsh UBT: Modules must now explicitly specify the path to the header used to generate a PCH if one is desired, rather than the header being determined automatically by attempting to parse the source code. Now that PCHs are force-included anyway, this removes a lot of dependencies inside UBT. Change 4229824 by Ben.Marsh UBT: Remove unused lists inside UEBuildModuleCPP.SourceFilesClass. Change 4229841 by Ben.Marsh UBT: Remove some legacy code from auto-detecting PCHs. Change 4230521 by Ben.Marsh UBT: Add utility functions to the log class to allow formatting errors and warnings in Visual Studio output format (eg. File(Line): warning: Message) Change 4230871 by Ben.Marsh UAT: Remove StreamUtilis utility class; there is a simpler way to implement the one place it's used. Change 4230882 by Ben.Marsh UAT: Add StreamUtils back into UAT, seems like it's still used there. Change 4230896 by Ben.Marsh UBT: Remove some redundant parameters from UEBuildModule/UEBuildModuleCPP/UEBuildModuleExternal constructors. Change 4231014 by Ben.Marsh WorkspaceTool: Include a dump of raw bytes when garbage is read from the P4 process, for diagnostic purposes. Change 4231032 by Ben.Marsh Fix CIS. Change 4231096 by Ben.Marsh Bump the FlatCPPIncludeDependencyCache version, to prevent errors trying to load old files. Change 4231446 by Ben.Marsh UBT: Added support for expanding UE-specific variables in include paths and library paths: $(EngineDir), $(ProjectDir), $(PluginDir), $(ModuleDir). Change 4231460 by Ben.Marsh Modules may now explicitly specify rpaths on Linux via the PublicRuntimeLibraryPaths and PrivateRuntimeLibraryPaths properties. Change 4233909 by Robert.Manuszewski PR #4779: Reason fails as the supplied variable is incorrect (Contributed by projectgheist) Change 4233910 by Ben.Marsh Enable PCHs on IOS. Reduces build time by ~25%. Change 4234176 by Ben.Marsh UBT: Add better messaging for modules that need to have a private PCH set. Now detects the likely PCH using the same method as legacy code and includes it as a suggestion. Change 4234193 by Ben.Marsh Add the Delete command to Perforce wrapper in DotNETUtilities. Change 4234688 by Ben.Marsh UBT: Simplify handling of installed/precompiled builds. Settings for whether a folder is installed/read-only or not is now stored on the RulesAssembly instance, allowing multiple things to be configured separately and stacked together (eg. engine/enterprise/project). RulesAssembly.IsReadOnly() allows determining if a flie can be modified or not and replaces many previous IsXXXInstalledCalls(), and traverses the chain of assemblies. Change 4234711 by Ben.Marsh UBT: Runtime dependencies can now be copied to output directories as part of the build. When adding a runtime dependency, an optional source location can be specified to copy from. Both the source and target paths can use variables can be used as part of the path, eg. $(OutputDir), $(ModuleDir), $(PluginDir). Example usage (from a .build.cs file): RuntimeDependencies.Add("$(OutputDir)/Foo.dll", "$(PluginDir)/Source/ThirdParty/Foo.dll", StagedFileType.NonUFS); Change 4234872 by Ben.Marsh Expose a flag for whether the engine is installed, to fix issues generating project files. Change 4234929 by Ben.Marsh Fix null reference generating receipts when UBT makefiles are active. Change 4235883 by Chad.Garyet Merging 4231245 to core Giving Coordinator its own sln. This should fix what 4158155 was supposed to. #jira UE-61955 Change 4236075 by Ben.Marsh CIS fix Change 4237066 by Robert.Manuszewski Fix for a potential crash when terminating the engine while it's being initialized #jira UE-60545 Change 4237078 by Robert.Manuszewski The engine will no longer be resetting all linkers causing massive load times when renaming the world package when entering Play In Editor Change 4237116 by Ben.Marsh Rewrite some Windows utility functions to support paths longer than MAX_PATH. Change 4237158 by Ben.Marsh Add const TCHAR* overloads of FString::RemoveFromStart() and FString::RemoveFromEnd(). Change 4237159 by Ben.Marsh Fix FWindowsPlatformFile::GetFilenameOnDisk() support for paths longer than MAX_PATH, and simplify some of the other long path functions to avoid copying string buffers. Change 4239050 by Ben.Marsh Missing file Change 4239318 by Ben.Marsh Linux CIS fix. Change 4239685 by Ben.Marsh Static analysis CIS fix. Change 4240800 by Ben.Marsh WorkspaceTool: Include the full command line in the log for any P4 commands. Change 4240903 by Ben.Marsh PR #4909: Update copyright notices to 2018 (Contributed by projectgheist) Change 4241025 by Ben.Marsh UBT: Exclude mobile pipeline caches from generated project files. Causes huge slowdown when using 'Find in Files' through the IDE. Change 4241770 by Ben.Marsh UBT: Include action number in parallel executor output. #jira UE-62032 Change 4243469 by Ben.Marsh TBA: Merge FAnnotatedStructuredArchiveFormatter with FStructuredArchiveFormatter. Any functions that are only implemented for text archives now have a _TextOnly suffix, and are exposed through the FStructuredArchive interface. Change 4245723 by Robert.Manuszewski Fixing another creash when terminating the engine while initializing. #jira UE-60545 Change 4245862 by Steve.Robb VectorLoadFloat2(Ptr) added, which loads { Ptr[0], Ptr[1], Ptr[0], Ptr[1] } into a VectorRegister. Change 4246412 by Robert.Manuszewski The warning 'Calling StaticLoadObject during PostLoad may result in hitches during streaming' will now also report the object which had the PostLoad called on it when StaticLoadObject call happened. Change 4246612 by Ben.Marsh UBT: Fix spelling of "Intellisense". Change 4249454 by Robert.Manuszewski Added extra checks to catch scenarios where the EDL Precache Buffer is flushed before a package header is fully read Change 4249513 by Robert.Manuszewski Made sure the Async Loading Thread doesn't continue running after creating new async packages when garbage collector wants to run on the game thread Change 4255207 by Ben.Marsh UGS: Add additional logging whenever a P4 command fails, and when the user is logged out. Change 4255288 by Ben.Marsh PR #4921: Honor ModuleRules' bEnableExceptions flag when creating precompiled h. (Contributed by surakin) Change 4256422 by Ben.Marsh UBT: Add an error if a module referenced by a plugin descriptor doesn't exist. Change 4257385 by Robert.Manuszewski Creating new objects from within ForEachObjectWithOuter will now result in a fatal error as it's unsafe to change internal UObject hash tables when iterating over them. Change 4257454 by Robert.Manuszewski Added the option to filter clusters listed with gc.ListClusters by objects within them. Usage: gc.ListClusters Hierachy With=ObjectName1,ObjectName2... Change 4257526 by Robert.Manuszewski It's now possible to filter clusters that get logged with verbose cluster logging enabled (UE_GCCLUSTER_VERBOSE_LOGGING=1) by objects within them by specifying -DumpClustersWithObjects=ObjectName1,ObjectName2 in the command line Change 4257822 by Ben.Marsh Fixes for PlatformShowcase compile errors. Change 4258771 by Ben.Marsh UBT: Fix project files not being generated for foreign projects when creating .stub files. #jira UE-62462 Change 4258790 by Ben.Marsh UBT: Clean up the logic around generating project files before creating a stub IPA, so that it fails loudly if project files do not exist, and can accept target names not matching project names. Change 4259276 by Ben.Marsh UBT: Make it an error if a framework doesn't exist, rather than failing silently. Also remove some remote toolchain stuff that's no longer necessary. Change 4259280 by Ben.Marsh UBT: Fix embedded framework zips not being uploaded for plugins. #jira UE-62485 Change 4260236 by Ben.Marsh UBT: Fix path to generated engine project file. Change 4260334 by Ben.Marsh UGS: Fix custom build steps dialog inadvertantly modifying config file settings in-place. Change 4260361 by Ben.Marsh UGS: Allow for p4 login commands to fail, even though the user is logged in (due to a bad connection, etc...) Change 4260559 by Ben.Marsh UGS: Update version. Change 4261160 by Robert.Manuszewski MediaPlaylist will now be added to root set if the owning MediaPlayer is in the disregard for GC set (fixes GC assumption violation crash) #jira UE-62495 Change 4261421 by Ben.Marsh Force-sync files for building documentation, to fix issues with files not being updated. #jira UE-62413 Change 4261425 by Ben.Marsh UBT: Remove some leftover functions for handling the remote toolchain. Change 4261530 by Ben.Marsh UBT: Speculative fix (and better error reporting) for IOS mobile provision not being found in CIS. Change 4261611 by Ben.Marsh UBT: Downgrade warning to a log message, since it appears when generating project files. Change 4261710 by Ben.Marsh Remove assert that GLogConsole is set; it won't be for command line utilities that don't depend on ApplicationCore. #jira UE-62545 Change 4261831 by Ben.Marsh Fix compile errors due to missing include path when hot-reloading a module from the editor. There are not necessarily source files to compile when -modulewithsuffix is specified on the command line, which was results in GeneratedCodeWildcard not being set. #jira UE-62463, UE-62384 Change 4262723 by Ben.Marsh Whitelist plugins that need to be loaded by UFE. #jira UE-62564 Change 4265444 by Ben.Marsh Fix incorrect executable name for DebugGame configurations in Xcode. #jira UE-62574 Change 4265892 by Ben.Marsh Fix incremental compile failures due to dependency checking for unity files. CachedIncludePaths was not correctly being set on file items, so dependencies were being ignored. #jira UE-62575, UE-62603, UE-62597 Change 4266019 by Josh.Adams - Fixed the CopyAction for runtime dependencies that need to be copied to different location, on non-XGE Change 4266264 by Ben.Marsh Remove override for the __IPHONE_OS_VERSION_MIN_REQUIRED macro on TVOS. This macro is already defined by system headers (in <AvailabilityInternal.h>). Now that we support PCHs on IOS and TVOS, manually defining this macro results in it being defined three times (once for the PCH, once by AvailabilityInternal.h, and once by the force-included list of definitions for the source file being built). The errors for redefining the macro in AvailabilityInternal.h are suppressed due to it being a system header, but the error for redefining it for the source file being compiled are not. #jira UE-62578 Change 4266273 by Ben.Marsh Fixes incremental build failure when compile arguments for PCH have changed on IOS/TVOS. Compile action needs to have a dependency on PCH build action. Change 4266614 by Graeme.Thornton Fix crash when cooking nativized blueprints due to removal of child cooker system. Change 4266763 by Ben.Marsh Always build UnrealPak when building client targets. The ProjectParams.Pak option is not reliable, because it can be forced on later by the target platform. #jira UE-62584 Change 4267985 by Robert.Manuszewski When iterating with ForEachObjectWithouter, don't lock the entire has table but only the hash bucket that is currently being iterated #jira UE-62600 Change 4268558 by Robert.Manuszewski PurgeLegacyBlueprints will no longer be called from within ForEachObjectWithOuter is it renames objects that reside in hash tables that are being iterated over which may lead to undefined behavior. #jira UE-62600 Change 4269011 by Chad.Garyet - Fixing Wildcard match issue, the change to ugsapi sends projects as //Depot/Stream instead of //Depot/Stream/ Wildcard match was only substringing to 3 chars. - Checking in the change a while back that increases the number of queried jobs up to 432 based on some maths from Bob about how many builds we want to grab Published to ugsapi server 8/8/17 #jira none Change 4270788 by Ben.Marsh Fix IOS provisioning data being using when remote compiling on TVOS. #jira UE-62705 Change 4271916 by Ben.Marsh Tag the XGEControlWorker executable as a build product after compiling SCW, to make sure it's included in the UGS zip file. Change 4271934 by Ben.Marsh Upload all static libraries in plugin folders as part of remote builds. #jira UE-62694 Change 4273368 by Ben.Marsh Fix Slate dependencies not being enumerated, and rules assembly not being rebuilt when building remotely. #jira UE-62705 Change 4274049 by Ben.Marsh Always parse the team UUID out of the mobile provision when doing a remote compile. The provision installed on the remote Mac (and selected for signing) may be different. #jira UE-62751 Change 4274823 by Ben.Marsh Add the -VersionCookedContent argument to disable the -unversioned parameter on the cooker command line. Change 4275838 by Ben.Marsh Fix BuildVersion string not being passed through from <SetVersion> task. Also add a -BuildVersion command line argument to UBT to override it for a particular build. Change 4275913 by Ben.Marsh Add a dummy exported symbol to the XGEController module, to fix build errors due to missing .lib file when it's built with WITH_XGE_CONTROLLER = 0. Change 4284161 by Ben.Marsh Allow mirroring Oodle files to remote Mac. Change 4074774 by Steve.Robb Vast simplification of TFunction, making it smaller in footprint, easier to follow and extend, and more correct. TUniqueFunction added, which is a move-only TFunction which can hold move-only functors. Fix for UWidgetBlueprint::ForEachSourceWidget() which should never have compiled but did. FFunctionGraphTask and TFuture<> updated to use TUniqueFunction to make them more general. TArray::HeapPop() made to work with move-only types. Change 4082591 by Ben.Marsh Move the Log class from UBT to DotNetUtilities. Change 4083236 by Ben.Marsh Add a Log.WriteException() method to dump an exception message to the console (and write the exception trace to the log) Change 4084107 by Ben.Marsh UAT: Remove the unused -SkipHeader argument to UE4Build. Change 4089771 by Steve.Robb GitHub #4743 : modified VirtualAlloc function flag https://blogs.msdn.microsoft.com/oldnewthing/20151008-00/?p=91411 Change 4091456 by Steve.Robb Unification of all platforms' FMath::CountTrailingZeros() and FMath::CountLeadingZeros() for both 32-bit and 64-bit. Change 4156437 by Ben.Marsh Lots and lots of fixes compiling for Clang on Windows. Editor now compiles cleanly without warnings, but crashes on startup due to error in intrinsics test. Disabling that runs further, but crashes accessing freed memory. Switching to the ANSI allocator runs further, but crashes in Slate after the splash screen and before the editor window opens. // TODO! * Switching between Clang/ICL/VS2015/VS2017 is now supported through the same mechanism as switching Visual Studio versions, without requiring any source level changes. To use Clang, set WindowsPlatform.Compiler = WindowsCompiler.Clang from a .target.cs file, or set <WindowsPlatform><Compiler>Clang</Compiler></WindowsPlatform> from BuildConfiguration.xml. To pick a specific toolchain version, set WindowsPlatform.CompilerVersion. * Clang is now supported through AutoSDKs; will be added to CIS. * The Samples/Sandbox/Clang project forces Clang to be used from its target.cs file, and allows easily building all editor modules and plugins with Clang on Windows. * UnrealMathSSE intrinsics have been re-enabled for Clang due to missing functions from the UnrealMathFPU implementation, but causes failure in tests at startup. * SSE4_CRC32() is disabled in D3D12Pipelinestate.cpp, since intrinsics are only allowed if enabled for the whole target (rather than being used in specific functions due to runtime checks) Change 4157389 by Ben.Marsh Few more fixes for compiling the editor with Clang. Change 4183911 by Ben.Marsh Fixes to support incremental linking on Windows. Does not seem to have any net benefit right now; may improve once minimal rebuild is enabled. * Incremental linking no longer forces PDB files to be enabled for source files. * Actions can specify specific files to be deleted before each build. Code to forcibly delete PDB files has been moved to the MSVC toolchain. * Unused libraries produced by the cross-referenced link are no longer added as build products, since (a) deleting them breaks dependency checking for incremental linking and causes a full link, and (b) not deleting them breaks UBT dependency checking and causes actions to be run over and over again. * Icon update is disabled for Windows when incremental linking is enabled. * Removed rarely-used setting to always delete produced items before each build. Change 4184311 by Ben.Marsh UGS: Added a dialog which shows all the required platform SDKs for a branch, linked from the status panel in UGS. The llist is configured via the UGS config file submitted to Engine/Programs/UnrealGameSync/UnrealGameSync.ini (and may be overridden by the project config file if necessary): [Default] ; Set this to a network share which contains the SDK installers for your site SdkInstallerDir= ; All the required SDKs for the current version of the engine +SdkInfo=(Category="Android", Description="NDK r21", Browse="$(SdkInstallerDir)\\Android") +SdkInfo=(Category="Windows", Description="Visual Studio 2017") +SdkInfo=(Category="Windows", Description="Visual C++ Toolchain 14.13.26128") +SdkInfo=(Category="Windows", Description="Windows SDK 10.0.16299.0") Similar entries for console platforms are added in console subdirectories. Each entry may contain an Install="Foo.exe" and/or Browse="C:\Foo" style attribute, specifying the path to an installer to run or directory to open in explorer respectively. The SdkInstallerDir setting is used as a base directory for the default installers, seen above for Android. Licensees may override this with a network path specific to the site that UGS is being deployed to (either in this file, in a project specific config file, or in a Engine/Programs/UnrealGameSync/NotForLicensees/UnrealGameSync.ini file). Change 4200452 by Ben.Marsh UBT: Change DebugGame configurations to output a separate executable rather than requiring a -Debug argument at runtime. Previous behavior was a common source of errors. Engine modules are still shared between Development and DebugGame, but the launch module sets a flag in Core on startup indicating the game configuration. Change 4206189 by Ben.Marsh UBT: Simplify logic for precompiling binaries. * Target no longer has separate list of "precompile only" binaries or modules. New -AllModules option allows adding every module to a target, which can be used with -Precompile and -NoLink to precompile object files for monolithic builds. * Precompiled file lists have been removed from target receipts. * The manifest now includes all generated headers and precompiled files when run with the -Precompile option. * Separate -DependencyList=Foo.txt has been added to write a list of all dependencies required to use precompiled binaries. This file list can be read using the <Tag> task in buildgraph. Change 4215466 by Ben.Marsh UBT: Remove indirect calls to determine extensions for object files and precompiled headers. The toolchain knows the correct convention for the platform. Change 4215975 by Ben.Marsh UBT: Remove telemetry code. This has never proved useful for analyzing performance due to the number of incidental factors that affect build times (eg. number of files being compiled). Change 4220154 by Ben.Marsh Move text-only implementations of FOutputDeviceError back into Core, so we can build command-line applications that don't depend on ApplicationCore. Change 4224708 by Ben.Marsh Add a bCompileAgainstApplicationCore setting to the target rules, which allows compiling out references to the ApplicationCore module (which should only be necessary for applications with a GUI). Removed ApplicationCore from several engine tools and utilities. Change 4224958 by Ben.Marsh Remove CoreMinimal.h includes from Core. Change 4229059 by Ben.Marsh UBT: Remove the UEBuildPlatform.ShouldNotBuildEditor() hook for target platforms. We shouldn't be modifying a target's build environment to disable the editor; it is invalid to build the editor for these target platforms at all, and this is already enforced by the GetSupportedPlatforms() function. Change 4230508 by Ben.Marsh Fixup precompiled header setting for samples and games. Change 4231457 by Ben.Marsh Fix exceptions in log messages having trailing newlines. Change 4232406 by Ben.Marsh UBT: Always force include a PCH for generated code if there's one set; the code may depend on it to compile. Change 4234177 by Ben.Marsh Set up private PCH files everywhere that previously used them. Change 4235973 by Ben.Marsh Change FPlatformMisc::GetEnvironmentVariable() to return an FString() rather than requiring a fixed size buffer to be passed in. Removes references to MAX_PATH. Change 4238842 by Ben.Marsh Add support for paths longer than MAX_PATH in the editor. Requires Windows 10 version 1607, and the functionality to be enabled via a registry key or group policy (see https://docs.microsoft.com/en-us/windows/desktop/FileIO/naming-a-file). Only a subset of Win32 functions support long paths (executables can only be started from paths shorter than MAX_PATH, for example). * Added a FPlatformMisc::GetMaxPathLength() function to return the maximum length of a path on the current system. On Windows, this returns a different value for systems with long paths enabled to those without. * The MAX_PATH define is no longer set by non-Windows platforms. Instead, there is a MAC_MAX_PATH, UNIX_MAX_PATH, etc... for any platform-specific code that still relies on the previous macro. * The MAX_UNREAL_FILENAME_LENGTH macro has been renamed to MAX_UNREAL_FILENAME_LENGTH_DEPRECATED * The PLATFORM_MAX_FILEPATH_LENGTH macro has been renamed to PLATFORM_MAX_FILEPATH_LENGTH_DEPRECATED. * Removed custom resource files for programs, since they are just copies of the base UE4 one (which is used by default anyway). The base UE4 manifest declares support for long paths. * Fix 512 character maximum length on editor commands. 260 character limit remains in place for cooking at the moment (see ContentBrowserUtils.h), until C# staging code supports long paths. Change 4255042 by Ben.Marsh UBT: Remote compilation now uploads the entire workspace to the remote Mac and executes a separate remote instance of UBT rather than synchronizing individual actions. This makes the remote compile codepath much simpler, and removes a lot of special cases that exist to support it previously. The list of files to be transferred to the remote are listed as rsync filter rules in Engine/Build/Rsync/RsyncEngine.txt and RsyncProject.txt, which are applied to the root engine directory and project directory respectively. Projects that need to customize which files are uploaded can add their own <ProjectDir>/Build/Rsync/RsyncProject.txt file, which will be included in the filter before the default version. Change 4260567 by Ben.Marsh UAT: Rename CommandUtils.Log to CommandUtils.LogInformation, to avoid conflicts with the underlying Tools.DotNETCommon.Log class. #rb none [CL 4285673 by Ben Marsh in Main branch]
2018-08-14 18:32:34 -04:00
LogInformation("Stopping client...");
ClientProcess.StopProcess();
Thread.Sleep(10000);
}
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 3345728) #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 3315219 on 2017/02/21 by Steve.Robb Fix for FObjectAndNameAsStringProxyArchive when serializing a TWeakObjectPtr. Change 3315285 on 2017/02/21 by Steve.Robb Explicitly pass string builder into code generation functions. Change 3315341 on 2017/02/21 by Ben.Marsh UAT: Clean up some formatting in StreamCopyDescription output - remove #fyi lines, exclude merge commits, and remove some blank lines. Change 3315350 on 2017/02/21 by Ben.Marsh Fix shared resource files not being rebuilt if the version header changes. Change 3315823 on 2017/02/21 by Ben.Marsh UAT: Use a class derived from AutomationException to return information specific to commandlets failing, rather than putting it in the base class. Change 3315826 on 2017/02/21 by Ben.Marsh UAT: Move Distiller class from general use in UAT; FileFilter provides a much safer and fully featured implementation of the same concepts. Change 3315857 on 2017/02/21 by Ben.Marsh UBT: Remove the StripBaseDirectory() and MakeRerootedFilePath() utility functions from UBT. These operations can now be done more safely with FileReference objects. Change 3315942 on 2017/02/21 by Ben.Marsh UBT: Convert FileFilter to use FileReference and DirectoryReference arguments everywhere. Change 3316236 on 2017/02/22 by Maciej.Mroz #jira UE-42045 Nativization Fixed Warning: TEnumAsByte is not intended for use with enum Change 3316253 on 2017/02/22 by Robert.Manuszewski Fixes for the async log file writer hangs and crashes. - potential fix for the logging system hang when running out of disk space while flushing log - fix for unexpected concurrency assert when flushing the log buffer to disk Change 3316293 on 2017/02/22 by Steve.Robb GetTypeHash and lexicographical comparison operators (operator<() etc.) for TTuple. Change 3316342 on 2017/02/22 by Maciej.Mroz Nativization: Wrappers (stubs) required only by other wrappers are properly generated. #codereview: Mike.Beach Change 3316344 on 2017/02/22 by Maciej.Mroz Fixed crash in nativized Odin Async loading properly handles nativized structs. Change 3316359 on 2017/02/22 by Steve.Robb GitHub #3287 : Ignore #pragma in USTRUCTs #jira UE-42248 Change 3316389 on 2017/02/22 by Matthew.Griffin Switched Installed Engine Filters to multiline properties to make them more readable Added Oodle to list of excluded plugins #jira UE-42030 Change 3316392 on 2017/02/22 by Ben.Marsh UBT: Split out FileReference/DirectoryReference classes into their own file. Change 3316394 on 2017/02/22 by Ben.Marsh UBT: Move FileReference/DirectoryReference extension methods into the appropriate file. Change 3316411 on 2017/02/22 by Ben.Marsh UAT: Remove file functions that take multiple arguments. There's not really a compelling use case for these to exist over looping from the calling code. Change 3316446 on 2017/02/22 by Ben.Marsh UAT: Try disabling function name prefix to log output from UAT, to see if it improves readability. Function names are still included in the log file for debugging. Change 3316575 on 2017/02/22 by Ben.Marsh UAT: Remove unused functionality for dealing with labels, and output a more human readable list of P4 settings at startup. Change 3318481 on 2017/02/22 by Steve.Robb Use of FMath::IsPowerOfTwo in check. Static assert to ensure that an inline set allocator will have a hash size of a power of two. Change 3318496 on 2017/02/22 by Steve.Robb Fix for TSet visualizers. Change 3318919 on 2017/02/23 by Steve.Robb Fix for hot reloading UScriptStruct-derived objects in a module, where the CDOs of these objects haven't had PrepareCppStructOps() called on them. #jira UE-42178 Change 3318942 on 2017/02/23 by Steve.Robb Removal of a redundant insertion which can cause problems on reallocation of the map. Change 3319010 on 2017/02/23 by Ben.Marsh UBT: Fix exception when a file that was previously part of the working set is deleted. Change 3319134 on 2017/02/23 by Robert.Manuszewski Better fix for a deadlock when flushing log while it's already being flushed due to flush timer on the async log writer thread. Change 3319249 on 2017/02/23 by Matthew.Griffin Added a function to check if running with debug game libs instead of checking command line in multiple places Added -RunConfig parameter, which has equivalent result to -debug if value of parameter starts with 'debug' Added -RunConfig=$(Configuration) as a default commandline argument for Mac so that editor can use debug game libs Removed -Shipping argument from VCProject generation as it's not used anymore Change 3319253 on 2017/02/23 by Maciej.Mroz #jira UE-41846 New mechanism to gather modules necessary for Nativized Assets. The modules are listed based on included headers. Previously the dependencies was gathered only in FBlueprintNativeCodeGenManifest::GatherModuleDependencies. Change 3319591 on 2017/02/23 by Ben.Marsh Don't strip prefixes beginning with WARNING: or ERROR: using the Postp filter. Change 3320357 on 2017/02/23 by Steven.Hutton Slight changes to Add Crash method - Returning select fields instead of entity objects in queries for perf reasons. Change 3320361 on 2017/02/23 by Steven.Hutton Performance improvements subsequent to the recent database changes. Change 3320446 on 2017/02/23 by Steven.Hutton adding my temporary performance tracker class - reports to a private slack channel with add crash performance data. Change 3320479 on 2017/02/23 by Ben.Marsh Fix CIS errors. Change 3320576 on 2017/02/23 by Jin.Zhang Update CrashReporter to use AWS Change 3320742 on 2017/02/23 by Jin.Zhang Merging crash caching Change 3321119 on 2017/02/24 by Robert.Manuszewski DLL injection protection support for non-monolithic builds Change 3323308 on 2017/02/27 by Matthew.Griffin Moved compilation of SwarmInterface after its dependencies so that we will see a build failure immediately if they change version in future Change 3323423 on 2017/02/27 by Chad.Garyet Adding a script to check and warn about csproj targeted .net versions being mismatched #JIRA UE-39624 Change 3323442 on 2017/02/27 by Ben.Marsh UBT: Output an error if an engine module references a game module. Change 3323743 on 2017/02/27 by Ben.Marsh PR #3303: Resolved PVS scan issues (Contributed by projectgheist) Change 3323748 on 2017/02/27 by Ben.Marsh Convert whitespace to tabs. Change 3324851 on 2017/02/28 by Chris.Wood Add Odin symbol locations to engine config for MDD on CR server. NotForLicensees Change 3324979 on 2017/02/28 by Gil.Gribb Fixed bad merge of priority change in the EDL. Change 3326889 on 2017/03/01 by Steven.Hutton Update to buggs controller to generate faster queries. Change 3326910 on 2017/03/01 by Robert.Manuszewski Removing legacy #if from PackageFileSummary. Change 3327118 on 2017/03/01 by Gil.Gribb UE4 - Fixed race that resulted in a memory leak when reading compressed paks. Change 3327633 on 2017/03/01 by Gil.Gribb UE4 - Added a cvar to control the pak precacher thottle. Change 3327674 on 2017/03/01 by Steve.Robb Unified boilerplate between all generated code files. Change 3328544 on 2017/03/01 by Chris.Wood CrashReportProcess.config update (CRP v1.2.17) Tweaks to a few values. Update website URL to explicitly point to old, non-cloud site on devweb-02. Change 3328714 on 2017/03/01 by Chris.Wood Correct CRP config regression. Point website at new cloud site. Still v1.2.17 Change 3329192 on 2017/03/02 by Matthew.Griffin Added Shared Build Id file to the list of Precompiled Build Dependencies in a target receipt so that it's brought into an installed build Change 3329285 on 2017/03/02 by Ben.Marsh UGS: Allow a project to specify a filters for the streams that should be displayed for fast-switching to. The QuickSelectStreamList seting in the [Options] section of the project settings references a depot path containing a list of strings used to filter the stream list. An option is shown to switch back to showing all available streams, if desired. Change 3330636 on 2017/03/02 by Ben.Marsh UBT: Bump version number of C++ include cache to force it to be rebuilt with additional include information for the default RC files. Change 3331262 on 2017/03/03 by Robert.Manuszewski Merging Dev-LoadTimes to Dev-Core (Garbage Collection performance improvements) - Improved GC multithreading - Improved BeginDestroy performance - Introduced ULevelActorCluster for StaticMeshActor and ReflectionCapture actor clustering (can be toggled through project settings or console command gc.ActorClusterEnabled) - A few improvements to AddReferencedObjects functions - Misc improvements to GC code - Garbage Collector now properly handles clusters which had their objects marked as pending kill - Blueprints can now create clusters too (can be toggled through project settings or console command gc.BlueprintClusteringEnabled, defaults to disabled) Change 3331285 on 2017/03/03 by Robert.Manuszewski A few fixes for the previous check-in. Change 3332001 on 2017/03/03 by Ben.Marsh UBT: Add support for generating a UDN file containing the valid settings for BuildConfiguration.xml. Pass -configdoc=<filename> on the command line to generate such a file. Change 3332022 on 2017/03/03 by Ben.Marsh Update documentation for where to find the BuildConfiguration settings. Change 3332031 on 2017/03/03 by Ben.Marsh Remove documentation for Windows XP support; it has been removed in the 4.16 release. Change 3332256 on 2017/03/03 by Ben.Marsh UBT: Add support for generating a UDN page containing module and target settings. Change 3332458 on 2017/03/03 by Ben.Marsh UBT: Improvements to generated documentation. Change 3332459 on 2017/03/03 by Ben.Marsh Add generated documentation for .target.cs files, .build.cs files, and BuildConfiguration.xml files. Change 3332460 on 2017/03/03 by Ben.Marsh UBT: Make LinkTypePrivate actually private, so it doesn't show up in the docs. Change 3332899 on 2017/03/06 by Robert.Manuszewski Making sure actor clustering is not used in the editor (fix for actors being deleted when GC runs in the editor) #jira UE-42548 Change 3332955 on 2017/03/06 by Maciej.Mroz Nativization distinguishes client and server platform: - Separated lists on additional assets, additional modules, excluded assets, excluded modules, excluded paths (in config) - Context (compilation options, nativization options and platform) is deliveren to BPCOmpilerCppBackend in FCompilerNativizationOptions struct. - Wrappers (for unconverted BPs) are created only when they are directly called. - Fortnite dedicated server can be nativized Change 3332990 on 2017/03/06 by Ben.Marsh UBT: Add more comprehensive wrapper methods for System.IO.File and System.IO.Directory to FileReference and DirectoryReference. Change 3333032 on 2017/03/06 by Ben.Marsh Documentation for build tools Change 3333037 on 2017/03/06 by Ben.Marsh Add a build step to extract UAT and UBT documentation from XML comments. Change 3333089 on 2017/03/06 by Ben.Marsh UAT: Re-enable logging the calling function to the console in UAT. Needs a pass for readability first. Change 3333651 on 2017/03/06 by Gil.Gribb UE4 - Fix a werid recursive situation where StaticLoadObject could return an object that has not finished loading. Also produces a fatal error if this sometimes happens. EDL only. Change 3335236 on 2017/03/07 by Ben.Marsh UGS: Set the sync changelist separately to the compatibility changelist. Change 3335261 on 2017/03/07 by Gil.Gribb UE4 - Fixed batched render fences when BeginDestroy calls FlushRenderingCommands. Change 3335740 on 2017/03/07 by Gil.Gribb maybe fix static analysis warning Change 3335945 on 2017/03/07 by Steve.Robb Move FFindInstancedReferenceSubobjectHelper code out of header. Add map/set property support to allow instanced members of these container types to be handled during CPFUO. https://udn.unrealengine.com/questions/349232/tmap-with-instanced-object-as-value-gets-cleared-o.html Change 3336693 on 2017/03/07 by Ben.Marsh UBT: Use shared PCHs for game plugins by default, to reduce time spent generating individual PCHs. Change 3336694 on 2017/03/07 by Steve.Robb Static assert added to TMap to prevent the use of keys which don't implement a GetTypeHash. Fixes to types which relied on implicit conversions when calling GetTypeHash. Workaround in SAssetView.h and PropertyEditorModule.h for an apparent VC bug where the compiler wrongly instantiates TPointerIsConvertibleFromTo for certain forward-declared types, causing future TSharedPtr conversions to fail. #jira UE-42441 Change 3336698 on 2017/03/07 by Steve.Robb Hardcoded endpoint handling replaced with a generic string. Obsolete .proto and .java code generation removed. Change 3336811 on 2017/03/07 by Wes.Hunt Add a game blacklist to the crash report processor. Fixed a syntax error in Config.cs, added a XML comment to shut up a warning. Change 3336973 on 2017/03/08 by Steve.Robb Fix for missing GetTypeHash in a plugin. Change 3336996 on 2017/03/08 by Steve.Robb Significant refactor of code generation, to try and make data flow more apparent. Change 3337571 on 2017/03/08 by Steve.Robb CIS fixes for missing GetTypeHash functions. Non-unity fix. Change 3337588 on 2017/03/08 by Gil.Gribb UE4 - Fixed obscure check with flushing rhi resources. Change 3337620 on 2017/03/08 by Steve.Robb WITH_HOT_RELOAD_CTORS macros removed. UseVTableConstructors config option removed. Change 3339369 on 2017/03/09 by Steve.Robb GetTypeHash overload for nn::account::Uid. Change 3339464 on 2017/03/09 by Daniel.Lamb Fixed assert in 4.15 to do with trying to gather dependency info from invalid packages. #jira UE-42583 #test Editor + Cook + Run shootergame Change 3339465 on 2017/03/09 by Maciej.Mroz Fixed serialization issue, after UserDefinedEnum was used in EnumProperty. Change 3339469 on 2017/03/09 by Maciej.Mroz Fixed Nativization problem, when default value is passed as non-const reference. Change 3340178 on 2017/03/09 by Daniel.Lamb Added support for in memory only packages. The Cooker ignores these and added core functions to recognize these packages. Other systems will need to add support where nessisary. Change 3341002 on 2017/03/10 by Maciej.Mroz Nativization: Fixed FFindHeadersToInclude. Headers necessary for owners of subobjects are properly included. Change 3341076 on 2017/03/10 by Steve.Robb Fix for FBakedTextureSourceInfo move semantics. #jira UE-42658 Change 3341160 on 2017/03/10 by Gil.Gribb UE4 - Fix hazard with SetMaterialUsage from a thread. Change 3341409 on 2017/03/10 by Steve.Robb Reduction of the generated code size for StaticRegisterNatives functions. Change 3341523 on 2017/03/10 by Steve.Robb Code generation simplified. Change 3341800 on 2017/03/10 by Ben.Marsh UnrealVS: Fix UnrealVS compatibility with RTM version of Visual Studio 2017. 2017 toolchain for extensions is no longer able to build <= 2015 extensions due to validation of the VSIX manifest, so create a separate solution for it. Change 3342034 on 2017/03/10 by Ben.Marsh Fix compiler setting not being loaded correctly into the Windows target settings dialog. #jira UE-42746 Change 3342041 on 2017/03/10 by Ben.Marsh Fix -ErrorOnEngineContentUse not being set in the cooker options correctly. Change 3342094 on 2017/03/10 by Steve.Robb Fix to deteministic name order during code generation. Change 3342251 on 2017/03/10 by Daniel.Lamb Integrate fix for resave lightmaps commandlet when upgrading from no mapbuilddatapackages to mapbuilddatapackages. #thanks Tim.Hagberg #test None Change 3342961 on 2017/03/13 by Robert.Manuszewski Fixing memory leak when playing while running -nullrhi on the commandline in cooked games caused by shader resources not being destroyed. #jira FORT-38977 Change 3343022 on 2017/03/13 by Steve.Robb GetTypeHash fixes for FUniqueNetIdLive. #jira UE-42788 Change 3343448 on 2017/03/13 by Steve.Robb Compiled-in defer object order fixed. Debuggability of the deferred registration map improved. #jira UE-42828 [CL 3345747 by Ben Marsh in Main branch]
2017-03-14 15:48:33 -04:00
while (!ClientLogReader.EndOfStream)
{
string ClientOutput = ClientLogReader.ReadToEnd();
if (!String.IsNullOrEmpty(ClientOutput))
{
Console.Write(ClientOutput);
}
}
if (!WelcomedCorrectly)
{
throw new AutomationException("Client exited before we asked it to.");
}
}
}
else
{
var SC = DeployContextList[0];
Copying //UE4/Dev-Platform to //UE4/Dev-Main (Source: //UE4/Dev-Platform @ 3120366) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 2714591 on 2015/10/02 by Ben.Marsh Initial branch of files from Engine-Main (//UE4/Engine-Main) to Dev-Platform (//UE4/Dev-Platform) Change 2916715 on 2016/03/21 by Daniel.Lamb First pass at splitting out build cook run into into seperate scripts. Change 2948322 on 2016/04/19 by Nick.Shin update libwebsockets to v1.7.4 part 4 of 4 - doing this in stages for tracking purposes #jira UEPLAT-1246 - Update libWebsockets #jira UEPLAT-1221 - update websocket library #jira UEPLAT-1204 - Rebuild libwebsockets with SSL Change 2970016 on 2016/05/07 by Nick.Shin undo all of the following upgrades: - zlib - openssl - libcurl - libwebsockets and reset webrtc #jira UE-30298 - Fortnite and Orion crash on login Change 3059693 on 2016/07/21 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3061151 on 2016/07/22 by Niklas.Smedberg Fast ASTC texture compression, using ISPC. #jira UE-32308 Change 3061428 on 2016/07/22 by Peter.Sauerbrei Back out changelist 3061151 as it wasn't approved for submission Change 3061970 on 2016/07/22 by Steve.Cano Adding AdMob interstitital ad support for Android, including Blueprint functions #jira UE-33286 #ue4 #android Change 3062160 on 2016/07/22 by Mark.Satterthwaite Fix the fix for handling RHISetStreamSource overriding stride on Metal - not all MTLVertexDescriptors are equally hashable so do this ourselves. #jira UE-33355 Change 3062770 on 2016/07/24 by Brent.Pease UE-32397 Error Message displays as Unknown Error when failing to supply a Remote Build server for ios on Windows Change 3063227 on 2016/07/25 by Dmitry.Rekman Update hlslcc cross-compile after libc++ change. Change 3063314 on 2016/07/25 by Jeff.Campeau Xbox One DLL loading Receipts can be read back by request for target info Change 3063329 on 2016/07/25 by Mark.Satterthwaite CL #3046743 was breaking other samples in unexpected ways after a recent Main merge, so make a Metal-specific change to the shader instead and amend the MetalBackend to better match HLSL's handling of NaN/inf with common single-precision float intrinsics. This is sufficient to fix the AtmosphericFog and the recent regressions. #jira UE-33600 #jira UE-33028 #jira UE-27879 #jira UE-25802 Change 3063492 on 2016/07/25 by Brent.Pease UE-23846 - iOS Movie Player can't handle videos at resolutions that aren't multiples of 16 UE-33200 - A movie isn't played on iOS occasionally. Change 3063729 on 2016/07/25 by Dmitry.Rekman Linux: enable XGE on all platforms. #tests Cross-compiled a number of Linux targets on Windows. Change 3063732 on 2016/07/25 by Dmitry.Rekman Fixed formatting (spaces->tabs) in previous change. Change 3063750 on 2016/07/25 by Daniel.Lamb Added code to dump the cook modification delegate loads to log. Fixed the memory usage output log. #test cook paragon. Change 3063804 on 2016/07/25 by Daniel.Lamb Added cookpartialgc additional commandline option to uat. #test UFE Change 3064008 on 2016/07/25 by Mark.Satterthwaite For non-shipping builds conditionally bind a default uniform buffer in Metal and report an error if the slot was unbound, if our validation layer is enabled attempt to report the shader source in question. This relies on the shader compiler providing accurate information about uniform buffer bindings and won't fix all occurances of bad uniform usage (if a buffer is bound but too short the result will be GPU restarts or an error in Apple's validation layer - we can't detect this case) but will help debug the typical error of leaving an active slot unbound. #jira FORT-27685 Change 3064141 on 2016/07/25 by Jeff.Campeau Rebuild vpxmd.lib with delayed codegen disabled (fixes linker warning building Win64). Change 3065024 on 2016/07/26 by Nick.Shin Change filetype remove exclusive check out bit requested by or.coheni & nick.penwarden Change 3065274 on 2016/07/26 by Jonathan.Fitzpatrick DirectoriesToAlwaysStageAsUFS now properly filters out *.uasset and *.umap files This prevents the bug where cooked assets get trampled by staging their uncooked version on top of them during the UFS step Added a file filter to DirectoriesToAlwaysStageAsUFS for uasset and umap. Change 3066338 on 2016/07/27 by Mark.Satterthwaite Handle releasing an SRV/UAV & the source object within a single Metal command-buffer. #jira UE-33779 Change 3066789 on 2016/07/27 by Daniel.Lamb Realtime mode does not save any packages anymore unless they are ready. #test cookontheside, cookbythebook shooter game Change 3066847 on 2016/07/27 by Jeff.Campeau Fix define #2634 #jira UE-33813 Change 3068868 on 2016/07/28 by Mark.Satterthwaite Extend hlslcc's handling of switch-statements to allow implict casts from scalar bool, half & float as HLSL itself permits while also making sure it errors if the expression input is not scalar. This fixes shader compile errors in UT. Change 3070040 on 2016/07/29 by Dmitry.Rekman Delete Nadzorca. Change 3070947 on 2016/07/29 by Jeff.Campeau Perforce C++ API 2015.2 (includes debug libraries) Change 3073707 on 2016/08/02 by Daniel.Lamb Derived data cache commandlet runs resolve string asset references to load any string asset refereced packages from the map. Also process async results from shaders being compiled so they can have their memory resources released. #test DerivedDataCache commandlet shootergame. Change 3076613 on 2016/08/03 by Brent.Pease + UnrealTargetConfiguration is now passed into deploy and package methods + The UIRequiredDeviceCapabilities plist key now only considers the architectures from the corresponding target configuration (shipping or development) Change 3076668 on 2016/08/03 by Brent.Pease Back out changelist 3076613 Change 3077157 on 2016/08/04 by Daniel.Lamb Fixed up DLC staging so that it stages to the proper mount point. Fixes up include engine content in DLC staging paths. #test Made up shooter game DLC Change 3077191 on 2016/08/04 by Daniel.Lamb More smartly process async shader compilation if we are waiting for it. #test cook on the side shooter game cook by the book shooter game. Change 3077412 on 2016/08/04 by Mark.Satterthwaite Fix "iOS Metal-based build crashes at launch with sub-levels": - Slate should not bind the null RHI texture from an unitialised texture atlas - atlases only have a valid texture pointer once an entry has been added to them and in the template projects an empty sub-level doesn't add anything. - To prevent this kind of bug resurfacing and being so hard to track down add Metal shader binding validation to our validation layer as Apple's is incomplete on iOS and won't warn us about nil texture usage which causes these GPU restarts. This requires reworking our vertex declaration handling to be more efficient so that we can cache the pipeline reflection data as well as the pipeline objects. - Fix validation error of texture reallocation on loading template projects under Metal. #jira UE-30847 Change 3077958 on 2016/08/04 by Brent.Pease + UnrealTargetConfiguration is now passed into deploy and package methods + The UIRequiredDeviceCapabilities plist key now only considers the architectures from the corresponding target configuration (shipping or development) Change 3079503 on 2016/08/05 by Mark.Satterthwaite Initialise more variable types to 0 in Metal shaders to workaround Xcode 8 toolchain no longer doing this for us for "threadgroup shared" variables. Everything but structs and atomic's will now be initialised. #jira UE-33856 Change 3079737 on 2016/08/05 by Jeff.Campeau Add support for delay load DLLs on Xbox One Turn off warnging for missing PDBs to match VCToolchain.cs Change 3081005 on 2016/08/08 by Mark.Satterthwaite Fix-up Metal device name on AMD for macOS 10.12 which reports it correctly and enable tiled reflections on Intel from macOS 10.12 too as they now work. Change 3081557 on 2016/08/08 by Daniel.Lamb File-> Package saves all packages before starting packaging. #test File package first person template Change 3082215 on 2016/08/09 by Lee.Clark PS4 - Added 4k profile Change 3082412 on 2016/08/09 by Daniel.Lamb Fixed cook on the fly server not handling cook requests. #test Cook on the fly shooter game. Change 3082955 on 2016/08/09 by Dmitry.Rekman Linux: convert existing Strcat() uses to Strncat(). - Strcat() does not check destination size so can silently corrupt memory. While this was not observed, this conversion removes this concern altogether. Change 3083772 on 2016/08/10 by Luke.Thatcher [PLATFORM] [PS4] [+] Checking in PS4CrashHandler files so we have a copy in Perforce rather than just on the server. - Taken from \\devweb-02 and removed all the unused files/dependencies. - Created a publish profile pointing to \\devweb-02\Sites\PS4Services\PS4CrashHandlerDev so I'm not writing over the existing deployed crash handler. - Moved all code in the Page_Load event to inside the check for the HTTP method (POST) otherwise GET'ing the page from a browser will generate crash folders that hang around forever. Change 3085450 on 2016/08/11 by Lee.Clark PS4 - Fix mediaplayer pipeline allocation Change 3086360 on 2016/08/11 by Michael.Trepka Fixed a non-unity build error in Mac UnrealFrontend Change 3087224 on 2016/08/12 by Luke.Thatcher [PLATFORM] [PS4] [~] Refactor PS4 Crash Handler site - Removed CoreDumpHandler. Processing dump files is handled directly by an async thread within the aspx process. - Separated configuration values into their own class. Currently set to output to a testing directory, rather than the actual crash reporter landing zone. - Added a debug upload page to allow manual submission of .orbisdmp/.txt settings files, accessible by GET'ing Default.aspx. - Added logging. Logs self-delete after 30 days. Testing required before we switch to the new system. #jira UE-34504 #jira OR-26886 Change 3087626 on 2016/08/12 by Dmitry.Rekman PR #2689: Fix copying/duplicating failing on Linux (UE-34586). - Contributed by Web-eWorks. Change 3087991 on 2016/08/12 by Mark.Satterthwaite Initial AVFoundation implementation of Media Framework for Mac, iOS & tvOS. - Video playback occurs via AVPlayerItemVideoOutput's attached to the AVPlayerItem's output. This means gathering video samples is trivial. - Metal texture updates occur by wrapping the texture object provided by AVF - for Mac this is simple as it can bind to the IOSurface directly, for iOS/tvOS we have to create a CVMetalTextureCache and allocate our texture from there. - OpenGL and OpenGLES currently have to lock the pixel buffer and upload to a texture the old fashioned way - this should be revisited when there is time. - Subtitles/Captions are captured using AVPlayerItemLegibleOutput which also connects to the AVPlayerItem's output. - On Mac audio samples are returned by manually reading from the stream using an AVAssetReaderTrackOutput, including manual seeking and synching. - On iOS/tvOS the audio is played directly by AVPlayer because the IOSAudio system can't handle procedural buffers - otherwise it could reuse the Mac code. - AVFoundation does not support AVI - that's an obsolete Microsoft/Windows file-format. - Only 'file://' URLs are supported - streaming would require a totally different audio solution (using MTAudioProcessingTap) and has many more edge and failure cases that would need to be handled. #jira UE-34315 Change 3088790 on 2016/08/15 by Luke.Thatcher [PLATFORM] [PS4] [~] Hook new PS4 crash handler up to the crash reporter website. - Removed indentation from generated crash context XML file. The crash reporter process does manual XML parsing which doesn't correctly handle whitespace at the start of lines. - Switched the final output folder to match the one the crash reporter process is watching. - Hide upload form on a config variable. #jira UE-34504 #jira OR-26886 Change 3089060 on 2016/08/15 by Luke.Thatcher [PLATFORM] [PS4] [!] Change PS4 crash handler log file extension to ".ps4chlog", otherwise the crash reporter site attaches the wrong log file to the crash report. Allowed showing of debug upload form via "Default.aspx?showform=1" query string. #jira UE-34504 #jira OR-26886 Change 3089089 on 2016/08/15 by Mark.Satterthwaite Duplicated changes to AppleMovieStreamer from CL #3088149. #jira UE-34315 Change 3089460 on 2016/08/15 by Mark.Satterthwaite Duplicate CL #3080971: Workaround a macOS 10.12 Beta bug on some Metal drivers that can't initialise temporary/local variable arrays, only those that are marked threadgroup shared. #jira UE-34355 Change 3089465 on 2016/08/15 by Mark.Satterthwaite For Metal shader translation retain more precision for float constants -1.0f >< 1.0f by emitting them in scientific notation - prevents Hammersley constant amongst others from being flushed to 0. Change 3089902 on 2016/08/15 by Daniel.Lamb Changed the next compiling ID to the correct compiling ID. #test Cook Change 3089903 on 2016/08/15 by Daniel.Lamb Cooker monitors config useage during cook and uses those settings to invalidate cooked content instead of all config settings. Change 3090114 on 2016/08/16 by Luke.Thatcher [PLATFORM] [PS4] [~] Minor change to PS4 settings text on crash handler site. Change 3090949 on 2016/08/16 by Nick.Shin WebSocketNetDriver crash fix filled in missing chunk of code that calls PacketHandler's "packet modifiers" #jira UE-25492 HTML5 Client cannot connect to Windows Server #jira UE-30880 WinServer crashes when NetDriver is set to WebSocket and Client attempts to connect via websocket #code.review john.pollard john.barrett Change 3091265 on 2016/08/16 by Brent.Pease Add IOS support to HarfBuzz Change 3091267 on 2016/08/16 by Brent.Pease Add references to fix mono build Change 3091291 on 2016/08/16 by Nick.Shin CIS warning fix #jira UE-25492 HTML5 Client cannot connect to Windows Server #jira UE-30880 WinServer crashes when NetDriver is set to WebSocket and Client attempts to connect via websocket Change 3091781 on 2016/08/17 by Joe.Barnes UE-33640: Exposed UPrimitiveComponent::IsAnyRigidBodyAwake() to Blueprints. Change 3092687 on 2016/08/17 by Daniel.Lamb Added support for using binned allocator in cooker instead of tbb. #test Cook shootergame. Change 3093867 on 2016/08/18 by Mark.Satterthwaite Use a read/write mutex to protect access to Metal's internal shader pipeline caches so that parallel threads can progress in the common case where new shaders are not being compiled. Change 3093950 on 2016/08/18 by Mark.Satterthwaite Change the Mac GPU identification code to cope with AMD's new naming scheme on 10.12. Change 3093951 on 2016/08/18 by Mark.Satterthwaite More SCW threads on Mac - they work now. Change 3093960 on 2016/08/18 by Mark.Satterthwaite Increase the default number of command-buffers on Mac because bigger games overflow the current limit of 64 per queue. Change 3096493 on 2016/08/22 by Jeff.Campeau Use Xbox version of DirectX include. Change 3097509 on 2016/08/23 by Luke.Thatcher [PLATFORM] [PS4] [+] Refactor PS4 Symbol Publish - Moved the SymStore task from Win.Automation to BuildGraph.Automation, and made it more generic. - The specifics of uploading symbols are now implemented in the platform tool chain, alongside StripSymbols(). - Re-generated the build graph schema file. - Removed the old PS4 symbols upload path in the package step. Modified OrionBuild.xml to publish symbols for all PS4 dev, test and shipping config builds of OrionClient. Change 3097635 on 2016/08/23 by Luke.Thatcher [PLATFORM] [PS4] [+] Refactor Age Symbols task in UAT. - Moved the AgeStore task from Win.Automation to BuildGraph.Automation and made it more generic. - Symbol server directory structure is now defined by the platform tool chain, which the common task uses to clean out old symbols. - Added a "filter" parameter to prevent age tasks deleting symbols from unrelated builds in shared symbol servers. Modified OrionBuild.xml to age both the Windows and PS4 symbol stores. Change 3097713 on 2016/08/23 by Luke.Thatcher [PLATFORM] [PS4] [+] Enable new PS4 crash handler server - Created live deployment profile and applied the required config file changes. Change 3099214 on 2016/08/24 by Luke.Thatcher [PLATFORM] [PS4] [!] Fix compile error in PS4 tool chain. For some reason, this only breaks ocassionally. Maybe we're alternating between the 2013 and 2015 C# compilers depending on what initiates the build (e.g. Visual Studio vs GenerateProjectFiles)? Change 3099222 on 2016/08/24 by Luke.Thatcher [PLATFORM] [PS4] [+] Added PS4 support for FPlatformMisc::MessageBoxExt using the MsgDialog library. - Note, only one and two button message dialogs are supported (limitation of MsgDialog). Change 3099260 on 2016/08/24 by Luke.Thatcher [PLATFORM] [PS4] [~] Better PS4 exit function. Calls quick_exit instead of abort when we've not asserted. Allows for a "cleaner" forced exit without generating a crash dump. Change 3101192 on 2016/08/25 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3101944 on 2016/08/25 by Daniel.Lamb Ask to save the current level when we are using launch on. Change 3102036 on 2016/08/25 by Nick.Shin check for minimum expected size upon data received from network #jira UE-13657 - HTML5 plugin OnRawRecieve overflow Change 3102115 on 2016/08/25 by Brent.Pease - Fix small errors that probably only show up in the mac mono build #code.review peter.sauerbrei Change 3102747 on 2016/08/26 by Jeremiah.Waldron Re-submitting OnlineSubsystemGameCircle with TPS permission for Amazon SDK - Also fixed the plugin to remove any related files from the final package when IAP is disabled or GameCircle support itself is disabled with the plugin still enabled - Added support for new AlreadyOwned IAP response code as well which is already used for GooglePlay and IOS Change 3102900 on 2016/08/26 by Nick.Shin since last checkin (CL: 2981945) - prints are crashing the browser - this change will allow browser to print the details via console.log() #jira UE-26047 - HTML5 HTTP Response Headers not implemented Change 3103130 on 2016/08/26 by Brent.Pease UE-24679 - Enable the ability to change ports for a firewall to pass them through rsync Change 3103225 on 2016/08/26 by Daniel.Lamb Fixed issue with warning which would cause crash. Change 3103425 on 2016/08/26 by Dmitry.Rekman Enable offscreen GL rendering without X. - Added new video subsystem to SDL that is uses EGL to initialize the context. - Most windoing functions stubbed. - Also added a new test case to TestPAL for easier debugging. Change 3104743 on 2016/08/29 by Brent.Pease Support remote offline metal shader compilation Change 3105051 on 2016/08/29 by Brent.Pease UE-2382 - TASK: MobleMVP: iOS: Add ability to view iOS device console output in the editor UFE - IOS Automation will now create a thread to collect the console logs from the device and send them to C# Console output while the app is running on device - Made ProcessResult an interface (IProcessResult) which ProcessResult implements. This allows platforms to provide their own implementation if needed. - Moved the RunLoop related parts of CoreFoundation into MobileDevice.cs Change 3105053 on 2016/08/29 by Brent.Pease - IOS dll's as part of the last check-in Change 3106853 on 2016/08/30 by Jeff.Campeau Implement FD3D11DynamicRHI::RHICreateComputeFence to prevent memory overwrite Change 3107361 on 2016/08/30 by Dmitry.Rekman Renderer: changes to allow postproc delegates. Change 3107362 on 2016/08/30 by Dmitry.Rekman Plugin with a CUDA postproc example. - Linux version only. Runs under a headless GL too (without X). - Disabled during cross-compilation, can be compiled natively only. - CUDA kernel should be compiled separately, CMakefile with compilation attached (can be used to generate VStudio projects as well). - To test the output, run under the debugger, interrupt and set global variable GSaveTheOutput to 50 (this will write out kernel output buffer 50 times as .bmp files into working directory). Change 3107913 on 2016/08/31 by Daniel.Lamb Fixed loading of cooked content in the editor. Change 3107916 on 2016/08/31 by Daniel.Lamb Added error case when shader compilation fails to notify shader. #test Cook shooter game. Change 3108080 on 2016/08/31 by Josh.Adams - Fixed PS4Automation compile errors Change 3109077 on 2016/08/31 by Brent.Pease Fix C# debug builds by specifying x64 and add reference to MobileDeviceInterface Change 3110086 on 2016/09/01 by Dmitry.Rekman Fix race condition in PThread runnable (UE-35074). - Instead of relying on busy-wait, join the threads. This prevents race between PostRun() (executed in the context of the thread) and FPThreadRunnableThread() destructor (see UE-34909). - Do not use an invalid value for pthread_t, since there's none. Change 3110172 on 2016/09/01 by Dmitry.Rekman Fixed a crash exiting VR Preview on Windows GL4 (UE-28708). - PR #2188 submitted by ardneran. Change 3110313 on 2016/09/01 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3111134 on 2016/09/01 by Dmitry.Rekman UBT: prevent mono from hanging on Ctrl-C. - Sometimes Ctrl-C can cause thread creation to fail. Without this change, UBT would lock up. Change 3111171 on 2016/09/01 by Brent.Pease Move all C# projects to use the x64 Platform for consistency with other changes made to move to the x64 Platform Change 3111177 on 2016/09/01 by Dmitry.Rekman Fix Linux build on systems without CUDA (UE-35460). Change 3111548 on 2016/09/02 by Luke.Thatcher [PLATFORM] [PS4] [!] Fix for PS4 iterative deployment. - Changes in Dev-Mobile broke the deployment manifests, as PS4 was now using the wrong filename when creating delta and obsolete file lists. Change 3111863 on 2016/09/02 by Dmitry.Rekman Better fix for build without CUDA (UE-35460). Change 3112738 on 2016/09/02 by Mark.Satterthwaite Fix the pausing particles on Metal - one line bug in the Metal query implementation meant that the first query wouldn't return the correct result for no good reason. #jira UE-34989 Change 3114579 on 2016/09/06 by Chris.Babcock Fix Vulkan include path in NDK check (contributed by geediiiiky) #jira UE-35490 #github #2758 #ue4 #android Change 3115115 on 2016/09/06 by Jeff.Campeau Calculate buffer size for paks using the bitwindow override as needed Change 3115600 on 2016/09/07 by Luke.Thatcher [PLATFORM] [PS4] [~] Make the crash dump handler registration much earlier, to catch crashes in early engine init. - Fixed up places in FGenericCrashContext::SerializeContentToBuffer which used the command line. If we crash early, the command line may not have been initialized yet. - Added a GetNoInit function to FThreadHeartBeat to avoid creating the heart beat thread if we crash early, and the thread doesn't exist yet. Tested by calling abort() immediately inside int main(), and we get a valid crash dump that the crash handler service can consume. Change 3115676 on 2016/09/07 by Luke.Thatcher [PLATFORM] [~] Dev-Platform integration fix for original CL 3064888 in //Orion/Release-29.1 Add .exe and .dll to windows symbol upload file filters. Change 3115811 on 2016/09/07 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3115944 on 2016/09/07 by Michael.Trepka Implemented IsGamepadAttached() for Mac Change 3115948 on 2016/09/07 by Michael.Trepka Don't try to restore Help menu item on Mac if MenuBlock does not contain it Change 3116200 on 2016/09/07 by Jeff.Campeau Fix parameter ordering Change 3117660 on 2016/09/08 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3117728 on 2016/09/08 by Michael.Trepka Copy of CL 3117698 by Mike.Fricker Fixed regression with editor's Simulate mode where cursor would teleport back to the center of the viewport after every click - This bug was introduced in CL 3075932 from a borderless window cursor handling fix that was needed for games that capture the cursor Change 3117797 on 2016/09/08 by Peter.Sauerbrei Shader Resource compression Change 3117988 on 2016/09/08 by Brent.Pease - Solutiion generator will now pick x64 instead of AnyCPU for the default platform configuration - Fix what I think was a merge error in BuildGraph.cs Change 3118296 on 2016/09/08 by Daniel.Lamb Fixed crash with launch on. Couldnt' correctly detect previous generated ini settings. #test launch on QA game #jira UE-35741 Change 3118438 on 2016/09/08 by JohnHenry.Carawon Fix UAT compilation on Linux #UE-35745 Change 3118934 on 2016/09/08 by Jeff.Campeau Shader compression setting based on target platform instead of cooking host platform. #jira UE-35753 Change 3120190 on 2016/09/09 by Ben.Marsh Add missing Platform attribute to build script for Dev-Platform. [CL 3120378 by Josh Adams in Main branch]
2016-09-09 20:13:41 -04:00
IProcessResult ClientProcess = SC.StageTargetPlatform.RunClient(ClientRunFlags, ClientApp, ClientCmdLine, Params);
if (ClientProcess != null)
{
// If the client runs without StdOut redirect we're going to read the log output directly from log file on
// a separate thread.
if ((ClientRunFlags & ERunOptions.NoStdOutRedirect) == ERunOptions.NoStdOutRedirect)
{
ClientLogReaderThread = new System.Threading.Thread(ClientLogReaderProc);
ClientLogReaderThread.Start(new object[] { ClientLogFile, ClientProcess });
}
do
{
Thread.Sleep(100);
}
while (ClientProcess.HasExited == false);
SC.StageTargetPlatform.PostRunClient(ClientProcess, Params);
// any non-zero exit code should propagate an exception. The Virtual function above may have
// already thrown a more specific exception or given a more specific ErrorCode, but this catches the rest.
if (ClientProcess.ExitCode != 0)
{
throw new AutomationException("Client exited with error code: " + ClientProcess.ExitCode);
}
}
}
}
Copying //UE4/Dev-Platform to //UE4/Dev-Main (Source: //UE4/Dev-Platform @ 3120366) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 2714591 on 2015/10/02 by Ben.Marsh Initial branch of files from Engine-Main (//UE4/Engine-Main) to Dev-Platform (//UE4/Dev-Platform) Change 2916715 on 2016/03/21 by Daniel.Lamb First pass at splitting out build cook run into into seperate scripts. Change 2948322 on 2016/04/19 by Nick.Shin update libwebsockets to v1.7.4 part 4 of 4 - doing this in stages for tracking purposes #jira UEPLAT-1246 - Update libWebsockets #jira UEPLAT-1221 - update websocket library #jira UEPLAT-1204 - Rebuild libwebsockets with SSL Change 2970016 on 2016/05/07 by Nick.Shin undo all of the following upgrades: - zlib - openssl - libcurl - libwebsockets and reset webrtc #jira UE-30298 - Fortnite and Orion crash on login Change 3059693 on 2016/07/21 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3061151 on 2016/07/22 by Niklas.Smedberg Fast ASTC texture compression, using ISPC. #jira UE-32308 Change 3061428 on 2016/07/22 by Peter.Sauerbrei Back out changelist 3061151 as it wasn't approved for submission Change 3061970 on 2016/07/22 by Steve.Cano Adding AdMob interstitital ad support for Android, including Blueprint functions #jira UE-33286 #ue4 #android Change 3062160 on 2016/07/22 by Mark.Satterthwaite Fix the fix for handling RHISetStreamSource overriding stride on Metal - not all MTLVertexDescriptors are equally hashable so do this ourselves. #jira UE-33355 Change 3062770 on 2016/07/24 by Brent.Pease UE-32397 Error Message displays as Unknown Error when failing to supply a Remote Build server for ios on Windows Change 3063227 on 2016/07/25 by Dmitry.Rekman Update hlslcc cross-compile after libc++ change. Change 3063314 on 2016/07/25 by Jeff.Campeau Xbox One DLL loading Receipts can be read back by request for target info Change 3063329 on 2016/07/25 by Mark.Satterthwaite CL #3046743 was breaking other samples in unexpected ways after a recent Main merge, so make a Metal-specific change to the shader instead and amend the MetalBackend to better match HLSL's handling of NaN/inf with common single-precision float intrinsics. This is sufficient to fix the AtmosphericFog and the recent regressions. #jira UE-33600 #jira UE-33028 #jira UE-27879 #jira UE-25802 Change 3063492 on 2016/07/25 by Brent.Pease UE-23846 - iOS Movie Player can't handle videos at resolutions that aren't multiples of 16 UE-33200 - A movie isn't played on iOS occasionally. Change 3063729 on 2016/07/25 by Dmitry.Rekman Linux: enable XGE on all platforms. #tests Cross-compiled a number of Linux targets on Windows. Change 3063732 on 2016/07/25 by Dmitry.Rekman Fixed formatting (spaces->tabs) in previous change. Change 3063750 on 2016/07/25 by Daniel.Lamb Added code to dump the cook modification delegate loads to log. Fixed the memory usage output log. #test cook paragon. Change 3063804 on 2016/07/25 by Daniel.Lamb Added cookpartialgc additional commandline option to uat. #test UFE Change 3064008 on 2016/07/25 by Mark.Satterthwaite For non-shipping builds conditionally bind a default uniform buffer in Metal and report an error if the slot was unbound, if our validation layer is enabled attempt to report the shader source in question. This relies on the shader compiler providing accurate information about uniform buffer bindings and won't fix all occurances of bad uniform usage (if a buffer is bound but too short the result will be GPU restarts or an error in Apple's validation layer - we can't detect this case) but will help debug the typical error of leaving an active slot unbound. #jira FORT-27685 Change 3064141 on 2016/07/25 by Jeff.Campeau Rebuild vpxmd.lib with delayed codegen disabled (fixes linker warning building Win64). Change 3065024 on 2016/07/26 by Nick.Shin Change filetype remove exclusive check out bit requested by or.coheni & nick.penwarden Change 3065274 on 2016/07/26 by Jonathan.Fitzpatrick DirectoriesToAlwaysStageAsUFS now properly filters out *.uasset and *.umap files This prevents the bug where cooked assets get trampled by staging their uncooked version on top of them during the UFS step Added a file filter to DirectoriesToAlwaysStageAsUFS for uasset and umap. Change 3066338 on 2016/07/27 by Mark.Satterthwaite Handle releasing an SRV/UAV & the source object within a single Metal command-buffer. #jira UE-33779 Change 3066789 on 2016/07/27 by Daniel.Lamb Realtime mode does not save any packages anymore unless they are ready. #test cookontheside, cookbythebook shooter game Change 3066847 on 2016/07/27 by Jeff.Campeau Fix define #2634 #jira UE-33813 Change 3068868 on 2016/07/28 by Mark.Satterthwaite Extend hlslcc's handling of switch-statements to allow implict casts from scalar bool, half & float as HLSL itself permits while also making sure it errors if the expression input is not scalar. This fixes shader compile errors in UT. Change 3070040 on 2016/07/29 by Dmitry.Rekman Delete Nadzorca. Change 3070947 on 2016/07/29 by Jeff.Campeau Perforce C++ API 2015.2 (includes debug libraries) Change 3073707 on 2016/08/02 by Daniel.Lamb Derived data cache commandlet runs resolve string asset references to load any string asset refereced packages from the map. Also process async results from shaders being compiled so they can have their memory resources released. #test DerivedDataCache commandlet shootergame. Change 3076613 on 2016/08/03 by Brent.Pease + UnrealTargetConfiguration is now passed into deploy and package methods + The UIRequiredDeviceCapabilities plist key now only considers the architectures from the corresponding target configuration (shipping or development) Change 3076668 on 2016/08/03 by Brent.Pease Back out changelist 3076613 Change 3077157 on 2016/08/04 by Daniel.Lamb Fixed up DLC staging so that it stages to the proper mount point. Fixes up include engine content in DLC staging paths. #test Made up shooter game DLC Change 3077191 on 2016/08/04 by Daniel.Lamb More smartly process async shader compilation if we are waiting for it. #test cook on the side shooter game cook by the book shooter game. Change 3077412 on 2016/08/04 by Mark.Satterthwaite Fix "iOS Metal-based build crashes at launch with sub-levels": - Slate should not bind the null RHI texture from an unitialised texture atlas - atlases only have a valid texture pointer once an entry has been added to them and in the template projects an empty sub-level doesn't add anything. - To prevent this kind of bug resurfacing and being so hard to track down add Metal shader binding validation to our validation layer as Apple's is incomplete on iOS and won't warn us about nil texture usage which causes these GPU restarts. This requires reworking our vertex declaration handling to be more efficient so that we can cache the pipeline reflection data as well as the pipeline objects. - Fix validation error of texture reallocation on loading template projects under Metal. #jira UE-30847 Change 3077958 on 2016/08/04 by Brent.Pease + UnrealTargetConfiguration is now passed into deploy and package methods + The UIRequiredDeviceCapabilities plist key now only considers the architectures from the corresponding target configuration (shipping or development) Change 3079503 on 2016/08/05 by Mark.Satterthwaite Initialise more variable types to 0 in Metal shaders to workaround Xcode 8 toolchain no longer doing this for us for "threadgroup shared" variables. Everything but structs and atomic's will now be initialised. #jira UE-33856 Change 3079737 on 2016/08/05 by Jeff.Campeau Add support for delay load DLLs on Xbox One Turn off warnging for missing PDBs to match VCToolchain.cs Change 3081005 on 2016/08/08 by Mark.Satterthwaite Fix-up Metal device name on AMD for macOS 10.12 which reports it correctly and enable tiled reflections on Intel from macOS 10.12 too as they now work. Change 3081557 on 2016/08/08 by Daniel.Lamb File-> Package saves all packages before starting packaging. #test File package first person template Change 3082215 on 2016/08/09 by Lee.Clark PS4 - Added 4k profile Change 3082412 on 2016/08/09 by Daniel.Lamb Fixed cook on the fly server not handling cook requests. #test Cook on the fly shooter game. Change 3082955 on 2016/08/09 by Dmitry.Rekman Linux: convert existing Strcat() uses to Strncat(). - Strcat() does not check destination size so can silently corrupt memory. While this was not observed, this conversion removes this concern altogether. Change 3083772 on 2016/08/10 by Luke.Thatcher [PLATFORM] [PS4] [+] Checking in PS4CrashHandler files so we have a copy in Perforce rather than just on the server. - Taken from \\devweb-02 and removed all the unused files/dependencies. - Created a publish profile pointing to \\devweb-02\Sites\PS4Services\PS4CrashHandlerDev so I'm not writing over the existing deployed crash handler. - Moved all code in the Page_Load event to inside the check for the HTTP method (POST) otherwise GET'ing the page from a browser will generate crash folders that hang around forever. Change 3085450 on 2016/08/11 by Lee.Clark PS4 - Fix mediaplayer pipeline allocation Change 3086360 on 2016/08/11 by Michael.Trepka Fixed a non-unity build error in Mac UnrealFrontend Change 3087224 on 2016/08/12 by Luke.Thatcher [PLATFORM] [PS4] [~] Refactor PS4 Crash Handler site - Removed CoreDumpHandler. Processing dump files is handled directly by an async thread within the aspx process. - Separated configuration values into their own class. Currently set to output to a testing directory, rather than the actual crash reporter landing zone. - Added a debug upload page to allow manual submission of .orbisdmp/.txt settings files, accessible by GET'ing Default.aspx. - Added logging. Logs self-delete after 30 days. Testing required before we switch to the new system. #jira UE-34504 #jira OR-26886 Change 3087626 on 2016/08/12 by Dmitry.Rekman PR #2689: Fix copying/duplicating failing on Linux (UE-34586). - Contributed by Web-eWorks. Change 3087991 on 2016/08/12 by Mark.Satterthwaite Initial AVFoundation implementation of Media Framework for Mac, iOS & tvOS. - Video playback occurs via AVPlayerItemVideoOutput's attached to the AVPlayerItem's output. This means gathering video samples is trivial. - Metal texture updates occur by wrapping the texture object provided by AVF - for Mac this is simple as it can bind to the IOSurface directly, for iOS/tvOS we have to create a CVMetalTextureCache and allocate our texture from there. - OpenGL and OpenGLES currently have to lock the pixel buffer and upload to a texture the old fashioned way - this should be revisited when there is time. - Subtitles/Captions are captured using AVPlayerItemLegibleOutput which also connects to the AVPlayerItem's output. - On Mac audio samples are returned by manually reading from the stream using an AVAssetReaderTrackOutput, including manual seeking and synching. - On iOS/tvOS the audio is played directly by AVPlayer because the IOSAudio system can't handle procedural buffers - otherwise it could reuse the Mac code. - AVFoundation does not support AVI - that's an obsolete Microsoft/Windows file-format. - Only 'file://' URLs are supported - streaming would require a totally different audio solution (using MTAudioProcessingTap) and has many more edge and failure cases that would need to be handled. #jira UE-34315 Change 3088790 on 2016/08/15 by Luke.Thatcher [PLATFORM] [PS4] [~] Hook new PS4 crash handler up to the crash reporter website. - Removed indentation from generated crash context XML file. The crash reporter process does manual XML parsing which doesn't correctly handle whitespace at the start of lines. - Switched the final output folder to match the one the crash reporter process is watching. - Hide upload form on a config variable. #jira UE-34504 #jira OR-26886 Change 3089060 on 2016/08/15 by Luke.Thatcher [PLATFORM] [PS4] [!] Change PS4 crash handler log file extension to ".ps4chlog", otherwise the crash reporter site attaches the wrong log file to the crash report. Allowed showing of debug upload form via "Default.aspx?showform=1" query string. #jira UE-34504 #jira OR-26886 Change 3089089 on 2016/08/15 by Mark.Satterthwaite Duplicated changes to AppleMovieStreamer from CL #3088149. #jira UE-34315 Change 3089460 on 2016/08/15 by Mark.Satterthwaite Duplicate CL #3080971: Workaround a macOS 10.12 Beta bug on some Metal drivers that can't initialise temporary/local variable arrays, only those that are marked threadgroup shared. #jira UE-34355 Change 3089465 on 2016/08/15 by Mark.Satterthwaite For Metal shader translation retain more precision for float constants -1.0f >< 1.0f by emitting them in scientific notation - prevents Hammersley constant amongst others from being flushed to 0. Change 3089902 on 2016/08/15 by Daniel.Lamb Changed the next compiling ID to the correct compiling ID. #test Cook Change 3089903 on 2016/08/15 by Daniel.Lamb Cooker monitors config useage during cook and uses those settings to invalidate cooked content instead of all config settings. Change 3090114 on 2016/08/16 by Luke.Thatcher [PLATFORM] [PS4] [~] Minor change to PS4 settings text on crash handler site. Change 3090949 on 2016/08/16 by Nick.Shin WebSocketNetDriver crash fix filled in missing chunk of code that calls PacketHandler's "packet modifiers" #jira UE-25492 HTML5 Client cannot connect to Windows Server #jira UE-30880 WinServer crashes when NetDriver is set to WebSocket and Client attempts to connect via websocket #code.review john.pollard john.barrett Change 3091265 on 2016/08/16 by Brent.Pease Add IOS support to HarfBuzz Change 3091267 on 2016/08/16 by Brent.Pease Add references to fix mono build Change 3091291 on 2016/08/16 by Nick.Shin CIS warning fix #jira UE-25492 HTML5 Client cannot connect to Windows Server #jira UE-30880 WinServer crashes when NetDriver is set to WebSocket and Client attempts to connect via websocket Change 3091781 on 2016/08/17 by Joe.Barnes UE-33640: Exposed UPrimitiveComponent::IsAnyRigidBodyAwake() to Blueprints. Change 3092687 on 2016/08/17 by Daniel.Lamb Added support for using binned allocator in cooker instead of tbb. #test Cook shootergame. Change 3093867 on 2016/08/18 by Mark.Satterthwaite Use a read/write mutex to protect access to Metal's internal shader pipeline caches so that parallel threads can progress in the common case where new shaders are not being compiled. Change 3093950 on 2016/08/18 by Mark.Satterthwaite Change the Mac GPU identification code to cope with AMD's new naming scheme on 10.12. Change 3093951 on 2016/08/18 by Mark.Satterthwaite More SCW threads on Mac - they work now. Change 3093960 on 2016/08/18 by Mark.Satterthwaite Increase the default number of command-buffers on Mac because bigger games overflow the current limit of 64 per queue. Change 3096493 on 2016/08/22 by Jeff.Campeau Use Xbox version of DirectX include. Change 3097509 on 2016/08/23 by Luke.Thatcher [PLATFORM] [PS4] [+] Refactor PS4 Symbol Publish - Moved the SymStore task from Win.Automation to BuildGraph.Automation, and made it more generic. - The specifics of uploading symbols are now implemented in the platform tool chain, alongside StripSymbols(). - Re-generated the build graph schema file. - Removed the old PS4 symbols upload path in the package step. Modified OrionBuild.xml to publish symbols for all PS4 dev, test and shipping config builds of OrionClient. Change 3097635 on 2016/08/23 by Luke.Thatcher [PLATFORM] [PS4] [+] Refactor Age Symbols task in UAT. - Moved the AgeStore task from Win.Automation to BuildGraph.Automation and made it more generic. - Symbol server directory structure is now defined by the platform tool chain, which the common task uses to clean out old symbols. - Added a "filter" parameter to prevent age tasks deleting symbols from unrelated builds in shared symbol servers. Modified OrionBuild.xml to age both the Windows and PS4 symbol stores. Change 3097713 on 2016/08/23 by Luke.Thatcher [PLATFORM] [PS4] [+] Enable new PS4 crash handler server - Created live deployment profile and applied the required config file changes. Change 3099214 on 2016/08/24 by Luke.Thatcher [PLATFORM] [PS4] [!] Fix compile error in PS4 tool chain. For some reason, this only breaks ocassionally. Maybe we're alternating between the 2013 and 2015 C# compilers depending on what initiates the build (e.g. Visual Studio vs GenerateProjectFiles)? Change 3099222 on 2016/08/24 by Luke.Thatcher [PLATFORM] [PS4] [+] Added PS4 support for FPlatformMisc::MessageBoxExt using the MsgDialog library. - Note, only one and two button message dialogs are supported (limitation of MsgDialog). Change 3099260 on 2016/08/24 by Luke.Thatcher [PLATFORM] [PS4] [~] Better PS4 exit function. Calls quick_exit instead of abort when we've not asserted. Allows for a "cleaner" forced exit without generating a crash dump. Change 3101192 on 2016/08/25 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3101944 on 2016/08/25 by Daniel.Lamb Ask to save the current level when we are using launch on. Change 3102036 on 2016/08/25 by Nick.Shin check for minimum expected size upon data received from network #jira UE-13657 - HTML5 plugin OnRawRecieve overflow Change 3102115 on 2016/08/25 by Brent.Pease - Fix small errors that probably only show up in the mac mono build #code.review peter.sauerbrei Change 3102747 on 2016/08/26 by Jeremiah.Waldron Re-submitting OnlineSubsystemGameCircle with TPS permission for Amazon SDK - Also fixed the plugin to remove any related files from the final package when IAP is disabled or GameCircle support itself is disabled with the plugin still enabled - Added support for new AlreadyOwned IAP response code as well which is already used for GooglePlay and IOS Change 3102900 on 2016/08/26 by Nick.Shin since last checkin (CL: 2981945) - prints are crashing the browser - this change will allow browser to print the details via console.log() #jira UE-26047 - HTML5 HTTP Response Headers not implemented Change 3103130 on 2016/08/26 by Brent.Pease UE-24679 - Enable the ability to change ports for a firewall to pass them through rsync Change 3103225 on 2016/08/26 by Daniel.Lamb Fixed issue with warning which would cause crash. Change 3103425 on 2016/08/26 by Dmitry.Rekman Enable offscreen GL rendering without X. - Added new video subsystem to SDL that is uses EGL to initialize the context. - Most windoing functions stubbed. - Also added a new test case to TestPAL for easier debugging. Change 3104743 on 2016/08/29 by Brent.Pease Support remote offline metal shader compilation Change 3105051 on 2016/08/29 by Brent.Pease UE-2382 - TASK: MobleMVP: iOS: Add ability to view iOS device console output in the editor UFE - IOS Automation will now create a thread to collect the console logs from the device and send them to C# Console output while the app is running on device - Made ProcessResult an interface (IProcessResult) which ProcessResult implements. This allows platforms to provide their own implementation if needed. - Moved the RunLoop related parts of CoreFoundation into MobileDevice.cs Change 3105053 on 2016/08/29 by Brent.Pease - IOS dll's as part of the last check-in Change 3106853 on 2016/08/30 by Jeff.Campeau Implement FD3D11DynamicRHI::RHICreateComputeFence to prevent memory overwrite Change 3107361 on 2016/08/30 by Dmitry.Rekman Renderer: changes to allow postproc delegates. Change 3107362 on 2016/08/30 by Dmitry.Rekman Plugin with a CUDA postproc example. - Linux version only. Runs under a headless GL too (without X). - Disabled during cross-compilation, can be compiled natively only. - CUDA kernel should be compiled separately, CMakefile with compilation attached (can be used to generate VStudio projects as well). - To test the output, run under the debugger, interrupt and set global variable GSaveTheOutput to 50 (this will write out kernel output buffer 50 times as .bmp files into working directory). Change 3107913 on 2016/08/31 by Daniel.Lamb Fixed loading of cooked content in the editor. Change 3107916 on 2016/08/31 by Daniel.Lamb Added error case when shader compilation fails to notify shader. #test Cook shooter game. Change 3108080 on 2016/08/31 by Josh.Adams - Fixed PS4Automation compile errors Change 3109077 on 2016/08/31 by Brent.Pease Fix C# debug builds by specifying x64 and add reference to MobileDeviceInterface Change 3110086 on 2016/09/01 by Dmitry.Rekman Fix race condition in PThread runnable (UE-35074). - Instead of relying on busy-wait, join the threads. This prevents race between PostRun() (executed in the context of the thread) and FPThreadRunnableThread() destructor (see UE-34909). - Do not use an invalid value for pthread_t, since there's none. Change 3110172 on 2016/09/01 by Dmitry.Rekman Fixed a crash exiting VR Preview on Windows GL4 (UE-28708). - PR #2188 submitted by ardneran. Change 3110313 on 2016/09/01 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3111134 on 2016/09/01 by Dmitry.Rekman UBT: prevent mono from hanging on Ctrl-C. - Sometimes Ctrl-C can cause thread creation to fail. Without this change, UBT would lock up. Change 3111171 on 2016/09/01 by Brent.Pease Move all C# projects to use the x64 Platform for consistency with other changes made to move to the x64 Platform Change 3111177 on 2016/09/01 by Dmitry.Rekman Fix Linux build on systems without CUDA (UE-35460). Change 3111548 on 2016/09/02 by Luke.Thatcher [PLATFORM] [PS4] [!] Fix for PS4 iterative deployment. - Changes in Dev-Mobile broke the deployment manifests, as PS4 was now using the wrong filename when creating delta and obsolete file lists. Change 3111863 on 2016/09/02 by Dmitry.Rekman Better fix for build without CUDA (UE-35460). Change 3112738 on 2016/09/02 by Mark.Satterthwaite Fix the pausing particles on Metal - one line bug in the Metal query implementation meant that the first query wouldn't return the correct result for no good reason. #jira UE-34989 Change 3114579 on 2016/09/06 by Chris.Babcock Fix Vulkan include path in NDK check (contributed by geediiiiky) #jira UE-35490 #github #2758 #ue4 #android Change 3115115 on 2016/09/06 by Jeff.Campeau Calculate buffer size for paks using the bitwindow override as needed Change 3115600 on 2016/09/07 by Luke.Thatcher [PLATFORM] [PS4] [~] Make the crash dump handler registration much earlier, to catch crashes in early engine init. - Fixed up places in FGenericCrashContext::SerializeContentToBuffer which used the command line. If we crash early, the command line may not have been initialized yet. - Added a GetNoInit function to FThreadHeartBeat to avoid creating the heart beat thread if we crash early, and the thread doesn't exist yet. Tested by calling abort() immediately inside int main(), and we get a valid crash dump that the crash handler service can consume. Change 3115676 on 2016/09/07 by Luke.Thatcher [PLATFORM] [~] Dev-Platform integration fix for original CL 3064888 in //Orion/Release-29.1 Add .exe and .dll to windows symbol upload file filters. Change 3115811 on 2016/09/07 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3115944 on 2016/09/07 by Michael.Trepka Implemented IsGamepadAttached() for Mac Change 3115948 on 2016/09/07 by Michael.Trepka Don't try to restore Help menu item on Mac if MenuBlock does not contain it Change 3116200 on 2016/09/07 by Jeff.Campeau Fix parameter ordering Change 3117660 on 2016/09/08 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3117728 on 2016/09/08 by Michael.Trepka Copy of CL 3117698 by Mike.Fricker Fixed regression with editor's Simulate mode where cursor would teleport back to the center of the viewport after every click - This bug was introduced in CL 3075932 from a borderless window cursor handling fix that was needed for games that capture the cursor Change 3117797 on 2016/09/08 by Peter.Sauerbrei Shader Resource compression Change 3117988 on 2016/09/08 by Brent.Pease - Solutiion generator will now pick x64 instead of AnyCPU for the default platform configuration - Fix what I think was a merge error in BuildGraph.cs Change 3118296 on 2016/09/08 by Daniel.Lamb Fixed crash with launch on. Couldnt' correctly detect previous generated ini settings. #test launch on QA game #jira UE-35741 Change 3118438 on 2016/09/08 by JohnHenry.Carawon Fix UAT compilation on Linux #UE-35745 Change 3118934 on 2016/09/08 by Jeff.Campeau Shader compression setting based on target platform instead of cooking host platform. #jira UE-35753 Change 3120190 on 2016/09/09 by Ben.Marsh Add missing Platform attribute to build script for Dev-Platform. [CL 3120378 by Josh Adams in Main branch]
2016-09-09 20:13:41 -04:00
private static void RunClientWithServer(List<DeploymentContext> DeployContextList, string ServerLogFile, IProcessResult ServerProcess, string ClientApp, string ClientCmdLine, ERunOptions ClientRunFlags, string ClientLogFile, ProjectParams Params)
{
Copying //UE4/Dev-Platform to //UE4/Dev-Main (Source: //UE4/Dev-Platform @ 3120366) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 2714591 on 2015/10/02 by Ben.Marsh Initial branch of files from Engine-Main (//UE4/Engine-Main) to Dev-Platform (//UE4/Dev-Platform) Change 2916715 on 2016/03/21 by Daniel.Lamb First pass at splitting out build cook run into into seperate scripts. Change 2948322 on 2016/04/19 by Nick.Shin update libwebsockets to v1.7.4 part 4 of 4 - doing this in stages for tracking purposes #jira UEPLAT-1246 - Update libWebsockets #jira UEPLAT-1221 - update websocket library #jira UEPLAT-1204 - Rebuild libwebsockets with SSL Change 2970016 on 2016/05/07 by Nick.Shin undo all of the following upgrades: - zlib - openssl - libcurl - libwebsockets and reset webrtc #jira UE-30298 - Fortnite and Orion crash on login Change 3059693 on 2016/07/21 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3061151 on 2016/07/22 by Niklas.Smedberg Fast ASTC texture compression, using ISPC. #jira UE-32308 Change 3061428 on 2016/07/22 by Peter.Sauerbrei Back out changelist 3061151 as it wasn't approved for submission Change 3061970 on 2016/07/22 by Steve.Cano Adding AdMob interstitital ad support for Android, including Blueprint functions #jira UE-33286 #ue4 #android Change 3062160 on 2016/07/22 by Mark.Satterthwaite Fix the fix for handling RHISetStreamSource overriding stride on Metal - not all MTLVertexDescriptors are equally hashable so do this ourselves. #jira UE-33355 Change 3062770 on 2016/07/24 by Brent.Pease UE-32397 Error Message displays as Unknown Error when failing to supply a Remote Build server for ios on Windows Change 3063227 on 2016/07/25 by Dmitry.Rekman Update hlslcc cross-compile after libc++ change. Change 3063314 on 2016/07/25 by Jeff.Campeau Xbox One DLL loading Receipts can be read back by request for target info Change 3063329 on 2016/07/25 by Mark.Satterthwaite CL #3046743 was breaking other samples in unexpected ways after a recent Main merge, so make a Metal-specific change to the shader instead and amend the MetalBackend to better match HLSL's handling of NaN/inf with common single-precision float intrinsics. This is sufficient to fix the AtmosphericFog and the recent regressions. #jira UE-33600 #jira UE-33028 #jira UE-27879 #jira UE-25802 Change 3063492 on 2016/07/25 by Brent.Pease UE-23846 - iOS Movie Player can't handle videos at resolutions that aren't multiples of 16 UE-33200 - A movie isn't played on iOS occasionally. Change 3063729 on 2016/07/25 by Dmitry.Rekman Linux: enable XGE on all platforms. #tests Cross-compiled a number of Linux targets on Windows. Change 3063732 on 2016/07/25 by Dmitry.Rekman Fixed formatting (spaces->tabs) in previous change. Change 3063750 on 2016/07/25 by Daniel.Lamb Added code to dump the cook modification delegate loads to log. Fixed the memory usage output log. #test cook paragon. Change 3063804 on 2016/07/25 by Daniel.Lamb Added cookpartialgc additional commandline option to uat. #test UFE Change 3064008 on 2016/07/25 by Mark.Satterthwaite For non-shipping builds conditionally bind a default uniform buffer in Metal and report an error if the slot was unbound, if our validation layer is enabled attempt to report the shader source in question. This relies on the shader compiler providing accurate information about uniform buffer bindings and won't fix all occurances of bad uniform usage (if a buffer is bound but too short the result will be GPU restarts or an error in Apple's validation layer - we can't detect this case) but will help debug the typical error of leaving an active slot unbound. #jira FORT-27685 Change 3064141 on 2016/07/25 by Jeff.Campeau Rebuild vpxmd.lib with delayed codegen disabled (fixes linker warning building Win64). Change 3065024 on 2016/07/26 by Nick.Shin Change filetype remove exclusive check out bit requested by or.coheni & nick.penwarden Change 3065274 on 2016/07/26 by Jonathan.Fitzpatrick DirectoriesToAlwaysStageAsUFS now properly filters out *.uasset and *.umap files This prevents the bug where cooked assets get trampled by staging their uncooked version on top of them during the UFS step Added a file filter to DirectoriesToAlwaysStageAsUFS for uasset and umap. Change 3066338 on 2016/07/27 by Mark.Satterthwaite Handle releasing an SRV/UAV & the source object within a single Metal command-buffer. #jira UE-33779 Change 3066789 on 2016/07/27 by Daniel.Lamb Realtime mode does not save any packages anymore unless they are ready. #test cookontheside, cookbythebook shooter game Change 3066847 on 2016/07/27 by Jeff.Campeau Fix define #2634 #jira UE-33813 Change 3068868 on 2016/07/28 by Mark.Satterthwaite Extend hlslcc's handling of switch-statements to allow implict casts from scalar bool, half & float as HLSL itself permits while also making sure it errors if the expression input is not scalar. This fixes shader compile errors in UT. Change 3070040 on 2016/07/29 by Dmitry.Rekman Delete Nadzorca. Change 3070947 on 2016/07/29 by Jeff.Campeau Perforce C++ API 2015.2 (includes debug libraries) Change 3073707 on 2016/08/02 by Daniel.Lamb Derived data cache commandlet runs resolve string asset references to load any string asset refereced packages from the map. Also process async results from shaders being compiled so they can have their memory resources released. #test DerivedDataCache commandlet shootergame. Change 3076613 on 2016/08/03 by Brent.Pease + UnrealTargetConfiguration is now passed into deploy and package methods + The UIRequiredDeviceCapabilities plist key now only considers the architectures from the corresponding target configuration (shipping or development) Change 3076668 on 2016/08/03 by Brent.Pease Back out changelist 3076613 Change 3077157 on 2016/08/04 by Daniel.Lamb Fixed up DLC staging so that it stages to the proper mount point. Fixes up include engine content in DLC staging paths. #test Made up shooter game DLC Change 3077191 on 2016/08/04 by Daniel.Lamb More smartly process async shader compilation if we are waiting for it. #test cook on the side shooter game cook by the book shooter game. Change 3077412 on 2016/08/04 by Mark.Satterthwaite Fix "iOS Metal-based build crashes at launch with sub-levels": - Slate should not bind the null RHI texture from an unitialised texture atlas - atlases only have a valid texture pointer once an entry has been added to them and in the template projects an empty sub-level doesn't add anything. - To prevent this kind of bug resurfacing and being so hard to track down add Metal shader binding validation to our validation layer as Apple's is incomplete on iOS and won't warn us about nil texture usage which causes these GPU restarts. This requires reworking our vertex declaration handling to be more efficient so that we can cache the pipeline reflection data as well as the pipeline objects. - Fix validation error of texture reallocation on loading template projects under Metal. #jira UE-30847 Change 3077958 on 2016/08/04 by Brent.Pease + UnrealTargetConfiguration is now passed into deploy and package methods + The UIRequiredDeviceCapabilities plist key now only considers the architectures from the corresponding target configuration (shipping or development) Change 3079503 on 2016/08/05 by Mark.Satterthwaite Initialise more variable types to 0 in Metal shaders to workaround Xcode 8 toolchain no longer doing this for us for "threadgroup shared" variables. Everything but structs and atomic's will now be initialised. #jira UE-33856 Change 3079737 on 2016/08/05 by Jeff.Campeau Add support for delay load DLLs on Xbox One Turn off warnging for missing PDBs to match VCToolchain.cs Change 3081005 on 2016/08/08 by Mark.Satterthwaite Fix-up Metal device name on AMD for macOS 10.12 which reports it correctly and enable tiled reflections on Intel from macOS 10.12 too as they now work. Change 3081557 on 2016/08/08 by Daniel.Lamb File-> Package saves all packages before starting packaging. #test File package first person template Change 3082215 on 2016/08/09 by Lee.Clark PS4 - Added 4k profile Change 3082412 on 2016/08/09 by Daniel.Lamb Fixed cook on the fly server not handling cook requests. #test Cook on the fly shooter game. Change 3082955 on 2016/08/09 by Dmitry.Rekman Linux: convert existing Strcat() uses to Strncat(). - Strcat() does not check destination size so can silently corrupt memory. While this was not observed, this conversion removes this concern altogether. Change 3083772 on 2016/08/10 by Luke.Thatcher [PLATFORM] [PS4] [+] Checking in PS4CrashHandler files so we have a copy in Perforce rather than just on the server. - Taken from \\devweb-02 and removed all the unused files/dependencies. - Created a publish profile pointing to \\devweb-02\Sites\PS4Services\PS4CrashHandlerDev so I'm not writing over the existing deployed crash handler. - Moved all code in the Page_Load event to inside the check for the HTTP method (POST) otherwise GET'ing the page from a browser will generate crash folders that hang around forever. Change 3085450 on 2016/08/11 by Lee.Clark PS4 - Fix mediaplayer pipeline allocation Change 3086360 on 2016/08/11 by Michael.Trepka Fixed a non-unity build error in Mac UnrealFrontend Change 3087224 on 2016/08/12 by Luke.Thatcher [PLATFORM] [PS4] [~] Refactor PS4 Crash Handler site - Removed CoreDumpHandler. Processing dump files is handled directly by an async thread within the aspx process. - Separated configuration values into their own class. Currently set to output to a testing directory, rather than the actual crash reporter landing zone. - Added a debug upload page to allow manual submission of .orbisdmp/.txt settings files, accessible by GET'ing Default.aspx. - Added logging. Logs self-delete after 30 days. Testing required before we switch to the new system. #jira UE-34504 #jira OR-26886 Change 3087626 on 2016/08/12 by Dmitry.Rekman PR #2689: Fix copying/duplicating failing on Linux (UE-34586). - Contributed by Web-eWorks. Change 3087991 on 2016/08/12 by Mark.Satterthwaite Initial AVFoundation implementation of Media Framework for Mac, iOS & tvOS. - Video playback occurs via AVPlayerItemVideoOutput's attached to the AVPlayerItem's output. This means gathering video samples is trivial. - Metal texture updates occur by wrapping the texture object provided by AVF - for Mac this is simple as it can bind to the IOSurface directly, for iOS/tvOS we have to create a CVMetalTextureCache and allocate our texture from there. - OpenGL and OpenGLES currently have to lock the pixel buffer and upload to a texture the old fashioned way - this should be revisited when there is time. - Subtitles/Captions are captured using AVPlayerItemLegibleOutput which also connects to the AVPlayerItem's output. - On Mac audio samples are returned by manually reading from the stream using an AVAssetReaderTrackOutput, including manual seeking and synching. - On iOS/tvOS the audio is played directly by AVPlayer because the IOSAudio system can't handle procedural buffers - otherwise it could reuse the Mac code. - AVFoundation does not support AVI - that's an obsolete Microsoft/Windows file-format. - Only 'file://' URLs are supported - streaming would require a totally different audio solution (using MTAudioProcessingTap) and has many more edge and failure cases that would need to be handled. #jira UE-34315 Change 3088790 on 2016/08/15 by Luke.Thatcher [PLATFORM] [PS4] [~] Hook new PS4 crash handler up to the crash reporter website. - Removed indentation from generated crash context XML file. The crash reporter process does manual XML parsing which doesn't correctly handle whitespace at the start of lines. - Switched the final output folder to match the one the crash reporter process is watching. - Hide upload form on a config variable. #jira UE-34504 #jira OR-26886 Change 3089060 on 2016/08/15 by Luke.Thatcher [PLATFORM] [PS4] [!] Change PS4 crash handler log file extension to ".ps4chlog", otherwise the crash reporter site attaches the wrong log file to the crash report. Allowed showing of debug upload form via "Default.aspx?showform=1" query string. #jira UE-34504 #jira OR-26886 Change 3089089 on 2016/08/15 by Mark.Satterthwaite Duplicated changes to AppleMovieStreamer from CL #3088149. #jira UE-34315 Change 3089460 on 2016/08/15 by Mark.Satterthwaite Duplicate CL #3080971: Workaround a macOS 10.12 Beta bug on some Metal drivers that can't initialise temporary/local variable arrays, only those that are marked threadgroup shared. #jira UE-34355 Change 3089465 on 2016/08/15 by Mark.Satterthwaite For Metal shader translation retain more precision for float constants -1.0f >< 1.0f by emitting them in scientific notation - prevents Hammersley constant amongst others from being flushed to 0. Change 3089902 on 2016/08/15 by Daniel.Lamb Changed the next compiling ID to the correct compiling ID. #test Cook Change 3089903 on 2016/08/15 by Daniel.Lamb Cooker monitors config useage during cook and uses those settings to invalidate cooked content instead of all config settings. Change 3090114 on 2016/08/16 by Luke.Thatcher [PLATFORM] [PS4] [~] Minor change to PS4 settings text on crash handler site. Change 3090949 on 2016/08/16 by Nick.Shin WebSocketNetDriver crash fix filled in missing chunk of code that calls PacketHandler's "packet modifiers" #jira UE-25492 HTML5 Client cannot connect to Windows Server #jira UE-30880 WinServer crashes when NetDriver is set to WebSocket and Client attempts to connect via websocket #code.review john.pollard john.barrett Change 3091265 on 2016/08/16 by Brent.Pease Add IOS support to HarfBuzz Change 3091267 on 2016/08/16 by Brent.Pease Add references to fix mono build Change 3091291 on 2016/08/16 by Nick.Shin CIS warning fix #jira UE-25492 HTML5 Client cannot connect to Windows Server #jira UE-30880 WinServer crashes when NetDriver is set to WebSocket and Client attempts to connect via websocket Change 3091781 on 2016/08/17 by Joe.Barnes UE-33640: Exposed UPrimitiveComponent::IsAnyRigidBodyAwake() to Blueprints. Change 3092687 on 2016/08/17 by Daniel.Lamb Added support for using binned allocator in cooker instead of tbb. #test Cook shootergame. Change 3093867 on 2016/08/18 by Mark.Satterthwaite Use a read/write mutex to protect access to Metal's internal shader pipeline caches so that parallel threads can progress in the common case where new shaders are not being compiled. Change 3093950 on 2016/08/18 by Mark.Satterthwaite Change the Mac GPU identification code to cope with AMD's new naming scheme on 10.12. Change 3093951 on 2016/08/18 by Mark.Satterthwaite More SCW threads on Mac - they work now. Change 3093960 on 2016/08/18 by Mark.Satterthwaite Increase the default number of command-buffers on Mac because bigger games overflow the current limit of 64 per queue. Change 3096493 on 2016/08/22 by Jeff.Campeau Use Xbox version of DirectX include. Change 3097509 on 2016/08/23 by Luke.Thatcher [PLATFORM] [PS4] [+] Refactor PS4 Symbol Publish - Moved the SymStore task from Win.Automation to BuildGraph.Automation, and made it more generic. - The specifics of uploading symbols are now implemented in the platform tool chain, alongside StripSymbols(). - Re-generated the build graph schema file. - Removed the old PS4 symbols upload path in the package step. Modified OrionBuild.xml to publish symbols for all PS4 dev, test and shipping config builds of OrionClient. Change 3097635 on 2016/08/23 by Luke.Thatcher [PLATFORM] [PS4] [+] Refactor Age Symbols task in UAT. - Moved the AgeStore task from Win.Automation to BuildGraph.Automation and made it more generic. - Symbol server directory structure is now defined by the platform tool chain, which the common task uses to clean out old symbols. - Added a "filter" parameter to prevent age tasks deleting symbols from unrelated builds in shared symbol servers. Modified OrionBuild.xml to age both the Windows and PS4 symbol stores. Change 3097713 on 2016/08/23 by Luke.Thatcher [PLATFORM] [PS4] [+] Enable new PS4 crash handler server - Created live deployment profile and applied the required config file changes. Change 3099214 on 2016/08/24 by Luke.Thatcher [PLATFORM] [PS4] [!] Fix compile error in PS4 tool chain. For some reason, this only breaks ocassionally. Maybe we're alternating between the 2013 and 2015 C# compilers depending on what initiates the build (e.g. Visual Studio vs GenerateProjectFiles)? Change 3099222 on 2016/08/24 by Luke.Thatcher [PLATFORM] [PS4] [+] Added PS4 support for FPlatformMisc::MessageBoxExt using the MsgDialog library. - Note, only one and two button message dialogs are supported (limitation of MsgDialog). Change 3099260 on 2016/08/24 by Luke.Thatcher [PLATFORM] [PS4] [~] Better PS4 exit function. Calls quick_exit instead of abort when we've not asserted. Allows for a "cleaner" forced exit without generating a crash dump. Change 3101192 on 2016/08/25 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3101944 on 2016/08/25 by Daniel.Lamb Ask to save the current level when we are using launch on. Change 3102036 on 2016/08/25 by Nick.Shin check for minimum expected size upon data received from network #jira UE-13657 - HTML5 plugin OnRawRecieve overflow Change 3102115 on 2016/08/25 by Brent.Pease - Fix small errors that probably only show up in the mac mono build #code.review peter.sauerbrei Change 3102747 on 2016/08/26 by Jeremiah.Waldron Re-submitting OnlineSubsystemGameCircle with TPS permission for Amazon SDK - Also fixed the plugin to remove any related files from the final package when IAP is disabled or GameCircle support itself is disabled with the plugin still enabled - Added support for new AlreadyOwned IAP response code as well which is already used for GooglePlay and IOS Change 3102900 on 2016/08/26 by Nick.Shin since last checkin (CL: 2981945) - prints are crashing the browser - this change will allow browser to print the details via console.log() #jira UE-26047 - HTML5 HTTP Response Headers not implemented Change 3103130 on 2016/08/26 by Brent.Pease UE-24679 - Enable the ability to change ports for a firewall to pass them through rsync Change 3103225 on 2016/08/26 by Daniel.Lamb Fixed issue with warning which would cause crash. Change 3103425 on 2016/08/26 by Dmitry.Rekman Enable offscreen GL rendering without X. - Added new video subsystem to SDL that is uses EGL to initialize the context. - Most windoing functions stubbed. - Also added a new test case to TestPAL for easier debugging. Change 3104743 on 2016/08/29 by Brent.Pease Support remote offline metal shader compilation Change 3105051 on 2016/08/29 by Brent.Pease UE-2382 - TASK: MobleMVP: iOS: Add ability to view iOS device console output in the editor UFE - IOS Automation will now create a thread to collect the console logs from the device and send them to C# Console output while the app is running on device - Made ProcessResult an interface (IProcessResult) which ProcessResult implements. This allows platforms to provide their own implementation if needed. - Moved the RunLoop related parts of CoreFoundation into MobileDevice.cs Change 3105053 on 2016/08/29 by Brent.Pease - IOS dll's as part of the last check-in Change 3106853 on 2016/08/30 by Jeff.Campeau Implement FD3D11DynamicRHI::RHICreateComputeFence to prevent memory overwrite Change 3107361 on 2016/08/30 by Dmitry.Rekman Renderer: changes to allow postproc delegates. Change 3107362 on 2016/08/30 by Dmitry.Rekman Plugin with a CUDA postproc example. - Linux version only. Runs under a headless GL too (without X). - Disabled during cross-compilation, can be compiled natively only. - CUDA kernel should be compiled separately, CMakefile with compilation attached (can be used to generate VStudio projects as well). - To test the output, run under the debugger, interrupt and set global variable GSaveTheOutput to 50 (this will write out kernel output buffer 50 times as .bmp files into working directory). Change 3107913 on 2016/08/31 by Daniel.Lamb Fixed loading of cooked content in the editor. Change 3107916 on 2016/08/31 by Daniel.Lamb Added error case when shader compilation fails to notify shader. #test Cook shooter game. Change 3108080 on 2016/08/31 by Josh.Adams - Fixed PS4Automation compile errors Change 3109077 on 2016/08/31 by Brent.Pease Fix C# debug builds by specifying x64 and add reference to MobileDeviceInterface Change 3110086 on 2016/09/01 by Dmitry.Rekman Fix race condition in PThread runnable (UE-35074). - Instead of relying on busy-wait, join the threads. This prevents race between PostRun() (executed in the context of the thread) and FPThreadRunnableThread() destructor (see UE-34909). - Do not use an invalid value for pthread_t, since there's none. Change 3110172 on 2016/09/01 by Dmitry.Rekman Fixed a crash exiting VR Preview on Windows GL4 (UE-28708). - PR #2188 submitted by ardneran. Change 3110313 on 2016/09/01 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3111134 on 2016/09/01 by Dmitry.Rekman UBT: prevent mono from hanging on Ctrl-C. - Sometimes Ctrl-C can cause thread creation to fail. Without this change, UBT would lock up. Change 3111171 on 2016/09/01 by Brent.Pease Move all C# projects to use the x64 Platform for consistency with other changes made to move to the x64 Platform Change 3111177 on 2016/09/01 by Dmitry.Rekman Fix Linux build on systems without CUDA (UE-35460). Change 3111548 on 2016/09/02 by Luke.Thatcher [PLATFORM] [PS4] [!] Fix for PS4 iterative deployment. - Changes in Dev-Mobile broke the deployment manifests, as PS4 was now using the wrong filename when creating delta and obsolete file lists. Change 3111863 on 2016/09/02 by Dmitry.Rekman Better fix for build without CUDA (UE-35460). Change 3112738 on 2016/09/02 by Mark.Satterthwaite Fix the pausing particles on Metal - one line bug in the Metal query implementation meant that the first query wouldn't return the correct result for no good reason. #jira UE-34989 Change 3114579 on 2016/09/06 by Chris.Babcock Fix Vulkan include path in NDK check (contributed by geediiiiky) #jira UE-35490 #github #2758 #ue4 #android Change 3115115 on 2016/09/06 by Jeff.Campeau Calculate buffer size for paks using the bitwindow override as needed Change 3115600 on 2016/09/07 by Luke.Thatcher [PLATFORM] [PS4] [~] Make the crash dump handler registration much earlier, to catch crashes in early engine init. - Fixed up places in FGenericCrashContext::SerializeContentToBuffer which used the command line. If we crash early, the command line may not have been initialized yet. - Added a GetNoInit function to FThreadHeartBeat to avoid creating the heart beat thread if we crash early, and the thread doesn't exist yet. Tested by calling abort() immediately inside int main(), and we get a valid crash dump that the crash handler service can consume. Change 3115676 on 2016/09/07 by Luke.Thatcher [PLATFORM] [~] Dev-Platform integration fix for original CL 3064888 in //Orion/Release-29.1 Add .exe and .dll to windows symbol upload file filters. Change 3115811 on 2016/09/07 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3115944 on 2016/09/07 by Michael.Trepka Implemented IsGamepadAttached() for Mac Change 3115948 on 2016/09/07 by Michael.Trepka Don't try to restore Help menu item on Mac if MenuBlock does not contain it Change 3116200 on 2016/09/07 by Jeff.Campeau Fix parameter ordering Change 3117660 on 2016/09/08 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3117728 on 2016/09/08 by Michael.Trepka Copy of CL 3117698 by Mike.Fricker Fixed regression with editor's Simulate mode where cursor would teleport back to the center of the viewport after every click - This bug was introduced in CL 3075932 from a borderless window cursor handling fix that was needed for games that capture the cursor Change 3117797 on 2016/09/08 by Peter.Sauerbrei Shader Resource compression Change 3117988 on 2016/09/08 by Brent.Pease - Solutiion generator will now pick x64 instead of AnyCPU for the default platform configuration - Fix what I think was a merge error in BuildGraph.cs Change 3118296 on 2016/09/08 by Daniel.Lamb Fixed crash with launch on. Couldnt' correctly detect previous generated ini settings. #test launch on QA game #jira UE-35741 Change 3118438 on 2016/09/08 by JohnHenry.Carawon Fix UAT compilation on Linux #UE-35745 Change 3118934 on 2016/09/08 by Jeff.Campeau Shader compression setting based on target platform instead of cooking host platform. #jira UE-35753 Change 3120190 on 2016/09/09 by Ben.Marsh Add missing Platform attribute to build script for Dev-Platform. [CL 3120378 by Josh Adams in Main branch]
2016-09-09 20:13:41 -04:00
IProcessResult ClientProcess = null;
var OtherClients = new List<IProcessResult>();
bool WelcomedCorrectly = false;
int NumClients = Params.NumClients;
string AllClientOutput = "";
int LastAutoFailIndex = -1;
if (Params.Unattended)
{
string LookFor = "Bringing up level for play took";
if (Params.DedicatedServer)
{
LookFor = "Welcomed by server";
}
else if (Params.RunAutomationTest != "")
{
LookFor = "Automation Test Succeeded";
}
else if (Params.RunAutomationTests)
{
LookFor = "Automation Test Queue Empty";
}
{
while (!FileExists(ServerLogFile) && !ServerProcess.HasExited)
{
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 4285612) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3836829 by Ben.Marsh UBT: Fix ability to precompile plugins from installed engine builds. Change 3839519 by Ben.Marsh UBT: Simplify configuring bPrecompile and bUsePrecompile settings for modules. Each rules assembly can now be configured as installed, which defaults the module rules it creates to use precompiled data. Change 4042043 by Steve.Robb GitHub #4705 : Added weak lambda's for delegates and multicast delegates. Change 4042056 by Robert.Manuszewski Optimized Mark Phase of GC by up to 10ms by making it run in parallel and removing a huge array presize which we didn't need. Change 4042104 by Robert.Manuszewski Set the minimum GC cluster size to 5 so that GC doesn't have to process micro clusters which are more expensive than processing individual objects + Exposed the minimum cluster size to ini and project settings as gc.MinGCClusterSize + Added the ability to sort clusters by name/object count/mutable object count/referenced clusters count when dumping them with gc.ListClusters command Change 4042377 by Robert.Manuszewski Reworked how GC and other threads (ALT specifically) interact - GC will now notify the ALT it wants to run and ALT will immediately try to finish its current work to allow that. Also the entire ALT tick is now protected against GC running at the same time to improve ALT stability. + added gc.ForceCollectGarbageEveryFrame console variable that triggers a forced GC every frame Change 4042427 by Robert.Manuszewski Changed FGCCSyncObject to use events when waiting for GC to finish so that it doesn't spin on non-game threads when GC is running Change 4042482 by Robert.Manuszewski Unhashing unreachable objects (ConditionalBeginDestroy) will now also be done incrementally, just like the purge phase of Garbage Collection Change 4042635 by Robert.Manuszewski Fix for a potential assert when incremental purge garbage is pending and something forces a full purge Change 4044092 by Steve.Robb Fix for forward declared CoreUObject weakobject types in delegates when building in Clang. Change 4044102 by Robert.Manuszewski Fix for a possible hang when worker threads are preventing GC from running and something is later trying to FlushAsyncLoading with the Async Loading Thread enabled Change 4044113 by Steve.Robb Another Clang fix. Change 4044160 by Robert.Manuszewski Disregard For GC pool will now be enabled by default in cooked builds Change 4044287 by Steve.Robb Typo fix. Change 4047723 by Graeme.Thornton TBA: Fixes for import/export name cache and object resolving Change 4048015 by Graeme.Thornton TBA: Weak/Soft/Lazy pointer serialization changes * Remove FWeakObjectPtr::Serialize, move it's logic into, and replace usages of with calls to, FArchiveUObject::SerializeWeakObjectPtr(). Ensures that something is always sent to the archive so that structured archives can be kept happy in the future. * Added Weak/Soft/Lazy pointer handling to the structured archive slot interface and all the formatters. Binary formatters just forward the call onto their inner and text archives store as a string path reference. * FArchiveUObjectFromStructuredArchive caches all these pointer types and stores indices in the binary block, same as with a UObject*. All pointers are then forwarded to the underlying formatter in one go on finalization. Change 4048021 by Steve.Robb Fix for binding an unbound TFunction to another TFunction with a different signature. Also all null pointers now count as unbindings, not just nullptr. TIsMemberPointer added. TIsATFunction and TIsATFunctionRef renamed to remove the 'A's. Change 4048544 by Robert.Manuszewski Fixing ConditionalBeginDestroy profiling after changes to incremental CBD. Change 4051028 by Graeme.Thornton TBA: ArchiveFromStructuredArchive adapter uses Inner to determine if it is outputting to text, and sets it's own ArIsTextFormat to false Change 4051056 by Graeme.Thornton TBA: High level tagged property / UObject base class text serialization - UObject serialize converted to structured archive - Properties written to text individually with text tags, and then binary adapted values - Only saves, doesn't load Change 4051111 by Graeme.Thornton TBA: Temporarily disable loading of text assets until tagged property serialization path is fixed up Change 4051154 by Graeme.Thornton TBA: Convert a few uobject serializers to structured archive format for example purposes Change 4051181 by Graeme.Thornton TBA: Added default structured archive implementation of SerializeItem to UProperty, which just calls the FArchive version on an FArchiveUObjectFromStructuredArchive adapter. Implemented structured archive SerializeItem for UArrayProperty Change 4051197 by Graeme.Thornton TBA: ObjectProperty text serialization Change 4051216 by Graeme.Thornton Restored a modified FWeakObjectPtr::Serialize function to keep backwards compatibility in code I don't have access to. Change 4051261 by Graeme.Thornton TBA: Convert UMetaData to structured archive Change 4051374 by Steve.Robb Incorrect assert removed. Change 4051562 by Robert.Manuszewski Adding stats for the new GC internal functions Change 4051614 by Graeme.Thornton TBA: Removed UProperty::SerializeItem(FArchive, ...) and replaced with UProperty::SerializeItem(FStructuredArchive::FSlot, ...). Fixed up most of them to work properly and added adapters in for any that were non-trivial. Change 4052512 by Graeme.Thornton TBA: Temporary workaround for softobjectptr and lazyobjectptr uproperties not serialization anything when they know the archive is a reference collector. They should always be serializing their pointers and letting the underlying archive itself ignore them. Change 4053917 by Robert.Manuszewski Clustered objects from clusters that are no longer reachable will now be marked as unreachable immediately when gathering unreachable objects Change 4053919 by Robert.Manuszewski Added the ability to disable incremental BeginDestroy in ini/project settings Change 4055518 by Daniel.Lamb Fixup for deterministic audio generation issue. Submitted on behalf of Rich.Whitehouse #jira nojira #test prefilght automated test. Change 4056854 by Graeme.Thornton TBA: Added a test asset to EngineTest which contains all the different property types and test cases. Change 4056858 by Graeme.Thornton TBA: Updated USetProperty to proper structured archive usage Change 4056872 by Graeme.Thornton TBA: Add map property field to test object Change 4056873 by Graeme.Thornton TBA: Convert UMapProperty to full structured archive Change 4056994 by Graeme.Thornton TBA: Converted FText over to structured archive. Implemented saving, but not loading. Change 4059728 by Ben.Marsh UBT: Add support for using adaptive non-unity builds when the engine and project are in separate repositories. Change 4059805 by Graeme.Thornton Fixed typo in text serialization. Fixes CIS automation test errors Change 4060007 by Graeme.Thornton TBA: FArchiveFromStructuredArchive will now access it's host slot lazily, i.e. only when a value is actually written to the archive. Change 4060092 by Stefan.Boberg Added optimized Windows console window output path to GenericConsoleOutput since this slowed down cooking considerably (2 minutes spent in wprintf alone for one large dataset) When stdout is attached to a console we use the WriteConsoleW function instead of wprintf since the latter is very slow especially in unbuffered mode which the engine currently configures for stdout (see setvbuf call in LaunchEngineLoop.cpp). At some point we should reconsider this buffering policy since it's likely to slow down other platforms as well but I wanted to do a safe change for now as I don't yet fully understand why the setvbuf call is there in the first place. Change 4060108 by Stefan.Boberg Introduced some additional target platform utilities to help with asset cook optimizations * We now assign each ITargetPlatform a zero-based ordinal value * Introduced FTargetPlatform and FTargetPlatformSet types to help store platform references and platform sets efficiently. These are not currently used in the engine but are designed to replace the existing ITargetPlatform/string/FName representations in the cooking data structures. Change 4060143 by Graeme.Thornton Undo //UE4/Dev-Core/Engine/Source/Runtime/... changelist 4060007 Needs some other changes that I haven't checked in yet... Change 4062432 by Ben.Marsh Fix error message when enumerating P4 changes. Change 4062648 by Ben.Marsh Add missing p4 integration action. Change 4063620 by Graeme.Thornton Integrated a fix from UDN where the engine would crash when trying to load a very small encrypted file (<16bytes) from a pak file, where the read address wasn't already aligned to the AES block size. (https://udn.unrealengine.com/questions/431989/crash-while-reading-a-very-small-file-in-encrypted.html) Change 4066963 by Robert.Manuszewski Fixing GC cluster verification code reporting false positives when a cluster is referencing another cluster through 'mutable' objects list. Change 4067133 by Robert.Manuszewski Changed log verbosity when reporting individual cases of GC cluster assumption violations as they are followed by an asser anyway and this way we get the chance to see all issues before we assert at the end of these checks. Change 4067443 by Steve.Robb FString can now be constructed from any char pointer type and length. Change 4068156 by Steve.Robb Fix necessary because of FString constructor change in CL# 4067443. Change 4070258 by Graeme.Thornton Fixes for VSCode Change 4070372 by Graeme.Thornton TBA: Script struct serialization to structured archives Change 4071913 by Ben.Marsh Move bulk of the code for UnrealPak into an engine developer module, so it can be used in the editor. Change 4071914 by Ben.Marsh Missing files. Change 4071937 by Ben.Marsh Missing header. Change 4072015 by Ben.Marsh Fixes for compiling PakFileUtilities as part of the editor. Change 4072826 by Steve.Robb TBitArray::Reserve() added. TBitArray::Add() overloaded to allow adding multiple bits. TSparseArray::Reserve() optimized to call the overloaded Add(). Change 4073271 by Daniel.Lamb Fixed add patch tier in project launcher passing the wrong commandline option to UAT. #test none Change 4074708 by James.Hopkin #core Removed redundant Casts Change 4074763 by Steve.Robb Fix for TSparseArray::Reserve() size. Change 4076063 by Ben.Marsh Add an "UnrealPak" commandlet with the same functionality as the standalone UnrealPak program. Invoke by running the editor with -run=UnrealPak and the standard UnrealPak commandline options. Change 4077064 by Robert.Manuszewski Fixing compile error in PakFileUtilities Change 4077144 by Graeme.Thornton TBA: TextAssetCommandlet improvements * Collect lists of broken assets during roundtrip tests and print a summary of packages that failed each phase at the end * After resaving as text, load the file back as a plain JSON hierarchy to ensure the output was valid Change 4077412 by Ben.Marsh Set the correct exit code for UnrealPak. Should return 0 on success, not 1. Change 4077760 by Graeme.Thornton TBA: Loading fixed for tagged property serialization Includes conversion of all UProperty::ConvertFromType() and SerializeFromMismatchedTag() functions to use structured archives Lazy initialization of FArchiveFromStructruredArchive when loading, to support the possibility of an adapter being create around an object property serialize call to its inner UStruct, which then decides not to do anything and return false. Stops the ArchiveFromStructuredArchive from consuming the slot and getting upset later on when we try to serialize normal tagged properties from it. Disabled lazy bulk data loading from text assets. Requires a bigger change to make it work. Added some debug checks to json input formatter which track the current value stack size when a new object is pushed onto the stack, and makes sure that the stack has returned to the same size when the object is popped. Catches cases where we unpack an array/stream to the value stack but then don't consume all the items. Change 4078800 by Ben.Marsh Change UAT to using the editor's UnrealPak commandlet rather than invoking the standalone UnrealPak executable. To improve performance when building several PAK files, also add a new -batch=<file> command which reads commands to execute in parallel from a text file. Change 4079745 by Graeme.Thornton TBA: Migrated a couple of UObject Serialize functions to FStructuredArchive (SoundCue / MaterialExpressions / Editor strip flags) Change 4079847 by Graeme.Thornton TBA: Add 'FindMismatchedSerializers' mode to text asset commandlet, which dumps out a list of all UClasses which don't have the CLASS_MatchedSerializers flag, meaning we can't guarantee the have Serialize functions for FArchive AND FStructuredArchive, therefore we can't use the new structured archive based serialize path. Should only ever be native instrinsic classes as UHT takes care of all other cases. Change 4079925 by Ben.Marsh Fix incorrect assignment when deriving name for chunked pak file. Change 4080214 by Ben.Marsh Move the ThreadPoolWorkQueue class into DotNETUtilities so it can be used by other projects. Change 4082394 by Graeme.Thornton CIS fix for variable shadowing warning Change 4082583 by Ben.Marsh Add a IBinarySerializable interface for types that support reading from a BinaryReader and writing to a BinaryWriter. Implementing IBinarySerializable implies a constructor taking a BinaryReader argument is available for deserializing. Change 4082652 by Ben.Marsh Fix FileReference.Directory not returning a directory with a trailing backslash for files in the root directory. Change 4082755 by Graeme.Thornton Fixed an erroneous usage of TUniquePtr<uint8>as a pointer to a uint8 array when creating pak files. Caused a crash when compression was enabled, and has probably surfaced because pak generation is now done by an editor commandlet rather than a standalone program. Change 4082756 by Graeme.Thornton Fixed some incorrect documentation for pakfile compressed chunk headers Change 4082883 by Graeme.Thornton Static analysis warning fix Change 4082912 by Ben.Marsh Move ExceptionUtils into DotNETUtilities. Change 4085291 by Graeme.Thornton TBA: In the Json output formatter, write float and double values out with enough precision for successful roundtripping. Added some debug only code which will immediately reconvert the string back to its original value and compare the the input Change 4085523 by Graeme.Thornton TBA: Remove only explicit usage of DECLARE_FSTRUCTUREDARCHIVE_SERIALIZER. Should only be used from UHT generated code. Change 4086037 by Robert.Manuszewski Fix for a potential race condition when two threads want to acquire GC lock Change 4088655 by Graeme.Thornton Pak creation now uses the bEnablePakSigning setting from the crypto config json file Change 4091474 by Steve.Robb Fix for TStaticBitArray::FindFirstSetBit() and TStaticBitArray::FindFirstClearBit(). Unused variables removed. Change 4093632 by Steve.Robb CIS fixes. Change 4093656 by Graeme.Thornton Build fix Change 4093744 by Ben.Marsh Allow per-chunk settings for whether to enable compression in UnrealPak. Change 4099712 by Gil.Gribb UE4 - Fixed rare case where insufficient space was preallocated for cooldown ticks. #jira UE-59686 Change 4099912 by Stefan.Boberg Cooking timer optimizations: - Replaced data structures for FScopeTimer and FHierarchicalTimerInfo. Previous implementation used FString for many things and caused *lots* of heap and string concatenation activity. Replaced with a compile-time node id (using __COUNTER__) and raw string literals. - Removed PERPACKAGE_TIMER support (was disabled by default and was difficult to test) - Made it possible to toggle OUTPUT_TIMING and ENABLE_COOK_STATS independently - Removed some extremely tight timers because the overhead from calling QPC significantly exceeded the measured code This change shaved some 15% off a clean cook of Fortnite WindowsClient (en) with fully populated local DDC Change 4100519 by Stefan.Boberg Quick fix for Linux build issue introduced in 4099927 Change 4105327 by Stefan.Boberg Cooker: Changed FHierarchicalTimerInfo so it uses a linked list for tracking child nodes, to be able to deal with any child count. Previously we assumed there would never be more than 9 children but it turns out there are cooker modes that need more. Fixes check when using -FullLoadAndSave to cook Change 4105448 by Stefan.Boberg - Fixed Linux build warning re: member initialization order - Also eliminated OUTPUT_HIERARCHYTIMERS/CLEAR_HIEARCHYTIMERS macros (plain functions are fine) - Moved finishing-up code for FullLoadAndSave() to TickCookOnTheSide() call site to improve timer output. Previously some of the scopes would not have been closed before printing and thus the output was misleading. Change 4109031 by Ben.Marsh Attribute-driven Perforce wrapper (old Epic Friday project). Offers a more complete implementation than the current P4 wrapper in UAT without requiring any platform-specific libraries. Uses the Python binary output for parsing. Change 4109588 by Ben.Marsh UBT: Add extension methods for serializing a nullable type to a BinaryReader/BinaryWriter. Change 4109595 by Ben.Marsh Missing project file for DotNETUtilities. Change 4110724 by Stefan.Boberg Removed annotation map locking in UObjectMarks, eliminating around one minute (~3.5%) from Fortnite cook time. The locking was redundant since the annotation maps are managed per thread anyway. Change 4111304 by Ben.Marsh UAT: Add support for setting a status message through the log class. Allows writing transient messages (eg. progress messages) which will be cleared out before writing other messages. Best used through the LogStatusScope class, which can set a status message for the duration of a using() block. As part of this change, the console no longer has to be added as a dedicated trace listener. Since we already special-case this listener when formatting log output, it's easier to just keep the implementation separate to the other trace listeners. Change 4112708 by Steve.Robb Fix for TBitArray::MaxBits in assignment. Change 4114133 by Stefan.Boberg Tweaked how low-level memory (LLM) tracker is implemented to reduce overheads. Previously FMemory functions would acquire the LLM singleton and call OnLowLevelFree/OnLowLevelAlloc etc which would check the bIsDisabled flag and early out if it was set. Due to how frequently these functions were called this ended up costing quite a bit. - This change makes the flag a static member variable instead of a member variable and therefore enables a simpler early-out to be implemented. - The singleton getter is also simplified to avoid hitting the threadsafe singleton construction path on every call. - The enable flag is no longer TAtomic - this also incurs extra overhead for no clear benefit Shaves approximately 3.5% (one minute) off a Fortnite cook test scenario (using -FullLoadAndSave) Change 4115010 by Robert.Manuszewski Fixing CIS Change 4115249 by Robert.Manuszewski Fixing async loading code asserts when exiting game very early due to an error #jira UE-56267 Change 4117091 by Ben.Marsh Prevent doubled-up lines when writing status updates with console log verbosity. Change 4117207 by Ben.Marsh UGS: Do not include executables in diagnostics zip file, and ignore "no such files" error when cleaning workspace. Change 4119175 by Ben.Marsh UGS: Fix crash writing version files when directory does not already exist. Change 4119987 by Ben.Marsh UGS: Show a dialog box while the launcher is updating executables from Perforce, which allows cancelling the operation if necessary. Allow setting the username on the settings window, and prompt for login credentials if necessary. Should prevent situations where users have to update settings from the command prompt. Holding down shift during launch now shows the settings dialog rather than an immediate prompt to launch the unstable version (unstable version is shown as a checkbox on this dialog). Change 4119991 by Ben.Marsh Update version number for UGS launcher to 1.13. Change 4121943 by Robert.Manuszewski Don't use FArchiveAsync2 for reading packages with non-async path in editor builds as its performance is worse than the standard archive's (saves about 1 minute when doing larger cooks and 7 seconds when loading into PIE) Change 4122592 by Steve.Robb GitHub #4762 : Improve wording and grammar of Math comments Also includes improved accuracy in FMath::ComputeBoundingSphereForCone(). Change 4122819 by Stefan.Boberg Don't call CreateDirectory redundantly when opening files for writing using FFileManagerGeneric::CreateFileWriter This change avoids calling IPlatformFile::CreateDirectoryTree if possible since this is a very expensive function especially for deep hierarchies as it performs directory creation from the root directory onwards instead of from the leaf downwards. That function should also be fixed but this change improves performance in the meantime. Change 4122872 by Stefan.Boberg CreateDirectoryTree now creates directories leaf-to-root instead of the other way around. This is much more efficient since we don't spend time on system API calls for directories which already exist. This accounted for a very large amount of CPU time in cooking as the full target file directory hierarchy would be "created" for every single output file. Change 4123109 by Stefan.Boberg - Disable overlapped I/O in editor / cooker. Synchronous I/O reduces the number of syscalls and Windows performs prefetching on our behalf anyway for sequential reads - Eliminated syscall which was issued for every write to update cached file size -- since we're the only writers to the file (file access allows read sharing at most) we can authoritatively update the file size on write completion Change 4123455 by Ben.Marsh PR #4775: New build param PCHMemoryAllocationFactor to set /Zm VS build param. (Contributed by lucaswall) Change 4124207 by Ben.Marsh UBT: Remove some unnecessary indirection for generated code paths. Change 4124217 by Ben.Marsh UBT: Remove another unused variable from UEBuildModuleCPP. Change 4124377 by Stefan.Boberg In IPlatformFile::DeleteDirectoryRecursively, attempt to delete file first and if it fails clear the readonly flag and try again Previously there was a call to clear the readonly flag for every deleted file and this is a waste of resources 99% of the time. The SetFileAttributes call accounted for a significant amount of time during cooker sandbox directory deletion Change 4125071 by Stefan.Boberg Some tweaks to FQueuedThreadPoolBase scheduling and memory management - Explicitly pass in false for TArray::RemoveAt(..., bool bAllowShrinking) argument to prevent memory reallocation when arrays are drained and inevitably repopulated shortly afterwards - Use a MRU strategy instead of LRU when picking a thread to wake up. The MRU thread is the most likely to have a 'hot' cache for the stack etc. Picking from the back of the array also happens to be cheaper since no memory movement is necessary when RemoveAt is called. (This was the strategy in place before CL2600362 which seems to have changed it unintentionally) - Release lock as soon as a thread has been chosen, before asking the worker thread to wake up and do the work Change 4126132 by Ben.Marsh UAT: Detect when stdout is redirected and prevent using backspace characters to move the cursor. Change 4126867 by Graeme.Thornton TBA: Fix tagged binary formatter Change 4127010 by Robert.Manuszewski AnimScriptInstances created at runtime will now also be added to the owning omponent's cluster to avoid GC issues. Change 4127932 by Ben.Marsh WorkspaceTool: Reduce unnecessary logging of status messages when console output is not redirected. Change 4129050 by Ben.Marsh UGS: Check for NET Framework 4.5 being installed before running the installer. Also fix warning trying to kill existing UGS instances before upgrade. Change 4129459 by Graeme.Thornton TBA: TextAssetCommandlet - When outputting converted assets to an output path, replicate the workspace relative path in the output directory Change 4129515 by Graeme.Thornton TBA: Add EnterRecord overload that allows outputting of available field names when loading. Change 4129517 by Graeme.Thornton TBA: Tagged properties are written out as named fields on the "Properties" record, rather than as a stream with a null tag at the end Change 4129518 by Graeme.Thornton TBA: Added a local const bool to allow easy hacking out of text asset loading support Change 4129558 by Graeme.Thornton TBA: Build fix for textasset-less configs Change 4129614 by Ben.Marsh UGS: Main window is now restored to normal size when activated by clicking on the tray icon. #jira UE-60490 Change 4129618 by Ben.Marsh UGS: Speculative fix for unreproduced exception accessing disposed window while shutting down. Change 4131936 by Robert.Manuszewski Removing some WIP code accidentally checked in with CL #4121943 Change 4133490 by Ben.Marsh UGS: Allow the $(Change) variable to be used in more places than just the context menu. #jira UE-60573 Change 4133550 by Ben.Marsh UGS: Setting for whether or not to use incremental builds is now exposed through the variable "$(UseIncrementalBuilds)" for use by custom build steps. #jira UE-60554 Change 4133681 by Ben.Marsh UGS: A per-project list of folders and extensions to be deleted by default when running the 'clean workspace' tool can now be specified through the <ProjectDir>/Build/UnrealGameSync.ini file. Settings may be specified for an individual branch (via a category with the depot path to the project) or for wherever the project is currently open (via the [Default] category). The SafeToDeleteFolders list specifies a substring that will be checked against folder paths. Anything containing this folder will be marked as safe for delete by default. The SafeToDeleteExtensions list specifies a list of extensions for files that can always be deleted. Example: [Default] +SafeToDeleteFolders=/MyGame/Test/ +SafeToDeleteFolders=/DataService/ +SafeToDeleteExtensions=.xx1 +SafeToDeleteExtensions=.xx2 #jira UE-60575 Change 4135449 by Ben.Marsh Fix allowing use of Job objects on Windows platforms (debug code submitted by mistake) Change 4135730 by Ben.Marsh UBT: Plugins can now be enabled and disabled from the .target.cs file (for targets that do not use the shared compile environment), by compiling the list of enabled/disabled plugin names into the Projects module. Change 4135823 by Ben.Marsh UBT: Remove legacy code to handle disabling optional plugins; now that this is compiled into the target, it will work for any plugins we choose. Change 4135945 by Ben.Marsh UBT: Fix error running programs with no explicitly enabled or disabled plugins. Change 4137207 by Ben.Marsh UGS: Align all badges with the same name, to make it easier to see which CIS steps are being run. Allow overriding the slot taken by a particular badge by calling it "SlotName:LabelName". Change 4137311 by Stefan.Boberg Removed child cooker support. In practice it is not a useful feature as it provides no performance improvement (quite the opposite in fact) and adds testing and maintenance complexity. Change 4137393 by Ben.Marsh UGS: Fix display of multiline errors in the status panel. Change 4141708 by Steve.Robb GitHub #3631 : Incorrect default argument in WeakObjectPtrTemplate #jira UE-45490 Change 4146655 by Stefan.Boberg Removed FullGCAssetClasses logic - no longer necessary nor useful Change 4147318 by Ben.Marsh UGS: Compress build badges in a column if it shrinks below the size that they would be visible. Change 4148207 by Ben.Marsh UGS: Added support for showing the latest completed build from a specific list of badges in the status panel. To declare a badge as one that should appear in the status panel rather than the CIS column, add it to the project's UnrealGameSync.ini in the project or [Default] section like so: +ServiceBadges=RoboMerge Change 4148282 by Stefan.Boberg Fixed bug in UCookOnTheFlyServer::GetCookOnTheFlyUnsolicitedFiles - UnsolicitedFiles should be passed by reference not by value Change 4148344 by Stefan.Boberg Fixed minor indentation error (most likely caused by sloppy merge) Change 4148521 by Stefan.Boberg Removed accidentally checked in PRAGMA_DISABLE_OPTIMIZATION from CookOnTheFlyServer.cpp Change 4148639 by Ben.Marsh UGS: Fix tooltips not showing for changes that have description badges. Change 4149373 by Ben.Marsh UGS: Allow adding additional columns to display particular badges by adding entries from the project config file. Example syntax: +Columns=(Name="Desktop",MinWidth=50,DesiredWidth=100,Weight=3,Badges="Editor") +Columns=(Name="Mobile",MinWidth=50,DesiredWidth=100,Weight=3,Badges="IOS,Android") Same form can be used to control how default columns are displayed (though badge settings are ignored). Also allow PerforceMonitor to detect local changes to project config files and update settings automatically. Change 4149399 by Ben.Marsh UGS: Update version to 1.143. Change 4155660 by Steve.Robb PROJECTION and PROJECTION_MEMBER macros which provide the correct behavior when creating projections using functions which are overloaded or use default arguments. Change 4157117 by Ben.Marsh Fix warning due to plugins disabled in .target.cs file. Change 4158011 by Ben.Marsh UBT: Add a check that the UnrealHeaderTool target file exists, rather than throwing an exception when reading it fails. Change 4158646 by Ben.Marsh UGS: Fix exception when login is discovered to have expired during a workspace update. Change 4158678 by Ben.Marsh UGS: Fix an exception on shutdown due to the icon being hidden after it's already been disposed. Change 4158683 by Ben.Marsh UGS: Add an unhandled exception filter which sends the exception data to the backend. Change 4159131 by Ben.Marsh UGS: Reduce the number of characters displayed for build badges based on the available space. Change 4159194 by Graeme.Thornton TBA: Fix incorrect map property conversion code when converting an old property that contains a map with different key/value types Change 4159239 by Steve.Robb Improved readability and compliance with coding standards. Change 4159246 by Ben.Marsh UGS: Allow syncing projects where source code is not available (and various version files don't exist). #jira UE-60985 Change 4159286 by Ben.Marsh UGS: Remove requirement for UE4Editor.target.cs to be visible in the depot in order to open a project. #jira UE-60986 Change 4159302 by Ben.Marsh UGS: Update version to 1.144. Change 4160308 by Ben.Marsh All staging client executables for blueprint projects. #jira UE-60983 Change 4161567 by Steve.Robb GitHub #4816 : UE-60771: Handle escaped double quote in FParse::LineExtended Change 4162641 by Ben.Marsh UGS: Allow customizing the position of custom columns, via the Index=N attribute. Change 4162647 by Ben.Marsh UGS: Update version to 1.145. Change 4165319 by Robert.Manuszewski PR #4812: Fix inconsistent command-line argument handling under Windows (Contributed by adamrehn) Change 4166150 by Ben.Marsh UGS: Include *.inl when looking for code changes. Change 4166551 by Steve.Robb Whitespace fixes caused by a bad merge. Change 4168483 by Ben.Marsh UGS: Add a more useful error if a file to be synced exceeds the max allowed path length. Change 4168490 by Ben.Marsh UGS: Update version to 1.146. Change 4168551 by Ben.Marsh UBT: Move bBuildLargeAddressAwareBinary into an exposed setting. Change 4168560 by Ben.Marsh UBT: Remove static config variable for controlling which configuration of UHT to use. Change 4171296 by Ben.Marsh UGS: Move the check for overlong paths earlier. Change 4171531 by Ben.Marsh UBT: Fix exception if BuildConfiguration.xml contains an unknown category. Change 4183371 by Robert.Manuszewski Fix for a crash in Async Loading Graph's CheckCycles when GC kicks in on the game thread and forces ALT to exit early Change 4184312 by Ben.Marsh UGS: Update version to 1.148 Change 4184480 by Robert.Manuszewski Removing unused async loading stat Change 4186390 by Ben.Marsh UBT: Format XML validation errors in a format that allows double-clicking on the message in Visual Studio. Change 4188644 by Ben.Marsh UBT: Add the MakePathSafeToUseWithCommandLine() function to UBT. Change 4188647 by Ben.Marsh UBT: Fix exception in target receipt when architecture is null. Change 4189617 by Ben.Marsh Change FileSystemReference, FileReference and DirectoryReference objects to use OrdinalIgnoreCase comparisons without creating a separate copy of the string to compare. The filesystem does not use the invariant culture, and it can produce the wrong results in some cases (the ordinal comparison is faster, too). Change 4189740 by Ben.Marsh UAT: Remote code to build UnrealPak when packaging; we use the editor now. Change 4189860 by Ben.Marsh UGS: Make the filter for excluding automated lighting rebuilds more explicit. Change 4190082 by Ben.Marsh Fixes to allow enabling edit and continue for Windows builds. Have experienced quite a few VS crashes when testing it in editor; not yet recommended for general use. - Allow edit and continue for any configuration, not just debug. - Fixed PDB errors compiling files that use a shared PCH with edit and continue enabled. Path to the generated PDB file was using the wrong directory. - Removed code that tracks PDB output files, since they're modified multiple times during a build. - Enable debug information when compiling generated CPP files, since it causes errors if the shared PCH PDB doesn't have the same option. - Disable support for remote execution of steps that modify the PDB, since the same file has to be modified many times. Remote execution causes the PDB files to be corrupted. Unfortunately, this makes E&C builds significantly slower. #jira Change 4192949 by Ben.Marsh UBT: Minor tidy-up (merging UEBuildBinary.Build and UEBuildBinary.SetupOutputFiles) Change 4193218 by Ben.Marsh Fix formatting. Change 4197252 by Mike.Erwin UAT: Fix log output w/ correct count of non-code projects. #jira none Change 4197941 by Ben.Marsh UGS: Add support for DebugGame editors that have an executable with a DebugGame suffix. Change 4197964 by Ben.Marsh UGS: Prevent attempts to automatically reopen projects while a modal dialog is up, or the workspace is syncing. Change 4198144 by Ben.Marsh UGS: Prevent modal dialogs when login expires in P4, and prompt for password when hitting "retry". Change 4198413 by Ben.Marsh UGS: Always show the main window when launched manually, and run with -RestoreState when launched at startup. Also add a couple more places that save the visibility state, since logging off seems like it can terminate the process abrubtly. Change 4198779 by Ben.Marsh UBT: Allow generating manifests to any arbitrary locations with the -Manifest=<Path> argument. Change 4198825 by Ben.Marsh UBT: Move code to enumerate Slate runtime dependencies into the Slate module. Doesn't need to be done inside core UBT. Change 4199341 by Ben.Marsh UGS: Update version to 1.149 Change 4199642 by Chad.Garyet - Deprecate CISController - Add BuildController to replace CIS GET/POST for builds - Add LatestController, GET does what CIS/GET used to do - Change Latest/GET to return the last 25 builds filtered by project, rather than the last 5000 individual Ids - Latest/GET now returns "LatestData" object instead of array of longs - Updated EventMonitor to match all API changes - Fixed bug where IDs were getting reset to initial startup values every update loop Change 4199663 by Chad.Garyet CIS controller still needs to return an array of longs #jira none Change 4199680 by Ben.Marsh UGS: Update version to 1.150 Change 4200457 by Ben.Marsh Merging CIS fix for non-development configurations. Change 4200472 by Mike.Erwin UAT: fix -skipbuildclient param default It was defaulting to skipbuildeditor's value, likely a copy-paste error. #jira none Change 4202595 by Ben.Marsh Fix static analysis warning due to constant comparison against macro. Change 4203250 by Ben.Marsh UGS: Always show the "Sync Precompiled Editor" option, but disable it and show a tooltip explaining why if it is not available. Change 4206191 by Ben.Marsh Exclude editor target files from installed builds, since they leak info about DLLs that have been stripped out. Change 4213011 by Ben.Marsh UBT: Include contents of modified intermediate files in the log, to make it easier to debug hidden dependencies. Change 4213487 by Ben.Marsh UBT: Fix assumption that bPrecompile is equivalent to bBuildAllModules. This is no longer the case; they are now controlled by separate options. Should fix CIS errors building the editor. Change 4213609 by Ben.Marsh Ensure that strings formatted using FMicrosoftPlatformString::GetVarArgs() are always null terminated, whether we use the secure CRT or not. Change 4215971 by Ben.Marsh UBT: Remove action graph visualization code; no longer used. Change 4215996 by Ben.Marsh UBT: Remove unqiue id from all actions in the action graph. This is only used for printing debug info in the case of a (rare) cycle in the action graph, so just look it up when needed. Change 4216022 by Ben.Marsh UBT: Rename Crypto.cs to EncryptionAndSigning.cs to match the name of the class inside it, and move it under the System folder. Change 4216031 by Ben.Marsh UBT: Move all the action executors into their own folder in the project. Change 4216526 by Ben.Marsh Fix CIS warnings. Change 4216544 by Ben.Marsh Replace custom code to ensure FMicrosoftPlatformString::GetVarArgs() null terminates its buffer with Microsoft's standards-compliant implementation. Change 4216633 by Ben.Marsh Add support for UnrealPak plugins. * Project and plugin modules can now specify an array of supported programs in the "WhitelistPrograms" field of their module descriptors, to allow modules to be loaded by programs. * Programs can now load any runtime modules, as long as they are whitelisted. * Programs under the engine directory can now use a shared build environment, so that building with a project file does not cause output binaries to be output to the project directory. * UnrealPak is now always built by default when packaging * Convert UnrealPak to a modular configuration Change 4216736 by Ben.Marsh UnrealPak: Move "ExportDependencies" command into an editor commandlet, since it relies on the UObject system, asset registry, etc... Change 4217447 by Ben.Marsh Back out revision 50 from //UE4/Dev-Core/Engine/Build/InstalledEngineBuild.xml Change 4217451 by Ben.Marsh Back out revision 11 from //UE4/Dev-Core/Engine/Plugins/Developer/VisualStudioSourceCodeAccess/Source/VisualStudioSourceCodeAccess/VisualStudioSourceCodeAccess.Build.cs Change 4217617 by Ben.Marsh Back out changelist 4217451 Change 4222552 by Ben.Marsh Don't use #import <TypeLib> for VS source code accessor when building with Clang; it's not supported. Change 4222630 by Ben.Marsh UBT: Fix spam while generating project files if Clang isn't installed. Change 4223316 by Ben.Marsh UBT: Change the order in which Visual C++ toolchains are enumerated to prefer full releases over preview releases. Change 4223318 by Ben.Marsh UBT: Add a build setting which allows creating a dedicated PCH for every file that's excluded from the unity working set (disabled by default). Improves iteration times when working on individual cpp files, but slows down iterating on header changes (and can take a lot of disk space for large changes). Dedicated PCH contains all includes scraped from the top of each cpp file, until a non-#include directive is encountered. Change 4223401 by Ben.Marsh UBT: Add an option to automatically enable edit and continue for files in the adaptive non-unity working set. E&C doesn't seem very useful for UE4 projects right now; compile time is comparable to regular build times, but it can take several minutes to apply code changes for large projects. Change 4223899 by Ben.Marsh UBT: Fix loading XML config files on Mono; Type.GetField(Name) does not seem to return values unless binding flags are specified. Change 4224637 by Ben.Marsh Add a "SupportedPrograms" field to plugin descriptors, which allows plugins to declare which plugins they support independently of individual modules. Programs now respect the "bEnabledByDefault" setting in plugins. Plugins that are compatible with a program now need to list that program in the SupportedPrograms list, and whitelist any modules that should load for that program. Change 4224710 by Ben.Marsh UBT: Don't add import libraries as final build products unless the target is being precompiled. Prevents the need for building them for leaf nodes in the action graph. Change 4224715 by Ben.Marsh UBT: Remove hack to allow Stats2.cpp to not follow IWYU convention. Change 4224726 by Ben.Marsh Remove commented out line. Change 4224903 by Ben.Marsh Fix non-unity compile error in Stats2.h. Change 4225051 by Ben.Marsh Back out changelist 4224710; causing CIS errors due to receipts not matching. Change 4225134 by Ben.Marsh Fixing non-unity errors. Change 4225203 by Ben.Marsh Another non-unity fix. Change 4225249 by Ben.Marsh Fix Linux dependencies being copied for the Windows editor; they can be added as requirements for the Linux target platform on Windows instead, so it respects the user's chosen platforms. #jira UE-62001 Change 4225512 by Ben.Marsh BuildGraph: Allow setting the target to build when using the <CsCompile> task. Change 4228815 by Ben.Marsh UBT: Always add the generated code directory to the list of include paths when generating project files. It may only be created after UHT has been run. Change 4228944 by Ben.Marsh UBT: Remove legacy CppCompileEnvironment and LinkEnvironment wrappers from TargetRules that were deprecated in 4.19. Change 4229028 by Ben.Marsh UBT: Fix editor targets with unique build environment having the wrong executable path in generated project files. Move move logic to configure target rules post-construction by the rules assembly to ensure it's valid. Change 4229065 by Ben.Marsh UBT: Move another target setting into the rules assembly. Change 4229105 by Ben.Marsh Fix BPT exception when generating project files. Change 4229311 by Ben.Marsh UBT: Store the module rules file location on the ModuleRules instance, as well as the plugin that it was created from. Also expose the plugin directory as a property on the ModuleRules instance. Change 4229421 by Ben.Marsh UBT: Consolidate functionality for UHT module setup in ExternalExecution.cs. Change 4229817 by Ben.Marsh UBT: Modules must now explicitly specify the path to the header used to generate a PCH if one is desired, rather than the header being determined automatically by attempting to parse the source code. Now that PCHs are force-included anyway, this removes a lot of dependencies inside UBT. Change 4229824 by Ben.Marsh UBT: Remove unused lists inside UEBuildModuleCPP.SourceFilesClass. Change 4229841 by Ben.Marsh UBT: Remove some legacy code from auto-detecting PCHs. Change 4230521 by Ben.Marsh UBT: Add utility functions to the log class to allow formatting errors and warnings in Visual Studio output format (eg. File(Line): warning: Message) Change 4230871 by Ben.Marsh UAT: Remove StreamUtilis utility class; there is a simpler way to implement the one place it's used. Change 4230882 by Ben.Marsh UAT: Add StreamUtils back into UAT, seems like it's still used there. Change 4230896 by Ben.Marsh UBT: Remove some redundant parameters from UEBuildModule/UEBuildModuleCPP/UEBuildModuleExternal constructors. Change 4231014 by Ben.Marsh WorkspaceTool: Include a dump of raw bytes when garbage is read from the P4 process, for diagnostic purposes. Change 4231032 by Ben.Marsh Fix CIS. Change 4231096 by Ben.Marsh Bump the FlatCPPIncludeDependencyCache version, to prevent errors trying to load old files. Change 4231446 by Ben.Marsh UBT: Added support for expanding UE-specific variables in include paths and library paths: $(EngineDir), $(ProjectDir), $(PluginDir), $(ModuleDir). Change 4231460 by Ben.Marsh Modules may now explicitly specify rpaths on Linux via the PublicRuntimeLibraryPaths and PrivateRuntimeLibraryPaths properties. Change 4233909 by Robert.Manuszewski PR #4779: Reason fails as the supplied variable is incorrect (Contributed by projectgheist) Change 4233910 by Ben.Marsh Enable PCHs on IOS. Reduces build time by ~25%. Change 4234176 by Ben.Marsh UBT: Add better messaging for modules that need to have a private PCH set. Now detects the likely PCH using the same method as legacy code and includes it as a suggestion. Change 4234193 by Ben.Marsh Add the Delete command to Perforce wrapper in DotNETUtilities. Change 4234688 by Ben.Marsh UBT: Simplify handling of installed/precompiled builds. Settings for whether a folder is installed/read-only or not is now stored on the RulesAssembly instance, allowing multiple things to be configured separately and stacked together (eg. engine/enterprise/project). RulesAssembly.IsReadOnly() allows determining if a flie can be modified or not and replaces many previous IsXXXInstalledCalls(), and traverses the chain of assemblies. Change 4234711 by Ben.Marsh UBT: Runtime dependencies can now be copied to output directories as part of the build. When adding a runtime dependency, an optional source location can be specified to copy from. Both the source and target paths can use variables can be used as part of the path, eg. $(OutputDir), $(ModuleDir), $(PluginDir). Example usage (from a .build.cs file): RuntimeDependencies.Add("$(OutputDir)/Foo.dll", "$(PluginDir)/Source/ThirdParty/Foo.dll", StagedFileType.NonUFS); Change 4234872 by Ben.Marsh Expose a flag for whether the engine is installed, to fix issues generating project files. Change 4234929 by Ben.Marsh Fix null reference generating receipts when UBT makefiles are active. Change 4235883 by Chad.Garyet Merging 4231245 to core Giving Coordinator its own sln. This should fix what 4158155 was supposed to. #jira UE-61955 Change 4236075 by Ben.Marsh CIS fix Change 4237066 by Robert.Manuszewski Fix for a potential crash when terminating the engine while it's being initialized #jira UE-60545 Change 4237078 by Robert.Manuszewski The engine will no longer be resetting all linkers causing massive load times when renaming the world package when entering Play In Editor Change 4237116 by Ben.Marsh Rewrite some Windows utility functions to support paths longer than MAX_PATH. Change 4237158 by Ben.Marsh Add const TCHAR* overloads of FString::RemoveFromStart() and FString::RemoveFromEnd(). Change 4237159 by Ben.Marsh Fix FWindowsPlatformFile::GetFilenameOnDisk() support for paths longer than MAX_PATH, and simplify some of the other long path functions to avoid copying string buffers. Change 4239050 by Ben.Marsh Missing file Change 4239318 by Ben.Marsh Linux CIS fix. Change 4239685 by Ben.Marsh Static analysis CIS fix. Change 4240800 by Ben.Marsh WorkspaceTool: Include the full command line in the log for any P4 commands. Change 4240903 by Ben.Marsh PR #4909: Update copyright notices to 2018 (Contributed by projectgheist) Change 4241025 by Ben.Marsh UBT: Exclude mobile pipeline caches from generated project files. Causes huge slowdown when using 'Find in Files' through the IDE. Change 4241770 by Ben.Marsh UBT: Include action number in parallel executor output. #jira UE-62032 Change 4243469 by Ben.Marsh TBA: Merge FAnnotatedStructuredArchiveFormatter with FStructuredArchiveFormatter. Any functions that are only implemented for text archives now have a _TextOnly suffix, and are exposed through the FStructuredArchive interface. Change 4245723 by Robert.Manuszewski Fixing another creash when terminating the engine while initializing. #jira UE-60545 Change 4245862 by Steve.Robb VectorLoadFloat2(Ptr) added, which loads { Ptr[0], Ptr[1], Ptr[0], Ptr[1] } into a VectorRegister. Change 4246412 by Robert.Manuszewski The warning 'Calling StaticLoadObject during PostLoad may result in hitches during streaming' will now also report the object which had the PostLoad called on it when StaticLoadObject call happened. Change 4246612 by Ben.Marsh UBT: Fix spelling of "Intellisense". Change 4249454 by Robert.Manuszewski Added extra checks to catch scenarios where the EDL Precache Buffer is flushed before a package header is fully read Change 4249513 by Robert.Manuszewski Made sure the Async Loading Thread doesn't continue running after creating new async packages when garbage collector wants to run on the game thread Change 4255207 by Ben.Marsh UGS: Add additional logging whenever a P4 command fails, and when the user is logged out. Change 4255288 by Ben.Marsh PR #4921: Honor ModuleRules' bEnableExceptions flag when creating precompiled h. (Contributed by surakin) Change 4256422 by Ben.Marsh UBT: Add an error if a module referenced by a plugin descriptor doesn't exist. Change 4257385 by Robert.Manuszewski Creating new objects from within ForEachObjectWithOuter will now result in a fatal error as it's unsafe to change internal UObject hash tables when iterating over them. Change 4257454 by Robert.Manuszewski Added the option to filter clusters listed with gc.ListClusters by objects within them. Usage: gc.ListClusters Hierachy With=ObjectName1,ObjectName2... Change 4257526 by Robert.Manuszewski It's now possible to filter clusters that get logged with verbose cluster logging enabled (UE_GCCLUSTER_VERBOSE_LOGGING=1) by objects within them by specifying -DumpClustersWithObjects=ObjectName1,ObjectName2 in the command line Change 4257822 by Ben.Marsh Fixes for PlatformShowcase compile errors. Change 4258771 by Ben.Marsh UBT: Fix project files not being generated for foreign projects when creating .stub files. #jira UE-62462 Change 4258790 by Ben.Marsh UBT: Clean up the logic around generating project files before creating a stub IPA, so that it fails loudly if project files do not exist, and can accept target names not matching project names. Change 4259276 by Ben.Marsh UBT: Make it an error if a framework doesn't exist, rather than failing silently. Also remove some remote toolchain stuff that's no longer necessary. Change 4259280 by Ben.Marsh UBT: Fix embedded framework zips not being uploaded for plugins. #jira UE-62485 Change 4260236 by Ben.Marsh UBT: Fix path to generated engine project file. Change 4260334 by Ben.Marsh UGS: Fix custom build steps dialog inadvertantly modifying config file settings in-place. Change 4260361 by Ben.Marsh UGS: Allow for p4 login commands to fail, even though the user is logged in (due to a bad connection, etc...) Change 4260559 by Ben.Marsh UGS: Update version. Change 4261160 by Robert.Manuszewski MediaPlaylist will now be added to root set if the owning MediaPlayer is in the disregard for GC set (fixes GC assumption violation crash) #jira UE-62495 Change 4261421 by Ben.Marsh Force-sync files for building documentation, to fix issues with files not being updated. #jira UE-62413 Change 4261425 by Ben.Marsh UBT: Remove some leftover functions for handling the remote toolchain. Change 4261530 by Ben.Marsh UBT: Speculative fix (and better error reporting) for IOS mobile provision not being found in CIS. Change 4261611 by Ben.Marsh UBT: Downgrade warning to a log message, since it appears when generating project files. Change 4261710 by Ben.Marsh Remove assert that GLogConsole is set; it won't be for command line utilities that don't depend on ApplicationCore. #jira UE-62545 Change 4261831 by Ben.Marsh Fix compile errors due to missing include path when hot-reloading a module from the editor. There are not necessarily source files to compile when -modulewithsuffix is specified on the command line, which was results in GeneratedCodeWildcard not being set. #jira UE-62463, UE-62384 Change 4262723 by Ben.Marsh Whitelist plugins that need to be loaded by UFE. #jira UE-62564 Change 4265444 by Ben.Marsh Fix incorrect executable name for DebugGame configurations in Xcode. #jira UE-62574 Change 4265892 by Ben.Marsh Fix incremental compile failures due to dependency checking for unity files. CachedIncludePaths was not correctly being set on file items, so dependencies were being ignored. #jira UE-62575, UE-62603, UE-62597 Change 4266019 by Josh.Adams - Fixed the CopyAction for runtime dependencies that need to be copied to different location, on non-XGE Change 4266264 by Ben.Marsh Remove override for the __IPHONE_OS_VERSION_MIN_REQUIRED macro on TVOS. This macro is already defined by system headers (in <AvailabilityInternal.h>). Now that we support PCHs on IOS and TVOS, manually defining this macro results in it being defined three times (once for the PCH, once by AvailabilityInternal.h, and once by the force-included list of definitions for the source file being built). The errors for redefining the macro in AvailabilityInternal.h are suppressed due to it being a system header, but the error for redefining it for the source file being compiled are not. #jira UE-62578 Change 4266273 by Ben.Marsh Fixes incremental build failure when compile arguments for PCH have changed on IOS/TVOS. Compile action needs to have a dependency on PCH build action. Change 4266614 by Graeme.Thornton Fix crash when cooking nativized blueprints due to removal of child cooker system. Change 4266763 by Ben.Marsh Always build UnrealPak when building client targets. The ProjectParams.Pak option is not reliable, because it can be forced on later by the target platform. #jira UE-62584 Change 4267985 by Robert.Manuszewski When iterating with ForEachObjectWithouter, don't lock the entire has table but only the hash bucket that is currently being iterated #jira UE-62600 Change 4268558 by Robert.Manuszewski PurgeLegacyBlueprints will no longer be called from within ForEachObjectWithOuter is it renames objects that reside in hash tables that are being iterated over which may lead to undefined behavior. #jira UE-62600 Change 4269011 by Chad.Garyet - Fixing Wildcard match issue, the change to ugsapi sends projects as //Depot/Stream instead of //Depot/Stream/ Wildcard match was only substringing to 3 chars. - Checking in the change a while back that increases the number of queried jobs up to 432 based on some maths from Bob about how many builds we want to grab Published to ugsapi server 8/8/17 #jira none Change 4270788 by Ben.Marsh Fix IOS provisioning data being using when remote compiling on TVOS. #jira UE-62705 Change 4271916 by Ben.Marsh Tag the XGEControlWorker executable as a build product after compiling SCW, to make sure it's included in the UGS zip file. Change 4271934 by Ben.Marsh Upload all static libraries in plugin folders as part of remote builds. #jira UE-62694 Change 4273368 by Ben.Marsh Fix Slate dependencies not being enumerated, and rules assembly not being rebuilt when building remotely. #jira UE-62705 Change 4274049 by Ben.Marsh Always parse the team UUID out of the mobile provision when doing a remote compile. The provision installed on the remote Mac (and selected for signing) may be different. #jira UE-62751 Change 4274823 by Ben.Marsh Add the -VersionCookedContent argument to disable the -unversioned parameter on the cooker command line. Change 4275838 by Ben.Marsh Fix BuildVersion string not being passed through from <SetVersion> task. Also add a -BuildVersion command line argument to UBT to override it for a particular build. Change 4275913 by Ben.Marsh Add a dummy exported symbol to the XGEController module, to fix build errors due to missing .lib file when it's built with WITH_XGE_CONTROLLER = 0. Change 4284161 by Ben.Marsh Allow mirroring Oodle files to remote Mac. Change 4074774 by Steve.Robb Vast simplification of TFunction, making it smaller in footprint, easier to follow and extend, and more correct. TUniqueFunction added, which is a move-only TFunction which can hold move-only functors. Fix for UWidgetBlueprint::ForEachSourceWidget() which should never have compiled but did. FFunctionGraphTask and TFuture<> updated to use TUniqueFunction to make them more general. TArray::HeapPop() made to work with move-only types. Change 4082591 by Ben.Marsh Move the Log class from UBT to DotNetUtilities. Change 4083236 by Ben.Marsh Add a Log.WriteException() method to dump an exception message to the console (and write the exception trace to the log) Change 4084107 by Ben.Marsh UAT: Remove the unused -SkipHeader argument to UE4Build. Change 4089771 by Steve.Robb GitHub #4743 : modified VirtualAlloc function flag https://blogs.msdn.microsoft.com/oldnewthing/20151008-00/?p=91411 Change 4091456 by Steve.Robb Unification of all platforms' FMath::CountTrailingZeros() and FMath::CountLeadingZeros() for both 32-bit and 64-bit. Change 4156437 by Ben.Marsh Lots and lots of fixes compiling for Clang on Windows. Editor now compiles cleanly without warnings, but crashes on startup due to error in intrinsics test. Disabling that runs further, but crashes accessing freed memory. Switching to the ANSI allocator runs further, but crashes in Slate after the splash screen and before the editor window opens. // TODO! * Switching between Clang/ICL/VS2015/VS2017 is now supported through the same mechanism as switching Visual Studio versions, without requiring any source level changes. To use Clang, set WindowsPlatform.Compiler = WindowsCompiler.Clang from a .target.cs file, or set <WindowsPlatform><Compiler>Clang</Compiler></WindowsPlatform> from BuildConfiguration.xml. To pick a specific toolchain version, set WindowsPlatform.CompilerVersion. * Clang is now supported through AutoSDKs; will be added to CIS. * The Samples/Sandbox/Clang project forces Clang to be used from its target.cs file, and allows easily building all editor modules and plugins with Clang on Windows. * UnrealMathSSE intrinsics have been re-enabled for Clang due to missing functions from the UnrealMathFPU implementation, but causes failure in tests at startup. * SSE4_CRC32() is disabled in D3D12Pipelinestate.cpp, since intrinsics are only allowed if enabled for the whole target (rather than being used in specific functions due to runtime checks) Change 4157389 by Ben.Marsh Few more fixes for compiling the editor with Clang. Change 4183911 by Ben.Marsh Fixes to support incremental linking on Windows. Does not seem to have any net benefit right now; may improve once minimal rebuild is enabled. * Incremental linking no longer forces PDB files to be enabled for source files. * Actions can specify specific files to be deleted before each build. Code to forcibly delete PDB files has been moved to the MSVC toolchain. * Unused libraries produced by the cross-referenced link are no longer added as build products, since (a) deleting them breaks dependency checking for incremental linking and causes a full link, and (b) not deleting them breaks UBT dependency checking and causes actions to be run over and over again. * Icon update is disabled for Windows when incremental linking is enabled. * Removed rarely-used setting to always delete produced items before each build. Change 4184311 by Ben.Marsh UGS: Added a dialog which shows all the required platform SDKs for a branch, linked from the status panel in UGS. The llist is configured via the UGS config file submitted to Engine/Programs/UnrealGameSync/UnrealGameSync.ini (and may be overridden by the project config file if necessary): [Default] ; Set this to a network share which contains the SDK installers for your site SdkInstallerDir= ; All the required SDKs for the current version of the engine +SdkInfo=(Category="Android", Description="NDK r21", Browse="$(SdkInstallerDir)\\Android") +SdkInfo=(Category="Windows", Description="Visual Studio 2017") +SdkInfo=(Category="Windows", Description="Visual C++ Toolchain 14.13.26128") +SdkInfo=(Category="Windows", Description="Windows SDK 10.0.16299.0") Similar entries for console platforms are added in console subdirectories. Each entry may contain an Install="Foo.exe" and/or Browse="C:\Foo" style attribute, specifying the path to an installer to run or directory to open in explorer respectively. The SdkInstallerDir setting is used as a base directory for the default installers, seen above for Android. Licensees may override this with a network path specific to the site that UGS is being deployed to (either in this file, in a project specific config file, or in a Engine/Programs/UnrealGameSync/NotForLicensees/UnrealGameSync.ini file). Change 4200452 by Ben.Marsh UBT: Change DebugGame configurations to output a separate executable rather than requiring a -Debug argument at runtime. Previous behavior was a common source of errors. Engine modules are still shared between Development and DebugGame, but the launch module sets a flag in Core on startup indicating the game configuration. Change 4206189 by Ben.Marsh UBT: Simplify logic for precompiling binaries. * Target no longer has separate list of "precompile only" binaries or modules. New -AllModules option allows adding every module to a target, which can be used with -Precompile and -NoLink to precompile object files for monolithic builds. * Precompiled file lists have been removed from target receipts. * The manifest now includes all generated headers and precompiled files when run with the -Precompile option. * Separate -DependencyList=Foo.txt has been added to write a list of all dependencies required to use precompiled binaries. This file list can be read using the <Tag> task in buildgraph. Change 4215466 by Ben.Marsh UBT: Remove indirect calls to determine extensions for object files and precompiled headers. The toolchain knows the correct convention for the platform. Change 4215975 by Ben.Marsh UBT: Remove telemetry code. This has never proved useful for analyzing performance due to the number of incidental factors that affect build times (eg. number of files being compiled). Change 4220154 by Ben.Marsh Move text-only implementations of FOutputDeviceError back into Core, so we can build command-line applications that don't depend on ApplicationCore. Change 4224708 by Ben.Marsh Add a bCompileAgainstApplicationCore setting to the target rules, which allows compiling out references to the ApplicationCore module (which should only be necessary for applications with a GUI). Removed ApplicationCore from several engine tools and utilities. Change 4224958 by Ben.Marsh Remove CoreMinimal.h includes from Core. Change 4229059 by Ben.Marsh UBT: Remove the UEBuildPlatform.ShouldNotBuildEditor() hook for target platforms. We shouldn't be modifying a target's build environment to disable the editor; it is invalid to build the editor for these target platforms at all, and this is already enforced by the GetSupportedPlatforms() function. Change 4230508 by Ben.Marsh Fixup precompiled header setting for samples and games. Change 4231457 by Ben.Marsh Fix exceptions in log messages having trailing newlines. Change 4232406 by Ben.Marsh UBT: Always force include a PCH for generated code if there's one set; the code may depend on it to compile. Change 4234177 by Ben.Marsh Set up private PCH files everywhere that previously used them. Change 4235973 by Ben.Marsh Change FPlatformMisc::GetEnvironmentVariable() to return an FString() rather than requiring a fixed size buffer to be passed in. Removes references to MAX_PATH. Change 4238842 by Ben.Marsh Add support for paths longer than MAX_PATH in the editor. Requires Windows 10 version 1607, and the functionality to be enabled via a registry key or group policy (see https://docs.microsoft.com/en-us/windows/desktop/FileIO/naming-a-file). Only a subset of Win32 functions support long paths (executables can only be started from paths shorter than MAX_PATH, for example). * Added a FPlatformMisc::GetMaxPathLength() function to return the maximum length of a path on the current system. On Windows, this returns a different value for systems with long paths enabled to those without. * The MAX_PATH define is no longer set by non-Windows platforms. Instead, there is a MAC_MAX_PATH, UNIX_MAX_PATH, etc... for any platform-specific code that still relies on the previous macro. * The MAX_UNREAL_FILENAME_LENGTH macro has been renamed to MAX_UNREAL_FILENAME_LENGTH_DEPRECATED * The PLATFORM_MAX_FILEPATH_LENGTH macro has been renamed to PLATFORM_MAX_FILEPATH_LENGTH_DEPRECATED. * Removed custom resource files for programs, since they are just copies of the base UE4 one (which is used by default anyway). The base UE4 manifest declares support for long paths. * Fix 512 character maximum length on editor commands. 260 character limit remains in place for cooking at the moment (see ContentBrowserUtils.h), until C# staging code supports long paths. Change 4255042 by Ben.Marsh UBT: Remote compilation now uploads the entire workspace to the remote Mac and executes a separate remote instance of UBT rather than synchronizing individual actions. This makes the remote compile codepath much simpler, and removes a lot of special cases that exist to support it previously. The list of files to be transferred to the remote are listed as rsync filter rules in Engine/Build/Rsync/RsyncEngine.txt and RsyncProject.txt, which are applied to the root engine directory and project directory respectively. Projects that need to customize which files are uploaded can add their own <ProjectDir>/Build/Rsync/RsyncProject.txt file, which will be included in the filter before the default version. Change 4260567 by Ben.Marsh UAT: Rename CommandUtils.Log to CommandUtils.LogInformation, to avoid conflicts with the underlying Tools.DotNETCommon.Log class. #rb none [CL 4285673 by Ben Marsh in Main branch]
2018-08-14 18:32:34 -04:00
LogInformation("Waiting for logging process to start...");
Thread.Sleep(2000);
}
Thread.Sleep(1000);
string AllServerOutput = "";
using (FileStream ProcessLog = File.Open(ServerLogFile, FileMode.Open, FileAccess.Read, FileShare.ReadWrite))
{
StreamReader LogReader = new StreamReader(ProcessLog);
bool bKeepReading = true;
FileStream ClientProcessLog = null;
StreamReader ClientLogReader = null;
// Read until the process has exited.
while (!ServerProcess.HasExited && bKeepReading)
{
while (!LogReader.EndOfStream && bKeepReading && ClientProcess == null)
{
string Output = LogReader.ReadToEnd();
if (!String.IsNullOrEmpty(Output))
{
AllServerOutput += Output;
if (ClientProcess == null &&
(AllServerOutput.Contains("Game Engine Initialized") || AllServerOutput.Contains("Unreal Network File Server is ready")))
{
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 4285612) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3836829 by Ben.Marsh UBT: Fix ability to precompile plugins from installed engine builds. Change 3839519 by Ben.Marsh UBT: Simplify configuring bPrecompile and bUsePrecompile settings for modules. Each rules assembly can now be configured as installed, which defaults the module rules it creates to use precompiled data. Change 4042043 by Steve.Robb GitHub #4705 : Added weak lambda's for delegates and multicast delegates. Change 4042056 by Robert.Manuszewski Optimized Mark Phase of GC by up to 10ms by making it run in parallel and removing a huge array presize which we didn't need. Change 4042104 by Robert.Manuszewski Set the minimum GC cluster size to 5 so that GC doesn't have to process micro clusters which are more expensive than processing individual objects + Exposed the minimum cluster size to ini and project settings as gc.MinGCClusterSize + Added the ability to sort clusters by name/object count/mutable object count/referenced clusters count when dumping them with gc.ListClusters command Change 4042377 by Robert.Manuszewski Reworked how GC and other threads (ALT specifically) interact - GC will now notify the ALT it wants to run and ALT will immediately try to finish its current work to allow that. Also the entire ALT tick is now protected against GC running at the same time to improve ALT stability. + added gc.ForceCollectGarbageEveryFrame console variable that triggers a forced GC every frame Change 4042427 by Robert.Manuszewski Changed FGCCSyncObject to use events when waiting for GC to finish so that it doesn't spin on non-game threads when GC is running Change 4042482 by Robert.Manuszewski Unhashing unreachable objects (ConditionalBeginDestroy) will now also be done incrementally, just like the purge phase of Garbage Collection Change 4042635 by Robert.Manuszewski Fix for a potential assert when incremental purge garbage is pending and something forces a full purge Change 4044092 by Steve.Robb Fix for forward declared CoreUObject weakobject types in delegates when building in Clang. Change 4044102 by Robert.Manuszewski Fix for a possible hang when worker threads are preventing GC from running and something is later trying to FlushAsyncLoading with the Async Loading Thread enabled Change 4044113 by Steve.Robb Another Clang fix. Change 4044160 by Robert.Manuszewski Disregard For GC pool will now be enabled by default in cooked builds Change 4044287 by Steve.Robb Typo fix. Change 4047723 by Graeme.Thornton TBA: Fixes for import/export name cache and object resolving Change 4048015 by Graeme.Thornton TBA: Weak/Soft/Lazy pointer serialization changes * Remove FWeakObjectPtr::Serialize, move it's logic into, and replace usages of with calls to, FArchiveUObject::SerializeWeakObjectPtr(). Ensures that something is always sent to the archive so that structured archives can be kept happy in the future. * Added Weak/Soft/Lazy pointer handling to the structured archive slot interface and all the formatters. Binary formatters just forward the call onto their inner and text archives store as a string path reference. * FArchiveUObjectFromStructuredArchive caches all these pointer types and stores indices in the binary block, same as with a UObject*. All pointers are then forwarded to the underlying formatter in one go on finalization. Change 4048021 by Steve.Robb Fix for binding an unbound TFunction to another TFunction with a different signature. Also all null pointers now count as unbindings, not just nullptr. TIsMemberPointer added. TIsATFunction and TIsATFunctionRef renamed to remove the 'A's. Change 4048544 by Robert.Manuszewski Fixing ConditionalBeginDestroy profiling after changes to incremental CBD. Change 4051028 by Graeme.Thornton TBA: ArchiveFromStructuredArchive adapter uses Inner to determine if it is outputting to text, and sets it's own ArIsTextFormat to false Change 4051056 by Graeme.Thornton TBA: High level tagged property / UObject base class text serialization - UObject serialize converted to structured archive - Properties written to text individually with text tags, and then binary adapted values - Only saves, doesn't load Change 4051111 by Graeme.Thornton TBA: Temporarily disable loading of text assets until tagged property serialization path is fixed up Change 4051154 by Graeme.Thornton TBA: Convert a few uobject serializers to structured archive format for example purposes Change 4051181 by Graeme.Thornton TBA: Added default structured archive implementation of SerializeItem to UProperty, which just calls the FArchive version on an FArchiveUObjectFromStructuredArchive adapter. Implemented structured archive SerializeItem for UArrayProperty Change 4051197 by Graeme.Thornton TBA: ObjectProperty text serialization Change 4051216 by Graeme.Thornton Restored a modified FWeakObjectPtr::Serialize function to keep backwards compatibility in code I don't have access to. Change 4051261 by Graeme.Thornton TBA: Convert UMetaData to structured archive Change 4051374 by Steve.Robb Incorrect assert removed. Change 4051562 by Robert.Manuszewski Adding stats for the new GC internal functions Change 4051614 by Graeme.Thornton TBA: Removed UProperty::SerializeItem(FArchive, ...) and replaced with UProperty::SerializeItem(FStructuredArchive::FSlot, ...). Fixed up most of them to work properly and added adapters in for any that were non-trivial. Change 4052512 by Graeme.Thornton TBA: Temporary workaround for softobjectptr and lazyobjectptr uproperties not serialization anything when they know the archive is a reference collector. They should always be serializing their pointers and letting the underlying archive itself ignore them. Change 4053917 by Robert.Manuszewski Clustered objects from clusters that are no longer reachable will now be marked as unreachable immediately when gathering unreachable objects Change 4053919 by Robert.Manuszewski Added the ability to disable incremental BeginDestroy in ini/project settings Change 4055518 by Daniel.Lamb Fixup for deterministic audio generation issue. Submitted on behalf of Rich.Whitehouse #jira nojira #test prefilght automated test. Change 4056854 by Graeme.Thornton TBA: Added a test asset to EngineTest which contains all the different property types and test cases. Change 4056858 by Graeme.Thornton TBA: Updated USetProperty to proper structured archive usage Change 4056872 by Graeme.Thornton TBA: Add map property field to test object Change 4056873 by Graeme.Thornton TBA: Convert UMapProperty to full structured archive Change 4056994 by Graeme.Thornton TBA: Converted FText over to structured archive. Implemented saving, but not loading. Change 4059728 by Ben.Marsh UBT: Add support for using adaptive non-unity builds when the engine and project are in separate repositories. Change 4059805 by Graeme.Thornton Fixed typo in text serialization. Fixes CIS automation test errors Change 4060007 by Graeme.Thornton TBA: FArchiveFromStructuredArchive will now access it's host slot lazily, i.e. only when a value is actually written to the archive. Change 4060092 by Stefan.Boberg Added optimized Windows console window output path to GenericConsoleOutput since this slowed down cooking considerably (2 minutes spent in wprintf alone for one large dataset) When stdout is attached to a console we use the WriteConsoleW function instead of wprintf since the latter is very slow especially in unbuffered mode which the engine currently configures for stdout (see setvbuf call in LaunchEngineLoop.cpp). At some point we should reconsider this buffering policy since it's likely to slow down other platforms as well but I wanted to do a safe change for now as I don't yet fully understand why the setvbuf call is there in the first place. Change 4060108 by Stefan.Boberg Introduced some additional target platform utilities to help with asset cook optimizations * We now assign each ITargetPlatform a zero-based ordinal value * Introduced FTargetPlatform and FTargetPlatformSet types to help store platform references and platform sets efficiently. These are not currently used in the engine but are designed to replace the existing ITargetPlatform/string/FName representations in the cooking data structures. Change 4060143 by Graeme.Thornton Undo //UE4/Dev-Core/Engine/Source/Runtime/... changelist 4060007 Needs some other changes that I haven't checked in yet... Change 4062432 by Ben.Marsh Fix error message when enumerating P4 changes. Change 4062648 by Ben.Marsh Add missing p4 integration action. Change 4063620 by Graeme.Thornton Integrated a fix from UDN where the engine would crash when trying to load a very small encrypted file (<16bytes) from a pak file, where the read address wasn't already aligned to the AES block size. (https://udn.unrealengine.com/questions/431989/crash-while-reading-a-very-small-file-in-encrypted.html) Change 4066963 by Robert.Manuszewski Fixing GC cluster verification code reporting false positives when a cluster is referencing another cluster through 'mutable' objects list. Change 4067133 by Robert.Manuszewski Changed log verbosity when reporting individual cases of GC cluster assumption violations as they are followed by an asser anyway and this way we get the chance to see all issues before we assert at the end of these checks. Change 4067443 by Steve.Robb FString can now be constructed from any char pointer type and length. Change 4068156 by Steve.Robb Fix necessary because of FString constructor change in CL# 4067443. Change 4070258 by Graeme.Thornton Fixes for VSCode Change 4070372 by Graeme.Thornton TBA: Script struct serialization to structured archives Change 4071913 by Ben.Marsh Move bulk of the code for UnrealPak into an engine developer module, so it can be used in the editor. Change 4071914 by Ben.Marsh Missing files. Change 4071937 by Ben.Marsh Missing header. Change 4072015 by Ben.Marsh Fixes for compiling PakFileUtilities as part of the editor. Change 4072826 by Steve.Robb TBitArray::Reserve() added. TBitArray::Add() overloaded to allow adding multiple bits. TSparseArray::Reserve() optimized to call the overloaded Add(). Change 4073271 by Daniel.Lamb Fixed add patch tier in project launcher passing the wrong commandline option to UAT. #test none Change 4074708 by James.Hopkin #core Removed redundant Casts Change 4074763 by Steve.Robb Fix for TSparseArray::Reserve() size. Change 4076063 by Ben.Marsh Add an "UnrealPak" commandlet with the same functionality as the standalone UnrealPak program. Invoke by running the editor with -run=UnrealPak and the standard UnrealPak commandline options. Change 4077064 by Robert.Manuszewski Fixing compile error in PakFileUtilities Change 4077144 by Graeme.Thornton TBA: TextAssetCommandlet improvements * Collect lists of broken assets during roundtrip tests and print a summary of packages that failed each phase at the end * After resaving as text, load the file back as a plain JSON hierarchy to ensure the output was valid Change 4077412 by Ben.Marsh Set the correct exit code for UnrealPak. Should return 0 on success, not 1. Change 4077760 by Graeme.Thornton TBA: Loading fixed for tagged property serialization Includes conversion of all UProperty::ConvertFromType() and SerializeFromMismatchedTag() functions to use structured archives Lazy initialization of FArchiveFromStructruredArchive when loading, to support the possibility of an adapter being create around an object property serialize call to its inner UStruct, which then decides not to do anything and return false. Stops the ArchiveFromStructuredArchive from consuming the slot and getting upset later on when we try to serialize normal tagged properties from it. Disabled lazy bulk data loading from text assets. Requires a bigger change to make it work. Added some debug checks to json input formatter which track the current value stack size when a new object is pushed onto the stack, and makes sure that the stack has returned to the same size when the object is popped. Catches cases where we unpack an array/stream to the value stack but then don't consume all the items. Change 4078800 by Ben.Marsh Change UAT to using the editor's UnrealPak commandlet rather than invoking the standalone UnrealPak executable. To improve performance when building several PAK files, also add a new -batch=<file> command which reads commands to execute in parallel from a text file. Change 4079745 by Graeme.Thornton TBA: Migrated a couple of UObject Serialize functions to FStructuredArchive (SoundCue / MaterialExpressions / Editor strip flags) Change 4079847 by Graeme.Thornton TBA: Add 'FindMismatchedSerializers' mode to text asset commandlet, which dumps out a list of all UClasses which don't have the CLASS_MatchedSerializers flag, meaning we can't guarantee the have Serialize functions for FArchive AND FStructuredArchive, therefore we can't use the new structured archive based serialize path. Should only ever be native instrinsic classes as UHT takes care of all other cases. Change 4079925 by Ben.Marsh Fix incorrect assignment when deriving name for chunked pak file. Change 4080214 by Ben.Marsh Move the ThreadPoolWorkQueue class into DotNETUtilities so it can be used by other projects. Change 4082394 by Graeme.Thornton CIS fix for variable shadowing warning Change 4082583 by Ben.Marsh Add a IBinarySerializable interface for types that support reading from a BinaryReader and writing to a BinaryWriter. Implementing IBinarySerializable implies a constructor taking a BinaryReader argument is available for deserializing. Change 4082652 by Ben.Marsh Fix FileReference.Directory not returning a directory with a trailing backslash for files in the root directory. Change 4082755 by Graeme.Thornton Fixed an erroneous usage of TUniquePtr<uint8>as a pointer to a uint8 array when creating pak files. Caused a crash when compression was enabled, and has probably surfaced because pak generation is now done by an editor commandlet rather than a standalone program. Change 4082756 by Graeme.Thornton Fixed some incorrect documentation for pakfile compressed chunk headers Change 4082883 by Graeme.Thornton Static analysis warning fix Change 4082912 by Ben.Marsh Move ExceptionUtils into DotNETUtilities. Change 4085291 by Graeme.Thornton TBA: In the Json output formatter, write float and double values out with enough precision for successful roundtripping. Added some debug only code which will immediately reconvert the string back to its original value and compare the the input Change 4085523 by Graeme.Thornton TBA: Remove only explicit usage of DECLARE_FSTRUCTUREDARCHIVE_SERIALIZER. Should only be used from UHT generated code. Change 4086037 by Robert.Manuszewski Fix for a potential race condition when two threads want to acquire GC lock Change 4088655 by Graeme.Thornton Pak creation now uses the bEnablePakSigning setting from the crypto config json file Change 4091474 by Steve.Robb Fix for TStaticBitArray::FindFirstSetBit() and TStaticBitArray::FindFirstClearBit(). Unused variables removed. Change 4093632 by Steve.Robb CIS fixes. Change 4093656 by Graeme.Thornton Build fix Change 4093744 by Ben.Marsh Allow per-chunk settings for whether to enable compression in UnrealPak. Change 4099712 by Gil.Gribb UE4 - Fixed rare case where insufficient space was preallocated for cooldown ticks. #jira UE-59686 Change 4099912 by Stefan.Boberg Cooking timer optimizations: - Replaced data structures for FScopeTimer and FHierarchicalTimerInfo. Previous implementation used FString for many things and caused *lots* of heap and string concatenation activity. Replaced with a compile-time node id (using __COUNTER__) and raw string literals. - Removed PERPACKAGE_TIMER support (was disabled by default and was difficult to test) - Made it possible to toggle OUTPUT_TIMING and ENABLE_COOK_STATS independently - Removed some extremely tight timers because the overhead from calling QPC significantly exceeded the measured code This change shaved some 15% off a clean cook of Fortnite WindowsClient (en) with fully populated local DDC Change 4100519 by Stefan.Boberg Quick fix for Linux build issue introduced in 4099927 Change 4105327 by Stefan.Boberg Cooker: Changed FHierarchicalTimerInfo so it uses a linked list for tracking child nodes, to be able to deal with any child count. Previously we assumed there would never be more than 9 children but it turns out there are cooker modes that need more. Fixes check when using -FullLoadAndSave to cook Change 4105448 by Stefan.Boberg - Fixed Linux build warning re: member initialization order - Also eliminated OUTPUT_HIERARCHYTIMERS/CLEAR_HIEARCHYTIMERS macros (plain functions are fine) - Moved finishing-up code for FullLoadAndSave() to TickCookOnTheSide() call site to improve timer output. Previously some of the scopes would not have been closed before printing and thus the output was misleading. Change 4109031 by Ben.Marsh Attribute-driven Perforce wrapper (old Epic Friday project). Offers a more complete implementation than the current P4 wrapper in UAT without requiring any platform-specific libraries. Uses the Python binary output for parsing. Change 4109588 by Ben.Marsh UBT: Add extension methods for serializing a nullable type to a BinaryReader/BinaryWriter. Change 4109595 by Ben.Marsh Missing project file for DotNETUtilities. Change 4110724 by Stefan.Boberg Removed annotation map locking in UObjectMarks, eliminating around one minute (~3.5%) from Fortnite cook time. The locking was redundant since the annotation maps are managed per thread anyway. Change 4111304 by Ben.Marsh UAT: Add support for setting a status message through the log class. Allows writing transient messages (eg. progress messages) which will be cleared out before writing other messages. Best used through the LogStatusScope class, which can set a status message for the duration of a using() block. As part of this change, the console no longer has to be added as a dedicated trace listener. Since we already special-case this listener when formatting log output, it's easier to just keep the implementation separate to the other trace listeners. Change 4112708 by Steve.Robb Fix for TBitArray::MaxBits in assignment. Change 4114133 by Stefan.Boberg Tweaked how low-level memory (LLM) tracker is implemented to reduce overheads. Previously FMemory functions would acquire the LLM singleton and call OnLowLevelFree/OnLowLevelAlloc etc which would check the bIsDisabled flag and early out if it was set. Due to how frequently these functions were called this ended up costing quite a bit. - This change makes the flag a static member variable instead of a member variable and therefore enables a simpler early-out to be implemented. - The singleton getter is also simplified to avoid hitting the threadsafe singleton construction path on every call. - The enable flag is no longer TAtomic - this also incurs extra overhead for no clear benefit Shaves approximately 3.5% (one minute) off a Fortnite cook test scenario (using -FullLoadAndSave) Change 4115010 by Robert.Manuszewski Fixing CIS Change 4115249 by Robert.Manuszewski Fixing async loading code asserts when exiting game very early due to an error #jira UE-56267 Change 4117091 by Ben.Marsh Prevent doubled-up lines when writing status updates with console log verbosity. Change 4117207 by Ben.Marsh UGS: Do not include executables in diagnostics zip file, and ignore "no such files" error when cleaning workspace. Change 4119175 by Ben.Marsh UGS: Fix crash writing version files when directory does not already exist. Change 4119987 by Ben.Marsh UGS: Show a dialog box while the launcher is updating executables from Perforce, which allows cancelling the operation if necessary. Allow setting the username on the settings window, and prompt for login credentials if necessary. Should prevent situations where users have to update settings from the command prompt. Holding down shift during launch now shows the settings dialog rather than an immediate prompt to launch the unstable version (unstable version is shown as a checkbox on this dialog). Change 4119991 by Ben.Marsh Update version number for UGS launcher to 1.13. Change 4121943 by Robert.Manuszewski Don't use FArchiveAsync2 for reading packages with non-async path in editor builds as its performance is worse than the standard archive's (saves about 1 minute when doing larger cooks and 7 seconds when loading into PIE) Change 4122592 by Steve.Robb GitHub #4762 : Improve wording and grammar of Math comments Also includes improved accuracy in FMath::ComputeBoundingSphereForCone(). Change 4122819 by Stefan.Boberg Don't call CreateDirectory redundantly when opening files for writing using FFileManagerGeneric::CreateFileWriter This change avoids calling IPlatformFile::CreateDirectoryTree if possible since this is a very expensive function especially for deep hierarchies as it performs directory creation from the root directory onwards instead of from the leaf downwards. That function should also be fixed but this change improves performance in the meantime. Change 4122872 by Stefan.Boberg CreateDirectoryTree now creates directories leaf-to-root instead of the other way around. This is much more efficient since we don't spend time on system API calls for directories which already exist. This accounted for a very large amount of CPU time in cooking as the full target file directory hierarchy would be "created" for every single output file. Change 4123109 by Stefan.Boberg - Disable overlapped I/O in editor / cooker. Synchronous I/O reduces the number of syscalls and Windows performs prefetching on our behalf anyway for sequential reads - Eliminated syscall which was issued for every write to update cached file size -- since we're the only writers to the file (file access allows read sharing at most) we can authoritatively update the file size on write completion Change 4123455 by Ben.Marsh PR #4775: New build param PCHMemoryAllocationFactor to set /Zm VS build param. (Contributed by lucaswall) Change 4124207 by Ben.Marsh UBT: Remove some unnecessary indirection for generated code paths. Change 4124217 by Ben.Marsh UBT: Remove another unused variable from UEBuildModuleCPP. Change 4124377 by Stefan.Boberg In IPlatformFile::DeleteDirectoryRecursively, attempt to delete file first and if it fails clear the readonly flag and try again Previously there was a call to clear the readonly flag for every deleted file and this is a waste of resources 99% of the time. The SetFileAttributes call accounted for a significant amount of time during cooker sandbox directory deletion Change 4125071 by Stefan.Boberg Some tweaks to FQueuedThreadPoolBase scheduling and memory management - Explicitly pass in false for TArray::RemoveAt(..., bool bAllowShrinking) argument to prevent memory reallocation when arrays are drained and inevitably repopulated shortly afterwards - Use a MRU strategy instead of LRU when picking a thread to wake up. The MRU thread is the most likely to have a 'hot' cache for the stack etc. Picking from the back of the array also happens to be cheaper since no memory movement is necessary when RemoveAt is called. (This was the strategy in place before CL2600362 which seems to have changed it unintentionally) - Release lock as soon as a thread has been chosen, before asking the worker thread to wake up and do the work Change 4126132 by Ben.Marsh UAT: Detect when stdout is redirected and prevent using backspace characters to move the cursor. Change 4126867 by Graeme.Thornton TBA: Fix tagged binary formatter Change 4127010 by Robert.Manuszewski AnimScriptInstances created at runtime will now also be added to the owning omponent's cluster to avoid GC issues. Change 4127932 by Ben.Marsh WorkspaceTool: Reduce unnecessary logging of status messages when console output is not redirected. Change 4129050 by Ben.Marsh UGS: Check for NET Framework 4.5 being installed before running the installer. Also fix warning trying to kill existing UGS instances before upgrade. Change 4129459 by Graeme.Thornton TBA: TextAssetCommandlet - When outputting converted assets to an output path, replicate the workspace relative path in the output directory Change 4129515 by Graeme.Thornton TBA: Add EnterRecord overload that allows outputting of available field names when loading. Change 4129517 by Graeme.Thornton TBA: Tagged properties are written out as named fields on the "Properties" record, rather than as a stream with a null tag at the end Change 4129518 by Graeme.Thornton TBA: Added a local const bool to allow easy hacking out of text asset loading support Change 4129558 by Graeme.Thornton TBA: Build fix for textasset-less configs Change 4129614 by Ben.Marsh UGS: Main window is now restored to normal size when activated by clicking on the tray icon. #jira UE-60490 Change 4129618 by Ben.Marsh UGS: Speculative fix for unreproduced exception accessing disposed window while shutting down. Change 4131936 by Robert.Manuszewski Removing some WIP code accidentally checked in with CL #4121943 Change 4133490 by Ben.Marsh UGS: Allow the $(Change) variable to be used in more places than just the context menu. #jira UE-60573 Change 4133550 by Ben.Marsh UGS: Setting for whether or not to use incremental builds is now exposed through the variable "$(UseIncrementalBuilds)" for use by custom build steps. #jira UE-60554 Change 4133681 by Ben.Marsh UGS: A per-project list of folders and extensions to be deleted by default when running the 'clean workspace' tool can now be specified through the <ProjectDir>/Build/UnrealGameSync.ini file. Settings may be specified for an individual branch (via a category with the depot path to the project) or for wherever the project is currently open (via the [Default] category). The SafeToDeleteFolders list specifies a substring that will be checked against folder paths. Anything containing this folder will be marked as safe for delete by default. The SafeToDeleteExtensions list specifies a list of extensions for files that can always be deleted. Example: [Default] +SafeToDeleteFolders=/MyGame/Test/ +SafeToDeleteFolders=/DataService/ +SafeToDeleteExtensions=.xx1 +SafeToDeleteExtensions=.xx2 #jira UE-60575 Change 4135449 by Ben.Marsh Fix allowing use of Job objects on Windows platforms (debug code submitted by mistake) Change 4135730 by Ben.Marsh UBT: Plugins can now be enabled and disabled from the .target.cs file (for targets that do not use the shared compile environment), by compiling the list of enabled/disabled plugin names into the Projects module. Change 4135823 by Ben.Marsh UBT: Remove legacy code to handle disabling optional plugins; now that this is compiled into the target, it will work for any plugins we choose. Change 4135945 by Ben.Marsh UBT: Fix error running programs with no explicitly enabled or disabled plugins. Change 4137207 by Ben.Marsh UGS: Align all badges with the same name, to make it easier to see which CIS steps are being run. Allow overriding the slot taken by a particular badge by calling it "SlotName:LabelName". Change 4137311 by Stefan.Boberg Removed child cooker support. In practice it is not a useful feature as it provides no performance improvement (quite the opposite in fact) and adds testing and maintenance complexity. Change 4137393 by Ben.Marsh UGS: Fix display of multiline errors in the status panel. Change 4141708 by Steve.Robb GitHub #3631 : Incorrect default argument in WeakObjectPtrTemplate #jira UE-45490 Change 4146655 by Stefan.Boberg Removed FullGCAssetClasses logic - no longer necessary nor useful Change 4147318 by Ben.Marsh UGS: Compress build badges in a column if it shrinks below the size that they would be visible. Change 4148207 by Ben.Marsh UGS: Added support for showing the latest completed build from a specific list of badges in the status panel. To declare a badge as one that should appear in the status panel rather than the CIS column, add it to the project's UnrealGameSync.ini in the project or [Default] section like so: +ServiceBadges=RoboMerge Change 4148282 by Stefan.Boberg Fixed bug in UCookOnTheFlyServer::GetCookOnTheFlyUnsolicitedFiles - UnsolicitedFiles should be passed by reference not by value Change 4148344 by Stefan.Boberg Fixed minor indentation error (most likely caused by sloppy merge) Change 4148521 by Stefan.Boberg Removed accidentally checked in PRAGMA_DISABLE_OPTIMIZATION from CookOnTheFlyServer.cpp Change 4148639 by Ben.Marsh UGS: Fix tooltips not showing for changes that have description badges. Change 4149373 by Ben.Marsh UGS: Allow adding additional columns to display particular badges by adding entries from the project config file. Example syntax: +Columns=(Name="Desktop",MinWidth=50,DesiredWidth=100,Weight=3,Badges="Editor") +Columns=(Name="Mobile",MinWidth=50,DesiredWidth=100,Weight=3,Badges="IOS,Android") Same form can be used to control how default columns are displayed (though badge settings are ignored). Also allow PerforceMonitor to detect local changes to project config files and update settings automatically. Change 4149399 by Ben.Marsh UGS: Update version to 1.143. Change 4155660 by Steve.Robb PROJECTION and PROJECTION_MEMBER macros which provide the correct behavior when creating projections using functions which are overloaded or use default arguments. Change 4157117 by Ben.Marsh Fix warning due to plugins disabled in .target.cs file. Change 4158011 by Ben.Marsh UBT: Add a check that the UnrealHeaderTool target file exists, rather than throwing an exception when reading it fails. Change 4158646 by Ben.Marsh UGS: Fix exception when login is discovered to have expired during a workspace update. Change 4158678 by Ben.Marsh UGS: Fix an exception on shutdown due to the icon being hidden after it's already been disposed. Change 4158683 by Ben.Marsh UGS: Add an unhandled exception filter which sends the exception data to the backend. Change 4159131 by Ben.Marsh UGS: Reduce the number of characters displayed for build badges based on the available space. Change 4159194 by Graeme.Thornton TBA: Fix incorrect map property conversion code when converting an old property that contains a map with different key/value types Change 4159239 by Steve.Robb Improved readability and compliance with coding standards. Change 4159246 by Ben.Marsh UGS: Allow syncing projects where source code is not available (and various version files don't exist). #jira UE-60985 Change 4159286 by Ben.Marsh UGS: Remove requirement for UE4Editor.target.cs to be visible in the depot in order to open a project. #jira UE-60986 Change 4159302 by Ben.Marsh UGS: Update version to 1.144. Change 4160308 by Ben.Marsh All staging client executables for blueprint projects. #jira UE-60983 Change 4161567 by Steve.Robb GitHub #4816 : UE-60771: Handle escaped double quote in FParse::LineExtended Change 4162641 by Ben.Marsh UGS: Allow customizing the position of custom columns, via the Index=N attribute. Change 4162647 by Ben.Marsh UGS: Update version to 1.145. Change 4165319 by Robert.Manuszewski PR #4812: Fix inconsistent command-line argument handling under Windows (Contributed by adamrehn) Change 4166150 by Ben.Marsh UGS: Include *.inl when looking for code changes. Change 4166551 by Steve.Robb Whitespace fixes caused by a bad merge. Change 4168483 by Ben.Marsh UGS: Add a more useful error if a file to be synced exceeds the max allowed path length. Change 4168490 by Ben.Marsh UGS: Update version to 1.146. Change 4168551 by Ben.Marsh UBT: Move bBuildLargeAddressAwareBinary into an exposed setting. Change 4168560 by Ben.Marsh UBT: Remove static config variable for controlling which configuration of UHT to use. Change 4171296 by Ben.Marsh UGS: Move the check for overlong paths earlier. Change 4171531 by Ben.Marsh UBT: Fix exception if BuildConfiguration.xml contains an unknown category. Change 4183371 by Robert.Manuszewski Fix for a crash in Async Loading Graph's CheckCycles when GC kicks in on the game thread and forces ALT to exit early Change 4184312 by Ben.Marsh UGS: Update version to 1.148 Change 4184480 by Robert.Manuszewski Removing unused async loading stat Change 4186390 by Ben.Marsh UBT: Format XML validation errors in a format that allows double-clicking on the message in Visual Studio. Change 4188644 by Ben.Marsh UBT: Add the MakePathSafeToUseWithCommandLine() function to UBT. Change 4188647 by Ben.Marsh UBT: Fix exception in target receipt when architecture is null. Change 4189617 by Ben.Marsh Change FileSystemReference, FileReference and DirectoryReference objects to use OrdinalIgnoreCase comparisons without creating a separate copy of the string to compare. The filesystem does not use the invariant culture, and it can produce the wrong results in some cases (the ordinal comparison is faster, too). Change 4189740 by Ben.Marsh UAT: Remote code to build UnrealPak when packaging; we use the editor now. Change 4189860 by Ben.Marsh UGS: Make the filter for excluding automated lighting rebuilds more explicit. Change 4190082 by Ben.Marsh Fixes to allow enabling edit and continue for Windows builds. Have experienced quite a few VS crashes when testing it in editor; not yet recommended for general use. - Allow edit and continue for any configuration, not just debug. - Fixed PDB errors compiling files that use a shared PCH with edit and continue enabled. Path to the generated PDB file was using the wrong directory. - Removed code that tracks PDB output files, since they're modified multiple times during a build. - Enable debug information when compiling generated CPP files, since it causes errors if the shared PCH PDB doesn't have the same option. - Disable support for remote execution of steps that modify the PDB, since the same file has to be modified many times. Remote execution causes the PDB files to be corrupted. Unfortunately, this makes E&C builds significantly slower. #jira Change 4192949 by Ben.Marsh UBT: Minor tidy-up (merging UEBuildBinary.Build and UEBuildBinary.SetupOutputFiles) Change 4193218 by Ben.Marsh Fix formatting. Change 4197252 by Mike.Erwin UAT: Fix log output w/ correct count of non-code projects. #jira none Change 4197941 by Ben.Marsh UGS: Add support for DebugGame editors that have an executable with a DebugGame suffix. Change 4197964 by Ben.Marsh UGS: Prevent attempts to automatically reopen projects while a modal dialog is up, or the workspace is syncing. Change 4198144 by Ben.Marsh UGS: Prevent modal dialogs when login expires in P4, and prompt for password when hitting "retry". Change 4198413 by Ben.Marsh UGS: Always show the main window when launched manually, and run with -RestoreState when launched at startup. Also add a couple more places that save the visibility state, since logging off seems like it can terminate the process abrubtly. Change 4198779 by Ben.Marsh UBT: Allow generating manifests to any arbitrary locations with the -Manifest=<Path> argument. Change 4198825 by Ben.Marsh UBT: Move code to enumerate Slate runtime dependencies into the Slate module. Doesn't need to be done inside core UBT. Change 4199341 by Ben.Marsh UGS: Update version to 1.149 Change 4199642 by Chad.Garyet - Deprecate CISController - Add BuildController to replace CIS GET/POST for builds - Add LatestController, GET does what CIS/GET used to do - Change Latest/GET to return the last 25 builds filtered by project, rather than the last 5000 individual Ids - Latest/GET now returns "LatestData" object instead of array of longs - Updated EventMonitor to match all API changes - Fixed bug where IDs were getting reset to initial startup values every update loop Change 4199663 by Chad.Garyet CIS controller still needs to return an array of longs #jira none Change 4199680 by Ben.Marsh UGS: Update version to 1.150 Change 4200457 by Ben.Marsh Merging CIS fix for non-development configurations. Change 4200472 by Mike.Erwin UAT: fix -skipbuildclient param default It was defaulting to skipbuildeditor's value, likely a copy-paste error. #jira none Change 4202595 by Ben.Marsh Fix static analysis warning due to constant comparison against macro. Change 4203250 by Ben.Marsh UGS: Always show the "Sync Precompiled Editor" option, but disable it and show a tooltip explaining why if it is not available. Change 4206191 by Ben.Marsh Exclude editor target files from installed builds, since they leak info about DLLs that have been stripped out. Change 4213011 by Ben.Marsh UBT: Include contents of modified intermediate files in the log, to make it easier to debug hidden dependencies. Change 4213487 by Ben.Marsh UBT: Fix assumption that bPrecompile is equivalent to bBuildAllModules. This is no longer the case; they are now controlled by separate options. Should fix CIS errors building the editor. Change 4213609 by Ben.Marsh Ensure that strings formatted using FMicrosoftPlatformString::GetVarArgs() are always null terminated, whether we use the secure CRT or not. Change 4215971 by Ben.Marsh UBT: Remove action graph visualization code; no longer used. Change 4215996 by Ben.Marsh UBT: Remove unqiue id from all actions in the action graph. This is only used for printing debug info in the case of a (rare) cycle in the action graph, so just look it up when needed. Change 4216022 by Ben.Marsh UBT: Rename Crypto.cs to EncryptionAndSigning.cs to match the name of the class inside it, and move it under the System folder. Change 4216031 by Ben.Marsh UBT: Move all the action executors into their own folder in the project. Change 4216526 by Ben.Marsh Fix CIS warnings. Change 4216544 by Ben.Marsh Replace custom code to ensure FMicrosoftPlatformString::GetVarArgs() null terminates its buffer with Microsoft's standards-compliant implementation. Change 4216633 by Ben.Marsh Add support for UnrealPak plugins. * Project and plugin modules can now specify an array of supported programs in the "WhitelistPrograms" field of their module descriptors, to allow modules to be loaded by programs. * Programs can now load any runtime modules, as long as they are whitelisted. * Programs under the engine directory can now use a shared build environment, so that building with a project file does not cause output binaries to be output to the project directory. * UnrealPak is now always built by default when packaging * Convert UnrealPak to a modular configuration Change 4216736 by Ben.Marsh UnrealPak: Move "ExportDependencies" command into an editor commandlet, since it relies on the UObject system, asset registry, etc... Change 4217447 by Ben.Marsh Back out revision 50 from //UE4/Dev-Core/Engine/Build/InstalledEngineBuild.xml Change 4217451 by Ben.Marsh Back out revision 11 from //UE4/Dev-Core/Engine/Plugins/Developer/VisualStudioSourceCodeAccess/Source/VisualStudioSourceCodeAccess/VisualStudioSourceCodeAccess.Build.cs Change 4217617 by Ben.Marsh Back out changelist 4217451 Change 4222552 by Ben.Marsh Don't use #import <TypeLib> for VS source code accessor when building with Clang; it's not supported. Change 4222630 by Ben.Marsh UBT: Fix spam while generating project files if Clang isn't installed. Change 4223316 by Ben.Marsh UBT: Change the order in which Visual C++ toolchains are enumerated to prefer full releases over preview releases. Change 4223318 by Ben.Marsh UBT: Add a build setting which allows creating a dedicated PCH for every file that's excluded from the unity working set (disabled by default). Improves iteration times when working on individual cpp files, but slows down iterating on header changes (and can take a lot of disk space for large changes). Dedicated PCH contains all includes scraped from the top of each cpp file, until a non-#include directive is encountered. Change 4223401 by Ben.Marsh UBT: Add an option to automatically enable edit and continue for files in the adaptive non-unity working set. E&C doesn't seem very useful for UE4 projects right now; compile time is comparable to regular build times, but it can take several minutes to apply code changes for large projects. Change 4223899 by Ben.Marsh UBT: Fix loading XML config files on Mono; Type.GetField(Name) does not seem to return values unless binding flags are specified. Change 4224637 by Ben.Marsh Add a "SupportedPrograms" field to plugin descriptors, which allows plugins to declare which plugins they support independently of individual modules. Programs now respect the "bEnabledByDefault" setting in plugins. Plugins that are compatible with a program now need to list that program in the SupportedPrograms list, and whitelist any modules that should load for that program. Change 4224710 by Ben.Marsh UBT: Don't add import libraries as final build products unless the target is being precompiled. Prevents the need for building them for leaf nodes in the action graph. Change 4224715 by Ben.Marsh UBT: Remove hack to allow Stats2.cpp to not follow IWYU convention. Change 4224726 by Ben.Marsh Remove commented out line. Change 4224903 by Ben.Marsh Fix non-unity compile error in Stats2.h. Change 4225051 by Ben.Marsh Back out changelist 4224710; causing CIS errors due to receipts not matching. Change 4225134 by Ben.Marsh Fixing non-unity errors. Change 4225203 by Ben.Marsh Another non-unity fix. Change 4225249 by Ben.Marsh Fix Linux dependencies being copied for the Windows editor; they can be added as requirements for the Linux target platform on Windows instead, so it respects the user's chosen platforms. #jira UE-62001 Change 4225512 by Ben.Marsh BuildGraph: Allow setting the target to build when using the <CsCompile> task. Change 4228815 by Ben.Marsh UBT: Always add the generated code directory to the list of include paths when generating project files. It may only be created after UHT has been run. Change 4228944 by Ben.Marsh UBT: Remove legacy CppCompileEnvironment and LinkEnvironment wrappers from TargetRules that were deprecated in 4.19. Change 4229028 by Ben.Marsh UBT: Fix editor targets with unique build environment having the wrong executable path in generated project files. Move move logic to configure target rules post-construction by the rules assembly to ensure it's valid. Change 4229065 by Ben.Marsh UBT: Move another target setting into the rules assembly. Change 4229105 by Ben.Marsh Fix BPT exception when generating project files. Change 4229311 by Ben.Marsh UBT: Store the module rules file location on the ModuleRules instance, as well as the plugin that it was created from. Also expose the plugin directory as a property on the ModuleRules instance. Change 4229421 by Ben.Marsh UBT: Consolidate functionality for UHT module setup in ExternalExecution.cs. Change 4229817 by Ben.Marsh UBT: Modules must now explicitly specify the path to the header used to generate a PCH if one is desired, rather than the header being determined automatically by attempting to parse the source code. Now that PCHs are force-included anyway, this removes a lot of dependencies inside UBT. Change 4229824 by Ben.Marsh UBT: Remove unused lists inside UEBuildModuleCPP.SourceFilesClass. Change 4229841 by Ben.Marsh UBT: Remove some legacy code from auto-detecting PCHs. Change 4230521 by Ben.Marsh UBT: Add utility functions to the log class to allow formatting errors and warnings in Visual Studio output format (eg. File(Line): warning: Message) Change 4230871 by Ben.Marsh UAT: Remove StreamUtilis utility class; there is a simpler way to implement the one place it's used. Change 4230882 by Ben.Marsh UAT: Add StreamUtils back into UAT, seems like it's still used there. Change 4230896 by Ben.Marsh UBT: Remove some redundant parameters from UEBuildModule/UEBuildModuleCPP/UEBuildModuleExternal constructors. Change 4231014 by Ben.Marsh WorkspaceTool: Include a dump of raw bytes when garbage is read from the P4 process, for diagnostic purposes. Change 4231032 by Ben.Marsh Fix CIS. Change 4231096 by Ben.Marsh Bump the FlatCPPIncludeDependencyCache version, to prevent errors trying to load old files. Change 4231446 by Ben.Marsh UBT: Added support for expanding UE-specific variables in include paths and library paths: $(EngineDir), $(ProjectDir), $(PluginDir), $(ModuleDir). Change 4231460 by Ben.Marsh Modules may now explicitly specify rpaths on Linux via the PublicRuntimeLibraryPaths and PrivateRuntimeLibraryPaths properties. Change 4233909 by Robert.Manuszewski PR #4779: Reason fails as the supplied variable is incorrect (Contributed by projectgheist) Change 4233910 by Ben.Marsh Enable PCHs on IOS. Reduces build time by ~25%. Change 4234176 by Ben.Marsh UBT: Add better messaging for modules that need to have a private PCH set. Now detects the likely PCH using the same method as legacy code and includes it as a suggestion. Change 4234193 by Ben.Marsh Add the Delete command to Perforce wrapper in DotNETUtilities. Change 4234688 by Ben.Marsh UBT: Simplify handling of installed/precompiled builds. Settings for whether a folder is installed/read-only or not is now stored on the RulesAssembly instance, allowing multiple things to be configured separately and stacked together (eg. engine/enterprise/project). RulesAssembly.IsReadOnly() allows determining if a flie can be modified or not and replaces many previous IsXXXInstalledCalls(), and traverses the chain of assemblies. Change 4234711 by Ben.Marsh UBT: Runtime dependencies can now be copied to output directories as part of the build. When adding a runtime dependency, an optional source location can be specified to copy from. Both the source and target paths can use variables can be used as part of the path, eg. $(OutputDir), $(ModuleDir), $(PluginDir). Example usage (from a .build.cs file): RuntimeDependencies.Add("$(OutputDir)/Foo.dll", "$(PluginDir)/Source/ThirdParty/Foo.dll", StagedFileType.NonUFS); Change 4234872 by Ben.Marsh Expose a flag for whether the engine is installed, to fix issues generating project files. Change 4234929 by Ben.Marsh Fix null reference generating receipts when UBT makefiles are active. Change 4235883 by Chad.Garyet Merging 4231245 to core Giving Coordinator its own sln. This should fix what 4158155 was supposed to. #jira UE-61955 Change 4236075 by Ben.Marsh CIS fix Change 4237066 by Robert.Manuszewski Fix for a potential crash when terminating the engine while it's being initialized #jira UE-60545 Change 4237078 by Robert.Manuszewski The engine will no longer be resetting all linkers causing massive load times when renaming the world package when entering Play In Editor Change 4237116 by Ben.Marsh Rewrite some Windows utility functions to support paths longer than MAX_PATH. Change 4237158 by Ben.Marsh Add const TCHAR* overloads of FString::RemoveFromStart() and FString::RemoveFromEnd(). Change 4237159 by Ben.Marsh Fix FWindowsPlatformFile::GetFilenameOnDisk() support for paths longer than MAX_PATH, and simplify some of the other long path functions to avoid copying string buffers. Change 4239050 by Ben.Marsh Missing file Change 4239318 by Ben.Marsh Linux CIS fix. Change 4239685 by Ben.Marsh Static analysis CIS fix. Change 4240800 by Ben.Marsh WorkspaceTool: Include the full command line in the log for any P4 commands. Change 4240903 by Ben.Marsh PR #4909: Update copyright notices to 2018 (Contributed by projectgheist) Change 4241025 by Ben.Marsh UBT: Exclude mobile pipeline caches from generated project files. Causes huge slowdown when using 'Find in Files' through the IDE. Change 4241770 by Ben.Marsh UBT: Include action number in parallel executor output. #jira UE-62032 Change 4243469 by Ben.Marsh TBA: Merge FAnnotatedStructuredArchiveFormatter with FStructuredArchiveFormatter. Any functions that are only implemented for text archives now have a _TextOnly suffix, and are exposed through the FStructuredArchive interface. Change 4245723 by Robert.Manuszewski Fixing another creash when terminating the engine while initializing. #jira UE-60545 Change 4245862 by Steve.Robb VectorLoadFloat2(Ptr) added, which loads { Ptr[0], Ptr[1], Ptr[0], Ptr[1] } into a VectorRegister. Change 4246412 by Robert.Manuszewski The warning 'Calling StaticLoadObject during PostLoad may result in hitches during streaming' will now also report the object which had the PostLoad called on it when StaticLoadObject call happened. Change 4246612 by Ben.Marsh UBT: Fix spelling of "Intellisense". Change 4249454 by Robert.Manuszewski Added extra checks to catch scenarios where the EDL Precache Buffer is flushed before a package header is fully read Change 4249513 by Robert.Manuszewski Made sure the Async Loading Thread doesn't continue running after creating new async packages when garbage collector wants to run on the game thread Change 4255207 by Ben.Marsh UGS: Add additional logging whenever a P4 command fails, and when the user is logged out. Change 4255288 by Ben.Marsh PR #4921: Honor ModuleRules' bEnableExceptions flag when creating precompiled h. (Contributed by surakin) Change 4256422 by Ben.Marsh UBT: Add an error if a module referenced by a plugin descriptor doesn't exist. Change 4257385 by Robert.Manuszewski Creating new objects from within ForEachObjectWithOuter will now result in a fatal error as it's unsafe to change internal UObject hash tables when iterating over them. Change 4257454 by Robert.Manuszewski Added the option to filter clusters listed with gc.ListClusters by objects within them. Usage: gc.ListClusters Hierachy With=ObjectName1,ObjectName2... Change 4257526 by Robert.Manuszewski It's now possible to filter clusters that get logged with verbose cluster logging enabled (UE_GCCLUSTER_VERBOSE_LOGGING=1) by objects within them by specifying -DumpClustersWithObjects=ObjectName1,ObjectName2 in the command line Change 4257822 by Ben.Marsh Fixes for PlatformShowcase compile errors. Change 4258771 by Ben.Marsh UBT: Fix project files not being generated for foreign projects when creating .stub files. #jira UE-62462 Change 4258790 by Ben.Marsh UBT: Clean up the logic around generating project files before creating a stub IPA, so that it fails loudly if project files do not exist, and can accept target names not matching project names. Change 4259276 by Ben.Marsh UBT: Make it an error if a framework doesn't exist, rather than failing silently. Also remove some remote toolchain stuff that's no longer necessary. Change 4259280 by Ben.Marsh UBT: Fix embedded framework zips not being uploaded for plugins. #jira UE-62485 Change 4260236 by Ben.Marsh UBT: Fix path to generated engine project file. Change 4260334 by Ben.Marsh UGS: Fix custom build steps dialog inadvertantly modifying config file settings in-place. Change 4260361 by Ben.Marsh UGS: Allow for p4 login commands to fail, even though the user is logged in (due to a bad connection, etc...) Change 4260559 by Ben.Marsh UGS: Update version. Change 4261160 by Robert.Manuszewski MediaPlaylist will now be added to root set if the owning MediaPlayer is in the disregard for GC set (fixes GC assumption violation crash) #jira UE-62495 Change 4261421 by Ben.Marsh Force-sync files for building documentation, to fix issues with files not being updated. #jira UE-62413 Change 4261425 by Ben.Marsh UBT: Remove some leftover functions for handling the remote toolchain. Change 4261530 by Ben.Marsh UBT: Speculative fix (and better error reporting) for IOS mobile provision not being found in CIS. Change 4261611 by Ben.Marsh UBT: Downgrade warning to a log message, since it appears when generating project files. Change 4261710 by Ben.Marsh Remove assert that GLogConsole is set; it won't be for command line utilities that don't depend on ApplicationCore. #jira UE-62545 Change 4261831 by Ben.Marsh Fix compile errors due to missing include path when hot-reloading a module from the editor. There are not necessarily source files to compile when -modulewithsuffix is specified on the command line, which was results in GeneratedCodeWildcard not being set. #jira UE-62463, UE-62384 Change 4262723 by Ben.Marsh Whitelist plugins that need to be loaded by UFE. #jira UE-62564 Change 4265444 by Ben.Marsh Fix incorrect executable name for DebugGame configurations in Xcode. #jira UE-62574 Change 4265892 by Ben.Marsh Fix incremental compile failures due to dependency checking for unity files. CachedIncludePaths was not correctly being set on file items, so dependencies were being ignored. #jira UE-62575, UE-62603, UE-62597 Change 4266019 by Josh.Adams - Fixed the CopyAction for runtime dependencies that need to be copied to different location, on non-XGE Change 4266264 by Ben.Marsh Remove override for the __IPHONE_OS_VERSION_MIN_REQUIRED macro on TVOS. This macro is already defined by system headers (in <AvailabilityInternal.h>). Now that we support PCHs on IOS and TVOS, manually defining this macro results in it being defined three times (once for the PCH, once by AvailabilityInternal.h, and once by the force-included list of definitions for the source file being built). The errors for redefining the macro in AvailabilityInternal.h are suppressed due to it being a system header, but the error for redefining it for the source file being compiled are not. #jira UE-62578 Change 4266273 by Ben.Marsh Fixes incremental build failure when compile arguments for PCH have changed on IOS/TVOS. Compile action needs to have a dependency on PCH build action. Change 4266614 by Graeme.Thornton Fix crash when cooking nativized blueprints due to removal of child cooker system. Change 4266763 by Ben.Marsh Always build UnrealPak when building client targets. The ProjectParams.Pak option is not reliable, because it can be forced on later by the target platform. #jira UE-62584 Change 4267985 by Robert.Manuszewski When iterating with ForEachObjectWithouter, don't lock the entire has table but only the hash bucket that is currently being iterated #jira UE-62600 Change 4268558 by Robert.Manuszewski PurgeLegacyBlueprints will no longer be called from within ForEachObjectWithOuter is it renames objects that reside in hash tables that are being iterated over which may lead to undefined behavior. #jira UE-62600 Change 4269011 by Chad.Garyet - Fixing Wildcard match issue, the change to ugsapi sends projects as //Depot/Stream instead of //Depot/Stream/ Wildcard match was only substringing to 3 chars. - Checking in the change a while back that increases the number of queried jobs up to 432 based on some maths from Bob about how many builds we want to grab Published to ugsapi server 8/8/17 #jira none Change 4270788 by Ben.Marsh Fix IOS provisioning data being using when remote compiling on TVOS. #jira UE-62705 Change 4271916 by Ben.Marsh Tag the XGEControlWorker executable as a build product after compiling SCW, to make sure it's included in the UGS zip file. Change 4271934 by Ben.Marsh Upload all static libraries in plugin folders as part of remote builds. #jira UE-62694 Change 4273368 by Ben.Marsh Fix Slate dependencies not being enumerated, and rules assembly not being rebuilt when building remotely. #jira UE-62705 Change 4274049 by Ben.Marsh Always parse the team UUID out of the mobile provision when doing a remote compile. The provision installed on the remote Mac (and selected for signing) may be different. #jira UE-62751 Change 4274823 by Ben.Marsh Add the -VersionCookedContent argument to disable the -unversioned parameter on the cooker command line. Change 4275838 by Ben.Marsh Fix BuildVersion string not being passed through from <SetVersion> task. Also add a -BuildVersion command line argument to UBT to override it for a particular build. Change 4275913 by Ben.Marsh Add a dummy exported symbol to the XGEController module, to fix build errors due to missing .lib file when it's built with WITH_XGE_CONTROLLER = 0. Change 4284161 by Ben.Marsh Allow mirroring Oodle files to remote Mac. Change 4074774 by Steve.Robb Vast simplification of TFunction, making it smaller in footprint, easier to follow and extend, and more correct. TUniqueFunction added, which is a move-only TFunction which can hold move-only functors. Fix for UWidgetBlueprint::ForEachSourceWidget() which should never have compiled but did. FFunctionGraphTask and TFuture<> updated to use TUniqueFunction to make them more general. TArray::HeapPop() made to work with move-only types. Change 4082591 by Ben.Marsh Move the Log class from UBT to DotNetUtilities. Change 4083236 by Ben.Marsh Add a Log.WriteException() method to dump an exception message to the console (and write the exception trace to the log) Change 4084107 by Ben.Marsh UAT: Remove the unused -SkipHeader argument to UE4Build. Change 4089771 by Steve.Robb GitHub #4743 : modified VirtualAlloc function flag https://blogs.msdn.microsoft.com/oldnewthing/20151008-00/?p=91411 Change 4091456 by Steve.Robb Unification of all platforms' FMath::CountTrailingZeros() and FMath::CountLeadingZeros() for both 32-bit and 64-bit. Change 4156437 by Ben.Marsh Lots and lots of fixes compiling for Clang on Windows. Editor now compiles cleanly without warnings, but crashes on startup due to error in intrinsics test. Disabling that runs further, but crashes accessing freed memory. Switching to the ANSI allocator runs further, but crashes in Slate after the splash screen and before the editor window opens. // TODO! * Switching between Clang/ICL/VS2015/VS2017 is now supported through the same mechanism as switching Visual Studio versions, without requiring any source level changes. To use Clang, set WindowsPlatform.Compiler = WindowsCompiler.Clang from a .target.cs file, or set <WindowsPlatform><Compiler>Clang</Compiler></WindowsPlatform> from BuildConfiguration.xml. To pick a specific toolchain version, set WindowsPlatform.CompilerVersion. * Clang is now supported through AutoSDKs; will be added to CIS. * The Samples/Sandbox/Clang project forces Clang to be used from its target.cs file, and allows easily building all editor modules and plugins with Clang on Windows. * UnrealMathSSE intrinsics have been re-enabled for Clang due to missing functions from the UnrealMathFPU implementation, but causes failure in tests at startup. * SSE4_CRC32() is disabled in D3D12Pipelinestate.cpp, since intrinsics are only allowed if enabled for the whole target (rather than being used in specific functions due to runtime checks) Change 4157389 by Ben.Marsh Few more fixes for compiling the editor with Clang. Change 4183911 by Ben.Marsh Fixes to support incremental linking on Windows. Does not seem to have any net benefit right now; may improve once minimal rebuild is enabled. * Incremental linking no longer forces PDB files to be enabled for source files. * Actions can specify specific files to be deleted before each build. Code to forcibly delete PDB files has been moved to the MSVC toolchain. * Unused libraries produced by the cross-referenced link are no longer added as build products, since (a) deleting them breaks dependency checking for incremental linking and causes a full link, and (b) not deleting them breaks UBT dependency checking and causes actions to be run over and over again. * Icon update is disabled for Windows when incremental linking is enabled. * Removed rarely-used setting to always delete produced items before each build. Change 4184311 by Ben.Marsh UGS: Added a dialog which shows all the required platform SDKs for a branch, linked from the status panel in UGS. The llist is configured via the UGS config file submitted to Engine/Programs/UnrealGameSync/UnrealGameSync.ini (and may be overridden by the project config file if necessary): [Default] ; Set this to a network share which contains the SDK installers for your site SdkInstallerDir= ; All the required SDKs for the current version of the engine +SdkInfo=(Category="Android", Description="NDK r21", Browse="$(SdkInstallerDir)\\Android") +SdkInfo=(Category="Windows", Description="Visual Studio 2017") +SdkInfo=(Category="Windows", Description="Visual C++ Toolchain 14.13.26128") +SdkInfo=(Category="Windows", Description="Windows SDK 10.0.16299.0") Similar entries for console platforms are added in console subdirectories. Each entry may contain an Install="Foo.exe" and/or Browse="C:\Foo" style attribute, specifying the path to an installer to run or directory to open in explorer respectively. The SdkInstallerDir setting is used as a base directory for the default installers, seen above for Android. Licensees may override this with a network path specific to the site that UGS is being deployed to (either in this file, in a project specific config file, or in a Engine/Programs/UnrealGameSync/NotForLicensees/UnrealGameSync.ini file). Change 4200452 by Ben.Marsh UBT: Change DebugGame configurations to output a separate executable rather than requiring a -Debug argument at runtime. Previous behavior was a common source of errors. Engine modules are still shared between Development and DebugGame, but the launch module sets a flag in Core on startup indicating the game configuration. Change 4206189 by Ben.Marsh UBT: Simplify logic for precompiling binaries. * Target no longer has separate list of "precompile only" binaries or modules. New -AllModules option allows adding every module to a target, which can be used with -Precompile and -NoLink to precompile object files for monolithic builds. * Precompiled file lists have been removed from target receipts. * The manifest now includes all generated headers and precompiled files when run with the -Precompile option. * Separate -DependencyList=Foo.txt has been added to write a list of all dependencies required to use precompiled binaries. This file list can be read using the <Tag> task in buildgraph. Change 4215466 by Ben.Marsh UBT: Remove indirect calls to determine extensions for object files and precompiled headers. The toolchain knows the correct convention for the platform. Change 4215975 by Ben.Marsh UBT: Remove telemetry code. This has never proved useful for analyzing performance due to the number of incidental factors that affect build times (eg. number of files being compiled). Change 4220154 by Ben.Marsh Move text-only implementations of FOutputDeviceError back into Core, so we can build command-line applications that don't depend on ApplicationCore. Change 4224708 by Ben.Marsh Add a bCompileAgainstApplicationCore setting to the target rules, which allows compiling out references to the ApplicationCore module (which should only be necessary for applications with a GUI). Removed ApplicationCore from several engine tools and utilities. Change 4224958 by Ben.Marsh Remove CoreMinimal.h includes from Core. Change 4229059 by Ben.Marsh UBT: Remove the UEBuildPlatform.ShouldNotBuildEditor() hook for target platforms. We shouldn't be modifying a target's build environment to disable the editor; it is invalid to build the editor for these target platforms at all, and this is already enforced by the GetSupportedPlatforms() function. Change 4230508 by Ben.Marsh Fixup precompiled header setting for samples and games. Change 4231457 by Ben.Marsh Fix exceptions in log messages having trailing newlines. Change 4232406 by Ben.Marsh UBT: Always force include a PCH for generated code if there's one set; the code may depend on it to compile. Change 4234177 by Ben.Marsh Set up private PCH files everywhere that previously used them. Change 4235973 by Ben.Marsh Change FPlatformMisc::GetEnvironmentVariable() to return an FString() rather than requiring a fixed size buffer to be passed in. Removes references to MAX_PATH. Change 4238842 by Ben.Marsh Add support for paths longer than MAX_PATH in the editor. Requires Windows 10 version 1607, and the functionality to be enabled via a registry key or group policy (see https://docs.microsoft.com/en-us/windows/desktop/FileIO/naming-a-file). Only a subset of Win32 functions support long paths (executables can only be started from paths shorter than MAX_PATH, for example). * Added a FPlatformMisc::GetMaxPathLength() function to return the maximum length of a path on the current system. On Windows, this returns a different value for systems with long paths enabled to those without. * The MAX_PATH define is no longer set by non-Windows platforms. Instead, there is a MAC_MAX_PATH, UNIX_MAX_PATH, etc... for any platform-specific code that still relies on the previous macro. * The MAX_UNREAL_FILENAME_LENGTH macro has been renamed to MAX_UNREAL_FILENAME_LENGTH_DEPRECATED * The PLATFORM_MAX_FILEPATH_LENGTH macro has been renamed to PLATFORM_MAX_FILEPATH_LENGTH_DEPRECATED. * Removed custom resource files for programs, since they are just copies of the base UE4 one (which is used by default anyway). The base UE4 manifest declares support for long paths. * Fix 512 character maximum length on editor commands. 260 character limit remains in place for cooking at the moment (see ContentBrowserUtils.h), until C# staging code supports long paths. Change 4255042 by Ben.Marsh UBT: Remote compilation now uploads the entire workspace to the remote Mac and executes a separate remote instance of UBT rather than synchronizing individual actions. This makes the remote compile codepath much simpler, and removes a lot of special cases that exist to support it previously. The list of files to be transferred to the remote are listed as rsync filter rules in Engine/Build/Rsync/RsyncEngine.txt and RsyncProject.txt, which are applied to the root engine directory and project directory respectively. Projects that need to customize which files are uploaded can add their own <ProjectDir>/Build/Rsync/RsyncProject.txt file, which will be included in the filter before the default version. Change 4260567 by Ben.Marsh UAT: Rename CommandUtils.Log to CommandUtils.LogInformation, to avoid conflicts with the underlying Tools.DotNETCommon.Log class. #rb none [CL 4285673 by Ben Marsh in Main branch]
2018-08-14 18:32:34 -04:00
LogInformation("Starting Client for unattended test....");
ClientProcess = Run(ClientApp, ClientCmdLine + " -testexit=\"" + LookFor + "\"", null, ClientRunFlags | ERunOptions.NoWaitForExit);
//@todo no testing is done on these
if (NumClients > 1 && NumClients < 9)
{
for (int i = 1; i < NumClients; i++)
{
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 4285612) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3836829 by Ben.Marsh UBT: Fix ability to precompile plugins from installed engine builds. Change 3839519 by Ben.Marsh UBT: Simplify configuring bPrecompile and bUsePrecompile settings for modules. Each rules assembly can now be configured as installed, which defaults the module rules it creates to use precompiled data. Change 4042043 by Steve.Robb GitHub #4705 : Added weak lambda's for delegates and multicast delegates. Change 4042056 by Robert.Manuszewski Optimized Mark Phase of GC by up to 10ms by making it run in parallel and removing a huge array presize which we didn't need. Change 4042104 by Robert.Manuszewski Set the minimum GC cluster size to 5 so that GC doesn't have to process micro clusters which are more expensive than processing individual objects + Exposed the minimum cluster size to ini and project settings as gc.MinGCClusterSize + Added the ability to sort clusters by name/object count/mutable object count/referenced clusters count when dumping them with gc.ListClusters command Change 4042377 by Robert.Manuszewski Reworked how GC and other threads (ALT specifically) interact - GC will now notify the ALT it wants to run and ALT will immediately try to finish its current work to allow that. Also the entire ALT tick is now protected against GC running at the same time to improve ALT stability. + added gc.ForceCollectGarbageEveryFrame console variable that triggers a forced GC every frame Change 4042427 by Robert.Manuszewski Changed FGCCSyncObject to use events when waiting for GC to finish so that it doesn't spin on non-game threads when GC is running Change 4042482 by Robert.Manuszewski Unhashing unreachable objects (ConditionalBeginDestroy) will now also be done incrementally, just like the purge phase of Garbage Collection Change 4042635 by Robert.Manuszewski Fix for a potential assert when incremental purge garbage is pending and something forces a full purge Change 4044092 by Steve.Robb Fix for forward declared CoreUObject weakobject types in delegates when building in Clang. Change 4044102 by Robert.Manuszewski Fix for a possible hang when worker threads are preventing GC from running and something is later trying to FlushAsyncLoading with the Async Loading Thread enabled Change 4044113 by Steve.Robb Another Clang fix. Change 4044160 by Robert.Manuszewski Disregard For GC pool will now be enabled by default in cooked builds Change 4044287 by Steve.Robb Typo fix. Change 4047723 by Graeme.Thornton TBA: Fixes for import/export name cache and object resolving Change 4048015 by Graeme.Thornton TBA: Weak/Soft/Lazy pointer serialization changes * Remove FWeakObjectPtr::Serialize, move it's logic into, and replace usages of with calls to, FArchiveUObject::SerializeWeakObjectPtr(). Ensures that something is always sent to the archive so that structured archives can be kept happy in the future. * Added Weak/Soft/Lazy pointer handling to the structured archive slot interface and all the formatters. Binary formatters just forward the call onto their inner and text archives store as a string path reference. * FArchiveUObjectFromStructuredArchive caches all these pointer types and stores indices in the binary block, same as with a UObject*. All pointers are then forwarded to the underlying formatter in one go on finalization. Change 4048021 by Steve.Robb Fix for binding an unbound TFunction to another TFunction with a different signature. Also all null pointers now count as unbindings, not just nullptr. TIsMemberPointer added. TIsATFunction and TIsATFunctionRef renamed to remove the 'A's. Change 4048544 by Robert.Manuszewski Fixing ConditionalBeginDestroy profiling after changes to incremental CBD. Change 4051028 by Graeme.Thornton TBA: ArchiveFromStructuredArchive adapter uses Inner to determine if it is outputting to text, and sets it's own ArIsTextFormat to false Change 4051056 by Graeme.Thornton TBA: High level tagged property / UObject base class text serialization - UObject serialize converted to structured archive - Properties written to text individually with text tags, and then binary adapted values - Only saves, doesn't load Change 4051111 by Graeme.Thornton TBA: Temporarily disable loading of text assets until tagged property serialization path is fixed up Change 4051154 by Graeme.Thornton TBA: Convert a few uobject serializers to structured archive format for example purposes Change 4051181 by Graeme.Thornton TBA: Added default structured archive implementation of SerializeItem to UProperty, which just calls the FArchive version on an FArchiveUObjectFromStructuredArchive adapter. Implemented structured archive SerializeItem for UArrayProperty Change 4051197 by Graeme.Thornton TBA: ObjectProperty text serialization Change 4051216 by Graeme.Thornton Restored a modified FWeakObjectPtr::Serialize function to keep backwards compatibility in code I don't have access to. Change 4051261 by Graeme.Thornton TBA: Convert UMetaData to structured archive Change 4051374 by Steve.Robb Incorrect assert removed. Change 4051562 by Robert.Manuszewski Adding stats for the new GC internal functions Change 4051614 by Graeme.Thornton TBA: Removed UProperty::SerializeItem(FArchive, ...) and replaced with UProperty::SerializeItem(FStructuredArchive::FSlot, ...). Fixed up most of them to work properly and added adapters in for any that were non-trivial. Change 4052512 by Graeme.Thornton TBA: Temporary workaround for softobjectptr and lazyobjectptr uproperties not serialization anything when they know the archive is a reference collector. They should always be serializing their pointers and letting the underlying archive itself ignore them. Change 4053917 by Robert.Manuszewski Clustered objects from clusters that are no longer reachable will now be marked as unreachable immediately when gathering unreachable objects Change 4053919 by Robert.Manuszewski Added the ability to disable incremental BeginDestroy in ini/project settings Change 4055518 by Daniel.Lamb Fixup for deterministic audio generation issue. Submitted on behalf of Rich.Whitehouse #jira nojira #test prefilght automated test. Change 4056854 by Graeme.Thornton TBA: Added a test asset to EngineTest which contains all the different property types and test cases. Change 4056858 by Graeme.Thornton TBA: Updated USetProperty to proper structured archive usage Change 4056872 by Graeme.Thornton TBA: Add map property field to test object Change 4056873 by Graeme.Thornton TBA: Convert UMapProperty to full structured archive Change 4056994 by Graeme.Thornton TBA: Converted FText over to structured archive. Implemented saving, but not loading. Change 4059728 by Ben.Marsh UBT: Add support for using adaptive non-unity builds when the engine and project are in separate repositories. Change 4059805 by Graeme.Thornton Fixed typo in text serialization. Fixes CIS automation test errors Change 4060007 by Graeme.Thornton TBA: FArchiveFromStructuredArchive will now access it's host slot lazily, i.e. only when a value is actually written to the archive. Change 4060092 by Stefan.Boberg Added optimized Windows console window output path to GenericConsoleOutput since this slowed down cooking considerably (2 minutes spent in wprintf alone for one large dataset) When stdout is attached to a console we use the WriteConsoleW function instead of wprintf since the latter is very slow especially in unbuffered mode which the engine currently configures for stdout (see setvbuf call in LaunchEngineLoop.cpp). At some point we should reconsider this buffering policy since it's likely to slow down other platforms as well but I wanted to do a safe change for now as I don't yet fully understand why the setvbuf call is there in the first place. Change 4060108 by Stefan.Boberg Introduced some additional target platform utilities to help with asset cook optimizations * We now assign each ITargetPlatform a zero-based ordinal value * Introduced FTargetPlatform and FTargetPlatformSet types to help store platform references and platform sets efficiently. These are not currently used in the engine but are designed to replace the existing ITargetPlatform/string/FName representations in the cooking data structures. Change 4060143 by Graeme.Thornton Undo //UE4/Dev-Core/Engine/Source/Runtime/... changelist 4060007 Needs some other changes that I haven't checked in yet... Change 4062432 by Ben.Marsh Fix error message when enumerating P4 changes. Change 4062648 by Ben.Marsh Add missing p4 integration action. Change 4063620 by Graeme.Thornton Integrated a fix from UDN where the engine would crash when trying to load a very small encrypted file (<16bytes) from a pak file, where the read address wasn't already aligned to the AES block size. (https://udn.unrealengine.com/questions/431989/crash-while-reading-a-very-small-file-in-encrypted.html) Change 4066963 by Robert.Manuszewski Fixing GC cluster verification code reporting false positives when a cluster is referencing another cluster through 'mutable' objects list. Change 4067133 by Robert.Manuszewski Changed log verbosity when reporting individual cases of GC cluster assumption violations as they are followed by an asser anyway and this way we get the chance to see all issues before we assert at the end of these checks. Change 4067443 by Steve.Robb FString can now be constructed from any char pointer type and length. Change 4068156 by Steve.Robb Fix necessary because of FString constructor change in CL# 4067443. Change 4070258 by Graeme.Thornton Fixes for VSCode Change 4070372 by Graeme.Thornton TBA: Script struct serialization to structured archives Change 4071913 by Ben.Marsh Move bulk of the code for UnrealPak into an engine developer module, so it can be used in the editor. Change 4071914 by Ben.Marsh Missing files. Change 4071937 by Ben.Marsh Missing header. Change 4072015 by Ben.Marsh Fixes for compiling PakFileUtilities as part of the editor. Change 4072826 by Steve.Robb TBitArray::Reserve() added. TBitArray::Add() overloaded to allow adding multiple bits. TSparseArray::Reserve() optimized to call the overloaded Add(). Change 4073271 by Daniel.Lamb Fixed add patch tier in project launcher passing the wrong commandline option to UAT. #test none Change 4074708 by James.Hopkin #core Removed redundant Casts Change 4074763 by Steve.Robb Fix for TSparseArray::Reserve() size. Change 4076063 by Ben.Marsh Add an "UnrealPak" commandlet with the same functionality as the standalone UnrealPak program. Invoke by running the editor with -run=UnrealPak and the standard UnrealPak commandline options. Change 4077064 by Robert.Manuszewski Fixing compile error in PakFileUtilities Change 4077144 by Graeme.Thornton TBA: TextAssetCommandlet improvements * Collect lists of broken assets during roundtrip tests and print a summary of packages that failed each phase at the end * After resaving as text, load the file back as a plain JSON hierarchy to ensure the output was valid Change 4077412 by Ben.Marsh Set the correct exit code for UnrealPak. Should return 0 on success, not 1. Change 4077760 by Graeme.Thornton TBA: Loading fixed for tagged property serialization Includes conversion of all UProperty::ConvertFromType() and SerializeFromMismatchedTag() functions to use structured archives Lazy initialization of FArchiveFromStructruredArchive when loading, to support the possibility of an adapter being create around an object property serialize call to its inner UStruct, which then decides not to do anything and return false. Stops the ArchiveFromStructuredArchive from consuming the slot and getting upset later on when we try to serialize normal tagged properties from it. Disabled lazy bulk data loading from text assets. Requires a bigger change to make it work. Added some debug checks to json input formatter which track the current value stack size when a new object is pushed onto the stack, and makes sure that the stack has returned to the same size when the object is popped. Catches cases where we unpack an array/stream to the value stack but then don't consume all the items. Change 4078800 by Ben.Marsh Change UAT to using the editor's UnrealPak commandlet rather than invoking the standalone UnrealPak executable. To improve performance when building several PAK files, also add a new -batch=<file> command which reads commands to execute in parallel from a text file. Change 4079745 by Graeme.Thornton TBA: Migrated a couple of UObject Serialize functions to FStructuredArchive (SoundCue / MaterialExpressions / Editor strip flags) Change 4079847 by Graeme.Thornton TBA: Add 'FindMismatchedSerializers' mode to text asset commandlet, which dumps out a list of all UClasses which don't have the CLASS_MatchedSerializers flag, meaning we can't guarantee the have Serialize functions for FArchive AND FStructuredArchive, therefore we can't use the new structured archive based serialize path. Should only ever be native instrinsic classes as UHT takes care of all other cases. Change 4079925 by Ben.Marsh Fix incorrect assignment when deriving name for chunked pak file. Change 4080214 by Ben.Marsh Move the ThreadPoolWorkQueue class into DotNETUtilities so it can be used by other projects. Change 4082394 by Graeme.Thornton CIS fix for variable shadowing warning Change 4082583 by Ben.Marsh Add a IBinarySerializable interface for types that support reading from a BinaryReader and writing to a BinaryWriter. Implementing IBinarySerializable implies a constructor taking a BinaryReader argument is available for deserializing. Change 4082652 by Ben.Marsh Fix FileReference.Directory not returning a directory with a trailing backslash for files in the root directory. Change 4082755 by Graeme.Thornton Fixed an erroneous usage of TUniquePtr<uint8>as a pointer to a uint8 array when creating pak files. Caused a crash when compression was enabled, and has probably surfaced because pak generation is now done by an editor commandlet rather than a standalone program. Change 4082756 by Graeme.Thornton Fixed some incorrect documentation for pakfile compressed chunk headers Change 4082883 by Graeme.Thornton Static analysis warning fix Change 4082912 by Ben.Marsh Move ExceptionUtils into DotNETUtilities. Change 4085291 by Graeme.Thornton TBA: In the Json output formatter, write float and double values out with enough precision for successful roundtripping. Added some debug only code which will immediately reconvert the string back to its original value and compare the the input Change 4085523 by Graeme.Thornton TBA: Remove only explicit usage of DECLARE_FSTRUCTUREDARCHIVE_SERIALIZER. Should only be used from UHT generated code. Change 4086037 by Robert.Manuszewski Fix for a potential race condition when two threads want to acquire GC lock Change 4088655 by Graeme.Thornton Pak creation now uses the bEnablePakSigning setting from the crypto config json file Change 4091474 by Steve.Robb Fix for TStaticBitArray::FindFirstSetBit() and TStaticBitArray::FindFirstClearBit(). Unused variables removed. Change 4093632 by Steve.Robb CIS fixes. Change 4093656 by Graeme.Thornton Build fix Change 4093744 by Ben.Marsh Allow per-chunk settings for whether to enable compression in UnrealPak. Change 4099712 by Gil.Gribb UE4 - Fixed rare case where insufficient space was preallocated for cooldown ticks. #jira UE-59686 Change 4099912 by Stefan.Boberg Cooking timer optimizations: - Replaced data structures for FScopeTimer and FHierarchicalTimerInfo. Previous implementation used FString for many things and caused *lots* of heap and string concatenation activity. Replaced with a compile-time node id (using __COUNTER__) and raw string literals. - Removed PERPACKAGE_TIMER support (was disabled by default and was difficult to test) - Made it possible to toggle OUTPUT_TIMING and ENABLE_COOK_STATS independently - Removed some extremely tight timers because the overhead from calling QPC significantly exceeded the measured code This change shaved some 15% off a clean cook of Fortnite WindowsClient (en) with fully populated local DDC Change 4100519 by Stefan.Boberg Quick fix for Linux build issue introduced in 4099927 Change 4105327 by Stefan.Boberg Cooker: Changed FHierarchicalTimerInfo so it uses a linked list for tracking child nodes, to be able to deal with any child count. Previously we assumed there would never be more than 9 children but it turns out there are cooker modes that need more. Fixes check when using -FullLoadAndSave to cook Change 4105448 by Stefan.Boberg - Fixed Linux build warning re: member initialization order - Also eliminated OUTPUT_HIERARCHYTIMERS/CLEAR_HIEARCHYTIMERS macros (plain functions are fine) - Moved finishing-up code for FullLoadAndSave() to TickCookOnTheSide() call site to improve timer output. Previously some of the scopes would not have been closed before printing and thus the output was misleading. Change 4109031 by Ben.Marsh Attribute-driven Perforce wrapper (old Epic Friday project). Offers a more complete implementation than the current P4 wrapper in UAT without requiring any platform-specific libraries. Uses the Python binary output for parsing. Change 4109588 by Ben.Marsh UBT: Add extension methods for serializing a nullable type to a BinaryReader/BinaryWriter. Change 4109595 by Ben.Marsh Missing project file for DotNETUtilities. Change 4110724 by Stefan.Boberg Removed annotation map locking in UObjectMarks, eliminating around one minute (~3.5%) from Fortnite cook time. The locking was redundant since the annotation maps are managed per thread anyway. Change 4111304 by Ben.Marsh UAT: Add support for setting a status message through the log class. Allows writing transient messages (eg. progress messages) which will be cleared out before writing other messages. Best used through the LogStatusScope class, which can set a status message for the duration of a using() block. As part of this change, the console no longer has to be added as a dedicated trace listener. Since we already special-case this listener when formatting log output, it's easier to just keep the implementation separate to the other trace listeners. Change 4112708 by Steve.Robb Fix for TBitArray::MaxBits in assignment. Change 4114133 by Stefan.Boberg Tweaked how low-level memory (LLM) tracker is implemented to reduce overheads. Previously FMemory functions would acquire the LLM singleton and call OnLowLevelFree/OnLowLevelAlloc etc which would check the bIsDisabled flag and early out if it was set. Due to how frequently these functions were called this ended up costing quite a bit. - This change makes the flag a static member variable instead of a member variable and therefore enables a simpler early-out to be implemented. - The singleton getter is also simplified to avoid hitting the threadsafe singleton construction path on every call. - The enable flag is no longer TAtomic - this also incurs extra overhead for no clear benefit Shaves approximately 3.5% (one minute) off a Fortnite cook test scenario (using -FullLoadAndSave) Change 4115010 by Robert.Manuszewski Fixing CIS Change 4115249 by Robert.Manuszewski Fixing async loading code asserts when exiting game very early due to an error #jira UE-56267 Change 4117091 by Ben.Marsh Prevent doubled-up lines when writing status updates with console log verbosity. Change 4117207 by Ben.Marsh UGS: Do not include executables in diagnostics zip file, and ignore "no such files" error when cleaning workspace. Change 4119175 by Ben.Marsh UGS: Fix crash writing version files when directory does not already exist. Change 4119987 by Ben.Marsh UGS: Show a dialog box while the launcher is updating executables from Perforce, which allows cancelling the operation if necessary. Allow setting the username on the settings window, and prompt for login credentials if necessary. Should prevent situations where users have to update settings from the command prompt. Holding down shift during launch now shows the settings dialog rather than an immediate prompt to launch the unstable version (unstable version is shown as a checkbox on this dialog). Change 4119991 by Ben.Marsh Update version number for UGS launcher to 1.13. Change 4121943 by Robert.Manuszewski Don't use FArchiveAsync2 for reading packages with non-async path in editor builds as its performance is worse than the standard archive's (saves about 1 minute when doing larger cooks and 7 seconds when loading into PIE) Change 4122592 by Steve.Robb GitHub #4762 : Improve wording and grammar of Math comments Also includes improved accuracy in FMath::ComputeBoundingSphereForCone(). Change 4122819 by Stefan.Boberg Don't call CreateDirectory redundantly when opening files for writing using FFileManagerGeneric::CreateFileWriter This change avoids calling IPlatformFile::CreateDirectoryTree if possible since this is a very expensive function especially for deep hierarchies as it performs directory creation from the root directory onwards instead of from the leaf downwards. That function should also be fixed but this change improves performance in the meantime. Change 4122872 by Stefan.Boberg CreateDirectoryTree now creates directories leaf-to-root instead of the other way around. This is much more efficient since we don't spend time on system API calls for directories which already exist. This accounted for a very large amount of CPU time in cooking as the full target file directory hierarchy would be "created" for every single output file. Change 4123109 by Stefan.Boberg - Disable overlapped I/O in editor / cooker. Synchronous I/O reduces the number of syscalls and Windows performs prefetching on our behalf anyway for sequential reads - Eliminated syscall which was issued for every write to update cached file size -- since we're the only writers to the file (file access allows read sharing at most) we can authoritatively update the file size on write completion Change 4123455 by Ben.Marsh PR #4775: New build param PCHMemoryAllocationFactor to set /Zm VS build param. (Contributed by lucaswall) Change 4124207 by Ben.Marsh UBT: Remove some unnecessary indirection for generated code paths. Change 4124217 by Ben.Marsh UBT: Remove another unused variable from UEBuildModuleCPP. Change 4124377 by Stefan.Boberg In IPlatformFile::DeleteDirectoryRecursively, attempt to delete file first and if it fails clear the readonly flag and try again Previously there was a call to clear the readonly flag for every deleted file and this is a waste of resources 99% of the time. The SetFileAttributes call accounted for a significant amount of time during cooker sandbox directory deletion Change 4125071 by Stefan.Boberg Some tweaks to FQueuedThreadPoolBase scheduling and memory management - Explicitly pass in false for TArray::RemoveAt(..., bool bAllowShrinking) argument to prevent memory reallocation when arrays are drained and inevitably repopulated shortly afterwards - Use a MRU strategy instead of LRU when picking a thread to wake up. The MRU thread is the most likely to have a 'hot' cache for the stack etc. Picking from the back of the array also happens to be cheaper since no memory movement is necessary when RemoveAt is called. (This was the strategy in place before CL2600362 which seems to have changed it unintentionally) - Release lock as soon as a thread has been chosen, before asking the worker thread to wake up and do the work Change 4126132 by Ben.Marsh UAT: Detect when stdout is redirected and prevent using backspace characters to move the cursor. Change 4126867 by Graeme.Thornton TBA: Fix tagged binary formatter Change 4127010 by Robert.Manuszewski AnimScriptInstances created at runtime will now also be added to the owning omponent's cluster to avoid GC issues. Change 4127932 by Ben.Marsh WorkspaceTool: Reduce unnecessary logging of status messages when console output is not redirected. Change 4129050 by Ben.Marsh UGS: Check for NET Framework 4.5 being installed before running the installer. Also fix warning trying to kill existing UGS instances before upgrade. Change 4129459 by Graeme.Thornton TBA: TextAssetCommandlet - When outputting converted assets to an output path, replicate the workspace relative path in the output directory Change 4129515 by Graeme.Thornton TBA: Add EnterRecord overload that allows outputting of available field names when loading. Change 4129517 by Graeme.Thornton TBA: Tagged properties are written out as named fields on the "Properties" record, rather than as a stream with a null tag at the end Change 4129518 by Graeme.Thornton TBA: Added a local const bool to allow easy hacking out of text asset loading support Change 4129558 by Graeme.Thornton TBA: Build fix for textasset-less configs Change 4129614 by Ben.Marsh UGS: Main window is now restored to normal size when activated by clicking on the tray icon. #jira UE-60490 Change 4129618 by Ben.Marsh UGS: Speculative fix for unreproduced exception accessing disposed window while shutting down. Change 4131936 by Robert.Manuszewski Removing some WIP code accidentally checked in with CL #4121943 Change 4133490 by Ben.Marsh UGS: Allow the $(Change) variable to be used in more places than just the context menu. #jira UE-60573 Change 4133550 by Ben.Marsh UGS: Setting for whether or not to use incremental builds is now exposed through the variable "$(UseIncrementalBuilds)" for use by custom build steps. #jira UE-60554 Change 4133681 by Ben.Marsh UGS: A per-project list of folders and extensions to be deleted by default when running the 'clean workspace' tool can now be specified through the <ProjectDir>/Build/UnrealGameSync.ini file. Settings may be specified for an individual branch (via a category with the depot path to the project) or for wherever the project is currently open (via the [Default] category). The SafeToDeleteFolders list specifies a substring that will be checked against folder paths. Anything containing this folder will be marked as safe for delete by default. The SafeToDeleteExtensions list specifies a list of extensions for files that can always be deleted. Example: [Default] +SafeToDeleteFolders=/MyGame/Test/ +SafeToDeleteFolders=/DataService/ +SafeToDeleteExtensions=.xx1 +SafeToDeleteExtensions=.xx2 #jira UE-60575 Change 4135449 by Ben.Marsh Fix allowing use of Job objects on Windows platforms (debug code submitted by mistake) Change 4135730 by Ben.Marsh UBT: Plugins can now be enabled and disabled from the .target.cs file (for targets that do not use the shared compile environment), by compiling the list of enabled/disabled plugin names into the Projects module. Change 4135823 by Ben.Marsh UBT: Remove legacy code to handle disabling optional plugins; now that this is compiled into the target, it will work for any plugins we choose. Change 4135945 by Ben.Marsh UBT: Fix error running programs with no explicitly enabled or disabled plugins. Change 4137207 by Ben.Marsh UGS: Align all badges with the same name, to make it easier to see which CIS steps are being run. Allow overriding the slot taken by a particular badge by calling it "SlotName:LabelName". Change 4137311 by Stefan.Boberg Removed child cooker support. In practice it is not a useful feature as it provides no performance improvement (quite the opposite in fact) and adds testing and maintenance complexity. Change 4137393 by Ben.Marsh UGS: Fix display of multiline errors in the status panel. Change 4141708 by Steve.Robb GitHub #3631 : Incorrect default argument in WeakObjectPtrTemplate #jira UE-45490 Change 4146655 by Stefan.Boberg Removed FullGCAssetClasses logic - no longer necessary nor useful Change 4147318 by Ben.Marsh UGS: Compress build badges in a column if it shrinks below the size that they would be visible. Change 4148207 by Ben.Marsh UGS: Added support for showing the latest completed build from a specific list of badges in the status panel. To declare a badge as one that should appear in the status panel rather than the CIS column, add it to the project's UnrealGameSync.ini in the project or [Default] section like so: +ServiceBadges=RoboMerge Change 4148282 by Stefan.Boberg Fixed bug in UCookOnTheFlyServer::GetCookOnTheFlyUnsolicitedFiles - UnsolicitedFiles should be passed by reference not by value Change 4148344 by Stefan.Boberg Fixed minor indentation error (most likely caused by sloppy merge) Change 4148521 by Stefan.Boberg Removed accidentally checked in PRAGMA_DISABLE_OPTIMIZATION from CookOnTheFlyServer.cpp Change 4148639 by Ben.Marsh UGS: Fix tooltips not showing for changes that have description badges. Change 4149373 by Ben.Marsh UGS: Allow adding additional columns to display particular badges by adding entries from the project config file. Example syntax: +Columns=(Name="Desktop",MinWidth=50,DesiredWidth=100,Weight=3,Badges="Editor") +Columns=(Name="Mobile",MinWidth=50,DesiredWidth=100,Weight=3,Badges="IOS,Android") Same form can be used to control how default columns are displayed (though badge settings are ignored). Also allow PerforceMonitor to detect local changes to project config files and update settings automatically. Change 4149399 by Ben.Marsh UGS: Update version to 1.143. Change 4155660 by Steve.Robb PROJECTION and PROJECTION_MEMBER macros which provide the correct behavior when creating projections using functions which are overloaded or use default arguments. Change 4157117 by Ben.Marsh Fix warning due to plugins disabled in .target.cs file. Change 4158011 by Ben.Marsh UBT: Add a check that the UnrealHeaderTool target file exists, rather than throwing an exception when reading it fails. Change 4158646 by Ben.Marsh UGS: Fix exception when login is discovered to have expired during a workspace update. Change 4158678 by Ben.Marsh UGS: Fix an exception on shutdown due to the icon being hidden after it's already been disposed. Change 4158683 by Ben.Marsh UGS: Add an unhandled exception filter which sends the exception data to the backend. Change 4159131 by Ben.Marsh UGS: Reduce the number of characters displayed for build badges based on the available space. Change 4159194 by Graeme.Thornton TBA: Fix incorrect map property conversion code when converting an old property that contains a map with different key/value types Change 4159239 by Steve.Robb Improved readability and compliance with coding standards. Change 4159246 by Ben.Marsh UGS: Allow syncing projects where source code is not available (and various version files don't exist). #jira UE-60985 Change 4159286 by Ben.Marsh UGS: Remove requirement for UE4Editor.target.cs to be visible in the depot in order to open a project. #jira UE-60986 Change 4159302 by Ben.Marsh UGS: Update version to 1.144. Change 4160308 by Ben.Marsh All staging client executables for blueprint projects. #jira UE-60983 Change 4161567 by Steve.Robb GitHub #4816 : UE-60771: Handle escaped double quote in FParse::LineExtended Change 4162641 by Ben.Marsh UGS: Allow customizing the position of custom columns, via the Index=N attribute. Change 4162647 by Ben.Marsh UGS: Update version to 1.145. Change 4165319 by Robert.Manuszewski PR #4812: Fix inconsistent command-line argument handling under Windows (Contributed by adamrehn) Change 4166150 by Ben.Marsh UGS: Include *.inl when looking for code changes. Change 4166551 by Steve.Robb Whitespace fixes caused by a bad merge. Change 4168483 by Ben.Marsh UGS: Add a more useful error if a file to be synced exceeds the max allowed path length. Change 4168490 by Ben.Marsh UGS: Update version to 1.146. Change 4168551 by Ben.Marsh UBT: Move bBuildLargeAddressAwareBinary into an exposed setting. Change 4168560 by Ben.Marsh UBT: Remove static config variable for controlling which configuration of UHT to use. Change 4171296 by Ben.Marsh UGS: Move the check for overlong paths earlier. Change 4171531 by Ben.Marsh UBT: Fix exception if BuildConfiguration.xml contains an unknown category. Change 4183371 by Robert.Manuszewski Fix for a crash in Async Loading Graph's CheckCycles when GC kicks in on the game thread and forces ALT to exit early Change 4184312 by Ben.Marsh UGS: Update version to 1.148 Change 4184480 by Robert.Manuszewski Removing unused async loading stat Change 4186390 by Ben.Marsh UBT: Format XML validation errors in a format that allows double-clicking on the message in Visual Studio. Change 4188644 by Ben.Marsh UBT: Add the MakePathSafeToUseWithCommandLine() function to UBT. Change 4188647 by Ben.Marsh UBT: Fix exception in target receipt when architecture is null. Change 4189617 by Ben.Marsh Change FileSystemReference, FileReference and DirectoryReference objects to use OrdinalIgnoreCase comparisons without creating a separate copy of the string to compare. The filesystem does not use the invariant culture, and it can produce the wrong results in some cases (the ordinal comparison is faster, too). Change 4189740 by Ben.Marsh UAT: Remote code to build UnrealPak when packaging; we use the editor now. Change 4189860 by Ben.Marsh UGS: Make the filter for excluding automated lighting rebuilds more explicit. Change 4190082 by Ben.Marsh Fixes to allow enabling edit and continue for Windows builds. Have experienced quite a few VS crashes when testing it in editor; not yet recommended for general use. - Allow edit and continue for any configuration, not just debug. - Fixed PDB errors compiling files that use a shared PCH with edit and continue enabled. Path to the generated PDB file was using the wrong directory. - Removed code that tracks PDB output files, since they're modified multiple times during a build. - Enable debug information when compiling generated CPP files, since it causes errors if the shared PCH PDB doesn't have the same option. - Disable support for remote execution of steps that modify the PDB, since the same file has to be modified many times. Remote execution causes the PDB files to be corrupted. Unfortunately, this makes E&C builds significantly slower. #jira Change 4192949 by Ben.Marsh UBT: Minor tidy-up (merging UEBuildBinary.Build and UEBuildBinary.SetupOutputFiles) Change 4193218 by Ben.Marsh Fix formatting. Change 4197252 by Mike.Erwin UAT: Fix log output w/ correct count of non-code projects. #jira none Change 4197941 by Ben.Marsh UGS: Add support for DebugGame editors that have an executable with a DebugGame suffix. Change 4197964 by Ben.Marsh UGS: Prevent attempts to automatically reopen projects while a modal dialog is up, or the workspace is syncing. Change 4198144 by Ben.Marsh UGS: Prevent modal dialogs when login expires in P4, and prompt for password when hitting "retry". Change 4198413 by Ben.Marsh UGS: Always show the main window when launched manually, and run with -RestoreState when launched at startup. Also add a couple more places that save the visibility state, since logging off seems like it can terminate the process abrubtly. Change 4198779 by Ben.Marsh UBT: Allow generating manifests to any arbitrary locations with the -Manifest=<Path> argument. Change 4198825 by Ben.Marsh UBT: Move code to enumerate Slate runtime dependencies into the Slate module. Doesn't need to be done inside core UBT. Change 4199341 by Ben.Marsh UGS: Update version to 1.149 Change 4199642 by Chad.Garyet - Deprecate CISController - Add BuildController to replace CIS GET/POST for builds - Add LatestController, GET does what CIS/GET used to do - Change Latest/GET to return the last 25 builds filtered by project, rather than the last 5000 individual Ids - Latest/GET now returns "LatestData" object instead of array of longs - Updated EventMonitor to match all API changes - Fixed bug where IDs were getting reset to initial startup values every update loop Change 4199663 by Chad.Garyet CIS controller still needs to return an array of longs #jira none Change 4199680 by Ben.Marsh UGS: Update version to 1.150 Change 4200457 by Ben.Marsh Merging CIS fix for non-development configurations. Change 4200472 by Mike.Erwin UAT: fix -skipbuildclient param default It was defaulting to skipbuildeditor's value, likely a copy-paste error. #jira none Change 4202595 by Ben.Marsh Fix static analysis warning due to constant comparison against macro. Change 4203250 by Ben.Marsh UGS: Always show the "Sync Precompiled Editor" option, but disable it and show a tooltip explaining why if it is not available. Change 4206191 by Ben.Marsh Exclude editor target files from installed builds, since they leak info about DLLs that have been stripped out. Change 4213011 by Ben.Marsh UBT: Include contents of modified intermediate files in the log, to make it easier to debug hidden dependencies. Change 4213487 by Ben.Marsh UBT: Fix assumption that bPrecompile is equivalent to bBuildAllModules. This is no longer the case; they are now controlled by separate options. Should fix CIS errors building the editor. Change 4213609 by Ben.Marsh Ensure that strings formatted using FMicrosoftPlatformString::GetVarArgs() are always null terminated, whether we use the secure CRT or not. Change 4215971 by Ben.Marsh UBT: Remove action graph visualization code; no longer used. Change 4215996 by Ben.Marsh UBT: Remove unqiue id from all actions in the action graph. This is only used for printing debug info in the case of a (rare) cycle in the action graph, so just look it up when needed. Change 4216022 by Ben.Marsh UBT: Rename Crypto.cs to EncryptionAndSigning.cs to match the name of the class inside it, and move it under the System folder. Change 4216031 by Ben.Marsh UBT: Move all the action executors into their own folder in the project. Change 4216526 by Ben.Marsh Fix CIS warnings. Change 4216544 by Ben.Marsh Replace custom code to ensure FMicrosoftPlatformString::GetVarArgs() null terminates its buffer with Microsoft's standards-compliant implementation. Change 4216633 by Ben.Marsh Add support for UnrealPak plugins. * Project and plugin modules can now specify an array of supported programs in the "WhitelistPrograms" field of their module descriptors, to allow modules to be loaded by programs. * Programs can now load any runtime modules, as long as they are whitelisted. * Programs under the engine directory can now use a shared build environment, so that building with a project file does not cause output binaries to be output to the project directory. * UnrealPak is now always built by default when packaging * Convert UnrealPak to a modular configuration Change 4216736 by Ben.Marsh UnrealPak: Move "ExportDependencies" command into an editor commandlet, since it relies on the UObject system, asset registry, etc... Change 4217447 by Ben.Marsh Back out revision 50 from //UE4/Dev-Core/Engine/Build/InstalledEngineBuild.xml Change 4217451 by Ben.Marsh Back out revision 11 from //UE4/Dev-Core/Engine/Plugins/Developer/VisualStudioSourceCodeAccess/Source/VisualStudioSourceCodeAccess/VisualStudioSourceCodeAccess.Build.cs Change 4217617 by Ben.Marsh Back out changelist 4217451 Change 4222552 by Ben.Marsh Don't use #import <TypeLib> for VS source code accessor when building with Clang; it's not supported. Change 4222630 by Ben.Marsh UBT: Fix spam while generating project files if Clang isn't installed. Change 4223316 by Ben.Marsh UBT: Change the order in which Visual C++ toolchains are enumerated to prefer full releases over preview releases. Change 4223318 by Ben.Marsh UBT: Add a build setting which allows creating a dedicated PCH for every file that's excluded from the unity working set (disabled by default). Improves iteration times when working on individual cpp files, but slows down iterating on header changes (and can take a lot of disk space for large changes). Dedicated PCH contains all includes scraped from the top of each cpp file, until a non-#include directive is encountered. Change 4223401 by Ben.Marsh UBT: Add an option to automatically enable edit and continue for files in the adaptive non-unity working set. E&C doesn't seem very useful for UE4 projects right now; compile time is comparable to regular build times, but it can take several minutes to apply code changes for large projects. Change 4223899 by Ben.Marsh UBT: Fix loading XML config files on Mono; Type.GetField(Name) does not seem to return values unless binding flags are specified. Change 4224637 by Ben.Marsh Add a "SupportedPrograms" field to plugin descriptors, which allows plugins to declare which plugins they support independently of individual modules. Programs now respect the "bEnabledByDefault" setting in plugins. Plugins that are compatible with a program now need to list that program in the SupportedPrograms list, and whitelist any modules that should load for that program. Change 4224710 by Ben.Marsh UBT: Don't add import libraries as final build products unless the target is being precompiled. Prevents the need for building them for leaf nodes in the action graph. Change 4224715 by Ben.Marsh UBT: Remove hack to allow Stats2.cpp to not follow IWYU convention. Change 4224726 by Ben.Marsh Remove commented out line. Change 4224903 by Ben.Marsh Fix non-unity compile error in Stats2.h. Change 4225051 by Ben.Marsh Back out changelist 4224710; causing CIS errors due to receipts not matching. Change 4225134 by Ben.Marsh Fixing non-unity errors. Change 4225203 by Ben.Marsh Another non-unity fix. Change 4225249 by Ben.Marsh Fix Linux dependencies being copied for the Windows editor; they can be added as requirements for the Linux target platform on Windows instead, so it respects the user's chosen platforms. #jira UE-62001 Change 4225512 by Ben.Marsh BuildGraph: Allow setting the target to build when using the <CsCompile> task. Change 4228815 by Ben.Marsh UBT: Always add the generated code directory to the list of include paths when generating project files. It may only be created after UHT has been run. Change 4228944 by Ben.Marsh UBT: Remove legacy CppCompileEnvironment and LinkEnvironment wrappers from TargetRules that were deprecated in 4.19. Change 4229028 by Ben.Marsh UBT: Fix editor targets with unique build environment having the wrong executable path in generated project files. Move move logic to configure target rules post-construction by the rules assembly to ensure it's valid. Change 4229065 by Ben.Marsh UBT: Move another target setting into the rules assembly. Change 4229105 by Ben.Marsh Fix BPT exception when generating project files. Change 4229311 by Ben.Marsh UBT: Store the module rules file location on the ModuleRules instance, as well as the plugin that it was created from. Also expose the plugin directory as a property on the ModuleRules instance. Change 4229421 by Ben.Marsh UBT: Consolidate functionality for UHT module setup in ExternalExecution.cs. Change 4229817 by Ben.Marsh UBT: Modules must now explicitly specify the path to the header used to generate a PCH if one is desired, rather than the header being determined automatically by attempting to parse the source code. Now that PCHs are force-included anyway, this removes a lot of dependencies inside UBT. Change 4229824 by Ben.Marsh UBT: Remove unused lists inside UEBuildModuleCPP.SourceFilesClass. Change 4229841 by Ben.Marsh UBT: Remove some legacy code from auto-detecting PCHs. Change 4230521 by Ben.Marsh UBT: Add utility functions to the log class to allow formatting errors and warnings in Visual Studio output format (eg. File(Line): warning: Message) Change 4230871 by Ben.Marsh UAT: Remove StreamUtilis utility class; there is a simpler way to implement the one place it's used. Change 4230882 by Ben.Marsh UAT: Add StreamUtils back into UAT, seems like it's still used there. Change 4230896 by Ben.Marsh UBT: Remove some redundant parameters from UEBuildModule/UEBuildModuleCPP/UEBuildModuleExternal constructors. Change 4231014 by Ben.Marsh WorkspaceTool: Include a dump of raw bytes when garbage is read from the P4 process, for diagnostic purposes. Change 4231032 by Ben.Marsh Fix CIS. Change 4231096 by Ben.Marsh Bump the FlatCPPIncludeDependencyCache version, to prevent errors trying to load old files. Change 4231446 by Ben.Marsh UBT: Added support for expanding UE-specific variables in include paths and library paths: $(EngineDir), $(ProjectDir), $(PluginDir), $(ModuleDir). Change 4231460 by Ben.Marsh Modules may now explicitly specify rpaths on Linux via the PublicRuntimeLibraryPaths and PrivateRuntimeLibraryPaths properties. Change 4233909 by Robert.Manuszewski PR #4779: Reason fails as the supplied variable is incorrect (Contributed by projectgheist) Change 4233910 by Ben.Marsh Enable PCHs on IOS. Reduces build time by ~25%. Change 4234176 by Ben.Marsh UBT: Add better messaging for modules that need to have a private PCH set. Now detects the likely PCH using the same method as legacy code and includes it as a suggestion. Change 4234193 by Ben.Marsh Add the Delete command to Perforce wrapper in DotNETUtilities. Change 4234688 by Ben.Marsh UBT: Simplify handling of installed/precompiled builds. Settings for whether a folder is installed/read-only or not is now stored on the RulesAssembly instance, allowing multiple things to be configured separately and stacked together (eg. engine/enterprise/project). RulesAssembly.IsReadOnly() allows determining if a flie can be modified or not and replaces many previous IsXXXInstalledCalls(), and traverses the chain of assemblies. Change 4234711 by Ben.Marsh UBT: Runtime dependencies can now be copied to output directories as part of the build. When adding a runtime dependency, an optional source location can be specified to copy from. Both the source and target paths can use variables can be used as part of the path, eg. $(OutputDir), $(ModuleDir), $(PluginDir). Example usage (from a .build.cs file): RuntimeDependencies.Add("$(OutputDir)/Foo.dll", "$(PluginDir)/Source/ThirdParty/Foo.dll", StagedFileType.NonUFS); Change 4234872 by Ben.Marsh Expose a flag for whether the engine is installed, to fix issues generating project files. Change 4234929 by Ben.Marsh Fix null reference generating receipts when UBT makefiles are active. Change 4235883 by Chad.Garyet Merging 4231245 to core Giving Coordinator its own sln. This should fix what 4158155 was supposed to. #jira UE-61955 Change 4236075 by Ben.Marsh CIS fix Change 4237066 by Robert.Manuszewski Fix for a potential crash when terminating the engine while it's being initialized #jira UE-60545 Change 4237078 by Robert.Manuszewski The engine will no longer be resetting all linkers causing massive load times when renaming the world package when entering Play In Editor Change 4237116 by Ben.Marsh Rewrite some Windows utility functions to support paths longer than MAX_PATH. Change 4237158 by Ben.Marsh Add const TCHAR* overloads of FString::RemoveFromStart() and FString::RemoveFromEnd(). Change 4237159 by Ben.Marsh Fix FWindowsPlatformFile::GetFilenameOnDisk() support for paths longer than MAX_PATH, and simplify some of the other long path functions to avoid copying string buffers. Change 4239050 by Ben.Marsh Missing file Change 4239318 by Ben.Marsh Linux CIS fix. Change 4239685 by Ben.Marsh Static analysis CIS fix. Change 4240800 by Ben.Marsh WorkspaceTool: Include the full command line in the log for any P4 commands. Change 4240903 by Ben.Marsh PR #4909: Update copyright notices to 2018 (Contributed by projectgheist) Change 4241025 by Ben.Marsh UBT: Exclude mobile pipeline caches from generated project files. Causes huge slowdown when using 'Find in Files' through the IDE. Change 4241770 by Ben.Marsh UBT: Include action number in parallel executor output. #jira UE-62032 Change 4243469 by Ben.Marsh TBA: Merge FAnnotatedStructuredArchiveFormatter with FStructuredArchiveFormatter. Any functions that are only implemented for text archives now have a _TextOnly suffix, and are exposed through the FStructuredArchive interface. Change 4245723 by Robert.Manuszewski Fixing another creash when terminating the engine while initializing. #jira UE-60545 Change 4245862 by Steve.Robb VectorLoadFloat2(Ptr) added, which loads { Ptr[0], Ptr[1], Ptr[0], Ptr[1] } into a VectorRegister. Change 4246412 by Robert.Manuszewski The warning 'Calling StaticLoadObject during PostLoad may result in hitches during streaming' will now also report the object which had the PostLoad called on it when StaticLoadObject call happened. Change 4246612 by Ben.Marsh UBT: Fix spelling of "Intellisense". Change 4249454 by Robert.Manuszewski Added extra checks to catch scenarios where the EDL Precache Buffer is flushed before a package header is fully read Change 4249513 by Robert.Manuszewski Made sure the Async Loading Thread doesn't continue running after creating new async packages when garbage collector wants to run on the game thread Change 4255207 by Ben.Marsh UGS: Add additional logging whenever a P4 command fails, and when the user is logged out. Change 4255288 by Ben.Marsh PR #4921: Honor ModuleRules' bEnableExceptions flag when creating precompiled h. (Contributed by surakin) Change 4256422 by Ben.Marsh UBT: Add an error if a module referenced by a plugin descriptor doesn't exist. Change 4257385 by Robert.Manuszewski Creating new objects from within ForEachObjectWithOuter will now result in a fatal error as it's unsafe to change internal UObject hash tables when iterating over them. Change 4257454 by Robert.Manuszewski Added the option to filter clusters listed with gc.ListClusters by objects within them. Usage: gc.ListClusters Hierachy With=ObjectName1,ObjectName2... Change 4257526 by Robert.Manuszewski It's now possible to filter clusters that get logged with verbose cluster logging enabled (UE_GCCLUSTER_VERBOSE_LOGGING=1) by objects within them by specifying -DumpClustersWithObjects=ObjectName1,ObjectName2 in the command line Change 4257822 by Ben.Marsh Fixes for PlatformShowcase compile errors. Change 4258771 by Ben.Marsh UBT: Fix project files not being generated for foreign projects when creating .stub files. #jira UE-62462 Change 4258790 by Ben.Marsh UBT: Clean up the logic around generating project files before creating a stub IPA, so that it fails loudly if project files do not exist, and can accept target names not matching project names. Change 4259276 by Ben.Marsh UBT: Make it an error if a framework doesn't exist, rather than failing silently. Also remove some remote toolchain stuff that's no longer necessary. Change 4259280 by Ben.Marsh UBT: Fix embedded framework zips not being uploaded for plugins. #jira UE-62485 Change 4260236 by Ben.Marsh UBT: Fix path to generated engine project file. Change 4260334 by Ben.Marsh UGS: Fix custom build steps dialog inadvertantly modifying config file settings in-place. Change 4260361 by Ben.Marsh UGS: Allow for p4 login commands to fail, even though the user is logged in (due to a bad connection, etc...) Change 4260559 by Ben.Marsh UGS: Update version. Change 4261160 by Robert.Manuszewski MediaPlaylist will now be added to root set if the owning MediaPlayer is in the disregard for GC set (fixes GC assumption violation crash) #jira UE-62495 Change 4261421 by Ben.Marsh Force-sync files for building documentation, to fix issues with files not being updated. #jira UE-62413 Change 4261425 by Ben.Marsh UBT: Remove some leftover functions for handling the remote toolchain. Change 4261530 by Ben.Marsh UBT: Speculative fix (and better error reporting) for IOS mobile provision not being found in CIS. Change 4261611 by Ben.Marsh UBT: Downgrade warning to a log message, since it appears when generating project files. Change 4261710 by Ben.Marsh Remove assert that GLogConsole is set; it won't be for command line utilities that don't depend on ApplicationCore. #jira UE-62545 Change 4261831 by Ben.Marsh Fix compile errors due to missing include path when hot-reloading a module from the editor. There are not necessarily source files to compile when -modulewithsuffix is specified on the command line, which was results in GeneratedCodeWildcard not being set. #jira UE-62463, UE-62384 Change 4262723 by Ben.Marsh Whitelist plugins that need to be loaded by UFE. #jira UE-62564 Change 4265444 by Ben.Marsh Fix incorrect executable name for DebugGame configurations in Xcode. #jira UE-62574 Change 4265892 by Ben.Marsh Fix incremental compile failures due to dependency checking for unity files. CachedIncludePaths was not correctly being set on file items, so dependencies were being ignored. #jira UE-62575, UE-62603, UE-62597 Change 4266019 by Josh.Adams - Fixed the CopyAction for runtime dependencies that need to be copied to different location, on non-XGE Change 4266264 by Ben.Marsh Remove override for the __IPHONE_OS_VERSION_MIN_REQUIRED macro on TVOS. This macro is already defined by system headers (in <AvailabilityInternal.h>). Now that we support PCHs on IOS and TVOS, manually defining this macro results in it being defined three times (once for the PCH, once by AvailabilityInternal.h, and once by the force-included list of definitions for the source file being built). The errors for redefining the macro in AvailabilityInternal.h are suppressed due to it being a system header, but the error for redefining it for the source file being compiled are not. #jira UE-62578 Change 4266273 by Ben.Marsh Fixes incremental build failure when compile arguments for PCH have changed on IOS/TVOS. Compile action needs to have a dependency on PCH build action. Change 4266614 by Graeme.Thornton Fix crash when cooking nativized blueprints due to removal of child cooker system. Change 4266763 by Ben.Marsh Always build UnrealPak when building client targets. The ProjectParams.Pak option is not reliable, because it can be forced on later by the target platform. #jira UE-62584 Change 4267985 by Robert.Manuszewski When iterating with ForEachObjectWithouter, don't lock the entire has table but only the hash bucket that is currently being iterated #jira UE-62600 Change 4268558 by Robert.Manuszewski PurgeLegacyBlueprints will no longer be called from within ForEachObjectWithOuter is it renames objects that reside in hash tables that are being iterated over which may lead to undefined behavior. #jira UE-62600 Change 4269011 by Chad.Garyet - Fixing Wildcard match issue, the change to ugsapi sends projects as //Depot/Stream instead of //Depot/Stream/ Wildcard match was only substringing to 3 chars. - Checking in the change a while back that increases the number of queried jobs up to 432 based on some maths from Bob about how many builds we want to grab Published to ugsapi server 8/8/17 #jira none Change 4270788 by Ben.Marsh Fix IOS provisioning data being using when remote compiling on TVOS. #jira UE-62705 Change 4271916 by Ben.Marsh Tag the XGEControlWorker executable as a build product after compiling SCW, to make sure it's included in the UGS zip file. Change 4271934 by Ben.Marsh Upload all static libraries in plugin folders as part of remote builds. #jira UE-62694 Change 4273368 by Ben.Marsh Fix Slate dependencies not being enumerated, and rules assembly not being rebuilt when building remotely. #jira UE-62705 Change 4274049 by Ben.Marsh Always parse the team UUID out of the mobile provision when doing a remote compile. The provision installed on the remote Mac (and selected for signing) may be different. #jira UE-62751 Change 4274823 by Ben.Marsh Add the -VersionCookedContent argument to disable the -unversioned parameter on the cooker command line. Change 4275838 by Ben.Marsh Fix BuildVersion string not being passed through from <SetVersion> task. Also add a -BuildVersion command line argument to UBT to override it for a particular build. Change 4275913 by Ben.Marsh Add a dummy exported symbol to the XGEController module, to fix build errors due to missing .lib file when it's built with WITH_XGE_CONTROLLER = 0. Change 4284161 by Ben.Marsh Allow mirroring Oodle files to remote Mac. Change 4074774 by Steve.Robb Vast simplification of TFunction, making it smaller in footprint, easier to follow and extend, and more correct. TUniqueFunction added, which is a move-only TFunction which can hold move-only functors. Fix for UWidgetBlueprint::ForEachSourceWidget() which should never have compiled but did. FFunctionGraphTask and TFuture<> updated to use TUniqueFunction to make them more general. TArray::HeapPop() made to work with move-only types. Change 4082591 by Ben.Marsh Move the Log class from UBT to DotNetUtilities. Change 4083236 by Ben.Marsh Add a Log.WriteException() method to dump an exception message to the console (and write the exception trace to the log) Change 4084107 by Ben.Marsh UAT: Remove the unused -SkipHeader argument to UE4Build. Change 4089771 by Steve.Robb GitHub #4743 : modified VirtualAlloc function flag https://blogs.msdn.microsoft.com/oldnewthing/20151008-00/?p=91411 Change 4091456 by Steve.Robb Unification of all platforms' FMath::CountTrailingZeros() and FMath::CountLeadingZeros() for both 32-bit and 64-bit. Change 4156437 by Ben.Marsh Lots and lots of fixes compiling for Clang on Windows. Editor now compiles cleanly without warnings, but crashes on startup due to error in intrinsics test. Disabling that runs further, but crashes accessing freed memory. Switching to the ANSI allocator runs further, but crashes in Slate after the splash screen and before the editor window opens. // TODO! * Switching between Clang/ICL/VS2015/VS2017 is now supported through the same mechanism as switching Visual Studio versions, without requiring any source level changes. To use Clang, set WindowsPlatform.Compiler = WindowsCompiler.Clang from a .target.cs file, or set <WindowsPlatform><Compiler>Clang</Compiler></WindowsPlatform> from BuildConfiguration.xml. To pick a specific toolchain version, set WindowsPlatform.CompilerVersion. * Clang is now supported through AutoSDKs; will be added to CIS. * The Samples/Sandbox/Clang project forces Clang to be used from its target.cs file, and allows easily building all editor modules and plugins with Clang on Windows. * UnrealMathSSE intrinsics have been re-enabled for Clang due to missing functions from the UnrealMathFPU implementation, but causes failure in tests at startup. * SSE4_CRC32() is disabled in D3D12Pipelinestate.cpp, since intrinsics are only allowed if enabled for the whole target (rather than being used in specific functions due to runtime checks) Change 4157389 by Ben.Marsh Few more fixes for compiling the editor with Clang. Change 4183911 by Ben.Marsh Fixes to support incremental linking on Windows. Does not seem to have any net benefit right now; may improve once minimal rebuild is enabled. * Incremental linking no longer forces PDB files to be enabled for source files. * Actions can specify specific files to be deleted before each build. Code to forcibly delete PDB files has been moved to the MSVC toolchain. * Unused libraries produced by the cross-referenced link are no longer added as build products, since (a) deleting them breaks dependency checking for incremental linking and causes a full link, and (b) not deleting them breaks UBT dependency checking and causes actions to be run over and over again. * Icon update is disabled for Windows when incremental linking is enabled. * Removed rarely-used setting to always delete produced items before each build. Change 4184311 by Ben.Marsh UGS: Added a dialog which shows all the required platform SDKs for a branch, linked from the status panel in UGS. The llist is configured via the UGS config file submitted to Engine/Programs/UnrealGameSync/UnrealGameSync.ini (and may be overridden by the project config file if necessary): [Default] ; Set this to a network share which contains the SDK installers for your site SdkInstallerDir= ; All the required SDKs for the current version of the engine +SdkInfo=(Category="Android", Description="NDK r21", Browse="$(SdkInstallerDir)\\Android") +SdkInfo=(Category="Windows", Description="Visual Studio 2017") +SdkInfo=(Category="Windows", Description="Visual C++ Toolchain 14.13.26128") +SdkInfo=(Category="Windows", Description="Windows SDK 10.0.16299.0") Similar entries for console platforms are added in console subdirectories. Each entry may contain an Install="Foo.exe" and/or Browse="C:\Foo" style attribute, specifying the path to an installer to run or directory to open in explorer respectively. The SdkInstallerDir setting is used as a base directory for the default installers, seen above for Android. Licensees may override this with a network path specific to the site that UGS is being deployed to (either in this file, in a project specific config file, or in a Engine/Programs/UnrealGameSync/NotForLicensees/UnrealGameSync.ini file). Change 4200452 by Ben.Marsh UBT: Change DebugGame configurations to output a separate executable rather than requiring a -Debug argument at runtime. Previous behavior was a common source of errors. Engine modules are still shared between Development and DebugGame, but the launch module sets a flag in Core on startup indicating the game configuration. Change 4206189 by Ben.Marsh UBT: Simplify logic for precompiling binaries. * Target no longer has separate list of "precompile only" binaries or modules. New -AllModules option allows adding every module to a target, which can be used with -Precompile and -NoLink to precompile object files for monolithic builds. * Precompiled file lists have been removed from target receipts. * The manifest now includes all generated headers and precompiled files when run with the -Precompile option. * Separate -DependencyList=Foo.txt has been added to write a list of all dependencies required to use precompiled binaries. This file list can be read using the <Tag> task in buildgraph. Change 4215466 by Ben.Marsh UBT: Remove indirect calls to determine extensions for object files and precompiled headers. The toolchain knows the correct convention for the platform. Change 4215975 by Ben.Marsh UBT: Remove telemetry code. This has never proved useful for analyzing performance due to the number of incidental factors that affect build times (eg. number of files being compiled). Change 4220154 by Ben.Marsh Move text-only implementations of FOutputDeviceError back into Core, so we can build command-line applications that don't depend on ApplicationCore. Change 4224708 by Ben.Marsh Add a bCompileAgainstApplicationCore setting to the target rules, which allows compiling out references to the ApplicationCore module (which should only be necessary for applications with a GUI). Removed ApplicationCore from several engine tools and utilities. Change 4224958 by Ben.Marsh Remove CoreMinimal.h includes from Core. Change 4229059 by Ben.Marsh UBT: Remove the UEBuildPlatform.ShouldNotBuildEditor() hook for target platforms. We shouldn't be modifying a target's build environment to disable the editor; it is invalid to build the editor for these target platforms at all, and this is already enforced by the GetSupportedPlatforms() function. Change 4230508 by Ben.Marsh Fixup precompiled header setting for samples and games. Change 4231457 by Ben.Marsh Fix exceptions in log messages having trailing newlines. Change 4232406 by Ben.Marsh UBT: Always force include a PCH for generated code if there's one set; the code may depend on it to compile. Change 4234177 by Ben.Marsh Set up private PCH files everywhere that previously used them. Change 4235973 by Ben.Marsh Change FPlatformMisc::GetEnvironmentVariable() to return an FString() rather than requiring a fixed size buffer to be passed in. Removes references to MAX_PATH. Change 4238842 by Ben.Marsh Add support for paths longer than MAX_PATH in the editor. Requires Windows 10 version 1607, and the functionality to be enabled via a registry key or group policy (see https://docs.microsoft.com/en-us/windows/desktop/FileIO/naming-a-file). Only a subset of Win32 functions support long paths (executables can only be started from paths shorter than MAX_PATH, for example). * Added a FPlatformMisc::GetMaxPathLength() function to return the maximum length of a path on the current system. On Windows, this returns a different value for systems with long paths enabled to those without. * The MAX_PATH define is no longer set by non-Windows platforms. Instead, there is a MAC_MAX_PATH, UNIX_MAX_PATH, etc... for any platform-specific code that still relies on the previous macro. * The MAX_UNREAL_FILENAME_LENGTH macro has been renamed to MAX_UNREAL_FILENAME_LENGTH_DEPRECATED * The PLATFORM_MAX_FILEPATH_LENGTH macro has been renamed to PLATFORM_MAX_FILEPATH_LENGTH_DEPRECATED. * Removed custom resource files for programs, since they are just copies of the base UE4 one (which is used by default anyway). The base UE4 manifest declares support for long paths. * Fix 512 character maximum length on editor commands. 260 character limit remains in place for cooking at the moment (see ContentBrowserUtils.h), until C# staging code supports long paths. Change 4255042 by Ben.Marsh UBT: Remote compilation now uploads the entire workspace to the remote Mac and executes a separate remote instance of UBT rather than synchronizing individual actions. This makes the remote compile codepath much simpler, and removes a lot of special cases that exist to support it previously. The list of files to be transferred to the remote are listed as rsync filter rules in Engine/Build/Rsync/RsyncEngine.txt and RsyncProject.txt, which are applied to the root engine directory and project directory respectively. Projects that need to customize which files are uploaded can add their own <ProjectDir>/Build/Rsync/RsyncProject.txt file, which will be included in the filter before the default version. Change 4260567 by Ben.Marsh UAT: Rename CommandUtils.Log to CommandUtils.LogInformation, to avoid conflicts with the underlying Tools.DotNETCommon.Log class. #rb none [CL 4285673 by Ben Marsh in Main branch]
2018-08-14 18:32:34 -04:00
LogInformation("Starting Extra Client....");
OtherClients.Add(Run(ClientApp, ClientCmdLine, null, ClientRunFlags | ERunOptions.NoWaitForExit));
}
}
while (!FileExists(ClientLogFile) && !ClientProcess.HasExited)
{
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 4285612) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3836829 by Ben.Marsh UBT: Fix ability to precompile plugins from installed engine builds. Change 3839519 by Ben.Marsh UBT: Simplify configuring bPrecompile and bUsePrecompile settings for modules. Each rules assembly can now be configured as installed, which defaults the module rules it creates to use precompiled data. Change 4042043 by Steve.Robb GitHub #4705 : Added weak lambda's for delegates and multicast delegates. Change 4042056 by Robert.Manuszewski Optimized Mark Phase of GC by up to 10ms by making it run in parallel and removing a huge array presize which we didn't need. Change 4042104 by Robert.Manuszewski Set the minimum GC cluster size to 5 so that GC doesn't have to process micro clusters which are more expensive than processing individual objects + Exposed the minimum cluster size to ini and project settings as gc.MinGCClusterSize + Added the ability to sort clusters by name/object count/mutable object count/referenced clusters count when dumping them with gc.ListClusters command Change 4042377 by Robert.Manuszewski Reworked how GC and other threads (ALT specifically) interact - GC will now notify the ALT it wants to run and ALT will immediately try to finish its current work to allow that. Also the entire ALT tick is now protected against GC running at the same time to improve ALT stability. + added gc.ForceCollectGarbageEveryFrame console variable that triggers a forced GC every frame Change 4042427 by Robert.Manuszewski Changed FGCCSyncObject to use events when waiting for GC to finish so that it doesn't spin on non-game threads when GC is running Change 4042482 by Robert.Manuszewski Unhashing unreachable objects (ConditionalBeginDestroy) will now also be done incrementally, just like the purge phase of Garbage Collection Change 4042635 by Robert.Manuszewski Fix for a potential assert when incremental purge garbage is pending and something forces a full purge Change 4044092 by Steve.Robb Fix for forward declared CoreUObject weakobject types in delegates when building in Clang. Change 4044102 by Robert.Manuszewski Fix for a possible hang when worker threads are preventing GC from running and something is later trying to FlushAsyncLoading with the Async Loading Thread enabled Change 4044113 by Steve.Robb Another Clang fix. Change 4044160 by Robert.Manuszewski Disregard For GC pool will now be enabled by default in cooked builds Change 4044287 by Steve.Robb Typo fix. Change 4047723 by Graeme.Thornton TBA: Fixes for import/export name cache and object resolving Change 4048015 by Graeme.Thornton TBA: Weak/Soft/Lazy pointer serialization changes * Remove FWeakObjectPtr::Serialize, move it's logic into, and replace usages of with calls to, FArchiveUObject::SerializeWeakObjectPtr(). Ensures that something is always sent to the archive so that structured archives can be kept happy in the future. * Added Weak/Soft/Lazy pointer handling to the structured archive slot interface and all the formatters. Binary formatters just forward the call onto their inner and text archives store as a string path reference. * FArchiveUObjectFromStructuredArchive caches all these pointer types and stores indices in the binary block, same as with a UObject*. All pointers are then forwarded to the underlying formatter in one go on finalization. Change 4048021 by Steve.Robb Fix for binding an unbound TFunction to another TFunction with a different signature. Also all null pointers now count as unbindings, not just nullptr. TIsMemberPointer added. TIsATFunction and TIsATFunctionRef renamed to remove the 'A's. Change 4048544 by Robert.Manuszewski Fixing ConditionalBeginDestroy profiling after changes to incremental CBD. Change 4051028 by Graeme.Thornton TBA: ArchiveFromStructuredArchive adapter uses Inner to determine if it is outputting to text, and sets it's own ArIsTextFormat to false Change 4051056 by Graeme.Thornton TBA: High level tagged property / UObject base class text serialization - UObject serialize converted to structured archive - Properties written to text individually with text tags, and then binary adapted values - Only saves, doesn't load Change 4051111 by Graeme.Thornton TBA: Temporarily disable loading of text assets until tagged property serialization path is fixed up Change 4051154 by Graeme.Thornton TBA: Convert a few uobject serializers to structured archive format for example purposes Change 4051181 by Graeme.Thornton TBA: Added default structured archive implementation of SerializeItem to UProperty, which just calls the FArchive version on an FArchiveUObjectFromStructuredArchive adapter. Implemented structured archive SerializeItem for UArrayProperty Change 4051197 by Graeme.Thornton TBA: ObjectProperty text serialization Change 4051216 by Graeme.Thornton Restored a modified FWeakObjectPtr::Serialize function to keep backwards compatibility in code I don't have access to. Change 4051261 by Graeme.Thornton TBA: Convert UMetaData to structured archive Change 4051374 by Steve.Robb Incorrect assert removed. Change 4051562 by Robert.Manuszewski Adding stats for the new GC internal functions Change 4051614 by Graeme.Thornton TBA: Removed UProperty::SerializeItem(FArchive, ...) and replaced with UProperty::SerializeItem(FStructuredArchive::FSlot, ...). Fixed up most of them to work properly and added adapters in for any that were non-trivial. Change 4052512 by Graeme.Thornton TBA: Temporary workaround for softobjectptr and lazyobjectptr uproperties not serialization anything when they know the archive is a reference collector. They should always be serializing their pointers and letting the underlying archive itself ignore them. Change 4053917 by Robert.Manuszewski Clustered objects from clusters that are no longer reachable will now be marked as unreachable immediately when gathering unreachable objects Change 4053919 by Robert.Manuszewski Added the ability to disable incremental BeginDestroy in ini/project settings Change 4055518 by Daniel.Lamb Fixup for deterministic audio generation issue. Submitted on behalf of Rich.Whitehouse #jira nojira #test prefilght automated test. Change 4056854 by Graeme.Thornton TBA: Added a test asset to EngineTest which contains all the different property types and test cases. Change 4056858 by Graeme.Thornton TBA: Updated USetProperty to proper structured archive usage Change 4056872 by Graeme.Thornton TBA: Add map property field to test object Change 4056873 by Graeme.Thornton TBA: Convert UMapProperty to full structured archive Change 4056994 by Graeme.Thornton TBA: Converted FText over to structured archive. Implemented saving, but not loading. Change 4059728 by Ben.Marsh UBT: Add support for using adaptive non-unity builds when the engine and project are in separate repositories. Change 4059805 by Graeme.Thornton Fixed typo in text serialization. Fixes CIS automation test errors Change 4060007 by Graeme.Thornton TBA: FArchiveFromStructuredArchive will now access it's host slot lazily, i.e. only when a value is actually written to the archive. Change 4060092 by Stefan.Boberg Added optimized Windows console window output path to GenericConsoleOutput since this slowed down cooking considerably (2 minutes spent in wprintf alone for one large dataset) When stdout is attached to a console we use the WriteConsoleW function instead of wprintf since the latter is very slow especially in unbuffered mode which the engine currently configures for stdout (see setvbuf call in LaunchEngineLoop.cpp). At some point we should reconsider this buffering policy since it's likely to slow down other platforms as well but I wanted to do a safe change for now as I don't yet fully understand why the setvbuf call is there in the first place. Change 4060108 by Stefan.Boberg Introduced some additional target platform utilities to help with asset cook optimizations * We now assign each ITargetPlatform a zero-based ordinal value * Introduced FTargetPlatform and FTargetPlatformSet types to help store platform references and platform sets efficiently. These are not currently used in the engine but are designed to replace the existing ITargetPlatform/string/FName representations in the cooking data structures. Change 4060143 by Graeme.Thornton Undo //UE4/Dev-Core/Engine/Source/Runtime/... changelist 4060007 Needs some other changes that I haven't checked in yet... Change 4062432 by Ben.Marsh Fix error message when enumerating P4 changes. Change 4062648 by Ben.Marsh Add missing p4 integration action. Change 4063620 by Graeme.Thornton Integrated a fix from UDN where the engine would crash when trying to load a very small encrypted file (<16bytes) from a pak file, where the read address wasn't already aligned to the AES block size. (https://udn.unrealengine.com/questions/431989/crash-while-reading-a-very-small-file-in-encrypted.html) Change 4066963 by Robert.Manuszewski Fixing GC cluster verification code reporting false positives when a cluster is referencing another cluster through 'mutable' objects list. Change 4067133 by Robert.Manuszewski Changed log verbosity when reporting individual cases of GC cluster assumption violations as they are followed by an asser anyway and this way we get the chance to see all issues before we assert at the end of these checks. Change 4067443 by Steve.Robb FString can now be constructed from any char pointer type and length. Change 4068156 by Steve.Robb Fix necessary because of FString constructor change in CL# 4067443. Change 4070258 by Graeme.Thornton Fixes for VSCode Change 4070372 by Graeme.Thornton TBA: Script struct serialization to structured archives Change 4071913 by Ben.Marsh Move bulk of the code for UnrealPak into an engine developer module, so it can be used in the editor. Change 4071914 by Ben.Marsh Missing files. Change 4071937 by Ben.Marsh Missing header. Change 4072015 by Ben.Marsh Fixes for compiling PakFileUtilities as part of the editor. Change 4072826 by Steve.Robb TBitArray::Reserve() added. TBitArray::Add() overloaded to allow adding multiple bits. TSparseArray::Reserve() optimized to call the overloaded Add(). Change 4073271 by Daniel.Lamb Fixed add patch tier in project launcher passing the wrong commandline option to UAT. #test none Change 4074708 by James.Hopkin #core Removed redundant Casts Change 4074763 by Steve.Robb Fix for TSparseArray::Reserve() size. Change 4076063 by Ben.Marsh Add an "UnrealPak" commandlet with the same functionality as the standalone UnrealPak program. Invoke by running the editor with -run=UnrealPak and the standard UnrealPak commandline options. Change 4077064 by Robert.Manuszewski Fixing compile error in PakFileUtilities Change 4077144 by Graeme.Thornton TBA: TextAssetCommandlet improvements * Collect lists of broken assets during roundtrip tests and print a summary of packages that failed each phase at the end * After resaving as text, load the file back as a plain JSON hierarchy to ensure the output was valid Change 4077412 by Ben.Marsh Set the correct exit code for UnrealPak. Should return 0 on success, not 1. Change 4077760 by Graeme.Thornton TBA: Loading fixed for tagged property serialization Includes conversion of all UProperty::ConvertFromType() and SerializeFromMismatchedTag() functions to use structured archives Lazy initialization of FArchiveFromStructruredArchive when loading, to support the possibility of an adapter being create around an object property serialize call to its inner UStruct, which then decides not to do anything and return false. Stops the ArchiveFromStructuredArchive from consuming the slot and getting upset later on when we try to serialize normal tagged properties from it. Disabled lazy bulk data loading from text assets. Requires a bigger change to make it work. Added some debug checks to json input formatter which track the current value stack size when a new object is pushed onto the stack, and makes sure that the stack has returned to the same size when the object is popped. Catches cases where we unpack an array/stream to the value stack but then don't consume all the items. Change 4078800 by Ben.Marsh Change UAT to using the editor's UnrealPak commandlet rather than invoking the standalone UnrealPak executable. To improve performance when building several PAK files, also add a new -batch=<file> command which reads commands to execute in parallel from a text file. Change 4079745 by Graeme.Thornton TBA: Migrated a couple of UObject Serialize functions to FStructuredArchive (SoundCue / MaterialExpressions / Editor strip flags) Change 4079847 by Graeme.Thornton TBA: Add 'FindMismatchedSerializers' mode to text asset commandlet, which dumps out a list of all UClasses which don't have the CLASS_MatchedSerializers flag, meaning we can't guarantee the have Serialize functions for FArchive AND FStructuredArchive, therefore we can't use the new structured archive based serialize path. Should only ever be native instrinsic classes as UHT takes care of all other cases. Change 4079925 by Ben.Marsh Fix incorrect assignment when deriving name for chunked pak file. Change 4080214 by Ben.Marsh Move the ThreadPoolWorkQueue class into DotNETUtilities so it can be used by other projects. Change 4082394 by Graeme.Thornton CIS fix for variable shadowing warning Change 4082583 by Ben.Marsh Add a IBinarySerializable interface for types that support reading from a BinaryReader and writing to a BinaryWriter. Implementing IBinarySerializable implies a constructor taking a BinaryReader argument is available for deserializing. Change 4082652 by Ben.Marsh Fix FileReference.Directory not returning a directory with a trailing backslash for files in the root directory. Change 4082755 by Graeme.Thornton Fixed an erroneous usage of TUniquePtr<uint8>as a pointer to a uint8 array when creating pak files. Caused a crash when compression was enabled, and has probably surfaced because pak generation is now done by an editor commandlet rather than a standalone program. Change 4082756 by Graeme.Thornton Fixed some incorrect documentation for pakfile compressed chunk headers Change 4082883 by Graeme.Thornton Static analysis warning fix Change 4082912 by Ben.Marsh Move ExceptionUtils into DotNETUtilities. Change 4085291 by Graeme.Thornton TBA: In the Json output formatter, write float and double values out with enough precision for successful roundtripping. Added some debug only code which will immediately reconvert the string back to its original value and compare the the input Change 4085523 by Graeme.Thornton TBA: Remove only explicit usage of DECLARE_FSTRUCTUREDARCHIVE_SERIALIZER. Should only be used from UHT generated code. Change 4086037 by Robert.Manuszewski Fix for a potential race condition when two threads want to acquire GC lock Change 4088655 by Graeme.Thornton Pak creation now uses the bEnablePakSigning setting from the crypto config json file Change 4091474 by Steve.Robb Fix for TStaticBitArray::FindFirstSetBit() and TStaticBitArray::FindFirstClearBit(). Unused variables removed. Change 4093632 by Steve.Robb CIS fixes. Change 4093656 by Graeme.Thornton Build fix Change 4093744 by Ben.Marsh Allow per-chunk settings for whether to enable compression in UnrealPak. Change 4099712 by Gil.Gribb UE4 - Fixed rare case where insufficient space was preallocated for cooldown ticks. #jira UE-59686 Change 4099912 by Stefan.Boberg Cooking timer optimizations: - Replaced data structures for FScopeTimer and FHierarchicalTimerInfo. Previous implementation used FString for many things and caused *lots* of heap and string concatenation activity. Replaced with a compile-time node id (using __COUNTER__) and raw string literals. - Removed PERPACKAGE_TIMER support (was disabled by default and was difficult to test) - Made it possible to toggle OUTPUT_TIMING and ENABLE_COOK_STATS independently - Removed some extremely tight timers because the overhead from calling QPC significantly exceeded the measured code This change shaved some 15% off a clean cook of Fortnite WindowsClient (en) with fully populated local DDC Change 4100519 by Stefan.Boberg Quick fix for Linux build issue introduced in 4099927 Change 4105327 by Stefan.Boberg Cooker: Changed FHierarchicalTimerInfo so it uses a linked list for tracking child nodes, to be able to deal with any child count. Previously we assumed there would never be more than 9 children but it turns out there are cooker modes that need more. Fixes check when using -FullLoadAndSave to cook Change 4105448 by Stefan.Boberg - Fixed Linux build warning re: member initialization order - Also eliminated OUTPUT_HIERARCHYTIMERS/CLEAR_HIEARCHYTIMERS macros (plain functions are fine) - Moved finishing-up code for FullLoadAndSave() to TickCookOnTheSide() call site to improve timer output. Previously some of the scopes would not have been closed before printing and thus the output was misleading. Change 4109031 by Ben.Marsh Attribute-driven Perforce wrapper (old Epic Friday project). Offers a more complete implementation than the current P4 wrapper in UAT without requiring any platform-specific libraries. Uses the Python binary output for parsing. Change 4109588 by Ben.Marsh UBT: Add extension methods for serializing a nullable type to a BinaryReader/BinaryWriter. Change 4109595 by Ben.Marsh Missing project file for DotNETUtilities. Change 4110724 by Stefan.Boberg Removed annotation map locking in UObjectMarks, eliminating around one minute (~3.5%) from Fortnite cook time. The locking was redundant since the annotation maps are managed per thread anyway. Change 4111304 by Ben.Marsh UAT: Add support for setting a status message through the log class. Allows writing transient messages (eg. progress messages) which will be cleared out before writing other messages. Best used through the LogStatusScope class, which can set a status message for the duration of a using() block. As part of this change, the console no longer has to be added as a dedicated trace listener. Since we already special-case this listener when formatting log output, it's easier to just keep the implementation separate to the other trace listeners. Change 4112708 by Steve.Robb Fix for TBitArray::MaxBits in assignment. Change 4114133 by Stefan.Boberg Tweaked how low-level memory (LLM) tracker is implemented to reduce overheads. Previously FMemory functions would acquire the LLM singleton and call OnLowLevelFree/OnLowLevelAlloc etc which would check the bIsDisabled flag and early out if it was set. Due to how frequently these functions were called this ended up costing quite a bit. - This change makes the flag a static member variable instead of a member variable and therefore enables a simpler early-out to be implemented. - The singleton getter is also simplified to avoid hitting the threadsafe singleton construction path on every call. - The enable flag is no longer TAtomic - this also incurs extra overhead for no clear benefit Shaves approximately 3.5% (one minute) off a Fortnite cook test scenario (using -FullLoadAndSave) Change 4115010 by Robert.Manuszewski Fixing CIS Change 4115249 by Robert.Manuszewski Fixing async loading code asserts when exiting game very early due to an error #jira UE-56267 Change 4117091 by Ben.Marsh Prevent doubled-up lines when writing status updates with console log verbosity. Change 4117207 by Ben.Marsh UGS: Do not include executables in diagnostics zip file, and ignore "no such files" error when cleaning workspace. Change 4119175 by Ben.Marsh UGS: Fix crash writing version files when directory does not already exist. Change 4119987 by Ben.Marsh UGS: Show a dialog box while the launcher is updating executables from Perforce, which allows cancelling the operation if necessary. Allow setting the username on the settings window, and prompt for login credentials if necessary. Should prevent situations where users have to update settings from the command prompt. Holding down shift during launch now shows the settings dialog rather than an immediate prompt to launch the unstable version (unstable version is shown as a checkbox on this dialog). Change 4119991 by Ben.Marsh Update version number for UGS launcher to 1.13. Change 4121943 by Robert.Manuszewski Don't use FArchiveAsync2 for reading packages with non-async path in editor builds as its performance is worse than the standard archive's (saves about 1 minute when doing larger cooks and 7 seconds when loading into PIE) Change 4122592 by Steve.Robb GitHub #4762 : Improve wording and grammar of Math comments Also includes improved accuracy in FMath::ComputeBoundingSphereForCone(). Change 4122819 by Stefan.Boberg Don't call CreateDirectory redundantly when opening files for writing using FFileManagerGeneric::CreateFileWriter This change avoids calling IPlatformFile::CreateDirectoryTree if possible since this is a very expensive function especially for deep hierarchies as it performs directory creation from the root directory onwards instead of from the leaf downwards. That function should also be fixed but this change improves performance in the meantime. Change 4122872 by Stefan.Boberg CreateDirectoryTree now creates directories leaf-to-root instead of the other way around. This is much more efficient since we don't spend time on system API calls for directories which already exist. This accounted for a very large amount of CPU time in cooking as the full target file directory hierarchy would be "created" for every single output file. Change 4123109 by Stefan.Boberg - Disable overlapped I/O in editor / cooker. Synchronous I/O reduces the number of syscalls and Windows performs prefetching on our behalf anyway for sequential reads - Eliminated syscall which was issued for every write to update cached file size -- since we're the only writers to the file (file access allows read sharing at most) we can authoritatively update the file size on write completion Change 4123455 by Ben.Marsh PR #4775: New build param PCHMemoryAllocationFactor to set /Zm VS build param. (Contributed by lucaswall) Change 4124207 by Ben.Marsh UBT: Remove some unnecessary indirection for generated code paths. Change 4124217 by Ben.Marsh UBT: Remove another unused variable from UEBuildModuleCPP. Change 4124377 by Stefan.Boberg In IPlatformFile::DeleteDirectoryRecursively, attempt to delete file first and if it fails clear the readonly flag and try again Previously there was a call to clear the readonly flag for every deleted file and this is a waste of resources 99% of the time. The SetFileAttributes call accounted for a significant amount of time during cooker sandbox directory deletion Change 4125071 by Stefan.Boberg Some tweaks to FQueuedThreadPoolBase scheduling and memory management - Explicitly pass in false for TArray::RemoveAt(..., bool bAllowShrinking) argument to prevent memory reallocation when arrays are drained and inevitably repopulated shortly afterwards - Use a MRU strategy instead of LRU when picking a thread to wake up. The MRU thread is the most likely to have a 'hot' cache for the stack etc. Picking from the back of the array also happens to be cheaper since no memory movement is necessary when RemoveAt is called. (This was the strategy in place before CL2600362 which seems to have changed it unintentionally) - Release lock as soon as a thread has been chosen, before asking the worker thread to wake up and do the work Change 4126132 by Ben.Marsh UAT: Detect when stdout is redirected and prevent using backspace characters to move the cursor. Change 4126867 by Graeme.Thornton TBA: Fix tagged binary formatter Change 4127010 by Robert.Manuszewski AnimScriptInstances created at runtime will now also be added to the owning omponent's cluster to avoid GC issues. Change 4127932 by Ben.Marsh WorkspaceTool: Reduce unnecessary logging of status messages when console output is not redirected. Change 4129050 by Ben.Marsh UGS: Check for NET Framework 4.5 being installed before running the installer. Also fix warning trying to kill existing UGS instances before upgrade. Change 4129459 by Graeme.Thornton TBA: TextAssetCommandlet - When outputting converted assets to an output path, replicate the workspace relative path in the output directory Change 4129515 by Graeme.Thornton TBA: Add EnterRecord overload that allows outputting of available field names when loading. Change 4129517 by Graeme.Thornton TBA: Tagged properties are written out as named fields on the "Properties" record, rather than as a stream with a null tag at the end Change 4129518 by Graeme.Thornton TBA: Added a local const bool to allow easy hacking out of text asset loading support Change 4129558 by Graeme.Thornton TBA: Build fix for textasset-less configs Change 4129614 by Ben.Marsh UGS: Main window is now restored to normal size when activated by clicking on the tray icon. #jira UE-60490 Change 4129618 by Ben.Marsh UGS: Speculative fix for unreproduced exception accessing disposed window while shutting down. Change 4131936 by Robert.Manuszewski Removing some WIP code accidentally checked in with CL #4121943 Change 4133490 by Ben.Marsh UGS: Allow the $(Change) variable to be used in more places than just the context menu. #jira UE-60573 Change 4133550 by Ben.Marsh UGS: Setting for whether or not to use incremental builds is now exposed through the variable "$(UseIncrementalBuilds)" for use by custom build steps. #jira UE-60554 Change 4133681 by Ben.Marsh UGS: A per-project list of folders and extensions to be deleted by default when running the 'clean workspace' tool can now be specified through the <ProjectDir>/Build/UnrealGameSync.ini file. Settings may be specified for an individual branch (via a category with the depot path to the project) or for wherever the project is currently open (via the [Default] category). The SafeToDeleteFolders list specifies a substring that will be checked against folder paths. Anything containing this folder will be marked as safe for delete by default. The SafeToDeleteExtensions list specifies a list of extensions for files that can always be deleted. Example: [Default] +SafeToDeleteFolders=/MyGame/Test/ +SafeToDeleteFolders=/DataService/ +SafeToDeleteExtensions=.xx1 +SafeToDeleteExtensions=.xx2 #jira UE-60575 Change 4135449 by Ben.Marsh Fix allowing use of Job objects on Windows platforms (debug code submitted by mistake) Change 4135730 by Ben.Marsh UBT: Plugins can now be enabled and disabled from the .target.cs file (for targets that do not use the shared compile environment), by compiling the list of enabled/disabled plugin names into the Projects module. Change 4135823 by Ben.Marsh UBT: Remove legacy code to handle disabling optional plugins; now that this is compiled into the target, it will work for any plugins we choose. Change 4135945 by Ben.Marsh UBT: Fix error running programs with no explicitly enabled or disabled plugins. Change 4137207 by Ben.Marsh UGS: Align all badges with the same name, to make it easier to see which CIS steps are being run. Allow overriding the slot taken by a particular badge by calling it "SlotName:LabelName". Change 4137311 by Stefan.Boberg Removed child cooker support. In practice it is not a useful feature as it provides no performance improvement (quite the opposite in fact) and adds testing and maintenance complexity. Change 4137393 by Ben.Marsh UGS: Fix display of multiline errors in the status panel. Change 4141708 by Steve.Robb GitHub #3631 : Incorrect default argument in WeakObjectPtrTemplate #jira UE-45490 Change 4146655 by Stefan.Boberg Removed FullGCAssetClasses logic - no longer necessary nor useful Change 4147318 by Ben.Marsh UGS: Compress build badges in a column if it shrinks below the size that they would be visible. Change 4148207 by Ben.Marsh UGS: Added support for showing the latest completed build from a specific list of badges in the status panel. To declare a badge as one that should appear in the status panel rather than the CIS column, add it to the project's UnrealGameSync.ini in the project or [Default] section like so: +ServiceBadges=RoboMerge Change 4148282 by Stefan.Boberg Fixed bug in UCookOnTheFlyServer::GetCookOnTheFlyUnsolicitedFiles - UnsolicitedFiles should be passed by reference not by value Change 4148344 by Stefan.Boberg Fixed minor indentation error (most likely caused by sloppy merge) Change 4148521 by Stefan.Boberg Removed accidentally checked in PRAGMA_DISABLE_OPTIMIZATION from CookOnTheFlyServer.cpp Change 4148639 by Ben.Marsh UGS: Fix tooltips not showing for changes that have description badges. Change 4149373 by Ben.Marsh UGS: Allow adding additional columns to display particular badges by adding entries from the project config file. Example syntax: +Columns=(Name="Desktop",MinWidth=50,DesiredWidth=100,Weight=3,Badges="Editor") +Columns=(Name="Mobile",MinWidth=50,DesiredWidth=100,Weight=3,Badges="IOS,Android") Same form can be used to control how default columns are displayed (though badge settings are ignored). Also allow PerforceMonitor to detect local changes to project config files and update settings automatically. Change 4149399 by Ben.Marsh UGS: Update version to 1.143. Change 4155660 by Steve.Robb PROJECTION and PROJECTION_MEMBER macros which provide the correct behavior when creating projections using functions which are overloaded or use default arguments. Change 4157117 by Ben.Marsh Fix warning due to plugins disabled in .target.cs file. Change 4158011 by Ben.Marsh UBT: Add a check that the UnrealHeaderTool target file exists, rather than throwing an exception when reading it fails. Change 4158646 by Ben.Marsh UGS: Fix exception when login is discovered to have expired during a workspace update. Change 4158678 by Ben.Marsh UGS: Fix an exception on shutdown due to the icon being hidden after it's already been disposed. Change 4158683 by Ben.Marsh UGS: Add an unhandled exception filter which sends the exception data to the backend. Change 4159131 by Ben.Marsh UGS: Reduce the number of characters displayed for build badges based on the available space. Change 4159194 by Graeme.Thornton TBA: Fix incorrect map property conversion code when converting an old property that contains a map with different key/value types Change 4159239 by Steve.Robb Improved readability and compliance with coding standards. Change 4159246 by Ben.Marsh UGS: Allow syncing projects where source code is not available (and various version files don't exist). #jira UE-60985 Change 4159286 by Ben.Marsh UGS: Remove requirement for UE4Editor.target.cs to be visible in the depot in order to open a project. #jira UE-60986 Change 4159302 by Ben.Marsh UGS: Update version to 1.144. Change 4160308 by Ben.Marsh All staging client executables for blueprint projects. #jira UE-60983 Change 4161567 by Steve.Robb GitHub #4816 : UE-60771: Handle escaped double quote in FParse::LineExtended Change 4162641 by Ben.Marsh UGS: Allow customizing the position of custom columns, via the Index=N attribute. Change 4162647 by Ben.Marsh UGS: Update version to 1.145. Change 4165319 by Robert.Manuszewski PR #4812: Fix inconsistent command-line argument handling under Windows (Contributed by adamrehn) Change 4166150 by Ben.Marsh UGS: Include *.inl when looking for code changes. Change 4166551 by Steve.Robb Whitespace fixes caused by a bad merge. Change 4168483 by Ben.Marsh UGS: Add a more useful error if a file to be synced exceeds the max allowed path length. Change 4168490 by Ben.Marsh UGS: Update version to 1.146. Change 4168551 by Ben.Marsh UBT: Move bBuildLargeAddressAwareBinary into an exposed setting. Change 4168560 by Ben.Marsh UBT: Remove static config variable for controlling which configuration of UHT to use. Change 4171296 by Ben.Marsh UGS: Move the check for overlong paths earlier. Change 4171531 by Ben.Marsh UBT: Fix exception if BuildConfiguration.xml contains an unknown category. Change 4183371 by Robert.Manuszewski Fix for a crash in Async Loading Graph's CheckCycles when GC kicks in on the game thread and forces ALT to exit early Change 4184312 by Ben.Marsh UGS: Update version to 1.148 Change 4184480 by Robert.Manuszewski Removing unused async loading stat Change 4186390 by Ben.Marsh UBT: Format XML validation errors in a format that allows double-clicking on the message in Visual Studio. Change 4188644 by Ben.Marsh UBT: Add the MakePathSafeToUseWithCommandLine() function to UBT. Change 4188647 by Ben.Marsh UBT: Fix exception in target receipt when architecture is null. Change 4189617 by Ben.Marsh Change FileSystemReference, FileReference and DirectoryReference objects to use OrdinalIgnoreCase comparisons without creating a separate copy of the string to compare. The filesystem does not use the invariant culture, and it can produce the wrong results in some cases (the ordinal comparison is faster, too). Change 4189740 by Ben.Marsh UAT: Remote code to build UnrealPak when packaging; we use the editor now. Change 4189860 by Ben.Marsh UGS: Make the filter for excluding automated lighting rebuilds more explicit. Change 4190082 by Ben.Marsh Fixes to allow enabling edit and continue for Windows builds. Have experienced quite a few VS crashes when testing it in editor; not yet recommended for general use. - Allow edit and continue for any configuration, not just debug. - Fixed PDB errors compiling files that use a shared PCH with edit and continue enabled. Path to the generated PDB file was using the wrong directory. - Removed code that tracks PDB output files, since they're modified multiple times during a build. - Enable debug information when compiling generated CPP files, since it causes errors if the shared PCH PDB doesn't have the same option. - Disable support for remote execution of steps that modify the PDB, since the same file has to be modified many times. Remote execution causes the PDB files to be corrupted. Unfortunately, this makes E&C builds significantly slower. #jira Change 4192949 by Ben.Marsh UBT: Minor tidy-up (merging UEBuildBinary.Build and UEBuildBinary.SetupOutputFiles) Change 4193218 by Ben.Marsh Fix formatting. Change 4197252 by Mike.Erwin UAT: Fix log output w/ correct count of non-code projects. #jira none Change 4197941 by Ben.Marsh UGS: Add support for DebugGame editors that have an executable with a DebugGame suffix. Change 4197964 by Ben.Marsh UGS: Prevent attempts to automatically reopen projects while a modal dialog is up, or the workspace is syncing. Change 4198144 by Ben.Marsh UGS: Prevent modal dialogs when login expires in P4, and prompt for password when hitting "retry". Change 4198413 by Ben.Marsh UGS: Always show the main window when launched manually, and run with -RestoreState when launched at startup. Also add a couple more places that save the visibility state, since logging off seems like it can terminate the process abrubtly. Change 4198779 by Ben.Marsh UBT: Allow generating manifests to any arbitrary locations with the -Manifest=<Path> argument. Change 4198825 by Ben.Marsh UBT: Move code to enumerate Slate runtime dependencies into the Slate module. Doesn't need to be done inside core UBT. Change 4199341 by Ben.Marsh UGS: Update version to 1.149 Change 4199642 by Chad.Garyet - Deprecate CISController - Add BuildController to replace CIS GET/POST for builds - Add LatestController, GET does what CIS/GET used to do - Change Latest/GET to return the last 25 builds filtered by project, rather than the last 5000 individual Ids - Latest/GET now returns "LatestData" object instead of array of longs - Updated EventMonitor to match all API changes - Fixed bug where IDs were getting reset to initial startup values every update loop Change 4199663 by Chad.Garyet CIS controller still needs to return an array of longs #jira none Change 4199680 by Ben.Marsh UGS: Update version to 1.150 Change 4200457 by Ben.Marsh Merging CIS fix for non-development configurations. Change 4200472 by Mike.Erwin UAT: fix -skipbuildclient param default It was defaulting to skipbuildeditor's value, likely a copy-paste error. #jira none Change 4202595 by Ben.Marsh Fix static analysis warning due to constant comparison against macro. Change 4203250 by Ben.Marsh UGS: Always show the "Sync Precompiled Editor" option, but disable it and show a tooltip explaining why if it is not available. Change 4206191 by Ben.Marsh Exclude editor target files from installed builds, since they leak info about DLLs that have been stripped out. Change 4213011 by Ben.Marsh UBT: Include contents of modified intermediate files in the log, to make it easier to debug hidden dependencies. Change 4213487 by Ben.Marsh UBT: Fix assumption that bPrecompile is equivalent to bBuildAllModules. This is no longer the case; they are now controlled by separate options. Should fix CIS errors building the editor. Change 4213609 by Ben.Marsh Ensure that strings formatted using FMicrosoftPlatformString::GetVarArgs() are always null terminated, whether we use the secure CRT or not. Change 4215971 by Ben.Marsh UBT: Remove action graph visualization code; no longer used. Change 4215996 by Ben.Marsh UBT: Remove unqiue id from all actions in the action graph. This is only used for printing debug info in the case of a (rare) cycle in the action graph, so just look it up when needed. Change 4216022 by Ben.Marsh UBT: Rename Crypto.cs to EncryptionAndSigning.cs to match the name of the class inside it, and move it under the System folder. Change 4216031 by Ben.Marsh UBT: Move all the action executors into their own folder in the project. Change 4216526 by Ben.Marsh Fix CIS warnings. Change 4216544 by Ben.Marsh Replace custom code to ensure FMicrosoftPlatformString::GetVarArgs() null terminates its buffer with Microsoft's standards-compliant implementation. Change 4216633 by Ben.Marsh Add support for UnrealPak plugins. * Project and plugin modules can now specify an array of supported programs in the "WhitelistPrograms" field of their module descriptors, to allow modules to be loaded by programs. * Programs can now load any runtime modules, as long as they are whitelisted. * Programs under the engine directory can now use a shared build environment, so that building with a project file does not cause output binaries to be output to the project directory. * UnrealPak is now always built by default when packaging * Convert UnrealPak to a modular configuration Change 4216736 by Ben.Marsh UnrealPak: Move "ExportDependencies" command into an editor commandlet, since it relies on the UObject system, asset registry, etc... Change 4217447 by Ben.Marsh Back out revision 50 from //UE4/Dev-Core/Engine/Build/InstalledEngineBuild.xml Change 4217451 by Ben.Marsh Back out revision 11 from //UE4/Dev-Core/Engine/Plugins/Developer/VisualStudioSourceCodeAccess/Source/VisualStudioSourceCodeAccess/VisualStudioSourceCodeAccess.Build.cs Change 4217617 by Ben.Marsh Back out changelist 4217451 Change 4222552 by Ben.Marsh Don't use #import <TypeLib> for VS source code accessor when building with Clang; it's not supported. Change 4222630 by Ben.Marsh UBT: Fix spam while generating project files if Clang isn't installed. Change 4223316 by Ben.Marsh UBT: Change the order in which Visual C++ toolchains are enumerated to prefer full releases over preview releases. Change 4223318 by Ben.Marsh UBT: Add a build setting which allows creating a dedicated PCH for every file that's excluded from the unity working set (disabled by default). Improves iteration times when working on individual cpp files, but slows down iterating on header changes (and can take a lot of disk space for large changes). Dedicated PCH contains all includes scraped from the top of each cpp file, until a non-#include directive is encountered. Change 4223401 by Ben.Marsh UBT: Add an option to automatically enable edit and continue for files in the adaptive non-unity working set. E&C doesn't seem very useful for UE4 projects right now; compile time is comparable to regular build times, but it can take several minutes to apply code changes for large projects. Change 4223899 by Ben.Marsh UBT: Fix loading XML config files on Mono; Type.GetField(Name) does not seem to return values unless binding flags are specified. Change 4224637 by Ben.Marsh Add a "SupportedPrograms" field to plugin descriptors, which allows plugins to declare which plugins they support independently of individual modules. Programs now respect the "bEnabledByDefault" setting in plugins. Plugins that are compatible with a program now need to list that program in the SupportedPrograms list, and whitelist any modules that should load for that program. Change 4224710 by Ben.Marsh UBT: Don't add import libraries as final build products unless the target is being precompiled. Prevents the need for building them for leaf nodes in the action graph. Change 4224715 by Ben.Marsh UBT: Remove hack to allow Stats2.cpp to not follow IWYU convention. Change 4224726 by Ben.Marsh Remove commented out line. Change 4224903 by Ben.Marsh Fix non-unity compile error in Stats2.h. Change 4225051 by Ben.Marsh Back out changelist 4224710; causing CIS errors due to receipts not matching. Change 4225134 by Ben.Marsh Fixing non-unity errors. Change 4225203 by Ben.Marsh Another non-unity fix. Change 4225249 by Ben.Marsh Fix Linux dependencies being copied for the Windows editor; they can be added as requirements for the Linux target platform on Windows instead, so it respects the user's chosen platforms. #jira UE-62001 Change 4225512 by Ben.Marsh BuildGraph: Allow setting the target to build when using the <CsCompile> task. Change 4228815 by Ben.Marsh UBT: Always add the generated code directory to the list of include paths when generating project files. It may only be created after UHT has been run. Change 4228944 by Ben.Marsh UBT: Remove legacy CppCompileEnvironment and LinkEnvironment wrappers from TargetRules that were deprecated in 4.19. Change 4229028 by Ben.Marsh UBT: Fix editor targets with unique build environment having the wrong executable path in generated project files. Move move logic to configure target rules post-construction by the rules assembly to ensure it's valid. Change 4229065 by Ben.Marsh UBT: Move another target setting into the rules assembly. Change 4229105 by Ben.Marsh Fix BPT exception when generating project files. Change 4229311 by Ben.Marsh UBT: Store the module rules file location on the ModuleRules instance, as well as the plugin that it was created from. Also expose the plugin directory as a property on the ModuleRules instance. Change 4229421 by Ben.Marsh UBT: Consolidate functionality for UHT module setup in ExternalExecution.cs. Change 4229817 by Ben.Marsh UBT: Modules must now explicitly specify the path to the header used to generate a PCH if one is desired, rather than the header being determined automatically by attempting to parse the source code. Now that PCHs are force-included anyway, this removes a lot of dependencies inside UBT. Change 4229824 by Ben.Marsh UBT: Remove unused lists inside UEBuildModuleCPP.SourceFilesClass. Change 4229841 by Ben.Marsh UBT: Remove some legacy code from auto-detecting PCHs. Change 4230521 by Ben.Marsh UBT: Add utility functions to the log class to allow formatting errors and warnings in Visual Studio output format (eg. File(Line): warning: Message) Change 4230871 by Ben.Marsh UAT: Remove StreamUtilis utility class; there is a simpler way to implement the one place it's used. Change 4230882 by Ben.Marsh UAT: Add StreamUtils back into UAT, seems like it's still used there. Change 4230896 by Ben.Marsh UBT: Remove some redundant parameters from UEBuildModule/UEBuildModuleCPP/UEBuildModuleExternal constructors. Change 4231014 by Ben.Marsh WorkspaceTool: Include a dump of raw bytes when garbage is read from the P4 process, for diagnostic purposes. Change 4231032 by Ben.Marsh Fix CIS. Change 4231096 by Ben.Marsh Bump the FlatCPPIncludeDependencyCache version, to prevent errors trying to load old files. Change 4231446 by Ben.Marsh UBT: Added support for expanding UE-specific variables in include paths and library paths: $(EngineDir), $(ProjectDir), $(PluginDir), $(ModuleDir). Change 4231460 by Ben.Marsh Modules may now explicitly specify rpaths on Linux via the PublicRuntimeLibraryPaths and PrivateRuntimeLibraryPaths properties. Change 4233909 by Robert.Manuszewski PR #4779: Reason fails as the supplied variable is incorrect (Contributed by projectgheist) Change 4233910 by Ben.Marsh Enable PCHs on IOS. Reduces build time by ~25%. Change 4234176 by Ben.Marsh UBT: Add better messaging for modules that need to have a private PCH set. Now detects the likely PCH using the same method as legacy code and includes it as a suggestion. Change 4234193 by Ben.Marsh Add the Delete command to Perforce wrapper in DotNETUtilities. Change 4234688 by Ben.Marsh UBT: Simplify handling of installed/precompiled builds. Settings for whether a folder is installed/read-only or not is now stored on the RulesAssembly instance, allowing multiple things to be configured separately and stacked together (eg. engine/enterprise/project). RulesAssembly.IsReadOnly() allows determining if a flie can be modified or not and replaces many previous IsXXXInstalledCalls(), and traverses the chain of assemblies. Change 4234711 by Ben.Marsh UBT: Runtime dependencies can now be copied to output directories as part of the build. When adding a runtime dependency, an optional source location can be specified to copy from. Both the source and target paths can use variables can be used as part of the path, eg. $(OutputDir), $(ModuleDir), $(PluginDir). Example usage (from a .build.cs file): RuntimeDependencies.Add("$(OutputDir)/Foo.dll", "$(PluginDir)/Source/ThirdParty/Foo.dll", StagedFileType.NonUFS); Change 4234872 by Ben.Marsh Expose a flag for whether the engine is installed, to fix issues generating project files. Change 4234929 by Ben.Marsh Fix null reference generating receipts when UBT makefiles are active. Change 4235883 by Chad.Garyet Merging 4231245 to core Giving Coordinator its own sln. This should fix what 4158155 was supposed to. #jira UE-61955 Change 4236075 by Ben.Marsh CIS fix Change 4237066 by Robert.Manuszewski Fix for a potential crash when terminating the engine while it's being initialized #jira UE-60545 Change 4237078 by Robert.Manuszewski The engine will no longer be resetting all linkers causing massive load times when renaming the world package when entering Play In Editor Change 4237116 by Ben.Marsh Rewrite some Windows utility functions to support paths longer than MAX_PATH. Change 4237158 by Ben.Marsh Add const TCHAR* overloads of FString::RemoveFromStart() and FString::RemoveFromEnd(). Change 4237159 by Ben.Marsh Fix FWindowsPlatformFile::GetFilenameOnDisk() support for paths longer than MAX_PATH, and simplify some of the other long path functions to avoid copying string buffers. Change 4239050 by Ben.Marsh Missing file Change 4239318 by Ben.Marsh Linux CIS fix. Change 4239685 by Ben.Marsh Static analysis CIS fix. Change 4240800 by Ben.Marsh WorkspaceTool: Include the full command line in the log for any P4 commands. Change 4240903 by Ben.Marsh PR #4909: Update copyright notices to 2018 (Contributed by projectgheist) Change 4241025 by Ben.Marsh UBT: Exclude mobile pipeline caches from generated project files. Causes huge slowdown when using 'Find in Files' through the IDE. Change 4241770 by Ben.Marsh UBT: Include action number in parallel executor output. #jira UE-62032 Change 4243469 by Ben.Marsh TBA: Merge FAnnotatedStructuredArchiveFormatter with FStructuredArchiveFormatter. Any functions that are only implemented for text archives now have a _TextOnly suffix, and are exposed through the FStructuredArchive interface. Change 4245723 by Robert.Manuszewski Fixing another creash when terminating the engine while initializing. #jira UE-60545 Change 4245862 by Steve.Robb VectorLoadFloat2(Ptr) added, which loads { Ptr[0], Ptr[1], Ptr[0], Ptr[1] } into a VectorRegister. Change 4246412 by Robert.Manuszewski The warning 'Calling StaticLoadObject during PostLoad may result in hitches during streaming' will now also report the object which had the PostLoad called on it when StaticLoadObject call happened. Change 4246612 by Ben.Marsh UBT: Fix spelling of "Intellisense". Change 4249454 by Robert.Manuszewski Added extra checks to catch scenarios where the EDL Precache Buffer is flushed before a package header is fully read Change 4249513 by Robert.Manuszewski Made sure the Async Loading Thread doesn't continue running after creating new async packages when garbage collector wants to run on the game thread Change 4255207 by Ben.Marsh UGS: Add additional logging whenever a P4 command fails, and when the user is logged out. Change 4255288 by Ben.Marsh PR #4921: Honor ModuleRules' bEnableExceptions flag when creating precompiled h. (Contributed by surakin) Change 4256422 by Ben.Marsh UBT: Add an error if a module referenced by a plugin descriptor doesn't exist. Change 4257385 by Robert.Manuszewski Creating new objects from within ForEachObjectWithOuter will now result in a fatal error as it's unsafe to change internal UObject hash tables when iterating over them. Change 4257454 by Robert.Manuszewski Added the option to filter clusters listed with gc.ListClusters by objects within them. Usage: gc.ListClusters Hierachy With=ObjectName1,ObjectName2... Change 4257526 by Robert.Manuszewski It's now possible to filter clusters that get logged with verbose cluster logging enabled (UE_GCCLUSTER_VERBOSE_LOGGING=1) by objects within them by specifying -DumpClustersWithObjects=ObjectName1,ObjectName2 in the command line Change 4257822 by Ben.Marsh Fixes for PlatformShowcase compile errors. Change 4258771 by Ben.Marsh UBT: Fix project files not being generated for foreign projects when creating .stub files. #jira UE-62462 Change 4258790 by Ben.Marsh UBT: Clean up the logic around generating project files before creating a stub IPA, so that it fails loudly if project files do not exist, and can accept target names not matching project names. Change 4259276 by Ben.Marsh UBT: Make it an error if a framework doesn't exist, rather than failing silently. Also remove some remote toolchain stuff that's no longer necessary. Change 4259280 by Ben.Marsh UBT: Fix embedded framework zips not being uploaded for plugins. #jira UE-62485 Change 4260236 by Ben.Marsh UBT: Fix path to generated engine project file. Change 4260334 by Ben.Marsh UGS: Fix custom build steps dialog inadvertantly modifying config file settings in-place. Change 4260361 by Ben.Marsh UGS: Allow for p4 login commands to fail, even though the user is logged in (due to a bad connection, etc...) Change 4260559 by Ben.Marsh UGS: Update version. Change 4261160 by Robert.Manuszewski MediaPlaylist will now be added to root set if the owning MediaPlayer is in the disregard for GC set (fixes GC assumption violation crash) #jira UE-62495 Change 4261421 by Ben.Marsh Force-sync files for building documentation, to fix issues with files not being updated. #jira UE-62413 Change 4261425 by Ben.Marsh UBT: Remove some leftover functions for handling the remote toolchain. Change 4261530 by Ben.Marsh UBT: Speculative fix (and better error reporting) for IOS mobile provision not being found in CIS. Change 4261611 by Ben.Marsh UBT: Downgrade warning to a log message, since it appears when generating project files. Change 4261710 by Ben.Marsh Remove assert that GLogConsole is set; it won't be for command line utilities that don't depend on ApplicationCore. #jira UE-62545 Change 4261831 by Ben.Marsh Fix compile errors due to missing include path when hot-reloading a module from the editor. There are not necessarily source files to compile when -modulewithsuffix is specified on the command line, which was results in GeneratedCodeWildcard not being set. #jira UE-62463, UE-62384 Change 4262723 by Ben.Marsh Whitelist plugins that need to be loaded by UFE. #jira UE-62564 Change 4265444 by Ben.Marsh Fix incorrect executable name for DebugGame configurations in Xcode. #jira UE-62574 Change 4265892 by Ben.Marsh Fix incremental compile failures due to dependency checking for unity files. CachedIncludePaths was not correctly being set on file items, so dependencies were being ignored. #jira UE-62575, UE-62603, UE-62597 Change 4266019 by Josh.Adams - Fixed the CopyAction for runtime dependencies that need to be copied to different location, on non-XGE Change 4266264 by Ben.Marsh Remove override for the __IPHONE_OS_VERSION_MIN_REQUIRED macro on TVOS. This macro is already defined by system headers (in <AvailabilityInternal.h>). Now that we support PCHs on IOS and TVOS, manually defining this macro results in it being defined three times (once for the PCH, once by AvailabilityInternal.h, and once by the force-included list of definitions for the source file being built). The errors for redefining the macro in AvailabilityInternal.h are suppressed due to it being a system header, but the error for redefining it for the source file being compiled are not. #jira UE-62578 Change 4266273 by Ben.Marsh Fixes incremental build failure when compile arguments for PCH have changed on IOS/TVOS. Compile action needs to have a dependency on PCH build action. Change 4266614 by Graeme.Thornton Fix crash when cooking nativized blueprints due to removal of child cooker system. Change 4266763 by Ben.Marsh Always build UnrealPak when building client targets. The ProjectParams.Pak option is not reliable, because it can be forced on later by the target platform. #jira UE-62584 Change 4267985 by Robert.Manuszewski When iterating with ForEachObjectWithouter, don't lock the entire has table but only the hash bucket that is currently being iterated #jira UE-62600 Change 4268558 by Robert.Manuszewski PurgeLegacyBlueprints will no longer be called from within ForEachObjectWithOuter is it renames objects that reside in hash tables that are being iterated over which may lead to undefined behavior. #jira UE-62600 Change 4269011 by Chad.Garyet - Fixing Wildcard match issue, the change to ugsapi sends projects as //Depot/Stream instead of //Depot/Stream/ Wildcard match was only substringing to 3 chars. - Checking in the change a while back that increases the number of queried jobs up to 432 based on some maths from Bob about how many builds we want to grab Published to ugsapi server 8/8/17 #jira none Change 4270788 by Ben.Marsh Fix IOS provisioning data being using when remote compiling on TVOS. #jira UE-62705 Change 4271916 by Ben.Marsh Tag the XGEControlWorker executable as a build product after compiling SCW, to make sure it's included in the UGS zip file. Change 4271934 by Ben.Marsh Upload all static libraries in plugin folders as part of remote builds. #jira UE-62694 Change 4273368 by Ben.Marsh Fix Slate dependencies not being enumerated, and rules assembly not being rebuilt when building remotely. #jira UE-62705 Change 4274049 by Ben.Marsh Always parse the team UUID out of the mobile provision when doing a remote compile. The provision installed on the remote Mac (and selected for signing) may be different. #jira UE-62751 Change 4274823 by Ben.Marsh Add the -VersionCookedContent argument to disable the -unversioned parameter on the cooker command line. Change 4275838 by Ben.Marsh Fix BuildVersion string not being passed through from <SetVersion> task. Also add a -BuildVersion command line argument to UBT to override it for a particular build. Change 4275913 by Ben.Marsh Add a dummy exported symbol to the XGEController module, to fix build errors due to missing .lib file when it's built with WITH_XGE_CONTROLLER = 0. Change 4284161 by Ben.Marsh Allow mirroring Oodle files to remote Mac. Change 4074774 by Steve.Robb Vast simplification of TFunction, making it smaller in footprint, easier to follow and extend, and more correct. TUniqueFunction added, which is a move-only TFunction which can hold move-only functors. Fix for UWidgetBlueprint::ForEachSourceWidget() which should never have compiled but did. FFunctionGraphTask and TFuture<> updated to use TUniqueFunction to make them more general. TArray::HeapPop() made to work with move-only types. Change 4082591 by Ben.Marsh Move the Log class from UBT to DotNetUtilities. Change 4083236 by Ben.Marsh Add a Log.WriteException() method to dump an exception message to the console (and write the exception trace to the log) Change 4084107 by Ben.Marsh UAT: Remove the unused -SkipHeader argument to UE4Build. Change 4089771 by Steve.Robb GitHub #4743 : modified VirtualAlloc function flag https://blogs.msdn.microsoft.com/oldnewthing/20151008-00/?p=91411 Change 4091456 by Steve.Robb Unification of all platforms' FMath::CountTrailingZeros() and FMath::CountLeadingZeros() for both 32-bit and 64-bit. Change 4156437 by Ben.Marsh Lots and lots of fixes compiling for Clang on Windows. Editor now compiles cleanly without warnings, but crashes on startup due to error in intrinsics test. Disabling that runs further, but crashes accessing freed memory. Switching to the ANSI allocator runs further, but crashes in Slate after the splash screen and before the editor window opens. // TODO! * Switching between Clang/ICL/VS2015/VS2017 is now supported through the same mechanism as switching Visual Studio versions, without requiring any source level changes. To use Clang, set WindowsPlatform.Compiler = WindowsCompiler.Clang from a .target.cs file, or set <WindowsPlatform><Compiler>Clang</Compiler></WindowsPlatform> from BuildConfiguration.xml. To pick a specific toolchain version, set WindowsPlatform.CompilerVersion. * Clang is now supported through AutoSDKs; will be added to CIS. * The Samples/Sandbox/Clang project forces Clang to be used from its target.cs file, and allows easily building all editor modules and plugins with Clang on Windows. * UnrealMathSSE intrinsics have been re-enabled for Clang due to missing functions from the UnrealMathFPU implementation, but causes failure in tests at startup. * SSE4_CRC32() is disabled in D3D12Pipelinestate.cpp, since intrinsics are only allowed if enabled for the whole target (rather than being used in specific functions due to runtime checks) Change 4157389 by Ben.Marsh Few more fixes for compiling the editor with Clang. Change 4183911 by Ben.Marsh Fixes to support incremental linking on Windows. Does not seem to have any net benefit right now; may improve once minimal rebuild is enabled. * Incremental linking no longer forces PDB files to be enabled for source files. * Actions can specify specific files to be deleted before each build. Code to forcibly delete PDB files has been moved to the MSVC toolchain. * Unused libraries produced by the cross-referenced link are no longer added as build products, since (a) deleting them breaks dependency checking for incremental linking and causes a full link, and (b) not deleting them breaks UBT dependency checking and causes actions to be run over and over again. * Icon update is disabled for Windows when incremental linking is enabled. * Removed rarely-used setting to always delete produced items before each build. Change 4184311 by Ben.Marsh UGS: Added a dialog which shows all the required platform SDKs for a branch, linked from the status panel in UGS. The llist is configured via the UGS config file submitted to Engine/Programs/UnrealGameSync/UnrealGameSync.ini (and may be overridden by the project config file if necessary): [Default] ; Set this to a network share which contains the SDK installers for your site SdkInstallerDir= ; All the required SDKs for the current version of the engine +SdkInfo=(Category="Android", Description="NDK r21", Browse="$(SdkInstallerDir)\\Android") +SdkInfo=(Category="Windows", Description="Visual Studio 2017") +SdkInfo=(Category="Windows", Description="Visual C++ Toolchain 14.13.26128") +SdkInfo=(Category="Windows", Description="Windows SDK 10.0.16299.0") Similar entries for console platforms are added in console subdirectories. Each entry may contain an Install="Foo.exe" and/or Browse="C:\Foo" style attribute, specifying the path to an installer to run or directory to open in explorer respectively. The SdkInstallerDir setting is used as a base directory for the default installers, seen above for Android. Licensees may override this with a network path specific to the site that UGS is being deployed to (either in this file, in a project specific config file, or in a Engine/Programs/UnrealGameSync/NotForLicensees/UnrealGameSync.ini file). Change 4200452 by Ben.Marsh UBT: Change DebugGame configurations to output a separate executable rather than requiring a -Debug argument at runtime. Previous behavior was a common source of errors. Engine modules are still shared between Development and DebugGame, but the launch module sets a flag in Core on startup indicating the game configuration. Change 4206189 by Ben.Marsh UBT: Simplify logic for precompiling binaries. * Target no longer has separate list of "precompile only" binaries or modules. New -AllModules option allows adding every module to a target, which can be used with -Precompile and -NoLink to precompile object files for monolithic builds. * Precompiled file lists have been removed from target receipts. * The manifest now includes all generated headers and precompiled files when run with the -Precompile option. * Separate -DependencyList=Foo.txt has been added to write a list of all dependencies required to use precompiled binaries. This file list can be read using the <Tag> task in buildgraph. Change 4215466 by Ben.Marsh UBT: Remove indirect calls to determine extensions for object files and precompiled headers. The toolchain knows the correct convention for the platform. Change 4215975 by Ben.Marsh UBT: Remove telemetry code. This has never proved useful for analyzing performance due to the number of incidental factors that affect build times (eg. number of files being compiled). Change 4220154 by Ben.Marsh Move text-only implementations of FOutputDeviceError back into Core, so we can build command-line applications that don't depend on ApplicationCore. Change 4224708 by Ben.Marsh Add a bCompileAgainstApplicationCore setting to the target rules, which allows compiling out references to the ApplicationCore module (which should only be necessary for applications with a GUI). Removed ApplicationCore from several engine tools and utilities. Change 4224958 by Ben.Marsh Remove CoreMinimal.h includes from Core. Change 4229059 by Ben.Marsh UBT: Remove the UEBuildPlatform.ShouldNotBuildEditor() hook for target platforms. We shouldn't be modifying a target's build environment to disable the editor; it is invalid to build the editor for these target platforms at all, and this is already enforced by the GetSupportedPlatforms() function. Change 4230508 by Ben.Marsh Fixup precompiled header setting for samples and games. Change 4231457 by Ben.Marsh Fix exceptions in log messages having trailing newlines. Change 4232406 by Ben.Marsh UBT: Always force include a PCH for generated code if there's one set; the code may depend on it to compile. Change 4234177 by Ben.Marsh Set up private PCH files everywhere that previously used them. Change 4235973 by Ben.Marsh Change FPlatformMisc::GetEnvironmentVariable() to return an FString() rather than requiring a fixed size buffer to be passed in. Removes references to MAX_PATH. Change 4238842 by Ben.Marsh Add support for paths longer than MAX_PATH in the editor. Requires Windows 10 version 1607, and the functionality to be enabled via a registry key or group policy (see https://docs.microsoft.com/en-us/windows/desktop/FileIO/naming-a-file). Only a subset of Win32 functions support long paths (executables can only be started from paths shorter than MAX_PATH, for example). * Added a FPlatformMisc::GetMaxPathLength() function to return the maximum length of a path on the current system. On Windows, this returns a different value for systems with long paths enabled to those without. * The MAX_PATH define is no longer set by non-Windows platforms. Instead, there is a MAC_MAX_PATH, UNIX_MAX_PATH, etc... for any platform-specific code that still relies on the previous macro. * The MAX_UNREAL_FILENAME_LENGTH macro has been renamed to MAX_UNREAL_FILENAME_LENGTH_DEPRECATED * The PLATFORM_MAX_FILEPATH_LENGTH macro has been renamed to PLATFORM_MAX_FILEPATH_LENGTH_DEPRECATED. * Removed custom resource files for programs, since they are just copies of the base UE4 one (which is used by default anyway). The base UE4 manifest declares support for long paths. * Fix 512 character maximum length on editor commands. 260 character limit remains in place for cooking at the moment (see ContentBrowserUtils.h), until C# staging code supports long paths. Change 4255042 by Ben.Marsh UBT: Remote compilation now uploads the entire workspace to the remote Mac and executes a separate remote instance of UBT rather than synchronizing individual actions. This makes the remote compile codepath much simpler, and removes a lot of special cases that exist to support it previously. The list of files to be transferred to the remote are listed as rsync filter rules in Engine/Build/Rsync/RsyncEngine.txt and RsyncProject.txt, which are applied to the root engine directory and project directory respectively. Projects that need to customize which files are uploaded can add their own <ProjectDir>/Build/Rsync/RsyncProject.txt file, which will be included in the filter before the default version. Change 4260567 by Ben.Marsh UAT: Rename CommandUtils.Log to CommandUtils.LogInformation, to avoid conflicts with the underlying Tools.DotNETCommon.Log class. #rb none [CL 4285673 by Ben Marsh in Main branch]
2018-08-14 18:32:34 -04:00
LogInformation("Waiting for client logging process to start...{0}", ClientLogFile);
Thread.Sleep(2000);
}
if (!ClientProcess.HasExited)
{
Thread.Sleep(2000);
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 4285612) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3836829 by Ben.Marsh UBT: Fix ability to precompile plugins from installed engine builds. Change 3839519 by Ben.Marsh UBT: Simplify configuring bPrecompile and bUsePrecompile settings for modules. Each rules assembly can now be configured as installed, which defaults the module rules it creates to use precompiled data. Change 4042043 by Steve.Robb GitHub #4705 : Added weak lambda's for delegates and multicast delegates. Change 4042056 by Robert.Manuszewski Optimized Mark Phase of GC by up to 10ms by making it run in parallel and removing a huge array presize which we didn't need. Change 4042104 by Robert.Manuszewski Set the minimum GC cluster size to 5 so that GC doesn't have to process micro clusters which are more expensive than processing individual objects + Exposed the minimum cluster size to ini and project settings as gc.MinGCClusterSize + Added the ability to sort clusters by name/object count/mutable object count/referenced clusters count when dumping them with gc.ListClusters command Change 4042377 by Robert.Manuszewski Reworked how GC and other threads (ALT specifically) interact - GC will now notify the ALT it wants to run and ALT will immediately try to finish its current work to allow that. Also the entire ALT tick is now protected against GC running at the same time to improve ALT stability. + added gc.ForceCollectGarbageEveryFrame console variable that triggers a forced GC every frame Change 4042427 by Robert.Manuszewski Changed FGCCSyncObject to use events when waiting for GC to finish so that it doesn't spin on non-game threads when GC is running Change 4042482 by Robert.Manuszewski Unhashing unreachable objects (ConditionalBeginDestroy) will now also be done incrementally, just like the purge phase of Garbage Collection Change 4042635 by Robert.Manuszewski Fix for a potential assert when incremental purge garbage is pending and something forces a full purge Change 4044092 by Steve.Robb Fix for forward declared CoreUObject weakobject types in delegates when building in Clang. Change 4044102 by Robert.Manuszewski Fix for a possible hang when worker threads are preventing GC from running and something is later trying to FlushAsyncLoading with the Async Loading Thread enabled Change 4044113 by Steve.Robb Another Clang fix. Change 4044160 by Robert.Manuszewski Disregard For GC pool will now be enabled by default in cooked builds Change 4044287 by Steve.Robb Typo fix. Change 4047723 by Graeme.Thornton TBA: Fixes for import/export name cache and object resolving Change 4048015 by Graeme.Thornton TBA: Weak/Soft/Lazy pointer serialization changes * Remove FWeakObjectPtr::Serialize, move it's logic into, and replace usages of with calls to, FArchiveUObject::SerializeWeakObjectPtr(). Ensures that something is always sent to the archive so that structured archives can be kept happy in the future. * Added Weak/Soft/Lazy pointer handling to the structured archive slot interface and all the formatters. Binary formatters just forward the call onto their inner and text archives store as a string path reference. * FArchiveUObjectFromStructuredArchive caches all these pointer types and stores indices in the binary block, same as with a UObject*. All pointers are then forwarded to the underlying formatter in one go on finalization. Change 4048021 by Steve.Robb Fix for binding an unbound TFunction to another TFunction with a different signature. Also all null pointers now count as unbindings, not just nullptr. TIsMemberPointer added. TIsATFunction and TIsATFunctionRef renamed to remove the 'A's. Change 4048544 by Robert.Manuszewski Fixing ConditionalBeginDestroy profiling after changes to incremental CBD. Change 4051028 by Graeme.Thornton TBA: ArchiveFromStructuredArchive adapter uses Inner to determine if it is outputting to text, and sets it's own ArIsTextFormat to false Change 4051056 by Graeme.Thornton TBA: High level tagged property / UObject base class text serialization - UObject serialize converted to structured archive - Properties written to text individually with text tags, and then binary adapted values - Only saves, doesn't load Change 4051111 by Graeme.Thornton TBA: Temporarily disable loading of text assets until tagged property serialization path is fixed up Change 4051154 by Graeme.Thornton TBA: Convert a few uobject serializers to structured archive format for example purposes Change 4051181 by Graeme.Thornton TBA: Added default structured archive implementation of SerializeItem to UProperty, which just calls the FArchive version on an FArchiveUObjectFromStructuredArchive adapter. Implemented structured archive SerializeItem for UArrayProperty Change 4051197 by Graeme.Thornton TBA: ObjectProperty text serialization Change 4051216 by Graeme.Thornton Restored a modified FWeakObjectPtr::Serialize function to keep backwards compatibility in code I don't have access to. Change 4051261 by Graeme.Thornton TBA: Convert UMetaData to structured archive Change 4051374 by Steve.Robb Incorrect assert removed. Change 4051562 by Robert.Manuszewski Adding stats for the new GC internal functions Change 4051614 by Graeme.Thornton TBA: Removed UProperty::SerializeItem(FArchive, ...) and replaced with UProperty::SerializeItem(FStructuredArchive::FSlot, ...). Fixed up most of them to work properly and added adapters in for any that were non-trivial. Change 4052512 by Graeme.Thornton TBA: Temporary workaround for softobjectptr and lazyobjectptr uproperties not serialization anything when they know the archive is a reference collector. They should always be serializing their pointers and letting the underlying archive itself ignore them. Change 4053917 by Robert.Manuszewski Clustered objects from clusters that are no longer reachable will now be marked as unreachable immediately when gathering unreachable objects Change 4053919 by Robert.Manuszewski Added the ability to disable incremental BeginDestroy in ini/project settings Change 4055518 by Daniel.Lamb Fixup for deterministic audio generation issue. Submitted on behalf of Rich.Whitehouse #jira nojira #test prefilght automated test. Change 4056854 by Graeme.Thornton TBA: Added a test asset to EngineTest which contains all the different property types and test cases. Change 4056858 by Graeme.Thornton TBA: Updated USetProperty to proper structured archive usage Change 4056872 by Graeme.Thornton TBA: Add map property field to test object Change 4056873 by Graeme.Thornton TBA: Convert UMapProperty to full structured archive Change 4056994 by Graeme.Thornton TBA: Converted FText over to structured archive. Implemented saving, but not loading. Change 4059728 by Ben.Marsh UBT: Add support for using adaptive non-unity builds when the engine and project are in separate repositories. Change 4059805 by Graeme.Thornton Fixed typo in text serialization. Fixes CIS automation test errors Change 4060007 by Graeme.Thornton TBA: FArchiveFromStructuredArchive will now access it's host slot lazily, i.e. only when a value is actually written to the archive. Change 4060092 by Stefan.Boberg Added optimized Windows console window output path to GenericConsoleOutput since this slowed down cooking considerably (2 minutes spent in wprintf alone for one large dataset) When stdout is attached to a console we use the WriteConsoleW function instead of wprintf since the latter is very slow especially in unbuffered mode which the engine currently configures for stdout (see setvbuf call in LaunchEngineLoop.cpp). At some point we should reconsider this buffering policy since it's likely to slow down other platforms as well but I wanted to do a safe change for now as I don't yet fully understand why the setvbuf call is there in the first place. Change 4060108 by Stefan.Boberg Introduced some additional target platform utilities to help with asset cook optimizations * We now assign each ITargetPlatform a zero-based ordinal value * Introduced FTargetPlatform and FTargetPlatformSet types to help store platform references and platform sets efficiently. These are not currently used in the engine but are designed to replace the existing ITargetPlatform/string/FName representations in the cooking data structures. Change 4060143 by Graeme.Thornton Undo //UE4/Dev-Core/Engine/Source/Runtime/... changelist 4060007 Needs some other changes that I haven't checked in yet... Change 4062432 by Ben.Marsh Fix error message when enumerating P4 changes. Change 4062648 by Ben.Marsh Add missing p4 integration action. Change 4063620 by Graeme.Thornton Integrated a fix from UDN where the engine would crash when trying to load a very small encrypted file (<16bytes) from a pak file, where the read address wasn't already aligned to the AES block size. (https://udn.unrealengine.com/questions/431989/crash-while-reading-a-very-small-file-in-encrypted.html) Change 4066963 by Robert.Manuszewski Fixing GC cluster verification code reporting false positives when a cluster is referencing another cluster through 'mutable' objects list. Change 4067133 by Robert.Manuszewski Changed log verbosity when reporting individual cases of GC cluster assumption violations as they are followed by an asser anyway and this way we get the chance to see all issues before we assert at the end of these checks. Change 4067443 by Steve.Robb FString can now be constructed from any char pointer type and length. Change 4068156 by Steve.Robb Fix necessary because of FString constructor change in CL# 4067443. Change 4070258 by Graeme.Thornton Fixes for VSCode Change 4070372 by Graeme.Thornton TBA: Script struct serialization to structured archives Change 4071913 by Ben.Marsh Move bulk of the code for UnrealPak into an engine developer module, so it can be used in the editor. Change 4071914 by Ben.Marsh Missing files. Change 4071937 by Ben.Marsh Missing header. Change 4072015 by Ben.Marsh Fixes for compiling PakFileUtilities as part of the editor. Change 4072826 by Steve.Robb TBitArray::Reserve() added. TBitArray::Add() overloaded to allow adding multiple bits. TSparseArray::Reserve() optimized to call the overloaded Add(). Change 4073271 by Daniel.Lamb Fixed add patch tier in project launcher passing the wrong commandline option to UAT. #test none Change 4074708 by James.Hopkin #core Removed redundant Casts Change 4074763 by Steve.Robb Fix for TSparseArray::Reserve() size. Change 4076063 by Ben.Marsh Add an "UnrealPak" commandlet with the same functionality as the standalone UnrealPak program. Invoke by running the editor with -run=UnrealPak and the standard UnrealPak commandline options. Change 4077064 by Robert.Manuszewski Fixing compile error in PakFileUtilities Change 4077144 by Graeme.Thornton TBA: TextAssetCommandlet improvements * Collect lists of broken assets during roundtrip tests and print a summary of packages that failed each phase at the end * After resaving as text, load the file back as a plain JSON hierarchy to ensure the output was valid Change 4077412 by Ben.Marsh Set the correct exit code for UnrealPak. Should return 0 on success, not 1. Change 4077760 by Graeme.Thornton TBA: Loading fixed for tagged property serialization Includes conversion of all UProperty::ConvertFromType() and SerializeFromMismatchedTag() functions to use structured archives Lazy initialization of FArchiveFromStructruredArchive when loading, to support the possibility of an adapter being create around an object property serialize call to its inner UStruct, which then decides not to do anything and return false. Stops the ArchiveFromStructuredArchive from consuming the slot and getting upset later on when we try to serialize normal tagged properties from it. Disabled lazy bulk data loading from text assets. Requires a bigger change to make it work. Added some debug checks to json input formatter which track the current value stack size when a new object is pushed onto the stack, and makes sure that the stack has returned to the same size when the object is popped. Catches cases where we unpack an array/stream to the value stack but then don't consume all the items. Change 4078800 by Ben.Marsh Change UAT to using the editor's UnrealPak commandlet rather than invoking the standalone UnrealPak executable. To improve performance when building several PAK files, also add a new -batch=<file> command which reads commands to execute in parallel from a text file. Change 4079745 by Graeme.Thornton TBA: Migrated a couple of UObject Serialize functions to FStructuredArchive (SoundCue / MaterialExpressions / Editor strip flags) Change 4079847 by Graeme.Thornton TBA: Add 'FindMismatchedSerializers' mode to text asset commandlet, which dumps out a list of all UClasses which don't have the CLASS_MatchedSerializers flag, meaning we can't guarantee the have Serialize functions for FArchive AND FStructuredArchive, therefore we can't use the new structured archive based serialize path. Should only ever be native instrinsic classes as UHT takes care of all other cases. Change 4079925 by Ben.Marsh Fix incorrect assignment when deriving name for chunked pak file. Change 4080214 by Ben.Marsh Move the ThreadPoolWorkQueue class into DotNETUtilities so it can be used by other projects. Change 4082394 by Graeme.Thornton CIS fix for variable shadowing warning Change 4082583 by Ben.Marsh Add a IBinarySerializable interface for types that support reading from a BinaryReader and writing to a BinaryWriter. Implementing IBinarySerializable implies a constructor taking a BinaryReader argument is available for deserializing. Change 4082652 by Ben.Marsh Fix FileReference.Directory not returning a directory with a trailing backslash for files in the root directory. Change 4082755 by Graeme.Thornton Fixed an erroneous usage of TUniquePtr<uint8>as a pointer to a uint8 array when creating pak files. Caused a crash when compression was enabled, and has probably surfaced because pak generation is now done by an editor commandlet rather than a standalone program. Change 4082756 by Graeme.Thornton Fixed some incorrect documentation for pakfile compressed chunk headers Change 4082883 by Graeme.Thornton Static analysis warning fix Change 4082912 by Ben.Marsh Move ExceptionUtils into DotNETUtilities. Change 4085291 by Graeme.Thornton TBA: In the Json output formatter, write float and double values out with enough precision for successful roundtripping. Added some debug only code which will immediately reconvert the string back to its original value and compare the the input Change 4085523 by Graeme.Thornton TBA: Remove only explicit usage of DECLARE_FSTRUCTUREDARCHIVE_SERIALIZER. Should only be used from UHT generated code. Change 4086037 by Robert.Manuszewski Fix for a potential race condition when two threads want to acquire GC lock Change 4088655 by Graeme.Thornton Pak creation now uses the bEnablePakSigning setting from the crypto config json file Change 4091474 by Steve.Robb Fix for TStaticBitArray::FindFirstSetBit() and TStaticBitArray::FindFirstClearBit(). Unused variables removed. Change 4093632 by Steve.Robb CIS fixes. Change 4093656 by Graeme.Thornton Build fix Change 4093744 by Ben.Marsh Allow per-chunk settings for whether to enable compression in UnrealPak. Change 4099712 by Gil.Gribb UE4 - Fixed rare case where insufficient space was preallocated for cooldown ticks. #jira UE-59686 Change 4099912 by Stefan.Boberg Cooking timer optimizations: - Replaced data structures for FScopeTimer and FHierarchicalTimerInfo. Previous implementation used FString for many things and caused *lots* of heap and string concatenation activity. Replaced with a compile-time node id (using __COUNTER__) and raw string literals. - Removed PERPACKAGE_TIMER support (was disabled by default and was difficult to test) - Made it possible to toggle OUTPUT_TIMING and ENABLE_COOK_STATS independently - Removed some extremely tight timers because the overhead from calling QPC significantly exceeded the measured code This change shaved some 15% off a clean cook of Fortnite WindowsClient (en) with fully populated local DDC Change 4100519 by Stefan.Boberg Quick fix for Linux build issue introduced in 4099927 Change 4105327 by Stefan.Boberg Cooker: Changed FHierarchicalTimerInfo so it uses a linked list for tracking child nodes, to be able to deal with any child count. Previously we assumed there would never be more than 9 children but it turns out there are cooker modes that need more. Fixes check when using -FullLoadAndSave to cook Change 4105448 by Stefan.Boberg - Fixed Linux build warning re: member initialization order - Also eliminated OUTPUT_HIERARCHYTIMERS/CLEAR_HIEARCHYTIMERS macros (plain functions are fine) - Moved finishing-up code for FullLoadAndSave() to TickCookOnTheSide() call site to improve timer output. Previously some of the scopes would not have been closed before printing and thus the output was misleading. Change 4109031 by Ben.Marsh Attribute-driven Perforce wrapper (old Epic Friday project). Offers a more complete implementation than the current P4 wrapper in UAT without requiring any platform-specific libraries. Uses the Python binary output for parsing. Change 4109588 by Ben.Marsh UBT: Add extension methods for serializing a nullable type to a BinaryReader/BinaryWriter. Change 4109595 by Ben.Marsh Missing project file for DotNETUtilities. Change 4110724 by Stefan.Boberg Removed annotation map locking in UObjectMarks, eliminating around one minute (~3.5%) from Fortnite cook time. The locking was redundant since the annotation maps are managed per thread anyway. Change 4111304 by Ben.Marsh UAT: Add support for setting a status message through the log class. Allows writing transient messages (eg. progress messages) which will be cleared out before writing other messages. Best used through the LogStatusScope class, which can set a status message for the duration of a using() block. As part of this change, the console no longer has to be added as a dedicated trace listener. Since we already special-case this listener when formatting log output, it's easier to just keep the implementation separate to the other trace listeners. Change 4112708 by Steve.Robb Fix for TBitArray::MaxBits in assignment. Change 4114133 by Stefan.Boberg Tweaked how low-level memory (LLM) tracker is implemented to reduce overheads. Previously FMemory functions would acquire the LLM singleton and call OnLowLevelFree/OnLowLevelAlloc etc which would check the bIsDisabled flag and early out if it was set. Due to how frequently these functions were called this ended up costing quite a bit. - This change makes the flag a static member variable instead of a member variable and therefore enables a simpler early-out to be implemented. - The singleton getter is also simplified to avoid hitting the threadsafe singleton construction path on every call. - The enable flag is no longer TAtomic - this also incurs extra overhead for no clear benefit Shaves approximately 3.5% (one minute) off a Fortnite cook test scenario (using -FullLoadAndSave) Change 4115010 by Robert.Manuszewski Fixing CIS Change 4115249 by Robert.Manuszewski Fixing async loading code asserts when exiting game very early due to an error #jira UE-56267 Change 4117091 by Ben.Marsh Prevent doubled-up lines when writing status updates with console log verbosity. Change 4117207 by Ben.Marsh UGS: Do not include executables in diagnostics zip file, and ignore "no such files" error when cleaning workspace. Change 4119175 by Ben.Marsh UGS: Fix crash writing version files when directory does not already exist. Change 4119987 by Ben.Marsh UGS: Show a dialog box while the launcher is updating executables from Perforce, which allows cancelling the operation if necessary. Allow setting the username on the settings window, and prompt for login credentials if necessary. Should prevent situations where users have to update settings from the command prompt. Holding down shift during launch now shows the settings dialog rather than an immediate prompt to launch the unstable version (unstable version is shown as a checkbox on this dialog). Change 4119991 by Ben.Marsh Update version number for UGS launcher to 1.13. Change 4121943 by Robert.Manuszewski Don't use FArchiveAsync2 for reading packages with non-async path in editor builds as its performance is worse than the standard archive's (saves about 1 minute when doing larger cooks and 7 seconds when loading into PIE) Change 4122592 by Steve.Robb GitHub #4762 : Improve wording and grammar of Math comments Also includes improved accuracy in FMath::ComputeBoundingSphereForCone(). Change 4122819 by Stefan.Boberg Don't call CreateDirectory redundantly when opening files for writing using FFileManagerGeneric::CreateFileWriter This change avoids calling IPlatformFile::CreateDirectoryTree if possible since this is a very expensive function especially for deep hierarchies as it performs directory creation from the root directory onwards instead of from the leaf downwards. That function should also be fixed but this change improves performance in the meantime. Change 4122872 by Stefan.Boberg CreateDirectoryTree now creates directories leaf-to-root instead of the other way around. This is much more efficient since we don't spend time on system API calls for directories which already exist. This accounted for a very large amount of CPU time in cooking as the full target file directory hierarchy would be "created" for every single output file. Change 4123109 by Stefan.Boberg - Disable overlapped I/O in editor / cooker. Synchronous I/O reduces the number of syscalls and Windows performs prefetching on our behalf anyway for sequential reads - Eliminated syscall which was issued for every write to update cached file size -- since we're the only writers to the file (file access allows read sharing at most) we can authoritatively update the file size on write completion Change 4123455 by Ben.Marsh PR #4775: New build param PCHMemoryAllocationFactor to set /Zm VS build param. (Contributed by lucaswall) Change 4124207 by Ben.Marsh UBT: Remove some unnecessary indirection for generated code paths. Change 4124217 by Ben.Marsh UBT: Remove another unused variable from UEBuildModuleCPP. Change 4124377 by Stefan.Boberg In IPlatformFile::DeleteDirectoryRecursively, attempt to delete file first and if it fails clear the readonly flag and try again Previously there was a call to clear the readonly flag for every deleted file and this is a waste of resources 99% of the time. The SetFileAttributes call accounted for a significant amount of time during cooker sandbox directory deletion Change 4125071 by Stefan.Boberg Some tweaks to FQueuedThreadPoolBase scheduling and memory management - Explicitly pass in false for TArray::RemoveAt(..., bool bAllowShrinking) argument to prevent memory reallocation when arrays are drained and inevitably repopulated shortly afterwards - Use a MRU strategy instead of LRU when picking a thread to wake up. The MRU thread is the most likely to have a 'hot' cache for the stack etc. Picking from the back of the array also happens to be cheaper since no memory movement is necessary when RemoveAt is called. (This was the strategy in place before CL2600362 which seems to have changed it unintentionally) - Release lock as soon as a thread has been chosen, before asking the worker thread to wake up and do the work Change 4126132 by Ben.Marsh UAT: Detect when stdout is redirected and prevent using backspace characters to move the cursor. Change 4126867 by Graeme.Thornton TBA: Fix tagged binary formatter Change 4127010 by Robert.Manuszewski AnimScriptInstances created at runtime will now also be added to the owning omponent's cluster to avoid GC issues. Change 4127932 by Ben.Marsh WorkspaceTool: Reduce unnecessary logging of status messages when console output is not redirected. Change 4129050 by Ben.Marsh UGS: Check for NET Framework 4.5 being installed before running the installer. Also fix warning trying to kill existing UGS instances before upgrade. Change 4129459 by Graeme.Thornton TBA: TextAssetCommandlet - When outputting converted assets to an output path, replicate the workspace relative path in the output directory Change 4129515 by Graeme.Thornton TBA: Add EnterRecord overload that allows outputting of available field names when loading. Change 4129517 by Graeme.Thornton TBA: Tagged properties are written out as named fields on the "Properties" record, rather than as a stream with a null tag at the end Change 4129518 by Graeme.Thornton TBA: Added a local const bool to allow easy hacking out of text asset loading support Change 4129558 by Graeme.Thornton TBA: Build fix for textasset-less configs Change 4129614 by Ben.Marsh UGS: Main window is now restored to normal size when activated by clicking on the tray icon. #jira UE-60490 Change 4129618 by Ben.Marsh UGS: Speculative fix for unreproduced exception accessing disposed window while shutting down. Change 4131936 by Robert.Manuszewski Removing some WIP code accidentally checked in with CL #4121943 Change 4133490 by Ben.Marsh UGS: Allow the $(Change) variable to be used in more places than just the context menu. #jira UE-60573 Change 4133550 by Ben.Marsh UGS: Setting for whether or not to use incremental builds is now exposed through the variable "$(UseIncrementalBuilds)" for use by custom build steps. #jira UE-60554 Change 4133681 by Ben.Marsh UGS: A per-project list of folders and extensions to be deleted by default when running the 'clean workspace' tool can now be specified through the <ProjectDir>/Build/UnrealGameSync.ini file. Settings may be specified for an individual branch (via a category with the depot path to the project) or for wherever the project is currently open (via the [Default] category). The SafeToDeleteFolders list specifies a substring that will be checked against folder paths. Anything containing this folder will be marked as safe for delete by default. The SafeToDeleteExtensions list specifies a list of extensions for files that can always be deleted. Example: [Default] +SafeToDeleteFolders=/MyGame/Test/ +SafeToDeleteFolders=/DataService/ +SafeToDeleteExtensions=.xx1 +SafeToDeleteExtensions=.xx2 #jira UE-60575 Change 4135449 by Ben.Marsh Fix allowing use of Job objects on Windows platforms (debug code submitted by mistake) Change 4135730 by Ben.Marsh UBT: Plugins can now be enabled and disabled from the .target.cs file (for targets that do not use the shared compile environment), by compiling the list of enabled/disabled plugin names into the Projects module. Change 4135823 by Ben.Marsh UBT: Remove legacy code to handle disabling optional plugins; now that this is compiled into the target, it will work for any plugins we choose. Change 4135945 by Ben.Marsh UBT: Fix error running programs with no explicitly enabled or disabled plugins. Change 4137207 by Ben.Marsh UGS: Align all badges with the same name, to make it easier to see which CIS steps are being run. Allow overriding the slot taken by a particular badge by calling it "SlotName:LabelName". Change 4137311 by Stefan.Boberg Removed child cooker support. In practice it is not a useful feature as it provides no performance improvement (quite the opposite in fact) and adds testing and maintenance complexity. Change 4137393 by Ben.Marsh UGS: Fix display of multiline errors in the status panel. Change 4141708 by Steve.Robb GitHub #3631 : Incorrect default argument in WeakObjectPtrTemplate #jira UE-45490 Change 4146655 by Stefan.Boberg Removed FullGCAssetClasses logic - no longer necessary nor useful Change 4147318 by Ben.Marsh UGS: Compress build badges in a column if it shrinks below the size that they would be visible. Change 4148207 by Ben.Marsh UGS: Added support for showing the latest completed build from a specific list of badges in the status panel. To declare a badge as one that should appear in the status panel rather than the CIS column, add it to the project's UnrealGameSync.ini in the project or [Default] section like so: +ServiceBadges=RoboMerge Change 4148282 by Stefan.Boberg Fixed bug in UCookOnTheFlyServer::GetCookOnTheFlyUnsolicitedFiles - UnsolicitedFiles should be passed by reference not by value Change 4148344 by Stefan.Boberg Fixed minor indentation error (most likely caused by sloppy merge) Change 4148521 by Stefan.Boberg Removed accidentally checked in PRAGMA_DISABLE_OPTIMIZATION from CookOnTheFlyServer.cpp Change 4148639 by Ben.Marsh UGS: Fix tooltips not showing for changes that have description badges. Change 4149373 by Ben.Marsh UGS: Allow adding additional columns to display particular badges by adding entries from the project config file. Example syntax: +Columns=(Name="Desktop",MinWidth=50,DesiredWidth=100,Weight=3,Badges="Editor") +Columns=(Name="Mobile",MinWidth=50,DesiredWidth=100,Weight=3,Badges="IOS,Android") Same form can be used to control how default columns are displayed (though badge settings are ignored). Also allow PerforceMonitor to detect local changes to project config files and update settings automatically. Change 4149399 by Ben.Marsh UGS: Update version to 1.143. Change 4155660 by Steve.Robb PROJECTION and PROJECTION_MEMBER macros which provide the correct behavior when creating projections using functions which are overloaded or use default arguments. Change 4157117 by Ben.Marsh Fix warning due to plugins disabled in .target.cs file. Change 4158011 by Ben.Marsh UBT: Add a check that the UnrealHeaderTool target file exists, rather than throwing an exception when reading it fails. Change 4158646 by Ben.Marsh UGS: Fix exception when login is discovered to have expired during a workspace update. Change 4158678 by Ben.Marsh UGS: Fix an exception on shutdown due to the icon being hidden after it's already been disposed. Change 4158683 by Ben.Marsh UGS: Add an unhandled exception filter which sends the exception data to the backend. Change 4159131 by Ben.Marsh UGS: Reduce the number of characters displayed for build badges based on the available space. Change 4159194 by Graeme.Thornton TBA: Fix incorrect map property conversion code when converting an old property that contains a map with different key/value types Change 4159239 by Steve.Robb Improved readability and compliance with coding standards. Change 4159246 by Ben.Marsh UGS: Allow syncing projects where source code is not available (and various version files don't exist). #jira UE-60985 Change 4159286 by Ben.Marsh UGS: Remove requirement for UE4Editor.target.cs to be visible in the depot in order to open a project. #jira UE-60986 Change 4159302 by Ben.Marsh UGS: Update version to 1.144. Change 4160308 by Ben.Marsh All staging client executables for blueprint projects. #jira UE-60983 Change 4161567 by Steve.Robb GitHub #4816 : UE-60771: Handle escaped double quote in FParse::LineExtended Change 4162641 by Ben.Marsh UGS: Allow customizing the position of custom columns, via the Index=N attribute. Change 4162647 by Ben.Marsh UGS: Update version to 1.145. Change 4165319 by Robert.Manuszewski PR #4812: Fix inconsistent command-line argument handling under Windows (Contributed by adamrehn) Change 4166150 by Ben.Marsh UGS: Include *.inl when looking for code changes. Change 4166551 by Steve.Robb Whitespace fixes caused by a bad merge. Change 4168483 by Ben.Marsh UGS: Add a more useful error if a file to be synced exceeds the max allowed path length. Change 4168490 by Ben.Marsh UGS: Update version to 1.146. Change 4168551 by Ben.Marsh UBT: Move bBuildLargeAddressAwareBinary into an exposed setting. Change 4168560 by Ben.Marsh UBT: Remove static config variable for controlling which configuration of UHT to use. Change 4171296 by Ben.Marsh UGS: Move the check for overlong paths earlier. Change 4171531 by Ben.Marsh UBT: Fix exception if BuildConfiguration.xml contains an unknown category. Change 4183371 by Robert.Manuszewski Fix for a crash in Async Loading Graph's CheckCycles when GC kicks in on the game thread and forces ALT to exit early Change 4184312 by Ben.Marsh UGS: Update version to 1.148 Change 4184480 by Robert.Manuszewski Removing unused async loading stat Change 4186390 by Ben.Marsh UBT: Format XML validation errors in a format that allows double-clicking on the message in Visual Studio. Change 4188644 by Ben.Marsh UBT: Add the MakePathSafeToUseWithCommandLine() function to UBT. Change 4188647 by Ben.Marsh UBT: Fix exception in target receipt when architecture is null. Change 4189617 by Ben.Marsh Change FileSystemReference, FileReference and DirectoryReference objects to use OrdinalIgnoreCase comparisons without creating a separate copy of the string to compare. The filesystem does not use the invariant culture, and it can produce the wrong results in some cases (the ordinal comparison is faster, too). Change 4189740 by Ben.Marsh UAT: Remote code to build UnrealPak when packaging; we use the editor now. Change 4189860 by Ben.Marsh UGS: Make the filter for excluding automated lighting rebuilds more explicit. Change 4190082 by Ben.Marsh Fixes to allow enabling edit and continue for Windows builds. Have experienced quite a few VS crashes when testing it in editor; not yet recommended for general use. - Allow edit and continue for any configuration, not just debug. - Fixed PDB errors compiling files that use a shared PCH with edit and continue enabled. Path to the generated PDB file was using the wrong directory. - Removed code that tracks PDB output files, since they're modified multiple times during a build. - Enable debug information when compiling generated CPP files, since it causes errors if the shared PCH PDB doesn't have the same option. - Disable support for remote execution of steps that modify the PDB, since the same file has to be modified many times. Remote execution causes the PDB files to be corrupted. Unfortunately, this makes E&C builds significantly slower. #jira Change 4192949 by Ben.Marsh UBT: Minor tidy-up (merging UEBuildBinary.Build and UEBuildBinary.SetupOutputFiles) Change 4193218 by Ben.Marsh Fix formatting. Change 4197252 by Mike.Erwin UAT: Fix log output w/ correct count of non-code projects. #jira none Change 4197941 by Ben.Marsh UGS: Add support for DebugGame editors that have an executable with a DebugGame suffix. Change 4197964 by Ben.Marsh UGS: Prevent attempts to automatically reopen projects while a modal dialog is up, or the workspace is syncing. Change 4198144 by Ben.Marsh UGS: Prevent modal dialogs when login expires in P4, and prompt for password when hitting "retry". Change 4198413 by Ben.Marsh UGS: Always show the main window when launched manually, and run with -RestoreState when launched at startup. Also add a couple more places that save the visibility state, since logging off seems like it can terminate the process abrubtly. Change 4198779 by Ben.Marsh UBT: Allow generating manifests to any arbitrary locations with the -Manifest=<Path> argument. Change 4198825 by Ben.Marsh UBT: Move code to enumerate Slate runtime dependencies into the Slate module. Doesn't need to be done inside core UBT. Change 4199341 by Ben.Marsh UGS: Update version to 1.149 Change 4199642 by Chad.Garyet - Deprecate CISController - Add BuildController to replace CIS GET/POST for builds - Add LatestController, GET does what CIS/GET used to do - Change Latest/GET to return the last 25 builds filtered by project, rather than the last 5000 individual Ids - Latest/GET now returns "LatestData" object instead of array of longs - Updated EventMonitor to match all API changes - Fixed bug where IDs were getting reset to initial startup values every update loop Change 4199663 by Chad.Garyet CIS controller still needs to return an array of longs #jira none Change 4199680 by Ben.Marsh UGS: Update version to 1.150 Change 4200457 by Ben.Marsh Merging CIS fix for non-development configurations. Change 4200472 by Mike.Erwin UAT: fix -skipbuildclient param default It was defaulting to skipbuildeditor's value, likely a copy-paste error. #jira none Change 4202595 by Ben.Marsh Fix static analysis warning due to constant comparison against macro. Change 4203250 by Ben.Marsh UGS: Always show the "Sync Precompiled Editor" option, but disable it and show a tooltip explaining why if it is not available. Change 4206191 by Ben.Marsh Exclude editor target files from installed builds, since they leak info about DLLs that have been stripped out. Change 4213011 by Ben.Marsh UBT: Include contents of modified intermediate files in the log, to make it easier to debug hidden dependencies. Change 4213487 by Ben.Marsh UBT: Fix assumption that bPrecompile is equivalent to bBuildAllModules. This is no longer the case; they are now controlled by separate options. Should fix CIS errors building the editor. Change 4213609 by Ben.Marsh Ensure that strings formatted using FMicrosoftPlatformString::GetVarArgs() are always null terminated, whether we use the secure CRT or not. Change 4215971 by Ben.Marsh UBT: Remove action graph visualization code; no longer used. Change 4215996 by Ben.Marsh UBT: Remove unqiue id from all actions in the action graph. This is only used for printing debug info in the case of a (rare) cycle in the action graph, so just look it up when needed. Change 4216022 by Ben.Marsh UBT: Rename Crypto.cs to EncryptionAndSigning.cs to match the name of the class inside it, and move it under the System folder. Change 4216031 by Ben.Marsh UBT: Move all the action executors into their own folder in the project. Change 4216526 by Ben.Marsh Fix CIS warnings. Change 4216544 by Ben.Marsh Replace custom code to ensure FMicrosoftPlatformString::GetVarArgs() null terminates its buffer with Microsoft's standards-compliant implementation. Change 4216633 by Ben.Marsh Add support for UnrealPak plugins. * Project and plugin modules can now specify an array of supported programs in the "WhitelistPrograms" field of their module descriptors, to allow modules to be loaded by programs. * Programs can now load any runtime modules, as long as they are whitelisted. * Programs under the engine directory can now use a shared build environment, so that building with a project file does not cause output binaries to be output to the project directory. * UnrealPak is now always built by default when packaging * Convert UnrealPak to a modular configuration Change 4216736 by Ben.Marsh UnrealPak: Move "ExportDependencies" command into an editor commandlet, since it relies on the UObject system, asset registry, etc... Change 4217447 by Ben.Marsh Back out revision 50 from //UE4/Dev-Core/Engine/Build/InstalledEngineBuild.xml Change 4217451 by Ben.Marsh Back out revision 11 from //UE4/Dev-Core/Engine/Plugins/Developer/VisualStudioSourceCodeAccess/Source/VisualStudioSourceCodeAccess/VisualStudioSourceCodeAccess.Build.cs Change 4217617 by Ben.Marsh Back out changelist 4217451 Change 4222552 by Ben.Marsh Don't use #import <TypeLib> for VS source code accessor when building with Clang; it's not supported. Change 4222630 by Ben.Marsh UBT: Fix spam while generating project files if Clang isn't installed. Change 4223316 by Ben.Marsh UBT: Change the order in which Visual C++ toolchains are enumerated to prefer full releases over preview releases. Change 4223318 by Ben.Marsh UBT: Add a build setting which allows creating a dedicated PCH for every file that's excluded from the unity working set (disabled by default). Improves iteration times when working on individual cpp files, but slows down iterating on header changes (and can take a lot of disk space for large changes). Dedicated PCH contains all includes scraped from the top of each cpp file, until a non-#include directive is encountered. Change 4223401 by Ben.Marsh UBT: Add an option to automatically enable edit and continue for files in the adaptive non-unity working set. E&C doesn't seem very useful for UE4 projects right now; compile time is comparable to regular build times, but it can take several minutes to apply code changes for large projects. Change 4223899 by Ben.Marsh UBT: Fix loading XML config files on Mono; Type.GetField(Name) does not seem to return values unless binding flags are specified. Change 4224637 by Ben.Marsh Add a "SupportedPrograms" field to plugin descriptors, which allows plugins to declare which plugins they support independently of individual modules. Programs now respect the "bEnabledByDefault" setting in plugins. Plugins that are compatible with a program now need to list that program in the SupportedPrograms list, and whitelist any modules that should load for that program. Change 4224710 by Ben.Marsh UBT: Don't add import libraries as final build products unless the target is being precompiled. Prevents the need for building them for leaf nodes in the action graph. Change 4224715 by Ben.Marsh UBT: Remove hack to allow Stats2.cpp to not follow IWYU convention. Change 4224726 by Ben.Marsh Remove commented out line. Change 4224903 by Ben.Marsh Fix non-unity compile error in Stats2.h. Change 4225051 by Ben.Marsh Back out changelist 4224710; causing CIS errors due to receipts not matching. Change 4225134 by Ben.Marsh Fixing non-unity errors. Change 4225203 by Ben.Marsh Another non-unity fix. Change 4225249 by Ben.Marsh Fix Linux dependencies being copied for the Windows editor; they can be added as requirements for the Linux target platform on Windows instead, so it respects the user's chosen platforms. #jira UE-62001 Change 4225512 by Ben.Marsh BuildGraph: Allow setting the target to build when using the <CsCompile> task. Change 4228815 by Ben.Marsh UBT: Always add the generated code directory to the list of include paths when generating project files. It may only be created after UHT has been run. Change 4228944 by Ben.Marsh UBT: Remove legacy CppCompileEnvironment and LinkEnvironment wrappers from TargetRules that were deprecated in 4.19. Change 4229028 by Ben.Marsh UBT: Fix editor targets with unique build environment having the wrong executable path in generated project files. Move move logic to configure target rules post-construction by the rules assembly to ensure it's valid. Change 4229065 by Ben.Marsh UBT: Move another target setting into the rules assembly. Change 4229105 by Ben.Marsh Fix BPT exception when generating project files. Change 4229311 by Ben.Marsh UBT: Store the module rules file location on the ModuleRules instance, as well as the plugin that it was created from. Also expose the plugin directory as a property on the ModuleRules instance. Change 4229421 by Ben.Marsh UBT: Consolidate functionality for UHT module setup in ExternalExecution.cs. Change 4229817 by Ben.Marsh UBT: Modules must now explicitly specify the path to the header used to generate a PCH if one is desired, rather than the header being determined automatically by attempting to parse the source code. Now that PCHs are force-included anyway, this removes a lot of dependencies inside UBT. Change 4229824 by Ben.Marsh UBT: Remove unused lists inside UEBuildModuleCPP.SourceFilesClass. Change 4229841 by Ben.Marsh UBT: Remove some legacy code from auto-detecting PCHs. Change 4230521 by Ben.Marsh UBT: Add utility functions to the log class to allow formatting errors and warnings in Visual Studio output format (eg. File(Line): warning: Message) Change 4230871 by Ben.Marsh UAT: Remove StreamUtilis utility class; there is a simpler way to implement the one place it's used. Change 4230882 by Ben.Marsh UAT: Add StreamUtils back into UAT, seems like it's still used there. Change 4230896 by Ben.Marsh UBT: Remove some redundant parameters from UEBuildModule/UEBuildModuleCPP/UEBuildModuleExternal constructors. Change 4231014 by Ben.Marsh WorkspaceTool: Include a dump of raw bytes when garbage is read from the P4 process, for diagnostic purposes. Change 4231032 by Ben.Marsh Fix CIS. Change 4231096 by Ben.Marsh Bump the FlatCPPIncludeDependencyCache version, to prevent errors trying to load old files. Change 4231446 by Ben.Marsh UBT: Added support for expanding UE-specific variables in include paths and library paths: $(EngineDir), $(ProjectDir), $(PluginDir), $(ModuleDir). Change 4231460 by Ben.Marsh Modules may now explicitly specify rpaths on Linux via the PublicRuntimeLibraryPaths and PrivateRuntimeLibraryPaths properties. Change 4233909 by Robert.Manuszewski PR #4779: Reason fails as the supplied variable is incorrect (Contributed by projectgheist) Change 4233910 by Ben.Marsh Enable PCHs on IOS. Reduces build time by ~25%. Change 4234176 by Ben.Marsh UBT: Add better messaging for modules that need to have a private PCH set. Now detects the likely PCH using the same method as legacy code and includes it as a suggestion. Change 4234193 by Ben.Marsh Add the Delete command to Perforce wrapper in DotNETUtilities. Change 4234688 by Ben.Marsh UBT: Simplify handling of installed/precompiled builds. Settings for whether a folder is installed/read-only or not is now stored on the RulesAssembly instance, allowing multiple things to be configured separately and stacked together (eg. engine/enterprise/project). RulesAssembly.IsReadOnly() allows determining if a flie can be modified or not and replaces many previous IsXXXInstalledCalls(), and traverses the chain of assemblies. Change 4234711 by Ben.Marsh UBT: Runtime dependencies can now be copied to output directories as part of the build. When adding a runtime dependency, an optional source location can be specified to copy from. Both the source and target paths can use variables can be used as part of the path, eg. $(OutputDir), $(ModuleDir), $(PluginDir). Example usage (from a .build.cs file): RuntimeDependencies.Add("$(OutputDir)/Foo.dll", "$(PluginDir)/Source/ThirdParty/Foo.dll", StagedFileType.NonUFS); Change 4234872 by Ben.Marsh Expose a flag for whether the engine is installed, to fix issues generating project files. Change 4234929 by Ben.Marsh Fix null reference generating receipts when UBT makefiles are active. Change 4235883 by Chad.Garyet Merging 4231245 to core Giving Coordinator its own sln. This should fix what 4158155 was supposed to. #jira UE-61955 Change 4236075 by Ben.Marsh CIS fix Change 4237066 by Robert.Manuszewski Fix for a potential crash when terminating the engine while it's being initialized #jira UE-60545 Change 4237078 by Robert.Manuszewski The engine will no longer be resetting all linkers causing massive load times when renaming the world package when entering Play In Editor Change 4237116 by Ben.Marsh Rewrite some Windows utility functions to support paths longer than MAX_PATH. Change 4237158 by Ben.Marsh Add const TCHAR* overloads of FString::RemoveFromStart() and FString::RemoveFromEnd(). Change 4237159 by Ben.Marsh Fix FWindowsPlatformFile::GetFilenameOnDisk() support for paths longer than MAX_PATH, and simplify some of the other long path functions to avoid copying string buffers. Change 4239050 by Ben.Marsh Missing file Change 4239318 by Ben.Marsh Linux CIS fix. Change 4239685 by Ben.Marsh Static analysis CIS fix. Change 4240800 by Ben.Marsh WorkspaceTool: Include the full command line in the log for any P4 commands. Change 4240903 by Ben.Marsh PR #4909: Update copyright notices to 2018 (Contributed by projectgheist) Change 4241025 by Ben.Marsh UBT: Exclude mobile pipeline caches from generated project files. Causes huge slowdown when using 'Find in Files' through the IDE. Change 4241770 by Ben.Marsh UBT: Include action number in parallel executor output. #jira UE-62032 Change 4243469 by Ben.Marsh TBA: Merge FAnnotatedStructuredArchiveFormatter with FStructuredArchiveFormatter. Any functions that are only implemented for text archives now have a _TextOnly suffix, and are exposed through the FStructuredArchive interface. Change 4245723 by Robert.Manuszewski Fixing another creash when terminating the engine while initializing. #jira UE-60545 Change 4245862 by Steve.Robb VectorLoadFloat2(Ptr) added, which loads { Ptr[0], Ptr[1], Ptr[0], Ptr[1] } into a VectorRegister. Change 4246412 by Robert.Manuszewski The warning 'Calling StaticLoadObject during PostLoad may result in hitches during streaming' will now also report the object which had the PostLoad called on it when StaticLoadObject call happened. Change 4246612 by Ben.Marsh UBT: Fix spelling of "Intellisense". Change 4249454 by Robert.Manuszewski Added extra checks to catch scenarios where the EDL Precache Buffer is flushed before a package header is fully read Change 4249513 by Robert.Manuszewski Made sure the Async Loading Thread doesn't continue running after creating new async packages when garbage collector wants to run on the game thread Change 4255207 by Ben.Marsh UGS: Add additional logging whenever a P4 command fails, and when the user is logged out. Change 4255288 by Ben.Marsh PR #4921: Honor ModuleRules' bEnableExceptions flag when creating precompiled h. (Contributed by surakin) Change 4256422 by Ben.Marsh UBT: Add an error if a module referenced by a plugin descriptor doesn't exist. Change 4257385 by Robert.Manuszewski Creating new objects from within ForEachObjectWithOuter will now result in a fatal error as it's unsafe to change internal UObject hash tables when iterating over them. Change 4257454 by Robert.Manuszewski Added the option to filter clusters listed with gc.ListClusters by objects within them. Usage: gc.ListClusters Hierachy With=ObjectName1,ObjectName2... Change 4257526 by Robert.Manuszewski It's now possible to filter clusters that get logged with verbose cluster logging enabled (UE_GCCLUSTER_VERBOSE_LOGGING=1) by objects within them by specifying -DumpClustersWithObjects=ObjectName1,ObjectName2 in the command line Change 4257822 by Ben.Marsh Fixes for PlatformShowcase compile errors. Change 4258771 by Ben.Marsh UBT: Fix project files not being generated for foreign projects when creating .stub files. #jira UE-62462 Change 4258790 by Ben.Marsh UBT: Clean up the logic around generating project files before creating a stub IPA, so that it fails loudly if project files do not exist, and can accept target names not matching project names. Change 4259276 by Ben.Marsh UBT: Make it an error if a framework doesn't exist, rather than failing silently. Also remove some remote toolchain stuff that's no longer necessary. Change 4259280 by Ben.Marsh UBT: Fix embedded framework zips not being uploaded for plugins. #jira UE-62485 Change 4260236 by Ben.Marsh UBT: Fix path to generated engine project file. Change 4260334 by Ben.Marsh UGS: Fix custom build steps dialog inadvertantly modifying config file settings in-place. Change 4260361 by Ben.Marsh UGS: Allow for p4 login commands to fail, even though the user is logged in (due to a bad connection, etc...) Change 4260559 by Ben.Marsh UGS: Update version. Change 4261160 by Robert.Manuszewski MediaPlaylist will now be added to root set if the owning MediaPlayer is in the disregard for GC set (fixes GC assumption violation crash) #jira UE-62495 Change 4261421 by Ben.Marsh Force-sync files for building documentation, to fix issues with files not being updated. #jira UE-62413 Change 4261425 by Ben.Marsh UBT: Remove some leftover functions for handling the remote toolchain. Change 4261530 by Ben.Marsh UBT: Speculative fix (and better error reporting) for IOS mobile provision not being found in CIS. Change 4261611 by Ben.Marsh UBT: Downgrade warning to a log message, since it appears when generating project files. Change 4261710 by Ben.Marsh Remove assert that GLogConsole is set; it won't be for command line utilities that don't depend on ApplicationCore. #jira UE-62545 Change 4261831 by Ben.Marsh Fix compile errors due to missing include path when hot-reloading a module from the editor. There are not necessarily source files to compile when -modulewithsuffix is specified on the command line, which was results in GeneratedCodeWildcard not being set. #jira UE-62463, UE-62384 Change 4262723 by Ben.Marsh Whitelist plugins that need to be loaded by UFE. #jira UE-62564 Change 4265444 by Ben.Marsh Fix incorrect executable name for DebugGame configurations in Xcode. #jira UE-62574 Change 4265892 by Ben.Marsh Fix incremental compile failures due to dependency checking for unity files. CachedIncludePaths was not correctly being set on file items, so dependencies were being ignored. #jira UE-62575, UE-62603, UE-62597 Change 4266019 by Josh.Adams - Fixed the CopyAction for runtime dependencies that need to be copied to different location, on non-XGE Change 4266264 by Ben.Marsh Remove override for the __IPHONE_OS_VERSION_MIN_REQUIRED macro on TVOS. This macro is already defined by system headers (in <AvailabilityInternal.h>). Now that we support PCHs on IOS and TVOS, manually defining this macro results in it being defined three times (once for the PCH, once by AvailabilityInternal.h, and once by the force-included list of definitions for the source file being built). The errors for redefining the macro in AvailabilityInternal.h are suppressed due to it being a system header, but the error for redefining it for the source file being compiled are not. #jira UE-62578 Change 4266273 by Ben.Marsh Fixes incremental build failure when compile arguments for PCH have changed on IOS/TVOS. Compile action needs to have a dependency on PCH build action. Change 4266614 by Graeme.Thornton Fix crash when cooking nativized blueprints due to removal of child cooker system. Change 4266763 by Ben.Marsh Always build UnrealPak when building client targets. The ProjectParams.Pak option is not reliable, because it can be forced on later by the target platform. #jira UE-62584 Change 4267985 by Robert.Manuszewski When iterating with ForEachObjectWithouter, don't lock the entire has table but only the hash bucket that is currently being iterated #jira UE-62600 Change 4268558 by Robert.Manuszewski PurgeLegacyBlueprints will no longer be called from within ForEachObjectWithOuter is it renames objects that reside in hash tables that are being iterated over which may lead to undefined behavior. #jira UE-62600 Change 4269011 by Chad.Garyet - Fixing Wildcard match issue, the change to ugsapi sends projects as //Depot/Stream instead of //Depot/Stream/ Wildcard match was only substringing to 3 chars. - Checking in the change a while back that increases the number of queried jobs up to 432 based on some maths from Bob about how many builds we want to grab Published to ugsapi server 8/8/17 #jira none Change 4270788 by Ben.Marsh Fix IOS provisioning data being using when remote compiling on TVOS. #jira UE-62705 Change 4271916 by Ben.Marsh Tag the XGEControlWorker executable as a build product after compiling SCW, to make sure it's included in the UGS zip file. Change 4271934 by Ben.Marsh Upload all static libraries in plugin folders as part of remote builds. #jira UE-62694 Change 4273368 by Ben.Marsh Fix Slate dependencies not being enumerated, and rules assembly not being rebuilt when building remotely. #jira UE-62705 Change 4274049 by Ben.Marsh Always parse the team UUID out of the mobile provision when doing a remote compile. The provision installed on the remote Mac (and selected for signing) may be different. #jira UE-62751 Change 4274823 by Ben.Marsh Add the -VersionCookedContent argument to disable the -unversioned parameter on the cooker command line. Change 4275838 by Ben.Marsh Fix BuildVersion string not being passed through from <SetVersion> task. Also add a -BuildVersion command line argument to UBT to override it for a particular build. Change 4275913 by Ben.Marsh Add a dummy exported symbol to the XGEController module, to fix build errors due to missing .lib file when it's built with WITH_XGE_CONTROLLER = 0. Change 4284161 by Ben.Marsh Allow mirroring Oodle files to remote Mac. Change 4074774 by Steve.Robb Vast simplification of TFunction, making it smaller in footprint, easier to follow and extend, and more correct. TUniqueFunction added, which is a move-only TFunction which can hold move-only functors. Fix for UWidgetBlueprint::ForEachSourceWidget() which should never have compiled but did. FFunctionGraphTask and TFuture<> updated to use TUniqueFunction to make them more general. TArray::HeapPop() made to work with move-only types. Change 4082591 by Ben.Marsh Move the Log class from UBT to DotNetUtilities. Change 4083236 by Ben.Marsh Add a Log.WriteException() method to dump an exception message to the console (and write the exception trace to the log) Change 4084107 by Ben.Marsh UAT: Remove the unused -SkipHeader argument to UE4Build. Change 4089771 by Steve.Robb GitHub #4743 : modified VirtualAlloc function flag https://blogs.msdn.microsoft.com/oldnewthing/20151008-00/?p=91411 Change 4091456 by Steve.Robb Unification of all platforms' FMath::CountTrailingZeros() and FMath::CountLeadingZeros() for both 32-bit and 64-bit. Change 4156437 by Ben.Marsh Lots and lots of fixes compiling for Clang on Windows. Editor now compiles cleanly without warnings, but crashes on startup due to error in intrinsics test. Disabling that runs further, but crashes accessing freed memory. Switching to the ANSI allocator runs further, but crashes in Slate after the splash screen and before the editor window opens. // TODO! * Switching between Clang/ICL/VS2015/VS2017 is now supported through the same mechanism as switching Visual Studio versions, without requiring any source level changes. To use Clang, set WindowsPlatform.Compiler = WindowsCompiler.Clang from a .target.cs file, or set <WindowsPlatform><Compiler>Clang</Compiler></WindowsPlatform> from BuildConfiguration.xml. To pick a specific toolchain version, set WindowsPlatform.CompilerVersion. * Clang is now supported through AutoSDKs; will be added to CIS. * The Samples/Sandbox/Clang project forces Clang to be used from its target.cs file, and allows easily building all editor modules and plugins with Clang on Windows. * UnrealMathSSE intrinsics have been re-enabled for Clang due to missing functions from the UnrealMathFPU implementation, but causes failure in tests at startup. * SSE4_CRC32() is disabled in D3D12Pipelinestate.cpp, since intrinsics are only allowed if enabled for the whole target (rather than being used in specific functions due to runtime checks) Change 4157389 by Ben.Marsh Few more fixes for compiling the editor with Clang. Change 4183911 by Ben.Marsh Fixes to support incremental linking on Windows. Does not seem to have any net benefit right now; may improve once minimal rebuild is enabled. * Incremental linking no longer forces PDB files to be enabled for source files. * Actions can specify specific files to be deleted before each build. Code to forcibly delete PDB files has been moved to the MSVC toolchain. * Unused libraries produced by the cross-referenced link are no longer added as build products, since (a) deleting them breaks dependency checking for incremental linking and causes a full link, and (b) not deleting them breaks UBT dependency checking and causes actions to be run over and over again. * Icon update is disabled for Windows when incremental linking is enabled. * Removed rarely-used setting to always delete produced items before each build. Change 4184311 by Ben.Marsh UGS: Added a dialog which shows all the required platform SDKs for a branch, linked from the status panel in UGS. The llist is configured via the UGS config file submitted to Engine/Programs/UnrealGameSync/UnrealGameSync.ini (and may be overridden by the project config file if necessary): [Default] ; Set this to a network share which contains the SDK installers for your site SdkInstallerDir= ; All the required SDKs for the current version of the engine +SdkInfo=(Category="Android", Description="NDK r21", Browse="$(SdkInstallerDir)\\Android") +SdkInfo=(Category="Windows", Description="Visual Studio 2017") +SdkInfo=(Category="Windows", Description="Visual C++ Toolchain 14.13.26128") +SdkInfo=(Category="Windows", Description="Windows SDK 10.0.16299.0") Similar entries for console platforms are added in console subdirectories. Each entry may contain an Install="Foo.exe" and/or Browse="C:\Foo" style attribute, specifying the path to an installer to run or directory to open in explorer respectively. The SdkInstallerDir setting is used as a base directory for the default installers, seen above for Android. Licensees may override this with a network path specific to the site that UGS is being deployed to (either in this file, in a project specific config file, or in a Engine/Programs/UnrealGameSync/NotForLicensees/UnrealGameSync.ini file). Change 4200452 by Ben.Marsh UBT: Change DebugGame configurations to output a separate executable rather than requiring a -Debug argument at runtime. Previous behavior was a common source of errors. Engine modules are still shared between Development and DebugGame, but the launch module sets a flag in Core on startup indicating the game configuration. Change 4206189 by Ben.Marsh UBT: Simplify logic for precompiling binaries. * Target no longer has separate list of "precompile only" binaries or modules. New -AllModules option allows adding every module to a target, which can be used with -Precompile and -NoLink to precompile object files for monolithic builds. * Precompiled file lists have been removed from target receipts. * The manifest now includes all generated headers and precompiled files when run with the -Precompile option. * Separate -DependencyList=Foo.txt has been added to write a list of all dependencies required to use precompiled binaries. This file list can be read using the <Tag> task in buildgraph. Change 4215466 by Ben.Marsh UBT: Remove indirect calls to determine extensions for object files and precompiled headers. The toolchain knows the correct convention for the platform. Change 4215975 by Ben.Marsh UBT: Remove telemetry code. This has never proved useful for analyzing performance due to the number of incidental factors that affect build times (eg. number of files being compiled). Change 4220154 by Ben.Marsh Move text-only implementations of FOutputDeviceError back into Core, so we can build command-line applications that don't depend on ApplicationCore. Change 4224708 by Ben.Marsh Add a bCompileAgainstApplicationCore setting to the target rules, which allows compiling out references to the ApplicationCore module (which should only be necessary for applications with a GUI). Removed ApplicationCore from several engine tools and utilities. Change 4224958 by Ben.Marsh Remove CoreMinimal.h includes from Core. Change 4229059 by Ben.Marsh UBT: Remove the UEBuildPlatform.ShouldNotBuildEditor() hook for target platforms. We shouldn't be modifying a target's build environment to disable the editor; it is invalid to build the editor for these target platforms at all, and this is already enforced by the GetSupportedPlatforms() function. Change 4230508 by Ben.Marsh Fixup precompiled header setting for samples and games. Change 4231457 by Ben.Marsh Fix exceptions in log messages having trailing newlines. Change 4232406 by Ben.Marsh UBT: Always force include a PCH for generated code if there's one set; the code may depend on it to compile. Change 4234177 by Ben.Marsh Set up private PCH files everywhere that previously used them. Change 4235973 by Ben.Marsh Change FPlatformMisc::GetEnvironmentVariable() to return an FString() rather than requiring a fixed size buffer to be passed in. Removes references to MAX_PATH. Change 4238842 by Ben.Marsh Add support for paths longer than MAX_PATH in the editor. Requires Windows 10 version 1607, and the functionality to be enabled via a registry key or group policy (see https://docs.microsoft.com/en-us/windows/desktop/FileIO/naming-a-file). Only a subset of Win32 functions support long paths (executables can only be started from paths shorter than MAX_PATH, for example). * Added a FPlatformMisc::GetMaxPathLength() function to return the maximum length of a path on the current system. On Windows, this returns a different value for systems with long paths enabled to those without. * The MAX_PATH define is no longer set by non-Windows platforms. Instead, there is a MAC_MAX_PATH, UNIX_MAX_PATH, etc... for any platform-specific code that still relies on the previous macro. * The MAX_UNREAL_FILENAME_LENGTH macro has been renamed to MAX_UNREAL_FILENAME_LENGTH_DEPRECATED * The PLATFORM_MAX_FILEPATH_LENGTH macro has been renamed to PLATFORM_MAX_FILEPATH_LENGTH_DEPRECATED. * Removed custom resource files for programs, since they are just copies of the base UE4 one (which is used by default anyway). The base UE4 manifest declares support for long paths. * Fix 512 character maximum length on editor commands. 260 character limit remains in place for cooking at the moment (see ContentBrowserUtils.h), until C# staging code supports long paths. Change 4255042 by Ben.Marsh UBT: Remote compilation now uploads the entire workspace to the remote Mac and executes a separate remote instance of UBT rather than synchronizing individual actions. This makes the remote compile codepath much simpler, and removes a lot of special cases that exist to support it previously. The list of files to be transferred to the remote are listed as rsync filter rules in Engine/Build/Rsync/RsyncEngine.txt and RsyncProject.txt, which are applied to the root engine directory and project directory respectively. Projects that need to customize which files are uploaded can add their own <ProjectDir>/Build/Rsync/RsyncProject.txt file, which will be included in the filter before the default version. Change 4260567 by Ben.Marsh UAT: Rename CommandUtils.Log to CommandUtils.LogInformation, to avoid conflicts with the underlying Tools.DotNETCommon.Log class. #rb none [CL 4285673 by Ben Marsh in Main branch]
2018-08-14 18:32:34 -04:00
LogInformation("Client logging process started...{0}", ClientLogFile);
ClientProcessLog = File.Open(ClientLogFile, FileMode.Open, FileAccess.Read, FileShare.ReadWrite);
ClientLogReader = new StreamReader(ClientProcessLog);
}
}
else if (ClientProcess == null && !ServerProcess.HasExited)
{
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 4285612) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3836829 by Ben.Marsh UBT: Fix ability to precompile plugins from installed engine builds. Change 3839519 by Ben.Marsh UBT: Simplify configuring bPrecompile and bUsePrecompile settings for modules. Each rules assembly can now be configured as installed, which defaults the module rules it creates to use precompiled data. Change 4042043 by Steve.Robb GitHub #4705 : Added weak lambda's for delegates and multicast delegates. Change 4042056 by Robert.Manuszewski Optimized Mark Phase of GC by up to 10ms by making it run in parallel and removing a huge array presize which we didn't need. Change 4042104 by Robert.Manuszewski Set the minimum GC cluster size to 5 so that GC doesn't have to process micro clusters which are more expensive than processing individual objects + Exposed the minimum cluster size to ini and project settings as gc.MinGCClusterSize + Added the ability to sort clusters by name/object count/mutable object count/referenced clusters count when dumping them with gc.ListClusters command Change 4042377 by Robert.Manuszewski Reworked how GC and other threads (ALT specifically) interact - GC will now notify the ALT it wants to run and ALT will immediately try to finish its current work to allow that. Also the entire ALT tick is now protected against GC running at the same time to improve ALT stability. + added gc.ForceCollectGarbageEveryFrame console variable that triggers a forced GC every frame Change 4042427 by Robert.Manuszewski Changed FGCCSyncObject to use events when waiting for GC to finish so that it doesn't spin on non-game threads when GC is running Change 4042482 by Robert.Manuszewski Unhashing unreachable objects (ConditionalBeginDestroy) will now also be done incrementally, just like the purge phase of Garbage Collection Change 4042635 by Robert.Manuszewski Fix for a potential assert when incremental purge garbage is pending and something forces a full purge Change 4044092 by Steve.Robb Fix for forward declared CoreUObject weakobject types in delegates when building in Clang. Change 4044102 by Robert.Manuszewski Fix for a possible hang when worker threads are preventing GC from running and something is later trying to FlushAsyncLoading with the Async Loading Thread enabled Change 4044113 by Steve.Robb Another Clang fix. Change 4044160 by Robert.Manuszewski Disregard For GC pool will now be enabled by default in cooked builds Change 4044287 by Steve.Robb Typo fix. Change 4047723 by Graeme.Thornton TBA: Fixes for import/export name cache and object resolving Change 4048015 by Graeme.Thornton TBA: Weak/Soft/Lazy pointer serialization changes * Remove FWeakObjectPtr::Serialize, move it's logic into, and replace usages of with calls to, FArchiveUObject::SerializeWeakObjectPtr(). Ensures that something is always sent to the archive so that structured archives can be kept happy in the future. * Added Weak/Soft/Lazy pointer handling to the structured archive slot interface and all the formatters. Binary formatters just forward the call onto their inner and text archives store as a string path reference. * FArchiveUObjectFromStructuredArchive caches all these pointer types and stores indices in the binary block, same as with a UObject*. All pointers are then forwarded to the underlying formatter in one go on finalization. Change 4048021 by Steve.Robb Fix for binding an unbound TFunction to another TFunction with a different signature. Also all null pointers now count as unbindings, not just nullptr. TIsMemberPointer added. TIsATFunction and TIsATFunctionRef renamed to remove the 'A's. Change 4048544 by Robert.Manuszewski Fixing ConditionalBeginDestroy profiling after changes to incremental CBD. Change 4051028 by Graeme.Thornton TBA: ArchiveFromStructuredArchive adapter uses Inner to determine if it is outputting to text, and sets it's own ArIsTextFormat to false Change 4051056 by Graeme.Thornton TBA: High level tagged property / UObject base class text serialization - UObject serialize converted to structured archive - Properties written to text individually with text tags, and then binary adapted values - Only saves, doesn't load Change 4051111 by Graeme.Thornton TBA: Temporarily disable loading of text assets until tagged property serialization path is fixed up Change 4051154 by Graeme.Thornton TBA: Convert a few uobject serializers to structured archive format for example purposes Change 4051181 by Graeme.Thornton TBA: Added default structured archive implementation of SerializeItem to UProperty, which just calls the FArchive version on an FArchiveUObjectFromStructuredArchive adapter. Implemented structured archive SerializeItem for UArrayProperty Change 4051197 by Graeme.Thornton TBA: ObjectProperty text serialization Change 4051216 by Graeme.Thornton Restored a modified FWeakObjectPtr::Serialize function to keep backwards compatibility in code I don't have access to. Change 4051261 by Graeme.Thornton TBA: Convert UMetaData to structured archive Change 4051374 by Steve.Robb Incorrect assert removed. Change 4051562 by Robert.Manuszewski Adding stats for the new GC internal functions Change 4051614 by Graeme.Thornton TBA: Removed UProperty::SerializeItem(FArchive, ...) and replaced with UProperty::SerializeItem(FStructuredArchive::FSlot, ...). Fixed up most of them to work properly and added adapters in for any that were non-trivial. Change 4052512 by Graeme.Thornton TBA: Temporary workaround for softobjectptr and lazyobjectptr uproperties not serialization anything when they know the archive is a reference collector. They should always be serializing their pointers and letting the underlying archive itself ignore them. Change 4053917 by Robert.Manuszewski Clustered objects from clusters that are no longer reachable will now be marked as unreachable immediately when gathering unreachable objects Change 4053919 by Robert.Manuszewski Added the ability to disable incremental BeginDestroy in ini/project settings Change 4055518 by Daniel.Lamb Fixup for deterministic audio generation issue. Submitted on behalf of Rich.Whitehouse #jira nojira #test prefilght automated test. Change 4056854 by Graeme.Thornton TBA: Added a test asset to EngineTest which contains all the different property types and test cases. Change 4056858 by Graeme.Thornton TBA: Updated USetProperty to proper structured archive usage Change 4056872 by Graeme.Thornton TBA: Add map property field to test object Change 4056873 by Graeme.Thornton TBA: Convert UMapProperty to full structured archive Change 4056994 by Graeme.Thornton TBA: Converted FText over to structured archive. Implemented saving, but not loading. Change 4059728 by Ben.Marsh UBT: Add support for using adaptive non-unity builds when the engine and project are in separate repositories. Change 4059805 by Graeme.Thornton Fixed typo in text serialization. Fixes CIS automation test errors Change 4060007 by Graeme.Thornton TBA: FArchiveFromStructuredArchive will now access it's host slot lazily, i.e. only when a value is actually written to the archive. Change 4060092 by Stefan.Boberg Added optimized Windows console window output path to GenericConsoleOutput since this slowed down cooking considerably (2 minutes spent in wprintf alone for one large dataset) When stdout is attached to a console we use the WriteConsoleW function instead of wprintf since the latter is very slow especially in unbuffered mode which the engine currently configures for stdout (see setvbuf call in LaunchEngineLoop.cpp). At some point we should reconsider this buffering policy since it's likely to slow down other platforms as well but I wanted to do a safe change for now as I don't yet fully understand why the setvbuf call is there in the first place. Change 4060108 by Stefan.Boberg Introduced some additional target platform utilities to help with asset cook optimizations * We now assign each ITargetPlatform a zero-based ordinal value * Introduced FTargetPlatform and FTargetPlatformSet types to help store platform references and platform sets efficiently. These are not currently used in the engine but are designed to replace the existing ITargetPlatform/string/FName representations in the cooking data structures. Change 4060143 by Graeme.Thornton Undo //UE4/Dev-Core/Engine/Source/Runtime/... changelist 4060007 Needs some other changes that I haven't checked in yet... Change 4062432 by Ben.Marsh Fix error message when enumerating P4 changes. Change 4062648 by Ben.Marsh Add missing p4 integration action. Change 4063620 by Graeme.Thornton Integrated a fix from UDN where the engine would crash when trying to load a very small encrypted file (<16bytes) from a pak file, where the read address wasn't already aligned to the AES block size. (https://udn.unrealengine.com/questions/431989/crash-while-reading-a-very-small-file-in-encrypted.html) Change 4066963 by Robert.Manuszewski Fixing GC cluster verification code reporting false positives when a cluster is referencing another cluster through 'mutable' objects list. Change 4067133 by Robert.Manuszewski Changed log verbosity when reporting individual cases of GC cluster assumption violations as they are followed by an asser anyway and this way we get the chance to see all issues before we assert at the end of these checks. Change 4067443 by Steve.Robb FString can now be constructed from any char pointer type and length. Change 4068156 by Steve.Robb Fix necessary because of FString constructor change in CL# 4067443. Change 4070258 by Graeme.Thornton Fixes for VSCode Change 4070372 by Graeme.Thornton TBA: Script struct serialization to structured archives Change 4071913 by Ben.Marsh Move bulk of the code for UnrealPak into an engine developer module, so it can be used in the editor. Change 4071914 by Ben.Marsh Missing files. Change 4071937 by Ben.Marsh Missing header. Change 4072015 by Ben.Marsh Fixes for compiling PakFileUtilities as part of the editor. Change 4072826 by Steve.Robb TBitArray::Reserve() added. TBitArray::Add() overloaded to allow adding multiple bits. TSparseArray::Reserve() optimized to call the overloaded Add(). Change 4073271 by Daniel.Lamb Fixed add patch tier in project launcher passing the wrong commandline option to UAT. #test none Change 4074708 by James.Hopkin #core Removed redundant Casts Change 4074763 by Steve.Robb Fix for TSparseArray::Reserve() size. Change 4076063 by Ben.Marsh Add an "UnrealPak" commandlet with the same functionality as the standalone UnrealPak program. Invoke by running the editor with -run=UnrealPak and the standard UnrealPak commandline options. Change 4077064 by Robert.Manuszewski Fixing compile error in PakFileUtilities Change 4077144 by Graeme.Thornton TBA: TextAssetCommandlet improvements * Collect lists of broken assets during roundtrip tests and print a summary of packages that failed each phase at the end * After resaving as text, load the file back as a plain JSON hierarchy to ensure the output was valid Change 4077412 by Ben.Marsh Set the correct exit code for UnrealPak. Should return 0 on success, not 1. Change 4077760 by Graeme.Thornton TBA: Loading fixed for tagged property serialization Includes conversion of all UProperty::ConvertFromType() and SerializeFromMismatchedTag() functions to use structured archives Lazy initialization of FArchiveFromStructruredArchive when loading, to support the possibility of an adapter being create around an object property serialize call to its inner UStruct, which then decides not to do anything and return false. Stops the ArchiveFromStructuredArchive from consuming the slot and getting upset later on when we try to serialize normal tagged properties from it. Disabled lazy bulk data loading from text assets. Requires a bigger change to make it work. Added some debug checks to json input formatter which track the current value stack size when a new object is pushed onto the stack, and makes sure that the stack has returned to the same size when the object is popped. Catches cases where we unpack an array/stream to the value stack but then don't consume all the items. Change 4078800 by Ben.Marsh Change UAT to using the editor's UnrealPak commandlet rather than invoking the standalone UnrealPak executable. To improve performance when building several PAK files, also add a new -batch=<file> command which reads commands to execute in parallel from a text file. Change 4079745 by Graeme.Thornton TBA: Migrated a couple of UObject Serialize functions to FStructuredArchive (SoundCue / MaterialExpressions / Editor strip flags) Change 4079847 by Graeme.Thornton TBA: Add 'FindMismatchedSerializers' mode to text asset commandlet, which dumps out a list of all UClasses which don't have the CLASS_MatchedSerializers flag, meaning we can't guarantee the have Serialize functions for FArchive AND FStructuredArchive, therefore we can't use the new structured archive based serialize path. Should only ever be native instrinsic classes as UHT takes care of all other cases. Change 4079925 by Ben.Marsh Fix incorrect assignment when deriving name for chunked pak file. Change 4080214 by Ben.Marsh Move the ThreadPoolWorkQueue class into DotNETUtilities so it can be used by other projects. Change 4082394 by Graeme.Thornton CIS fix for variable shadowing warning Change 4082583 by Ben.Marsh Add a IBinarySerializable interface for types that support reading from a BinaryReader and writing to a BinaryWriter. Implementing IBinarySerializable implies a constructor taking a BinaryReader argument is available for deserializing. Change 4082652 by Ben.Marsh Fix FileReference.Directory not returning a directory with a trailing backslash for files in the root directory. Change 4082755 by Graeme.Thornton Fixed an erroneous usage of TUniquePtr<uint8>as a pointer to a uint8 array when creating pak files. Caused a crash when compression was enabled, and has probably surfaced because pak generation is now done by an editor commandlet rather than a standalone program. Change 4082756 by Graeme.Thornton Fixed some incorrect documentation for pakfile compressed chunk headers Change 4082883 by Graeme.Thornton Static analysis warning fix Change 4082912 by Ben.Marsh Move ExceptionUtils into DotNETUtilities. Change 4085291 by Graeme.Thornton TBA: In the Json output formatter, write float and double values out with enough precision for successful roundtripping. Added some debug only code which will immediately reconvert the string back to its original value and compare the the input Change 4085523 by Graeme.Thornton TBA: Remove only explicit usage of DECLARE_FSTRUCTUREDARCHIVE_SERIALIZER. Should only be used from UHT generated code. Change 4086037 by Robert.Manuszewski Fix for a potential race condition when two threads want to acquire GC lock Change 4088655 by Graeme.Thornton Pak creation now uses the bEnablePakSigning setting from the crypto config json file Change 4091474 by Steve.Robb Fix for TStaticBitArray::FindFirstSetBit() and TStaticBitArray::FindFirstClearBit(). Unused variables removed. Change 4093632 by Steve.Robb CIS fixes. Change 4093656 by Graeme.Thornton Build fix Change 4093744 by Ben.Marsh Allow per-chunk settings for whether to enable compression in UnrealPak. Change 4099712 by Gil.Gribb UE4 - Fixed rare case where insufficient space was preallocated for cooldown ticks. #jira UE-59686 Change 4099912 by Stefan.Boberg Cooking timer optimizations: - Replaced data structures for FScopeTimer and FHierarchicalTimerInfo. Previous implementation used FString for many things and caused *lots* of heap and string concatenation activity. Replaced with a compile-time node id (using __COUNTER__) and raw string literals. - Removed PERPACKAGE_TIMER support (was disabled by default and was difficult to test) - Made it possible to toggle OUTPUT_TIMING and ENABLE_COOK_STATS independently - Removed some extremely tight timers because the overhead from calling QPC significantly exceeded the measured code This change shaved some 15% off a clean cook of Fortnite WindowsClient (en) with fully populated local DDC Change 4100519 by Stefan.Boberg Quick fix for Linux build issue introduced in 4099927 Change 4105327 by Stefan.Boberg Cooker: Changed FHierarchicalTimerInfo so it uses a linked list for tracking child nodes, to be able to deal with any child count. Previously we assumed there would never be more than 9 children but it turns out there are cooker modes that need more. Fixes check when using -FullLoadAndSave to cook Change 4105448 by Stefan.Boberg - Fixed Linux build warning re: member initialization order - Also eliminated OUTPUT_HIERARCHYTIMERS/CLEAR_HIEARCHYTIMERS macros (plain functions are fine) - Moved finishing-up code for FullLoadAndSave() to TickCookOnTheSide() call site to improve timer output. Previously some of the scopes would not have been closed before printing and thus the output was misleading. Change 4109031 by Ben.Marsh Attribute-driven Perforce wrapper (old Epic Friday project). Offers a more complete implementation than the current P4 wrapper in UAT without requiring any platform-specific libraries. Uses the Python binary output for parsing. Change 4109588 by Ben.Marsh UBT: Add extension methods for serializing a nullable type to a BinaryReader/BinaryWriter. Change 4109595 by Ben.Marsh Missing project file for DotNETUtilities. Change 4110724 by Stefan.Boberg Removed annotation map locking in UObjectMarks, eliminating around one minute (~3.5%) from Fortnite cook time. The locking was redundant since the annotation maps are managed per thread anyway. Change 4111304 by Ben.Marsh UAT: Add support for setting a status message through the log class. Allows writing transient messages (eg. progress messages) which will be cleared out before writing other messages. Best used through the LogStatusScope class, which can set a status message for the duration of a using() block. As part of this change, the console no longer has to be added as a dedicated trace listener. Since we already special-case this listener when formatting log output, it's easier to just keep the implementation separate to the other trace listeners. Change 4112708 by Steve.Robb Fix for TBitArray::MaxBits in assignment. Change 4114133 by Stefan.Boberg Tweaked how low-level memory (LLM) tracker is implemented to reduce overheads. Previously FMemory functions would acquire the LLM singleton and call OnLowLevelFree/OnLowLevelAlloc etc which would check the bIsDisabled flag and early out if it was set. Due to how frequently these functions were called this ended up costing quite a bit. - This change makes the flag a static member variable instead of a member variable and therefore enables a simpler early-out to be implemented. - The singleton getter is also simplified to avoid hitting the threadsafe singleton construction path on every call. - The enable flag is no longer TAtomic - this also incurs extra overhead for no clear benefit Shaves approximately 3.5% (one minute) off a Fortnite cook test scenario (using -FullLoadAndSave) Change 4115010 by Robert.Manuszewski Fixing CIS Change 4115249 by Robert.Manuszewski Fixing async loading code asserts when exiting game very early due to an error #jira UE-56267 Change 4117091 by Ben.Marsh Prevent doubled-up lines when writing status updates with console log verbosity. Change 4117207 by Ben.Marsh UGS: Do not include executables in diagnostics zip file, and ignore "no such files" error when cleaning workspace. Change 4119175 by Ben.Marsh UGS: Fix crash writing version files when directory does not already exist. Change 4119987 by Ben.Marsh UGS: Show a dialog box while the launcher is updating executables from Perforce, which allows cancelling the operation if necessary. Allow setting the username on the settings window, and prompt for login credentials if necessary. Should prevent situations where users have to update settings from the command prompt. Holding down shift during launch now shows the settings dialog rather than an immediate prompt to launch the unstable version (unstable version is shown as a checkbox on this dialog). Change 4119991 by Ben.Marsh Update version number for UGS launcher to 1.13. Change 4121943 by Robert.Manuszewski Don't use FArchiveAsync2 for reading packages with non-async path in editor builds as its performance is worse than the standard archive's (saves about 1 minute when doing larger cooks and 7 seconds when loading into PIE) Change 4122592 by Steve.Robb GitHub #4762 : Improve wording and grammar of Math comments Also includes improved accuracy in FMath::ComputeBoundingSphereForCone(). Change 4122819 by Stefan.Boberg Don't call CreateDirectory redundantly when opening files for writing using FFileManagerGeneric::CreateFileWriter This change avoids calling IPlatformFile::CreateDirectoryTree if possible since this is a very expensive function especially for deep hierarchies as it performs directory creation from the root directory onwards instead of from the leaf downwards. That function should also be fixed but this change improves performance in the meantime. Change 4122872 by Stefan.Boberg CreateDirectoryTree now creates directories leaf-to-root instead of the other way around. This is much more efficient since we don't spend time on system API calls for directories which already exist. This accounted for a very large amount of CPU time in cooking as the full target file directory hierarchy would be "created" for every single output file. Change 4123109 by Stefan.Boberg - Disable overlapped I/O in editor / cooker. Synchronous I/O reduces the number of syscalls and Windows performs prefetching on our behalf anyway for sequential reads - Eliminated syscall which was issued for every write to update cached file size -- since we're the only writers to the file (file access allows read sharing at most) we can authoritatively update the file size on write completion Change 4123455 by Ben.Marsh PR #4775: New build param PCHMemoryAllocationFactor to set /Zm VS build param. (Contributed by lucaswall) Change 4124207 by Ben.Marsh UBT: Remove some unnecessary indirection for generated code paths. Change 4124217 by Ben.Marsh UBT: Remove another unused variable from UEBuildModuleCPP. Change 4124377 by Stefan.Boberg In IPlatformFile::DeleteDirectoryRecursively, attempt to delete file first and if it fails clear the readonly flag and try again Previously there was a call to clear the readonly flag for every deleted file and this is a waste of resources 99% of the time. The SetFileAttributes call accounted for a significant amount of time during cooker sandbox directory deletion Change 4125071 by Stefan.Boberg Some tweaks to FQueuedThreadPoolBase scheduling and memory management - Explicitly pass in false for TArray::RemoveAt(..., bool bAllowShrinking) argument to prevent memory reallocation when arrays are drained and inevitably repopulated shortly afterwards - Use a MRU strategy instead of LRU when picking a thread to wake up. The MRU thread is the most likely to have a 'hot' cache for the stack etc. Picking from the back of the array also happens to be cheaper since no memory movement is necessary when RemoveAt is called. (This was the strategy in place before CL2600362 which seems to have changed it unintentionally) - Release lock as soon as a thread has been chosen, before asking the worker thread to wake up and do the work Change 4126132 by Ben.Marsh UAT: Detect when stdout is redirected and prevent using backspace characters to move the cursor. Change 4126867 by Graeme.Thornton TBA: Fix tagged binary formatter Change 4127010 by Robert.Manuszewski AnimScriptInstances created at runtime will now also be added to the owning omponent's cluster to avoid GC issues. Change 4127932 by Ben.Marsh WorkspaceTool: Reduce unnecessary logging of status messages when console output is not redirected. Change 4129050 by Ben.Marsh UGS: Check for NET Framework 4.5 being installed before running the installer. Also fix warning trying to kill existing UGS instances before upgrade. Change 4129459 by Graeme.Thornton TBA: TextAssetCommandlet - When outputting converted assets to an output path, replicate the workspace relative path in the output directory Change 4129515 by Graeme.Thornton TBA: Add EnterRecord overload that allows outputting of available field names when loading. Change 4129517 by Graeme.Thornton TBA: Tagged properties are written out as named fields on the "Properties" record, rather than as a stream with a null tag at the end Change 4129518 by Graeme.Thornton TBA: Added a local const bool to allow easy hacking out of text asset loading support Change 4129558 by Graeme.Thornton TBA: Build fix for textasset-less configs Change 4129614 by Ben.Marsh UGS: Main window is now restored to normal size when activated by clicking on the tray icon. #jira UE-60490 Change 4129618 by Ben.Marsh UGS: Speculative fix for unreproduced exception accessing disposed window while shutting down. Change 4131936 by Robert.Manuszewski Removing some WIP code accidentally checked in with CL #4121943 Change 4133490 by Ben.Marsh UGS: Allow the $(Change) variable to be used in more places than just the context menu. #jira UE-60573 Change 4133550 by Ben.Marsh UGS: Setting for whether or not to use incremental builds is now exposed through the variable "$(UseIncrementalBuilds)" for use by custom build steps. #jira UE-60554 Change 4133681 by Ben.Marsh UGS: A per-project list of folders and extensions to be deleted by default when running the 'clean workspace' tool can now be specified through the <ProjectDir>/Build/UnrealGameSync.ini file. Settings may be specified for an individual branch (via a category with the depot path to the project) or for wherever the project is currently open (via the [Default] category). The SafeToDeleteFolders list specifies a substring that will be checked against folder paths. Anything containing this folder will be marked as safe for delete by default. The SafeToDeleteExtensions list specifies a list of extensions for files that can always be deleted. Example: [Default] +SafeToDeleteFolders=/MyGame/Test/ +SafeToDeleteFolders=/DataService/ +SafeToDeleteExtensions=.xx1 +SafeToDeleteExtensions=.xx2 #jira UE-60575 Change 4135449 by Ben.Marsh Fix allowing use of Job objects on Windows platforms (debug code submitted by mistake) Change 4135730 by Ben.Marsh UBT: Plugins can now be enabled and disabled from the .target.cs file (for targets that do not use the shared compile environment), by compiling the list of enabled/disabled plugin names into the Projects module. Change 4135823 by Ben.Marsh UBT: Remove legacy code to handle disabling optional plugins; now that this is compiled into the target, it will work for any plugins we choose. Change 4135945 by Ben.Marsh UBT: Fix error running programs with no explicitly enabled or disabled plugins. Change 4137207 by Ben.Marsh UGS: Align all badges with the same name, to make it easier to see which CIS steps are being run. Allow overriding the slot taken by a particular badge by calling it "SlotName:LabelName". Change 4137311 by Stefan.Boberg Removed child cooker support. In practice it is not a useful feature as it provides no performance improvement (quite the opposite in fact) and adds testing and maintenance complexity. Change 4137393 by Ben.Marsh UGS: Fix display of multiline errors in the status panel. Change 4141708 by Steve.Robb GitHub #3631 : Incorrect default argument in WeakObjectPtrTemplate #jira UE-45490 Change 4146655 by Stefan.Boberg Removed FullGCAssetClasses logic - no longer necessary nor useful Change 4147318 by Ben.Marsh UGS: Compress build badges in a column if it shrinks below the size that they would be visible. Change 4148207 by Ben.Marsh UGS: Added support for showing the latest completed build from a specific list of badges in the status panel. To declare a badge as one that should appear in the status panel rather than the CIS column, add it to the project's UnrealGameSync.ini in the project or [Default] section like so: +ServiceBadges=RoboMerge Change 4148282 by Stefan.Boberg Fixed bug in UCookOnTheFlyServer::GetCookOnTheFlyUnsolicitedFiles - UnsolicitedFiles should be passed by reference not by value Change 4148344 by Stefan.Boberg Fixed minor indentation error (most likely caused by sloppy merge) Change 4148521 by Stefan.Boberg Removed accidentally checked in PRAGMA_DISABLE_OPTIMIZATION from CookOnTheFlyServer.cpp Change 4148639 by Ben.Marsh UGS: Fix tooltips not showing for changes that have description badges. Change 4149373 by Ben.Marsh UGS: Allow adding additional columns to display particular badges by adding entries from the project config file. Example syntax: +Columns=(Name="Desktop",MinWidth=50,DesiredWidth=100,Weight=3,Badges="Editor") +Columns=(Name="Mobile",MinWidth=50,DesiredWidth=100,Weight=3,Badges="IOS,Android") Same form can be used to control how default columns are displayed (though badge settings are ignored). Also allow PerforceMonitor to detect local changes to project config files and update settings automatically. Change 4149399 by Ben.Marsh UGS: Update version to 1.143. Change 4155660 by Steve.Robb PROJECTION and PROJECTION_MEMBER macros which provide the correct behavior when creating projections using functions which are overloaded or use default arguments. Change 4157117 by Ben.Marsh Fix warning due to plugins disabled in .target.cs file. Change 4158011 by Ben.Marsh UBT: Add a check that the UnrealHeaderTool target file exists, rather than throwing an exception when reading it fails. Change 4158646 by Ben.Marsh UGS: Fix exception when login is discovered to have expired during a workspace update. Change 4158678 by Ben.Marsh UGS: Fix an exception on shutdown due to the icon being hidden after it's already been disposed. Change 4158683 by Ben.Marsh UGS: Add an unhandled exception filter which sends the exception data to the backend. Change 4159131 by Ben.Marsh UGS: Reduce the number of characters displayed for build badges based on the available space. Change 4159194 by Graeme.Thornton TBA: Fix incorrect map property conversion code when converting an old property that contains a map with different key/value types Change 4159239 by Steve.Robb Improved readability and compliance with coding standards. Change 4159246 by Ben.Marsh UGS: Allow syncing projects where source code is not available (and various version files don't exist). #jira UE-60985 Change 4159286 by Ben.Marsh UGS: Remove requirement for UE4Editor.target.cs to be visible in the depot in order to open a project. #jira UE-60986 Change 4159302 by Ben.Marsh UGS: Update version to 1.144. Change 4160308 by Ben.Marsh All staging client executables for blueprint projects. #jira UE-60983 Change 4161567 by Steve.Robb GitHub #4816 : UE-60771: Handle escaped double quote in FParse::LineExtended Change 4162641 by Ben.Marsh UGS: Allow customizing the position of custom columns, via the Index=N attribute. Change 4162647 by Ben.Marsh UGS: Update version to 1.145. Change 4165319 by Robert.Manuszewski PR #4812: Fix inconsistent command-line argument handling under Windows (Contributed by adamrehn) Change 4166150 by Ben.Marsh UGS: Include *.inl when looking for code changes. Change 4166551 by Steve.Robb Whitespace fixes caused by a bad merge. Change 4168483 by Ben.Marsh UGS: Add a more useful error if a file to be synced exceeds the max allowed path length. Change 4168490 by Ben.Marsh UGS: Update version to 1.146. Change 4168551 by Ben.Marsh UBT: Move bBuildLargeAddressAwareBinary into an exposed setting. Change 4168560 by Ben.Marsh UBT: Remove static config variable for controlling which configuration of UHT to use. Change 4171296 by Ben.Marsh UGS: Move the check for overlong paths earlier. Change 4171531 by Ben.Marsh UBT: Fix exception if BuildConfiguration.xml contains an unknown category. Change 4183371 by Robert.Manuszewski Fix for a crash in Async Loading Graph's CheckCycles when GC kicks in on the game thread and forces ALT to exit early Change 4184312 by Ben.Marsh UGS: Update version to 1.148 Change 4184480 by Robert.Manuszewski Removing unused async loading stat Change 4186390 by Ben.Marsh UBT: Format XML validation errors in a format that allows double-clicking on the message in Visual Studio. Change 4188644 by Ben.Marsh UBT: Add the MakePathSafeToUseWithCommandLine() function to UBT. Change 4188647 by Ben.Marsh UBT: Fix exception in target receipt when architecture is null. Change 4189617 by Ben.Marsh Change FileSystemReference, FileReference and DirectoryReference objects to use OrdinalIgnoreCase comparisons without creating a separate copy of the string to compare. The filesystem does not use the invariant culture, and it can produce the wrong results in some cases (the ordinal comparison is faster, too). Change 4189740 by Ben.Marsh UAT: Remote code to build UnrealPak when packaging; we use the editor now. Change 4189860 by Ben.Marsh UGS: Make the filter for excluding automated lighting rebuilds more explicit. Change 4190082 by Ben.Marsh Fixes to allow enabling edit and continue for Windows builds. Have experienced quite a few VS crashes when testing it in editor; not yet recommended for general use. - Allow edit and continue for any configuration, not just debug. - Fixed PDB errors compiling files that use a shared PCH with edit and continue enabled. Path to the generated PDB file was using the wrong directory. - Removed code that tracks PDB output files, since they're modified multiple times during a build. - Enable debug information when compiling generated CPP files, since it causes errors if the shared PCH PDB doesn't have the same option. - Disable support for remote execution of steps that modify the PDB, since the same file has to be modified many times. Remote execution causes the PDB files to be corrupted. Unfortunately, this makes E&C builds significantly slower. #jira Change 4192949 by Ben.Marsh UBT: Minor tidy-up (merging UEBuildBinary.Build and UEBuildBinary.SetupOutputFiles) Change 4193218 by Ben.Marsh Fix formatting. Change 4197252 by Mike.Erwin UAT: Fix log output w/ correct count of non-code projects. #jira none Change 4197941 by Ben.Marsh UGS: Add support for DebugGame editors that have an executable with a DebugGame suffix. Change 4197964 by Ben.Marsh UGS: Prevent attempts to automatically reopen projects while a modal dialog is up, or the workspace is syncing. Change 4198144 by Ben.Marsh UGS: Prevent modal dialogs when login expires in P4, and prompt for password when hitting "retry". Change 4198413 by Ben.Marsh UGS: Always show the main window when launched manually, and run with -RestoreState when launched at startup. Also add a couple more places that save the visibility state, since logging off seems like it can terminate the process abrubtly. Change 4198779 by Ben.Marsh UBT: Allow generating manifests to any arbitrary locations with the -Manifest=<Path> argument. Change 4198825 by Ben.Marsh UBT: Move code to enumerate Slate runtime dependencies into the Slate module. Doesn't need to be done inside core UBT. Change 4199341 by Ben.Marsh UGS: Update version to 1.149 Change 4199642 by Chad.Garyet - Deprecate CISController - Add BuildController to replace CIS GET/POST for builds - Add LatestController, GET does what CIS/GET used to do - Change Latest/GET to return the last 25 builds filtered by project, rather than the last 5000 individual Ids - Latest/GET now returns "LatestData" object instead of array of longs - Updated EventMonitor to match all API changes - Fixed bug where IDs were getting reset to initial startup values every update loop Change 4199663 by Chad.Garyet CIS controller still needs to return an array of longs #jira none Change 4199680 by Ben.Marsh UGS: Update version to 1.150 Change 4200457 by Ben.Marsh Merging CIS fix for non-development configurations. Change 4200472 by Mike.Erwin UAT: fix -skipbuildclient param default It was defaulting to skipbuildeditor's value, likely a copy-paste error. #jira none Change 4202595 by Ben.Marsh Fix static analysis warning due to constant comparison against macro. Change 4203250 by Ben.Marsh UGS: Always show the "Sync Precompiled Editor" option, but disable it and show a tooltip explaining why if it is not available. Change 4206191 by Ben.Marsh Exclude editor target files from installed builds, since they leak info about DLLs that have been stripped out. Change 4213011 by Ben.Marsh UBT: Include contents of modified intermediate files in the log, to make it easier to debug hidden dependencies. Change 4213487 by Ben.Marsh UBT: Fix assumption that bPrecompile is equivalent to bBuildAllModules. This is no longer the case; they are now controlled by separate options. Should fix CIS errors building the editor. Change 4213609 by Ben.Marsh Ensure that strings formatted using FMicrosoftPlatformString::GetVarArgs() are always null terminated, whether we use the secure CRT or not. Change 4215971 by Ben.Marsh UBT: Remove action graph visualization code; no longer used. Change 4215996 by Ben.Marsh UBT: Remove unqiue id from all actions in the action graph. This is only used for printing debug info in the case of a (rare) cycle in the action graph, so just look it up when needed. Change 4216022 by Ben.Marsh UBT: Rename Crypto.cs to EncryptionAndSigning.cs to match the name of the class inside it, and move it under the System folder. Change 4216031 by Ben.Marsh UBT: Move all the action executors into their own folder in the project. Change 4216526 by Ben.Marsh Fix CIS warnings. Change 4216544 by Ben.Marsh Replace custom code to ensure FMicrosoftPlatformString::GetVarArgs() null terminates its buffer with Microsoft's standards-compliant implementation. Change 4216633 by Ben.Marsh Add support for UnrealPak plugins. * Project and plugin modules can now specify an array of supported programs in the "WhitelistPrograms" field of their module descriptors, to allow modules to be loaded by programs. * Programs can now load any runtime modules, as long as they are whitelisted. * Programs under the engine directory can now use a shared build environment, so that building with a project file does not cause output binaries to be output to the project directory. * UnrealPak is now always built by default when packaging * Convert UnrealPak to a modular configuration Change 4216736 by Ben.Marsh UnrealPak: Move "ExportDependencies" command into an editor commandlet, since it relies on the UObject system, asset registry, etc... Change 4217447 by Ben.Marsh Back out revision 50 from //UE4/Dev-Core/Engine/Build/InstalledEngineBuild.xml Change 4217451 by Ben.Marsh Back out revision 11 from //UE4/Dev-Core/Engine/Plugins/Developer/VisualStudioSourceCodeAccess/Source/VisualStudioSourceCodeAccess/VisualStudioSourceCodeAccess.Build.cs Change 4217617 by Ben.Marsh Back out changelist 4217451 Change 4222552 by Ben.Marsh Don't use #import <TypeLib> for VS source code accessor when building with Clang; it's not supported. Change 4222630 by Ben.Marsh UBT: Fix spam while generating project files if Clang isn't installed. Change 4223316 by Ben.Marsh UBT: Change the order in which Visual C++ toolchains are enumerated to prefer full releases over preview releases. Change 4223318 by Ben.Marsh UBT: Add a build setting which allows creating a dedicated PCH for every file that's excluded from the unity working set (disabled by default). Improves iteration times when working on individual cpp files, but slows down iterating on header changes (and can take a lot of disk space for large changes). Dedicated PCH contains all includes scraped from the top of each cpp file, until a non-#include directive is encountered. Change 4223401 by Ben.Marsh UBT: Add an option to automatically enable edit and continue for files in the adaptive non-unity working set. E&C doesn't seem very useful for UE4 projects right now; compile time is comparable to regular build times, but it can take several minutes to apply code changes for large projects. Change 4223899 by Ben.Marsh UBT: Fix loading XML config files on Mono; Type.GetField(Name) does not seem to return values unless binding flags are specified. Change 4224637 by Ben.Marsh Add a "SupportedPrograms" field to plugin descriptors, which allows plugins to declare which plugins they support independently of individual modules. Programs now respect the "bEnabledByDefault" setting in plugins. Plugins that are compatible with a program now need to list that program in the SupportedPrograms list, and whitelist any modules that should load for that program. Change 4224710 by Ben.Marsh UBT: Don't add import libraries as final build products unless the target is being precompiled. Prevents the need for building them for leaf nodes in the action graph. Change 4224715 by Ben.Marsh UBT: Remove hack to allow Stats2.cpp to not follow IWYU convention. Change 4224726 by Ben.Marsh Remove commented out line. Change 4224903 by Ben.Marsh Fix non-unity compile error in Stats2.h. Change 4225051 by Ben.Marsh Back out changelist 4224710; causing CIS errors due to receipts not matching. Change 4225134 by Ben.Marsh Fixing non-unity errors. Change 4225203 by Ben.Marsh Another non-unity fix. Change 4225249 by Ben.Marsh Fix Linux dependencies being copied for the Windows editor; they can be added as requirements for the Linux target platform on Windows instead, so it respects the user's chosen platforms. #jira UE-62001 Change 4225512 by Ben.Marsh BuildGraph: Allow setting the target to build when using the <CsCompile> task. Change 4228815 by Ben.Marsh UBT: Always add the generated code directory to the list of include paths when generating project files. It may only be created after UHT has been run. Change 4228944 by Ben.Marsh UBT: Remove legacy CppCompileEnvironment and LinkEnvironment wrappers from TargetRules that were deprecated in 4.19. Change 4229028 by Ben.Marsh UBT: Fix editor targets with unique build environment having the wrong executable path in generated project files. Move move logic to configure target rules post-construction by the rules assembly to ensure it's valid. Change 4229065 by Ben.Marsh UBT: Move another target setting into the rules assembly. Change 4229105 by Ben.Marsh Fix BPT exception when generating project files. Change 4229311 by Ben.Marsh UBT: Store the module rules file location on the ModuleRules instance, as well as the plugin that it was created from. Also expose the plugin directory as a property on the ModuleRules instance. Change 4229421 by Ben.Marsh UBT: Consolidate functionality for UHT module setup in ExternalExecution.cs. Change 4229817 by Ben.Marsh UBT: Modules must now explicitly specify the path to the header used to generate a PCH if one is desired, rather than the header being determined automatically by attempting to parse the source code. Now that PCHs are force-included anyway, this removes a lot of dependencies inside UBT. Change 4229824 by Ben.Marsh UBT: Remove unused lists inside UEBuildModuleCPP.SourceFilesClass. Change 4229841 by Ben.Marsh UBT: Remove some legacy code from auto-detecting PCHs. Change 4230521 by Ben.Marsh UBT: Add utility functions to the log class to allow formatting errors and warnings in Visual Studio output format (eg. File(Line): warning: Message) Change 4230871 by Ben.Marsh UAT: Remove StreamUtilis utility class; there is a simpler way to implement the one place it's used. Change 4230882 by Ben.Marsh UAT: Add StreamUtils back into UAT, seems like it's still used there. Change 4230896 by Ben.Marsh UBT: Remove some redundant parameters from UEBuildModule/UEBuildModuleCPP/UEBuildModuleExternal constructors. Change 4231014 by Ben.Marsh WorkspaceTool: Include a dump of raw bytes when garbage is read from the P4 process, for diagnostic purposes. Change 4231032 by Ben.Marsh Fix CIS. Change 4231096 by Ben.Marsh Bump the FlatCPPIncludeDependencyCache version, to prevent errors trying to load old files. Change 4231446 by Ben.Marsh UBT: Added support for expanding UE-specific variables in include paths and library paths: $(EngineDir), $(ProjectDir), $(PluginDir), $(ModuleDir). Change 4231460 by Ben.Marsh Modules may now explicitly specify rpaths on Linux via the PublicRuntimeLibraryPaths and PrivateRuntimeLibraryPaths properties. Change 4233909 by Robert.Manuszewski PR #4779: Reason fails as the supplied variable is incorrect (Contributed by projectgheist) Change 4233910 by Ben.Marsh Enable PCHs on IOS. Reduces build time by ~25%. Change 4234176 by Ben.Marsh UBT: Add better messaging for modules that need to have a private PCH set. Now detects the likely PCH using the same method as legacy code and includes it as a suggestion. Change 4234193 by Ben.Marsh Add the Delete command to Perforce wrapper in DotNETUtilities. Change 4234688 by Ben.Marsh UBT: Simplify handling of installed/precompiled builds. Settings for whether a folder is installed/read-only or not is now stored on the RulesAssembly instance, allowing multiple things to be configured separately and stacked together (eg. engine/enterprise/project). RulesAssembly.IsReadOnly() allows determining if a flie can be modified or not and replaces many previous IsXXXInstalledCalls(), and traverses the chain of assemblies. Change 4234711 by Ben.Marsh UBT: Runtime dependencies can now be copied to output directories as part of the build. When adding a runtime dependency, an optional source location can be specified to copy from. Both the source and target paths can use variables can be used as part of the path, eg. $(OutputDir), $(ModuleDir), $(PluginDir). Example usage (from a .build.cs file): RuntimeDependencies.Add("$(OutputDir)/Foo.dll", "$(PluginDir)/Source/ThirdParty/Foo.dll", StagedFileType.NonUFS); Change 4234872 by Ben.Marsh Expose a flag for whether the engine is installed, to fix issues generating project files. Change 4234929 by Ben.Marsh Fix null reference generating receipts when UBT makefiles are active. Change 4235883 by Chad.Garyet Merging 4231245 to core Giving Coordinator its own sln. This should fix what 4158155 was supposed to. #jira UE-61955 Change 4236075 by Ben.Marsh CIS fix Change 4237066 by Robert.Manuszewski Fix for a potential crash when terminating the engine while it's being initialized #jira UE-60545 Change 4237078 by Robert.Manuszewski The engine will no longer be resetting all linkers causing massive load times when renaming the world package when entering Play In Editor Change 4237116 by Ben.Marsh Rewrite some Windows utility functions to support paths longer than MAX_PATH. Change 4237158 by Ben.Marsh Add const TCHAR* overloads of FString::RemoveFromStart() and FString::RemoveFromEnd(). Change 4237159 by Ben.Marsh Fix FWindowsPlatformFile::GetFilenameOnDisk() support for paths longer than MAX_PATH, and simplify some of the other long path functions to avoid copying string buffers. Change 4239050 by Ben.Marsh Missing file Change 4239318 by Ben.Marsh Linux CIS fix. Change 4239685 by Ben.Marsh Static analysis CIS fix. Change 4240800 by Ben.Marsh WorkspaceTool: Include the full command line in the log for any P4 commands. Change 4240903 by Ben.Marsh PR #4909: Update copyright notices to 2018 (Contributed by projectgheist) Change 4241025 by Ben.Marsh UBT: Exclude mobile pipeline caches from generated project files. Causes huge slowdown when using 'Find in Files' through the IDE. Change 4241770 by Ben.Marsh UBT: Include action number in parallel executor output. #jira UE-62032 Change 4243469 by Ben.Marsh TBA: Merge FAnnotatedStructuredArchiveFormatter with FStructuredArchiveFormatter. Any functions that are only implemented for text archives now have a _TextOnly suffix, and are exposed through the FStructuredArchive interface. Change 4245723 by Robert.Manuszewski Fixing another creash when terminating the engine while initializing. #jira UE-60545 Change 4245862 by Steve.Robb VectorLoadFloat2(Ptr) added, which loads { Ptr[0], Ptr[1], Ptr[0], Ptr[1] } into a VectorRegister. Change 4246412 by Robert.Manuszewski The warning 'Calling StaticLoadObject during PostLoad may result in hitches during streaming' will now also report the object which had the PostLoad called on it when StaticLoadObject call happened. Change 4246612 by Ben.Marsh UBT: Fix spelling of "Intellisense". Change 4249454 by Robert.Manuszewski Added extra checks to catch scenarios where the EDL Precache Buffer is flushed before a package header is fully read Change 4249513 by Robert.Manuszewski Made sure the Async Loading Thread doesn't continue running after creating new async packages when garbage collector wants to run on the game thread Change 4255207 by Ben.Marsh UGS: Add additional logging whenever a P4 command fails, and when the user is logged out. Change 4255288 by Ben.Marsh PR #4921: Honor ModuleRules' bEnableExceptions flag when creating precompiled h. (Contributed by surakin) Change 4256422 by Ben.Marsh UBT: Add an error if a module referenced by a plugin descriptor doesn't exist. Change 4257385 by Robert.Manuszewski Creating new objects from within ForEachObjectWithOuter will now result in a fatal error as it's unsafe to change internal UObject hash tables when iterating over them. Change 4257454 by Robert.Manuszewski Added the option to filter clusters listed with gc.ListClusters by objects within them. Usage: gc.ListClusters Hierachy With=ObjectName1,ObjectName2... Change 4257526 by Robert.Manuszewski It's now possible to filter clusters that get logged with verbose cluster logging enabled (UE_GCCLUSTER_VERBOSE_LOGGING=1) by objects within them by specifying -DumpClustersWithObjects=ObjectName1,ObjectName2 in the command line Change 4257822 by Ben.Marsh Fixes for PlatformShowcase compile errors. Change 4258771 by Ben.Marsh UBT: Fix project files not being generated for foreign projects when creating .stub files. #jira UE-62462 Change 4258790 by Ben.Marsh UBT: Clean up the logic around generating project files before creating a stub IPA, so that it fails loudly if project files do not exist, and can accept target names not matching project names. Change 4259276 by Ben.Marsh UBT: Make it an error if a framework doesn't exist, rather than failing silently. Also remove some remote toolchain stuff that's no longer necessary. Change 4259280 by Ben.Marsh UBT: Fix embedded framework zips not being uploaded for plugins. #jira UE-62485 Change 4260236 by Ben.Marsh UBT: Fix path to generated engine project file. Change 4260334 by Ben.Marsh UGS: Fix custom build steps dialog inadvertantly modifying config file settings in-place. Change 4260361 by Ben.Marsh UGS: Allow for p4 login commands to fail, even though the user is logged in (due to a bad connection, etc...) Change 4260559 by Ben.Marsh UGS: Update version. Change 4261160 by Robert.Manuszewski MediaPlaylist will now be added to root set if the owning MediaPlayer is in the disregard for GC set (fixes GC assumption violation crash) #jira UE-62495 Change 4261421 by Ben.Marsh Force-sync files for building documentation, to fix issues with files not being updated. #jira UE-62413 Change 4261425 by Ben.Marsh UBT: Remove some leftover functions for handling the remote toolchain. Change 4261530 by Ben.Marsh UBT: Speculative fix (and better error reporting) for IOS mobile provision not being found in CIS. Change 4261611 by Ben.Marsh UBT: Downgrade warning to a log message, since it appears when generating project files. Change 4261710 by Ben.Marsh Remove assert that GLogConsole is set; it won't be for command line utilities that don't depend on ApplicationCore. #jira UE-62545 Change 4261831 by Ben.Marsh Fix compile errors due to missing include path when hot-reloading a module from the editor. There are not necessarily source files to compile when -modulewithsuffix is specified on the command line, which was results in GeneratedCodeWildcard not being set. #jira UE-62463, UE-62384 Change 4262723 by Ben.Marsh Whitelist plugins that need to be loaded by UFE. #jira UE-62564 Change 4265444 by Ben.Marsh Fix incorrect executable name for DebugGame configurations in Xcode. #jira UE-62574 Change 4265892 by Ben.Marsh Fix incremental compile failures due to dependency checking for unity files. CachedIncludePaths was not correctly being set on file items, so dependencies were being ignored. #jira UE-62575, UE-62603, UE-62597 Change 4266019 by Josh.Adams - Fixed the CopyAction for runtime dependencies that need to be copied to different location, on non-XGE Change 4266264 by Ben.Marsh Remove override for the __IPHONE_OS_VERSION_MIN_REQUIRED macro on TVOS. This macro is already defined by system headers (in <AvailabilityInternal.h>). Now that we support PCHs on IOS and TVOS, manually defining this macro results in it being defined three times (once for the PCH, once by AvailabilityInternal.h, and once by the force-included list of definitions for the source file being built). The errors for redefining the macro in AvailabilityInternal.h are suppressed due to it being a system header, but the error for redefining it for the source file being compiled are not. #jira UE-62578 Change 4266273 by Ben.Marsh Fixes incremental build failure when compile arguments for PCH have changed on IOS/TVOS. Compile action needs to have a dependency on PCH build action. Change 4266614 by Graeme.Thornton Fix crash when cooking nativized blueprints due to removal of child cooker system. Change 4266763 by Ben.Marsh Always build UnrealPak when building client targets. The ProjectParams.Pak option is not reliable, because it can be forced on later by the target platform. #jira UE-62584 Change 4267985 by Robert.Manuszewski When iterating with ForEachObjectWithouter, don't lock the entire has table but only the hash bucket that is currently being iterated #jira UE-62600 Change 4268558 by Robert.Manuszewski PurgeLegacyBlueprints will no longer be called from within ForEachObjectWithOuter is it renames objects that reside in hash tables that are being iterated over which may lead to undefined behavior. #jira UE-62600 Change 4269011 by Chad.Garyet - Fixing Wildcard match issue, the change to ugsapi sends projects as //Depot/Stream instead of //Depot/Stream/ Wildcard match was only substringing to 3 chars. - Checking in the change a while back that increases the number of queried jobs up to 432 based on some maths from Bob about how many builds we want to grab Published to ugsapi server 8/8/17 #jira none Change 4270788 by Ben.Marsh Fix IOS provisioning data being using when remote compiling on TVOS. #jira UE-62705 Change 4271916 by Ben.Marsh Tag the XGEControlWorker executable as a build product after compiling SCW, to make sure it's included in the UGS zip file. Change 4271934 by Ben.Marsh Upload all static libraries in plugin folders as part of remote builds. #jira UE-62694 Change 4273368 by Ben.Marsh Fix Slate dependencies not being enumerated, and rules assembly not being rebuilt when building remotely. #jira UE-62705 Change 4274049 by Ben.Marsh Always parse the team UUID out of the mobile provision when doing a remote compile. The provision installed on the remote Mac (and selected for signing) may be different. #jira UE-62751 Change 4274823 by Ben.Marsh Add the -VersionCookedContent argument to disable the -unversioned parameter on the cooker command line. Change 4275838 by Ben.Marsh Fix BuildVersion string not being passed through from <SetVersion> task. Also add a -BuildVersion command line argument to UBT to override it for a particular build. Change 4275913 by Ben.Marsh Add a dummy exported symbol to the XGEController module, to fix build errors due to missing .lib file when it's built with WITH_XGE_CONTROLLER = 0. Change 4284161 by Ben.Marsh Allow mirroring Oodle files to remote Mac. Change 4074774 by Steve.Robb Vast simplification of TFunction, making it smaller in footprint, easier to follow and extend, and more correct. TUniqueFunction added, which is a move-only TFunction which can hold move-only functors. Fix for UWidgetBlueprint::ForEachSourceWidget() which should never have compiled but did. FFunctionGraphTask and TFuture<> updated to use TUniqueFunction to make them more general. TArray::HeapPop() made to work with move-only types. Change 4082591 by Ben.Marsh Move the Log class from UBT to DotNetUtilities. Change 4083236 by Ben.Marsh Add a Log.WriteException() method to dump an exception message to the console (and write the exception trace to the log) Change 4084107 by Ben.Marsh UAT: Remove the unused -SkipHeader argument to UE4Build. Change 4089771 by Steve.Robb GitHub #4743 : modified VirtualAlloc function flag https://blogs.msdn.microsoft.com/oldnewthing/20151008-00/?p=91411 Change 4091456 by Steve.Robb Unification of all platforms' FMath::CountTrailingZeros() and FMath::CountLeadingZeros() for both 32-bit and 64-bit. Change 4156437 by Ben.Marsh Lots and lots of fixes compiling for Clang on Windows. Editor now compiles cleanly without warnings, but crashes on startup due to error in intrinsics test. Disabling that runs further, but crashes accessing freed memory. Switching to the ANSI allocator runs further, but crashes in Slate after the splash screen and before the editor window opens. // TODO! * Switching between Clang/ICL/VS2015/VS2017 is now supported through the same mechanism as switching Visual Studio versions, without requiring any source level changes. To use Clang, set WindowsPlatform.Compiler = WindowsCompiler.Clang from a .target.cs file, or set <WindowsPlatform><Compiler>Clang</Compiler></WindowsPlatform> from BuildConfiguration.xml. To pick a specific toolchain version, set WindowsPlatform.CompilerVersion. * Clang is now supported through AutoSDKs; will be added to CIS. * The Samples/Sandbox/Clang project forces Clang to be used from its target.cs file, and allows easily building all editor modules and plugins with Clang on Windows. * UnrealMathSSE intrinsics have been re-enabled for Clang due to missing functions from the UnrealMathFPU implementation, but causes failure in tests at startup. * SSE4_CRC32() is disabled in D3D12Pipelinestate.cpp, since intrinsics are only allowed if enabled for the whole target (rather than being used in specific functions due to runtime checks) Change 4157389 by Ben.Marsh Few more fixes for compiling the editor with Clang. Change 4183911 by Ben.Marsh Fixes to support incremental linking on Windows. Does not seem to have any net benefit right now; may improve once minimal rebuild is enabled. * Incremental linking no longer forces PDB files to be enabled for source files. * Actions can specify specific files to be deleted before each build. Code to forcibly delete PDB files has been moved to the MSVC toolchain. * Unused libraries produced by the cross-referenced link are no longer added as build products, since (a) deleting them breaks dependency checking for incremental linking and causes a full link, and (b) not deleting them breaks UBT dependency checking and causes actions to be run over and over again. * Icon update is disabled for Windows when incremental linking is enabled. * Removed rarely-used setting to always delete produced items before each build. Change 4184311 by Ben.Marsh UGS: Added a dialog which shows all the required platform SDKs for a branch, linked from the status panel in UGS. The llist is configured via the UGS config file submitted to Engine/Programs/UnrealGameSync/UnrealGameSync.ini (and may be overridden by the project config file if necessary): [Default] ; Set this to a network share which contains the SDK installers for your site SdkInstallerDir= ; All the required SDKs for the current version of the engine +SdkInfo=(Category="Android", Description="NDK r21", Browse="$(SdkInstallerDir)\\Android") +SdkInfo=(Category="Windows", Description="Visual Studio 2017") +SdkInfo=(Category="Windows", Description="Visual C++ Toolchain 14.13.26128") +SdkInfo=(Category="Windows", Description="Windows SDK 10.0.16299.0") Similar entries for console platforms are added in console subdirectories. Each entry may contain an Install="Foo.exe" and/or Browse="C:\Foo" style attribute, specifying the path to an installer to run or directory to open in explorer respectively. The SdkInstallerDir setting is used as a base directory for the default installers, seen above for Android. Licensees may override this with a network path specific to the site that UGS is being deployed to (either in this file, in a project specific config file, or in a Engine/Programs/UnrealGameSync/NotForLicensees/UnrealGameSync.ini file). Change 4200452 by Ben.Marsh UBT: Change DebugGame configurations to output a separate executable rather than requiring a -Debug argument at runtime. Previous behavior was a common source of errors. Engine modules are still shared between Development and DebugGame, but the launch module sets a flag in Core on startup indicating the game configuration. Change 4206189 by Ben.Marsh UBT: Simplify logic for precompiling binaries. * Target no longer has separate list of "precompile only" binaries or modules. New -AllModules option allows adding every module to a target, which can be used with -Precompile and -NoLink to precompile object files for monolithic builds. * Precompiled file lists have been removed from target receipts. * The manifest now includes all generated headers and precompiled files when run with the -Precompile option. * Separate -DependencyList=Foo.txt has been added to write a list of all dependencies required to use precompiled binaries. This file list can be read using the <Tag> task in buildgraph. Change 4215466 by Ben.Marsh UBT: Remove indirect calls to determine extensions for object files and precompiled headers. The toolchain knows the correct convention for the platform. Change 4215975 by Ben.Marsh UBT: Remove telemetry code. This has never proved useful for analyzing performance due to the number of incidental factors that affect build times (eg. number of files being compiled). Change 4220154 by Ben.Marsh Move text-only implementations of FOutputDeviceError back into Core, so we can build command-line applications that don't depend on ApplicationCore. Change 4224708 by Ben.Marsh Add a bCompileAgainstApplicationCore setting to the target rules, which allows compiling out references to the ApplicationCore module (which should only be necessary for applications with a GUI). Removed ApplicationCore from several engine tools and utilities. Change 4224958 by Ben.Marsh Remove CoreMinimal.h includes from Core. Change 4229059 by Ben.Marsh UBT: Remove the UEBuildPlatform.ShouldNotBuildEditor() hook for target platforms. We shouldn't be modifying a target's build environment to disable the editor; it is invalid to build the editor for these target platforms at all, and this is already enforced by the GetSupportedPlatforms() function. Change 4230508 by Ben.Marsh Fixup precompiled header setting for samples and games. Change 4231457 by Ben.Marsh Fix exceptions in log messages having trailing newlines. Change 4232406 by Ben.Marsh UBT: Always force include a PCH for generated code if there's one set; the code may depend on it to compile. Change 4234177 by Ben.Marsh Set up private PCH files everywhere that previously used them. Change 4235973 by Ben.Marsh Change FPlatformMisc::GetEnvironmentVariable() to return an FString() rather than requiring a fixed size buffer to be passed in. Removes references to MAX_PATH. Change 4238842 by Ben.Marsh Add support for paths longer than MAX_PATH in the editor. Requires Windows 10 version 1607, and the functionality to be enabled via a registry key or group policy (see https://docs.microsoft.com/en-us/windows/desktop/FileIO/naming-a-file). Only a subset of Win32 functions support long paths (executables can only be started from paths shorter than MAX_PATH, for example). * Added a FPlatformMisc::GetMaxPathLength() function to return the maximum length of a path on the current system. On Windows, this returns a different value for systems with long paths enabled to those without. * The MAX_PATH define is no longer set by non-Windows platforms. Instead, there is a MAC_MAX_PATH, UNIX_MAX_PATH, etc... for any platform-specific code that still relies on the previous macro. * The MAX_UNREAL_FILENAME_LENGTH macro has been renamed to MAX_UNREAL_FILENAME_LENGTH_DEPRECATED * The PLATFORM_MAX_FILEPATH_LENGTH macro has been renamed to PLATFORM_MAX_FILEPATH_LENGTH_DEPRECATED. * Removed custom resource files for programs, since they are just copies of the base UE4 one (which is used by default anyway). The base UE4 manifest declares support for long paths. * Fix 512 character maximum length on editor commands. 260 character limit remains in place for cooking at the moment (see ContentBrowserUtils.h), until C# staging code supports long paths. Change 4255042 by Ben.Marsh UBT: Remote compilation now uploads the entire workspace to the remote Mac and executes a separate remote instance of UBT rather than synchronizing individual actions. This makes the remote compile codepath much simpler, and removes a lot of special cases that exist to support it previously. The list of files to be transferred to the remote are listed as rsync filter rules in Engine/Build/Rsync/RsyncEngine.txt and RsyncProject.txt, which are applied to the root engine directory and project directory respectively. Projects that need to customize which files are uploaded can add their own <ProjectDir>/Build/Rsync/RsyncProject.txt file, which will be included in the filter before the default version. Change 4260567 by Ben.Marsh UAT: Rename CommandUtils.Log to CommandUtils.LogInformation, to avoid conflicts with the underlying Tools.DotNETCommon.Log class. #rb none [CL 4285673 by Ben Marsh in Main branch]
2018-08-14 18:32:34 -04:00
LogInformation("Waiting for server to start....");
Thread.Sleep(2000);
}
if (ClientProcess != null && ClientProcess.HasExited)
{
ServerProcess.StopProcess();
throw new AutomationException("Client exited before we asked it to.");
}
}
}
if (ClientLogReader != null)
{
if (ClientProcess.HasExited)
{
ServerProcess.StopProcess();
throw new AutomationException("Client exited or closed the log before we asked it to.");
}
while (!ClientProcess.HasExited && !ServerProcess.HasExited && bKeepReading)
{
while (!ClientLogReader.EndOfStream && bKeepReading && !ServerProcess.HasExited && !ClientProcess.HasExited)
{
string ClientOutput = ClientLogReader.ReadToEnd();
if (!String.IsNullOrEmpty(ClientOutput))
{
AllClientOutput += ClientOutput;
Console.Write(ClientOutput);
if (AllClientOutput.LastIndexOf(LookFor) > AllClientOutput.IndexOf(LookFor))
{
if (Params.FakeClient)
{
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 4285612) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3836829 by Ben.Marsh UBT: Fix ability to precompile plugins from installed engine builds. Change 3839519 by Ben.Marsh UBT: Simplify configuring bPrecompile and bUsePrecompile settings for modules. Each rules assembly can now be configured as installed, which defaults the module rules it creates to use precompiled data. Change 4042043 by Steve.Robb GitHub #4705 : Added weak lambda's for delegates and multicast delegates. Change 4042056 by Robert.Manuszewski Optimized Mark Phase of GC by up to 10ms by making it run in parallel and removing a huge array presize which we didn't need. Change 4042104 by Robert.Manuszewski Set the minimum GC cluster size to 5 so that GC doesn't have to process micro clusters which are more expensive than processing individual objects + Exposed the minimum cluster size to ini and project settings as gc.MinGCClusterSize + Added the ability to sort clusters by name/object count/mutable object count/referenced clusters count when dumping them with gc.ListClusters command Change 4042377 by Robert.Manuszewski Reworked how GC and other threads (ALT specifically) interact - GC will now notify the ALT it wants to run and ALT will immediately try to finish its current work to allow that. Also the entire ALT tick is now protected against GC running at the same time to improve ALT stability. + added gc.ForceCollectGarbageEveryFrame console variable that triggers a forced GC every frame Change 4042427 by Robert.Manuszewski Changed FGCCSyncObject to use events when waiting for GC to finish so that it doesn't spin on non-game threads when GC is running Change 4042482 by Robert.Manuszewski Unhashing unreachable objects (ConditionalBeginDestroy) will now also be done incrementally, just like the purge phase of Garbage Collection Change 4042635 by Robert.Manuszewski Fix for a potential assert when incremental purge garbage is pending and something forces a full purge Change 4044092 by Steve.Robb Fix for forward declared CoreUObject weakobject types in delegates when building in Clang. Change 4044102 by Robert.Manuszewski Fix for a possible hang when worker threads are preventing GC from running and something is later trying to FlushAsyncLoading with the Async Loading Thread enabled Change 4044113 by Steve.Robb Another Clang fix. Change 4044160 by Robert.Manuszewski Disregard For GC pool will now be enabled by default in cooked builds Change 4044287 by Steve.Robb Typo fix. Change 4047723 by Graeme.Thornton TBA: Fixes for import/export name cache and object resolving Change 4048015 by Graeme.Thornton TBA: Weak/Soft/Lazy pointer serialization changes * Remove FWeakObjectPtr::Serialize, move it's logic into, and replace usages of with calls to, FArchiveUObject::SerializeWeakObjectPtr(). Ensures that something is always sent to the archive so that structured archives can be kept happy in the future. * Added Weak/Soft/Lazy pointer handling to the structured archive slot interface and all the formatters. Binary formatters just forward the call onto their inner and text archives store as a string path reference. * FArchiveUObjectFromStructuredArchive caches all these pointer types and stores indices in the binary block, same as with a UObject*. All pointers are then forwarded to the underlying formatter in one go on finalization. Change 4048021 by Steve.Robb Fix for binding an unbound TFunction to another TFunction with a different signature. Also all null pointers now count as unbindings, not just nullptr. TIsMemberPointer added. TIsATFunction and TIsATFunctionRef renamed to remove the 'A's. Change 4048544 by Robert.Manuszewski Fixing ConditionalBeginDestroy profiling after changes to incremental CBD. Change 4051028 by Graeme.Thornton TBA: ArchiveFromStructuredArchive adapter uses Inner to determine if it is outputting to text, and sets it's own ArIsTextFormat to false Change 4051056 by Graeme.Thornton TBA: High level tagged property / UObject base class text serialization - UObject serialize converted to structured archive - Properties written to text individually with text tags, and then binary adapted values - Only saves, doesn't load Change 4051111 by Graeme.Thornton TBA: Temporarily disable loading of text assets until tagged property serialization path is fixed up Change 4051154 by Graeme.Thornton TBA: Convert a few uobject serializers to structured archive format for example purposes Change 4051181 by Graeme.Thornton TBA: Added default structured archive implementation of SerializeItem to UProperty, which just calls the FArchive version on an FArchiveUObjectFromStructuredArchive adapter. Implemented structured archive SerializeItem for UArrayProperty Change 4051197 by Graeme.Thornton TBA: ObjectProperty text serialization Change 4051216 by Graeme.Thornton Restored a modified FWeakObjectPtr::Serialize function to keep backwards compatibility in code I don't have access to. Change 4051261 by Graeme.Thornton TBA: Convert UMetaData to structured archive Change 4051374 by Steve.Robb Incorrect assert removed. Change 4051562 by Robert.Manuszewski Adding stats for the new GC internal functions Change 4051614 by Graeme.Thornton TBA: Removed UProperty::SerializeItem(FArchive, ...) and replaced with UProperty::SerializeItem(FStructuredArchive::FSlot, ...). Fixed up most of them to work properly and added adapters in for any that were non-trivial. Change 4052512 by Graeme.Thornton TBA: Temporary workaround for softobjectptr and lazyobjectptr uproperties not serialization anything when they know the archive is a reference collector. They should always be serializing their pointers and letting the underlying archive itself ignore them. Change 4053917 by Robert.Manuszewski Clustered objects from clusters that are no longer reachable will now be marked as unreachable immediately when gathering unreachable objects Change 4053919 by Robert.Manuszewski Added the ability to disable incremental BeginDestroy in ini/project settings Change 4055518 by Daniel.Lamb Fixup for deterministic audio generation issue. Submitted on behalf of Rich.Whitehouse #jira nojira #test prefilght automated test. Change 4056854 by Graeme.Thornton TBA: Added a test asset to EngineTest which contains all the different property types and test cases. Change 4056858 by Graeme.Thornton TBA: Updated USetProperty to proper structured archive usage Change 4056872 by Graeme.Thornton TBA: Add map property field to test object Change 4056873 by Graeme.Thornton TBA: Convert UMapProperty to full structured archive Change 4056994 by Graeme.Thornton TBA: Converted FText over to structured archive. Implemented saving, but not loading. Change 4059728 by Ben.Marsh UBT: Add support for using adaptive non-unity builds when the engine and project are in separate repositories. Change 4059805 by Graeme.Thornton Fixed typo in text serialization. Fixes CIS automation test errors Change 4060007 by Graeme.Thornton TBA: FArchiveFromStructuredArchive will now access it's host slot lazily, i.e. only when a value is actually written to the archive. Change 4060092 by Stefan.Boberg Added optimized Windows console window output path to GenericConsoleOutput since this slowed down cooking considerably (2 minutes spent in wprintf alone for one large dataset) When stdout is attached to a console we use the WriteConsoleW function instead of wprintf since the latter is very slow especially in unbuffered mode which the engine currently configures for stdout (see setvbuf call in LaunchEngineLoop.cpp). At some point we should reconsider this buffering policy since it's likely to slow down other platforms as well but I wanted to do a safe change for now as I don't yet fully understand why the setvbuf call is there in the first place. Change 4060108 by Stefan.Boberg Introduced some additional target platform utilities to help with asset cook optimizations * We now assign each ITargetPlatform a zero-based ordinal value * Introduced FTargetPlatform and FTargetPlatformSet types to help store platform references and platform sets efficiently. These are not currently used in the engine but are designed to replace the existing ITargetPlatform/string/FName representations in the cooking data structures. Change 4060143 by Graeme.Thornton Undo //UE4/Dev-Core/Engine/Source/Runtime/... changelist 4060007 Needs some other changes that I haven't checked in yet... Change 4062432 by Ben.Marsh Fix error message when enumerating P4 changes. Change 4062648 by Ben.Marsh Add missing p4 integration action. Change 4063620 by Graeme.Thornton Integrated a fix from UDN where the engine would crash when trying to load a very small encrypted file (<16bytes) from a pak file, where the read address wasn't already aligned to the AES block size. (https://udn.unrealengine.com/questions/431989/crash-while-reading-a-very-small-file-in-encrypted.html) Change 4066963 by Robert.Manuszewski Fixing GC cluster verification code reporting false positives when a cluster is referencing another cluster through 'mutable' objects list. Change 4067133 by Robert.Manuszewski Changed log verbosity when reporting individual cases of GC cluster assumption violations as they are followed by an asser anyway and this way we get the chance to see all issues before we assert at the end of these checks. Change 4067443 by Steve.Robb FString can now be constructed from any char pointer type and length. Change 4068156 by Steve.Robb Fix necessary because of FString constructor change in CL# 4067443. Change 4070258 by Graeme.Thornton Fixes for VSCode Change 4070372 by Graeme.Thornton TBA: Script struct serialization to structured archives Change 4071913 by Ben.Marsh Move bulk of the code for UnrealPak into an engine developer module, so it can be used in the editor. Change 4071914 by Ben.Marsh Missing files. Change 4071937 by Ben.Marsh Missing header. Change 4072015 by Ben.Marsh Fixes for compiling PakFileUtilities as part of the editor. Change 4072826 by Steve.Robb TBitArray::Reserve() added. TBitArray::Add() overloaded to allow adding multiple bits. TSparseArray::Reserve() optimized to call the overloaded Add(). Change 4073271 by Daniel.Lamb Fixed add patch tier in project launcher passing the wrong commandline option to UAT. #test none Change 4074708 by James.Hopkin #core Removed redundant Casts Change 4074763 by Steve.Robb Fix for TSparseArray::Reserve() size. Change 4076063 by Ben.Marsh Add an "UnrealPak" commandlet with the same functionality as the standalone UnrealPak program. Invoke by running the editor with -run=UnrealPak and the standard UnrealPak commandline options. Change 4077064 by Robert.Manuszewski Fixing compile error in PakFileUtilities Change 4077144 by Graeme.Thornton TBA: TextAssetCommandlet improvements * Collect lists of broken assets during roundtrip tests and print a summary of packages that failed each phase at the end * After resaving as text, load the file back as a plain JSON hierarchy to ensure the output was valid Change 4077412 by Ben.Marsh Set the correct exit code for UnrealPak. Should return 0 on success, not 1. Change 4077760 by Graeme.Thornton TBA: Loading fixed for tagged property serialization Includes conversion of all UProperty::ConvertFromType() and SerializeFromMismatchedTag() functions to use structured archives Lazy initialization of FArchiveFromStructruredArchive when loading, to support the possibility of an adapter being create around an object property serialize call to its inner UStruct, which then decides not to do anything and return false. Stops the ArchiveFromStructuredArchive from consuming the slot and getting upset later on when we try to serialize normal tagged properties from it. Disabled lazy bulk data loading from text assets. Requires a bigger change to make it work. Added some debug checks to json input formatter which track the current value stack size when a new object is pushed onto the stack, and makes sure that the stack has returned to the same size when the object is popped. Catches cases where we unpack an array/stream to the value stack but then don't consume all the items. Change 4078800 by Ben.Marsh Change UAT to using the editor's UnrealPak commandlet rather than invoking the standalone UnrealPak executable. To improve performance when building several PAK files, also add a new -batch=<file> command which reads commands to execute in parallel from a text file. Change 4079745 by Graeme.Thornton TBA: Migrated a couple of UObject Serialize functions to FStructuredArchive (SoundCue / MaterialExpressions / Editor strip flags) Change 4079847 by Graeme.Thornton TBA: Add 'FindMismatchedSerializers' mode to text asset commandlet, which dumps out a list of all UClasses which don't have the CLASS_MatchedSerializers flag, meaning we can't guarantee the have Serialize functions for FArchive AND FStructuredArchive, therefore we can't use the new structured archive based serialize path. Should only ever be native instrinsic classes as UHT takes care of all other cases. Change 4079925 by Ben.Marsh Fix incorrect assignment when deriving name for chunked pak file. Change 4080214 by Ben.Marsh Move the ThreadPoolWorkQueue class into DotNETUtilities so it can be used by other projects. Change 4082394 by Graeme.Thornton CIS fix for variable shadowing warning Change 4082583 by Ben.Marsh Add a IBinarySerializable interface for types that support reading from a BinaryReader and writing to a BinaryWriter. Implementing IBinarySerializable implies a constructor taking a BinaryReader argument is available for deserializing. Change 4082652 by Ben.Marsh Fix FileReference.Directory not returning a directory with a trailing backslash for files in the root directory. Change 4082755 by Graeme.Thornton Fixed an erroneous usage of TUniquePtr<uint8>as a pointer to a uint8 array when creating pak files. Caused a crash when compression was enabled, and has probably surfaced because pak generation is now done by an editor commandlet rather than a standalone program. Change 4082756 by Graeme.Thornton Fixed some incorrect documentation for pakfile compressed chunk headers Change 4082883 by Graeme.Thornton Static analysis warning fix Change 4082912 by Ben.Marsh Move ExceptionUtils into DotNETUtilities. Change 4085291 by Graeme.Thornton TBA: In the Json output formatter, write float and double values out with enough precision for successful roundtripping. Added some debug only code which will immediately reconvert the string back to its original value and compare the the input Change 4085523 by Graeme.Thornton TBA: Remove only explicit usage of DECLARE_FSTRUCTUREDARCHIVE_SERIALIZER. Should only be used from UHT generated code. Change 4086037 by Robert.Manuszewski Fix for a potential race condition when two threads want to acquire GC lock Change 4088655 by Graeme.Thornton Pak creation now uses the bEnablePakSigning setting from the crypto config json file Change 4091474 by Steve.Robb Fix for TStaticBitArray::FindFirstSetBit() and TStaticBitArray::FindFirstClearBit(). Unused variables removed. Change 4093632 by Steve.Robb CIS fixes. Change 4093656 by Graeme.Thornton Build fix Change 4093744 by Ben.Marsh Allow per-chunk settings for whether to enable compression in UnrealPak. Change 4099712 by Gil.Gribb UE4 - Fixed rare case where insufficient space was preallocated for cooldown ticks. #jira UE-59686 Change 4099912 by Stefan.Boberg Cooking timer optimizations: - Replaced data structures for FScopeTimer and FHierarchicalTimerInfo. Previous implementation used FString for many things and caused *lots* of heap and string concatenation activity. Replaced with a compile-time node id (using __COUNTER__) and raw string literals. - Removed PERPACKAGE_TIMER support (was disabled by default and was difficult to test) - Made it possible to toggle OUTPUT_TIMING and ENABLE_COOK_STATS independently - Removed some extremely tight timers because the overhead from calling QPC significantly exceeded the measured code This change shaved some 15% off a clean cook of Fortnite WindowsClient (en) with fully populated local DDC Change 4100519 by Stefan.Boberg Quick fix for Linux build issue introduced in 4099927 Change 4105327 by Stefan.Boberg Cooker: Changed FHierarchicalTimerInfo so it uses a linked list for tracking child nodes, to be able to deal with any child count. Previously we assumed there would never be more than 9 children but it turns out there are cooker modes that need more. Fixes check when using -FullLoadAndSave to cook Change 4105448 by Stefan.Boberg - Fixed Linux build warning re: member initialization order - Also eliminated OUTPUT_HIERARCHYTIMERS/CLEAR_HIEARCHYTIMERS macros (plain functions are fine) - Moved finishing-up code for FullLoadAndSave() to TickCookOnTheSide() call site to improve timer output. Previously some of the scopes would not have been closed before printing and thus the output was misleading. Change 4109031 by Ben.Marsh Attribute-driven Perforce wrapper (old Epic Friday project). Offers a more complete implementation than the current P4 wrapper in UAT without requiring any platform-specific libraries. Uses the Python binary output for parsing. Change 4109588 by Ben.Marsh UBT: Add extension methods for serializing a nullable type to a BinaryReader/BinaryWriter. Change 4109595 by Ben.Marsh Missing project file for DotNETUtilities. Change 4110724 by Stefan.Boberg Removed annotation map locking in UObjectMarks, eliminating around one minute (~3.5%) from Fortnite cook time. The locking was redundant since the annotation maps are managed per thread anyway. Change 4111304 by Ben.Marsh UAT: Add support for setting a status message through the log class. Allows writing transient messages (eg. progress messages) which will be cleared out before writing other messages. Best used through the LogStatusScope class, which can set a status message for the duration of a using() block. As part of this change, the console no longer has to be added as a dedicated trace listener. Since we already special-case this listener when formatting log output, it's easier to just keep the implementation separate to the other trace listeners. Change 4112708 by Steve.Robb Fix for TBitArray::MaxBits in assignment. Change 4114133 by Stefan.Boberg Tweaked how low-level memory (LLM) tracker is implemented to reduce overheads. Previously FMemory functions would acquire the LLM singleton and call OnLowLevelFree/OnLowLevelAlloc etc which would check the bIsDisabled flag and early out if it was set. Due to how frequently these functions were called this ended up costing quite a bit. - This change makes the flag a static member variable instead of a member variable and therefore enables a simpler early-out to be implemented. - The singleton getter is also simplified to avoid hitting the threadsafe singleton construction path on every call. - The enable flag is no longer TAtomic - this also incurs extra overhead for no clear benefit Shaves approximately 3.5% (one minute) off a Fortnite cook test scenario (using -FullLoadAndSave) Change 4115010 by Robert.Manuszewski Fixing CIS Change 4115249 by Robert.Manuszewski Fixing async loading code asserts when exiting game very early due to an error #jira UE-56267 Change 4117091 by Ben.Marsh Prevent doubled-up lines when writing status updates with console log verbosity. Change 4117207 by Ben.Marsh UGS: Do not include executables in diagnostics zip file, and ignore "no such files" error when cleaning workspace. Change 4119175 by Ben.Marsh UGS: Fix crash writing version files when directory does not already exist. Change 4119987 by Ben.Marsh UGS: Show a dialog box while the launcher is updating executables from Perforce, which allows cancelling the operation if necessary. Allow setting the username on the settings window, and prompt for login credentials if necessary. Should prevent situations where users have to update settings from the command prompt. Holding down shift during launch now shows the settings dialog rather than an immediate prompt to launch the unstable version (unstable version is shown as a checkbox on this dialog). Change 4119991 by Ben.Marsh Update version number for UGS launcher to 1.13. Change 4121943 by Robert.Manuszewski Don't use FArchiveAsync2 for reading packages with non-async path in editor builds as its performance is worse than the standard archive's (saves about 1 minute when doing larger cooks and 7 seconds when loading into PIE) Change 4122592 by Steve.Robb GitHub #4762 : Improve wording and grammar of Math comments Also includes improved accuracy in FMath::ComputeBoundingSphereForCone(). Change 4122819 by Stefan.Boberg Don't call CreateDirectory redundantly when opening files for writing using FFileManagerGeneric::CreateFileWriter This change avoids calling IPlatformFile::CreateDirectoryTree if possible since this is a very expensive function especially for deep hierarchies as it performs directory creation from the root directory onwards instead of from the leaf downwards. That function should also be fixed but this change improves performance in the meantime. Change 4122872 by Stefan.Boberg CreateDirectoryTree now creates directories leaf-to-root instead of the other way around. This is much more efficient since we don't spend time on system API calls for directories which already exist. This accounted for a very large amount of CPU time in cooking as the full target file directory hierarchy would be "created" for every single output file. Change 4123109 by Stefan.Boberg - Disable overlapped I/O in editor / cooker. Synchronous I/O reduces the number of syscalls and Windows performs prefetching on our behalf anyway for sequential reads - Eliminated syscall which was issued for every write to update cached file size -- since we're the only writers to the file (file access allows read sharing at most) we can authoritatively update the file size on write completion Change 4123455 by Ben.Marsh PR #4775: New build param PCHMemoryAllocationFactor to set /Zm VS build param. (Contributed by lucaswall) Change 4124207 by Ben.Marsh UBT: Remove some unnecessary indirection for generated code paths. Change 4124217 by Ben.Marsh UBT: Remove another unused variable from UEBuildModuleCPP. Change 4124377 by Stefan.Boberg In IPlatformFile::DeleteDirectoryRecursively, attempt to delete file first and if it fails clear the readonly flag and try again Previously there was a call to clear the readonly flag for every deleted file and this is a waste of resources 99% of the time. The SetFileAttributes call accounted for a significant amount of time during cooker sandbox directory deletion Change 4125071 by Stefan.Boberg Some tweaks to FQueuedThreadPoolBase scheduling and memory management - Explicitly pass in false for TArray::RemoveAt(..., bool bAllowShrinking) argument to prevent memory reallocation when arrays are drained and inevitably repopulated shortly afterwards - Use a MRU strategy instead of LRU when picking a thread to wake up. The MRU thread is the most likely to have a 'hot' cache for the stack etc. Picking from the back of the array also happens to be cheaper since no memory movement is necessary when RemoveAt is called. (This was the strategy in place before CL2600362 which seems to have changed it unintentionally) - Release lock as soon as a thread has been chosen, before asking the worker thread to wake up and do the work Change 4126132 by Ben.Marsh UAT: Detect when stdout is redirected and prevent using backspace characters to move the cursor. Change 4126867 by Graeme.Thornton TBA: Fix tagged binary formatter Change 4127010 by Robert.Manuszewski AnimScriptInstances created at runtime will now also be added to the owning omponent's cluster to avoid GC issues. Change 4127932 by Ben.Marsh WorkspaceTool: Reduce unnecessary logging of status messages when console output is not redirected. Change 4129050 by Ben.Marsh UGS: Check for NET Framework 4.5 being installed before running the installer. Also fix warning trying to kill existing UGS instances before upgrade. Change 4129459 by Graeme.Thornton TBA: TextAssetCommandlet - When outputting converted assets to an output path, replicate the workspace relative path in the output directory Change 4129515 by Graeme.Thornton TBA: Add EnterRecord overload that allows outputting of available field names when loading. Change 4129517 by Graeme.Thornton TBA: Tagged properties are written out as named fields on the "Properties" record, rather than as a stream with a null tag at the end Change 4129518 by Graeme.Thornton TBA: Added a local const bool to allow easy hacking out of text asset loading support Change 4129558 by Graeme.Thornton TBA: Build fix for textasset-less configs Change 4129614 by Ben.Marsh UGS: Main window is now restored to normal size when activated by clicking on the tray icon. #jira UE-60490 Change 4129618 by Ben.Marsh UGS: Speculative fix for unreproduced exception accessing disposed window while shutting down. Change 4131936 by Robert.Manuszewski Removing some WIP code accidentally checked in with CL #4121943 Change 4133490 by Ben.Marsh UGS: Allow the $(Change) variable to be used in more places than just the context menu. #jira UE-60573 Change 4133550 by Ben.Marsh UGS: Setting for whether or not to use incremental builds is now exposed through the variable "$(UseIncrementalBuilds)" for use by custom build steps. #jira UE-60554 Change 4133681 by Ben.Marsh UGS: A per-project list of folders and extensions to be deleted by default when running the 'clean workspace' tool can now be specified through the <ProjectDir>/Build/UnrealGameSync.ini file. Settings may be specified for an individual branch (via a category with the depot path to the project) or for wherever the project is currently open (via the [Default] category). The SafeToDeleteFolders list specifies a substring that will be checked against folder paths. Anything containing this folder will be marked as safe for delete by default. The SafeToDeleteExtensions list specifies a list of extensions for files that can always be deleted. Example: [Default] +SafeToDeleteFolders=/MyGame/Test/ +SafeToDeleteFolders=/DataService/ +SafeToDeleteExtensions=.xx1 +SafeToDeleteExtensions=.xx2 #jira UE-60575 Change 4135449 by Ben.Marsh Fix allowing use of Job objects on Windows platforms (debug code submitted by mistake) Change 4135730 by Ben.Marsh UBT: Plugins can now be enabled and disabled from the .target.cs file (for targets that do not use the shared compile environment), by compiling the list of enabled/disabled plugin names into the Projects module. Change 4135823 by Ben.Marsh UBT: Remove legacy code to handle disabling optional plugins; now that this is compiled into the target, it will work for any plugins we choose. Change 4135945 by Ben.Marsh UBT: Fix error running programs with no explicitly enabled or disabled plugins. Change 4137207 by Ben.Marsh UGS: Align all badges with the same name, to make it easier to see which CIS steps are being run. Allow overriding the slot taken by a particular badge by calling it "SlotName:LabelName". Change 4137311 by Stefan.Boberg Removed child cooker support. In practice it is not a useful feature as it provides no performance improvement (quite the opposite in fact) and adds testing and maintenance complexity. Change 4137393 by Ben.Marsh UGS: Fix display of multiline errors in the status panel. Change 4141708 by Steve.Robb GitHub #3631 : Incorrect default argument in WeakObjectPtrTemplate #jira UE-45490 Change 4146655 by Stefan.Boberg Removed FullGCAssetClasses logic - no longer necessary nor useful Change 4147318 by Ben.Marsh UGS: Compress build badges in a column if it shrinks below the size that they would be visible. Change 4148207 by Ben.Marsh UGS: Added support for showing the latest completed build from a specific list of badges in the status panel. To declare a badge as one that should appear in the status panel rather than the CIS column, add it to the project's UnrealGameSync.ini in the project or [Default] section like so: +ServiceBadges=RoboMerge Change 4148282 by Stefan.Boberg Fixed bug in UCookOnTheFlyServer::GetCookOnTheFlyUnsolicitedFiles - UnsolicitedFiles should be passed by reference not by value Change 4148344 by Stefan.Boberg Fixed minor indentation error (most likely caused by sloppy merge) Change 4148521 by Stefan.Boberg Removed accidentally checked in PRAGMA_DISABLE_OPTIMIZATION from CookOnTheFlyServer.cpp Change 4148639 by Ben.Marsh UGS: Fix tooltips not showing for changes that have description badges. Change 4149373 by Ben.Marsh UGS: Allow adding additional columns to display particular badges by adding entries from the project config file. Example syntax: +Columns=(Name="Desktop",MinWidth=50,DesiredWidth=100,Weight=3,Badges="Editor") +Columns=(Name="Mobile",MinWidth=50,DesiredWidth=100,Weight=3,Badges="IOS,Android") Same form can be used to control how default columns are displayed (though badge settings are ignored). Also allow PerforceMonitor to detect local changes to project config files and update settings automatically. Change 4149399 by Ben.Marsh UGS: Update version to 1.143. Change 4155660 by Steve.Robb PROJECTION and PROJECTION_MEMBER macros which provide the correct behavior when creating projections using functions which are overloaded or use default arguments. Change 4157117 by Ben.Marsh Fix warning due to plugins disabled in .target.cs file. Change 4158011 by Ben.Marsh UBT: Add a check that the UnrealHeaderTool target file exists, rather than throwing an exception when reading it fails. Change 4158646 by Ben.Marsh UGS: Fix exception when login is discovered to have expired during a workspace update. Change 4158678 by Ben.Marsh UGS: Fix an exception on shutdown due to the icon being hidden after it's already been disposed. Change 4158683 by Ben.Marsh UGS: Add an unhandled exception filter which sends the exception data to the backend. Change 4159131 by Ben.Marsh UGS: Reduce the number of characters displayed for build badges based on the available space. Change 4159194 by Graeme.Thornton TBA: Fix incorrect map property conversion code when converting an old property that contains a map with different key/value types Change 4159239 by Steve.Robb Improved readability and compliance with coding standards. Change 4159246 by Ben.Marsh UGS: Allow syncing projects where source code is not available (and various version files don't exist). #jira UE-60985 Change 4159286 by Ben.Marsh UGS: Remove requirement for UE4Editor.target.cs to be visible in the depot in order to open a project. #jira UE-60986 Change 4159302 by Ben.Marsh UGS: Update version to 1.144. Change 4160308 by Ben.Marsh All staging client executables for blueprint projects. #jira UE-60983 Change 4161567 by Steve.Robb GitHub #4816 : UE-60771: Handle escaped double quote in FParse::LineExtended Change 4162641 by Ben.Marsh UGS: Allow customizing the position of custom columns, via the Index=N attribute. Change 4162647 by Ben.Marsh UGS: Update version to 1.145. Change 4165319 by Robert.Manuszewski PR #4812: Fix inconsistent command-line argument handling under Windows (Contributed by adamrehn) Change 4166150 by Ben.Marsh UGS: Include *.inl when looking for code changes. Change 4166551 by Steve.Robb Whitespace fixes caused by a bad merge. Change 4168483 by Ben.Marsh UGS: Add a more useful error if a file to be synced exceeds the max allowed path length. Change 4168490 by Ben.Marsh UGS: Update version to 1.146. Change 4168551 by Ben.Marsh UBT: Move bBuildLargeAddressAwareBinary into an exposed setting. Change 4168560 by Ben.Marsh UBT: Remove static config variable for controlling which configuration of UHT to use. Change 4171296 by Ben.Marsh UGS: Move the check for overlong paths earlier. Change 4171531 by Ben.Marsh UBT: Fix exception if BuildConfiguration.xml contains an unknown category. Change 4183371 by Robert.Manuszewski Fix for a crash in Async Loading Graph's CheckCycles when GC kicks in on the game thread and forces ALT to exit early Change 4184312 by Ben.Marsh UGS: Update version to 1.148 Change 4184480 by Robert.Manuszewski Removing unused async loading stat Change 4186390 by Ben.Marsh UBT: Format XML validation errors in a format that allows double-clicking on the message in Visual Studio. Change 4188644 by Ben.Marsh UBT: Add the MakePathSafeToUseWithCommandLine() function to UBT. Change 4188647 by Ben.Marsh UBT: Fix exception in target receipt when architecture is null. Change 4189617 by Ben.Marsh Change FileSystemReference, FileReference and DirectoryReference objects to use OrdinalIgnoreCase comparisons without creating a separate copy of the string to compare. The filesystem does not use the invariant culture, and it can produce the wrong results in some cases (the ordinal comparison is faster, too). Change 4189740 by Ben.Marsh UAT: Remote code to build UnrealPak when packaging; we use the editor now. Change 4189860 by Ben.Marsh UGS: Make the filter for excluding automated lighting rebuilds more explicit. Change 4190082 by Ben.Marsh Fixes to allow enabling edit and continue for Windows builds. Have experienced quite a few VS crashes when testing it in editor; not yet recommended for general use. - Allow edit and continue for any configuration, not just debug. - Fixed PDB errors compiling files that use a shared PCH with edit and continue enabled. Path to the generated PDB file was using the wrong directory. - Removed code that tracks PDB output files, since they're modified multiple times during a build. - Enable debug information when compiling generated CPP files, since it causes errors if the shared PCH PDB doesn't have the same option. - Disable support for remote execution of steps that modify the PDB, since the same file has to be modified many times. Remote execution causes the PDB files to be corrupted. Unfortunately, this makes E&C builds significantly slower. #jira Change 4192949 by Ben.Marsh UBT: Minor tidy-up (merging UEBuildBinary.Build and UEBuildBinary.SetupOutputFiles) Change 4193218 by Ben.Marsh Fix formatting. Change 4197252 by Mike.Erwin UAT: Fix log output w/ correct count of non-code projects. #jira none Change 4197941 by Ben.Marsh UGS: Add support for DebugGame editors that have an executable with a DebugGame suffix. Change 4197964 by Ben.Marsh UGS: Prevent attempts to automatically reopen projects while a modal dialog is up, or the workspace is syncing. Change 4198144 by Ben.Marsh UGS: Prevent modal dialogs when login expires in P4, and prompt for password when hitting "retry". Change 4198413 by Ben.Marsh UGS: Always show the main window when launched manually, and run with -RestoreState when launched at startup. Also add a couple more places that save the visibility state, since logging off seems like it can terminate the process abrubtly. Change 4198779 by Ben.Marsh UBT: Allow generating manifests to any arbitrary locations with the -Manifest=<Path> argument. Change 4198825 by Ben.Marsh UBT: Move code to enumerate Slate runtime dependencies into the Slate module. Doesn't need to be done inside core UBT. Change 4199341 by Ben.Marsh UGS: Update version to 1.149 Change 4199642 by Chad.Garyet - Deprecate CISController - Add BuildController to replace CIS GET/POST for builds - Add LatestController, GET does what CIS/GET used to do - Change Latest/GET to return the last 25 builds filtered by project, rather than the last 5000 individual Ids - Latest/GET now returns "LatestData" object instead of array of longs - Updated EventMonitor to match all API changes - Fixed bug where IDs were getting reset to initial startup values every update loop Change 4199663 by Chad.Garyet CIS controller still needs to return an array of longs #jira none Change 4199680 by Ben.Marsh UGS: Update version to 1.150 Change 4200457 by Ben.Marsh Merging CIS fix for non-development configurations. Change 4200472 by Mike.Erwin UAT: fix -skipbuildclient param default It was defaulting to skipbuildeditor's value, likely a copy-paste error. #jira none Change 4202595 by Ben.Marsh Fix static analysis warning due to constant comparison against macro. Change 4203250 by Ben.Marsh UGS: Always show the "Sync Precompiled Editor" option, but disable it and show a tooltip explaining why if it is not available. Change 4206191 by Ben.Marsh Exclude editor target files from installed builds, since they leak info about DLLs that have been stripped out. Change 4213011 by Ben.Marsh UBT: Include contents of modified intermediate files in the log, to make it easier to debug hidden dependencies. Change 4213487 by Ben.Marsh UBT: Fix assumption that bPrecompile is equivalent to bBuildAllModules. This is no longer the case; they are now controlled by separate options. Should fix CIS errors building the editor. Change 4213609 by Ben.Marsh Ensure that strings formatted using FMicrosoftPlatformString::GetVarArgs() are always null terminated, whether we use the secure CRT or not. Change 4215971 by Ben.Marsh UBT: Remove action graph visualization code; no longer used. Change 4215996 by Ben.Marsh UBT: Remove unqiue id from all actions in the action graph. This is only used for printing debug info in the case of a (rare) cycle in the action graph, so just look it up when needed. Change 4216022 by Ben.Marsh UBT: Rename Crypto.cs to EncryptionAndSigning.cs to match the name of the class inside it, and move it under the System folder. Change 4216031 by Ben.Marsh UBT: Move all the action executors into their own folder in the project. Change 4216526 by Ben.Marsh Fix CIS warnings. Change 4216544 by Ben.Marsh Replace custom code to ensure FMicrosoftPlatformString::GetVarArgs() null terminates its buffer with Microsoft's standards-compliant implementation. Change 4216633 by Ben.Marsh Add support for UnrealPak plugins. * Project and plugin modules can now specify an array of supported programs in the "WhitelistPrograms" field of their module descriptors, to allow modules to be loaded by programs. * Programs can now load any runtime modules, as long as they are whitelisted. * Programs under the engine directory can now use a shared build environment, so that building with a project file does not cause output binaries to be output to the project directory. * UnrealPak is now always built by default when packaging * Convert UnrealPak to a modular configuration Change 4216736 by Ben.Marsh UnrealPak: Move "ExportDependencies" command into an editor commandlet, since it relies on the UObject system, asset registry, etc... Change 4217447 by Ben.Marsh Back out revision 50 from //UE4/Dev-Core/Engine/Build/InstalledEngineBuild.xml Change 4217451 by Ben.Marsh Back out revision 11 from //UE4/Dev-Core/Engine/Plugins/Developer/VisualStudioSourceCodeAccess/Source/VisualStudioSourceCodeAccess/VisualStudioSourceCodeAccess.Build.cs Change 4217617 by Ben.Marsh Back out changelist 4217451 Change 4222552 by Ben.Marsh Don't use #import <TypeLib> for VS source code accessor when building with Clang; it's not supported. Change 4222630 by Ben.Marsh UBT: Fix spam while generating project files if Clang isn't installed. Change 4223316 by Ben.Marsh UBT: Change the order in which Visual C++ toolchains are enumerated to prefer full releases over preview releases. Change 4223318 by Ben.Marsh UBT: Add a build setting which allows creating a dedicated PCH for every file that's excluded from the unity working set (disabled by default). Improves iteration times when working on individual cpp files, but slows down iterating on header changes (and can take a lot of disk space for large changes). Dedicated PCH contains all includes scraped from the top of each cpp file, until a non-#include directive is encountered. Change 4223401 by Ben.Marsh UBT: Add an option to automatically enable edit and continue for files in the adaptive non-unity working set. E&C doesn't seem very useful for UE4 projects right now; compile time is comparable to regular build times, but it can take several minutes to apply code changes for large projects. Change 4223899 by Ben.Marsh UBT: Fix loading XML config files on Mono; Type.GetField(Name) does not seem to return values unless binding flags are specified. Change 4224637 by Ben.Marsh Add a "SupportedPrograms" field to plugin descriptors, which allows plugins to declare which plugins they support independently of individual modules. Programs now respect the "bEnabledByDefault" setting in plugins. Plugins that are compatible with a program now need to list that program in the SupportedPrograms list, and whitelist any modules that should load for that program. Change 4224710 by Ben.Marsh UBT: Don't add import libraries as final build products unless the target is being precompiled. Prevents the need for building them for leaf nodes in the action graph. Change 4224715 by Ben.Marsh UBT: Remove hack to allow Stats2.cpp to not follow IWYU convention. Change 4224726 by Ben.Marsh Remove commented out line. Change 4224903 by Ben.Marsh Fix non-unity compile error in Stats2.h. Change 4225051 by Ben.Marsh Back out changelist 4224710; causing CIS errors due to receipts not matching. Change 4225134 by Ben.Marsh Fixing non-unity errors. Change 4225203 by Ben.Marsh Another non-unity fix. Change 4225249 by Ben.Marsh Fix Linux dependencies being copied for the Windows editor; they can be added as requirements for the Linux target platform on Windows instead, so it respects the user's chosen platforms. #jira UE-62001 Change 4225512 by Ben.Marsh BuildGraph: Allow setting the target to build when using the <CsCompile> task. Change 4228815 by Ben.Marsh UBT: Always add the generated code directory to the list of include paths when generating project files. It may only be created after UHT has been run. Change 4228944 by Ben.Marsh UBT: Remove legacy CppCompileEnvironment and LinkEnvironment wrappers from TargetRules that were deprecated in 4.19. Change 4229028 by Ben.Marsh UBT: Fix editor targets with unique build environment having the wrong executable path in generated project files. Move move logic to configure target rules post-construction by the rules assembly to ensure it's valid. Change 4229065 by Ben.Marsh UBT: Move another target setting into the rules assembly. Change 4229105 by Ben.Marsh Fix BPT exception when generating project files. Change 4229311 by Ben.Marsh UBT: Store the module rules file location on the ModuleRules instance, as well as the plugin that it was created from. Also expose the plugin directory as a property on the ModuleRules instance. Change 4229421 by Ben.Marsh UBT: Consolidate functionality for UHT module setup in ExternalExecution.cs. Change 4229817 by Ben.Marsh UBT: Modules must now explicitly specify the path to the header used to generate a PCH if one is desired, rather than the header being determined automatically by attempting to parse the source code. Now that PCHs are force-included anyway, this removes a lot of dependencies inside UBT. Change 4229824 by Ben.Marsh UBT: Remove unused lists inside UEBuildModuleCPP.SourceFilesClass. Change 4229841 by Ben.Marsh UBT: Remove some legacy code from auto-detecting PCHs. Change 4230521 by Ben.Marsh UBT: Add utility functions to the log class to allow formatting errors and warnings in Visual Studio output format (eg. File(Line): warning: Message) Change 4230871 by Ben.Marsh UAT: Remove StreamUtilis utility class; there is a simpler way to implement the one place it's used. Change 4230882 by Ben.Marsh UAT: Add StreamUtils back into UAT, seems like it's still used there. Change 4230896 by Ben.Marsh UBT: Remove some redundant parameters from UEBuildModule/UEBuildModuleCPP/UEBuildModuleExternal constructors. Change 4231014 by Ben.Marsh WorkspaceTool: Include a dump of raw bytes when garbage is read from the P4 process, for diagnostic purposes. Change 4231032 by Ben.Marsh Fix CIS. Change 4231096 by Ben.Marsh Bump the FlatCPPIncludeDependencyCache version, to prevent errors trying to load old files. Change 4231446 by Ben.Marsh UBT: Added support for expanding UE-specific variables in include paths and library paths: $(EngineDir), $(ProjectDir), $(PluginDir), $(ModuleDir). Change 4231460 by Ben.Marsh Modules may now explicitly specify rpaths on Linux via the PublicRuntimeLibraryPaths and PrivateRuntimeLibraryPaths properties. Change 4233909 by Robert.Manuszewski PR #4779: Reason fails as the supplied variable is incorrect (Contributed by projectgheist) Change 4233910 by Ben.Marsh Enable PCHs on IOS. Reduces build time by ~25%. Change 4234176 by Ben.Marsh UBT: Add better messaging for modules that need to have a private PCH set. Now detects the likely PCH using the same method as legacy code and includes it as a suggestion. Change 4234193 by Ben.Marsh Add the Delete command to Perforce wrapper in DotNETUtilities. Change 4234688 by Ben.Marsh UBT: Simplify handling of installed/precompiled builds. Settings for whether a folder is installed/read-only or not is now stored on the RulesAssembly instance, allowing multiple things to be configured separately and stacked together (eg. engine/enterprise/project). RulesAssembly.IsReadOnly() allows determining if a flie can be modified or not and replaces many previous IsXXXInstalledCalls(), and traverses the chain of assemblies. Change 4234711 by Ben.Marsh UBT: Runtime dependencies can now be copied to output directories as part of the build. When adding a runtime dependency, an optional source location can be specified to copy from. Both the source and target paths can use variables can be used as part of the path, eg. $(OutputDir), $(ModuleDir), $(PluginDir). Example usage (from a .build.cs file): RuntimeDependencies.Add("$(OutputDir)/Foo.dll", "$(PluginDir)/Source/ThirdParty/Foo.dll", StagedFileType.NonUFS); Change 4234872 by Ben.Marsh Expose a flag for whether the engine is installed, to fix issues generating project files. Change 4234929 by Ben.Marsh Fix null reference generating receipts when UBT makefiles are active. Change 4235883 by Chad.Garyet Merging 4231245 to core Giving Coordinator its own sln. This should fix what 4158155 was supposed to. #jira UE-61955 Change 4236075 by Ben.Marsh CIS fix Change 4237066 by Robert.Manuszewski Fix for a potential crash when terminating the engine while it's being initialized #jira UE-60545 Change 4237078 by Robert.Manuszewski The engine will no longer be resetting all linkers causing massive load times when renaming the world package when entering Play In Editor Change 4237116 by Ben.Marsh Rewrite some Windows utility functions to support paths longer than MAX_PATH. Change 4237158 by Ben.Marsh Add const TCHAR* overloads of FString::RemoveFromStart() and FString::RemoveFromEnd(). Change 4237159 by Ben.Marsh Fix FWindowsPlatformFile::GetFilenameOnDisk() support for paths longer than MAX_PATH, and simplify some of the other long path functions to avoid copying string buffers. Change 4239050 by Ben.Marsh Missing file Change 4239318 by Ben.Marsh Linux CIS fix. Change 4239685 by Ben.Marsh Static analysis CIS fix. Change 4240800 by Ben.Marsh WorkspaceTool: Include the full command line in the log for any P4 commands. Change 4240903 by Ben.Marsh PR #4909: Update copyright notices to 2018 (Contributed by projectgheist) Change 4241025 by Ben.Marsh UBT: Exclude mobile pipeline caches from generated project files. Causes huge slowdown when using 'Find in Files' through the IDE. Change 4241770 by Ben.Marsh UBT: Include action number in parallel executor output. #jira UE-62032 Change 4243469 by Ben.Marsh TBA: Merge FAnnotatedStructuredArchiveFormatter with FStructuredArchiveFormatter. Any functions that are only implemented for text archives now have a _TextOnly suffix, and are exposed through the FStructuredArchive interface. Change 4245723 by Robert.Manuszewski Fixing another creash when terminating the engine while initializing. #jira UE-60545 Change 4245862 by Steve.Robb VectorLoadFloat2(Ptr) added, which loads { Ptr[0], Ptr[1], Ptr[0], Ptr[1] } into a VectorRegister. Change 4246412 by Robert.Manuszewski The warning 'Calling StaticLoadObject during PostLoad may result in hitches during streaming' will now also report the object which had the PostLoad called on it when StaticLoadObject call happened. Change 4246612 by Ben.Marsh UBT: Fix spelling of "Intellisense". Change 4249454 by Robert.Manuszewski Added extra checks to catch scenarios where the EDL Precache Buffer is flushed before a package header is fully read Change 4249513 by Robert.Manuszewski Made sure the Async Loading Thread doesn't continue running after creating new async packages when garbage collector wants to run on the game thread Change 4255207 by Ben.Marsh UGS: Add additional logging whenever a P4 command fails, and when the user is logged out. Change 4255288 by Ben.Marsh PR #4921: Honor ModuleRules' bEnableExceptions flag when creating precompiled h. (Contributed by surakin) Change 4256422 by Ben.Marsh UBT: Add an error if a module referenced by a plugin descriptor doesn't exist. Change 4257385 by Robert.Manuszewski Creating new objects from within ForEachObjectWithOuter will now result in a fatal error as it's unsafe to change internal UObject hash tables when iterating over them. Change 4257454 by Robert.Manuszewski Added the option to filter clusters listed with gc.ListClusters by objects within them. Usage: gc.ListClusters Hierachy With=ObjectName1,ObjectName2... Change 4257526 by Robert.Manuszewski It's now possible to filter clusters that get logged with verbose cluster logging enabled (UE_GCCLUSTER_VERBOSE_LOGGING=1) by objects within them by specifying -DumpClustersWithObjects=ObjectName1,ObjectName2 in the command line Change 4257822 by Ben.Marsh Fixes for PlatformShowcase compile errors. Change 4258771 by Ben.Marsh UBT: Fix project files not being generated for foreign projects when creating .stub files. #jira UE-62462 Change 4258790 by Ben.Marsh UBT: Clean up the logic around generating project files before creating a stub IPA, so that it fails loudly if project files do not exist, and can accept target names not matching project names. Change 4259276 by Ben.Marsh UBT: Make it an error if a framework doesn't exist, rather than failing silently. Also remove some remote toolchain stuff that's no longer necessary. Change 4259280 by Ben.Marsh UBT: Fix embedded framework zips not being uploaded for plugins. #jira UE-62485 Change 4260236 by Ben.Marsh UBT: Fix path to generated engine project file. Change 4260334 by Ben.Marsh UGS: Fix custom build steps dialog inadvertantly modifying config file settings in-place. Change 4260361 by Ben.Marsh UGS: Allow for p4 login commands to fail, even though the user is logged in (due to a bad connection, etc...) Change 4260559 by Ben.Marsh UGS: Update version. Change 4261160 by Robert.Manuszewski MediaPlaylist will now be added to root set if the owning MediaPlayer is in the disregard for GC set (fixes GC assumption violation crash) #jira UE-62495 Change 4261421 by Ben.Marsh Force-sync files for building documentation, to fix issues with files not being updated. #jira UE-62413 Change 4261425 by Ben.Marsh UBT: Remove some leftover functions for handling the remote toolchain. Change 4261530 by Ben.Marsh UBT: Speculative fix (and better error reporting) for IOS mobile provision not being found in CIS. Change 4261611 by Ben.Marsh UBT: Downgrade warning to a log message, since it appears when generating project files. Change 4261710 by Ben.Marsh Remove assert that GLogConsole is set; it won't be for command line utilities that don't depend on ApplicationCore. #jira UE-62545 Change 4261831 by Ben.Marsh Fix compile errors due to missing include path when hot-reloading a module from the editor. There are not necessarily source files to compile when -modulewithsuffix is specified on the command line, which was results in GeneratedCodeWildcard not being set. #jira UE-62463, UE-62384 Change 4262723 by Ben.Marsh Whitelist plugins that need to be loaded by UFE. #jira UE-62564 Change 4265444 by Ben.Marsh Fix incorrect executable name for DebugGame configurations in Xcode. #jira UE-62574 Change 4265892 by Ben.Marsh Fix incremental compile failures due to dependency checking for unity files. CachedIncludePaths was not correctly being set on file items, so dependencies were being ignored. #jira UE-62575, UE-62603, UE-62597 Change 4266019 by Josh.Adams - Fixed the CopyAction for runtime dependencies that need to be copied to different location, on non-XGE Change 4266264 by Ben.Marsh Remove override for the __IPHONE_OS_VERSION_MIN_REQUIRED macro on TVOS. This macro is already defined by system headers (in <AvailabilityInternal.h>). Now that we support PCHs on IOS and TVOS, manually defining this macro results in it being defined three times (once for the PCH, once by AvailabilityInternal.h, and once by the force-included list of definitions for the source file being built). The errors for redefining the macro in AvailabilityInternal.h are suppressed due to it being a system header, but the error for redefining it for the source file being compiled are not. #jira UE-62578 Change 4266273 by Ben.Marsh Fixes incremental build failure when compile arguments for PCH have changed on IOS/TVOS. Compile action needs to have a dependency on PCH build action. Change 4266614 by Graeme.Thornton Fix crash when cooking nativized blueprints due to removal of child cooker system. Change 4266763 by Ben.Marsh Always build UnrealPak when building client targets. The ProjectParams.Pak option is not reliable, because it can be forced on later by the target platform. #jira UE-62584 Change 4267985 by Robert.Manuszewski When iterating with ForEachObjectWithouter, don't lock the entire has table but only the hash bucket that is currently being iterated #jira UE-62600 Change 4268558 by Robert.Manuszewski PurgeLegacyBlueprints will no longer be called from within ForEachObjectWithOuter is it renames objects that reside in hash tables that are being iterated over which may lead to undefined behavior. #jira UE-62600 Change 4269011 by Chad.Garyet - Fixing Wildcard match issue, the change to ugsapi sends projects as //Depot/Stream instead of //Depot/Stream/ Wildcard match was only substringing to 3 chars. - Checking in the change a while back that increases the number of queried jobs up to 432 based on some maths from Bob about how many builds we want to grab Published to ugsapi server 8/8/17 #jira none Change 4270788 by Ben.Marsh Fix IOS provisioning data being using when remote compiling on TVOS. #jira UE-62705 Change 4271916 by Ben.Marsh Tag the XGEControlWorker executable as a build product after compiling SCW, to make sure it's included in the UGS zip file. Change 4271934 by Ben.Marsh Upload all static libraries in plugin folders as part of remote builds. #jira UE-62694 Change 4273368 by Ben.Marsh Fix Slate dependencies not being enumerated, and rules assembly not being rebuilt when building remotely. #jira UE-62705 Change 4274049 by Ben.Marsh Always parse the team UUID out of the mobile provision when doing a remote compile. The provision installed on the remote Mac (and selected for signing) may be different. #jira UE-62751 Change 4274823 by Ben.Marsh Add the -VersionCookedContent argument to disable the -unversioned parameter on the cooker command line. Change 4275838 by Ben.Marsh Fix BuildVersion string not being passed through from <SetVersion> task. Also add a -BuildVersion command line argument to UBT to override it for a particular build. Change 4275913 by Ben.Marsh Add a dummy exported symbol to the XGEController module, to fix build errors due to missing .lib file when it's built with WITH_XGE_CONTROLLER = 0. Change 4284161 by Ben.Marsh Allow mirroring Oodle files to remote Mac. Change 4074774 by Steve.Robb Vast simplification of TFunction, making it smaller in footprint, easier to follow and extend, and more correct. TUniqueFunction added, which is a move-only TFunction which can hold move-only functors. Fix for UWidgetBlueprint::ForEachSourceWidget() which should never have compiled but did. FFunctionGraphTask and TFuture<> updated to use TUniqueFunction to make them more general. TArray::HeapPop() made to work with move-only types. Change 4082591 by Ben.Marsh Move the Log class from UBT to DotNetUtilities. Change 4083236 by Ben.Marsh Add a Log.WriteException() method to dump an exception message to the console (and write the exception trace to the log) Change 4084107 by Ben.Marsh UAT: Remove the unused -SkipHeader argument to UE4Build. Change 4089771 by Steve.Robb GitHub #4743 : modified VirtualAlloc function flag https://blogs.msdn.microsoft.com/oldnewthing/20151008-00/?p=91411 Change 4091456 by Steve.Robb Unification of all platforms' FMath::CountTrailingZeros() and FMath::CountLeadingZeros() for both 32-bit and 64-bit. Change 4156437 by Ben.Marsh Lots and lots of fixes compiling for Clang on Windows. Editor now compiles cleanly without warnings, but crashes on startup due to error in intrinsics test. Disabling that runs further, but crashes accessing freed memory. Switching to the ANSI allocator runs further, but crashes in Slate after the splash screen and before the editor window opens. // TODO! * Switching between Clang/ICL/VS2015/VS2017 is now supported through the same mechanism as switching Visual Studio versions, without requiring any source level changes. To use Clang, set WindowsPlatform.Compiler = WindowsCompiler.Clang from a .target.cs file, or set <WindowsPlatform><Compiler>Clang</Compiler></WindowsPlatform> from BuildConfiguration.xml. To pick a specific toolchain version, set WindowsPlatform.CompilerVersion. * Clang is now supported through AutoSDKs; will be added to CIS. * The Samples/Sandbox/Clang project forces Clang to be used from its target.cs file, and allows easily building all editor modules and plugins with Clang on Windows. * UnrealMathSSE intrinsics have been re-enabled for Clang due to missing functions from the UnrealMathFPU implementation, but causes failure in tests at startup. * SSE4_CRC32() is disabled in D3D12Pipelinestate.cpp, since intrinsics are only allowed if enabled for the whole target (rather than being used in specific functions due to runtime checks) Change 4157389 by Ben.Marsh Few more fixes for compiling the editor with Clang. Change 4183911 by Ben.Marsh Fixes to support incremental linking on Windows. Does not seem to have any net benefit right now; may improve once minimal rebuild is enabled. * Incremental linking no longer forces PDB files to be enabled for source files. * Actions can specify specific files to be deleted before each build. Code to forcibly delete PDB files has been moved to the MSVC toolchain. * Unused libraries produced by the cross-referenced link are no longer added as build products, since (a) deleting them breaks dependency checking for incremental linking and causes a full link, and (b) not deleting them breaks UBT dependency checking and causes actions to be run over and over again. * Icon update is disabled for Windows when incremental linking is enabled. * Removed rarely-used setting to always delete produced items before each build. Change 4184311 by Ben.Marsh UGS: Added a dialog which shows all the required platform SDKs for a branch, linked from the status panel in UGS. The llist is configured via the UGS config file submitted to Engine/Programs/UnrealGameSync/UnrealGameSync.ini (and may be overridden by the project config file if necessary): [Default] ; Set this to a network share which contains the SDK installers for your site SdkInstallerDir= ; All the required SDKs for the current version of the engine +SdkInfo=(Category="Android", Description="NDK r21", Browse="$(SdkInstallerDir)\\Android") +SdkInfo=(Category="Windows", Description="Visual Studio 2017") +SdkInfo=(Category="Windows", Description="Visual C++ Toolchain 14.13.26128") +SdkInfo=(Category="Windows", Description="Windows SDK 10.0.16299.0") Similar entries for console platforms are added in console subdirectories. Each entry may contain an Install="Foo.exe" and/or Browse="C:\Foo" style attribute, specifying the path to an installer to run or directory to open in explorer respectively. The SdkInstallerDir setting is used as a base directory for the default installers, seen above for Android. Licensees may override this with a network path specific to the site that UGS is being deployed to (either in this file, in a project specific config file, or in a Engine/Programs/UnrealGameSync/NotForLicensees/UnrealGameSync.ini file). Change 4200452 by Ben.Marsh UBT: Change DebugGame configurations to output a separate executable rather than requiring a -Debug argument at runtime. Previous behavior was a common source of errors. Engine modules are still shared between Development and DebugGame, but the launch module sets a flag in Core on startup indicating the game configuration. Change 4206189 by Ben.Marsh UBT: Simplify logic for precompiling binaries. * Target no longer has separate list of "precompile only" binaries or modules. New -AllModules option allows adding every module to a target, which can be used with -Precompile and -NoLink to precompile object files for monolithic builds. * Precompiled file lists have been removed from target receipts. * The manifest now includes all generated headers and precompiled files when run with the -Precompile option. * Separate -DependencyList=Foo.txt has been added to write a list of all dependencies required to use precompiled binaries. This file list can be read using the <Tag> task in buildgraph. Change 4215466 by Ben.Marsh UBT: Remove indirect calls to determine extensions for object files and precompiled headers. The toolchain knows the correct convention for the platform. Change 4215975 by Ben.Marsh UBT: Remove telemetry code. This has never proved useful for analyzing performance due to the number of incidental factors that affect build times (eg. number of files being compiled). Change 4220154 by Ben.Marsh Move text-only implementations of FOutputDeviceError back into Core, so we can build command-line applications that don't depend on ApplicationCore. Change 4224708 by Ben.Marsh Add a bCompileAgainstApplicationCore setting to the target rules, which allows compiling out references to the ApplicationCore module (which should only be necessary for applications with a GUI). Removed ApplicationCore from several engine tools and utilities. Change 4224958 by Ben.Marsh Remove CoreMinimal.h includes from Core. Change 4229059 by Ben.Marsh UBT: Remove the UEBuildPlatform.ShouldNotBuildEditor() hook for target platforms. We shouldn't be modifying a target's build environment to disable the editor; it is invalid to build the editor for these target platforms at all, and this is already enforced by the GetSupportedPlatforms() function. Change 4230508 by Ben.Marsh Fixup precompiled header setting for samples and games. Change 4231457 by Ben.Marsh Fix exceptions in log messages having trailing newlines. Change 4232406 by Ben.Marsh UBT: Always force include a PCH for generated code if there's one set; the code may depend on it to compile. Change 4234177 by Ben.Marsh Set up private PCH files everywhere that previously used them. Change 4235973 by Ben.Marsh Change FPlatformMisc::GetEnvironmentVariable() to return an FString() rather than requiring a fixed size buffer to be passed in. Removes references to MAX_PATH. Change 4238842 by Ben.Marsh Add support for paths longer than MAX_PATH in the editor. Requires Windows 10 version 1607, and the functionality to be enabled via a registry key or group policy (see https://docs.microsoft.com/en-us/windows/desktop/FileIO/naming-a-file). Only a subset of Win32 functions support long paths (executables can only be started from paths shorter than MAX_PATH, for example). * Added a FPlatformMisc::GetMaxPathLength() function to return the maximum length of a path on the current system. On Windows, this returns a different value for systems with long paths enabled to those without. * The MAX_PATH define is no longer set by non-Windows platforms. Instead, there is a MAC_MAX_PATH, UNIX_MAX_PATH, etc... for any platform-specific code that still relies on the previous macro. * The MAX_UNREAL_FILENAME_LENGTH macro has been renamed to MAX_UNREAL_FILENAME_LENGTH_DEPRECATED * The PLATFORM_MAX_FILEPATH_LENGTH macro has been renamed to PLATFORM_MAX_FILEPATH_LENGTH_DEPRECATED. * Removed custom resource files for programs, since they are just copies of the base UE4 one (which is used by default anyway). The base UE4 manifest declares support for long paths. * Fix 512 character maximum length on editor commands. 260 character limit remains in place for cooking at the moment (see ContentBrowserUtils.h), until C# staging code supports long paths. Change 4255042 by Ben.Marsh UBT: Remote compilation now uploads the entire workspace to the remote Mac and executes a separate remote instance of UBT rather than synchronizing individual actions. This makes the remote compile codepath much simpler, and removes a lot of special cases that exist to support it previously. The list of files to be transferred to the remote are listed as rsync filter rules in Engine/Build/Rsync/RsyncEngine.txt and RsyncProject.txt, which are applied to the root engine directory and project directory respectively. Projects that need to customize which files are uploaded can add their own <ProjectDir>/Build/Rsync/RsyncProject.txt file, which will be included in the filter before the default version. Change 4260567 by Ben.Marsh UAT: Rename CommandUtils.Log to CommandUtils.LogInformation, to avoid conflicts with the underlying Tools.DotNETCommon.Log class. #rb none [CL 4285673 by Ben Marsh in Main branch]
2018-08-14 18:32:34 -04:00
LogInformation("Welcomed by server or client loaded, lets wait ten minutes...");
Thread.Sleep(60000 * 10);
}
else
{
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 4285612) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3836829 by Ben.Marsh UBT: Fix ability to precompile plugins from installed engine builds. Change 3839519 by Ben.Marsh UBT: Simplify configuring bPrecompile and bUsePrecompile settings for modules. Each rules assembly can now be configured as installed, which defaults the module rules it creates to use precompiled data. Change 4042043 by Steve.Robb GitHub #4705 : Added weak lambda's for delegates and multicast delegates. Change 4042056 by Robert.Manuszewski Optimized Mark Phase of GC by up to 10ms by making it run in parallel and removing a huge array presize which we didn't need. Change 4042104 by Robert.Manuszewski Set the minimum GC cluster size to 5 so that GC doesn't have to process micro clusters which are more expensive than processing individual objects + Exposed the minimum cluster size to ini and project settings as gc.MinGCClusterSize + Added the ability to sort clusters by name/object count/mutable object count/referenced clusters count when dumping them with gc.ListClusters command Change 4042377 by Robert.Manuszewski Reworked how GC and other threads (ALT specifically) interact - GC will now notify the ALT it wants to run and ALT will immediately try to finish its current work to allow that. Also the entire ALT tick is now protected against GC running at the same time to improve ALT stability. + added gc.ForceCollectGarbageEveryFrame console variable that triggers a forced GC every frame Change 4042427 by Robert.Manuszewski Changed FGCCSyncObject to use events when waiting for GC to finish so that it doesn't spin on non-game threads when GC is running Change 4042482 by Robert.Manuszewski Unhashing unreachable objects (ConditionalBeginDestroy) will now also be done incrementally, just like the purge phase of Garbage Collection Change 4042635 by Robert.Manuszewski Fix for a potential assert when incremental purge garbage is pending and something forces a full purge Change 4044092 by Steve.Robb Fix for forward declared CoreUObject weakobject types in delegates when building in Clang. Change 4044102 by Robert.Manuszewski Fix for a possible hang when worker threads are preventing GC from running and something is later trying to FlushAsyncLoading with the Async Loading Thread enabled Change 4044113 by Steve.Robb Another Clang fix. Change 4044160 by Robert.Manuszewski Disregard For GC pool will now be enabled by default in cooked builds Change 4044287 by Steve.Robb Typo fix. Change 4047723 by Graeme.Thornton TBA: Fixes for import/export name cache and object resolving Change 4048015 by Graeme.Thornton TBA: Weak/Soft/Lazy pointer serialization changes * Remove FWeakObjectPtr::Serialize, move it's logic into, and replace usages of with calls to, FArchiveUObject::SerializeWeakObjectPtr(). Ensures that something is always sent to the archive so that structured archives can be kept happy in the future. * Added Weak/Soft/Lazy pointer handling to the structured archive slot interface and all the formatters. Binary formatters just forward the call onto their inner and text archives store as a string path reference. * FArchiveUObjectFromStructuredArchive caches all these pointer types and stores indices in the binary block, same as with a UObject*. All pointers are then forwarded to the underlying formatter in one go on finalization. Change 4048021 by Steve.Robb Fix for binding an unbound TFunction to another TFunction with a different signature. Also all null pointers now count as unbindings, not just nullptr. TIsMemberPointer added. TIsATFunction and TIsATFunctionRef renamed to remove the 'A's. Change 4048544 by Robert.Manuszewski Fixing ConditionalBeginDestroy profiling after changes to incremental CBD. Change 4051028 by Graeme.Thornton TBA: ArchiveFromStructuredArchive adapter uses Inner to determine if it is outputting to text, and sets it's own ArIsTextFormat to false Change 4051056 by Graeme.Thornton TBA: High level tagged property / UObject base class text serialization - UObject serialize converted to structured archive - Properties written to text individually with text tags, and then binary adapted values - Only saves, doesn't load Change 4051111 by Graeme.Thornton TBA: Temporarily disable loading of text assets until tagged property serialization path is fixed up Change 4051154 by Graeme.Thornton TBA: Convert a few uobject serializers to structured archive format for example purposes Change 4051181 by Graeme.Thornton TBA: Added default structured archive implementation of SerializeItem to UProperty, which just calls the FArchive version on an FArchiveUObjectFromStructuredArchive adapter. Implemented structured archive SerializeItem for UArrayProperty Change 4051197 by Graeme.Thornton TBA: ObjectProperty text serialization Change 4051216 by Graeme.Thornton Restored a modified FWeakObjectPtr::Serialize function to keep backwards compatibility in code I don't have access to. Change 4051261 by Graeme.Thornton TBA: Convert UMetaData to structured archive Change 4051374 by Steve.Robb Incorrect assert removed. Change 4051562 by Robert.Manuszewski Adding stats for the new GC internal functions Change 4051614 by Graeme.Thornton TBA: Removed UProperty::SerializeItem(FArchive, ...) and replaced with UProperty::SerializeItem(FStructuredArchive::FSlot, ...). Fixed up most of them to work properly and added adapters in for any that were non-trivial. Change 4052512 by Graeme.Thornton TBA: Temporary workaround for softobjectptr and lazyobjectptr uproperties not serialization anything when they know the archive is a reference collector. They should always be serializing their pointers and letting the underlying archive itself ignore them. Change 4053917 by Robert.Manuszewski Clustered objects from clusters that are no longer reachable will now be marked as unreachable immediately when gathering unreachable objects Change 4053919 by Robert.Manuszewski Added the ability to disable incremental BeginDestroy in ini/project settings Change 4055518 by Daniel.Lamb Fixup for deterministic audio generation issue. Submitted on behalf of Rich.Whitehouse #jira nojira #test prefilght automated test. Change 4056854 by Graeme.Thornton TBA: Added a test asset to EngineTest which contains all the different property types and test cases. Change 4056858 by Graeme.Thornton TBA: Updated USetProperty to proper structured archive usage Change 4056872 by Graeme.Thornton TBA: Add map property field to test object Change 4056873 by Graeme.Thornton TBA: Convert UMapProperty to full structured archive Change 4056994 by Graeme.Thornton TBA: Converted FText over to structured archive. Implemented saving, but not loading. Change 4059728 by Ben.Marsh UBT: Add support for using adaptive non-unity builds when the engine and project are in separate repositories. Change 4059805 by Graeme.Thornton Fixed typo in text serialization. Fixes CIS automation test errors Change 4060007 by Graeme.Thornton TBA: FArchiveFromStructuredArchive will now access it's host slot lazily, i.e. only when a value is actually written to the archive. Change 4060092 by Stefan.Boberg Added optimized Windows console window output path to GenericConsoleOutput since this slowed down cooking considerably (2 minutes spent in wprintf alone for one large dataset) When stdout is attached to a console we use the WriteConsoleW function instead of wprintf since the latter is very slow especially in unbuffered mode which the engine currently configures for stdout (see setvbuf call in LaunchEngineLoop.cpp). At some point we should reconsider this buffering policy since it's likely to slow down other platforms as well but I wanted to do a safe change for now as I don't yet fully understand why the setvbuf call is there in the first place. Change 4060108 by Stefan.Boberg Introduced some additional target platform utilities to help with asset cook optimizations * We now assign each ITargetPlatform a zero-based ordinal value * Introduced FTargetPlatform and FTargetPlatformSet types to help store platform references and platform sets efficiently. These are not currently used in the engine but are designed to replace the existing ITargetPlatform/string/FName representations in the cooking data structures. Change 4060143 by Graeme.Thornton Undo //UE4/Dev-Core/Engine/Source/Runtime/... changelist 4060007 Needs some other changes that I haven't checked in yet... Change 4062432 by Ben.Marsh Fix error message when enumerating P4 changes. Change 4062648 by Ben.Marsh Add missing p4 integration action. Change 4063620 by Graeme.Thornton Integrated a fix from UDN where the engine would crash when trying to load a very small encrypted file (<16bytes) from a pak file, where the read address wasn't already aligned to the AES block size. (https://udn.unrealengine.com/questions/431989/crash-while-reading-a-very-small-file-in-encrypted.html) Change 4066963 by Robert.Manuszewski Fixing GC cluster verification code reporting false positives when a cluster is referencing another cluster through 'mutable' objects list. Change 4067133 by Robert.Manuszewski Changed log verbosity when reporting individual cases of GC cluster assumption violations as they are followed by an asser anyway and this way we get the chance to see all issues before we assert at the end of these checks. Change 4067443 by Steve.Robb FString can now be constructed from any char pointer type and length. Change 4068156 by Steve.Robb Fix necessary because of FString constructor change in CL# 4067443. Change 4070258 by Graeme.Thornton Fixes for VSCode Change 4070372 by Graeme.Thornton TBA: Script struct serialization to structured archives Change 4071913 by Ben.Marsh Move bulk of the code for UnrealPak into an engine developer module, so it can be used in the editor. Change 4071914 by Ben.Marsh Missing files. Change 4071937 by Ben.Marsh Missing header. Change 4072015 by Ben.Marsh Fixes for compiling PakFileUtilities as part of the editor. Change 4072826 by Steve.Robb TBitArray::Reserve() added. TBitArray::Add() overloaded to allow adding multiple bits. TSparseArray::Reserve() optimized to call the overloaded Add(). Change 4073271 by Daniel.Lamb Fixed add patch tier in project launcher passing the wrong commandline option to UAT. #test none Change 4074708 by James.Hopkin #core Removed redundant Casts Change 4074763 by Steve.Robb Fix for TSparseArray::Reserve() size. Change 4076063 by Ben.Marsh Add an "UnrealPak" commandlet with the same functionality as the standalone UnrealPak program. Invoke by running the editor with -run=UnrealPak and the standard UnrealPak commandline options. Change 4077064 by Robert.Manuszewski Fixing compile error in PakFileUtilities Change 4077144 by Graeme.Thornton TBA: TextAssetCommandlet improvements * Collect lists of broken assets during roundtrip tests and print a summary of packages that failed each phase at the end * After resaving as text, load the file back as a plain JSON hierarchy to ensure the output was valid Change 4077412 by Ben.Marsh Set the correct exit code for UnrealPak. Should return 0 on success, not 1. Change 4077760 by Graeme.Thornton TBA: Loading fixed for tagged property serialization Includes conversion of all UProperty::ConvertFromType() and SerializeFromMismatchedTag() functions to use structured archives Lazy initialization of FArchiveFromStructruredArchive when loading, to support the possibility of an adapter being create around an object property serialize call to its inner UStruct, which then decides not to do anything and return false. Stops the ArchiveFromStructuredArchive from consuming the slot and getting upset later on when we try to serialize normal tagged properties from it. Disabled lazy bulk data loading from text assets. Requires a bigger change to make it work. Added some debug checks to json input formatter which track the current value stack size when a new object is pushed onto the stack, and makes sure that the stack has returned to the same size when the object is popped. Catches cases where we unpack an array/stream to the value stack but then don't consume all the items. Change 4078800 by Ben.Marsh Change UAT to using the editor's UnrealPak commandlet rather than invoking the standalone UnrealPak executable. To improve performance when building several PAK files, also add a new -batch=<file> command which reads commands to execute in parallel from a text file. Change 4079745 by Graeme.Thornton TBA: Migrated a couple of UObject Serialize functions to FStructuredArchive (SoundCue / MaterialExpressions / Editor strip flags) Change 4079847 by Graeme.Thornton TBA: Add 'FindMismatchedSerializers' mode to text asset commandlet, which dumps out a list of all UClasses which don't have the CLASS_MatchedSerializers flag, meaning we can't guarantee the have Serialize functions for FArchive AND FStructuredArchive, therefore we can't use the new structured archive based serialize path. Should only ever be native instrinsic classes as UHT takes care of all other cases. Change 4079925 by Ben.Marsh Fix incorrect assignment when deriving name for chunked pak file. Change 4080214 by Ben.Marsh Move the ThreadPoolWorkQueue class into DotNETUtilities so it can be used by other projects. Change 4082394 by Graeme.Thornton CIS fix for variable shadowing warning Change 4082583 by Ben.Marsh Add a IBinarySerializable interface for types that support reading from a BinaryReader and writing to a BinaryWriter. Implementing IBinarySerializable implies a constructor taking a BinaryReader argument is available for deserializing. Change 4082652 by Ben.Marsh Fix FileReference.Directory not returning a directory with a trailing backslash for files in the root directory. Change 4082755 by Graeme.Thornton Fixed an erroneous usage of TUniquePtr<uint8>as a pointer to a uint8 array when creating pak files. Caused a crash when compression was enabled, and has probably surfaced because pak generation is now done by an editor commandlet rather than a standalone program. Change 4082756 by Graeme.Thornton Fixed some incorrect documentation for pakfile compressed chunk headers Change 4082883 by Graeme.Thornton Static analysis warning fix Change 4082912 by Ben.Marsh Move ExceptionUtils into DotNETUtilities. Change 4085291 by Graeme.Thornton TBA: In the Json output formatter, write float and double values out with enough precision for successful roundtripping. Added some debug only code which will immediately reconvert the string back to its original value and compare the the input Change 4085523 by Graeme.Thornton TBA: Remove only explicit usage of DECLARE_FSTRUCTUREDARCHIVE_SERIALIZER. Should only be used from UHT generated code. Change 4086037 by Robert.Manuszewski Fix for a potential race condition when two threads want to acquire GC lock Change 4088655 by Graeme.Thornton Pak creation now uses the bEnablePakSigning setting from the crypto config json file Change 4091474 by Steve.Robb Fix for TStaticBitArray::FindFirstSetBit() and TStaticBitArray::FindFirstClearBit(). Unused variables removed. Change 4093632 by Steve.Robb CIS fixes. Change 4093656 by Graeme.Thornton Build fix Change 4093744 by Ben.Marsh Allow per-chunk settings for whether to enable compression in UnrealPak. Change 4099712 by Gil.Gribb UE4 - Fixed rare case where insufficient space was preallocated for cooldown ticks. #jira UE-59686 Change 4099912 by Stefan.Boberg Cooking timer optimizations: - Replaced data structures for FScopeTimer and FHierarchicalTimerInfo. Previous implementation used FString for many things and caused *lots* of heap and string concatenation activity. Replaced with a compile-time node id (using __COUNTER__) and raw string literals. - Removed PERPACKAGE_TIMER support (was disabled by default and was difficult to test) - Made it possible to toggle OUTPUT_TIMING and ENABLE_COOK_STATS independently - Removed some extremely tight timers because the overhead from calling QPC significantly exceeded the measured code This change shaved some 15% off a clean cook of Fortnite WindowsClient (en) with fully populated local DDC Change 4100519 by Stefan.Boberg Quick fix for Linux build issue introduced in 4099927 Change 4105327 by Stefan.Boberg Cooker: Changed FHierarchicalTimerInfo so it uses a linked list for tracking child nodes, to be able to deal with any child count. Previously we assumed there would never be more than 9 children but it turns out there are cooker modes that need more. Fixes check when using -FullLoadAndSave to cook Change 4105448 by Stefan.Boberg - Fixed Linux build warning re: member initialization order - Also eliminated OUTPUT_HIERARCHYTIMERS/CLEAR_HIEARCHYTIMERS macros (plain functions are fine) - Moved finishing-up code for FullLoadAndSave() to TickCookOnTheSide() call site to improve timer output. Previously some of the scopes would not have been closed before printing and thus the output was misleading. Change 4109031 by Ben.Marsh Attribute-driven Perforce wrapper (old Epic Friday project). Offers a more complete implementation than the current P4 wrapper in UAT without requiring any platform-specific libraries. Uses the Python binary output for parsing. Change 4109588 by Ben.Marsh UBT: Add extension methods for serializing a nullable type to a BinaryReader/BinaryWriter. Change 4109595 by Ben.Marsh Missing project file for DotNETUtilities. Change 4110724 by Stefan.Boberg Removed annotation map locking in UObjectMarks, eliminating around one minute (~3.5%) from Fortnite cook time. The locking was redundant since the annotation maps are managed per thread anyway. Change 4111304 by Ben.Marsh UAT: Add support for setting a status message through the log class. Allows writing transient messages (eg. progress messages) which will be cleared out before writing other messages. Best used through the LogStatusScope class, which can set a status message for the duration of a using() block. As part of this change, the console no longer has to be added as a dedicated trace listener. Since we already special-case this listener when formatting log output, it's easier to just keep the implementation separate to the other trace listeners. Change 4112708 by Steve.Robb Fix for TBitArray::MaxBits in assignment. Change 4114133 by Stefan.Boberg Tweaked how low-level memory (LLM) tracker is implemented to reduce overheads. Previously FMemory functions would acquire the LLM singleton and call OnLowLevelFree/OnLowLevelAlloc etc which would check the bIsDisabled flag and early out if it was set. Due to how frequently these functions were called this ended up costing quite a bit. - This change makes the flag a static member variable instead of a member variable and therefore enables a simpler early-out to be implemented. - The singleton getter is also simplified to avoid hitting the threadsafe singleton construction path on every call. - The enable flag is no longer TAtomic - this also incurs extra overhead for no clear benefit Shaves approximately 3.5% (one minute) off a Fortnite cook test scenario (using -FullLoadAndSave) Change 4115010 by Robert.Manuszewski Fixing CIS Change 4115249 by Robert.Manuszewski Fixing async loading code asserts when exiting game very early due to an error #jira UE-56267 Change 4117091 by Ben.Marsh Prevent doubled-up lines when writing status updates with console log verbosity. Change 4117207 by Ben.Marsh UGS: Do not include executables in diagnostics zip file, and ignore "no such files" error when cleaning workspace. Change 4119175 by Ben.Marsh UGS: Fix crash writing version files when directory does not already exist. Change 4119987 by Ben.Marsh UGS: Show a dialog box while the launcher is updating executables from Perforce, which allows cancelling the operation if necessary. Allow setting the username on the settings window, and prompt for login credentials if necessary. Should prevent situations where users have to update settings from the command prompt. Holding down shift during launch now shows the settings dialog rather than an immediate prompt to launch the unstable version (unstable version is shown as a checkbox on this dialog). Change 4119991 by Ben.Marsh Update version number for UGS launcher to 1.13. Change 4121943 by Robert.Manuszewski Don't use FArchiveAsync2 for reading packages with non-async path in editor builds as its performance is worse than the standard archive's (saves about 1 minute when doing larger cooks and 7 seconds when loading into PIE) Change 4122592 by Steve.Robb GitHub #4762 : Improve wording and grammar of Math comments Also includes improved accuracy in FMath::ComputeBoundingSphereForCone(). Change 4122819 by Stefan.Boberg Don't call CreateDirectory redundantly when opening files for writing using FFileManagerGeneric::CreateFileWriter This change avoids calling IPlatformFile::CreateDirectoryTree if possible since this is a very expensive function especially for deep hierarchies as it performs directory creation from the root directory onwards instead of from the leaf downwards. That function should also be fixed but this change improves performance in the meantime. Change 4122872 by Stefan.Boberg CreateDirectoryTree now creates directories leaf-to-root instead of the other way around. This is much more efficient since we don't spend time on system API calls for directories which already exist. This accounted for a very large amount of CPU time in cooking as the full target file directory hierarchy would be "created" for every single output file. Change 4123109 by Stefan.Boberg - Disable overlapped I/O in editor / cooker. Synchronous I/O reduces the number of syscalls and Windows performs prefetching on our behalf anyway for sequential reads - Eliminated syscall which was issued for every write to update cached file size -- since we're the only writers to the file (file access allows read sharing at most) we can authoritatively update the file size on write completion Change 4123455 by Ben.Marsh PR #4775: New build param PCHMemoryAllocationFactor to set /Zm VS build param. (Contributed by lucaswall) Change 4124207 by Ben.Marsh UBT: Remove some unnecessary indirection for generated code paths. Change 4124217 by Ben.Marsh UBT: Remove another unused variable from UEBuildModuleCPP. Change 4124377 by Stefan.Boberg In IPlatformFile::DeleteDirectoryRecursively, attempt to delete file first and if it fails clear the readonly flag and try again Previously there was a call to clear the readonly flag for every deleted file and this is a waste of resources 99% of the time. The SetFileAttributes call accounted for a significant amount of time during cooker sandbox directory deletion Change 4125071 by Stefan.Boberg Some tweaks to FQueuedThreadPoolBase scheduling and memory management - Explicitly pass in false for TArray::RemoveAt(..., bool bAllowShrinking) argument to prevent memory reallocation when arrays are drained and inevitably repopulated shortly afterwards - Use a MRU strategy instead of LRU when picking a thread to wake up. The MRU thread is the most likely to have a 'hot' cache for the stack etc. Picking from the back of the array also happens to be cheaper since no memory movement is necessary when RemoveAt is called. (This was the strategy in place before CL2600362 which seems to have changed it unintentionally) - Release lock as soon as a thread has been chosen, before asking the worker thread to wake up and do the work Change 4126132 by Ben.Marsh UAT: Detect when stdout is redirected and prevent using backspace characters to move the cursor. Change 4126867 by Graeme.Thornton TBA: Fix tagged binary formatter Change 4127010 by Robert.Manuszewski AnimScriptInstances created at runtime will now also be added to the owning omponent's cluster to avoid GC issues. Change 4127932 by Ben.Marsh WorkspaceTool: Reduce unnecessary logging of status messages when console output is not redirected. Change 4129050 by Ben.Marsh UGS: Check for NET Framework 4.5 being installed before running the installer. Also fix warning trying to kill existing UGS instances before upgrade. Change 4129459 by Graeme.Thornton TBA: TextAssetCommandlet - When outputting converted assets to an output path, replicate the workspace relative path in the output directory Change 4129515 by Graeme.Thornton TBA: Add EnterRecord overload that allows outputting of available field names when loading. Change 4129517 by Graeme.Thornton TBA: Tagged properties are written out as named fields on the "Properties" record, rather than as a stream with a null tag at the end Change 4129518 by Graeme.Thornton TBA: Added a local const bool to allow easy hacking out of text asset loading support Change 4129558 by Graeme.Thornton TBA: Build fix for textasset-less configs Change 4129614 by Ben.Marsh UGS: Main window is now restored to normal size when activated by clicking on the tray icon. #jira UE-60490 Change 4129618 by Ben.Marsh UGS: Speculative fix for unreproduced exception accessing disposed window while shutting down. Change 4131936 by Robert.Manuszewski Removing some WIP code accidentally checked in with CL #4121943 Change 4133490 by Ben.Marsh UGS: Allow the $(Change) variable to be used in more places than just the context menu. #jira UE-60573 Change 4133550 by Ben.Marsh UGS: Setting for whether or not to use incremental builds is now exposed through the variable "$(UseIncrementalBuilds)" for use by custom build steps. #jira UE-60554 Change 4133681 by Ben.Marsh UGS: A per-project list of folders and extensions to be deleted by default when running the 'clean workspace' tool can now be specified through the <ProjectDir>/Build/UnrealGameSync.ini file. Settings may be specified for an individual branch (via a category with the depot path to the project) or for wherever the project is currently open (via the [Default] category). The SafeToDeleteFolders list specifies a substring that will be checked against folder paths. Anything containing this folder will be marked as safe for delete by default. The SafeToDeleteExtensions list specifies a list of extensions for files that can always be deleted. Example: [Default] +SafeToDeleteFolders=/MyGame/Test/ +SafeToDeleteFolders=/DataService/ +SafeToDeleteExtensions=.xx1 +SafeToDeleteExtensions=.xx2 #jira UE-60575 Change 4135449 by Ben.Marsh Fix allowing use of Job objects on Windows platforms (debug code submitted by mistake) Change 4135730 by Ben.Marsh UBT: Plugins can now be enabled and disabled from the .target.cs file (for targets that do not use the shared compile environment), by compiling the list of enabled/disabled plugin names into the Projects module. Change 4135823 by Ben.Marsh UBT: Remove legacy code to handle disabling optional plugins; now that this is compiled into the target, it will work for any plugins we choose. Change 4135945 by Ben.Marsh UBT: Fix error running programs with no explicitly enabled or disabled plugins. Change 4137207 by Ben.Marsh UGS: Align all badges with the same name, to make it easier to see which CIS steps are being run. Allow overriding the slot taken by a particular badge by calling it "SlotName:LabelName". Change 4137311 by Stefan.Boberg Removed child cooker support. In practice it is not a useful feature as it provides no performance improvement (quite the opposite in fact) and adds testing and maintenance complexity. Change 4137393 by Ben.Marsh UGS: Fix display of multiline errors in the status panel. Change 4141708 by Steve.Robb GitHub #3631 : Incorrect default argument in WeakObjectPtrTemplate #jira UE-45490 Change 4146655 by Stefan.Boberg Removed FullGCAssetClasses logic - no longer necessary nor useful Change 4147318 by Ben.Marsh UGS: Compress build badges in a column if it shrinks below the size that they would be visible. Change 4148207 by Ben.Marsh UGS: Added support for showing the latest completed build from a specific list of badges in the status panel. To declare a badge as one that should appear in the status panel rather than the CIS column, add it to the project's UnrealGameSync.ini in the project or [Default] section like so: +ServiceBadges=RoboMerge Change 4148282 by Stefan.Boberg Fixed bug in UCookOnTheFlyServer::GetCookOnTheFlyUnsolicitedFiles - UnsolicitedFiles should be passed by reference not by value Change 4148344 by Stefan.Boberg Fixed minor indentation error (most likely caused by sloppy merge) Change 4148521 by Stefan.Boberg Removed accidentally checked in PRAGMA_DISABLE_OPTIMIZATION from CookOnTheFlyServer.cpp Change 4148639 by Ben.Marsh UGS: Fix tooltips not showing for changes that have description badges. Change 4149373 by Ben.Marsh UGS: Allow adding additional columns to display particular badges by adding entries from the project config file. Example syntax: +Columns=(Name="Desktop",MinWidth=50,DesiredWidth=100,Weight=3,Badges="Editor") +Columns=(Name="Mobile",MinWidth=50,DesiredWidth=100,Weight=3,Badges="IOS,Android") Same form can be used to control how default columns are displayed (though badge settings are ignored). Also allow PerforceMonitor to detect local changes to project config files and update settings automatically. Change 4149399 by Ben.Marsh UGS: Update version to 1.143. Change 4155660 by Steve.Robb PROJECTION and PROJECTION_MEMBER macros which provide the correct behavior when creating projections using functions which are overloaded or use default arguments. Change 4157117 by Ben.Marsh Fix warning due to plugins disabled in .target.cs file. Change 4158011 by Ben.Marsh UBT: Add a check that the UnrealHeaderTool target file exists, rather than throwing an exception when reading it fails. Change 4158646 by Ben.Marsh UGS: Fix exception when login is discovered to have expired during a workspace update. Change 4158678 by Ben.Marsh UGS: Fix an exception on shutdown due to the icon being hidden after it's already been disposed. Change 4158683 by Ben.Marsh UGS: Add an unhandled exception filter which sends the exception data to the backend. Change 4159131 by Ben.Marsh UGS: Reduce the number of characters displayed for build badges based on the available space. Change 4159194 by Graeme.Thornton TBA: Fix incorrect map property conversion code when converting an old property that contains a map with different key/value types Change 4159239 by Steve.Robb Improved readability and compliance with coding standards. Change 4159246 by Ben.Marsh UGS: Allow syncing projects where source code is not available (and various version files don't exist). #jira UE-60985 Change 4159286 by Ben.Marsh UGS: Remove requirement for UE4Editor.target.cs to be visible in the depot in order to open a project. #jira UE-60986 Change 4159302 by Ben.Marsh UGS: Update version to 1.144. Change 4160308 by Ben.Marsh All staging client executables for blueprint projects. #jira UE-60983 Change 4161567 by Steve.Robb GitHub #4816 : UE-60771: Handle escaped double quote in FParse::LineExtended Change 4162641 by Ben.Marsh UGS: Allow customizing the position of custom columns, via the Index=N attribute. Change 4162647 by Ben.Marsh UGS: Update version to 1.145. Change 4165319 by Robert.Manuszewski PR #4812: Fix inconsistent command-line argument handling under Windows (Contributed by adamrehn) Change 4166150 by Ben.Marsh UGS: Include *.inl when looking for code changes. Change 4166551 by Steve.Robb Whitespace fixes caused by a bad merge. Change 4168483 by Ben.Marsh UGS: Add a more useful error if a file to be synced exceeds the max allowed path length. Change 4168490 by Ben.Marsh UGS: Update version to 1.146. Change 4168551 by Ben.Marsh UBT: Move bBuildLargeAddressAwareBinary into an exposed setting. Change 4168560 by Ben.Marsh UBT: Remove static config variable for controlling which configuration of UHT to use. Change 4171296 by Ben.Marsh UGS: Move the check for overlong paths earlier. Change 4171531 by Ben.Marsh UBT: Fix exception if BuildConfiguration.xml contains an unknown category. Change 4183371 by Robert.Manuszewski Fix for a crash in Async Loading Graph's CheckCycles when GC kicks in on the game thread and forces ALT to exit early Change 4184312 by Ben.Marsh UGS: Update version to 1.148 Change 4184480 by Robert.Manuszewski Removing unused async loading stat Change 4186390 by Ben.Marsh UBT: Format XML validation errors in a format that allows double-clicking on the message in Visual Studio. Change 4188644 by Ben.Marsh UBT: Add the MakePathSafeToUseWithCommandLine() function to UBT. Change 4188647 by Ben.Marsh UBT: Fix exception in target receipt when architecture is null. Change 4189617 by Ben.Marsh Change FileSystemReference, FileReference and DirectoryReference objects to use OrdinalIgnoreCase comparisons without creating a separate copy of the string to compare. The filesystem does not use the invariant culture, and it can produce the wrong results in some cases (the ordinal comparison is faster, too). Change 4189740 by Ben.Marsh UAT: Remote code to build UnrealPak when packaging; we use the editor now. Change 4189860 by Ben.Marsh UGS: Make the filter for excluding automated lighting rebuilds more explicit. Change 4190082 by Ben.Marsh Fixes to allow enabling edit and continue for Windows builds. Have experienced quite a few VS crashes when testing it in editor; not yet recommended for general use. - Allow edit and continue for any configuration, not just debug. - Fixed PDB errors compiling files that use a shared PCH with edit and continue enabled. Path to the generated PDB file was using the wrong directory. - Removed code that tracks PDB output files, since they're modified multiple times during a build. - Enable debug information when compiling generated CPP files, since it causes errors if the shared PCH PDB doesn't have the same option. - Disable support for remote execution of steps that modify the PDB, since the same file has to be modified many times. Remote execution causes the PDB files to be corrupted. Unfortunately, this makes E&C builds significantly slower. #jira Change 4192949 by Ben.Marsh UBT: Minor tidy-up (merging UEBuildBinary.Build and UEBuildBinary.SetupOutputFiles) Change 4193218 by Ben.Marsh Fix formatting. Change 4197252 by Mike.Erwin UAT: Fix log output w/ correct count of non-code projects. #jira none Change 4197941 by Ben.Marsh UGS: Add support for DebugGame editors that have an executable with a DebugGame suffix. Change 4197964 by Ben.Marsh UGS: Prevent attempts to automatically reopen projects while a modal dialog is up, or the workspace is syncing. Change 4198144 by Ben.Marsh UGS: Prevent modal dialogs when login expires in P4, and prompt for password when hitting "retry". Change 4198413 by Ben.Marsh UGS: Always show the main window when launched manually, and run with -RestoreState when launched at startup. Also add a couple more places that save the visibility state, since logging off seems like it can terminate the process abrubtly. Change 4198779 by Ben.Marsh UBT: Allow generating manifests to any arbitrary locations with the -Manifest=<Path> argument. Change 4198825 by Ben.Marsh UBT: Move code to enumerate Slate runtime dependencies into the Slate module. Doesn't need to be done inside core UBT. Change 4199341 by Ben.Marsh UGS: Update version to 1.149 Change 4199642 by Chad.Garyet - Deprecate CISController - Add BuildController to replace CIS GET/POST for builds - Add LatestController, GET does what CIS/GET used to do - Change Latest/GET to return the last 25 builds filtered by project, rather than the last 5000 individual Ids - Latest/GET now returns "LatestData" object instead of array of longs - Updated EventMonitor to match all API changes - Fixed bug where IDs were getting reset to initial startup values every update loop Change 4199663 by Chad.Garyet CIS controller still needs to return an array of longs #jira none Change 4199680 by Ben.Marsh UGS: Update version to 1.150 Change 4200457 by Ben.Marsh Merging CIS fix for non-development configurations. Change 4200472 by Mike.Erwin UAT: fix -skipbuildclient param default It was defaulting to skipbuildeditor's value, likely a copy-paste error. #jira none Change 4202595 by Ben.Marsh Fix static analysis warning due to constant comparison against macro. Change 4203250 by Ben.Marsh UGS: Always show the "Sync Precompiled Editor" option, but disable it and show a tooltip explaining why if it is not available. Change 4206191 by Ben.Marsh Exclude editor target files from installed builds, since they leak info about DLLs that have been stripped out. Change 4213011 by Ben.Marsh UBT: Include contents of modified intermediate files in the log, to make it easier to debug hidden dependencies. Change 4213487 by Ben.Marsh UBT: Fix assumption that bPrecompile is equivalent to bBuildAllModules. This is no longer the case; they are now controlled by separate options. Should fix CIS errors building the editor. Change 4213609 by Ben.Marsh Ensure that strings formatted using FMicrosoftPlatformString::GetVarArgs() are always null terminated, whether we use the secure CRT or not. Change 4215971 by Ben.Marsh UBT: Remove action graph visualization code; no longer used. Change 4215996 by Ben.Marsh UBT: Remove unqiue id from all actions in the action graph. This is only used for printing debug info in the case of a (rare) cycle in the action graph, so just look it up when needed. Change 4216022 by Ben.Marsh UBT: Rename Crypto.cs to EncryptionAndSigning.cs to match the name of the class inside it, and move it under the System folder. Change 4216031 by Ben.Marsh UBT: Move all the action executors into their own folder in the project. Change 4216526 by Ben.Marsh Fix CIS warnings. Change 4216544 by Ben.Marsh Replace custom code to ensure FMicrosoftPlatformString::GetVarArgs() null terminates its buffer with Microsoft's standards-compliant implementation. Change 4216633 by Ben.Marsh Add support for UnrealPak plugins. * Project and plugin modules can now specify an array of supported programs in the "WhitelistPrograms" field of their module descriptors, to allow modules to be loaded by programs. * Programs can now load any runtime modules, as long as they are whitelisted. * Programs under the engine directory can now use a shared build environment, so that building with a project file does not cause output binaries to be output to the project directory. * UnrealPak is now always built by default when packaging * Convert UnrealPak to a modular configuration Change 4216736 by Ben.Marsh UnrealPak: Move "ExportDependencies" command into an editor commandlet, since it relies on the UObject system, asset registry, etc... Change 4217447 by Ben.Marsh Back out revision 50 from //UE4/Dev-Core/Engine/Build/InstalledEngineBuild.xml Change 4217451 by Ben.Marsh Back out revision 11 from //UE4/Dev-Core/Engine/Plugins/Developer/VisualStudioSourceCodeAccess/Source/VisualStudioSourceCodeAccess/VisualStudioSourceCodeAccess.Build.cs Change 4217617 by Ben.Marsh Back out changelist 4217451 Change 4222552 by Ben.Marsh Don't use #import <TypeLib> for VS source code accessor when building with Clang; it's not supported. Change 4222630 by Ben.Marsh UBT: Fix spam while generating project files if Clang isn't installed. Change 4223316 by Ben.Marsh UBT: Change the order in which Visual C++ toolchains are enumerated to prefer full releases over preview releases. Change 4223318 by Ben.Marsh UBT: Add a build setting which allows creating a dedicated PCH for every file that's excluded from the unity working set (disabled by default). Improves iteration times when working on individual cpp files, but slows down iterating on header changes (and can take a lot of disk space for large changes). Dedicated PCH contains all includes scraped from the top of each cpp file, until a non-#include directive is encountered. Change 4223401 by Ben.Marsh UBT: Add an option to automatically enable edit and continue for files in the adaptive non-unity working set. E&C doesn't seem very useful for UE4 projects right now; compile time is comparable to regular build times, but it can take several minutes to apply code changes for large projects. Change 4223899 by Ben.Marsh UBT: Fix loading XML config files on Mono; Type.GetField(Name) does not seem to return values unless binding flags are specified. Change 4224637 by Ben.Marsh Add a "SupportedPrograms" field to plugin descriptors, which allows plugins to declare which plugins they support independently of individual modules. Programs now respect the "bEnabledByDefault" setting in plugins. Plugins that are compatible with a program now need to list that program in the SupportedPrograms list, and whitelist any modules that should load for that program. Change 4224710 by Ben.Marsh UBT: Don't add import libraries as final build products unless the target is being precompiled. Prevents the need for building them for leaf nodes in the action graph. Change 4224715 by Ben.Marsh UBT: Remove hack to allow Stats2.cpp to not follow IWYU convention. Change 4224726 by Ben.Marsh Remove commented out line. Change 4224903 by Ben.Marsh Fix non-unity compile error in Stats2.h. Change 4225051 by Ben.Marsh Back out changelist 4224710; causing CIS errors due to receipts not matching. Change 4225134 by Ben.Marsh Fixing non-unity errors. Change 4225203 by Ben.Marsh Another non-unity fix. Change 4225249 by Ben.Marsh Fix Linux dependencies being copied for the Windows editor; they can be added as requirements for the Linux target platform on Windows instead, so it respects the user's chosen platforms. #jira UE-62001 Change 4225512 by Ben.Marsh BuildGraph: Allow setting the target to build when using the <CsCompile> task. Change 4228815 by Ben.Marsh UBT: Always add the generated code directory to the list of include paths when generating project files. It may only be created after UHT has been run. Change 4228944 by Ben.Marsh UBT: Remove legacy CppCompileEnvironment and LinkEnvironment wrappers from TargetRules that were deprecated in 4.19. Change 4229028 by Ben.Marsh UBT: Fix editor targets with unique build environment having the wrong executable path in generated project files. Move move logic to configure target rules post-construction by the rules assembly to ensure it's valid. Change 4229065 by Ben.Marsh UBT: Move another target setting into the rules assembly. Change 4229105 by Ben.Marsh Fix BPT exception when generating project files. Change 4229311 by Ben.Marsh UBT: Store the module rules file location on the ModuleRules instance, as well as the plugin that it was created from. Also expose the plugin directory as a property on the ModuleRules instance. Change 4229421 by Ben.Marsh UBT: Consolidate functionality for UHT module setup in ExternalExecution.cs. Change 4229817 by Ben.Marsh UBT: Modules must now explicitly specify the path to the header used to generate a PCH if one is desired, rather than the header being determined automatically by attempting to parse the source code. Now that PCHs are force-included anyway, this removes a lot of dependencies inside UBT. Change 4229824 by Ben.Marsh UBT: Remove unused lists inside UEBuildModuleCPP.SourceFilesClass. Change 4229841 by Ben.Marsh UBT: Remove some legacy code from auto-detecting PCHs. Change 4230521 by Ben.Marsh UBT: Add utility functions to the log class to allow formatting errors and warnings in Visual Studio output format (eg. File(Line): warning: Message) Change 4230871 by Ben.Marsh UAT: Remove StreamUtilis utility class; there is a simpler way to implement the one place it's used. Change 4230882 by Ben.Marsh UAT: Add StreamUtils back into UAT, seems like it's still used there. Change 4230896 by Ben.Marsh UBT: Remove some redundant parameters from UEBuildModule/UEBuildModuleCPP/UEBuildModuleExternal constructors. Change 4231014 by Ben.Marsh WorkspaceTool: Include a dump of raw bytes when garbage is read from the P4 process, for diagnostic purposes. Change 4231032 by Ben.Marsh Fix CIS. Change 4231096 by Ben.Marsh Bump the FlatCPPIncludeDependencyCache version, to prevent errors trying to load old files. Change 4231446 by Ben.Marsh UBT: Added support for expanding UE-specific variables in include paths and library paths: $(EngineDir), $(ProjectDir), $(PluginDir), $(ModuleDir). Change 4231460 by Ben.Marsh Modules may now explicitly specify rpaths on Linux via the PublicRuntimeLibraryPaths and PrivateRuntimeLibraryPaths properties. Change 4233909 by Robert.Manuszewski PR #4779: Reason fails as the supplied variable is incorrect (Contributed by projectgheist) Change 4233910 by Ben.Marsh Enable PCHs on IOS. Reduces build time by ~25%. Change 4234176 by Ben.Marsh UBT: Add better messaging for modules that need to have a private PCH set. Now detects the likely PCH using the same method as legacy code and includes it as a suggestion. Change 4234193 by Ben.Marsh Add the Delete command to Perforce wrapper in DotNETUtilities. Change 4234688 by Ben.Marsh UBT: Simplify handling of installed/precompiled builds. Settings for whether a folder is installed/read-only or not is now stored on the RulesAssembly instance, allowing multiple things to be configured separately and stacked together (eg. engine/enterprise/project). RulesAssembly.IsReadOnly() allows determining if a flie can be modified or not and replaces many previous IsXXXInstalledCalls(), and traverses the chain of assemblies. Change 4234711 by Ben.Marsh UBT: Runtime dependencies can now be copied to output directories as part of the build. When adding a runtime dependency, an optional source location can be specified to copy from. Both the source and target paths can use variables can be used as part of the path, eg. $(OutputDir), $(ModuleDir), $(PluginDir). Example usage (from a .build.cs file): RuntimeDependencies.Add("$(OutputDir)/Foo.dll", "$(PluginDir)/Source/ThirdParty/Foo.dll", StagedFileType.NonUFS); Change 4234872 by Ben.Marsh Expose a flag for whether the engine is installed, to fix issues generating project files. Change 4234929 by Ben.Marsh Fix null reference generating receipts when UBT makefiles are active. Change 4235883 by Chad.Garyet Merging 4231245 to core Giving Coordinator its own sln. This should fix what 4158155 was supposed to. #jira UE-61955 Change 4236075 by Ben.Marsh CIS fix Change 4237066 by Robert.Manuszewski Fix for a potential crash when terminating the engine while it's being initialized #jira UE-60545 Change 4237078 by Robert.Manuszewski The engine will no longer be resetting all linkers causing massive load times when renaming the world package when entering Play In Editor Change 4237116 by Ben.Marsh Rewrite some Windows utility functions to support paths longer than MAX_PATH. Change 4237158 by Ben.Marsh Add const TCHAR* overloads of FString::RemoveFromStart() and FString::RemoveFromEnd(). Change 4237159 by Ben.Marsh Fix FWindowsPlatformFile::GetFilenameOnDisk() support for paths longer than MAX_PATH, and simplify some of the other long path functions to avoid copying string buffers. Change 4239050 by Ben.Marsh Missing file Change 4239318 by Ben.Marsh Linux CIS fix. Change 4239685 by Ben.Marsh Static analysis CIS fix. Change 4240800 by Ben.Marsh WorkspaceTool: Include the full command line in the log for any P4 commands. Change 4240903 by Ben.Marsh PR #4909: Update copyright notices to 2018 (Contributed by projectgheist) Change 4241025 by Ben.Marsh UBT: Exclude mobile pipeline caches from generated project files. Causes huge slowdown when using 'Find in Files' through the IDE. Change 4241770 by Ben.Marsh UBT: Include action number in parallel executor output. #jira UE-62032 Change 4243469 by Ben.Marsh TBA: Merge FAnnotatedStructuredArchiveFormatter with FStructuredArchiveFormatter. Any functions that are only implemented for text archives now have a _TextOnly suffix, and are exposed through the FStructuredArchive interface. Change 4245723 by Robert.Manuszewski Fixing another creash when terminating the engine while initializing. #jira UE-60545 Change 4245862 by Steve.Robb VectorLoadFloat2(Ptr) added, which loads { Ptr[0], Ptr[1], Ptr[0], Ptr[1] } into a VectorRegister. Change 4246412 by Robert.Manuszewski The warning 'Calling StaticLoadObject during PostLoad may result in hitches during streaming' will now also report the object which had the PostLoad called on it when StaticLoadObject call happened. Change 4246612 by Ben.Marsh UBT: Fix spelling of "Intellisense". Change 4249454 by Robert.Manuszewski Added extra checks to catch scenarios where the EDL Precache Buffer is flushed before a package header is fully read Change 4249513 by Robert.Manuszewski Made sure the Async Loading Thread doesn't continue running after creating new async packages when garbage collector wants to run on the game thread Change 4255207 by Ben.Marsh UGS: Add additional logging whenever a P4 command fails, and when the user is logged out. Change 4255288 by Ben.Marsh PR #4921: Honor ModuleRules' bEnableExceptions flag when creating precompiled h. (Contributed by surakin) Change 4256422 by Ben.Marsh UBT: Add an error if a module referenced by a plugin descriptor doesn't exist. Change 4257385 by Robert.Manuszewski Creating new objects from within ForEachObjectWithOuter will now result in a fatal error as it's unsafe to change internal UObject hash tables when iterating over them. Change 4257454 by Robert.Manuszewski Added the option to filter clusters listed with gc.ListClusters by objects within them. Usage: gc.ListClusters Hierachy With=ObjectName1,ObjectName2... Change 4257526 by Robert.Manuszewski It's now possible to filter clusters that get logged with verbose cluster logging enabled (UE_GCCLUSTER_VERBOSE_LOGGING=1) by objects within them by specifying -DumpClustersWithObjects=ObjectName1,ObjectName2 in the command line Change 4257822 by Ben.Marsh Fixes for PlatformShowcase compile errors. Change 4258771 by Ben.Marsh UBT: Fix project files not being generated for foreign projects when creating .stub files. #jira UE-62462 Change 4258790 by Ben.Marsh UBT: Clean up the logic around generating project files before creating a stub IPA, so that it fails loudly if project files do not exist, and can accept target names not matching project names. Change 4259276 by Ben.Marsh UBT: Make it an error if a framework doesn't exist, rather than failing silently. Also remove some remote toolchain stuff that's no longer necessary. Change 4259280 by Ben.Marsh UBT: Fix embedded framework zips not being uploaded for plugins. #jira UE-62485 Change 4260236 by Ben.Marsh UBT: Fix path to generated engine project file. Change 4260334 by Ben.Marsh UGS: Fix custom build steps dialog inadvertantly modifying config file settings in-place. Change 4260361 by Ben.Marsh UGS: Allow for p4 login commands to fail, even though the user is logged in (due to a bad connection, etc...) Change 4260559 by Ben.Marsh UGS: Update version. Change 4261160 by Robert.Manuszewski MediaPlaylist will now be added to root set if the owning MediaPlayer is in the disregard for GC set (fixes GC assumption violation crash) #jira UE-62495 Change 4261421 by Ben.Marsh Force-sync files for building documentation, to fix issues with files not being updated. #jira UE-62413 Change 4261425 by Ben.Marsh UBT: Remove some leftover functions for handling the remote toolchain. Change 4261530 by Ben.Marsh UBT: Speculative fix (and better error reporting) for IOS mobile provision not being found in CIS. Change 4261611 by Ben.Marsh UBT: Downgrade warning to a log message, since it appears when generating project files. Change 4261710 by Ben.Marsh Remove assert that GLogConsole is set; it won't be for command line utilities that don't depend on ApplicationCore. #jira UE-62545 Change 4261831 by Ben.Marsh Fix compile errors due to missing include path when hot-reloading a module from the editor. There are not necessarily source files to compile when -modulewithsuffix is specified on the command line, which was results in GeneratedCodeWildcard not being set. #jira UE-62463, UE-62384 Change 4262723 by Ben.Marsh Whitelist plugins that need to be loaded by UFE. #jira UE-62564 Change 4265444 by Ben.Marsh Fix incorrect executable name for DebugGame configurations in Xcode. #jira UE-62574 Change 4265892 by Ben.Marsh Fix incremental compile failures due to dependency checking for unity files. CachedIncludePaths was not correctly being set on file items, so dependencies were being ignored. #jira UE-62575, UE-62603, UE-62597 Change 4266019 by Josh.Adams - Fixed the CopyAction for runtime dependencies that need to be copied to different location, on non-XGE Change 4266264 by Ben.Marsh Remove override for the __IPHONE_OS_VERSION_MIN_REQUIRED macro on TVOS. This macro is already defined by system headers (in <AvailabilityInternal.h>). Now that we support PCHs on IOS and TVOS, manually defining this macro results in it being defined three times (once for the PCH, once by AvailabilityInternal.h, and once by the force-included list of definitions for the source file being built). The errors for redefining the macro in AvailabilityInternal.h are suppressed due to it being a system header, but the error for redefining it for the source file being compiled are not. #jira UE-62578 Change 4266273 by Ben.Marsh Fixes incremental build failure when compile arguments for PCH have changed on IOS/TVOS. Compile action needs to have a dependency on PCH build action. Change 4266614 by Graeme.Thornton Fix crash when cooking nativized blueprints due to removal of child cooker system. Change 4266763 by Ben.Marsh Always build UnrealPak when building client targets. The ProjectParams.Pak option is not reliable, because it can be forced on later by the target platform. #jira UE-62584 Change 4267985 by Robert.Manuszewski When iterating with ForEachObjectWithouter, don't lock the entire has table but only the hash bucket that is currently being iterated #jira UE-62600 Change 4268558 by Robert.Manuszewski PurgeLegacyBlueprints will no longer be called from within ForEachObjectWithOuter is it renames objects that reside in hash tables that are being iterated over which may lead to undefined behavior. #jira UE-62600 Change 4269011 by Chad.Garyet - Fixing Wildcard match issue, the change to ugsapi sends projects as //Depot/Stream instead of //Depot/Stream/ Wildcard match was only substringing to 3 chars. - Checking in the change a while back that increases the number of queried jobs up to 432 based on some maths from Bob about how many builds we want to grab Published to ugsapi server 8/8/17 #jira none Change 4270788 by Ben.Marsh Fix IOS provisioning data being using when remote compiling on TVOS. #jira UE-62705 Change 4271916 by Ben.Marsh Tag the XGEControlWorker executable as a build product after compiling SCW, to make sure it's included in the UGS zip file. Change 4271934 by Ben.Marsh Upload all static libraries in plugin folders as part of remote builds. #jira UE-62694 Change 4273368 by Ben.Marsh Fix Slate dependencies not being enumerated, and rules assembly not being rebuilt when building remotely. #jira UE-62705 Change 4274049 by Ben.Marsh Always parse the team UUID out of the mobile provision when doing a remote compile. The provision installed on the remote Mac (and selected for signing) may be different. #jira UE-62751 Change 4274823 by Ben.Marsh Add the -VersionCookedContent argument to disable the -unversioned parameter on the cooker command line. Change 4275838 by Ben.Marsh Fix BuildVersion string not being passed through from <SetVersion> task. Also add a -BuildVersion command line argument to UBT to override it for a particular build. Change 4275913 by Ben.Marsh Add a dummy exported symbol to the XGEController module, to fix build errors due to missing .lib file when it's built with WITH_XGE_CONTROLLER = 0. Change 4284161 by Ben.Marsh Allow mirroring Oodle files to remote Mac. Change 4074774 by Steve.Robb Vast simplification of TFunction, making it smaller in footprint, easier to follow and extend, and more correct. TUniqueFunction added, which is a move-only TFunction which can hold move-only functors. Fix for UWidgetBlueprint::ForEachSourceWidget() which should never have compiled but did. FFunctionGraphTask and TFuture<> updated to use TUniqueFunction to make them more general. TArray::HeapPop() made to work with move-only types. Change 4082591 by Ben.Marsh Move the Log class from UBT to DotNetUtilities. Change 4083236 by Ben.Marsh Add a Log.WriteException() method to dump an exception message to the console (and write the exception trace to the log) Change 4084107 by Ben.Marsh UAT: Remove the unused -SkipHeader argument to UE4Build. Change 4089771 by Steve.Robb GitHub #4743 : modified VirtualAlloc function flag https://blogs.msdn.microsoft.com/oldnewthing/20151008-00/?p=91411 Change 4091456 by Steve.Robb Unification of all platforms' FMath::CountTrailingZeros() and FMath::CountLeadingZeros() for both 32-bit and 64-bit. Change 4156437 by Ben.Marsh Lots and lots of fixes compiling for Clang on Windows. Editor now compiles cleanly without warnings, but crashes on startup due to error in intrinsics test. Disabling that runs further, but crashes accessing freed memory. Switching to the ANSI allocator runs further, but crashes in Slate after the splash screen and before the editor window opens. // TODO! * Switching between Clang/ICL/VS2015/VS2017 is now supported through the same mechanism as switching Visual Studio versions, without requiring any source level changes. To use Clang, set WindowsPlatform.Compiler = WindowsCompiler.Clang from a .target.cs file, or set <WindowsPlatform><Compiler>Clang</Compiler></WindowsPlatform> from BuildConfiguration.xml. To pick a specific toolchain version, set WindowsPlatform.CompilerVersion. * Clang is now supported through AutoSDKs; will be added to CIS. * The Samples/Sandbox/Clang project forces Clang to be used from its target.cs file, and allows easily building all editor modules and plugins with Clang on Windows. * UnrealMathSSE intrinsics have been re-enabled for Clang due to missing functions from the UnrealMathFPU implementation, but causes failure in tests at startup. * SSE4_CRC32() is disabled in D3D12Pipelinestate.cpp, since intrinsics are only allowed if enabled for the whole target (rather than being used in specific functions due to runtime checks) Change 4157389 by Ben.Marsh Few more fixes for compiling the editor with Clang. Change 4183911 by Ben.Marsh Fixes to support incremental linking on Windows. Does not seem to have any net benefit right now; may improve once minimal rebuild is enabled. * Incremental linking no longer forces PDB files to be enabled for source files. * Actions can specify specific files to be deleted before each build. Code to forcibly delete PDB files has been moved to the MSVC toolchain. * Unused libraries produced by the cross-referenced link are no longer added as build products, since (a) deleting them breaks dependency checking for incremental linking and causes a full link, and (b) not deleting them breaks UBT dependency checking and causes actions to be run over and over again. * Icon update is disabled for Windows when incremental linking is enabled. * Removed rarely-used setting to always delete produced items before each build. Change 4184311 by Ben.Marsh UGS: Added a dialog which shows all the required platform SDKs for a branch, linked from the status panel in UGS. The llist is configured via the UGS config file submitted to Engine/Programs/UnrealGameSync/UnrealGameSync.ini (and may be overridden by the project config file if necessary): [Default] ; Set this to a network share which contains the SDK installers for your site SdkInstallerDir= ; All the required SDKs for the current version of the engine +SdkInfo=(Category="Android", Description="NDK r21", Browse="$(SdkInstallerDir)\\Android") +SdkInfo=(Category="Windows", Description="Visual Studio 2017") +SdkInfo=(Category="Windows", Description="Visual C++ Toolchain 14.13.26128") +SdkInfo=(Category="Windows", Description="Windows SDK 10.0.16299.0") Similar entries for console platforms are added in console subdirectories. Each entry may contain an Install="Foo.exe" and/or Browse="C:\Foo" style attribute, specifying the path to an installer to run or directory to open in explorer respectively. The SdkInstallerDir setting is used as a base directory for the default installers, seen above for Android. Licensees may override this with a network path specific to the site that UGS is being deployed to (either in this file, in a project specific config file, or in a Engine/Programs/UnrealGameSync/NotForLicensees/UnrealGameSync.ini file). Change 4200452 by Ben.Marsh UBT: Change DebugGame configurations to output a separate executable rather than requiring a -Debug argument at runtime. Previous behavior was a common source of errors. Engine modules are still shared between Development and DebugGame, but the launch module sets a flag in Core on startup indicating the game configuration. Change 4206189 by Ben.Marsh UBT: Simplify logic for precompiling binaries. * Target no longer has separate list of "precompile only" binaries or modules. New -AllModules option allows adding every module to a target, which can be used with -Precompile and -NoLink to precompile object files for monolithic builds. * Precompiled file lists have been removed from target receipts. * The manifest now includes all generated headers and precompiled files when run with the -Precompile option. * Separate -DependencyList=Foo.txt has been added to write a list of all dependencies required to use precompiled binaries. This file list can be read using the <Tag> task in buildgraph. Change 4215466 by Ben.Marsh UBT: Remove indirect calls to determine extensions for object files and precompiled headers. The toolchain knows the correct convention for the platform. Change 4215975 by Ben.Marsh UBT: Remove telemetry code. This has never proved useful for analyzing performance due to the number of incidental factors that affect build times (eg. number of files being compiled). Change 4220154 by Ben.Marsh Move text-only implementations of FOutputDeviceError back into Core, so we can build command-line applications that don't depend on ApplicationCore. Change 4224708 by Ben.Marsh Add a bCompileAgainstApplicationCore setting to the target rules, which allows compiling out references to the ApplicationCore module (which should only be necessary for applications with a GUI). Removed ApplicationCore from several engine tools and utilities. Change 4224958 by Ben.Marsh Remove CoreMinimal.h includes from Core. Change 4229059 by Ben.Marsh UBT: Remove the UEBuildPlatform.ShouldNotBuildEditor() hook for target platforms. We shouldn't be modifying a target's build environment to disable the editor; it is invalid to build the editor for these target platforms at all, and this is already enforced by the GetSupportedPlatforms() function. Change 4230508 by Ben.Marsh Fixup precompiled header setting for samples and games. Change 4231457 by Ben.Marsh Fix exceptions in log messages having trailing newlines. Change 4232406 by Ben.Marsh UBT: Always force include a PCH for generated code if there's one set; the code may depend on it to compile. Change 4234177 by Ben.Marsh Set up private PCH files everywhere that previously used them. Change 4235973 by Ben.Marsh Change FPlatformMisc::GetEnvironmentVariable() to return an FString() rather than requiring a fixed size buffer to be passed in. Removes references to MAX_PATH. Change 4238842 by Ben.Marsh Add support for paths longer than MAX_PATH in the editor. Requires Windows 10 version 1607, and the functionality to be enabled via a registry key or group policy (see https://docs.microsoft.com/en-us/windows/desktop/FileIO/naming-a-file). Only a subset of Win32 functions support long paths (executables can only be started from paths shorter than MAX_PATH, for example). * Added a FPlatformMisc::GetMaxPathLength() function to return the maximum length of a path on the current system. On Windows, this returns a different value for systems with long paths enabled to those without. * The MAX_PATH define is no longer set by non-Windows platforms. Instead, there is a MAC_MAX_PATH, UNIX_MAX_PATH, etc... for any platform-specific code that still relies on the previous macro. * The MAX_UNREAL_FILENAME_LENGTH macro has been renamed to MAX_UNREAL_FILENAME_LENGTH_DEPRECATED * The PLATFORM_MAX_FILEPATH_LENGTH macro has been renamed to PLATFORM_MAX_FILEPATH_LENGTH_DEPRECATED. * Removed custom resource files for programs, since they are just copies of the base UE4 one (which is used by default anyway). The base UE4 manifest declares support for long paths. * Fix 512 character maximum length on editor commands. 260 character limit remains in place for cooking at the moment (see ContentBrowserUtils.h), until C# staging code supports long paths. Change 4255042 by Ben.Marsh UBT: Remote compilation now uploads the entire workspace to the remote Mac and executes a separate remote instance of UBT rather than synchronizing individual actions. This makes the remote compile codepath much simpler, and removes a lot of special cases that exist to support it previously. The list of files to be transferred to the remote are listed as rsync filter rules in Engine/Build/Rsync/RsyncEngine.txt and RsyncProject.txt, which are applied to the root engine directory and project directory respectively. Projects that need to customize which files are uploaded can add their own <ProjectDir>/Build/Rsync/RsyncProject.txt file, which will be included in the filter before the default version. Change 4260567 by Ben.Marsh UAT: Rename CommandUtils.Log to CommandUtils.LogInformation, to avoid conflicts with the underlying Tools.DotNETCommon.Log class. #rb none [CL 4285673 by Ben Marsh in Main branch]
2018-08-14 18:32:34 -04:00
LogInformation("Welcomed by server or client loaded, lets wait 30 seconds...");
Thread.Sleep(30000);
}
WelcomedCorrectly = true;
bKeepReading = false;
}
else if (Params.RunAutomationTests)
{
int FailIndex = AllClientOutput.LastIndexOf("Automation Test Failed");
int ParenIndex = AllClientOutput.LastIndexOf(")");
if (FailIndex >= 0 && ParenIndex > FailIndex && FailIndex > LastAutoFailIndex)
{
string Tail = AllClientOutput.Substring(FailIndex);
int CloseParenIndex = Tail.IndexOf(")");
int OpenParenIndex = Tail.IndexOf("(");
string Test = "";
if (OpenParenIndex >= 0 && CloseParenIndex > OpenParenIndex)
{
Test = Tail.Substring(OpenParenIndex + 1, CloseParenIndex - OpenParenIndex - 1);
LogError("Automated test failed ({0}).", Test);
LastAutoFailIndex = FailIndex;
}
}
}
}
}
}
}
}
}
}
}
else
{
LogFileReaderProcess(ServerLogFile, ServerProcess, (string Output) =>
{
bool bKeepReading = true;
if (ClientProcess == null && !String.IsNullOrEmpty(Output))
{
AllClientOutput += Output;
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 3345728) #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 3315219 on 2017/02/21 by Steve.Robb Fix for FObjectAndNameAsStringProxyArchive when serializing a TWeakObjectPtr. Change 3315285 on 2017/02/21 by Steve.Robb Explicitly pass string builder into code generation functions. Change 3315341 on 2017/02/21 by Ben.Marsh UAT: Clean up some formatting in StreamCopyDescription output - remove #fyi lines, exclude merge commits, and remove some blank lines. Change 3315350 on 2017/02/21 by Ben.Marsh Fix shared resource files not being rebuilt if the version header changes. Change 3315823 on 2017/02/21 by Ben.Marsh UAT: Use a class derived from AutomationException to return information specific to commandlets failing, rather than putting it in the base class. Change 3315826 on 2017/02/21 by Ben.Marsh UAT: Move Distiller class from general use in UAT; FileFilter provides a much safer and fully featured implementation of the same concepts. Change 3315857 on 2017/02/21 by Ben.Marsh UBT: Remove the StripBaseDirectory() and MakeRerootedFilePath() utility functions from UBT. These operations can now be done more safely with FileReference objects. Change 3315942 on 2017/02/21 by Ben.Marsh UBT: Convert FileFilter to use FileReference and DirectoryReference arguments everywhere. Change 3316236 on 2017/02/22 by Maciej.Mroz #jira UE-42045 Nativization Fixed Warning: TEnumAsByte is not intended for use with enum Change 3316253 on 2017/02/22 by Robert.Manuszewski Fixes for the async log file writer hangs and crashes. - potential fix for the logging system hang when running out of disk space while flushing log - fix for unexpected concurrency assert when flushing the log buffer to disk Change 3316293 on 2017/02/22 by Steve.Robb GetTypeHash and lexicographical comparison operators (operator<() etc.) for TTuple. Change 3316342 on 2017/02/22 by Maciej.Mroz Nativization: Wrappers (stubs) required only by other wrappers are properly generated. #codereview: Mike.Beach Change 3316344 on 2017/02/22 by Maciej.Mroz Fixed crash in nativized Odin Async loading properly handles nativized structs. Change 3316359 on 2017/02/22 by Steve.Robb GitHub #3287 : Ignore #pragma in USTRUCTs #jira UE-42248 Change 3316389 on 2017/02/22 by Matthew.Griffin Switched Installed Engine Filters to multiline properties to make them more readable Added Oodle to list of excluded plugins #jira UE-42030 Change 3316392 on 2017/02/22 by Ben.Marsh UBT: Split out FileReference/DirectoryReference classes into their own file. Change 3316394 on 2017/02/22 by Ben.Marsh UBT: Move FileReference/DirectoryReference extension methods into the appropriate file. Change 3316411 on 2017/02/22 by Ben.Marsh UAT: Remove file functions that take multiple arguments. There's not really a compelling use case for these to exist over looping from the calling code. Change 3316446 on 2017/02/22 by Ben.Marsh UAT: Try disabling function name prefix to log output from UAT, to see if it improves readability. Function names are still included in the log file for debugging. Change 3316575 on 2017/02/22 by Ben.Marsh UAT: Remove unused functionality for dealing with labels, and output a more human readable list of P4 settings at startup. Change 3318481 on 2017/02/22 by Steve.Robb Use of FMath::IsPowerOfTwo in check. Static assert to ensure that an inline set allocator will have a hash size of a power of two. Change 3318496 on 2017/02/22 by Steve.Robb Fix for TSet visualizers. Change 3318919 on 2017/02/23 by Steve.Robb Fix for hot reloading UScriptStruct-derived objects in a module, where the CDOs of these objects haven't had PrepareCppStructOps() called on them. #jira UE-42178 Change 3318942 on 2017/02/23 by Steve.Robb Removal of a redundant insertion which can cause problems on reallocation of the map. Change 3319010 on 2017/02/23 by Ben.Marsh UBT: Fix exception when a file that was previously part of the working set is deleted. Change 3319134 on 2017/02/23 by Robert.Manuszewski Better fix for a deadlock when flushing log while it's already being flushed due to flush timer on the async log writer thread. Change 3319249 on 2017/02/23 by Matthew.Griffin Added a function to check if running with debug game libs instead of checking command line in multiple places Added -RunConfig parameter, which has equivalent result to -debug if value of parameter starts with 'debug' Added -RunConfig=$(Configuration) as a default commandline argument for Mac so that editor can use debug game libs Removed -Shipping argument from VCProject generation as it's not used anymore Change 3319253 on 2017/02/23 by Maciej.Mroz #jira UE-41846 New mechanism to gather modules necessary for Nativized Assets. The modules are listed based on included headers. Previously the dependencies was gathered only in FBlueprintNativeCodeGenManifest::GatherModuleDependencies. Change 3319591 on 2017/02/23 by Ben.Marsh Don't strip prefixes beginning with WARNING: or ERROR: using the Postp filter. Change 3320357 on 2017/02/23 by Steven.Hutton Slight changes to Add Crash method - Returning select fields instead of entity objects in queries for perf reasons. Change 3320361 on 2017/02/23 by Steven.Hutton Performance improvements subsequent to the recent database changes. Change 3320446 on 2017/02/23 by Steven.Hutton adding my temporary performance tracker class - reports to a private slack channel with add crash performance data. Change 3320479 on 2017/02/23 by Ben.Marsh Fix CIS errors. Change 3320576 on 2017/02/23 by Jin.Zhang Update CrashReporter to use AWS Change 3320742 on 2017/02/23 by Jin.Zhang Merging crash caching Change 3321119 on 2017/02/24 by Robert.Manuszewski DLL injection protection support for non-monolithic builds Change 3323308 on 2017/02/27 by Matthew.Griffin Moved compilation of SwarmInterface after its dependencies so that we will see a build failure immediately if they change version in future Change 3323423 on 2017/02/27 by Chad.Garyet Adding a script to check and warn about csproj targeted .net versions being mismatched #JIRA UE-39624 Change 3323442 on 2017/02/27 by Ben.Marsh UBT: Output an error if an engine module references a game module. Change 3323743 on 2017/02/27 by Ben.Marsh PR #3303: Resolved PVS scan issues (Contributed by projectgheist) Change 3323748 on 2017/02/27 by Ben.Marsh Convert whitespace to tabs. Change 3324851 on 2017/02/28 by Chris.Wood Add Odin symbol locations to engine config for MDD on CR server. NotForLicensees Change 3324979 on 2017/02/28 by Gil.Gribb Fixed bad merge of priority change in the EDL. Change 3326889 on 2017/03/01 by Steven.Hutton Update to buggs controller to generate faster queries. Change 3326910 on 2017/03/01 by Robert.Manuszewski Removing legacy #if from PackageFileSummary. Change 3327118 on 2017/03/01 by Gil.Gribb UE4 - Fixed race that resulted in a memory leak when reading compressed paks. Change 3327633 on 2017/03/01 by Gil.Gribb UE4 - Added a cvar to control the pak precacher thottle. Change 3327674 on 2017/03/01 by Steve.Robb Unified boilerplate between all generated code files. Change 3328544 on 2017/03/01 by Chris.Wood CrashReportProcess.config update (CRP v1.2.17) Tweaks to a few values. Update website URL to explicitly point to old, non-cloud site on devweb-02. Change 3328714 on 2017/03/01 by Chris.Wood Correct CRP config regression. Point website at new cloud site. Still v1.2.17 Change 3329192 on 2017/03/02 by Matthew.Griffin Added Shared Build Id file to the list of Precompiled Build Dependencies in a target receipt so that it's brought into an installed build Change 3329285 on 2017/03/02 by Ben.Marsh UGS: Allow a project to specify a filters for the streams that should be displayed for fast-switching to. The QuickSelectStreamList seting in the [Options] section of the project settings references a depot path containing a list of strings used to filter the stream list. An option is shown to switch back to showing all available streams, if desired. Change 3330636 on 2017/03/02 by Ben.Marsh UBT: Bump version number of C++ include cache to force it to be rebuilt with additional include information for the default RC files. Change 3331262 on 2017/03/03 by Robert.Manuszewski Merging Dev-LoadTimes to Dev-Core (Garbage Collection performance improvements) - Improved GC multithreading - Improved BeginDestroy performance - Introduced ULevelActorCluster for StaticMeshActor and ReflectionCapture actor clustering (can be toggled through project settings or console command gc.ActorClusterEnabled) - A few improvements to AddReferencedObjects functions - Misc improvements to GC code - Garbage Collector now properly handles clusters which had their objects marked as pending kill - Blueprints can now create clusters too (can be toggled through project settings or console command gc.BlueprintClusteringEnabled, defaults to disabled) Change 3331285 on 2017/03/03 by Robert.Manuszewski A few fixes for the previous check-in. Change 3332001 on 2017/03/03 by Ben.Marsh UBT: Add support for generating a UDN file containing the valid settings for BuildConfiguration.xml. Pass -configdoc=<filename> on the command line to generate such a file. Change 3332022 on 2017/03/03 by Ben.Marsh Update documentation for where to find the BuildConfiguration settings. Change 3332031 on 2017/03/03 by Ben.Marsh Remove documentation for Windows XP support; it has been removed in the 4.16 release. Change 3332256 on 2017/03/03 by Ben.Marsh UBT: Add support for generating a UDN page containing module and target settings. Change 3332458 on 2017/03/03 by Ben.Marsh UBT: Improvements to generated documentation. Change 3332459 on 2017/03/03 by Ben.Marsh Add generated documentation for .target.cs files, .build.cs files, and BuildConfiguration.xml files. Change 3332460 on 2017/03/03 by Ben.Marsh UBT: Make LinkTypePrivate actually private, so it doesn't show up in the docs. Change 3332899 on 2017/03/06 by Robert.Manuszewski Making sure actor clustering is not used in the editor (fix for actors being deleted when GC runs in the editor) #jira UE-42548 Change 3332955 on 2017/03/06 by Maciej.Mroz Nativization distinguishes client and server platform: - Separated lists on additional assets, additional modules, excluded assets, excluded modules, excluded paths (in config) - Context (compilation options, nativization options and platform) is deliveren to BPCOmpilerCppBackend in FCompilerNativizationOptions struct. - Wrappers (for unconverted BPs) are created only when they are directly called. - Fortnite dedicated server can be nativized Change 3332990 on 2017/03/06 by Ben.Marsh UBT: Add more comprehensive wrapper methods for System.IO.File and System.IO.Directory to FileReference and DirectoryReference. Change 3333032 on 2017/03/06 by Ben.Marsh Documentation for build tools Change 3333037 on 2017/03/06 by Ben.Marsh Add a build step to extract UAT and UBT documentation from XML comments. Change 3333089 on 2017/03/06 by Ben.Marsh UAT: Re-enable logging the calling function to the console in UAT. Needs a pass for readability first. Change 3333651 on 2017/03/06 by Gil.Gribb UE4 - Fix a werid recursive situation where StaticLoadObject could return an object that has not finished loading. Also produces a fatal error if this sometimes happens. EDL only. Change 3335236 on 2017/03/07 by Ben.Marsh UGS: Set the sync changelist separately to the compatibility changelist. Change 3335261 on 2017/03/07 by Gil.Gribb UE4 - Fixed batched render fences when BeginDestroy calls FlushRenderingCommands. Change 3335740 on 2017/03/07 by Gil.Gribb maybe fix static analysis warning Change 3335945 on 2017/03/07 by Steve.Robb Move FFindInstancedReferenceSubobjectHelper code out of header. Add map/set property support to allow instanced members of these container types to be handled during CPFUO. https://udn.unrealengine.com/questions/349232/tmap-with-instanced-object-as-value-gets-cleared-o.html Change 3336693 on 2017/03/07 by Ben.Marsh UBT: Use shared PCHs for game plugins by default, to reduce time spent generating individual PCHs. Change 3336694 on 2017/03/07 by Steve.Robb Static assert added to TMap to prevent the use of keys which don't implement a GetTypeHash. Fixes to types which relied on implicit conversions when calling GetTypeHash. Workaround in SAssetView.h and PropertyEditorModule.h for an apparent VC bug where the compiler wrongly instantiates TPointerIsConvertibleFromTo for certain forward-declared types, causing future TSharedPtr conversions to fail. #jira UE-42441 Change 3336698 on 2017/03/07 by Steve.Robb Hardcoded endpoint handling replaced with a generic string. Obsolete .proto and .java code generation removed. Change 3336811 on 2017/03/07 by Wes.Hunt Add a game blacklist to the crash report processor. Fixed a syntax error in Config.cs, added a XML comment to shut up a warning. Change 3336973 on 2017/03/08 by Steve.Robb Fix for missing GetTypeHash in a plugin. Change 3336996 on 2017/03/08 by Steve.Robb Significant refactor of code generation, to try and make data flow more apparent. Change 3337571 on 2017/03/08 by Steve.Robb CIS fixes for missing GetTypeHash functions. Non-unity fix. Change 3337588 on 2017/03/08 by Gil.Gribb UE4 - Fixed obscure check with flushing rhi resources. Change 3337620 on 2017/03/08 by Steve.Robb WITH_HOT_RELOAD_CTORS macros removed. UseVTableConstructors config option removed. Change 3339369 on 2017/03/09 by Steve.Robb GetTypeHash overload for nn::account::Uid. Change 3339464 on 2017/03/09 by Daniel.Lamb Fixed assert in 4.15 to do with trying to gather dependency info from invalid packages. #jira UE-42583 #test Editor + Cook + Run shootergame Change 3339465 on 2017/03/09 by Maciej.Mroz Fixed serialization issue, after UserDefinedEnum was used in EnumProperty. Change 3339469 on 2017/03/09 by Maciej.Mroz Fixed Nativization problem, when default value is passed as non-const reference. Change 3340178 on 2017/03/09 by Daniel.Lamb Added support for in memory only packages. The Cooker ignores these and added core functions to recognize these packages. Other systems will need to add support where nessisary. Change 3341002 on 2017/03/10 by Maciej.Mroz Nativization: Fixed FFindHeadersToInclude. Headers necessary for owners of subobjects are properly included. Change 3341076 on 2017/03/10 by Steve.Robb Fix for FBakedTextureSourceInfo move semantics. #jira UE-42658 Change 3341160 on 2017/03/10 by Gil.Gribb UE4 - Fix hazard with SetMaterialUsage from a thread. Change 3341409 on 2017/03/10 by Steve.Robb Reduction of the generated code size for StaticRegisterNatives functions. Change 3341523 on 2017/03/10 by Steve.Robb Code generation simplified. Change 3341800 on 2017/03/10 by Ben.Marsh UnrealVS: Fix UnrealVS compatibility with RTM version of Visual Studio 2017. 2017 toolchain for extensions is no longer able to build <= 2015 extensions due to validation of the VSIX manifest, so create a separate solution for it. Change 3342034 on 2017/03/10 by Ben.Marsh Fix compiler setting not being loaded correctly into the Windows target settings dialog. #jira UE-42746 Change 3342041 on 2017/03/10 by Ben.Marsh Fix -ErrorOnEngineContentUse not being set in the cooker options correctly. Change 3342094 on 2017/03/10 by Steve.Robb Fix to deteministic name order during code generation. Change 3342251 on 2017/03/10 by Daniel.Lamb Integrate fix for resave lightmaps commandlet when upgrading from no mapbuilddatapackages to mapbuilddatapackages. #thanks Tim.Hagberg #test None Change 3342961 on 2017/03/13 by Robert.Manuszewski Fixing memory leak when playing while running -nullrhi on the commandline in cooked games caused by shader resources not being destroyed. #jira FORT-38977 Change 3343022 on 2017/03/13 by Steve.Robb GetTypeHash fixes for FUniqueNetIdLive. #jira UE-42788 Change 3343448 on 2017/03/13 by Steve.Robb Compiled-in defer object order fixed. Debuggability of the deferred registration map improved. #jira UE-42828 [CL 3345747 by Ben Marsh in Main branch]
2017-03-14 15:48:33 -04:00
if (AllClientOutput.Contains("Game Engine Initialized") || AllClientOutput.Contains("Unreal Network File Server is ready"))
{
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 4285612) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3836829 by Ben.Marsh UBT: Fix ability to precompile plugins from installed engine builds. Change 3839519 by Ben.Marsh UBT: Simplify configuring bPrecompile and bUsePrecompile settings for modules. Each rules assembly can now be configured as installed, which defaults the module rules it creates to use precompiled data. Change 4042043 by Steve.Robb GitHub #4705 : Added weak lambda's for delegates and multicast delegates. Change 4042056 by Robert.Manuszewski Optimized Mark Phase of GC by up to 10ms by making it run in parallel and removing a huge array presize which we didn't need. Change 4042104 by Robert.Manuszewski Set the minimum GC cluster size to 5 so that GC doesn't have to process micro clusters which are more expensive than processing individual objects + Exposed the minimum cluster size to ini and project settings as gc.MinGCClusterSize + Added the ability to sort clusters by name/object count/mutable object count/referenced clusters count when dumping them with gc.ListClusters command Change 4042377 by Robert.Manuszewski Reworked how GC and other threads (ALT specifically) interact - GC will now notify the ALT it wants to run and ALT will immediately try to finish its current work to allow that. Also the entire ALT tick is now protected against GC running at the same time to improve ALT stability. + added gc.ForceCollectGarbageEveryFrame console variable that triggers a forced GC every frame Change 4042427 by Robert.Manuszewski Changed FGCCSyncObject to use events when waiting for GC to finish so that it doesn't spin on non-game threads when GC is running Change 4042482 by Robert.Manuszewski Unhashing unreachable objects (ConditionalBeginDestroy) will now also be done incrementally, just like the purge phase of Garbage Collection Change 4042635 by Robert.Manuszewski Fix for a potential assert when incremental purge garbage is pending and something forces a full purge Change 4044092 by Steve.Robb Fix for forward declared CoreUObject weakobject types in delegates when building in Clang. Change 4044102 by Robert.Manuszewski Fix for a possible hang when worker threads are preventing GC from running and something is later trying to FlushAsyncLoading with the Async Loading Thread enabled Change 4044113 by Steve.Robb Another Clang fix. Change 4044160 by Robert.Manuszewski Disregard For GC pool will now be enabled by default in cooked builds Change 4044287 by Steve.Robb Typo fix. Change 4047723 by Graeme.Thornton TBA: Fixes for import/export name cache and object resolving Change 4048015 by Graeme.Thornton TBA: Weak/Soft/Lazy pointer serialization changes * Remove FWeakObjectPtr::Serialize, move it's logic into, and replace usages of with calls to, FArchiveUObject::SerializeWeakObjectPtr(). Ensures that something is always sent to the archive so that structured archives can be kept happy in the future. * Added Weak/Soft/Lazy pointer handling to the structured archive slot interface and all the formatters. Binary formatters just forward the call onto their inner and text archives store as a string path reference. * FArchiveUObjectFromStructuredArchive caches all these pointer types and stores indices in the binary block, same as with a UObject*. All pointers are then forwarded to the underlying formatter in one go on finalization. Change 4048021 by Steve.Robb Fix for binding an unbound TFunction to another TFunction with a different signature. Also all null pointers now count as unbindings, not just nullptr. TIsMemberPointer added. TIsATFunction and TIsATFunctionRef renamed to remove the 'A's. Change 4048544 by Robert.Manuszewski Fixing ConditionalBeginDestroy profiling after changes to incremental CBD. Change 4051028 by Graeme.Thornton TBA: ArchiveFromStructuredArchive adapter uses Inner to determine if it is outputting to text, and sets it's own ArIsTextFormat to false Change 4051056 by Graeme.Thornton TBA: High level tagged property / UObject base class text serialization - UObject serialize converted to structured archive - Properties written to text individually with text tags, and then binary adapted values - Only saves, doesn't load Change 4051111 by Graeme.Thornton TBA: Temporarily disable loading of text assets until tagged property serialization path is fixed up Change 4051154 by Graeme.Thornton TBA: Convert a few uobject serializers to structured archive format for example purposes Change 4051181 by Graeme.Thornton TBA: Added default structured archive implementation of SerializeItem to UProperty, which just calls the FArchive version on an FArchiveUObjectFromStructuredArchive adapter. Implemented structured archive SerializeItem for UArrayProperty Change 4051197 by Graeme.Thornton TBA: ObjectProperty text serialization Change 4051216 by Graeme.Thornton Restored a modified FWeakObjectPtr::Serialize function to keep backwards compatibility in code I don't have access to. Change 4051261 by Graeme.Thornton TBA: Convert UMetaData to structured archive Change 4051374 by Steve.Robb Incorrect assert removed. Change 4051562 by Robert.Manuszewski Adding stats for the new GC internal functions Change 4051614 by Graeme.Thornton TBA: Removed UProperty::SerializeItem(FArchive, ...) and replaced with UProperty::SerializeItem(FStructuredArchive::FSlot, ...). Fixed up most of them to work properly and added adapters in for any that were non-trivial. Change 4052512 by Graeme.Thornton TBA: Temporary workaround for softobjectptr and lazyobjectptr uproperties not serialization anything when they know the archive is a reference collector. They should always be serializing their pointers and letting the underlying archive itself ignore them. Change 4053917 by Robert.Manuszewski Clustered objects from clusters that are no longer reachable will now be marked as unreachable immediately when gathering unreachable objects Change 4053919 by Robert.Manuszewski Added the ability to disable incremental BeginDestroy in ini/project settings Change 4055518 by Daniel.Lamb Fixup for deterministic audio generation issue. Submitted on behalf of Rich.Whitehouse #jira nojira #test prefilght automated test. Change 4056854 by Graeme.Thornton TBA: Added a test asset to EngineTest which contains all the different property types and test cases. Change 4056858 by Graeme.Thornton TBA: Updated USetProperty to proper structured archive usage Change 4056872 by Graeme.Thornton TBA: Add map property field to test object Change 4056873 by Graeme.Thornton TBA: Convert UMapProperty to full structured archive Change 4056994 by Graeme.Thornton TBA: Converted FText over to structured archive. Implemented saving, but not loading. Change 4059728 by Ben.Marsh UBT: Add support for using adaptive non-unity builds when the engine and project are in separate repositories. Change 4059805 by Graeme.Thornton Fixed typo in text serialization. Fixes CIS automation test errors Change 4060007 by Graeme.Thornton TBA: FArchiveFromStructuredArchive will now access it's host slot lazily, i.e. only when a value is actually written to the archive. Change 4060092 by Stefan.Boberg Added optimized Windows console window output path to GenericConsoleOutput since this slowed down cooking considerably (2 minutes spent in wprintf alone for one large dataset) When stdout is attached to a console we use the WriteConsoleW function instead of wprintf since the latter is very slow especially in unbuffered mode which the engine currently configures for stdout (see setvbuf call in LaunchEngineLoop.cpp). At some point we should reconsider this buffering policy since it's likely to slow down other platforms as well but I wanted to do a safe change for now as I don't yet fully understand why the setvbuf call is there in the first place. Change 4060108 by Stefan.Boberg Introduced some additional target platform utilities to help with asset cook optimizations * We now assign each ITargetPlatform a zero-based ordinal value * Introduced FTargetPlatform and FTargetPlatformSet types to help store platform references and platform sets efficiently. These are not currently used in the engine but are designed to replace the existing ITargetPlatform/string/FName representations in the cooking data structures. Change 4060143 by Graeme.Thornton Undo //UE4/Dev-Core/Engine/Source/Runtime/... changelist 4060007 Needs some other changes that I haven't checked in yet... Change 4062432 by Ben.Marsh Fix error message when enumerating P4 changes. Change 4062648 by Ben.Marsh Add missing p4 integration action. Change 4063620 by Graeme.Thornton Integrated a fix from UDN where the engine would crash when trying to load a very small encrypted file (<16bytes) from a pak file, where the read address wasn't already aligned to the AES block size. (https://udn.unrealengine.com/questions/431989/crash-while-reading-a-very-small-file-in-encrypted.html) Change 4066963 by Robert.Manuszewski Fixing GC cluster verification code reporting false positives when a cluster is referencing another cluster through 'mutable' objects list. Change 4067133 by Robert.Manuszewski Changed log verbosity when reporting individual cases of GC cluster assumption violations as they are followed by an asser anyway and this way we get the chance to see all issues before we assert at the end of these checks. Change 4067443 by Steve.Robb FString can now be constructed from any char pointer type and length. Change 4068156 by Steve.Robb Fix necessary because of FString constructor change in CL# 4067443. Change 4070258 by Graeme.Thornton Fixes for VSCode Change 4070372 by Graeme.Thornton TBA: Script struct serialization to structured archives Change 4071913 by Ben.Marsh Move bulk of the code for UnrealPak into an engine developer module, so it can be used in the editor. Change 4071914 by Ben.Marsh Missing files. Change 4071937 by Ben.Marsh Missing header. Change 4072015 by Ben.Marsh Fixes for compiling PakFileUtilities as part of the editor. Change 4072826 by Steve.Robb TBitArray::Reserve() added. TBitArray::Add() overloaded to allow adding multiple bits. TSparseArray::Reserve() optimized to call the overloaded Add(). Change 4073271 by Daniel.Lamb Fixed add patch tier in project launcher passing the wrong commandline option to UAT. #test none Change 4074708 by James.Hopkin #core Removed redundant Casts Change 4074763 by Steve.Robb Fix for TSparseArray::Reserve() size. Change 4076063 by Ben.Marsh Add an "UnrealPak" commandlet with the same functionality as the standalone UnrealPak program. Invoke by running the editor with -run=UnrealPak and the standard UnrealPak commandline options. Change 4077064 by Robert.Manuszewski Fixing compile error in PakFileUtilities Change 4077144 by Graeme.Thornton TBA: TextAssetCommandlet improvements * Collect lists of broken assets during roundtrip tests and print a summary of packages that failed each phase at the end * After resaving as text, load the file back as a plain JSON hierarchy to ensure the output was valid Change 4077412 by Ben.Marsh Set the correct exit code for UnrealPak. Should return 0 on success, not 1. Change 4077760 by Graeme.Thornton TBA: Loading fixed for tagged property serialization Includes conversion of all UProperty::ConvertFromType() and SerializeFromMismatchedTag() functions to use structured archives Lazy initialization of FArchiveFromStructruredArchive when loading, to support the possibility of an adapter being create around an object property serialize call to its inner UStruct, which then decides not to do anything and return false. Stops the ArchiveFromStructuredArchive from consuming the slot and getting upset later on when we try to serialize normal tagged properties from it. Disabled lazy bulk data loading from text assets. Requires a bigger change to make it work. Added some debug checks to json input formatter which track the current value stack size when a new object is pushed onto the stack, and makes sure that the stack has returned to the same size when the object is popped. Catches cases where we unpack an array/stream to the value stack but then don't consume all the items. Change 4078800 by Ben.Marsh Change UAT to using the editor's UnrealPak commandlet rather than invoking the standalone UnrealPak executable. To improve performance when building several PAK files, also add a new -batch=<file> command which reads commands to execute in parallel from a text file. Change 4079745 by Graeme.Thornton TBA: Migrated a couple of UObject Serialize functions to FStructuredArchive (SoundCue / MaterialExpressions / Editor strip flags) Change 4079847 by Graeme.Thornton TBA: Add 'FindMismatchedSerializers' mode to text asset commandlet, which dumps out a list of all UClasses which don't have the CLASS_MatchedSerializers flag, meaning we can't guarantee the have Serialize functions for FArchive AND FStructuredArchive, therefore we can't use the new structured archive based serialize path. Should only ever be native instrinsic classes as UHT takes care of all other cases. Change 4079925 by Ben.Marsh Fix incorrect assignment when deriving name for chunked pak file. Change 4080214 by Ben.Marsh Move the ThreadPoolWorkQueue class into DotNETUtilities so it can be used by other projects. Change 4082394 by Graeme.Thornton CIS fix for variable shadowing warning Change 4082583 by Ben.Marsh Add a IBinarySerializable interface for types that support reading from a BinaryReader and writing to a BinaryWriter. Implementing IBinarySerializable implies a constructor taking a BinaryReader argument is available for deserializing. Change 4082652 by Ben.Marsh Fix FileReference.Directory not returning a directory with a trailing backslash for files in the root directory. Change 4082755 by Graeme.Thornton Fixed an erroneous usage of TUniquePtr<uint8>as a pointer to a uint8 array when creating pak files. Caused a crash when compression was enabled, and has probably surfaced because pak generation is now done by an editor commandlet rather than a standalone program. Change 4082756 by Graeme.Thornton Fixed some incorrect documentation for pakfile compressed chunk headers Change 4082883 by Graeme.Thornton Static analysis warning fix Change 4082912 by Ben.Marsh Move ExceptionUtils into DotNETUtilities. Change 4085291 by Graeme.Thornton TBA: In the Json output formatter, write float and double values out with enough precision for successful roundtripping. Added some debug only code which will immediately reconvert the string back to its original value and compare the the input Change 4085523 by Graeme.Thornton TBA: Remove only explicit usage of DECLARE_FSTRUCTUREDARCHIVE_SERIALIZER. Should only be used from UHT generated code. Change 4086037 by Robert.Manuszewski Fix for a potential race condition when two threads want to acquire GC lock Change 4088655 by Graeme.Thornton Pak creation now uses the bEnablePakSigning setting from the crypto config json file Change 4091474 by Steve.Robb Fix for TStaticBitArray::FindFirstSetBit() and TStaticBitArray::FindFirstClearBit(). Unused variables removed. Change 4093632 by Steve.Robb CIS fixes. Change 4093656 by Graeme.Thornton Build fix Change 4093744 by Ben.Marsh Allow per-chunk settings for whether to enable compression in UnrealPak. Change 4099712 by Gil.Gribb UE4 - Fixed rare case where insufficient space was preallocated for cooldown ticks. #jira UE-59686 Change 4099912 by Stefan.Boberg Cooking timer optimizations: - Replaced data structures for FScopeTimer and FHierarchicalTimerInfo. Previous implementation used FString for many things and caused *lots* of heap and string concatenation activity. Replaced with a compile-time node id (using __COUNTER__) and raw string literals. - Removed PERPACKAGE_TIMER support (was disabled by default and was difficult to test) - Made it possible to toggle OUTPUT_TIMING and ENABLE_COOK_STATS independently - Removed some extremely tight timers because the overhead from calling QPC significantly exceeded the measured code This change shaved some 15% off a clean cook of Fortnite WindowsClient (en) with fully populated local DDC Change 4100519 by Stefan.Boberg Quick fix for Linux build issue introduced in 4099927 Change 4105327 by Stefan.Boberg Cooker: Changed FHierarchicalTimerInfo so it uses a linked list for tracking child nodes, to be able to deal with any child count. Previously we assumed there would never be more than 9 children but it turns out there are cooker modes that need more. Fixes check when using -FullLoadAndSave to cook Change 4105448 by Stefan.Boberg - Fixed Linux build warning re: member initialization order - Also eliminated OUTPUT_HIERARCHYTIMERS/CLEAR_HIEARCHYTIMERS macros (plain functions are fine) - Moved finishing-up code for FullLoadAndSave() to TickCookOnTheSide() call site to improve timer output. Previously some of the scopes would not have been closed before printing and thus the output was misleading. Change 4109031 by Ben.Marsh Attribute-driven Perforce wrapper (old Epic Friday project). Offers a more complete implementation than the current P4 wrapper in UAT without requiring any platform-specific libraries. Uses the Python binary output for parsing. Change 4109588 by Ben.Marsh UBT: Add extension methods for serializing a nullable type to a BinaryReader/BinaryWriter. Change 4109595 by Ben.Marsh Missing project file for DotNETUtilities. Change 4110724 by Stefan.Boberg Removed annotation map locking in UObjectMarks, eliminating around one minute (~3.5%) from Fortnite cook time. The locking was redundant since the annotation maps are managed per thread anyway. Change 4111304 by Ben.Marsh UAT: Add support for setting a status message through the log class. Allows writing transient messages (eg. progress messages) which will be cleared out before writing other messages. Best used through the LogStatusScope class, which can set a status message for the duration of a using() block. As part of this change, the console no longer has to be added as a dedicated trace listener. Since we already special-case this listener when formatting log output, it's easier to just keep the implementation separate to the other trace listeners. Change 4112708 by Steve.Robb Fix for TBitArray::MaxBits in assignment. Change 4114133 by Stefan.Boberg Tweaked how low-level memory (LLM) tracker is implemented to reduce overheads. Previously FMemory functions would acquire the LLM singleton and call OnLowLevelFree/OnLowLevelAlloc etc which would check the bIsDisabled flag and early out if it was set. Due to how frequently these functions were called this ended up costing quite a bit. - This change makes the flag a static member variable instead of a member variable and therefore enables a simpler early-out to be implemented. - The singleton getter is also simplified to avoid hitting the threadsafe singleton construction path on every call. - The enable flag is no longer TAtomic - this also incurs extra overhead for no clear benefit Shaves approximately 3.5% (one minute) off a Fortnite cook test scenario (using -FullLoadAndSave) Change 4115010 by Robert.Manuszewski Fixing CIS Change 4115249 by Robert.Manuszewski Fixing async loading code asserts when exiting game very early due to an error #jira UE-56267 Change 4117091 by Ben.Marsh Prevent doubled-up lines when writing status updates with console log verbosity. Change 4117207 by Ben.Marsh UGS: Do not include executables in diagnostics zip file, and ignore "no such files" error when cleaning workspace. Change 4119175 by Ben.Marsh UGS: Fix crash writing version files when directory does not already exist. Change 4119987 by Ben.Marsh UGS: Show a dialog box while the launcher is updating executables from Perforce, which allows cancelling the operation if necessary. Allow setting the username on the settings window, and prompt for login credentials if necessary. Should prevent situations where users have to update settings from the command prompt. Holding down shift during launch now shows the settings dialog rather than an immediate prompt to launch the unstable version (unstable version is shown as a checkbox on this dialog). Change 4119991 by Ben.Marsh Update version number for UGS launcher to 1.13. Change 4121943 by Robert.Manuszewski Don't use FArchiveAsync2 for reading packages with non-async path in editor builds as its performance is worse than the standard archive's (saves about 1 minute when doing larger cooks and 7 seconds when loading into PIE) Change 4122592 by Steve.Robb GitHub #4762 : Improve wording and grammar of Math comments Also includes improved accuracy in FMath::ComputeBoundingSphereForCone(). Change 4122819 by Stefan.Boberg Don't call CreateDirectory redundantly when opening files for writing using FFileManagerGeneric::CreateFileWriter This change avoids calling IPlatformFile::CreateDirectoryTree if possible since this is a very expensive function especially for deep hierarchies as it performs directory creation from the root directory onwards instead of from the leaf downwards. That function should also be fixed but this change improves performance in the meantime. Change 4122872 by Stefan.Boberg CreateDirectoryTree now creates directories leaf-to-root instead of the other way around. This is much more efficient since we don't spend time on system API calls for directories which already exist. This accounted for a very large amount of CPU time in cooking as the full target file directory hierarchy would be "created" for every single output file. Change 4123109 by Stefan.Boberg - Disable overlapped I/O in editor / cooker. Synchronous I/O reduces the number of syscalls and Windows performs prefetching on our behalf anyway for sequential reads - Eliminated syscall which was issued for every write to update cached file size -- since we're the only writers to the file (file access allows read sharing at most) we can authoritatively update the file size on write completion Change 4123455 by Ben.Marsh PR #4775: New build param PCHMemoryAllocationFactor to set /Zm VS build param. (Contributed by lucaswall) Change 4124207 by Ben.Marsh UBT: Remove some unnecessary indirection for generated code paths. Change 4124217 by Ben.Marsh UBT: Remove another unused variable from UEBuildModuleCPP. Change 4124377 by Stefan.Boberg In IPlatformFile::DeleteDirectoryRecursively, attempt to delete file first and if it fails clear the readonly flag and try again Previously there was a call to clear the readonly flag for every deleted file and this is a waste of resources 99% of the time. The SetFileAttributes call accounted for a significant amount of time during cooker sandbox directory deletion Change 4125071 by Stefan.Boberg Some tweaks to FQueuedThreadPoolBase scheduling and memory management - Explicitly pass in false for TArray::RemoveAt(..., bool bAllowShrinking) argument to prevent memory reallocation when arrays are drained and inevitably repopulated shortly afterwards - Use a MRU strategy instead of LRU when picking a thread to wake up. The MRU thread is the most likely to have a 'hot' cache for the stack etc. Picking from the back of the array also happens to be cheaper since no memory movement is necessary when RemoveAt is called. (This was the strategy in place before CL2600362 which seems to have changed it unintentionally) - Release lock as soon as a thread has been chosen, before asking the worker thread to wake up and do the work Change 4126132 by Ben.Marsh UAT: Detect when stdout is redirected and prevent using backspace characters to move the cursor. Change 4126867 by Graeme.Thornton TBA: Fix tagged binary formatter Change 4127010 by Robert.Manuszewski AnimScriptInstances created at runtime will now also be added to the owning omponent's cluster to avoid GC issues. Change 4127932 by Ben.Marsh WorkspaceTool: Reduce unnecessary logging of status messages when console output is not redirected. Change 4129050 by Ben.Marsh UGS: Check for NET Framework 4.5 being installed before running the installer. Also fix warning trying to kill existing UGS instances before upgrade. Change 4129459 by Graeme.Thornton TBA: TextAssetCommandlet - When outputting converted assets to an output path, replicate the workspace relative path in the output directory Change 4129515 by Graeme.Thornton TBA: Add EnterRecord overload that allows outputting of available field names when loading. Change 4129517 by Graeme.Thornton TBA: Tagged properties are written out as named fields on the "Properties" record, rather than as a stream with a null tag at the end Change 4129518 by Graeme.Thornton TBA: Added a local const bool to allow easy hacking out of text asset loading support Change 4129558 by Graeme.Thornton TBA: Build fix for textasset-less configs Change 4129614 by Ben.Marsh UGS: Main window is now restored to normal size when activated by clicking on the tray icon. #jira UE-60490 Change 4129618 by Ben.Marsh UGS: Speculative fix for unreproduced exception accessing disposed window while shutting down. Change 4131936 by Robert.Manuszewski Removing some WIP code accidentally checked in with CL #4121943 Change 4133490 by Ben.Marsh UGS: Allow the $(Change) variable to be used in more places than just the context menu. #jira UE-60573 Change 4133550 by Ben.Marsh UGS: Setting for whether or not to use incremental builds is now exposed through the variable "$(UseIncrementalBuilds)" for use by custom build steps. #jira UE-60554 Change 4133681 by Ben.Marsh UGS: A per-project list of folders and extensions to be deleted by default when running the 'clean workspace' tool can now be specified through the <ProjectDir>/Build/UnrealGameSync.ini file. Settings may be specified for an individual branch (via a category with the depot path to the project) or for wherever the project is currently open (via the [Default] category). The SafeToDeleteFolders list specifies a substring that will be checked against folder paths. Anything containing this folder will be marked as safe for delete by default. The SafeToDeleteExtensions list specifies a list of extensions for files that can always be deleted. Example: [Default] +SafeToDeleteFolders=/MyGame/Test/ +SafeToDeleteFolders=/DataService/ +SafeToDeleteExtensions=.xx1 +SafeToDeleteExtensions=.xx2 #jira UE-60575 Change 4135449 by Ben.Marsh Fix allowing use of Job objects on Windows platforms (debug code submitted by mistake) Change 4135730 by Ben.Marsh UBT: Plugins can now be enabled and disabled from the .target.cs file (for targets that do not use the shared compile environment), by compiling the list of enabled/disabled plugin names into the Projects module. Change 4135823 by Ben.Marsh UBT: Remove legacy code to handle disabling optional plugins; now that this is compiled into the target, it will work for any plugins we choose. Change 4135945 by Ben.Marsh UBT: Fix error running programs with no explicitly enabled or disabled plugins. Change 4137207 by Ben.Marsh UGS: Align all badges with the same name, to make it easier to see which CIS steps are being run. Allow overriding the slot taken by a particular badge by calling it "SlotName:LabelName". Change 4137311 by Stefan.Boberg Removed child cooker support. In practice it is not a useful feature as it provides no performance improvement (quite the opposite in fact) and adds testing and maintenance complexity. Change 4137393 by Ben.Marsh UGS: Fix display of multiline errors in the status panel. Change 4141708 by Steve.Robb GitHub #3631 : Incorrect default argument in WeakObjectPtrTemplate #jira UE-45490 Change 4146655 by Stefan.Boberg Removed FullGCAssetClasses logic - no longer necessary nor useful Change 4147318 by Ben.Marsh UGS: Compress build badges in a column if it shrinks below the size that they would be visible. Change 4148207 by Ben.Marsh UGS: Added support for showing the latest completed build from a specific list of badges in the status panel. To declare a badge as one that should appear in the status panel rather than the CIS column, add it to the project's UnrealGameSync.ini in the project or [Default] section like so: +ServiceBadges=RoboMerge Change 4148282 by Stefan.Boberg Fixed bug in UCookOnTheFlyServer::GetCookOnTheFlyUnsolicitedFiles - UnsolicitedFiles should be passed by reference not by value Change 4148344 by Stefan.Boberg Fixed minor indentation error (most likely caused by sloppy merge) Change 4148521 by Stefan.Boberg Removed accidentally checked in PRAGMA_DISABLE_OPTIMIZATION from CookOnTheFlyServer.cpp Change 4148639 by Ben.Marsh UGS: Fix tooltips not showing for changes that have description badges. Change 4149373 by Ben.Marsh UGS: Allow adding additional columns to display particular badges by adding entries from the project config file. Example syntax: +Columns=(Name="Desktop",MinWidth=50,DesiredWidth=100,Weight=3,Badges="Editor") +Columns=(Name="Mobile",MinWidth=50,DesiredWidth=100,Weight=3,Badges="IOS,Android") Same form can be used to control how default columns are displayed (though badge settings are ignored). Also allow PerforceMonitor to detect local changes to project config files and update settings automatically. Change 4149399 by Ben.Marsh UGS: Update version to 1.143. Change 4155660 by Steve.Robb PROJECTION and PROJECTION_MEMBER macros which provide the correct behavior when creating projections using functions which are overloaded or use default arguments. Change 4157117 by Ben.Marsh Fix warning due to plugins disabled in .target.cs file. Change 4158011 by Ben.Marsh UBT: Add a check that the UnrealHeaderTool target file exists, rather than throwing an exception when reading it fails. Change 4158646 by Ben.Marsh UGS: Fix exception when login is discovered to have expired during a workspace update. Change 4158678 by Ben.Marsh UGS: Fix an exception on shutdown due to the icon being hidden after it's already been disposed. Change 4158683 by Ben.Marsh UGS: Add an unhandled exception filter which sends the exception data to the backend. Change 4159131 by Ben.Marsh UGS: Reduce the number of characters displayed for build badges based on the available space. Change 4159194 by Graeme.Thornton TBA: Fix incorrect map property conversion code when converting an old property that contains a map with different key/value types Change 4159239 by Steve.Robb Improved readability and compliance with coding standards. Change 4159246 by Ben.Marsh UGS: Allow syncing projects where source code is not available (and various version files don't exist). #jira UE-60985 Change 4159286 by Ben.Marsh UGS: Remove requirement for UE4Editor.target.cs to be visible in the depot in order to open a project. #jira UE-60986 Change 4159302 by Ben.Marsh UGS: Update version to 1.144. Change 4160308 by Ben.Marsh All staging client executables for blueprint projects. #jira UE-60983 Change 4161567 by Steve.Robb GitHub #4816 : UE-60771: Handle escaped double quote in FParse::LineExtended Change 4162641 by Ben.Marsh UGS: Allow customizing the position of custom columns, via the Index=N attribute. Change 4162647 by Ben.Marsh UGS: Update version to 1.145. Change 4165319 by Robert.Manuszewski PR #4812: Fix inconsistent command-line argument handling under Windows (Contributed by adamrehn) Change 4166150 by Ben.Marsh UGS: Include *.inl when looking for code changes. Change 4166551 by Steve.Robb Whitespace fixes caused by a bad merge. Change 4168483 by Ben.Marsh UGS: Add a more useful error if a file to be synced exceeds the max allowed path length. Change 4168490 by Ben.Marsh UGS: Update version to 1.146. Change 4168551 by Ben.Marsh UBT: Move bBuildLargeAddressAwareBinary into an exposed setting. Change 4168560 by Ben.Marsh UBT: Remove static config variable for controlling which configuration of UHT to use. Change 4171296 by Ben.Marsh UGS: Move the check for overlong paths earlier. Change 4171531 by Ben.Marsh UBT: Fix exception if BuildConfiguration.xml contains an unknown category. Change 4183371 by Robert.Manuszewski Fix for a crash in Async Loading Graph's CheckCycles when GC kicks in on the game thread and forces ALT to exit early Change 4184312 by Ben.Marsh UGS: Update version to 1.148 Change 4184480 by Robert.Manuszewski Removing unused async loading stat Change 4186390 by Ben.Marsh UBT: Format XML validation errors in a format that allows double-clicking on the message in Visual Studio. Change 4188644 by Ben.Marsh UBT: Add the MakePathSafeToUseWithCommandLine() function to UBT. Change 4188647 by Ben.Marsh UBT: Fix exception in target receipt when architecture is null. Change 4189617 by Ben.Marsh Change FileSystemReference, FileReference and DirectoryReference objects to use OrdinalIgnoreCase comparisons without creating a separate copy of the string to compare. The filesystem does not use the invariant culture, and it can produce the wrong results in some cases (the ordinal comparison is faster, too). Change 4189740 by Ben.Marsh UAT: Remote code to build UnrealPak when packaging; we use the editor now. Change 4189860 by Ben.Marsh UGS: Make the filter for excluding automated lighting rebuilds more explicit. Change 4190082 by Ben.Marsh Fixes to allow enabling edit and continue for Windows builds. Have experienced quite a few VS crashes when testing it in editor; not yet recommended for general use. - Allow edit and continue for any configuration, not just debug. - Fixed PDB errors compiling files that use a shared PCH with edit and continue enabled. Path to the generated PDB file was using the wrong directory. - Removed code that tracks PDB output files, since they're modified multiple times during a build. - Enable debug information when compiling generated CPP files, since it causes errors if the shared PCH PDB doesn't have the same option. - Disable support for remote execution of steps that modify the PDB, since the same file has to be modified many times. Remote execution causes the PDB files to be corrupted. Unfortunately, this makes E&C builds significantly slower. #jira Change 4192949 by Ben.Marsh UBT: Minor tidy-up (merging UEBuildBinary.Build and UEBuildBinary.SetupOutputFiles) Change 4193218 by Ben.Marsh Fix formatting. Change 4197252 by Mike.Erwin UAT: Fix log output w/ correct count of non-code projects. #jira none Change 4197941 by Ben.Marsh UGS: Add support for DebugGame editors that have an executable with a DebugGame suffix. Change 4197964 by Ben.Marsh UGS: Prevent attempts to automatically reopen projects while a modal dialog is up, or the workspace is syncing. Change 4198144 by Ben.Marsh UGS: Prevent modal dialogs when login expires in P4, and prompt for password when hitting "retry". Change 4198413 by Ben.Marsh UGS: Always show the main window when launched manually, and run with -RestoreState when launched at startup. Also add a couple more places that save the visibility state, since logging off seems like it can terminate the process abrubtly. Change 4198779 by Ben.Marsh UBT: Allow generating manifests to any arbitrary locations with the -Manifest=<Path> argument. Change 4198825 by Ben.Marsh UBT: Move code to enumerate Slate runtime dependencies into the Slate module. Doesn't need to be done inside core UBT. Change 4199341 by Ben.Marsh UGS: Update version to 1.149 Change 4199642 by Chad.Garyet - Deprecate CISController - Add BuildController to replace CIS GET/POST for builds - Add LatestController, GET does what CIS/GET used to do - Change Latest/GET to return the last 25 builds filtered by project, rather than the last 5000 individual Ids - Latest/GET now returns "LatestData" object instead of array of longs - Updated EventMonitor to match all API changes - Fixed bug where IDs were getting reset to initial startup values every update loop Change 4199663 by Chad.Garyet CIS controller still needs to return an array of longs #jira none Change 4199680 by Ben.Marsh UGS: Update version to 1.150 Change 4200457 by Ben.Marsh Merging CIS fix for non-development configurations. Change 4200472 by Mike.Erwin UAT: fix -skipbuildclient param default It was defaulting to skipbuildeditor's value, likely a copy-paste error. #jira none Change 4202595 by Ben.Marsh Fix static analysis warning due to constant comparison against macro. Change 4203250 by Ben.Marsh UGS: Always show the "Sync Precompiled Editor" option, but disable it and show a tooltip explaining why if it is not available. Change 4206191 by Ben.Marsh Exclude editor target files from installed builds, since they leak info about DLLs that have been stripped out. Change 4213011 by Ben.Marsh UBT: Include contents of modified intermediate files in the log, to make it easier to debug hidden dependencies. Change 4213487 by Ben.Marsh UBT: Fix assumption that bPrecompile is equivalent to bBuildAllModules. This is no longer the case; they are now controlled by separate options. Should fix CIS errors building the editor. Change 4213609 by Ben.Marsh Ensure that strings formatted using FMicrosoftPlatformString::GetVarArgs() are always null terminated, whether we use the secure CRT or not. Change 4215971 by Ben.Marsh UBT: Remove action graph visualization code; no longer used. Change 4215996 by Ben.Marsh UBT: Remove unqiue id from all actions in the action graph. This is only used for printing debug info in the case of a (rare) cycle in the action graph, so just look it up when needed. Change 4216022 by Ben.Marsh UBT: Rename Crypto.cs to EncryptionAndSigning.cs to match the name of the class inside it, and move it under the System folder. Change 4216031 by Ben.Marsh UBT: Move all the action executors into their own folder in the project. Change 4216526 by Ben.Marsh Fix CIS warnings. Change 4216544 by Ben.Marsh Replace custom code to ensure FMicrosoftPlatformString::GetVarArgs() null terminates its buffer with Microsoft's standards-compliant implementation. Change 4216633 by Ben.Marsh Add support for UnrealPak plugins. * Project and plugin modules can now specify an array of supported programs in the "WhitelistPrograms" field of their module descriptors, to allow modules to be loaded by programs. * Programs can now load any runtime modules, as long as they are whitelisted. * Programs under the engine directory can now use a shared build environment, so that building with a project file does not cause output binaries to be output to the project directory. * UnrealPak is now always built by default when packaging * Convert UnrealPak to a modular configuration Change 4216736 by Ben.Marsh UnrealPak: Move "ExportDependencies" command into an editor commandlet, since it relies on the UObject system, asset registry, etc... Change 4217447 by Ben.Marsh Back out revision 50 from //UE4/Dev-Core/Engine/Build/InstalledEngineBuild.xml Change 4217451 by Ben.Marsh Back out revision 11 from //UE4/Dev-Core/Engine/Plugins/Developer/VisualStudioSourceCodeAccess/Source/VisualStudioSourceCodeAccess/VisualStudioSourceCodeAccess.Build.cs Change 4217617 by Ben.Marsh Back out changelist 4217451 Change 4222552 by Ben.Marsh Don't use #import <TypeLib> for VS source code accessor when building with Clang; it's not supported. Change 4222630 by Ben.Marsh UBT: Fix spam while generating project files if Clang isn't installed. Change 4223316 by Ben.Marsh UBT: Change the order in which Visual C++ toolchains are enumerated to prefer full releases over preview releases. Change 4223318 by Ben.Marsh UBT: Add a build setting which allows creating a dedicated PCH for every file that's excluded from the unity working set (disabled by default). Improves iteration times when working on individual cpp files, but slows down iterating on header changes (and can take a lot of disk space for large changes). Dedicated PCH contains all includes scraped from the top of each cpp file, until a non-#include directive is encountered. Change 4223401 by Ben.Marsh UBT: Add an option to automatically enable edit and continue for files in the adaptive non-unity working set. E&C doesn't seem very useful for UE4 projects right now; compile time is comparable to regular build times, but it can take several minutes to apply code changes for large projects. Change 4223899 by Ben.Marsh UBT: Fix loading XML config files on Mono; Type.GetField(Name) does not seem to return values unless binding flags are specified. Change 4224637 by Ben.Marsh Add a "SupportedPrograms" field to plugin descriptors, which allows plugins to declare which plugins they support independently of individual modules. Programs now respect the "bEnabledByDefault" setting in plugins. Plugins that are compatible with a program now need to list that program in the SupportedPrograms list, and whitelist any modules that should load for that program. Change 4224710 by Ben.Marsh UBT: Don't add import libraries as final build products unless the target is being precompiled. Prevents the need for building them for leaf nodes in the action graph. Change 4224715 by Ben.Marsh UBT: Remove hack to allow Stats2.cpp to not follow IWYU convention. Change 4224726 by Ben.Marsh Remove commented out line. Change 4224903 by Ben.Marsh Fix non-unity compile error in Stats2.h. Change 4225051 by Ben.Marsh Back out changelist 4224710; causing CIS errors due to receipts not matching. Change 4225134 by Ben.Marsh Fixing non-unity errors. Change 4225203 by Ben.Marsh Another non-unity fix. Change 4225249 by Ben.Marsh Fix Linux dependencies being copied for the Windows editor; they can be added as requirements for the Linux target platform on Windows instead, so it respects the user's chosen platforms. #jira UE-62001 Change 4225512 by Ben.Marsh BuildGraph: Allow setting the target to build when using the <CsCompile> task. Change 4228815 by Ben.Marsh UBT: Always add the generated code directory to the list of include paths when generating project files. It may only be created after UHT has been run. Change 4228944 by Ben.Marsh UBT: Remove legacy CppCompileEnvironment and LinkEnvironment wrappers from TargetRules that were deprecated in 4.19. Change 4229028 by Ben.Marsh UBT: Fix editor targets with unique build environment having the wrong executable path in generated project files. Move move logic to configure target rules post-construction by the rules assembly to ensure it's valid. Change 4229065 by Ben.Marsh UBT: Move another target setting into the rules assembly. Change 4229105 by Ben.Marsh Fix BPT exception when generating project files. Change 4229311 by Ben.Marsh UBT: Store the module rules file location on the ModuleRules instance, as well as the plugin that it was created from. Also expose the plugin directory as a property on the ModuleRules instance. Change 4229421 by Ben.Marsh UBT: Consolidate functionality for UHT module setup in ExternalExecution.cs. Change 4229817 by Ben.Marsh UBT: Modules must now explicitly specify the path to the header used to generate a PCH if one is desired, rather than the header being determined automatically by attempting to parse the source code. Now that PCHs are force-included anyway, this removes a lot of dependencies inside UBT. Change 4229824 by Ben.Marsh UBT: Remove unused lists inside UEBuildModuleCPP.SourceFilesClass. Change 4229841 by Ben.Marsh UBT: Remove some legacy code from auto-detecting PCHs. Change 4230521 by Ben.Marsh UBT: Add utility functions to the log class to allow formatting errors and warnings in Visual Studio output format (eg. File(Line): warning: Message) Change 4230871 by Ben.Marsh UAT: Remove StreamUtilis utility class; there is a simpler way to implement the one place it's used. Change 4230882 by Ben.Marsh UAT: Add StreamUtils back into UAT, seems like it's still used there. Change 4230896 by Ben.Marsh UBT: Remove some redundant parameters from UEBuildModule/UEBuildModuleCPP/UEBuildModuleExternal constructors. Change 4231014 by Ben.Marsh WorkspaceTool: Include a dump of raw bytes when garbage is read from the P4 process, for diagnostic purposes. Change 4231032 by Ben.Marsh Fix CIS. Change 4231096 by Ben.Marsh Bump the FlatCPPIncludeDependencyCache version, to prevent errors trying to load old files. Change 4231446 by Ben.Marsh UBT: Added support for expanding UE-specific variables in include paths and library paths: $(EngineDir), $(ProjectDir), $(PluginDir), $(ModuleDir). Change 4231460 by Ben.Marsh Modules may now explicitly specify rpaths on Linux via the PublicRuntimeLibraryPaths and PrivateRuntimeLibraryPaths properties. Change 4233909 by Robert.Manuszewski PR #4779: Reason fails as the supplied variable is incorrect (Contributed by projectgheist) Change 4233910 by Ben.Marsh Enable PCHs on IOS. Reduces build time by ~25%. Change 4234176 by Ben.Marsh UBT: Add better messaging for modules that need to have a private PCH set. Now detects the likely PCH using the same method as legacy code and includes it as a suggestion. Change 4234193 by Ben.Marsh Add the Delete command to Perforce wrapper in DotNETUtilities. Change 4234688 by Ben.Marsh UBT: Simplify handling of installed/precompiled builds. Settings for whether a folder is installed/read-only or not is now stored on the RulesAssembly instance, allowing multiple things to be configured separately and stacked together (eg. engine/enterprise/project). RulesAssembly.IsReadOnly() allows determining if a flie can be modified or not and replaces many previous IsXXXInstalledCalls(), and traverses the chain of assemblies. Change 4234711 by Ben.Marsh UBT: Runtime dependencies can now be copied to output directories as part of the build. When adding a runtime dependency, an optional source location can be specified to copy from. Both the source and target paths can use variables can be used as part of the path, eg. $(OutputDir), $(ModuleDir), $(PluginDir). Example usage (from a .build.cs file): RuntimeDependencies.Add("$(OutputDir)/Foo.dll", "$(PluginDir)/Source/ThirdParty/Foo.dll", StagedFileType.NonUFS); Change 4234872 by Ben.Marsh Expose a flag for whether the engine is installed, to fix issues generating project files. Change 4234929 by Ben.Marsh Fix null reference generating receipts when UBT makefiles are active. Change 4235883 by Chad.Garyet Merging 4231245 to core Giving Coordinator its own sln. This should fix what 4158155 was supposed to. #jira UE-61955 Change 4236075 by Ben.Marsh CIS fix Change 4237066 by Robert.Manuszewski Fix for a potential crash when terminating the engine while it's being initialized #jira UE-60545 Change 4237078 by Robert.Manuszewski The engine will no longer be resetting all linkers causing massive load times when renaming the world package when entering Play In Editor Change 4237116 by Ben.Marsh Rewrite some Windows utility functions to support paths longer than MAX_PATH. Change 4237158 by Ben.Marsh Add const TCHAR* overloads of FString::RemoveFromStart() and FString::RemoveFromEnd(). Change 4237159 by Ben.Marsh Fix FWindowsPlatformFile::GetFilenameOnDisk() support for paths longer than MAX_PATH, and simplify some of the other long path functions to avoid copying string buffers. Change 4239050 by Ben.Marsh Missing file Change 4239318 by Ben.Marsh Linux CIS fix. Change 4239685 by Ben.Marsh Static analysis CIS fix. Change 4240800 by Ben.Marsh WorkspaceTool: Include the full command line in the log for any P4 commands. Change 4240903 by Ben.Marsh PR #4909: Update copyright notices to 2018 (Contributed by projectgheist) Change 4241025 by Ben.Marsh UBT: Exclude mobile pipeline caches from generated project files. Causes huge slowdown when using 'Find in Files' through the IDE. Change 4241770 by Ben.Marsh UBT: Include action number in parallel executor output. #jira UE-62032 Change 4243469 by Ben.Marsh TBA: Merge FAnnotatedStructuredArchiveFormatter with FStructuredArchiveFormatter. Any functions that are only implemented for text archives now have a _TextOnly suffix, and are exposed through the FStructuredArchive interface. Change 4245723 by Robert.Manuszewski Fixing another creash when terminating the engine while initializing. #jira UE-60545 Change 4245862 by Steve.Robb VectorLoadFloat2(Ptr) added, which loads { Ptr[0], Ptr[1], Ptr[0], Ptr[1] } into a VectorRegister. Change 4246412 by Robert.Manuszewski The warning 'Calling StaticLoadObject during PostLoad may result in hitches during streaming' will now also report the object which had the PostLoad called on it when StaticLoadObject call happened. Change 4246612 by Ben.Marsh UBT: Fix spelling of "Intellisense". Change 4249454 by Robert.Manuszewski Added extra checks to catch scenarios where the EDL Precache Buffer is flushed before a package header is fully read Change 4249513 by Robert.Manuszewski Made sure the Async Loading Thread doesn't continue running after creating new async packages when garbage collector wants to run on the game thread Change 4255207 by Ben.Marsh UGS: Add additional logging whenever a P4 command fails, and when the user is logged out. Change 4255288 by Ben.Marsh PR #4921: Honor ModuleRules' bEnableExceptions flag when creating precompiled h. (Contributed by surakin) Change 4256422 by Ben.Marsh UBT: Add an error if a module referenced by a plugin descriptor doesn't exist. Change 4257385 by Robert.Manuszewski Creating new objects from within ForEachObjectWithOuter will now result in a fatal error as it's unsafe to change internal UObject hash tables when iterating over them. Change 4257454 by Robert.Manuszewski Added the option to filter clusters listed with gc.ListClusters by objects within them. Usage: gc.ListClusters Hierachy With=ObjectName1,ObjectName2... Change 4257526 by Robert.Manuszewski It's now possible to filter clusters that get logged with verbose cluster logging enabled (UE_GCCLUSTER_VERBOSE_LOGGING=1) by objects within them by specifying -DumpClustersWithObjects=ObjectName1,ObjectName2 in the command line Change 4257822 by Ben.Marsh Fixes for PlatformShowcase compile errors. Change 4258771 by Ben.Marsh UBT: Fix project files not being generated for foreign projects when creating .stub files. #jira UE-62462 Change 4258790 by Ben.Marsh UBT: Clean up the logic around generating project files before creating a stub IPA, so that it fails loudly if project files do not exist, and can accept target names not matching project names. Change 4259276 by Ben.Marsh UBT: Make it an error if a framework doesn't exist, rather than failing silently. Also remove some remote toolchain stuff that's no longer necessary. Change 4259280 by Ben.Marsh UBT: Fix embedded framework zips not being uploaded for plugins. #jira UE-62485 Change 4260236 by Ben.Marsh UBT: Fix path to generated engine project file. Change 4260334 by Ben.Marsh UGS: Fix custom build steps dialog inadvertantly modifying config file settings in-place. Change 4260361 by Ben.Marsh UGS: Allow for p4 login commands to fail, even though the user is logged in (due to a bad connection, etc...) Change 4260559 by Ben.Marsh UGS: Update version. Change 4261160 by Robert.Manuszewski MediaPlaylist will now be added to root set if the owning MediaPlayer is in the disregard for GC set (fixes GC assumption violation crash) #jira UE-62495 Change 4261421 by Ben.Marsh Force-sync files for building documentation, to fix issues with files not being updated. #jira UE-62413 Change 4261425 by Ben.Marsh UBT: Remove some leftover functions for handling the remote toolchain. Change 4261530 by Ben.Marsh UBT: Speculative fix (and better error reporting) for IOS mobile provision not being found in CIS. Change 4261611 by Ben.Marsh UBT: Downgrade warning to a log message, since it appears when generating project files. Change 4261710 by Ben.Marsh Remove assert that GLogConsole is set; it won't be for command line utilities that don't depend on ApplicationCore. #jira UE-62545 Change 4261831 by Ben.Marsh Fix compile errors due to missing include path when hot-reloading a module from the editor. There are not necessarily source files to compile when -modulewithsuffix is specified on the command line, which was results in GeneratedCodeWildcard not being set. #jira UE-62463, UE-62384 Change 4262723 by Ben.Marsh Whitelist plugins that need to be loaded by UFE. #jira UE-62564 Change 4265444 by Ben.Marsh Fix incorrect executable name for DebugGame configurations in Xcode. #jira UE-62574 Change 4265892 by Ben.Marsh Fix incremental compile failures due to dependency checking for unity files. CachedIncludePaths was not correctly being set on file items, so dependencies were being ignored. #jira UE-62575, UE-62603, UE-62597 Change 4266019 by Josh.Adams - Fixed the CopyAction for runtime dependencies that need to be copied to different location, on non-XGE Change 4266264 by Ben.Marsh Remove override for the __IPHONE_OS_VERSION_MIN_REQUIRED macro on TVOS. This macro is already defined by system headers (in <AvailabilityInternal.h>). Now that we support PCHs on IOS and TVOS, manually defining this macro results in it being defined three times (once for the PCH, once by AvailabilityInternal.h, and once by the force-included list of definitions for the source file being built). The errors for redefining the macro in AvailabilityInternal.h are suppressed due to it being a system header, but the error for redefining it for the source file being compiled are not. #jira UE-62578 Change 4266273 by Ben.Marsh Fixes incremental build failure when compile arguments for PCH have changed on IOS/TVOS. Compile action needs to have a dependency on PCH build action. Change 4266614 by Graeme.Thornton Fix crash when cooking nativized blueprints due to removal of child cooker system. Change 4266763 by Ben.Marsh Always build UnrealPak when building client targets. The ProjectParams.Pak option is not reliable, because it can be forced on later by the target platform. #jira UE-62584 Change 4267985 by Robert.Manuszewski When iterating with ForEachObjectWithouter, don't lock the entire has table but only the hash bucket that is currently being iterated #jira UE-62600 Change 4268558 by Robert.Manuszewski PurgeLegacyBlueprints will no longer be called from within ForEachObjectWithOuter is it renames objects that reside in hash tables that are being iterated over which may lead to undefined behavior. #jira UE-62600 Change 4269011 by Chad.Garyet - Fixing Wildcard match issue, the change to ugsapi sends projects as //Depot/Stream instead of //Depot/Stream/ Wildcard match was only substringing to 3 chars. - Checking in the change a while back that increases the number of queried jobs up to 432 based on some maths from Bob about how many builds we want to grab Published to ugsapi server 8/8/17 #jira none Change 4270788 by Ben.Marsh Fix IOS provisioning data being using when remote compiling on TVOS. #jira UE-62705 Change 4271916 by Ben.Marsh Tag the XGEControlWorker executable as a build product after compiling SCW, to make sure it's included in the UGS zip file. Change 4271934 by Ben.Marsh Upload all static libraries in plugin folders as part of remote builds. #jira UE-62694 Change 4273368 by Ben.Marsh Fix Slate dependencies not being enumerated, and rules assembly not being rebuilt when building remotely. #jira UE-62705 Change 4274049 by Ben.Marsh Always parse the team UUID out of the mobile provision when doing a remote compile. The provision installed on the remote Mac (and selected for signing) may be different. #jira UE-62751 Change 4274823 by Ben.Marsh Add the -VersionCookedContent argument to disable the -unversioned parameter on the cooker command line. Change 4275838 by Ben.Marsh Fix BuildVersion string not being passed through from <SetVersion> task. Also add a -BuildVersion command line argument to UBT to override it for a particular build. Change 4275913 by Ben.Marsh Add a dummy exported symbol to the XGEController module, to fix build errors due to missing .lib file when it's built with WITH_XGE_CONTROLLER = 0. Change 4284161 by Ben.Marsh Allow mirroring Oodle files to remote Mac. Change 4074774 by Steve.Robb Vast simplification of TFunction, making it smaller in footprint, easier to follow and extend, and more correct. TUniqueFunction added, which is a move-only TFunction which can hold move-only functors. Fix for UWidgetBlueprint::ForEachSourceWidget() which should never have compiled but did. FFunctionGraphTask and TFuture<> updated to use TUniqueFunction to make them more general. TArray::HeapPop() made to work with move-only types. Change 4082591 by Ben.Marsh Move the Log class from UBT to DotNetUtilities. Change 4083236 by Ben.Marsh Add a Log.WriteException() method to dump an exception message to the console (and write the exception trace to the log) Change 4084107 by Ben.Marsh UAT: Remove the unused -SkipHeader argument to UE4Build. Change 4089771 by Steve.Robb GitHub #4743 : modified VirtualAlloc function flag https://blogs.msdn.microsoft.com/oldnewthing/20151008-00/?p=91411 Change 4091456 by Steve.Robb Unification of all platforms' FMath::CountTrailingZeros() and FMath::CountLeadingZeros() for both 32-bit and 64-bit. Change 4156437 by Ben.Marsh Lots and lots of fixes compiling for Clang on Windows. Editor now compiles cleanly without warnings, but crashes on startup due to error in intrinsics test. Disabling that runs further, but crashes accessing freed memory. Switching to the ANSI allocator runs further, but crashes in Slate after the splash screen and before the editor window opens. // TODO! * Switching between Clang/ICL/VS2015/VS2017 is now supported through the same mechanism as switching Visual Studio versions, without requiring any source level changes. To use Clang, set WindowsPlatform.Compiler = WindowsCompiler.Clang from a .target.cs file, or set <WindowsPlatform><Compiler>Clang</Compiler></WindowsPlatform> from BuildConfiguration.xml. To pick a specific toolchain version, set WindowsPlatform.CompilerVersion. * Clang is now supported through AutoSDKs; will be added to CIS. * The Samples/Sandbox/Clang project forces Clang to be used from its target.cs file, and allows easily building all editor modules and plugins with Clang on Windows. * UnrealMathSSE intrinsics have been re-enabled for Clang due to missing functions from the UnrealMathFPU implementation, but causes failure in tests at startup. * SSE4_CRC32() is disabled in D3D12Pipelinestate.cpp, since intrinsics are only allowed if enabled for the whole target (rather than being used in specific functions due to runtime checks) Change 4157389 by Ben.Marsh Few more fixes for compiling the editor with Clang. Change 4183911 by Ben.Marsh Fixes to support incremental linking on Windows. Does not seem to have any net benefit right now; may improve once minimal rebuild is enabled. * Incremental linking no longer forces PDB files to be enabled for source files. * Actions can specify specific files to be deleted before each build. Code to forcibly delete PDB files has been moved to the MSVC toolchain. * Unused libraries produced by the cross-referenced link are no longer added as build products, since (a) deleting them breaks dependency checking for incremental linking and causes a full link, and (b) not deleting them breaks UBT dependency checking and causes actions to be run over and over again. * Icon update is disabled for Windows when incremental linking is enabled. * Removed rarely-used setting to always delete produced items before each build. Change 4184311 by Ben.Marsh UGS: Added a dialog which shows all the required platform SDKs for a branch, linked from the status panel in UGS. The llist is configured via the UGS config file submitted to Engine/Programs/UnrealGameSync/UnrealGameSync.ini (and may be overridden by the project config file if necessary): [Default] ; Set this to a network share which contains the SDK installers for your site SdkInstallerDir= ; All the required SDKs for the current version of the engine +SdkInfo=(Category="Android", Description="NDK r21", Browse="$(SdkInstallerDir)\\Android") +SdkInfo=(Category="Windows", Description="Visual Studio 2017") +SdkInfo=(Category="Windows", Description="Visual C++ Toolchain 14.13.26128") +SdkInfo=(Category="Windows", Description="Windows SDK 10.0.16299.0") Similar entries for console platforms are added in console subdirectories. Each entry may contain an Install="Foo.exe" and/or Browse="C:\Foo" style attribute, specifying the path to an installer to run or directory to open in explorer respectively. The SdkInstallerDir setting is used as a base directory for the default installers, seen above for Android. Licensees may override this with a network path specific to the site that UGS is being deployed to (either in this file, in a project specific config file, or in a Engine/Programs/UnrealGameSync/NotForLicensees/UnrealGameSync.ini file). Change 4200452 by Ben.Marsh UBT: Change DebugGame configurations to output a separate executable rather than requiring a -Debug argument at runtime. Previous behavior was a common source of errors. Engine modules are still shared between Development and DebugGame, but the launch module sets a flag in Core on startup indicating the game configuration. Change 4206189 by Ben.Marsh UBT: Simplify logic for precompiling binaries. * Target no longer has separate list of "precompile only" binaries or modules. New -AllModules option allows adding every module to a target, which can be used with -Precompile and -NoLink to precompile object files for monolithic builds. * Precompiled file lists have been removed from target receipts. * The manifest now includes all generated headers and precompiled files when run with the -Precompile option. * Separate -DependencyList=Foo.txt has been added to write a list of all dependencies required to use precompiled binaries. This file list can be read using the <Tag> task in buildgraph. Change 4215466 by Ben.Marsh UBT: Remove indirect calls to determine extensions for object files and precompiled headers. The toolchain knows the correct convention for the platform. Change 4215975 by Ben.Marsh UBT: Remove telemetry code. This has never proved useful for analyzing performance due to the number of incidental factors that affect build times (eg. number of files being compiled). Change 4220154 by Ben.Marsh Move text-only implementations of FOutputDeviceError back into Core, so we can build command-line applications that don't depend on ApplicationCore. Change 4224708 by Ben.Marsh Add a bCompileAgainstApplicationCore setting to the target rules, which allows compiling out references to the ApplicationCore module (which should only be necessary for applications with a GUI). Removed ApplicationCore from several engine tools and utilities. Change 4224958 by Ben.Marsh Remove CoreMinimal.h includes from Core. Change 4229059 by Ben.Marsh UBT: Remove the UEBuildPlatform.ShouldNotBuildEditor() hook for target platforms. We shouldn't be modifying a target's build environment to disable the editor; it is invalid to build the editor for these target platforms at all, and this is already enforced by the GetSupportedPlatforms() function. Change 4230508 by Ben.Marsh Fixup precompiled header setting for samples and games. Change 4231457 by Ben.Marsh Fix exceptions in log messages having trailing newlines. Change 4232406 by Ben.Marsh UBT: Always force include a PCH for generated code if there's one set; the code may depend on it to compile. Change 4234177 by Ben.Marsh Set up private PCH files everywhere that previously used them. Change 4235973 by Ben.Marsh Change FPlatformMisc::GetEnvironmentVariable() to return an FString() rather than requiring a fixed size buffer to be passed in. Removes references to MAX_PATH. Change 4238842 by Ben.Marsh Add support for paths longer than MAX_PATH in the editor. Requires Windows 10 version 1607, and the functionality to be enabled via a registry key or group policy (see https://docs.microsoft.com/en-us/windows/desktop/FileIO/naming-a-file). Only a subset of Win32 functions support long paths (executables can only be started from paths shorter than MAX_PATH, for example). * Added a FPlatformMisc::GetMaxPathLength() function to return the maximum length of a path on the current system. On Windows, this returns a different value for systems with long paths enabled to those without. * The MAX_PATH define is no longer set by non-Windows platforms. Instead, there is a MAC_MAX_PATH, UNIX_MAX_PATH, etc... for any platform-specific code that still relies on the previous macro. * The MAX_UNREAL_FILENAME_LENGTH macro has been renamed to MAX_UNREAL_FILENAME_LENGTH_DEPRECATED * The PLATFORM_MAX_FILEPATH_LENGTH macro has been renamed to PLATFORM_MAX_FILEPATH_LENGTH_DEPRECATED. * Removed custom resource files for programs, since they are just copies of the base UE4 one (which is used by default anyway). The base UE4 manifest declares support for long paths. * Fix 512 character maximum length on editor commands. 260 character limit remains in place for cooking at the moment (see ContentBrowserUtils.h), until C# staging code supports long paths. Change 4255042 by Ben.Marsh UBT: Remote compilation now uploads the entire workspace to the remote Mac and executes a separate remote instance of UBT rather than synchronizing individual actions. This makes the remote compile codepath much simpler, and removes a lot of special cases that exist to support it previously. The list of files to be transferred to the remote are listed as rsync filter rules in Engine/Build/Rsync/RsyncEngine.txt and RsyncProject.txt, which are applied to the root engine directory and project directory respectively. Projects that need to customize which files are uploaded can add their own <ProjectDir>/Build/Rsync/RsyncProject.txt file, which will be included in the filter before the default version. Change 4260567 by Ben.Marsh UAT: Rename CommandUtils.Log to CommandUtils.LogInformation, to avoid conflicts with the underlying Tools.DotNETCommon.Log class. #rb none [CL 4285673 by Ben Marsh in Main branch]
2018-08-14 18:32:34 -04:00
LogInformation("Starting Client....");
var SC = DeployContextList[0];
ClientProcess = SC.StageTargetPlatform.RunClient(ClientRunFlags | ERunOptions.NoWaitForExit, ClientApp, ClientCmdLine, Params);
// ClientProcess = Run(ClientApp, ClientCmdLine, null, ClientRunFlags | ERunOptions.NoWaitForExit);
if (NumClients > 1 && NumClients < 9)
{
for (int i = 1; i < NumClients; i++)
{
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 4285612) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3836829 by Ben.Marsh UBT: Fix ability to precompile plugins from installed engine builds. Change 3839519 by Ben.Marsh UBT: Simplify configuring bPrecompile and bUsePrecompile settings for modules. Each rules assembly can now be configured as installed, which defaults the module rules it creates to use precompiled data. Change 4042043 by Steve.Robb GitHub #4705 : Added weak lambda's for delegates and multicast delegates. Change 4042056 by Robert.Manuszewski Optimized Mark Phase of GC by up to 10ms by making it run in parallel and removing a huge array presize which we didn't need. Change 4042104 by Robert.Manuszewski Set the minimum GC cluster size to 5 so that GC doesn't have to process micro clusters which are more expensive than processing individual objects + Exposed the minimum cluster size to ini and project settings as gc.MinGCClusterSize + Added the ability to sort clusters by name/object count/mutable object count/referenced clusters count when dumping them with gc.ListClusters command Change 4042377 by Robert.Manuszewski Reworked how GC and other threads (ALT specifically) interact - GC will now notify the ALT it wants to run and ALT will immediately try to finish its current work to allow that. Also the entire ALT tick is now protected against GC running at the same time to improve ALT stability. + added gc.ForceCollectGarbageEveryFrame console variable that triggers a forced GC every frame Change 4042427 by Robert.Manuszewski Changed FGCCSyncObject to use events when waiting for GC to finish so that it doesn't spin on non-game threads when GC is running Change 4042482 by Robert.Manuszewski Unhashing unreachable objects (ConditionalBeginDestroy) will now also be done incrementally, just like the purge phase of Garbage Collection Change 4042635 by Robert.Manuszewski Fix for a potential assert when incremental purge garbage is pending and something forces a full purge Change 4044092 by Steve.Robb Fix for forward declared CoreUObject weakobject types in delegates when building in Clang. Change 4044102 by Robert.Manuszewski Fix for a possible hang when worker threads are preventing GC from running and something is later trying to FlushAsyncLoading with the Async Loading Thread enabled Change 4044113 by Steve.Robb Another Clang fix. Change 4044160 by Robert.Manuszewski Disregard For GC pool will now be enabled by default in cooked builds Change 4044287 by Steve.Robb Typo fix. Change 4047723 by Graeme.Thornton TBA: Fixes for import/export name cache and object resolving Change 4048015 by Graeme.Thornton TBA: Weak/Soft/Lazy pointer serialization changes * Remove FWeakObjectPtr::Serialize, move it's logic into, and replace usages of with calls to, FArchiveUObject::SerializeWeakObjectPtr(). Ensures that something is always sent to the archive so that structured archives can be kept happy in the future. * Added Weak/Soft/Lazy pointer handling to the structured archive slot interface and all the formatters. Binary formatters just forward the call onto their inner and text archives store as a string path reference. * FArchiveUObjectFromStructuredArchive caches all these pointer types and stores indices in the binary block, same as with a UObject*. All pointers are then forwarded to the underlying formatter in one go on finalization. Change 4048021 by Steve.Robb Fix for binding an unbound TFunction to another TFunction with a different signature. Also all null pointers now count as unbindings, not just nullptr. TIsMemberPointer added. TIsATFunction and TIsATFunctionRef renamed to remove the 'A's. Change 4048544 by Robert.Manuszewski Fixing ConditionalBeginDestroy profiling after changes to incremental CBD. Change 4051028 by Graeme.Thornton TBA: ArchiveFromStructuredArchive adapter uses Inner to determine if it is outputting to text, and sets it's own ArIsTextFormat to false Change 4051056 by Graeme.Thornton TBA: High level tagged property / UObject base class text serialization - UObject serialize converted to structured archive - Properties written to text individually with text tags, and then binary adapted values - Only saves, doesn't load Change 4051111 by Graeme.Thornton TBA: Temporarily disable loading of text assets until tagged property serialization path is fixed up Change 4051154 by Graeme.Thornton TBA: Convert a few uobject serializers to structured archive format for example purposes Change 4051181 by Graeme.Thornton TBA: Added default structured archive implementation of SerializeItem to UProperty, which just calls the FArchive version on an FArchiveUObjectFromStructuredArchive adapter. Implemented structured archive SerializeItem for UArrayProperty Change 4051197 by Graeme.Thornton TBA: ObjectProperty text serialization Change 4051216 by Graeme.Thornton Restored a modified FWeakObjectPtr::Serialize function to keep backwards compatibility in code I don't have access to. Change 4051261 by Graeme.Thornton TBA: Convert UMetaData to structured archive Change 4051374 by Steve.Robb Incorrect assert removed. Change 4051562 by Robert.Manuszewski Adding stats for the new GC internal functions Change 4051614 by Graeme.Thornton TBA: Removed UProperty::SerializeItem(FArchive, ...) and replaced with UProperty::SerializeItem(FStructuredArchive::FSlot, ...). Fixed up most of them to work properly and added adapters in for any that were non-trivial. Change 4052512 by Graeme.Thornton TBA: Temporary workaround for softobjectptr and lazyobjectptr uproperties not serialization anything when they know the archive is a reference collector. They should always be serializing their pointers and letting the underlying archive itself ignore them. Change 4053917 by Robert.Manuszewski Clustered objects from clusters that are no longer reachable will now be marked as unreachable immediately when gathering unreachable objects Change 4053919 by Robert.Manuszewski Added the ability to disable incremental BeginDestroy in ini/project settings Change 4055518 by Daniel.Lamb Fixup for deterministic audio generation issue. Submitted on behalf of Rich.Whitehouse #jira nojira #test prefilght automated test. Change 4056854 by Graeme.Thornton TBA: Added a test asset to EngineTest which contains all the different property types and test cases. Change 4056858 by Graeme.Thornton TBA: Updated USetProperty to proper structured archive usage Change 4056872 by Graeme.Thornton TBA: Add map property field to test object Change 4056873 by Graeme.Thornton TBA: Convert UMapProperty to full structured archive Change 4056994 by Graeme.Thornton TBA: Converted FText over to structured archive. Implemented saving, but not loading. Change 4059728 by Ben.Marsh UBT: Add support for using adaptive non-unity builds when the engine and project are in separate repositories. Change 4059805 by Graeme.Thornton Fixed typo in text serialization. Fixes CIS automation test errors Change 4060007 by Graeme.Thornton TBA: FArchiveFromStructuredArchive will now access it's host slot lazily, i.e. only when a value is actually written to the archive. Change 4060092 by Stefan.Boberg Added optimized Windows console window output path to GenericConsoleOutput since this slowed down cooking considerably (2 minutes spent in wprintf alone for one large dataset) When stdout is attached to a console we use the WriteConsoleW function instead of wprintf since the latter is very slow especially in unbuffered mode which the engine currently configures for stdout (see setvbuf call in LaunchEngineLoop.cpp). At some point we should reconsider this buffering policy since it's likely to slow down other platforms as well but I wanted to do a safe change for now as I don't yet fully understand why the setvbuf call is there in the first place. Change 4060108 by Stefan.Boberg Introduced some additional target platform utilities to help with asset cook optimizations * We now assign each ITargetPlatform a zero-based ordinal value * Introduced FTargetPlatform and FTargetPlatformSet types to help store platform references and platform sets efficiently. These are not currently used in the engine but are designed to replace the existing ITargetPlatform/string/FName representations in the cooking data structures. Change 4060143 by Graeme.Thornton Undo //UE4/Dev-Core/Engine/Source/Runtime/... changelist 4060007 Needs some other changes that I haven't checked in yet... Change 4062432 by Ben.Marsh Fix error message when enumerating P4 changes. Change 4062648 by Ben.Marsh Add missing p4 integration action. Change 4063620 by Graeme.Thornton Integrated a fix from UDN where the engine would crash when trying to load a very small encrypted file (<16bytes) from a pak file, where the read address wasn't already aligned to the AES block size. (https://udn.unrealengine.com/questions/431989/crash-while-reading-a-very-small-file-in-encrypted.html) Change 4066963 by Robert.Manuszewski Fixing GC cluster verification code reporting false positives when a cluster is referencing another cluster through 'mutable' objects list. Change 4067133 by Robert.Manuszewski Changed log verbosity when reporting individual cases of GC cluster assumption violations as they are followed by an asser anyway and this way we get the chance to see all issues before we assert at the end of these checks. Change 4067443 by Steve.Robb FString can now be constructed from any char pointer type and length. Change 4068156 by Steve.Robb Fix necessary because of FString constructor change in CL# 4067443. Change 4070258 by Graeme.Thornton Fixes for VSCode Change 4070372 by Graeme.Thornton TBA: Script struct serialization to structured archives Change 4071913 by Ben.Marsh Move bulk of the code for UnrealPak into an engine developer module, so it can be used in the editor. Change 4071914 by Ben.Marsh Missing files. Change 4071937 by Ben.Marsh Missing header. Change 4072015 by Ben.Marsh Fixes for compiling PakFileUtilities as part of the editor. Change 4072826 by Steve.Robb TBitArray::Reserve() added. TBitArray::Add() overloaded to allow adding multiple bits. TSparseArray::Reserve() optimized to call the overloaded Add(). Change 4073271 by Daniel.Lamb Fixed add patch tier in project launcher passing the wrong commandline option to UAT. #test none Change 4074708 by James.Hopkin #core Removed redundant Casts Change 4074763 by Steve.Robb Fix for TSparseArray::Reserve() size. Change 4076063 by Ben.Marsh Add an "UnrealPak" commandlet with the same functionality as the standalone UnrealPak program. Invoke by running the editor with -run=UnrealPak and the standard UnrealPak commandline options. Change 4077064 by Robert.Manuszewski Fixing compile error in PakFileUtilities Change 4077144 by Graeme.Thornton TBA: TextAssetCommandlet improvements * Collect lists of broken assets during roundtrip tests and print a summary of packages that failed each phase at the end * After resaving as text, load the file back as a plain JSON hierarchy to ensure the output was valid Change 4077412 by Ben.Marsh Set the correct exit code for UnrealPak. Should return 0 on success, not 1. Change 4077760 by Graeme.Thornton TBA: Loading fixed for tagged property serialization Includes conversion of all UProperty::ConvertFromType() and SerializeFromMismatchedTag() functions to use structured archives Lazy initialization of FArchiveFromStructruredArchive when loading, to support the possibility of an adapter being create around an object property serialize call to its inner UStruct, which then decides not to do anything and return false. Stops the ArchiveFromStructuredArchive from consuming the slot and getting upset later on when we try to serialize normal tagged properties from it. Disabled lazy bulk data loading from text assets. Requires a bigger change to make it work. Added some debug checks to json input formatter which track the current value stack size when a new object is pushed onto the stack, and makes sure that the stack has returned to the same size when the object is popped. Catches cases where we unpack an array/stream to the value stack but then don't consume all the items. Change 4078800 by Ben.Marsh Change UAT to using the editor's UnrealPak commandlet rather than invoking the standalone UnrealPak executable. To improve performance when building several PAK files, also add a new -batch=<file> command which reads commands to execute in parallel from a text file. Change 4079745 by Graeme.Thornton TBA: Migrated a couple of UObject Serialize functions to FStructuredArchive (SoundCue / MaterialExpressions / Editor strip flags) Change 4079847 by Graeme.Thornton TBA: Add 'FindMismatchedSerializers' mode to text asset commandlet, which dumps out a list of all UClasses which don't have the CLASS_MatchedSerializers flag, meaning we can't guarantee the have Serialize functions for FArchive AND FStructuredArchive, therefore we can't use the new structured archive based serialize path. Should only ever be native instrinsic classes as UHT takes care of all other cases. Change 4079925 by Ben.Marsh Fix incorrect assignment when deriving name for chunked pak file. Change 4080214 by Ben.Marsh Move the ThreadPoolWorkQueue class into DotNETUtilities so it can be used by other projects. Change 4082394 by Graeme.Thornton CIS fix for variable shadowing warning Change 4082583 by Ben.Marsh Add a IBinarySerializable interface for types that support reading from a BinaryReader and writing to a BinaryWriter. Implementing IBinarySerializable implies a constructor taking a BinaryReader argument is available for deserializing. Change 4082652 by Ben.Marsh Fix FileReference.Directory not returning a directory with a trailing backslash for files in the root directory. Change 4082755 by Graeme.Thornton Fixed an erroneous usage of TUniquePtr<uint8>as a pointer to a uint8 array when creating pak files. Caused a crash when compression was enabled, and has probably surfaced because pak generation is now done by an editor commandlet rather than a standalone program. Change 4082756 by Graeme.Thornton Fixed some incorrect documentation for pakfile compressed chunk headers Change 4082883 by Graeme.Thornton Static analysis warning fix Change 4082912 by Ben.Marsh Move ExceptionUtils into DotNETUtilities. Change 4085291 by Graeme.Thornton TBA: In the Json output formatter, write float and double values out with enough precision for successful roundtripping. Added some debug only code which will immediately reconvert the string back to its original value and compare the the input Change 4085523 by Graeme.Thornton TBA: Remove only explicit usage of DECLARE_FSTRUCTUREDARCHIVE_SERIALIZER. Should only be used from UHT generated code. Change 4086037 by Robert.Manuszewski Fix for a potential race condition when two threads want to acquire GC lock Change 4088655 by Graeme.Thornton Pak creation now uses the bEnablePakSigning setting from the crypto config json file Change 4091474 by Steve.Robb Fix for TStaticBitArray::FindFirstSetBit() and TStaticBitArray::FindFirstClearBit(). Unused variables removed. Change 4093632 by Steve.Robb CIS fixes. Change 4093656 by Graeme.Thornton Build fix Change 4093744 by Ben.Marsh Allow per-chunk settings for whether to enable compression in UnrealPak. Change 4099712 by Gil.Gribb UE4 - Fixed rare case where insufficient space was preallocated for cooldown ticks. #jira UE-59686 Change 4099912 by Stefan.Boberg Cooking timer optimizations: - Replaced data structures for FScopeTimer and FHierarchicalTimerInfo. Previous implementation used FString for many things and caused *lots* of heap and string concatenation activity. Replaced with a compile-time node id (using __COUNTER__) and raw string literals. - Removed PERPACKAGE_TIMER support (was disabled by default and was difficult to test) - Made it possible to toggle OUTPUT_TIMING and ENABLE_COOK_STATS independently - Removed some extremely tight timers because the overhead from calling QPC significantly exceeded the measured code This change shaved some 15% off a clean cook of Fortnite WindowsClient (en) with fully populated local DDC Change 4100519 by Stefan.Boberg Quick fix for Linux build issue introduced in 4099927 Change 4105327 by Stefan.Boberg Cooker: Changed FHierarchicalTimerInfo so it uses a linked list for tracking child nodes, to be able to deal with any child count. Previously we assumed there would never be more than 9 children but it turns out there are cooker modes that need more. Fixes check when using -FullLoadAndSave to cook Change 4105448 by Stefan.Boberg - Fixed Linux build warning re: member initialization order - Also eliminated OUTPUT_HIERARCHYTIMERS/CLEAR_HIEARCHYTIMERS macros (plain functions are fine) - Moved finishing-up code for FullLoadAndSave() to TickCookOnTheSide() call site to improve timer output. Previously some of the scopes would not have been closed before printing and thus the output was misleading. Change 4109031 by Ben.Marsh Attribute-driven Perforce wrapper (old Epic Friday project). Offers a more complete implementation than the current P4 wrapper in UAT without requiring any platform-specific libraries. Uses the Python binary output for parsing. Change 4109588 by Ben.Marsh UBT: Add extension methods for serializing a nullable type to a BinaryReader/BinaryWriter. Change 4109595 by Ben.Marsh Missing project file for DotNETUtilities. Change 4110724 by Stefan.Boberg Removed annotation map locking in UObjectMarks, eliminating around one minute (~3.5%) from Fortnite cook time. The locking was redundant since the annotation maps are managed per thread anyway. Change 4111304 by Ben.Marsh UAT: Add support for setting a status message through the log class. Allows writing transient messages (eg. progress messages) which will be cleared out before writing other messages. Best used through the LogStatusScope class, which can set a status message for the duration of a using() block. As part of this change, the console no longer has to be added as a dedicated trace listener. Since we already special-case this listener when formatting log output, it's easier to just keep the implementation separate to the other trace listeners. Change 4112708 by Steve.Robb Fix for TBitArray::MaxBits in assignment. Change 4114133 by Stefan.Boberg Tweaked how low-level memory (LLM) tracker is implemented to reduce overheads. Previously FMemory functions would acquire the LLM singleton and call OnLowLevelFree/OnLowLevelAlloc etc which would check the bIsDisabled flag and early out if it was set. Due to how frequently these functions were called this ended up costing quite a bit. - This change makes the flag a static member variable instead of a member variable and therefore enables a simpler early-out to be implemented. - The singleton getter is also simplified to avoid hitting the threadsafe singleton construction path on every call. - The enable flag is no longer TAtomic - this also incurs extra overhead for no clear benefit Shaves approximately 3.5% (one minute) off a Fortnite cook test scenario (using -FullLoadAndSave) Change 4115010 by Robert.Manuszewski Fixing CIS Change 4115249 by Robert.Manuszewski Fixing async loading code asserts when exiting game very early due to an error #jira UE-56267 Change 4117091 by Ben.Marsh Prevent doubled-up lines when writing status updates with console log verbosity. Change 4117207 by Ben.Marsh UGS: Do not include executables in diagnostics zip file, and ignore "no such files" error when cleaning workspace. Change 4119175 by Ben.Marsh UGS: Fix crash writing version files when directory does not already exist. Change 4119987 by Ben.Marsh UGS: Show a dialog box while the launcher is updating executables from Perforce, which allows cancelling the operation if necessary. Allow setting the username on the settings window, and prompt for login credentials if necessary. Should prevent situations where users have to update settings from the command prompt. Holding down shift during launch now shows the settings dialog rather than an immediate prompt to launch the unstable version (unstable version is shown as a checkbox on this dialog). Change 4119991 by Ben.Marsh Update version number for UGS launcher to 1.13. Change 4121943 by Robert.Manuszewski Don't use FArchiveAsync2 for reading packages with non-async path in editor builds as its performance is worse than the standard archive's (saves about 1 minute when doing larger cooks and 7 seconds when loading into PIE) Change 4122592 by Steve.Robb GitHub #4762 : Improve wording and grammar of Math comments Also includes improved accuracy in FMath::ComputeBoundingSphereForCone(). Change 4122819 by Stefan.Boberg Don't call CreateDirectory redundantly when opening files for writing using FFileManagerGeneric::CreateFileWriter This change avoids calling IPlatformFile::CreateDirectoryTree if possible since this is a very expensive function especially for deep hierarchies as it performs directory creation from the root directory onwards instead of from the leaf downwards. That function should also be fixed but this change improves performance in the meantime. Change 4122872 by Stefan.Boberg CreateDirectoryTree now creates directories leaf-to-root instead of the other way around. This is much more efficient since we don't spend time on system API calls for directories which already exist. This accounted for a very large amount of CPU time in cooking as the full target file directory hierarchy would be "created" for every single output file. Change 4123109 by Stefan.Boberg - Disable overlapped I/O in editor / cooker. Synchronous I/O reduces the number of syscalls and Windows performs prefetching on our behalf anyway for sequential reads - Eliminated syscall which was issued for every write to update cached file size -- since we're the only writers to the file (file access allows read sharing at most) we can authoritatively update the file size on write completion Change 4123455 by Ben.Marsh PR #4775: New build param PCHMemoryAllocationFactor to set /Zm VS build param. (Contributed by lucaswall) Change 4124207 by Ben.Marsh UBT: Remove some unnecessary indirection for generated code paths. Change 4124217 by Ben.Marsh UBT: Remove another unused variable from UEBuildModuleCPP. Change 4124377 by Stefan.Boberg In IPlatformFile::DeleteDirectoryRecursively, attempt to delete file first and if it fails clear the readonly flag and try again Previously there was a call to clear the readonly flag for every deleted file and this is a waste of resources 99% of the time. The SetFileAttributes call accounted for a significant amount of time during cooker sandbox directory deletion Change 4125071 by Stefan.Boberg Some tweaks to FQueuedThreadPoolBase scheduling and memory management - Explicitly pass in false for TArray::RemoveAt(..., bool bAllowShrinking) argument to prevent memory reallocation when arrays are drained and inevitably repopulated shortly afterwards - Use a MRU strategy instead of LRU when picking a thread to wake up. The MRU thread is the most likely to have a 'hot' cache for the stack etc. Picking from the back of the array also happens to be cheaper since no memory movement is necessary when RemoveAt is called. (This was the strategy in place before CL2600362 which seems to have changed it unintentionally) - Release lock as soon as a thread has been chosen, before asking the worker thread to wake up and do the work Change 4126132 by Ben.Marsh UAT: Detect when stdout is redirected and prevent using backspace characters to move the cursor. Change 4126867 by Graeme.Thornton TBA: Fix tagged binary formatter Change 4127010 by Robert.Manuszewski AnimScriptInstances created at runtime will now also be added to the owning omponent's cluster to avoid GC issues. Change 4127932 by Ben.Marsh WorkspaceTool: Reduce unnecessary logging of status messages when console output is not redirected. Change 4129050 by Ben.Marsh UGS: Check for NET Framework 4.5 being installed before running the installer. Also fix warning trying to kill existing UGS instances before upgrade. Change 4129459 by Graeme.Thornton TBA: TextAssetCommandlet - When outputting converted assets to an output path, replicate the workspace relative path in the output directory Change 4129515 by Graeme.Thornton TBA: Add EnterRecord overload that allows outputting of available field names when loading. Change 4129517 by Graeme.Thornton TBA: Tagged properties are written out as named fields on the "Properties" record, rather than as a stream with a null tag at the end Change 4129518 by Graeme.Thornton TBA: Added a local const bool to allow easy hacking out of text asset loading support Change 4129558 by Graeme.Thornton TBA: Build fix for textasset-less configs Change 4129614 by Ben.Marsh UGS: Main window is now restored to normal size when activated by clicking on the tray icon. #jira UE-60490 Change 4129618 by Ben.Marsh UGS: Speculative fix for unreproduced exception accessing disposed window while shutting down. Change 4131936 by Robert.Manuszewski Removing some WIP code accidentally checked in with CL #4121943 Change 4133490 by Ben.Marsh UGS: Allow the $(Change) variable to be used in more places than just the context menu. #jira UE-60573 Change 4133550 by Ben.Marsh UGS: Setting for whether or not to use incremental builds is now exposed through the variable "$(UseIncrementalBuilds)" for use by custom build steps. #jira UE-60554 Change 4133681 by Ben.Marsh UGS: A per-project list of folders and extensions to be deleted by default when running the 'clean workspace' tool can now be specified through the <ProjectDir>/Build/UnrealGameSync.ini file. Settings may be specified for an individual branch (via a category with the depot path to the project) or for wherever the project is currently open (via the [Default] category). The SafeToDeleteFolders list specifies a substring that will be checked against folder paths. Anything containing this folder will be marked as safe for delete by default. The SafeToDeleteExtensions list specifies a list of extensions for files that can always be deleted. Example: [Default] +SafeToDeleteFolders=/MyGame/Test/ +SafeToDeleteFolders=/DataService/ +SafeToDeleteExtensions=.xx1 +SafeToDeleteExtensions=.xx2 #jira UE-60575 Change 4135449 by Ben.Marsh Fix allowing use of Job objects on Windows platforms (debug code submitted by mistake) Change 4135730 by Ben.Marsh UBT: Plugins can now be enabled and disabled from the .target.cs file (for targets that do not use the shared compile environment), by compiling the list of enabled/disabled plugin names into the Projects module. Change 4135823 by Ben.Marsh UBT: Remove legacy code to handle disabling optional plugins; now that this is compiled into the target, it will work for any plugins we choose. Change 4135945 by Ben.Marsh UBT: Fix error running programs with no explicitly enabled or disabled plugins. Change 4137207 by Ben.Marsh UGS: Align all badges with the same name, to make it easier to see which CIS steps are being run. Allow overriding the slot taken by a particular badge by calling it "SlotName:LabelName". Change 4137311 by Stefan.Boberg Removed child cooker support. In practice it is not a useful feature as it provides no performance improvement (quite the opposite in fact) and adds testing and maintenance complexity. Change 4137393 by Ben.Marsh UGS: Fix display of multiline errors in the status panel. Change 4141708 by Steve.Robb GitHub #3631 : Incorrect default argument in WeakObjectPtrTemplate #jira UE-45490 Change 4146655 by Stefan.Boberg Removed FullGCAssetClasses logic - no longer necessary nor useful Change 4147318 by Ben.Marsh UGS: Compress build badges in a column if it shrinks below the size that they would be visible. Change 4148207 by Ben.Marsh UGS: Added support for showing the latest completed build from a specific list of badges in the status panel. To declare a badge as one that should appear in the status panel rather than the CIS column, add it to the project's UnrealGameSync.ini in the project or [Default] section like so: +ServiceBadges=RoboMerge Change 4148282 by Stefan.Boberg Fixed bug in UCookOnTheFlyServer::GetCookOnTheFlyUnsolicitedFiles - UnsolicitedFiles should be passed by reference not by value Change 4148344 by Stefan.Boberg Fixed minor indentation error (most likely caused by sloppy merge) Change 4148521 by Stefan.Boberg Removed accidentally checked in PRAGMA_DISABLE_OPTIMIZATION from CookOnTheFlyServer.cpp Change 4148639 by Ben.Marsh UGS: Fix tooltips not showing for changes that have description badges. Change 4149373 by Ben.Marsh UGS: Allow adding additional columns to display particular badges by adding entries from the project config file. Example syntax: +Columns=(Name="Desktop",MinWidth=50,DesiredWidth=100,Weight=3,Badges="Editor") +Columns=(Name="Mobile",MinWidth=50,DesiredWidth=100,Weight=3,Badges="IOS,Android") Same form can be used to control how default columns are displayed (though badge settings are ignored). Also allow PerforceMonitor to detect local changes to project config files and update settings automatically. Change 4149399 by Ben.Marsh UGS: Update version to 1.143. Change 4155660 by Steve.Robb PROJECTION and PROJECTION_MEMBER macros which provide the correct behavior when creating projections using functions which are overloaded or use default arguments. Change 4157117 by Ben.Marsh Fix warning due to plugins disabled in .target.cs file. Change 4158011 by Ben.Marsh UBT: Add a check that the UnrealHeaderTool target file exists, rather than throwing an exception when reading it fails. Change 4158646 by Ben.Marsh UGS: Fix exception when login is discovered to have expired during a workspace update. Change 4158678 by Ben.Marsh UGS: Fix an exception on shutdown due to the icon being hidden after it's already been disposed. Change 4158683 by Ben.Marsh UGS: Add an unhandled exception filter which sends the exception data to the backend. Change 4159131 by Ben.Marsh UGS: Reduce the number of characters displayed for build badges based on the available space. Change 4159194 by Graeme.Thornton TBA: Fix incorrect map property conversion code when converting an old property that contains a map with different key/value types Change 4159239 by Steve.Robb Improved readability and compliance with coding standards. Change 4159246 by Ben.Marsh UGS: Allow syncing projects where source code is not available (and various version files don't exist). #jira UE-60985 Change 4159286 by Ben.Marsh UGS: Remove requirement for UE4Editor.target.cs to be visible in the depot in order to open a project. #jira UE-60986 Change 4159302 by Ben.Marsh UGS: Update version to 1.144. Change 4160308 by Ben.Marsh All staging client executables for blueprint projects. #jira UE-60983 Change 4161567 by Steve.Robb GitHub #4816 : UE-60771: Handle escaped double quote in FParse::LineExtended Change 4162641 by Ben.Marsh UGS: Allow customizing the position of custom columns, via the Index=N attribute. Change 4162647 by Ben.Marsh UGS: Update version to 1.145. Change 4165319 by Robert.Manuszewski PR #4812: Fix inconsistent command-line argument handling under Windows (Contributed by adamrehn) Change 4166150 by Ben.Marsh UGS: Include *.inl when looking for code changes. Change 4166551 by Steve.Robb Whitespace fixes caused by a bad merge. Change 4168483 by Ben.Marsh UGS: Add a more useful error if a file to be synced exceeds the max allowed path length. Change 4168490 by Ben.Marsh UGS: Update version to 1.146. Change 4168551 by Ben.Marsh UBT: Move bBuildLargeAddressAwareBinary into an exposed setting. Change 4168560 by Ben.Marsh UBT: Remove static config variable for controlling which configuration of UHT to use. Change 4171296 by Ben.Marsh UGS: Move the check for overlong paths earlier. Change 4171531 by Ben.Marsh UBT: Fix exception if BuildConfiguration.xml contains an unknown category. Change 4183371 by Robert.Manuszewski Fix for a crash in Async Loading Graph's CheckCycles when GC kicks in on the game thread and forces ALT to exit early Change 4184312 by Ben.Marsh UGS: Update version to 1.148 Change 4184480 by Robert.Manuszewski Removing unused async loading stat Change 4186390 by Ben.Marsh UBT: Format XML validation errors in a format that allows double-clicking on the message in Visual Studio. Change 4188644 by Ben.Marsh UBT: Add the MakePathSafeToUseWithCommandLine() function to UBT. Change 4188647 by Ben.Marsh UBT: Fix exception in target receipt when architecture is null. Change 4189617 by Ben.Marsh Change FileSystemReference, FileReference and DirectoryReference objects to use OrdinalIgnoreCase comparisons without creating a separate copy of the string to compare. The filesystem does not use the invariant culture, and it can produce the wrong results in some cases (the ordinal comparison is faster, too). Change 4189740 by Ben.Marsh UAT: Remote code to build UnrealPak when packaging; we use the editor now. Change 4189860 by Ben.Marsh UGS: Make the filter for excluding automated lighting rebuilds more explicit. Change 4190082 by Ben.Marsh Fixes to allow enabling edit and continue for Windows builds. Have experienced quite a few VS crashes when testing it in editor; not yet recommended for general use. - Allow edit and continue for any configuration, not just debug. - Fixed PDB errors compiling files that use a shared PCH with edit and continue enabled. Path to the generated PDB file was using the wrong directory. - Removed code that tracks PDB output files, since they're modified multiple times during a build. - Enable debug information when compiling generated CPP files, since it causes errors if the shared PCH PDB doesn't have the same option. - Disable support for remote execution of steps that modify the PDB, since the same file has to be modified many times. Remote execution causes the PDB files to be corrupted. Unfortunately, this makes E&C builds significantly slower. #jira Change 4192949 by Ben.Marsh UBT: Minor tidy-up (merging UEBuildBinary.Build and UEBuildBinary.SetupOutputFiles) Change 4193218 by Ben.Marsh Fix formatting. Change 4197252 by Mike.Erwin UAT: Fix log output w/ correct count of non-code projects. #jira none Change 4197941 by Ben.Marsh UGS: Add support for DebugGame editors that have an executable with a DebugGame suffix. Change 4197964 by Ben.Marsh UGS: Prevent attempts to automatically reopen projects while a modal dialog is up, or the workspace is syncing. Change 4198144 by Ben.Marsh UGS: Prevent modal dialogs when login expires in P4, and prompt for password when hitting "retry". Change 4198413 by Ben.Marsh UGS: Always show the main window when launched manually, and run with -RestoreState when launched at startup. Also add a couple more places that save the visibility state, since logging off seems like it can terminate the process abrubtly. Change 4198779 by Ben.Marsh UBT: Allow generating manifests to any arbitrary locations with the -Manifest=<Path> argument. Change 4198825 by Ben.Marsh UBT: Move code to enumerate Slate runtime dependencies into the Slate module. Doesn't need to be done inside core UBT. Change 4199341 by Ben.Marsh UGS: Update version to 1.149 Change 4199642 by Chad.Garyet - Deprecate CISController - Add BuildController to replace CIS GET/POST for builds - Add LatestController, GET does what CIS/GET used to do - Change Latest/GET to return the last 25 builds filtered by project, rather than the last 5000 individual Ids - Latest/GET now returns "LatestData" object instead of array of longs - Updated EventMonitor to match all API changes - Fixed bug where IDs were getting reset to initial startup values every update loop Change 4199663 by Chad.Garyet CIS controller still needs to return an array of longs #jira none Change 4199680 by Ben.Marsh UGS: Update version to 1.150 Change 4200457 by Ben.Marsh Merging CIS fix for non-development configurations. Change 4200472 by Mike.Erwin UAT: fix -skipbuildclient param default It was defaulting to skipbuildeditor's value, likely a copy-paste error. #jira none Change 4202595 by Ben.Marsh Fix static analysis warning due to constant comparison against macro. Change 4203250 by Ben.Marsh UGS: Always show the "Sync Precompiled Editor" option, but disable it and show a tooltip explaining why if it is not available. Change 4206191 by Ben.Marsh Exclude editor target files from installed builds, since they leak info about DLLs that have been stripped out. Change 4213011 by Ben.Marsh UBT: Include contents of modified intermediate files in the log, to make it easier to debug hidden dependencies. Change 4213487 by Ben.Marsh UBT: Fix assumption that bPrecompile is equivalent to bBuildAllModules. This is no longer the case; they are now controlled by separate options. Should fix CIS errors building the editor. Change 4213609 by Ben.Marsh Ensure that strings formatted using FMicrosoftPlatformString::GetVarArgs() are always null terminated, whether we use the secure CRT or not. Change 4215971 by Ben.Marsh UBT: Remove action graph visualization code; no longer used. Change 4215996 by Ben.Marsh UBT: Remove unqiue id from all actions in the action graph. This is only used for printing debug info in the case of a (rare) cycle in the action graph, so just look it up when needed. Change 4216022 by Ben.Marsh UBT: Rename Crypto.cs to EncryptionAndSigning.cs to match the name of the class inside it, and move it under the System folder. Change 4216031 by Ben.Marsh UBT: Move all the action executors into their own folder in the project. Change 4216526 by Ben.Marsh Fix CIS warnings. Change 4216544 by Ben.Marsh Replace custom code to ensure FMicrosoftPlatformString::GetVarArgs() null terminates its buffer with Microsoft's standards-compliant implementation. Change 4216633 by Ben.Marsh Add support for UnrealPak plugins. * Project and plugin modules can now specify an array of supported programs in the "WhitelistPrograms" field of their module descriptors, to allow modules to be loaded by programs. * Programs can now load any runtime modules, as long as they are whitelisted. * Programs under the engine directory can now use a shared build environment, so that building with a project file does not cause output binaries to be output to the project directory. * UnrealPak is now always built by default when packaging * Convert UnrealPak to a modular configuration Change 4216736 by Ben.Marsh UnrealPak: Move "ExportDependencies" command into an editor commandlet, since it relies on the UObject system, asset registry, etc... Change 4217447 by Ben.Marsh Back out revision 50 from //UE4/Dev-Core/Engine/Build/InstalledEngineBuild.xml Change 4217451 by Ben.Marsh Back out revision 11 from //UE4/Dev-Core/Engine/Plugins/Developer/VisualStudioSourceCodeAccess/Source/VisualStudioSourceCodeAccess/VisualStudioSourceCodeAccess.Build.cs Change 4217617 by Ben.Marsh Back out changelist 4217451 Change 4222552 by Ben.Marsh Don't use #import <TypeLib> for VS source code accessor when building with Clang; it's not supported. Change 4222630 by Ben.Marsh UBT: Fix spam while generating project files if Clang isn't installed. Change 4223316 by Ben.Marsh UBT: Change the order in which Visual C++ toolchains are enumerated to prefer full releases over preview releases. Change 4223318 by Ben.Marsh UBT: Add a build setting which allows creating a dedicated PCH for every file that's excluded from the unity working set (disabled by default). Improves iteration times when working on individual cpp files, but slows down iterating on header changes (and can take a lot of disk space for large changes). Dedicated PCH contains all includes scraped from the top of each cpp file, until a non-#include directive is encountered. Change 4223401 by Ben.Marsh UBT: Add an option to automatically enable edit and continue for files in the adaptive non-unity working set. E&C doesn't seem very useful for UE4 projects right now; compile time is comparable to regular build times, but it can take several minutes to apply code changes for large projects. Change 4223899 by Ben.Marsh UBT: Fix loading XML config files on Mono; Type.GetField(Name) does not seem to return values unless binding flags are specified. Change 4224637 by Ben.Marsh Add a "SupportedPrograms" field to plugin descriptors, which allows plugins to declare which plugins they support independently of individual modules. Programs now respect the "bEnabledByDefault" setting in plugins. Plugins that are compatible with a program now need to list that program in the SupportedPrograms list, and whitelist any modules that should load for that program. Change 4224710 by Ben.Marsh UBT: Don't add import libraries as final build products unless the target is being precompiled. Prevents the need for building them for leaf nodes in the action graph. Change 4224715 by Ben.Marsh UBT: Remove hack to allow Stats2.cpp to not follow IWYU convention. Change 4224726 by Ben.Marsh Remove commented out line. Change 4224903 by Ben.Marsh Fix non-unity compile error in Stats2.h. Change 4225051 by Ben.Marsh Back out changelist 4224710; causing CIS errors due to receipts not matching. Change 4225134 by Ben.Marsh Fixing non-unity errors. Change 4225203 by Ben.Marsh Another non-unity fix. Change 4225249 by Ben.Marsh Fix Linux dependencies being copied for the Windows editor; they can be added as requirements for the Linux target platform on Windows instead, so it respects the user's chosen platforms. #jira UE-62001 Change 4225512 by Ben.Marsh BuildGraph: Allow setting the target to build when using the <CsCompile> task. Change 4228815 by Ben.Marsh UBT: Always add the generated code directory to the list of include paths when generating project files. It may only be created after UHT has been run. Change 4228944 by Ben.Marsh UBT: Remove legacy CppCompileEnvironment and LinkEnvironment wrappers from TargetRules that were deprecated in 4.19. Change 4229028 by Ben.Marsh UBT: Fix editor targets with unique build environment having the wrong executable path in generated project files. Move move logic to configure target rules post-construction by the rules assembly to ensure it's valid. Change 4229065 by Ben.Marsh UBT: Move another target setting into the rules assembly. Change 4229105 by Ben.Marsh Fix BPT exception when generating project files. Change 4229311 by Ben.Marsh UBT: Store the module rules file location on the ModuleRules instance, as well as the plugin that it was created from. Also expose the plugin directory as a property on the ModuleRules instance. Change 4229421 by Ben.Marsh UBT: Consolidate functionality for UHT module setup in ExternalExecution.cs. Change 4229817 by Ben.Marsh UBT: Modules must now explicitly specify the path to the header used to generate a PCH if one is desired, rather than the header being determined automatically by attempting to parse the source code. Now that PCHs are force-included anyway, this removes a lot of dependencies inside UBT. Change 4229824 by Ben.Marsh UBT: Remove unused lists inside UEBuildModuleCPP.SourceFilesClass. Change 4229841 by Ben.Marsh UBT: Remove some legacy code from auto-detecting PCHs. Change 4230521 by Ben.Marsh UBT: Add utility functions to the log class to allow formatting errors and warnings in Visual Studio output format (eg. File(Line): warning: Message) Change 4230871 by Ben.Marsh UAT: Remove StreamUtilis utility class; there is a simpler way to implement the one place it's used. Change 4230882 by Ben.Marsh UAT: Add StreamUtils back into UAT, seems like it's still used there. Change 4230896 by Ben.Marsh UBT: Remove some redundant parameters from UEBuildModule/UEBuildModuleCPP/UEBuildModuleExternal constructors. Change 4231014 by Ben.Marsh WorkspaceTool: Include a dump of raw bytes when garbage is read from the P4 process, for diagnostic purposes. Change 4231032 by Ben.Marsh Fix CIS. Change 4231096 by Ben.Marsh Bump the FlatCPPIncludeDependencyCache version, to prevent errors trying to load old files. Change 4231446 by Ben.Marsh UBT: Added support for expanding UE-specific variables in include paths and library paths: $(EngineDir), $(ProjectDir), $(PluginDir), $(ModuleDir). Change 4231460 by Ben.Marsh Modules may now explicitly specify rpaths on Linux via the PublicRuntimeLibraryPaths and PrivateRuntimeLibraryPaths properties. Change 4233909 by Robert.Manuszewski PR #4779: Reason fails as the supplied variable is incorrect (Contributed by projectgheist) Change 4233910 by Ben.Marsh Enable PCHs on IOS. Reduces build time by ~25%. Change 4234176 by Ben.Marsh UBT: Add better messaging for modules that need to have a private PCH set. Now detects the likely PCH using the same method as legacy code and includes it as a suggestion. Change 4234193 by Ben.Marsh Add the Delete command to Perforce wrapper in DotNETUtilities. Change 4234688 by Ben.Marsh UBT: Simplify handling of installed/precompiled builds. Settings for whether a folder is installed/read-only or not is now stored on the RulesAssembly instance, allowing multiple things to be configured separately and stacked together (eg. engine/enterprise/project). RulesAssembly.IsReadOnly() allows determining if a flie can be modified or not and replaces many previous IsXXXInstalledCalls(), and traverses the chain of assemblies. Change 4234711 by Ben.Marsh UBT: Runtime dependencies can now be copied to output directories as part of the build. When adding a runtime dependency, an optional source location can be specified to copy from. Both the source and target paths can use variables can be used as part of the path, eg. $(OutputDir), $(ModuleDir), $(PluginDir). Example usage (from a .build.cs file): RuntimeDependencies.Add("$(OutputDir)/Foo.dll", "$(PluginDir)/Source/ThirdParty/Foo.dll", StagedFileType.NonUFS); Change 4234872 by Ben.Marsh Expose a flag for whether the engine is installed, to fix issues generating project files. Change 4234929 by Ben.Marsh Fix null reference generating receipts when UBT makefiles are active. Change 4235883 by Chad.Garyet Merging 4231245 to core Giving Coordinator its own sln. This should fix what 4158155 was supposed to. #jira UE-61955 Change 4236075 by Ben.Marsh CIS fix Change 4237066 by Robert.Manuszewski Fix for a potential crash when terminating the engine while it's being initialized #jira UE-60545 Change 4237078 by Robert.Manuszewski The engine will no longer be resetting all linkers causing massive load times when renaming the world package when entering Play In Editor Change 4237116 by Ben.Marsh Rewrite some Windows utility functions to support paths longer than MAX_PATH. Change 4237158 by Ben.Marsh Add const TCHAR* overloads of FString::RemoveFromStart() and FString::RemoveFromEnd(). Change 4237159 by Ben.Marsh Fix FWindowsPlatformFile::GetFilenameOnDisk() support for paths longer than MAX_PATH, and simplify some of the other long path functions to avoid copying string buffers. Change 4239050 by Ben.Marsh Missing file Change 4239318 by Ben.Marsh Linux CIS fix. Change 4239685 by Ben.Marsh Static analysis CIS fix. Change 4240800 by Ben.Marsh WorkspaceTool: Include the full command line in the log for any P4 commands. Change 4240903 by Ben.Marsh PR #4909: Update copyright notices to 2018 (Contributed by projectgheist) Change 4241025 by Ben.Marsh UBT: Exclude mobile pipeline caches from generated project files. Causes huge slowdown when using 'Find in Files' through the IDE. Change 4241770 by Ben.Marsh UBT: Include action number in parallel executor output. #jira UE-62032 Change 4243469 by Ben.Marsh TBA: Merge FAnnotatedStructuredArchiveFormatter with FStructuredArchiveFormatter. Any functions that are only implemented for text archives now have a _TextOnly suffix, and are exposed through the FStructuredArchive interface. Change 4245723 by Robert.Manuszewski Fixing another creash when terminating the engine while initializing. #jira UE-60545 Change 4245862 by Steve.Robb VectorLoadFloat2(Ptr) added, which loads { Ptr[0], Ptr[1], Ptr[0], Ptr[1] } into a VectorRegister. Change 4246412 by Robert.Manuszewski The warning 'Calling StaticLoadObject during PostLoad may result in hitches during streaming' will now also report the object which had the PostLoad called on it when StaticLoadObject call happened. Change 4246612 by Ben.Marsh UBT: Fix spelling of "Intellisense". Change 4249454 by Robert.Manuszewski Added extra checks to catch scenarios where the EDL Precache Buffer is flushed before a package header is fully read Change 4249513 by Robert.Manuszewski Made sure the Async Loading Thread doesn't continue running after creating new async packages when garbage collector wants to run on the game thread Change 4255207 by Ben.Marsh UGS: Add additional logging whenever a P4 command fails, and when the user is logged out. Change 4255288 by Ben.Marsh PR #4921: Honor ModuleRules' bEnableExceptions flag when creating precompiled h. (Contributed by surakin) Change 4256422 by Ben.Marsh UBT: Add an error if a module referenced by a plugin descriptor doesn't exist. Change 4257385 by Robert.Manuszewski Creating new objects from within ForEachObjectWithOuter will now result in a fatal error as it's unsafe to change internal UObject hash tables when iterating over them. Change 4257454 by Robert.Manuszewski Added the option to filter clusters listed with gc.ListClusters by objects within them. Usage: gc.ListClusters Hierachy With=ObjectName1,ObjectName2... Change 4257526 by Robert.Manuszewski It's now possible to filter clusters that get logged with verbose cluster logging enabled (UE_GCCLUSTER_VERBOSE_LOGGING=1) by objects within them by specifying -DumpClustersWithObjects=ObjectName1,ObjectName2 in the command line Change 4257822 by Ben.Marsh Fixes for PlatformShowcase compile errors. Change 4258771 by Ben.Marsh UBT: Fix project files not being generated for foreign projects when creating .stub files. #jira UE-62462 Change 4258790 by Ben.Marsh UBT: Clean up the logic around generating project files before creating a stub IPA, so that it fails loudly if project files do not exist, and can accept target names not matching project names. Change 4259276 by Ben.Marsh UBT: Make it an error if a framework doesn't exist, rather than failing silently. Also remove some remote toolchain stuff that's no longer necessary. Change 4259280 by Ben.Marsh UBT: Fix embedded framework zips not being uploaded for plugins. #jira UE-62485 Change 4260236 by Ben.Marsh UBT: Fix path to generated engine project file. Change 4260334 by Ben.Marsh UGS: Fix custom build steps dialog inadvertantly modifying config file settings in-place. Change 4260361 by Ben.Marsh UGS: Allow for p4 login commands to fail, even though the user is logged in (due to a bad connection, etc...) Change 4260559 by Ben.Marsh UGS: Update version. Change 4261160 by Robert.Manuszewski MediaPlaylist will now be added to root set if the owning MediaPlayer is in the disregard for GC set (fixes GC assumption violation crash) #jira UE-62495 Change 4261421 by Ben.Marsh Force-sync files for building documentation, to fix issues with files not being updated. #jira UE-62413 Change 4261425 by Ben.Marsh UBT: Remove some leftover functions for handling the remote toolchain. Change 4261530 by Ben.Marsh UBT: Speculative fix (and better error reporting) for IOS mobile provision not being found in CIS. Change 4261611 by Ben.Marsh UBT: Downgrade warning to a log message, since it appears when generating project files. Change 4261710 by Ben.Marsh Remove assert that GLogConsole is set; it won't be for command line utilities that don't depend on ApplicationCore. #jira UE-62545 Change 4261831 by Ben.Marsh Fix compile errors due to missing include path when hot-reloading a module from the editor. There are not necessarily source files to compile when -modulewithsuffix is specified on the command line, which was results in GeneratedCodeWildcard not being set. #jira UE-62463, UE-62384 Change 4262723 by Ben.Marsh Whitelist plugins that need to be loaded by UFE. #jira UE-62564 Change 4265444 by Ben.Marsh Fix incorrect executable name for DebugGame configurations in Xcode. #jira UE-62574 Change 4265892 by Ben.Marsh Fix incremental compile failures due to dependency checking for unity files. CachedIncludePaths was not correctly being set on file items, so dependencies were being ignored. #jira UE-62575, UE-62603, UE-62597 Change 4266019 by Josh.Adams - Fixed the CopyAction for runtime dependencies that need to be copied to different location, on non-XGE Change 4266264 by Ben.Marsh Remove override for the __IPHONE_OS_VERSION_MIN_REQUIRED macro on TVOS. This macro is already defined by system headers (in <AvailabilityInternal.h>). Now that we support PCHs on IOS and TVOS, manually defining this macro results in it being defined three times (once for the PCH, once by AvailabilityInternal.h, and once by the force-included list of definitions for the source file being built). The errors for redefining the macro in AvailabilityInternal.h are suppressed due to it being a system header, but the error for redefining it for the source file being compiled are not. #jira UE-62578 Change 4266273 by Ben.Marsh Fixes incremental build failure when compile arguments for PCH have changed on IOS/TVOS. Compile action needs to have a dependency on PCH build action. Change 4266614 by Graeme.Thornton Fix crash when cooking nativized blueprints due to removal of child cooker system. Change 4266763 by Ben.Marsh Always build UnrealPak when building client targets. The ProjectParams.Pak option is not reliable, because it can be forced on later by the target platform. #jira UE-62584 Change 4267985 by Robert.Manuszewski When iterating with ForEachObjectWithouter, don't lock the entire has table but only the hash bucket that is currently being iterated #jira UE-62600 Change 4268558 by Robert.Manuszewski PurgeLegacyBlueprints will no longer be called from within ForEachObjectWithOuter is it renames objects that reside in hash tables that are being iterated over which may lead to undefined behavior. #jira UE-62600 Change 4269011 by Chad.Garyet - Fixing Wildcard match issue, the change to ugsapi sends projects as //Depot/Stream instead of //Depot/Stream/ Wildcard match was only substringing to 3 chars. - Checking in the change a while back that increases the number of queried jobs up to 432 based on some maths from Bob about how many builds we want to grab Published to ugsapi server 8/8/17 #jira none Change 4270788 by Ben.Marsh Fix IOS provisioning data being using when remote compiling on TVOS. #jira UE-62705 Change 4271916 by Ben.Marsh Tag the XGEControlWorker executable as a build product after compiling SCW, to make sure it's included in the UGS zip file. Change 4271934 by Ben.Marsh Upload all static libraries in plugin folders as part of remote builds. #jira UE-62694 Change 4273368 by Ben.Marsh Fix Slate dependencies not being enumerated, and rules assembly not being rebuilt when building remotely. #jira UE-62705 Change 4274049 by Ben.Marsh Always parse the team UUID out of the mobile provision when doing a remote compile. The provision installed on the remote Mac (and selected for signing) may be different. #jira UE-62751 Change 4274823 by Ben.Marsh Add the -VersionCookedContent argument to disable the -unversioned parameter on the cooker command line. Change 4275838 by Ben.Marsh Fix BuildVersion string not being passed through from <SetVersion> task. Also add a -BuildVersion command line argument to UBT to override it for a particular build. Change 4275913 by Ben.Marsh Add a dummy exported symbol to the XGEController module, to fix build errors due to missing .lib file when it's built with WITH_XGE_CONTROLLER = 0. Change 4284161 by Ben.Marsh Allow mirroring Oodle files to remote Mac. Change 4074774 by Steve.Robb Vast simplification of TFunction, making it smaller in footprint, easier to follow and extend, and more correct. TUniqueFunction added, which is a move-only TFunction which can hold move-only functors. Fix for UWidgetBlueprint::ForEachSourceWidget() which should never have compiled but did. FFunctionGraphTask and TFuture<> updated to use TUniqueFunction to make them more general. TArray::HeapPop() made to work with move-only types. Change 4082591 by Ben.Marsh Move the Log class from UBT to DotNetUtilities. Change 4083236 by Ben.Marsh Add a Log.WriteException() method to dump an exception message to the console (and write the exception trace to the log) Change 4084107 by Ben.Marsh UAT: Remove the unused -SkipHeader argument to UE4Build. Change 4089771 by Steve.Robb GitHub #4743 : modified VirtualAlloc function flag https://blogs.msdn.microsoft.com/oldnewthing/20151008-00/?p=91411 Change 4091456 by Steve.Robb Unification of all platforms' FMath::CountTrailingZeros() and FMath::CountLeadingZeros() for both 32-bit and 64-bit. Change 4156437 by Ben.Marsh Lots and lots of fixes compiling for Clang on Windows. Editor now compiles cleanly without warnings, but crashes on startup due to error in intrinsics test. Disabling that runs further, but crashes accessing freed memory. Switching to the ANSI allocator runs further, but crashes in Slate after the splash screen and before the editor window opens. // TODO! * Switching between Clang/ICL/VS2015/VS2017 is now supported through the same mechanism as switching Visual Studio versions, without requiring any source level changes. To use Clang, set WindowsPlatform.Compiler = WindowsCompiler.Clang from a .target.cs file, or set <WindowsPlatform><Compiler>Clang</Compiler></WindowsPlatform> from BuildConfiguration.xml. To pick a specific toolchain version, set WindowsPlatform.CompilerVersion. * Clang is now supported through AutoSDKs; will be added to CIS. * The Samples/Sandbox/Clang project forces Clang to be used from its target.cs file, and allows easily building all editor modules and plugins with Clang on Windows. * UnrealMathSSE intrinsics have been re-enabled for Clang due to missing functions from the UnrealMathFPU implementation, but causes failure in tests at startup. * SSE4_CRC32() is disabled in D3D12Pipelinestate.cpp, since intrinsics are only allowed if enabled for the whole target (rather than being used in specific functions due to runtime checks) Change 4157389 by Ben.Marsh Few more fixes for compiling the editor with Clang. Change 4183911 by Ben.Marsh Fixes to support incremental linking on Windows. Does not seem to have any net benefit right now; may improve once minimal rebuild is enabled. * Incremental linking no longer forces PDB files to be enabled for source files. * Actions can specify specific files to be deleted before each build. Code to forcibly delete PDB files has been moved to the MSVC toolchain. * Unused libraries produced by the cross-referenced link are no longer added as build products, since (a) deleting them breaks dependency checking for incremental linking and causes a full link, and (b) not deleting them breaks UBT dependency checking and causes actions to be run over and over again. * Icon update is disabled for Windows when incremental linking is enabled. * Removed rarely-used setting to always delete produced items before each build. Change 4184311 by Ben.Marsh UGS: Added a dialog which shows all the required platform SDKs for a branch, linked from the status panel in UGS. The llist is configured via the UGS config file submitted to Engine/Programs/UnrealGameSync/UnrealGameSync.ini (and may be overridden by the project config file if necessary): [Default] ; Set this to a network share which contains the SDK installers for your site SdkInstallerDir= ; All the required SDKs for the current version of the engine +SdkInfo=(Category="Android", Description="NDK r21", Browse="$(SdkInstallerDir)\\Android") +SdkInfo=(Category="Windows", Description="Visual Studio 2017") +SdkInfo=(Category="Windows", Description="Visual C++ Toolchain 14.13.26128") +SdkInfo=(Category="Windows", Description="Windows SDK 10.0.16299.0") Similar entries for console platforms are added in console subdirectories. Each entry may contain an Install="Foo.exe" and/or Browse="C:\Foo" style attribute, specifying the path to an installer to run or directory to open in explorer respectively. The SdkInstallerDir setting is used as a base directory for the default installers, seen above for Android. Licensees may override this with a network path specific to the site that UGS is being deployed to (either in this file, in a project specific config file, or in a Engine/Programs/UnrealGameSync/NotForLicensees/UnrealGameSync.ini file). Change 4200452 by Ben.Marsh UBT: Change DebugGame configurations to output a separate executable rather than requiring a -Debug argument at runtime. Previous behavior was a common source of errors. Engine modules are still shared between Development and DebugGame, but the launch module sets a flag in Core on startup indicating the game configuration. Change 4206189 by Ben.Marsh UBT: Simplify logic for precompiling binaries. * Target no longer has separate list of "precompile only" binaries or modules. New -AllModules option allows adding every module to a target, which can be used with -Precompile and -NoLink to precompile object files for monolithic builds. * Precompiled file lists have been removed from target receipts. * The manifest now includes all generated headers and precompiled files when run with the -Precompile option. * Separate -DependencyList=Foo.txt has been added to write a list of all dependencies required to use precompiled binaries. This file list can be read using the <Tag> task in buildgraph. Change 4215466 by Ben.Marsh UBT: Remove indirect calls to determine extensions for object files and precompiled headers. The toolchain knows the correct convention for the platform. Change 4215975 by Ben.Marsh UBT: Remove telemetry code. This has never proved useful for analyzing performance due to the number of incidental factors that affect build times (eg. number of files being compiled). Change 4220154 by Ben.Marsh Move text-only implementations of FOutputDeviceError back into Core, so we can build command-line applications that don't depend on ApplicationCore. Change 4224708 by Ben.Marsh Add a bCompileAgainstApplicationCore setting to the target rules, which allows compiling out references to the ApplicationCore module (which should only be necessary for applications with a GUI). Removed ApplicationCore from several engine tools and utilities. Change 4224958 by Ben.Marsh Remove CoreMinimal.h includes from Core. Change 4229059 by Ben.Marsh UBT: Remove the UEBuildPlatform.ShouldNotBuildEditor() hook for target platforms. We shouldn't be modifying a target's build environment to disable the editor; it is invalid to build the editor for these target platforms at all, and this is already enforced by the GetSupportedPlatforms() function. Change 4230508 by Ben.Marsh Fixup precompiled header setting for samples and games. Change 4231457 by Ben.Marsh Fix exceptions in log messages having trailing newlines. Change 4232406 by Ben.Marsh UBT: Always force include a PCH for generated code if there's one set; the code may depend on it to compile. Change 4234177 by Ben.Marsh Set up private PCH files everywhere that previously used them. Change 4235973 by Ben.Marsh Change FPlatformMisc::GetEnvironmentVariable() to return an FString() rather than requiring a fixed size buffer to be passed in. Removes references to MAX_PATH. Change 4238842 by Ben.Marsh Add support for paths longer than MAX_PATH in the editor. Requires Windows 10 version 1607, and the functionality to be enabled via a registry key or group policy (see https://docs.microsoft.com/en-us/windows/desktop/FileIO/naming-a-file). Only a subset of Win32 functions support long paths (executables can only be started from paths shorter than MAX_PATH, for example). * Added a FPlatformMisc::GetMaxPathLength() function to return the maximum length of a path on the current system. On Windows, this returns a different value for systems with long paths enabled to those without. * The MAX_PATH define is no longer set by non-Windows platforms. Instead, there is a MAC_MAX_PATH, UNIX_MAX_PATH, etc... for any platform-specific code that still relies on the previous macro. * The MAX_UNREAL_FILENAME_LENGTH macro has been renamed to MAX_UNREAL_FILENAME_LENGTH_DEPRECATED * The PLATFORM_MAX_FILEPATH_LENGTH macro has been renamed to PLATFORM_MAX_FILEPATH_LENGTH_DEPRECATED. * Removed custom resource files for programs, since they are just copies of the base UE4 one (which is used by default anyway). The base UE4 manifest declares support for long paths. * Fix 512 character maximum length on editor commands. 260 character limit remains in place for cooking at the moment (see ContentBrowserUtils.h), until C# staging code supports long paths. Change 4255042 by Ben.Marsh UBT: Remote compilation now uploads the entire workspace to the remote Mac and executes a separate remote instance of UBT rather than synchronizing individual actions. This makes the remote compile codepath much simpler, and removes a lot of special cases that exist to support it previously. The list of files to be transferred to the remote are listed as rsync filter rules in Engine/Build/Rsync/RsyncEngine.txt and RsyncProject.txt, which are applied to the root engine directory and project directory respectively. Projects that need to customize which files are uploaded can add their own <ProjectDir>/Build/Rsync/RsyncProject.txt file, which will be included in the filter before the default version. Change 4260567 by Ben.Marsh UAT: Rename CommandUtils.Log to CommandUtils.LogInformation, to avoid conflicts with the underlying Tools.DotNETCommon.Log class. #rb none [CL 4285673 by Ben Marsh in Main branch]
2018-08-14 18:32:34 -04:00
LogInformation("Starting Extra Client....");
Copying //UE4/Dev-Platform to //UE4/Dev-Main (Source: //UE4/Dev-Platform @ 3120366) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 2714591 on 2015/10/02 by Ben.Marsh Initial branch of files from Engine-Main (//UE4/Engine-Main) to Dev-Platform (//UE4/Dev-Platform) Change 2916715 on 2016/03/21 by Daniel.Lamb First pass at splitting out build cook run into into seperate scripts. Change 2948322 on 2016/04/19 by Nick.Shin update libwebsockets to v1.7.4 part 4 of 4 - doing this in stages for tracking purposes #jira UEPLAT-1246 - Update libWebsockets #jira UEPLAT-1221 - update websocket library #jira UEPLAT-1204 - Rebuild libwebsockets with SSL Change 2970016 on 2016/05/07 by Nick.Shin undo all of the following upgrades: - zlib - openssl - libcurl - libwebsockets and reset webrtc #jira UE-30298 - Fortnite and Orion crash on login Change 3059693 on 2016/07/21 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3061151 on 2016/07/22 by Niklas.Smedberg Fast ASTC texture compression, using ISPC. #jira UE-32308 Change 3061428 on 2016/07/22 by Peter.Sauerbrei Back out changelist 3061151 as it wasn't approved for submission Change 3061970 on 2016/07/22 by Steve.Cano Adding AdMob interstitital ad support for Android, including Blueprint functions #jira UE-33286 #ue4 #android Change 3062160 on 2016/07/22 by Mark.Satterthwaite Fix the fix for handling RHISetStreamSource overriding stride on Metal - not all MTLVertexDescriptors are equally hashable so do this ourselves. #jira UE-33355 Change 3062770 on 2016/07/24 by Brent.Pease UE-32397 Error Message displays as Unknown Error when failing to supply a Remote Build server for ios on Windows Change 3063227 on 2016/07/25 by Dmitry.Rekman Update hlslcc cross-compile after libc++ change. Change 3063314 on 2016/07/25 by Jeff.Campeau Xbox One DLL loading Receipts can be read back by request for target info Change 3063329 on 2016/07/25 by Mark.Satterthwaite CL #3046743 was breaking other samples in unexpected ways after a recent Main merge, so make a Metal-specific change to the shader instead and amend the MetalBackend to better match HLSL's handling of NaN/inf with common single-precision float intrinsics. This is sufficient to fix the AtmosphericFog and the recent regressions. #jira UE-33600 #jira UE-33028 #jira UE-27879 #jira UE-25802 Change 3063492 on 2016/07/25 by Brent.Pease UE-23846 - iOS Movie Player can't handle videos at resolutions that aren't multiples of 16 UE-33200 - A movie isn't played on iOS occasionally. Change 3063729 on 2016/07/25 by Dmitry.Rekman Linux: enable XGE on all platforms. #tests Cross-compiled a number of Linux targets on Windows. Change 3063732 on 2016/07/25 by Dmitry.Rekman Fixed formatting (spaces->tabs) in previous change. Change 3063750 on 2016/07/25 by Daniel.Lamb Added code to dump the cook modification delegate loads to log. Fixed the memory usage output log. #test cook paragon. Change 3063804 on 2016/07/25 by Daniel.Lamb Added cookpartialgc additional commandline option to uat. #test UFE Change 3064008 on 2016/07/25 by Mark.Satterthwaite For non-shipping builds conditionally bind a default uniform buffer in Metal and report an error if the slot was unbound, if our validation layer is enabled attempt to report the shader source in question. This relies on the shader compiler providing accurate information about uniform buffer bindings and won't fix all occurances of bad uniform usage (if a buffer is bound but too short the result will be GPU restarts or an error in Apple's validation layer - we can't detect this case) but will help debug the typical error of leaving an active slot unbound. #jira FORT-27685 Change 3064141 on 2016/07/25 by Jeff.Campeau Rebuild vpxmd.lib with delayed codegen disabled (fixes linker warning building Win64). Change 3065024 on 2016/07/26 by Nick.Shin Change filetype remove exclusive check out bit requested by or.coheni & nick.penwarden Change 3065274 on 2016/07/26 by Jonathan.Fitzpatrick DirectoriesToAlwaysStageAsUFS now properly filters out *.uasset and *.umap files This prevents the bug where cooked assets get trampled by staging their uncooked version on top of them during the UFS step Added a file filter to DirectoriesToAlwaysStageAsUFS for uasset and umap. Change 3066338 on 2016/07/27 by Mark.Satterthwaite Handle releasing an SRV/UAV & the source object within a single Metal command-buffer. #jira UE-33779 Change 3066789 on 2016/07/27 by Daniel.Lamb Realtime mode does not save any packages anymore unless they are ready. #test cookontheside, cookbythebook shooter game Change 3066847 on 2016/07/27 by Jeff.Campeau Fix define #2634 #jira UE-33813 Change 3068868 on 2016/07/28 by Mark.Satterthwaite Extend hlslcc's handling of switch-statements to allow implict casts from scalar bool, half & float as HLSL itself permits while also making sure it errors if the expression input is not scalar. This fixes shader compile errors in UT. Change 3070040 on 2016/07/29 by Dmitry.Rekman Delete Nadzorca. Change 3070947 on 2016/07/29 by Jeff.Campeau Perforce C++ API 2015.2 (includes debug libraries) Change 3073707 on 2016/08/02 by Daniel.Lamb Derived data cache commandlet runs resolve string asset references to load any string asset refereced packages from the map. Also process async results from shaders being compiled so they can have their memory resources released. #test DerivedDataCache commandlet shootergame. Change 3076613 on 2016/08/03 by Brent.Pease + UnrealTargetConfiguration is now passed into deploy and package methods + The UIRequiredDeviceCapabilities plist key now only considers the architectures from the corresponding target configuration (shipping or development) Change 3076668 on 2016/08/03 by Brent.Pease Back out changelist 3076613 Change 3077157 on 2016/08/04 by Daniel.Lamb Fixed up DLC staging so that it stages to the proper mount point. Fixes up include engine content in DLC staging paths. #test Made up shooter game DLC Change 3077191 on 2016/08/04 by Daniel.Lamb More smartly process async shader compilation if we are waiting for it. #test cook on the side shooter game cook by the book shooter game. Change 3077412 on 2016/08/04 by Mark.Satterthwaite Fix "iOS Metal-based build crashes at launch with sub-levels": - Slate should not bind the null RHI texture from an unitialised texture atlas - atlases only have a valid texture pointer once an entry has been added to them and in the template projects an empty sub-level doesn't add anything. - To prevent this kind of bug resurfacing and being so hard to track down add Metal shader binding validation to our validation layer as Apple's is incomplete on iOS and won't warn us about nil texture usage which causes these GPU restarts. This requires reworking our vertex declaration handling to be more efficient so that we can cache the pipeline reflection data as well as the pipeline objects. - Fix validation error of texture reallocation on loading template projects under Metal. #jira UE-30847 Change 3077958 on 2016/08/04 by Brent.Pease + UnrealTargetConfiguration is now passed into deploy and package methods + The UIRequiredDeviceCapabilities plist key now only considers the architectures from the corresponding target configuration (shipping or development) Change 3079503 on 2016/08/05 by Mark.Satterthwaite Initialise more variable types to 0 in Metal shaders to workaround Xcode 8 toolchain no longer doing this for us for "threadgroup shared" variables. Everything but structs and atomic's will now be initialised. #jira UE-33856 Change 3079737 on 2016/08/05 by Jeff.Campeau Add support for delay load DLLs on Xbox One Turn off warnging for missing PDBs to match VCToolchain.cs Change 3081005 on 2016/08/08 by Mark.Satterthwaite Fix-up Metal device name on AMD for macOS 10.12 which reports it correctly and enable tiled reflections on Intel from macOS 10.12 too as they now work. Change 3081557 on 2016/08/08 by Daniel.Lamb File-> Package saves all packages before starting packaging. #test File package first person template Change 3082215 on 2016/08/09 by Lee.Clark PS4 - Added 4k profile Change 3082412 on 2016/08/09 by Daniel.Lamb Fixed cook on the fly server not handling cook requests. #test Cook on the fly shooter game. Change 3082955 on 2016/08/09 by Dmitry.Rekman Linux: convert existing Strcat() uses to Strncat(). - Strcat() does not check destination size so can silently corrupt memory. While this was not observed, this conversion removes this concern altogether. Change 3083772 on 2016/08/10 by Luke.Thatcher [PLATFORM] [PS4] [+] Checking in PS4CrashHandler files so we have a copy in Perforce rather than just on the server. - Taken from \\devweb-02 and removed all the unused files/dependencies. - Created a publish profile pointing to \\devweb-02\Sites\PS4Services\PS4CrashHandlerDev so I'm not writing over the existing deployed crash handler. - Moved all code in the Page_Load event to inside the check for the HTTP method (POST) otherwise GET'ing the page from a browser will generate crash folders that hang around forever. Change 3085450 on 2016/08/11 by Lee.Clark PS4 - Fix mediaplayer pipeline allocation Change 3086360 on 2016/08/11 by Michael.Trepka Fixed a non-unity build error in Mac UnrealFrontend Change 3087224 on 2016/08/12 by Luke.Thatcher [PLATFORM] [PS4] [~] Refactor PS4 Crash Handler site - Removed CoreDumpHandler. Processing dump files is handled directly by an async thread within the aspx process. - Separated configuration values into their own class. Currently set to output to a testing directory, rather than the actual crash reporter landing zone. - Added a debug upload page to allow manual submission of .orbisdmp/.txt settings files, accessible by GET'ing Default.aspx. - Added logging. Logs self-delete after 30 days. Testing required before we switch to the new system. #jira UE-34504 #jira OR-26886 Change 3087626 on 2016/08/12 by Dmitry.Rekman PR #2689: Fix copying/duplicating failing on Linux (UE-34586). - Contributed by Web-eWorks. Change 3087991 on 2016/08/12 by Mark.Satterthwaite Initial AVFoundation implementation of Media Framework for Mac, iOS & tvOS. - Video playback occurs via AVPlayerItemVideoOutput's attached to the AVPlayerItem's output. This means gathering video samples is trivial. - Metal texture updates occur by wrapping the texture object provided by AVF - for Mac this is simple as it can bind to the IOSurface directly, for iOS/tvOS we have to create a CVMetalTextureCache and allocate our texture from there. - OpenGL and OpenGLES currently have to lock the pixel buffer and upload to a texture the old fashioned way - this should be revisited when there is time. - Subtitles/Captions are captured using AVPlayerItemLegibleOutput which also connects to the AVPlayerItem's output. - On Mac audio samples are returned by manually reading from the stream using an AVAssetReaderTrackOutput, including manual seeking and synching. - On iOS/tvOS the audio is played directly by AVPlayer because the IOSAudio system can't handle procedural buffers - otherwise it could reuse the Mac code. - AVFoundation does not support AVI - that's an obsolete Microsoft/Windows file-format. - Only 'file://' URLs are supported - streaming would require a totally different audio solution (using MTAudioProcessingTap) and has many more edge and failure cases that would need to be handled. #jira UE-34315 Change 3088790 on 2016/08/15 by Luke.Thatcher [PLATFORM] [PS4] [~] Hook new PS4 crash handler up to the crash reporter website. - Removed indentation from generated crash context XML file. The crash reporter process does manual XML parsing which doesn't correctly handle whitespace at the start of lines. - Switched the final output folder to match the one the crash reporter process is watching. - Hide upload form on a config variable. #jira UE-34504 #jira OR-26886 Change 3089060 on 2016/08/15 by Luke.Thatcher [PLATFORM] [PS4] [!] Change PS4 crash handler log file extension to ".ps4chlog", otherwise the crash reporter site attaches the wrong log file to the crash report. Allowed showing of debug upload form via "Default.aspx?showform=1" query string. #jira UE-34504 #jira OR-26886 Change 3089089 on 2016/08/15 by Mark.Satterthwaite Duplicated changes to AppleMovieStreamer from CL #3088149. #jira UE-34315 Change 3089460 on 2016/08/15 by Mark.Satterthwaite Duplicate CL #3080971: Workaround a macOS 10.12 Beta bug on some Metal drivers that can't initialise temporary/local variable arrays, only those that are marked threadgroup shared. #jira UE-34355 Change 3089465 on 2016/08/15 by Mark.Satterthwaite For Metal shader translation retain more precision for float constants -1.0f >< 1.0f by emitting them in scientific notation - prevents Hammersley constant amongst others from being flushed to 0. Change 3089902 on 2016/08/15 by Daniel.Lamb Changed the next compiling ID to the correct compiling ID. #test Cook Change 3089903 on 2016/08/15 by Daniel.Lamb Cooker monitors config useage during cook and uses those settings to invalidate cooked content instead of all config settings. Change 3090114 on 2016/08/16 by Luke.Thatcher [PLATFORM] [PS4] [~] Minor change to PS4 settings text on crash handler site. Change 3090949 on 2016/08/16 by Nick.Shin WebSocketNetDriver crash fix filled in missing chunk of code that calls PacketHandler's "packet modifiers" #jira UE-25492 HTML5 Client cannot connect to Windows Server #jira UE-30880 WinServer crashes when NetDriver is set to WebSocket and Client attempts to connect via websocket #code.review john.pollard john.barrett Change 3091265 on 2016/08/16 by Brent.Pease Add IOS support to HarfBuzz Change 3091267 on 2016/08/16 by Brent.Pease Add references to fix mono build Change 3091291 on 2016/08/16 by Nick.Shin CIS warning fix #jira UE-25492 HTML5 Client cannot connect to Windows Server #jira UE-30880 WinServer crashes when NetDriver is set to WebSocket and Client attempts to connect via websocket Change 3091781 on 2016/08/17 by Joe.Barnes UE-33640: Exposed UPrimitiveComponent::IsAnyRigidBodyAwake() to Blueprints. Change 3092687 on 2016/08/17 by Daniel.Lamb Added support for using binned allocator in cooker instead of tbb. #test Cook shootergame. Change 3093867 on 2016/08/18 by Mark.Satterthwaite Use a read/write mutex to protect access to Metal's internal shader pipeline caches so that parallel threads can progress in the common case where new shaders are not being compiled. Change 3093950 on 2016/08/18 by Mark.Satterthwaite Change the Mac GPU identification code to cope with AMD's new naming scheme on 10.12. Change 3093951 on 2016/08/18 by Mark.Satterthwaite More SCW threads on Mac - they work now. Change 3093960 on 2016/08/18 by Mark.Satterthwaite Increase the default number of command-buffers on Mac because bigger games overflow the current limit of 64 per queue. Change 3096493 on 2016/08/22 by Jeff.Campeau Use Xbox version of DirectX include. Change 3097509 on 2016/08/23 by Luke.Thatcher [PLATFORM] [PS4] [+] Refactor PS4 Symbol Publish - Moved the SymStore task from Win.Automation to BuildGraph.Automation, and made it more generic. - The specifics of uploading symbols are now implemented in the platform tool chain, alongside StripSymbols(). - Re-generated the build graph schema file. - Removed the old PS4 symbols upload path in the package step. Modified OrionBuild.xml to publish symbols for all PS4 dev, test and shipping config builds of OrionClient. Change 3097635 on 2016/08/23 by Luke.Thatcher [PLATFORM] [PS4] [+] Refactor Age Symbols task in UAT. - Moved the AgeStore task from Win.Automation to BuildGraph.Automation and made it more generic. - Symbol server directory structure is now defined by the platform tool chain, which the common task uses to clean out old symbols. - Added a "filter" parameter to prevent age tasks deleting symbols from unrelated builds in shared symbol servers. Modified OrionBuild.xml to age both the Windows and PS4 symbol stores. Change 3097713 on 2016/08/23 by Luke.Thatcher [PLATFORM] [PS4] [+] Enable new PS4 crash handler server - Created live deployment profile and applied the required config file changes. Change 3099214 on 2016/08/24 by Luke.Thatcher [PLATFORM] [PS4] [!] Fix compile error in PS4 tool chain. For some reason, this only breaks ocassionally. Maybe we're alternating between the 2013 and 2015 C# compilers depending on what initiates the build (e.g. Visual Studio vs GenerateProjectFiles)? Change 3099222 on 2016/08/24 by Luke.Thatcher [PLATFORM] [PS4] [+] Added PS4 support for FPlatformMisc::MessageBoxExt using the MsgDialog library. - Note, only one and two button message dialogs are supported (limitation of MsgDialog). Change 3099260 on 2016/08/24 by Luke.Thatcher [PLATFORM] [PS4] [~] Better PS4 exit function. Calls quick_exit instead of abort when we've not asserted. Allows for a "cleaner" forced exit without generating a crash dump. Change 3101192 on 2016/08/25 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3101944 on 2016/08/25 by Daniel.Lamb Ask to save the current level when we are using launch on. Change 3102036 on 2016/08/25 by Nick.Shin check for minimum expected size upon data received from network #jira UE-13657 - HTML5 plugin OnRawRecieve overflow Change 3102115 on 2016/08/25 by Brent.Pease - Fix small errors that probably only show up in the mac mono build #code.review peter.sauerbrei Change 3102747 on 2016/08/26 by Jeremiah.Waldron Re-submitting OnlineSubsystemGameCircle with TPS permission for Amazon SDK - Also fixed the plugin to remove any related files from the final package when IAP is disabled or GameCircle support itself is disabled with the plugin still enabled - Added support for new AlreadyOwned IAP response code as well which is already used for GooglePlay and IOS Change 3102900 on 2016/08/26 by Nick.Shin since last checkin (CL: 2981945) - prints are crashing the browser - this change will allow browser to print the details via console.log() #jira UE-26047 - HTML5 HTTP Response Headers not implemented Change 3103130 on 2016/08/26 by Brent.Pease UE-24679 - Enable the ability to change ports for a firewall to pass them through rsync Change 3103225 on 2016/08/26 by Daniel.Lamb Fixed issue with warning which would cause crash. Change 3103425 on 2016/08/26 by Dmitry.Rekman Enable offscreen GL rendering without X. - Added new video subsystem to SDL that is uses EGL to initialize the context. - Most windoing functions stubbed. - Also added a new test case to TestPAL for easier debugging. Change 3104743 on 2016/08/29 by Brent.Pease Support remote offline metal shader compilation Change 3105051 on 2016/08/29 by Brent.Pease UE-2382 - TASK: MobleMVP: iOS: Add ability to view iOS device console output in the editor UFE - IOS Automation will now create a thread to collect the console logs from the device and send them to C# Console output while the app is running on device - Made ProcessResult an interface (IProcessResult) which ProcessResult implements. This allows platforms to provide their own implementation if needed. - Moved the RunLoop related parts of CoreFoundation into MobileDevice.cs Change 3105053 on 2016/08/29 by Brent.Pease - IOS dll's as part of the last check-in Change 3106853 on 2016/08/30 by Jeff.Campeau Implement FD3D11DynamicRHI::RHICreateComputeFence to prevent memory overwrite Change 3107361 on 2016/08/30 by Dmitry.Rekman Renderer: changes to allow postproc delegates. Change 3107362 on 2016/08/30 by Dmitry.Rekman Plugin with a CUDA postproc example. - Linux version only. Runs under a headless GL too (without X). - Disabled during cross-compilation, can be compiled natively only. - CUDA kernel should be compiled separately, CMakefile with compilation attached (can be used to generate VStudio projects as well). - To test the output, run under the debugger, interrupt and set global variable GSaveTheOutput to 50 (this will write out kernel output buffer 50 times as .bmp files into working directory). Change 3107913 on 2016/08/31 by Daniel.Lamb Fixed loading of cooked content in the editor. Change 3107916 on 2016/08/31 by Daniel.Lamb Added error case when shader compilation fails to notify shader. #test Cook shooter game. Change 3108080 on 2016/08/31 by Josh.Adams - Fixed PS4Automation compile errors Change 3109077 on 2016/08/31 by Brent.Pease Fix C# debug builds by specifying x64 and add reference to MobileDeviceInterface Change 3110086 on 2016/09/01 by Dmitry.Rekman Fix race condition in PThread runnable (UE-35074). - Instead of relying on busy-wait, join the threads. This prevents race between PostRun() (executed in the context of the thread) and FPThreadRunnableThread() destructor (see UE-34909). - Do not use an invalid value for pthread_t, since there's none. Change 3110172 on 2016/09/01 by Dmitry.Rekman Fixed a crash exiting VR Preview on Windows GL4 (UE-28708). - PR #2188 submitted by ardneran. Change 3110313 on 2016/09/01 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3111134 on 2016/09/01 by Dmitry.Rekman UBT: prevent mono from hanging on Ctrl-C. - Sometimes Ctrl-C can cause thread creation to fail. Without this change, UBT would lock up. Change 3111171 on 2016/09/01 by Brent.Pease Move all C# projects to use the x64 Platform for consistency with other changes made to move to the x64 Platform Change 3111177 on 2016/09/01 by Dmitry.Rekman Fix Linux build on systems without CUDA (UE-35460). Change 3111548 on 2016/09/02 by Luke.Thatcher [PLATFORM] [PS4] [!] Fix for PS4 iterative deployment. - Changes in Dev-Mobile broke the deployment manifests, as PS4 was now using the wrong filename when creating delta and obsolete file lists. Change 3111863 on 2016/09/02 by Dmitry.Rekman Better fix for build without CUDA (UE-35460). Change 3112738 on 2016/09/02 by Mark.Satterthwaite Fix the pausing particles on Metal - one line bug in the Metal query implementation meant that the first query wouldn't return the correct result for no good reason. #jira UE-34989 Change 3114579 on 2016/09/06 by Chris.Babcock Fix Vulkan include path in NDK check (contributed by geediiiiky) #jira UE-35490 #github #2758 #ue4 #android Change 3115115 on 2016/09/06 by Jeff.Campeau Calculate buffer size for paks using the bitwindow override as needed Change 3115600 on 2016/09/07 by Luke.Thatcher [PLATFORM] [PS4] [~] Make the crash dump handler registration much earlier, to catch crashes in early engine init. - Fixed up places in FGenericCrashContext::SerializeContentToBuffer which used the command line. If we crash early, the command line may not have been initialized yet. - Added a GetNoInit function to FThreadHeartBeat to avoid creating the heart beat thread if we crash early, and the thread doesn't exist yet. Tested by calling abort() immediately inside int main(), and we get a valid crash dump that the crash handler service can consume. Change 3115676 on 2016/09/07 by Luke.Thatcher [PLATFORM] [~] Dev-Platform integration fix for original CL 3064888 in //Orion/Release-29.1 Add .exe and .dll to windows symbol upload file filters. Change 3115811 on 2016/09/07 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3115944 on 2016/09/07 by Michael.Trepka Implemented IsGamepadAttached() for Mac Change 3115948 on 2016/09/07 by Michael.Trepka Don't try to restore Help menu item on Mac if MenuBlock does not contain it Change 3116200 on 2016/09/07 by Jeff.Campeau Fix parameter ordering Change 3117660 on 2016/09/08 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3117728 on 2016/09/08 by Michael.Trepka Copy of CL 3117698 by Mike.Fricker Fixed regression with editor's Simulate mode where cursor would teleport back to the center of the viewport after every click - This bug was introduced in CL 3075932 from a borderless window cursor handling fix that was needed for games that capture the cursor Change 3117797 on 2016/09/08 by Peter.Sauerbrei Shader Resource compression Change 3117988 on 2016/09/08 by Brent.Pease - Solutiion generator will now pick x64 instead of AnyCPU for the default platform configuration - Fix what I think was a merge error in BuildGraph.cs Change 3118296 on 2016/09/08 by Daniel.Lamb Fixed crash with launch on. Couldnt' correctly detect previous generated ini settings. #test launch on QA game #jira UE-35741 Change 3118438 on 2016/09/08 by JohnHenry.Carawon Fix UAT compilation on Linux #UE-35745 Change 3118934 on 2016/09/08 by Jeff.Campeau Shader compression setting based on target platform instead of cooking host platform. #jira UE-35753 Change 3120190 on 2016/09/09 by Ben.Marsh Add missing Platform attribute to build script for Dev-Platform. [CL 3120378 by Josh Adams in Main branch]
2016-09-09 20:13:41 -04:00
IProcessResult NewClient = SC.StageTargetPlatform.RunClient(ClientRunFlags | ERunOptions.NoWaitForExit, ClientApp, ClientCmdLine, Params);
OtherClients.Add(NewClient);
}
}
}
}
else if (ClientProcess == null && !ServerProcess.HasExited)
{
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 4285612) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3836829 by Ben.Marsh UBT: Fix ability to precompile plugins from installed engine builds. Change 3839519 by Ben.Marsh UBT: Simplify configuring bPrecompile and bUsePrecompile settings for modules. Each rules assembly can now be configured as installed, which defaults the module rules it creates to use precompiled data. Change 4042043 by Steve.Robb GitHub #4705 : Added weak lambda's for delegates and multicast delegates. Change 4042056 by Robert.Manuszewski Optimized Mark Phase of GC by up to 10ms by making it run in parallel and removing a huge array presize which we didn't need. Change 4042104 by Robert.Manuszewski Set the minimum GC cluster size to 5 so that GC doesn't have to process micro clusters which are more expensive than processing individual objects + Exposed the minimum cluster size to ini and project settings as gc.MinGCClusterSize + Added the ability to sort clusters by name/object count/mutable object count/referenced clusters count when dumping them with gc.ListClusters command Change 4042377 by Robert.Manuszewski Reworked how GC and other threads (ALT specifically) interact - GC will now notify the ALT it wants to run and ALT will immediately try to finish its current work to allow that. Also the entire ALT tick is now protected against GC running at the same time to improve ALT stability. + added gc.ForceCollectGarbageEveryFrame console variable that triggers a forced GC every frame Change 4042427 by Robert.Manuszewski Changed FGCCSyncObject to use events when waiting for GC to finish so that it doesn't spin on non-game threads when GC is running Change 4042482 by Robert.Manuszewski Unhashing unreachable objects (ConditionalBeginDestroy) will now also be done incrementally, just like the purge phase of Garbage Collection Change 4042635 by Robert.Manuszewski Fix for a potential assert when incremental purge garbage is pending and something forces a full purge Change 4044092 by Steve.Robb Fix for forward declared CoreUObject weakobject types in delegates when building in Clang. Change 4044102 by Robert.Manuszewski Fix for a possible hang when worker threads are preventing GC from running and something is later trying to FlushAsyncLoading with the Async Loading Thread enabled Change 4044113 by Steve.Robb Another Clang fix. Change 4044160 by Robert.Manuszewski Disregard For GC pool will now be enabled by default in cooked builds Change 4044287 by Steve.Robb Typo fix. Change 4047723 by Graeme.Thornton TBA: Fixes for import/export name cache and object resolving Change 4048015 by Graeme.Thornton TBA: Weak/Soft/Lazy pointer serialization changes * Remove FWeakObjectPtr::Serialize, move it's logic into, and replace usages of with calls to, FArchiveUObject::SerializeWeakObjectPtr(). Ensures that something is always sent to the archive so that structured archives can be kept happy in the future. * Added Weak/Soft/Lazy pointer handling to the structured archive slot interface and all the formatters. Binary formatters just forward the call onto their inner and text archives store as a string path reference. * FArchiveUObjectFromStructuredArchive caches all these pointer types and stores indices in the binary block, same as with a UObject*. All pointers are then forwarded to the underlying formatter in one go on finalization. Change 4048021 by Steve.Robb Fix for binding an unbound TFunction to another TFunction with a different signature. Also all null pointers now count as unbindings, not just nullptr. TIsMemberPointer added. TIsATFunction and TIsATFunctionRef renamed to remove the 'A's. Change 4048544 by Robert.Manuszewski Fixing ConditionalBeginDestroy profiling after changes to incremental CBD. Change 4051028 by Graeme.Thornton TBA: ArchiveFromStructuredArchive adapter uses Inner to determine if it is outputting to text, and sets it's own ArIsTextFormat to false Change 4051056 by Graeme.Thornton TBA: High level tagged property / UObject base class text serialization - UObject serialize converted to structured archive - Properties written to text individually with text tags, and then binary adapted values - Only saves, doesn't load Change 4051111 by Graeme.Thornton TBA: Temporarily disable loading of text assets until tagged property serialization path is fixed up Change 4051154 by Graeme.Thornton TBA: Convert a few uobject serializers to structured archive format for example purposes Change 4051181 by Graeme.Thornton TBA: Added default structured archive implementation of SerializeItem to UProperty, which just calls the FArchive version on an FArchiveUObjectFromStructuredArchive adapter. Implemented structured archive SerializeItem for UArrayProperty Change 4051197 by Graeme.Thornton TBA: ObjectProperty text serialization Change 4051216 by Graeme.Thornton Restored a modified FWeakObjectPtr::Serialize function to keep backwards compatibility in code I don't have access to. Change 4051261 by Graeme.Thornton TBA: Convert UMetaData to structured archive Change 4051374 by Steve.Robb Incorrect assert removed. Change 4051562 by Robert.Manuszewski Adding stats for the new GC internal functions Change 4051614 by Graeme.Thornton TBA: Removed UProperty::SerializeItem(FArchive, ...) and replaced with UProperty::SerializeItem(FStructuredArchive::FSlot, ...). Fixed up most of them to work properly and added adapters in for any that were non-trivial. Change 4052512 by Graeme.Thornton TBA: Temporary workaround for softobjectptr and lazyobjectptr uproperties not serialization anything when they know the archive is a reference collector. They should always be serializing their pointers and letting the underlying archive itself ignore them. Change 4053917 by Robert.Manuszewski Clustered objects from clusters that are no longer reachable will now be marked as unreachable immediately when gathering unreachable objects Change 4053919 by Robert.Manuszewski Added the ability to disable incremental BeginDestroy in ini/project settings Change 4055518 by Daniel.Lamb Fixup for deterministic audio generation issue. Submitted on behalf of Rich.Whitehouse #jira nojira #test prefilght automated test. Change 4056854 by Graeme.Thornton TBA: Added a test asset to EngineTest which contains all the different property types and test cases. Change 4056858 by Graeme.Thornton TBA: Updated USetProperty to proper structured archive usage Change 4056872 by Graeme.Thornton TBA: Add map property field to test object Change 4056873 by Graeme.Thornton TBA: Convert UMapProperty to full structured archive Change 4056994 by Graeme.Thornton TBA: Converted FText over to structured archive. Implemented saving, but not loading. Change 4059728 by Ben.Marsh UBT: Add support for using adaptive non-unity builds when the engine and project are in separate repositories. Change 4059805 by Graeme.Thornton Fixed typo in text serialization. Fixes CIS automation test errors Change 4060007 by Graeme.Thornton TBA: FArchiveFromStructuredArchive will now access it's host slot lazily, i.e. only when a value is actually written to the archive. Change 4060092 by Stefan.Boberg Added optimized Windows console window output path to GenericConsoleOutput since this slowed down cooking considerably (2 minutes spent in wprintf alone for one large dataset) When stdout is attached to a console we use the WriteConsoleW function instead of wprintf since the latter is very slow especially in unbuffered mode which the engine currently configures for stdout (see setvbuf call in LaunchEngineLoop.cpp). At some point we should reconsider this buffering policy since it's likely to slow down other platforms as well but I wanted to do a safe change for now as I don't yet fully understand why the setvbuf call is there in the first place. Change 4060108 by Stefan.Boberg Introduced some additional target platform utilities to help with asset cook optimizations * We now assign each ITargetPlatform a zero-based ordinal value * Introduced FTargetPlatform and FTargetPlatformSet types to help store platform references and platform sets efficiently. These are not currently used in the engine but are designed to replace the existing ITargetPlatform/string/FName representations in the cooking data structures. Change 4060143 by Graeme.Thornton Undo //UE4/Dev-Core/Engine/Source/Runtime/... changelist 4060007 Needs some other changes that I haven't checked in yet... Change 4062432 by Ben.Marsh Fix error message when enumerating P4 changes. Change 4062648 by Ben.Marsh Add missing p4 integration action. Change 4063620 by Graeme.Thornton Integrated a fix from UDN where the engine would crash when trying to load a very small encrypted file (<16bytes) from a pak file, where the read address wasn't already aligned to the AES block size. (https://udn.unrealengine.com/questions/431989/crash-while-reading-a-very-small-file-in-encrypted.html) Change 4066963 by Robert.Manuszewski Fixing GC cluster verification code reporting false positives when a cluster is referencing another cluster through 'mutable' objects list. Change 4067133 by Robert.Manuszewski Changed log verbosity when reporting individual cases of GC cluster assumption violations as they are followed by an asser anyway and this way we get the chance to see all issues before we assert at the end of these checks. Change 4067443 by Steve.Robb FString can now be constructed from any char pointer type and length. Change 4068156 by Steve.Robb Fix necessary because of FString constructor change in CL# 4067443. Change 4070258 by Graeme.Thornton Fixes for VSCode Change 4070372 by Graeme.Thornton TBA: Script struct serialization to structured archives Change 4071913 by Ben.Marsh Move bulk of the code for UnrealPak into an engine developer module, so it can be used in the editor. Change 4071914 by Ben.Marsh Missing files. Change 4071937 by Ben.Marsh Missing header. Change 4072015 by Ben.Marsh Fixes for compiling PakFileUtilities as part of the editor. Change 4072826 by Steve.Robb TBitArray::Reserve() added. TBitArray::Add() overloaded to allow adding multiple bits. TSparseArray::Reserve() optimized to call the overloaded Add(). Change 4073271 by Daniel.Lamb Fixed add patch tier in project launcher passing the wrong commandline option to UAT. #test none Change 4074708 by James.Hopkin #core Removed redundant Casts Change 4074763 by Steve.Robb Fix for TSparseArray::Reserve() size. Change 4076063 by Ben.Marsh Add an "UnrealPak" commandlet with the same functionality as the standalone UnrealPak program. Invoke by running the editor with -run=UnrealPak and the standard UnrealPak commandline options. Change 4077064 by Robert.Manuszewski Fixing compile error in PakFileUtilities Change 4077144 by Graeme.Thornton TBA: TextAssetCommandlet improvements * Collect lists of broken assets during roundtrip tests and print a summary of packages that failed each phase at the end * After resaving as text, load the file back as a plain JSON hierarchy to ensure the output was valid Change 4077412 by Ben.Marsh Set the correct exit code for UnrealPak. Should return 0 on success, not 1. Change 4077760 by Graeme.Thornton TBA: Loading fixed for tagged property serialization Includes conversion of all UProperty::ConvertFromType() and SerializeFromMismatchedTag() functions to use structured archives Lazy initialization of FArchiveFromStructruredArchive when loading, to support the possibility of an adapter being create around an object property serialize call to its inner UStruct, which then decides not to do anything and return false. Stops the ArchiveFromStructuredArchive from consuming the slot and getting upset later on when we try to serialize normal tagged properties from it. Disabled lazy bulk data loading from text assets. Requires a bigger change to make it work. Added some debug checks to json input formatter which track the current value stack size when a new object is pushed onto the stack, and makes sure that the stack has returned to the same size when the object is popped. Catches cases where we unpack an array/stream to the value stack but then don't consume all the items. Change 4078800 by Ben.Marsh Change UAT to using the editor's UnrealPak commandlet rather than invoking the standalone UnrealPak executable. To improve performance when building several PAK files, also add a new -batch=<file> command which reads commands to execute in parallel from a text file. Change 4079745 by Graeme.Thornton TBA: Migrated a couple of UObject Serialize functions to FStructuredArchive (SoundCue / MaterialExpressions / Editor strip flags) Change 4079847 by Graeme.Thornton TBA: Add 'FindMismatchedSerializers' mode to text asset commandlet, which dumps out a list of all UClasses which don't have the CLASS_MatchedSerializers flag, meaning we can't guarantee the have Serialize functions for FArchive AND FStructuredArchive, therefore we can't use the new structured archive based serialize path. Should only ever be native instrinsic classes as UHT takes care of all other cases. Change 4079925 by Ben.Marsh Fix incorrect assignment when deriving name for chunked pak file. Change 4080214 by Ben.Marsh Move the ThreadPoolWorkQueue class into DotNETUtilities so it can be used by other projects. Change 4082394 by Graeme.Thornton CIS fix for variable shadowing warning Change 4082583 by Ben.Marsh Add a IBinarySerializable interface for types that support reading from a BinaryReader and writing to a BinaryWriter. Implementing IBinarySerializable implies a constructor taking a BinaryReader argument is available for deserializing. Change 4082652 by Ben.Marsh Fix FileReference.Directory not returning a directory with a trailing backslash for files in the root directory. Change 4082755 by Graeme.Thornton Fixed an erroneous usage of TUniquePtr<uint8>as a pointer to a uint8 array when creating pak files. Caused a crash when compression was enabled, and has probably surfaced because pak generation is now done by an editor commandlet rather than a standalone program. Change 4082756 by Graeme.Thornton Fixed some incorrect documentation for pakfile compressed chunk headers Change 4082883 by Graeme.Thornton Static analysis warning fix Change 4082912 by Ben.Marsh Move ExceptionUtils into DotNETUtilities. Change 4085291 by Graeme.Thornton TBA: In the Json output formatter, write float and double values out with enough precision for successful roundtripping. Added some debug only code which will immediately reconvert the string back to its original value and compare the the input Change 4085523 by Graeme.Thornton TBA: Remove only explicit usage of DECLARE_FSTRUCTUREDARCHIVE_SERIALIZER. Should only be used from UHT generated code. Change 4086037 by Robert.Manuszewski Fix for a potential race condition when two threads want to acquire GC lock Change 4088655 by Graeme.Thornton Pak creation now uses the bEnablePakSigning setting from the crypto config json file Change 4091474 by Steve.Robb Fix for TStaticBitArray::FindFirstSetBit() and TStaticBitArray::FindFirstClearBit(). Unused variables removed. Change 4093632 by Steve.Robb CIS fixes. Change 4093656 by Graeme.Thornton Build fix Change 4093744 by Ben.Marsh Allow per-chunk settings for whether to enable compression in UnrealPak. Change 4099712 by Gil.Gribb UE4 - Fixed rare case where insufficient space was preallocated for cooldown ticks. #jira UE-59686 Change 4099912 by Stefan.Boberg Cooking timer optimizations: - Replaced data structures for FScopeTimer and FHierarchicalTimerInfo. Previous implementation used FString for many things and caused *lots* of heap and string concatenation activity. Replaced with a compile-time node id (using __COUNTER__) and raw string literals. - Removed PERPACKAGE_TIMER support (was disabled by default and was difficult to test) - Made it possible to toggle OUTPUT_TIMING and ENABLE_COOK_STATS independently - Removed some extremely tight timers because the overhead from calling QPC significantly exceeded the measured code This change shaved some 15% off a clean cook of Fortnite WindowsClient (en) with fully populated local DDC Change 4100519 by Stefan.Boberg Quick fix for Linux build issue introduced in 4099927 Change 4105327 by Stefan.Boberg Cooker: Changed FHierarchicalTimerInfo so it uses a linked list for tracking child nodes, to be able to deal with any child count. Previously we assumed there would never be more than 9 children but it turns out there are cooker modes that need more. Fixes check when using -FullLoadAndSave to cook Change 4105448 by Stefan.Boberg - Fixed Linux build warning re: member initialization order - Also eliminated OUTPUT_HIERARCHYTIMERS/CLEAR_HIEARCHYTIMERS macros (plain functions are fine) - Moved finishing-up code for FullLoadAndSave() to TickCookOnTheSide() call site to improve timer output. Previously some of the scopes would not have been closed before printing and thus the output was misleading. Change 4109031 by Ben.Marsh Attribute-driven Perforce wrapper (old Epic Friday project). Offers a more complete implementation than the current P4 wrapper in UAT without requiring any platform-specific libraries. Uses the Python binary output for parsing. Change 4109588 by Ben.Marsh UBT: Add extension methods for serializing a nullable type to a BinaryReader/BinaryWriter. Change 4109595 by Ben.Marsh Missing project file for DotNETUtilities. Change 4110724 by Stefan.Boberg Removed annotation map locking in UObjectMarks, eliminating around one minute (~3.5%) from Fortnite cook time. The locking was redundant since the annotation maps are managed per thread anyway. Change 4111304 by Ben.Marsh UAT: Add support for setting a status message through the log class. Allows writing transient messages (eg. progress messages) which will be cleared out before writing other messages. Best used through the LogStatusScope class, which can set a status message for the duration of a using() block. As part of this change, the console no longer has to be added as a dedicated trace listener. Since we already special-case this listener when formatting log output, it's easier to just keep the implementation separate to the other trace listeners. Change 4112708 by Steve.Robb Fix for TBitArray::MaxBits in assignment. Change 4114133 by Stefan.Boberg Tweaked how low-level memory (LLM) tracker is implemented to reduce overheads. Previously FMemory functions would acquire the LLM singleton and call OnLowLevelFree/OnLowLevelAlloc etc which would check the bIsDisabled flag and early out if it was set. Due to how frequently these functions were called this ended up costing quite a bit. - This change makes the flag a static member variable instead of a member variable and therefore enables a simpler early-out to be implemented. - The singleton getter is also simplified to avoid hitting the threadsafe singleton construction path on every call. - The enable flag is no longer TAtomic - this also incurs extra overhead for no clear benefit Shaves approximately 3.5% (one minute) off a Fortnite cook test scenario (using -FullLoadAndSave) Change 4115010 by Robert.Manuszewski Fixing CIS Change 4115249 by Robert.Manuszewski Fixing async loading code asserts when exiting game very early due to an error #jira UE-56267 Change 4117091 by Ben.Marsh Prevent doubled-up lines when writing status updates with console log verbosity. Change 4117207 by Ben.Marsh UGS: Do not include executables in diagnostics zip file, and ignore "no such files" error when cleaning workspace. Change 4119175 by Ben.Marsh UGS: Fix crash writing version files when directory does not already exist. Change 4119987 by Ben.Marsh UGS: Show a dialog box while the launcher is updating executables from Perforce, which allows cancelling the operation if necessary. Allow setting the username on the settings window, and prompt for login credentials if necessary. Should prevent situations where users have to update settings from the command prompt. Holding down shift during launch now shows the settings dialog rather than an immediate prompt to launch the unstable version (unstable version is shown as a checkbox on this dialog). Change 4119991 by Ben.Marsh Update version number for UGS launcher to 1.13. Change 4121943 by Robert.Manuszewski Don't use FArchiveAsync2 for reading packages with non-async path in editor builds as its performance is worse than the standard archive's (saves about 1 minute when doing larger cooks and 7 seconds when loading into PIE) Change 4122592 by Steve.Robb GitHub #4762 : Improve wording and grammar of Math comments Also includes improved accuracy in FMath::ComputeBoundingSphereForCone(). Change 4122819 by Stefan.Boberg Don't call CreateDirectory redundantly when opening files for writing using FFileManagerGeneric::CreateFileWriter This change avoids calling IPlatformFile::CreateDirectoryTree if possible since this is a very expensive function especially for deep hierarchies as it performs directory creation from the root directory onwards instead of from the leaf downwards. That function should also be fixed but this change improves performance in the meantime. Change 4122872 by Stefan.Boberg CreateDirectoryTree now creates directories leaf-to-root instead of the other way around. This is much more efficient since we don't spend time on system API calls for directories which already exist. This accounted for a very large amount of CPU time in cooking as the full target file directory hierarchy would be "created" for every single output file. Change 4123109 by Stefan.Boberg - Disable overlapped I/O in editor / cooker. Synchronous I/O reduces the number of syscalls and Windows performs prefetching on our behalf anyway for sequential reads - Eliminated syscall which was issued for every write to update cached file size -- since we're the only writers to the file (file access allows read sharing at most) we can authoritatively update the file size on write completion Change 4123455 by Ben.Marsh PR #4775: New build param PCHMemoryAllocationFactor to set /Zm VS build param. (Contributed by lucaswall) Change 4124207 by Ben.Marsh UBT: Remove some unnecessary indirection for generated code paths. Change 4124217 by Ben.Marsh UBT: Remove another unused variable from UEBuildModuleCPP. Change 4124377 by Stefan.Boberg In IPlatformFile::DeleteDirectoryRecursively, attempt to delete file first and if it fails clear the readonly flag and try again Previously there was a call to clear the readonly flag for every deleted file and this is a waste of resources 99% of the time. The SetFileAttributes call accounted for a significant amount of time during cooker sandbox directory deletion Change 4125071 by Stefan.Boberg Some tweaks to FQueuedThreadPoolBase scheduling and memory management - Explicitly pass in false for TArray::RemoveAt(..., bool bAllowShrinking) argument to prevent memory reallocation when arrays are drained and inevitably repopulated shortly afterwards - Use a MRU strategy instead of LRU when picking a thread to wake up. The MRU thread is the most likely to have a 'hot' cache for the stack etc. Picking from the back of the array also happens to be cheaper since no memory movement is necessary when RemoveAt is called. (This was the strategy in place before CL2600362 which seems to have changed it unintentionally) - Release lock as soon as a thread has been chosen, before asking the worker thread to wake up and do the work Change 4126132 by Ben.Marsh UAT: Detect when stdout is redirected and prevent using backspace characters to move the cursor. Change 4126867 by Graeme.Thornton TBA: Fix tagged binary formatter Change 4127010 by Robert.Manuszewski AnimScriptInstances created at runtime will now also be added to the owning omponent's cluster to avoid GC issues. Change 4127932 by Ben.Marsh WorkspaceTool: Reduce unnecessary logging of status messages when console output is not redirected. Change 4129050 by Ben.Marsh UGS: Check for NET Framework 4.5 being installed before running the installer. Also fix warning trying to kill existing UGS instances before upgrade. Change 4129459 by Graeme.Thornton TBA: TextAssetCommandlet - When outputting converted assets to an output path, replicate the workspace relative path in the output directory Change 4129515 by Graeme.Thornton TBA: Add EnterRecord overload that allows outputting of available field names when loading. Change 4129517 by Graeme.Thornton TBA: Tagged properties are written out as named fields on the "Properties" record, rather than as a stream with a null tag at the end Change 4129518 by Graeme.Thornton TBA: Added a local const bool to allow easy hacking out of text asset loading support Change 4129558 by Graeme.Thornton TBA: Build fix for textasset-less configs Change 4129614 by Ben.Marsh UGS: Main window is now restored to normal size when activated by clicking on the tray icon. #jira UE-60490 Change 4129618 by Ben.Marsh UGS: Speculative fix for unreproduced exception accessing disposed window while shutting down. Change 4131936 by Robert.Manuszewski Removing some WIP code accidentally checked in with CL #4121943 Change 4133490 by Ben.Marsh UGS: Allow the $(Change) variable to be used in more places than just the context menu. #jira UE-60573 Change 4133550 by Ben.Marsh UGS: Setting for whether or not to use incremental builds is now exposed through the variable "$(UseIncrementalBuilds)" for use by custom build steps. #jira UE-60554 Change 4133681 by Ben.Marsh UGS: A per-project list of folders and extensions to be deleted by default when running the 'clean workspace' tool can now be specified through the <ProjectDir>/Build/UnrealGameSync.ini file. Settings may be specified for an individual branch (via a category with the depot path to the project) or for wherever the project is currently open (via the [Default] category). The SafeToDeleteFolders list specifies a substring that will be checked against folder paths. Anything containing this folder will be marked as safe for delete by default. The SafeToDeleteExtensions list specifies a list of extensions for files that can always be deleted. Example: [Default] +SafeToDeleteFolders=/MyGame/Test/ +SafeToDeleteFolders=/DataService/ +SafeToDeleteExtensions=.xx1 +SafeToDeleteExtensions=.xx2 #jira UE-60575 Change 4135449 by Ben.Marsh Fix allowing use of Job objects on Windows platforms (debug code submitted by mistake) Change 4135730 by Ben.Marsh UBT: Plugins can now be enabled and disabled from the .target.cs file (for targets that do not use the shared compile environment), by compiling the list of enabled/disabled plugin names into the Projects module. Change 4135823 by Ben.Marsh UBT: Remove legacy code to handle disabling optional plugins; now that this is compiled into the target, it will work for any plugins we choose. Change 4135945 by Ben.Marsh UBT: Fix error running programs with no explicitly enabled or disabled plugins. Change 4137207 by Ben.Marsh UGS: Align all badges with the same name, to make it easier to see which CIS steps are being run. Allow overriding the slot taken by a particular badge by calling it "SlotName:LabelName". Change 4137311 by Stefan.Boberg Removed child cooker support. In practice it is not a useful feature as it provides no performance improvement (quite the opposite in fact) and adds testing and maintenance complexity. Change 4137393 by Ben.Marsh UGS: Fix display of multiline errors in the status panel. Change 4141708 by Steve.Robb GitHub #3631 : Incorrect default argument in WeakObjectPtrTemplate #jira UE-45490 Change 4146655 by Stefan.Boberg Removed FullGCAssetClasses logic - no longer necessary nor useful Change 4147318 by Ben.Marsh UGS: Compress build badges in a column if it shrinks below the size that they would be visible. Change 4148207 by Ben.Marsh UGS: Added support for showing the latest completed build from a specific list of badges in the status panel. To declare a badge as one that should appear in the status panel rather than the CIS column, add it to the project's UnrealGameSync.ini in the project or [Default] section like so: +ServiceBadges=RoboMerge Change 4148282 by Stefan.Boberg Fixed bug in UCookOnTheFlyServer::GetCookOnTheFlyUnsolicitedFiles - UnsolicitedFiles should be passed by reference not by value Change 4148344 by Stefan.Boberg Fixed minor indentation error (most likely caused by sloppy merge) Change 4148521 by Stefan.Boberg Removed accidentally checked in PRAGMA_DISABLE_OPTIMIZATION from CookOnTheFlyServer.cpp Change 4148639 by Ben.Marsh UGS: Fix tooltips not showing for changes that have description badges. Change 4149373 by Ben.Marsh UGS: Allow adding additional columns to display particular badges by adding entries from the project config file. Example syntax: +Columns=(Name="Desktop",MinWidth=50,DesiredWidth=100,Weight=3,Badges="Editor") +Columns=(Name="Mobile",MinWidth=50,DesiredWidth=100,Weight=3,Badges="IOS,Android") Same form can be used to control how default columns are displayed (though badge settings are ignored). Also allow PerforceMonitor to detect local changes to project config files and update settings automatically. Change 4149399 by Ben.Marsh UGS: Update version to 1.143. Change 4155660 by Steve.Robb PROJECTION and PROJECTION_MEMBER macros which provide the correct behavior when creating projections using functions which are overloaded or use default arguments. Change 4157117 by Ben.Marsh Fix warning due to plugins disabled in .target.cs file. Change 4158011 by Ben.Marsh UBT: Add a check that the UnrealHeaderTool target file exists, rather than throwing an exception when reading it fails. Change 4158646 by Ben.Marsh UGS: Fix exception when login is discovered to have expired during a workspace update. Change 4158678 by Ben.Marsh UGS: Fix an exception on shutdown due to the icon being hidden after it's already been disposed. Change 4158683 by Ben.Marsh UGS: Add an unhandled exception filter which sends the exception data to the backend. Change 4159131 by Ben.Marsh UGS: Reduce the number of characters displayed for build badges based on the available space. Change 4159194 by Graeme.Thornton TBA: Fix incorrect map property conversion code when converting an old property that contains a map with different key/value types Change 4159239 by Steve.Robb Improved readability and compliance with coding standards. Change 4159246 by Ben.Marsh UGS: Allow syncing projects where source code is not available (and various version files don't exist). #jira UE-60985 Change 4159286 by Ben.Marsh UGS: Remove requirement for UE4Editor.target.cs to be visible in the depot in order to open a project. #jira UE-60986 Change 4159302 by Ben.Marsh UGS: Update version to 1.144. Change 4160308 by Ben.Marsh All staging client executables for blueprint projects. #jira UE-60983 Change 4161567 by Steve.Robb GitHub #4816 : UE-60771: Handle escaped double quote in FParse::LineExtended Change 4162641 by Ben.Marsh UGS: Allow customizing the position of custom columns, via the Index=N attribute. Change 4162647 by Ben.Marsh UGS: Update version to 1.145. Change 4165319 by Robert.Manuszewski PR #4812: Fix inconsistent command-line argument handling under Windows (Contributed by adamrehn) Change 4166150 by Ben.Marsh UGS: Include *.inl when looking for code changes. Change 4166551 by Steve.Robb Whitespace fixes caused by a bad merge. Change 4168483 by Ben.Marsh UGS: Add a more useful error if a file to be synced exceeds the max allowed path length. Change 4168490 by Ben.Marsh UGS: Update version to 1.146. Change 4168551 by Ben.Marsh UBT: Move bBuildLargeAddressAwareBinary into an exposed setting. Change 4168560 by Ben.Marsh UBT: Remove static config variable for controlling which configuration of UHT to use. Change 4171296 by Ben.Marsh UGS: Move the check for overlong paths earlier. Change 4171531 by Ben.Marsh UBT: Fix exception if BuildConfiguration.xml contains an unknown category. Change 4183371 by Robert.Manuszewski Fix for a crash in Async Loading Graph's CheckCycles when GC kicks in on the game thread and forces ALT to exit early Change 4184312 by Ben.Marsh UGS: Update version to 1.148 Change 4184480 by Robert.Manuszewski Removing unused async loading stat Change 4186390 by Ben.Marsh UBT: Format XML validation errors in a format that allows double-clicking on the message in Visual Studio. Change 4188644 by Ben.Marsh UBT: Add the MakePathSafeToUseWithCommandLine() function to UBT. Change 4188647 by Ben.Marsh UBT: Fix exception in target receipt when architecture is null. Change 4189617 by Ben.Marsh Change FileSystemReference, FileReference and DirectoryReference objects to use OrdinalIgnoreCase comparisons without creating a separate copy of the string to compare. The filesystem does not use the invariant culture, and it can produce the wrong results in some cases (the ordinal comparison is faster, too). Change 4189740 by Ben.Marsh UAT: Remote code to build UnrealPak when packaging; we use the editor now. Change 4189860 by Ben.Marsh UGS: Make the filter for excluding automated lighting rebuilds more explicit. Change 4190082 by Ben.Marsh Fixes to allow enabling edit and continue for Windows builds. Have experienced quite a few VS crashes when testing it in editor; not yet recommended for general use. - Allow edit and continue for any configuration, not just debug. - Fixed PDB errors compiling files that use a shared PCH with edit and continue enabled. Path to the generated PDB file was using the wrong directory. - Removed code that tracks PDB output files, since they're modified multiple times during a build. - Enable debug information when compiling generated CPP files, since it causes errors if the shared PCH PDB doesn't have the same option. - Disable support for remote execution of steps that modify the PDB, since the same file has to be modified many times. Remote execution causes the PDB files to be corrupted. Unfortunately, this makes E&C builds significantly slower. #jira Change 4192949 by Ben.Marsh UBT: Minor tidy-up (merging UEBuildBinary.Build and UEBuildBinary.SetupOutputFiles) Change 4193218 by Ben.Marsh Fix formatting. Change 4197252 by Mike.Erwin UAT: Fix log output w/ correct count of non-code projects. #jira none Change 4197941 by Ben.Marsh UGS: Add support for DebugGame editors that have an executable with a DebugGame suffix. Change 4197964 by Ben.Marsh UGS: Prevent attempts to automatically reopen projects while a modal dialog is up, or the workspace is syncing. Change 4198144 by Ben.Marsh UGS: Prevent modal dialogs when login expires in P4, and prompt for password when hitting "retry". Change 4198413 by Ben.Marsh UGS: Always show the main window when launched manually, and run with -RestoreState when launched at startup. Also add a couple more places that save the visibility state, since logging off seems like it can terminate the process abrubtly. Change 4198779 by Ben.Marsh UBT: Allow generating manifests to any arbitrary locations with the -Manifest=<Path> argument. Change 4198825 by Ben.Marsh UBT: Move code to enumerate Slate runtime dependencies into the Slate module. Doesn't need to be done inside core UBT. Change 4199341 by Ben.Marsh UGS: Update version to 1.149 Change 4199642 by Chad.Garyet - Deprecate CISController - Add BuildController to replace CIS GET/POST for builds - Add LatestController, GET does what CIS/GET used to do - Change Latest/GET to return the last 25 builds filtered by project, rather than the last 5000 individual Ids - Latest/GET now returns "LatestData" object instead of array of longs - Updated EventMonitor to match all API changes - Fixed bug where IDs were getting reset to initial startup values every update loop Change 4199663 by Chad.Garyet CIS controller still needs to return an array of longs #jira none Change 4199680 by Ben.Marsh UGS: Update version to 1.150 Change 4200457 by Ben.Marsh Merging CIS fix for non-development configurations. Change 4200472 by Mike.Erwin UAT: fix -skipbuildclient param default It was defaulting to skipbuildeditor's value, likely a copy-paste error. #jira none Change 4202595 by Ben.Marsh Fix static analysis warning due to constant comparison against macro. Change 4203250 by Ben.Marsh UGS: Always show the "Sync Precompiled Editor" option, but disable it and show a tooltip explaining why if it is not available. Change 4206191 by Ben.Marsh Exclude editor target files from installed builds, since they leak info about DLLs that have been stripped out. Change 4213011 by Ben.Marsh UBT: Include contents of modified intermediate files in the log, to make it easier to debug hidden dependencies. Change 4213487 by Ben.Marsh UBT: Fix assumption that bPrecompile is equivalent to bBuildAllModules. This is no longer the case; they are now controlled by separate options. Should fix CIS errors building the editor. Change 4213609 by Ben.Marsh Ensure that strings formatted using FMicrosoftPlatformString::GetVarArgs() are always null terminated, whether we use the secure CRT or not. Change 4215971 by Ben.Marsh UBT: Remove action graph visualization code; no longer used. Change 4215996 by Ben.Marsh UBT: Remove unqiue id from all actions in the action graph. This is only used for printing debug info in the case of a (rare) cycle in the action graph, so just look it up when needed. Change 4216022 by Ben.Marsh UBT: Rename Crypto.cs to EncryptionAndSigning.cs to match the name of the class inside it, and move it under the System folder. Change 4216031 by Ben.Marsh UBT: Move all the action executors into their own folder in the project. Change 4216526 by Ben.Marsh Fix CIS warnings. Change 4216544 by Ben.Marsh Replace custom code to ensure FMicrosoftPlatformString::GetVarArgs() null terminates its buffer with Microsoft's standards-compliant implementation. Change 4216633 by Ben.Marsh Add support for UnrealPak plugins. * Project and plugin modules can now specify an array of supported programs in the "WhitelistPrograms" field of their module descriptors, to allow modules to be loaded by programs. * Programs can now load any runtime modules, as long as they are whitelisted. * Programs under the engine directory can now use a shared build environment, so that building with a project file does not cause output binaries to be output to the project directory. * UnrealPak is now always built by default when packaging * Convert UnrealPak to a modular configuration Change 4216736 by Ben.Marsh UnrealPak: Move "ExportDependencies" command into an editor commandlet, since it relies on the UObject system, asset registry, etc... Change 4217447 by Ben.Marsh Back out revision 50 from //UE4/Dev-Core/Engine/Build/InstalledEngineBuild.xml Change 4217451 by Ben.Marsh Back out revision 11 from //UE4/Dev-Core/Engine/Plugins/Developer/VisualStudioSourceCodeAccess/Source/VisualStudioSourceCodeAccess/VisualStudioSourceCodeAccess.Build.cs Change 4217617 by Ben.Marsh Back out changelist 4217451 Change 4222552 by Ben.Marsh Don't use #import <TypeLib> for VS source code accessor when building with Clang; it's not supported. Change 4222630 by Ben.Marsh UBT: Fix spam while generating project files if Clang isn't installed. Change 4223316 by Ben.Marsh UBT: Change the order in which Visual C++ toolchains are enumerated to prefer full releases over preview releases. Change 4223318 by Ben.Marsh UBT: Add a build setting which allows creating a dedicated PCH for every file that's excluded from the unity working set (disabled by default). Improves iteration times when working on individual cpp files, but slows down iterating on header changes (and can take a lot of disk space for large changes). Dedicated PCH contains all includes scraped from the top of each cpp file, until a non-#include directive is encountered. Change 4223401 by Ben.Marsh UBT: Add an option to automatically enable edit and continue for files in the adaptive non-unity working set. E&C doesn't seem very useful for UE4 projects right now; compile time is comparable to regular build times, but it can take several minutes to apply code changes for large projects. Change 4223899 by Ben.Marsh UBT: Fix loading XML config files on Mono; Type.GetField(Name) does not seem to return values unless binding flags are specified. Change 4224637 by Ben.Marsh Add a "SupportedPrograms" field to plugin descriptors, which allows plugins to declare which plugins they support independently of individual modules. Programs now respect the "bEnabledByDefault" setting in plugins. Plugins that are compatible with a program now need to list that program in the SupportedPrograms list, and whitelist any modules that should load for that program. Change 4224710 by Ben.Marsh UBT: Don't add import libraries as final build products unless the target is being precompiled. Prevents the need for building them for leaf nodes in the action graph. Change 4224715 by Ben.Marsh UBT: Remove hack to allow Stats2.cpp to not follow IWYU convention. Change 4224726 by Ben.Marsh Remove commented out line. Change 4224903 by Ben.Marsh Fix non-unity compile error in Stats2.h. Change 4225051 by Ben.Marsh Back out changelist 4224710; causing CIS errors due to receipts not matching. Change 4225134 by Ben.Marsh Fixing non-unity errors. Change 4225203 by Ben.Marsh Another non-unity fix. Change 4225249 by Ben.Marsh Fix Linux dependencies being copied for the Windows editor; they can be added as requirements for the Linux target platform on Windows instead, so it respects the user's chosen platforms. #jira UE-62001 Change 4225512 by Ben.Marsh BuildGraph: Allow setting the target to build when using the <CsCompile> task. Change 4228815 by Ben.Marsh UBT: Always add the generated code directory to the list of include paths when generating project files. It may only be created after UHT has been run. Change 4228944 by Ben.Marsh UBT: Remove legacy CppCompileEnvironment and LinkEnvironment wrappers from TargetRules that were deprecated in 4.19. Change 4229028 by Ben.Marsh UBT: Fix editor targets with unique build environment having the wrong executable path in generated project files. Move move logic to configure target rules post-construction by the rules assembly to ensure it's valid. Change 4229065 by Ben.Marsh UBT: Move another target setting into the rules assembly. Change 4229105 by Ben.Marsh Fix BPT exception when generating project files. Change 4229311 by Ben.Marsh UBT: Store the module rules file location on the ModuleRules instance, as well as the plugin that it was created from. Also expose the plugin directory as a property on the ModuleRules instance. Change 4229421 by Ben.Marsh UBT: Consolidate functionality for UHT module setup in ExternalExecution.cs. Change 4229817 by Ben.Marsh UBT: Modules must now explicitly specify the path to the header used to generate a PCH if one is desired, rather than the header being determined automatically by attempting to parse the source code. Now that PCHs are force-included anyway, this removes a lot of dependencies inside UBT. Change 4229824 by Ben.Marsh UBT: Remove unused lists inside UEBuildModuleCPP.SourceFilesClass. Change 4229841 by Ben.Marsh UBT: Remove some legacy code from auto-detecting PCHs. Change 4230521 by Ben.Marsh UBT: Add utility functions to the log class to allow formatting errors and warnings in Visual Studio output format (eg. File(Line): warning: Message) Change 4230871 by Ben.Marsh UAT: Remove StreamUtilis utility class; there is a simpler way to implement the one place it's used. Change 4230882 by Ben.Marsh UAT: Add StreamUtils back into UAT, seems like it's still used there. Change 4230896 by Ben.Marsh UBT: Remove some redundant parameters from UEBuildModule/UEBuildModuleCPP/UEBuildModuleExternal constructors. Change 4231014 by Ben.Marsh WorkspaceTool: Include a dump of raw bytes when garbage is read from the P4 process, for diagnostic purposes. Change 4231032 by Ben.Marsh Fix CIS. Change 4231096 by Ben.Marsh Bump the FlatCPPIncludeDependencyCache version, to prevent errors trying to load old files. Change 4231446 by Ben.Marsh UBT: Added support for expanding UE-specific variables in include paths and library paths: $(EngineDir), $(ProjectDir), $(PluginDir), $(ModuleDir). Change 4231460 by Ben.Marsh Modules may now explicitly specify rpaths on Linux via the PublicRuntimeLibraryPaths and PrivateRuntimeLibraryPaths properties. Change 4233909 by Robert.Manuszewski PR #4779: Reason fails as the supplied variable is incorrect (Contributed by projectgheist) Change 4233910 by Ben.Marsh Enable PCHs on IOS. Reduces build time by ~25%. Change 4234176 by Ben.Marsh UBT: Add better messaging for modules that need to have a private PCH set. Now detects the likely PCH using the same method as legacy code and includes it as a suggestion. Change 4234193 by Ben.Marsh Add the Delete command to Perforce wrapper in DotNETUtilities. Change 4234688 by Ben.Marsh UBT: Simplify handling of installed/precompiled builds. Settings for whether a folder is installed/read-only or not is now stored on the RulesAssembly instance, allowing multiple things to be configured separately and stacked together (eg. engine/enterprise/project). RulesAssembly.IsReadOnly() allows determining if a flie can be modified or not and replaces many previous IsXXXInstalledCalls(), and traverses the chain of assemblies. Change 4234711 by Ben.Marsh UBT: Runtime dependencies can now be copied to output directories as part of the build. When adding a runtime dependency, an optional source location can be specified to copy from. Both the source and target paths can use variables can be used as part of the path, eg. $(OutputDir), $(ModuleDir), $(PluginDir). Example usage (from a .build.cs file): RuntimeDependencies.Add("$(OutputDir)/Foo.dll", "$(PluginDir)/Source/ThirdParty/Foo.dll", StagedFileType.NonUFS); Change 4234872 by Ben.Marsh Expose a flag for whether the engine is installed, to fix issues generating project files. Change 4234929 by Ben.Marsh Fix null reference generating receipts when UBT makefiles are active. Change 4235883 by Chad.Garyet Merging 4231245 to core Giving Coordinator its own sln. This should fix what 4158155 was supposed to. #jira UE-61955 Change 4236075 by Ben.Marsh CIS fix Change 4237066 by Robert.Manuszewski Fix for a potential crash when terminating the engine while it's being initialized #jira UE-60545 Change 4237078 by Robert.Manuszewski The engine will no longer be resetting all linkers causing massive load times when renaming the world package when entering Play In Editor Change 4237116 by Ben.Marsh Rewrite some Windows utility functions to support paths longer than MAX_PATH. Change 4237158 by Ben.Marsh Add const TCHAR* overloads of FString::RemoveFromStart() and FString::RemoveFromEnd(). Change 4237159 by Ben.Marsh Fix FWindowsPlatformFile::GetFilenameOnDisk() support for paths longer than MAX_PATH, and simplify some of the other long path functions to avoid copying string buffers. Change 4239050 by Ben.Marsh Missing file Change 4239318 by Ben.Marsh Linux CIS fix. Change 4239685 by Ben.Marsh Static analysis CIS fix. Change 4240800 by Ben.Marsh WorkspaceTool: Include the full command line in the log for any P4 commands. Change 4240903 by Ben.Marsh PR #4909: Update copyright notices to 2018 (Contributed by projectgheist) Change 4241025 by Ben.Marsh UBT: Exclude mobile pipeline caches from generated project files. Causes huge slowdown when using 'Find in Files' through the IDE. Change 4241770 by Ben.Marsh UBT: Include action number in parallel executor output. #jira UE-62032 Change 4243469 by Ben.Marsh TBA: Merge FAnnotatedStructuredArchiveFormatter with FStructuredArchiveFormatter. Any functions that are only implemented for text archives now have a _TextOnly suffix, and are exposed through the FStructuredArchive interface. Change 4245723 by Robert.Manuszewski Fixing another creash when terminating the engine while initializing. #jira UE-60545 Change 4245862 by Steve.Robb VectorLoadFloat2(Ptr) added, which loads { Ptr[0], Ptr[1], Ptr[0], Ptr[1] } into a VectorRegister. Change 4246412 by Robert.Manuszewski The warning 'Calling StaticLoadObject during PostLoad may result in hitches during streaming' will now also report the object which had the PostLoad called on it when StaticLoadObject call happened. Change 4246612 by Ben.Marsh UBT: Fix spelling of "Intellisense". Change 4249454 by Robert.Manuszewski Added extra checks to catch scenarios where the EDL Precache Buffer is flushed before a package header is fully read Change 4249513 by Robert.Manuszewski Made sure the Async Loading Thread doesn't continue running after creating new async packages when garbage collector wants to run on the game thread Change 4255207 by Ben.Marsh UGS: Add additional logging whenever a P4 command fails, and when the user is logged out. Change 4255288 by Ben.Marsh PR #4921: Honor ModuleRules' bEnableExceptions flag when creating precompiled h. (Contributed by surakin) Change 4256422 by Ben.Marsh UBT: Add an error if a module referenced by a plugin descriptor doesn't exist. Change 4257385 by Robert.Manuszewski Creating new objects from within ForEachObjectWithOuter will now result in a fatal error as it's unsafe to change internal UObject hash tables when iterating over them. Change 4257454 by Robert.Manuszewski Added the option to filter clusters listed with gc.ListClusters by objects within them. Usage: gc.ListClusters Hierachy With=ObjectName1,ObjectName2... Change 4257526 by Robert.Manuszewski It's now possible to filter clusters that get logged with verbose cluster logging enabled (UE_GCCLUSTER_VERBOSE_LOGGING=1) by objects within them by specifying -DumpClustersWithObjects=ObjectName1,ObjectName2 in the command line Change 4257822 by Ben.Marsh Fixes for PlatformShowcase compile errors. Change 4258771 by Ben.Marsh UBT: Fix project files not being generated for foreign projects when creating .stub files. #jira UE-62462 Change 4258790 by Ben.Marsh UBT: Clean up the logic around generating project files before creating a stub IPA, so that it fails loudly if project files do not exist, and can accept target names not matching project names. Change 4259276 by Ben.Marsh UBT: Make it an error if a framework doesn't exist, rather than failing silently. Also remove some remote toolchain stuff that's no longer necessary. Change 4259280 by Ben.Marsh UBT: Fix embedded framework zips not being uploaded for plugins. #jira UE-62485 Change 4260236 by Ben.Marsh UBT: Fix path to generated engine project file. Change 4260334 by Ben.Marsh UGS: Fix custom build steps dialog inadvertantly modifying config file settings in-place. Change 4260361 by Ben.Marsh UGS: Allow for p4 login commands to fail, even though the user is logged in (due to a bad connection, etc...) Change 4260559 by Ben.Marsh UGS: Update version. Change 4261160 by Robert.Manuszewski MediaPlaylist will now be added to root set if the owning MediaPlayer is in the disregard for GC set (fixes GC assumption violation crash) #jira UE-62495 Change 4261421 by Ben.Marsh Force-sync files for building documentation, to fix issues with files not being updated. #jira UE-62413 Change 4261425 by Ben.Marsh UBT: Remove some leftover functions for handling the remote toolchain. Change 4261530 by Ben.Marsh UBT: Speculative fix (and better error reporting) for IOS mobile provision not being found in CIS. Change 4261611 by Ben.Marsh UBT: Downgrade warning to a log message, since it appears when generating project files. Change 4261710 by Ben.Marsh Remove assert that GLogConsole is set; it won't be for command line utilities that don't depend on ApplicationCore. #jira UE-62545 Change 4261831 by Ben.Marsh Fix compile errors due to missing include path when hot-reloading a module from the editor. There are not necessarily source files to compile when -modulewithsuffix is specified on the command line, which was results in GeneratedCodeWildcard not being set. #jira UE-62463, UE-62384 Change 4262723 by Ben.Marsh Whitelist plugins that need to be loaded by UFE. #jira UE-62564 Change 4265444 by Ben.Marsh Fix incorrect executable name for DebugGame configurations in Xcode. #jira UE-62574 Change 4265892 by Ben.Marsh Fix incremental compile failures due to dependency checking for unity files. CachedIncludePaths was not correctly being set on file items, so dependencies were being ignored. #jira UE-62575, UE-62603, UE-62597 Change 4266019 by Josh.Adams - Fixed the CopyAction for runtime dependencies that need to be copied to different location, on non-XGE Change 4266264 by Ben.Marsh Remove override for the __IPHONE_OS_VERSION_MIN_REQUIRED macro on TVOS. This macro is already defined by system headers (in <AvailabilityInternal.h>). Now that we support PCHs on IOS and TVOS, manually defining this macro results in it being defined three times (once for the PCH, once by AvailabilityInternal.h, and once by the force-included list of definitions for the source file being built). The errors for redefining the macro in AvailabilityInternal.h are suppressed due to it being a system header, but the error for redefining it for the source file being compiled are not. #jira UE-62578 Change 4266273 by Ben.Marsh Fixes incremental build failure when compile arguments for PCH have changed on IOS/TVOS. Compile action needs to have a dependency on PCH build action. Change 4266614 by Graeme.Thornton Fix crash when cooking nativized blueprints due to removal of child cooker system. Change 4266763 by Ben.Marsh Always build UnrealPak when building client targets. The ProjectParams.Pak option is not reliable, because it can be forced on later by the target platform. #jira UE-62584 Change 4267985 by Robert.Manuszewski When iterating with ForEachObjectWithouter, don't lock the entire has table but only the hash bucket that is currently being iterated #jira UE-62600 Change 4268558 by Robert.Manuszewski PurgeLegacyBlueprints will no longer be called from within ForEachObjectWithOuter is it renames objects that reside in hash tables that are being iterated over which may lead to undefined behavior. #jira UE-62600 Change 4269011 by Chad.Garyet - Fixing Wildcard match issue, the change to ugsapi sends projects as //Depot/Stream instead of //Depot/Stream/ Wildcard match was only substringing to 3 chars. - Checking in the change a while back that increases the number of queried jobs up to 432 based on some maths from Bob about how many builds we want to grab Published to ugsapi server 8/8/17 #jira none Change 4270788 by Ben.Marsh Fix IOS provisioning data being using when remote compiling on TVOS. #jira UE-62705 Change 4271916 by Ben.Marsh Tag the XGEControlWorker executable as a build product after compiling SCW, to make sure it's included in the UGS zip file. Change 4271934 by Ben.Marsh Upload all static libraries in plugin folders as part of remote builds. #jira UE-62694 Change 4273368 by Ben.Marsh Fix Slate dependencies not being enumerated, and rules assembly not being rebuilt when building remotely. #jira UE-62705 Change 4274049 by Ben.Marsh Always parse the team UUID out of the mobile provision when doing a remote compile. The provision installed on the remote Mac (and selected for signing) may be different. #jira UE-62751 Change 4274823 by Ben.Marsh Add the -VersionCookedContent argument to disable the -unversioned parameter on the cooker command line. Change 4275838 by Ben.Marsh Fix BuildVersion string not being passed through from <SetVersion> task. Also add a -BuildVersion command line argument to UBT to override it for a particular build. Change 4275913 by Ben.Marsh Add a dummy exported symbol to the XGEController module, to fix build errors due to missing .lib file when it's built with WITH_XGE_CONTROLLER = 0. Change 4284161 by Ben.Marsh Allow mirroring Oodle files to remote Mac. Change 4074774 by Steve.Robb Vast simplification of TFunction, making it smaller in footprint, easier to follow and extend, and more correct. TUniqueFunction added, which is a move-only TFunction which can hold move-only functors. Fix for UWidgetBlueprint::ForEachSourceWidget() which should never have compiled but did. FFunctionGraphTask and TFuture<> updated to use TUniqueFunction to make them more general. TArray::HeapPop() made to work with move-only types. Change 4082591 by Ben.Marsh Move the Log class from UBT to DotNetUtilities. Change 4083236 by Ben.Marsh Add a Log.WriteException() method to dump an exception message to the console (and write the exception trace to the log) Change 4084107 by Ben.Marsh UAT: Remove the unused -SkipHeader argument to UE4Build. Change 4089771 by Steve.Robb GitHub #4743 : modified VirtualAlloc function flag https://blogs.msdn.microsoft.com/oldnewthing/20151008-00/?p=91411 Change 4091456 by Steve.Robb Unification of all platforms' FMath::CountTrailingZeros() and FMath::CountLeadingZeros() for both 32-bit and 64-bit. Change 4156437 by Ben.Marsh Lots and lots of fixes compiling for Clang on Windows. Editor now compiles cleanly without warnings, but crashes on startup due to error in intrinsics test. Disabling that runs further, but crashes accessing freed memory. Switching to the ANSI allocator runs further, but crashes in Slate after the splash screen and before the editor window opens. // TODO! * Switching between Clang/ICL/VS2015/VS2017 is now supported through the same mechanism as switching Visual Studio versions, without requiring any source level changes. To use Clang, set WindowsPlatform.Compiler = WindowsCompiler.Clang from a .target.cs file, or set <WindowsPlatform><Compiler>Clang</Compiler></WindowsPlatform> from BuildConfiguration.xml. To pick a specific toolchain version, set WindowsPlatform.CompilerVersion. * Clang is now supported through AutoSDKs; will be added to CIS. * The Samples/Sandbox/Clang project forces Clang to be used from its target.cs file, and allows easily building all editor modules and plugins with Clang on Windows. * UnrealMathSSE intrinsics have been re-enabled for Clang due to missing functions from the UnrealMathFPU implementation, but causes failure in tests at startup. * SSE4_CRC32() is disabled in D3D12Pipelinestate.cpp, since intrinsics are only allowed if enabled for the whole target (rather than being used in specific functions due to runtime checks) Change 4157389 by Ben.Marsh Few more fixes for compiling the editor with Clang. Change 4183911 by Ben.Marsh Fixes to support incremental linking on Windows. Does not seem to have any net benefit right now; may improve once minimal rebuild is enabled. * Incremental linking no longer forces PDB files to be enabled for source files. * Actions can specify specific files to be deleted before each build. Code to forcibly delete PDB files has been moved to the MSVC toolchain. * Unused libraries produced by the cross-referenced link are no longer added as build products, since (a) deleting them breaks dependency checking for incremental linking and causes a full link, and (b) not deleting them breaks UBT dependency checking and causes actions to be run over and over again. * Icon update is disabled for Windows when incremental linking is enabled. * Removed rarely-used setting to always delete produced items before each build. Change 4184311 by Ben.Marsh UGS: Added a dialog which shows all the required platform SDKs for a branch, linked from the status panel in UGS. The llist is configured via the UGS config file submitted to Engine/Programs/UnrealGameSync/UnrealGameSync.ini (and may be overridden by the project config file if necessary): [Default] ; Set this to a network share which contains the SDK installers for your site SdkInstallerDir= ; All the required SDKs for the current version of the engine +SdkInfo=(Category="Android", Description="NDK r21", Browse="$(SdkInstallerDir)\\Android") +SdkInfo=(Category="Windows", Description="Visual Studio 2017") +SdkInfo=(Category="Windows", Description="Visual C++ Toolchain 14.13.26128") +SdkInfo=(Category="Windows", Description="Windows SDK 10.0.16299.0") Similar entries for console platforms are added in console subdirectories. Each entry may contain an Install="Foo.exe" and/or Browse="C:\Foo" style attribute, specifying the path to an installer to run or directory to open in explorer respectively. The SdkInstallerDir setting is used as a base directory for the default installers, seen above for Android. Licensees may override this with a network path specific to the site that UGS is being deployed to (either in this file, in a project specific config file, or in a Engine/Programs/UnrealGameSync/NotForLicensees/UnrealGameSync.ini file). Change 4200452 by Ben.Marsh UBT: Change DebugGame configurations to output a separate executable rather than requiring a -Debug argument at runtime. Previous behavior was a common source of errors. Engine modules are still shared between Development and DebugGame, but the launch module sets a flag in Core on startup indicating the game configuration. Change 4206189 by Ben.Marsh UBT: Simplify logic for precompiling binaries. * Target no longer has separate list of "precompile only" binaries or modules. New -AllModules option allows adding every module to a target, which can be used with -Precompile and -NoLink to precompile object files for monolithic builds. * Precompiled file lists have been removed from target receipts. * The manifest now includes all generated headers and precompiled files when run with the -Precompile option. * Separate -DependencyList=Foo.txt has been added to write a list of all dependencies required to use precompiled binaries. This file list can be read using the <Tag> task in buildgraph. Change 4215466 by Ben.Marsh UBT: Remove indirect calls to determine extensions for object files and precompiled headers. The toolchain knows the correct convention for the platform. Change 4215975 by Ben.Marsh UBT: Remove telemetry code. This has never proved useful for analyzing performance due to the number of incidental factors that affect build times (eg. number of files being compiled). Change 4220154 by Ben.Marsh Move text-only implementations of FOutputDeviceError back into Core, so we can build command-line applications that don't depend on ApplicationCore. Change 4224708 by Ben.Marsh Add a bCompileAgainstApplicationCore setting to the target rules, which allows compiling out references to the ApplicationCore module (which should only be necessary for applications with a GUI). Removed ApplicationCore from several engine tools and utilities. Change 4224958 by Ben.Marsh Remove CoreMinimal.h includes from Core. Change 4229059 by Ben.Marsh UBT: Remove the UEBuildPlatform.ShouldNotBuildEditor() hook for target platforms. We shouldn't be modifying a target's build environment to disable the editor; it is invalid to build the editor for these target platforms at all, and this is already enforced by the GetSupportedPlatforms() function. Change 4230508 by Ben.Marsh Fixup precompiled header setting for samples and games. Change 4231457 by Ben.Marsh Fix exceptions in log messages having trailing newlines. Change 4232406 by Ben.Marsh UBT: Always force include a PCH for generated code if there's one set; the code may depend on it to compile. Change 4234177 by Ben.Marsh Set up private PCH files everywhere that previously used them. Change 4235973 by Ben.Marsh Change FPlatformMisc::GetEnvironmentVariable() to return an FString() rather than requiring a fixed size buffer to be passed in. Removes references to MAX_PATH. Change 4238842 by Ben.Marsh Add support for paths longer than MAX_PATH in the editor. Requires Windows 10 version 1607, and the functionality to be enabled via a registry key or group policy (see https://docs.microsoft.com/en-us/windows/desktop/FileIO/naming-a-file). Only a subset of Win32 functions support long paths (executables can only be started from paths shorter than MAX_PATH, for example). * Added a FPlatformMisc::GetMaxPathLength() function to return the maximum length of a path on the current system. On Windows, this returns a different value for systems with long paths enabled to those without. * The MAX_PATH define is no longer set by non-Windows platforms. Instead, there is a MAC_MAX_PATH, UNIX_MAX_PATH, etc... for any platform-specific code that still relies on the previous macro. * The MAX_UNREAL_FILENAME_LENGTH macro has been renamed to MAX_UNREAL_FILENAME_LENGTH_DEPRECATED * The PLATFORM_MAX_FILEPATH_LENGTH macro has been renamed to PLATFORM_MAX_FILEPATH_LENGTH_DEPRECATED. * Removed custom resource files for programs, since they are just copies of the base UE4 one (which is used by default anyway). The base UE4 manifest declares support for long paths. * Fix 512 character maximum length on editor commands. 260 character limit remains in place for cooking at the moment (see ContentBrowserUtils.h), until C# staging code supports long paths. Change 4255042 by Ben.Marsh UBT: Remote compilation now uploads the entire workspace to the remote Mac and executes a separate remote instance of UBT rather than synchronizing individual actions. This makes the remote compile codepath much simpler, and removes a lot of special cases that exist to support it previously. The list of files to be transferred to the remote are listed as rsync filter rules in Engine/Build/Rsync/RsyncEngine.txt and RsyncProject.txt, which are applied to the root engine directory and project directory respectively. Projects that need to customize which files are uploaded can add their own <ProjectDir>/Build/Rsync/RsyncProject.txt file, which will be included in the filter before the default version. Change 4260567 by Ben.Marsh UAT: Rename CommandUtils.Log to CommandUtils.LogInformation, to avoid conflicts with the underlying Tools.DotNETCommon.Log class. #rb none [CL 4285673 by Ben Marsh in Main branch]
2018-08-14 18:32:34 -04:00
LogInformation("Waiting for server to start....");
Thread.Sleep(2000);
}
if (String.IsNullOrEmpty(Output) == false)
{
Console.Write(Output);
}
if (ClientProcess != null && ClientProcess.HasExited)
{
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 4285612) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3836829 by Ben.Marsh UBT: Fix ability to precompile plugins from installed engine builds. Change 3839519 by Ben.Marsh UBT: Simplify configuring bPrecompile and bUsePrecompile settings for modules. Each rules assembly can now be configured as installed, which defaults the module rules it creates to use precompiled data. Change 4042043 by Steve.Robb GitHub #4705 : Added weak lambda's for delegates and multicast delegates. Change 4042056 by Robert.Manuszewski Optimized Mark Phase of GC by up to 10ms by making it run in parallel and removing a huge array presize which we didn't need. Change 4042104 by Robert.Manuszewski Set the minimum GC cluster size to 5 so that GC doesn't have to process micro clusters which are more expensive than processing individual objects + Exposed the minimum cluster size to ini and project settings as gc.MinGCClusterSize + Added the ability to sort clusters by name/object count/mutable object count/referenced clusters count when dumping them with gc.ListClusters command Change 4042377 by Robert.Manuszewski Reworked how GC and other threads (ALT specifically) interact - GC will now notify the ALT it wants to run and ALT will immediately try to finish its current work to allow that. Also the entire ALT tick is now protected against GC running at the same time to improve ALT stability. + added gc.ForceCollectGarbageEveryFrame console variable that triggers a forced GC every frame Change 4042427 by Robert.Manuszewski Changed FGCCSyncObject to use events when waiting for GC to finish so that it doesn't spin on non-game threads when GC is running Change 4042482 by Robert.Manuszewski Unhashing unreachable objects (ConditionalBeginDestroy) will now also be done incrementally, just like the purge phase of Garbage Collection Change 4042635 by Robert.Manuszewski Fix for a potential assert when incremental purge garbage is pending and something forces a full purge Change 4044092 by Steve.Robb Fix for forward declared CoreUObject weakobject types in delegates when building in Clang. Change 4044102 by Robert.Manuszewski Fix for a possible hang when worker threads are preventing GC from running and something is later trying to FlushAsyncLoading with the Async Loading Thread enabled Change 4044113 by Steve.Robb Another Clang fix. Change 4044160 by Robert.Manuszewski Disregard For GC pool will now be enabled by default in cooked builds Change 4044287 by Steve.Robb Typo fix. Change 4047723 by Graeme.Thornton TBA: Fixes for import/export name cache and object resolving Change 4048015 by Graeme.Thornton TBA: Weak/Soft/Lazy pointer serialization changes * Remove FWeakObjectPtr::Serialize, move it's logic into, and replace usages of with calls to, FArchiveUObject::SerializeWeakObjectPtr(). Ensures that something is always sent to the archive so that structured archives can be kept happy in the future. * Added Weak/Soft/Lazy pointer handling to the structured archive slot interface and all the formatters. Binary formatters just forward the call onto their inner and text archives store as a string path reference. * FArchiveUObjectFromStructuredArchive caches all these pointer types and stores indices in the binary block, same as with a UObject*. All pointers are then forwarded to the underlying formatter in one go on finalization. Change 4048021 by Steve.Robb Fix for binding an unbound TFunction to another TFunction with a different signature. Also all null pointers now count as unbindings, not just nullptr. TIsMemberPointer added. TIsATFunction and TIsATFunctionRef renamed to remove the 'A's. Change 4048544 by Robert.Manuszewski Fixing ConditionalBeginDestroy profiling after changes to incremental CBD. Change 4051028 by Graeme.Thornton TBA: ArchiveFromStructuredArchive adapter uses Inner to determine if it is outputting to text, and sets it's own ArIsTextFormat to false Change 4051056 by Graeme.Thornton TBA: High level tagged property / UObject base class text serialization - UObject serialize converted to structured archive - Properties written to text individually with text tags, and then binary adapted values - Only saves, doesn't load Change 4051111 by Graeme.Thornton TBA: Temporarily disable loading of text assets until tagged property serialization path is fixed up Change 4051154 by Graeme.Thornton TBA: Convert a few uobject serializers to structured archive format for example purposes Change 4051181 by Graeme.Thornton TBA: Added default structured archive implementation of SerializeItem to UProperty, which just calls the FArchive version on an FArchiveUObjectFromStructuredArchive adapter. Implemented structured archive SerializeItem for UArrayProperty Change 4051197 by Graeme.Thornton TBA: ObjectProperty text serialization Change 4051216 by Graeme.Thornton Restored a modified FWeakObjectPtr::Serialize function to keep backwards compatibility in code I don't have access to. Change 4051261 by Graeme.Thornton TBA: Convert UMetaData to structured archive Change 4051374 by Steve.Robb Incorrect assert removed. Change 4051562 by Robert.Manuszewski Adding stats for the new GC internal functions Change 4051614 by Graeme.Thornton TBA: Removed UProperty::SerializeItem(FArchive, ...) and replaced with UProperty::SerializeItem(FStructuredArchive::FSlot, ...). Fixed up most of them to work properly and added adapters in for any that were non-trivial. Change 4052512 by Graeme.Thornton TBA: Temporary workaround for softobjectptr and lazyobjectptr uproperties not serialization anything when they know the archive is a reference collector. They should always be serializing their pointers and letting the underlying archive itself ignore them. Change 4053917 by Robert.Manuszewski Clustered objects from clusters that are no longer reachable will now be marked as unreachable immediately when gathering unreachable objects Change 4053919 by Robert.Manuszewski Added the ability to disable incremental BeginDestroy in ini/project settings Change 4055518 by Daniel.Lamb Fixup for deterministic audio generation issue. Submitted on behalf of Rich.Whitehouse #jira nojira #test prefilght automated test. Change 4056854 by Graeme.Thornton TBA: Added a test asset to EngineTest which contains all the different property types and test cases. Change 4056858 by Graeme.Thornton TBA: Updated USetProperty to proper structured archive usage Change 4056872 by Graeme.Thornton TBA: Add map property field to test object Change 4056873 by Graeme.Thornton TBA: Convert UMapProperty to full structured archive Change 4056994 by Graeme.Thornton TBA: Converted FText over to structured archive. Implemented saving, but not loading. Change 4059728 by Ben.Marsh UBT: Add support for using adaptive non-unity builds when the engine and project are in separate repositories. Change 4059805 by Graeme.Thornton Fixed typo in text serialization. Fixes CIS automation test errors Change 4060007 by Graeme.Thornton TBA: FArchiveFromStructuredArchive will now access it's host slot lazily, i.e. only when a value is actually written to the archive. Change 4060092 by Stefan.Boberg Added optimized Windows console window output path to GenericConsoleOutput since this slowed down cooking considerably (2 minutes spent in wprintf alone for one large dataset) When stdout is attached to a console we use the WriteConsoleW function instead of wprintf since the latter is very slow especially in unbuffered mode which the engine currently configures for stdout (see setvbuf call in LaunchEngineLoop.cpp). At some point we should reconsider this buffering policy since it's likely to slow down other platforms as well but I wanted to do a safe change for now as I don't yet fully understand why the setvbuf call is there in the first place. Change 4060108 by Stefan.Boberg Introduced some additional target platform utilities to help with asset cook optimizations * We now assign each ITargetPlatform a zero-based ordinal value * Introduced FTargetPlatform and FTargetPlatformSet types to help store platform references and platform sets efficiently. These are not currently used in the engine but are designed to replace the existing ITargetPlatform/string/FName representations in the cooking data structures. Change 4060143 by Graeme.Thornton Undo //UE4/Dev-Core/Engine/Source/Runtime/... changelist 4060007 Needs some other changes that I haven't checked in yet... Change 4062432 by Ben.Marsh Fix error message when enumerating P4 changes. Change 4062648 by Ben.Marsh Add missing p4 integration action. Change 4063620 by Graeme.Thornton Integrated a fix from UDN where the engine would crash when trying to load a very small encrypted file (<16bytes) from a pak file, where the read address wasn't already aligned to the AES block size. (https://udn.unrealengine.com/questions/431989/crash-while-reading-a-very-small-file-in-encrypted.html) Change 4066963 by Robert.Manuszewski Fixing GC cluster verification code reporting false positives when a cluster is referencing another cluster through 'mutable' objects list. Change 4067133 by Robert.Manuszewski Changed log verbosity when reporting individual cases of GC cluster assumption violations as they are followed by an asser anyway and this way we get the chance to see all issues before we assert at the end of these checks. Change 4067443 by Steve.Robb FString can now be constructed from any char pointer type and length. Change 4068156 by Steve.Robb Fix necessary because of FString constructor change in CL# 4067443. Change 4070258 by Graeme.Thornton Fixes for VSCode Change 4070372 by Graeme.Thornton TBA: Script struct serialization to structured archives Change 4071913 by Ben.Marsh Move bulk of the code for UnrealPak into an engine developer module, so it can be used in the editor. Change 4071914 by Ben.Marsh Missing files. Change 4071937 by Ben.Marsh Missing header. Change 4072015 by Ben.Marsh Fixes for compiling PakFileUtilities as part of the editor. Change 4072826 by Steve.Robb TBitArray::Reserve() added. TBitArray::Add() overloaded to allow adding multiple bits. TSparseArray::Reserve() optimized to call the overloaded Add(). Change 4073271 by Daniel.Lamb Fixed add patch tier in project launcher passing the wrong commandline option to UAT. #test none Change 4074708 by James.Hopkin #core Removed redundant Casts Change 4074763 by Steve.Robb Fix for TSparseArray::Reserve() size. Change 4076063 by Ben.Marsh Add an "UnrealPak" commandlet with the same functionality as the standalone UnrealPak program. Invoke by running the editor with -run=UnrealPak and the standard UnrealPak commandline options. Change 4077064 by Robert.Manuszewski Fixing compile error in PakFileUtilities Change 4077144 by Graeme.Thornton TBA: TextAssetCommandlet improvements * Collect lists of broken assets during roundtrip tests and print a summary of packages that failed each phase at the end * After resaving as text, load the file back as a plain JSON hierarchy to ensure the output was valid Change 4077412 by Ben.Marsh Set the correct exit code for UnrealPak. Should return 0 on success, not 1. Change 4077760 by Graeme.Thornton TBA: Loading fixed for tagged property serialization Includes conversion of all UProperty::ConvertFromType() and SerializeFromMismatchedTag() functions to use structured archives Lazy initialization of FArchiveFromStructruredArchive when loading, to support the possibility of an adapter being create around an object property serialize call to its inner UStruct, which then decides not to do anything and return false. Stops the ArchiveFromStructuredArchive from consuming the slot and getting upset later on when we try to serialize normal tagged properties from it. Disabled lazy bulk data loading from text assets. Requires a bigger change to make it work. Added some debug checks to json input formatter which track the current value stack size when a new object is pushed onto the stack, and makes sure that the stack has returned to the same size when the object is popped. Catches cases where we unpack an array/stream to the value stack but then don't consume all the items. Change 4078800 by Ben.Marsh Change UAT to using the editor's UnrealPak commandlet rather than invoking the standalone UnrealPak executable. To improve performance when building several PAK files, also add a new -batch=<file> command which reads commands to execute in parallel from a text file. Change 4079745 by Graeme.Thornton TBA: Migrated a couple of UObject Serialize functions to FStructuredArchive (SoundCue / MaterialExpressions / Editor strip flags) Change 4079847 by Graeme.Thornton TBA: Add 'FindMismatchedSerializers' mode to text asset commandlet, which dumps out a list of all UClasses which don't have the CLASS_MatchedSerializers flag, meaning we can't guarantee the have Serialize functions for FArchive AND FStructuredArchive, therefore we can't use the new structured archive based serialize path. Should only ever be native instrinsic classes as UHT takes care of all other cases. Change 4079925 by Ben.Marsh Fix incorrect assignment when deriving name for chunked pak file. Change 4080214 by Ben.Marsh Move the ThreadPoolWorkQueue class into DotNETUtilities so it can be used by other projects. Change 4082394 by Graeme.Thornton CIS fix for variable shadowing warning Change 4082583 by Ben.Marsh Add a IBinarySerializable interface for types that support reading from a BinaryReader and writing to a BinaryWriter. Implementing IBinarySerializable implies a constructor taking a BinaryReader argument is available for deserializing. Change 4082652 by Ben.Marsh Fix FileReference.Directory not returning a directory with a trailing backslash for files in the root directory. Change 4082755 by Graeme.Thornton Fixed an erroneous usage of TUniquePtr<uint8>as a pointer to a uint8 array when creating pak files. Caused a crash when compression was enabled, and has probably surfaced because pak generation is now done by an editor commandlet rather than a standalone program. Change 4082756 by Graeme.Thornton Fixed some incorrect documentation for pakfile compressed chunk headers Change 4082883 by Graeme.Thornton Static analysis warning fix Change 4082912 by Ben.Marsh Move ExceptionUtils into DotNETUtilities. Change 4085291 by Graeme.Thornton TBA: In the Json output formatter, write float and double values out with enough precision for successful roundtripping. Added some debug only code which will immediately reconvert the string back to its original value and compare the the input Change 4085523 by Graeme.Thornton TBA: Remove only explicit usage of DECLARE_FSTRUCTUREDARCHIVE_SERIALIZER. Should only be used from UHT generated code. Change 4086037 by Robert.Manuszewski Fix for a potential race condition when two threads want to acquire GC lock Change 4088655 by Graeme.Thornton Pak creation now uses the bEnablePakSigning setting from the crypto config json file Change 4091474 by Steve.Robb Fix for TStaticBitArray::FindFirstSetBit() and TStaticBitArray::FindFirstClearBit(). Unused variables removed. Change 4093632 by Steve.Robb CIS fixes. Change 4093656 by Graeme.Thornton Build fix Change 4093744 by Ben.Marsh Allow per-chunk settings for whether to enable compression in UnrealPak. Change 4099712 by Gil.Gribb UE4 - Fixed rare case where insufficient space was preallocated for cooldown ticks. #jira UE-59686 Change 4099912 by Stefan.Boberg Cooking timer optimizations: - Replaced data structures for FScopeTimer and FHierarchicalTimerInfo. Previous implementation used FString for many things and caused *lots* of heap and string concatenation activity. Replaced with a compile-time node id (using __COUNTER__) and raw string literals. - Removed PERPACKAGE_TIMER support (was disabled by default and was difficult to test) - Made it possible to toggle OUTPUT_TIMING and ENABLE_COOK_STATS independently - Removed some extremely tight timers because the overhead from calling QPC significantly exceeded the measured code This change shaved some 15% off a clean cook of Fortnite WindowsClient (en) with fully populated local DDC Change 4100519 by Stefan.Boberg Quick fix for Linux build issue introduced in 4099927 Change 4105327 by Stefan.Boberg Cooker: Changed FHierarchicalTimerInfo so it uses a linked list for tracking child nodes, to be able to deal with any child count. Previously we assumed there would never be more than 9 children but it turns out there are cooker modes that need more. Fixes check when using -FullLoadAndSave to cook Change 4105448 by Stefan.Boberg - Fixed Linux build warning re: member initialization order - Also eliminated OUTPUT_HIERARCHYTIMERS/CLEAR_HIEARCHYTIMERS macros (plain functions are fine) - Moved finishing-up code for FullLoadAndSave() to TickCookOnTheSide() call site to improve timer output. Previously some of the scopes would not have been closed before printing and thus the output was misleading. Change 4109031 by Ben.Marsh Attribute-driven Perforce wrapper (old Epic Friday project). Offers a more complete implementation than the current P4 wrapper in UAT without requiring any platform-specific libraries. Uses the Python binary output for parsing. Change 4109588 by Ben.Marsh UBT: Add extension methods for serializing a nullable type to a BinaryReader/BinaryWriter. Change 4109595 by Ben.Marsh Missing project file for DotNETUtilities. Change 4110724 by Stefan.Boberg Removed annotation map locking in UObjectMarks, eliminating around one minute (~3.5%) from Fortnite cook time. The locking was redundant since the annotation maps are managed per thread anyway. Change 4111304 by Ben.Marsh UAT: Add support for setting a status message through the log class. Allows writing transient messages (eg. progress messages) which will be cleared out before writing other messages. Best used through the LogStatusScope class, which can set a status message for the duration of a using() block. As part of this change, the console no longer has to be added as a dedicated trace listener. Since we already special-case this listener when formatting log output, it's easier to just keep the implementation separate to the other trace listeners. Change 4112708 by Steve.Robb Fix for TBitArray::MaxBits in assignment. Change 4114133 by Stefan.Boberg Tweaked how low-level memory (LLM) tracker is implemented to reduce overheads. Previously FMemory functions would acquire the LLM singleton and call OnLowLevelFree/OnLowLevelAlloc etc which would check the bIsDisabled flag and early out if it was set. Due to how frequently these functions were called this ended up costing quite a bit. - This change makes the flag a static member variable instead of a member variable and therefore enables a simpler early-out to be implemented. - The singleton getter is also simplified to avoid hitting the threadsafe singleton construction path on every call. - The enable flag is no longer TAtomic - this also incurs extra overhead for no clear benefit Shaves approximately 3.5% (one minute) off a Fortnite cook test scenario (using -FullLoadAndSave) Change 4115010 by Robert.Manuszewski Fixing CIS Change 4115249 by Robert.Manuszewski Fixing async loading code asserts when exiting game very early due to an error #jira UE-56267 Change 4117091 by Ben.Marsh Prevent doubled-up lines when writing status updates with console log verbosity. Change 4117207 by Ben.Marsh UGS: Do not include executables in diagnostics zip file, and ignore "no such files" error when cleaning workspace. Change 4119175 by Ben.Marsh UGS: Fix crash writing version files when directory does not already exist. Change 4119987 by Ben.Marsh UGS: Show a dialog box while the launcher is updating executables from Perforce, which allows cancelling the operation if necessary. Allow setting the username on the settings window, and prompt for login credentials if necessary. Should prevent situations where users have to update settings from the command prompt. Holding down shift during launch now shows the settings dialog rather than an immediate prompt to launch the unstable version (unstable version is shown as a checkbox on this dialog). Change 4119991 by Ben.Marsh Update version number for UGS launcher to 1.13. Change 4121943 by Robert.Manuszewski Don't use FArchiveAsync2 for reading packages with non-async path in editor builds as its performance is worse than the standard archive's (saves about 1 minute when doing larger cooks and 7 seconds when loading into PIE) Change 4122592 by Steve.Robb GitHub #4762 : Improve wording and grammar of Math comments Also includes improved accuracy in FMath::ComputeBoundingSphereForCone(). Change 4122819 by Stefan.Boberg Don't call CreateDirectory redundantly when opening files for writing using FFileManagerGeneric::CreateFileWriter This change avoids calling IPlatformFile::CreateDirectoryTree if possible since this is a very expensive function especially for deep hierarchies as it performs directory creation from the root directory onwards instead of from the leaf downwards. That function should also be fixed but this change improves performance in the meantime. Change 4122872 by Stefan.Boberg CreateDirectoryTree now creates directories leaf-to-root instead of the other way around. This is much more efficient since we don't spend time on system API calls for directories which already exist. This accounted for a very large amount of CPU time in cooking as the full target file directory hierarchy would be "created" for every single output file. Change 4123109 by Stefan.Boberg - Disable overlapped I/O in editor / cooker. Synchronous I/O reduces the number of syscalls and Windows performs prefetching on our behalf anyway for sequential reads - Eliminated syscall which was issued for every write to update cached file size -- since we're the only writers to the file (file access allows read sharing at most) we can authoritatively update the file size on write completion Change 4123455 by Ben.Marsh PR #4775: New build param PCHMemoryAllocationFactor to set /Zm VS build param. (Contributed by lucaswall) Change 4124207 by Ben.Marsh UBT: Remove some unnecessary indirection for generated code paths. Change 4124217 by Ben.Marsh UBT: Remove another unused variable from UEBuildModuleCPP. Change 4124377 by Stefan.Boberg In IPlatformFile::DeleteDirectoryRecursively, attempt to delete file first and if it fails clear the readonly flag and try again Previously there was a call to clear the readonly flag for every deleted file and this is a waste of resources 99% of the time. The SetFileAttributes call accounted for a significant amount of time during cooker sandbox directory deletion Change 4125071 by Stefan.Boberg Some tweaks to FQueuedThreadPoolBase scheduling and memory management - Explicitly pass in false for TArray::RemoveAt(..., bool bAllowShrinking) argument to prevent memory reallocation when arrays are drained and inevitably repopulated shortly afterwards - Use a MRU strategy instead of LRU when picking a thread to wake up. The MRU thread is the most likely to have a 'hot' cache for the stack etc. Picking from the back of the array also happens to be cheaper since no memory movement is necessary when RemoveAt is called. (This was the strategy in place before CL2600362 which seems to have changed it unintentionally) - Release lock as soon as a thread has been chosen, before asking the worker thread to wake up and do the work Change 4126132 by Ben.Marsh UAT: Detect when stdout is redirected and prevent using backspace characters to move the cursor. Change 4126867 by Graeme.Thornton TBA: Fix tagged binary formatter Change 4127010 by Robert.Manuszewski AnimScriptInstances created at runtime will now also be added to the owning omponent's cluster to avoid GC issues. Change 4127932 by Ben.Marsh WorkspaceTool: Reduce unnecessary logging of status messages when console output is not redirected. Change 4129050 by Ben.Marsh UGS: Check for NET Framework 4.5 being installed before running the installer. Also fix warning trying to kill existing UGS instances before upgrade. Change 4129459 by Graeme.Thornton TBA: TextAssetCommandlet - When outputting converted assets to an output path, replicate the workspace relative path in the output directory Change 4129515 by Graeme.Thornton TBA: Add EnterRecord overload that allows outputting of available field names when loading. Change 4129517 by Graeme.Thornton TBA: Tagged properties are written out as named fields on the "Properties" record, rather than as a stream with a null tag at the end Change 4129518 by Graeme.Thornton TBA: Added a local const bool to allow easy hacking out of text asset loading support Change 4129558 by Graeme.Thornton TBA: Build fix for textasset-less configs Change 4129614 by Ben.Marsh UGS: Main window is now restored to normal size when activated by clicking on the tray icon. #jira UE-60490 Change 4129618 by Ben.Marsh UGS: Speculative fix for unreproduced exception accessing disposed window while shutting down. Change 4131936 by Robert.Manuszewski Removing some WIP code accidentally checked in with CL #4121943 Change 4133490 by Ben.Marsh UGS: Allow the $(Change) variable to be used in more places than just the context menu. #jira UE-60573 Change 4133550 by Ben.Marsh UGS: Setting for whether or not to use incremental builds is now exposed through the variable "$(UseIncrementalBuilds)" for use by custom build steps. #jira UE-60554 Change 4133681 by Ben.Marsh UGS: A per-project list of folders and extensions to be deleted by default when running the 'clean workspace' tool can now be specified through the <ProjectDir>/Build/UnrealGameSync.ini file. Settings may be specified for an individual branch (via a category with the depot path to the project) or for wherever the project is currently open (via the [Default] category). The SafeToDeleteFolders list specifies a substring that will be checked against folder paths. Anything containing this folder will be marked as safe for delete by default. The SafeToDeleteExtensions list specifies a list of extensions for files that can always be deleted. Example: [Default] +SafeToDeleteFolders=/MyGame/Test/ +SafeToDeleteFolders=/DataService/ +SafeToDeleteExtensions=.xx1 +SafeToDeleteExtensions=.xx2 #jira UE-60575 Change 4135449 by Ben.Marsh Fix allowing use of Job objects on Windows platforms (debug code submitted by mistake) Change 4135730 by Ben.Marsh UBT: Plugins can now be enabled and disabled from the .target.cs file (for targets that do not use the shared compile environment), by compiling the list of enabled/disabled plugin names into the Projects module. Change 4135823 by Ben.Marsh UBT: Remove legacy code to handle disabling optional plugins; now that this is compiled into the target, it will work for any plugins we choose. Change 4135945 by Ben.Marsh UBT: Fix error running programs with no explicitly enabled or disabled plugins. Change 4137207 by Ben.Marsh UGS: Align all badges with the same name, to make it easier to see which CIS steps are being run. Allow overriding the slot taken by a particular badge by calling it "SlotName:LabelName". Change 4137311 by Stefan.Boberg Removed child cooker support. In practice it is not a useful feature as it provides no performance improvement (quite the opposite in fact) and adds testing and maintenance complexity. Change 4137393 by Ben.Marsh UGS: Fix display of multiline errors in the status panel. Change 4141708 by Steve.Robb GitHub #3631 : Incorrect default argument in WeakObjectPtrTemplate #jira UE-45490 Change 4146655 by Stefan.Boberg Removed FullGCAssetClasses logic - no longer necessary nor useful Change 4147318 by Ben.Marsh UGS: Compress build badges in a column if it shrinks below the size that they would be visible. Change 4148207 by Ben.Marsh UGS: Added support for showing the latest completed build from a specific list of badges in the status panel. To declare a badge as one that should appear in the status panel rather than the CIS column, add it to the project's UnrealGameSync.ini in the project or [Default] section like so: +ServiceBadges=RoboMerge Change 4148282 by Stefan.Boberg Fixed bug in UCookOnTheFlyServer::GetCookOnTheFlyUnsolicitedFiles - UnsolicitedFiles should be passed by reference not by value Change 4148344 by Stefan.Boberg Fixed minor indentation error (most likely caused by sloppy merge) Change 4148521 by Stefan.Boberg Removed accidentally checked in PRAGMA_DISABLE_OPTIMIZATION from CookOnTheFlyServer.cpp Change 4148639 by Ben.Marsh UGS: Fix tooltips not showing for changes that have description badges. Change 4149373 by Ben.Marsh UGS: Allow adding additional columns to display particular badges by adding entries from the project config file. Example syntax: +Columns=(Name="Desktop",MinWidth=50,DesiredWidth=100,Weight=3,Badges="Editor") +Columns=(Name="Mobile",MinWidth=50,DesiredWidth=100,Weight=3,Badges="IOS,Android") Same form can be used to control how default columns are displayed (though badge settings are ignored). Also allow PerforceMonitor to detect local changes to project config files and update settings automatically. Change 4149399 by Ben.Marsh UGS: Update version to 1.143. Change 4155660 by Steve.Robb PROJECTION and PROJECTION_MEMBER macros which provide the correct behavior when creating projections using functions which are overloaded or use default arguments. Change 4157117 by Ben.Marsh Fix warning due to plugins disabled in .target.cs file. Change 4158011 by Ben.Marsh UBT: Add a check that the UnrealHeaderTool target file exists, rather than throwing an exception when reading it fails. Change 4158646 by Ben.Marsh UGS: Fix exception when login is discovered to have expired during a workspace update. Change 4158678 by Ben.Marsh UGS: Fix an exception on shutdown due to the icon being hidden after it's already been disposed. Change 4158683 by Ben.Marsh UGS: Add an unhandled exception filter which sends the exception data to the backend. Change 4159131 by Ben.Marsh UGS: Reduce the number of characters displayed for build badges based on the available space. Change 4159194 by Graeme.Thornton TBA: Fix incorrect map property conversion code when converting an old property that contains a map with different key/value types Change 4159239 by Steve.Robb Improved readability and compliance with coding standards. Change 4159246 by Ben.Marsh UGS: Allow syncing projects where source code is not available (and various version files don't exist). #jira UE-60985 Change 4159286 by Ben.Marsh UGS: Remove requirement for UE4Editor.target.cs to be visible in the depot in order to open a project. #jira UE-60986 Change 4159302 by Ben.Marsh UGS: Update version to 1.144. Change 4160308 by Ben.Marsh All staging client executables for blueprint projects. #jira UE-60983 Change 4161567 by Steve.Robb GitHub #4816 : UE-60771: Handle escaped double quote in FParse::LineExtended Change 4162641 by Ben.Marsh UGS: Allow customizing the position of custom columns, via the Index=N attribute. Change 4162647 by Ben.Marsh UGS: Update version to 1.145. Change 4165319 by Robert.Manuszewski PR #4812: Fix inconsistent command-line argument handling under Windows (Contributed by adamrehn) Change 4166150 by Ben.Marsh UGS: Include *.inl when looking for code changes. Change 4166551 by Steve.Robb Whitespace fixes caused by a bad merge. Change 4168483 by Ben.Marsh UGS: Add a more useful error if a file to be synced exceeds the max allowed path length. Change 4168490 by Ben.Marsh UGS: Update version to 1.146. Change 4168551 by Ben.Marsh UBT: Move bBuildLargeAddressAwareBinary into an exposed setting. Change 4168560 by Ben.Marsh UBT: Remove static config variable for controlling which configuration of UHT to use. Change 4171296 by Ben.Marsh UGS: Move the check for overlong paths earlier. Change 4171531 by Ben.Marsh UBT: Fix exception if BuildConfiguration.xml contains an unknown category. Change 4183371 by Robert.Manuszewski Fix for a crash in Async Loading Graph's CheckCycles when GC kicks in on the game thread and forces ALT to exit early Change 4184312 by Ben.Marsh UGS: Update version to 1.148 Change 4184480 by Robert.Manuszewski Removing unused async loading stat Change 4186390 by Ben.Marsh UBT: Format XML validation errors in a format that allows double-clicking on the message in Visual Studio. Change 4188644 by Ben.Marsh UBT: Add the MakePathSafeToUseWithCommandLine() function to UBT. Change 4188647 by Ben.Marsh UBT: Fix exception in target receipt when architecture is null. Change 4189617 by Ben.Marsh Change FileSystemReference, FileReference and DirectoryReference objects to use OrdinalIgnoreCase comparisons without creating a separate copy of the string to compare. The filesystem does not use the invariant culture, and it can produce the wrong results in some cases (the ordinal comparison is faster, too). Change 4189740 by Ben.Marsh UAT: Remote code to build UnrealPak when packaging; we use the editor now. Change 4189860 by Ben.Marsh UGS: Make the filter for excluding automated lighting rebuilds more explicit. Change 4190082 by Ben.Marsh Fixes to allow enabling edit and continue for Windows builds. Have experienced quite a few VS crashes when testing it in editor; not yet recommended for general use. - Allow edit and continue for any configuration, not just debug. - Fixed PDB errors compiling files that use a shared PCH with edit and continue enabled. Path to the generated PDB file was using the wrong directory. - Removed code that tracks PDB output files, since they're modified multiple times during a build. - Enable debug information when compiling generated CPP files, since it causes errors if the shared PCH PDB doesn't have the same option. - Disable support for remote execution of steps that modify the PDB, since the same file has to be modified many times. Remote execution causes the PDB files to be corrupted. Unfortunately, this makes E&C builds significantly slower. #jira Change 4192949 by Ben.Marsh UBT: Minor tidy-up (merging UEBuildBinary.Build and UEBuildBinary.SetupOutputFiles) Change 4193218 by Ben.Marsh Fix formatting. Change 4197252 by Mike.Erwin UAT: Fix log output w/ correct count of non-code projects. #jira none Change 4197941 by Ben.Marsh UGS: Add support for DebugGame editors that have an executable with a DebugGame suffix. Change 4197964 by Ben.Marsh UGS: Prevent attempts to automatically reopen projects while a modal dialog is up, or the workspace is syncing. Change 4198144 by Ben.Marsh UGS: Prevent modal dialogs when login expires in P4, and prompt for password when hitting "retry". Change 4198413 by Ben.Marsh UGS: Always show the main window when launched manually, and run with -RestoreState when launched at startup. Also add a couple more places that save the visibility state, since logging off seems like it can terminate the process abrubtly. Change 4198779 by Ben.Marsh UBT: Allow generating manifests to any arbitrary locations with the -Manifest=<Path> argument. Change 4198825 by Ben.Marsh UBT: Move code to enumerate Slate runtime dependencies into the Slate module. Doesn't need to be done inside core UBT. Change 4199341 by Ben.Marsh UGS: Update version to 1.149 Change 4199642 by Chad.Garyet - Deprecate CISController - Add BuildController to replace CIS GET/POST for builds - Add LatestController, GET does what CIS/GET used to do - Change Latest/GET to return the last 25 builds filtered by project, rather than the last 5000 individual Ids - Latest/GET now returns "LatestData" object instead of array of longs - Updated EventMonitor to match all API changes - Fixed bug where IDs were getting reset to initial startup values every update loop Change 4199663 by Chad.Garyet CIS controller still needs to return an array of longs #jira none Change 4199680 by Ben.Marsh UGS: Update version to 1.150 Change 4200457 by Ben.Marsh Merging CIS fix for non-development configurations. Change 4200472 by Mike.Erwin UAT: fix -skipbuildclient param default It was defaulting to skipbuildeditor's value, likely a copy-paste error. #jira none Change 4202595 by Ben.Marsh Fix static analysis warning due to constant comparison against macro. Change 4203250 by Ben.Marsh UGS: Always show the "Sync Precompiled Editor" option, but disable it and show a tooltip explaining why if it is not available. Change 4206191 by Ben.Marsh Exclude editor target files from installed builds, since they leak info about DLLs that have been stripped out. Change 4213011 by Ben.Marsh UBT: Include contents of modified intermediate files in the log, to make it easier to debug hidden dependencies. Change 4213487 by Ben.Marsh UBT: Fix assumption that bPrecompile is equivalent to bBuildAllModules. This is no longer the case; they are now controlled by separate options. Should fix CIS errors building the editor. Change 4213609 by Ben.Marsh Ensure that strings formatted using FMicrosoftPlatformString::GetVarArgs() are always null terminated, whether we use the secure CRT or not. Change 4215971 by Ben.Marsh UBT: Remove action graph visualization code; no longer used. Change 4215996 by Ben.Marsh UBT: Remove unqiue id from all actions in the action graph. This is only used for printing debug info in the case of a (rare) cycle in the action graph, so just look it up when needed. Change 4216022 by Ben.Marsh UBT: Rename Crypto.cs to EncryptionAndSigning.cs to match the name of the class inside it, and move it under the System folder. Change 4216031 by Ben.Marsh UBT: Move all the action executors into their own folder in the project. Change 4216526 by Ben.Marsh Fix CIS warnings. Change 4216544 by Ben.Marsh Replace custom code to ensure FMicrosoftPlatformString::GetVarArgs() null terminates its buffer with Microsoft's standards-compliant implementation. Change 4216633 by Ben.Marsh Add support for UnrealPak plugins. * Project and plugin modules can now specify an array of supported programs in the "WhitelistPrograms" field of their module descriptors, to allow modules to be loaded by programs. * Programs can now load any runtime modules, as long as they are whitelisted. * Programs under the engine directory can now use a shared build environment, so that building with a project file does not cause output binaries to be output to the project directory. * UnrealPak is now always built by default when packaging * Convert UnrealPak to a modular configuration Change 4216736 by Ben.Marsh UnrealPak: Move "ExportDependencies" command into an editor commandlet, since it relies on the UObject system, asset registry, etc... Change 4217447 by Ben.Marsh Back out revision 50 from //UE4/Dev-Core/Engine/Build/InstalledEngineBuild.xml Change 4217451 by Ben.Marsh Back out revision 11 from //UE4/Dev-Core/Engine/Plugins/Developer/VisualStudioSourceCodeAccess/Source/VisualStudioSourceCodeAccess/VisualStudioSourceCodeAccess.Build.cs Change 4217617 by Ben.Marsh Back out changelist 4217451 Change 4222552 by Ben.Marsh Don't use #import <TypeLib> for VS source code accessor when building with Clang; it's not supported. Change 4222630 by Ben.Marsh UBT: Fix spam while generating project files if Clang isn't installed. Change 4223316 by Ben.Marsh UBT: Change the order in which Visual C++ toolchains are enumerated to prefer full releases over preview releases. Change 4223318 by Ben.Marsh UBT: Add a build setting which allows creating a dedicated PCH for every file that's excluded from the unity working set (disabled by default). Improves iteration times when working on individual cpp files, but slows down iterating on header changes (and can take a lot of disk space for large changes). Dedicated PCH contains all includes scraped from the top of each cpp file, until a non-#include directive is encountered. Change 4223401 by Ben.Marsh UBT: Add an option to automatically enable edit and continue for files in the adaptive non-unity working set. E&C doesn't seem very useful for UE4 projects right now; compile time is comparable to regular build times, but it can take several minutes to apply code changes for large projects. Change 4223899 by Ben.Marsh UBT: Fix loading XML config files on Mono; Type.GetField(Name) does not seem to return values unless binding flags are specified. Change 4224637 by Ben.Marsh Add a "SupportedPrograms" field to plugin descriptors, which allows plugins to declare which plugins they support independently of individual modules. Programs now respect the "bEnabledByDefault" setting in plugins. Plugins that are compatible with a program now need to list that program in the SupportedPrograms list, and whitelist any modules that should load for that program. Change 4224710 by Ben.Marsh UBT: Don't add import libraries as final build products unless the target is being precompiled. Prevents the need for building them for leaf nodes in the action graph. Change 4224715 by Ben.Marsh UBT: Remove hack to allow Stats2.cpp to not follow IWYU convention. Change 4224726 by Ben.Marsh Remove commented out line. Change 4224903 by Ben.Marsh Fix non-unity compile error in Stats2.h. Change 4225051 by Ben.Marsh Back out changelist 4224710; causing CIS errors due to receipts not matching. Change 4225134 by Ben.Marsh Fixing non-unity errors. Change 4225203 by Ben.Marsh Another non-unity fix. Change 4225249 by Ben.Marsh Fix Linux dependencies being copied for the Windows editor; they can be added as requirements for the Linux target platform on Windows instead, so it respects the user's chosen platforms. #jira UE-62001 Change 4225512 by Ben.Marsh BuildGraph: Allow setting the target to build when using the <CsCompile> task. Change 4228815 by Ben.Marsh UBT: Always add the generated code directory to the list of include paths when generating project files. It may only be created after UHT has been run. Change 4228944 by Ben.Marsh UBT: Remove legacy CppCompileEnvironment and LinkEnvironment wrappers from TargetRules that were deprecated in 4.19. Change 4229028 by Ben.Marsh UBT: Fix editor targets with unique build environment having the wrong executable path in generated project files. Move move logic to configure target rules post-construction by the rules assembly to ensure it's valid. Change 4229065 by Ben.Marsh UBT: Move another target setting into the rules assembly. Change 4229105 by Ben.Marsh Fix BPT exception when generating project files. Change 4229311 by Ben.Marsh UBT: Store the module rules file location on the ModuleRules instance, as well as the plugin that it was created from. Also expose the plugin directory as a property on the ModuleRules instance. Change 4229421 by Ben.Marsh UBT: Consolidate functionality for UHT module setup in ExternalExecution.cs. Change 4229817 by Ben.Marsh UBT: Modules must now explicitly specify the path to the header used to generate a PCH if one is desired, rather than the header being determined automatically by attempting to parse the source code. Now that PCHs are force-included anyway, this removes a lot of dependencies inside UBT. Change 4229824 by Ben.Marsh UBT: Remove unused lists inside UEBuildModuleCPP.SourceFilesClass. Change 4229841 by Ben.Marsh UBT: Remove some legacy code from auto-detecting PCHs. Change 4230521 by Ben.Marsh UBT: Add utility functions to the log class to allow formatting errors and warnings in Visual Studio output format (eg. File(Line): warning: Message) Change 4230871 by Ben.Marsh UAT: Remove StreamUtilis utility class; there is a simpler way to implement the one place it's used. Change 4230882 by Ben.Marsh UAT: Add StreamUtils back into UAT, seems like it's still used there. Change 4230896 by Ben.Marsh UBT: Remove some redundant parameters from UEBuildModule/UEBuildModuleCPP/UEBuildModuleExternal constructors. Change 4231014 by Ben.Marsh WorkspaceTool: Include a dump of raw bytes when garbage is read from the P4 process, for diagnostic purposes. Change 4231032 by Ben.Marsh Fix CIS. Change 4231096 by Ben.Marsh Bump the FlatCPPIncludeDependencyCache version, to prevent errors trying to load old files. Change 4231446 by Ben.Marsh UBT: Added support for expanding UE-specific variables in include paths and library paths: $(EngineDir), $(ProjectDir), $(PluginDir), $(ModuleDir). Change 4231460 by Ben.Marsh Modules may now explicitly specify rpaths on Linux via the PublicRuntimeLibraryPaths and PrivateRuntimeLibraryPaths properties. Change 4233909 by Robert.Manuszewski PR #4779: Reason fails as the supplied variable is incorrect (Contributed by projectgheist) Change 4233910 by Ben.Marsh Enable PCHs on IOS. Reduces build time by ~25%. Change 4234176 by Ben.Marsh UBT: Add better messaging for modules that need to have a private PCH set. Now detects the likely PCH using the same method as legacy code and includes it as a suggestion. Change 4234193 by Ben.Marsh Add the Delete command to Perforce wrapper in DotNETUtilities. Change 4234688 by Ben.Marsh UBT: Simplify handling of installed/precompiled builds. Settings for whether a folder is installed/read-only or not is now stored on the RulesAssembly instance, allowing multiple things to be configured separately and stacked together (eg. engine/enterprise/project). RulesAssembly.IsReadOnly() allows determining if a flie can be modified or not and replaces many previous IsXXXInstalledCalls(), and traverses the chain of assemblies. Change 4234711 by Ben.Marsh UBT: Runtime dependencies can now be copied to output directories as part of the build. When adding a runtime dependency, an optional source location can be specified to copy from. Both the source and target paths can use variables can be used as part of the path, eg. $(OutputDir), $(ModuleDir), $(PluginDir). Example usage (from a .build.cs file): RuntimeDependencies.Add("$(OutputDir)/Foo.dll", "$(PluginDir)/Source/ThirdParty/Foo.dll", StagedFileType.NonUFS); Change 4234872 by Ben.Marsh Expose a flag for whether the engine is installed, to fix issues generating project files. Change 4234929 by Ben.Marsh Fix null reference generating receipts when UBT makefiles are active. Change 4235883 by Chad.Garyet Merging 4231245 to core Giving Coordinator its own sln. This should fix what 4158155 was supposed to. #jira UE-61955 Change 4236075 by Ben.Marsh CIS fix Change 4237066 by Robert.Manuszewski Fix for a potential crash when terminating the engine while it's being initialized #jira UE-60545 Change 4237078 by Robert.Manuszewski The engine will no longer be resetting all linkers causing massive load times when renaming the world package when entering Play In Editor Change 4237116 by Ben.Marsh Rewrite some Windows utility functions to support paths longer than MAX_PATH. Change 4237158 by Ben.Marsh Add const TCHAR* overloads of FString::RemoveFromStart() and FString::RemoveFromEnd(). Change 4237159 by Ben.Marsh Fix FWindowsPlatformFile::GetFilenameOnDisk() support for paths longer than MAX_PATH, and simplify some of the other long path functions to avoid copying string buffers. Change 4239050 by Ben.Marsh Missing file Change 4239318 by Ben.Marsh Linux CIS fix. Change 4239685 by Ben.Marsh Static analysis CIS fix. Change 4240800 by Ben.Marsh WorkspaceTool: Include the full command line in the log for any P4 commands. Change 4240903 by Ben.Marsh PR #4909: Update copyright notices to 2018 (Contributed by projectgheist) Change 4241025 by Ben.Marsh UBT: Exclude mobile pipeline caches from generated project files. Causes huge slowdown when using 'Find in Files' through the IDE. Change 4241770 by Ben.Marsh UBT: Include action number in parallel executor output. #jira UE-62032 Change 4243469 by Ben.Marsh TBA: Merge FAnnotatedStructuredArchiveFormatter with FStructuredArchiveFormatter. Any functions that are only implemented for text archives now have a _TextOnly suffix, and are exposed through the FStructuredArchive interface. Change 4245723 by Robert.Manuszewski Fixing another creash when terminating the engine while initializing. #jira UE-60545 Change 4245862 by Steve.Robb VectorLoadFloat2(Ptr) added, which loads { Ptr[0], Ptr[1], Ptr[0], Ptr[1] } into a VectorRegister. Change 4246412 by Robert.Manuszewski The warning 'Calling StaticLoadObject during PostLoad may result in hitches during streaming' will now also report the object which had the PostLoad called on it when StaticLoadObject call happened. Change 4246612 by Ben.Marsh UBT: Fix spelling of "Intellisense". Change 4249454 by Robert.Manuszewski Added extra checks to catch scenarios where the EDL Precache Buffer is flushed before a package header is fully read Change 4249513 by Robert.Manuszewski Made sure the Async Loading Thread doesn't continue running after creating new async packages when garbage collector wants to run on the game thread Change 4255207 by Ben.Marsh UGS: Add additional logging whenever a P4 command fails, and when the user is logged out. Change 4255288 by Ben.Marsh PR #4921: Honor ModuleRules' bEnableExceptions flag when creating precompiled h. (Contributed by surakin) Change 4256422 by Ben.Marsh UBT: Add an error if a module referenced by a plugin descriptor doesn't exist. Change 4257385 by Robert.Manuszewski Creating new objects from within ForEachObjectWithOuter will now result in a fatal error as it's unsafe to change internal UObject hash tables when iterating over them. Change 4257454 by Robert.Manuszewski Added the option to filter clusters listed with gc.ListClusters by objects within them. Usage: gc.ListClusters Hierachy With=ObjectName1,ObjectName2... Change 4257526 by Robert.Manuszewski It's now possible to filter clusters that get logged with verbose cluster logging enabled (UE_GCCLUSTER_VERBOSE_LOGGING=1) by objects within them by specifying -DumpClustersWithObjects=ObjectName1,ObjectName2 in the command line Change 4257822 by Ben.Marsh Fixes for PlatformShowcase compile errors. Change 4258771 by Ben.Marsh UBT: Fix project files not being generated for foreign projects when creating .stub files. #jira UE-62462 Change 4258790 by Ben.Marsh UBT: Clean up the logic around generating project files before creating a stub IPA, so that it fails loudly if project files do not exist, and can accept target names not matching project names. Change 4259276 by Ben.Marsh UBT: Make it an error if a framework doesn't exist, rather than failing silently. Also remove some remote toolchain stuff that's no longer necessary. Change 4259280 by Ben.Marsh UBT: Fix embedded framework zips not being uploaded for plugins. #jira UE-62485 Change 4260236 by Ben.Marsh UBT: Fix path to generated engine project file. Change 4260334 by Ben.Marsh UGS: Fix custom build steps dialog inadvertantly modifying config file settings in-place. Change 4260361 by Ben.Marsh UGS: Allow for p4 login commands to fail, even though the user is logged in (due to a bad connection, etc...) Change 4260559 by Ben.Marsh UGS: Update version. Change 4261160 by Robert.Manuszewski MediaPlaylist will now be added to root set if the owning MediaPlayer is in the disregard for GC set (fixes GC assumption violation crash) #jira UE-62495 Change 4261421 by Ben.Marsh Force-sync files for building documentation, to fix issues with files not being updated. #jira UE-62413 Change 4261425 by Ben.Marsh UBT: Remove some leftover functions for handling the remote toolchain. Change 4261530 by Ben.Marsh UBT: Speculative fix (and better error reporting) for IOS mobile provision not being found in CIS. Change 4261611 by Ben.Marsh UBT: Downgrade warning to a log message, since it appears when generating project files. Change 4261710 by Ben.Marsh Remove assert that GLogConsole is set; it won't be for command line utilities that don't depend on ApplicationCore. #jira UE-62545 Change 4261831 by Ben.Marsh Fix compile errors due to missing include path when hot-reloading a module from the editor. There are not necessarily source files to compile when -modulewithsuffix is specified on the command line, which was results in GeneratedCodeWildcard not being set. #jira UE-62463, UE-62384 Change 4262723 by Ben.Marsh Whitelist plugins that need to be loaded by UFE. #jira UE-62564 Change 4265444 by Ben.Marsh Fix incorrect executable name for DebugGame configurations in Xcode. #jira UE-62574 Change 4265892 by Ben.Marsh Fix incremental compile failures due to dependency checking for unity files. CachedIncludePaths was not correctly being set on file items, so dependencies were being ignored. #jira UE-62575, UE-62603, UE-62597 Change 4266019 by Josh.Adams - Fixed the CopyAction for runtime dependencies that need to be copied to different location, on non-XGE Change 4266264 by Ben.Marsh Remove override for the __IPHONE_OS_VERSION_MIN_REQUIRED macro on TVOS. This macro is already defined by system headers (in <AvailabilityInternal.h>). Now that we support PCHs on IOS and TVOS, manually defining this macro results in it being defined three times (once for the PCH, once by AvailabilityInternal.h, and once by the force-included list of definitions for the source file being built). The errors for redefining the macro in AvailabilityInternal.h are suppressed due to it being a system header, but the error for redefining it for the source file being compiled are not. #jira UE-62578 Change 4266273 by Ben.Marsh Fixes incremental build failure when compile arguments for PCH have changed on IOS/TVOS. Compile action needs to have a dependency on PCH build action. Change 4266614 by Graeme.Thornton Fix crash when cooking nativized blueprints due to removal of child cooker system. Change 4266763 by Ben.Marsh Always build UnrealPak when building client targets. The ProjectParams.Pak option is not reliable, because it can be forced on later by the target platform. #jira UE-62584 Change 4267985 by Robert.Manuszewski When iterating with ForEachObjectWithouter, don't lock the entire has table but only the hash bucket that is currently being iterated #jira UE-62600 Change 4268558 by Robert.Manuszewski PurgeLegacyBlueprints will no longer be called from within ForEachObjectWithOuter is it renames objects that reside in hash tables that are being iterated over which may lead to undefined behavior. #jira UE-62600 Change 4269011 by Chad.Garyet - Fixing Wildcard match issue, the change to ugsapi sends projects as //Depot/Stream instead of //Depot/Stream/ Wildcard match was only substringing to 3 chars. - Checking in the change a while back that increases the number of queried jobs up to 432 based on some maths from Bob about how many builds we want to grab Published to ugsapi server 8/8/17 #jira none Change 4270788 by Ben.Marsh Fix IOS provisioning data being using when remote compiling on TVOS. #jira UE-62705 Change 4271916 by Ben.Marsh Tag the XGEControlWorker executable as a build product after compiling SCW, to make sure it's included in the UGS zip file. Change 4271934 by Ben.Marsh Upload all static libraries in plugin folders as part of remote builds. #jira UE-62694 Change 4273368 by Ben.Marsh Fix Slate dependencies not being enumerated, and rules assembly not being rebuilt when building remotely. #jira UE-62705 Change 4274049 by Ben.Marsh Always parse the team UUID out of the mobile provision when doing a remote compile. The provision installed on the remote Mac (and selected for signing) may be different. #jira UE-62751 Change 4274823 by Ben.Marsh Add the -VersionCookedContent argument to disable the -unversioned parameter on the cooker command line. Change 4275838 by Ben.Marsh Fix BuildVersion string not being passed through from <SetVersion> task. Also add a -BuildVersion command line argument to UBT to override it for a particular build. Change 4275913 by Ben.Marsh Add a dummy exported symbol to the XGEController module, to fix build errors due to missing .lib file when it's built with WITH_XGE_CONTROLLER = 0. Change 4284161 by Ben.Marsh Allow mirroring Oodle files to remote Mac. Change 4074774 by Steve.Robb Vast simplification of TFunction, making it smaller in footprint, easier to follow and extend, and more correct. TUniqueFunction added, which is a move-only TFunction which can hold move-only functors. Fix for UWidgetBlueprint::ForEachSourceWidget() which should never have compiled but did. FFunctionGraphTask and TFuture<> updated to use TUniqueFunction to make them more general. TArray::HeapPop() made to work with move-only types. Change 4082591 by Ben.Marsh Move the Log class from UBT to DotNetUtilities. Change 4083236 by Ben.Marsh Add a Log.WriteException() method to dump an exception message to the console (and write the exception trace to the log) Change 4084107 by Ben.Marsh UAT: Remove the unused -SkipHeader argument to UE4Build. Change 4089771 by Steve.Robb GitHub #4743 : modified VirtualAlloc function flag https://blogs.msdn.microsoft.com/oldnewthing/20151008-00/?p=91411 Change 4091456 by Steve.Robb Unification of all platforms' FMath::CountTrailingZeros() and FMath::CountLeadingZeros() for both 32-bit and 64-bit. Change 4156437 by Ben.Marsh Lots and lots of fixes compiling for Clang on Windows. Editor now compiles cleanly without warnings, but crashes on startup due to error in intrinsics test. Disabling that runs further, but crashes accessing freed memory. Switching to the ANSI allocator runs further, but crashes in Slate after the splash screen and before the editor window opens. // TODO! * Switching between Clang/ICL/VS2015/VS2017 is now supported through the same mechanism as switching Visual Studio versions, without requiring any source level changes. To use Clang, set WindowsPlatform.Compiler = WindowsCompiler.Clang from a .target.cs file, or set <WindowsPlatform><Compiler>Clang</Compiler></WindowsPlatform> from BuildConfiguration.xml. To pick a specific toolchain version, set WindowsPlatform.CompilerVersion. * Clang is now supported through AutoSDKs; will be added to CIS. * The Samples/Sandbox/Clang project forces Clang to be used from its target.cs file, and allows easily building all editor modules and plugins with Clang on Windows. * UnrealMathSSE intrinsics have been re-enabled for Clang due to missing functions from the UnrealMathFPU implementation, but causes failure in tests at startup. * SSE4_CRC32() is disabled in D3D12Pipelinestate.cpp, since intrinsics are only allowed if enabled for the whole target (rather than being used in specific functions due to runtime checks) Change 4157389 by Ben.Marsh Few more fixes for compiling the editor with Clang. Change 4183911 by Ben.Marsh Fixes to support incremental linking on Windows. Does not seem to have any net benefit right now; may improve once minimal rebuild is enabled. * Incremental linking no longer forces PDB files to be enabled for source files. * Actions can specify specific files to be deleted before each build. Code to forcibly delete PDB files has been moved to the MSVC toolchain. * Unused libraries produced by the cross-referenced link are no longer added as build products, since (a) deleting them breaks dependency checking for incremental linking and causes a full link, and (b) not deleting them breaks UBT dependency checking and causes actions to be run over and over again. * Icon update is disabled for Windows when incremental linking is enabled. * Removed rarely-used setting to always delete produced items before each build. Change 4184311 by Ben.Marsh UGS: Added a dialog which shows all the required platform SDKs for a branch, linked from the status panel in UGS. The llist is configured via the UGS config file submitted to Engine/Programs/UnrealGameSync/UnrealGameSync.ini (and may be overridden by the project config file if necessary): [Default] ; Set this to a network share which contains the SDK installers for your site SdkInstallerDir= ; All the required SDKs for the current version of the engine +SdkInfo=(Category="Android", Description="NDK r21", Browse="$(SdkInstallerDir)\\Android") +SdkInfo=(Category="Windows", Description="Visual Studio 2017") +SdkInfo=(Category="Windows", Description="Visual C++ Toolchain 14.13.26128") +SdkInfo=(Category="Windows", Description="Windows SDK 10.0.16299.0") Similar entries for console platforms are added in console subdirectories. Each entry may contain an Install="Foo.exe" and/or Browse="C:\Foo" style attribute, specifying the path to an installer to run or directory to open in explorer respectively. The SdkInstallerDir setting is used as a base directory for the default installers, seen above for Android. Licensees may override this with a network path specific to the site that UGS is being deployed to (either in this file, in a project specific config file, or in a Engine/Programs/UnrealGameSync/NotForLicensees/UnrealGameSync.ini file). Change 4200452 by Ben.Marsh UBT: Change DebugGame configurations to output a separate executable rather than requiring a -Debug argument at runtime. Previous behavior was a common source of errors. Engine modules are still shared between Development and DebugGame, but the launch module sets a flag in Core on startup indicating the game configuration. Change 4206189 by Ben.Marsh UBT: Simplify logic for precompiling binaries. * Target no longer has separate list of "precompile only" binaries or modules. New -AllModules option allows adding every module to a target, which can be used with -Precompile and -NoLink to precompile object files for monolithic builds. * Precompiled file lists have been removed from target receipts. * The manifest now includes all generated headers and precompiled files when run with the -Precompile option. * Separate -DependencyList=Foo.txt has been added to write a list of all dependencies required to use precompiled binaries. This file list can be read using the <Tag> task in buildgraph. Change 4215466 by Ben.Marsh UBT: Remove indirect calls to determine extensions for object files and precompiled headers. The toolchain knows the correct convention for the platform. Change 4215975 by Ben.Marsh UBT: Remove telemetry code. This has never proved useful for analyzing performance due to the number of incidental factors that affect build times (eg. number of files being compiled). Change 4220154 by Ben.Marsh Move text-only implementations of FOutputDeviceError back into Core, so we can build command-line applications that don't depend on ApplicationCore. Change 4224708 by Ben.Marsh Add a bCompileAgainstApplicationCore setting to the target rules, which allows compiling out references to the ApplicationCore module (which should only be necessary for applications with a GUI). Removed ApplicationCore from several engine tools and utilities. Change 4224958 by Ben.Marsh Remove CoreMinimal.h includes from Core. Change 4229059 by Ben.Marsh UBT: Remove the UEBuildPlatform.ShouldNotBuildEditor() hook for target platforms. We shouldn't be modifying a target's build environment to disable the editor; it is invalid to build the editor for these target platforms at all, and this is already enforced by the GetSupportedPlatforms() function. Change 4230508 by Ben.Marsh Fixup precompiled header setting for samples and games. Change 4231457 by Ben.Marsh Fix exceptions in log messages having trailing newlines. Change 4232406 by Ben.Marsh UBT: Always force include a PCH for generated code if there's one set; the code may depend on it to compile. Change 4234177 by Ben.Marsh Set up private PCH files everywhere that previously used them. Change 4235973 by Ben.Marsh Change FPlatformMisc::GetEnvironmentVariable() to return an FString() rather than requiring a fixed size buffer to be passed in. Removes references to MAX_PATH. Change 4238842 by Ben.Marsh Add support for paths longer than MAX_PATH in the editor. Requires Windows 10 version 1607, and the functionality to be enabled via a registry key or group policy (see https://docs.microsoft.com/en-us/windows/desktop/FileIO/naming-a-file). Only a subset of Win32 functions support long paths (executables can only be started from paths shorter than MAX_PATH, for example). * Added a FPlatformMisc::GetMaxPathLength() function to return the maximum length of a path on the current system. On Windows, this returns a different value for systems with long paths enabled to those without. * The MAX_PATH define is no longer set by non-Windows platforms. Instead, there is a MAC_MAX_PATH, UNIX_MAX_PATH, etc... for any platform-specific code that still relies on the previous macro. * The MAX_UNREAL_FILENAME_LENGTH macro has been renamed to MAX_UNREAL_FILENAME_LENGTH_DEPRECATED * The PLATFORM_MAX_FILEPATH_LENGTH macro has been renamed to PLATFORM_MAX_FILEPATH_LENGTH_DEPRECATED. * Removed custom resource files for programs, since they are just copies of the base UE4 one (which is used by default anyway). The base UE4 manifest declares support for long paths. * Fix 512 character maximum length on editor commands. 260 character limit remains in place for cooking at the moment (see ContentBrowserUtils.h), until C# staging code supports long paths. Change 4255042 by Ben.Marsh UBT: Remote compilation now uploads the entire workspace to the remote Mac and executes a separate remote instance of UBT rather than synchronizing individual actions. This makes the remote compile codepath much simpler, and removes a lot of special cases that exist to support it previously. The list of files to be transferred to the remote are listed as rsync filter rules in Engine/Build/Rsync/RsyncEngine.txt and RsyncProject.txt, which are applied to the root engine directory and project directory respectively. Projects that need to customize which files are uploaded can add their own <ProjectDir>/Build/Rsync/RsyncProject.txt file, which will be included in the filter before the default version. Change 4260567 by Ben.Marsh UAT: Rename CommandUtils.Log to CommandUtils.LogInformation, to avoid conflicts with the underlying Tools.DotNETCommon.Log class. #rb none [CL 4285673 by Ben Marsh in Main branch]
2018-08-14 18:32:34 -04:00
LogInformation("Client exited, stopping server....");
if (!GlobalCommandLine.NoKill)
{
ServerProcess.StopProcess();
}
bKeepReading = false;
}
return bKeepReading; // Keep reading
});
}
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 4285612) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3836829 by Ben.Marsh UBT: Fix ability to precompile plugins from installed engine builds. Change 3839519 by Ben.Marsh UBT: Simplify configuring bPrecompile and bUsePrecompile settings for modules. Each rules assembly can now be configured as installed, which defaults the module rules it creates to use precompiled data. Change 4042043 by Steve.Robb GitHub #4705 : Added weak lambda's for delegates and multicast delegates. Change 4042056 by Robert.Manuszewski Optimized Mark Phase of GC by up to 10ms by making it run in parallel and removing a huge array presize which we didn't need. Change 4042104 by Robert.Manuszewski Set the minimum GC cluster size to 5 so that GC doesn't have to process micro clusters which are more expensive than processing individual objects + Exposed the minimum cluster size to ini and project settings as gc.MinGCClusterSize + Added the ability to sort clusters by name/object count/mutable object count/referenced clusters count when dumping them with gc.ListClusters command Change 4042377 by Robert.Manuszewski Reworked how GC and other threads (ALT specifically) interact - GC will now notify the ALT it wants to run and ALT will immediately try to finish its current work to allow that. Also the entire ALT tick is now protected against GC running at the same time to improve ALT stability. + added gc.ForceCollectGarbageEveryFrame console variable that triggers a forced GC every frame Change 4042427 by Robert.Manuszewski Changed FGCCSyncObject to use events when waiting for GC to finish so that it doesn't spin on non-game threads when GC is running Change 4042482 by Robert.Manuszewski Unhashing unreachable objects (ConditionalBeginDestroy) will now also be done incrementally, just like the purge phase of Garbage Collection Change 4042635 by Robert.Manuszewski Fix for a potential assert when incremental purge garbage is pending and something forces a full purge Change 4044092 by Steve.Robb Fix for forward declared CoreUObject weakobject types in delegates when building in Clang. Change 4044102 by Robert.Manuszewski Fix for a possible hang when worker threads are preventing GC from running and something is later trying to FlushAsyncLoading with the Async Loading Thread enabled Change 4044113 by Steve.Robb Another Clang fix. Change 4044160 by Robert.Manuszewski Disregard For GC pool will now be enabled by default in cooked builds Change 4044287 by Steve.Robb Typo fix. Change 4047723 by Graeme.Thornton TBA: Fixes for import/export name cache and object resolving Change 4048015 by Graeme.Thornton TBA: Weak/Soft/Lazy pointer serialization changes * Remove FWeakObjectPtr::Serialize, move it's logic into, and replace usages of with calls to, FArchiveUObject::SerializeWeakObjectPtr(). Ensures that something is always sent to the archive so that structured archives can be kept happy in the future. * Added Weak/Soft/Lazy pointer handling to the structured archive slot interface and all the formatters. Binary formatters just forward the call onto their inner and text archives store as a string path reference. * FArchiveUObjectFromStructuredArchive caches all these pointer types and stores indices in the binary block, same as with a UObject*. All pointers are then forwarded to the underlying formatter in one go on finalization. Change 4048021 by Steve.Robb Fix for binding an unbound TFunction to another TFunction with a different signature. Also all null pointers now count as unbindings, not just nullptr. TIsMemberPointer added. TIsATFunction and TIsATFunctionRef renamed to remove the 'A's. Change 4048544 by Robert.Manuszewski Fixing ConditionalBeginDestroy profiling after changes to incremental CBD. Change 4051028 by Graeme.Thornton TBA: ArchiveFromStructuredArchive adapter uses Inner to determine if it is outputting to text, and sets it's own ArIsTextFormat to false Change 4051056 by Graeme.Thornton TBA: High level tagged property / UObject base class text serialization - UObject serialize converted to structured archive - Properties written to text individually with text tags, and then binary adapted values - Only saves, doesn't load Change 4051111 by Graeme.Thornton TBA: Temporarily disable loading of text assets until tagged property serialization path is fixed up Change 4051154 by Graeme.Thornton TBA: Convert a few uobject serializers to structured archive format for example purposes Change 4051181 by Graeme.Thornton TBA: Added default structured archive implementation of SerializeItem to UProperty, which just calls the FArchive version on an FArchiveUObjectFromStructuredArchive adapter. Implemented structured archive SerializeItem for UArrayProperty Change 4051197 by Graeme.Thornton TBA: ObjectProperty text serialization Change 4051216 by Graeme.Thornton Restored a modified FWeakObjectPtr::Serialize function to keep backwards compatibility in code I don't have access to. Change 4051261 by Graeme.Thornton TBA: Convert UMetaData to structured archive Change 4051374 by Steve.Robb Incorrect assert removed. Change 4051562 by Robert.Manuszewski Adding stats for the new GC internal functions Change 4051614 by Graeme.Thornton TBA: Removed UProperty::SerializeItem(FArchive, ...) and replaced with UProperty::SerializeItem(FStructuredArchive::FSlot, ...). Fixed up most of them to work properly and added adapters in for any that were non-trivial. Change 4052512 by Graeme.Thornton TBA: Temporary workaround for softobjectptr and lazyobjectptr uproperties not serialization anything when they know the archive is a reference collector. They should always be serializing their pointers and letting the underlying archive itself ignore them. Change 4053917 by Robert.Manuszewski Clustered objects from clusters that are no longer reachable will now be marked as unreachable immediately when gathering unreachable objects Change 4053919 by Robert.Manuszewski Added the ability to disable incremental BeginDestroy in ini/project settings Change 4055518 by Daniel.Lamb Fixup for deterministic audio generation issue. Submitted on behalf of Rich.Whitehouse #jira nojira #test prefilght automated test. Change 4056854 by Graeme.Thornton TBA: Added a test asset to EngineTest which contains all the different property types and test cases. Change 4056858 by Graeme.Thornton TBA: Updated USetProperty to proper structured archive usage Change 4056872 by Graeme.Thornton TBA: Add map property field to test object Change 4056873 by Graeme.Thornton TBA: Convert UMapProperty to full structured archive Change 4056994 by Graeme.Thornton TBA: Converted FText over to structured archive. Implemented saving, but not loading. Change 4059728 by Ben.Marsh UBT: Add support for using adaptive non-unity builds when the engine and project are in separate repositories. Change 4059805 by Graeme.Thornton Fixed typo in text serialization. Fixes CIS automation test errors Change 4060007 by Graeme.Thornton TBA: FArchiveFromStructuredArchive will now access it's host slot lazily, i.e. only when a value is actually written to the archive. Change 4060092 by Stefan.Boberg Added optimized Windows console window output path to GenericConsoleOutput since this slowed down cooking considerably (2 minutes spent in wprintf alone for one large dataset) When stdout is attached to a console we use the WriteConsoleW function instead of wprintf since the latter is very slow especially in unbuffered mode which the engine currently configures for stdout (see setvbuf call in LaunchEngineLoop.cpp). At some point we should reconsider this buffering policy since it's likely to slow down other platforms as well but I wanted to do a safe change for now as I don't yet fully understand why the setvbuf call is there in the first place. Change 4060108 by Stefan.Boberg Introduced some additional target platform utilities to help with asset cook optimizations * We now assign each ITargetPlatform a zero-based ordinal value * Introduced FTargetPlatform and FTargetPlatformSet types to help store platform references and platform sets efficiently. These are not currently used in the engine but are designed to replace the existing ITargetPlatform/string/FName representations in the cooking data structures. Change 4060143 by Graeme.Thornton Undo //UE4/Dev-Core/Engine/Source/Runtime/... changelist 4060007 Needs some other changes that I haven't checked in yet... Change 4062432 by Ben.Marsh Fix error message when enumerating P4 changes. Change 4062648 by Ben.Marsh Add missing p4 integration action. Change 4063620 by Graeme.Thornton Integrated a fix from UDN where the engine would crash when trying to load a very small encrypted file (<16bytes) from a pak file, where the read address wasn't already aligned to the AES block size. (https://udn.unrealengine.com/questions/431989/crash-while-reading-a-very-small-file-in-encrypted.html) Change 4066963 by Robert.Manuszewski Fixing GC cluster verification code reporting false positives when a cluster is referencing another cluster through 'mutable' objects list. Change 4067133 by Robert.Manuszewski Changed log verbosity when reporting individual cases of GC cluster assumption violations as they are followed by an asser anyway and this way we get the chance to see all issues before we assert at the end of these checks. Change 4067443 by Steve.Robb FString can now be constructed from any char pointer type and length. Change 4068156 by Steve.Robb Fix necessary because of FString constructor change in CL# 4067443. Change 4070258 by Graeme.Thornton Fixes for VSCode Change 4070372 by Graeme.Thornton TBA: Script struct serialization to structured archives Change 4071913 by Ben.Marsh Move bulk of the code for UnrealPak into an engine developer module, so it can be used in the editor. Change 4071914 by Ben.Marsh Missing files. Change 4071937 by Ben.Marsh Missing header. Change 4072015 by Ben.Marsh Fixes for compiling PakFileUtilities as part of the editor. Change 4072826 by Steve.Robb TBitArray::Reserve() added. TBitArray::Add() overloaded to allow adding multiple bits. TSparseArray::Reserve() optimized to call the overloaded Add(). Change 4073271 by Daniel.Lamb Fixed add patch tier in project launcher passing the wrong commandline option to UAT. #test none Change 4074708 by James.Hopkin #core Removed redundant Casts Change 4074763 by Steve.Robb Fix for TSparseArray::Reserve() size. Change 4076063 by Ben.Marsh Add an "UnrealPak" commandlet with the same functionality as the standalone UnrealPak program. Invoke by running the editor with -run=UnrealPak and the standard UnrealPak commandline options. Change 4077064 by Robert.Manuszewski Fixing compile error in PakFileUtilities Change 4077144 by Graeme.Thornton TBA: TextAssetCommandlet improvements * Collect lists of broken assets during roundtrip tests and print a summary of packages that failed each phase at the end * After resaving as text, load the file back as a plain JSON hierarchy to ensure the output was valid Change 4077412 by Ben.Marsh Set the correct exit code for UnrealPak. Should return 0 on success, not 1. Change 4077760 by Graeme.Thornton TBA: Loading fixed for tagged property serialization Includes conversion of all UProperty::ConvertFromType() and SerializeFromMismatchedTag() functions to use structured archives Lazy initialization of FArchiveFromStructruredArchive when loading, to support the possibility of an adapter being create around an object property serialize call to its inner UStruct, which then decides not to do anything and return false. Stops the ArchiveFromStructuredArchive from consuming the slot and getting upset later on when we try to serialize normal tagged properties from it. Disabled lazy bulk data loading from text assets. Requires a bigger change to make it work. Added some debug checks to json input formatter which track the current value stack size when a new object is pushed onto the stack, and makes sure that the stack has returned to the same size when the object is popped. Catches cases where we unpack an array/stream to the value stack but then don't consume all the items. Change 4078800 by Ben.Marsh Change UAT to using the editor's UnrealPak commandlet rather than invoking the standalone UnrealPak executable. To improve performance when building several PAK files, also add a new -batch=<file> command which reads commands to execute in parallel from a text file. Change 4079745 by Graeme.Thornton TBA: Migrated a couple of UObject Serialize functions to FStructuredArchive (SoundCue / MaterialExpressions / Editor strip flags) Change 4079847 by Graeme.Thornton TBA: Add 'FindMismatchedSerializers' mode to text asset commandlet, which dumps out a list of all UClasses which don't have the CLASS_MatchedSerializers flag, meaning we can't guarantee the have Serialize functions for FArchive AND FStructuredArchive, therefore we can't use the new structured archive based serialize path. Should only ever be native instrinsic classes as UHT takes care of all other cases. Change 4079925 by Ben.Marsh Fix incorrect assignment when deriving name for chunked pak file. Change 4080214 by Ben.Marsh Move the ThreadPoolWorkQueue class into DotNETUtilities so it can be used by other projects. Change 4082394 by Graeme.Thornton CIS fix for variable shadowing warning Change 4082583 by Ben.Marsh Add a IBinarySerializable interface for types that support reading from a BinaryReader and writing to a BinaryWriter. Implementing IBinarySerializable implies a constructor taking a BinaryReader argument is available for deserializing. Change 4082652 by Ben.Marsh Fix FileReference.Directory not returning a directory with a trailing backslash for files in the root directory. Change 4082755 by Graeme.Thornton Fixed an erroneous usage of TUniquePtr<uint8>as a pointer to a uint8 array when creating pak files. Caused a crash when compression was enabled, and has probably surfaced because pak generation is now done by an editor commandlet rather than a standalone program. Change 4082756 by Graeme.Thornton Fixed some incorrect documentation for pakfile compressed chunk headers Change 4082883 by Graeme.Thornton Static analysis warning fix Change 4082912 by Ben.Marsh Move ExceptionUtils into DotNETUtilities. Change 4085291 by Graeme.Thornton TBA: In the Json output formatter, write float and double values out with enough precision for successful roundtripping. Added some debug only code which will immediately reconvert the string back to its original value and compare the the input Change 4085523 by Graeme.Thornton TBA: Remove only explicit usage of DECLARE_FSTRUCTUREDARCHIVE_SERIALIZER. Should only be used from UHT generated code. Change 4086037 by Robert.Manuszewski Fix for a potential race condition when two threads want to acquire GC lock Change 4088655 by Graeme.Thornton Pak creation now uses the bEnablePakSigning setting from the crypto config json file Change 4091474 by Steve.Robb Fix for TStaticBitArray::FindFirstSetBit() and TStaticBitArray::FindFirstClearBit(). Unused variables removed. Change 4093632 by Steve.Robb CIS fixes. Change 4093656 by Graeme.Thornton Build fix Change 4093744 by Ben.Marsh Allow per-chunk settings for whether to enable compression in UnrealPak. Change 4099712 by Gil.Gribb UE4 - Fixed rare case where insufficient space was preallocated for cooldown ticks. #jira UE-59686 Change 4099912 by Stefan.Boberg Cooking timer optimizations: - Replaced data structures for FScopeTimer and FHierarchicalTimerInfo. Previous implementation used FString for many things and caused *lots* of heap and string concatenation activity. Replaced with a compile-time node id (using __COUNTER__) and raw string literals. - Removed PERPACKAGE_TIMER support (was disabled by default and was difficult to test) - Made it possible to toggle OUTPUT_TIMING and ENABLE_COOK_STATS independently - Removed some extremely tight timers because the overhead from calling QPC significantly exceeded the measured code This change shaved some 15% off a clean cook of Fortnite WindowsClient (en) with fully populated local DDC Change 4100519 by Stefan.Boberg Quick fix for Linux build issue introduced in 4099927 Change 4105327 by Stefan.Boberg Cooker: Changed FHierarchicalTimerInfo so it uses a linked list for tracking child nodes, to be able to deal with any child count. Previously we assumed there would never be more than 9 children but it turns out there are cooker modes that need more. Fixes check when using -FullLoadAndSave to cook Change 4105448 by Stefan.Boberg - Fixed Linux build warning re: member initialization order - Also eliminated OUTPUT_HIERARCHYTIMERS/CLEAR_HIEARCHYTIMERS macros (plain functions are fine) - Moved finishing-up code for FullLoadAndSave() to TickCookOnTheSide() call site to improve timer output. Previously some of the scopes would not have been closed before printing and thus the output was misleading. Change 4109031 by Ben.Marsh Attribute-driven Perforce wrapper (old Epic Friday project). Offers a more complete implementation than the current P4 wrapper in UAT without requiring any platform-specific libraries. Uses the Python binary output for parsing. Change 4109588 by Ben.Marsh UBT: Add extension methods for serializing a nullable type to a BinaryReader/BinaryWriter. Change 4109595 by Ben.Marsh Missing project file for DotNETUtilities. Change 4110724 by Stefan.Boberg Removed annotation map locking in UObjectMarks, eliminating around one minute (~3.5%) from Fortnite cook time. The locking was redundant since the annotation maps are managed per thread anyway. Change 4111304 by Ben.Marsh UAT: Add support for setting a status message through the log class. Allows writing transient messages (eg. progress messages) which will be cleared out before writing other messages. Best used through the LogStatusScope class, which can set a status message for the duration of a using() block. As part of this change, the console no longer has to be added as a dedicated trace listener. Since we already special-case this listener when formatting log output, it's easier to just keep the implementation separate to the other trace listeners. Change 4112708 by Steve.Robb Fix for TBitArray::MaxBits in assignment. Change 4114133 by Stefan.Boberg Tweaked how low-level memory (LLM) tracker is implemented to reduce overheads. Previously FMemory functions would acquire the LLM singleton and call OnLowLevelFree/OnLowLevelAlloc etc which would check the bIsDisabled flag and early out if it was set. Due to how frequently these functions were called this ended up costing quite a bit. - This change makes the flag a static member variable instead of a member variable and therefore enables a simpler early-out to be implemented. - The singleton getter is also simplified to avoid hitting the threadsafe singleton construction path on every call. - The enable flag is no longer TAtomic - this also incurs extra overhead for no clear benefit Shaves approximately 3.5% (one minute) off a Fortnite cook test scenario (using -FullLoadAndSave) Change 4115010 by Robert.Manuszewski Fixing CIS Change 4115249 by Robert.Manuszewski Fixing async loading code asserts when exiting game very early due to an error #jira UE-56267 Change 4117091 by Ben.Marsh Prevent doubled-up lines when writing status updates with console log verbosity. Change 4117207 by Ben.Marsh UGS: Do not include executables in diagnostics zip file, and ignore "no such files" error when cleaning workspace. Change 4119175 by Ben.Marsh UGS: Fix crash writing version files when directory does not already exist. Change 4119987 by Ben.Marsh UGS: Show a dialog box while the launcher is updating executables from Perforce, which allows cancelling the operation if necessary. Allow setting the username on the settings window, and prompt for login credentials if necessary. Should prevent situations where users have to update settings from the command prompt. Holding down shift during launch now shows the settings dialog rather than an immediate prompt to launch the unstable version (unstable version is shown as a checkbox on this dialog). Change 4119991 by Ben.Marsh Update version number for UGS launcher to 1.13. Change 4121943 by Robert.Manuszewski Don't use FArchiveAsync2 for reading packages with non-async path in editor builds as its performance is worse than the standard archive's (saves about 1 minute when doing larger cooks and 7 seconds when loading into PIE) Change 4122592 by Steve.Robb GitHub #4762 : Improve wording and grammar of Math comments Also includes improved accuracy in FMath::ComputeBoundingSphereForCone(). Change 4122819 by Stefan.Boberg Don't call CreateDirectory redundantly when opening files for writing using FFileManagerGeneric::CreateFileWriter This change avoids calling IPlatformFile::CreateDirectoryTree if possible since this is a very expensive function especially for deep hierarchies as it performs directory creation from the root directory onwards instead of from the leaf downwards. That function should also be fixed but this change improves performance in the meantime. Change 4122872 by Stefan.Boberg CreateDirectoryTree now creates directories leaf-to-root instead of the other way around. This is much more efficient since we don't spend time on system API calls for directories which already exist. This accounted for a very large amount of CPU time in cooking as the full target file directory hierarchy would be "created" for every single output file. Change 4123109 by Stefan.Boberg - Disable overlapped I/O in editor / cooker. Synchronous I/O reduces the number of syscalls and Windows performs prefetching on our behalf anyway for sequential reads - Eliminated syscall which was issued for every write to update cached file size -- since we're the only writers to the file (file access allows read sharing at most) we can authoritatively update the file size on write completion Change 4123455 by Ben.Marsh PR #4775: New build param PCHMemoryAllocationFactor to set /Zm VS build param. (Contributed by lucaswall) Change 4124207 by Ben.Marsh UBT: Remove some unnecessary indirection for generated code paths. Change 4124217 by Ben.Marsh UBT: Remove another unused variable from UEBuildModuleCPP. Change 4124377 by Stefan.Boberg In IPlatformFile::DeleteDirectoryRecursively, attempt to delete file first and if it fails clear the readonly flag and try again Previously there was a call to clear the readonly flag for every deleted file and this is a waste of resources 99% of the time. The SetFileAttributes call accounted for a significant amount of time during cooker sandbox directory deletion Change 4125071 by Stefan.Boberg Some tweaks to FQueuedThreadPoolBase scheduling and memory management - Explicitly pass in false for TArray::RemoveAt(..., bool bAllowShrinking) argument to prevent memory reallocation when arrays are drained and inevitably repopulated shortly afterwards - Use a MRU strategy instead of LRU when picking a thread to wake up. The MRU thread is the most likely to have a 'hot' cache for the stack etc. Picking from the back of the array also happens to be cheaper since no memory movement is necessary when RemoveAt is called. (This was the strategy in place before CL2600362 which seems to have changed it unintentionally) - Release lock as soon as a thread has been chosen, before asking the worker thread to wake up and do the work Change 4126132 by Ben.Marsh UAT: Detect when stdout is redirected and prevent using backspace characters to move the cursor. Change 4126867 by Graeme.Thornton TBA: Fix tagged binary formatter Change 4127010 by Robert.Manuszewski AnimScriptInstances created at runtime will now also be added to the owning omponent's cluster to avoid GC issues. Change 4127932 by Ben.Marsh WorkspaceTool: Reduce unnecessary logging of status messages when console output is not redirected. Change 4129050 by Ben.Marsh UGS: Check for NET Framework 4.5 being installed before running the installer. Also fix warning trying to kill existing UGS instances before upgrade. Change 4129459 by Graeme.Thornton TBA: TextAssetCommandlet - When outputting converted assets to an output path, replicate the workspace relative path in the output directory Change 4129515 by Graeme.Thornton TBA: Add EnterRecord overload that allows outputting of available field names when loading. Change 4129517 by Graeme.Thornton TBA: Tagged properties are written out as named fields on the "Properties" record, rather than as a stream with a null tag at the end Change 4129518 by Graeme.Thornton TBA: Added a local const bool to allow easy hacking out of text asset loading support Change 4129558 by Graeme.Thornton TBA: Build fix for textasset-less configs Change 4129614 by Ben.Marsh UGS: Main window is now restored to normal size when activated by clicking on the tray icon. #jira UE-60490 Change 4129618 by Ben.Marsh UGS: Speculative fix for unreproduced exception accessing disposed window while shutting down. Change 4131936 by Robert.Manuszewski Removing some WIP code accidentally checked in with CL #4121943 Change 4133490 by Ben.Marsh UGS: Allow the $(Change) variable to be used in more places than just the context menu. #jira UE-60573 Change 4133550 by Ben.Marsh UGS: Setting for whether or not to use incremental builds is now exposed through the variable "$(UseIncrementalBuilds)" for use by custom build steps. #jira UE-60554 Change 4133681 by Ben.Marsh UGS: A per-project list of folders and extensions to be deleted by default when running the 'clean workspace' tool can now be specified through the <ProjectDir>/Build/UnrealGameSync.ini file. Settings may be specified for an individual branch (via a category with the depot path to the project) or for wherever the project is currently open (via the [Default] category). The SafeToDeleteFolders list specifies a substring that will be checked against folder paths. Anything containing this folder will be marked as safe for delete by default. The SafeToDeleteExtensions list specifies a list of extensions for files that can always be deleted. Example: [Default] +SafeToDeleteFolders=/MyGame/Test/ +SafeToDeleteFolders=/DataService/ +SafeToDeleteExtensions=.xx1 +SafeToDeleteExtensions=.xx2 #jira UE-60575 Change 4135449 by Ben.Marsh Fix allowing use of Job objects on Windows platforms (debug code submitted by mistake) Change 4135730 by Ben.Marsh UBT: Plugins can now be enabled and disabled from the .target.cs file (for targets that do not use the shared compile environment), by compiling the list of enabled/disabled plugin names into the Projects module. Change 4135823 by Ben.Marsh UBT: Remove legacy code to handle disabling optional plugins; now that this is compiled into the target, it will work for any plugins we choose. Change 4135945 by Ben.Marsh UBT: Fix error running programs with no explicitly enabled or disabled plugins. Change 4137207 by Ben.Marsh UGS: Align all badges with the same name, to make it easier to see which CIS steps are being run. Allow overriding the slot taken by a particular badge by calling it "SlotName:LabelName". Change 4137311 by Stefan.Boberg Removed child cooker support. In practice it is not a useful feature as it provides no performance improvement (quite the opposite in fact) and adds testing and maintenance complexity. Change 4137393 by Ben.Marsh UGS: Fix display of multiline errors in the status panel. Change 4141708 by Steve.Robb GitHub #3631 : Incorrect default argument in WeakObjectPtrTemplate #jira UE-45490 Change 4146655 by Stefan.Boberg Removed FullGCAssetClasses logic - no longer necessary nor useful Change 4147318 by Ben.Marsh UGS: Compress build badges in a column if it shrinks below the size that they would be visible. Change 4148207 by Ben.Marsh UGS: Added support for showing the latest completed build from a specific list of badges in the status panel. To declare a badge as one that should appear in the status panel rather than the CIS column, add it to the project's UnrealGameSync.ini in the project or [Default] section like so: +ServiceBadges=RoboMerge Change 4148282 by Stefan.Boberg Fixed bug in UCookOnTheFlyServer::GetCookOnTheFlyUnsolicitedFiles - UnsolicitedFiles should be passed by reference not by value Change 4148344 by Stefan.Boberg Fixed minor indentation error (most likely caused by sloppy merge) Change 4148521 by Stefan.Boberg Removed accidentally checked in PRAGMA_DISABLE_OPTIMIZATION from CookOnTheFlyServer.cpp Change 4148639 by Ben.Marsh UGS: Fix tooltips not showing for changes that have description badges. Change 4149373 by Ben.Marsh UGS: Allow adding additional columns to display particular badges by adding entries from the project config file. Example syntax: +Columns=(Name="Desktop",MinWidth=50,DesiredWidth=100,Weight=3,Badges="Editor") +Columns=(Name="Mobile",MinWidth=50,DesiredWidth=100,Weight=3,Badges="IOS,Android") Same form can be used to control how default columns are displayed (though badge settings are ignored). Also allow PerforceMonitor to detect local changes to project config files and update settings automatically. Change 4149399 by Ben.Marsh UGS: Update version to 1.143. Change 4155660 by Steve.Robb PROJECTION and PROJECTION_MEMBER macros which provide the correct behavior when creating projections using functions which are overloaded or use default arguments. Change 4157117 by Ben.Marsh Fix warning due to plugins disabled in .target.cs file. Change 4158011 by Ben.Marsh UBT: Add a check that the UnrealHeaderTool target file exists, rather than throwing an exception when reading it fails. Change 4158646 by Ben.Marsh UGS: Fix exception when login is discovered to have expired during a workspace update. Change 4158678 by Ben.Marsh UGS: Fix an exception on shutdown due to the icon being hidden after it's already been disposed. Change 4158683 by Ben.Marsh UGS: Add an unhandled exception filter which sends the exception data to the backend. Change 4159131 by Ben.Marsh UGS: Reduce the number of characters displayed for build badges based on the available space. Change 4159194 by Graeme.Thornton TBA: Fix incorrect map property conversion code when converting an old property that contains a map with different key/value types Change 4159239 by Steve.Robb Improved readability and compliance with coding standards. Change 4159246 by Ben.Marsh UGS: Allow syncing projects where source code is not available (and various version files don't exist). #jira UE-60985 Change 4159286 by Ben.Marsh UGS: Remove requirement for UE4Editor.target.cs to be visible in the depot in order to open a project. #jira UE-60986 Change 4159302 by Ben.Marsh UGS: Update version to 1.144. Change 4160308 by Ben.Marsh All staging client executables for blueprint projects. #jira UE-60983 Change 4161567 by Steve.Robb GitHub #4816 : UE-60771: Handle escaped double quote in FParse::LineExtended Change 4162641 by Ben.Marsh UGS: Allow customizing the position of custom columns, via the Index=N attribute. Change 4162647 by Ben.Marsh UGS: Update version to 1.145. Change 4165319 by Robert.Manuszewski PR #4812: Fix inconsistent command-line argument handling under Windows (Contributed by adamrehn) Change 4166150 by Ben.Marsh UGS: Include *.inl when looking for code changes. Change 4166551 by Steve.Robb Whitespace fixes caused by a bad merge. Change 4168483 by Ben.Marsh UGS: Add a more useful error if a file to be synced exceeds the max allowed path length. Change 4168490 by Ben.Marsh UGS: Update version to 1.146. Change 4168551 by Ben.Marsh UBT: Move bBuildLargeAddressAwareBinary into an exposed setting. Change 4168560 by Ben.Marsh UBT: Remove static config variable for controlling which configuration of UHT to use. Change 4171296 by Ben.Marsh UGS: Move the check for overlong paths earlier. Change 4171531 by Ben.Marsh UBT: Fix exception if BuildConfiguration.xml contains an unknown category. Change 4183371 by Robert.Manuszewski Fix for a crash in Async Loading Graph's CheckCycles when GC kicks in on the game thread and forces ALT to exit early Change 4184312 by Ben.Marsh UGS: Update version to 1.148 Change 4184480 by Robert.Manuszewski Removing unused async loading stat Change 4186390 by Ben.Marsh UBT: Format XML validation errors in a format that allows double-clicking on the message in Visual Studio. Change 4188644 by Ben.Marsh UBT: Add the MakePathSafeToUseWithCommandLine() function to UBT. Change 4188647 by Ben.Marsh UBT: Fix exception in target receipt when architecture is null. Change 4189617 by Ben.Marsh Change FileSystemReference, FileReference and DirectoryReference objects to use OrdinalIgnoreCase comparisons without creating a separate copy of the string to compare. The filesystem does not use the invariant culture, and it can produce the wrong results in some cases (the ordinal comparison is faster, too). Change 4189740 by Ben.Marsh UAT: Remote code to build UnrealPak when packaging; we use the editor now. Change 4189860 by Ben.Marsh UGS: Make the filter for excluding automated lighting rebuilds more explicit. Change 4190082 by Ben.Marsh Fixes to allow enabling edit and continue for Windows builds. Have experienced quite a few VS crashes when testing it in editor; not yet recommended for general use. - Allow edit and continue for any configuration, not just debug. - Fixed PDB errors compiling files that use a shared PCH with edit and continue enabled. Path to the generated PDB file was using the wrong directory. - Removed code that tracks PDB output files, since they're modified multiple times during a build. - Enable debug information when compiling generated CPP files, since it causes errors if the shared PCH PDB doesn't have the same option. - Disable support for remote execution of steps that modify the PDB, since the same file has to be modified many times. Remote execution causes the PDB files to be corrupted. Unfortunately, this makes E&C builds significantly slower. #jira Change 4192949 by Ben.Marsh UBT: Minor tidy-up (merging UEBuildBinary.Build and UEBuildBinary.SetupOutputFiles) Change 4193218 by Ben.Marsh Fix formatting. Change 4197252 by Mike.Erwin UAT: Fix log output w/ correct count of non-code projects. #jira none Change 4197941 by Ben.Marsh UGS: Add support for DebugGame editors that have an executable with a DebugGame suffix. Change 4197964 by Ben.Marsh UGS: Prevent attempts to automatically reopen projects while a modal dialog is up, or the workspace is syncing. Change 4198144 by Ben.Marsh UGS: Prevent modal dialogs when login expires in P4, and prompt for password when hitting "retry". Change 4198413 by Ben.Marsh UGS: Always show the main window when launched manually, and run with -RestoreState when launched at startup. Also add a couple more places that save the visibility state, since logging off seems like it can terminate the process abrubtly. Change 4198779 by Ben.Marsh UBT: Allow generating manifests to any arbitrary locations with the -Manifest=<Path> argument. Change 4198825 by Ben.Marsh UBT: Move code to enumerate Slate runtime dependencies into the Slate module. Doesn't need to be done inside core UBT. Change 4199341 by Ben.Marsh UGS: Update version to 1.149 Change 4199642 by Chad.Garyet - Deprecate CISController - Add BuildController to replace CIS GET/POST for builds - Add LatestController, GET does what CIS/GET used to do - Change Latest/GET to return the last 25 builds filtered by project, rather than the last 5000 individual Ids - Latest/GET now returns "LatestData" object instead of array of longs - Updated EventMonitor to match all API changes - Fixed bug where IDs were getting reset to initial startup values every update loop Change 4199663 by Chad.Garyet CIS controller still needs to return an array of longs #jira none Change 4199680 by Ben.Marsh UGS: Update version to 1.150 Change 4200457 by Ben.Marsh Merging CIS fix for non-development configurations. Change 4200472 by Mike.Erwin UAT: fix -skipbuildclient param default It was defaulting to skipbuildeditor's value, likely a copy-paste error. #jira none Change 4202595 by Ben.Marsh Fix static analysis warning due to constant comparison against macro. Change 4203250 by Ben.Marsh UGS: Always show the "Sync Precompiled Editor" option, but disable it and show a tooltip explaining why if it is not available. Change 4206191 by Ben.Marsh Exclude editor target files from installed builds, since they leak info about DLLs that have been stripped out. Change 4213011 by Ben.Marsh UBT: Include contents of modified intermediate files in the log, to make it easier to debug hidden dependencies. Change 4213487 by Ben.Marsh UBT: Fix assumption that bPrecompile is equivalent to bBuildAllModules. This is no longer the case; they are now controlled by separate options. Should fix CIS errors building the editor. Change 4213609 by Ben.Marsh Ensure that strings formatted using FMicrosoftPlatformString::GetVarArgs() are always null terminated, whether we use the secure CRT or not. Change 4215971 by Ben.Marsh UBT: Remove action graph visualization code; no longer used. Change 4215996 by Ben.Marsh UBT: Remove unqiue id from all actions in the action graph. This is only used for printing debug info in the case of a (rare) cycle in the action graph, so just look it up when needed. Change 4216022 by Ben.Marsh UBT: Rename Crypto.cs to EncryptionAndSigning.cs to match the name of the class inside it, and move it under the System folder. Change 4216031 by Ben.Marsh UBT: Move all the action executors into their own folder in the project. Change 4216526 by Ben.Marsh Fix CIS warnings. Change 4216544 by Ben.Marsh Replace custom code to ensure FMicrosoftPlatformString::GetVarArgs() null terminates its buffer with Microsoft's standards-compliant implementation. Change 4216633 by Ben.Marsh Add support for UnrealPak plugins. * Project and plugin modules can now specify an array of supported programs in the "WhitelistPrograms" field of their module descriptors, to allow modules to be loaded by programs. * Programs can now load any runtime modules, as long as they are whitelisted. * Programs under the engine directory can now use a shared build environment, so that building with a project file does not cause output binaries to be output to the project directory. * UnrealPak is now always built by default when packaging * Convert UnrealPak to a modular configuration Change 4216736 by Ben.Marsh UnrealPak: Move "ExportDependencies" command into an editor commandlet, since it relies on the UObject system, asset registry, etc... Change 4217447 by Ben.Marsh Back out revision 50 from //UE4/Dev-Core/Engine/Build/InstalledEngineBuild.xml Change 4217451 by Ben.Marsh Back out revision 11 from //UE4/Dev-Core/Engine/Plugins/Developer/VisualStudioSourceCodeAccess/Source/VisualStudioSourceCodeAccess/VisualStudioSourceCodeAccess.Build.cs Change 4217617 by Ben.Marsh Back out changelist 4217451 Change 4222552 by Ben.Marsh Don't use #import <TypeLib> for VS source code accessor when building with Clang; it's not supported. Change 4222630 by Ben.Marsh UBT: Fix spam while generating project files if Clang isn't installed. Change 4223316 by Ben.Marsh UBT: Change the order in which Visual C++ toolchains are enumerated to prefer full releases over preview releases. Change 4223318 by Ben.Marsh UBT: Add a build setting which allows creating a dedicated PCH for every file that's excluded from the unity working set (disabled by default). Improves iteration times when working on individual cpp files, but slows down iterating on header changes (and can take a lot of disk space for large changes). Dedicated PCH contains all includes scraped from the top of each cpp file, until a non-#include directive is encountered. Change 4223401 by Ben.Marsh UBT: Add an option to automatically enable edit and continue for files in the adaptive non-unity working set. E&C doesn't seem very useful for UE4 projects right now; compile time is comparable to regular build times, but it can take several minutes to apply code changes for large projects. Change 4223899 by Ben.Marsh UBT: Fix loading XML config files on Mono; Type.GetField(Name) does not seem to return values unless binding flags are specified. Change 4224637 by Ben.Marsh Add a "SupportedPrograms" field to plugin descriptors, which allows plugins to declare which plugins they support independently of individual modules. Programs now respect the "bEnabledByDefault" setting in plugins. Plugins that are compatible with a program now need to list that program in the SupportedPrograms list, and whitelist any modules that should load for that program. Change 4224710 by Ben.Marsh UBT: Don't add import libraries as final build products unless the target is being precompiled. Prevents the need for building them for leaf nodes in the action graph. Change 4224715 by Ben.Marsh UBT: Remove hack to allow Stats2.cpp to not follow IWYU convention. Change 4224726 by Ben.Marsh Remove commented out line. Change 4224903 by Ben.Marsh Fix non-unity compile error in Stats2.h. Change 4225051 by Ben.Marsh Back out changelist 4224710; causing CIS errors due to receipts not matching. Change 4225134 by Ben.Marsh Fixing non-unity errors. Change 4225203 by Ben.Marsh Another non-unity fix. Change 4225249 by Ben.Marsh Fix Linux dependencies being copied for the Windows editor; they can be added as requirements for the Linux target platform on Windows instead, so it respects the user's chosen platforms. #jira UE-62001 Change 4225512 by Ben.Marsh BuildGraph: Allow setting the target to build when using the <CsCompile> task. Change 4228815 by Ben.Marsh UBT: Always add the generated code directory to the list of include paths when generating project files. It may only be created after UHT has been run. Change 4228944 by Ben.Marsh UBT: Remove legacy CppCompileEnvironment and LinkEnvironment wrappers from TargetRules that were deprecated in 4.19. Change 4229028 by Ben.Marsh UBT: Fix editor targets with unique build environment having the wrong executable path in generated project files. Move move logic to configure target rules post-construction by the rules assembly to ensure it's valid. Change 4229065 by Ben.Marsh UBT: Move another target setting into the rules assembly. Change 4229105 by Ben.Marsh Fix BPT exception when generating project files. Change 4229311 by Ben.Marsh UBT: Store the module rules file location on the ModuleRules instance, as well as the plugin that it was created from. Also expose the plugin directory as a property on the ModuleRules instance. Change 4229421 by Ben.Marsh UBT: Consolidate functionality for UHT module setup in ExternalExecution.cs. Change 4229817 by Ben.Marsh UBT: Modules must now explicitly specify the path to the header used to generate a PCH if one is desired, rather than the header being determined automatically by attempting to parse the source code. Now that PCHs are force-included anyway, this removes a lot of dependencies inside UBT. Change 4229824 by Ben.Marsh UBT: Remove unused lists inside UEBuildModuleCPP.SourceFilesClass. Change 4229841 by Ben.Marsh UBT: Remove some legacy code from auto-detecting PCHs. Change 4230521 by Ben.Marsh UBT: Add utility functions to the log class to allow formatting errors and warnings in Visual Studio output format (eg. File(Line): warning: Message) Change 4230871 by Ben.Marsh UAT: Remove StreamUtilis utility class; there is a simpler way to implement the one place it's used. Change 4230882 by Ben.Marsh UAT: Add StreamUtils back into UAT, seems like it's still used there. Change 4230896 by Ben.Marsh UBT: Remove some redundant parameters from UEBuildModule/UEBuildModuleCPP/UEBuildModuleExternal constructors. Change 4231014 by Ben.Marsh WorkspaceTool: Include a dump of raw bytes when garbage is read from the P4 process, for diagnostic purposes. Change 4231032 by Ben.Marsh Fix CIS. Change 4231096 by Ben.Marsh Bump the FlatCPPIncludeDependencyCache version, to prevent errors trying to load old files. Change 4231446 by Ben.Marsh UBT: Added support for expanding UE-specific variables in include paths and library paths: $(EngineDir), $(ProjectDir), $(PluginDir), $(ModuleDir). Change 4231460 by Ben.Marsh Modules may now explicitly specify rpaths on Linux via the PublicRuntimeLibraryPaths and PrivateRuntimeLibraryPaths properties. Change 4233909 by Robert.Manuszewski PR #4779: Reason fails as the supplied variable is incorrect (Contributed by projectgheist) Change 4233910 by Ben.Marsh Enable PCHs on IOS. Reduces build time by ~25%. Change 4234176 by Ben.Marsh UBT: Add better messaging for modules that need to have a private PCH set. Now detects the likely PCH using the same method as legacy code and includes it as a suggestion. Change 4234193 by Ben.Marsh Add the Delete command to Perforce wrapper in DotNETUtilities. Change 4234688 by Ben.Marsh UBT: Simplify handling of installed/precompiled builds. Settings for whether a folder is installed/read-only or not is now stored on the RulesAssembly instance, allowing multiple things to be configured separately and stacked together (eg. engine/enterprise/project). RulesAssembly.IsReadOnly() allows determining if a flie can be modified or not and replaces many previous IsXXXInstalledCalls(), and traverses the chain of assemblies. Change 4234711 by Ben.Marsh UBT: Runtime dependencies can now be copied to output directories as part of the build. When adding a runtime dependency, an optional source location can be specified to copy from. Both the source and target paths can use variables can be used as part of the path, eg. $(OutputDir), $(ModuleDir), $(PluginDir). Example usage (from a .build.cs file): RuntimeDependencies.Add("$(OutputDir)/Foo.dll", "$(PluginDir)/Source/ThirdParty/Foo.dll", StagedFileType.NonUFS); Change 4234872 by Ben.Marsh Expose a flag for whether the engine is installed, to fix issues generating project files. Change 4234929 by Ben.Marsh Fix null reference generating receipts when UBT makefiles are active. Change 4235883 by Chad.Garyet Merging 4231245 to core Giving Coordinator its own sln. This should fix what 4158155 was supposed to. #jira UE-61955 Change 4236075 by Ben.Marsh CIS fix Change 4237066 by Robert.Manuszewski Fix for a potential crash when terminating the engine while it's being initialized #jira UE-60545 Change 4237078 by Robert.Manuszewski The engine will no longer be resetting all linkers causing massive load times when renaming the world package when entering Play In Editor Change 4237116 by Ben.Marsh Rewrite some Windows utility functions to support paths longer than MAX_PATH. Change 4237158 by Ben.Marsh Add const TCHAR* overloads of FString::RemoveFromStart() and FString::RemoveFromEnd(). Change 4237159 by Ben.Marsh Fix FWindowsPlatformFile::GetFilenameOnDisk() support for paths longer than MAX_PATH, and simplify some of the other long path functions to avoid copying string buffers. Change 4239050 by Ben.Marsh Missing file Change 4239318 by Ben.Marsh Linux CIS fix. Change 4239685 by Ben.Marsh Static analysis CIS fix. Change 4240800 by Ben.Marsh WorkspaceTool: Include the full command line in the log for any P4 commands. Change 4240903 by Ben.Marsh PR #4909: Update copyright notices to 2018 (Contributed by projectgheist) Change 4241025 by Ben.Marsh UBT: Exclude mobile pipeline caches from generated project files. Causes huge slowdown when using 'Find in Files' through the IDE. Change 4241770 by Ben.Marsh UBT: Include action number in parallel executor output. #jira UE-62032 Change 4243469 by Ben.Marsh TBA: Merge FAnnotatedStructuredArchiveFormatter with FStructuredArchiveFormatter. Any functions that are only implemented for text archives now have a _TextOnly suffix, and are exposed through the FStructuredArchive interface. Change 4245723 by Robert.Manuszewski Fixing another creash when terminating the engine while initializing. #jira UE-60545 Change 4245862 by Steve.Robb VectorLoadFloat2(Ptr) added, which loads { Ptr[0], Ptr[1], Ptr[0], Ptr[1] } into a VectorRegister. Change 4246412 by Robert.Manuszewski The warning 'Calling StaticLoadObject during PostLoad may result in hitches during streaming' will now also report the object which had the PostLoad called on it when StaticLoadObject call happened. Change 4246612 by Ben.Marsh UBT: Fix spelling of "Intellisense". Change 4249454 by Robert.Manuszewski Added extra checks to catch scenarios where the EDL Precache Buffer is flushed before a package header is fully read Change 4249513 by Robert.Manuszewski Made sure the Async Loading Thread doesn't continue running after creating new async packages when garbage collector wants to run on the game thread Change 4255207 by Ben.Marsh UGS: Add additional logging whenever a P4 command fails, and when the user is logged out. Change 4255288 by Ben.Marsh PR #4921: Honor ModuleRules' bEnableExceptions flag when creating precompiled h. (Contributed by surakin) Change 4256422 by Ben.Marsh UBT: Add an error if a module referenced by a plugin descriptor doesn't exist. Change 4257385 by Robert.Manuszewski Creating new objects from within ForEachObjectWithOuter will now result in a fatal error as it's unsafe to change internal UObject hash tables when iterating over them. Change 4257454 by Robert.Manuszewski Added the option to filter clusters listed with gc.ListClusters by objects within them. Usage: gc.ListClusters Hierachy With=ObjectName1,ObjectName2... Change 4257526 by Robert.Manuszewski It's now possible to filter clusters that get logged with verbose cluster logging enabled (UE_GCCLUSTER_VERBOSE_LOGGING=1) by objects within them by specifying -DumpClustersWithObjects=ObjectName1,ObjectName2 in the command line Change 4257822 by Ben.Marsh Fixes for PlatformShowcase compile errors. Change 4258771 by Ben.Marsh UBT: Fix project files not being generated for foreign projects when creating .stub files. #jira UE-62462 Change 4258790 by Ben.Marsh UBT: Clean up the logic around generating project files before creating a stub IPA, so that it fails loudly if project files do not exist, and can accept target names not matching project names. Change 4259276 by Ben.Marsh UBT: Make it an error if a framework doesn't exist, rather than failing silently. Also remove some remote toolchain stuff that's no longer necessary. Change 4259280 by Ben.Marsh UBT: Fix embedded framework zips not being uploaded for plugins. #jira UE-62485 Change 4260236 by Ben.Marsh UBT: Fix path to generated engine project file. Change 4260334 by Ben.Marsh UGS: Fix custom build steps dialog inadvertantly modifying config file settings in-place. Change 4260361 by Ben.Marsh UGS: Allow for p4 login commands to fail, even though the user is logged in (due to a bad connection, etc...) Change 4260559 by Ben.Marsh UGS: Update version. Change 4261160 by Robert.Manuszewski MediaPlaylist will now be added to root set if the owning MediaPlayer is in the disregard for GC set (fixes GC assumption violation crash) #jira UE-62495 Change 4261421 by Ben.Marsh Force-sync files for building documentation, to fix issues with files not being updated. #jira UE-62413 Change 4261425 by Ben.Marsh UBT: Remove some leftover functions for handling the remote toolchain. Change 4261530 by Ben.Marsh UBT: Speculative fix (and better error reporting) for IOS mobile provision not being found in CIS. Change 4261611 by Ben.Marsh UBT: Downgrade warning to a log message, since it appears when generating project files. Change 4261710 by Ben.Marsh Remove assert that GLogConsole is set; it won't be for command line utilities that don't depend on ApplicationCore. #jira UE-62545 Change 4261831 by Ben.Marsh Fix compile errors due to missing include path when hot-reloading a module from the editor. There are not necessarily source files to compile when -modulewithsuffix is specified on the command line, which was results in GeneratedCodeWildcard not being set. #jira UE-62463, UE-62384 Change 4262723 by Ben.Marsh Whitelist plugins that need to be loaded by UFE. #jira UE-62564 Change 4265444 by Ben.Marsh Fix incorrect executable name for DebugGame configurations in Xcode. #jira UE-62574 Change 4265892 by Ben.Marsh Fix incremental compile failures due to dependency checking for unity files. CachedIncludePaths was not correctly being set on file items, so dependencies were being ignored. #jira UE-62575, UE-62603, UE-62597 Change 4266019 by Josh.Adams - Fixed the CopyAction for runtime dependencies that need to be copied to different location, on non-XGE Change 4266264 by Ben.Marsh Remove override for the __IPHONE_OS_VERSION_MIN_REQUIRED macro on TVOS. This macro is already defined by system headers (in <AvailabilityInternal.h>). Now that we support PCHs on IOS and TVOS, manually defining this macro results in it being defined three times (once for the PCH, once by AvailabilityInternal.h, and once by the force-included list of definitions for the source file being built). The errors for redefining the macro in AvailabilityInternal.h are suppressed due to it being a system header, but the error for redefining it for the source file being compiled are not. #jira UE-62578 Change 4266273 by Ben.Marsh Fixes incremental build failure when compile arguments for PCH have changed on IOS/TVOS. Compile action needs to have a dependency on PCH build action. Change 4266614 by Graeme.Thornton Fix crash when cooking nativized blueprints due to removal of child cooker system. Change 4266763 by Ben.Marsh Always build UnrealPak when building client targets. The ProjectParams.Pak option is not reliable, because it can be forced on later by the target platform. #jira UE-62584 Change 4267985 by Robert.Manuszewski When iterating with ForEachObjectWithouter, don't lock the entire has table but only the hash bucket that is currently being iterated #jira UE-62600 Change 4268558 by Robert.Manuszewski PurgeLegacyBlueprints will no longer be called from within ForEachObjectWithOuter is it renames objects that reside in hash tables that are being iterated over which may lead to undefined behavior. #jira UE-62600 Change 4269011 by Chad.Garyet - Fixing Wildcard match issue, the change to ugsapi sends projects as //Depot/Stream instead of //Depot/Stream/ Wildcard match was only substringing to 3 chars. - Checking in the change a while back that increases the number of queried jobs up to 432 based on some maths from Bob about how many builds we want to grab Published to ugsapi server 8/8/17 #jira none Change 4270788 by Ben.Marsh Fix IOS provisioning data being using when remote compiling on TVOS. #jira UE-62705 Change 4271916 by Ben.Marsh Tag the XGEControlWorker executable as a build product after compiling SCW, to make sure it's included in the UGS zip file. Change 4271934 by Ben.Marsh Upload all static libraries in plugin folders as part of remote builds. #jira UE-62694 Change 4273368 by Ben.Marsh Fix Slate dependencies not being enumerated, and rules assembly not being rebuilt when building remotely. #jira UE-62705 Change 4274049 by Ben.Marsh Always parse the team UUID out of the mobile provision when doing a remote compile. The provision installed on the remote Mac (and selected for signing) may be different. #jira UE-62751 Change 4274823 by Ben.Marsh Add the -VersionCookedContent argument to disable the -unversioned parameter on the cooker command line. Change 4275838 by Ben.Marsh Fix BuildVersion string not being passed through from <SetVersion> task. Also add a -BuildVersion command line argument to UBT to override it for a particular build. Change 4275913 by Ben.Marsh Add a dummy exported symbol to the XGEController module, to fix build errors due to missing .lib file when it's built with WITH_XGE_CONTROLLER = 0. Change 4284161 by Ben.Marsh Allow mirroring Oodle files to remote Mac. Change 4074774 by Steve.Robb Vast simplification of TFunction, making it smaller in footprint, easier to follow and extend, and more correct. TUniqueFunction added, which is a move-only TFunction which can hold move-only functors. Fix for UWidgetBlueprint::ForEachSourceWidget() which should never have compiled but did. FFunctionGraphTask and TFuture<> updated to use TUniqueFunction to make them more general. TArray::HeapPop() made to work with move-only types. Change 4082591 by Ben.Marsh Move the Log class from UBT to DotNetUtilities. Change 4083236 by Ben.Marsh Add a Log.WriteException() method to dump an exception message to the console (and write the exception trace to the log) Change 4084107 by Ben.Marsh UAT: Remove the unused -SkipHeader argument to UE4Build. Change 4089771 by Steve.Robb GitHub #4743 : modified VirtualAlloc function flag https://blogs.msdn.microsoft.com/oldnewthing/20151008-00/?p=91411 Change 4091456 by Steve.Robb Unification of all platforms' FMath::CountTrailingZeros() and FMath::CountLeadingZeros() for both 32-bit and 64-bit. Change 4156437 by Ben.Marsh Lots and lots of fixes compiling for Clang on Windows. Editor now compiles cleanly without warnings, but crashes on startup due to error in intrinsics test. Disabling that runs further, but crashes accessing freed memory. Switching to the ANSI allocator runs further, but crashes in Slate after the splash screen and before the editor window opens. // TODO! * Switching between Clang/ICL/VS2015/VS2017 is now supported through the same mechanism as switching Visual Studio versions, without requiring any source level changes. To use Clang, set WindowsPlatform.Compiler = WindowsCompiler.Clang from a .target.cs file, or set <WindowsPlatform><Compiler>Clang</Compiler></WindowsPlatform> from BuildConfiguration.xml. To pick a specific toolchain version, set WindowsPlatform.CompilerVersion. * Clang is now supported through AutoSDKs; will be added to CIS. * The Samples/Sandbox/Clang project forces Clang to be used from its target.cs file, and allows easily building all editor modules and plugins with Clang on Windows. * UnrealMathSSE intrinsics have been re-enabled for Clang due to missing functions from the UnrealMathFPU implementation, but causes failure in tests at startup. * SSE4_CRC32() is disabled in D3D12Pipelinestate.cpp, since intrinsics are only allowed if enabled for the whole target (rather than being used in specific functions due to runtime checks) Change 4157389 by Ben.Marsh Few more fixes for compiling the editor with Clang. Change 4183911 by Ben.Marsh Fixes to support incremental linking on Windows. Does not seem to have any net benefit right now; may improve once minimal rebuild is enabled. * Incremental linking no longer forces PDB files to be enabled for source files. * Actions can specify specific files to be deleted before each build. Code to forcibly delete PDB files has been moved to the MSVC toolchain. * Unused libraries produced by the cross-referenced link are no longer added as build products, since (a) deleting them breaks dependency checking for incremental linking and causes a full link, and (b) not deleting them breaks UBT dependency checking and causes actions to be run over and over again. * Icon update is disabled for Windows when incremental linking is enabled. * Removed rarely-used setting to always delete produced items before each build. Change 4184311 by Ben.Marsh UGS: Added a dialog which shows all the required platform SDKs for a branch, linked from the status panel in UGS. The llist is configured via the UGS config file submitted to Engine/Programs/UnrealGameSync/UnrealGameSync.ini (and may be overridden by the project config file if necessary): [Default] ; Set this to a network share which contains the SDK installers for your site SdkInstallerDir= ; All the required SDKs for the current version of the engine +SdkInfo=(Category="Android", Description="NDK r21", Browse="$(SdkInstallerDir)\\Android") +SdkInfo=(Category="Windows", Description="Visual Studio 2017") +SdkInfo=(Category="Windows", Description="Visual C++ Toolchain 14.13.26128") +SdkInfo=(Category="Windows", Description="Windows SDK 10.0.16299.0") Similar entries for console platforms are added in console subdirectories. Each entry may contain an Install="Foo.exe" and/or Browse="C:\Foo" style attribute, specifying the path to an installer to run or directory to open in explorer respectively. The SdkInstallerDir setting is used as a base directory for the default installers, seen above for Android. Licensees may override this with a network path specific to the site that UGS is being deployed to (either in this file, in a project specific config file, or in a Engine/Programs/UnrealGameSync/NotForLicensees/UnrealGameSync.ini file). Change 4200452 by Ben.Marsh UBT: Change DebugGame configurations to output a separate executable rather than requiring a -Debug argument at runtime. Previous behavior was a common source of errors. Engine modules are still shared between Development and DebugGame, but the launch module sets a flag in Core on startup indicating the game configuration. Change 4206189 by Ben.Marsh UBT: Simplify logic for precompiling binaries. * Target no longer has separate list of "precompile only" binaries or modules. New -AllModules option allows adding every module to a target, which can be used with -Precompile and -NoLink to precompile object files for monolithic builds. * Precompiled file lists have been removed from target receipts. * The manifest now includes all generated headers and precompiled files when run with the -Precompile option. * Separate -DependencyList=Foo.txt has been added to write a list of all dependencies required to use precompiled binaries. This file list can be read using the <Tag> task in buildgraph. Change 4215466 by Ben.Marsh UBT: Remove indirect calls to determine extensions for object files and precompiled headers. The toolchain knows the correct convention for the platform. Change 4215975 by Ben.Marsh UBT: Remove telemetry code. This has never proved useful for analyzing performance due to the number of incidental factors that affect build times (eg. number of files being compiled). Change 4220154 by Ben.Marsh Move text-only implementations of FOutputDeviceError back into Core, so we can build command-line applications that don't depend on ApplicationCore. Change 4224708 by Ben.Marsh Add a bCompileAgainstApplicationCore setting to the target rules, which allows compiling out references to the ApplicationCore module (which should only be necessary for applications with a GUI). Removed ApplicationCore from several engine tools and utilities. Change 4224958 by Ben.Marsh Remove CoreMinimal.h includes from Core. Change 4229059 by Ben.Marsh UBT: Remove the UEBuildPlatform.ShouldNotBuildEditor() hook for target platforms. We shouldn't be modifying a target's build environment to disable the editor; it is invalid to build the editor for these target platforms at all, and this is already enforced by the GetSupportedPlatforms() function. Change 4230508 by Ben.Marsh Fixup precompiled header setting for samples and games. Change 4231457 by Ben.Marsh Fix exceptions in log messages having trailing newlines. Change 4232406 by Ben.Marsh UBT: Always force include a PCH for generated code if there's one set; the code may depend on it to compile. Change 4234177 by Ben.Marsh Set up private PCH files everywhere that previously used them. Change 4235973 by Ben.Marsh Change FPlatformMisc::GetEnvironmentVariable() to return an FString() rather than requiring a fixed size buffer to be passed in. Removes references to MAX_PATH. Change 4238842 by Ben.Marsh Add support for paths longer than MAX_PATH in the editor. Requires Windows 10 version 1607, and the functionality to be enabled via a registry key or group policy (see https://docs.microsoft.com/en-us/windows/desktop/FileIO/naming-a-file). Only a subset of Win32 functions support long paths (executables can only be started from paths shorter than MAX_PATH, for example). * Added a FPlatformMisc::GetMaxPathLength() function to return the maximum length of a path on the current system. On Windows, this returns a different value for systems with long paths enabled to those without. * The MAX_PATH define is no longer set by non-Windows platforms. Instead, there is a MAC_MAX_PATH, UNIX_MAX_PATH, etc... for any platform-specific code that still relies on the previous macro. * The MAX_UNREAL_FILENAME_LENGTH macro has been renamed to MAX_UNREAL_FILENAME_LENGTH_DEPRECATED * The PLATFORM_MAX_FILEPATH_LENGTH macro has been renamed to PLATFORM_MAX_FILEPATH_LENGTH_DEPRECATED. * Removed custom resource files for programs, since they are just copies of the base UE4 one (which is used by default anyway). The base UE4 manifest declares support for long paths. * Fix 512 character maximum length on editor commands. 260 character limit remains in place for cooking at the moment (see ContentBrowserUtils.h), until C# staging code supports long paths. Change 4255042 by Ben.Marsh UBT: Remote compilation now uploads the entire workspace to the remote Mac and executes a separate remote instance of UBT rather than synchronizing individual actions. This makes the remote compile codepath much simpler, and removes a lot of special cases that exist to support it previously. The list of files to be transferred to the remote are listed as rsync filter rules in Engine/Build/Rsync/RsyncEngine.txt and RsyncProject.txt, which are applied to the root engine directory and project directory respectively. Projects that need to customize which files are uploaded can add their own <ProjectDir>/Build/Rsync/RsyncProject.txt file, which will be included in the filter before the default version. Change 4260567 by Ben.Marsh UAT: Rename CommandUtils.Log to CommandUtils.LogInformation, to avoid conflicts with the underlying Tools.DotNETCommon.Log class. #rb none [CL 4285673 by Ben Marsh in Main branch]
2018-08-14 18:32:34 -04:00
LogInformation("Server exited....");
if (ClientProcess != null && !ClientProcess.HasExited)
{
ClientProcess.StopProcess();
}
foreach (var OtherClient in OtherClients)
{
if (OtherClient != null && !OtherClient.HasExited)
{
OtherClient.StopProcess();
}
}
if (Params.Unattended)
{
if (!WelcomedCorrectly)
{
throw new AutomationException("Server or client exited before we asked it to.");
}
}
}
private static void SetupClientParams(List<DeploymentContext> DeployContextList, ProjectParams Params, string ClientLogFile, out ERunOptions ClientRunFlags, out string ClientApp, out string ClientCmdLine)
{
if (Params.ClientTargetPlatforms.Count == 0)
{
throw new AutomationException("No ClientTargetPlatform set for SetupClientParams.");
}
// var DeployContextList = CreateDeploymentContext(Params, false);
if (DeployContextList.Count == 0)
{
throw new AutomationException("No DeployContextList for SetupClientParams.");
}
var SC = DeployContextList[0];
// Get client app name and command line.
ClientRunFlags = ERunOptions.AllowSpew | ERunOptions.AppMustExist;
ClientApp = "";
ClientCmdLine = "";
Copying //UE4/Dev-Console to //UE4/Dev-Main (Source: //UE4/Dev-Console @ 3483086) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3389969 on 2017/04/12 by Guillaume.Abadie Implements FDebug::DumpStackTraceToLog() debugging utility. Change 3391579 on 2017/04/12 by Joe.Barnes Fix minor spacing issue. Change 3402629 on 2017/04/20 by Ben.Marsh Build: Remove job to populate the DDC. Trying out a new system for this. Change 3417501 on 2017/05/01 by Joe.Barnes IWYU - Missing #include files. Change 3419927 on 2017/05/02 by Joe.Barnes - Support custom LOD for shadow map generation only (r.ForceLODShadow) - New #define to expose forceLOD and forceLODShadow also in Test/Ship builds (#define EXPOSE_FORCE_LOD 1 in RenderCore.cpp). Not exposed by default. Change 3420964 on 2017/05/03 by Jonathan.Fitzpatrick Fixed null dereference of LineBatcher when using DrawDebugSphere and DrawDebugAltCone #jira UE-30213 Change 3423470 on 2017/05/04 by Luke.Thatcher [CONSOLE] [STREAMS] [^] Merging //UE4/Dev-Main (CL 3391974) to Dev-Console (//UE4/Dev-Console) - Compile errors in Switch, to be fixed after check-in. Change 3430410 on 2017/05/09 by Ben.Woodhouse Fix uninitialized local variable causing crashes in Test #jira UE-44832 Change 3430506 on 2017/05/09 by Josh.Adams - Fixed up the editor platforms' method of loading TargetSettings objects so that we don't need any manual parsing of .ini files to fill out the class defaults Change 3434035 on 2017/05/10 by Ben.Woodhouse Integrate updated FortGPUTestbed from Fortnite/Main Change 3437046 on 2017/05/12 by Joe.Barnes Fix for clang producing a warning when not all specializations of a templated function are marked FORCEINLINE. Also, switch a specialization of BlendTransform() from a function with a check to just a declaration so compiler will catch error instead of a runtime catch. Change 3437259 on 2017/05/12 by Joe.Barnes Fix for clang producing a warning when not all specializations of a templated function are marked FORCEINLINE. Also, switch a specialization of BlendTransform() from a function with a check to just a declaration so compiler will catch error instead of a runtime catch. Change 3440758 on 2017/05/16 by Ben.Woodhouse Simple threaded CSV Profiler To capture: - On the commandline, add -csvCaptureFrames=N to capture N frames from startup - On the console, use csvprofile start, csvprofile stop or csvprofile frames=N to capture a fixed number of frames - Instrument with CSV_SCOPED_STAT(statname), CSV_CUSTOM_STAT(statname,value). CSV capture is enabled in all builds except shipping - Please do not check in the instrumentation √ we don╞t want to pollute the engine with lots of additional instrumentation. We may add some minimal level of instrumentation at some point Change 3440954 on 2017/05/16 by Josh.Adams - Cleaned up some DeviceProfiles in BaseDP.ini Change 3443778 on 2017/05/17 by Ben.Woodhouse Aliasing for transient resources + new high level API Changelists integrated: 3368830 3368887 3377762 3377763 3379513 3381840 3382046 3382138 3385390 3385391 3385531 3396613 3388752 3396756 3397007 3397059 3397780 3397883 3401716 3415179 Change 3451460 on 2017/05/22 by Ben.Woodhouse Fix editor crash (NULL dereference of ScreenSpaceShadowTexture) when moving the camera around in tm-shadermodels, probably fallout from the VRAM aliasing merge. Not sure if this is the correct fix, but it prevents the crash for now Change 3451601 on 2017/05/22 by Josh.Adams - Track idle time from MaxTickRate, so that stat unit is accurate on Game: thread Change 3452025 on 2017/05/22 by Ben.Woodhouse Integrate (as edit) CL 3378734 (editor crash fix) Also add a check for null in LightFunctionRendering.cpp Change 3452389 on 2017/05/22 by Josh.Adams - Replaced POCulturePluralForms with a static array, instead of TMapBuilder (was blowing stack or similar on Switch Debug). Code courtesy of Jamie Dale. Change 3452758 on 2017/05/22 by Joe.Barnes Add FindFirstClearBit() and FindFirstSetBit() to TStaticBitArray. Change 3455889 on 2017/05/23 by Ben.Woodhouse Integrate from //UE4/Main/...@3453436 to //UE4/Dev-Console/... Change 3458654 on 2017/05/25 by Joe.Conley Attempting to fix Static Analysis warning. Change 3462710 on 2017/05/26 by Ben.Woodhouse Integrate from //UE4/Main/...@3461688 to //UE4/Dev-Console/... Change 3471711 on 2017/06/02 by Jonathan.Fitzpatrick Updating MallocProfiler to use the accessor for OnOutOfMemory delegate to conform with change made in CL 3415996. Change 3473813 on 2017/06/05 by Ben.Woodhouse Fix streaming visibility logic bug reported on UDN #jira UE-43892 Change 3475298 on 2017/06/06 by Luke.Thatcher [CONSOLE] [!] Fix RHITransitionResources crash with more than 16 textures. - Old command had a fixed sized array of 16 textures that would overflow. - New command allocates an array of texture pointers inline in the command list, so any number is supported. #jira UE-45625 Change 3476776 on 2017/06/06 by Ben.Woodhouse Integrate from //UE4/Main/...@3475908 Change 3479083 on 2017/06/07 by Ben.Woodhouse Integrate as edit CL 3467315 from dev-animphys: From Alexis Matte. Ensure SectionMap is fixed up for old entries that are no longer valid. #JIRA UE-45438 #jira UE-45735 Change 3480576 on 2017/06/08 by Ben.Woodhouse Integrate from //UE4/Main/...@3480024 to //UE4/Dev-Console/... [CL 3483258 by Luke Thatcher in Main branch]
2017-06-09 17:44:13 -04:00
string TempCmdLine = SC.ProjectArgForCommandLines + " ";
var PlatformName = Params.ClientTargetPlatforms[0].ToString();
if (Params.Cook || Params.CookOnTheFly)
{
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 3491552) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3421703 on 2017/05/03 by Ben.Marsh Surround invalid character message in quotes, so it's clear when a space is listed. #jira UE-44606 Change 3422644 on 2017/05/04 by Steve.Robb Ranged-for support for TChunkedArray. Change 3422754 on 2017/05/04 by Steve.Robb IAsyncReadFileHandle made non-copyable to prevent accidental wrong stat calculation. Change 3422758 on 2017/05/04 by Steve.Robb Misc readability/standards improvements in stats code. Change 3427955 on 2017/05/08 by Steve.Robb Version fix for IOS optimization pragmas, copied from equivalent Mac code. Change 3428017 on 2017/05/08 by Steve.Robb Unused property types removed. Change 3428641 on 2017/05/08 by Ben.Marsh UAT: Remove failed attempt to separate out BuildCookRun into separate commands, which have since rotted. Change 3430407 on 2017/05/09 by Ben.Marsh UBT: Define UE_4_X_OR_LATER macros for every UE4 version greater than 4.17 (eg. UE_4_17_OR_LATER, etc...). Change 3430682 on 2017/05/09 by Gil.Gribb UE4 - Added a fatal error for asking for very large alignments from MallocBinned2 and also return the true size of the memory block in GetAllocationSize(). Change 3430685 on 2017/05/09 by Gil.Gribb UE4 - Fixed a bug with the windows async IO stuff related to an unsafe pointer cast to LPDWORD from int64*. Change 3430756 on 2017/05/09 by Ben.Marsh UBT: Switch some receipt stuff to use FileReference/DirectoryReference objects rather than raw paths. Change 3431157 on 2017/05/09 by Ben.Marsh UBT: Store absolute paths when receipts are in memory; only insert pseudo-variables for $(EngineDir) and $(ProjectDir) when saved to disk. Change 3432334 on 2017/05/10 by Graeme.Thornton Include project name in the UBT error message which appears when a plugin is missing Change 3432481 on 2017/05/10 by Gil.Gribb UE4 - Fixed code to detect cycles in parallel tick sorting. Change 3432485 on 2017/05/10 by Steve.Robb Simplified templating around bitfield offset calculation. Change 3432608 on 2017/05/10 by Steve.Robb 'bool == byte' static_assert restored after being removed in CL# 3432485. Change 3432767 on 2017/05/10 by Ben.Marsh UBT: Fix exception when a missing plugin is encountered if the target does not have a project. Change 3433031 on 2017/05/10 by Ben.Marsh UAT: Add classes to allow safer manipulation of paths within the staging directory (StagedFileReference, StagedDirectoryReference), and convert staging code over to using those and their regular filesystem counterparts (FileReference/DirectoryReference). Lots of cleanup and refactoring of staging code. Change 3433049 on 2017/05/10 by Ben.Marsh Add more diagnostic information to asserts in TStaticIndirectArrayThreadSafeRead, to try and shed light on what sort of corrupted data is being passed in from the cooker. #jira UE-44336 Change 3433097 on 2017/05/10 by Steve.Robb Value initialization fix for MakeUnique<T[]>(). Change 3433972 on 2017/05/10 by Daniel.Lamb Stop unrealpak from crashing if generating a patch with more pak files then the original game. Change 3434124 on 2017/05/10 by Ben.Marsh UAT: Remove hacky bUseWebSocketNetDriver option. Change 3434824 on 2017/05/11 by Gil.Gribb UE4 - Printed an error instead of asserting when there are missing native classes. Change 3434916 on 2017/05/11 by Ben.Marsh UAT: Separate the list of files to be staged into a separate class. Change 3435427 on 2017/05/11 by Gil.Gribb UE4 - Fixed attempts to load compiled in packages, which produces warnings and is slow. Change 3436240 on 2017/05/11 by Ben.Marsh UAT: Add a command to search for restricted folders under a given base directory. Change 3438068 on 2017/05/12 by James.Fox Checking in Phase 1 of the Dev-Core test map for repro purposes. UE-44996 #rb none Change 3438855 on 2017/05/15 by Robert.Manuszewski When verbose cluster logging is enabled and new object is added to an already existing cluster, the cluster will be dumped to log. Change 3438929 on 2017/05/15 by Robert.Manuszewski Merging CL # 3436939 using Dev-Core_To_Dev-LoadTimes: Fix for potential crashes caused by levels staying in memory through material references. Change 3439021 on 2017/05/15 by Ben.Marsh PR #3566: fix non-ascii characters in help command HTML converted to "?" (Contributed by kayama-shift) Change 3439079 on 2017/05/15 by Ben.Marsh PR #2832: Implement missing MessageBox (Contributed by projectgheist) Change 3439258 on 2017/05/15 by Ben.Marsh Highlight lines containing the strings "Error:" or "Warning:" in the output log, so that diagnostics from child processes are highlighted appropriately. The build system already relies similar logic for scraping diagnostics from logs, so it should be safe and predictable to check for messages in this way. #jira UE-43673 Change 3439358 on 2017/05/15 by Ben.Marsh UBT: Fix Visual Studio solution referencing the incorrect platform for existing C# project ("Any CPU" instead of "AnyCPU"). Was causing prompt to save the solution the first time it is opened. Change 3439665 on 2017/05/15 by Ben.Marsh UAT: Remove DeployPakInternalLowerCaseFilenames(). No platforms require this to be true. Change 3440735 on 2017/05/16 by Robert.Manuszewski UBT compile fix after the last merge Change 3440889 on 2017/05/16 by Ben.Marsh EC: Fix regex for matching path to source files included in error messages from the Linux toolchain. Change 3442776 on 2017/05/17 by Steve.Robb Platform fix for FPaths::IsSamePath. Change 3445411 on 2017/05/17 by Ben.Marsh UBT: Fix typo in makefile diagnostic string. Change 3446070 on 2017/05/18 by Steve.Robb Fix to array sizes in generated UFunction code, which should now handle editor-only functions. Change 3446091 on 2017/05/18 by Steve.Robb Another array size fix for generated code. Change 3446605 on 2017/05/18 by Steve.Robb BuildConfiguration option for static analysis. Change 3448601 on 2017/05/19 by Richard.Fawcett Change FWindowsPlatformProcess::ApplicationSettingsDir() so that it no longer returns a path with a mixture of "\" and "/" characters, and only contains "/" characters. This makes it consistent with other related functions like FWindowsPlatformProcess::UserSettingsDir(). Change 3449026 on 2017/05/19 by Ben.Marsh Fix whitespace in template file. Change 3449697 on 2017/05/19 by James.Fox Checking in Phase 2 of Dev-Core test map for QAGame Also enabled Blueprint and Actor clustering by default in QAGame for more thorough GC testing. Change 3451352 on 2017/05/22 by Steve.Robb UFunction flags are now viewable in the debugger. Change 3451355 on 2017/05/22 by Steve.Robb ARRAY_COUNT fix for zero-sized arrays in Clang. Change 3451379 on 2017/05/22 by Steve.Robb C++14 operator delete overloads with size, for consistency. Change 3451398 on 2017/05/22 by Graeme.Thornton Add AES and RSA encryption keys to the list of config fields that get stripped from ini files when staging When creating a pak file, do a filtered copy of all ini files to a temp directory so that all confidential fields can be stripped. Equivalent behaviour to staging a loose file distribution Change 3451476 on 2017/05/22 by Ben.Marsh Compile shipping builds for WEX and Ocean, and post telemetry for the resulting executable size. Change 3451478 on 2017/05/22 by Graeme.Thornton PR #3197: Improved log message formatting (Contributed by projectgheist) Change 3451868 on 2017/05/22 by Steve.Robb Static log category moved out of header. ENUM_CLASS_FLAGS macro used instead of explicit operators. Change 3452319 on 2017/05/22 by Ben.Marsh UBT: Add a new "package" build product type, which can be used for APK files on Android and Stub files on iOS. Treating these files as executables is causing the measured executable size to be incorrect. Change 3452607 on 2017/05/22 by Ben.Marsh UBT: Filter out folders for other platforms when searching for headers to pass to UHT. Change 3453600 on 2017/05/23 by Graeme.Thornton PR #3226 - Updated some code comments to better describe the usage of the log category definition macros Change 3453616 on 2017/05/23 by Steve.Robb Error reported instead of a crash when there's a space between UCLASS or UINTERFACE and the open parenthesis. Change 3453714 on 2017/05/23 by Ben.Marsh Build: Add some Visual Studio 2017 test compiles to the build system. Change 3453795 on 2017/05/23 by Ben.Marsh UBT: Fix parsing of command line attributes that have a specific value assigned. We should never have an '=' suffix for such arguments. Change 3454606 on 2017/05/23 by Ben.Marsh UAT: Make sure log filenames are unique by creating a 0-byte file in its place. Change 3454709 on 2017/05/23 by Ben.Marsh UBT: Enable the /permissive- option for stricter standards compliance on Visual Studio 2017. Currently have /Zc:strictStrings disabled due to violations in Windows headers; all UE4 instances have been fixed up. Change 3456445 on 2017/05/24 by Graeme.Thornton MemoryProfiler2 - Add mprof filename into title bar after opening Change 3457129 on 2017/05/24 by Ben.Marsh Fix comment for FVector::Normalize(). #jira UE-45369 #rnx Change 3457228 on 2017/05/24 by Ben.Marsh Do not allow forward-declaring Rect structs. They are not public, and it conflicts with third party libraries. #rnx Change 3458357 on 2017/05/24 by Ben.Marsh Fix name resolution issue with /permissive- in VS2017. Change 3458812 on 2017/05/25 by Robert.Manuszewski PR #2407: Fix LoadLibrary error with Microsoft Group Policy CWDIllegalinDllSearch mode 1 or 2 (Contributed by bozaro) Change 3458894 on 2017/05/25 by Robert.Manuszewski PR #2096: Fix argument parsing in DiffAssets Comandlet (Contributed by cgrebeld) Change 3461205 on 2017/05/26 by Robert.Manuszewski Fixed parameter parsing so that arguments are not parsed if not preceeded by a whitespace (for example "-Log" was parsed in "TM-Log") #jira UE-33790 Change 3464714 on 2017/05/30 by Robert.Manuszewski Fixing potential deadlock caused by a race condition when using FMallocVerifyProxy with FMallocBinned Change 3465310 on 2017/05/30 by Ben.Marsh UBT: Enable bAdaptiveUnityDisablesOptimizations by default. Change 3465346 on 2017/05/30 by Ben.Marsh UBT: Require Update 3 to be installed when compiling using VS2015. Change 3465389 on 2017/05/30 by Ben.Marsh UBT: Fix support for RTTI when creating PCHs and shared PCHs. Change 3466084 on 2017/05/30 by Ben.Marsh Fix compiling plain C files, where it would incorrectly use a C++ PCH. Change 3467018 on 2017/05/31 by Robert.Manuszewski Async loading code will now properly handle cases when the requested package could not be created. Change 3467113 on 2017/05/31 by Ben.Marsh UGS: When opening a solution in Visual Studio, always start the process in the solution's directory. Change 3467508 on 2017/05/31 by Ben.Marsh Add a function to fix a long package name so it matches the case of a file on disk. Fixes deterministic cooking issues when on-disk case changes. Change 3467510 on 2017/05/31 by Ben.Marsh Fix deterministic cooking issue caused by LODGroup only being initialized in the CDO if it's serialized, causing inconsistent delta serialization for instances. Change 3467967 on 2017/05/31 by Ben.Marsh Always allow UAT to compile on non-Windows platforms, even if a debugger is present, since MSVC is the only one that will load C# PDBs. Change 3468544 on 2017/05/31 by Ben.Marsh UBT: Add a more helpful message when a module is being compiled with implicit PCHs, but a source file is not configured correctly. Change 3469241 on 2017/06/01 by Ben.Marsh UBT: Fix single-file compile causing a different UHT manifest to be generated, potentially excluding hidden dependencies. Change 3471709 on 2017/06/02 by Daniel.Lamb Rebuild lighting commandlet now rebuilds reflections also instead of trashing them. #test None Change 3471719 on 2017/06/02 by Daniel.Lamb Fixed crash in cooker while trying to cook for multiple platforms #test Launch on shootergame windows + ps4 #jira UE-45356 Change 3472261 on 2017/06/02 by Ben.Marsh CRP: Clear out MDD logs whenever we clear out CRP logs. Change 3473169 on 2017/06/05 by Graeme.Thornton PR #3622: Log category code cleanup (Contributed by projectgheist) Change 3473176 on 2017/06/05 by Graeme.Thornton PR #3622: Log category code cleanup (Contributed by projectgheist) (Part II) - Missed some files from my previous checkin Change 3473597 on 2017/06/05 by Ben.Marsh UnrealVS: Fix massive slowdown on startup caused by searching the directory tree under the solution for *.uproject files (including intermediate folders, etc...). Now reads *.uprojectdirs files and only checks the listed directories within. Measured it taking > 30s to run before, now takes < 0.1s. Change 3473722 on 2017/06/05 by Steve.Robb GitHub #3444: UE-42521: Added missing macro's for TMap and TSet PREPROCESSOR_COMMA_SEPARATED added as a better solution for the hacky comma separator solution in the PR. Change 3475073 on 2017/06/06 by Steve.Robb Fix for TPromise's move assignment operator return value. Change 3475331 on 2017/06/06 by Ben.Marsh UAT: Fix invalid paths being generated when stripping encryption settings from config files. * In cases where INI files were in a subfolder of the Config folder (eg. Config\Localization), it was not stripping the separating slash, resulting in files being written to the root directory of the current drive. * Paths under the config folder are not guaranteed to be unique. Change 3475453 on 2017/06/06 by Ben.Marsh UBT: Add an error if a plugin lists a non-plugin module as belonging to it. #jira UE-45178 Change 3475668 on 2017/06/06 by Ben.Marsh Add a message showing when we begin creating the asset registry, since it can take a long time. #jira UE-41675 Change 3475747 on 2017/06/06 by Steve.Robb Replicated from CL# 3332960: Force a gather on hot reload, so we don't use stale state from the makefile. #jira UE-42205 Change 3475897 on 2017/06/06 by Ben.Marsh PR #3655: Improved behavior for Automation.IsBuildMachine (Contributed by projectgheist) Change 3477432 on 2017/06/07 by Robert.Manuszewski Removed AsyncIOBandwidthLimit as it was no longer being used by anything. Change 3478582 on 2017/06/07 by Ben.Marsh UBT: Allow setting the UE_ENGINE_DIRECTORY macro for any monolithic builds, to fix being able to debug cooked foreign projects in the binary release. Change 3480035 on 2017/06/08 by Gil.Gribb UE4 - Fixed async loading from pak files < 64k. Change 3484348 on 2017/06/12 by Robert.Manuszewski Removed private_subobject macro which was a temporary measure to make all subobjects private without breaking game code. Change 3484863 on 2017/06/12 by Steve.Robb Fix for TSparseArray::operator= corrupting non-POD objects. InCopy.ArrayMax cached in a local instead of being read each time. Const-correctness fix for element copy construction. SrcData and DestData names flipped as they were the wrong way around. Source: https://udn.unrealengine.com/questions/374840/possible-bug-in-tsparsearray-assignment-operator.html Change 3485003 on 2017/06/12 by Ben.Marsh UGS: Add support for multiple tabs. Each tab can monitor changes in a separate workspace, and scheduled syncs will run for all open tabs. Change 3485063 on 2017/06/12 by Ben.Marsh UGS: Fix a null reference exception when right clicking on the notification icon during startup. Change 3485104 on 2017/06/12 by Ben.Marsh PR #2084: [UAT] Command-line parameter to override branch name (Contributed by nbjk667) Change 3485112 on 2017/06/12 by Steve.Robb TSetElement generic constructor protected from becoming a copy constructor. Redundant #include removed from AreTypesEqual.h. Source: https://udn.unrealengine.com/questions/374840/possible-bug-in-tsparsearray-assignment-operator.html Change 3485452 on 2017/06/12 by Ben.Marsh UnrealVS: Fix command line not being updated for C# projects. IVsBuildPropertyStorage.SetPropertyValue does not seem to update properties that are cached in memory. #jira UE-45716 Change 3486182 on 2017/06/12 by Ben.Marsh UGS: Include option to selet tab names in the options menu. Change 3486189 on 2017/06/12 by Ben.Marsh UGS: Fix browse button from context menu always opening a new tab. Change 3486636 on 2017/06/13 by Steve.Robb FStatMessagesArray iteration changed to use ranged-for instead of indexing. Change 3486688 on 2017/06/13 by Steve.Robb Fix for CDO pointer replacement in non-UObject properties during hot reload. #jira UE-38146 Change 3486704 on 2017/06/13 by Ben.Marsh UGS: Fix exception when closing the last open tab. Change 3486707 on 2017/06/13 by Ben.Marsh UGS: Fix exception on load if UGS was closed with no projects open. Change 3486715 on 2017/06/13 by Ben.Marsh UGS: Change tabs to show the project file by default. Change 3486718 on 2017/06/13 by Ben.Marsh UGS: Only allow one workspace to sync at a time. Change 3486880 on 2017/06/13 by Ben.Marsh UGS: Show the sync progress of each tab via the underline on the tab button. Change 3486912 on 2017/06/13 by Ben.Marsh UGS: Include the open project and recent project list as separate top-level menu items. Change 3486914 on 2017/06/13 by Ben.Marsh UGS: Update version to 1.101. Change 3487092 on 2017/06/13 by Ben.Marsh UGS: Fix crash on startup if log window is minimized. Change 3487099 on 2017/06/13 by Ben.Marsh UGS: Update version to 1.102 Change 3487198 on 2017/06/13 by Ben.Marsh Remove debug code. Change 3487285 on 2017/06/13 by Ben.Marsh Restore Remap() function that was accidentally removed in merge. Change 3487769 on 2017/06/13 by Ben.Marsh Disable the promoted flag when using the SyncProject command on Mac; doing so prevents UE4Game being compiled when packaging blueprint projects. #jira UE-45995 Change 3487915 on 2017/06/13 by Ben.Marsh UAT: Fix exception due to collection being modified while packaging for Linux. #jira UE-46013 Change 3487972 on 2017/06/13 by Ben.Marsh UAT: Always allow staged files to overwrite previously staged files. New iOS code relies on old behavior to overwrite engine icons and metadata with game copies. #jira UE-46014 Change 3487991 on 2017/06/13 by Ben.Marsh UAT: Ensure that the directory exists before trying to create a placeholder log filename. #jira UE-46015 Change 3489062 on 2017/06/14 by Robert.Manuszewski Removed FPackageFileSummary's AdditionalPackagesToCook as it was not used by anything. This should reduce the package header size considerably for levels with many streaming sublevels. #jira UE-45563 Change 3489063 on 2017/06/14 by Robert.Manuszewski Increasing the maximum package summary size to handle levels with multiple streaming sublevels. #jira UE-45563 Change 3491552 on 2017/06/15 by Ben.Marsh Handle failures to load *MeshReduction modules. [CL 3492074 by Ben Marsh in Main branch]
2017-06-15 12:43:54 -04:00
List<FileReference> Exes = SC.StageTargetPlatform.GetExecutableNames(SC);
ClientApp = Exes[0].FullName;
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3431384) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3252833 on 2017/01/10 by Ori.Cohen Refactor constraint so that it can be used for external solvers. (Copying //Tasks/UE4/Dev-ImmediateModePhysics to Dev-Framework (//UE4/Dev-Framework)) Change 3256288 on 2017/01/12 by Ori.Cohen Undo constraint refactor as we found a way around it and it made the code much harder to read/debug Change 3373195 on 2017/03/30 by Mike.Beach For nativization, changing it so we key off of the target platform-info struct instead of the platform (in preparation for defining the nativized plugin's platform whitelist). Change 3381178 on 2017/04/05 by Dan.Oconnor Make sure we don't inherit the NATIVE func flag when generating skeleton functions, also make sure all bojects outer'd to the skeleton class are marked transient #jira UE-43616 Change 3381532 on 2017/04/05 by Marc.Audy (4.16) Fix various cases where built lighting on child actors could be lost when loading a level #jira UE-43553 Change 3381586 on 2017/04/05 by Mike.Beach Now generating TArrayCaster conversions for nativized UClass arrays that need it (to handle different TSubclassOf arrays). #jira UE-42676, UE-43257 Change 3381682 on 2017/04/05 by mason.seay Some more changes to test map Change 3381844 on 2017/04/05 by Dan.Oconnor Match existing logic for CPF_ReturnParm/CPF_OutParm. Fixes compilation error in BP_TurbineBlades when using compilation manager Change 3382054 on 2017/04/05 by Zak.Middleton #ue4 - Optimize CharacterMovementComponent::GetPredictionData_Client_Character() and GetPredictionData_Server_Character() to remove virtual calls. #jira UE-30998 Change 3382703 on 2017/04/06 by Lukasz.Furman fixed missing links between navmesh polys when there are more than 4 neighbor connections #jira UE-43524 Change 3383357 on 2017/04/06 by Marc.Audy (4.16) Make SetHiddenInGame propagate consistently with SetVisibility #jira UE-43709 Change 3383359 on 2017/04/06 by Dan.Oconnor Fix last errant SKEL reference when cooking Odin Change 3383591 on 2017/04/06 by Mike.Beach Prevent users from setting object variables as 'config' properties (disallowed by UHT). This prevents some errors that could happen later when users nativize the Blueprint. #jira UE-42085 Change 3384762 on 2017/04/07 by Zak.Middleton #ue4 - Fix SpringArmComponent not restoring relative transform when bUsePawnControlRotation is turned off. Fixes the editor interaction ignoring transform of the component in the viewport after bUsePawnControlRotation is toggled on then off, since by then the world transform had been overwritten (from tick in editor) and nothing would drive transform changes from the editable value. Toggling bUsePawnControlRotation off at runtime now restores the rotation to the initial relative rotation, not stomping it with the current pawn rotation, allowing toggling between the editable/desired base rotation and the control rotation. #jira UE-24850 Change 3384948 on 2017/04/07 by Dan.Oconnor Prevent GForceDisableBlueprintCompileOnLoad from causing all sorts of badness when dependencies are loaded as part of a Diff operation. Instead of setting a global flag we flag the package as LOAD_DisableCompileOnLoad Change 3385267 on 2017/04/07 by Michael.Noland Graph Editing: Pushed some node diffing code down from UAIGraphNode into UEdGraphNode so nodes with details panel properties will diff correctly (e.g., various animation nodes and BP switch nodes) #jira UE-21724 Change 3385473 on 2017/04/07 by Phillip.Kavan #jira UE-43067 - Fix broken pin wires after an Expand Node operation, along with some misc. cleanup. Change summary: - Fixed to use correct string for "Expand Node" transaction name. - Modified FBlueprintEditor::OnExpandNodes() to consolidate some redundant code. - Fixed to generate a unique node GUID for cases where the source graph is not removed after expansion. Change 3385583 on 2017/04/07 by Dan.Oconnor Handle CreatePropertyOnScope nullptr return values (happens for structs missing a struct property) #jira UE-43746 Change 3386581 on 2017/04/10 by Michael.Noland Blueprints: Further hardening FBlueprintActionInfo::GetOwnerClass() #jira UE-43824 Change 3386615 on 2017/04/10 by Marc.Audy Instanced properties can now properly be set on a per-instance basis in blueprint added components. #jira UE-42066 Change 3387000 on 2017/04/10 by Marc.Audy Fix includes for CIS Change 3387229 on 2017/04/10 by mason.seay More changes to TM-Gameplay Added Save Game test (with blueprint) Tick Interval test (with blueprint) BP logic cleanup Level organization Change 3388437 on 2017/04/11 by Mike.Beach Adding support for map/set literals in the backend (so you can use set nodes for structs containing sets/maps, without having to connect a RHS input - resets to struct defaults). #jira UE-42617 Change 3388532 on 2017/04/11 by mason.seay Submitting latest changes for crash repro Change 3389026 on 2017/04/11 by Ben.Zeigler Performance and bug fixes for incremetal cooking with asset registry, duplicate of several changes made on //Fortnite/Main Fix it so AssetRegistry.ScanPathsAndFilesSynchronous won't scan subdirectories inside already scanned directories, this cuts down on the number of cache files Fix 2 second stall when shutting down AssetSourceFilenameCache if it had never been previously created Change 3389163 on 2017/04/11 by Ben.Zeigler #jira UE-42922 Fix it so connecting function input node output pins does not clear default value, we only want to clear the value when connecting an input pin. Properly testing this fix depends on UE-43883 Change 3389205 on 2017/04/11 by Marc.Audy Protect against a handful of GEditor usages that can now be hit in standalone Change 3389220 on 2017/04/11 by Marc.Audy Don't borrow ClassWithin to masquerade as ParentClass during compilation and instead just set the super struct immediately Change 3389222 on 2017/04/11 by Michael.Noland Framework: Adding a cvar (t.TickComponentLatentActionsWithTheComponent) to allow users to revert to the old behavior on when component latent actions tick - Non-zero values behave the same way as actors do, ticking pending latent action when the component ticks, instead of later on in the frame (default behavior in 4.16 and beyond) - Prior to 4.16, components behaved as if the value were 0, which meant their latent actions behaved differently to actors This CVar will be removed in a future version, defaulting to on #jira UE-43661 Change 3389276 on 2017/04/11 by Marc.Audy Spelling fix and NULL to nullptr Change 3389303 on 2017/04/11 by Mieszko.Zielinski Made sure AIController::Posses doesn't get called when compiling Pawn BP #UE4 #jira UE-43873 Change 3390215 on 2017/04/12 by mason.seay Removed some tests, will need further review Change 3390638 on 2017/04/12 by Mike.Beach Generalizing the omission of the CoerceProperty (in EmitTerm) - previously we were only omitting properties for our custom array lib. For wildcards, a coerce property should not be used as its type will not match. NOTE: There is a slight behavior change in UEdGraphSchema_K2::ConvertPropertyToPinType(), as it will return 'wildcard' for params marked as 'ArrayTypeDependentParams' (previously would have returned 'int'). #jira UE-42747 Change 3390774 on 2017/04/12 by Ben.Zeigler #jira UE-43911 Fix several issues with saving a runtime asset registry containing redirectors that caused crashes in cook on the fly. Don't resolve redirectors on incoming links because it will make a circular link, and fix an issue where chained redirectors would break the for loop iteration and return a bad dependency Fix it so the asset registry written out at the beginning of CookOnTheFly uses the registry generator, otherwise it will include all of the stripped editor only tags Change 3390778 on 2017/04/12 by Ben.Zeigler Fix UCookOnTheFlyServer::CollectFilesToCook to check for initial unsolicited packages up front. This is required in iterative mode because it may skip cooking all explicit packages and thus miss a new startup loaded package Change 3390782 on 2017/04/12 by Ben.Zeigler Change RunProjectCommand to not imply -nomcp, and allow reading -clientcmdline to override setting the map parameter to 127.0.0.1 by default Fix RunProjectCommand to remove ios-specific checks to not pass weird platform parameters, and instead never pass them Fix PS4Platform to pass along command line when calling build cook run, args needs to be the last parameter so explicitly set -target= Change 3390859 on 2017/04/12 by Mike.Beach T3D class fields now export with the class's fully qualified path name (to avoid abiguity). Since we can have multiple classes with the same name (Blueprints in different folders), we have to use the class's fully qualified object path. #jira UE-28048 Change 3390914 on 2017/04/12 by Lukasz.Furman fixed missing navlink component's transform in exported navigation data #jira UE-43688 Change 3391122 on 2017/04/12 by Ben.Zeigler Add new PreloadPrimaryAssets call to AssetManager that stream the desired assets without modifying the official load/unload state. This is useful if you want to preload things in case the might be used in the future, and it also supports recursion Fix crash calling GetAssetDataForPath with null path Change 3391494 on 2017/04/12 by Dan.Oconnor Fix bad references in deep object (widget) hierarchies #jira UE-43802 Change 3391529 on 2017/04/12 by Dan.Oconnor Fix log spam, accidently submitted #rnx Change 3391756 on 2017/04/12 by Dan.Oconnor LinkExternalDependencies needs to be performed before we RefreshVariables #jira UE-43843 Change 3392542 on 2017/04/13 by Marc.Audy Ensure that initialized actors get cleaned up when removed from world even if that world hasn't begun play. #jira UE-43879 Change 3392746 on 2017/04/13 by Marc.Audy (4.16) When duplicating a blueprint node, correctly make the new node a sibling of the duplicated node, not a child of it (unless duplicating the root component). Also resets scale of a duplicated root component to 1 to avoid a squaring of the scale for that component. #jira UE-40218 #jira UE-42086 Change 3393253 on 2017/04/13 by Dan.Oconnor Make sure calculated meta data is correctly set on functions generated by the compilation manager (SKEL_ class functions) #jira UE-43883 Change 3393509 on 2017/04/13 by Mike.Beach Removing hack'ish ResetLoaders() call that was causing undesired side-effects (resetting of a loaded package that other objects were relying on). This was originally intended to release file handles so separate editor processes could make updates and save the file (from CL 1712376). Using ResetLoaders() for this is bad though, as it has too many side effects. Instead we have to wait for GC to run. This also makes sure that GC should run as intended as the CookOnTheFly sever is idling. #jira UE-37284 Change 3394350 on 2017/04/14 by Michael.Noland Core: Making FDateTime and FTimespan actually reflected, so they get duplicated properly in CopyPropertiesForUnrelatedObjects, etc... #jira UE-39921 Change 3395985 on 2017/04/17 by Phillip.Kavan #jira UE-38280 - Fix invalid custom type selections on member fields in the User-Defined Structure Editor after a reload. Change summary: - Ensure that the 'SubCategoryObject' member in a UDS variable descriptor has been loaded when converting to an FEdGraphPinType. Change 3396152 on 2017/04/17 by Marc.Audy TickableGameObjects that have IsTickableInEditor false should not tick in the editor #jira UE-40421 Change 3396279 on 2017/04/17 by Phillip.Kavan #jira UE-43968 - Fix failed validation of bitmask enum types when serializing bitmask literal nodes. Change 3396299 on 2017/04/17 by Dan.Oconnor Fix resintancing issues exposed by running TM-Gameplay with -game. We cannot reinstance actors in levels on load because the scene is not created. #jira UE-43859 Change 3396712 on 2017/04/17 by Marc.Audy Call PostLoad on subobjects before copying for unrelated properties to avoid cases where an out of date object patched over in the linker has not been brought up to date #jira UE-38234 Change 3396718 on 2017/04/17 by Mike.Beach Adding a search bar to the components tree for Blueprints. #epicfriday #jira UE-17620 Change 3396999 on 2017/04/17 by Mike.Beach In generated code, call event '_Implementation' functions directly for interface functions being invoked on self (avoids a UHT runtime error). #jira UE-44018 Change 3397700 on 2017/04/18 by Marc.Audy UT struct BlueprintType fixups Change 3397701 on 2017/04/18 by Marc.Audy Odin struct BlueprintType fixups Change 3397703 on 2017/04/18 by Marc.Audy Ocean struct BlueprintType fixups Change 3397704 on 2017/04/18 by Marc.Audy WEX struct BlueprintType fixups Change 3397705 on 2017/04/18 by Marc.Audy Additional UT blueprint type struct fixups Change 3397706 on 2017/04/18 by Marc.Audy Fortnite struct BlueprintType fixups Change 3397708 on 2017/04/18 by Marc.Audy Fixup Engine BlueprintType markup of structs Change 3397709 on 2017/04/18 by Marc.Audy Sample Game struct BlueprintType fixups Change 3397711 on 2017/04/18 by Marc.Audy Mark AnimNodes as BlueprintType and BlueprintInternalUseOnly Change 3397712 on 2017/04/18 by Marc.Audy Paragon struct BlueprintType fixups Change 3397735 on 2017/04/18 by Marc.Audy Definition pieces of BlueprintInternalUseOnly to fix UHT errors with structs already marked to use it Change 3397912 on 2017/04/18 by Mike.Beach Fix for CIS warnings about shadowed variables (fallout from CL 3396718). Change 3398455 on 2017/04/18 by Marc.Audy Make less critical errors log an error rather than immediately throwing allowing multiple errors to be reported in the same compile Change 3398491 on 2017/04/18 by Marc.Audy BPRW/BPRO in a non-BlueprintType is now a UHT error Change 3398539 on 2017/04/18 by Marc.Audy Fixup live link struct markups Change 3399412 on 2017/04/19 by Marc.Audy Fix Match3 blueprint type struct markups Change 3399509 on 2017/04/19 by Phillip.Kavan #jira UE-38574 - Fix AnimBlueprint function graphs marked as 'const' to treat 'self' as read-only when compiling. Change summary: - Modified FKismetCompilerContext::ProcessOneFunctionGraph() to use the function graph schema rather than the compiler context schema for both the function context's schema as well as testing the function for 'const'-ness. For AnimBPs, the compiler context and the function graph context can differ, so we need to make sure we are using the right one when making queries for a specific function context during compilation. - Minor cleanup: changed the function context schema to be 'const' in order to be consistent with the function graph GetSchema() API's result. Added a few 'const' qualifiers where needed to match. - Added a new object version in order to avoid breaking compilation of existing AnimBP function graphs that may already be violating the 'const' rule (this is the same thing that was done when 'const' was first added to "normal" BP function graphs). Just as with normal function graphs in place before the addition, a warning will be generated for existing AnimBP function graphs if they violate 'const' correctness, and an error will be generated for all new ones. Change 3399749 on 2017/04/19 by Mike.Beach Hiding the Nativized Blueprints plugin from the in-editor browser (prevent users from disabling it). Change 3399774 on 2017/04/19 by Marc.Audy ConditionalPostLoad is already called on StaticMesh earlier in the function #rnx Change 3400313 on 2017/04/19 by Mike.Beach Mirroring CL 3398673 from 4.16 Now, with ICWYU, making sure that the coresponding header gets included first in nativized Blueprint files (else we get a UHT error). Had to fixup some ShooterGame specific files as a result (they had missing includes and forward declarations). #jira UE-44124 Change 3400328 on 2017/04/19 by Mike.Beach Missing file from mirrored change (CL 3400313 - mirroring CL 3398673 from 4.16) #jira UE-44124 Change 3400415 on 2017/04/19 by Chad.Garyet adding physx switch build to framework Change 3400514 on 2017/04/19 by Mike.Beach Back out changelist 3400313 / 3400328 (mirrored from CL 3398673 in 4.16), as it was producing "include PCH first" errors. Likely, CL 3398673 was a fix for a 4.16 specific change, altering the expected include order. We'll have to wait for this one to be integrated back. Change 3400552 on 2017/04/19 by Marc.Audy Undo the calling of post load prior to the CPFUO as dependent objects may not yet be loaded. Instead copy the need load flag to the new CDO subobject, similarly to how the top level CDO object copies its flags over. #jira UE-44150 Change 3400815 on 2017/04/19 by Marc.Audy Spelling fix (part of PR #3490) #rnx Change 3400918 on 2017/04/19 by Marc.Audy Partial pull of PR #3490: Improved remapping game controls support (Contributed by projectgheist) This portion brings in the exposure of the bindings to blueprint #jira UE-44122 Change 3401550 on 2017/04/20 by Marc.Audy fix kitedemo blueprint type markup #rnx Change 3401702 on 2017/04/20 by Mike.Beach Make it so plugins added to a project through the .uproject's 'AdditionalPluginDirectories' list get folded into the generated code project (for visual studio, etc.). Change 3401720 on 2017/04/20 by Mike.Beach Add white and black lists for target type (game, client, server, etc.) to plugin module descriptors. Change 3401725 on 2017/04/20 by Mike.Beach Whitelisting the nativized Blueprint plugin for only the targets it was built for (game, server, or client). Change 3401800 on 2017/04/20 by Ben.Zeigler Add Algo::BinarySearch, LowerBound, and UpperBound. These are setup to allow binary searching a presorted array, and allow for specifying projection and sort predicates. Convert some engine code to use it Add TSortedMap, which is a map data structure that has the same API as TMap, but is backed by a sorted array. It uses half the memory and performance is faster below n=10 Add FName::CompareIndexes so a SortedMap with FNames can be used without doing very slow string compares, and FNameSortIndexes predicate to sort by it Add code to Algo and Container tests. Split up container tests so the new ones aren't run in smoketest as they are a bit slow Add RemoveCurrent and SetToEnd to ArrayIterator Change 3401849 on 2017/04/20 by Marc.Audy Partial pull of PR #3490: Improved remapping game controls support (Contributed by projectgheist) This portion brings bug fixes and improvements to InputKeySelector UMG widgets. #jira UE-44122 Change 3402088 on 2017/04/20 by Marc.Audy Focus the search box when expanding the map value type #jira UE-44211 Change 3402251 on 2017/04/20 by Ben.Zeigler Fix issue where SortedMap needs to be resorted after serialization, because the sorting may have changed from when it was saved out Change 3402335 on 2017/04/20 by Ben.Zeigler Significant changes to FAssetData serialization and memory, cuts memory significantly but will break code that was using some of the internal API that was not properly hidden before Both Editor and Runtime cache now use the same FAssetRegistryVersion, which is now registered as a custom version Rename FAssetData and FAssetPackage operator<< to SerializeForCache to make it clear that it isn't safe to use for general serialization Remove GroupNames from FAssetData, it has not been useful since the UE4 package structure changed around 4.0 Rename generic-sounding but not actually generic SharedMapView class to AssetDataTagMapSharedView to indicate what it is actually used for Change TagsAndValues to use a new array-backed TSortedMap as the base structure instead of a hash map. Also, it only allocates the map on demand, which saves significant memory at runtime as many packages have no tags Add bFilterAssetDataWithNoTags to [AssetRegistry] ini section, if set it will only save cooked asset data if it has tags, off by default but saves significant memory if your whitelist is set up properly Fix issue where asset registry tags updated by loading assets during cook were not being reflected in the cooked registry Add AssetRegistry::GetAllocatedSize and add to MemReport output Change 3402457 on 2017/04/20 by Ben.Zeigler Enable asset registry iteration and stripping unused asset data in Fortnite. Registry iteration is already on in //Fortnite/Main, stripping is a new feature I want to test Change 3402498 on 2017/04/20 by Ben.Zeigler CIS fix. Why did this compile locally? Change 3402537 on 2017/04/20 by Ben.Zeigler Remove ensure for making AssetData for subobjects, the editor does this for thumbnail creation in some cases Change 3402600 on 2017/04/20 by Ben.Zeigler Add bShouldGuessTypeAndNameInEditor to manager settings, can be set false for games where type cannot be safely implied and content must be resaved Fix up some bool setting code inside asset manager, and fix const correctness and for iterator issues AssetManager can now discover any BlueprintCore type when bHasBlueprintClasses=true Add AssetManager.DumpAssetRegistryInfo to output detailed asset registry usage stats Add Primary Name to asset audit window by default Change 3403556 on 2017/04/21 by Marc.Audy Fix Orion input key selector override class #rnx Change 3404090 on 2017/04/21 by mason.seay Applying Forcefeedback to test map Change 3404093 on 2017/04/21 by mason.seay Changing text in level Change 3404139 on 2017/04/21 by mason.seay Added Force Feedback test and made some tweaks. Change 3404146 on 2017/04/21 by mason.seay Added source reference to Instanced Variable test Change 3404154 on 2017/04/21 by mason.seay More minor tweaks Change 3404155 on 2017/04/21 by Marc.Audy Remove auto #rnx Change 3404188 on 2017/04/21 by Marc.Audy Fixed crash changing variable type when any type other than map #jira UE-44249 #rnx Change 3404463 on 2017/04/21 by Ben.Zeigler Fix asset data code to not ensure when loading an object with invalid exports, and instead print warning with name of package that needs to be resaved Resave a map that had a redirector from a DIFFERENT package saved in it's exports. I do not understand how this happened, but it appears to be related to the lightmap BuiltData transition when old maps are opened Change 3404465 on 2017/04/21 by Ben.Zeigler Fix issue with trying to load editor-only asset classes in a cooked build Fix issues with renaming or changing template Ids of assets from the editor Always print the Duplicate Asset ID error, as if you have more than one the ensuremsg only goes off once Change 3404481 on 2017/04/21 by Dan.Oconnor Remove unneeded walk up hierarchy - prevent stale entries in action database if we compile a BP but don't compile its children Change 3404510 on 2017/04/21 by Phillip.Kavan #jira UE-35727 - Collapsed graphs containing a local variable node will no longer cause a compile error when the parent graph is renamed. Change 3404590 on 2017/04/21 by Michael.Noland Editor: Fixed incorrect filtering of abstract/deprecated UDeveloperSettings and UContentBrowserFrontEndFilterExtension classes caused by a typo (HasAnyCastFlags versus HasAnyClassFlags) Change 3404593 on 2017/04/21 by Marc.Audy Fixed another crash to do with input pin secondary combo box #jira UE-44269 #rnx Change 3404600 on 2017/04/21 by Michael.Noland Core: Allow UE_GC_TRACK_OBJ_AVAILABLE to be set externally #rnx Change 3404602 on 2017/04/21 by Michael.Noland Engine: Switched from an include to a forward declaration of SWidget in UDeveloperSettings to keep it slim #rnx Change 3404608 on 2017/04/21 by Michael.Noland Core: Marked TNumericLimits as constexpr so they can be used in static asserts Change 3404659 on 2017/04/21 by Michael.Noland Engine: Adding includes back to two UDeveloperSettings subclasses Change 3405289 on 2017/04/24 by Marc.Audy Remove auto #rnx Change 3405446 on 2017/04/24 by Marc.Audy Fix Win32 unsigned compile issue Change 3405512 on 2017/04/24 by Mike.Beach Piping through NativizationOptions to filename generation (so we're able to gen different files names per target: client vs. server). Change 3406080 on 2017/04/24 by Ben.Zeigler Deprecate UEngine::OnPostEngineInit and move to FCoreDelegates, clean up comments for the initialization delegates Call OnPostEngineInit from commandlet initialization as well as normal execution. I thought about making a wrapper function, but the commandlet calls EditorInit directly so it wouldn't work Bind delegate to refresh the AssetRegistry native class hierarchy after engine init so it picks up game/plugin classes. Undo ini change that was required to hack around this Change 3406381 on 2017/04/24 by Ben.Zeigler #jira UE-23768 Enable Run Physics With No Controller for montage test pawn. The montage pawn has no controller so wasn't correctly running physics when the root motion stopped. This flag needs to be set to allow it to correctly stop after the montage is over Change 3406438 on 2017/04/24 by Ben.Zeigler Fix deprecation warning Change 3406519 on 2017/04/24 by Phillip.Kavan #jira UE-43612 - Suppress array "Get" node fixup notifications on load when the BP Compilation Manager is enabled. Change summary: - Wrapped BPCM calls to FBlueprintEditorUtils::ReconstructAllNodes() and ReplaceDeprecatedNodes() duirng compile-on-load with bIsRegeneratingOnLoad = true. This matches the BP's state during compile-on-load when the BPCM is not enabled. Change 3406565 on 2017/04/24 by Dan.Oconnor Make sure all interface functions are added to skeleton #jira UE-44152 Change 3407489 on 2017/04/25 by Ben.Zeigler #jira UE-44317 Fix game-only TickableGameObjects to correctly tick in PIE Change 3407558 on 2017/04/25 by Ben.Zeigler Fix Fortnite cook warnings, issue had to do with the CDO being registered as a Primary Asset in conflict with the Class being registered Fix issue with renaming a BP primary asset not finding the old name Change 3407701 on 2017/04/25 by Dan.Oconnor Remove unneeded null check, static analysis doen't like the inconsistency Change 3407995 on 2017/04/25 by Marc.Audy Fixed maps and sets not working correctly with split pin. #jira UE-43857 Change 3408124 on 2017/04/25 by Ben.Zeigler #jira UE-39586 Change it so the blueprint String/Name/Object to Text node creates culture invariant text, and also have them show as an expanded node with a comment explaining this Fix Transform to actually return in the format specified in the comment, and fix comments on many text conversions Change 3408134 on 2017/04/25 by Marc.Audy Graph pin container type now represented by an enumeration (EPinContainerType) rather than 3 "independent" booleans. FEdGraphPinType constructor, UEdGraphNode::CreatePin, and FKismetCompilerContext::SpawnInternalVariable that took 3 booleans deprecated and replaced with a version that takes EPinContainerType. UEdGraphNode::CreatePin parameters reorganized so that PinName is before ContainerType and bIsReference, which default to None and false respectively Change 3408256 on 2017/04/25 by Michael.Noland Core: Changed UClass::ClassFlags to be of type EClassFlags for improved type safety Change 3408282 on 2017/04/25 by Marc.Audy (4.16) Fix incorrect positioning of instance components after duplication #jira UE-44314 Change 3408404 on 2017/04/25 by Mike.Beach Adding and removing the nativized plugin to/from the project when we alter the packaging nativization setting (so it gets picked up by project generation). Change 3408445 on 2017/04/25 by Marc.Audy Fix up missed deprecation cases #rnx Change 3409354 on 2017/04/26 by Marc.Audy Fix Linux CIS failure #rnx Change 3409487 on 2017/04/26 by Marc.Audy When dragging assets in to the SCS create them as siblings, not nested #jira UE-43041 Change 3409776 on 2017/04/26 by Ben.Zeigler #jira UE-44401 Fix issue with cooking a map containing a reparented component. In that case the child component may think it's not editor only, but it's archetype is editor only. This is not allowed in EDL, so now the child is marked as editor only as well Change 3410168 on 2017/04/26 by Dan.Oconnor Avoid calling virtual functions in the middle of compile #jira UE-44243 Change 3410252 on 2017/04/26 by Lukasz.Furman adjusted WITH_GAMEPLAY_DEBUGGER checks after IWYU changes #ue4 Change 3410385 on 2017/04/26 by Marc.Audy ChildActorComponent SetClass no longer fails when setting at runtime. #jira UE-43356 Change 3410466 on 2017/04/26 by Michael.Noland Core: Ensuring EClassFlags is 32 bit in a different way (underlying type of the enum is coming out signed even though all members are unsigned, long term fix is probably to move it to an enum class) #rnx Change 3410476 on 2017/04/26 by Michael.Noland Automation: Deleting some commented out methods #rnx Change 3411070 on 2017/04/27 by Marc.Audy Properly complete deprecation of old attachment API Change 3411338 on 2017/04/27 by mason.seay Map for Latent Action Tick Bug Change 3411637 on 2017/04/27 by Ben.Zeigler Back out CL #3381532 as it was causing crashes when adding new variables to blueprints, as the transaction array was being recursively modified while it was being added to Change 3412052 on 2017/04/27 by mason.seay Updated jump test map and pawn Change 3412231 on 2017/04/27 by Ben.Zeigler Fix issue where running SearchAllAssets multiple times after mounting new paths would throw away the asset registry cache, which slowed down incremental cooking substantially because the cooker mounts the autosave folder Duplicate of CL #3411860 Change 3412233 on 2017/04/27 by Ben.Zeigler Made FStreamableHandle::GetLoadedCount much faster by taking advantage of existing progress counter Duplicate of CL #3411778 Change 3412235 on 2017/04/27 by Ben.Zeigler Add code to FStringAssetReferenceThreadContext and FStringAssetReferenceSerializationScope which allows setting package name and collect options for string asset references serialized via something other than linker load Make RedirectCollector threadsafe to avoid issues with async loading asset references Fix it so ProcessStringAssetReferencePackageList will remove entries from the string asset array like resolve did, and rename function to indicate that Fix it so string asset references created by asset labels do not automatically get cooked, and significantly improve the speed of labels with lots of assets Add code to cooker and asset manager to explicitly mark non-cookable assets as NeverVook, this stops labels from ending up in the build if set that way Added option to not recurse package dependency changes more than one level when hashes change. This ended up not being significantly faster in a realistic case so left disabled Duplicate of CL #3412080 Change 3412352 on 2017/04/27 by Marc.Audy Refix lighting getting wrong position when getting component instance data Change 3412426 on 2017/04/27 by Marc.Audy Take first steps to making ComponentToWorld private and force use of accessor Make bWorldToComponentUpdated private Make ComponentToWorld and bWorldToComponentUpdated mutable Add a SetComponentToWorld function for the (likely ill-advised) places that were setting it directly. Change 3412468 on 2017/04/27 by Marc.Audy Remove last remnants of deprecated (4.11) custom location system Change 3413398 on 2017/04/28 by Marc.Audy Fix up missed deprecated attachment API uses Change 3413403 on 2017/04/28 by Marc.Audy Fix Orion compile error #rnx Change 3413448 on 2017/04/28 by Marc.Audy Fix up kite demo component to world privataization warnings #rnx Change 3413792 on 2017/04/28 by Ben.Zeigler Fix many bugs with blueprint pin default values, and add "Reset to Default Value" option to pin context menu Deprecate and rename SetPinDefaultValue because it actually sets the Autogenerated default. This was being called in bad places and destroying the stored autogenerated defaults #jira UE-40101 Fix expose on spawn pins to correctly update when the spawned object's defaults change #jira UE-21642 Fix struct pin default values to properly update when the struct is changed #jira UE-39418 Fix changed function/macro default values to properly update in already placed call nodes Change 3413839 on 2017/04/28 by samuel.proctor Added some Blueprint focused tests for TM-Gameplay Change 3414030 on 2017/04/28 by Ben.Zeigler Enable use of AssetPtr variables with Config, for native and blueprint This incorporates CL #3302487 but also enables for blueprint usage as that code is new to framework branch Change 3414229 on 2017/04/28 by Marc.Audy Fixup virtuals not calling their Super Remove some autos #rnx Change 3414451 on 2017/04/28 by Lukasz.Furman static analysis fix for gameplay debugger Change 3414482 on 2017/04/28 by Ben.Zeigler Fix crash found where changing pin type on ConvertAsset accessed an array while deleting it Change 3414609 on 2017/04/28 by Ben.Zeigler #jira UE-18146 Refresh graph when disconnecting a resolve asset id node Change 3415852 on 2017/05/01 by Marc.Audy Remove unused code #rnx Change 3415856 on 2017/05/01 by Marc.Audy auto removal #rnx Change 3415858 on 2017/05/01 by Marc.Audy Fix function taking an input as reference when unneeded and causing (still unclear why it suddenly started showing up) error in cooking #rnx Change 3415946 on 2017/05/01 by Marc.Audy Have K2Node_StructOperation skip the K2Node_Variable validation as it doesn't need a property (per CL# 1756451) #rnx Change 3415988 on 2017/05/01 by Lukasz.Furman renamed WorldContext param in AI related static blueprint functions to remove load/cook warnings #jira UE-44544 Change 3416030 on 2017/05/01 by Ben.Zeigler Fix issue with WorldContext pins being broken by my pin value refactor, partial paths like "WorldContext" need to be stored as strings and not as broken object references. Change 3416230 on 2017/05/01 by Marc.Audy Fix spelling error #rnx Change 3416419 on 2017/05/01 by Phillip.Kavan #jira UE-44213 - Nativizing a Blueprint class with a non-nativized Blueprint class subobject dependency will no longer lead to a crash at load time. Change summary: - Modified the FFakeImportTableHelper ctor to inject subobject CDOs into the 'SerializeBeforeCreateCDODependencies' array. This in turn ensures that EDL will serialize those subobject CDOs (if necessary) before we create the subobject's nativized owner's CDO at load time. - Modified FEmitDefaultValueHelper::GenerateCustomDynamicClassInitialization() to emit MiscConvertedSubobject instantiations AFTER we emit the FillUsedAssetsInDynamicClass() call. This is now consistent with the code emitted for other subobjects (all of which assumes that the UsedAssets array has been initialized). - Modified FFindAssetsToInclude::HandleObjectReference() to add UField owner CDOs in addition to the owner class to the asset dependency list. This ensures that owner CDOs will be emitted alongside the class to both the nativized asset dependency table as well as to the fake import table associated with the UDynamicClass linker for the nativized BP asset. Change 3416425 on 2017/05/01 by Phillip.Kavan #jira UE-44219 - Nativizing a Blueprint class with a nativized DOBP class dependency will no longer lead to a compile error at cook/nativization time. - Modified the FGatherConvertedClassDependencies ctor to properly handle DOBPs in exclusive mode that have been explicitly enabled for nativization. Previously, this code wasn't taking that possibility into account, and as a result could lead to a missing header file in a dependent nativized class body's include set. - Modified FGatherConvertedClassDependencies::GetFirstNativeOrConvertedClass() to remove the 'bExcludeBPDataOnly' parameter, as it was primarily just being used for a redundant exclusion check when called from the FGatherConvertedClassDependencies ctor. That call site has now been modified to start searching from the super class instead. Additionally, any DOBPs will already fail the preceding WillClassBeConverted() check if they have not been explicitly enabled for nativization in exclusive mode, and will always fail if nativizing in inclusive mode. The extra check was breaking the explicitly-enabled case, so it was removed to allow explicitly-enabled DOBPs to pass. Notes: - Allowing for explicitly-enabled DOBPs in exclusive mode may be removed in a future change, but since it is currently supported, the changes noted above will at least ensure that the generated code will compile properly for now. Change 3416570 on 2017/05/01 by mason.seay Added UMG test to map. Tweaked force feedback test Change 3416580 on 2017/05/01 by mason.seay Resubmitting sub levels Change 3416597 on 2017/05/01 by Dan.Oconnor Compilation manager iteration, adds machinery for individual blueprint compilation, adds comments, cleans up duplicated code Change 3416636 on 2017/05/01 by Phillip.Kavan #jira UE-44505 - Potential fix for a low-repro crash tied to the Blueprint graph context menu. Change summary: - Switched FBlueprintActionInfo::ActionOwner to be a weak object reference. Change 3416960 on 2017/05/01 by Dan.Oconnor Use compilation manager when clicking the compile button, PIE'ing, etc Change 3417207 on 2017/05/01 by Ben.Zeigler Fix issue with None strings causing default value parsing failures Add SetPinDefaultValueAtConstruction needed by some other changes Change 3417519 on 2017/05/01 by Ben.Zeigler Fix BP compile errors caused by local variables with invalid default values. There's no reason to set autogenerated here because the nodes are transient and invisible in the UI. There is still a problem here, local variables are not getting their default values validated when type is changed, so you end up with an integer that has the default value of a struct. Change 3418659 on 2017/05/02 by Ben.Zeigler #jira UE-44534 Fix it so animation node pins get properly created autogenerated default values that are based on the node struct defaults. This fixes issues when they are reset to other defaults #jira UE-44532 Fix it so connecting an animation asset pin on a node player resets the pin value to the autogenerated default instead of the cached asset. This was causing old unused assets to get unnecessarily cooked Fix it so any animation node with an exposed pin that is an object property will reset that object propery when the pin is exposed. This fixes UE-31015 in a generic way Change the OptionalPinManager to take a Defaults address as well as a current address, to allow setting autogenerated defaults properly Remove Import/ExportKismetDefaultValueToProperty as they were redundant with PropertyValueFromString and were using the wrong pin setting functions, replaced with PropertyValueFromString_Direct and calling the schema pin set functions I need to write some backward compatibility code to fix existing nodes, I'll do that in a later checkin Change 3418700 on 2017/05/02 by Ben.Zeigler Actually fix None object paths for real this time. I did not test sufficiently before Change 3418811 on 2017/05/02 by Ben.Zeigler Fix existing animation blueprint nodes with dead asset references duplicated by pins. This code can be applied independent of the other change to fix specific games Change 3419165 on 2017/05/02 by Dan.Oconnor Add misc. functionality from FKismetEditorUtilities::CompileBlueprint Change 3419202 on 2017/05/02 by Marc.Audy Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3417825 #rnx Change 3419236 on 2017/05/02 by mason.seay Removed OnPressed event from Widget BP Change 3419314 on 2017/05/02 by Marc.Audy Fix bad auto-resolve #rnx Change 3419524 on 2017/05/02 by Marc.Audy PR #3528: Improved Input BP library node display names (Contributed by projectgheist) #jira UE-44587 #rn Improved Input BP library node display names Change 3419570 on 2017/05/02 by Zak.Middleton #ue4 - Fix typo in TFunctionRef comment/example. Change 3419709 on 2017/05/02 by Dan.Oconnor Fix missing category metadata on SkeletonGeneratedClass when using compilation manager Change 3419756 on 2017/05/02 by Dan.Oconnor Remove unintentional verbosity increase Change 3420875 on 2017/05/03 by Marc.Audy Make IsExecPin static Minor optimization to IsMetaPin #rnx Change 3420981 on 2017/05/03 by Marc.Audy Change tagging temporarily until other changes are done so that we don't have warnings in the meantime #rnx Change 3421367 on 2017/05/03 by Marc.Audy Manually introduce changes from CL# 3398673 in 4.16 that failed to make it to Dev-Framework as a result of the integration submitted as CL# 3401725. #rnx Change 3421685 on 2017/05/03 by Ben.Zeigler #jira UE-23001 Convert literal Asset ID/Class ID pins to store path as string instead of as hard object reference. Old pins are fixed on load, after resaving the hard references will go away Refactor the way that FStringAssetReference and FAssetPtr are serialized, it now does the various fixups in FStringAssetReference::SerializePath, which is called from archivers Change it so the asset registry reads in a list of all scanned redirectors and adds them to GRedirectCollector, this means that saving a string asset reference will automatically fix it up to point to the redirector destination Change the default behavior of FAssetPtr serialize on ArchiveUObject to match what most of it's children want, and remove several special case hacks. It now serializes as asset reference when saving/loading, and as object for other cases Deprecate StringAssetReferenceLoaded/StringAssetReferenceSaving delegates, replace with PreSavePath and PostLoadPath on FStringAssetReference Make AssetLongPathname private on FStringAssetReference, it was deprecated in 4.9 Change 3421728 on 2017/05/03 by Phillip.Kavan Mirror CL 3408285 from //UE4/Release-4.16. #jira UE-44124 #rnx Change 3422370 on 2017/05/03 by Dan.Oconnor Mirror 3422359 Implement UBlueprintGeneratedClass::NeedsLoadForEditorGame to match UBlueprint, also tag a class's CDO as NeedsLoadForEditorGame. This prevents us from failing to load a UBlueprint's GeneratedClass when running the editor with -server. #jira UE-44659 Change 3423192 on 2017/05/04 by Ben.Zeigler CIS Fix Change 3423305 on 2017/05/04 by Ben.Zeigler Fix "Missing opening parenthesis" warnings for Vector and Rotator the same way they were fixed for Transform Change 3423358 on 2017/05/04 by Marc.Audy Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3422809 #rnx Change 3423766 on 2017/05/04 by Ben.Zeigler #jira UE-44680 Delete some corrupted redirectors that are no longer in use Change 3423804 on 2017/05/04 by Dan.Oconnor Honor SaveIntermediateCompilerResults when using compilation manager Change 3424010 on 2017/05/04 by Marc.Audy Validate that switch string cases are unique Change 3424011 on 2017/05/04 by Marc.Audy Re-fix switch node default pin not appearing as an exec output Remove unused boolean Change 3424071 on 2017/05/04 by Ben.Zeigler Delete FixupRedirects commandlet, replace with -FixupRedirects/FixupRedirectors option on ResavePackages. This new method is much faster than the old commandlet as it uses the asset registry vs loading all packages, fixing up all redirectors in Fortnite only took about an hour vs 12+ hours the old way Removed some hacky bits in Core that only existed to support FixupRedirects Change it so the AssetRegistry listens to DirectoryWatcher callbacks in commandlets now that commandlets use the asset registry properly. This won't do anything unless you tick directory watcher the way that ResavePackages does Change 3424313 on 2017/05/04 by Dan.Oconnor Address missing property flags on SkeletonGeneratedClass when using compilation manager #jira UE-44705 Change 3424325 on 2017/05/04 by Phillip.Kavan #jira UE-44222 - Move nativized UDS implementation details into its own .cpp file in order to avoid circular dependencies. Change summary: - Modified IKismetCompilerInterface::GenerateCppCodeForStruct() to include an output parameter for CPP source and modified FKismet2CompilerModule to match the updated API. - Modified IBlueprintCompilerCppBackend::GenerateCodeFromStruct() to include an output parameter for CPP source and modified FBlueprintCompilerCppBackendBase to match the updated API. - Modified FBlueprintNativeCodeGenUtils::GenerateCppCode() to adjust the call to GenerateCppCodeForStruct() to include CPP source output. - Modified FGatherConvertedClassDependencies::DependenciesForHeader() to switch UDS property dependencies to be forward declarations rather than includes (for default value init code). - Modified FEmitDefaultValueHelper::GenerateGetDefaultValue() to emit implementation details to the 'Body' container, and adjust the header content to be a declaration only. - Modified FIncludeHeaderHelper::EmitInner() to exclude a potentially-redundant line for the module's .h file, for the case when the caller has included the base filename in the 'AlreadyIncluded' set. - Modified FEmitterLocalContext::FindGloballyMappedObject() to limit the 'TryUsedAssetsList' path to UClass conversions only (since that requires a UDynamicClass target to work). - Modified FGatherConvertedClassDependencies::DependenciesForHeader() to only include BPGC fields if they are also being converted. Eliminates an issue with missing header files in generated code. Change 3424359 on 2017/05/04 by Ben.Zeigler Fix issue where StreamableManager would break when requesting an async load that failed the first time. Because our game supports downloading assets during gameplay it's not safe to assume it will never load again. Port of CL #3424159 Change 3424367 on 2017/05/04 by Ben.Zeigler Fix some asset manager warnings to not go off in invalid cases Change 3425270 on 2017/05/05 by Marc.Audy Pack booleans/enums in UEdGraphNode and FOptionalPinFromProperty #rnx Change 3425696 on 2017/05/05 by Ben.Zeigler #jira UE-44672 Fix it so select node option pins get populated with default values properly #jira UE-43927 Fix it so select node opion pin type is correctly maintained accross node recreation, as opposed to deriving from the attached pins #jira UE-44675 Fix it to correctly refresh select node when switching from bool to integer index Change 3425833 on 2017/05/05 by Ben.Zeigler #jira UE-31749 Fix it so Undo works properly when modifying a local variable #jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value Change 3425890 on 2017/05/05 by Marc.Audy Fix Copy/Paste of child actor components losing the template #jira UE-44566 Change 3425947 on 2017/05/05 by Ben.Zeigler This was meant to be part of last checkin Change 3425959 on 2017/05/05 by Ben.Zeigler #jira UE-44692 Fix it so only the sequentially last node can be removed from a Switch On Int, and for Switch On Name stop it from removing an exec pin if it's the only non-default one Change 3425979 on 2017/05/05 by Dan.Oconnor PVS fix Change 3425985 on 2017/05/05 by Phillip.Kavan Fix an uninitialized variable. #rnx Change 3426043 on 2017/05/05 by Ben.Zeigler #jira UE-35583 Correctly refresh array node UI when connecting pins that change it away from wildcard Change 3426174 on 2017/05/05 by Zak.Middleton #ue4 - Avoid call to virtual getSimulationFilterData() to only use it when needed in PreFilter if we actually have items in the IgnoreComponents list (which is rare). The sim filter data 'word2' stores the component ID. Change 3426621 on 2017/05/05 by Phillip.Kavan #jira UE-44708 - Fix an issue that re-introduced component data loss in a non-nativized child Blueprint class with a nativized parent Blueprint class. Change summary: - Removed an unnecessary additional check I had for the presence of "-NativizeAssets" switch on the command line in UBlueprint::BeginCacheForCookedPlatformData(). This check was failing because the usage was recently changed to include an optional value. It was not needed anyway so I just removed it. #rnx Change 3426906 on 2017/05/05 by Ben.Zeigler #jira UE-11189 Fix function/macro input default values to show as a pin customization instead of as a broken text box that doesn't work correctly for most types. This fixes enums and provide validation for other types Types that don't have a customization (most structs) will now show any more, they did not work before either #jira UE-21754 Hide function default values if pass by reference is set Fix it so changing input parameter will also reset default value, to avoid having the wrong type value set and to work the same as local variables Change 3426941 on 2017/05/05 by Dan.Oconnor Fix determinstic cooking of LoadAssetClass nodes in macros Change 3427021 on 2017/05/05 by Dan.Oconnor Build fix, make initialization order in source match artifact #rnx Change 3427135 on 2017/05/05 by Phillip.Kavan #jira UE-44702 - Restore code-based interface classes to Blueprint editor UI. Change summary: - Partially backed out CL# 3348513 to return to previous behavior for 4.16. The UI is no longer filtering on the __is_abstract() type trait for interface classes. - Modified FNativeClassHeaderGenerator::ExportClassFromSourceFileInner() to emit the _getUObject() declaration for native interface types as a default implementation that returns NULL rather than as a pure virtual declaration. #rnx Change 3427144 on 2017/05/06 by Marc.Audy Fix init order #rnx Change 3427146 on 2017/05/06 by Marc.Audy remove stray semicolon #rnx Change 3427242 on 2017/05/06 by Phillip.Kavan #jira UE-44744 - Fix a regression in which a UMG Widget Blueprint property not explicitly marked as a variable would cause Blueprint nativization to fail at package time. Change summary: - Modified FWidgetBlueprintCompiler::CreateClassVariablesFromBlueprint() to only add 'Category' metadata when we set the 'CPF_BlueprintVisible' flag on the UProperty, which in is now tied to whether or not the property has been explcitly marked as a variable. This avoids a UHT warning when compiling the nativized codegen that would cause packaging to fail. #rnx Change 3427720 on 2017/05/08 by Dan.Oconnor Backing out 3419202 #rnx Change 3427725 on 2017/05/08 by Dan.Oconnor SA fix #rnx Change 3427734 on 2017/05/08 by Dan.Oconnor More exhaustive GEditor null checks, to appease SA #rnx Change 3427882 on 2017/05/08 by Marc.Audy Properly order all booleans in intialization #rnx Change 3428049 on 2017/05/08 by Marc.Audy Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3427804 #rnx Change 3428523 on 2017/05/08 by Ben.Zeigler #jira UE-44781 Refresh function input UI when blueprint graph refreshes, needed as pins may have gone away Change 3428563 on 2017/05/08 by Ben.Zeigler #jira UE-44783 If setting a hard reference pin type from a string, load the referenced object. Change 3428595 on 2017/05/08 by Dan.Oconnor Avoid node reconstruction when we're compiling a blueprint with no linker (e.g., a duplicated blueprint) #jira UE-44777 Change 3428599 on 2017/05/08 by Ben.Zeigler #jira UE-44789 Fix string asset renamer to not mark IsPersistent becuase that crashes in lightmap code, change it so the path fixup doesn't require the persistent flag Change 3428609 on 2017/05/08 by Dan.Oconnor Improved fix for UE-44777 #jira UE-44777 #rnx Change 3429176 on 2017/05/08 by Phillip.Kavan #jira UE-44755 - Fix nativization build errors when packaging a game project that is not IWYU-compliant for a build target that disables PCH files. - Mirrored from //UE4/Release-4.16 (CL# 3429030). #rnx Change 3429198 on 2017/05/08 by Phillip.Kavan CIS fix. #rnx Change 3429583 on 2017/05/08 by Ben.Zeigler Fix SGraphPinClass to work properly after my changes to allow unloaded assets. For Class pins we need to store separate Runtime and Editor asset data objects, as one has _C and refers to the class, and the other doesn't and refers to the blueprint. The content browser wants the editor path, the pin defaults want the runtime path. Change default value widgets to look more like properties widgets by forcing them to act as highlighted and disabling black background Change 3429640 on 2017/05/08 by Marc.Audy Fix issues with select nodes in macros connected to wildcard pins. #jira UE-44799 #rnx Change 3429890 on 2017/05/08 by Ben.Zeigler Fix function/macro defaults to properly propagate when changed using the new edit UI Refactor some code out of the details customization into the k2 schema Disable defaults UI for object/class/interface hard references as it is disabled in KismetCompiler Change 3429947 on 2017/05/08 by Michael.Noland Core: Backing out CL# 3394352 (marking FDateTime and FTimespan nonexport member Tick with UPROPERTY()), which will re-break UE-39921 but fix UE-44418 There appears to be a more serious underlying issue with how the CDO is instanced which needs to be addressed #jira UE-44418 #reimplementing 3411681 from Release 4.16 Change 3429987 on 2017/05/08 by Ben.Zeigler #jira UE-44798 Do a better job of validating object paths saved as default values, due to an old bug with local variables some object paths are saved as struct exportext At load time clear invalid default value for local variables Add IsValidObjectPath to FPackageName that validates the passed in path would be valid to load with LoadObject Change 3430392 on 2017/05/09 by Marc.Audy Fix SA CIS error #rnx Change 3430747 on 2017/05/09 by Ben.Zeigler #jira UE-44836 Don't reconstruct node during callback for param value changing, this can happen during a reconstruction and recursive reconstruction is unsafe Don't call ModifyUserDefinedPinDefaultValue unless the default value has actually changed Change 3431027 on 2017/05/09 by Marc.Audy Fix BPRW mark up causing Ocean warnings #rnx Change 3431353 on 2017/05/09 by Marc.Audy Fix UHT error due to exposing FJsonObjectWrapper to blueprints #rnx [CL 3431398 by Marc Audy in Main branch]
2017-05-09 17:15:32 -04:00
if (!String.IsNullOrEmpty(Params.ClientCommandline))
{
TempCmdLine += Params.ClientCommandline + " ";
}
else
{
TempCmdLine += Params.MapToRun + " ";
}
if (Params.CookOnTheFly || Params.FileServer)
{
TempCmdLine += "-filehostip=";
bool FirstParam = true;
if (UnrealBuildTool.BuildHostPlatform.Current.Platform == UnrealTargetPlatform.Mac)
{
NetworkInterface[] Interfaces = NetworkInterface.GetAllNetworkInterfaces();
foreach (NetworkInterface adapter in Interfaces)
{
if (adapter.NetworkInterfaceType != NetworkInterfaceType.Loopback)
{
IPInterfaceProperties IP = adapter.GetIPProperties();
for (int Index = 0; Index < IP.UnicastAddresses.Count; ++Index)
{
if (IP.UnicastAddresses[Index].IsDnsEligible && IP.UnicastAddresses[Index].Address.AddressFamily == System.Net.Sockets.AddressFamily.InterNetwork)
{
if (!IsNullOrEmpty(Params.Port))
{
foreach (var Port in Params.Port)
{
if (!FirstParam)
{
TempCmdLine += "+";
}
FirstParam = false;
string[] PortProtocol = Port.Split(new char[] { ':' });
if (PortProtocol.Length > 1)
{
TempCmdLine += String.Format("{0}://{1}:{2}", PortProtocol[0], IP.UnicastAddresses[Index].Address.ToString(), PortProtocol[1]);
}
else
{
TempCmdLine += IP.UnicastAddresses[Index].Address.ToString();
TempCmdLine += ":";
TempCmdLine += Params.Port;
}
}
}
else
{
if (!FirstParam)
{
TempCmdLine += "+";
}
FirstParam = false;
// use default port
TempCmdLine += IP.UnicastAddresses[Index].Address.ToString();
}
}
}
}
}
}
else
{
NetworkInterface[] Interfaces = NetworkInterface.GetAllNetworkInterfaces();
foreach (NetworkInterface adapter in Interfaces)
{
if (adapter.OperationalStatus == OperationalStatus.Up)
{
IPInterfaceProperties IP = adapter.GetIPProperties();
for (int Index = 0; Index < IP.UnicastAddresses.Count; ++Index)
{
if (IP.UnicastAddresses[Index].IsDnsEligible)
{
if (!IsNullOrEmpty(Params.Port))
{
foreach (var Port in Params.Port)
{
if (!FirstParam)
{
TempCmdLine += "+";
}
FirstParam = false;
string[] PortProtocol = Port.Split(new char[] { ':' });
if (PortProtocol.Length > 1)
{
TempCmdLine += String.Format("{0}://{1}:{2}", PortProtocol[0], IP.UnicastAddresses[Index].Address.ToString(), PortProtocol[1]);
}
else
{
TempCmdLine += IP.UnicastAddresses[Index].Address.ToString();
TempCmdLine += ":";
TempCmdLine += Params.Port;
}
}
}
else
{
if (!FirstParam)
{
TempCmdLine += "+";
}
FirstParam = false;
// use default port
TempCmdLine += IP.UnicastAddresses[Index].Address.ToString();
}
}
}
}
}
}
const string LocalHost = "127.0.0.1";
if (!IsNullOrEmpty(Params.Port))
{
foreach (var Port in Params.Port)
{
if (!FirstParam)
{
TempCmdLine += "+";
}
FirstParam = false;
string[] PortProtocol = Port.Split(new char[] { ':' });
if (PortProtocol.Length > 1)
{
TempCmdLine += String.Format("{0}://{1}:{2}", PortProtocol[0], LocalHost, PortProtocol[1]);
}
else
{
TempCmdLine += LocalHost;
TempCmdLine += ":";
TempCmdLine += Params.Port;
}
}
}
else
{
if (!FirstParam)
{
TempCmdLine += "+";
}
FirstParam = false;
// use default port
TempCmdLine += LocalHost;
}
TempCmdLine += " ";
if (Params.CookOnTheFlyStreaming)
{
TempCmdLine += "-streaming ";
}
else if (SC.StageTargetPlatform.PlatformType != UnrealTargetPlatform.IOS)
{
// per josh, allowcaching is deprecated/doesn't make sense for iOS.
TempCmdLine += "-allowcaching ";
}
}
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565) #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 2976484 on 2016/05/12 by Jason.Bestimt #ROBOMERGE-AUTHOR: nick.atamas Added queueing to HUD Alerts so they don't clobber each other. Added input visualization so that keys show up in game. SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth #test PIE #ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483 #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 2976256 on 2016/05/12 by Zak.Middleton #ue4 - Fix for shipping build. #tests compiled Change 2976205 on 2016/05/12 by Zak.Middleton #ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns. #tests MP PIE PlayGo (Merging CL 2957866 using Framework->DevGeneral) Change 2976166 on 2016/05/12 by Daniel.Lamb Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time. #test Cook paragon Change 2976161 on 2016/05/12 by Zak.Middleton #ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects). #tests PIE MP w/ real-world networking Change 2976092 on 2016/05/12 by Mieszko.Zielinski Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4 #test golden path Change 2976001 on 2016/05/12 by Robert.Manuszewski Don't log to memory on dedicated servers #jira UE-30693 #test Cooked dedicated server and client Change 2975855 on 2016/05/12 by Lukasz.Furman fixed behavior tree serialization spawning duplicates of task services #tests BT editor Change 2975706 on 2016/05/12 by Daniel.Lamb Fixed redirect collector stats. #test Compile Change 2975636 on 2016/05/12 by Jason.Bestimt #ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge DUI @ CL 2975557 #RB:none #Tests:none [CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank #ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 2975592 on 2016/05/12 by Zak.Middleton #ue4 - Add stat for SetHitResultFromShapeAndFaceIndex(). #tests PIE Change 2975589 on 2016/05/12 by Zak.Middleton #ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds. #tests PIE Change 2975588 on 2016/05/12 by Zak.Middleton #ue4 - Minor tweak to avoid array read each loop iteration. #tests PIE Change 2975587 on 2016/05/12 by Zak.Middleton #ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed. #tests PIE Change 2975504 on 2016/05/12 by Daniel.Lamb Remove new stats system because it broke build. #test cook paragon Change 2975500 on 2016/05/12 by Daniel.Lamb Enable redirect timers so I can get stats from build machines. #test cook paragon. Change 2975367 on 2016/05/12 by Jason.Bestimt #ROBOMERGE-AUTHOR: david.nikdel #OGF #CatalogService #OSS #Localization - Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text - Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text - Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup) [CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt #RB: Sam.Zamani #TESTS: storefront w/ language change #ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 2975209 on 2016/05/12 by Simon.Tovey Fixed initialization order warning. #tests none Change 2975200 on 2016/05/12 by Simon.Tovey Translucency GPU time stats for automation. Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency. Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation. There are occasional spikes when the GPU is starved but overall the data out seems good. #tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data. Change 2974984 on 2016/05/11 by Mieszko.Zielinski Fixed a bug in graph-a-star heuristics' calculation #UE4 #test golden path Change 2974916 on 2016/05/11 by Jason.Bestimt #ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 26 @ CL 2974578 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 2974869 on 2016/05/11 by Ben.Marsh BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names. #tests none Change 2974673 on 2016/05/11 by Mieszko.Zielinski Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4 (change by ?ukasz.Furman) #test golden path Change 2974581 on 2016/05/11 by Jason.Bestimt #ROBOMERGE-AUTHOR: matt.kuhlenschmidt Merged CL 2974565 from Release-.26 -> Main: Fixed loc region not saving in shipping builds Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes #ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 2974444 on 2016/05/11 by Jason.Bestimt #ROBOMERGE-AUTHOR: richard.fawcett Reimplement support for specifying BuildPatchTool version used in chunking This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407. #tests none #ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 2974408 on 2016/05/11 by Jason.Bestimt #ROBOMERGE-AUTHOR: ben.marsh BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio. #tests none [CodeReviewed] Richard.Fawcett #ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 2974392 on 2016/05/11 by Daniel.Lamb Optimizing resolve string asset reference resolution. Added timing stats (disabled by default). #test Cook paragon. Change 2974349 on 2016/05/11 by Jason.Bestimt #ROBOMERGE-AUTHOR: richard.fawcett Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm. #tests none #ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 2974299 on 2016/05/11 by Jason.Bestimt #ROBOMERGE-AUTHOR: richard.fawcett Add support for chunking builds with the pre-release version of BuildPatchTool. #tests None. This code will be tested by creating a build on the build farm immediately after submission. #ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 2974277 on 2016/05/11 by Lina.Halper Fix up of retargeting when it skips replacing nested reference #tests: retargeting anim BP Change 2974210 on 2016/05/11 by Bart.Bressler Merging Oodle changes from Dev-Networking Change 2939167 on 2016/04/10 by John.Barrett Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size). Added new 'stat packet' stats group, for tracking reserved packet bits. Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state. Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable). Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes. Change 2939168 on 2016/04/10 by John.Barrett Updated Oodle to support new packet bit-termination code. Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases). Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage. Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code. Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API Added 'stat oodle' stats for tracking failed attempts at compressing packets. Change 2942964 on 2016/04/10 by Ryan.Gerleve Fix broken indentation/formatting Change 2958260 on 2016/04/27 by Bart.bRessler Add branch name and changelist to oodle packet capture filenames. Change 2964360 on 2016/05/03 by John.Barrett Updated Oodle to support using a dictionary and capturing packets at the same time. The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary. Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server): "Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets) "Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary. "Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline. "Oodle ResetStats" - resets the 'stat oodle' stat counters. The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed. Change 2964553 on 2016/05/03 by Bart.Bressler Add process ID to oodle capture filenames Change 2966247 on 2016/05/04 by John.Pollard Oodle 2.1.5 SDK Change 2968761 on 2016/05/06 by Bart.Bressler - Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything) - Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options - When looking for capture files, we will now recursively search subdirectories Change 2970529 on 2016/05/09 by Bart.Bressler Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection Change 2970874 on 2016/05/09 by Bart.Bressler - Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds - Link to version 215 of oodle Change 2971233 on 2016/05/09 by Bart.Bressler Update Oodle DLLs in Orion Change 2971362 on 2016/05/09 by Bart.Bressler Create script for building an oodle dictionary out of capture files in an arbitrary location Change 2972176 on 2016/05/10 by Bart.Bressler Update oodle references to version 215 in OodleHandlerComponent.Build.cs #tests used solo vs. ai to test oodle captures and using them Change 2974035 on 2016/05/11 by Simon.Tovey Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time. This is the time a PSC needs to be invisible for to have all it's collisions ignored. This is potentially the cause of a bug Tim et al are seeing. #tests Editor, Can be used to repro/fix the issue. Change 2973985 on 2016/05/11 by Lina.Halper Retargeting fix with editor saving issue #tests: retargeting Change 2973695 on 2016/05/11 by Jason.Bestimt #ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 26 @ CL 2973469 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 2973679 on 2016/05/11 by Graeme.Thornton UAT parameter -signedpak now no longer implies -pak #tests win64 cooked client. checked that pak generation works as expected through project launcher Change 2973588 on 2016/05/11 by Simon.Tovey OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint Particles can now receive collision events selectively based upon the phyisics material of the hit. Physics material is passed through the event and can be accessed in BPs. The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials. #tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here. Change 2973394 on 2016/05/11 by bruce.nesbit Fixed couple of shadow vars #tests compiled Change 2973335 on 2016/05/11 by Andrew.Grant Warning fix #tests compiled Change 2973308 on 2016/05/10 by Dmitry.Rekman Add "unplayable condition" reporting. - The server will report an unplayable condition by creating a local file (under Saved). - An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine. - Report file is to be deleted by an external script. #tests Compiled and ran Linux server, subjected it to various hitches. Change 2973235 on 2016/05/10 by Zak.Middleton #ue4 - Removed allocs after initial spawn from client saved move processing in character movement. #tests PIE multiplayer w/ Bots Change 2973157 on 2016/05/10 by Olaf.Piesche Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General Providing particle source and target for beam emitters #tests editor game PC Change 2972715 on 2016/05/10 by Jason.Bestimt #ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 26 @ CL 2972681 #RB: none #Tests:none #ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 2972678 on 2016/05/10 by Mieszko.Zielinski Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion #jira OR-18590 #test golden path Change 2972595 on 2016/05/10 by Lina.Halper Animation Retargeting fix for blendspaces #code review: Benn.Gallagher, Martin.Wilson #tests: retargeting anim BP Change 2972282 on 2016/05/10 by Daniel.Lamb Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook. #test cook paragon. Change 2972260 on 2016/05/10 by Laurent.Delayen Fixed crash in UCharacterMovementComponent::HasRootMotionSources(). #tests Chains pull not crashing anymore. Change 2972241 on 2016/05/10 by Frank.Fella UMG - Fixes for material animation copied from 4.12. #RB Matt K. #TESTS Struct materials can now be animated and animated materials are named nicely. Change 2971643 on 2016/05/09 by Dmitry.Rekman Add reporting of "zero load" frame times (OR-21035). - Added a thread that does nothing but sleeps and counts how often it missed the target FPS. - Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match. - Server only. #tests Compiled and ran Linux server on a compatible content, played few matches in a row. Change 2971544 on 2016/05/09 by Ben.Marsh EC: Use a full path to the telemetry file, to account for UAT switching directories. Change 2971532 on 2016/05/09 by Wes.Hunt Alter the cook stats hierarchical profile data to reflect the latest cook changes. #tests none Change 2971527 on 2016/05/09 by Ben.Marsh UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere. #tests none Change 2971461 on 2016/05/09 by David.Ratti Fix issues with mesh swap skins: -Front end intro animations not playing -In game spawn animations not playing -Some attachment weirdness (twinblast) #tests golden path Change 2971460 on 2016/05/09 by David.Ratti Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects #tests pie Change 2971364 on 2016/05/09 by Ben.Marsh EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC. #tests none Change 2971245 on 2016/05/09 by Dmitry.Rekman Add a "hitchhunter" log message to catch hitches while sleeping. #tests Compiled and ran Linux server on a compatible content. Change 2971196 on 2016/05/09 by jason.bestimt #ORION_MAIN - Merge 25.2 @ CL 2971139 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) #ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human. //Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened #CodeReview: david.nikdel, jason.bestimt Change 2971113 on 2016/05/09 by Dmitry.Rekman UdpMessaging: Fixed broken filters for when to enable UDP transport. - Redoing MaxP's change from Dev-Sequencer (CL 2963357). - Reduces number of threads spawned by the server. #tests Compiled Linux server, ran it on a compatible content. Change 2971040 on 2016/05/09 by jason.bestimt #ORION_MAIN - Merge 25.2 @ CL 2970990 #RB:none #Tests:none [CodeReviewed]: jon.lietz #ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) #ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human. #CodeReview: david.nikdel, jason.bestimt Change 2970555 on 2016/05/09 by Ben.Marsh BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log. #tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796 Change 2970507 on 2016/05/09 by David.Ratti Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability. Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component #tests pie Change 2970414 on 2016/05/09 by Graeme.Thornton Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const& #tests win64 client golden path Change 2969729 on 2016/05/06 by Mieszko.Zielinski Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4 #test golden path Change 2969675 on 2016/05/06 by Mieszko.Zielinski Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4 Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController Reverted hack-feature that supplied same functionality to EQS #test golden path Change 2969652 on 2016/05/06 by Michael.Noland HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs) - Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used #tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated Change 2969651 on 2016/05/06 by Michael.Noland Simplygon: Added time taken for simplygon mesh reduction to the log message #tests Simplified a LOD cluster and inspected the log Change 2969604 on 2016/05/06 by Uriel.Doyon Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT. #tests confirmed that default value has changed for old assets, while allowing override. Change 2969418 on 2016/05/06 by jason.bestimt #ROBOMERGE-AUTHOR: andrew.grant Fixed unconverted char string being passed as part of build info #tests ran & verified patch check passes #ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 2968817 on 2016/05/06 by jason.bestimt #ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 25.2 @ CL 2968572 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 2968383 on 2016/05/05 by Mieszko.Zielinski Added "default navigation filter" to AIController #UE4 Also, made EQS take advantage of that #test golden path Change 2968225 on 2016/05/05 by John.Pollard Add sanity checks and more info to help track down possible memory corruption #tests Networking, replication Change 2967903 on 2016/05/05 by jason.bestimt #ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 25.2 @ CL 2967827 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 2967899 on 2016/05/05 by Lina.Halper Merged change of 2956152 Remove invalid ensure - this didn't work if you have composite inside. #tests: none Change 2967870 on 2016/05/05 by Andrew.Grant Fix for OR-20731 (gamever crashes client) #tests gamever at console with -game Change 2967606 on 2016/05/05 by Wes.Hunt Tweaked output log message for HTTP module shutdown. #tests none Change 2967359 on 2016/05/05 by Wes.Hunt HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level. #tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete. Change 2966987 on 2016/05/05 by Dmitry.Rekman Fix editor build. #tests Compiled Win64 editor. Change 2966977 on 2016/05/05 by Dmitry.Rekman Added collecting and reporting periodic server frame time distribution. - Added generic FHistogram class and necessary analytic events. - Also added reporting hostname (OR-20842). #tests Built Linux server and ran a few matches on a compatible content. Change 2966920 on 2016/05/04 by jason.bestimt #ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 25.2 @ CL 2966805 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 2966778 on 2016/05/04 by Michael.Noland Rendering: Fixed shadow variable warning in GPUProfiler #tests Compiled and tested GPUProfiler command Change 2966769 on 2016/05/04 by Mieszko.Zielinski Fixed GraphAStar not resetting the output path before fillinf it with results #UE4 #test golden path Change 2966704 on 2016/05/04 by Michael.Noland Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material - This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture - It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName") #tests Used ProfileGPU a number of times Change 2966696 on 2016/05/04 by Michael.Noland Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes #tests Tested FPS charts in an uncooked and cooked build #jira OR-19713 Change 2966336 on 2016/05/04 by Lukasz.Furman fixed jungle minions unable to reach spawn locations when camp resets #jira OR-20700 #tests jungle camp POC Change 2965948 on 2016/05/04 by David.Ratti Changes to how passive abilities activate -Passives now continually try to activate by default rather than only on spawn Support for Status.Immortal -Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens. -Clamps health to 1. Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died. Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match #tests multi pie Change 2965870 on 2016/05/04 by Ryan.Gerleve Duplicated fix from Release-4.12 by marc.audy, CL 2960819: Owned components are once again referenced by their Owning actor for GC purposes #jira UE-29131 #tests golden path Change 2965798 on 2016/05/04 by jason.bestimt #ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 25.2 @ CL 2965789 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 2965220 on 2016/05/03 by Dmitry.Rekman Log instance id and system id (OR-20782). - These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file. #tests Compiled Linux server, ran on compatible client. Change 2964907 on 2016/05/03 by Jason.Bestimt #ORION_DG - Merge MAIN @ CL 2964858 #RB:none #Tests:none Change 2964530 on 2016/05/03 by Laurent.Delayen Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime. Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered). Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered) Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice. #tests Chains full feature system in PIE. Change 2964498 on 2016/05/03 by Frank.Fella DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags. #RB Andrew Rodham #TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer. Change 2964428 on 2016/05/03 by Benn.Gallagher Fixed stale clothing chunk/section references after container realloc in editor #tests editor Change 2964316 on 2016/05/03 by bruce.nesbit Banner revisions Banners now use components for various banner items Banners can now be enabled when killing a hero. #tests PIE+Game Change 2964187 on 2016/05/03 by Jon.Lietz Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent() - Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent - Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer #RB DanY #tests JIP shadow pad still works. Change 2964136 on 2016/05/03 by Laurent.Delayen Fix crash while switching tabs using Persona. #tests not crashing anymore. Change 2964083 on 2016/05/03 by jason.bestimt #ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 25.2 @ CL 2963929 [CodeReviewed]: andrew.grant HTTP Manager has larger stack size (1024) #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 2963771 on 2016/05/02 by Nick.Atamas Setting a desired size scale invalidates layout and volatility. #test none Change 2963555 on 2016/05/02 by Rob.Cannaday Fix PS4 Orion players being able to whisper chat with non-Orion players #jira OR-20626 #tests chat with launcher, fortnite Change 2963387 on 2016/05/02 by Laurent.Delayen Added GatherDebugData to FABRIK node. #tests showdebug animation works on Chains now. Change 2963331 on 2016/05/02 by Jon.Lietz fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1. #RB none #tests compiles Change 2963106 on 2016/05/02 by Rob.Cannaday Increase HTTP thread's stack size to 128k We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion) #tests log in Change 2963047 on 2016/05/02 by Jon.Lietz OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect. - adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate. #RB Dave.Ratti #test shadow pad, slow, stun and root still trigger and trigger for JIP players. Change 2962836 on 2016/05/02 by jason.bestimt #ROBOMERGE-AUTHOR: andrew.grant [NULL MERGE] Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files [CodeReviewed] Ben.Marsh #ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835 #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 2962570 on 2016/05/02 by Jason.Bestimt #ORION_MAIN - Merge MAIN @ CL 2962544 #RB:none #Tests:none Change 2962552 on 2016/05/02 by Ben.Marsh Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version. #tests none Change 2962506 on 2016/05/02 by Ben.Marsh Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task. #tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables. Change 2962228 on 2016/04/30 by Dmitry.Rekman Move processing HTTP requests into separate thread (OR-20723). - First iteration of the implementation, pending implementing feedback. - Adds a separate thread for CurlHttp where actual processing is performed. - Coded by RobC, post-processed by me. #tests Compiled Linux server and Windows client, ran them on compatible content, played a match. Change 2961899 on 2016/04/29 by Ben.Marsh BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries. #tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603) Change 2961587 on 2016/04/29 by Daniel.Lamb Redirector doesn't fire callback if it fails to be loaded. #test Cook orion. Change 2961458 on 2016/04/29 by Wes.Hunt Cooker Stats improvements. Also removed some old UBT telemetry that was not being used. #tests many cooks of orion Change 2961136 on 2016/04/29 by Daniel.Lamb Readded caching of platform data into postload of materials. #test Cook paragon. [CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
else if (Params.UsePak(SC.StageTargetPlatform))
{
if (Params.SignedPak)
{
TempCmdLine += "-signedpak ";
}
else
{
TempCmdLine += "-pak ";
}
}
else if (!Params.Stage)
{
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 3491552) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3421703 on 2017/05/03 by Ben.Marsh Surround invalid character message in quotes, so it's clear when a space is listed. #jira UE-44606 Change 3422644 on 2017/05/04 by Steve.Robb Ranged-for support for TChunkedArray. Change 3422754 on 2017/05/04 by Steve.Robb IAsyncReadFileHandle made non-copyable to prevent accidental wrong stat calculation. Change 3422758 on 2017/05/04 by Steve.Robb Misc readability/standards improvements in stats code. Change 3427955 on 2017/05/08 by Steve.Robb Version fix for IOS optimization pragmas, copied from equivalent Mac code. Change 3428017 on 2017/05/08 by Steve.Robb Unused property types removed. Change 3428641 on 2017/05/08 by Ben.Marsh UAT: Remove failed attempt to separate out BuildCookRun into separate commands, which have since rotted. Change 3430407 on 2017/05/09 by Ben.Marsh UBT: Define UE_4_X_OR_LATER macros for every UE4 version greater than 4.17 (eg. UE_4_17_OR_LATER, etc...). Change 3430682 on 2017/05/09 by Gil.Gribb UE4 - Added a fatal error for asking for very large alignments from MallocBinned2 and also return the true size of the memory block in GetAllocationSize(). Change 3430685 on 2017/05/09 by Gil.Gribb UE4 - Fixed a bug with the windows async IO stuff related to an unsafe pointer cast to LPDWORD from int64*. Change 3430756 on 2017/05/09 by Ben.Marsh UBT: Switch some receipt stuff to use FileReference/DirectoryReference objects rather than raw paths. Change 3431157 on 2017/05/09 by Ben.Marsh UBT: Store absolute paths when receipts are in memory; only insert pseudo-variables for $(EngineDir) and $(ProjectDir) when saved to disk. Change 3432334 on 2017/05/10 by Graeme.Thornton Include project name in the UBT error message which appears when a plugin is missing Change 3432481 on 2017/05/10 by Gil.Gribb UE4 - Fixed code to detect cycles in parallel tick sorting. Change 3432485 on 2017/05/10 by Steve.Robb Simplified templating around bitfield offset calculation. Change 3432608 on 2017/05/10 by Steve.Robb 'bool == byte' static_assert restored after being removed in CL# 3432485. Change 3432767 on 2017/05/10 by Ben.Marsh UBT: Fix exception when a missing plugin is encountered if the target does not have a project. Change 3433031 on 2017/05/10 by Ben.Marsh UAT: Add classes to allow safer manipulation of paths within the staging directory (StagedFileReference, StagedDirectoryReference), and convert staging code over to using those and their regular filesystem counterparts (FileReference/DirectoryReference). Lots of cleanup and refactoring of staging code. Change 3433049 on 2017/05/10 by Ben.Marsh Add more diagnostic information to asserts in TStaticIndirectArrayThreadSafeRead, to try and shed light on what sort of corrupted data is being passed in from the cooker. #jira UE-44336 Change 3433097 on 2017/05/10 by Steve.Robb Value initialization fix for MakeUnique<T[]>(). Change 3433972 on 2017/05/10 by Daniel.Lamb Stop unrealpak from crashing if generating a patch with more pak files then the original game. Change 3434124 on 2017/05/10 by Ben.Marsh UAT: Remove hacky bUseWebSocketNetDriver option. Change 3434824 on 2017/05/11 by Gil.Gribb UE4 - Printed an error instead of asserting when there are missing native classes. Change 3434916 on 2017/05/11 by Ben.Marsh UAT: Separate the list of files to be staged into a separate class. Change 3435427 on 2017/05/11 by Gil.Gribb UE4 - Fixed attempts to load compiled in packages, which produces warnings and is slow. Change 3436240 on 2017/05/11 by Ben.Marsh UAT: Add a command to search for restricted folders under a given base directory. Change 3438068 on 2017/05/12 by James.Fox Checking in Phase 1 of the Dev-Core test map for repro purposes. UE-44996 #rb none Change 3438855 on 2017/05/15 by Robert.Manuszewski When verbose cluster logging is enabled and new object is added to an already existing cluster, the cluster will be dumped to log. Change 3438929 on 2017/05/15 by Robert.Manuszewski Merging CL # 3436939 using Dev-Core_To_Dev-LoadTimes: Fix for potential crashes caused by levels staying in memory through material references. Change 3439021 on 2017/05/15 by Ben.Marsh PR #3566: fix non-ascii characters in help command HTML converted to "?" (Contributed by kayama-shift) Change 3439079 on 2017/05/15 by Ben.Marsh PR #2832: Implement missing MessageBox (Contributed by projectgheist) Change 3439258 on 2017/05/15 by Ben.Marsh Highlight lines containing the strings "Error:" or "Warning:" in the output log, so that diagnostics from child processes are highlighted appropriately. The build system already relies similar logic for scraping diagnostics from logs, so it should be safe and predictable to check for messages in this way. #jira UE-43673 Change 3439358 on 2017/05/15 by Ben.Marsh UBT: Fix Visual Studio solution referencing the incorrect platform for existing C# project ("Any CPU" instead of "AnyCPU"). Was causing prompt to save the solution the first time it is opened. Change 3439665 on 2017/05/15 by Ben.Marsh UAT: Remove DeployPakInternalLowerCaseFilenames(). No platforms require this to be true. Change 3440735 on 2017/05/16 by Robert.Manuszewski UBT compile fix after the last merge Change 3440889 on 2017/05/16 by Ben.Marsh EC: Fix regex for matching path to source files included in error messages from the Linux toolchain. Change 3442776 on 2017/05/17 by Steve.Robb Platform fix for FPaths::IsSamePath. Change 3445411 on 2017/05/17 by Ben.Marsh UBT: Fix typo in makefile diagnostic string. Change 3446070 on 2017/05/18 by Steve.Robb Fix to array sizes in generated UFunction code, which should now handle editor-only functions. Change 3446091 on 2017/05/18 by Steve.Robb Another array size fix for generated code. Change 3446605 on 2017/05/18 by Steve.Robb BuildConfiguration option for static analysis. Change 3448601 on 2017/05/19 by Richard.Fawcett Change FWindowsPlatformProcess::ApplicationSettingsDir() so that it no longer returns a path with a mixture of "\" and "/" characters, and only contains "/" characters. This makes it consistent with other related functions like FWindowsPlatformProcess::UserSettingsDir(). Change 3449026 on 2017/05/19 by Ben.Marsh Fix whitespace in template file. Change 3449697 on 2017/05/19 by James.Fox Checking in Phase 2 of Dev-Core test map for QAGame Also enabled Blueprint and Actor clustering by default in QAGame for more thorough GC testing. Change 3451352 on 2017/05/22 by Steve.Robb UFunction flags are now viewable in the debugger. Change 3451355 on 2017/05/22 by Steve.Robb ARRAY_COUNT fix for zero-sized arrays in Clang. Change 3451379 on 2017/05/22 by Steve.Robb C++14 operator delete overloads with size, for consistency. Change 3451398 on 2017/05/22 by Graeme.Thornton Add AES and RSA encryption keys to the list of config fields that get stripped from ini files when staging When creating a pak file, do a filtered copy of all ini files to a temp directory so that all confidential fields can be stripped. Equivalent behaviour to staging a loose file distribution Change 3451476 on 2017/05/22 by Ben.Marsh Compile shipping builds for WEX and Ocean, and post telemetry for the resulting executable size. Change 3451478 on 2017/05/22 by Graeme.Thornton PR #3197: Improved log message formatting (Contributed by projectgheist) Change 3451868 on 2017/05/22 by Steve.Robb Static log category moved out of header. ENUM_CLASS_FLAGS macro used instead of explicit operators. Change 3452319 on 2017/05/22 by Ben.Marsh UBT: Add a new "package" build product type, which can be used for APK files on Android and Stub files on iOS. Treating these files as executables is causing the measured executable size to be incorrect. Change 3452607 on 2017/05/22 by Ben.Marsh UBT: Filter out folders for other platforms when searching for headers to pass to UHT. Change 3453600 on 2017/05/23 by Graeme.Thornton PR #3226 - Updated some code comments to better describe the usage of the log category definition macros Change 3453616 on 2017/05/23 by Steve.Robb Error reported instead of a crash when there's a space between UCLASS or UINTERFACE and the open parenthesis. Change 3453714 on 2017/05/23 by Ben.Marsh Build: Add some Visual Studio 2017 test compiles to the build system. Change 3453795 on 2017/05/23 by Ben.Marsh UBT: Fix parsing of command line attributes that have a specific value assigned. We should never have an '=' suffix for such arguments. Change 3454606 on 2017/05/23 by Ben.Marsh UAT: Make sure log filenames are unique by creating a 0-byte file in its place. Change 3454709 on 2017/05/23 by Ben.Marsh UBT: Enable the /permissive- option for stricter standards compliance on Visual Studio 2017. Currently have /Zc:strictStrings disabled due to violations in Windows headers; all UE4 instances have been fixed up. Change 3456445 on 2017/05/24 by Graeme.Thornton MemoryProfiler2 - Add mprof filename into title bar after opening Change 3457129 on 2017/05/24 by Ben.Marsh Fix comment for FVector::Normalize(). #jira UE-45369 #rnx Change 3457228 on 2017/05/24 by Ben.Marsh Do not allow forward-declaring Rect structs. They are not public, and it conflicts with third party libraries. #rnx Change 3458357 on 2017/05/24 by Ben.Marsh Fix name resolution issue with /permissive- in VS2017. Change 3458812 on 2017/05/25 by Robert.Manuszewski PR #2407: Fix LoadLibrary error with Microsoft Group Policy CWDIllegalinDllSearch mode 1 or 2 (Contributed by bozaro) Change 3458894 on 2017/05/25 by Robert.Manuszewski PR #2096: Fix argument parsing in DiffAssets Comandlet (Contributed by cgrebeld) Change 3461205 on 2017/05/26 by Robert.Manuszewski Fixed parameter parsing so that arguments are not parsed if not preceeded by a whitespace (for example "-Log" was parsed in "TM-Log") #jira UE-33790 Change 3464714 on 2017/05/30 by Robert.Manuszewski Fixing potential deadlock caused by a race condition when using FMallocVerifyProxy with FMallocBinned Change 3465310 on 2017/05/30 by Ben.Marsh UBT: Enable bAdaptiveUnityDisablesOptimizations by default. Change 3465346 on 2017/05/30 by Ben.Marsh UBT: Require Update 3 to be installed when compiling using VS2015. Change 3465389 on 2017/05/30 by Ben.Marsh UBT: Fix support for RTTI when creating PCHs and shared PCHs. Change 3466084 on 2017/05/30 by Ben.Marsh Fix compiling plain C files, where it would incorrectly use a C++ PCH. Change 3467018 on 2017/05/31 by Robert.Manuszewski Async loading code will now properly handle cases when the requested package could not be created. Change 3467113 on 2017/05/31 by Ben.Marsh UGS: When opening a solution in Visual Studio, always start the process in the solution's directory. Change 3467508 on 2017/05/31 by Ben.Marsh Add a function to fix a long package name so it matches the case of a file on disk. Fixes deterministic cooking issues when on-disk case changes. Change 3467510 on 2017/05/31 by Ben.Marsh Fix deterministic cooking issue caused by LODGroup only being initialized in the CDO if it's serialized, causing inconsistent delta serialization for instances. Change 3467967 on 2017/05/31 by Ben.Marsh Always allow UAT to compile on non-Windows platforms, even if a debugger is present, since MSVC is the only one that will load C# PDBs. Change 3468544 on 2017/05/31 by Ben.Marsh UBT: Add a more helpful message when a module is being compiled with implicit PCHs, but a source file is not configured correctly. Change 3469241 on 2017/06/01 by Ben.Marsh UBT: Fix single-file compile causing a different UHT manifest to be generated, potentially excluding hidden dependencies. Change 3471709 on 2017/06/02 by Daniel.Lamb Rebuild lighting commandlet now rebuilds reflections also instead of trashing them. #test None Change 3471719 on 2017/06/02 by Daniel.Lamb Fixed crash in cooker while trying to cook for multiple platforms #test Launch on shootergame windows + ps4 #jira UE-45356 Change 3472261 on 2017/06/02 by Ben.Marsh CRP: Clear out MDD logs whenever we clear out CRP logs. Change 3473169 on 2017/06/05 by Graeme.Thornton PR #3622: Log category code cleanup (Contributed by projectgheist) Change 3473176 on 2017/06/05 by Graeme.Thornton PR #3622: Log category code cleanup (Contributed by projectgheist) (Part II) - Missed some files from my previous checkin Change 3473597 on 2017/06/05 by Ben.Marsh UnrealVS: Fix massive slowdown on startup caused by searching the directory tree under the solution for *.uproject files (including intermediate folders, etc...). Now reads *.uprojectdirs files and only checks the listed directories within. Measured it taking > 30s to run before, now takes < 0.1s. Change 3473722 on 2017/06/05 by Steve.Robb GitHub #3444: UE-42521: Added missing macro's for TMap and TSet PREPROCESSOR_COMMA_SEPARATED added as a better solution for the hacky comma separator solution in the PR. Change 3475073 on 2017/06/06 by Steve.Robb Fix for TPromise's move assignment operator return value. Change 3475331 on 2017/06/06 by Ben.Marsh UAT: Fix invalid paths being generated when stripping encryption settings from config files. * In cases where INI files were in a subfolder of the Config folder (eg. Config\Localization), it was not stripping the separating slash, resulting in files being written to the root directory of the current drive. * Paths under the config folder are not guaranteed to be unique. Change 3475453 on 2017/06/06 by Ben.Marsh UBT: Add an error if a plugin lists a non-plugin module as belonging to it. #jira UE-45178 Change 3475668 on 2017/06/06 by Ben.Marsh Add a message showing when we begin creating the asset registry, since it can take a long time. #jira UE-41675 Change 3475747 on 2017/06/06 by Steve.Robb Replicated from CL# 3332960: Force a gather on hot reload, so we don't use stale state from the makefile. #jira UE-42205 Change 3475897 on 2017/06/06 by Ben.Marsh PR #3655: Improved behavior for Automation.IsBuildMachine (Contributed by projectgheist) Change 3477432 on 2017/06/07 by Robert.Manuszewski Removed AsyncIOBandwidthLimit as it was no longer being used by anything. Change 3478582 on 2017/06/07 by Ben.Marsh UBT: Allow setting the UE_ENGINE_DIRECTORY macro for any monolithic builds, to fix being able to debug cooked foreign projects in the binary release. Change 3480035 on 2017/06/08 by Gil.Gribb UE4 - Fixed async loading from pak files < 64k. Change 3484348 on 2017/06/12 by Robert.Manuszewski Removed private_subobject macro which was a temporary measure to make all subobjects private without breaking game code. Change 3484863 on 2017/06/12 by Steve.Robb Fix for TSparseArray::operator= corrupting non-POD objects. InCopy.ArrayMax cached in a local instead of being read each time. Const-correctness fix for element copy construction. SrcData and DestData names flipped as they were the wrong way around. Source: https://udn.unrealengine.com/questions/374840/possible-bug-in-tsparsearray-assignment-operator.html Change 3485003 on 2017/06/12 by Ben.Marsh UGS: Add support for multiple tabs. Each tab can monitor changes in a separate workspace, and scheduled syncs will run for all open tabs. Change 3485063 on 2017/06/12 by Ben.Marsh UGS: Fix a null reference exception when right clicking on the notification icon during startup. Change 3485104 on 2017/06/12 by Ben.Marsh PR #2084: [UAT] Command-line parameter to override branch name (Contributed by nbjk667) Change 3485112 on 2017/06/12 by Steve.Robb TSetElement generic constructor protected from becoming a copy constructor. Redundant #include removed from AreTypesEqual.h. Source: https://udn.unrealengine.com/questions/374840/possible-bug-in-tsparsearray-assignment-operator.html Change 3485452 on 2017/06/12 by Ben.Marsh UnrealVS: Fix command line not being updated for C# projects. IVsBuildPropertyStorage.SetPropertyValue does not seem to update properties that are cached in memory. #jira UE-45716 Change 3486182 on 2017/06/12 by Ben.Marsh UGS: Include option to selet tab names in the options menu. Change 3486189 on 2017/06/12 by Ben.Marsh UGS: Fix browse button from context menu always opening a new tab. Change 3486636 on 2017/06/13 by Steve.Robb FStatMessagesArray iteration changed to use ranged-for instead of indexing. Change 3486688 on 2017/06/13 by Steve.Robb Fix for CDO pointer replacement in non-UObject properties during hot reload. #jira UE-38146 Change 3486704 on 2017/06/13 by Ben.Marsh UGS: Fix exception when closing the last open tab. Change 3486707 on 2017/06/13 by Ben.Marsh UGS: Fix exception on load if UGS was closed with no projects open. Change 3486715 on 2017/06/13 by Ben.Marsh UGS: Change tabs to show the project file by default. Change 3486718 on 2017/06/13 by Ben.Marsh UGS: Only allow one workspace to sync at a time. Change 3486880 on 2017/06/13 by Ben.Marsh UGS: Show the sync progress of each tab via the underline on the tab button. Change 3486912 on 2017/06/13 by Ben.Marsh UGS: Include the open project and recent project list as separate top-level menu items. Change 3486914 on 2017/06/13 by Ben.Marsh UGS: Update version to 1.101. Change 3487092 on 2017/06/13 by Ben.Marsh UGS: Fix crash on startup if log window is minimized. Change 3487099 on 2017/06/13 by Ben.Marsh UGS: Update version to 1.102 Change 3487198 on 2017/06/13 by Ben.Marsh Remove debug code. Change 3487285 on 2017/06/13 by Ben.Marsh Restore Remap() function that was accidentally removed in merge. Change 3487769 on 2017/06/13 by Ben.Marsh Disable the promoted flag when using the SyncProject command on Mac; doing so prevents UE4Game being compiled when packaging blueprint projects. #jira UE-45995 Change 3487915 on 2017/06/13 by Ben.Marsh UAT: Fix exception due to collection being modified while packaging for Linux. #jira UE-46013 Change 3487972 on 2017/06/13 by Ben.Marsh UAT: Always allow staged files to overwrite previously staged files. New iOS code relies on old behavior to overwrite engine icons and metadata with game copies. #jira UE-46014 Change 3487991 on 2017/06/13 by Ben.Marsh UAT: Ensure that the directory exists before trying to create a placeholder log filename. #jira UE-46015 Change 3489062 on 2017/06/14 by Robert.Manuszewski Removed FPackageFileSummary's AdditionalPackagesToCook as it was not used by anything. This should reduce the package header size considerably for levels with many streaming sublevels. #jira UE-45563 Change 3489063 on 2017/06/14 by Robert.Manuszewski Increasing the maximum package summary size to handle levels with multiple streaming sublevels. #jira UE-45563 Change 3491552 on 2017/06/15 by Ben.Marsh Handle failures to load *MeshReduction modules. [CL 3492074 by Ben Marsh in Main branch]
2017-06-15 12:43:54 -04:00
var SandboxPath = CombinePaths(SC.RuntimeProjectRootDir.FullName, "Saved", "Cooked", SC.CookPlatform);
if (!SC.StageTargetPlatform.LaunchViaUFE)
{
TempCmdLine += "-sandbox=" + CommandUtils.MakePathSafeToUseWithCommandLine(SandboxPath) + " ";
}
else
{
TempCmdLine += "-sandbox=\'" + SandboxPath + "\' ";
}
}
}
else
{
ClientApp = CombinePaths(CmdEnv.LocalRoot, "Engine/Binaries", PlatformName, "UE4Editor.exe");
if (!Params.EditorTest)
{
TempCmdLine += "-game " + Params.MapToRun + " ";
}
Copying //UE4/Dev-Rendering to //UE4/Dev-Main (Source: //UE4/Dev-Rendering @ 2967470) #lockdown nick.penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 2943963 on 2016/04/14 by Daniel.Wright Shader compile errors are unsuppressed Change 2943978 on 2016/04/14 by Gil.Gribb UE4 - First pass at async loading improvements....mostly disabled. Change 2944021 on 2016/04/14 by Martin.Mittring fixed HLSL compiler warning Change 2944031 on 2016/04/14 by Martin.Mittring fixed ensures, wrapped some members behind get accessor functions Change 2944086 on 2016/04/14 by Martin.Mittring cleanup: removed not needed code Change 2944177 on 2016/04/14 by Daniel.Wright Clamp on FarShadowCascadeCount, prevents crashing from huge values Change 2944182 on 2016/04/14 by Martin.Mittring removed not needed code Change 2944250 on 2016/04/14 by Rolando.Caloca DR - vk - Minor fixes Change 2944286 on 2016/04/14 by Daniel.Wright Added bRenderSceneTwoSided to planar reflections, which can be useful to limit leaking Added ShowOnlyActors and HiddenActors to SceneCaptureComponent for easy use without having to call BP functions Added bShowPreviewPlane to planar reflection actors The view state is recreated on planar reflection edit, which resets the Temporal AA history, allowing instant previewing of changes Change 2944288 on 2016/04/14 by Daniel.Wright Fixed refraction with a world space normal Change 2944291 on 2016/04/14 by Daniel.Wright Panner nodes have an optional speed input Change 2944346 on 2016/04/14 by Rolando.Caloca DR - Fix Vulkan shader platform on Android - Added more info on checks() Change 2945007 on 2016/04/15 by Gil.Gribb Merging //UE4/Dev-Main@2944911 to Dev-Rendering (//UE4/Dev-Rendering) Change 2945348 on 2016/04/15 by Daniel.Wright Fixed compile error Change 2945358 on 2016/04/15 by Olaf.Piesche #jira UE-29241 Sequential particle selection code was all sorts of weird. Rewrote and simplified. Change 2945941 on 2016/04/15 by Martin.Mittring added r.DisplayInternals to debug determinism for screen shot comparison Change 2945999 on 2016/04/15 by Martin.Mittring improved r.DisplayInternal output Change 2946023 on 2016/04/15 by Olaf.Piesche Adding missing call to Super::PostEditChangeProperty; UDN 286717 Change 2947155 on 2016/04/18 by Martin.Mittring started minor cleanup of transluceny rendering, use Sort key to support SeparateTransluceny, not fully hooked up #test:PC Change 2947207 on 2016/04/18 by Martin.Mittring fixed engine compiling in shipping/test #code_review:Uriel.Doyan Change 2947212 on 2016/04/18 by Uriel.Doyon Lightmap density viewmode now shows the wanted resolution when the lighting isn't build. #jira UE-29317 Change 2947374 on 2016/04/18 by Uriel.Doyon Fixed support for resolution scale for the PostProcessVisualizeComplexity #jira UE-29473 Change 2947903 on 2016/04/19 by Gil.Gribb Merging //UE4/Dev-Main@2947728 to Dev-Rendering (//UE4/Dev-Rendering) Change 2948019 on 2016/04/19 by Rolando.Caloca DR - Allow vk format as a target format for win Change 2948162 on 2016/04/19 by Simon.Tovey Fix for crash with Collision visualization. Change 2948419 on 2016/04/19 by Martin.Mittring fixed sort priority of translucent rendering (caused by recent checkin) Change 2948433 on 2016/04/19 by Martin.Mittring fixed memory handling of FRendererViewExtension Change 2948631 on 2016/04/19 by Martin.Mittring fixed compile error on Mac Change 2948832 on 2016/04/19 by Martin.Mittring fixed UE-29572 (should result in less CPU cost and it might even fix some rendeirng issues) Change 2949013 on 2016/04/19 by Martin.Mittring refactored Transluceny rendering, SepTrans and non SepTrans is now in the same container, sorted by that critera first and rendered with ranges. This makes it easier to extend it to more transluceny types e.g. after TemporalAA, after Tonemapping this is useful for MeshDecals #test:PC, parallel on and off Change 2949620 on 2016/04/20 by Martin.Mittring fixed compiler warning Change 2949639 on 2016/04/20 by Uriel.Doyon Fixed Material TexCoord Analysis not compiling when sampling textures for shader frequency other than PixelShader Change 2949721 on 2016/04/20 by Chris.Bunner Avoid creating additional inline code fragment casting matching uniform types. #jira UE-29089 Change 2949722 on 2016/04/20 by Chris.Bunner Prevent nullptr crash and added additional logging. #jira UE-28387 Change 2949913 on 2016/04/20 by Martin.Mittring marked ccommand as cheat Change 2950064 on 2016/04/20 by Martin.Mittring added MatineeTime to r.DisplayInternals to track down rendering determinsim issues, added dark background Change 2950065 on 2016/04/20 by Martin.Mittring nicer debug printout Change 2950201 on 2016/04/20 by Martin.Mittring fixed UE-29752 Console commands input with " = " should display an error message Change 2950531 on 2016/04/20 by Martin.Mittring fixed comment Change 2951737 on 2016/04/21 by HaarmPieter.Duiker Adds support forHDR displays using Dolby PQ output Change 2951869 on 2016/04/21 by Martin.Mittring polish r.DisplayInternal Change 2951950 on 2016/04/21 by HaarmPieter.Duiker Reordered variable definition to address build warning Change 2951996 on 2016/04/21 by Martin.Mittring fixed PerformanceCapture code, added AutomationTest "Rendering.RenderOutputValidation", changed directory order to run locally it currently requires "r.ScreenshotDelegate=0" #code_review:Ben.Salem, Michael.Noland Change 2952146 on 2016/04/21 by Olaf.Piesche make sure that ST PDI primitives render through regular translucency if ST is disabled; fixes light shapes in scene/reflection captures Change 2952230 on 2016/04/21 by Martin.Mittring * Fixed automated ScreenshotVerify difference because of not streamed in texture, wait for up to 5sec . * changed some GFrameNumberRenderThread usage to ViewFamily.FrameNumber #code_review:Daniel.Wright Change 2953173 on 2016/04/22 by Olaf.Piesche Adding UI for easilly browsing and switching in a folder full of stats dumps Change 2953213 on 2016/04/22 by Olaf.Piesche Renaming a stat to be more descriptive Change 2953393 on 2016/04/22 by Zabir.Hoque Get DX12 running again: - Port Shader Resource Table change - Line up VS outputs and ps inputs - Fix incorrectly defining a static global in a .h Change 2953453 on 2016/04/22 by Martin.Mittring polished r.DisplayInternal Change 2954618 on 2016/04/25 by Zabir.Hoque 2 Fixes: - GLSL does not understand "unsigned int", converted to "uint" - Refactored problematic prev buffer allocation code to be more inline with proper level of abstraction. Change 2955369 on 2016/04/25 by Rolando.Caloca DR - hlslcc - Fix some memory leaks in the frontend Change 2955403 on 2016/04/25 by Uriel.Doyon Fixed texture streaming build on OpenGL. Probably more likely to work on other platforms like Mac and Linux. Enabled debug view shaders on PCD3D_SM4 and OPENGL_SM4 #jira UE-28840 Change 2955419 on 2016/04/25 by Rolando.Caloca DR - hlslcc - Reenabled support for static global variables being not const Change 2955432 on 2016/04/25 by Zabir.Hoque Fix build break from not undef'ing LOCTEXT_NAMESPACE Change 2955459 on 2016/04/25 by Zabir.Hoque TEMP Fix: On server enqued render thread work is dropped. So on server release Reflection capture resouce immediately instead of trying to defer enque. Change 2956292 on 2016/04/26 by Zabir.Hoque Fix OpenGL shader compile break from CL: 2951737 (Adds support forHDR displays using Dolby PQ output). #CodeReview: Jack.Porter, Allan.Bentham Change 2956662 on 2016/04/26 by Chris.Bunner Temporary fix for new Tonemapper issues. #jira UE-29935 Change 2957614 on 2016/04/27 by Marcus.Wassmer Fix PS4 shader compiler errors. Change 2958468 on 2016/04/27 by Rolando.Caloca DR - Fix hlslcc validation issue - Show error on SCW if shader format not found when running with -directcompile #jira UE-29982 Change 2959105 on 2016/04/28 by Rolando.Caloca DR - Rebuilt hlslcc for Mac Change 2959891 on 2016/04/28 by Daniel.Wright Shader compiler does a recreate render state even during blocking compile - fixes saving a material giving different behavior from applying changes with global distance fields Change 2959895 on 2016/04/28 by Daniel.Wright Work around build machine string matching heuristics that will cause a cook to fail Change 2959902 on 2016/04/28 by Daniel.Wright Added LowerHemisphereSolidColor to sky lights Change 2959930 on 2016/04/28 by Daniel.Wright Added OpacitySourceMode to SubUVAnimation, which is useful with textures created for additive particles Change 2959933 on 2016/04/28 by Daniel.Wright Substring matching for console command suggestions * Only implemented in the editor, game uses UConsole which needs an entirely different implementation * Not sorting starting matches first, although that is desired Change 2959942 on 2016/04/28 by Daniel.Wright Gracefully handle when input string doesn't match search results Change 2960743 on 2016/04/29 by Gil.Gribb UE4 - UAT - Add map name to editortest command line. Change 2960940 on 2016/04/29 by Chris.Bunner Allow custom material nodes to be used with tessellation outputs. #jira UE-29586 Change 2960955 on 2016/04/29 by Gil.Gribb UE4 - Improved the CPU burden of loading in several places. Made substantial progress on the complete loading revamp (currently disabled). Change 2960961 on 2016/04/29 by Chris.Bunner Potential material translator Lerp node pre-computations/optimizations. #jira OR-20138 Change 2961087 on 2016/04/29 by Gil.Gribb Fixed compile error in preflight relating to load time test rig Change 2962565 on 2016/05/02 by Gil.Gribb Merging //UE4/Dev-Main@2962478 to Dev-Rendering (//UE4/Dev-Rendering) Change 2965058 on 2016/05/03 by Chris.Bunner Shader version bump. #lockdown Gil.Gribb #jira UE-30206 Change 2966554 on 2016/05/04 by Chris.Bunner Bumping shader version again, unintentionally polluted DDC previously. #lockdown Gil.Gribb #jira UE-30329 Change 2967183 on 2016/05/05 by Gil.Gribb UE4 - Fixed a bad hash on landscape grass components. Simple, safe. #lockdown nick.penwarden [CL 2967480 by Gil Gribb in Main branch]
2016-05-05 12:13:26 -04:00
else
{
TempCmdLine += Params.MapToRun + " ";
}
}
if (Params.LogWindow)
{
// Without NoStdOutRedirect '-log' doesn't log anything to the window
ClientRunFlags |= ERunOptions.NoStdOutRedirect;
TempCmdLine += "-log ";
}
else
{
TempCmdLine += "-stdout ";
}
if (Params.Unattended)
{
TempCmdLine += "-unattended ";
}
if (IsBuildMachine || Params.Unattended)
{
TempCmdLine += "-buildmachine ";
}
if (Params.CrashIndex > 0)
{
int RealIndex = Params.CrashIndex - 1;
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 3345728) #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 3315219 on 2017/02/21 by Steve.Robb Fix for FObjectAndNameAsStringProxyArchive when serializing a TWeakObjectPtr. Change 3315285 on 2017/02/21 by Steve.Robb Explicitly pass string builder into code generation functions. Change 3315341 on 2017/02/21 by Ben.Marsh UAT: Clean up some formatting in StreamCopyDescription output - remove #fyi lines, exclude merge commits, and remove some blank lines. Change 3315350 on 2017/02/21 by Ben.Marsh Fix shared resource files not being rebuilt if the version header changes. Change 3315823 on 2017/02/21 by Ben.Marsh UAT: Use a class derived from AutomationException to return information specific to commandlets failing, rather than putting it in the base class. Change 3315826 on 2017/02/21 by Ben.Marsh UAT: Move Distiller class from general use in UAT; FileFilter provides a much safer and fully featured implementation of the same concepts. Change 3315857 on 2017/02/21 by Ben.Marsh UBT: Remove the StripBaseDirectory() and MakeRerootedFilePath() utility functions from UBT. These operations can now be done more safely with FileReference objects. Change 3315942 on 2017/02/21 by Ben.Marsh UBT: Convert FileFilter to use FileReference and DirectoryReference arguments everywhere. Change 3316236 on 2017/02/22 by Maciej.Mroz #jira UE-42045 Nativization Fixed Warning: TEnumAsByte is not intended for use with enum Change 3316253 on 2017/02/22 by Robert.Manuszewski Fixes for the async log file writer hangs and crashes. - potential fix for the logging system hang when running out of disk space while flushing log - fix for unexpected concurrency assert when flushing the log buffer to disk Change 3316293 on 2017/02/22 by Steve.Robb GetTypeHash and lexicographical comparison operators (operator<() etc.) for TTuple. Change 3316342 on 2017/02/22 by Maciej.Mroz Nativization: Wrappers (stubs) required only by other wrappers are properly generated. #codereview: Mike.Beach Change 3316344 on 2017/02/22 by Maciej.Mroz Fixed crash in nativized Odin Async loading properly handles nativized structs. Change 3316359 on 2017/02/22 by Steve.Robb GitHub #3287 : Ignore #pragma in USTRUCTs #jira UE-42248 Change 3316389 on 2017/02/22 by Matthew.Griffin Switched Installed Engine Filters to multiline properties to make them more readable Added Oodle to list of excluded plugins #jira UE-42030 Change 3316392 on 2017/02/22 by Ben.Marsh UBT: Split out FileReference/DirectoryReference classes into their own file. Change 3316394 on 2017/02/22 by Ben.Marsh UBT: Move FileReference/DirectoryReference extension methods into the appropriate file. Change 3316411 on 2017/02/22 by Ben.Marsh UAT: Remove file functions that take multiple arguments. There's not really a compelling use case for these to exist over looping from the calling code. Change 3316446 on 2017/02/22 by Ben.Marsh UAT: Try disabling function name prefix to log output from UAT, to see if it improves readability. Function names are still included in the log file for debugging. Change 3316575 on 2017/02/22 by Ben.Marsh UAT: Remove unused functionality for dealing with labels, and output a more human readable list of P4 settings at startup. Change 3318481 on 2017/02/22 by Steve.Robb Use of FMath::IsPowerOfTwo in check. Static assert to ensure that an inline set allocator will have a hash size of a power of two. Change 3318496 on 2017/02/22 by Steve.Robb Fix for TSet visualizers. Change 3318919 on 2017/02/23 by Steve.Robb Fix for hot reloading UScriptStruct-derived objects in a module, where the CDOs of these objects haven't had PrepareCppStructOps() called on them. #jira UE-42178 Change 3318942 on 2017/02/23 by Steve.Robb Removal of a redundant insertion which can cause problems on reallocation of the map. Change 3319010 on 2017/02/23 by Ben.Marsh UBT: Fix exception when a file that was previously part of the working set is deleted. Change 3319134 on 2017/02/23 by Robert.Manuszewski Better fix for a deadlock when flushing log while it's already being flushed due to flush timer on the async log writer thread. Change 3319249 on 2017/02/23 by Matthew.Griffin Added a function to check if running with debug game libs instead of checking command line in multiple places Added -RunConfig parameter, which has equivalent result to -debug if value of parameter starts with 'debug' Added -RunConfig=$(Configuration) as a default commandline argument for Mac so that editor can use debug game libs Removed -Shipping argument from VCProject generation as it's not used anymore Change 3319253 on 2017/02/23 by Maciej.Mroz #jira UE-41846 New mechanism to gather modules necessary for Nativized Assets. The modules are listed based on included headers. Previously the dependencies was gathered only in FBlueprintNativeCodeGenManifest::GatherModuleDependencies. Change 3319591 on 2017/02/23 by Ben.Marsh Don't strip prefixes beginning with WARNING: or ERROR: using the Postp filter. Change 3320357 on 2017/02/23 by Steven.Hutton Slight changes to Add Crash method - Returning select fields instead of entity objects in queries for perf reasons. Change 3320361 on 2017/02/23 by Steven.Hutton Performance improvements subsequent to the recent database changes. Change 3320446 on 2017/02/23 by Steven.Hutton adding my temporary performance tracker class - reports to a private slack channel with add crash performance data. Change 3320479 on 2017/02/23 by Ben.Marsh Fix CIS errors. Change 3320576 on 2017/02/23 by Jin.Zhang Update CrashReporter to use AWS Change 3320742 on 2017/02/23 by Jin.Zhang Merging crash caching Change 3321119 on 2017/02/24 by Robert.Manuszewski DLL injection protection support for non-monolithic builds Change 3323308 on 2017/02/27 by Matthew.Griffin Moved compilation of SwarmInterface after its dependencies so that we will see a build failure immediately if they change version in future Change 3323423 on 2017/02/27 by Chad.Garyet Adding a script to check and warn about csproj targeted .net versions being mismatched #JIRA UE-39624 Change 3323442 on 2017/02/27 by Ben.Marsh UBT: Output an error if an engine module references a game module. Change 3323743 on 2017/02/27 by Ben.Marsh PR #3303: Resolved PVS scan issues (Contributed by projectgheist) Change 3323748 on 2017/02/27 by Ben.Marsh Convert whitespace to tabs. Change 3324851 on 2017/02/28 by Chris.Wood Add Odin symbol locations to engine config for MDD on CR server. NotForLicensees Change 3324979 on 2017/02/28 by Gil.Gribb Fixed bad merge of priority change in the EDL. Change 3326889 on 2017/03/01 by Steven.Hutton Update to buggs controller to generate faster queries. Change 3326910 on 2017/03/01 by Robert.Manuszewski Removing legacy #if from PackageFileSummary. Change 3327118 on 2017/03/01 by Gil.Gribb UE4 - Fixed race that resulted in a memory leak when reading compressed paks. Change 3327633 on 2017/03/01 by Gil.Gribb UE4 - Added a cvar to control the pak precacher thottle. Change 3327674 on 2017/03/01 by Steve.Robb Unified boilerplate between all generated code files. Change 3328544 on 2017/03/01 by Chris.Wood CrashReportProcess.config update (CRP v1.2.17) Tweaks to a few values. Update website URL to explicitly point to old, non-cloud site on devweb-02. Change 3328714 on 2017/03/01 by Chris.Wood Correct CRP config regression. Point website at new cloud site. Still v1.2.17 Change 3329192 on 2017/03/02 by Matthew.Griffin Added Shared Build Id file to the list of Precompiled Build Dependencies in a target receipt so that it's brought into an installed build Change 3329285 on 2017/03/02 by Ben.Marsh UGS: Allow a project to specify a filters for the streams that should be displayed for fast-switching to. The QuickSelectStreamList seting in the [Options] section of the project settings references a depot path containing a list of strings used to filter the stream list. An option is shown to switch back to showing all available streams, if desired. Change 3330636 on 2017/03/02 by Ben.Marsh UBT: Bump version number of C++ include cache to force it to be rebuilt with additional include information for the default RC files. Change 3331262 on 2017/03/03 by Robert.Manuszewski Merging Dev-LoadTimes to Dev-Core (Garbage Collection performance improvements) - Improved GC multithreading - Improved BeginDestroy performance - Introduced ULevelActorCluster for StaticMeshActor and ReflectionCapture actor clustering (can be toggled through project settings or console command gc.ActorClusterEnabled) - A few improvements to AddReferencedObjects functions - Misc improvements to GC code - Garbage Collector now properly handles clusters which had their objects marked as pending kill - Blueprints can now create clusters too (can be toggled through project settings or console command gc.BlueprintClusteringEnabled, defaults to disabled) Change 3331285 on 2017/03/03 by Robert.Manuszewski A few fixes for the previous check-in. Change 3332001 on 2017/03/03 by Ben.Marsh UBT: Add support for generating a UDN file containing the valid settings for BuildConfiguration.xml. Pass -configdoc=<filename> on the command line to generate such a file. Change 3332022 on 2017/03/03 by Ben.Marsh Update documentation for where to find the BuildConfiguration settings. Change 3332031 on 2017/03/03 by Ben.Marsh Remove documentation for Windows XP support; it has been removed in the 4.16 release. Change 3332256 on 2017/03/03 by Ben.Marsh UBT: Add support for generating a UDN page containing module and target settings. Change 3332458 on 2017/03/03 by Ben.Marsh UBT: Improvements to generated documentation. Change 3332459 on 2017/03/03 by Ben.Marsh Add generated documentation for .target.cs files, .build.cs files, and BuildConfiguration.xml files. Change 3332460 on 2017/03/03 by Ben.Marsh UBT: Make LinkTypePrivate actually private, so it doesn't show up in the docs. Change 3332899 on 2017/03/06 by Robert.Manuszewski Making sure actor clustering is not used in the editor (fix for actors being deleted when GC runs in the editor) #jira UE-42548 Change 3332955 on 2017/03/06 by Maciej.Mroz Nativization distinguishes client and server platform: - Separated lists on additional assets, additional modules, excluded assets, excluded modules, excluded paths (in config) - Context (compilation options, nativization options and platform) is deliveren to BPCOmpilerCppBackend in FCompilerNativizationOptions struct. - Wrappers (for unconverted BPs) are created only when they are directly called. - Fortnite dedicated server can be nativized Change 3332990 on 2017/03/06 by Ben.Marsh UBT: Add more comprehensive wrapper methods for System.IO.File and System.IO.Directory to FileReference and DirectoryReference. Change 3333032 on 2017/03/06 by Ben.Marsh Documentation for build tools Change 3333037 on 2017/03/06 by Ben.Marsh Add a build step to extract UAT and UBT documentation from XML comments. Change 3333089 on 2017/03/06 by Ben.Marsh UAT: Re-enable logging the calling function to the console in UAT. Needs a pass for readability first. Change 3333651 on 2017/03/06 by Gil.Gribb UE4 - Fix a werid recursive situation where StaticLoadObject could return an object that has not finished loading. Also produces a fatal error if this sometimes happens. EDL only. Change 3335236 on 2017/03/07 by Ben.Marsh UGS: Set the sync changelist separately to the compatibility changelist. Change 3335261 on 2017/03/07 by Gil.Gribb UE4 - Fixed batched render fences when BeginDestroy calls FlushRenderingCommands. Change 3335740 on 2017/03/07 by Gil.Gribb maybe fix static analysis warning Change 3335945 on 2017/03/07 by Steve.Robb Move FFindInstancedReferenceSubobjectHelper code out of header. Add map/set property support to allow instanced members of these container types to be handled during CPFUO. https://udn.unrealengine.com/questions/349232/tmap-with-instanced-object-as-value-gets-cleared-o.html Change 3336693 on 2017/03/07 by Ben.Marsh UBT: Use shared PCHs for game plugins by default, to reduce time spent generating individual PCHs. Change 3336694 on 2017/03/07 by Steve.Robb Static assert added to TMap to prevent the use of keys which don't implement a GetTypeHash. Fixes to types which relied on implicit conversions when calling GetTypeHash. Workaround in SAssetView.h and PropertyEditorModule.h for an apparent VC bug where the compiler wrongly instantiates TPointerIsConvertibleFromTo for certain forward-declared types, causing future TSharedPtr conversions to fail. #jira UE-42441 Change 3336698 on 2017/03/07 by Steve.Robb Hardcoded endpoint handling replaced with a generic string. Obsolete .proto and .java code generation removed. Change 3336811 on 2017/03/07 by Wes.Hunt Add a game blacklist to the crash report processor. Fixed a syntax error in Config.cs, added a XML comment to shut up a warning. Change 3336973 on 2017/03/08 by Steve.Robb Fix for missing GetTypeHash in a plugin. Change 3336996 on 2017/03/08 by Steve.Robb Significant refactor of code generation, to try and make data flow more apparent. Change 3337571 on 2017/03/08 by Steve.Robb CIS fixes for missing GetTypeHash functions. Non-unity fix. Change 3337588 on 2017/03/08 by Gil.Gribb UE4 - Fixed obscure check with flushing rhi resources. Change 3337620 on 2017/03/08 by Steve.Robb WITH_HOT_RELOAD_CTORS macros removed. UseVTableConstructors config option removed. Change 3339369 on 2017/03/09 by Steve.Robb GetTypeHash overload for nn::account::Uid. Change 3339464 on 2017/03/09 by Daniel.Lamb Fixed assert in 4.15 to do with trying to gather dependency info from invalid packages. #jira UE-42583 #test Editor + Cook + Run shootergame Change 3339465 on 2017/03/09 by Maciej.Mroz Fixed serialization issue, after UserDefinedEnum was used in EnumProperty. Change 3339469 on 2017/03/09 by Maciej.Mroz Fixed Nativization problem, when default value is passed as non-const reference. Change 3340178 on 2017/03/09 by Daniel.Lamb Added support for in memory only packages. The Cooker ignores these and added core functions to recognize these packages. Other systems will need to add support where nessisary. Change 3341002 on 2017/03/10 by Maciej.Mroz Nativization: Fixed FFindHeadersToInclude. Headers necessary for owners of subobjects are properly included. Change 3341076 on 2017/03/10 by Steve.Robb Fix for FBakedTextureSourceInfo move semantics. #jira UE-42658 Change 3341160 on 2017/03/10 by Gil.Gribb UE4 - Fix hazard with SetMaterialUsage from a thread. Change 3341409 on 2017/03/10 by Steve.Robb Reduction of the generated code size for StaticRegisterNatives functions. Change 3341523 on 2017/03/10 by Steve.Robb Code generation simplified. Change 3341800 on 2017/03/10 by Ben.Marsh UnrealVS: Fix UnrealVS compatibility with RTM version of Visual Studio 2017. 2017 toolchain for extensions is no longer able to build <= 2015 extensions due to validation of the VSIX manifest, so create a separate solution for it. Change 3342034 on 2017/03/10 by Ben.Marsh Fix compiler setting not being loaded correctly into the Windows target settings dialog. #jira UE-42746 Change 3342041 on 2017/03/10 by Ben.Marsh Fix -ErrorOnEngineContentUse not being set in the cooker options correctly. Change 3342094 on 2017/03/10 by Steve.Robb Fix to deteministic name order during code generation. Change 3342251 on 2017/03/10 by Daniel.Lamb Integrate fix for resave lightmaps commandlet when upgrading from no mapbuilddatapackages to mapbuilddatapackages. #thanks Tim.Hagberg #test None Change 3342961 on 2017/03/13 by Robert.Manuszewski Fixing memory leak when playing while running -nullrhi on the commandline in cooked games caused by shader resources not being destroyed. #jira FORT-38977 Change 3343022 on 2017/03/13 by Steve.Robb GetTypeHash fixes for FUniqueNetIdLive. #jira UE-42788 Change 3343448 on 2017/03/13 by Steve.Robb Compiled-in defer object order fixed. Debuggability of the deferred registration map improved. #jira UE-42828 [CL 3345747 by Ben Marsh in Main branch]
2017-03-14 15:48:33 -04:00
if (RealIndex >= CrashCommands.Count())
{
throw new AutomationException("CrashIndex {0} is out of range...max={1}", Params.CrashIndex, CrashCommands.Count());
}
TempCmdLine += String.Format("-execcmds=\"debug {0}\" ", CrashCommands[RealIndex]);
}
else if (Params.RunAutomationTest != "")
{
TempCmdLine += "-execcmds=\"automation list;runtests " + Params.RunAutomationTest + "\" ";
}
else if (Params.RunAutomationTests)
{
TempCmdLine += "-execcmds=\"automation list;runall\" ";
}
if (SC.StageTargetPlatform.UseAbsLog)
{
TempCmdLine += "-abslog=" + CommandUtils.MakePathSafeToUseWithCommandLine(ClientLogFile) + " ";
}
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3431384) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3252833 on 2017/01/10 by Ori.Cohen Refactor constraint so that it can be used for external solvers. (Copying //Tasks/UE4/Dev-ImmediateModePhysics to Dev-Framework (//UE4/Dev-Framework)) Change 3256288 on 2017/01/12 by Ori.Cohen Undo constraint refactor as we found a way around it and it made the code much harder to read/debug Change 3373195 on 2017/03/30 by Mike.Beach For nativization, changing it so we key off of the target platform-info struct instead of the platform (in preparation for defining the nativized plugin's platform whitelist). Change 3381178 on 2017/04/05 by Dan.Oconnor Make sure we don't inherit the NATIVE func flag when generating skeleton functions, also make sure all bojects outer'd to the skeleton class are marked transient #jira UE-43616 Change 3381532 on 2017/04/05 by Marc.Audy (4.16) Fix various cases where built lighting on child actors could be lost when loading a level #jira UE-43553 Change 3381586 on 2017/04/05 by Mike.Beach Now generating TArrayCaster conversions for nativized UClass arrays that need it (to handle different TSubclassOf arrays). #jira UE-42676, UE-43257 Change 3381682 on 2017/04/05 by mason.seay Some more changes to test map Change 3381844 on 2017/04/05 by Dan.Oconnor Match existing logic for CPF_ReturnParm/CPF_OutParm. Fixes compilation error in BP_TurbineBlades when using compilation manager Change 3382054 on 2017/04/05 by Zak.Middleton #ue4 - Optimize CharacterMovementComponent::GetPredictionData_Client_Character() and GetPredictionData_Server_Character() to remove virtual calls. #jira UE-30998 Change 3382703 on 2017/04/06 by Lukasz.Furman fixed missing links between navmesh polys when there are more than 4 neighbor connections #jira UE-43524 Change 3383357 on 2017/04/06 by Marc.Audy (4.16) Make SetHiddenInGame propagate consistently with SetVisibility #jira UE-43709 Change 3383359 on 2017/04/06 by Dan.Oconnor Fix last errant SKEL reference when cooking Odin Change 3383591 on 2017/04/06 by Mike.Beach Prevent users from setting object variables as 'config' properties (disallowed by UHT). This prevents some errors that could happen later when users nativize the Blueprint. #jira UE-42085 Change 3384762 on 2017/04/07 by Zak.Middleton #ue4 - Fix SpringArmComponent not restoring relative transform when bUsePawnControlRotation is turned off. Fixes the editor interaction ignoring transform of the component in the viewport after bUsePawnControlRotation is toggled on then off, since by then the world transform had been overwritten (from tick in editor) and nothing would drive transform changes from the editable value. Toggling bUsePawnControlRotation off at runtime now restores the rotation to the initial relative rotation, not stomping it with the current pawn rotation, allowing toggling between the editable/desired base rotation and the control rotation. #jira UE-24850 Change 3384948 on 2017/04/07 by Dan.Oconnor Prevent GForceDisableBlueprintCompileOnLoad from causing all sorts of badness when dependencies are loaded as part of a Diff operation. Instead of setting a global flag we flag the package as LOAD_DisableCompileOnLoad Change 3385267 on 2017/04/07 by Michael.Noland Graph Editing: Pushed some node diffing code down from UAIGraphNode into UEdGraphNode so nodes with details panel properties will diff correctly (e.g., various animation nodes and BP switch nodes) #jira UE-21724 Change 3385473 on 2017/04/07 by Phillip.Kavan #jira UE-43067 - Fix broken pin wires after an Expand Node operation, along with some misc. cleanup. Change summary: - Fixed to use correct string for "Expand Node" transaction name. - Modified FBlueprintEditor::OnExpandNodes() to consolidate some redundant code. - Fixed to generate a unique node GUID for cases where the source graph is not removed after expansion. Change 3385583 on 2017/04/07 by Dan.Oconnor Handle CreatePropertyOnScope nullptr return values (happens for structs missing a struct property) #jira UE-43746 Change 3386581 on 2017/04/10 by Michael.Noland Blueprints: Further hardening FBlueprintActionInfo::GetOwnerClass() #jira UE-43824 Change 3386615 on 2017/04/10 by Marc.Audy Instanced properties can now properly be set on a per-instance basis in blueprint added components. #jira UE-42066 Change 3387000 on 2017/04/10 by Marc.Audy Fix includes for CIS Change 3387229 on 2017/04/10 by mason.seay More changes to TM-Gameplay Added Save Game test (with blueprint) Tick Interval test (with blueprint) BP logic cleanup Level organization Change 3388437 on 2017/04/11 by Mike.Beach Adding support for map/set literals in the backend (so you can use set nodes for structs containing sets/maps, without having to connect a RHS input - resets to struct defaults). #jira UE-42617 Change 3388532 on 2017/04/11 by mason.seay Submitting latest changes for crash repro Change 3389026 on 2017/04/11 by Ben.Zeigler Performance and bug fixes for incremetal cooking with asset registry, duplicate of several changes made on //Fortnite/Main Fix it so AssetRegistry.ScanPathsAndFilesSynchronous won't scan subdirectories inside already scanned directories, this cuts down on the number of cache files Fix 2 second stall when shutting down AssetSourceFilenameCache if it had never been previously created Change 3389163 on 2017/04/11 by Ben.Zeigler #jira UE-42922 Fix it so connecting function input node output pins does not clear default value, we only want to clear the value when connecting an input pin. Properly testing this fix depends on UE-43883 Change 3389205 on 2017/04/11 by Marc.Audy Protect against a handful of GEditor usages that can now be hit in standalone Change 3389220 on 2017/04/11 by Marc.Audy Don't borrow ClassWithin to masquerade as ParentClass during compilation and instead just set the super struct immediately Change 3389222 on 2017/04/11 by Michael.Noland Framework: Adding a cvar (t.TickComponentLatentActionsWithTheComponent) to allow users to revert to the old behavior on when component latent actions tick - Non-zero values behave the same way as actors do, ticking pending latent action when the component ticks, instead of later on in the frame (default behavior in 4.16 and beyond) - Prior to 4.16, components behaved as if the value were 0, which meant their latent actions behaved differently to actors This CVar will be removed in a future version, defaulting to on #jira UE-43661 Change 3389276 on 2017/04/11 by Marc.Audy Spelling fix and NULL to nullptr Change 3389303 on 2017/04/11 by Mieszko.Zielinski Made sure AIController::Posses doesn't get called when compiling Pawn BP #UE4 #jira UE-43873 Change 3390215 on 2017/04/12 by mason.seay Removed some tests, will need further review Change 3390638 on 2017/04/12 by Mike.Beach Generalizing the omission of the CoerceProperty (in EmitTerm) - previously we were only omitting properties for our custom array lib. For wildcards, a coerce property should not be used as its type will not match. NOTE: There is a slight behavior change in UEdGraphSchema_K2::ConvertPropertyToPinType(), as it will return 'wildcard' for params marked as 'ArrayTypeDependentParams' (previously would have returned 'int'). #jira UE-42747 Change 3390774 on 2017/04/12 by Ben.Zeigler #jira UE-43911 Fix several issues with saving a runtime asset registry containing redirectors that caused crashes in cook on the fly. Don't resolve redirectors on incoming links because it will make a circular link, and fix an issue where chained redirectors would break the for loop iteration and return a bad dependency Fix it so the asset registry written out at the beginning of CookOnTheFly uses the registry generator, otherwise it will include all of the stripped editor only tags Change 3390778 on 2017/04/12 by Ben.Zeigler Fix UCookOnTheFlyServer::CollectFilesToCook to check for initial unsolicited packages up front. This is required in iterative mode because it may skip cooking all explicit packages and thus miss a new startup loaded package Change 3390782 on 2017/04/12 by Ben.Zeigler Change RunProjectCommand to not imply -nomcp, and allow reading -clientcmdline to override setting the map parameter to 127.0.0.1 by default Fix RunProjectCommand to remove ios-specific checks to not pass weird platform parameters, and instead never pass them Fix PS4Platform to pass along command line when calling build cook run, args needs to be the last parameter so explicitly set -target= Change 3390859 on 2017/04/12 by Mike.Beach T3D class fields now export with the class's fully qualified path name (to avoid abiguity). Since we can have multiple classes with the same name (Blueprints in different folders), we have to use the class's fully qualified object path. #jira UE-28048 Change 3390914 on 2017/04/12 by Lukasz.Furman fixed missing navlink component's transform in exported navigation data #jira UE-43688 Change 3391122 on 2017/04/12 by Ben.Zeigler Add new PreloadPrimaryAssets call to AssetManager that stream the desired assets without modifying the official load/unload state. This is useful if you want to preload things in case the might be used in the future, and it also supports recursion Fix crash calling GetAssetDataForPath with null path Change 3391494 on 2017/04/12 by Dan.Oconnor Fix bad references in deep object (widget) hierarchies #jira UE-43802 Change 3391529 on 2017/04/12 by Dan.Oconnor Fix log spam, accidently submitted #rnx Change 3391756 on 2017/04/12 by Dan.Oconnor LinkExternalDependencies needs to be performed before we RefreshVariables #jira UE-43843 Change 3392542 on 2017/04/13 by Marc.Audy Ensure that initialized actors get cleaned up when removed from world even if that world hasn't begun play. #jira UE-43879 Change 3392746 on 2017/04/13 by Marc.Audy (4.16) When duplicating a blueprint node, correctly make the new node a sibling of the duplicated node, not a child of it (unless duplicating the root component). Also resets scale of a duplicated root component to 1 to avoid a squaring of the scale for that component. #jira UE-40218 #jira UE-42086 Change 3393253 on 2017/04/13 by Dan.Oconnor Make sure calculated meta data is correctly set on functions generated by the compilation manager (SKEL_ class functions) #jira UE-43883 Change 3393509 on 2017/04/13 by Mike.Beach Removing hack'ish ResetLoaders() call that was causing undesired side-effects (resetting of a loaded package that other objects were relying on). This was originally intended to release file handles so separate editor processes could make updates and save the file (from CL 1712376). Using ResetLoaders() for this is bad though, as it has too many side effects. Instead we have to wait for GC to run. This also makes sure that GC should run as intended as the CookOnTheFly sever is idling. #jira UE-37284 Change 3394350 on 2017/04/14 by Michael.Noland Core: Making FDateTime and FTimespan actually reflected, so they get duplicated properly in CopyPropertiesForUnrelatedObjects, etc... #jira UE-39921 Change 3395985 on 2017/04/17 by Phillip.Kavan #jira UE-38280 - Fix invalid custom type selections on member fields in the User-Defined Structure Editor after a reload. Change summary: - Ensure that the 'SubCategoryObject' member in a UDS variable descriptor has been loaded when converting to an FEdGraphPinType. Change 3396152 on 2017/04/17 by Marc.Audy TickableGameObjects that have IsTickableInEditor false should not tick in the editor #jira UE-40421 Change 3396279 on 2017/04/17 by Phillip.Kavan #jira UE-43968 - Fix failed validation of bitmask enum types when serializing bitmask literal nodes. Change 3396299 on 2017/04/17 by Dan.Oconnor Fix resintancing issues exposed by running TM-Gameplay with -game. We cannot reinstance actors in levels on load because the scene is not created. #jira UE-43859 Change 3396712 on 2017/04/17 by Marc.Audy Call PostLoad on subobjects before copying for unrelated properties to avoid cases where an out of date object patched over in the linker has not been brought up to date #jira UE-38234 Change 3396718 on 2017/04/17 by Mike.Beach Adding a search bar to the components tree for Blueprints. #epicfriday #jira UE-17620 Change 3396999 on 2017/04/17 by Mike.Beach In generated code, call event '_Implementation' functions directly for interface functions being invoked on self (avoids a UHT runtime error). #jira UE-44018 Change 3397700 on 2017/04/18 by Marc.Audy UT struct BlueprintType fixups Change 3397701 on 2017/04/18 by Marc.Audy Odin struct BlueprintType fixups Change 3397703 on 2017/04/18 by Marc.Audy Ocean struct BlueprintType fixups Change 3397704 on 2017/04/18 by Marc.Audy WEX struct BlueprintType fixups Change 3397705 on 2017/04/18 by Marc.Audy Additional UT blueprint type struct fixups Change 3397706 on 2017/04/18 by Marc.Audy Fortnite struct BlueprintType fixups Change 3397708 on 2017/04/18 by Marc.Audy Fixup Engine BlueprintType markup of structs Change 3397709 on 2017/04/18 by Marc.Audy Sample Game struct BlueprintType fixups Change 3397711 on 2017/04/18 by Marc.Audy Mark AnimNodes as BlueprintType and BlueprintInternalUseOnly Change 3397712 on 2017/04/18 by Marc.Audy Paragon struct BlueprintType fixups Change 3397735 on 2017/04/18 by Marc.Audy Definition pieces of BlueprintInternalUseOnly to fix UHT errors with structs already marked to use it Change 3397912 on 2017/04/18 by Mike.Beach Fix for CIS warnings about shadowed variables (fallout from CL 3396718). Change 3398455 on 2017/04/18 by Marc.Audy Make less critical errors log an error rather than immediately throwing allowing multiple errors to be reported in the same compile Change 3398491 on 2017/04/18 by Marc.Audy BPRW/BPRO in a non-BlueprintType is now a UHT error Change 3398539 on 2017/04/18 by Marc.Audy Fixup live link struct markups Change 3399412 on 2017/04/19 by Marc.Audy Fix Match3 blueprint type struct markups Change 3399509 on 2017/04/19 by Phillip.Kavan #jira UE-38574 - Fix AnimBlueprint function graphs marked as 'const' to treat 'self' as read-only when compiling. Change summary: - Modified FKismetCompilerContext::ProcessOneFunctionGraph() to use the function graph schema rather than the compiler context schema for both the function context's schema as well as testing the function for 'const'-ness. For AnimBPs, the compiler context and the function graph context can differ, so we need to make sure we are using the right one when making queries for a specific function context during compilation. - Minor cleanup: changed the function context schema to be 'const' in order to be consistent with the function graph GetSchema() API's result. Added a few 'const' qualifiers where needed to match. - Added a new object version in order to avoid breaking compilation of existing AnimBP function graphs that may already be violating the 'const' rule (this is the same thing that was done when 'const' was first added to "normal" BP function graphs). Just as with normal function graphs in place before the addition, a warning will be generated for existing AnimBP function graphs if they violate 'const' correctness, and an error will be generated for all new ones. Change 3399749 on 2017/04/19 by Mike.Beach Hiding the Nativized Blueprints plugin from the in-editor browser (prevent users from disabling it). Change 3399774 on 2017/04/19 by Marc.Audy ConditionalPostLoad is already called on StaticMesh earlier in the function #rnx Change 3400313 on 2017/04/19 by Mike.Beach Mirroring CL 3398673 from 4.16 Now, with ICWYU, making sure that the coresponding header gets included first in nativized Blueprint files (else we get a UHT error). Had to fixup some ShooterGame specific files as a result (they had missing includes and forward declarations). #jira UE-44124 Change 3400328 on 2017/04/19 by Mike.Beach Missing file from mirrored change (CL 3400313 - mirroring CL 3398673 from 4.16) #jira UE-44124 Change 3400415 on 2017/04/19 by Chad.Garyet adding physx switch build to framework Change 3400514 on 2017/04/19 by Mike.Beach Back out changelist 3400313 / 3400328 (mirrored from CL 3398673 in 4.16), as it was producing "include PCH first" errors. Likely, CL 3398673 was a fix for a 4.16 specific change, altering the expected include order. We'll have to wait for this one to be integrated back. Change 3400552 on 2017/04/19 by Marc.Audy Undo the calling of post load prior to the CPFUO as dependent objects may not yet be loaded. Instead copy the need load flag to the new CDO subobject, similarly to how the top level CDO object copies its flags over. #jira UE-44150 Change 3400815 on 2017/04/19 by Marc.Audy Spelling fix (part of PR #3490) #rnx Change 3400918 on 2017/04/19 by Marc.Audy Partial pull of PR #3490: Improved remapping game controls support (Contributed by projectgheist) This portion brings in the exposure of the bindings to blueprint #jira UE-44122 Change 3401550 on 2017/04/20 by Marc.Audy fix kitedemo blueprint type markup #rnx Change 3401702 on 2017/04/20 by Mike.Beach Make it so plugins added to a project through the .uproject's 'AdditionalPluginDirectories' list get folded into the generated code project (for visual studio, etc.). Change 3401720 on 2017/04/20 by Mike.Beach Add white and black lists for target type (game, client, server, etc.) to plugin module descriptors. Change 3401725 on 2017/04/20 by Mike.Beach Whitelisting the nativized Blueprint plugin for only the targets it was built for (game, server, or client). Change 3401800 on 2017/04/20 by Ben.Zeigler Add Algo::BinarySearch, LowerBound, and UpperBound. These are setup to allow binary searching a presorted array, and allow for specifying projection and sort predicates. Convert some engine code to use it Add TSortedMap, which is a map data structure that has the same API as TMap, but is backed by a sorted array. It uses half the memory and performance is faster below n=10 Add FName::CompareIndexes so a SortedMap with FNames can be used without doing very slow string compares, and FNameSortIndexes predicate to sort by it Add code to Algo and Container tests. Split up container tests so the new ones aren't run in smoketest as they are a bit slow Add RemoveCurrent and SetToEnd to ArrayIterator Change 3401849 on 2017/04/20 by Marc.Audy Partial pull of PR #3490: Improved remapping game controls support (Contributed by projectgheist) This portion brings bug fixes and improvements to InputKeySelector UMG widgets. #jira UE-44122 Change 3402088 on 2017/04/20 by Marc.Audy Focus the search box when expanding the map value type #jira UE-44211 Change 3402251 on 2017/04/20 by Ben.Zeigler Fix issue where SortedMap needs to be resorted after serialization, because the sorting may have changed from when it was saved out Change 3402335 on 2017/04/20 by Ben.Zeigler Significant changes to FAssetData serialization and memory, cuts memory significantly but will break code that was using some of the internal API that was not properly hidden before Both Editor and Runtime cache now use the same FAssetRegistryVersion, which is now registered as a custom version Rename FAssetData and FAssetPackage operator<< to SerializeForCache to make it clear that it isn't safe to use for general serialization Remove GroupNames from FAssetData, it has not been useful since the UE4 package structure changed around 4.0 Rename generic-sounding but not actually generic SharedMapView class to AssetDataTagMapSharedView to indicate what it is actually used for Change TagsAndValues to use a new array-backed TSortedMap as the base structure instead of a hash map. Also, it only allocates the map on demand, which saves significant memory at runtime as many packages have no tags Add bFilterAssetDataWithNoTags to [AssetRegistry] ini section, if set it will only save cooked asset data if it has tags, off by default but saves significant memory if your whitelist is set up properly Fix issue where asset registry tags updated by loading assets during cook were not being reflected in the cooked registry Add AssetRegistry::GetAllocatedSize and add to MemReport output Change 3402457 on 2017/04/20 by Ben.Zeigler Enable asset registry iteration and stripping unused asset data in Fortnite. Registry iteration is already on in //Fortnite/Main, stripping is a new feature I want to test Change 3402498 on 2017/04/20 by Ben.Zeigler CIS fix. Why did this compile locally? Change 3402537 on 2017/04/20 by Ben.Zeigler Remove ensure for making AssetData for subobjects, the editor does this for thumbnail creation in some cases Change 3402600 on 2017/04/20 by Ben.Zeigler Add bShouldGuessTypeAndNameInEditor to manager settings, can be set false for games where type cannot be safely implied and content must be resaved Fix up some bool setting code inside asset manager, and fix const correctness and for iterator issues AssetManager can now discover any BlueprintCore type when bHasBlueprintClasses=true Add AssetManager.DumpAssetRegistryInfo to output detailed asset registry usage stats Add Primary Name to asset audit window by default Change 3403556 on 2017/04/21 by Marc.Audy Fix Orion input key selector override class #rnx Change 3404090 on 2017/04/21 by mason.seay Applying Forcefeedback to test map Change 3404093 on 2017/04/21 by mason.seay Changing text in level Change 3404139 on 2017/04/21 by mason.seay Added Force Feedback test and made some tweaks. Change 3404146 on 2017/04/21 by mason.seay Added source reference to Instanced Variable test Change 3404154 on 2017/04/21 by mason.seay More minor tweaks Change 3404155 on 2017/04/21 by Marc.Audy Remove auto #rnx Change 3404188 on 2017/04/21 by Marc.Audy Fixed crash changing variable type when any type other than map #jira UE-44249 #rnx Change 3404463 on 2017/04/21 by Ben.Zeigler Fix asset data code to not ensure when loading an object with invalid exports, and instead print warning with name of package that needs to be resaved Resave a map that had a redirector from a DIFFERENT package saved in it's exports. I do not understand how this happened, but it appears to be related to the lightmap BuiltData transition when old maps are opened Change 3404465 on 2017/04/21 by Ben.Zeigler Fix issue with trying to load editor-only asset classes in a cooked build Fix issues with renaming or changing template Ids of assets from the editor Always print the Duplicate Asset ID error, as if you have more than one the ensuremsg only goes off once Change 3404481 on 2017/04/21 by Dan.Oconnor Remove unneeded walk up hierarchy - prevent stale entries in action database if we compile a BP but don't compile its children Change 3404510 on 2017/04/21 by Phillip.Kavan #jira UE-35727 - Collapsed graphs containing a local variable node will no longer cause a compile error when the parent graph is renamed. Change 3404590 on 2017/04/21 by Michael.Noland Editor: Fixed incorrect filtering of abstract/deprecated UDeveloperSettings and UContentBrowserFrontEndFilterExtension classes caused by a typo (HasAnyCastFlags versus HasAnyClassFlags) Change 3404593 on 2017/04/21 by Marc.Audy Fixed another crash to do with input pin secondary combo box #jira UE-44269 #rnx Change 3404600 on 2017/04/21 by Michael.Noland Core: Allow UE_GC_TRACK_OBJ_AVAILABLE to be set externally #rnx Change 3404602 on 2017/04/21 by Michael.Noland Engine: Switched from an include to a forward declaration of SWidget in UDeveloperSettings to keep it slim #rnx Change 3404608 on 2017/04/21 by Michael.Noland Core: Marked TNumericLimits as constexpr so they can be used in static asserts Change 3404659 on 2017/04/21 by Michael.Noland Engine: Adding includes back to two UDeveloperSettings subclasses Change 3405289 on 2017/04/24 by Marc.Audy Remove auto #rnx Change 3405446 on 2017/04/24 by Marc.Audy Fix Win32 unsigned compile issue Change 3405512 on 2017/04/24 by Mike.Beach Piping through NativizationOptions to filename generation (so we're able to gen different files names per target: client vs. server). Change 3406080 on 2017/04/24 by Ben.Zeigler Deprecate UEngine::OnPostEngineInit and move to FCoreDelegates, clean up comments for the initialization delegates Call OnPostEngineInit from commandlet initialization as well as normal execution. I thought about making a wrapper function, but the commandlet calls EditorInit directly so it wouldn't work Bind delegate to refresh the AssetRegistry native class hierarchy after engine init so it picks up game/plugin classes. Undo ini change that was required to hack around this Change 3406381 on 2017/04/24 by Ben.Zeigler #jira UE-23768 Enable Run Physics With No Controller for montage test pawn. The montage pawn has no controller so wasn't correctly running physics when the root motion stopped. This flag needs to be set to allow it to correctly stop after the montage is over Change 3406438 on 2017/04/24 by Ben.Zeigler Fix deprecation warning Change 3406519 on 2017/04/24 by Phillip.Kavan #jira UE-43612 - Suppress array "Get" node fixup notifications on load when the BP Compilation Manager is enabled. Change summary: - Wrapped BPCM calls to FBlueprintEditorUtils::ReconstructAllNodes() and ReplaceDeprecatedNodes() duirng compile-on-load with bIsRegeneratingOnLoad = true. This matches the BP's state during compile-on-load when the BPCM is not enabled. Change 3406565 on 2017/04/24 by Dan.Oconnor Make sure all interface functions are added to skeleton #jira UE-44152 Change 3407489 on 2017/04/25 by Ben.Zeigler #jira UE-44317 Fix game-only TickableGameObjects to correctly tick in PIE Change 3407558 on 2017/04/25 by Ben.Zeigler Fix Fortnite cook warnings, issue had to do with the CDO being registered as a Primary Asset in conflict with the Class being registered Fix issue with renaming a BP primary asset not finding the old name Change 3407701 on 2017/04/25 by Dan.Oconnor Remove unneeded null check, static analysis doen't like the inconsistency Change 3407995 on 2017/04/25 by Marc.Audy Fixed maps and sets not working correctly with split pin. #jira UE-43857 Change 3408124 on 2017/04/25 by Ben.Zeigler #jira UE-39586 Change it so the blueprint String/Name/Object to Text node creates culture invariant text, and also have them show as an expanded node with a comment explaining this Fix Transform to actually return in the format specified in the comment, and fix comments on many text conversions Change 3408134 on 2017/04/25 by Marc.Audy Graph pin container type now represented by an enumeration (EPinContainerType) rather than 3 "independent" booleans. FEdGraphPinType constructor, UEdGraphNode::CreatePin, and FKismetCompilerContext::SpawnInternalVariable that took 3 booleans deprecated and replaced with a version that takes EPinContainerType. UEdGraphNode::CreatePin parameters reorganized so that PinName is before ContainerType and bIsReference, which default to None and false respectively Change 3408256 on 2017/04/25 by Michael.Noland Core: Changed UClass::ClassFlags to be of type EClassFlags for improved type safety Change 3408282 on 2017/04/25 by Marc.Audy (4.16) Fix incorrect positioning of instance components after duplication #jira UE-44314 Change 3408404 on 2017/04/25 by Mike.Beach Adding and removing the nativized plugin to/from the project when we alter the packaging nativization setting (so it gets picked up by project generation). Change 3408445 on 2017/04/25 by Marc.Audy Fix up missed deprecation cases #rnx Change 3409354 on 2017/04/26 by Marc.Audy Fix Linux CIS failure #rnx Change 3409487 on 2017/04/26 by Marc.Audy When dragging assets in to the SCS create them as siblings, not nested #jira UE-43041 Change 3409776 on 2017/04/26 by Ben.Zeigler #jira UE-44401 Fix issue with cooking a map containing a reparented component. In that case the child component may think it's not editor only, but it's archetype is editor only. This is not allowed in EDL, so now the child is marked as editor only as well Change 3410168 on 2017/04/26 by Dan.Oconnor Avoid calling virtual functions in the middle of compile #jira UE-44243 Change 3410252 on 2017/04/26 by Lukasz.Furman adjusted WITH_GAMEPLAY_DEBUGGER checks after IWYU changes #ue4 Change 3410385 on 2017/04/26 by Marc.Audy ChildActorComponent SetClass no longer fails when setting at runtime. #jira UE-43356 Change 3410466 on 2017/04/26 by Michael.Noland Core: Ensuring EClassFlags is 32 bit in a different way (underlying type of the enum is coming out signed even though all members are unsigned, long term fix is probably to move it to an enum class) #rnx Change 3410476 on 2017/04/26 by Michael.Noland Automation: Deleting some commented out methods #rnx Change 3411070 on 2017/04/27 by Marc.Audy Properly complete deprecation of old attachment API Change 3411338 on 2017/04/27 by mason.seay Map for Latent Action Tick Bug Change 3411637 on 2017/04/27 by Ben.Zeigler Back out CL #3381532 as it was causing crashes when adding new variables to blueprints, as the transaction array was being recursively modified while it was being added to Change 3412052 on 2017/04/27 by mason.seay Updated jump test map and pawn Change 3412231 on 2017/04/27 by Ben.Zeigler Fix issue where running SearchAllAssets multiple times after mounting new paths would throw away the asset registry cache, which slowed down incremental cooking substantially because the cooker mounts the autosave folder Duplicate of CL #3411860 Change 3412233 on 2017/04/27 by Ben.Zeigler Made FStreamableHandle::GetLoadedCount much faster by taking advantage of existing progress counter Duplicate of CL #3411778 Change 3412235 on 2017/04/27 by Ben.Zeigler Add code to FStringAssetReferenceThreadContext and FStringAssetReferenceSerializationScope which allows setting package name and collect options for string asset references serialized via something other than linker load Make RedirectCollector threadsafe to avoid issues with async loading asset references Fix it so ProcessStringAssetReferencePackageList will remove entries from the string asset array like resolve did, and rename function to indicate that Fix it so string asset references created by asset labels do not automatically get cooked, and significantly improve the speed of labels with lots of assets Add code to cooker and asset manager to explicitly mark non-cookable assets as NeverVook, this stops labels from ending up in the build if set that way Added option to not recurse package dependency changes more than one level when hashes change. This ended up not being significantly faster in a realistic case so left disabled Duplicate of CL #3412080 Change 3412352 on 2017/04/27 by Marc.Audy Refix lighting getting wrong position when getting component instance data Change 3412426 on 2017/04/27 by Marc.Audy Take first steps to making ComponentToWorld private and force use of accessor Make bWorldToComponentUpdated private Make ComponentToWorld and bWorldToComponentUpdated mutable Add a SetComponentToWorld function for the (likely ill-advised) places that were setting it directly. Change 3412468 on 2017/04/27 by Marc.Audy Remove last remnants of deprecated (4.11) custom location system Change 3413398 on 2017/04/28 by Marc.Audy Fix up missed deprecated attachment API uses Change 3413403 on 2017/04/28 by Marc.Audy Fix Orion compile error #rnx Change 3413448 on 2017/04/28 by Marc.Audy Fix up kite demo component to world privataization warnings #rnx Change 3413792 on 2017/04/28 by Ben.Zeigler Fix many bugs with blueprint pin default values, and add "Reset to Default Value" option to pin context menu Deprecate and rename SetPinDefaultValue because it actually sets the Autogenerated default. This was being called in bad places and destroying the stored autogenerated defaults #jira UE-40101 Fix expose on spawn pins to correctly update when the spawned object's defaults change #jira UE-21642 Fix struct pin default values to properly update when the struct is changed #jira UE-39418 Fix changed function/macro default values to properly update in already placed call nodes Change 3413839 on 2017/04/28 by samuel.proctor Added some Blueprint focused tests for TM-Gameplay Change 3414030 on 2017/04/28 by Ben.Zeigler Enable use of AssetPtr variables with Config, for native and blueprint This incorporates CL #3302487 but also enables for blueprint usage as that code is new to framework branch Change 3414229 on 2017/04/28 by Marc.Audy Fixup virtuals not calling their Super Remove some autos #rnx Change 3414451 on 2017/04/28 by Lukasz.Furman static analysis fix for gameplay debugger Change 3414482 on 2017/04/28 by Ben.Zeigler Fix crash found where changing pin type on ConvertAsset accessed an array while deleting it Change 3414609 on 2017/04/28 by Ben.Zeigler #jira UE-18146 Refresh graph when disconnecting a resolve asset id node Change 3415852 on 2017/05/01 by Marc.Audy Remove unused code #rnx Change 3415856 on 2017/05/01 by Marc.Audy auto removal #rnx Change 3415858 on 2017/05/01 by Marc.Audy Fix function taking an input as reference when unneeded and causing (still unclear why it suddenly started showing up) error in cooking #rnx Change 3415946 on 2017/05/01 by Marc.Audy Have K2Node_StructOperation skip the K2Node_Variable validation as it doesn't need a property (per CL# 1756451) #rnx Change 3415988 on 2017/05/01 by Lukasz.Furman renamed WorldContext param in AI related static blueprint functions to remove load/cook warnings #jira UE-44544 Change 3416030 on 2017/05/01 by Ben.Zeigler Fix issue with WorldContext pins being broken by my pin value refactor, partial paths like "WorldContext" need to be stored as strings and not as broken object references. Change 3416230 on 2017/05/01 by Marc.Audy Fix spelling error #rnx Change 3416419 on 2017/05/01 by Phillip.Kavan #jira UE-44213 - Nativizing a Blueprint class with a non-nativized Blueprint class subobject dependency will no longer lead to a crash at load time. Change summary: - Modified the FFakeImportTableHelper ctor to inject subobject CDOs into the 'SerializeBeforeCreateCDODependencies' array. This in turn ensures that EDL will serialize those subobject CDOs (if necessary) before we create the subobject's nativized owner's CDO at load time. - Modified FEmitDefaultValueHelper::GenerateCustomDynamicClassInitialization() to emit MiscConvertedSubobject instantiations AFTER we emit the FillUsedAssetsInDynamicClass() call. This is now consistent with the code emitted for other subobjects (all of which assumes that the UsedAssets array has been initialized). - Modified FFindAssetsToInclude::HandleObjectReference() to add UField owner CDOs in addition to the owner class to the asset dependency list. This ensures that owner CDOs will be emitted alongside the class to both the nativized asset dependency table as well as to the fake import table associated with the UDynamicClass linker for the nativized BP asset. Change 3416425 on 2017/05/01 by Phillip.Kavan #jira UE-44219 - Nativizing a Blueprint class with a nativized DOBP class dependency will no longer lead to a compile error at cook/nativization time. - Modified the FGatherConvertedClassDependencies ctor to properly handle DOBPs in exclusive mode that have been explicitly enabled for nativization. Previously, this code wasn't taking that possibility into account, and as a result could lead to a missing header file in a dependent nativized class body's include set. - Modified FGatherConvertedClassDependencies::GetFirstNativeOrConvertedClass() to remove the 'bExcludeBPDataOnly' parameter, as it was primarily just being used for a redundant exclusion check when called from the FGatherConvertedClassDependencies ctor. That call site has now been modified to start searching from the super class instead. Additionally, any DOBPs will already fail the preceding WillClassBeConverted() check if they have not been explicitly enabled for nativization in exclusive mode, and will always fail if nativizing in inclusive mode. The extra check was breaking the explicitly-enabled case, so it was removed to allow explicitly-enabled DOBPs to pass. Notes: - Allowing for explicitly-enabled DOBPs in exclusive mode may be removed in a future change, but since it is currently supported, the changes noted above will at least ensure that the generated code will compile properly for now. Change 3416570 on 2017/05/01 by mason.seay Added UMG test to map. Tweaked force feedback test Change 3416580 on 2017/05/01 by mason.seay Resubmitting sub levels Change 3416597 on 2017/05/01 by Dan.Oconnor Compilation manager iteration, adds machinery for individual blueprint compilation, adds comments, cleans up duplicated code Change 3416636 on 2017/05/01 by Phillip.Kavan #jira UE-44505 - Potential fix for a low-repro crash tied to the Blueprint graph context menu. Change summary: - Switched FBlueprintActionInfo::ActionOwner to be a weak object reference. Change 3416960 on 2017/05/01 by Dan.Oconnor Use compilation manager when clicking the compile button, PIE'ing, etc Change 3417207 on 2017/05/01 by Ben.Zeigler Fix issue with None strings causing default value parsing failures Add SetPinDefaultValueAtConstruction needed by some other changes Change 3417519 on 2017/05/01 by Ben.Zeigler Fix BP compile errors caused by local variables with invalid default values. There's no reason to set autogenerated here because the nodes are transient and invisible in the UI. There is still a problem here, local variables are not getting their default values validated when type is changed, so you end up with an integer that has the default value of a struct. Change 3418659 on 2017/05/02 by Ben.Zeigler #jira UE-44534 Fix it so animation node pins get properly created autogenerated default values that are based on the node struct defaults. This fixes issues when they are reset to other defaults #jira UE-44532 Fix it so connecting an animation asset pin on a node player resets the pin value to the autogenerated default instead of the cached asset. This was causing old unused assets to get unnecessarily cooked Fix it so any animation node with an exposed pin that is an object property will reset that object propery when the pin is exposed. This fixes UE-31015 in a generic way Change the OptionalPinManager to take a Defaults address as well as a current address, to allow setting autogenerated defaults properly Remove Import/ExportKismetDefaultValueToProperty as they were redundant with PropertyValueFromString and were using the wrong pin setting functions, replaced with PropertyValueFromString_Direct and calling the schema pin set functions I need to write some backward compatibility code to fix existing nodes, I'll do that in a later checkin Change 3418700 on 2017/05/02 by Ben.Zeigler Actually fix None object paths for real this time. I did not test sufficiently before Change 3418811 on 2017/05/02 by Ben.Zeigler Fix existing animation blueprint nodes with dead asset references duplicated by pins. This code can be applied independent of the other change to fix specific games Change 3419165 on 2017/05/02 by Dan.Oconnor Add misc. functionality from FKismetEditorUtilities::CompileBlueprint Change 3419202 on 2017/05/02 by Marc.Audy Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3417825 #rnx Change 3419236 on 2017/05/02 by mason.seay Removed OnPressed event from Widget BP Change 3419314 on 2017/05/02 by Marc.Audy Fix bad auto-resolve #rnx Change 3419524 on 2017/05/02 by Marc.Audy PR #3528: Improved Input BP library node display names (Contributed by projectgheist) #jira UE-44587 #rn Improved Input BP library node display names Change 3419570 on 2017/05/02 by Zak.Middleton #ue4 - Fix typo in TFunctionRef comment/example. Change 3419709 on 2017/05/02 by Dan.Oconnor Fix missing category metadata on SkeletonGeneratedClass when using compilation manager Change 3419756 on 2017/05/02 by Dan.Oconnor Remove unintentional verbosity increase Change 3420875 on 2017/05/03 by Marc.Audy Make IsExecPin static Minor optimization to IsMetaPin #rnx Change 3420981 on 2017/05/03 by Marc.Audy Change tagging temporarily until other changes are done so that we don't have warnings in the meantime #rnx Change 3421367 on 2017/05/03 by Marc.Audy Manually introduce changes from CL# 3398673 in 4.16 that failed to make it to Dev-Framework as a result of the integration submitted as CL# 3401725. #rnx Change 3421685 on 2017/05/03 by Ben.Zeigler #jira UE-23001 Convert literal Asset ID/Class ID pins to store path as string instead of as hard object reference. Old pins are fixed on load, after resaving the hard references will go away Refactor the way that FStringAssetReference and FAssetPtr are serialized, it now does the various fixups in FStringAssetReference::SerializePath, which is called from archivers Change it so the asset registry reads in a list of all scanned redirectors and adds them to GRedirectCollector, this means that saving a string asset reference will automatically fix it up to point to the redirector destination Change the default behavior of FAssetPtr serialize on ArchiveUObject to match what most of it's children want, and remove several special case hacks. It now serializes as asset reference when saving/loading, and as object for other cases Deprecate StringAssetReferenceLoaded/StringAssetReferenceSaving delegates, replace with PreSavePath and PostLoadPath on FStringAssetReference Make AssetLongPathname private on FStringAssetReference, it was deprecated in 4.9 Change 3421728 on 2017/05/03 by Phillip.Kavan Mirror CL 3408285 from //UE4/Release-4.16. #jira UE-44124 #rnx Change 3422370 on 2017/05/03 by Dan.Oconnor Mirror 3422359 Implement UBlueprintGeneratedClass::NeedsLoadForEditorGame to match UBlueprint, also tag a class's CDO as NeedsLoadForEditorGame. This prevents us from failing to load a UBlueprint's GeneratedClass when running the editor with -server. #jira UE-44659 Change 3423192 on 2017/05/04 by Ben.Zeigler CIS Fix Change 3423305 on 2017/05/04 by Ben.Zeigler Fix "Missing opening parenthesis" warnings for Vector and Rotator the same way they were fixed for Transform Change 3423358 on 2017/05/04 by Marc.Audy Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3422809 #rnx Change 3423766 on 2017/05/04 by Ben.Zeigler #jira UE-44680 Delete some corrupted redirectors that are no longer in use Change 3423804 on 2017/05/04 by Dan.Oconnor Honor SaveIntermediateCompilerResults when using compilation manager Change 3424010 on 2017/05/04 by Marc.Audy Validate that switch string cases are unique Change 3424011 on 2017/05/04 by Marc.Audy Re-fix switch node default pin not appearing as an exec output Remove unused boolean Change 3424071 on 2017/05/04 by Ben.Zeigler Delete FixupRedirects commandlet, replace with -FixupRedirects/FixupRedirectors option on ResavePackages. This new method is much faster than the old commandlet as it uses the asset registry vs loading all packages, fixing up all redirectors in Fortnite only took about an hour vs 12+ hours the old way Removed some hacky bits in Core that only existed to support FixupRedirects Change it so the AssetRegistry listens to DirectoryWatcher callbacks in commandlets now that commandlets use the asset registry properly. This won't do anything unless you tick directory watcher the way that ResavePackages does Change 3424313 on 2017/05/04 by Dan.Oconnor Address missing property flags on SkeletonGeneratedClass when using compilation manager #jira UE-44705 Change 3424325 on 2017/05/04 by Phillip.Kavan #jira UE-44222 - Move nativized UDS implementation details into its own .cpp file in order to avoid circular dependencies. Change summary: - Modified IKismetCompilerInterface::GenerateCppCodeForStruct() to include an output parameter for CPP source and modified FKismet2CompilerModule to match the updated API. - Modified IBlueprintCompilerCppBackend::GenerateCodeFromStruct() to include an output parameter for CPP source and modified FBlueprintCompilerCppBackendBase to match the updated API. - Modified FBlueprintNativeCodeGenUtils::GenerateCppCode() to adjust the call to GenerateCppCodeForStruct() to include CPP source output. - Modified FGatherConvertedClassDependencies::DependenciesForHeader() to switch UDS property dependencies to be forward declarations rather than includes (for default value init code). - Modified FEmitDefaultValueHelper::GenerateGetDefaultValue() to emit implementation details to the 'Body' container, and adjust the header content to be a declaration only. - Modified FIncludeHeaderHelper::EmitInner() to exclude a potentially-redundant line for the module's .h file, for the case when the caller has included the base filename in the 'AlreadyIncluded' set. - Modified FEmitterLocalContext::FindGloballyMappedObject() to limit the 'TryUsedAssetsList' path to UClass conversions only (since that requires a UDynamicClass target to work). - Modified FGatherConvertedClassDependencies::DependenciesForHeader() to only include BPGC fields if they are also being converted. Eliminates an issue with missing header files in generated code. Change 3424359 on 2017/05/04 by Ben.Zeigler Fix issue where StreamableManager would break when requesting an async load that failed the first time. Because our game supports downloading assets during gameplay it's not safe to assume it will never load again. Port of CL #3424159 Change 3424367 on 2017/05/04 by Ben.Zeigler Fix some asset manager warnings to not go off in invalid cases Change 3425270 on 2017/05/05 by Marc.Audy Pack booleans/enums in UEdGraphNode and FOptionalPinFromProperty #rnx Change 3425696 on 2017/05/05 by Ben.Zeigler #jira UE-44672 Fix it so select node option pins get populated with default values properly #jira UE-43927 Fix it so select node opion pin type is correctly maintained accross node recreation, as opposed to deriving from the attached pins #jira UE-44675 Fix it to correctly refresh select node when switching from bool to integer index Change 3425833 on 2017/05/05 by Ben.Zeigler #jira UE-31749 Fix it so Undo works properly when modifying a local variable #jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value Change 3425890 on 2017/05/05 by Marc.Audy Fix Copy/Paste of child actor components losing the template #jira UE-44566 Change 3425947 on 2017/05/05 by Ben.Zeigler This was meant to be part of last checkin Change 3425959 on 2017/05/05 by Ben.Zeigler #jira UE-44692 Fix it so only the sequentially last node can be removed from a Switch On Int, and for Switch On Name stop it from removing an exec pin if it's the only non-default one Change 3425979 on 2017/05/05 by Dan.Oconnor PVS fix Change 3425985 on 2017/05/05 by Phillip.Kavan Fix an uninitialized variable. #rnx Change 3426043 on 2017/05/05 by Ben.Zeigler #jira UE-35583 Correctly refresh array node UI when connecting pins that change it away from wildcard Change 3426174 on 2017/05/05 by Zak.Middleton #ue4 - Avoid call to virtual getSimulationFilterData() to only use it when needed in PreFilter if we actually have items in the IgnoreComponents list (which is rare). The sim filter data 'word2' stores the component ID. Change 3426621 on 2017/05/05 by Phillip.Kavan #jira UE-44708 - Fix an issue that re-introduced component data loss in a non-nativized child Blueprint class with a nativized parent Blueprint class. Change summary: - Removed an unnecessary additional check I had for the presence of "-NativizeAssets" switch on the command line in UBlueprint::BeginCacheForCookedPlatformData(). This check was failing because the usage was recently changed to include an optional value. It was not needed anyway so I just removed it. #rnx Change 3426906 on 2017/05/05 by Ben.Zeigler #jira UE-11189 Fix function/macro input default values to show as a pin customization instead of as a broken text box that doesn't work correctly for most types. This fixes enums and provide validation for other types Types that don't have a customization (most structs) will now show any more, they did not work before either #jira UE-21754 Hide function default values if pass by reference is set Fix it so changing input parameter will also reset default value, to avoid having the wrong type value set and to work the same as local variables Change 3426941 on 2017/05/05 by Dan.Oconnor Fix determinstic cooking of LoadAssetClass nodes in macros Change 3427021 on 2017/05/05 by Dan.Oconnor Build fix, make initialization order in source match artifact #rnx Change 3427135 on 2017/05/05 by Phillip.Kavan #jira UE-44702 - Restore code-based interface classes to Blueprint editor UI. Change summary: - Partially backed out CL# 3348513 to return to previous behavior for 4.16. The UI is no longer filtering on the __is_abstract() type trait for interface classes. - Modified FNativeClassHeaderGenerator::ExportClassFromSourceFileInner() to emit the _getUObject() declaration for native interface types as a default implementation that returns NULL rather than as a pure virtual declaration. #rnx Change 3427144 on 2017/05/06 by Marc.Audy Fix init order #rnx Change 3427146 on 2017/05/06 by Marc.Audy remove stray semicolon #rnx Change 3427242 on 2017/05/06 by Phillip.Kavan #jira UE-44744 - Fix a regression in which a UMG Widget Blueprint property not explicitly marked as a variable would cause Blueprint nativization to fail at package time. Change summary: - Modified FWidgetBlueprintCompiler::CreateClassVariablesFromBlueprint() to only add 'Category' metadata when we set the 'CPF_BlueprintVisible' flag on the UProperty, which in is now tied to whether or not the property has been explcitly marked as a variable. This avoids a UHT warning when compiling the nativized codegen that would cause packaging to fail. #rnx Change 3427720 on 2017/05/08 by Dan.Oconnor Backing out 3419202 #rnx Change 3427725 on 2017/05/08 by Dan.Oconnor SA fix #rnx Change 3427734 on 2017/05/08 by Dan.Oconnor More exhaustive GEditor null checks, to appease SA #rnx Change 3427882 on 2017/05/08 by Marc.Audy Properly order all booleans in intialization #rnx Change 3428049 on 2017/05/08 by Marc.Audy Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3427804 #rnx Change 3428523 on 2017/05/08 by Ben.Zeigler #jira UE-44781 Refresh function input UI when blueprint graph refreshes, needed as pins may have gone away Change 3428563 on 2017/05/08 by Ben.Zeigler #jira UE-44783 If setting a hard reference pin type from a string, load the referenced object. Change 3428595 on 2017/05/08 by Dan.Oconnor Avoid node reconstruction when we're compiling a blueprint with no linker (e.g., a duplicated blueprint) #jira UE-44777 Change 3428599 on 2017/05/08 by Ben.Zeigler #jira UE-44789 Fix string asset renamer to not mark IsPersistent becuase that crashes in lightmap code, change it so the path fixup doesn't require the persistent flag Change 3428609 on 2017/05/08 by Dan.Oconnor Improved fix for UE-44777 #jira UE-44777 #rnx Change 3429176 on 2017/05/08 by Phillip.Kavan #jira UE-44755 - Fix nativization build errors when packaging a game project that is not IWYU-compliant for a build target that disables PCH files. - Mirrored from //UE4/Release-4.16 (CL# 3429030). #rnx Change 3429198 on 2017/05/08 by Phillip.Kavan CIS fix. #rnx Change 3429583 on 2017/05/08 by Ben.Zeigler Fix SGraphPinClass to work properly after my changes to allow unloaded assets. For Class pins we need to store separate Runtime and Editor asset data objects, as one has _C and refers to the class, and the other doesn't and refers to the blueprint. The content browser wants the editor path, the pin defaults want the runtime path. Change default value widgets to look more like properties widgets by forcing them to act as highlighted and disabling black background Change 3429640 on 2017/05/08 by Marc.Audy Fix issues with select nodes in macros connected to wildcard pins. #jira UE-44799 #rnx Change 3429890 on 2017/05/08 by Ben.Zeigler Fix function/macro defaults to properly propagate when changed using the new edit UI Refactor some code out of the details customization into the k2 schema Disable defaults UI for object/class/interface hard references as it is disabled in KismetCompiler Change 3429947 on 2017/05/08 by Michael.Noland Core: Backing out CL# 3394352 (marking FDateTime and FTimespan nonexport member Tick with UPROPERTY()), which will re-break UE-39921 but fix UE-44418 There appears to be a more serious underlying issue with how the CDO is instanced which needs to be addressed #jira UE-44418 #reimplementing 3411681 from Release 4.16 Change 3429987 on 2017/05/08 by Ben.Zeigler #jira UE-44798 Do a better job of validating object paths saved as default values, due to an old bug with local variables some object paths are saved as struct exportext At load time clear invalid default value for local variables Add IsValidObjectPath to FPackageName that validates the passed in path would be valid to load with LoadObject Change 3430392 on 2017/05/09 by Marc.Audy Fix SA CIS error #rnx Change 3430747 on 2017/05/09 by Ben.Zeigler #jira UE-44836 Don't reconstruct node during callback for param value changing, this can happen during a reconstruction and recursive reconstruction is unsafe Don't call ModifyUserDefinedPinDefaultValue unless the default value has actually changed Change 3431027 on 2017/05/09 by Marc.Audy Fix BPRW mark up causing Ocean warnings #rnx Change 3431353 on 2017/05/09 by Marc.Audy Fix UHT error due to exposing FJsonObjectWrapper to blueprints #rnx [CL 3431398 by Marc Audy in Main branch]
2017-05-09 17:15:32 -04:00
if (SC.StageTargetPlatform.PlatformType == UnrealTargetPlatform.Win32 || SC.StageTargetPlatform.PlatformType == UnrealTargetPlatform.Win64)
{
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3431384) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3252833 on 2017/01/10 by Ori.Cohen Refactor constraint so that it can be used for external solvers. (Copying //Tasks/UE4/Dev-ImmediateModePhysics to Dev-Framework (//UE4/Dev-Framework)) Change 3256288 on 2017/01/12 by Ori.Cohen Undo constraint refactor as we found a way around it and it made the code much harder to read/debug Change 3373195 on 2017/03/30 by Mike.Beach For nativization, changing it so we key off of the target platform-info struct instead of the platform (in preparation for defining the nativized plugin's platform whitelist). Change 3381178 on 2017/04/05 by Dan.Oconnor Make sure we don't inherit the NATIVE func flag when generating skeleton functions, also make sure all bojects outer'd to the skeleton class are marked transient #jira UE-43616 Change 3381532 on 2017/04/05 by Marc.Audy (4.16) Fix various cases where built lighting on child actors could be lost when loading a level #jira UE-43553 Change 3381586 on 2017/04/05 by Mike.Beach Now generating TArrayCaster conversions for nativized UClass arrays that need it (to handle different TSubclassOf arrays). #jira UE-42676, UE-43257 Change 3381682 on 2017/04/05 by mason.seay Some more changes to test map Change 3381844 on 2017/04/05 by Dan.Oconnor Match existing logic for CPF_ReturnParm/CPF_OutParm. Fixes compilation error in BP_TurbineBlades when using compilation manager Change 3382054 on 2017/04/05 by Zak.Middleton #ue4 - Optimize CharacterMovementComponent::GetPredictionData_Client_Character() and GetPredictionData_Server_Character() to remove virtual calls. #jira UE-30998 Change 3382703 on 2017/04/06 by Lukasz.Furman fixed missing links between navmesh polys when there are more than 4 neighbor connections #jira UE-43524 Change 3383357 on 2017/04/06 by Marc.Audy (4.16) Make SetHiddenInGame propagate consistently with SetVisibility #jira UE-43709 Change 3383359 on 2017/04/06 by Dan.Oconnor Fix last errant SKEL reference when cooking Odin Change 3383591 on 2017/04/06 by Mike.Beach Prevent users from setting object variables as 'config' properties (disallowed by UHT). This prevents some errors that could happen later when users nativize the Blueprint. #jira UE-42085 Change 3384762 on 2017/04/07 by Zak.Middleton #ue4 - Fix SpringArmComponent not restoring relative transform when bUsePawnControlRotation is turned off. Fixes the editor interaction ignoring transform of the component in the viewport after bUsePawnControlRotation is toggled on then off, since by then the world transform had been overwritten (from tick in editor) and nothing would drive transform changes from the editable value. Toggling bUsePawnControlRotation off at runtime now restores the rotation to the initial relative rotation, not stomping it with the current pawn rotation, allowing toggling between the editable/desired base rotation and the control rotation. #jira UE-24850 Change 3384948 on 2017/04/07 by Dan.Oconnor Prevent GForceDisableBlueprintCompileOnLoad from causing all sorts of badness when dependencies are loaded as part of a Diff operation. Instead of setting a global flag we flag the package as LOAD_DisableCompileOnLoad Change 3385267 on 2017/04/07 by Michael.Noland Graph Editing: Pushed some node diffing code down from UAIGraphNode into UEdGraphNode so nodes with details panel properties will diff correctly (e.g., various animation nodes and BP switch nodes) #jira UE-21724 Change 3385473 on 2017/04/07 by Phillip.Kavan #jira UE-43067 - Fix broken pin wires after an Expand Node operation, along with some misc. cleanup. Change summary: - Fixed to use correct string for "Expand Node" transaction name. - Modified FBlueprintEditor::OnExpandNodes() to consolidate some redundant code. - Fixed to generate a unique node GUID for cases where the source graph is not removed after expansion. Change 3385583 on 2017/04/07 by Dan.Oconnor Handle CreatePropertyOnScope nullptr return values (happens for structs missing a struct property) #jira UE-43746 Change 3386581 on 2017/04/10 by Michael.Noland Blueprints: Further hardening FBlueprintActionInfo::GetOwnerClass() #jira UE-43824 Change 3386615 on 2017/04/10 by Marc.Audy Instanced properties can now properly be set on a per-instance basis in blueprint added components. #jira UE-42066 Change 3387000 on 2017/04/10 by Marc.Audy Fix includes for CIS Change 3387229 on 2017/04/10 by mason.seay More changes to TM-Gameplay Added Save Game test (with blueprint) Tick Interval test (with blueprint) BP logic cleanup Level organization Change 3388437 on 2017/04/11 by Mike.Beach Adding support for map/set literals in the backend (so you can use set nodes for structs containing sets/maps, without having to connect a RHS input - resets to struct defaults). #jira UE-42617 Change 3388532 on 2017/04/11 by mason.seay Submitting latest changes for crash repro Change 3389026 on 2017/04/11 by Ben.Zeigler Performance and bug fixes for incremetal cooking with asset registry, duplicate of several changes made on //Fortnite/Main Fix it so AssetRegistry.ScanPathsAndFilesSynchronous won't scan subdirectories inside already scanned directories, this cuts down on the number of cache files Fix 2 second stall when shutting down AssetSourceFilenameCache if it had never been previously created Change 3389163 on 2017/04/11 by Ben.Zeigler #jira UE-42922 Fix it so connecting function input node output pins does not clear default value, we only want to clear the value when connecting an input pin. Properly testing this fix depends on UE-43883 Change 3389205 on 2017/04/11 by Marc.Audy Protect against a handful of GEditor usages that can now be hit in standalone Change 3389220 on 2017/04/11 by Marc.Audy Don't borrow ClassWithin to masquerade as ParentClass during compilation and instead just set the super struct immediately Change 3389222 on 2017/04/11 by Michael.Noland Framework: Adding a cvar (t.TickComponentLatentActionsWithTheComponent) to allow users to revert to the old behavior on when component latent actions tick - Non-zero values behave the same way as actors do, ticking pending latent action when the component ticks, instead of later on in the frame (default behavior in 4.16 and beyond) - Prior to 4.16, components behaved as if the value were 0, which meant their latent actions behaved differently to actors This CVar will be removed in a future version, defaulting to on #jira UE-43661 Change 3389276 on 2017/04/11 by Marc.Audy Spelling fix and NULL to nullptr Change 3389303 on 2017/04/11 by Mieszko.Zielinski Made sure AIController::Posses doesn't get called when compiling Pawn BP #UE4 #jira UE-43873 Change 3390215 on 2017/04/12 by mason.seay Removed some tests, will need further review Change 3390638 on 2017/04/12 by Mike.Beach Generalizing the omission of the CoerceProperty (in EmitTerm) - previously we were only omitting properties for our custom array lib. For wildcards, a coerce property should not be used as its type will not match. NOTE: There is a slight behavior change in UEdGraphSchema_K2::ConvertPropertyToPinType(), as it will return 'wildcard' for params marked as 'ArrayTypeDependentParams' (previously would have returned 'int'). #jira UE-42747 Change 3390774 on 2017/04/12 by Ben.Zeigler #jira UE-43911 Fix several issues with saving a runtime asset registry containing redirectors that caused crashes in cook on the fly. Don't resolve redirectors on incoming links because it will make a circular link, and fix an issue where chained redirectors would break the for loop iteration and return a bad dependency Fix it so the asset registry written out at the beginning of CookOnTheFly uses the registry generator, otherwise it will include all of the stripped editor only tags Change 3390778 on 2017/04/12 by Ben.Zeigler Fix UCookOnTheFlyServer::CollectFilesToCook to check for initial unsolicited packages up front. This is required in iterative mode because it may skip cooking all explicit packages and thus miss a new startup loaded package Change 3390782 on 2017/04/12 by Ben.Zeigler Change RunProjectCommand to not imply -nomcp, and allow reading -clientcmdline to override setting the map parameter to 127.0.0.1 by default Fix RunProjectCommand to remove ios-specific checks to not pass weird platform parameters, and instead never pass them Fix PS4Platform to pass along command line when calling build cook run, args needs to be the last parameter so explicitly set -target= Change 3390859 on 2017/04/12 by Mike.Beach T3D class fields now export with the class's fully qualified path name (to avoid abiguity). Since we can have multiple classes with the same name (Blueprints in different folders), we have to use the class's fully qualified object path. #jira UE-28048 Change 3390914 on 2017/04/12 by Lukasz.Furman fixed missing navlink component's transform in exported navigation data #jira UE-43688 Change 3391122 on 2017/04/12 by Ben.Zeigler Add new PreloadPrimaryAssets call to AssetManager that stream the desired assets without modifying the official load/unload state. This is useful if you want to preload things in case the might be used in the future, and it also supports recursion Fix crash calling GetAssetDataForPath with null path Change 3391494 on 2017/04/12 by Dan.Oconnor Fix bad references in deep object (widget) hierarchies #jira UE-43802 Change 3391529 on 2017/04/12 by Dan.Oconnor Fix log spam, accidently submitted #rnx Change 3391756 on 2017/04/12 by Dan.Oconnor LinkExternalDependencies needs to be performed before we RefreshVariables #jira UE-43843 Change 3392542 on 2017/04/13 by Marc.Audy Ensure that initialized actors get cleaned up when removed from world even if that world hasn't begun play. #jira UE-43879 Change 3392746 on 2017/04/13 by Marc.Audy (4.16) When duplicating a blueprint node, correctly make the new node a sibling of the duplicated node, not a child of it (unless duplicating the root component). Also resets scale of a duplicated root component to 1 to avoid a squaring of the scale for that component. #jira UE-40218 #jira UE-42086 Change 3393253 on 2017/04/13 by Dan.Oconnor Make sure calculated meta data is correctly set on functions generated by the compilation manager (SKEL_ class functions) #jira UE-43883 Change 3393509 on 2017/04/13 by Mike.Beach Removing hack'ish ResetLoaders() call that was causing undesired side-effects (resetting of a loaded package that other objects were relying on). This was originally intended to release file handles so separate editor processes could make updates and save the file (from CL 1712376). Using ResetLoaders() for this is bad though, as it has too many side effects. Instead we have to wait for GC to run. This also makes sure that GC should run as intended as the CookOnTheFly sever is idling. #jira UE-37284 Change 3394350 on 2017/04/14 by Michael.Noland Core: Making FDateTime and FTimespan actually reflected, so they get duplicated properly in CopyPropertiesForUnrelatedObjects, etc... #jira UE-39921 Change 3395985 on 2017/04/17 by Phillip.Kavan #jira UE-38280 - Fix invalid custom type selections on member fields in the User-Defined Structure Editor after a reload. Change summary: - Ensure that the 'SubCategoryObject' member in a UDS variable descriptor has been loaded when converting to an FEdGraphPinType. Change 3396152 on 2017/04/17 by Marc.Audy TickableGameObjects that have IsTickableInEditor false should not tick in the editor #jira UE-40421 Change 3396279 on 2017/04/17 by Phillip.Kavan #jira UE-43968 - Fix failed validation of bitmask enum types when serializing bitmask literal nodes. Change 3396299 on 2017/04/17 by Dan.Oconnor Fix resintancing issues exposed by running TM-Gameplay with -game. We cannot reinstance actors in levels on load because the scene is not created. #jira UE-43859 Change 3396712 on 2017/04/17 by Marc.Audy Call PostLoad on subobjects before copying for unrelated properties to avoid cases where an out of date object patched over in the linker has not been brought up to date #jira UE-38234 Change 3396718 on 2017/04/17 by Mike.Beach Adding a search bar to the components tree for Blueprints. #epicfriday #jira UE-17620 Change 3396999 on 2017/04/17 by Mike.Beach In generated code, call event '_Implementation' functions directly for interface functions being invoked on self (avoids a UHT runtime error). #jira UE-44018 Change 3397700 on 2017/04/18 by Marc.Audy UT struct BlueprintType fixups Change 3397701 on 2017/04/18 by Marc.Audy Odin struct BlueprintType fixups Change 3397703 on 2017/04/18 by Marc.Audy Ocean struct BlueprintType fixups Change 3397704 on 2017/04/18 by Marc.Audy WEX struct BlueprintType fixups Change 3397705 on 2017/04/18 by Marc.Audy Additional UT blueprint type struct fixups Change 3397706 on 2017/04/18 by Marc.Audy Fortnite struct BlueprintType fixups Change 3397708 on 2017/04/18 by Marc.Audy Fixup Engine BlueprintType markup of structs Change 3397709 on 2017/04/18 by Marc.Audy Sample Game struct BlueprintType fixups Change 3397711 on 2017/04/18 by Marc.Audy Mark AnimNodes as BlueprintType and BlueprintInternalUseOnly Change 3397712 on 2017/04/18 by Marc.Audy Paragon struct BlueprintType fixups Change 3397735 on 2017/04/18 by Marc.Audy Definition pieces of BlueprintInternalUseOnly to fix UHT errors with structs already marked to use it Change 3397912 on 2017/04/18 by Mike.Beach Fix for CIS warnings about shadowed variables (fallout from CL 3396718). Change 3398455 on 2017/04/18 by Marc.Audy Make less critical errors log an error rather than immediately throwing allowing multiple errors to be reported in the same compile Change 3398491 on 2017/04/18 by Marc.Audy BPRW/BPRO in a non-BlueprintType is now a UHT error Change 3398539 on 2017/04/18 by Marc.Audy Fixup live link struct markups Change 3399412 on 2017/04/19 by Marc.Audy Fix Match3 blueprint type struct markups Change 3399509 on 2017/04/19 by Phillip.Kavan #jira UE-38574 - Fix AnimBlueprint function graphs marked as 'const' to treat 'self' as read-only when compiling. Change summary: - Modified FKismetCompilerContext::ProcessOneFunctionGraph() to use the function graph schema rather than the compiler context schema for both the function context's schema as well as testing the function for 'const'-ness. For AnimBPs, the compiler context and the function graph context can differ, so we need to make sure we are using the right one when making queries for a specific function context during compilation. - Minor cleanup: changed the function context schema to be 'const' in order to be consistent with the function graph GetSchema() API's result. Added a few 'const' qualifiers where needed to match. - Added a new object version in order to avoid breaking compilation of existing AnimBP function graphs that may already be violating the 'const' rule (this is the same thing that was done when 'const' was first added to "normal" BP function graphs). Just as with normal function graphs in place before the addition, a warning will be generated for existing AnimBP function graphs if they violate 'const' correctness, and an error will be generated for all new ones. Change 3399749 on 2017/04/19 by Mike.Beach Hiding the Nativized Blueprints plugin from the in-editor browser (prevent users from disabling it). Change 3399774 on 2017/04/19 by Marc.Audy ConditionalPostLoad is already called on StaticMesh earlier in the function #rnx Change 3400313 on 2017/04/19 by Mike.Beach Mirroring CL 3398673 from 4.16 Now, with ICWYU, making sure that the coresponding header gets included first in nativized Blueprint files (else we get a UHT error). Had to fixup some ShooterGame specific files as a result (they had missing includes and forward declarations). #jira UE-44124 Change 3400328 on 2017/04/19 by Mike.Beach Missing file from mirrored change (CL 3400313 - mirroring CL 3398673 from 4.16) #jira UE-44124 Change 3400415 on 2017/04/19 by Chad.Garyet adding physx switch build to framework Change 3400514 on 2017/04/19 by Mike.Beach Back out changelist 3400313 / 3400328 (mirrored from CL 3398673 in 4.16), as it was producing "include PCH first" errors. Likely, CL 3398673 was a fix for a 4.16 specific change, altering the expected include order. We'll have to wait for this one to be integrated back. Change 3400552 on 2017/04/19 by Marc.Audy Undo the calling of post load prior to the CPFUO as dependent objects may not yet be loaded. Instead copy the need load flag to the new CDO subobject, similarly to how the top level CDO object copies its flags over. #jira UE-44150 Change 3400815 on 2017/04/19 by Marc.Audy Spelling fix (part of PR #3490) #rnx Change 3400918 on 2017/04/19 by Marc.Audy Partial pull of PR #3490: Improved remapping game controls support (Contributed by projectgheist) This portion brings in the exposure of the bindings to blueprint #jira UE-44122 Change 3401550 on 2017/04/20 by Marc.Audy fix kitedemo blueprint type markup #rnx Change 3401702 on 2017/04/20 by Mike.Beach Make it so plugins added to a project through the .uproject's 'AdditionalPluginDirectories' list get folded into the generated code project (for visual studio, etc.). Change 3401720 on 2017/04/20 by Mike.Beach Add white and black lists for target type (game, client, server, etc.) to plugin module descriptors. Change 3401725 on 2017/04/20 by Mike.Beach Whitelisting the nativized Blueprint plugin for only the targets it was built for (game, server, or client). Change 3401800 on 2017/04/20 by Ben.Zeigler Add Algo::BinarySearch, LowerBound, and UpperBound. These are setup to allow binary searching a presorted array, and allow for specifying projection and sort predicates. Convert some engine code to use it Add TSortedMap, which is a map data structure that has the same API as TMap, but is backed by a sorted array. It uses half the memory and performance is faster below n=10 Add FName::CompareIndexes so a SortedMap with FNames can be used without doing very slow string compares, and FNameSortIndexes predicate to sort by it Add code to Algo and Container tests. Split up container tests so the new ones aren't run in smoketest as they are a bit slow Add RemoveCurrent and SetToEnd to ArrayIterator Change 3401849 on 2017/04/20 by Marc.Audy Partial pull of PR #3490: Improved remapping game controls support (Contributed by projectgheist) This portion brings bug fixes and improvements to InputKeySelector UMG widgets. #jira UE-44122 Change 3402088 on 2017/04/20 by Marc.Audy Focus the search box when expanding the map value type #jira UE-44211 Change 3402251 on 2017/04/20 by Ben.Zeigler Fix issue where SortedMap needs to be resorted after serialization, because the sorting may have changed from when it was saved out Change 3402335 on 2017/04/20 by Ben.Zeigler Significant changes to FAssetData serialization and memory, cuts memory significantly but will break code that was using some of the internal API that was not properly hidden before Both Editor and Runtime cache now use the same FAssetRegistryVersion, which is now registered as a custom version Rename FAssetData and FAssetPackage operator<< to SerializeForCache to make it clear that it isn't safe to use for general serialization Remove GroupNames from FAssetData, it has not been useful since the UE4 package structure changed around 4.0 Rename generic-sounding but not actually generic SharedMapView class to AssetDataTagMapSharedView to indicate what it is actually used for Change TagsAndValues to use a new array-backed TSortedMap as the base structure instead of a hash map. Also, it only allocates the map on demand, which saves significant memory at runtime as many packages have no tags Add bFilterAssetDataWithNoTags to [AssetRegistry] ini section, if set it will only save cooked asset data if it has tags, off by default but saves significant memory if your whitelist is set up properly Fix issue where asset registry tags updated by loading assets during cook were not being reflected in the cooked registry Add AssetRegistry::GetAllocatedSize and add to MemReport output Change 3402457 on 2017/04/20 by Ben.Zeigler Enable asset registry iteration and stripping unused asset data in Fortnite. Registry iteration is already on in //Fortnite/Main, stripping is a new feature I want to test Change 3402498 on 2017/04/20 by Ben.Zeigler CIS fix. Why did this compile locally? Change 3402537 on 2017/04/20 by Ben.Zeigler Remove ensure for making AssetData for subobjects, the editor does this for thumbnail creation in some cases Change 3402600 on 2017/04/20 by Ben.Zeigler Add bShouldGuessTypeAndNameInEditor to manager settings, can be set false for games where type cannot be safely implied and content must be resaved Fix up some bool setting code inside asset manager, and fix const correctness and for iterator issues AssetManager can now discover any BlueprintCore type when bHasBlueprintClasses=true Add AssetManager.DumpAssetRegistryInfo to output detailed asset registry usage stats Add Primary Name to asset audit window by default Change 3403556 on 2017/04/21 by Marc.Audy Fix Orion input key selector override class #rnx Change 3404090 on 2017/04/21 by mason.seay Applying Forcefeedback to test map Change 3404093 on 2017/04/21 by mason.seay Changing text in level Change 3404139 on 2017/04/21 by mason.seay Added Force Feedback test and made some tweaks. Change 3404146 on 2017/04/21 by mason.seay Added source reference to Instanced Variable test Change 3404154 on 2017/04/21 by mason.seay More minor tweaks Change 3404155 on 2017/04/21 by Marc.Audy Remove auto #rnx Change 3404188 on 2017/04/21 by Marc.Audy Fixed crash changing variable type when any type other than map #jira UE-44249 #rnx Change 3404463 on 2017/04/21 by Ben.Zeigler Fix asset data code to not ensure when loading an object with invalid exports, and instead print warning with name of package that needs to be resaved Resave a map that had a redirector from a DIFFERENT package saved in it's exports. I do not understand how this happened, but it appears to be related to the lightmap BuiltData transition when old maps are opened Change 3404465 on 2017/04/21 by Ben.Zeigler Fix issue with trying to load editor-only asset classes in a cooked build Fix issues with renaming or changing template Ids of assets from the editor Always print the Duplicate Asset ID error, as if you have more than one the ensuremsg only goes off once Change 3404481 on 2017/04/21 by Dan.Oconnor Remove unneeded walk up hierarchy - prevent stale entries in action database if we compile a BP but don't compile its children Change 3404510 on 2017/04/21 by Phillip.Kavan #jira UE-35727 - Collapsed graphs containing a local variable node will no longer cause a compile error when the parent graph is renamed. Change 3404590 on 2017/04/21 by Michael.Noland Editor: Fixed incorrect filtering of abstract/deprecated UDeveloperSettings and UContentBrowserFrontEndFilterExtension classes caused by a typo (HasAnyCastFlags versus HasAnyClassFlags) Change 3404593 on 2017/04/21 by Marc.Audy Fixed another crash to do with input pin secondary combo box #jira UE-44269 #rnx Change 3404600 on 2017/04/21 by Michael.Noland Core: Allow UE_GC_TRACK_OBJ_AVAILABLE to be set externally #rnx Change 3404602 on 2017/04/21 by Michael.Noland Engine: Switched from an include to a forward declaration of SWidget in UDeveloperSettings to keep it slim #rnx Change 3404608 on 2017/04/21 by Michael.Noland Core: Marked TNumericLimits as constexpr so they can be used in static asserts Change 3404659 on 2017/04/21 by Michael.Noland Engine: Adding includes back to two UDeveloperSettings subclasses Change 3405289 on 2017/04/24 by Marc.Audy Remove auto #rnx Change 3405446 on 2017/04/24 by Marc.Audy Fix Win32 unsigned compile issue Change 3405512 on 2017/04/24 by Mike.Beach Piping through NativizationOptions to filename generation (so we're able to gen different files names per target: client vs. server). Change 3406080 on 2017/04/24 by Ben.Zeigler Deprecate UEngine::OnPostEngineInit and move to FCoreDelegates, clean up comments for the initialization delegates Call OnPostEngineInit from commandlet initialization as well as normal execution. I thought about making a wrapper function, but the commandlet calls EditorInit directly so it wouldn't work Bind delegate to refresh the AssetRegistry native class hierarchy after engine init so it picks up game/plugin classes. Undo ini change that was required to hack around this Change 3406381 on 2017/04/24 by Ben.Zeigler #jira UE-23768 Enable Run Physics With No Controller for montage test pawn. The montage pawn has no controller so wasn't correctly running physics when the root motion stopped. This flag needs to be set to allow it to correctly stop after the montage is over Change 3406438 on 2017/04/24 by Ben.Zeigler Fix deprecation warning Change 3406519 on 2017/04/24 by Phillip.Kavan #jira UE-43612 - Suppress array "Get" node fixup notifications on load when the BP Compilation Manager is enabled. Change summary: - Wrapped BPCM calls to FBlueprintEditorUtils::ReconstructAllNodes() and ReplaceDeprecatedNodes() duirng compile-on-load with bIsRegeneratingOnLoad = true. This matches the BP's state during compile-on-load when the BPCM is not enabled. Change 3406565 on 2017/04/24 by Dan.Oconnor Make sure all interface functions are added to skeleton #jira UE-44152 Change 3407489 on 2017/04/25 by Ben.Zeigler #jira UE-44317 Fix game-only TickableGameObjects to correctly tick in PIE Change 3407558 on 2017/04/25 by Ben.Zeigler Fix Fortnite cook warnings, issue had to do with the CDO being registered as a Primary Asset in conflict with the Class being registered Fix issue with renaming a BP primary asset not finding the old name Change 3407701 on 2017/04/25 by Dan.Oconnor Remove unneeded null check, static analysis doen't like the inconsistency Change 3407995 on 2017/04/25 by Marc.Audy Fixed maps and sets not working correctly with split pin. #jira UE-43857 Change 3408124 on 2017/04/25 by Ben.Zeigler #jira UE-39586 Change it so the blueprint String/Name/Object to Text node creates culture invariant text, and also have them show as an expanded node with a comment explaining this Fix Transform to actually return in the format specified in the comment, and fix comments on many text conversions Change 3408134 on 2017/04/25 by Marc.Audy Graph pin container type now represented by an enumeration (EPinContainerType) rather than 3 "independent" booleans. FEdGraphPinType constructor, UEdGraphNode::CreatePin, and FKismetCompilerContext::SpawnInternalVariable that took 3 booleans deprecated and replaced with a version that takes EPinContainerType. UEdGraphNode::CreatePin parameters reorganized so that PinName is before ContainerType and bIsReference, which default to None and false respectively Change 3408256 on 2017/04/25 by Michael.Noland Core: Changed UClass::ClassFlags to be of type EClassFlags for improved type safety Change 3408282 on 2017/04/25 by Marc.Audy (4.16) Fix incorrect positioning of instance components after duplication #jira UE-44314 Change 3408404 on 2017/04/25 by Mike.Beach Adding and removing the nativized plugin to/from the project when we alter the packaging nativization setting (so it gets picked up by project generation). Change 3408445 on 2017/04/25 by Marc.Audy Fix up missed deprecation cases #rnx Change 3409354 on 2017/04/26 by Marc.Audy Fix Linux CIS failure #rnx Change 3409487 on 2017/04/26 by Marc.Audy When dragging assets in to the SCS create them as siblings, not nested #jira UE-43041 Change 3409776 on 2017/04/26 by Ben.Zeigler #jira UE-44401 Fix issue with cooking a map containing a reparented component. In that case the child component may think it's not editor only, but it's archetype is editor only. This is not allowed in EDL, so now the child is marked as editor only as well Change 3410168 on 2017/04/26 by Dan.Oconnor Avoid calling virtual functions in the middle of compile #jira UE-44243 Change 3410252 on 2017/04/26 by Lukasz.Furman adjusted WITH_GAMEPLAY_DEBUGGER checks after IWYU changes #ue4 Change 3410385 on 2017/04/26 by Marc.Audy ChildActorComponent SetClass no longer fails when setting at runtime. #jira UE-43356 Change 3410466 on 2017/04/26 by Michael.Noland Core: Ensuring EClassFlags is 32 bit in a different way (underlying type of the enum is coming out signed even though all members are unsigned, long term fix is probably to move it to an enum class) #rnx Change 3410476 on 2017/04/26 by Michael.Noland Automation: Deleting some commented out methods #rnx Change 3411070 on 2017/04/27 by Marc.Audy Properly complete deprecation of old attachment API Change 3411338 on 2017/04/27 by mason.seay Map for Latent Action Tick Bug Change 3411637 on 2017/04/27 by Ben.Zeigler Back out CL #3381532 as it was causing crashes when adding new variables to blueprints, as the transaction array was being recursively modified while it was being added to Change 3412052 on 2017/04/27 by mason.seay Updated jump test map and pawn Change 3412231 on 2017/04/27 by Ben.Zeigler Fix issue where running SearchAllAssets multiple times after mounting new paths would throw away the asset registry cache, which slowed down incremental cooking substantially because the cooker mounts the autosave folder Duplicate of CL #3411860 Change 3412233 on 2017/04/27 by Ben.Zeigler Made FStreamableHandle::GetLoadedCount much faster by taking advantage of existing progress counter Duplicate of CL #3411778 Change 3412235 on 2017/04/27 by Ben.Zeigler Add code to FStringAssetReferenceThreadContext and FStringAssetReferenceSerializationScope which allows setting package name and collect options for string asset references serialized via something other than linker load Make RedirectCollector threadsafe to avoid issues with async loading asset references Fix it so ProcessStringAssetReferencePackageList will remove entries from the string asset array like resolve did, and rename function to indicate that Fix it so string asset references created by asset labels do not automatically get cooked, and significantly improve the speed of labels with lots of assets Add code to cooker and asset manager to explicitly mark non-cookable assets as NeverVook, this stops labels from ending up in the build if set that way Added option to not recurse package dependency changes more than one level when hashes change. This ended up not being significantly faster in a realistic case so left disabled Duplicate of CL #3412080 Change 3412352 on 2017/04/27 by Marc.Audy Refix lighting getting wrong position when getting component instance data Change 3412426 on 2017/04/27 by Marc.Audy Take first steps to making ComponentToWorld private and force use of accessor Make bWorldToComponentUpdated private Make ComponentToWorld and bWorldToComponentUpdated mutable Add a SetComponentToWorld function for the (likely ill-advised) places that were setting it directly. Change 3412468 on 2017/04/27 by Marc.Audy Remove last remnants of deprecated (4.11) custom location system Change 3413398 on 2017/04/28 by Marc.Audy Fix up missed deprecated attachment API uses Change 3413403 on 2017/04/28 by Marc.Audy Fix Orion compile error #rnx Change 3413448 on 2017/04/28 by Marc.Audy Fix up kite demo component to world privataization warnings #rnx Change 3413792 on 2017/04/28 by Ben.Zeigler Fix many bugs with blueprint pin default values, and add "Reset to Default Value" option to pin context menu Deprecate and rename SetPinDefaultValue because it actually sets the Autogenerated default. This was being called in bad places and destroying the stored autogenerated defaults #jira UE-40101 Fix expose on spawn pins to correctly update when the spawned object's defaults change #jira UE-21642 Fix struct pin default values to properly update when the struct is changed #jira UE-39418 Fix changed function/macro default values to properly update in already placed call nodes Change 3413839 on 2017/04/28 by samuel.proctor Added some Blueprint focused tests for TM-Gameplay Change 3414030 on 2017/04/28 by Ben.Zeigler Enable use of AssetPtr variables with Config, for native and blueprint This incorporates CL #3302487 but also enables for blueprint usage as that code is new to framework branch Change 3414229 on 2017/04/28 by Marc.Audy Fixup virtuals not calling their Super Remove some autos #rnx Change 3414451 on 2017/04/28 by Lukasz.Furman static analysis fix for gameplay debugger Change 3414482 on 2017/04/28 by Ben.Zeigler Fix crash found where changing pin type on ConvertAsset accessed an array while deleting it Change 3414609 on 2017/04/28 by Ben.Zeigler #jira UE-18146 Refresh graph when disconnecting a resolve asset id node Change 3415852 on 2017/05/01 by Marc.Audy Remove unused code #rnx Change 3415856 on 2017/05/01 by Marc.Audy auto removal #rnx Change 3415858 on 2017/05/01 by Marc.Audy Fix function taking an input as reference when unneeded and causing (still unclear why it suddenly started showing up) error in cooking #rnx Change 3415946 on 2017/05/01 by Marc.Audy Have K2Node_StructOperation skip the K2Node_Variable validation as it doesn't need a property (per CL# 1756451) #rnx Change 3415988 on 2017/05/01 by Lukasz.Furman renamed WorldContext param in AI related static blueprint functions to remove load/cook warnings #jira UE-44544 Change 3416030 on 2017/05/01 by Ben.Zeigler Fix issue with WorldContext pins being broken by my pin value refactor, partial paths like "WorldContext" need to be stored as strings and not as broken object references. Change 3416230 on 2017/05/01 by Marc.Audy Fix spelling error #rnx Change 3416419 on 2017/05/01 by Phillip.Kavan #jira UE-44213 - Nativizing a Blueprint class with a non-nativized Blueprint class subobject dependency will no longer lead to a crash at load time. Change summary: - Modified the FFakeImportTableHelper ctor to inject subobject CDOs into the 'SerializeBeforeCreateCDODependencies' array. This in turn ensures that EDL will serialize those subobject CDOs (if necessary) before we create the subobject's nativized owner's CDO at load time. - Modified FEmitDefaultValueHelper::GenerateCustomDynamicClassInitialization() to emit MiscConvertedSubobject instantiations AFTER we emit the FillUsedAssetsInDynamicClass() call. This is now consistent with the code emitted for other subobjects (all of which assumes that the UsedAssets array has been initialized). - Modified FFindAssetsToInclude::HandleObjectReference() to add UField owner CDOs in addition to the owner class to the asset dependency list. This ensures that owner CDOs will be emitted alongside the class to both the nativized asset dependency table as well as to the fake import table associated with the UDynamicClass linker for the nativized BP asset. Change 3416425 on 2017/05/01 by Phillip.Kavan #jira UE-44219 - Nativizing a Blueprint class with a nativized DOBP class dependency will no longer lead to a compile error at cook/nativization time. - Modified the FGatherConvertedClassDependencies ctor to properly handle DOBPs in exclusive mode that have been explicitly enabled for nativization. Previously, this code wasn't taking that possibility into account, and as a result could lead to a missing header file in a dependent nativized class body's include set. - Modified FGatherConvertedClassDependencies::GetFirstNativeOrConvertedClass() to remove the 'bExcludeBPDataOnly' parameter, as it was primarily just being used for a redundant exclusion check when called from the FGatherConvertedClassDependencies ctor. That call site has now been modified to start searching from the super class instead. Additionally, any DOBPs will already fail the preceding WillClassBeConverted() check if they have not been explicitly enabled for nativization in exclusive mode, and will always fail if nativizing in inclusive mode. The extra check was breaking the explicitly-enabled case, so it was removed to allow explicitly-enabled DOBPs to pass. Notes: - Allowing for explicitly-enabled DOBPs in exclusive mode may be removed in a future change, but since it is currently supported, the changes noted above will at least ensure that the generated code will compile properly for now. Change 3416570 on 2017/05/01 by mason.seay Added UMG test to map. Tweaked force feedback test Change 3416580 on 2017/05/01 by mason.seay Resubmitting sub levels Change 3416597 on 2017/05/01 by Dan.Oconnor Compilation manager iteration, adds machinery for individual blueprint compilation, adds comments, cleans up duplicated code Change 3416636 on 2017/05/01 by Phillip.Kavan #jira UE-44505 - Potential fix for a low-repro crash tied to the Blueprint graph context menu. Change summary: - Switched FBlueprintActionInfo::ActionOwner to be a weak object reference. Change 3416960 on 2017/05/01 by Dan.Oconnor Use compilation manager when clicking the compile button, PIE'ing, etc Change 3417207 on 2017/05/01 by Ben.Zeigler Fix issue with None strings causing default value parsing failures Add SetPinDefaultValueAtConstruction needed by some other changes Change 3417519 on 2017/05/01 by Ben.Zeigler Fix BP compile errors caused by local variables with invalid default values. There's no reason to set autogenerated here because the nodes are transient and invisible in the UI. There is still a problem here, local variables are not getting their default values validated when type is changed, so you end up with an integer that has the default value of a struct. Change 3418659 on 2017/05/02 by Ben.Zeigler #jira UE-44534 Fix it so animation node pins get properly created autogenerated default values that are based on the node struct defaults. This fixes issues when they are reset to other defaults #jira UE-44532 Fix it so connecting an animation asset pin on a node player resets the pin value to the autogenerated default instead of the cached asset. This was causing old unused assets to get unnecessarily cooked Fix it so any animation node with an exposed pin that is an object property will reset that object propery when the pin is exposed. This fixes UE-31015 in a generic way Change the OptionalPinManager to take a Defaults address as well as a current address, to allow setting autogenerated defaults properly Remove Import/ExportKismetDefaultValueToProperty as they were redundant with PropertyValueFromString and were using the wrong pin setting functions, replaced with PropertyValueFromString_Direct and calling the schema pin set functions I need to write some backward compatibility code to fix existing nodes, I'll do that in a later checkin Change 3418700 on 2017/05/02 by Ben.Zeigler Actually fix None object paths for real this time. I did not test sufficiently before Change 3418811 on 2017/05/02 by Ben.Zeigler Fix existing animation blueprint nodes with dead asset references duplicated by pins. This code can be applied independent of the other change to fix specific games Change 3419165 on 2017/05/02 by Dan.Oconnor Add misc. functionality from FKismetEditorUtilities::CompileBlueprint Change 3419202 on 2017/05/02 by Marc.Audy Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3417825 #rnx Change 3419236 on 2017/05/02 by mason.seay Removed OnPressed event from Widget BP Change 3419314 on 2017/05/02 by Marc.Audy Fix bad auto-resolve #rnx Change 3419524 on 2017/05/02 by Marc.Audy PR #3528: Improved Input BP library node display names (Contributed by projectgheist) #jira UE-44587 #rn Improved Input BP library node display names Change 3419570 on 2017/05/02 by Zak.Middleton #ue4 - Fix typo in TFunctionRef comment/example. Change 3419709 on 2017/05/02 by Dan.Oconnor Fix missing category metadata on SkeletonGeneratedClass when using compilation manager Change 3419756 on 2017/05/02 by Dan.Oconnor Remove unintentional verbosity increase Change 3420875 on 2017/05/03 by Marc.Audy Make IsExecPin static Minor optimization to IsMetaPin #rnx Change 3420981 on 2017/05/03 by Marc.Audy Change tagging temporarily until other changes are done so that we don't have warnings in the meantime #rnx Change 3421367 on 2017/05/03 by Marc.Audy Manually introduce changes from CL# 3398673 in 4.16 that failed to make it to Dev-Framework as a result of the integration submitted as CL# 3401725. #rnx Change 3421685 on 2017/05/03 by Ben.Zeigler #jira UE-23001 Convert literal Asset ID/Class ID pins to store path as string instead of as hard object reference. Old pins are fixed on load, after resaving the hard references will go away Refactor the way that FStringAssetReference and FAssetPtr are serialized, it now does the various fixups in FStringAssetReference::SerializePath, which is called from archivers Change it so the asset registry reads in a list of all scanned redirectors and adds them to GRedirectCollector, this means that saving a string asset reference will automatically fix it up to point to the redirector destination Change the default behavior of FAssetPtr serialize on ArchiveUObject to match what most of it's children want, and remove several special case hacks. It now serializes as asset reference when saving/loading, and as object for other cases Deprecate StringAssetReferenceLoaded/StringAssetReferenceSaving delegates, replace with PreSavePath and PostLoadPath on FStringAssetReference Make AssetLongPathname private on FStringAssetReference, it was deprecated in 4.9 Change 3421728 on 2017/05/03 by Phillip.Kavan Mirror CL 3408285 from //UE4/Release-4.16. #jira UE-44124 #rnx Change 3422370 on 2017/05/03 by Dan.Oconnor Mirror 3422359 Implement UBlueprintGeneratedClass::NeedsLoadForEditorGame to match UBlueprint, also tag a class's CDO as NeedsLoadForEditorGame. This prevents us from failing to load a UBlueprint's GeneratedClass when running the editor with -server. #jira UE-44659 Change 3423192 on 2017/05/04 by Ben.Zeigler CIS Fix Change 3423305 on 2017/05/04 by Ben.Zeigler Fix "Missing opening parenthesis" warnings for Vector and Rotator the same way they were fixed for Transform Change 3423358 on 2017/05/04 by Marc.Audy Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3422809 #rnx Change 3423766 on 2017/05/04 by Ben.Zeigler #jira UE-44680 Delete some corrupted redirectors that are no longer in use Change 3423804 on 2017/05/04 by Dan.Oconnor Honor SaveIntermediateCompilerResults when using compilation manager Change 3424010 on 2017/05/04 by Marc.Audy Validate that switch string cases are unique Change 3424011 on 2017/05/04 by Marc.Audy Re-fix switch node default pin not appearing as an exec output Remove unused boolean Change 3424071 on 2017/05/04 by Ben.Zeigler Delete FixupRedirects commandlet, replace with -FixupRedirects/FixupRedirectors option on ResavePackages. This new method is much faster than the old commandlet as it uses the asset registry vs loading all packages, fixing up all redirectors in Fortnite only took about an hour vs 12+ hours the old way Removed some hacky bits in Core that only existed to support FixupRedirects Change it so the AssetRegistry listens to DirectoryWatcher callbacks in commandlets now that commandlets use the asset registry properly. This won't do anything unless you tick directory watcher the way that ResavePackages does Change 3424313 on 2017/05/04 by Dan.Oconnor Address missing property flags on SkeletonGeneratedClass when using compilation manager #jira UE-44705 Change 3424325 on 2017/05/04 by Phillip.Kavan #jira UE-44222 - Move nativized UDS implementation details into its own .cpp file in order to avoid circular dependencies. Change summary: - Modified IKismetCompilerInterface::GenerateCppCodeForStruct() to include an output parameter for CPP source and modified FKismet2CompilerModule to match the updated API. - Modified IBlueprintCompilerCppBackend::GenerateCodeFromStruct() to include an output parameter for CPP source and modified FBlueprintCompilerCppBackendBase to match the updated API. - Modified FBlueprintNativeCodeGenUtils::GenerateCppCode() to adjust the call to GenerateCppCodeForStruct() to include CPP source output. - Modified FGatherConvertedClassDependencies::DependenciesForHeader() to switch UDS property dependencies to be forward declarations rather than includes (for default value init code). - Modified FEmitDefaultValueHelper::GenerateGetDefaultValue() to emit implementation details to the 'Body' container, and adjust the header content to be a declaration only. - Modified FIncludeHeaderHelper::EmitInner() to exclude a potentially-redundant line for the module's .h file, for the case when the caller has included the base filename in the 'AlreadyIncluded' set. - Modified FEmitterLocalContext::FindGloballyMappedObject() to limit the 'TryUsedAssetsList' path to UClass conversions only (since that requires a UDynamicClass target to work). - Modified FGatherConvertedClassDependencies::DependenciesForHeader() to only include BPGC fields if they are also being converted. Eliminates an issue with missing header files in generated code. Change 3424359 on 2017/05/04 by Ben.Zeigler Fix issue where StreamableManager would break when requesting an async load that failed the first time. Because our game supports downloading assets during gameplay it's not safe to assume it will never load again. Port of CL #3424159 Change 3424367 on 2017/05/04 by Ben.Zeigler Fix some asset manager warnings to not go off in invalid cases Change 3425270 on 2017/05/05 by Marc.Audy Pack booleans/enums in UEdGraphNode and FOptionalPinFromProperty #rnx Change 3425696 on 2017/05/05 by Ben.Zeigler #jira UE-44672 Fix it so select node option pins get populated with default values properly #jira UE-43927 Fix it so select node opion pin type is correctly maintained accross node recreation, as opposed to deriving from the attached pins #jira UE-44675 Fix it to correctly refresh select node when switching from bool to integer index Change 3425833 on 2017/05/05 by Ben.Zeigler #jira UE-31749 Fix it so Undo works properly when modifying a local variable #jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value Change 3425890 on 2017/05/05 by Marc.Audy Fix Copy/Paste of child actor components losing the template #jira UE-44566 Change 3425947 on 2017/05/05 by Ben.Zeigler This was meant to be part of last checkin Change 3425959 on 2017/05/05 by Ben.Zeigler #jira UE-44692 Fix it so only the sequentially last node can be removed from a Switch On Int, and for Switch On Name stop it from removing an exec pin if it's the only non-default one Change 3425979 on 2017/05/05 by Dan.Oconnor PVS fix Change 3425985 on 2017/05/05 by Phillip.Kavan Fix an uninitialized variable. #rnx Change 3426043 on 2017/05/05 by Ben.Zeigler #jira UE-35583 Correctly refresh array node UI when connecting pins that change it away from wildcard Change 3426174 on 2017/05/05 by Zak.Middleton #ue4 - Avoid call to virtual getSimulationFilterData() to only use it when needed in PreFilter if we actually have items in the IgnoreComponents list (which is rare). The sim filter data 'word2' stores the component ID. Change 3426621 on 2017/05/05 by Phillip.Kavan #jira UE-44708 - Fix an issue that re-introduced component data loss in a non-nativized child Blueprint class with a nativized parent Blueprint class. Change summary: - Removed an unnecessary additional check I had for the presence of "-NativizeAssets" switch on the command line in UBlueprint::BeginCacheForCookedPlatformData(). This check was failing because the usage was recently changed to include an optional value. It was not needed anyway so I just removed it. #rnx Change 3426906 on 2017/05/05 by Ben.Zeigler #jira UE-11189 Fix function/macro input default values to show as a pin customization instead of as a broken text box that doesn't work correctly for most types. This fixes enums and provide validation for other types Types that don't have a customization (most structs) will now show any more, they did not work before either #jira UE-21754 Hide function default values if pass by reference is set Fix it so changing input parameter will also reset default value, to avoid having the wrong type value set and to work the same as local variables Change 3426941 on 2017/05/05 by Dan.Oconnor Fix determinstic cooking of LoadAssetClass nodes in macros Change 3427021 on 2017/05/05 by Dan.Oconnor Build fix, make initialization order in source match artifact #rnx Change 3427135 on 2017/05/05 by Phillip.Kavan #jira UE-44702 - Restore code-based interface classes to Blueprint editor UI. Change summary: - Partially backed out CL# 3348513 to return to previous behavior for 4.16. The UI is no longer filtering on the __is_abstract() type trait for interface classes. - Modified FNativeClassHeaderGenerator::ExportClassFromSourceFileInner() to emit the _getUObject() declaration for native interface types as a default implementation that returns NULL rather than as a pure virtual declaration. #rnx Change 3427144 on 2017/05/06 by Marc.Audy Fix init order #rnx Change 3427146 on 2017/05/06 by Marc.Audy remove stray semicolon #rnx Change 3427242 on 2017/05/06 by Phillip.Kavan #jira UE-44744 - Fix a regression in which a UMG Widget Blueprint property not explicitly marked as a variable would cause Blueprint nativization to fail at package time. Change summary: - Modified FWidgetBlueprintCompiler::CreateClassVariablesFromBlueprint() to only add 'Category' metadata when we set the 'CPF_BlueprintVisible' flag on the UProperty, which in is now tied to whether or not the property has been explcitly marked as a variable. This avoids a UHT warning when compiling the nativized codegen that would cause packaging to fail. #rnx Change 3427720 on 2017/05/08 by Dan.Oconnor Backing out 3419202 #rnx Change 3427725 on 2017/05/08 by Dan.Oconnor SA fix #rnx Change 3427734 on 2017/05/08 by Dan.Oconnor More exhaustive GEditor null checks, to appease SA #rnx Change 3427882 on 2017/05/08 by Marc.Audy Properly order all booleans in intialization #rnx Change 3428049 on 2017/05/08 by Marc.Audy Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3427804 #rnx Change 3428523 on 2017/05/08 by Ben.Zeigler #jira UE-44781 Refresh function input UI when blueprint graph refreshes, needed as pins may have gone away Change 3428563 on 2017/05/08 by Ben.Zeigler #jira UE-44783 If setting a hard reference pin type from a string, load the referenced object. Change 3428595 on 2017/05/08 by Dan.Oconnor Avoid node reconstruction when we're compiling a blueprint with no linker (e.g., a duplicated blueprint) #jira UE-44777 Change 3428599 on 2017/05/08 by Ben.Zeigler #jira UE-44789 Fix string asset renamer to not mark IsPersistent becuase that crashes in lightmap code, change it so the path fixup doesn't require the persistent flag Change 3428609 on 2017/05/08 by Dan.Oconnor Improved fix for UE-44777 #jira UE-44777 #rnx Change 3429176 on 2017/05/08 by Phillip.Kavan #jira UE-44755 - Fix nativization build errors when packaging a game project that is not IWYU-compliant for a build target that disables PCH files. - Mirrored from //UE4/Release-4.16 (CL# 3429030). #rnx Change 3429198 on 2017/05/08 by Phillip.Kavan CIS fix. #rnx Change 3429583 on 2017/05/08 by Ben.Zeigler Fix SGraphPinClass to work properly after my changes to allow unloaded assets. For Class pins we need to store separate Runtime and Editor asset data objects, as one has _C and refers to the class, and the other doesn't and refers to the blueprint. The content browser wants the editor path, the pin defaults want the runtime path. Change default value widgets to look more like properties widgets by forcing them to act as highlighted and disabling black background Change 3429640 on 2017/05/08 by Marc.Audy Fix issues with select nodes in macros connected to wildcard pins. #jira UE-44799 #rnx Change 3429890 on 2017/05/08 by Ben.Zeigler Fix function/macro defaults to properly propagate when changed using the new edit UI Refactor some code out of the details customization into the k2 schema Disable defaults UI for object/class/interface hard references as it is disabled in KismetCompiler Change 3429947 on 2017/05/08 by Michael.Noland Core: Backing out CL# 3394352 (marking FDateTime and FTimespan nonexport member Tick with UPROPERTY()), which will re-break UE-39921 but fix UE-44418 There appears to be a more serious underlying issue with how the CDO is instanced which needs to be addressed #jira UE-44418 #reimplementing 3411681 from Release 4.16 Change 3429987 on 2017/05/08 by Ben.Zeigler #jira UE-44798 Do a better job of validating object paths saved as default values, due to an old bug with local variables some object paths are saved as struct exportext At load time clear invalid default value for local variables Add IsValidObjectPath to FPackageName that validates the passed in path would be valid to load with LoadObject Change 3430392 on 2017/05/09 by Marc.Audy Fix SA CIS error #rnx Change 3430747 on 2017/05/09 by Ben.Zeigler #jira UE-44836 Don't reconstruct node during callback for param value changing, this can happen during a reconstruction and recursive reconstruction is unsafe Don't call ModifyUserDefinedPinDefaultValue unless the default value has actually changed Change 3431027 on 2017/05/09 by Marc.Audy Fix BPRW mark up causing Ocean warnings #rnx Change 3431353 on 2017/05/09 by Marc.Audy Fix UHT error due to exposing FJsonObjectWrapper to blueprints #rnx [CL 3431398 by Marc Audy in Main branch]
2017-05-09 17:15:32 -04:00
TempCmdLine += "-Messaging -Windowed ";
}
else
{
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3271386) #lockdown Nick.Penwarden Change 3270776 on 2017/01/24 by Laurent.Delayen Fixed missing call to CacheBones in AnimNode_SubInstance. Fixes Mudang crash. #c0der3view benn.ghallager, lina.halper #tests does not crash #rb none Change 3270483 on 2017/01/24 by Shaun.Kime Removing the ensure and making it behave safely whenever the scene count is out of sync. Since Paragon isn't using the primary driving feature of MaterialParameterCollections in the UI that required this feature, Nick Darnell and I deemed this okay. #jira OR-34919 #rb nick.darnell #tests PIE and golden path Change 3270067 on 2017/01/24 by Laurent.Delayen Fixed crash when recompiling Mudang's AnimBP. (SubInstances array holding null references) #rb benn.ghallager #tests doesn not crash Change 3269760 on 2017/01/24 by Daniel.Lamb Added more files to inisettings blacklist. #rb Trivial #test cook paragon. Change 3269578 on 2017/01/24 by jason.bestimt #ORION_MAIN - Merge 37.2 @ CL 3269468 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3269570 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) #R0BOMERGE-SAYS: Unresolved conflicts. jason.bestimt, please merge this change by hand. //R0BOMERGE_ORION_Dev_General/OrionGame/Content/Characters/Heroes/Grux/Abilities/Stampede/GA_Grux_Stampede.uasset //R0BOMERGE_ORION_Dev_General/OrionGame/Content/Characters/Heroes/Ice/Icons/Minimap_char_portrait_Ice.uasset //R0BOMERGE_ORION_Dev_General/OrionGame/Content/Characters/Heroes/Ice/Icons/PORT_Ice.uasset #c0der3view: jason.bestimt Change 3269141 on 2017/01/23 by Mieszko.Zielinski TSimpleCellGrid::InvalidCell refactor to avoid it being a static member variable #UE4 #rb Lukasz.Furman #test golden path Change 3268953 on 2017/01/23 by Jason.Bestimt #ORION_DG - R0BOMERGE resolution from MAIN to DG of compile fix and banner stuff #RB:none #Tests:none #c0der3view: matt.schembari, andrew.grant Change 3268576 on 2017/01/23 by John.Pollard Add DemoNetDriver to the level collection earlier to remove small window where World->DemoNetDriver could be null as a result of FScopedLevelCollectionContextSwitch #rb RyanG #tests Live game play + replays + instant replay Change 3268119 on 2017/01/23 by Daniel.Lamb Added support for splitting up chunks into maximum sizes. #rb Andrew.Grant #test Cook paragon ps4 windows windowserver Change 3268020 on 2017/01/23 by Dan.Hertzka Moving TreeFilterHandler.h out into Slate/Public via branch & delete #c0der3view Nick.Darnell #rb none #tests compile Change 3267820 on 2017/01/23 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 37.2 @ CL 3267733 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3267817 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3266798 on 2017/01/20 by Daniel.Lamb Make the diff files commandlet more helpful. #rb Trivial #test Diff files commandlet. Change 3266795 on 2017/01/20 by Daniel.Lamb Fixed issue with Cooked packages trying to load dependencies from a dependency offset which is incorrect. #rb Gil.Gribb #c0der3view Gil.Gribb #test Load cooked packages using the editor. Change 3266310 on 2017/01/20 by Daniel.Lamb Fixed issue with cook ont he fly not resolving string asset reference redirectors on load. Added fastcook to the iterative cook detection. #rb Jamie.Dale #test Cook Paragon Change 3265879 on 2017/01/20 by Jon.Lietz fixing PS4 compile error #rb none #tests compiles #c0der3view andrew.grant Change 3265756 on 2017/01/20 by Jon.Lietz quest evaluator - added in an ability type that will evaluate in game events and increments player stats for quests, these abilities can be granted by quests or the hero data - added support to the ability system to have ability specs not replicated to the client, this will allow for passive only abillities for quest evaluation to only live and exicute on the dedicated server - now support loading in data for quest info asynchronously - orion quests can now grant evaluator abilities to the players that own the quests - AOrionPlayerState_Game::GiveAbilityData() now grabs all the abilities from active quests - at the end of the match unload any data loaded by the quests #RB david.ratti #test granting abilities Change 3265658 on 2017/01/20 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 37 @ CL 3265610 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3265627 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3265530 on 2017/01/20 by Robert.Manuszewski Making sure all package dependencies are loaded before post loading its objects #jira OR-34891 #tests Golden path x 12 #rb none Change 3265126 on 2017/01/19 by Frank.Gigliotti Notifies for abilities waiting on input confirmation; * Ability tasks waiting for input confirmation will now notify the ability when it begins and ends waiting. #RB Dave.Ratti #Tests PIE Change 3264489 on 2017/01/19 by Jason.Bestimt #R0BOMERGE-AUTHOR: andrew.grant Merged fix from 36.2. #rb #tests na #R0BOMERGE-SOURCE: CL 3264488 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3263948 on 2017/01/19 by Andrew.Grant Non-unity fixes. #tests compiled WIn64 editor #rb na #R0BOMERGE: Main, 37 Change 3263755 on 2017/01/19 by Laurent.Delayen OR-34970 FRootMotionSource_ConstantForce now has DisablePartialEndTick set, so we end up with a consistent velocity when the root motion ends. Added VelocityOnFinishMode to UAbilityTask_ApplyRootMotionConstantForce so we can optionally override or clamp velocity. CVarDebugRootMotionSources now displays Velocity and LastPreAdditiveVelocity on HUD to help debugging RootMotionSources. #rb frank.gigliotti #tests Ice Q Change 3263616 on 2017/01/19 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 37 @ CL 3263608 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3263613 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3262543 on 2017/01/18 by Eric.Newman Added GetAttributeSetValues feature to Ability System. Allows for pulling attribute rows without needing an Actor or AbilitySystemComponent #rb david.ratti #c0der3view david.ratti #tests used to export paragon hero attributes #jira TON-25429 Change 3262414 on 2017/01/18 by Laurent.Delayen Fixed crash opening up Ice's AnimBP. #rb lina.halper #c0der3view thomas.sarkanen #tests opening up AnimBP doesn't crash anymore. Change 3262291 on 2017/01/18 by Ryan.Gerleve Cache the network role of AbilitySystemComponents in PreNetReceive, to make sure the role is correct during serialization if properties are received before BeginPlay. Factor out the caching into its own function to reduce code duplication. #rb david.ratti #tests golden path, bug repro #jira OR-31424 Change 3262062 on 2017/01/18 by Max.Chen Sequencer: Fixed crash caused by lingering persistent evaluation data Copy from Release-4.15 #jira UE-40775 #rb andrew.rodham #tests none Change 3262061 on 2017/01/18 by Max.Chen Sequencer: Evaluation templates are now only fully rebuilt in PIE, and will not re-cycle track identifiers - This addresses issues with newly compiled tracks recycling the persistent data of old stale tracks. - This commit also ensures we don't fully rebuild templates in the editor when in Sequencer Copy from Release-4.15 #jira UE-40775 #rb andrew.rodham #tests none Change 3261946 on 2017/01/18 by Jason.Bestimt #ORION_DG - Fix for event tracks in sequencer #RB:none #Tests:none #R0BOMERGE: MAIN #c0der3view: Max.Chen, andrew.rodham, scott.james Change 3261812 on 2017/01/18 by Mieszko.Zielinski Made bos' perception component vlog information #Orion #rb Lukasz.Furman #test golden path Change 3261731 on 2017/01/18 by Benn.Gallagher Readded fix to clothing index buffer overflow (lost in merge a while back) #tests Editor, assigned clothing to skel mesh #rb Tom.Sarkanen Change 3261730 on 2017/01/18 by Robert.Manuszewski Build script sdk upgrade #rb none #tests Ran the script that was upgraded Change 3261392 on 2017/01/17 by Jason.Bestimt #R0BOMERGE-AUTHOR: andrew.grant non-unity fix #rb none #tests compiled #R0BOMERGE-SOURCE: CL 3261391 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3261096 on 2017/01/17 by Laurent.Delayen OR-33666 Removed 'bImpartsVelocityOnRemoval' for additive root motion sources, as that can create a 'bouncing' effect when Velocity is modified externally. #rb frank.gigliotti #tests Preflight QA test https://jira.it.epicgames.net/browse/PQATC-8713 Change 3261030 on 2017/01/17 by Laurent.Delayen Fix crash in Persona. #rb none #tests doesn't crash Change 3260561 on 2017/01/17 by Jason.Bestimt #R0BOMERGE-AUTHOR: andrew.grant Merging Fix from UE 4.15 Look at the body instance's desired collision enabled value rather than the primitive component's current collision enabled value when determining whether physics state should be created #rb Ori.Cohen #jira UE-39994 #tests na #R0BOMERGE-SOURCE: CL 3260557 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3260553 on 2017/01/17 by Ryan.Gerleve Change cvar in UDemoNetDriver::ShouldSaveCheckpoint to use GetValueOnAnyThread. Fixes OR-34759. #rb john.pollard #tests bug repro, golden path Change 3260202 on 2017/01/17 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 37/36.2 @ CL 3260077 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3260201 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3259560 on 2017/01/16 by Marcus.Wassmer Fix reflections #rb none #c0der3view Brian.Karis #tests added some reflections Change 3259348 on 2017/01/16 by Daniel.Lamb Moved automation maps from alwayscookmaps to AllAutomationMaps. #rb Andrew.Grant #test Cook Paragon + Fast Cook Paragon + Preflight Cook Paragon Change 3259113 on 2017/01/16 by Jason.Bestimt #R0BOMERGE-AUTHOR: andrew.grant #ORION_MAIN - Merge 36.2 @ CL 3258788 #RB:none #Tests:compiled Win64 editor #R0BOMERGE-SOURCE: CL 3258986 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3259090 on 2017/01/16 by Chris.Bunner Duplicating CL 3246830: Allow AllocGBuffer call when in simple-forward so dummy uniform buffer creation can occur. #rb None #tests Editor, -game, epic and min settings Change 3258910 on 2017/01/16 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - DAILY DG @ CL 3258854 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3258871 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3258807 on 2017/01/16 by Rolando.Caloca O - Fix for outlines #rb Chris.Bunner #tests Ran sovereign2 game #c0der3view Andrew.Grant Change 3258637 on 2017/01/16 by Charles.Anderson Removing wrongly added files (agrant) Change 3258601 on 2017/01/16 by Andrew.Grant Temp fix for rendering crash by disabling custom depth rendering #rb na #tests PIE'd Change 3258590 on 2017/01/16 by Tom.Wright One of these files are not syncing properly in my UnrealGameSync so I'm adding them manually (the .exe). Change 3258523 on 2017/01/16 by Andrew.Grant Removing intermediate build file that was checked in #rb #tests na Change 3258464 on 2017/01/16 by Andrew.Grant Fixes for non-unity #R0BOMERGE: Main #tests compiled Win64 #rb na Change 3258208 on 2017/01/15 by Mieszko.Zielinski FMetaNavMeshPath's Waypoints have been expanded to store user flags. #UE4 #rb none #test golden path Change 3258042 on 2017/01/14 by andrew.grant Merging test framework changes from //Orion/Release-36.2 to Main (//Orion/Main) #rb #tests preflighted #R0BOMERGE-SOURCE: CL 3258036 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) #R0BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human. //R0BOMERGE_ORION_Dev_General/OrionGame/Build/OrionBuild.xml #c0der3view: andrew.grant, jason.bestimt Change 3258035 on 2017/01/14 by Andrew.Grant Disable MfMedia plugin by default Change 3257936 on 2017/01/14 by Andrew.Grant Merging from //UE4/Main @ 3253977 through Orion-Staging #rb na #tests QA smoke in staging, built locally, preflighted Change 3257583 on 2017/01/13 by Daniel.Lamb Removed nomcp from the commandline when running on PC #rb Trivial #test Buildcookrun paragon windows Change 3257320 on 2017/01/13 by Cody.Haskell #Orion - Ansel Integration into Replay Mode - Updated Ansel SDK - Bug Fix for Ansel plugin - Made it not look terrible when you pause the game in regular replay mode #rb Andrew #r3view-3256093 @andrew.grant #tests Golden Path, compiles on PS4 #lockdown Andrew.Grant Change 3257239 on 2017/01/13 by Frank.Gigliotti ApplyRootMotionJumpForce end velocity options; * "ApplyRootMotionJumpForce" task now supports setting the end velocity. * Moved root motion end velocity options from the individual tasks into the base class. * Fixed a property on UAbilityTask_ApplyRootMotionConstantForce not replicating properly. #RB None #Tests PIE Change 3256173 on 2017/01/12 by Laurent.Delayen Added additional debug message to ShowResaveMessage. #rb lina.halper #test loaded broken Femme assets. Change 3256082 on 2017/01/12 by Andrew.Grant Temp fix for BuildHealth warning. Following up with BP team #rb none #tests verifierd compile warnings are gone Change 3255991 on 2017/01/12 by Ben.Woodhouse Cherry pick NV gpu hang fix from //ue4/release-4.14 @3238182 Disable timestamp queries on pre-Maxwell nvidia hardware. Local testing suggests that this is the major cause of instability in the UE4.14 release. It's possible that we could be more targeted by only excluding Fermi and older hardware, but identifying fermi hardware by device ID is difficult in practice, since the range overlaps with Kepler. #jira OR-22580 #rb none (r3viewed for 4.14 by Marcus Wassmer) #tests run locally on PC (change is windows-specific) Change 3255185 on 2017/01/12 by John.Nielson Made it so that PS4 compiles without warning from misordered initialization. #RB: r3view #r3view-3255186: Andrew.Grant #Test: None Change 3254885 on 2017/01/11 by Michael.Trepka CIS fix #rb none #tests none Change 3254568 on 2017/01/11 by Andrew.Grant Merging relay fix from //Orion/Release-36.2 to Dev-General (//Orion/Dev-General) #rb #tests na Change 3254544 on 2017/01/11 by Jason.Bestimt #R0BOMERGE-AUTHOR: andrew.grant Robomerging previous fix to Dev-Gen #rb #tests na #R0BOMERGE-SOURCE: CL 3254532 in //Orion/Release-36.1/... via CL 3254537 via CL 3254540 #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3254204 on 2017/01/11 by Michael.Trepka Added title bar area to the game layer manager, so that games can easily setup custom title bar content when using borderless windows. Disabled/hidden by default #rb none #tests Tested in editor build on PC Change 3254074 on 2017/01/11 by Ryan.Gerleve Fix for gameplay tags not being recorded in client replays. #rb david.ratti #tests golden path, replays Change 3254035 on 2017/01/11 by Laurent.Delayen OR-28756 Added WaitForMovementInput Ability Task to use with Emote ability. #rb dave.ratti, frank.gigliotti #tests Kallari's emotes Change 3253736 on 2017/01/11 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 36.2 @ CL 3253668 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3253715 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3252981 on 2017/01/10 by Daniel.Lamb Added async load package delegate. #rb Trivial #test BuildCookRun Paragon with local server Change 3252975 on 2017/01/10 by Daniel.Lamb Added EditorPerProjectUserSettings to the ignore config field for iterative cooking #rb None #test cook paragon. Change 3252784 on 2017/01/10 by Daniel.Lamb Integrated fix for rebuild lighting commandlet from Greg Korman @ Impulse Gear. #rb Daniel.Lamb #test Rebuild lighting Paragon Change 3252460 on 2017/01/10 by Aaron.Eady #jira UE-40390 Fix crash saving blueprint with an inherited DataTable/CurveTable reference. Delta serialization meant that the necessary name wasn't in the name table, so adding it manually now. #rb robert.manuszewski Copied from CL #3252418 Written by Ben.Zeigler #c0der3view Ben.Zeigler, David.Ratti, Andrew.Grant #tests PIE Change 3252222 on 2017/01/10 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 36.2 @ CL 3252019 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3252221 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3251379 on 2017/01/09 by Ori.Cohen Fix build #rb none #tests none Change 3251242 on 2017/01/09 by buildmachine BuildPhysX.Automation: Deploying PhysX & APEX Win64 libs. #rb none #lockdown Nick.Penwarden #tests none Change 3251240 on 2017/01/09 by buildmachine BuildPhysX.Automation: Deploying PhysX & APEX Win32 libs. #rb none #lockdown Nick.Penwarden #tests none Change 3251224 on 2017/01/09 by buildmachine BuildPhysX.Automation: Deploying PhysX & APEX Linux_x86_64-unknown-linux-gnu libs. #rb none #lockdown Nick.Penwarden #tests none Change 3251220 on 2017/01/09 by buildmachine BuildPhysX.Automation: Deploying PhysX & APEX PS4 libs. #rb none #lockdown Nick.Penwarden #tests none Change 3251206 on 2017/01/09 by Ori.Cohen Add logging to possible physx infinite loop. #JIRA OR-32515 #rb Dave.Ratti #tests none Change 3250847 on 2017/01/09 by Daniel.Lamb Added excution time stat to unrealpak. #rb Trivial #test BuildCookRun Paragon with timing info. Change 3250761 on 2017/01/09 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 36.2 @ CL 3250717 #RB: none #Tests:none #R0BOMERGE-SOURCE: CL 3250759 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3249410 on 2017/01/06 by Chris.Bunner Duplicating CL 3249213: Fixed up logic for windowed/fullscreen output display selection when working with HDR. Now selects the most appropriate display if HDR enabled, else current monitor window is on. FullscreenDisplay commandline functions regardless of HDR support. #rb None #tests -game windowed/fullscreen behavior Change 3249285 on 2017/01/06 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 36.2 @ CL 3249117 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3249278 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3247989 on 2017/01/05 by Dan.Hertzka Re-adding the null checks from CL 3247771 in Release-36 (the R0BOMERGEd submit didn't include these for some reason) #c0der3view Andrew.Grant #rb none #tests Compiled and didn't crash on editor startup #R0BOMERGE: Main Change 3247790 on 2017/01/05 by Jason.Bestimt #R0BOMERGE-AUTHOR: andrew.grant Robomerging! #tests #rb na #R0BOMERGE-SOURCE: CL 3247786 in //Orion/Release-36/... via CL 3247787 via CL 3247788 via CL 3247789 #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3247717 on 2017/01/05 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 36.2 @ CL 3247673 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3247716 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3247575 on 2017/01/05 by David.Ratti -Fix crash if GE has a null linked target GE -Change FGameplayEFfectContext::Ability to be AbilityCDO via TWeakObjectPtr rather than a TSubclass. TSubclass is not weak, so if a class was GC'd while still in a GEEC somewhere, it could crash. #rb none #tests pie Change 3247032 on 2017/01/04 by Ori.Cohen Touch engine file to re-link physx libs #JIRA OR-32839 #rb none #tests none Change 3247006 on 2017/01/04 by buildmachine BuildPhysX.Automation: Deploying PhysX & APEX PS4 libs. #rb none #lockdown Nick.Penwarden #tests none Change 3246987 on 2017/01/04 by Ori.Cohen Add newline for ps4 #rb none #tests none Change 3246986 on 2017/01/04 by buildmachine BuildPhysX.Automation: Deploying PhysX & APEX Win64 libs. #rb none #lockdown Nick.Penwarden #tests none Change 3246981 on 2017/01/04 by buildmachine BuildPhysX.Automation: Deploying PhysX & APEX Linux_x86_64-unknown-linux-gnu libs. #rb none #lockdown Nick.Penwarden #tests none Change 3246969 on 2017/01/04 by buildmachine BuildPhysX.Automation: Deploying PhysX & APEX Win32 libs. #rb none #lockdown Nick.Penwarden #tests none Change 3246921 on 2017/01/04 by Ori.Cohen Fix automation to include #tests none #rb none #tests none Change 3246900 on 2017/01/04 by Ori.Cohen Fix newline issues for ps4. #rb none #tests none Change 3246666 on 2017/01/04 by Chad.Garyet Updating physx build to include switch and linux-arm64 integrate/resolve from dev-physics-upgrade #c0der3view ori.cohen Change 3246450 on 2017/01/04 by Arciel.Rekman Fix for sweeps taking too long time (OR-32839). - Exhaustive investigation uncovered apparent numerical problems in this code (when compiling with clang 3.9.x with -ffast-math). - Current solution can result in overshoot for certain trace extents, but they are not expected to be a practical problem in Unreal. - NVidia is aware and will investigate a better solution. #rb Ori.Cohen #c0der3view Ori.Cohen #tests Compiled Linux server with the changed PhysX and continuously ran bot matches for about a day. Change 3246229 on 2017/01/04 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 36.2 @ CL 3246134 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3246204 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3245068 on 2017/01/03 by Lukasz.Furman improving obstacle grid avoidance: adjusting start location when inside obstacle, fixes for string pulling #jira OR-33318 #rb none #c0der3view Mieszko.Zielinski #tests PIE Change 3244698 on 2017/01/03 by Lukasz.Furman compilation fix: removed optimization pragmas from AISense_Sight.cpp #rb none #tests none Change 3244679 on 2017/01/03 by David.Ratti Unify linked gameplay effect spec creation: -Linked GEs -Conditional Execution GEs -Overflow GEs -Expiration GEs (premature/routine) These now create the dependant GE Spec the same way, by duplicating the original context and copying spec tags, MINUS the original GE's asset tags. Actor tags are still recaptured at the moment the spec is created. #rb Lietz #tests golden path #c0der3view Billy.Bramer, Fred.Kimberley Change 3244499 on 2017/01/02 by Mieszko.Zielinski Major AI tactics upgrade #Orion Introduction of new objective dealing algorithm (CSP inspired) Bots can now place wards Bots can now destroy wards and other appopriately marked up OrionDamagableActors (content change in following CL, allows bots to see these actors) Switched OrionAIBot.CurrentEnemy to AActor type Removed code related to Jungle Rig objectives #rb none #test golden path Change 3242918 on 2016/12/22 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 36.2 @ CL 3242890 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3242917 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3241817 on 2016/12/21 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 36.2 @ CL 3241745 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3241811 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3240916 on 2016/12/20 by Ben.Marsh Add metadata properties to jobs that create promotable artifacts and execute promotions, for consumption by the pipeline tool. Properties are added to /job[XXX]/Pipeline/Promotable-<Platform>-<Type> or /Promotion-<Platform>-<Type>. #rb none #c0der3view David.Vossel, Trevor.Pounds #tests Ran through preflight Change 3240857 on 2016/12/20 by Lina.Halper Added ensure to track marker sync crash #rb: Laurent.Delayen #code r3view: Martin.Wilson #tests: PIE with mudangs Change 3240856 on 2016/12/20 by Laurent.Delayen Potential fix for sync marker crash. #rb lina.halper #c0der3view martin.wilson, lina.halper #tests Mudang Change 3240813 on 2016/12/20 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 36.2 @ CL 3240768 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3240812 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3239624 on 2016/12/19 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 36.2 @ CL 3239590 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3239623 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3238573 on 2016/12/16 by Andrew.Grant Moved console vars to source file to avoid multiple definitions (OR-33470) #rb none #tests compiled Change 3238077 on 2016/12/16 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 36 @ CL 3238017 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3238059 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3237176 on 2016/12/15 by Laurent.Delayen Moved FloatRK4SpringInterpolator and VectorRK4Interpolator from Orion to Engine. #rb ori.cohen #c0der3view lina.halper, james.golding #tests Twinblast and Ice Change 3236911 on 2016/12/15 by Lukasz.Furman changed navgrid projection to use 2D poly search for more accurate results #orion #rb none #tests PIE Change 3236660 on 2016/12/15 by Jamie.Dale Updating Orion text block to upper-case its text in a localized way This also prevents it clobbering the text property value with the transformed text, resulting in key stability issues. #jira OR-32716 #rb Dan.Hertzka #tests Ran Orion and verified that the "all caps" text was correct, and responded to live-culture changes #R0BOMERGE: Main, Release-36 Change 3236658 on 2016/12/15 by Jamie.Dale Adding FText::ToLower and FText::ToUpper These also track history and rebuild when the text they were generated from is changed. #jira OR-32716 #rb Dan.Hertzka #tests Ran Orion and verified that the "all caps" text was correct, and responded to live-culture changes #R0BOMERGE: Main, Release-36 Change 3236501 on 2016/12/15 by Lukasz.Furman enabled navigation grid avoidance for jungle minions #jira OR-33318 #rb Mieszko.Zielinski #tests PIE Change 3236479 on 2016/12/15 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 36 @ CL 3236423 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3236474 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3236399 on 2016/12/15 by Andrew.Grant Fixed pkg warning "Patch created by newer SDK must contain sce_module files" by not excluding "libSceNpToolkit.prx" #rb none #tests none #R0BOMERGE: Main,36 Change 3236280 on 2016/12/15 by Benn.Gallagher Fixed crash when clothing cooked data is updated on a client that is not powerful enough to run multithreaded physics (2 or fewer cores) #rb Ori.Cohen #jira OR-33248 #tests - Editor + PIE, running through multiple character viewer screens in menu (as per repro), forced single threaded physics and re-ran tests Change 3235666 on 2016/12/14 by Matt.Schembari Merging 3200968 from Dev-Editor for OR-32947. #c0der3view Andrew.Grant,Arthur.Flew #tests compile ------- Fixed localization gather including texts that were instanced or otherwise unchanged - It now uses the archetype when exporting to diff against the default property value, and will only gather text that has changed from the default. - UMG widgets that are instanced from another UMG asset now only gather overridden values, and skip all child instances. #rb Nick.Darnell --------- Change 3235315 on 2016/12/14 by Adric.Worley Fix FText parse warning spam when dragging in world outliner #jira UE-29099 #tests editor #rb Matt.Kuhlenschmidt Change 3235177 on 2016/12/14 by Sam.Zamani Chat toxicity info added to every out-going party/team chat message Added optional "chat-info" XML element to XMPP chat stanzas being sent to a MUC room The chat info is added to the room's configuration via ChatInterface OSS Currently capturing playlist id, team size, and party size with each chat message OGS-479 Add extra attributes to XMPP chat messages for toxicity processing #rb: josh.markiewicz, rob.cannaday #coderview: ian.fox #tests: none Change 3235093 on 2016/12/14 by Arciel.Rekman Linux: switched PhysX/APEX debug info to DWARF3 and rebuilt the libs - Also fixed an unrelated compile error (by suppressing the warning - do not merge back to main). #rb Ori.Cohen, Andrew.Grant #c0der3view Ori.Cohen, Andrew.Grant #tests Compiled the server Change 3234913 on 2016/12/14 by Andrew.Grant Duplicated 3200382 from Dev-Core as suspected fix for OR-33328 #rb #tests na Change 3234910 on 2016/12/14 by Laurent.Delayen Added AnimNotifyState_DisableRootMotion to turn off root motion during a RootMotion Montage, and give control back to the player. #rb martin.wilson #tests Ice RootMotion Ult networked. Change 3234823 on 2016/12/14 by Lukasz.Furman added capsule support for local navigation grids #orion #rb none #tests PIE Change 3234768 on 2016/12/14 by Lukasz.Furman fixed crash in registering debug scene proxies of gameplay debugger tool #orion #rb none #tests PIE Change 3234682 on 2016/12/14 by Chad.Garyet Adding physx build to dev-general Change 3234643 on 2016/12/14 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 35.2/36 @ CL 3234401 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3234640 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3234597 on 2016/12/14 by Wes.Hunt Merging RealMoneyPurchaseComplete delegate from CatalogHelper into Orion * Hooked it up so CatalogHelper doesn't take a persistent reference to the analytics provider. Extensive refactor of Orion's AnalyticsProvider lifetime and management. * More tightly controlled provider lifetime, eliminated need to recreate the providers unnecessarily. * Made provider access functions simpler and clarified creation vs. access (no more lazy getters). * Improved handling of GameSessionIDs and UserIDs outside of match to improve data clarity for the analytics backend. Details: AnalyticsProviderET * Added Get/SetAppID APIs to allow the AppID to change without recreating the provider (needed for CompQA support, which isn't always known when the provider is created). * SetAppID and SetSessionID now flush their cached events before changing them. * SetUserID still does not Flush because we inadvertently rely on this so the UserID can be set several frames later and all events will be sent with a valid UserID. OrionAnalytics * Simplified contract for correctly creating a new provider: CreateAnalyticsProvider now takes an AccountID and GameSessionID so the provider can be fully initialized with a single call. * Exposed CreateAppID function so the places where the AppID needed to dynamically change (CompQA purposes) could use shared Orion naming conventions. * Exposed SetDefaultAttributes function so game code could share the logic for setting default attributes. * Add assert to CreateAnalyticsProvider because we never expect it to fail, and outside code doesn't have to do it. DemoNetDriver * Exposed UDemoNetDriver::GetDemoSessionID to allow analytics to set a consistent GameSessionID during replay that is NOT the game session ID of the original match, which was throwing heartbeat events for replays into the same session on the backend, if the replay was watched fast enough. OrionGameInstance * Server's analytics provider moved to GameInstance as it's lifetime is more appropriate than the GameMode. * SetUserID now works in PIE, and sets it to PIE_INSTANCE so we don't pollute our account data with random GUIDs GameInstanceCommon * When playing back a replay, use the DemoNetDriver's SessionID instead of the Game Session ID of the game being replayed. OrionGameMode_MOBA * Moved Login functionality to GameMode_Base so it will work properly in all Orion GameModes (ie, DraftLobby). OrionGameMode_Base * Removed SetAnalyticsProvider. This was confusing the interface and making it seem like providers could change dynamically (they couldn't). * GetAnalyticsProvider changed to just get it from the GameInstance where it is really stored now. OrionPlayerController_Base * Removed SetAnalyticsProvider. No external code should be changing the provider. * Exposed an explicit CreateAnalyticsProvider so GetAnalyticsProvider() no longer has to lazily create the provider. * Added some asserts on preconditions to CreateAnalyticsProvider to ensure we are not creating them at the wrong times. OrionGameSession * The Server Analytics provider now sets a UserID that is a combination of the machine name, PID, and a GUID unqiue to that run. This makes server analytics easier to trace back to servers. OrionGameState_Base * CreateGameSessionID renamed to StoreGameSessionID to better reflect that it isn't creating anything. * Remove the code that sets a random GUID for non game modes, which was just confusing the session handling code on the analytics backend. * Ensure that demo playback sets the demo session ID and not the replayed game's session ID. OrionGameStateMain * GameSessionID is always set to the empty string for non game modes. McpContext * InitAnalytics no longer needs to create the analytics provider or restart any session, etc. It just sets the new AppID (if we now know we are CompQA) and the UserID (since we just logged in). #c0der3view:john.pollard,ryan.gerleve,josh.markiewicz #rb josh.markiewicz #tests extensive runs of the game, dedicated server, menu, and match traveral, and replay watching. Also editor, PIE standalone, PIE w/ dedicated server, and nomcp configurations to ensure no crashes and the providers are created as expected, not recreated, and get the proper Session and GameSessionIDs at the expected times. #R0BOMERGE-AUTHOR: david.nikdel #CatalogHelper #Analytics: - Added a RealMoneyPurchaseComplete multicast delegate to CatalogHelper mostly intended for apps to be able to listen for this event (not as a completion delegate) and do their own analytics events. - Rolled up a bunch of the params into a struct for forward compatibility - Moved the ECom.ClientInAppPurchase code into a helper on the struct (would like to get this out of catalog helper now that the delegate is there) [c0der3viewed]: Ian.Fox, Wes.Hunt #R0BOMERGE-SOURCE: CL 3209122 in //WEX/Release-05/... via CL 3209123 #R0BOMERGE-BOT: OGS (BattleBreakers -> Main) #AUTOMERGE using branch ROBO://GamePlugins/Main->//Orion/Dev-General of change#3209125 by Jason.Bestimt on 2016/11/23 12:33:06. #R0BOMERGE-AUTHOR: david.nikdel Why does the compiler think a parameter can "hide" a non-static member from an outer class. That is most definitely not in scope... #R0BOMERGE-SOURCE: CL 3209212 in //WEX/Release-05/... via CL 3209213 #R0BOMERGE-BOT: OGS (BattleBreakers -> Main) #AUTOMERGE using branch ROBO://GamePlugins/Main->//Orion/Dev-General of change#3209214 by Jason.Bestimt on 2016/11/23 14:00:12. #R0BOMERGE-AUTHOR: david.nikdel #CatalogHelper: Change to AnalyticsProvider to shared reference [c0der3viewed]: Ian.Fox #R0BOMERGE-SOURCE: CL 3209222 in //WEX/Release-05/... via CL 3209223 #R0BOMERGE-BOT: OGS (BattleBreakers -> Main) #AUTOMERGE using branch ROBO://GamePlugins/Main->//Orion/Dev-General of change#3209225 by Jason.Bestimt on 2016/11/23 14:07:47. #R0BOMERGE-AUTHOR: wes.hunt Ensure that Heartbeat events will not clog the retry queue if the data router cannot be reached. * Renamed to Usage.Heartbeat and Context to match the more "non-gamey" naming we want to move to (also can't have WorldExplorers prefix). * Removed the Analytics provider from McpCatalogHelper and use the callback delegate instead. This removes analytics assumptions from the McpCatalog code and allows the analytics provider references to not leak outside of WExpAnalytics. This allows us to put ensures in the shutdown code to make sure it doesn't leak and sessions are closed when we expect. Also cleaned up some code that tried to work around the fact that outside code held onto a reference when trying to end the session. [c0der3viewed]:david.nikdel #jira wex-4038 #R0BOMERGE-SOURCE: CL 3209575 in //WEX/Main/WEX/Plugins/... #R0BOMERGE-BOT: OGS (BattleBreakers -> Main) #AUTOMERGE using branch ROBO://GamePlugins/Main->//Orion/Dev-General of change#3209653 by Jason.Bestimt on 2016/11/24 01:43:48. Change 3233911 on 2016/12/13 by Andrew.Grant Duplicating 3203865 from //UE4/Dev-Sequencer/... #tests #rb na Change 3233789 on 2016/12/13 by Olaf.Piesche Replicating 3233289 from Dev-Rendering - light component distance fade properties not initialized #c0der3view marcus.wassmer #rb marcus.wassmer #tests build Change 3233016 on 2016/12/13 by Ryan.Gerleve Fix for conditional properties being evaluated incorrectly when recording replay checkpoints. Fixes heroes appearing as grey boxes in deathcam and replays. #jira OR-32926 #tests golden path, deathcam, replays #rb john.pollard Change 3232909 on 2016/12/13 by Laurent.Delayen Renamed USkeletalMeshComponent::IsPlayingRootMotion() to ::IsPlayingNetworkedRootMotionMontage() to better match what the function does, and match definitions in ACharacter. (Also checks for RootMotionMode to be FromMontageOnly). Added proper IsPlayingRootMotion() to match ACharacter. Also constified these functions. #rb Martin.Wilson #tests Ice Root Motion ult Change 3232336 on 2016/12/13 by David.Ratti Spot merge async loading fix #rb Gil #tests cooked build front end store Change 3231733 on 2016/12/12 by Andrew.Grant Added code to dump out deferred engine commands when frametime is above desired #rb Michael.Noland #tests compiled, ran server #R0BOMERGE: Main Change 3231406 on 2016/12/12 by Laurent.Delayen CharacterMovementComponent: allow physics rotation to be performed during AnimRootMotion. #rb none #tests Ice Change 3230272 on 2016/12/10 by Andrew.Grant Fix for automation code being dead-stripped #rb none #tests verified automation works Change 3229976 on 2016/12/09 by Ryan.Gerleve Fix multiple UI/HUD issues during deathcam playback: No longer switch the local player's PlayerController during deathcam playback. The game player controller will now set it viewtarget to the hero in the deathcam replay. Add an option for the recording DemoNetDriver to not spawn a spectator controller at all. Clean up some hacks that were needed when the player controller did switch to make the card shop close properly. Remove other code that was related to the player controller switch. Add a deathcam camera component to hero characters and activate it during deathcam playback. Factor out the code common to the spectator chase camera and the deathcam camera into a helper struct that both camera components use. Client notifies the server when it starts and stops deathcam, so the server knows not to update the client's viewtarget for the duration. #jira OR-32433, OR-32568, OR-31299, OR-31197 #rb john.pollard, jon.lietz #tests golden path, deathcam, replays Change 3229790 on 2016/12/09 by Lina.Halper #DUPEFIX of CL 3219688 Merging using //Orion/Dev-General_to_//UE4/Dev-Framework Expected fix for cooking issue of animation #rb: Martin.Wilson #code r3view: Martin.Wilson, Laurent.Delayen #tests: none Change 3228731 on 2016/12/09 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 35.2 @ CL 3228573 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3228715 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3228602 on 2016/12/09 by Benn.Gallagher Added temporary CVar to fix broken clothing imports due to errant transposition of bone bind matrices on apx file import. This should not be integrated to main - hoping on a fix soon from Nvidia for this issue to be fully solved, this just gets our content creators back up and running while Nvidia investigates #tests Win64 Editor, importing clothing files for Twinblast and Fallen Angel #rb Lina.Halper Change 3227456 on 2016/12/08 by Andrew.Grant Stopped _BUiltData from being dirtied by autosave (copied from 3223169 in Dev-Editor) #rb #tests na Change 3227417 on 2016/12/08 by David.Ratti Fix category on gameplay tag settings #rb none #tests none Change 3227401 on 2016/12/08 by David.Ratti GameplayTag category restrictions remapping support. This allows engine properties to specify categories that can be specified/expanded by projects. Added categories for gameplayeffect tags #rb BenZ #tests editor, golden path #c0der3view Billy.Bramer, Fred.Kimberly Change 3227368 on 2016/12/08 by Uriel.Doyon Simple forward shading now disables self shadowed translucency (because it samples an invalid volumetric light buffer). #jira OR-32645 #tests Loaded editor, tested in game at different quality settings #rb daniel.wright Change 3227243 on 2016/12/08 by David.Ratti Spot integrate CL 3225990 to fix tag sorting #rb none #tests compile Change 3227029 on 2016/12/08 by Laurent.Delayen Fixed crash when creating a new Montage from scratch. #rb Lina.Halper #tests no more crashing when creating a montage from scratch Change 3226877 on 2016/12/08 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 35.2 @ CL 3226846 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3226876 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3226157 on 2016/12/07 by Aaron.McLeran Implementing UE-39421 fix into Orion-DevGeneral2 #rb none #tests Be able to view sound class graphs without destroying links. Change 3225422 on 2016/12/07 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - PhysX libs null merge from 35.2 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3225413 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3224772 on 2016/12/07 by David.Ratti Fix for Rentry in gameplaycue GetWorld functions #rb none #tests golden path Change 3224771 on 2016/12/07 by David.Ratti Reset RemoetInstanceHasended in UGameplayAbility::PreActivate #rb none #tests pie Change 3224752 on 2016/12/07 by Ben.Marsh Merge CL 3224750 from //UE4/Main: Removing -forcelogflush parameter from UAT invocations of the editor to improve cook times. #rb none #tests preflight Change 3224691 on 2016/12/07 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 35.2 @ CL 3224223 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3224690 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3224166 on 2016/12/06 by Daniel.Lamb Reenabled iterative cooking inisettings saving. #rb Trivial #test Cook paragon Change 3223965 on 2016/12/06 by Uriel.Doyon Building texture streaming data for materials does not wait for pending shaders to finish compilation anymore. Added more options to allow the user to cancel this build also. #rb daniel.wright #tests modified different shaders in the material editor and also in the material instance editor Change 3223953 on 2016/12/06 by Frank.Gigliotti Root motion time stamp reset; * The character movement time stamp is now decremented by MinTimeBetweenTimeStampResets instead of being reset to 0. * The character movement time stamp reset is now applied to the start times on root motions. This fixes root motions being stuck on since the time stamp could potentially never reach the start time. * Changed how root motion detects invalid start times since a negative start time is now valid. #RB zak.middleton, laurent.delayen #c0der3view zak.middleton, laurent.delayen #Tests PIE Change 3223463 on 2016/12/06 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 35.2 @ CL 3223380 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3223458 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3223219 on 2016/12/06 by Daniel.Lamb Added more stats to saving asset registry code. #rb None #test cook Change 3222459 on 2016/12/05 by Uriel.Doyon "Texture Streaming Build" now updates the map check after execution. Removed texture streaming data for primitives hidden in game. Fixed an issue where build all would not rebuild texture streaming data. #rb none #jira OR-32771 #tests rebuilt texture streaming data in different maps Change 3222246 on 2016/12/05 by Jason.Bestimt #R0BOMERGE-AUTHOR: andrew.grant Suppress warning when converting from int when the dest is floating point and the converted values are the same #rb none #tests verified converting -1 to -1.000 no longer results in a warning #R0BOMERGE-SOURCE: CL 3222245 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3221951 on 2016/12/05 by Daniel.Lamb More stats into saving asset registry. #rb None #test cook paragon Change 3221518 on 2016/12/05 by Daniel.Lamb Added some more ini settings parsing stats. Removed SaveCurrentIniSettings when not using iterative builds as it is slow will reenable when it's fast again. #rb None #test Cook paragon Change 3221475 on 2016/12/05 by Jason.Bestimt #R0BOMERGE-AUTHOR: andrew.grant Fix for atrac9 logging issue on PS4 #rb none #tests compiled PS4 client in unity #R0BOMERGE-SOURCE: CL 3221474 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3221403 on 2016/12/05 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 35.2 @ CL 3221235 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3221399 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3221247 on 2016/12/05 by Jason.Bestimt #R0BOMERGE-AUTHOR: andrew.grant Third-try at fixing non-unity compile issue #rb none #tests compiled PS4 client #R0BOMERGE-SOURCE: CL 3221242 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3219738 on 2016/12/02 by Daniel.Lamb Integrate Dev-Platform -> Dev-General Added support to rebuild lightmaps commandlet for building lightmaps in seperate files. #rb Daniel.Wright #test rebuild lighting Custom QAGame maps. #jira OR-31907 Change 3219133 on 2016/12/02 by Jason.Bestimt #R0BOMERGE-AUTHOR: guillaume.abadie Cherry picks Dev-Rendering's 3209305: Fix contact shadow's assemption on objects thickness #rb None #R0BOMERGE-SOURCE: CL 3219131 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3219081 on 2016/12/02 by Andrew.Grant Merging material fixes in 3208490 from //UE4/Dev-Rendering/... to //Orion/Dev-General/... #rb none #tests compiled WIn64 editor Change 3218980 on 2016/12/02 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 35.2 @ CL 3218942 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3218979 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3218970 on 2016/12/02 by Andrew.Grant Second attempt at unity / non-unity fix #rb none #tests compiled PS4 Client Change 3218807 on 2016/12/02 by Andrew.Grant Fix for non-unity issue #rb none #tests compiled Win64 editor Change 3218472 on 2016/12/01 by Andrew.Grant Temp fix to allow checked-out blueprint to compile #rb none #tests none Change 3218417 on 2016/12/01 by Andrew.Grant Merging //UE4/Main @ 3205566 through //UE4/Orion-Stating #rb #tests na Change 3218140 on 2016/12/01 by Arciel.Rekman Linux: report server hangs by crashing the hung thread (UE-39164). #rb Michael.Trepka #c0der3view Bart.Hawthorne, Andrew.Grant. #tests none in this branch (Merging 3218133 from Dev-Platform to to //Orion/Dev-General) Change 3216959 on 2016/12/01 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 35.2 @ CL 3216930 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3216954 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3216341 on 2016/11/30 by Michael.Noland Engine: Reduced the length of the hitch when turning off ToggleDebugCamera while showdebug was active by removing expired strings from the back of the array instead of the front (the underlying issue of strings accumulating while not being displayed / processed is covered by UE-39226) #rb marc.audy #tests showdebug significancemanager + toggledebugcamera + wait 30 s + toggledebugcamera Change 3216233 on 2016/11/30 by Andrew.Grant Generate symbols for PS4 as a post-build UBT step At runtime do a better job of searching paths for symbols #rb Marcus.Wassmer #tests verified symbols are generated and valid Change 3215522 on 2016/11/30 by David.Ratti Fixes from Simon for particle significance overriding explicit call to SetEmitterEnabled by game code. #rb none #tests pie #c0der3view Simon.Tovey Change 3215444 on 2016/11/30 by Aaron.McLeran OR-19392 (and now) OR-32017 Reintroducing CL 2943174 after it was lost due to integration issues! #rb none #tests none Change 3215110 on 2016/11/30 by jason.bestimt #ORION_MAIN - Merge 35.2 @ CL 3215050 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3215097 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) #R0BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human. //R0BOMERGE_ORION_Dev_General/OrionGame/Content/Characters/Heroes/Rampage/Skins/Rampage_v001_IceBlue/M_RampageV001_MASTER.uasset #c0der3view: jason.bestimt Change 3213268 on 2016/11/29 by jason.bestimt #ORION_MAIN - Merge 35.2 @ CL 3213062 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3213118 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) #R0BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human. //R0BOMERGE_ORION_Dev_General/OrionGame/Source/BlueprintContext/Private/BannerContext.cpp #c0der3view: jason.bestimt Change 3212226 on 2016/11/28 by Aaron.McLeran OR-32363 Client ensure with USoundWave::GetResourceSize() v35 DevGen Ensure is not valid since it's possible for the sound wave to have its resource size queried before its finished decoded in the case of precache on load. Rather than report ResourceSize (the compressed asset size), we're going to just report the fully decompressed data size (RawPCMDataSize) since that's what it will be when it finishes decoding. #tests none #rb zak.middleton Change 3208273 on 2016/11/22 by Tim.Elek Fix for Tonemapping sharpen black border for HDR #rb marc.olano #c0der3view marcus.wassmer, jordan.walker, andrew.grant Change 3207881 on 2016/11/22 by Jason.Bestimt #R0BOMERGE-AUTHOR: andrew.grant If a requested package can't be found and async loading is not an option, load the object instead of hoping that FlushAsyncLoading() will make things right... This flaw was spotted while investigating OR-31699 which was due to a different issue, but should have been handled by this codepath. #rb none #tests Faked a condition where a package wasn't loaded on the client but became referenced by a object from the server [c0der3viewed] Ben.Ziegler #R0BOMERGE-SOURCE: CL 3207880 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3207807 on 2016/11/22 by Jason.Bestimt #R0BOMERGE-AUTHOR: andrew.grant Fix for OR-31699 While preloading packages check that a package has actually been loaded. Previously this could result in a package failing to load because FindObjectFast would return it to itself (!) #rb none [c0der3viewed] Michael.Noland #tests verified can load into Monolith and get the shadow buff #R0BOMERGE-SOURCE: CL 3207806 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3207756 on 2016/11/22 by David.Ratti rollback networking changes since they seem to be causing side effects and v35 isnt the version to take chances on #rb none #tests compile Change 3206348 on 2016/11/21 by Dan.Hertzka Re-added lost type checking changes to the widget BP compiler when evaluating whether to bind a widget Also added the type check when renaming a widget - if the property name is taken by a BindWidget property, but the widget isn't of a valid type, the rename now fails #c0der3view Nick.Darnell #rb Nick.Darnell #tests Widget BP binding Change 3205882 on 2016/11/21 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 34.3 @ CL 3205612 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3205880 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3205802 on 2016/11/21 by Daniel.Lamb Fixed commandlet used for diffing cooked packages and generating serialization callstacks. #rb None #test Diff cooked package commandlet Change 3204959 on 2016/11/18 by Ryan.Gerleve World time is no longer adjusted when scrubbing in replays. Fixes several issues related to deathcam. Originally done to to fix ability cooldowns in replays, but shouldn't be necessary. #rb john.pollard #jira OR-30918, OR-31268, OR-31302 #tests golden path, deathcam, replays Change 3204805 on 2016/11/18 by Frank.Gigliotti Don't clamp root motion finish velocity if it doesn't need it. #RB None #Tests PIE Change 3204327 on 2016/11/18 by Mieszko.Zielinski Extended UBTDecorator_IsAtLocation with an option of using regular geometric distances rather than pathfollowing-based test #UE4 #rb Lukasz.Furman #test golden path Change 3204078 on 2016/11/18 by Ryan.Gerleve Flip incorrect sort when there are multiple viewpoints in the significance manager (duplicate of CL 3203997 from Dev-Framework). Fixes objects having incorrect significance in deathcam playback. #rb marc.audy #tests golden path, deathcam Change 3204041 on 2016/11/18 by John.Pollard Fix issue where old player controller from draft lobby was hanging around, causing replication warnings #rb BartH #tests Replays Change 3203971 on 2016/11/18 by John.Pollard Fix assert that can occur in player controller iterator when last element cast's to nullptr #rb BartH #tests Live + replays Change 3203843 on 2016/11/18 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 34.3 @ CL 3203682 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3203842 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3202948 on 2016/11/17 by Daniel.Lamb Disabled warning about invalidating cook due to unparsable ini setting. This occurs when you don't have any previously cooked content (like on build machine). #jira OR-31916 #rb trivial #test cook paragon Change 3202798 on 2016/11/17 by David.Ratti Fix logic error around bSuppressGameplayCues #rb none #tests compile Change 3202761 on 2016/11/17 by Jason.Bestimt #R0BOMERGE-AUTHOR: david.ratti Use FObjectKey instead of UClass* for function acceleration map. Speculative fix for rare client crash. #rb none #test pie #R0BOMERGE-SOURCE: CL 3202552 in //Orion/Release-34.3/... via CL 3202760 #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3202688 on 2016/11/17 by Michael.Noland Engine: Adding stats to performance assassians GetAllActorsWithInterface and GetAllActorsWithTag to make them clearer in dumphitches reports (also in GetAllActorsOfClass, which is usually fine unless used with something really broad like AActor or AStaticMeshActor) #rb none #tests Compiled and ran on PS4 Change 3202687 on 2016/11/17 by Michael.Noland Engine: Changed console variables and commands to allow using ? immediately following the command (without a space) to bring up the help text, in addition to the existing behavior of using ? as the first parameter #tests Tested with/without spaces on both a console variable and a console command #rb nick.darnell Change 3202686 on 2016/11/17 by Michael.Noland Engine: Made help console command open the generated HTML file via LaunchURL on windows #tests Tested help command on Windows (LaunchURL with file:// use is only enabled for Windows now, but will be tested on Mac and possibly enabled later) #rb nick.darnell Change 3202622 on 2016/11/17 by Ryan.Gerleve Support duplication of UReflectionCaptureComponents that were loaded from cooked data. Needed to support deathcam in Monolith. #rb daniel.wright #tests golden path on monolith with deathcam enabled on PS4 Change 3202575 on 2016/11/17 by Dan.Hertzka Blur widget updates - Renamed to SBackgroundBlur/UBackgroundBlur - Split SBackgroundBlur out into its own file - Added bApplyAlphaToBlur - when true, the strength of the blur is modulated by the widget alpha - Updated BlurRadius to be TOptional, so we auto-calculate radius when it isn't set - Added a UBackgroundBlurSlot, but left it unattached so it can be done in dev-editor (and update based on the engine version) - Updated OrionBlurWidget to export dll symbols and set up default low quality fallback image #c0der3view Matt.Kuhlenschmidt #rb none #tests PIE & widget designer Change 3202533 on 2016/11/17 by Mieszko.Zielinski Fixed new toggleable nav links not working in client-server environment #Orion #rb none #test golden path Change 3202456 on 2016/11/17 by Mieszko.Zielinski Introduced a new constant to Recast soruces to be used as initial value of tile salt variables #UE4 #rb none #test golden path Change 3202414 on 2016/11/17 by Chris.Bunner Clamp eye adapation working area to match scene viewrect. #rb Marcus.Wassmer #tests Editor #jira OR-31821 Change 3202205 on 2016/11/17 by David.Ratti Networking fix: -Fix ensure about Delayed Prediction Key being flushed while invalid -Fix issue where predicted GE would be removed due to prediction key catch up, but would be added to the removed predicted GE list, causing the later replicated GE to be ignored incorrrectly. This can cause cooldowns to not appear on client, making abilities appear to not function. #rb none #tests golden path, latency #c0der3view Frank.Gigliotti Change 3202063 on 2016/11/17 by Jason.Bestimt #R0BOMERGE-AUTHOR: nicholas.davies #jira OR-31641 Chat logs overlap text box when pressing enter Jamie Dale fix for adjusting text spacing when lines are removed from TextLayouts [c0der3viewed] Jamie.Dale #RB Jamie.Dale #TESTS Chat should no longer overlap when more than 40 messages have been added #R0BOMERGE-SOURCE: CL 3202062 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3201964 on 2016/11/17 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 34.3 @ CL 3201880 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3201956 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3201426 on 2016/11/16 by Mieszko.Zielinski Implemented a generic way to set up simple point navigation links that could be disabled at runtime on static navmesh #Orion #rb none #test golden path Change 3201174 on 2016/11/16 by John.Pollard Increase number of retries when refreshing viewer fails + refactor so that a refresh doesn't starve other REST calls #rb BartH #tests Replays Change 3200669 on 2016/11/16 by Jason.Bestimt #R0BOMERGE-AUTHOR: andrew.grant Merging test framework changes from Release-34 to resolve some known conflicts #rb #tests na #R0BOMERGE-SOURCE: CL 3200668 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3199192 on 2016/11/15 by Lina.Halper Extra ensure for the crash with OR-31795 #jira: OR-31795 #rb: Laurent.Delayen #tests: cooked, and test AI_Test with 9 bots Change 3199187 on 2016/11/15 by Aaron.McLeran UE-35533 Implementing from CL 3112097 Dev-Framework for joey #tests Perform tests described in JIRA #rb Jeff.Campeau Change 3199094 on 2016/11/15 by Eric.Newman Only ping Slate last interaction time for analog input outside the deadzone Orion now only reports handled for analog movements outside the deadzone #c0der3view matt.kulhenschmidt,chris.gagnon #rb cody.haskell #tests golden path w/ ps4 controller on PC Change 3199085 on 2016/11/15 by Laurent.Delayen Potential fix for https://jira.it.epicgames.net/browse/OR-31795 #rb lina.halper #tests twinblast ult multiPIE Change 3198934 on 2016/11/15 by Frank.Gigliotti Fixed out of sync root motion ability tasks; * Root motion ability tasks were out of sync and ending before the root motion was finished. The tasks now wait for the root motion to say it is done. #RB Laurent.Delayen #Tests PIE Change 3198486 on 2016/11/15 by David.Ratti Iniitalize EffectContext to default ASC EffectContext when no context is specified in AddGameplayCue_Internal. Fixes some GC translation issues. #rb none #tests pie Change 3198424 on 2016/11/15 by Rob.Cannaday Fix JSON_SERIALIZE_OBJECT_SERIALIZABLE macro in write mode not beginning a JSON object #rb ian.fox #tests class using JSON macros that writes a named subobject (BEGIN_JSON_SERIALIZER/JSON_SERIALIZE_OBJECT_SERIALIZABLE("name", obj)/END_JSON_SERIALIZER) Change 3198418 on 2016/11/15 by Rob.Cannaday More profiling for hitch when receiving friend request #jira OR-30503 #rb ian.fox #tests front end add/remove friend #lockdown nicholas.davies Change 3198214 on 2016/11/15 by David.Ratti Ability System: Added support for some advanced client prediction with the intention of removing latency from the effective duration of predictive gameplay effects. 1. Predicted GameplayEffect reconciliation. Predicted GEs are now reconciled with their replicated counter parts. Previously the predicted GE would be removed when the replicated one came in. Now we reconcile the predicted GE with the replicated GE, and throw out the replicated GE as if it was never added. To the outside, the predicted GE becomes the replicated GE seamlessly. 2. Server retry client activation fails. When a client ability activation fails on the server, the server can retry the activation for a few frames before officially failing it. This is to combat minor discrepencies caused by different server frame rate or jitter in networking conditions. The common example is that we handle RPCs at the top of the frame, before we update timer manager and removed expired GEs or end animations. Both features can be disabled with -DisableAdvancedClientPrediction. They can be toggled individually via config file. #QAr3view: 1. Verify ping time no longer affects attack speed OR-30123. We still expect packet loss to have some effect on rate of fire. 2. Be on the look out for "ability stuck" type of issues 3. If there are resources, I would like to get 2 people to give qualitative feedback on this. Have them lane 1v1 for ~7 minutes with 200 ms of ping (no packet loss). Do this twice, once normally and again with -DisableAdvancedClientPrediction on both client AND server. Do it blind: don't tell them which run has which setting, just see if they notice differences. The hope is that your LMB attacks feel consistent with respect to timing and match what the UI shows in terms of cooldown. I would recommend testing with Murdock and maybe a melee like Crunch #rb frank #c0der3view Frank.Gigliotti, Billy.Bramer, Fred.Kimberley #tests pie, golden path Change 3197309 on 2016/11/14 by Laurent.Delayen Additional debugging info for https://jira.it.epicgames.net/browse/OR-31266 #rb none #tests riftmage + venus VS riftmage multiPIE Change 3196654 on 2016/11/14 by Laurent.Delayen Additional debug info to track down https://jira.it.epicgames.net/browse/OR-31677 #rb none #tests compiles [CL 3276432 by Andrew Grant in Main branch]
2017-01-27 23:32:44 -05:00
TempCmdLine += "-Messaging ";
}
if (Params.NullRHI && SC.StageTargetPlatform.PlatformType != UnrealTargetPlatform.Mac) // all macs have GPUs, and currently the mac dies with nullrhi
{
TempCmdLine += "-nullrhi ";
}
if (Params.Deploy && !Params.CookOnTheFly && (SC.StageTargetPlatform.PlatformType == UnrealTargetPlatform.PS4))
{
TempCmdLine += "-deployedbuild ";
}
TempCmdLine += "-CrashForUAT ";
TempCmdLine += Params.RunCommandline;
// todo: move this into the platform
if (SC.StageTargetPlatform.LaunchViaUFE)
{
ClientCmdLine = "-run=Launch ";
Copying //UE4/Release-Staging-4.13 to //UE4/Dev-Main (Source: //UE4/Release-4.13 @ 3088355) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3088355 on 2016/08/13 by Max.Preussner Media Player Editor: Fixed Local file paths without file:// open when pressing Enter, but not when clicking Go button (UE-34643) #jira UE-34643 Change 3088331 on 2016/08/13 by Max.Preussner Media: Fixed Failing to load Precached Media Source (UE-34285) #jira UE-34285 Change 3088202 on 2016/08/12 by Zabir.Hoque Porting DX12 Fix from MS: Update D3D12 RHI for 4.13 - Fixed compiler errors with missing RHI methods. Fixed compiler warnings where names were hidding other variables. #jira UE-0 Change 3088149 on 2016/08/12 by Mark.Satterthwaite Duplicate CL #3087991: Initial AVFoundation implementation of Media Framework for Mac, iOS & tvOS. - Slight adaptation of AppleMovieStreamer to pick up movies from inside the GameContentDir on all Apple platforms. - Video playback occurs via AVPlayerItemVideoOutput's attached to the AVPlayerItem's output. This means gathering video samples is trivial. - Metal texture updates occur by wrapping the texture object provided by AVF - for Mac this is simple as it can bind to the IOSurface directly, for iOS/tvOS we have to create a CVMetalTextureCache and allocate our texture from there. - OpenGL and OpenGLES currently have to lock the pixel buffer and upload to a texture the old fashioned way - this should be revisited when there is time. - Subtitles/Captions are captured using AVPlayerItemLegibleOutput which also connects to the AVPlayerItem's output. - On Mac audio samples are returned by manually reading from the stream using an AVAssetReaderTrackOutput, including manual seeking and synching. - On iOS/tvOS the audio is played directly by AVPlayer because the IOSAudio system can't handle procedural buffers - otherwise it could reuse the Mac code. - AVFoundation does not support AVI - that's an obsolete Microsoft/Windows file-format. - Only 'file://' URLs are supported - streaming would require a totally different audio solution (using MTAudioProcessingTap) and has many more edge and failure cases that would need to be handled. #jira UE-34315 Change 3088131 on 2016/08/12 by Chris.Babcock Fix iterative deploy for new ADB #jira UE-34638 #ue4 #android Change 3088106 on 2016/08/12 by Dan.Oconnor Make check less strict, PinIds are only unique within a single node, unfortunately, hence why we use both an OwningNode and a PinId when resolving references #jira UE-34564 Change 3088099 on 2016/08/12 by Zabir.Hoque Move end of frame resource clean up to end of viewport rendering, since EndFrame calls were not consistently coming in when movie was playing but asset loading was done. #Jira UE-27026 Change 3088072 on 2016/08/12 by Max.Chen Sequencer: Level editor camera cut flag is now a one way gate This resolves issues to do with the flag being erroneously reset by external forces. #jira UE-33875 Change 3088031 on 2016/08/12 by Jeff.Campeau Fix WinXP build issues in WmfMedia and SteamVR plugins. #jira UE-32421 Change 3088025 on 2016/08/12 by Tom.Looman Updated VR Template with new VR device ID blueprint node. #jira ue-34592 Change 3088023 on 2016/08/12 by Tom.Looman Added PS Move input handling support to VR Template. #jira UE-34188 Change 3087989 on 2016/08/12 by Michael.Trepka Restored the code that's staging custom icons for Mac, which was accidentally removed when we switched to use build receipts. #jira UE-34581 Change 3087907 on 2016/08/12 by mason.seay New test assets for sub instance testing #jira UE-29618 Change 3087812 on 2016/08/12 by Maciej.Mroz #jira UE-34247 Nativized UMG assets not visible Redone cl#3087726 from Dev-Blueprints Change 3087810 on 2016/08/12 by Jeff.Fisher UEVR-13 PSVR: TCR Requirements : sceHmdReprojectionSetOutputMinColor Exposed sceHmdReprojectionSetOutputMinColor to blueprint via Morpheus Function Library. Allows one to set the minimum output color from reprojection processing. Can be used to mitigate certain artifacts (dark smearing, reprojection edges). See Sony documentation for more information. This setting does persist across switches out of vr mode and hmd disconnection, but it has no effect out of vr modes. #review-3087760 @nick.whiting #jira UEVR-13 Change 3087795 on 2016/08/12 by Mitchell.Wilson Added project thumbnail to subway sequencer. Added thumbnails to subway sequencer levels. Re-saved multiple files to resolve empty engine version and nodeguid warnings. #jira UE-34521 UE-34519 Change 3087730 on 2016/08/12 by Michael.Trepka Made bGeneratedSYMFile true by default and changed some ifs in Mac UBT code so that non-debug configs always build dSYM files on Mac, unless bGeneratedSYMFile is set to false in BuildConfiguration.xml #jira UE-34548 Change 3087699 on 2016/08/12 by Jeff.Campeau Make resource generation fault tolerant of unset config values. #jira UE-34614 Change 3087690 on 2016/08/12 by Mitchell.Wilson Added a thumbnail for the BlueprintRenderToTarget level. #jira UE-34544 Change 3087688 on 2016/08/12 by Marc.Audy Fix headshot crash when tearing down physics when not registered #jira UE-32935 Change 3087615 on 2016/08/12 by Ben.Woodhouse Fix for crash in shadowsetup when frustum is invalid #jira UE-33014 Change 3087607 on 2016/08/12 by Max.Chen Sequencer: Fix Import/Export FBX - Import FBX now maps arbitrary float properties as well as the transform - Import/Export FBX now consistently operates on selected nodes or all nodes - Fixed exported node names so that they're consistent with Sequencer node names #jira UETOOL-534 Change 3087586 on 2016/08/12 by Chris.Babcock Add HUAWEI_Mali device model recognition for Vulkan #jira UE-34610 #ue4 #android Change 3087529 on 2016/08/12 by Jurre.deBaare Fix for crash when start index != 0 and sampling at a different rate #jira UE-34637 Change 3087519 on 2016/08/12 by Ben.Marsh Pass the -ignorejunk flag on to child UBT instance when running a clean. Change 3087455 on 2016/08/12 by Jurre.deBaare Alembic importer plugin needs proper logo #fix Replaced icon with inverted official Alembic logo #jira UE-34474 Change 3087360 on 2016/08/12 by Ben.Marsh Print out the UBT command line before running it, to help diagnose -ignorejunk problem. Change 3087285 on 2016/08/12 by Lina.Halper - Add which animation it fails to compress - Make sure it doesn't go in there unless you have skeleton #jira: UE-34490 Change 3087237 on 2016/08/12 by Alex.Delesky #jira UE-34453 - Fixed an issue where a cast to find specific thumbnail scene info was being erroneously applied to the skeletal mesh thumbnail scene instead of the material thumbnail scene. Change 3087215 on 2016/08/12 by danny.bouimad #jira UE-29618 updated QA-AnimProfiles again... Change 3087212 on 2016/08/12 by Danny.Bouimad #jira UE-29618 updated TM-PhysicalAnimProfiles again Change 3087200 on 2016/08/12 by Robert.Manuszewski Fix for potential deadlock when a worker thread crashes caused by critical section lock in FOutputDeviceRedirector. The engine will no longer attempt to flush log messages in CheckRenderingThreadHealth if a critical error has already occured. Crash handlers flush log anyway. #jira UE-34373 Change 3087188 on 2016/08/12 by Matthew.Griffin Added SignExecutables Option to installed build script, which defaults to false and means most people won't have to pass -nosign anymore Added HostPlatformsOnly Option to installed build script as a way to easily make a build with only your current platform, without having to disable every other platform manually Change 3087160 on 2016/08/12 by Ben.Marsh Propagate the -ignorejunk option when we're building UHT as a child process in UBT. Change 3087148 on 2016/08/12 by Ben.Marsh Fix sample build failure due to intermediate headers being deleted from engine folder. Some modules only have *private* UObject classes which aren't included in the editor zip. UBT detects that there are no longer and UObject classes and deletes the intermediate folder, causing BuildGraph to fail when it detects the change. Change 3087143 on 2016/08/12 by Danny.Bouimad #jira UE-29618 updated QA-AnimProfiles and SK_Mannequin_PhysAssetTest to include constaint profiles for switching, removed old map in wrong folder. Change 3087140 on 2016/08/12 by Steve.Robb GitHub 2256 : Update UnrealCodeAnalyzer.Build.cs I have no evidence that this actually fixes anything, but it doesn't harm anything to add it... #jira UE-29286 Change 3087139 on 2016/08/12 by Steve.Robb Failed link actions during a hot reload now output a 'failed.hotreload' file in the destination folder to indicate that another link attempt is needed. This is because we can't distinguish between a successful compile with a failed link action, and a compile with no changes which requires no new module. #jira UE-31575 Change 3087107 on 2016/08/12 by Jurre.deBaare Alembic Import with empty first frame will cause the editor to crash #jira UE-34515 #fix Reject empty or invalid frames and remove them from the object, output messages are generated for such frames/objects #misc added a static const value indicating the first frame instead of hardcoded 0 array accesors #misc check condition fix in Runnable #misc log now adds new page named after the imported Alembic file Change 3087079 on 2016/08/12 by Dmitriy.Dyomin Fixed: Corrupted level package on loading cooked content #jira UE-34591 Change 3087063 on 2016/08/12 by James.Cobbett #jira UE-29618 Submitting test assets for Alembic Importer Change 3087048 on 2016/08/12 by Matthew.Griffin Changed Launcher Samples to create aggregate from property to avoid error in preflights Only notify about Launcher Samples trigger in non-preflight builds Change 3086985 on 2016/08/12 by Maciej.Mroz #jira UE-34372 [CrashReport] UE4Editor_CoreUObject!StaticAllocateObject() [uobjectglobals.cpp:2102] Redone cl#3083825 from Dev-Blueprints Change 3086960 on 2016/08/12 by Matthew.Griffin Prevent Build DDC command from making DDC for platforms that aren't supported by project #jira UEB-698 Change 3086945 on 2016/08/12 by Dmitriy.Dyomin Fixed: Sub-level layers do not show up in Layers tab when loaded as a part of world composition #jira UE-18291 Change 3086904 on 2016/08/11 by Lina.Halper Reverting the ensure as raw curve track != compressed because it doesn't go to compressed if the value doesn't have anything more than >0.f #jira: UE-34570 Change 3086891 on 2016/08/11 by Lina.Halper DUPEFIX: CL 3086544 from Michael Noland Paper2D: Fixed a crash when mutating grouped sprite components at runtime, and cleaned up how collision rendering is done for grouped sprite components addressing some other issues as well #jira UE-34223 #tests (from Michael N) Tested with repro project from JIRA, as well as adding/removing instances in the editor and with some sprites in the group having collision and others not, clearing collision on the component itself, etc... #tests (from Lina H) started the test project from JIRA and PIE, and no crash. Change 3086837 on 2016/08/11 by Nick.Whiting Modifying IsInGameThread() checks in Oculus positional tracking code to be !IsInActualRenderingThread(). This allows skel controls to use orientation and position with parallel animation #jira UE-32564 Change 3086797 on 2016/08/11 by Dmitry.Rekman Linux: fix crash on editor exit (UE-30795, UE-7519). - FText (stored in ZoomLevels static array) was being destructed during the global destructor phase, and it cannot do that. #jira UE-30795 Change 3086735 on 2016/08/11 by Richard.TalbotWatkin Fixed crash due to entries in the BlueprintCreatedComponents list not being present in the OwnerComponents list in RerunConstructionScript following an Undo. Handled this case explicitly now. #jira UE-34265 - Undo, Redo, Undoing a blueprint actor Replace action causes a crash Change 3086726 on 2016/08/11 by Jeff.Fisher UEVR-13 PSVR: TCR Requirements : 2DVR 2DVR is a way to show a static image on PlayStation VR temporarily, for example as a loading screen. -Implemented 2DVR reprojection mode, exposed Show2DVRSplashScreen and Hide2DVRSplashScreen to blueprint through a new MorpheusFunctionLibrary. #jira UEVR-13 #review-3086004 @chad.taylor @nick.whiting Change 3086652 on 2016/08/11 by Dmitry.Rekman Linux: re-enable ICU (UE-34012). - Built static libs against libc++; disabled using dynamic ones. - Fixes lack of rich text formatting. #jira UE-34012 Change 3086648 on 2016/08/11 by Nick.Whiting Adding support for getting the HMD Device name from code / blueprints #jira UE-31785 Change 3086589 on 2016/08/11 by Chad.Taylor Fixing Vive resolution on packaged builds #jira UE-34535 Change 3086568 on 2016/08/11 by Matt.Kuhlenschmidt Fix skeletal mesh LODs not being imported correctly. All meshes were imported to the base LOD instead. #jira UE-34397 Change 3086529 on 2016/08/11 by Marc.Audy Don't build UE4Game against shipping physx/apex libs causing module mismatches for binary code projects linked against profile libs (which is the default) #jira UE-34287 Change 3086376 on 2016/08/11 by Peter.Sauerbrei remove cached file handle from iOS and Android to save memory during loads #jira UE-31720 Change 3086369 on 2016/08/11 by Matt.Kuhlenschmidt Guard against crash with corrupted editor layouts #jira UE-34364 Change 3086345 on 2016/08/11 by Dan.Oconnor ULevel::Actors is now a TArray instead of a TTransArray. It has been misusing TTransArray for years (by both serializing individual elements and the entire array, TTransArray logic in EditorTransaction.cpp appears to be completely rotten, broken for a very long time) #jira UE-34380 Change 3086272 on 2016/08/11 by Cody.Albert Updating First Person templates to fix cook errors #jira UE-22726 Change 3086259 on 2016/08/11 by Nick.Whiting Added a project setting bStartInVR, which allows projects to specify that they want to default to starting in VR mode, regardless of whether the -vr commandline is used #jira UE-31617 Change 3086202 on 2016/08/11 by Marcus.Wassmer Duplicate 3086176 to fix broken shaderpipelines on PS4 #jira UE-34540 Change 3086080 on 2016/08/11 by mason.seay Test animbp for sub anim instances #jira UE-29618 Change 3086062 on 2016/08/11 by Tom.Looman Migrate from //depot/usr/ into Release-4.13 for VR Template. #jira ue-34533 Change 3086032 on 2016/08/11 by Mike.Beach Bolstering FSceneComponentDetails::MakeTransformDetails()'s null handling (there was one conditional that was missing it). #jira UE-34350 Change 3086025 on 2016/08/11 by Olaf.Piesche #jira UE-32058 Replicating fix from 3050352 Change 3085969 on 2016/08/11 by John.Pollard CIS fix #jira UE-30516 Change 3085819 on 2016/08/11 by Jurre.deBaare bForceOneSmoothingGroup not working for skeletal meshes #fix Added check for forced smoothing group and calculate normals accordingly #misc Spotted some non-referenced const TArrays being passed to CalculateTangents #jira UE-34555 Change 3085799 on 2016/08/11 by Ben.Marsh Pass the -ignorejunk option to UBT when generating code documentation. Since the UE_SDKS_ROOT environment variable is removed (because we don't want documentation for confidential platforms), UBT was deleting Linux target platform DLLs and causing an error when generating blueprint documentation when the files were missing. Change 3085763 on 2016/08/11 by Daniel.Lamb Fix for circular initialization of a singleton on android causing hang when using cook on the fly. #jira UE-34442 Change 3085717 on 2016/08/11 by Dmitry.Rekman Linux: better messaging around Steam initialization (UE-32052). - Also added a standalone test. #jira UE-32052 Change 3085715 on 2016/08/11 by Chris.Bunner Dropped check to an ensure as there's existing handling for invalid assets in that case. #jira UE-23902 Change 3085714 on 2016/08/11 by Olaf.Piesche #jira UE-30398 Fix offset added to particle collision locations. Replicated from 3084645 in Dev-Rendering Change 3085713 on 2016/08/11 by Chris.Babcock Allocate OptionalShadowDepthColorSurface to match DepthStencil dimensions (allow up to 4 resolutions for now) #jira UE-33840 #ue4 #android #ios #opengl Change 3085711 on 2016/08/11 by Olaf.Piesche #jira UE-34106 #jira UE-32784 #jira UE-31198 Reset vertex factories on mesh emitters if mesh has been reimported (if mesh package is dirty) Replicated from 3083909 in Dev-Rendering Change 3085707 on 2016/08/11 by Matthew.Griffin Duplicated CL#3081374 from Dev-Build and another fix to the SlateTextureAtlasInterface issue Change 3085656 on 2016/08/11 by Marc.Audy PR#2620. Make sure the component has its position updated before using it to spawn the child actor (Contributed by pampersrocker) #jira UE-32418 #jira UE-33617 Change 3085641 on 2016/08/11 by Lina.Halper Fixed invalid compressed track data - need a better solution and added ticket for 4.14 - UE-34547 #jira: UE-34077 Change 3085606 on 2016/08/11 by Max.Preussner Media: Attempt to fix Crash after Clearing Sound Wave Asset and Deleting Media Player from Content Browser (UE-34381) #jira UE-34381 Change 3085568 on 2016/08/11 by Maciej.Mroz #jira UE-34436 Ensures when copy/pasting linked anim bp nodes FGraphObjectTextFactory doesn't call compilation (it is called later by FBlueprintEditor::PasteNodesHere, when all nodes are pasted). CallFunction can be pasted even when it's function doesn't exist. The function could be created from a CustomEvent node, that was also pasted (so it wasn't compiled yet). Change 3085532 on 2016/08/11 by Peter.Sauerbrei fix for remote tool chain build issues with items not being built because they were already there and up to date, but are then deleted by the file sync because they are missing on the PC #jira UE-30335 Change 3085528 on 2016/08/11 by Max.Chen Sequence Recorder: Fix crash when actor class to record is null. #jira UE-34543 Change 3085418 on 2016/08/11 by Maciej.Mroz #jira UE-33883 Packaging with Nativize Blueprint Assets Causes Uninitialized Defaults Redone cl#3084313 from Dev-Blueprints Change 3085395 on 2016/08/11 by John.Pollard Don't allow hot-reloading if we're running PIE instances #jira UE-30516 Change 3085377 on 2016/08/11 by Tom.Looman Added StarterMap (WIP) to resolve JIRA. #jira ue-34311 Change 3085364 on 2016/08/11 by Ben.Woodhouse Remove the Shadows of Editor-Hidden Objects showflag. This feature hasn't worked for a long time, and making it work again would add additional complexity and performance overhead which we don't want to incur. #jira UE-28561 Change 3085341 on 2016/08/11 by Dmitriy.Dyomin Fixed: Creating Launcher Profile does not always shows all project available maps #jira UE-33765 Change 3085336 on 2016/08/11 by Andrew.Rodham Sequencer: Runtime instances are no longer updated when bluprints are recompiled This code was not actually necessary to fix UE-31635 since we explicitly update the object binding from the level sequence editor spawn register #jira UE-34499 Change 3085332 on 2016/08/11 by Dmitriy.Dyomin Fixed: UInstancedStaticMeshComponent does not keep its instances on duplication #jira UE-26868 Change 3085331 on 2016/08/11 by Ben.Woodhouse Fix for threading related crash with precomputed lighting volumes #jira UE-34531 Change 3085323 on 2016/08/11 by Allan.Bentham Remove android specific vulkan hack to recreate depth buffer's imageview. #jira UE-33593 #jira UE-33336 Change 3085313 on 2016/08/11 by Thomas.Sarkanen StopRecordingAnimation now uses the same maing logic as RecordAnimation This prevents inconsisten behaviour between record and stop record commands #jira UE-34498 - User is not able to use StopRecordingAnimation command on a single actor Change 3085301 on 2016/08/11 by Allan.Bentham Only allow gaussian DoF on mobile. Disable DoF for all other types. #jira UE-34217 Change 3085292 on 2016/08/11 by Thomas.Sarkanen Revert change to force shipping dlls in shipping builds #jira UE-34287 - Crash when opening a packaged code project for Win64 in shipping configuration Change 3085291 on 2016/08/11 by Matthew.Griffin Added nodes for Linux Editor, DDC and installed build Changed existing Linux nodes to use host platform version of UHT and removed unnecessary tagging of UHT products Change 3084973 on 2016/08/10 by Jeff.Campeau Use relative settings for ShooterGame manifest Package creation checks Xbox One target settings in Engine instead of Game config #jira UE-33808 Change 3084932 on 2016/08/10 by patrickr.donovan #jira UE-29618 SteamVR related test content updates- QA_SteamMoCo -> MotionController Components, fixing up button presses, reworking bounds drawing. Change 3084886 on 2016/08/10 by Daniel.Wright Reverted cl 2938543 "Lightmass now respects owner bHidden, and bCastHiddenShadow" because it did not have backwards compatibility so breaks content using hidden light cards #jira UE-33238 Change 3084878 on 2016/08/10 by Jeff.Campeau UFE launch command is generated with all devices requested instead of just the first. #jira UE-34302 Change 3084860 on 2016/08/10 by Dmitry.Rekman Fix CrashReportClient crashing on start (UE-32976, UE-34451). - Add spaces around -abslog=foo.log parameter to prevent unrelated parameters being concatenated (and missed) sometimes. #jira UE-32976 Change 3084756 on 2016/08/10 by Dmitry.Rekman Linux: clean-up compiler settings logic (UE-22715). - Includes parts of pull request #1704 by zaps166. - Disables exceptions in most builds. #jira UE-22715 Change 3084679 on 2016/08/10 by Richard.TalbotWatkin Duplicated from Dev-Editor, CL 3084475 Fixed issue with ModelComponent replication in client/server PIE if BSP is rebuilt. ModelComponent now implements IsNameStableForNetworking and always returns true, as a level's model components will never be rebuilt during a game session. Brush poly normals are now only fixed up in Editor builds. #jira UE-34391 - No run animation on client that is not focused when running 2 player and dedicated server Change 3084614 on 2016/08/10 by Daniel.Wright Scene capture alpha is now inverted to match DrawMaterialToRenderTarget, and to allow compositing with existing render target contents Added CompositeMode to SceneCapture2D, which can be used to addively accumulate or composite instead of the default overwrite behavior Added bCaptureOnMovement to SceneCapture, which can be disabled so the only source of scene capturing is a manual capture by calling CaptureScene() #jira UE-34321 Change 3084607 on 2016/08/10 by Jeremiah.Waldron Adding AlreadyOwned to EInAppPurchaseState and utilizing this enumeration for GooglePlay IAP Also changing IOS store to return AlreadyOwned when SKErrorClientInvalid is received. This seems to be the correct behavior according to: http://stackoverflow.com/questions/8833970/when-does-skerrorclientinvalid-occur Relates to: #jira UE-34283 Change 3084586 on 2016/08/10 by Jeff.Campeau Chunks don't assume they're done downloading at 100%. #jira UE-34386 Change 3084552 on 2016/08/10 by Lina.Halper Fix GetWorldFromContextObject to be used for another thread safer : Guard to modify static variabls by another thread #jira: UE-34416 Change 3084551 on 2016/08/10 by Mitchell.Wilson Changed AutoPossessPlayer to Disabled in ThirdPersonCharacter BP Changed AutoPossessPlayer to Player0 on the ThirdPersonCharacter Instance in the level. #jira UE-32855 Change 3084535 on 2016/08/10 by Mike.Beach Fix to MathExpression node - recent modifications caused subte changes in behavior (now back in line with how it worked before). Identifiers (variable names) are back to allowing numerical characters, and we properly detect the terminating 0 at the end of a name/string. Also, reserving symbols that currently aren't operators (as they used to be) so users don't start including them in identifier names. #jira UE-34378 Change 3084526 on 2016/08/10 by Jeff.Campeau Update XDK to August 2016 #jira UEPLAT-1374 Change 3084471 on 2016/08/10 by John.Pollard Fix UE-34295: [CrashReport] Crash opening project on network drive - VCRUNTIME140!<Unknown> #jira UE-34295 Change 3084363 on 2016/08/10 by Marc.Audy Make stat soundcues/waves work correctly when spinning up new audio devices and switching focused viewport #jira UE-34101 Change 3084231 on 2016/08/10 by Michael.Trepka Fixed a problem with the search box in blueprint context menu not getting focus on Mac #jira UE-20884 Change 3084229 on 2016/08/10 by Dmitry.Rekman Linux: remove hardcoded staged files (UE-24594). #jira UE-24594 Change 3084215 on 2016/08/10 by Chris.Bunner Moved StationaryLightOverlap vis mode drawing to later in the frame to avoid translucency in the view. #jira UE-31936 Change 3084052 on 2016/08/10 by Jurre.deBaare Alembic skeletal mesh importer does not calculate correct smoothing groups #fix follow same routine as regular smoothing group/normal calculation #jira UE-34493 Change 3084029 on 2016/08/10 by Phillip.Kavan [UE-34458] Fix a crash that can occur while instancing an uncompiled Blueprint class with a modified array property in the native parent class default object. Mirrored from //UE4/Dev-Blueprints (CL# 3082839). #jira UE-34458 Change 3084027 on 2016/08/10 by Ben.Woodhouse Fix for crash when applying BSP materials This was caused by the renderthread dereferencing a reference to a ModelElement object which had previously been destroyed on the game thread. The reference to the ModelElement was solely used to dereference the irrelevant light GUIDs. The fix involves removing the reference and keeping a local copy of this array which is owned by the proxy. This is consistent with other proxies, e.g. Landscape, StaticMesh. #jira UE-31460 Change 3083981 on 2016/08/10 by Matthew.Griffin Set Localization branch for Localise command to release version when running in the Release Branch #jira UE-34471 Change 3083970 on 2016/08/10 by Max.Preussner PS4Media: Fixed Media player does not play the 2nd item in the playlist on PS4 (UE-33481) #jira UE-33481 Change 3083918 on 2016/08/10 by Matthew.Griffin Exclude UBT generated files from the installed build Change 3083910 on 2016/08/10 by Matt.Kuhlenschmidt Fix crash using "Use Selected asset from Content Browser" for font materials when the selected asset is not a material #jira UE-34360 Change 3083890 on 2016/08/10 by Matthew.Griffin Converted Launcher Samples to a full list of sample nodes with individual cook platform settings. Changed unzip nodes to only rely on the produced zip files so that it doesn't copy anything from Temp Storage. Changed BuildLauncherSample command to take the root publish dir and build label so that it can create paths and do copies. Also removed code checking whether monolithic platforms are specified for the project. #jira UE-34401 Change 3083873 on 2016/08/10 by Dmitry.Rekman CMakefileGenerator: Fix compilation on .NET 4.0 and below (UE-34478). #jira UE-34478 Change 3083862 on 2016/08/10 by Mitchell.Wilson Rebuilt lighting on Advanced_Lighting level in Samples Content #jira UE-34383 Change 3083792 on 2016/08/10 by Benn.Gallagher PR #2671: Fix sub instance curve values. (Contributed by tmiv) PR #2668: Sub inst post anim fix (Contributed by tmiv) #jira UE-34162 #jira UE-34121 Change 3083775 on 2016/08/10 by Kevin.Rushin QAGame - Updating VRLatency Testmap, Can freelook #jira UE-29618 Change 3083771 on 2016/08/10 by Robert.Manuszewski Don't attempt to construct CDOs when assembling GC token stream while exiting as a result of an error in PreInit. #jira UE-34371 Change 3083742 on 2016/08/10 by Lee.Clark 4.13 - PS4 - Fix memory allocation sizes #jira UE-33270 Change 3083732 on 2016/08/10 by Ben.Marsh Fix all nodes being exported to JSON file for builder configuration, rather than just those behind the current trigger. Change 3083690 on 2016/08/10 by Dmitriy.Dyomin Fixed: Foliage instances are not included when exporting a scene to FBX #jira UE-34214 Change 3083654 on 2016/08/10 by Keith.Judge Fix analysis warnings. Simple change from Release() to SAFE_RELEASE(). #jira UE-23059 Change 3083646 on 2016/08/10 by Thomas.Sarkanen Use shipping PhysX libs for installed builds Copy fix from UE4Game.Target.cs to apply to all packaged games #jira UE-34287 - Crash when opening a packaged code project for Win64 in shipping configuration Change 3083527 on 2016/08/10 by Dmitriy.Dyomin Fixed: Warning upon Undo/redo-ing of sculpting the landscape #jira UE-34443 Change 3083502 on 2016/08/10 by Dmitriy.Dyomin Fixed: World Composition origin shifting does not account for shifting the Dynamic Directional Light shadow casting #jira UE-34417 Change 3083349 on 2016/08/09 by Daniel.Wright Clamped roughness for simple lights to avoid NaNs from D_GGX with a very narrow roughness range including 0.00316, but not 0 #jira UE-31181 Change 3083167 on 2016/08/09 by Chad.Taylor Null deref crash fix #jira UE-33830 Change 3083144 on 2016/08/09 by Zabir.Hoque Removed bDeviceRemoved flag from RHI and issue erroring hault right away. This allows finding the error reason much closer to the callsite. #jira UE-32980 Change 3083136 on 2016/08/09 by Chad.Taylor Stripping out egregious log spam #jira UE-34181 Change 3083116 on 2016/08/09 by John.Billon Defaulting r.D3D.RemoveUnusedInterpolators to on. #Jira UE-34461 Change 3083114 on 2016/08/09 by John.Billon Fixing static analysis warning in NullRHI. #Jira UE-34462 Change 3083070 on 2016/08/09 by Dmitry.Rekman PR #2516: CMake improvements and fixes (UE-22233, UE-32136). - Contributed by Nihlus. - Contains PR #1668 by mgerhardy Summary of changes (from PR): - Fixed an issue where CMake build files would contain invalid targets - Fixed an issue where CMake build files would generate without code completion data, making them useless in IDEs such as CLion. - Fixed an issue where invalid target platforms could fall through and cause issues with the file generation. - Improved code readability throughout the generator. Can still use some more polish. - Improved CMakeFile generation performance by approximately 25%. Before this patch, generating a CMakeFiles.txt for a small-ish project took 20s - by replacing most string concatenation with StringBuilders, it now takes approximately 15s. This should be more apparent in larger projects. - Improved commenting throughout the generator. As with readability, can still use some more polish. - Removed unused using statements. - Added the inclusion of a fake executable target to the CMake files. Some IDEs do not recognize header files that are not part of either an executable or a library. While this target will not build, it is neccesary in CLion. - Replaced all instances of String.Format with string interpolation expressions from C#6. This greatly improves readability, and helped me catch some bugs with the build targets. #jira UE-22233 Change 3082999 on 2016/08/09 by Jeremiah.Waldron Actually checking the consumePurchase response in the GooglePlayStoreHelper for purchases #jira UE-34457 Change 3082993 on 2016/08/09 by mason.seay Fixed level BP error and updated Reverb asset #jira UE-29618 Change 3082981 on 2016/08/09 by Peter.Sauerbrei disable roughness calculation for iOS metal #jira UE-31815 Change 3082912 on 2016/08/09 by Chris.Babcock Use FMallocAnsi instead of FMallocBinned on Android ARM64 for now #jira UE-34432 #ue4 #android Change 3082875 on 2016/08/09 by Chris.Bunner Lowered verbosity of mesh build warning when using MikkTSpace. #jira UE-23903 Change 3082867 on 2016/08/09 by Trung.Le VREditor: Foliage reapply tool shouldn't auto reapply brush settings without trigger presses #jira UE-34227 Change 3082818 on 2016/08/09 by Mike.Beach Backing out CL 3081020, as it was causing issues with duplicated Blueprint actors (triggering an assert). #jira UE-34430 Change 3082794 on 2016/08/09 by Lukasz.Furman fixed gameplay debugger extensions activating during simulate in editor #jira UE-33343 Change 3082760 on 2016/08/09 by Jamie.Dale Scene viewports are now centered when re-entering windowed mode #jira UE-32842 Change 3082744 on 2016/08/09 by Mitchell.Wilson Resaving assets to resolve empty engine version warnings. #jira UE-29746 Change 3082728 on 2016/08/09 by Ben.Marsh BuildGraph: Use separate arguments to indicate that a trigger should be skipped entirely and its nodes should be executed as part of the parent trigger (-skiptrigger=X+Y, -skiptriggers) versus when we want to execute ONLY nodes behind a certain trigger. Fixes cases where triggering sample builds before the parent job finishes would attempt to execute the remaining nodes belonging to the parent trigger. #jira UE-34329 Change 3082686 on 2016/08/09 by Marc.Audy If the GameMode is not carried over as part of a seamless travel create it. #jira UE-25569 Change 3082663 on 2016/08/09 by John.Billon Fixed SubUVAnimation asset crash when texture source is cleared. #Jira UE-34231 Change 3082650 on 2016/08/09 by John.Billon Changed an ensure the NullRHI dealing with memory allocation to be a log message. #Jira UE-32362 Change 3082644 on 2016/08/09 by Maciej.Mroz #jira UE-34240 Match 3 nativization failure Redone cl3082121 from Dev-Blueprints Change 3082633 on 2016/08/09 by Maciej.Mroz #jira UE-34374 [CrashReport] UE4Editor_Engine!UEdGraphNode::GetGraph() [edgraphnode.cpp:172] Redone cl3082414 from Dev-Blueprints Change 3082606 on 2016/08/09 by Michael.Trepka Changed OuputGamutMappingMatrix in TonemapCommon.usf so it doesn't create a temporary variable to work around a bug in Intel's Mac OpenGL shader compiler. #jira UE-34276 Change 3082579 on 2016/08/09 by Benn.Gallagher CIS fix, missed removing a few #ifs #jira UE-29180 Change 3082525 on 2016/08/09 by Tom.Looman Removed Android from supported platforms in VR Template. #jira UE-34189 Change 3082523 on 2016/08/09 by Tom.Looman Improved HMDLocomotionPawn teleportation (UX of location and material reability/behavior) Fixed typo in level text. #JIRA UE-34422 Change 3082504 on 2016/08/09 by Jurre.deBaare Crash importing alembic asset over itself after saving it in Content Browser #fix Trivial nullptr + isValid fix #jira UE-34418 Change 3082433 on 2016/08/09 by Tom.Looman Updated list of supported platforms. #jira UE-34189 Change 3082423 on 2016/08/09 by Mitchell.Wilson Resaving levels to resolve MikkTSpace warnings Updating collision on SM_Floor_Round #jira UE-30786 Change 3082361 on 2016/08/09 by Keith.Judge Xbox One - Fix a controller disconnection crash. - This would only reproduce in VS2015 Update 3, and only when the controller is connected right from the start, not when a pad is plugged in later, so it seems copying the array of ^ pointers wasn't incrementing the refcounts correctly and causing things to be deleted too early. - Changed it to copy each connected pad object one at a time, which maintains the correct refcount. - Possibly a VS2015 Update 3 bug. #jira UE-33955 Change 3082341 on 2016/08/09 by Mitchell.Wilson Reimporting SM_GodRay_Plane Resaving levels to resolve MikkTSpace warnings Resaving multiple materials to resolve warnings #jira UE-34212 Change 3082313 on 2016/08/09 by Matthew.Griffin Only append BuildLabel to the publish dir if it's been set to something (end up with bad path for local build) Change 3082294 on 2016/08/09 by Jurre.deBaare Crash when importing an Alembic file with Materials as a different asset type than one that already exists #fix Ensure that we have a valid material to assign to the assets #jira UE-34377 Change 3082291 on 2016/08/09 by Jurre.deBaare Unable to save Alembic asset with materials after importing more than once #fix Make sure we delete referenced transient materials if they are not used #jira UE-34400 Change 3082290 on 2016/08/09 by Jurre.deBaare Crash importing abc file as Geometry Cache over another used in level with World Normal view mode on #fix Make sure we always update the GeometryCacheComponents, will change this set-up in 4.14 #jira UE-34392 Change 3082274 on 2016/08/09 by Benn.Gallagher Moved FABRIK debug draw out of the native node into the graph node. It will no longer draw in-game, only in Persona previews. Debug drawing is not supported outside of the game thread currently so we can't do it in EvaluateBoneTransforms. #jira UE-29780 Change 3082273 on 2016/08/09 by Benn.Gallagher Improved anim dynamics chain handling with LODs, now a chain will continue to simulate any bodies that can be reached from the root body instead of disabling the whole chain #jira UE-30827 Change 3082270 on 2016/08/09 by Benn.Gallagher Moved source indices for active transitions out of editor only so we can identify them at runtime. This allows the transition ratio anim getter function to get the correct elapsed time instead of trying to infer it which is incorrect when the transition is interuppted. #jira UE-29180 Change 3082257 on 2016/08/09 by Jurre.deBaare Auto align floor mesh does not work in Persona #fix Readded functionality for the auto alignment :) #jira UE-34404 Change 3082239 on 2016/08/09 by Peter.Sauerbrei make sure IPP and supporting dlls are all 64-bit #jira UE-34408 Change 3082225 on 2016/08/09 by Mitchell.Wilson Removing r.Streaming.PoolSize from DefaultEngine.ini, adding DefaultScalability.ini to set r.StreamingPoolSize Reimporting SM_GodRay_Plane Saving all levels to resolve MikkTSpace warnings. #jira UE-30787 Change 3082222 on 2016/08/09 by Rolando.Caloca UE4.13 - Fix crash on opengl3 - Load proper shader map depending on feature level - int interpolators require nointerpolation modifier #jira UE-33879 Change 3082221 on 2016/08/09 by Benn.Gallagher Fix for stack overflow traversing subinstances for duplicated names when there is a circular loop #jira UE-34384 Change 3082179 on 2016/08/09 by Ben.Woodhouse Fix for default subsurface color for two sided foliage, so it defaults to black instead of white. This requires some additional logic because we don't want to change the default color for other lighting models which use the subsurface material input (e.g. subsurface, skin, hair etc). Bump the shader version so the change is correctly propagated to existing material shaders. #jira UE-31461 Change 3082170 on 2016/08/09 by Graeme.Thornton Manual copy of CL 3078836 from Dev-Core to Release-4.13 Silently skip creating exports from a package where the outer is also an export and has been filtered at runtime during loading #jira UE-33909 Change 3082169 on 2016/08/09 by Graeme.Thornton Make FLauncherTasks have unique names so we don't end up with stat name collisions #jira UE-33849 Change 3082163 on 2016/08/09 by Matthew.Griffin Include Linux Build Tools in Windows Installed Build so that Crash Reporter can be staged from receipts Added Checks for files that might not exist when creating Installed Build from Github etc. Tag the published installed build zips #jira UE-34249 Change 3082139 on 2016/08/09 by Ben.Marsh BuildGraph: Allow writing a schema without passing a script in. Change 3082109 on 2016/08/09 by Thomas.Sarkanen Fixed blendspaces producing bad data when degenerate spaces are present Delaunay triangulations that fail now revert to simple degenerate tesselation. This allows us to build a valid set of grid samples even with degenerate triangulations, so no need for any runtime modifications. #jira UE-34308 - 2DAimOffset mesh skews across viewport when anim sequence is added to offest graph Change 3082080 on 2016/08/09 by Matthew.Griffin Added notifications for available triggers Change 3082054 on 2016/08/09 by Allan.Bentham Quality level override changes to high QL are now correctly picked up. #jira UE-22812 Change 3082049 on 2016/08/09 by Allan.Bentham Update shaders when mobile preview device is changed. #jira UE-22810 Change 3081866 on 2016/08/09 by Max.Chen Fbx Export: Fix build. #jira UETOOL-750 Change 3081863 on 2016/08/09 by Max.Chen Fbx Export: Fix level sequence fbx export. - Fix 3d transform track export so that it does the correct flipping for translation and rotation curves. - Fix setting rich curve tangents and interpolation modes. - Fix camera focal length export. #jira UETOOL-750 Change 3081823 on 2016/08/08 by Dmitriy.Dyomin Fixed: Crash when simulating in editor with a landscape actor selected #jira UE-34367 #coderview Gareth.Martin Change 3081647 on 2016/08/08 by Chad.Taylor OpenVR changed to work with our FSteamVRHMD::VRGetGenericInterfaceFn retrieved from GetDllExport #jira UE-34352 Change 3081645 on 2016/08/08 by Zak.Middleton #ue4 - Fix anim root motion applying too much velocity to CharacterMovement when framerate is low causing moves to be substepped, or when movement mode changes during root motion playback. #jira UE-30178 Change 3081639 on 2016/08/08 by Tyler.Cole Update build scripts for WEX MCP in UE4 Release-4.13 stream. #jira NONE-0 Change 3081616 on 2016/08/08 by Jeff.Fisher UEVR-13 PSVR: TCR Requirements -2dvr support "stereo on" and "stereo off" now switch ps4 from 2d to vr mode. -A new ini setting for morpheus bStartInVR has been added, it defaults to true. #jira UEVR-13 #review-3081284 @chad.taylor @nick.whiting Change 3081597 on 2016/08/08 by Tyler.Cole Update build scripts for Ocean MCP in UE4 Release-4.13 stream. #jira NONE-0 Change 3081476 on 2016/08/08 by Tyler.Cole Update build script for UE4 Release-4.13 stream Fortnite MCP. #jira NONE-0 Change 3081397 on 2016/08/08 by Josh.Adams - Fixing more linux case issues in UT #jira ue-33478 Change 3081391 on 2016/08/08 by Mitchell.Wilson Removed ConstructorHelpers from TP_2DSideScrollerCharacter.cpp. Added Run and Idle animations to BP child of 2dSideScrollerCharacter in 2DSideScrollerExampleMap #jira UE-33843 Change 3081383 on 2016/08/08 by Aaron.McLeran #jira UE-34081 Implementing CL 3076637 into 4.13 #tests run a procedural sound wave object test Change 3081337 on 2016/08/08 by Aaron.McLeran #jira UE-34390 CLONE - CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay - OR-26580 - Implementing CL 3071258 to 3.13 #tests ran paragon with change, no crashes Change 3081335 on 2016/08/08 by Max.Preussner WmfMedia: Fixed memory leak in source resolver (UE-34385) #jira UE-34385 Change 3081320 on 2016/08/08 by Max.Preussner WmfMedia: Fixed typo (UE-32421) #jira UE-32421 Change 3081276 on 2016/08/08 by Mitchell.Wilson Resaving asset to resolve MikkTSpace warning. #jira UE-31116 Change 3081269 on 2016/08/08 by Dan.Oconnor Fix for name of blueprint changing when 'accept source' is used. Just caching the original name before unloading the blueprint #jira UE-34324 Change 3081052 on 2016/08/08 by Dan.Oconnor Making a change to test UE-34324 #jira UE-34324 Change 3081026 on 2016/08/08 by Daniel.Wright Added a heightfield painting example to BlueprintRenderToTarget content example #jira UE-34323 Change 3081025 on 2016/08/08 by Daniel.Wright CreateRenderTarget2D uses a world context object as owner, allows use in a construction script #jira UE-34321 Change 3081023 on 2016/08/08 by Aaron.McLeran #jira UE-34325 Implementing 3080958 in 4.13 - When a sound buffer is flushed from audio device manager and tries to stop sounds using a resource, was possible for the async header parse task to be in-flight, which would cause a crash - Fix is to bring back the code to call EnsureCompletion on tasks in the FreeResoruces function of the sound source object. This will potentially encure a slight perf increase when stopping a sound but audio engine is now going to run on a separate thread, so shouldn't have a game-thread impact in non-editor builds. #tests ran repro case described in bug several times without crashing (was 100% repro) Change 3081020 on 2016/08/08 by Dan.Oconnor Revised fix for UMG widgets with instanced properties resetting due to ImportText not copying objects assigned to Instanced properties #jira UE-26310 Change 3081010 on 2016/08/08 by Dan.Oconnor Fix for losing root transform when recycling objects #jira UE-28398 Change 3080972 on 2016/08/08 by Mark.Satterthwaite Duplicate CL #3080684: Flush on close of writable files on Apple platforms - close doesn't guarantee to push outstanding writes to the disk, only to the kernel. They might not make it to the disk prior to program termination. #jira UE-21857 Change 3080971 on 2016/08/08 by Mark.Satterthwaite Workaround a macOS 10.12 Beta bug on some Metal drivers that can't initialise temporary/local variable arrays, only those that are marked threadgroup shared. #jira UE-34355 Change 3080923 on 2016/08/08 by Michael.Trepka When archiving on for Mac delete the dest icon if it exists before trying to call File.Move #jira UE-33304 Change 3080919 on 2016/08/08 by samuel.proctor Revised assets for Blueprint Debugging tests #jira UE-29618 Change 3080878 on 2016/08/08 by Ben.Marsh Fix sample build timeouts due to generating DDC using installed engine builds taking too long. * New version of build script was not copying the DDCUtils module from the NotForLicensees folder to the installed engine directory, so network DDC was not being used. Set it from an environment variable instead. * Generating the installed project PAK was not using the Compressed.ddp file included with the engine, but was looking for a legacy DDC.ddp file instead. Change 3080849 on 2016/08/08 by Marc.Audy Always stop matinee sounds when jumping around, not just if the sound changed. #jira UE-31447 Change 3080843 on 2016/08/08 by Ben.Marsh BuildGraph: Fix compile error due to duplicated variable name. Change 3080840 on 2016/08/08 by Max.Chen Fbx: Fix rich curve export being exported at the incorrect times when baked. #jira UETOOL-750 Change 3080824 on 2016/08/08 by Max.Chen Sequencer: Revert fix root component structure for level sequence actor. #jira UE-34354 Change 3080819 on 2016/08/08 by Chad.Taylor Merging Move and Vive haptic implementation from Dev-VR to Release-4.13 #jira UE-27886 Change 3080818 on 2016/08/08 by Jurre.deBaare Crash when importing the same Alembic file but as a different Asset Type #fix Return the outer package of an imported asset, instead of InParent (which could be deleted/clean up if the import types differed) #misc Typo #jira UE-34293 Change 3080817 on 2016/08/08 by Jurre.deBaare Crash when importing an Alembic file with Materials if it already exists #fix Only create materials if they don't already exist #jira UE-34300 Change 3080814 on 2016/08/08 by Jurre.deBaare Crash when importing Alembic files as Skeletal Mesh #fix Set the NumVertices variable that was re-added :) #misc removed dead code #jira UE-34288 Change 3080813 on 2016/08/08 by Jurre.deBaare [CrashReport] UE4Editor_AlembicLibrary!AbcImporterUtilities::GenerateSmoothingGroupsIndices() #fix found in one of the reports messages that they were importing from 3DS, found that it exports the normals non-indiced but per-vertex, so now added expanding using the index buffer (also pre-emptively added it for UVs) #jira UE-34294 Change 3080797 on 2016/08/08 by Dmitriy.Dyomin Fix: Crash opening levels with landscape in them via the command console in standalone game #jira UE-34348 Change 3080784 on 2016/08/08 by Jamie.Dale We now keep the bulk data for stock engine fonts loaded to avoid attempting to load it on the render thread (from debug canvas rendering) #jira UE-34298 Change 3080734 on 2016/08/08 by Matthew.Griffin Made PDBs optional build products for CsCompile task and added .dll.mdb check for Mac Mono equivalent Change 3080685 on 2016/08/08 by Peter.Sauerbrei fix for crash on tvOS and iOS when launching a project #jira UE-34005 Change 3080683 on 2016/08/08 by Matthew.Griffin Added code to duplicate GUBP behavior when building DDC for samples so that only certain platforms are built Change 3080681 on 2016/08/08 by Matthew.Griffin Corrected path separators for Mac DDC location, which was preventing it from being included in installed build Change 3080675 on 2016/08/08 by Robert.Manuszewski Fixing CIS on Clang platforms #jira UE-34025 Change 3080674 on 2016/08/08 by Ben.Woodhouse Fix for reflection capture crash on autosave (null scene ptr) - integrate fix from fortnite CL 3033507 #jira UE-32651 Change 3080594 on 2016/08/08 by Keith.Judge Xbox One - Fix missing GPU particles when in Fast Semantics mode. SetRasterizerState() shouldn't be cached as it always needs resetting in Fast Semantics. Also enabled Fast Semantics by default, as the last known bug is now fixed. #jira UE-31607 Change 3080573 on 2016/08/08 by Martin.Wilson Fix Root Motion from Everything blending incorrectly when using layered blend per bone #Jira UE-17815 Change 3080517 on 2016/08/08 by James.Golding PR #2678: Fixed ProceduralMeshComponent compile issue, missing ConvexElem.h. (Contributed by ardneran) #jira UE-34299, UE-34279 Change 3080512 on 2016/08/08 by Benn.Gallagher Fix for dangling sub-instance pointers when reinstancing on AnimBP compile #jira UE-34137 Change 3080510 on 2016/08/08 by Max.Preussner WmfMedia: Fixed Packaged Shooter game does not load in Windows XP (UE-32421) #jira UE-32421 Change 3080509 on 2016/08/08 by Robert.Manuszewski Added more detailed message when TArray's BulkSerialize fails. #jira UE-34025 Change 3080506 on 2016/08/08 by Allan.Bentham Do not set render target if there are no modulated shadows. #jira UE-33252 Change 3080498 on 2016/08/08 by Keith.Judge Fix D3D12.x link error. #jira UE-34322 Change 3080493 on 2016/08/08 by Matthew.Griffin Allow symbol files to be skipped when staging build products as they are not essential for the staged project to run. #jira UE-34073 Change 3080490 on 2016/08/08 by Maciej.Mroz #jira UE-28625 Direction of GetOverlapInfos parameter doesn't match Redone cl# 3080484 Change 3080462 on 2016/08/08 by Allan.Bentham Leave FAndroidAppEntry::PlatformInit's ES2 EGL initialised unless vulkan or ES3.1 are required. Fix initialisation errors introduced in CL 3070035. #jira UE-34099 Change 3080242 on 2016/08/07 by Max.Chen Sequencer: Fix to allow deleting spawnables from the viewport #jira UE-28523 Change 3080241 on 2016/08/07 by Dmitriy.Dyomin Fixed: StartCameraFade not fading camera when MobileHDR is off #jira UE-34143 Change 3079990 on 2016/08/06 by andrew.porter Changing defaults on some settings on M_Details for test case. #jira UE-29618 Change 3079989 on 2016/08/06 by andrew.porter Setting two sided off on M_Details material #jira UE-29618 Change 3079986 on 2016/08/06 by phillip.patterson Updated QA-Foliage for test case #jira UE-29618 Change 3079984 on 2016/08/06 by andrew.porter Adding test content for using sprites in UMG #jira UE-29618 Change 3079879 on 2016/08/05 by Dmitry.Rekman Remove HITCHHUNTER logspam from release UE (UE-30959). #tests Compiled the UE4Editor. #jira UE-30959 Change 3079815 on 2016/08/05 by Tyler.Cole Set dependencies for Orion MCP in UE4 Release-4.13 stream. #jira NONE-0 Change 3079808 on 2016/08/05 by Daniel.Wright BlueprintRenderToTarget content example map with interactable fluid surface #jira UE-34323 Change 3079746 on 2016/08/05 by Daniel.Wright Copy - New blueprint function ClearRenderTarget2D, which is the only way to set a render target alpha directly New blueprint function CreateRenderTarget2D #jira UE-34321 Change 3079569 on 2016/08/05 by Mitchell.Wilson Updating template tutorials after assets were moved to new folders #jira UE-34139 Change 3079546 on 2016/08/05 by Ian.Shadden #UE4 #match3 Fixed button UI scaling on all buttons in Match3 (main menu, victory screen, options, notifications, etc...), tested on PC and Android Nexus 6 #jira UE-34316 Change 3079542 on 2016/08/05 by Mark.Satterthwaite Duplicate CL #3079503: Initialise more variable types to 0 in Metal shaders to workaround Xcode 8 toolchain no longer doing this for us for "threadgroup shared" variables. Everything but structs and atomic's will now be initialised. #jira UE-33856 Change 3079472 on 2016/08/05 by Peter.Sauerbrei fix for remote server name being empty stopping a build for a BP project in binary fix for several error messages from platform requirements not stopping a build #jira UE-34213 Change 3079453 on 2016/08/05 by Benjamin.Hyder Updating QA_Materials to include Material Details example #jira UE-29618 Change 3079389 on 2016/08/05 by Gareth.Martin Missing file from CL 3079376: Tessellate Landscape only in highest landscape LOD Fix incorrect UV coordinates when tessellation is enabled #jira UE-14253 #jira UE-20405 Change 3079384 on 2016/08/05 by Michael.Trepka PR #2266: BUGFIX: UBT not building on non HFS partitions on OSX (Contributed by Manny-MADE) #jira UE-29358 Change 3079376 on 2016/08/05 by Gareth.Martin Tessellate Landscape only in highest landscape LOD Fix incorrect UV coordinates when tessellation is enabled #jira UE-14253 #jira UE-20405 Change 3079365 on 2016/08/05 by Peter.Sauerbrei fix for executable name mismatch in plist vs actual executable when project has an underscore in the name #jira UE-34192 Change 3079361 on 2016/08/05 by Ryan.Vance #jira UE-34297 Fixing the screen space position in 3076326 broke an ISR dbuffer decal hack. Now, no longer a hack :) Change 3079349 on 2016/08/05 by Mason.Seay Deleting unneeded assets #jira UE-29618 Change 3079306 on 2016/08/05 by Peter.Sauerbrei IPP is now built as a 64-bit executable #jira UE-26393 Change 3079303 on 2016/08/05 by Peter.Sauerbrei PR2018 - disable user input request from ssh courtesy of Teivaz #jira UE-26393 Change 3079276 on 2016/08/05 by mason.seay Extended Line Trace For Convenient #jira UE-29618 Change 3079274 on 2016/08/05 by Alex.Delesky #jira UE-32396, UE-34103 - Fixed the issue where STextBLock widgets will revert to a gray-ish color in widget blueprints on compilation when set to magenta (#FF00FFFF). This fix does not introduce the side-effects of recoloring the text on editor buttons. Change 3079273 on 2016/08/05 by Max.Chen Sequencer: Fix converting matinee move tracks that have separate pos and euler tracks. #jira UE-34301 Change 3079254 on 2016/08/05 by Ori.Cohen Fix skeletal mesh having bodies in both sync and async scene. Simplifies a lot of code and fixes crash in case of substepping. #JIRA UE-34224 Change 3079242 on 2016/08/05 by Nick.Darnell Slate - Initializing WheelScrollMultiplier in the STableViewBase to avoid problems with subclasses not having an initialized value and the scrollbar misbehaving. #jira UE-34304 Change 3079129 on 2016/08/05 by Jurre.deBaare #jira UE-34278 #fix Changed reimport path to be the same as geometry cache / skeletal mesh Unable to reimport Alembic static meshes #jira UE-34292 #fix Handle cancelled situation during reimport ui interaction Cancelling the reimport of an Alembic file seems to confirm the action #jira UE-34288 #fix Possible fix, flush rendering commands before importing Crash when importing Alembic files as Skeletal Mesh #jira UE-34282 #fix Change import function override signature to include bCancelled and set the value appropriately + early out when cancelled "Failed to Import" message when clicking Cancel on the Alembic Import Message Change 3079127 on 2016/08/05 by Marc.Audy Properly clean up all worlds when ending PIE while a seamless transition is active #jira UE-33863 Change 3079107 on 2016/08/05 by Mike.Beach Reversing the order in which we iterate pins on node resonstruction - making sure we reconstruct split child pins first (to keep the old parent pin chain intact). #jira UE-30548 Change 3079093 on 2016/08/05 by Jurre.deBaare Toggling Vertex Colors on in Static Mesh Editor makes the viewport all white #fix Hide the environment and sky when showing vertex colours #jira UE-34251 Camera Auto exposure in the static mesh editor bleaches everything out when the environment is turned off #fix Turn on / off advanced engine show flags determined by whether or not post processing is enabled in the advanced preview scene settings #jira UE-34206 Change 3079090 on 2016/08/05 by Jurre.deBaare Bad performance when changing (slider) values for the advanced preview scene #fix Could not repro but added some more check if update needed checks #jira UE-33496 Adjusting Lighting Rig Rotation manually only affects the sky and not the lighting #fix Add the rotational delta for the sky to the directional light rotation #jira UE-34108 Change 3079088 on 2016/08/05 by Jurre.deBaare Alembic Cache Importer option for Hard Edge Angle Threshold does not work #fix Changed the condition for an edge to be hard / soft, fixed an issue in the smoothing group generation and changed the flow of normal calculation during importing #jira UE-34127 Change 3079040 on 2016/08/05 by Max.Preussner MediaAssets: Fixed media source asset cannot be inherited in other modules (UE-34290) Also made class properties blueprint read-writable #jira UE-34290 Change 3078958 on 2016/08/05 by Marc.Audy Don't ever reregister child actor components Don't destroy child actors when hiding a level #jira UE-31038 Change 3078954 on 2016/08/05 by ryan.brucks #jira ue-00001 Adding new material functions needed to go along with Noise Blog post requested by DanV and KimL Change 3078952 on 2016/08/05 by Phillip.Kavan [UE-34085] Fix an ensure when force-deleting compiled Blueprint class assets in the Content Browser. change summary: - modified ForceDeleteObjects() to relocate a redundant 'ObjectsToReplace' iteration that recently was converted to a ranged-based for loop; the conversion seems to have caused the iterator to ensure, due to existing code that was modifying the target array inside the loop. #jira UE-34085, UE-34169 Change 3078912 on 2016/08/05 by Andrew.Rodham Editor: When locking an editor viewport to a camera, camera cut flags are now correctly specified #jira UE-33875 Change 3078900 on 2016/08/05 by Lauren.Ridge Fix for small Vive HMD movements entering VR mode #jira UE-33970 Change 3078880 on 2016/08/05 by Jack.Porter Cannot set GenerateOverlapEvents flag on Landscape #jira UE-9055 Change 3078879 on 2016/08/05 by Lee.Clark PS4 - Fix corrupted debuffer decals (CMask wasn't getting decoded correctly) #jira UE-34273 Change 3078871 on 2016/08/05 by Steve.Robb Fix for changes to UObject*s in property boxes. #jira UE-29596 Change 3078857 on 2016/08/05 by Max.Chen Sequencer: Set Fixed frame interval playback to false by default. #jira UE-34272 Change 3078850 on 2016/08/05 by mason.seay Updated map to test physics mesh, added comments to level BP #jira UE-29618 Change 3078795 on 2016/08/05 by Andrew.Rodham Sequencer: Fixed spawnables not responding to blueprint reinstance events This ultimately left spawnable bindings broken, and an unreachable object in the world #jira UE-31635 Change 3078786 on 2016/08/05 by Robert.Manuszewski Reversed the order the UObject delete listeners were notified of UObject deletion to avoid skipping the next listener if the current one removed itself from the array. #jira UE-33872 Change 3078782 on 2016/08/05 by Andrew.Rodham Sequencer: Fixes to "Create Camera Here" functionality Fixed crash when undoing the "Create Camera Here" operation. Enabled RF_Transactional on all spawned instances in the world (to support undo/redo of instance properties properly) Fixed issues when the cursor was outside of the play range #jira UE-33127 Change 3078737 on 2016/08/05 by Andrew.Rodham Sequencer: Changed event and playback contexts to be weak references to ensure no strong GC references, while maintaining safety #jira UE-34256 Change 3078722 on 2016/08/05 by Ben.Woodhouse Fix shader compile error in TP_VirtualRealityBP (disable Morpheus, which was enabled (inadvertently?) in CL 3077481) #jira UE-34269 Change 3078620 on 2016/08/05 by Dmitriy.Dyomin Fixed: SunTemple geometry has rendering artifacts on low end devices [Android_Low] devices will use 'Low' material quality level #jira UE-22455 Change 3078584 on 2016/08/05 by James.Golding Add NumVertices back to FSkelMeshSection, so that info is available in non-editor builds (e.g. for runtime mesh merging) #jira UE-33675 Change 3078565 on 2016/08/05 by Jack.Porter Removed need for LandscapeInfo in GeneratePlatformPixelData which was crashing mobile previewer. #jira UE-33842 Change 3078564 on 2016/08/05 by James.Golding Fix display name for bSupportUVFromHitResults to fix missingspace #jira UE-34248 Change 3078542 on 2016/08/05 by Yannick.Lange VR Editor : Temporary fix to disable the possibility of both controllers having a windows docked. #jira UE-32839 Change 3078541 on 2016/08/05 by Yannick.Lange VR Editor : Fix linux compile error from VREditorAvatarActor #jira UE-34215 Change 3078396 on 2016/08/04 by Max.Chen Sequencer: Invalidate playback context when map changes. #jira UE-34256 Change 3078291 on 2016/08/04 by Jeff.Campeau RHI compress/decompress return success/failure Failure falls back to software method D3D12 for Xbox One still needs implementation #jira UE-31363 Change 3078131 on 2016/08/04 by Chris.Babcock Deal with missing Android movie framerate by defaulting to 30 if not available #jira UE-34208 #ue4 #android Change 3078084 on 2016/08/04 by John.Billon Disabled AMD hacks Cvars that aren't needed anymore. #Jira UE-30772 Change 3078083 on 2016/08/04 by John.Billon Consolidated ensures to detect a crash dealing with unallocated render targets in TranslucentLighting to a single test in DefferedShadingRendere and attempt to recover by reallocating deferred render targets. Added a couple of more ensures when allocating render targets. Added log message when changing feature levels. #Jira UE-32536 #Jira UE-32204 Change 3078039 on 2016/08/04 by Josh.Adams - Fixed a case issue with Linux #jira UE-33478 Change 3078029 on 2016/08/04 by Ryan.Vance #jira UE-30989 We need to disable the hmd mask when down sampling to ensure valid input data for blur passes. Change 3078027 on 2016/08/04 by Lina.Halper Fix sequencer morphtarget displaying issue #code review:Max.Chen #jira: UE-28459 Change 3078012 on 2016/08/04 by mason.seay map and asset updates for testing UV hit detection #jira UE-29618 Change 3078009 on 2016/08/04 by Jamie.Dale Ensured that BULKDATA_SingleUse is only set by UFontBulkData::Serialize when loading This prevents it being incorrectly set by other operations, such as counting memory used by font data. #jira UE-34252 Change 3078006 on 2016/08/04 by Mark.Satterthwaite Duplicate CL #3064008 & CL #3077412: Fix "iOS Metal-based build crashes at launch with sub-levels": - Slate should not bind the null RHI texture from an unitialised texture atlas - atlases only have a valid texture pointer once an entry has been added to them and in the template projects an empty sub-level doesn't add anything. - To prevent this kind of bug resurfacing and being so hard to track down add Metal shader binding validation to our validation layer as Apple's is incomplete on iOS and won't warn us about nil texture usage which causes these GPU restarts. This requires reworking our vertex declaration handling to be more efficient so that we can cache the pipeline reflection data as well as the pipeline objects. - Fix validation error of texture reallocation on loading template projects under Metal. #jira UE-30847 Change 3078002 on 2016/08/04 by John.Billon Fixed LowLightMapQuality warning triggering with wrong conditions. #Jira UE-33237 Change 3078001 on 2016/08/04 by John.Billon Fixed a crash due to particle threading issues in packaged game. #Jira UE-32147 Change 3077989 on 2016/08/04 by Rolando.Caloca UE4.13 - Fix Vulkan crash when compiling shaders on a new project due to running out of descriptor sets. Now we handle fragmentation of sets and multiple pools per RHI contexts. #jira UE-34218 Change 3077940 on 2016/08/04 by Jeff.Campeau Stage applocal dependencies from paths containing $(EngineDir) & $(ProjectDir) Include copies of the VS2015 runtime and UCRT Change -applocaldir parameter to -applocaldirectory Stage to engine and project binaries paths (for crash reporter, etc.) #jira UE-33903 Change 3077936 on 2016/08/04 by Daniel.Wright DrawMaterialToRenderTarget gracefully handles an invalid WorldContextObject #jira UE-34183 Change 3077927 on 2016/08/04 by Lina.Halper Fix issue with morphtarget not working due to invalid guid #jira: UE-34077 Change 3077919 on 2016/08/04 by Daniel.Wright Copy - Lighting channels can now be edited on components with static mobility, since dynamic lights can still affect them #jira UE-34245 Change 3077877 on 2016/08/04 by Ori.Cohen Fix physical animation undo/redo not affecting linked bodies and constraints #JIRA UE-33987 Change 3077823 on 2016/08/04 by Ori.Cohen Disable copy/paste action on physical animation profiles (From Matt.Kuhlenschmidt) #JIRA UE-33985 Change 3077814 on 2016/08/04 by Uriel.Doyon Changed the logs used in the "Texture Streaming Build". Previous warnings are now logged at verbose level. Can be toggled on by running "log texturestreamingbuild all" #jira UE-34120 #review-3077812 Change 3077781 on 2016/08/04 by Max.Chen Sequencer: Fix crash in rotation key struct #jira UE-34155 Change 3077771 on 2016/08/04 by Lina.Halper Added const and removed auto #jira: UE-33023 Change 3077702 on 2016/08/04 by Daniel.Wright Copy - Planar reflection show flags can now be edited #jira UE-34229 Change 3077585 on 2016/08/04 by Ori.Cohen Fix spam when moving simulated skeletal mesh in the editor. #JIRA UE-34164 Change 3077532 on 2016/08/04 by Tom.Looman Fixed error in description of VR Template. #jira ue-33950 Change 3077517 on 2016/08/04 by Tom.Looman Fixed parsing error for FP_VirtualRealityBP #jira UE-34059 Change 3077493 on 2016/08/04 by Tom.Looman Updated Template description to remove GearVR reference and include more clear message on the two available maps. #jira UE-33950 Change 3077492 on 2016/08/04 by Tom.Looman Improvements to VR Template Fixed teleportation issue on both locomotion types (JIRA) Rebuilt navmesh for motioncontrollermap Added new WIP startermap to clarify the difference between the multiple levels. Added more comments and did some cleanup in BPs. #jira UE-33962 Change 3077491 on 2016/08/04 by Jurre.deBaare Crash when attempting to merge two objects using Simplygon - ProxyMaterialUtilities::CreateProxyMaterialInstance #fix Pass in complete path to save material to instead of just the name #jira UE-34211 Change 3077481 on 2016/08/04 by Tom.Looman Workaround for issue in teleport camera fade. (Removing r.MobileHDR from config) #jira ue-34143 Change 3077463 on 2016/08/04 by Ben.Woodhouse Fix for ghosting in the SSR, caused by the SSRTemporal pass not getting velocities passed in. This is only an issue when temporal AA is disabled. There is a performance in this case, because a velocity pass is now required if SSR is enabled and temporalAA/motion blur are off. #jira UE-32843 Change 3077432 on 2016/08/04 by Steve.Robb Removal of Fortnite-specific setting which disables hot reload. #jira UE-33261 Change 3077380 on 2016/08/04 by Keith.Judge Fix for green reflection environment in some maps. - Moved deleting pending resources from EndFrame() to RHIEndDrawingViewport() so it *really* gets called once every time there's a Present() - Fixed a validation error when locking cube map faces which was causing them not to be updated. - Fixed a validated driver error when creating UAVs due to uninitialised parts of the descriptor and fixed the buffer description for occlusion queries to have the correct 256 byte size (another validation error). - Added a GPU/CPU sync at the same point the PS4 code does. #jira UE-32086 Change 3077336 on 2016/08/04 by Mitchell.Wilson removed r.Streaming.PoolSize from DefaultEngine.ini Adding DefaultScalability.ini and adding r.StreamingPoolSize to resolve a warning. #jira UE-30941 Change 3077275 on 2016/08/04 by Phillip.Kavan [UE-29903] Fix a potential infinite loop when replacing variable nodes in a Blueprint graph via drag-and-drop. #jira UE-29903 Change 3077119 on 2016/08/04 by Marc.Audy Use TickType All when in PIE #jira UE-18982 Change 3077108 on 2016/08/04 by Jon.Nabozny Add check to USkeletalMeshComponent::TickClothing to skip updating cloth when SkeletalMesh is null. This can happen when the mesh is cleared between USkeletalMeshComponent::TickComponent and USkeletalMeshComponent::TickClothing. #jira UE-34032 Change 3077073 on 2016/08/04 by Jurre.deBaare bBlendOverlappingNormals does not seem to have an impact for Alembic importing #fix this wasn't being used in the normal calculation anymore so redundant #jira UE-34204 Change 3077059 on 2016/08/04 by Robert.Manuszewski Disabling the assert when MaxObjectsInEditor or MaxObjectsInGame collide with EInternalObjectFlags as this is no longer relevant (since the serial number and object flags were split). #jira UE-34200 Change 3077024 on 2016/08/04 by Thomas.Sarkanen Added GetResourceSize to UDataAsset Data assets now correctly report their size. #jira UE-28851 - Fix mem reporting of DataTables Change 3077001 on 2016/08/04 by Andrew.Rodham Sequencer: Fixed sequencer adding spawnables into recorded worlds twice The issue here is that sequencer was re-evaluating itself with the current play world as the context, which also happened to be the world that it was trying to record. As a result, it ended up with the same sequence being played twice in the recording world. Added the ability to specify a playback context attribute for sequencer to use, and this no longer allows sequencer to play back in any worlds that are being recorded. #jira UE-31422 Change 3076995 on 2016/08/04 by Matthew.Griffin Fixed Shadow Variable warning Change 3076974 on 2016/08/04 by Matthew.Griffin Added Node to build CrashReportClient for Linux that can be used by internal game targets Change 3076820 on 2016/08/04 by Max.Chen Sequencer: Fix EDL export timing so that shot in time always start at 0 since movies are always rendered at their cut length (until shot handle exports exist). #jira UE-34199 Change 3076665 on 2016/08/03 by Dan.Oconnor Quick fix for regression introduced by 3075803. Crashing on load of some games because some tickables don't expect GetTickableGameObjectWorld to be called when IsTickable returns false #jira UE-18982 Change 3076569 on 2016/08/03 by Chad.Taylor SteamVR GetOrthoProjection implementation to fix broken console rendering in VR #jira UE-21424 Change 3076556 on 2016/08/03 by Aaron.McLeran #jira UE-34154 PSVR Stereo assets are spatialized as MONO - All audio was routing through A3D lib regardless of if it was mono/stereo etc. - Fix is to only route audio that is mono and spatialized - Fixed some compile errors/shadow variables - Renamed bIs3dSound to bIsA3dSound to indicate its a bool that flags if it is spatialized through A3D library Change 3076546 on 2016/08/03 by Aaron.McLeran #jira OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves Implementing 3069092 in Release-4.13 - Not all active sounds have sound classes, was causing a crash #tests Run game with stat soundcues and not crash Change 3076512 on 2016/08/03 by Ben.Marsh Fix warning about UnrealTournament:true argument. Change 3076492 on 2016/08/03 by Daniel.Wright Integrate - Disallowed DrawMaterialToRenderTarget and Begin/EndDrawCanvasToRenderTarget in construction scripts, since they don't work in game. Blutilities can be used to do blueprint rendering in the editor. #jira UE-34177 Change 3076491 on 2016/08/03 by Daniel.Wright Marked the Forward Shading project setting as experimental for 4.13 #jira UE-34176 Change 3076490 on 2016/08/03 by Daniel.Wright Integrate - Fixed crash rendering translucency with translucent shadows which were determined to be invisible #jira UE-34175 Change 3076489 on 2016/08/03 by Daniel.Wright Integrate - Now clamping light MinRoughness to .04 to avoid NaNs from Vis_SmithJointApprox on materials with Roughness 0 #jira UE-34174 Change 3076485 on 2016/08/03 by Daniel.Wright Integrate - Restored DetailMode changes causing a FGlobalComponentRecreateRenderStateContext - accidental removal from cl 2969413 #jira UE-34173 Change 3076440 on 2016/08/03 by Ryan.Vance #jira UE-34184 Merging 3060975, 3061888, 3072758 and 3076270 from devvr to rev Oculus sdk. Adding Oculus 1.6 support. Change 3076399 on 2016/08/03 by Nick.Darnell Slate - The LayoutCache pointer in SWidget is now a WeakPtr. This had to be done to handle edge cases where widgets were used in a pool, and placed into invalidation panels that had been deleted in the past, but were later invalidated with bogus pointers to long gone invalidation panels. Also making a tweak to WidgetCache, to update the lasthittestindex to be the one passed in, which is a bit closer to the intended behavior. #jira UE-34185 Change 3076397 on 2016/08/03 by Rolando.Caloca UE4.13 - hlslcc -Fix for hlsl length(float) #jira UE-32629 Change 3076337 on 2016/08/03 by mason.seay Test assets (and map for ensure bug) #jira UE-29618 Change 3076332 on 2016/08/03 by Peter.Sauerbrei fix for clang build errors #jira UE-34163 Change 3076326 on 2016/08/03 by Ryan.Vance #jira UE-32975 Using the wrong screen position in the base pass pixel shader with ISR. Change 3076309 on 2016/08/03 by Benjamin.Hyder Renaming TEST-LightingFeatures to TM-LightingFeatures #jira UE-29618 Change 3076299 on 2016/08/03 by Chad.Taylor Fix SteamVR lag in late-update fold child renderables. #jira UE-33928 Change 3076214 on 2016/08/03 by Mitchell.Wilson Resaving BluperintOffice level to resolve MikkTSpace warnings. Reimporting SM_GodRay_Plane to resolve cook warning. #jira UE-30064 Change 3076112 on 2016/08/03 by Max.Chen Sequencer: Fix crash when opening multiple UMG assets (multiple map/unmap record selected actors actions) #jira UE-34167 Change 3076090 on 2016/08/03 by Marc.Audy Fix Mac compile error #jira UE-34163 Change 3076075 on 2016/08/03 by Jeremiah.Waldron Fixing comments documenting attribute in deleteFiles node for UPL #jira UE-34161 Change 3076034 on 2016/08/03 by Mitchell.Wilson Resaving Strategy Game maps to resolve MikkTSpace warnings. Resaving material in strategy game to resolve string asset reference warning. #jira UE-29720 Change 3076003 on 2016/08/03 by Mitchell.Wilson Resaving Elemental Demo levels to resolve MikkTSpace warnings. Resaving multiple materials to resolve String asset reference warnings. #jira UE-29679 Change 3075985 on 2016/08/03 by Jeremiah.Waldron Fixing UPL comments misnaming the deleteFiles node #jira UE-34161 Change 3075977 on 2016/08/03 by Maciej.Mroz #jira UE-30473 Moving child component in child blueprint forces parent to become dirty Duplicated from Dev-Blueprints CL 3075793 Change 3075959 on 2016/08/03 by Marc.Audy Don't add WorldSettings to the Actor list twice if it is net relevant (pointed out by PR #2639) #jira UE-33921 Change 3075891 on 2016/08/03 by Chad.Taylor SteamVR crash fixes related to new OpenVR SDK. Some of the DLL export functions were converted to inline. #jira UE-34142 Change 3075882 on 2016/08/03 by Dan.Oconnor Manually integrating 3073939 to address UE-19062 #jira UE-19062 Change 3075805 on 2016/08/03 by Marc.Audy Implement GetTickableGameObjectWorld() for various FTickableGameObject classes. Releated to CL#3075803 #jira UE-18982 Change 3075803 on 2016/08/03 by Marc.Audy Make FTickableGameObject only tick once per frame by associating them with a World, and for those unassociated with a World, ticking them after other levels have ticked #jira UE-18982 Change 3075761 on 2016/08/03 by Max.Preussner MediaAssets: Fixed crash and incorrect re-initialization of media texture resource (UE-34152) #jira UE-34152 Change 3075719 on 2016/08/03 by Chad.Taylor Blocker fix for binary editor crash on incorrectly used dll #jira UE-34142 Change 3075709 on 2016/08/03 by Jeremiah.Waldron Changing InXMLNamespace parameter back to "http://schemas.android.com/apk/res/android" which is what it used to be set to directly within AndroidPluginLanguage before the transition from APL to UPL parameterized it in the constructor #android #jira UE-34149 Change 3075695 on 2016/08/03 by Jurre.deBaare Adding missing debug zlib dll #jira UE-123 Change 3075641 on 2016/08/03 by Jurre.deBaare Crash when re-importing alembic cache file several times #fix Always create a new object when importing #jira UE-34130 Change 3075609 on 2016/08/03 by Danny.Bouimad #jira UE-29618 updating TM-PhysicalAnimProfiles to use both NumKeys and number keys. Tweaked values inline with testcase so very apparent what each Physical Animation setting does. Change 3075578 on 2016/08/03 by Mitchell.Wilson Updating attenuation settings for multiple sounds in Strategy Game. #jira UE-25828 Change 3075529 on 2016/08/03 by Trung.Le VREditor: Fxied foliage lasso select without pressing trigger #jira UE-33689 Change 3075502 on 2016/08/03 by Lee.Clark Copied from cl#3041664 - Removing UpdateActorPosition. This was not needed in a vast majority of use cases and was causing a crash due to multithreading issues during end of frame updates. #jira UE-28549 Change 3075386 on 2016/08/03 by Robert.Manuszewski Fixing bulkdata using source data pointer as an archive instead of raw data when saving #jira UE-34132 Change 3075384 on 2016/08/03 by mason.seay AnimBP for crash bug #jira UE-29618 Change 3075350 on 2016/08/03 by Max.Chen Sequencer: Added support for additive skeletal animations. Evaluate all overlapping skeletal animation sections. #jira UE-30506 Change 3075327 on 2016/08/03 by Max.Chen Sequencer: Fix root component structure for level sequence actor. This fixes an ensure that occurs when double clicking on a level sequence actor sprite in the viewport. #jira UE-34093 Change 3075313 on 2016/08/03 by Matthew.Griffin Tidied up hardcoded installed build includes so that they're all in one file with platform checks Added .dll.config files to CsCompile build products if they exist Change 3075133 on 2016/08/03 by Yannick.Lange VREditor : Original submit in Dev-VREditor = 3064489 - Fix crash when starting VREditor and then changing levels #jira UE-33766 Change 3075124 on 2016/08/03 by Thomas.Sarkanen Fixed undo/redo crash when editing anim blueprint defaults Serializing copy records out of the undo buffer returns them to their initial uninitialized state, with NULL cached container pointers. To address this, we re-initialize the anim blueprint when we undo/redo. #jira UE-34024 - Crash undoing variable change in Animation Blueprint. Change 3075101 on 2016/08/03 by Matthew.Griffin Adding job to selectively build games in release branch Also adding documentation and localization to overnight build #jira UEB-688 Change 3075061 on 2016/08/03 by Yannick.Lange VR Editor : Original submit in Dev-VREditor = 3062883 - Fixed bug that Laser extends beyond UI when hovered over Selection Bar or Close Button #jira UE-33552 - Fixed crash when Closing Editor (Alt F4 while in VR mode) #jira UE-32509 - Fixed crash when enabling VR Editor in editor preferences without a HMD connected - Fixed bug if you "slowly press" over UI selection bars or close buttons, nothing happens #jira UE-33553 - Avatar code refactor to its own actor class #jira UETOOL-812 #jira UE-33552, #jira UE-32509, #jira UE-33553, #jira UETOOL-812 Change 3075059 on 2016/08/03 by Allan.Bentham Fall back to standard shadows when capsule shadows are not supported. #jira UE-33344 Change 3075045 on 2016/08/03 by Matthew.Griffin Added copies of new OpenVR dlls to Binaries/ThirdParty folder to fix warnings in build DDC step Change 3074693 on 2016/08/02 by Dan.Oconnor Manually integrating 3070569 from Dev-Blueprints #jira UE-34119 Change 3074672 on 2016/08/02 by Dan.Oconnor Manually integrating 3061854 into 4.13 from Dev-Blueprints #jira UE-34119 Change 3074646 on 2016/08/02 by Aaron.McLeran #jira UE-34081 Implementing from Dev-Framework CL 3074325 Procedural Sound Wave Fails to Play when returning 0 bytes in GeneratePCMData callback - Returning 0 bytes in GeneratePCMData results in the procedural sound wave not continuing to play audio. Instead of returning 0, this change returns an empty buffer if the procedural sound wave doesn't have audio ready to generate (due to loading or some other issue). - Change also fixes a threading issue with QueueAudio queing audio on game thread but being consumed by audio device thread. - Implementing 3003851 from UT into Dev-Framework. Change 3074630 on 2016/08/02 by Brent.Pease UE-23846 - iOS Movie Player can't handle videos at resolutions that aren't multiples of 16 UE-33200 - A movie isn't played on iOS occasionally. UE-32397 - Error Message displays as Unknown Error when failing to supply a Remote Build server for ios on Windows + Give a more friendly error message when UHT fails with an invalid error code. #jira UE-23846 #jira UE-33200 #jira UE-32397 Change 3074590 on 2016/08/02 by Rolando.Caloca UE4.13 - Fix gpu morph targets text; add support for RWByteBuffer (disabled). #jira UE-33694 Change 3074588 on 2016/08/02 by Chad.Taylor Update OpenVR SDK to v1.0.2 -Hooked up added aspect ratio and sort priority features to SteamVR stereo layers #jira UE-34115 Change 3074481 on 2016/08/02 by Ori.Cohen Make sure that new physical animation data defaults to 0 #JIRA UE-33678 Change 3074395 on 2016/08/02 by Ori.Cohen Fix duplication of physical animation profiles not duplicating data. Also fix undo redo not working for profiles. Fix editor not passing Duplicate change type #JIRA UE-33987, UE-33985 Change 3074392 on 2016/08/02 by Alex.Delesky #jira UE-32396 - Reverting CL 3074177, since it introduced side-effects. Change 3074364 on 2016/08/02 by phillip.patterson Re-created UMG_Optimization for Test Cases #jira UE-29618 Change 3074346 on 2016/08/02 by Jurre.deBaare Potential DDC warning fix, remove non-existing values #jira UE-123 Change 3074289 on 2016/08/02 by Jeff.Fisher UEVR-13 PSVR: TCR Requirement Reprojection problem after Sony PlaystationVR Morpheus HMD reconnect fixed. -When disconnecting and reconnecting the HMD 700+ sets of reprojection data would back up in a queue. After reconnection reprojection would be lagged by 12+ seconds. After some discussion we decided that the queue is not doing anything useful, so I replaced it with a single blob of reprojection data and a dirty flag. #jira UEVR-13 #review-3074209 @chad.taylor @nick.whiting Change 3074196 on 2016/08/02 by Martin.Wilson Mark old anim instances as pending kill so that they dont get grabbed by undo transactions (causes massive slowdown when dragging in spinboxes that modify default values on anim blueprints) #jira UE-23453 Change 3074177 on 2016/08/02 by Alex.Delesky #jira UE-32396 - Setting an STextBlock to magenta (#FF00FFFF) will no longer cause it to turn gray when compiling its parent widget blueprint. Change 3074157 on 2016/08/02 by Ben.Marsh Remove exception checking for a hard-coded CL. Licensees need to be able to use this stuff. Change 3074132 on 2016/08/02 by Trung.Le VREditor: Fixed brush preview present while in foliage mode and hovering at UI #jira UE-33228 Change 3074131 on 2016/08/02 by Tom.Looman Fix for scalability build warnings in VR Template #jira ue-33325 Change 3074089 on 2016/08/02 by Kevin.Rushin QAGame - Added Foliage to TestMap #jira UE-29618 Change 3074067 on 2016/08/02 by Kevin.Rushin QAGame- Rebuilt Lighting #jira UE-29618 Change 3074063 on 2016/08/02 by Kevin.Rushin QAGame - Fix up VREditor Map to have more asset variation #jira UE-29618 Change 3074057 on 2016/08/02 by Andrew.Porter Deleting - UMG_Optimization #jira UE-29618 Change 3074040 on 2016/08/02 by Michael.Trepka On Mac always process child windows when drawing, as they may be on screen even if their parents are minimized. #jira UE-31194 Change 3074008 on 2016/08/02 by Phillip.Patterson Renamed UMG_Invalidation to UMG_Optimization to better match test #jira UE-29618 Change 3073988 on 2016/08/02 by Mitchell.Wilson Updating starting camera location for Paper2d template to be consistant on both BP and Code version. #jira UE-32723 Change 3073966 on 2016/08/02 by Jurre.deBaare Alembic Cache Importer option for propagating matrix transformation does not work #fix Changed the flag combinations and overhauled the matrix retrieval/caching system #misc typo fix #jira UE-34066 Change 3073953 on 2016/08/02 by Lina.Halper Fixed static warning on null reference #jira: UE-33923 Change 3073951 on 2016/08/02 by Lina.Halper Fix GetRelativeTransform for negative scale #jira: UE-33380 Change 3073896 on 2016/08/02 by Alex.Delesky #jira UE-33580 - User can now play in editor or save after editing certain parameters such as colors via the eyedropper tool or by using numeric spinners. Minor usability improvements to the Data Table Row Editor. #jira UE-33867 - User can now play in editor after selecting a color outside of the color picker window using the eyedropper tool Change 3073804 on 2016/08/02 by Jamie.Dale Fixed the detail panel trying to apply class customizations to structs This could happen in the Data Table editor if you made a struct with the same name as a customized class (eg, Actor). #jira UE-32623 Change 3073803 on 2016/08/02 by Jurre.deBaare Morph target vertex mapping can be wrong with multi material caches #fix Changed the way we build the skeletal mesh from the import data and maintain a vertex remapping array to set up the morph targets correctly #jira UE-34074 Change 3073788 on 2016/08/02 by Andrew.Rodham Sequencer: Added support for montage based animation CL#3061714 : Sequencer: Fixed anim trails not playing in full, sequencer-driven animation. There were 2 issues here. Firstly, we were force-handling events and anim notifies in non-preview animation which caused undefined behaviour when the animation was also updated on tick. Secondly, On the very first frame of a game, sequencer can sometimes use the PreviewSetMatineeAnimPositionInner method because the actor it is referencing has not begun play yet. Unfortunately this function left the animation in a state where the 'real' animation update function wouldn't trigger any anim notifies properly. CL#3063015 : Sequencer: Fixed anim notifies not working when playing animation on blueprint-driven skeletal meshes We now inject a new animation position into the animation system, rather than trying to 'fake' events outside of the system. This allows for much more robust event triggering when playing back through sequencer. Previously, anim notifies for trail particles would be reset every frame due to TriggerAnimNotifies being called by the animation system, and sequencer. We now defer this responsibility to the animation system entirely during playback. CL#3068399 : Sequencer: Changed animation tracks to allow more animation types (such as anim montages) - APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility #jira UE-34046 Change 3073787 on 2016/08/02 by Jurre.deBaare Handle failed Simplygon proxy mesh generation with error message instead of hard checks #fix Added a failed delegate along side the succesful delegate #jira UE-31990 Change 3073786 on 2016/08/02 by Jurre.deBaare Alembic importer crashes when not assets are generated #fix Prevented adding nullptr values to the array (now only contains valid entries) #jira UE-34065 Change 3073777 on 2016/08/02 by Jurre.deBaare User is able to give a Preview Scene Profile the same name as an existing profile #fix check changed profile name and append _duplicatedname if found to be matching an existing profile name #jira UE-34033 Change 3073775 on 2016/08/02 by Mitchell.Wilson Updating VehicleExampleMap for BP and Code templates to have consistant starting locations #jira UE-31281 Change 3073732 on 2016/08/02 by Rolando.Caloca DR - Fix crash when enabling gpu morph targets on non SM5 platforms #jira UE-34011 Change 3073706 on 2016/08/02 by Peter.Sauerbrei fix for no tvOS libraries in binary release for Win64 #jira UE-34076 Change 3073671 on 2016/08/02 by Allan.Bentham High quality mobile reflection captures are now blended in correct (linear) space. #jira UE-33915 Change 3073663 on 2016/08/02 by Peter.Sauerbrei fix for launch on failing for iOS in Binary #jira UE-34014 Change 3073662 on 2016/08/02 by Lee.Clark 4.13 - PS4 - Fix Media Player Audio cutting out #jira UE-33850 Change 3073616 on 2016/08/02 by Mark.Satterthwaite Duplicate CL #3073584 from Dev-Platform: Fix iOS Metal not playing in the background when the phone is locked and there's no drawable texture. #jira UE-32323 Change 3073592 on 2016/08/02 by Max.Chen Curve Editor: End any transactions on mouse down that weren't ended cleanly. This fixes a bug where if you drag with the left mouse button and click with the right mouse button, the transactions are left in an ambiguous state. #jira UE-33993 Change 3073585 on 2016/08/02 by Nick.Darnell Slate/UMG - When you select a paper sprite, or any other implementor of the SlateTextureAtlasInterface the editor will now correctly pick a default size for the brush matching the size of the sprite like it does for textures. #jira UE-34075 Change 3073575 on 2016/08/02 by Richard.TalbotWatkin Duplicating from Dev-Editor, CL 3057645 Fixed single player PIE so the window position is correctly fetched and saved, even when running a dedicated server. This does not interfere with stored positions for multiple PIE, which uses ULevelEditorPlaySettings::MultipleInstancePositions. #jira UE-33416 - New Editor PIE window does not center to screen when running with a dedicated server Change 3073542 on 2016/08/02 by Richard.TalbotWatkin Duplicated from Dev-Editor, CL 3072169. A couple of changes to the BSP code: * Fixed longstanding issue where sometimes BSP geometry is not rebuilt correctly after editing it. This was due to poly normals not being recalculated after translating vertices in Geometry Mode. * Fixed corruption to FPoly::iLink as it is overloaded to have two meanings: when building BSP, it temporarily represents the surface index of the next coplanar surface (and adding a new BSP node uses this to determine whether a new surface needs to be added or not). In other operations it represents an FPoly index, in general this is used more in editor geometry operations. This fixes various crashes which arose from rebuilding BSP resulting in invalid FPoly indices. #jira UE-12157 - BSP brushes break when non-standard subtractive bsp brushes are used #jira UE-32087 - Crash occurs when creating Static Mesh from Trigger Volume Change 3073540 on 2016/08/02 by Matthew.Griffin Added Package Samples script behind a trigger to package samples for QA Removed submitter notifications from Launcher Samples nodes Added submitters of any file in Templates/StarterContent as notified for Feature Pack and DDC nodes Removed any dependencies on Win64 only nodes from the Mac Installed Build so that it can be run locally Added Overnight Build Type to Release Branch to run the Binary Release and Package Samples jobs #jira UEB-689 Change 3073511 on 2016/08/02 by Tom.Looman Removed object redirectors to fix build warning in VR Template #jira ue-33325 Change 3073458 on 2016/08/02 by Jurre.deBaare Update default preview scene ini and assets #fix deleted old sky texture and fixed BaseEditor.ini setup #jira UE-34063 Change 3073427 on 2016/08/02 by Richard.TalbotWatkin Duplicated from Dev-Editor, CL 3068585 Fix to Spline Mesh collision building so that geometry does not default to being auto-inflated in PhysX. #jira UE-34062 - SplineMesh collision can be generated incorrectly Change 3073421 on 2016/08/02 by James.Golding Resave PSD test assets in QAGame with proper version #jira UE-34061 Change 3073419 on 2016/08/02 by James.Golding Rename OrientationDriver to PoseDriver #jira UE-34015 Change 3073404 on 2016/08/02 by Richard.TalbotWatkin Duplicated from Dev-Editor, CL 3057895 Mesh paint bugfixes and improvements. Changes to RerunConstructionScript so that OnObjectsReplaced is called correctly on all components, whether they have been created by the SCS or the UCS. Previously, components created by the UCS were not being handled, and components created by the SCS were not always being matched. Now a serialized index is maintained for UCS-created objects, which is matched after the construction scripts have been executed. This will fix issues with the mesh paint tool, and any other editor tool which hooks into the OnObjectsReplaced callback in order to update its internal cache of component pointers, for example, the component visualizer render list. #jira UE-33010 - Crash changing mesh paint material in blueprint, then changing to a different mode tab #jira UE-32279 - Editor crashes when reselecting a mesh in paint mode #jira UE-31763 - [CrashReport] UE4Editor_MeshPaint!FMulticastDelegateBase<FWeakObjectPtr>::RemoveAll() [multicastdelegatebase.h:75] #jira UE-30661 - Vertex Painting changes collision complexity if the asset is saved while vertex painting Change 3073380 on 2016/08/02 by Richard.TalbotWatkin Fixed build error in unity builds. #jira UE-33049 - Transform widget visible in blueprint viewport when editing spline points in editor viewport #jira UE-9062 - Spline editing: It would be nice to be able to type in a specific value for a point #jira UE-7476 - Add ability to edit SplineComponent in BP editor (not just instance in level) #jira UE-13082 - Users would like a snapping feature for splines #jira UE-13568 - Additional Spline Component Functionality #jira UE-17822 - It would be useful to be able to update a bp spline layout from the editor viewport. Change 3073343 on 2016/08/02 by Matthew.Griffin Whitelisting PS4 and XboxOne plugins for those platforms specifically #jira UE-33866 Change 3073338 on 2016/08/02 by Ben.Marsh When running in unattended mode, write an error refusing to load any missing plugin rather than opening a modal dialog. Fixes ShooterGame build error with missing PS4/XboxOne plugins. Change 3073319 on 2016/08/02 by Maciej.Mroz #jira UE-26676, UE-33027, UE-32806, UE-33460, UE-33423, UE-33860 Manually integrated some fixes from Dev-Blueprints Change 3073311 on 2016/08/02 by Richard.TalbotWatkin Duplicated from Dev-Editor CL 3057868 Spline component improvements, both tools and runtime: - SplineComponentVisualizer now works within the Blueprint editor. This works via a generic extension added to the base ComponentVisualizer class which correctly propagates modified properties from the preview actor to the archetype, and then on to any instances whose properties are at the default value. - The above feature required a breaking change to USplineComponent - namely, the three FInterpCurve properties have been collected together into a struct and added as a single property. This is so that changes to the length of one of the FInterpCurves marks all three as dirty and needing rebuilding. - Added a custom version for SplineComponent and provded serialization fixes. - Added a details customization to SplineComponent to hide the raw FInterpCurve properties. - Added a custom detail builder category which polls the SplineComponentVisualizer each tick and provides numerical editing for spline points which are selected in the visualizer. - Relaxed the limitation that SplineComponent keys need to have an increment of 1.0. Now any SplineComponent key can be set. The details customization enforces that the sequence remains strictly ascending. - Allowed an explicit loop point to be specified for closed splines. - Allowed discontinuous splines by no longer forcing the ArriveTangent and LeaveTangent to be equal. - Added some new Blueprintable methods for building splines with an FSplinePoint struct, which allows all of a spline point's properties to be specified, and added to the FInterpCurves sorted by the input key. - Fixed the logic which determines whether the UCS has modified the spline curves. - Added UActorComponent::RemoveUCSModifiedProperties, which allows a component to remove any properties from the cached list which it doesn't want to be considered as 'modified'. This is used to distinguish the case of properties preserved by the SplineInstanceDataCache from those genuinely modified by the UCS. - Fixed "Apply Instance Changes to Blueprint" so that edited spline data can be applied to the archetype. - Fixed some issues with the spline component visualizer to make it generate appropriate up vectors if scale and rotation are enabled. #jira UETOOL-766 - Spline tool improvements #jira UE-33049 - Transform widget visible in blueprint viewport when editing spline points in editor viewport #jira UE-9062 - Spline editing: It would be nice to be able to type in a specific value for a point #jira UE-7476 - Add ability to edit SplineComponent in BP editor (not just instance in level) #jira UE-13082 - Users would like a snapping feature for splines #jira UE-13568 - Additional Spline Component Functionality #jira UE-17822 - It would be useful to be able to update a bp spline layout from the editor viewport. #jira UE-33049 - Transform widget visible in blueprint viewport when editing spline points in editor viewport #jira UE-33669 - Crash in Dev-Editor Change 3073242 on 2016/08/02 by James.Golding Move physics state create/destroy delegates from BodyInstance to ActorComponent - Rename virtual Create/DestroyPhysicsState on OnCreateDestroyPhysicsState, and make protected. - Create new public Create/DestroyPhysicsState non-virtual to call virtual, and also invoke delegate. #jira UE-32768 Change 3072953 on 2016/08/01 by Uriel.Doyon Texture GUIDs are now included in cooked builds, as they are required by the texture streamer to link build data to in game textures. #jira UE-34045 [CL 3094220 by Ben Marsh in Main branch]
2016-08-18 20:28:33 -04:00
ClientCmdLine += "-Device=" + Params.Devices[0];
for (int DeviceIndex = 1; DeviceIndex < Params.Devices.Count; DeviceIndex++)
{
ClientCmdLine += "+" + Params.Devices[DeviceIndex];
}
ClientCmdLine += " ";
ClientCmdLine += "-Exe=\"" + ClientApp + "\" ";
// @ATG_CHANGE : BEGIN UWP packaging & F5 support
ClientCmdLine += "-Targetplatform=" + Params.ClientTargetPlatforms[0].ToString() + " ";
// @ATG_CHANGE : END
ClientCmdLine += "-Params=\"" + TempCmdLine + "\"";
ClientApp = CombinePaths(CmdEnv.LocalRoot, "Engine/Binaries/Win64/UnrealFrontend.exe");
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 4285612) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3836829 by Ben.Marsh UBT: Fix ability to precompile plugins from installed engine builds. Change 3839519 by Ben.Marsh UBT: Simplify configuring bPrecompile and bUsePrecompile settings for modules. Each rules assembly can now be configured as installed, which defaults the module rules it creates to use precompiled data. Change 4042043 by Steve.Robb GitHub #4705 : Added weak lambda's for delegates and multicast delegates. Change 4042056 by Robert.Manuszewski Optimized Mark Phase of GC by up to 10ms by making it run in parallel and removing a huge array presize which we didn't need. Change 4042104 by Robert.Manuszewski Set the minimum GC cluster size to 5 so that GC doesn't have to process micro clusters which are more expensive than processing individual objects + Exposed the minimum cluster size to ini and project settings as gc.MinGCClusterSize + Added the ability to sort clusters by name/object count/mutable object count/referenced clusters count when dumping them with gc.ListClusters command Change 4042377 by Robert.Manuszewski Reworked how GC and other threads (ALT specifically) interact - GC will now notify the ALT it wants to run and ALT will immediately try to finish its current work to allow that. Also the entire ALT tick is now protected against GC running at the same time to improve ALT stability. + added gc.ForceCollectGarbageEveryFrame console variable that triggers a forced GC every frame Change 4042427 by Robert.Manuszewski Changed FGCCSyncObject to use events when waiting for GC to finish so that it doesn't spin on non-game threads when GC is running Change 4042482 by Robert.Manuszewski Unhashing unreachable objects (ConditionalBeginDestroy) will now also be done incrementally, just like the purge phase of Garbage Collection Change 4042635 by Robert.Manuszewski Fix for a potential assert when incremental purge garbage is pending and something forces a full purge Change 4044092 by Steve.Robb Fix for forward declared CoreUObject weakobject types in delegates when building in Clang. Change 4044102 by Robert.Manuszewski Fix for a possible hang when worker threads are preventing GC from running and something is later trying to FlushAsyncLoading with the Async Loading Thread enabled Change 4044113 by Steve.Robb Another Clang fix. Change 4044160 by Robert.Manuszewski Disregard For GC pool will now be enabled by default in cooked builds Change 4044287 by Steve.Robb Typo fix. Change 4047723 by Graeme.Thornton TBA: Fixes for import/export name cache and object resolving Change 4048015 by Graeme.Thornton TBA: Weak/Soft/Lazy pointer serialization changes * Remove FWeakObjectPtr::Serialize, move it's logic into, and replace usages of with calls to, FArchiveUObject::SerializeWeakObjectPtr(). Ensures that something is always sent to the archive so that structured archives can be kept happy in the future. * Added Weak/Soft/Lazy pointer handling to the structured archive slot interface and all the formatters. Binary formatters just forward the call onto their inner and text archives store as a string path reference. * FArchiveUObjectFromStructuredArchive caches all these pointer types and stores indices in the binary block, same as with a UObject*. All pointers are then forwarded to the underlying formatter in one go on finalization. Change 4048021 by Steve.Robb Fix for binding an unbound TFunction to another TFunction with a different signature. Also all null pointers now count as unbindings, not just nullptr. TIsMemberPointer added. TIsATFunction and TIsATFunctionRef renamed to remove the 'A's. Change 4048544 by Robert.Manuszewski Fixing ConditionalBeginDestroy profiling after changes to incremental CBD. Change 4051028 by Graeme.Thornton TBA: ArchiveFromStructuredArchive adapter uses Inner to determine if it is outputting to text, and sets it's own ArIsTextFormat to false Change 4051056 by Graeme.Thornton TBA: High level tagged property / UObject base class text serialization - UObject serialize converted to structured archive - Properties written to text individually with text tags, and then binary adapted values - Only saves, doesn't load Change 4051111 by Graeme.Thornton TBA: Temporarily disable loading of text assets until tagged property serialization path is fixed up Change 4051154 by Graeme.Thornton TBA: Convert a few uobject serializers to structured archive format for example purposes Change 4051181 by Graeme.Thornton TBA: Added default structured archive implementation of SerializeItem to UProperty, which just calls the FArchive version on an FArchiveUObjectFromStructuredArchive adapter. Implemented structured archive SerializeItem for UArrayProperty Change 4051197 by Graeme.Thornton TBA: ObjectProperty text serialization Change 4051216 by Graeme.Thornton Restored a modified FWeakObjectPtr::Serialize function to keep backwards compatibility in code I don't have access to. Change 4051261 by Graeme.Thornton TBA: Convert UMetaData to structured archive Change 4051374 by Steve.Robb Incorrect assert removed. Change 4051562 by Robert.Manuszewski Adding stats for the new GC internal functions Change 4051614 by Graeme.Thornton TBA: Removed UProperty::SerializeItem(FArchive, ...) and replaced with UProperty::SerializeItem(FStructuredArchive::FSlot, ...). Fixed up most of them to work properly and added adapters in for any that were non-trivial. Change 4052512 by Graeme.Thornton TBA: Temporary workaround for softobjectptr and lazyobjectptr uproperties not serialization anything when they know the archive is a reference collector. They should always be serializing their pointers and letting the underlying archive itself ignore them. Change 4053917 by Robert.Manuszewski Clustered objects from clusters that are no longer reachable will now be marked as unreachable immediately when gathering unreachable objects Change 4053919 by Robert.Manuszewski Added the ability to disable incremental BeginDestroy in ini/project settings Change 4055518 by Daniel.Lamb Fixup for deterministic audio generation issue. Submitted on behalf of Rich.Whitehouse #jira nojira #test prefilght automated test. Change 4056854 by Graeme.Thornton TBA: Added a test asset to EngineTest which contains all the different property types and test cases. Change 4056858 by Graeme.Thornton TBA: Updated USetProperty to proper structured archive usage Change 4056872 by Graeme.Thornton TBA: Add map property field to test object Change 4056873 by Graeme.Thornton TBA: Convert UMapProperty to full structured archive Change 4056994 by Graeme.Thornton TBA: Converted FText over to structured archive. Implemented saving, but not loading. Change 4059728 by Ben.Marsh UBT: Add support for using adaptive non-unity builds when the engine and project are in separate repositories. Change 4059805 by Graeme.Thornton Fixed typo in text serialization. Fixes CIS automation test errors Change 4060007 by Graeme.Thornton TBA: FArchiveFromStructuredArchive will now access it's host slot lazily, i.e. only when a value is actually written to the archive. Change 4060092 by Stefan.Boberg Added optimized Windows console window output path to GenericConsoleOutput since this slowed down cooking considerably (2 minutes spent in wprintf alone for one large dataset) When stdout is attached to a console we use the WriteConsoleW function instead of wprintf since the latter is very slow especially in unbuffered mode which the engine currently configures for stdout (see setvbuf call in LaunchEngineLoop.cpp). At some point we should reconsider this buffering policy since it's likely to slow down other platforms as well but I wanted to do a safe change for now as I don't yet fully understand why the setvbuf call is there in the first place. Change 4060108 by Stefan.Boberg Introduced some additional target platform utilities to help with asset cook optimizations * We now assign each ITargetPlatform a zero-based ordinal value * Introduced FTargetPlatform and FTargetPlatformSet types to help store platform references and platform sets efficiently. These are not currently used in the engine but are designed to replace the existing ITargetPlatform/string/FName representations in the cooking data structures. Change 4060143 by Graeme.Thornton Undo //UE4/Dev-Core/Engine/Source/Runtime/... changelist 4060007 Needs some other changes that I haven't checked in yet... Change 4062432 by Ben.Marsh Fix error message when enumerating P4 changes. Change 4062648 by Ben.Marsh Add missing p4 integration action. Change 4063620 by Graeme.Thornton Integrated a fix from UDN where the engine would crash when trying to load a very small encrypted file (<16bytes) from a pak file, where the read address wasn't already aligned to the AES block size. (https://udn.unrealengine.com/questions/431989/crash-while-reading-a-very-small-file-in-encrypted.html) Change 4066963 by Robert.Manuszewski Fixing GC cluster verification code reporting false positives when a cluster is referencing another cluster through 'mutable' objects list. Change 4067133 by Robert.Manuszewski Changed log verbosity when reporting individual cases of GC cluster assumption violations as they are followed by an asser anyway and this way we get the chance to see all issues before we assert at the end of these checks. Change 4067443 by Steve.Robb FString can now be constructed from any char pointer type and length. Change 4068156 by Steve.Robb Fix necessary because of FString constructor change in CL# 4067443. Change 4070258 by Graeme.Thornton Fixes for VSCode Change 4070372 by Graeme.Thornton TBA: Script struct serialization to structured archives Change 4071913 by Ben.Marsh Move bulk of the code for UnrealPak into an engine developer module, so it can be used in the editor. Change 4071914 by Ben.Marsh Missing files. Change 4071937 by Ben.Marsh Missing header. Change 4072015 by Ben.Marsh Fixes for compiling PakFileUtilities as part of the editor. Change 4072826 by Steve.Robb TBitArray::Reserve() added. TBitArray::Add() overloaded to allow adding multiple bits. TSparseArray::Reserve() optimized to call the overloaded Add(). Change 4073271 by Daniel.Lamb Fixed add patch tier in project launcher passing the wrong commandline option to UAT. #test none Change 4074708 by James.Hopkin #core Removed redundant Casts Change 4074763 by Steve.Robb Fix for TSparseArray::Reserve() size. Change 4076063 by Ben.Marsh Add an "UnrealPak" commandlet with the same functionality as the standalone UnrealPak program. Invoke by running the editor with -run=UnrealPak and the standard UnrealPak commandline options. Change 4077064 by Robert.Manuszewski Fixing compile error in PakFileUtilities Change 4077144 by Graeme.Thornton TBA: TextAssetCommandlet improvements * Collect lists of broken assets during roundtrip tests and print a summary of packages that failed each phase at the end * After resaving as text, load the file back as a plain JSON hierarchy to ensure the output was valid Change 4077412 by Ben.Marsh Set the correct exit code for UnrealPak. Should return 0 on success, not 1. Change 4077760 by Graeme.Thornton TBA: Loading fixed for tagged property serialization Includes conversion of all UProperty::ConvertFromType() and SerializeFromMismatchedTag() functions to use structured archives Lazy initialization of FArchiveFromStructruredArchive when loading, to support the possibility of an adapter being create around an object property serialize call to its inner UStruct, which then decides not to do anything and return false. Stops the ArchiveFromStructuredArchive from consuming the slot and getting upset later on when we try to serialize normal tagged properties from it. Disabled lazy bulk data loading from text assets. Requires a bigger change to make it work. Added some debug checks to json input formatter which track the current value stack size when a new object is pushed onto the stack, and makes sure that the stack has returned to the same size when the object is popped. Catches cases where we unpack an array/stream to the value stack but then don't consume all the items. Change 4078800 by Ben.Marsh Change UAT to using the editor's UnrealPak commandlet rather than invoking the standalone UnrealPak executable. To improve performance when building several PAK files, also add a new -batch=<file> command which reads commands to execute in parallel from a text file. Change 4079745 by Graeme.Thornton TBA: Migrated a couple of UObject Serialize functions to FStructuredArchive (SoundCue / MaterialExpressions / Editor strip flags) Change 4079847 by Graeme.Thornton TBA: Add 'FindMismatchedSerializers' mode to text asset commandlet, which dumps out a list of all UClasses which don't have the CLASS_MatchedSerializers flag, meaning we can't guarantee the have Serialize functions for FArchive AND FStructuredArchive, therefore we can't use the new structured archive based serialize path. Should only ever be native instrinsic classes as UHT takes care of all other cases. Change 4079925 by Ben.Marsh Fix incorrect assignment when deriving name for chunked pak file. Change 4080214 by Ben.Marsh Move the ThreadPoolWorkQueue class into DotNETUtilities so it can be used by other projects. Change 4082394 by Graeme.Thornton CIS fix for variable shadowing warning Change 4082583 by Ben.Marsh Add a IBinarySerializable interface for types that support reading from a BinaryReader and writing to a BinaryWriter. Implementing IBinarySerializable implies a constructor taking a BinaryReader argument is available for deserializing. Change 4082652 by Ben.Marsh Fix FileReference.Directory not returning a directory with a trailing backslash for files in the root directory. Change 4082755 by Graeme.Thornton Fixed an erroneous usage of TUniquePtr<uint8>as a pointer to a uint8 array when creating pak files. Caused a crash when compression was enabled, and has probably surfaced because pak generation is now done by an editor commandlet rather than a standalone program. Change 4082756 by Graeme.Thornton Fixed some incorrect documentation for pakfile compressed chunk headers Change 4082883 by Graeme.Thornton Static analysis warning fix Change 4082912 by Ben.Marsh Move ExceptionUtils into DotNETUtilities. Change 4085291 by Graeme.Thornton TBA: In the Json output formatter, write float and double values out with enough precision for successful roundtripping. Added some debug only code which will immediately reconvert the string back to its original value and compare the the input Change 4085523 by Graeme.Thornton TBA: Remove only explicit usage of DECLARE_FSTRUCTUREDARCHIVE_SERIALIZER. Should only be used from UHT generated code. Change 4086037 by Robert.Manuszewski Fix for a potential race condition when two threads want to acquire GC lock Change 4088655 by Graeme.Thornton Pak creation now uses the bEnablePakSigning setting from the crypto config json file Change 4091474 by Steve.Robb Fix for TStaticBitArray::FindFirstSetBit() and TStaticBitArray::FindFirstClearBit(). Unused variables removed. Change 4093632 by Steve.Robb CIS fixes. Change 4093656 by Graeme.Thornton Build fix Change 4093744 by Ben.Marsh Allow per-chunk settings for whether to enable compression in UnrealPak. Change 4099712 by Gil.Gribb UE4 - Fixed rare case where insufficient space was preallocated for cooldown ticks. #jira UE-59686 Change 4099912 by Stefan.Boberg Cooking timer optimizations: - Replaced data structures for FScopeTimer and FHierarchicalTimerInfo. Previous implementation used FString for many things and caused *lots* of heap and string concatenation activity. Replaced with a compile-time node id (using __COUNTER__) and raw string literals. - Removed PERPACKAGE_TIMER support (was disabled by default and was difficult to test) - Made it possible to toggle OUTPUT_TIMING and ENABLE_COOK_STATS independently - Removed some extremely tight timers because the overhead from calling QPC significantly exceeded the measured code This change shaved some 15% off a clean cook of Fortnite WindowsClient (en) with fully populated local DDC Change 4100519 by Stefan.Boberg Quick fix for Linux build issue introduced in 4099927 Change 4105327 by Stefan.Boberg Cooker: Changed FHierarchicalTimerInfo so it uses a linked list for tracking child nodes, to be able to deal with any child count. Previously we assumed there would never be more than 9 children but it turns out there are cooker modes that need more. Fixes check when using -FullLoadAndSave to cook Change 4105448 by Stefan.Boberg - Fixed Linux build warning re: member initialization order - Also eliminated OUTPUT_HIERARCHYTIMERS/CLEAR_HIEARCHYTIMERS macros (plain functions are fine) - Moved finishing-up code for FullLoadAndSave() to TickCookOnTheSide() call site to improve timer output. Previously some of the scopes would not have been closed before printing and thus the output was misleading. Change 4109031 by Ben.Marsh Attribute-driven Perforce wrapper (old Epic Friday project). Offers a more complete implementation than the current P4 wrapper in UAT without requiring any platform-specific libraries. Uses the Python binary output for parsing. Change 4109588 by Ben.Marsh UBT: Add extension methods for serializing a nullable type to a BinaryReader/BinaryWriter. Change 4109595 by Ben.Marsh Missing project file for DotNETUtilities. Change 4110724 by Stefan.Boberg Removed annotation map locking in UObjectMarks, eliminating around one minute (~3.5%) from Fortnite cook time. The locking was redundant since the annotation maps are managed per thread anyway. Change 4111304 by Ben.Marsh UAT: Add support for setting a status message through the log class. Allows writing transient messages (eg. progress messages) which will be cleared out before writing other messages. Best used through the LogStatusScope class, which can set a status message for the duration of a using() block. As part of this change, the console no longer has to be added as a dedicated trace listener. Since we already special-case this listener when formatting log output, it's easier to just keep the implementation separate to the other trace listeners. Change 4112708 by Steve.Robb Fix for TBitArray::MaxBits in assignment. Change 4114133 by Stefan.Boberg Tweaked how low-level memory (LLM) tracker is implemented to reduce overheads. Previously FMemory functions would acquire the LLM singleton and call OnLowLevelFree/OnLowLevelAlloc etc which would check the bIsDisabled flag and early out if it was set. Due to how frequently these functions were called this ended up costing quite a bit. - This change makes the flag a static member variable instead of a member variable and therefore enables a simpler early-out to be implemented. - The singleton getter is also simplified to avoid hitting the threadsafe singleton construction path on every call. - The enable flag is no longer TAtomic - this also incurs extra overhead for no clear benefit Shaves approximately 3.5% (one minute) off a Fortnite cook test scenario (using -FullLoadAndSave) Change 4115010 by Robert.Manuszewski Fixing CIS Change 4115249 by Robert.Manuszewski Fixing async loading code asserts when exiting game very early due to an error #jira UE-56267 Change 4117091 by Ben.Marsh Prevent doubled-up lines when writing status updates with console log verbosity. Change 4117207 by Ben.Marsh UGS: Do not include executables in diagnostics zip file, and ignore "no such files" error when cleaning workspace. Change 4119175 by Ben.Marsh UGS: Fix crash writing version files when directory does not already exist. Change 4119987 by Ben.Marsh UGS: Show a dialog box while the launcher is updating executables from Perforce, which allows cancelling the operation if necessary. Allow setting the username on the settings window, and prompt for login credentials if necessary. Should prevent situations where users have to update settings from the command prompt. Holding down shift during launch now shows the settings dialog rather than an immediate prompt to launch the unstable version (unstable version is shown as a checkbox on this dialog). Change 4119991 by Ben.Marsh Update version number for UGS launcher to 1.13. Change 4121943 by Robert.Manuszewski Don't use FArchiveAsync2 for reading packages with non-async path in editor builds as its performance is worse than the standard archive's (saves about 1 minute when doing larger cooks and 7 seconds when loading into PIE) Change 4122592 by Steve.Robb GitHub #4762 : Improve wording and grammar of Math comments Also includes improved accuracy in FMath::ComputeBoundingSphereForCone(). Change 4122819 by Stefan.Boberg Don't call CreateDirectory redundantly when opening files for writing using FFileManagerGeneric::CreateFileWriter This change avoids calling IPlatformFile::CreateDirectoryTree if possible since this is a very expensive function especially for deep hierarchies as it performs directory creation from the root directory onwards instead of from the leaf downwards. That function should also be fixed but this change improves performance in the meantime. Change 4122872 by Stefan.Boberg CreateDirectoryTree now creates directories leaf-to-root instead of the other way around. This is much more efficient since we don't spend time on system API calls for directories which already exist. This accounted for a very large amount of CPU time in cooking as the full target file directory hierarchy would be "created" for every single output file. Change 4123109 by Stefan.Boberg - Disable overlapped I/O in editor / cooker. Synchronous I/O reduces the number of syscalls and Windows performs prefetching on our behalf anyway for sequential reads - Eliminated syscall which was issued for every write to update cached file size -- since we're the only writers to the file (file access allows read sharing at most) we can authoritatively update the file size on write completion Change 4123455 by Ben.Marsh PR #4775: New build param PCHMemoryAllocationFactor to set /Zm VS build param. (Contributed by lucaswall) Change 4124207 by Ben.Marsh UBT: Remove some unnecessary indirection for generated code paths. Change 4124217 by Ben.Marsh UBT: Remove another unused variable from UEBuildModuleCPP. Change 4124377 by Stefan.Boberg In IPlatformFile::DeleteDirectoryRecursively, attempt to delete file first and if it fails clear the readonly flag and try again Previously there was a call to clear the readonly flag for every deleted file and this is a waste of resources 99% of the time. The SetFileAttributes call accounted for a significant amount of time during cooker sandbox directory deletion Change 4125071 by Stefan.Boberg Some tweaks to FQueuedThreadPoolBase scheduling and memory management - Explicitly pass in false for TArray::RemoveAt(..., bool bAllowShrinking) argument to prevent memory reallocation when arrays are drained and inevitably repopulated shortly afterwards - Use a MRU strategy instead of LRU when picking a thread to wake up. The MRU thread is the most likely to have a 'hot' cache for the stack etc. Picking from the back of the array also happens to be cheaper since no memory movement is necessary when RemoveAt is called. (This was the strategy in place before CL2600362 which seems to have changed it unintentionally) - Release lock as soon as a thread has been chosen, before asking the worker thread to wake up and do the work Change 4126132 by Ben.Marsh UAT: Detect when stdout is redirected and prevent using backspace characters to move the cursor. Change 4126867 by Graeme.Thornton TBA: Fix tagged binary formatter Change 4127010 by Robert.Manuszewski AnimScriptInstances created at runtime will now also be added to the owning omponent's cluster to avoid GC issues. Change 4127932 by Ben.Marsh WorkspaceTool: Reduce unnecessary logging of status messages when console output is not redirected. Change 4129050 by Ben.Marsh UGS: Check for NET Framework 4.5 being installed before running the installer. Also fix warning trying to kill existing UGS instances before upgrade. Change 4129459 by Graeme.Thornton TBA: TextAssetCommandlet - When outputting converted assets to an output path, replicate the workspace relative path in the output directory Change 4129515 by Graeme.Thornton TBA: Add EnterRecord overload that allows outputting of available field names when loading. Change 4129517 by Graeme.Thornton TBA: Tagged properties are written out as named fields on the "Properties" record, rather than as a stream with a null tag at the end Change 4129518 by Graeme.Thornton TBA: Added a local const bool to allow easy hacking out of text asset loading support Change 4129558 by Graeme.Thornton TBA: Build fix for textasset-less configs Change 4129614 by Ben.Marsh UGS: Main window is now restored to normal size when activated by clicking on the tray icon. #jira UE-60490 Change 4129618 by Ben.Marsh UGS: Speculative fix for unreproduced exception accessing disposed window while shutting down. Change 4131936 by Robert.Manuszewski Removing some WIP code accidentally checked in with CL #4121943 Change 4133490 by Ben.Marsh UGS: Allow the $(Change) variable to be used in more places than just the context menu. #jira UE-60573 Change 4133550 by Ben.Marsh UGS: Setting for whether or not to use incremental builds is now exposed through the variable "$(UseIncrementalBuilds)" for use by custom build steps. #jira UE-60554 Change 4133681 by Ben.Marsh UGS: A per-project list of folders and extensions to be deleted by default when running the 'clean workspace' tool can now be specified through the <ProjectDir>/Build/UnrealGameSync.ini file. Settings may be specified for an individual branch (via a category with the depot path to the project) or for wherever the project is currently open (via the [Default] category). The SafeToDeleteFolders list specifies a substring that will be checked against folder paths. Anything containing this folder will be marked as safe for delete by default. The SafeToDeleteExtensions list specifies a list of extensions for files that can always be deleted. Example: [Default] +SafeToDeleteFolders=/MyGame/Test/ +SafeToDeleteFolders=/DataService/ +SafeToDeleteExtensions=.xx1 +SafeToDeleteExtensions=.xx2 #jira UE-60575 Change 4135449 by Ben.Marsh Fix allowing use of Job objects on Windows platforms (debug code submitted by mistake) Change 4135730 by Ben.Marsh UBT: Plugins can now be enabled and disabled from the .target.cs file (for targets that do not use the shared compile environment), by compiling the list of enabled/disabled plugin names into the Projects module. Change 4135823 by Ben.Marsh UBT: Remove legacy code to handle disabling optional plugins; now that this is compiled into the target, it will work for any plugins we choose. Change 4135945 by Ben.Marsh UBT: Fix error running programs with no explicitly enabled or disabled plugins. Change 4137207 by Ben.Marsh UGS: Align all badges with the same name, to make it easier to see which CIS steps are being run. Allow overriding the slot taken by a particular badge by calling it "SlotName:LabelName". Change 4137311 by Stefan.Boberg Removed child cooker support. In practice it is not a useful feature as it provides no performance improvement (quite the opposite in fact) and adds testing and maintenance complexity. Change 4137393 by Ben.Marsh UGS: Fix display of multiline errors in the status panel. Change 4141708 by Steve.Robb GitHub #3631 : Incorrect default argument in WeakObjectPtrTemplate #jira UE-45490 Change 4146655 by Stefan.Boberg Removed FullGCAssetClasses logic - no longer necessary nor useful Change 4147318 by Ben.Marsh UGS: Compress build badges in a column if it shrinks below the size that they would be visible. Change 4148207 by Ben.Marsh UGS: Added support for showing the latest completed build from a specific list of badges in the status panel. To declare a badge as one that should appear in the status panel rather than the CIS column, add it to the project's UnrealGameSync.ini in the project or [Default] section like so: +ServiceBadges=RoboMerge Change 4148282 by Stefan.Boberg Fixed bug in UCookOnTheFlyServer::GetCookOnTheFlyUnsolicitedFiles - UnsolicitedFiles should be passed by reference not by value Change 4148344 by Stefan.Boberg Fixed minor indentation error (most likely caused by sloppy merge) Change 4148521 by Stefan.Boberg Removed accidentally checked in PRAGMA_DISABLE_OPTIMIZATION from CookOnTheFlyServer.cpp Change 4148639 by Ben.Marsh UGS: Fix tooltips not showing for changes that have description badges. Change 4149373 by Ben.Marsh UGS: Allow adding additional columns to display particular badges by adding entries from the project config file. Example syntax: +Columns=(Name="Desktop",MinWidth=50,DesiredWidth=100,Weight=3,Badges="Editor") +Columns=(Name="Mobile",MinWidth=50,DesiredWidth=100,Weight=3,Badges="IOS,Android") Same form can be used to control how default columns are displayed (though badge settings are ignored). Also allow PerforceMonitor to detect local changes to project config files and update settings automatically. Change 4149399 by Ben.Marsh UGS: Update version to 1.143. Change 4155660 by Steve.Robb PROJECTION and PROJECTION_MEMBER macros which provide the correct behavior when creating projections using functions which are overloaded or use default arguments. Change 4157117 by Ben.Marsh Fix warning due to plugins disabled in .target.cs file. Change 4158011 by Ben.Marsh UBT: Add a check that the UnrealHeaderTool target file exists, rather than throwing an exception when reading it fails. Change 4158646 by Ben.Marsh UGS: Fix exception when login is discovered to have expired during a workspace update. Change 4158678 by Ben.Marsh UGS: Fix an exception on shutdown due to the icon being hidden after it's already been disposed. Change 4158683 by Ben.Marsh UGS: Add an unhandled exception filter which sends the exception data to the backend. Change 4159131 by Ben.Marsh UGS: Reduce the number of characters displayed for build badges based on the available space. Change 4159194 by Graeme.Thornton TBA: Fix incorrect map property conversion code when converting an old property that contains a map with different key/value types Change 4159239 by Steve.Robb Improved readability and compliance with coding standards. Change 4159246 by Ben.Marsh UGS: Allow syncing projects where source code is not available (and various version files don't exist). #jira UE-60985 Change 4159286 by Ben.Marsh UGS: Remove requirement for UE4Editor.target.cs to be visible in the depot in order to open a project. #jira UE-60986 Change 4159302 by Ben.Marsh UGS: Update version to 1.144. Change 4160308 by Ben.Marsh All staging client executables for blueprint projects. #jira UE-60983 Change 4161567 by Steve.Robb GitHub #4816 : UE-60771: Handle escaped double quote in FParse::LineExtended Change 4162641 by Ben.Marsh UGS: Allow customizing the position of custom columns, via the Index=N attribute. Change 4162647 by Ben.Marsh UGS: Update version to 1.145. Change 4165319 by Robert.Manuszewski PR #4812: Fix inconsistent command-line argument handling under Windows (Contributed by adamrehn) Change 4166150 by Ben.Marsh UGS: Include *.inl when looking for code changes. Change 4166551 by Steve.Robb Whitespace fixes caused by a bad merge. Change 4168483 by Ben.Marsh UGS: Add a more useful error if a file to be synced exceeds the max allowed path length. Change 4168490 by Ben.Marsh UGS: Update version to 1.146. Change 4168551 by Ben.Marsh UBT: Move bBuildLargeAddressAwareBinary into an exposed setting. Change 4168560 by Ben.Marsh UBT: Remove static config variable for controlling which configuration of UHT to use. Change 4171296 by Ben.Marsh UGS: Move the check for overlong paths earlier. Change 4171531 by Ben.Marsh UBT: Fix exception if BuildConfiguration.xml contains an unknown category. Change 4183371 by Robert.Manuszewski Fix for a crash in Async Loading Graph's CheckCycles when GC kicks in on the game thread and forces ALT to exit early Change 4184312 by Ben.Marsh UGS: Update version to 1.148 Change 4184480 by Robert.Manuszewski Removing unused async loading stat Change 4186390 by Ben.Marsh UBT: Format XML validation errors in a format that allows double-clicking on the message in Visual Studio. Change 4188644 by Ben.Marsh UBT: Add the MakePathSafeToUseWithCommandLine() function to UBT. Change 4188647 by Ben.Marsh UBT: Fix exception in target receipt when architecture is null. Change 4189617 by Ben.Marsh Change FileSystemReference, FileReference and DirectoryReference objects to use OrdinalIgnoreCase comparisons without creating a separate copy of the string to compare. The filesystem does not use the invariant culture, and it can produce the wrong results in some cases (the ordinal comparison is faster, too). Change 4189740 by Ben.Marsh UAT: Remote code to build UnrealPak when packaging; we use the editor now. Change 4189860 by Ben.Marsh UGS: Make the filter for excluding automated lighting rebuilds more explicit. Change 4190082 by Ben.Marsh Fixes to allow enabling edit and continue for Windows builds. Have experienced quite a few VS crashes when testing it in editor; not yet recommended for general use. - Allow edit and continue for any configuration, not just debug. - Fixed PDB errors compiling files that use a shared PCH with edit and continue enabled. Path to the generated PDB file was using the wrong directory. - Removed code that tracks PDB output files, since they're modified multiple times during a build. - Enable debug information when compiling generated CPP files, since it causes errors if the shared PCH PDB doesn't have the same option. - Disable support for remote execution of steps that modify the PDB, since the same file has to be modified many times. Remote execution causes the PDB files to be corrupted. Unfortunately, this makes E&C builds significantly slower. #jira Change 4192949 by Ben.Marsh UBT: Minor tidy-up (merging UEBuildBinary.Build and UEBuildBinary.SetupOutputFiles) Change 4193218 by Ben.Marsh Fix formatting. Change 4197252 by Mike.Erwin UAT: Fix log output w/ correct count of non-code projects. #jira none Change 4197941 by Ben.Marsh UGS: Add support for DebugGame editors that have an executable with a DebugGame suffix. Change 4197964 by Ben.Marsh UGS: Prevent attempts to automatically reopen projects while a modal dialog is up, or the workspace is syncing. Change 4198144 by Ben.Marsh UGS: Prevent modal dialogs when login expires in P4, and prompt for password when hitting "retry". Change 4198413 by Ben.Marsh UGS: Always show the main window when launched manually, and run with -RestoreState when launched at startup. Also add a couple more places that save the visibility state, since logging off seems like it can terminate the process abrubtly. Change 4198779 by Ben.Marsh UBT: Allow generating manifests to any arbitrary locations with the -Manifest=<Path> argument. Change 4198825 by Ben.Marsh UBT: Move code to enumerate Slate runtime dependencies into the Slate module. Doesn't need to be done inside core UBT. Change 4199341 by Ben.Marsh UGS: Update version to 1.149 Change 4199642 by Chad.Garyet - Deprecate CISController - Add BuildController to replace CIS GET/POST for builds - Add LatestController, GET does what CIS/GET used to do - Change Latest/GET to return the last 25 builds filtered by project, rather than the last 5000 individual Ids - Latest/GET now returns "LatestData" object instead of array of longs - Updated EventMonitor to match all API changes - Fixed bug where IDs were getting reset to initial startup values every update loop Change 4199663 by Chad.Garyet CIS controller still needs to return an array of longs #jira none Change 4199680 by Ben.Marsh UGS: Update version to 1.150 Change 4200457 by Ben.Marsh Merging CIS fix for non-development configurations. Change 4200472 by Mike.Erwin UAT: fix -skipbuildclient param default It was defaulting to skipbuildeditor's value, likely a copy-paste error. #jira none Change 4202595 by Ben.Marsh Fix static analysis warning due to constant comparison against macro. Change 4203250 by Ben.Marsh UGS: Always show the "Sync Precompiled Editor" option, but disable it and show a tooltip explaining why if it is not available. Change 4206191 by Ben.Marsh Exclude editor target files from installed builds, since they leak info about DLLs that have been stripped out. Change 4213011 by Ben.Marsh UBT: Include contents of modified intermediate files in the log, to make it easier to debug hidden dependencies. Change 4213487 by Ben.Marsh UBT: Fix assumption that bPrecompile is equivalent to bBuildAllModules. This is no longer the case; they are now controlled by separate options. Should fix CIS errors building the editor. Change 4213609 by Ben.Marsh Ensure that strings formatted using FMicrosoftPlatformString::GetVarArgs() are always null terminated, whether we use the secure CRT or not. Change 4215971 by Ben.Marsh UBT: Remove action graph visualization code; no longer used. Change 4215996 by Ben.Marsh UBT: Remove unqiue id from all actions in the action graph. This is only used for printing debug info in the case of a (rare) cycle in the action graph, so just look it up when needed. Change 4216022 by Ben.Marsh UBT: Rename Crypto.cs to EncryptionAndSigning.cs to match the name of the class inside it, and move it under the System folder. Change 4216031 by Ben.Marsh UBT: Move all the action executors into their own folder in the project. Change 4216526 by Ben.Marsh Fix CIS warnings. Change 4216544 by Ben.Marsh Replace custom code to ensure FMicrosoftPlatformString::GetVarArgs() null terminates its buffer with Microsoft's standards-compliant implementation. Change 4216633 by Ben.Marsh Add support for UnrealPak plugins. * Project and plugin modules can now specify an array of supported programs in the "WhitelistPrograms" field of their module descriptors, to allow modules to be loaded by programs. * Programs can now load any runtime modules, as long as they are whitelisted. * Programs under the engine directory can now use a shared build environment, so that building with a project file does not cause output binaries to be output to the project directory. * UnrealPak is now always built by default when packaging * Convert UnrealPak to a modular configuration Change 4216736 by Ben.Marsh UnrealPak: Move "ExportDependencies" command into an editor commandlet, since it relies on the UObject system, asset registry, etc... Change 4217447 by Ben.Marsh Back out revision 50 from //UE4/Dev-Core/Engine/Build/InstalledEngineBuild.xml Change 4217451 by Ben.Marsh Back out revision 11 from //UE4/Dev-Core/Engine/Plugins/Developer/VisualStudioSourceCodeAccess/Source/VisualStudioSourceCodeAccess/VisualStudioSourceCodeAccess.Build.cs Change 4217617 by Ben.Marsh Back out changelist 4217451 Change 4222552 by Ben.Marsh Don't use #import <TypeLib> for VS source code accessor when building with Clang; it's not supported. Change 4222630 by Ben.Marsh UBT: Fix spam while generating project files if Clang isn't installed. Change 4223316 by Ben.Marsh UBT: Change the order in which Visual C++ toolchains are enumerated to prefer full releases over preview releases. Change 4223318 by Ben.Marsh UBT: Add a build setting which allows creating a dedicated PCH for every file that's excluded from the unity working set (disabled by default). Improves iteration times when working on individual cpp files, but slows down iterating on header changes (and can take a lot of disk space for large changes). Dedicated PCH contains all includes scraped from the top of each cpp file, until a non-#include directive is encountered. Change 4223401 by Ben.Marsh UBT: Add an option to automatically enable edit and continue for files in the adaptive non-unity working set. E&C doesn't seem very useful for UE4 projects right now; compile time is comparable to regular build times, but it can take several minutes to apply code changes for large projects. Change 4223899 by Ben.Marsh UBT: Fix loading XML config files on Mono; Type.GetField(Name) does not seem to return values unless binding flags are specified. Change 4224637 by Ben.Marsh Add a "SupportedPrograms" field to plugin descriptors, which allows plugins to declare which plugins they support independently of individual modules. Programs now respect the "bEnabledByDefault" setting in plugins. Plugins that are compatible with a program now need to list that program in the SupportedPrograms list, and whitelist any modules that should load for that program. Change 4224710 by Ben.Marsh UBT: Don't add import libraries as final build products unless the target is being precompiled. Prevents the need for building them for leaf nodes in the action graph. Change 4224715 by Ben.Marsh UBT: Remove hack to allow Stats2.cpp to not follow IWYU convention. Change 4224726 by Ben.Marsh Remove commented out line. Change 4224903 by Ben.Marsh Fix non-unity compile error in Stats2.h. Change 4225051 by Ben.Marsh Back out changelist 4224710; causing CIS errors due to receipts not matching. Change 4225134 by Ben.Marsh Fixing non-unity errors. Change 4225203 by Ben.Marsh Another non-unity fix. Change 4225249 by Ben.Marsh Fix Linux dependencies being copied for the Windows editor; they can be added as requirements for the Linux target platform on Windows instead, so it respects the user's chosen platforms. #jira UE-62001 Change 4225512 by Ben.Marsh BuildGraph: Allow setting the target to build when using the <CsCompile> task. Change 4228815 by Ben.Marsh UBT: Always add the generated code directory to the list of include paths when generating project files. It may only be created after UHT has been run. Change 4228944 by Ben.Marsh UBT: Remove legacy CppCompileEnvironment and LinkEnvironment wrappers from TargetRules that were deprecated in 4.19. Change 4229028 by Ben.Marsh UBT: Fix editor targets with unique build environment having the wrong executable path in generated project files. Move move logic to configure target rules post-construction by the rules assembly to ensure it's valid. Change 4229065 by Ben.Marsh UBT: Move another target setting into the rules assembly. Change 4229105 by Ben.Marsh Fix BPT exception when generating project files. Change 4229311 by Ben.Marsh UBT: Store the module rules file location on the ModuleRules instance, as well as the plugin that it was created from. Also expose the plugin directory as a property on the ModuleRules instance. Change 4229421 by Ben.Marsh UBT: Consolidate functionality for UHT module setup in ExternalExecution.cs. Change 4229817 by Ben.Marsh UBT: Modules must now explicitly specify the path to the header used to generate a PCH if one is desired, rather than the header being determined automatically by attempting to parse the source code. Now that PCHs are force-included anyway, this removes a lot of dependencies inside UBT. Change 4229824 by Ben.Marsh UBT: Remove unused lists inside UEBuildModuleCPP.SourceFilesClass. Change 4229841 by Ben.Marsh UBT: Remove some legacy code from auto-detecting PCHs. Change 4230521 by Ben.Marsh UBT: Add utility functions to the log class to allow formatting errors and warnings in Visual Studio output format (eg. File(Line): warning: Message) Change 4230871 by Ben.Marsh UAT: Remove StreamUtilis utility class; there is a simpler way to implement the one place it's used. Change 4230882 by Ben.Marsh UAT: Add StreamUtils back into UAT, seems like it's still used there. Change 4230896 by Ben.Marsh UBT: Remove some redundant parameters from UEBuildModule/UEBuildModuleCPP/UEBuildModuleExternal constructors. Change 4231014 by Ben.Marsh WorkspaceTool: Include a dump of raw bytes when garbage is read from the P4 process, for diagnostic purposes. Change 4231032 by Ben.Marsh Fix CIS. Change 4231096 by Ben.Marsh Bump the FlatCPPIncludeDependencyCache version, to prevent errors trying to load old files. Change 4231446 by Ben.Marsh UBT: Added support for expanding UE-specific variables in include paths and library paths: $(EngineDir), $(ProjectDir), $(PluginDir), $(ModuleDir). Change 4231460 by Ben.Marsh Modules may now explicitly specify rpaths on Linux via the PublicRuntimeLibraryPaths and PrivateRuntimeLibraryPaths properties. Change 4233909 by Robert.Manuszewski PR #4779: Reason fails as the supplied variable is incorrect (Contributed by projectgheist) Change 4233910 by Ben.Marsh Enable PCHs on IOS. Reduces build time by ~25%. Change 4234176 by Ben.Marsh UBT: Add better messaging for modules that need to have a private PCH set. Now detects the likely PCH using the same method as legacy code and includes it as a suggestion. Change 4234193 by Ben.Marsh Add the Delete command to Perforce wrapper in DotNETUtilities. Change 4234688 by Ben.Marsh UBT: Simplify handling of installed/precompiled builds. Settings for whether a folder is installed/read-only or not is now stored on the RulesAssembly instance, allowing multiple things to be configured separately and stacked together (eg. engine/enterprise/project). RulesAssembly.IsReadOnly() allows determining if a flie can be modified or not and replaces many previous IsXXXInstalledCalls(), and traverses the chain of assemblies. Change 4234711 by Ben.Marsh UBT: Runtime dependencies can now be copied to output directories as part of the build. When adding a runtime dependency, an optional source location can be specified to copy from. Both the source and target paths can use variables can be used as part of the path, eg. $(OutputDir), $(ModuleDir), $(PluginDir). Example usage (from a .build.cs file): RuntimeDependencies.Add("$(OutputDir)/Foo.dll", "$(PluginDir)/Source/ThirdParty/Foo.dll", StagedFileType.NonUFS); Change 4234872 by Ben.Marsh Expose a flag for whether the engine is installed, to fix issues generating project files. Change 4234929 by Ben.Marsh Fix null reference generating receipts when UBT makefiles are active. Change 4235883 by Chad.Garyet Merging 4231245 to core Giving Coordinator its own sln. This should fix what 4158155 was supposed to. #jira UE-61955 Change 4236075 by Ben.Marsh CIS fix Change 4237066 by Robert.Manuszewski Fix for a potential crash when terminating the engine while it's being initialized #jira UE-60545 Change 4237078 by Robert.Manuszewski The engine will no longer be resetting all linkers causing massive load times when renaming the world package when entering Play In Editor Change 4237116 by Ben.Marsh Rewrite some Windows utility functions to support paths longer than MAX_PATH. Change 4237158 by Ben.Marsh Add const TCHAR* overloads of FString::RemoveFromStart() and FString::RemoveFromEnd(). Change 4237159 by Ben.Marsh Fix FWindowsPlatformFile::GetFilenameOnDisk() support for paths longer than MAX_PATH, and simplify some of the other long path functions to avoid copying string buffers. Change 4239050 by Ben.Marsh Missing file Change 4239318 by Ben.Marsh Linux CIS fix. Change 4239685 by Ben.Marsh Static analysis CIS fix. Change 4240800 by Ben.Marsh WorkspaceTool: Include the full command line in the log for any P4 commands. Change 4240903 by Ben.Marsh PR #4909: Update copyright notices to 2018 (Contributed by projectgheist) Change 4241025 by Ben.Marsh UBT: Exclude mobile pipeline caches from generated project files. Causes huge slowdown when using 'Find in Files' through the IDE. Change 4241770 by Ben.Marsh UBT: Include action number in parallel executor output. #jira UE-62032 Change 4243469 by Ben.Marsh TBA: Merge FAnnotatedStructuredArchiveFormatter with FStructuredArchiveFormatter. Any functions that are only implemented for text archives now have a _TextOnly suffix, and are exposed through the FStructuredArchive interface. Change 4245723 by Robert.Manuszewski Fixing another creash when terminating the engine while initializing. #jira UE-60545 Change 4245862 by Steve.Robb VectorLoadFloat2(Ptr) added, which loads { Ptr[0], Ptr[1], Ptr[0], Ptr[1] } into a VectorRegister. Change 4246412 by Robert.Manuszewski The warning 'Calling StaticLoadObject during PostLoad may result in hitches during streaming' will now also report the object which had the PostLoad called on it when StaticLoadObject call happened. Change 4246612 by Ben.Marsh UBT: Fix spelling of "Intellisense". Change 4249454 by Robert.Manuszewski Added extra checks to catch scenarios where the EDL Precache Buffer is flushed before a package header is fully read Change 4249513 by Robert.Manuszewski Made sure the Async Loading Thread doesn't continue running after creating new async packages when garbage collector wants to run on the game thread Change 4255207 by Ben.Marsh UGS: Add additional logging whenever a P4 command fails, and when the user is logged out. Change 4255288 by Ben.Marsh PR #4921: Honor ModuleRules' bEnableExceptions flag when creating precompiled h. (Contributed by surakin) Change 4256422 by Ben.Marsh UBT: Add an error if a module referenced by a plugin descriptor doesn't exist. Change 4257385 by Robert.Manuszewski Creating new objects from within ForEachObjectWithOuter will now result in a fatal error as it's unsafe to change internal UObject hash tables when iterating over them. Change 4257454 by Robert.Manuszewski Added the option to filter clusters listed with gc.ListClusters by objects within them. Usage: gc.ListClusters Hierachy With=ObjectName1,ObjectName2... Change 4257526 by Robert.Manuszewski It's now possible to filter clusters that get logged with verbose cluster logging enabled (UE_GCCLUSTER_VERBOSE_LOGGING=1) by objects within them by specifying -DumpClustersWithObjects=ObjectName1,ObjectName2 in the command line Change 4257822 by Ben.Marsh Fixes for PlatformShowcase compile errors. Change 4258771 by Ben.Marsh UBT: Fix project files not being generated for foreign projects when creating .stub files. #jira UE-62462 Change 4258790 by Ben.Marsh UBT: Clean up the logic around generating project files before creating a stub IPA, so that it fails loudly if project files do not exist, and can accept target names not matching project names. Change 4259276 by Ben.Marsh UBT: Make it an error if a framework doesn't exist, rather than failing silently. Also remove some remote toolchain stuff that's no longer necessary. Change 4259280 by Ben.Marsh UBT: Fix embedded framework zips not being uploaded for plugins. #jira UE-62485 Change 4260236 by Ben.Marsh UBT: Fix path to generated engine project file. Change 4260334 by Ben.Marsh UGS: Fix custom build steps dialog inadvertantly modifying config file settings in-place. Change 4260361 by Ben.Marsh UGS: Allow for p4 login commands to fail, even though the user is logged in (due to a bad connection, etc...) Change 4260559 by Ben.Marsh UGS: Update version. Change 4261160 by Robert.Manuszewski MediaPlaylist will now be added to root set if the owning MediaPlayer is in the disregard for GC set (fixes GC assumption violation crash) #jira UE-62495 Change 4261421 by Ben.Marsh Force-sync files for building documentation, to fix issues with files not being updated. #jira UE-62413 Change 4261425 by Ben.Marsh UBT: Remove some leftover functions for handling the remote toolchain. Change 4261530 by Ben.Marsh UBT: Speculative fix (and better error reporting) for IOS mobile provision not being found in CIS. Change 4261611 by Ben.Marsh UBT: Downgrade warning to a log message, since it appears when generating project files. Change 4261710 by Ben.Marsh Remove assert that GLogConsole is set; it won't be for command line utilities that don't depend on ApplicationCore. #jira UE-62545 Change 4261831 by Ben.Marsh Fix compile errors due to missing include path when hot-reloading a module from the editor. There are not necessarily source files to compile when -modulewithsuffix is specified on the command line, which was results in GeneratedCodeWildcard not being set. #jira UE-62463, UE-62384 Change 4262723 by Ben.Marsh Whitelist plugins that need to be loaded by UFE. #jira UE-62564 Change 4265444 by Ben.Marsh Fix incorrect executable name for DebugGame configurations in Xcode. #jira UE-62574 Change 4265892 by Ben.Marsh Fix incremental compile failures due to dependency checking for unity files. CachedIncludePaths was not correctly being set on file items, so dependencies were being ignored. #jira UE-62575, UE-62603, UE-62597 Change 4266019 by Josh.Adams - Fixed the CopyAction for runtime dependencies that need to be copied to different location, on non-XGE Change 4266264 by Ben.Marsh Remove override for the __IPHONE_OS_VERSION_MIN_REQUIRED macro on TVOS. This macro is already defined by system headers (in <AvailabilityInternal.h>). Now that we support PCHs on IOS and TVOS, manually defining this macro results in it being defined three times (once for the PCH, once by AvailabilityInternal.h, and once by the force-included list of definitions for the source file being built). The errors for redefining the macro in AvailabilityInternal.h are suppressed due to it being a system header, but the error for redefining it for the source file being compiled are not. #jira UE-62578 Change 4266273 by Ben.Marsh Fixes incremental build failure when compile arguments for PCH have changed on IOS/TVOS. Compile action needs to have a dependency on PCH build action. Change 4266614 by Graeme.Thornton Fix crash when cooking nativized blueprints due to removal of child cooker system. Change 4266763 by Ben.Marsh Always build UnrealPak when building client targets. The ProjectParams.Pak option is not reliable, because it can be forced on later by the target platform. #jira UE-62584 Change 4267985 by Robert.Manuszewski When iterating with ForEachObjectWithouter, don't lock the entire has table but only the hash bucket that is currently being iterated #jira UE-62600 Change 4268558 by Robert.Manuszewski PurgeLegacyBlueprints will no longer be called from within ForEachObjectWithOuter is it renames objects that reside in hash tables that are being iterated over which may lead to undefined behavior. #jira UE-62600 Change 4269011 by Chad.Garyet - Fixing Wildcard match issue, the change to ugsapi sends projects as //Depot/Stream instead of //Depot/Stream/ Wildcard match was only substringing to 3 chars. - Checking in the change a while back that increases the number of queried jobs up to 432 based on some maths from Bob about how many builds we want to grab Published to ugsapi server 8/8/17 #jira none Change 4270788 by Ben.Marsh Fix IOS provisioning data being using when remote compiling on TVOS. #jira UE-62705 Change 4271916 by Ben.Marsh Tag the XGEControlWorker executable as a build product after compiling SCW, to make sure it's included in the UGS zip file. Change 4271934 by Ben.Marsh Upload all static libraries in plugin folders as part of remote builds. #jira UE-62694 Change 4273368 by Ben.Marsh Fix Slate dependencies not being enumerated, and rules assembly not being rebuilt when building remotely. #jira UE-62705 Change 4274049 by Ben.Marsh Always parse the team UUID out of the mobile provision when doing a remote compile. The provision installed on the remote Mac (and selected for signing) may be different. #jira UE-62751 Change 4274823 by Ben.Marsh Add the -VersionCookedContent argument to disable the -unversioned parameter on the cooker command line. Change 4275838 by Ben.Marsh Fix BuildVersion string not being passed through from <SetVersion> task. Also add a -BuildVersion command line argument to UBT to override it for a particular build. Change 4275913 by Ben.Marsh Add a dummy exported symbol to the XGEController module, to fix build errors due to missing .lib file when it's built with WITH_XGE_CONTROLLER = 0. Change 4284161 by Ben.Marsh Allow mirroring Oodle files to remote Mac. Change 4074774 by Steve.Robb Vast simplification of TFunction, making it smaller in footprint, easier to follow and extend, and more correct. TUniqueFunction added, which is a move-only TFunction which can hold move-only functors. Fix for UWidgetBlueprint::ForEachSourceWidget() which should never have compiled but did. FFunctionGraphTask and TFuture<> updated to use TUniqueFunction to make them more general. TArray::HeapPop() made to work with move-only types. Change 4082591 by Ben.Marsh Move the Log class from UBT to DotNetUtilities. Change 4083236 by Ben.Marsh Add a Log.WriteException() method to dump an exception message to the console (and write the exception trace to the log) Change 4084107 by Ben.Marsh UAT: Remove the unused -SkipHeader argument to UE4Build. Change 4089771 by Steve.Robb GitHub #4743 : modified VirtualAlloc function flag https://blogs.msdn.microsoft.com/oldnewthing/20151008-00/?p=91411 Change 4091456 by Steve.Robb Unification of all platforms' FMath::CountTrailingZeros() and FMath::CountLeadingZeros() for both 32-bit and 64-bit. Change 4156437 by Ben.Marsh Lots and lots of fixes compiling for Clang on Windows. Editor now compiles cleanly without warnings, but crashes on startup due to error in intrinsics test. Disabling that runs further, but crashes accessing freed memory. Switching to the ANSI allocator runs further, but crashes in Slate after the splash screen and before the editor window opens. // TODO! * Switching between Clang/ICL/VS2015/VS2017 is now supported through the same mechanism as switching Visual Studio versions, without requiring any source level changes. To use Clang, set WindowsPlatform.Compiler = WindowsCompiler.Clang from a .target.cs file, or set <WindowsPlatform><Compiler>Clang</Compiler></WindowsPlatform> from BuildConfiguration.xml. To pick a specific toolchain version, set WindowsPlatform.CompilerVersion. * Clang is now supported through AutoSDKs; will be added to CIS. * The Samples/Sandbox/Clang project forces Clang to be used from its target.cs file, and allows easily building all editor modules and plugins with Clang on Windows. * UnrealMathSSE intrinsics have been re-enabled for Clang due to missing functions from the UnrealMathFPU implementation, but causes failure in tests at startup. * SSE4_CRC32() is disabled in D3D12Pipelinestate.cpp, since intrinsics are only allowed if enabled for the whole target (rather than being used in specific functions due to runtime checks) Change 4157389 by Ben.Marsh Few more fixes for compiling the editor with Clang. Change 4183911 by Ben.Marsh Fixes to support incremental linking on Windows. Does not seem to have any net benefit right now; may improve once minimal rebuild is enabled. * Incremental linking no longer forces PDB files to be enabled for source files. * Actions can specify specific files to be deleted before each build. Code to forcibly delete PDB files has been moved to the MSVC toolchain. * Unused libraries produced by the cross-referenced link are no longer added as build products, since (a) deleting them breaks dependency checking for incremental linking and causes a full link, and (b) not deleting them breaks UBT dependency checking and causes actions to be run over and over again. * Icon update is disabled for Windows when incremental linking is enabled. * Removed rarely-used setting to always delete produced items before each build. Change 4184311 by Ben.Marsh UGS: Added a dialog which shows all the required platform SDKs for a branch, linked from the status panel in UGS. The llist is configured via the UGS config file submitted to Engine/Programs/UnrealGameSync/UnrealGameSync.ini (and may be overridden by the project config file if necessary): [Default] ; Set this to a network share which contains the SDK installers for your site SdkInstallerDir= ; All the required SDKs for the current version of the engine +SdkInfo=(Category="Android", Description="NDK r21", Browse="$(SdkInstallerDir)\\Android") +SdkInfo=(Category="Windows", Description="Visual Studio 2017") +SdkInfo=(Category="Windows", Description="Visual C++ Toolchain 14.13.26128") +SdkInfo=(Category="Windows", Description="Windows SDK 10.0.16299.0") Similar entries for console platforms are added in console subdirectories. Each entry may contain an Install="Foo.exe" and/or Browse="C:\Foo" style attribute, specifying the path to an installer to run or directory to open in explorer respectively. The SdkInstallerDir setting is used as a base directory for the default installers, seen above for Android. Licensees may override this with a network path specific to the site that UGS is being deployed to (either in this file, in a project specific config file, or in a Engine/Programs/UnrealGameSync/NotForLicensees/UnrealGameSync.ini file). Change 4200452 by Ben.Marsh UBT: Change DebugGame configurations to output a separate executable rather than requiring a -Debug argument at runtime. Previous behavior was a common source of errors. Engine modules are still shared between Development and DebugGame, but the launch module sets a flag in Core on startup indicating the game configuration. Change 4206189 by Ben.Marsh UBT: Simplify logic for precompiling binaries. * Target no longer has separate list of "precompile only" binaries or modules. New -AllModules option allows adding every module to a target, which can be used with -Precompile and -NoLink to precompile object files for monolithic builds. * Precompiled file lists have been removed from target receipts. * The manifest now includes all generated headers and precompiled files when run with the -Precompile option. * Separate -DependencyList=Foo.txt has been added to write a list of all dependencies required to use precompiled binaries. This file list can be read using the <Tag> task in buildgraph. Change 4215466 by Ben.Marsh UBT: Remove indirect calls to determine extensions for object files and precompiled headers. The toolchain knows the correct convention for the platform. Change 4215975 by Ben.Marsh UBT: Remove telemetry code. This has never proved useful for analyzing performance due to the number of incidental factors that affect build times (eg. number of files being compiled). Change 4220154 by Ben.Marsh Move text-only implementations of FOutputDeviceError back into Core, so we can build command-line applications that don't depend on ApplicationCore. Change 4224708 by Ben.Marsh Add a bCompileAgainstApplicationCore setting to the target rules, which allows compiling out references to the ApplicationCore module (which should only be necessary for applications with a GUI). Removed ApplicationCore from several engine tools and utilities. Change 4224958 by Ben.Marsh Remove CoreMinimal.h includes from Core. Change 4229059 by Ben.Marsh UBT: Remove the UEBuildPlatform.ShouldNotBuildEditor() hook for target platforms. We shouldn't be modifying a target's build environment to disable the editor; it is invalid to build the editor for these target platforms at all, and this is already enforced by the GetSupportedPlatforms() function. Change 4230508 by Ben.Marsh Fixup precompiled header setting for samples and games. Change 4231457 by Ben.Marsh Fix exceptions in log messages having trailing newlines. Change 4232406 by Ben.Marsh UBT: Always force include a PCH for generated code if there's one set; the code may depend on it to compile. Change 4234177 by Ben.Marsh Set up private PCH files everywhere that previously used them. Change 4235973 by Ben.Marsh Change FPlatformMisc::GetEnvironmentVariable() to return an FString() rather than requiring a fixed size buffer to be passed in. Removes references to MAX_PATH. Change 4238842 by Ben.Marsh Add support for paths longer than MAX_PATH in the editor. Requires Windows 10 version 1607, and the functionality to be enabled via a registry key or group policy (see https://docs.microsoft.com/en-us/windows/desktop/FileIO/naming-a-file). Only a subset of Win32 functions support long paths (executables can only be started from paths shorter than MAX_PATH, for example). * Added a FPlatformMisc::GetMaxPathLength() function to return the maximum length of a path on the current system. On Windows, this returns a different value for systems with long paths enabled to those without. * The MAX_PATH define is no longer set by non-Windows platforms. Instead, there is a MAC_MAX_PATH, UNIX_MAX_PATH, etc... for any platform-specific code that still relies on the previous macro. * The MAX_UNREAL_FILENAME_LENGTH macro has been renamed to MAX_UNREAL_FILENAME_LENGTH_DEPRECATED * The PLATFORM_MAX_FILEPATH_LENGTH macro has been renamed to PLATFORM_MAX_FILEPATH_LENGTH_DEPRECATED. * Removed custom resource files for programs, since they are just copies of the base UE4 one (which is used by default anyway). The base UE4 manifest declares support for long paths. * Fix 512 character maximum length on editor commands. 260 character limit remains in place for cooking at the moment (see ContentBrowserUtils.h), until C# staging code supports long paths. Change 4255042 by Ben.Marsh UBT: Remote compilation now uploads the entire workspace to the remote Mac and executes a separate remote instance of UBT rather than synchronizing individual actions. This makes the remote compile codepath much simpler, and removes a lot of special cases that exist to support it previously. The list of files to be transferred to the remote are listed as rsync filter rules in Engine/Build/Rsync/RsyncEngine.txt and RsyncProject.txt, which are applied to the root engine directory and project directory respectively. Projects that need to customize which files are uploaded can add their own <ProjectDir>/Build/Rsync/RsyncProject.txt file, which will be included in the filter before the default version. Change 4260567 by Ben.Marsh UAT: Rename CommandUtils.Log to CommandUtils.LogInformation, to avoid conflicts with the underlying Tools.DotNETCommon.Log class. #rb none [CL 4285673 by Ben Marsh in Main branch]
2018-08-14 18:32:34 -04:00
LogInformation("Launching via UFE:");
LogInformation("\tClientCmdLine: " + ClientCmdLine + "");
}
else
{
ClientCmdLine = TempCmdLine;
}
}
#endregion
#region Client Thread
private static void ClientLogReaderProc(object ArgsContainer)
{
var Args = ArgsContainer as object[];
var ClientLogFile = (string)Args[0];
Copying //UE4/Dev-Platform to //UE4/Dev-Main (Source: //UE4/Dev-Platform @ 3120366) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 2714591 on 2015/10/02 by Ben.Marsh Initial branch of files from Engine-Main (//UE4/Engine-Main) to Dev-Platform (//UE4/Dev-Platform) Change 2916715 on 2016/03/21 by Daniel.Lamb First pass at splitting out build cook run into into seperate scripts. Change 2948322 on 2016/04/19 by Nick.Shin update libwebsockets to v1.7.4 part 4 of 4 - doing this in stages for tracking purposes #jira UEPLAT-1246 - Update libWebsockets #jira UEPLAT-1221 - update websocket library #jira UEPLAT-1204 - Rebuild libwebsockets with SSL Change 2970016 on 2016/05/07 by Nick.Shin undo all of the following upgrades: - zlib - openssl - libcurl - libwebsockets and reset webrtc #jira UE-30298 - Fortnite and Orion crash on login Change 3059693 on 2016/07/21 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3061151 on 2016/07/22 by Niklas.Smedberg Fast ASTC texture compression, using ISPC. #jira UE-32308 Change 3061428 on 2016/07/22 by Peter.Sauerbrei Back out changelist 3061151 as it wasn't approved for submission Change 3061970 on 2016/07/22 by Steve.Cano Adding AdMob interstitital ad support for Android, including Blueprint functions #jira UE-33286 #ue4 #android Change 3062160 on 2016/07/22 by Mark.Satterthwaite Fix the fix for handling RHISetStreamSource overriding stride on Metal - not all MTLVertexDescriptors are equally hashable so do this ourselves. #jira UE-33355 Change 3062770 on 2016/07/24 by Brent.Pease UE-32397 Error Message displays as Unknown Error when failing to supply a Remote Build server for ios on Windows Change 3063227 on 2016/07/25 by Dmitry.Rekman Update hlslcc cross-compile after libc++ change. Change 3063314 on 2016/07/25 by Jeff.Campeau Xbox One DLL loading Receipts can be read back by request for target info Change 3063329 on 2016/07/25 by Mark.Satterthwaite CL #3046743 was breaking other samples in unexpected ways after a recent Main merge, so make a Metal-specific change to the shader instead and amend the MetalBackend to better match HLSL's handling of NaN/inf with common single-precision float intrinsics. This is sufficient to fix the AtmosphericFog and the recent regressions. #jira UE-33600 #jira UE-33028 #jira UE-27879 #jira UE-25802 Change 3063492 on 2016/07/25 by Brent.Pease UE-23846 - iOS Movie Player can't handle videos at resolutions that aren't multiples of 16 UE-33200 - A movie isn't played on iOS occasionally. Change 3063729 on 2016/07/25 by Dmitry.Rekman Linux: enable XGE on all platforms. #tests Cross-compiled a number of Linux targets on Windows. Change 3063732 on 2016/07/25 by Dmitry.Rekman Fixed formatting (spaces->tabs) in previous change. Change 3063750 on 2016/07/25 by Daniel.Lamb Added code to dump the cook modification delegate loads to log. Fixed the memory usage output log. #test cook paragon. Change 3063804 on 2016/07/25 by Daniel.Lamb Added cookpartialgc additional commandline option to uat. #test UFE Change 3064008 on 2016/07/25 by Mark.Satterthwaite For non-shipping builds conditionally bind a default uniform buffer in Metal and report an error if the slot was unbound, if our validation layer is enabled attempt to report the shader source in question. This relies on the shader compiler providing accurate information about uniform buffer bindings and won't fix all occurances of bad uniform usage (if a buffer is bound but too short the result will be GPU restarts or an error in Apple's validation layer - we can't detect this case) but will help debug the typical error of leaving an active slot unbound. #jira FORT-27685 Change 3064141 on 2016/07/25 by Jeff.Campeau Rebuild vpxmd.lib with delayed codegen disabled (fixes linker warning building Win64). Change 3065024 on 2016/07/26 by Nick.Shin Change filetype remove exclusive check out bit requested by or.coheni & nick.penwarden Change 3065274 on 2016/07/26 by Jonathan.Fitzpatrick DirectoriesToAlwaysStageAsUFS now properly filters out *.uasset and *.umap files This prevents the bug where cooked assets get trampled by staging their uncooked version on top of them during the UFS step Added a file filter to DirectoriesToAlwaysStageAsUFS for uasset and umap. Change 3066338 on 2016/07/27 by Mark.Satterthwaite Handle releasing an SRV/UAV & the source object within a single Metal command-buffer. #jira UE-33779 Change 3066789 on 2016/07/27 by Daniel.Lamb Realtime mode does not save any packages anymore unless they are ready. #test cookontheside, cookbythebook shooter game Change 3066847 on 2016/07/27 by Jeff.Campeau Fix define #2634 #jira UE-33813 Change 3068868 on 2016/07/28 by Mark.Satterthwaite Extend hlslcc's handling of switch-statements to allow implict casts from scalar bool, half & float as HLSL itself permits while also making sure it errors if the expression input is not scalar. This fixes shader compile errors in UT. Change 3070040 on 2016/07/29 by Dmitry.Rekman Delete Nadzorca. Change 3070947 on 2016/07/29 by Jeff.Campeau Perforce C++ API 2015.2 (includes debug libraries) Change 3073707 on 2016/08/02 by Daniel.Lamb Derived data cache commandlet runs resolve string asset references to load any string asset refereced packages from the map. Also process async results from shaders being compiled so they can have their memory resources released. #test DerivedDataCache commandlet shootergame. Change 3076613 on 2016/08/03 by Brent.Pease + UnrealTargetConfiguration is now passed into deploy and package methods + The UIRequiredDeviceCapabilities plist key now only considers the architectures from the corresponding target configuration (shipping or development) Change 3076668 on 2016/08/03 by Brent.Pease Back out changelist 3076613 Change 3077157 on 2016/08/04 by Daniel.Lamb Fixed up DLC staging so that it stages to the proper mount point. Fixes up include engine content in DLC staging paths. #test Made up shooter game DLC Change 3077191 on 2016/08/04 by Daniel.Lamb More smartly process async shader compilation if we are waiting for it. #test cook on the side shooter game cook by the book shooter game. Change 3077412 on 2016/08/04 by Mark.Satterthwaite Fix "iOS Metal-based build crashes at launch with sub-levels": - Slate should not bind the null RHI texture from an unitialised texture atlas - atlases only have a valid texture pointer once an entry has been added to them and in the template projects an empty sub-level doesn't add anything. - To prevent this kind of bug resurfacing and being so hard to track down add Metal shader binding validation to our validation layer as Apple's is incomplete on iOS and won't warn us about nil texture usage which causes these GPU restarts. This requires reworking our vertex declaration handling to be more efficient so that we can cache the pipeline reflection data as well as the pipeline objects. - Fix validation error of texture reallocation on loading template projects under Metal. #jira UE-30847 Change 3077958 on 2016/08/04 by Brent.Pease + UnrealTargetConfiguration is now passed into deploy and package methods + The UIRequiredDeviceCapabilities plist key now only considers the architectures from the corresponding target configuration (shipping or development) Change 3079503 on 2016/08/05 by Mark.Satterthwaite Initialise more variable types to 0 in Metal shaders to workaround Xcode 8 toolchain no longer doing this for us for "threadgroup shared" variables. Everything but structs and atomic's will now be initialised. #jira UE-33856 Change 3079737 on 2016/08/05 by Jeff.Campeau Add support for delay load DLLs on Xbox One Turn off warnging for missing PDBs to match VCToolchain.cs Change 3081005 on 2016/08/08 by Mark.Satterthwaite Fix-up Metal device name on AMD for macOS 10.12 which reports it correctly and enable tiled reflections on Intel from macOS 10.12 too as they now work. Change 3081557 on 2016/08/08 by Daniel.Lamb File-> Package saves all packages before starting packaging. #test File package first person template Change 3082215 on 2016/08/09 by Lee.Clark PS4 - Added 4k profile Change 3082412 on 2016/08/09 by Daniel.Lamb Fixed cook on the fly server not handling cook requests. #test Cook on the fly shooter game. Change 3082955 on 2016/08/09 by Dmitry.Rekman Linux: convert existing Strcat() uses to Strncat(). - Strcat() does not check destination size so can silently corrupt memory. While this was not observed, this conversion removes this concern altogether. Change 3083772 on 2016/08/10 by Luke.Thatcher [PLATFORM] [PS4] [+] Checking in PS4CrashHandler files so we have a copy in Perforce rather than just on the server. - Taken from \\devweb-02 and removed all the unused files/dependencies. - Created a publish profile pointing to \\devweb-02\Sites\PS4Services\PS4CrashHandlerDev so I'm not writing over the existing deployed crash handler. - Moved all code in the Page_Load event to inside the check for the HTTP method (POST) otherwise GET'ing the page from a browser will generate crash folders that hang around forever. Change 3085450 on 2016/08/11 by Lee.Clark PS4 - Fix mediaplayer pipeline allocation Change 3086360 on 2016/08/11 by Michael.Trepka Fixed a non-unity build error in Mac UnrealFrontend Change 3087224 on 2016/08/12 by Luke.Thatcher [PLATFORM] [PS4] [~] Refactor PS4 Crash Handler site - Removed CoreDumpHandler. Processing dump files is handled directly by an async thread within the aspx process. - Separated configuration values into their own class. Currently set to output to a testing directory, rather than the actual crash reporter landing zone. - Added a debug upload page to allow manual submission of .orbisdmp/.txt settings files, accessible by GET'ing Default.aspx. - Added logging. Logs self-delete after 30 days. Testing required before we switch to the new system. #jira UE-34504 #jira OR-26886 Change 3087626 on 2016/08/12 by Dmitry.Rekman PR #2689: Fix copying/duplicating failing on Linux (UE-34586). - Contributed by Web-eWorks. Change 3087991 on 2016/08/12 by Mark.Satterthwaite Initial AVFoundation implementation of Media Framework for Mac, iOS & tvOS. - Video playback occurs via AVPlayerItemVideoOutput's attached to the AVPlayerItem's output. This means gathering video samples is trivial. - Metal texture updates occur by wrapping the texture object provided by AVF - for Mac this is simple as it can bind to the IOSurface directly, for iOS/tvOS we have to create a CVMetalTextureCache and allocate our texture from there. - OpenGL and OpenGLES currently have to lock the pixel buffer and upload to a texture the old fashioned way - this should be revisited when there is time. - Subtitles/Captions are captured using AVPlayerItemLegibleOutput which also connects to the AVPlayerItem's output. - On Mac audio samples are returned by manually reading from the stream using an AVAssetReaderTrackOutput, including manual seeking and synching. - On iOS/tvOS the audio is played directly by AVPlayer because the IOSAudio system can't handle procedural buffers - otherwise it could reuse the Mac code. - AVFoundation does not support AVI - that's an obsolete Microsoft/Windows file-format. - Only 'file://' URLs are supported - streaming would require a totally different audio solution (using MTAudioProcessingTap) and has many more edge and failure cases that would need to be handled. #jira UE-34315 Change 3088790 on 2016/08/15 by Luke.Thatcher [PLATFORM] [PS4] [~] Hook new PS4 crash handler up to the crash reporter website. - Removed indentation from generated crash context XML file. The crash reporter process does manual XML parsing which doesn't correctly handle whitespace at the start of lines. - Switched the final output folder to match the one the crash reporter process is watching. - Hide upload form on a config variable. #jira UE-34504 #jira OR-26886 Change 3089060 on 2016/08/15 by Luke.Thatcher [PLATFORM] [PS4] [!] Change PS4 crash handler log file extension to ".ps4chlog", otherwise the crash reporter site attaches the wrong log file to the crash report. Allowed showing of debug upload form via "Default.aspx?showform=1" query string. #jira UE-34504 #jira OR-26886 Change 3089089 on 2016/08/15 by Mark.Satterthwaite Duplicated changes to AppleMovieStreamer from CL #3088149. #jira UE-34315 Change 3089460 on 2016/08/15 by Mark.Satterthwaite Duplicate CL #3080971: Workaround a macOS 10.12 Beta bug on some Metal drivers that can't initialise temporary/local variable arrays, only those that are marked threadgroup shared. #jira UE-34355 Change 3089465 on 2016/08/15 by Mark.Satterthwaite For Metal shader translation retain more precision for float constants -1.0f >< 1.0f by emitting them in scientific notation - prevents Hammersley constant amongst others from being flushed to 0. Change 3089902 on 2016/08/15 by Daniel.Lamb Changed the next compiling ID to the correct compiling ID. #test Cook Change 3089903 on 2016/08/15 by Daniel.Lamb Cooker monitors config useage during cook and uses those settings to invalidate cooked content instead of all config settings. Change 3090114 on 2016/08/16 by Luke.Thatcher [PLATFORM] [PS4] [~] Minor change to PS4 settings text on crash handler site. Change 3090949 on 2016/08/16 by Nick.Shin WebSocketNetDriver crash fix filled in missing chunk of code that calls PacketHandler's "packet modifiers" #jira UE-25492 HTML5 Client cannot connect to Windows Server #jira UE-30880 WinServer crashes when NetDriver is set to WebSocket and Client attempts to connect via websocket #code.review john.pollard john.barrett Change 3091265 on 2016/08/16 by Brent.Pease Add IOS support to HarfBuzz Change 3091267 on 2016/08/16 by Brent.Pease Add references to fix mono build Change 3091291 on 2016/08/16 by Nick.Shin CIS warning fix #jira UE-25492 HTML5 Client cannot connect to Windows Server #jira UE-30880 WinServer crashes when NetDriver is set to WebSocket and Client attempts to connect via websocket Change 3091781 on 2016/08/17 by Joe.Barnes UE-33640: Exposed UPrimitiveComponent::IsAnyRigidBodyAwake() to Blueprints. Change 3092687 on 2016/08/17 by Daniel.Lamb Added support for using binned allocator in cooker instead of tbb. #test Cook shootergame. Change 3093867 on 2016/08/18 by Mark.Satterthwaite Use a read/write mutex to protect access to Metal's internal shader pipeline caches so that parallel threads can progress in the common case where new shaders are not being compiled. Change 3093950 on 2016/08/18 by Mark.Satterthwaite Change the Mac GPU identification code to cope with AMD's new naming scheme on 10.12. Change 3093951 on 2016/08/18 by Mark.Satterthwaite More SCW threads on Mac - they work now. Change 3093960 on 2016/08/18 by Mark.Satterthwaite Increase the default number of command-buffers on Mac because bigger games overflow the current limit of 64 per queue. Change 3096493 on 2016/08/22 by Jeff.Campeau Use Xbox version of DirectX include. Change 3097509 on 2016/08/23 by Luke.Thatcher [PLATFORM] [PS4] [+] Refactor PS4 Symbol Publish - Moved the SymStore task from Win.Automation to BuildGraph.Automation, and made it more generic. - The specifics of uploading symbols are now implemented in the platform tool chain, alongside StripSymbols(). - Re-generated the build graph schema file. - Removed the old PS4 symbols upload path in the package step. Modified OrionBuild.xml to publish symbols for all PS4 dev, test and shipping config builds of OrionClient. Change 3097635 on 2016/08/23 by Luke.Thatcher [PLATFORM] [PS4] [+] Refactor Age Symbols task in UAT. - Moved the AgeStore task from Win.Automation to BuildGraph.Automation and made it more generic. - Symbol server directory structure is now defined by the platform tool chain, which the common task uses to clean out old symbols. - Added a "filter" parameter to prevent age tasks deleting symbols from unrelated builds in shared symbol servers. Modified OrionBuild.xml to age both the Windows and PS4 symbol stores. Change 3097713 on 2016/08/23 by Luke.Thatcher [PLATFORM] [PS4] [+] Enable new PS4 crash handler server - Created live deployment profile and applied the required config file changes. Change 3099214 on 2016/08/24 by Luke.Thatcher [PLATFORM] [PS4] [!] Fix compile error in PS4 tool chain. For some reason, this only breaks ocassionally. Maybe we're alternating between the 2013 and 2015 C# compilers depending on what initiates the build (e.g. Visual Studio vs GenerateProjectFiles)? Change 3099222 on 2016/08/24 by Luke.Thatcher [PLATFORM] [PS4] [+] Added PS4 support for FPlatformMisc::MessageBoxExt using the MsgDialog library. - Note, only one and two button message dialogs are supported (limitation of MsgDialog). Change 3099260 on 2016/08/24 by Luke.Thatcher [PLATFORM] [PS4] [~] Better PS4 exit function. Calls quick_exit instead of abort when we've not asserted. Allows for a "cleaner" forced exit without generating a crash dump. Change 3101192 on 2016/08/25 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3101944 on 2016/08/25 by Daniel.Lamb Ask to save the current level when we are using launch on. Change 3102036 on 2016/08/25 by Nick.Shin check for minimum expected size upon data received from network #jira UE-13657 - HTML5 plugin OnRawRecieve overflow Change 3102115 on 2016/08/25 by Brent.Pease - Fix small errors that probably only show up in the mac mono build #code.review peter.sauerbrei Change 3102747 on 2016/08/26 by Jeremiah.Waldron Re-submitting OnlineSubsystemGameCircle with TPS permission for Amazon SDK - Also fixed the plugin to remove any related files from the final package when IAP is disabled or GameCircle support itself is disabled with the plugin still enabled - Added support for new AlreadyOwned IAP response code as well which is already used for GooglePlay and IOS Change 3102900 on 2016/08/26 by Nick.Shin since last checkin (CL: 2981945) - prints are crashing the browser - this change will allow browser to print the details via console.log() #jira UE-26047 - HTML5 HTTP Response Headers not implemented Change 3103130 on 2016/08/26 by Brent.Pease UE-24679 - Enable the ability to change ports for a firewall to pass them through rsync Change 3103225 on 2016/08/26 by Daniel.Lamb Fixed issue with warning which would cause crash. Change 3103425 on 2016/08/26 by Dmitry.Rekman Enable offscreen GL rendering without X. - Added new video subsystem to SDL that is uses EGL to initialize the context. - Most windoing functions stubbed. - Also added a new test case to TestPAL for easier debugging. Change 3104743 on 2016/08/29 by Brent.Pease Support remote offline metal shader compilation Change 3105051 on 2016/08/29 by Brent.Pease UE-2382 - TASK: MobleMVP: iOS: Add ability to view iOS device console output in the editor UFE - IOS Automation will now create a thread to collect the console logs from the device and send them to C# Console output while the app is running on device - Made ProcessResult an interface (IProcessResult) which ProcessResult implements. This allows platforms to provide their own implementation if needed. - Moved the RunLoop related parts of CoreFoundation into MobileDevice.cs Change 3105053 on 2016/08/29 by Brent.Pease - IOS dll's as part of the last check-in Change 3106853 on 2016/08/30 by Jeff.Campeau Implement FD3D11DynamicRHI::RHICreateComputeFence to prevent memory overwrite Change 3107361 on 2016/08/30 by Dmitry.Rekman Renderer: changes to allow postproc delegates. Change 3107362 on 2016/08/30 by Dmitry.Rekman Plugin with a CUDA postproc example. - Linux version only. Runs under a headless GL too (without X). - Disabled during cross-compilation, can be compiled natively only. - CUDA kernel should be compiled separately, CMakefile with compilation attached (can be used to generate VStudio projects as well). - To test the output, run under the debugger, interrupt and set global variable GSaveTheOutput to 50 (this will write out kernel output buffer 50 times as .bmp files into working directory). Change 3107913 on 2016/08/31 by Daniel.Lamb Fixed loading of cooked content in the editor. Change 3107916 on 2016/08/31 by Daniel.Lamb Added error case when shader compilation fails to notify shader. #test Cook shooter game. Change 3108080 on 2016/08/31 by Josh.Adams - Fixed PS4Automation compile errors Change 3109077 on 2016/08/31 by Brent.Pease Fix C# debug builds by specifying x64 and add reference to MobileDeviceInterface Change 3110086 on 2016/09/01 by Dmitry.Rekman Fix race condition in PThread runnable (UE-35074). - Instead of relying on busy-wait, join the threads. This prevents race between PostRun() (executed in the context of the thread) and FPThreadRunnableThread() destructor (see UE-34909). - Do not use an invalid value for pthread_t, since there's none. Change 3110172 on 2016/09/01 by Dmitry.Rekman Fixed a crash exiting VR Preview on Windows GL4 (UE-28708). - PR #2188 submitted by ardneran. Change 3110313 on 2016/09/01 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3111134 on 2016/09/01 by Dmitry.Rekman UBT: prevent mono from hanging on Ctrl-C. - Sometimes Ctrl-C can cause thread creation to fail. Without this change, UBT would lock up. Change 3111171 on 2016/09/01 by Brent.Pease Move all C# projects to use the x64 Platform for consistency with other changes made to move to the x64 Platform Change 3111177 on 2016/09/01 by Dmitry.Rekman Fix Linux build on systems without CUDA (UE-35460). Change 3111548 on 2016/09/02 by Luke.Thatcher [PLATFORM] [PS4] [!] Fix for PS4 iterative deployment. - Changes in Dev-Mobile broke the deployment manifests, as PS4 was now using the wrong filename when creating delta and obsolete file lists. Change 3111863 on 2016/09/02 by Dmitry.Rekman Better fix for build without CUDA (UE-35460). Change 3112738 on 2016/09/02 by Mark.Satterthwaite Fix the pausing particles on Metal - one line bug in the Metal query implementation meant that the first query wouldn't return the correct result for no good reason. #jira UE-34989 Change 3114579 on 2016/09/06 by Chris.Babcock Fix Vulkan include path in NDK check (contributed by geediiiiky) #jira UE-35490 #github #2758 #ue4 #android Change 3115115 on 2016/09/06 by Jeff.Campeau Calculate buffer size for paks using the bitwindow override as needed Change 3115600 on 2016/09/07 by Luke.Thatcher [PLATFORM] [PS4] [~] Make the crash dump handler registration much earlier, to catch crashes in early engine init. - Fixed up places in FGenericCrashContext::SerializeContentToBuffer which used the command line. If we crash early, the command line may not have been initialized yet. - Added a GetNoInit function to FThreadHeartBeat to avoid creating the heart beat thread if we crash early, and the thread doesn't exist yet. Tested by calling abort() immediately inside int main(), and we get a valid crash dump that the crash handler service can consume. Change 3115676 on 2016/09/07 by Luke.Thatcher [PLATFORM] [~] Dev-Platform integration fix for original CL 3064888 in //Orion/Release-29.1 Add .exe and .dll to windows symbol upload file filters. Change 3115811 on 2016/09/07 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3115944 on 2016/09/07 by Michael.Trepka Implemented IsGamepadAttached() for Mac Change 3115948 on 2016/09/07 by Michael.Trepka Don't try to restore Help menu item on Mac if MenuBlock does not contain it Change 3116200 on 2016/09/07 by Jeff.Campeau Fix parameter ordering Change 3117660 on 2016/09/08 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3117728 on 2016/09/08 by Michael.Trepka Copy of CL 3117698 by Mike.Fricker Fixed regression with editor's Simulate mode where cursor would teleport back to the center of the viewport after every click - This bug was introduced in CL 3075932 from a borderless window cursor handling fix that was needed for games that capture the cursor Change 3117797 on 2016/09/08 by Peter.Sauerbrei Shader Resource compression Change 3117988 on 2016/09/08 by Brent.Pease - Solutiion generator will now pick x64 instead of AnyCPU for the default platform configuration - Fix what I think was a merge error in BuildGraph.cs Change 3118296 on 2016/09/08 by Daniel.Lamb Fixed crash with launch on. Couldnt' correctly detect previous generated ini settings. #test launch on QA game #jira UE-35741 Change 3118438 on 2016/09/08 by JohnHenry.Carawon Fix UAT compilation on Linux #UE-35745 Change 3118934 on 2016/09/08 by Jeff.Campeau Shader compression setting based on target platform instead of cooking host platform. #jira UE-35753 Change 3120190 on 2016/09/09 by Ben.Marsh Add missing Platform attribute to build script for Dev-Platform. [CL 3120378 by Josh Adams in Main branch]
2016-09-09 20:13:41 -04:00
var ClientProcess = (IProcessResult)Args[1];
LogFileReaderProcess(ClientLogFile, ClientProcess, (string Output) =>
{
if (String.IsNullOrEmpty(Output) == false)
{
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 4285612) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3836829 by Ben.Marsh UBT: Fix ability to precompile plugins from installed engine builds. Change 3839519 by Ben.Marsh UBT: Simplify configuring bPrecompile and bUsePrecompile settings for modules. Each rules assembly can now be configured as installed, which defaults the module rules it creates to use precompiled data. Change 4042043 by Steve.Robb GitHub #4705 : Added weak lambda's for delegates and multicast delegates. Change 4042056 by Robert.Manuszewski Optimized Mark Phase of GC by up to 10ms by making it run in parallel and removing a huge array presize which we didn't need. Change 4042104 by Robert.Manuszewski Set the minimum GC cluster size to 5 so that GC doesn't have to process micro clusters which are more expensive than processing individual objects + Exposed the minimum cluster size to ini and project settings as gc.MinGCClusterSize + Added the ability to sort clusters by name/object count/mutable object count/referenced clusters count when dumping them with gc.ListClusters command Change 4042377 by Robert.Manuszewski Reworked how GC and other threads (ALT specifically) interact - GC will now notify the ALT it wants to run and ALT will immediately try to finish its current work to allow that. Also the entire ALT tick is now protected against GC running at the same time to improve ALT stability. + added gc.ForceCollectGarbageEveryFrame console variable that triggers a forced GC every frame Change 4042427 by Robert.Manuszewski Changed FGCCSyncObject to use events when waiting for GC to finish so that it doesn't spin on non-game threads when GC is running Change 4042482 by Robert.Manuszewski Unhashing unreachable objects (ConditionalBeginDestroy) will now also be done incrementally, just like the purge phase of Garbage Collection Change 4042635 by Robert.Manuszewski Fix for a potential assert when incremental purge garbage is pending and something forces a full purge Change 4044092 by Steve.Robb Fix for forward declared CoreUObject weakobject types in delegates when building in Clang. Change 4044102 by Robert.Manuszewski Fix for a possible hang when worker threads are preventing GC from running and something is later trying to FlushAsyncLoading with the Async Loading Thread enabled Change 4044113 by Steve.Robb Another Clang fix. Change 4044160 by Robert.Manuszewski Disregard For GC pool will now be enabled by default in cooked builds Change 4044287 by Steve.Robb Typo fix. Change 4047723 by Graeme.Thornton TBA: Fixes for import/export name cache and object resolving Change 4048015 by Graeme.Thornton TBA: Weak/Soft/Lazy pointer serialization changes * Remove FWeakObjectPtr::Serialize, move it's logic into, and replace usages of with calls to, FArchiveUObject::SerializeWeakObjectPtr(). Ensures that something is always sent to the archive so that structured archives can be kept happy in the future. * Added Weak/Soft/Lazy pointer handling to the structured archive slot interface and all the formatters. Binary formatters just forward the call onto their inner and text archives store as a string path reference. * FArchiveUObjectFromStructuredArchive caches all these pointer types and stores indices in the binary block, same as with a UObject*. All pointers are then forwarded to the underlying formatter in one go on finalization. Change 4048021 by Steve.Robb Fix for binding an unbound TFunction to another TFunction with a different signature. Also all null pointers now count as unbindings, not just nullptr. TIsMemberPointer added. TIsATFunction and TIsATFunctionRef renamed to remove the 'A's. Change 4048544 by Robert.Manuszewski Fixing ConditionalBeginDestroy profiling after changes to incremental CBD. Change 4051028 by Graeme.Thornton TBA: ArchiveFromStructuredArchive adapter uses Inner to determine if it is outputting to text, and sets it's own ArIsTextFormat to false Change 4051056 by Graeme.Thornton TBA: High level tagged property / UObject base class text serialization - UObject serialize converted to structured archive - Properties written to text individually with text tags, and then binary adapted values - Only saves, doesn't load Change 4051111 by Graeme.Thornton TBA: Temporarily disable loading of text assets until tagged property serialization path is fixed up Change 4051154 by Graeme.Thornton TBA: Convert a few uobject serializers to structured archive format for example purposes Change 4051181 by Graeme.Thornton TBA: Added default structured archive implementation of SerializeItem to UProperty, which just calls the FArchive version on an FArchiveUObjectFromStructuredArchive adapter. Implemented structured archive SerializeItem for UArrayProperty Change 4051197 by Graeme.Thornton TBA: ObjectProperty text serialization Change 4051216 by Graeme.Thornton Restored a modified FWeakObjectPtr::Serialize function to keep backwards compatibility in code I don't have access to. Change 4051261 by Graeme.Thornton TBA: Convert UMetaData to structured archive Change 4051374 by Steve.Robb Incorrect assert removed. Change 4051562 by Robert.Manuszewski Adding stats for the new GC internal functions Change 4051614 by Graeme.Thornton TBA: Removed UProperty::SerializeItem(FArchive, ...) and replaced with UProperty::SerializeItem(FStructuredArchive::FSlot, ...). Fixed up most of them to work properly and added adapters in for any that were non-trivial. Change 4052512 by Graeme.Thornton TBA: Temporary workaround for softobjectptr and lazyobjectptr uproperties not serialization anything when they know the archive is a reference collector. They should always be serializing their pointers and letting the underlying archive itself ignore them. Change 4053917 by Robert.Manuszewski Clustered objects from clusters that are no longer reachable will now be marked as unreachable immediately when gathering unreachable objects Change 4053919 by Robert.Manuszewski Added the ability to disable incremental BeginDestroy in ini/project settings Change 4055518 by Daniel.Lamb Fixup for deterministic audio generation issue. Submitted on behalf of Rich.Whitehouse #jira nojira #test prefilght automated test. Change 4056854 by Graeme.Thornton TBA: Added a test asset to EngineTest which contains all the different property types and test cases. Change 4056858 by Graeme.Thornton TBA: Updated USetProperty to proper structured archive usage Change 4056872 by Graeme.Thornton TBA: Add map property field to test object Change 4056873 by Graeme.Thornton TBA: Convert UMapProperty to full structured archive Change 4056994 by Graeme.Thornton TBA: Converted FText over to structured archive. Implemented saving, but not loading. Change 4059728 by Ben.Marsh UBT: Add support for using adaptive non-unity builds when the engine and project are in separate repositories. Change 4059805 by Graeme.Thornton Fixed typo in text serialization. Fixes CIS automation test errors Change 4060007 by Graeme.Thornton TBA: FArchiveFromStructuredArchive will now access it's host slot lazily, i.e. only when a value is actually written to the archive. Change 4060092 by Stefan.Boberg Added optimized Windows console window output path to GenericConsoleOutput since this slowed down cooking considerably (2 minutes spent in wprintf alone for one large dataset) When stdout is attached to a console we use the WriteConsoleW function instead of wprintf since the latter is very slow especially in unbuffered mode which the engine currently configures for stdout (see setvbuf call in LaunchEngineLoop.cpp). At some point we should reconsider this buffering policy since it's likely to slow down other platforms as well but I wanted to do a safe change for now as I don't yet fully understand why the setvbuf call is there in the first place. Change 4060108 by Stefan.Boberg Introduced some additional target platform utilities to help with asset cook optimizations * We now assign each ITargetPlatform a zero-based ordinal value * Introduced FTargetPlatform and FTargetPlatformSet types to help store platform references and platform sets efficiently. These are not currently used in the engine but are designed to replace the existing ITargetPlatform/string/FName representations in the cooking data structures. Change 4060143 by Graeme.Thornton Undo //UE4/Dev-Core/Engine/Source/Runtime/... changelist 4060007 Needs some other changes that I haven't checked in yet... Change 4062432 by Ben.Marsh Fix error message when enumerating P4 changes. Change 4062648 by Ben.Marsh Add missing p4 integration action. Change 4063620 by Graeme.Thornton Integrated a fix from UDN where the engine would crash when trying to load a very small encrypted file (<16bytes) from a pak file, where the read address wasn't already aligned to the AES block size. (https://udn.unrealengine.com/questions/431989/crash-while-reading-a-very-small-file-in-encrypted.html) Change 4066963 by Robert.Manuszewski Fixing GC cluster verification code reporting false positives when a cluster is referencing another cluster through 'mutable' objects list. Change 4067133 by Robert.Manuszewski Changed log verbosity when reporting individual cases of GC cluster assumption violations as they are followed by an asser anyway and this way we get the chance to see all issues before we assert at the end of these checks. Change 4067443 by Steve.Robb FString can now be constructed from any char pointer type and length. Change 4068156 by Steve.Robb Fix necessary because of FString constructor change in CL# 4067443. Change 4070258 by Graeme.Thornton Fixes for VSCode Change 4070372 by Graeme.Thornton TBA: Script struct serialization to structured archives Change 4071913 by Ben.Marsh Move bulk of the code for UnrealPak into an engine developer module, so it can be used in the editor. Change 4071914 by Ben.Marsh Missing files. Change 4071937 by Ben.Marsh Missing header. Change 4072015 by Ben.Marsh Fixes for compiling PakFileUtilities as part of the editor. Change 4072826 by Steve.Robb TBitArray::Reserve() added. TBitArray::Add() overloaded to allow adding multiple bits. TSparseArray::Reserve() optimized to call the overloaded Add(). Change 4073271 by Daniel.Lamb Fixed add patch tier in project launcher passing the wrong commandline option to UAT. #test none Change 4074708 by James.Hopkin #core Removed redundant Casts Change 4074763 by Steve.Robb Fix for TSparseArray::Reserve() size. Change 4076063 by Ben.Marsh Add an "UnrealPak" commandlet with the same functionality as the standalone UnrealPak program. Invoke by running the editor with -run=UnrealPak and the standard UnrealPak commandline options. Change 4077064 by Robert.Manuszewski Fixing compile error in PakFileUtilities Change 4077144 by Graeme.Thornton TBA: TextAssetCommandlet improvements * Collect lists of broken assets during roundtrip tests and print a summary of packages that failed each phase at the end * After resaving as text, load the file back as a plain JSON hierarchy to ensure the output was valid Change 4077412 by Ben.Marsh Set the correct exit code for UnrealPak. Should return 0 on success, not 1. Change 4077760 by Graeme.Thornton TBA: Loading fixed for tagged property serialization Includes conversion of all UProperty::ConvertFromType() and SerializeFromMismatchedTag() functions to use structured archives Lazy initialization of FArchiveFromStructruredArchive when loading, to support the possibility of an adapter being create around an object property serialize call to its inner UStruct, which then decides not to do anything and return false. Stops the ArchiveFromStructuredArchive from consuming the slot and getting upset later on when we try to serialize normal tagged properties from it. Disabled lazy bulk data loading from text assets. Requires a bigger change to make it work. Added some debug checks to json input formatter which track the current value stack size when a new object is pushed onto the stack, and makes sure that the stack has returned to the same size when the object is popped. Catches cases where we unpack an array/stream to the value stack but then don't consume all the items. Change 4078800 by Ben.Marsh Change UAT to using the editor's UnrealPak commandlet rather than invoking the standalone UnrealPak executable. To improve performance when building several PAK files, also add a new -batch=<file> command which reads commands to execute in parallel from a text file. Change 4079745 by Graeme.Thornton TBA: Migrated a couple of UObject Serialize functions to FStructuredArchive (SoundCue / MaterialExpressions / Editor strip flags) Change 4079847 by Graeme.Thornton TBA: Add 'FindMismatchedSerializers' mode to text asset commandlet, which dumps out a list of all UClasses which don't have the CLASS_MatchedSerializers flag, meaning we can't guarantee the have Serialize functions for FArchive AND FStructuredArchive, therefore we can't use the new structured archive based serialize path. Should only ever be native instrinsic classes as UHT takes care of all other cases. Change 4079925 by Ben.Marsh Fix incorrect assignment when deriving name for chunked pak file. Change 4080214 by Ben.Marsh Move the ThreadPoolWorkQueue class into DotNETUtilities so it can be used by other projects. Change 4082394 by Graeme.Thornton CIS fix for variable shadowing warning Change 4082583 by Ben.Marsh Add a IBinarySerializable interface for types that support reading from a BinaryReader and writing to a BinaryWriter. Implementing IBinarySerializable implies a constructor taking a BinaryReader argument is available for deserializing. Change 4082652 by Ben.Marsh Fix FileReference.Directory not returning a directory with a trailing backslash for files in the root directory. Change 4082755 by Graeme.Thornton Fixed an erroneous usage of TUniquePtr<uint8>as a pointer to a uint8 array when creating pak files. Caused a crash when compression was enabled, and has probably surfaced because pak generation is now done by an editor commandlet rather than a standalone program. Change 4082756 by Graeme.Thornton Fixed some incorrect documentation for pakfile compressed chunk headers Change 4082883 by Graeme.Thornton Static analysis warning fix Change 4082912 by Ben.Marsh Move ExceptionUtils into DotNETUtilities. Change 4085291 by Graeme.Thornton TBA: In the Json output formatter, write float and double values out with enough precision for successful roundtripping. Added some debug only code which will immediately reconvert the string back to its original value and compare the the input Change 4085523 by Graeme.Thornton TBA: Remove only explicit usage of DECLARE_FSTRUCTUREDARCHIVE_SERIALIZER. Should only be used from UHT generated code. Change 4086037 by Robert.Manuszewski Fix for a potential race condition when two threads want to acquire GC lock Change 4088655 by Graeme.Thornton Pak creation now uses the bEnablePakSigning setting from the crypto config json file Change 4091474 by Steve.Robb Fix for TStaticBitArray::FindFirstSetBit() and TStaticBitArray::FindFirstClearBit(). Unused variables removed. Change 4093632 by Steve.Robb CIS fixes. Change 4093656 by Graeme.Thornton Build fix Change 4093744 by Ben.Marsh Allow per-chunk settings for whether to enable compression in UnrealPak. Change 4099712 by Gil.Gribb UE4 - Fixed rare case where insufficient space was preallocated for cooldown ticks. #jira UE-59686 Change 4099912 by Stefan.Boberg Cooking timer optimizations: - Replaced data structures for FScopeTimer and FHierarchicalTimerInfo. Previous implementation used FString for many things and caused *lots* of heap and string concatenation activity. Replaced with a compile-time node id (using __COUNTER__) and raw string literals. - Removed PERPACKAGE_TIMER support (was disabled by default and was difficult to test) - Made it possible to toggle OUTPUT_TIMING and ENABLE_COOK_STATS independently - Removed some extremely tight timers because the overhead from calling QPC significantly exceeded the measured code This change shaved some 15% off a clean cook of Fortnite WindowsClient (en) with fully populated local DDC Change 4100519 by Stefan.Boberg Quick fix for Linux build issue introduced in 4099927 Change 4105327 by Stefan.Boberg Cooker: Changed FHierarchicalTimerInfo so it uses a linked list for tracking child nodes, to be able to deal with any child count. Previously we assumed there would never be more than 9 children but it turns out there are cooker modes that need more. Fixes check when using -FullLoadAndSave to cook Change 4105448 by Stefan.Boberg - Fixed Linux build warning re: member initialization order - Also eliminated OUTPUT_HIERARCHYTIMERS/CLEAR_HIEARCHYTIMERS macros (plain functions are fine) - Moved finishing-up code for FullLoadAndSave() to TickCookOnTheSide() call site to improve timer output. Previously some of the scopes would not have been closed before printing and thus the output was misleading. Change 4109031 by Ben.Marsh Attribute-driven Perforce wrapper (old Epic Friday project). Offers a more complete implementation than the current P4 wrapper in UAT without requiring any platform-specific libraries. Uses the Python binary output for parsing. Change 4109588 by Ben.Marsh UBT: Add extension methods for serializing a nullable type to a BinaryReader/BinaryWriter. Change 4109595 by Ben.Marsh Missing project file for DotNETUtilities. Change 4110724 by Stefan.Boberg Removed annotation map locking in UObjectMarks, eliminating around one minute (~3.5%) from Fortnite cook time. The locking was redundant since the annotation maps are managed per thread anyway. Change 4111304 by Ben.Marsh UAT: Add support for setting a status message through the log class. Allows writing transient messages (eg. progress messages) which will be cleared out before writing other messages. Best used through the LogStatusScope class, which can set a status message for the duration of a using() block. As part of this change, the console no longer has to be added as a dedicated trace listener. Since we already special-case this listener when formatting log output, it's easier to just keep the implementation separate to the other trace listeners. Change 4112708 by Steve.Robb Fix for TBitArray::MaxBits in assignment. Change 4114133 by Stefan.Boberg Tweaked how low-level memory (LLM) tracker is implemented to reduce overheads. Previously FMemory functions would acquire the LLM singleton and call OnLowLevelFree/OnLowLevelAlloc etc which would check the bIsDisabled flag and early out if it was set. Due to how frequently these functions were called this ended up costing quite a bit. - This change makes the flag a static member variable instead of a member variable and therefore enables a simpler early-out to be implemented. - The singleton getter is also simplified to avoid hitting the threadsafe singleton construction path on every call. - The enable flag is no longer TAtomic - this also incurs extra overhead for no clear benefit Shaves approximately 3.5% (one minute) off a Fortnite cook test scenario (using -FullLoadAndSave) Change 4115010 by Robert.Manuszewski Fixing CIS Change 4115249 by Robert.Manuszewski Fixing async loading code asserts when exiting game very early due to an error #jira UE-56267 Change 4117091 by Ben.Marsh Prevent doubled-up lines when writing status updates with console log verbosity. Change 4117207 by Ben.Marsh UGS: Do not include executables in diagnostics zip file, and ignore "no such files" error when cleaning workspace. Change 4119175 by Ben.Marsh UGS: Fix crash writing version files when directory does not already exist. Change 4119987 by Ben.Marsh UGS: Show a dialog box while the launcher is updating executables from Perforce, which allows cancelling the operation if necessary. Allow setting the username on the settings window, and prompt for login credentials if necessary. Should prevent situations where users have to update settings from the command prompt. Holding down shift during launch now shows the settings dialog rather than an immediate prompt to launch the unstable version (unstable version is shown as a checkbox on this dialog). Change 4119991 by Ben.Marsh Update version number for UGS launcher to 1.13. Change 4121943 by Robert.Manuszewski Don't use FArchiveAsync2 for reading packages with non-async path in editor builds as its performance is worse than the standard archive's (saves about 1 minute when doing larger cooks and 7 seconds when loading into PIE) Change 4122592 by Steve.Robb GitHub #4762 : Improve wording and grammar of Math comments Also includes improved accuracy in FMath::ComputeBoundingSphereForCone(). Change 4122819 by Stefan.Boberg Don't call CreateDirectory redundantly when opening files for writing using FFileManagerGeneric::CreateFileWriter This change avoids calling IPlatformFile::CreateDirectoryTree if possible since this is a very expensive function especially for deep hierarchies as it performs directory creation from the root directory onwards instead of from the leaf downwards. That function should also be fixed but this change improves performance in the meantime. Change 4122872 by Stefan.Boberg CreateDirectoryTree now creates directories leaf-to-root instead of the other way around. This is much more efficient since we don't spend time on system API calls for directories which already exist. This accounted for a very large amount of CPU time in cooking as the full target file directory hierarchy would be "created" for every single output file. Change 4123109 by Stefan.Boberg - Disable overlapped I/O in editor / cooker. Synchronous I/O reduces the number of syscalls and Windows performs prefetching on our behalf anyway for sequential reads - Eliminated syscall which was issued for every write to update cached file size -- since we're the only writers to the file (file access allows read sharing at most) we can authoritatively update the file size on write completion Change 4123455 by Ben.Marsh PR #4775: New build param PCHMemoryAllocationFactor to set /Zm VS build param. (Contributed by lucaswall) Change 4124207 by Ben.Marsh UBT: Remove some unnecessary indirection for generated code paths. Change 4124217 by Ben.Marsh UBT: Remove another unused variable from UEBuildModuleCPP. Change 4124377 by Stefan.Boberg In IPlatformFile::DeleteDirectoryRecursively, attempt to delete file first and if it fails clear the readonly flag and try again Previously there was a call to clear the readonly flag for every deleted file and this is a waste of resources 99% of the time. The SetFileAttributes call accounted for a significant amount of time during cooker sandbox directory deletion Change 4125071 by Stefan.Boberg Some tweaks to FQueuedThreadPoolBase scheduling and memory management - Explicitly pass in false for TArray::RemoveAt(..., bool bAllowShrinking) argument to prevent memory reallocation when arrays are drained and inevitably repopulated shortly afterwards - Use a MRU strategy instead of LRU when picking a thread to wake up. The MRU thread is the most likely to have a 'hot' cache for the stack etc. Picking from the back of the array also happens to be cheaper since no memory movement is necessary when RemoveAt is called. (This was the strategy in place before CL2600362 which seems to have changed it unintentionally) - Release lock as soon as a thread has been chosen, before asking the worker thread to wake up and do the work Change 4126132 by Ben.Marsh UAT: Detect when stdout is redirected and prevent using backspace characters to move the cursor. Change 4126867 by Graeme.Thornton TBA: Fix tagged binary formatter Change 4127010 by Robert.Manuszewski AnimScriptInstances created at runtime will now also be added to the owning omponent's cluster to avoid GC issues. Change 4127932 by Ben.Marsh WorkspaceTool: Reduce unnecessary logging of status messages when console output is not redirected. Change 4129050 by Ben.Marsh UGS: Check for NET Framework 4.5 being installed before running the installer. Also fix warning trying to kill existing UGS instances before upgrade. Change 4129459 by Graeme.Thornton TBA: TextAssetCommandlet - When outputting converted assets to an output path, replicate the workspace relative path in the output directory Change 4129515 by Graeme.Thornton TBA: Add EnterRecord overload that allows outputting of available field names when loading. Change 4129517 by Graeme.Thornton TBA: Tagged properties are written out as named fields on the "Properties" record, rather than as a stream with a null tag at the end Change 4129518 by Graeme.Thornton TBA: Added a local const bool to allow easy hacking out of text asset loading support Change 4129558 by Graeme.Thornton TBA: Build fix for textasset-less configs Change 4129614 by Ben.Marsh UGS: Main window is now restored to normal size when activated by clicking on the tray icon. #jira UE-60490 Change 4129618 by Ben.Marsh UGS: Speculative fix for unreproduced exception accessing disposed window while shutting down. Change 4131936 by Robert.Manuszewski Removing some WIP code accidentally checked in with CL #4121943 Change 4133490 by Ben.Marsh UGS: Allow the $(Change) variable to be used in more places than just the context menu. #jira UE-60573 Change 4133550 by Ben.Marsh UGS: Setting for whether or not to use incremental builds is now exposed through the variable "$(UseIncrementalBuilds)" for use by custom build steps. #jira UE-60554 Change 4133681 by Ben.Marsh UGS: A per-project list of folders and extensions to be deleted by default when running the 'clean workspace' tool can now be specified through the <ProjectDir>/Build/UnrealGameSync.ini file. Settings may be specified for an individual branch (via a category with the depot path to the project) or for wherever the project is currently open (via the [Default] category). The SafeToDeleteFolders list specifies a substring that will be checked against folder paths. Anything containing this folder will be marked as safe for delete by default. The SafeToDeleteExtensions list specifies a list of extensions for files that can always be deleted. Example: [Default] +SafeToDeleteFolders=/MyGame/Test/ +SafeToDeleteFolders=/DataService/ +SafeToDeleteExtensions=.xx1 +SafeToDeleteExtensions=.xx2 #jira UE-60575 Change 4135449 by Ben.Marsh Fix allowing use of Job objects on Windows platforms (debug code submitted by mistake) Change 4135730 by Ben.Marsh UBT: Plugins can now be enabled and disabled from the .target.cs file (for targets that do not use the shared compile environment), by compiling the list of enabled/disabled plugin names into the Projects module. Change 4135823 by Ben.Marsh UBT: Remove legacy code to handle disabling optional plugins; now that this is compiled into the target, it will work for any plugins we choose. Change 4135945 by Ben.Marsh UBT: Fix error running programs with no explicitly enabled or disabled plugins. Change 4137207 by Ben.Marsh UGS: Align all badges with the same name, to make it easier to see which CIS steps are being run. Allow overriding the slot taken by a particular badge by calling it "SlotName:LabelName". Change 4137311 by Stefan.Boberg Removed child cooker support. In practice it is not a useful feature as it provides no performance improvement (quite the opposite in fact) and adds testing and maintenance complexity. Change 4137393 by Ben.Marsh UGS: Fix display of multiline errors in the status panel. Change 4141708 by Steve.Robb GitHub #3631 : Incorrect default argument in WeakObjectPtrTemplate #jira UE-45490 Change 4146655 by Stefan.Boberg Removed FullGCAssetClasses logic - no longer necessary nor useful Change 4147318 by Ben.Marsh UGS: Compress build badges in a column if it shrinks below the size that they would be visible. Change 4148207 by Ben.Marsh UGS: Added support for showing the latest completed build from a specific list of badges in the status panel. To declare a badge as one that should appear in the status panel rather than the CIS column, add it to the project's UnrealGameSync.ini in the project or [Default] section like so: +ServiceBadges=RoboMerge Change 4148282 by Stefan.Boberg Fixed bug in UCookOnTheFlyServer::GetCookOnTheFlyUnsolicitedFiles - UnsolicitedFiles should be passed by reference not by value Change 4148344 by Stefan.Boberg Fixed minor indentation error (most likely caused by sloppy merge) Change 4148521 by Stefan.Boberg Removed accidentally checked in PRAGMA_DISABLE_OPTIMIZATION from CookOnTheFlyServer.cpp Change 4148639 by Ben.Marsh UGS: Fix tooltips not showing for changes that have description badges. Change 4149373 by Ben.Marsh UGS: Allow adding additional columns to display particular badges by adding entries from the project config file. Example syntax: +Columns=(Name="Desktop",MinWidth=50,DesiredWidth=100,Weight=3,Badges="Editor") +Columns=(Name="Mobile",MinWidth=50,DesiredWidth=100,Weight=3,Badges="IOS,Android") Same form can be used to control how default columns are displayed (though badge settings are ignored). Also allow PerforceMonitor to detect local changes to project config files and update settings automatically. Change 4149399 by Ben.Marsh UGS: Update version to 1.143. Change 4155660 by Steve.Robb PROJECTION and PROJECTION_MEMBER macros which provide the correct behavior when creating projections using functions which are overloaded or use default arguments. Change 4157117 by Ben.Marsh Fix warning due to plugins disabled in .target.cs file. Change 4158011 by Ben.Marsh UBT: Add a check that the UnrealHeaderTool target file exists, rather than throwing an exception when reading it fails. Change 4158646 by Ben.Marsh UGS: Fix exception when login is discovered to have expired during a workspace update. Change 4158678 by Ben.Marsh UGS: Fix an exception on shutdown due to the icon being hidden after it's already been disposed. Change 4158683 by Ben.Marsh UGS: Add an unhandled exception filter which sends the exception data to the backend. Change 4159131 by Ben.Marsh UGS: Reduce the number of characters displayed for build badges based on the available space. Change 4159194 by Graeme.Thornton TBA: Fix incorrect map property conversion code when converting an old property that contains a map with different key/value types Change 4159239 by Steve.Robb Improved readability and compliance with coding standards. Change 4159246 by Ben.Marsh UGS: Allow syncing projects where source code is not available (and various version files don't exist). #jira UE-60985 Change 4159286 by Ben.Marsh UGS: Remove requirement for UE4Editor.target.cs to be visible in the depot in order to open a project. #jira UE-60986 Change 4159302 by Ben.Marsh UGS: Update version to 1.144. Change 4160308 by Ben.Marsh All staging client executables for blueprint projects. #jira UE-60983 Change 4161567 by Steve.Robb GitHub #4816 : UE-60771: Handle escaped double quote in FParse::LineExtended Change 4162641 by Ben.Marsh UGS: Allow customizing the position of custom columns, via the Index=N attribute. Change 4162647 by Ben.Marsh UGS: Update version to 1.145. Change 4165319 by Robert.Manuszewski PR #4812: Fix inconsistent command-line argument handling under Windows (Contributed by adamrehn) Change 4166150 by Ben.Marsh UGS: Include *.inl when looking for code changes. Change 4166551 by Steve.Robb Whitespace fixes caused by a bad merge. Change 4168483 by Ben.Marsh UGS: Add a more useful error if a file to be synced exceeds the max allowed path length. Change 4168490 by Ben.Marsh UGS: Update version to 1.146. Change 4168551 by Ben.Marsh UBT: Move bBuildLargeAddressAwareBinary into an exposed setting. Change 4168560 by Ben.Marsh UBT: Remove static config variable for controlling which configuration of UHT to use. Change 4171296 by Ben.Marsh UGS: Move the check for overlong paths earlier. Change 4171531 by Ben.Marsh UBT: Fix exception if BuildConfiguration.xml contains an unknown category. Change 4183371 by Robert.Manuszewski Fix for a crash in Async Loading Graph's CheckCycles when GC kicks in on the game thread and forces ALT to exit early Change 4184312 by Ben.Marsh UGS: Update version to 1.148 Change 4184480 by Robert.Manuszewski Removing unused async loading stat Change 4186390 by Ben.Marsh UBT: Format XML validation errors in a format that allows double-clicking on the message in Visual Studio. Change 4188644 by Ben.Marsh UBT: Add the MakePathSafeToUseWithCommandLine() function to UBT. Change 4188647 by Ben.Marsh UBT: Fix exception in target receipt when architecture is null. Change 4189617 by Ben.Marsh Change FileSystemReference, FileReference and DirectoryReference objects to use OrdinalIgnoreCase comparisons without creating a separate copy of the string to compare. The filesystem does not use the invariant culture, and it can produce the wrong results in some cases (the ordinal comparison is faster, too). Change 4189740 by Ben.Marsh UAT: Remote code to build UnrealPak when packaging; we use the editor now. Change 4189860 by Ben.Marsh UGS: Make the filter for excluding automated lighting rebuilds more explicit. Change 4190082 by Ben.Marsh Fixes to allow enabling edit and continue for Windows builds. Have experienced quite a few VS crashes when testing it in editor; not yet recommended for general use. - Allow edit and continue for any configuration, not just debug. - Fixed PDB errors compiling files that use a shared PCH with edit and continue enabled. Path to the generated PDB file was using the wrong directory. - Removed code that tracks PDB output files, since they're modified multiple times during a build. - Enable debug information when compiling generated CPP files, since it causes errors if the shared PCH PDB doesn't have the same option. - Disable support for remote execution of steps that modify the PDB, since the same file has to be modified many times. Remote execution causes the PDB files to be corrupted. Unfortunately, this makes E&C builds significantly slower. #jira Change 4192949 by Ben.Marsh UBT: Minor tidy-up (merging UEBuildBinary.Build and UEBuildBinary.SetupOutputFiles) Change 4193218 by Ben.Marsh Fix formatting. Change 4197252 by Mike.Erwin UAT: Fix log output w/ correct count of non-code projects. #jira none Change 4197941 by Ben.Marsh UGS: Add support for DebugGame editors that have an executable with a DebugGame suffix. Change 4197964 by Ben.Marsh UGS: Prevent attempts to automatically reopen projects while a modal dialog is up, or the workspace is syncing. Change 4198144 by Ben.Marsh UGS: Prevent modal dialogs when login expires in P4, and prompt for password when hitting "retry". Change 4198413 by Ben.Marsh UGS: Always show the main window when launched manually, and run with -RestoreState when launched at startup. Also add a couple more places that save the visibility state, since logging off seems like it can terminate the process abrubtly. Change 4198779 by Ben.Marsh UBT: Allow generating manifests to any arbitrary locations with the -Manifest=<Path> argument. Change 4198825 by Ben.Marsh UBT: Move code to enumerate Slate runtime dependencies into the Slate module. Doesn't need to be done inside core UBT. Change 4199341 by Ben.Marsh UGS: Update version to 1.149 Change 4199642 by Chad.Garyet - Deprecate CISController - Add BuildController to replace CIS GET/POST for builds - Add LatestController, GET does what CIS/GET used to do - Change Latest/GET to return the last 25 builds filtered by project, rather than the last 5000 individual Ids - Latest/GET now returns "LatestData" object instead of array of longs - Updated EventMonitor to match all API changes - Fixed bug where IDs were getting reset to initial startup values every update loop Change 4199663 by Chad.Garyet CIS controller still needs to return an array of longs #jira none Change 4199680 by Ben.Marsh UGS: Update version to 1.150 Change 4200457 by Ben.Marsh Merging CIS fix for non-development configurations. Change 4200472 by Mike.Erwin UAT: fix -skipbuildclient param default It was defaulting to skipbuildeditor's value, likely a copy-paste error. #jira none Change 4202595 by Ben.Marsh Fix static analysis warning due to constant comparison against macro. Change 4203250 by Ben.Marsh UGS: Always show the "Sync Precompiled Editor" option, but disable it and show a tooltip explaining why if it is not available. Change 4206191 by Ben.Marsh Exclude editor target files from installed builds, since they leak info about DLLs that have been stripped out. Change 4213011 by Ben.Marsh UBT: Include contents of modified intermediate files in the log, to make it easier to debug hidden dependencies. Change 4213487 by Ben.Marsh UBT: Fix assumption that bPrecompile is equivalent to bBuildAllModules. This is no longer the case; they are now controlled by separate options. Should fix CIS errors building the editor. Change 4213609 by Ben.Marsh Ensure that strings formatted using FMicrosoftPlatformString::GetVarArgs() are always null terminated, whether we use the secure CRT or not. Change 4215971 by Ben.Marsh UBT: Remove action graph visualization code; no longer used. Change 4215996 by Ben.Marsh UBT: Remove unqiue id from all actions in the action graph. This is only used for printing debug info in the case of a (rare) cycle in the action graph, so just look it up when needed. Change 4216022 by Ben.Marsh UBT: Rename Crypto.cs to EncryptionAndSigning.cs to match the name of the class inside it, and move it under the System folder. Change 4216031 by Ben.Marsh UBT: Move all the action executors into their own folder in the project. Change 4216526 by Ben.Marsh Fix CIS warnings. Change 4216544 by Ben.Marsh Replace custom code to ensure FMicrosoftPlatformString::GetVarArgs() null terminates its buffer with Microsoft's standards-compliant implementation. Change 4216633 by Ben.Marsh Add support for UnrealPak plugins. * Project and plugin modules can now specify an array of supported programs in the "WhitelistPrograms" field of their module descriptors, to allow modules to be loaded by programs. * Programs can now load any runtime modules, as long as they are whitelisted. * Programs under the engine directory can now use a shared build environment, so that building with a project file does not cause output binaries to be output to the project directory. * UnrealPak is now always built by default when packaging * Convert UnrealPak to a modular configuration Change 4216736 by Ben.Marsh UnrealPak: Move "ExportDependencies" command into an editor commandlet, since it relies on the UObject system, asset registry, etc... Change 4217447 by Ben.Marsh Back out revision 50 from //UE4/Dev-Core/Engine/Build/InstalledEngineBuild.xml Change 4217451 by Ben.Marsh Back out revision 11 from //UE4/Dev-Core/Engine/Plugins/Developer/VisualStudioSourceCodeAccess/Source/VisualStudioSourceCodeAccess/VisualStudioSourceCodeAccess.Build.cs Change 4217617 by Ben.Marsh Back out changelist 4217451 Change 4222552 by Ben.Marsh Don't use #import <TypeLib> for VS source code accessor when building with Clang; it's not supported. Change 4222630 by Ben.Marsh UBT: Fix spam while generating project files if Clang isn't installed. Change 4223316 by Ben.Marsh UBT: Change the order in which Visual C++ toolchains are enumerated to prefer full releases over preview releases. Change 4223318 by Ben.Marsh UBT: Add a build setting which allows creating a dedicated PCH for every file that's excluded from the unity working set (disabled by default). Improves iteration times when working on individual cpp files, but slows down iterating on header changes (and can take a lot of disk space for large changes). Dedicated PCH contains all includes scraped from the top of each cpp file, until a non-#include directive is encountered. Change 4223401 by Ben.Marsh UBT: Add an option to automatically enable edit and continue for files in the adaptive non-unity working set. E&C doesn't seem very useful for UE4 projects right now; compile time is comparable to regular build times, but it can take several minutes to apply code changes for large projects. Change 4223899 by Ben.Marsh UBT: Fix loading XML config files on Mono; Type.GetField(Name) does not seem to return values unless binding flags are specified. Change 4224637 by Ben.Marsh Add a "SupportedPrograms" field to plugin descriptors, which allows plugins to declare which plugins they support independently of individual modules. Programs now respect the "bEnabledByDefault" setting in plugins. Plugins that are compatible with a program now need to list that program in the SupportedPrograms list, and whitelist any modules that should load for that program. Change 4224710 by Ben.Marsh UBT: Don't add import libraries as final build products unless the target is being precompiled. Prevents the need for building them for leaf nodes in the action graph. Change 4224715 by Ben.Marsh UBT: Remove hack to allow Stats2.cpp to not follow IWYU convention. Change 4224726 by Ben.Marsh Remove commented out line. Change 4224903 by Ben.Marsh Fix non-unity compile error in Stats2.h. Change 4225051 by Ben.Marsh Back out changelist 4224710; causing CIS errors due to receipts not matching. Change 4225134 by Ben.Marsh Fixing non-unity errors. Change 4225203 by Ben.Marsh Another non-unity fix. Change 4225249 by Ben.Marsh Fix Linux dependencies being copied for the Windows editor; they can be added as requirements for the Linux target platform on Windows instead, so it respects the user's chosen platforms. #jira UE-62001 Change 4225512 by Ben.Marsh BuildGraph: Allow setting the target to build when using the <CsCompile> task. Change 4228815 by Ben.Marsh UBT: Always add the generated code directory to the list of include paths when generating project files. It may only be created after UHT has been run. Change 4228944 by Ben.Marsh UBT: Remove legacy CppCompileEnvironment and LinkEnvironment wrappers from TargetRules that were deprecated in 4.19. Change 4229028 by Ben.Marsh UBT: Fix editor targets with unique build environment having the wrong executable path in generated project files. Move move logic to configure target rules post-construction by the rules assembly to ensure it's valid. Change 4229065 by Ben.Marsh UBT: Move another target setting into the rules assembly. Change 4229105 by Ben.Marsh Fix BPT exception when generating project files. Change 4229311 by Ben.Marsh UBT: Store the module rules file location on the ModuleRules instance, as well as the plugin that it was created from. Also expose the plugin directory as a property on the ModuleRules instance. Change 4229421 by Ben.Marsh UBT: Consolidate functionality for UHT module setup in ExternalExecution.cs. Change 4229817 by Ben.Marsh UBT: Modules must now explicitly specify the path to the header used to generate a PCH if one is desired, rather than the header being determined automatically by attempting to parse the source code. Now that PCHs are force-included anyway, this removes a lot of dependencies inside UBT. Change 4229824 by Ben.Marsh UBT: Remove unused lists inside UEBuildModuleCPP.SourceFilesClass. Change 4229841 by Ben.Marsh UBT: Remove some legacy code from auto-detecting PCHs. Change 4230521 by Ben.Marsh UBT: Add utility functions to the log class to allow formatting errors and warnings in Visual Studio output format (eg. File(Line): warning: Message) Change 4230871 by Ben.Marsh UAT: Remove StreamUtilis utility class; there is a simpler way to implement the one place it's used. Change 4230882 by Ben.Marsh UAT: Add StreamUtils back into UAT, seems like it's still used there. Change 4230896 by Ben.Marsh UBT: Remove some redundant parameters from UEBuildModule/UEBuildModuleCPP/UEBuildModuleExternal constructors. Change 4231014 by Ben.Marsh WorkspaceTool: Include a dump of raw bytes when garbage is read from the P4 process, for diagnostic purposes. Change 4231032 by Ben.Marsh Fix CIS. Change 4231096 by Ben.Marsh Bump the FlatCPPIncludeDependencyCache version, to prevent errors trying to load old files. Change 4231446 by Ben.Marsh UBT: Added support for expanding UE-specific variables in include paths and library paths: $(EngineDir), $(ProjectDir), $(PluginDir), $(ModuleDir). Change 4231460 by Ben.Marsh Modules may now explicitly specify rpaths on Linux via the PublicRuntimeLibraryPaths and PrivateRuntimeLibraryPaths properties. Change 4233909 by Robert.Manuszewski PR #4779: Reason fails as the supplied variable is incorrect (Contributed by projectgheist) Change 4233910 by Ben.Marsh Enable PCHs on IOS. Reduces build time by ~25%. Change 4234176 by Ben.Marsh UBT: Add better messaging for modules that need to have a private PCH set. Now detects the likely PCH using the same method as legacy code and includes it as a suggestion. Change 4234193 by Ben.Marsh Add the Delete command to Perforce wrapper in DotNETUtilities. Change 4234688 by Ben.Marsh UBT: Simplify handling of installed/precompiled builds. Settings for whether a folder is installed/read-only or not is now stored on the RulesAssembly instance, allowing multiple things to be configured separately and stacked together (eg. engine/enterprise/project). RulesAssembly.IsReadOnly() allows determining if a flie can be modified or not and replaces many previous IsXXXInstalledCalls(), and traverses the chain of assemblies. Change 4234711 by Ben.Marsh UBT: Runtime dependencies can now be copied to output directories as part of the build. When adding a runtime dependency, an optional source location can be specified to copy from. Both the source and target paths can use variables can be used as part of the path, eg. $(OutputDir), $(ModuleDir), $(PluginDir). Example usage (from a .build.cs file): RuntimeDependencies.Add("$(OutputDir)/Foo.dll", "$(PluginDir)/Source/ThirdParty/Foo.dll", StagedFileType.NonUFS); Change 4234872 by Ben.Marsh Expose a flag for whether the engine is installed, to fix issues generating project files. Change 4234929 by Ben.Marsh Fix null reference generating receipts when UBT makefiles are active. Change 4235883 by Chad.Garyet Merging 4231245 to core Giving Coordinator its own sln. This should fix what 4158155 was supposed to. #jira UE-61955 Change 4236075 by Ben.Marsh CIS fix Change 4237066 by Robert.Manuszewski Fix for a potential crash when terminating the engine while it's being initialized #jira UE-60545 Change 4237078 by Robert.Manuszewski The engine will no longer be resetting all linkers causing massive load times when renaming the world package when entering Play In Editor Change 4237116 by Ben.Marsh Rewrite some Windows utility functions to support paths longer than MAX_PATH. Change 4237158 by Ben.Marsh Add const TCHAR* overloads of FString::RemoveFromStart() and FString::RemoveFromEnd(). Change 4237159 by Ben.Marsh Fix FWindowsPlatformFile::GetFilenameOnDisk() support for paths longer than MAX_PATH, and simplify some of the other long path functions to avoid copying string buffers. Change 4239050 by Ben.Marsh Missing file Change 4239318 by Ben.Marsh Linux CIS fix. Change 4239685 by Ben.Marsh Static analysis CIS fix. Change 4240800 by Ben.Marsh WorkspaceTool: Include the full command line in the log for any P4 commands. Change 4240903 by Ben.Marsh PR #4909: Update copyright notices to 2018 (Contributed by projectgheist) Change 4241025 by Ben.Marsh UBT: Exclude mobile pipeline caches from generated project files. Causes huge slowdown when using 'Find in Files' through the IDE. Change 4241770 by Ben.Marsh UBT: Include action number in parallel executor output. #jira UE-62032 Change 4243469 by Ben.Marsh TBA: Merge FAnnotatedStructuredArchiveFormatter with FStructuredArchiveFormatter. Any functions that are only implemented for text archives now have a _TextOnly suffix, and are exposed through the FStructuredArchive interface. Change 4245723 by Robert.Manuszewski Fixing another creash when terminating the engine while initializing. #jira UE-60545 Change 4245862 by Steve.Robb VectorLoadFloat2(Ptr) added, which loads { Ptr[0], Ptr[1], Ptr[0], Ptr[1] } into a VectorRegister. Change 4246412 by Robert.Manuszewski The warning 'Calling StaticLoadObject during PostLoad may result in hitches during streaming' will now also report the object which had the PostLoad called on it when StaticLoadObject call happened. Change 4246612 by Ben.Marsh UBT: Fix spelling of "Intellisense". Change 4249454 by Robert.Manuszewski Added extra checks to catch scenarios where the EDL Precache Buffer is flushed before a package header is fully read Change 4249513 by Robert.Manuszewski Made sure the Async Loading Thread doesn't continue running after creating new async packages when garbage collector wants to run on the game thread Change 4255207 by Ben.Marsh UGS: Add additional logging whenever a P4 command fails, and when the user is logged out. Change 4255288 by Ben.Marsh PR #4921: Honor ModuleRules' bEnableExceptions flag when creating precompiled h. (Contributed by surakin) Change 4256422 by Ben.Marsh UBT: Add an error if a module referenced by a plugin descriptor doesn't exist. Change 4257385 by Robert.Manuszewski Creating new objects from within ForEachObjectWithOuter will now result in a fatal error as it's unsafe to change internal UObject hash tables when iterating over them. Change 4257454 by Robert.Manuszewski Added the option to filter clusters listed with gc.ListClusters by objects within them. Usage: gc.ListClusters Hierachy With=ObjectName1,ObjectName2... Change 4257526 by Robert.Manuszewski It's now possible to filter clusters that get logged with verbose cluster logging enabled (UE_GCCLUSTER_VERBOSE_LOGGING=1) by objects within them by specifying -DumpClustersWithObjects=ObjectName1,ObjectName2 in the command line Change 4257822 by Ben.Marsh Fixes for PlatformShowcase compile errors. Change 4258771 by Ben.Marsh UBT: Fix project files not being generated for foreign projects when creating .stub files. #jira UE-62462 Change 4258790 by Ben.Marsh UBT: Clean up the logic around generating project files before creating a stub IPA, so that it fails loudly if project files do not exist, and can accept target names not matching project names. Change 4259276 by Ben.Marsh UBT: Make it an error if a framework doesn't exist, rather than failing silently. Also remove some remote toolchain stuff that's no longer necessary. Change 4259280 by Ben.Marsh UBT: Fix embedded framework zips not being uploaded for plugins. #jira UE-62485 Change 4260236 by Ben.Marsh UBT: Fix path to generated engine project file. Change 4260334 by Ben.Marsh UGS: Fix custom build steps dialog inadvertantly modifying config file settings in-place. Change 4260361 by Ben.Marsh UGS: Allow for p4 login commands to fail, even though the user is logged in (due to a bad connection, etc...) Change 4260559 by Ben.Marsh UGS: Update version. Change 4261160 by Robert.Manuszewski MediaPlaylist will now be added to root set if the owning MediaPlayer is in the disregard for GC set (fixes GC assumption violation crash) #jira UE-62495 Change 4261421 by Ben.Marsh Force-sync files for building documentation, to fix issues with files not being updated. #jira UE-62413 Change 4261425 by Ben.Marsh UBT: Remove some leftover functions for handling the remote toolchain. Change 4261530 by Ben.Marsh UBT: Speculative fix (and better error reporting) for IOS mobile provision not being found in CIS. Change 4261611 by Ben.Marsh UBT: Downgrade warning to a log message, since it appears when generating project files. Change 4261710 by Ben.Marsh Remove assert that GLogConsole is set; it won't be for command line utilities that don't depend on ApplicationCore. #jira UE-62545 Change 4261831 by Ben.Marsh Fix compile errors due to missing include path when hot-reloading a module from the editor. There are not necessarily source files to compile when -modulewithsuffix is specified on the command line, which was results in GeneratedCodeWildcard not being set. #jira UE-62463, UE-62384 Change 4262723 by Ben.Marsh Whitelist plugins that need to be loaded by UFE. #jira UE-62564 Change 4265444 by Ben.Marsh Fix incorrect executable name for DebugGame configurations in Xcode. #jira UE-62574 Change 4265892 by Ben.Marsh Fix incremental compile failures due to dependency checking for unity files. CachedIncludePaths was not correctly being set on file items, so dependencies were being ignored. #jira UE-62575, UE-62603, UE-62597 Change 4266019 by Josh.Adams - Fixed the CopyAction for runtime dependencies that need to be copied to different location, on non-XGE Change 4266264 by Ben.Marsh Remove override for the __IPHONE_OS_VERSION_MIN_REQUIRED macro on TVOS. This macro is already defined by system headers (in <AvailabilityInternal.h>). Now that we support PCHs on IOS and TVOS, manually defining this macro results in it being defined three times (once for the PCH, once by AvailabilityInternal.h, and once by the force-included list of definitions for the source file being built). The errors for redefining the macro in AvailabilityInternal.h are suppressed due to it being a system header, but the error for redefining it for the source file being compiled are not. #jira UE-62578 Change 4266273 by Ben.Marsh Fixes incremental build failure when compile arguments for PCH have changed on IOS/TVOS. Compile action needs to have a dependency on PCH build action. Change 4266614 by Graeme.Thornton Fix crash when cooking nativized blueprints due to removal of child cooker system. Change 4266763 by Ben.Marsh Always build UnrealPak when building client targets. The ProjectParams.Pak option is not reliable, because it can be forced on later by the target platform. #jira UE-62584 Change 4267985 by Robert.Manuszewski When iterating with ForEachObjectWithouter, don't lock the entire has table but only the hash bucket that is currently being iterated #jira UE-62600 Change 4268558 by Robert.Manuszewski PurgeLegacyBlueprints will no longer be called from within ForEachObjectWithOuter is it renames objects that reside in hash tables that are being iterated over which may lead to undefined behavior. #jira UE-62600 Change 4269011 by Chad.Garyet - Fixing Wildcard match issue, the change to ugsapi sends projects as //Depot/Stream instead of //Depot/Stream/ Wildcard match was only substringing to 3 chars. - Checking in the change a while back that increases the number of queried jobs up to 432 based on some maths from Bob about how many builds we want to grab Published to ugsapi server 8/8/17 #jira none Change 4270788 by Ben.Marsh Fix IOS provisioning data being using when remote compiling on TVOS. #jira UE-62705 Change 4271916 by Ben.Marsh Tag the XGEControlWorker executable as a build product after compiling SCW, to make sure it's included in the UGS zip file. Change 4271934 by Ben.Marsh Upload all static libraries in plugin folders as part of remote builds. #jira UE-62694 Change 4273368 by Ben.Marsh Fix Slate dependencies not being enumerated, and rules assembly not being rebuilt when building remotely. #jira UE-62705 Change 4274049 by Ben.Marsh Always parse the team UUID out of the mobile provision when doing a remote compile. The provision installed on the remote Mac (and selected for signing) may be different. #jira UE-62751 Change 4274823 by Ben.Marsh Add the -VersionCookedContent argument to disable the -unversioned parameter on the cooker command line. Change 4275838 by Ben.Marsh Fix BuildVersion string not being passed through from <SetVersion> task. Also add a -BuildVersion command line argument to UBT to override it for a particular build. Change 4275913 by Ben.Marsh Add a dummy exported symbol to the XGEController module, to fix build errors due to missing .lib file when it's built with WITH_XGE_CONTROLLER = 0. Change 4284161 by Ben.Marsh Allow mirroring Oodle files to remote Mac. Change 4074774 by Steve.Robb Vast simplification of TFunction, making it smaller in footprint, easier to follow and extend, and more correct. TUniqueFunction added, which is a move-only TFunction which can hold move-only functors. Fix for UWidgetBlueprint::ForEachSourceWidget() which should never have compiled but did. FFunctionGraphTask and TFuture<> updated to use TUniqueFunction to make them more general. TArray::HeapPop() made to work with move-only types. Change 4082591 by Ben.Marsh Move the Log class from UBT to DotNetUtilities. Change 4083236 by Ben.Marsh Add a Log.WriteException() method to dump an exception message to the console (and write the exception trace to the log) Change 4084107 by Ben.Marsh UAT: Remove the unused -SkipHeader argument to UE4Build. Change 4089771 by Steve.Robb GitHub #4743 : modified VirtualAlloc function flag https://blogs.msdn.microsoft.com/oldnewthing/20151008-00/?p=91411 Change 4091456 by Steve.Robb Unification of all platforms' FMath::CountTrailingZeros() and FMath::CountLeadingZeros() for both 32-bit and 64-bit. Change 4156437 by Ben.Marsh Lots and lots of fixes compiling for Clang on Windows. Editor now compiles cleanly without warnings, but crashes on startup due to error in intrinsics test. Disabling that runs further, but crashes accessing freed memory. Switching to the ANSI allocator runs further, but crashes in Slate after the splash screen and before the editor window opens. // TODO! * Switching between Clang/ICL/VS2015/VS2017 is now supported through the same mechanism as switching Visual Studio versions, without requiring any source level changes. To use Clang, set WindowsPlatform.Compiler = WindowsCompiler.Clang from a .target.cs file, or set <WindowsPlatform><Compiler>Clang</Compiler></WindowsPlatform> from BuildConfiguration.xml. To pick a specific toolchain version, set WindowsPlatform.CompilerVersion. * Clang is now supported through AutoSDKs; will be added to CIS. * The Samples/Sandbox/Clang project forces Clang to be used from its target.cs file, and allows easily building all editor modules and plugins with Clang on Windows. * UnrealMathSSE intrinsics have been re-enabled for Clang due to missing functions from the UnrealMathFPU implementation, but causes failure in tests at startup. * SSE4_CRC32() is disabled in D3D12Pipelinestate.cpp, since intrinsics are only allowed if enabled for the whole target (rather than being used in specific functions due to runtime checks) Change 4157389 by Ben.Marsh Few more fixes for compiling the editor with Clang. Change 4183911 by Ben.Marsh Fixes to support incremental linking on Windows. Does not seem to have any net benefit right now; may improve once minimal rebuild is enabled. * Incremental linking no longer forces PDB files to be enabled for source files. * Actions can specify specific files to be deleted before each build. Code to forcibly delete PDB files has been moved to the MSVC toolchain. * Unused libraries produced by the cross-referenced link are no longer added as build products, since (a) deleting them breaks dependency checking for incremental linking and causes a full link, and (b) not deleting them breaks UBT dependency checking and causes actions to be run over and over again. * Icon update is disabled for Windows when incremental linking is enabled. * Removed rarely-used setting to always delete produced items before each build. Change 4184311 by Ben.Marsh UGS: Added a dialog which shows all the required platform SDKs for a branch, linked from the status panel in UGS. The llist is configured via the UGS config file submitted to Engine/Programs/UnrealGameSync/UnrealGameSync.ini (and may be overridden by the project config file if necessary): [Default] ; Set this to a network share which contains the SDK installers for your site SdkInstallerDir= ; All the required SDKs for the current version of the engine +SdkInfo=(Category="Android", Description="NDK r21", Browse="$(SdkInstallerDir)\\Android") +SdkInfo=(Category="Windows", Description="Visual Studio 2017") +SdkInfo=(Category="Windows", Description="Visual C++ Toolchain 14.13.26128") +SdkInfo=(Category="Windows", Description="Windows SDK 10.0.16299.0") Similar entries for console platforms are added in console subdirectories. Each entry may contain an Install="Foo.exe" and/or Browse="C:\Foo" style attribute, specifying the path to an installer to run or directory to open in explorer respectively. The SdkInstallerDir setting is used as a base directory for the default installers, seen above for Android. Licensees may override this with a network path specific to the site that UGS is being deployed to (either in this file, in a project specific config file, or in a Engine/Programs/UnrealGameSync/NotForLicensees/UnrealGameSync.ini file). Change 4200452 by Ben.Marsh UBT: Change DebugGame configurations to output a separate executable rather than requiring a -Debug argument at runtime. Previous behavior was a common source of errors. Engine modules are still shared between Development and DebugGame, but the launch module sets a flag in Core on startup indicating the game configuration. Change 4206189 by Ben.Marsh UBT: Simplify logic for precompiling binaries. * Target no longer has separate list of "precompile only" binaries or modules. New -AllModules option allows adding every module to a target, which can be used with -Precompile and -NoLink to precompile object files for monolithic builds. * Precompiled file lists have been removed from target receipts. * The manifest now includes all generated headers and precompiled files when run with the -Precompile option. * Separate -DependencyList=Foo.txt has been added to write a list of all dependencies required to use precompiled binaries. This file list can be read using the <Tag> task in buildgraph. Change 4215466 by Ben.Marsh UBT: Remove indirect calls to determine extensions for object files and precompiled headers. The toolchain knows the correct convention for the platform. Change 4215975 by Ben.Marsh UBT: Remove telemetry code. This has never proved useful for analyzing performance due to the number of incidental factors that affect build times (eg. number of files being compiled). Change 4220154 by Ben.Marsh Move text-only implementations of FOutputDeviceError back into Core, so we can build command-line applications that don't depend on ApplicationCore. Change 4224708 by Ben.Marsh Add a bCompileAgainstApplicationCore setting to the target rules, which allows compiling out references to the ApplicationCore module (which should only be necessary for applications with a GUI). Removed ApplicationCore from several engine tools and utilities. Change 4224958 by Ben.Marsh Remove CoreMinimal.h includes from Core. Change 4229059 by Ben.Marsh UBT: Remove the UEBuildPlatform.ShouldNotBuildEditor() hook for target platforms. We shouldn't be modifying a target's build environment to disable the editor; it is invalid to build the editor for these target platforms at all, and this is already enforced by the GetSupportedPlatforms() function. Change 4230508 by Ben.Marsh Fixup precompiled header setting for samples and games. Change 4231457 by Ben.Marsh Fix exceptions in log messages having trailing newlines. Change 4232406 by Ben.Marsh UBT: Always force include a PCH for generated code if there's one set; the code may depend on it to compile. Change 4234177 by Ben.Marsh Set up private PCH files everywhere that previously used them. Change 4235973 by Ben.Marsh Change FPlatformMisc::GetEnvironmentVariable() to return an FString() rather than requiring a fixed size buffer to be passed in. Removes references to MAX_PATH. Change 4238842 by Ben.Marsh Add support for paths longer than MAX_PATH in the editor. Requires Windows 10 version 1607, and the functionality to be enabled via a registry key or group policy (see https://docs.microsoft.com/en-us/windows/desktop/FileIO/naming-a-file). Only a subset of Win32 functions support long paths (executables can only be started from paths shorter than MAX_PATH, for example). * Added a FPlatformMisc::GetMaxPathLength() function to return the maximum length of a path on the current system. On Windows, this returns a different value for systems with long paths enabled to those without. * The MAX_PATH define is no longer set by non-Windows platforms. Instead, there is a MAC_MAX_PATH, UNIX_MAX_PATH, etc... for any platform-specific code that still relies on the previous macro. * The MAX_UNREAL_FILENAME_LENGTH macro has been renamed to MAX_UNREAL_FILENAME_LENGTH_DEPRECATED * The PLATFORM_MAX_FILEPATH_LENGTH macro has been renamed to PLATFORM_MAX_FILEPATH_LENGTH_DEPRECATED. * Removed custom resource files for programs, since they are just copies of the base UE4 one (which is used by default anyway). The base UE4 manifest declares support for long paths. * Fix 512 character maximum length on editor commands. 260 character limit remains in place for cooking at the moment (see ContentBrowserUtils.h), until C# staging code supports long paths. Change 4255042 by Ben.Marsh UBT: Remote compilation now uploads the entire workspace to the remote Mac and executes a separate remote instance of UBT rather than synchronizing individual actions. This makes the remote compile codepath much simpler, and removes a lot of special cases that exist to support it previously. The list of files to be transferred to the remote are listed as rsync filter rules in Engine/Build/Rsync/RsyncEngine.txt and RsyncProject.txt, which are applied to the root engine directory and project directory respectively. Projects that need to customize which files are uploaded can add their own <ProjectDir>/Build/Rsync/RsyncProject.txt file, which will be included in the filter before the default version. Change 4260567 by Ben.Marsh UAT: Rename CommandUtils.Log to CommandUtils.LogInformation, to avoid conflicts with the underlying Tools.DotNETCommon.Log class. #rb none [CL 4285673 by Ben Marsh in Main branch]
2018-08-14 18:32:34 -04:00
LogInformation(Output);
}
return true;
});
}
#endregion
#region Servers
Copying //UE4/Dev-Platform to //UE4/Dev-Main (Source: //UE4/Dev-Platform @ 3120366) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 2714591 on 2015/10/02 by Ben.Marsh Initial branch of files from Engine-Main (//UE4/Engine-Main) to Dev-Platform (//UE4/Dev-Platform) Change 2916715 on 2016/03/21 by Daniel.Lamb First pass at splitting out build cook run into into seperate scripts. Change 2948322 on 2016/04/19 by Nick.Shin update libwebsockets to v1.7.4 part 4 of 4 - doing this in stages for tracking purposes #jira UEPLAT-1246 - Update libWebsockets #jira UEPLAT-1221 - update websocket library #jira UEPLAT-1204 - Rebuild libwebsockets with SSL Change 2970016 on 2016/05/07 by Nick.Shin undo all of the following upgrades: - zlib - openssl - libcurl - libwebsockets and reset webrtc #jira UE-30298 - Fortnite and Orion crash on login Change 3059693 on 2016/07/21 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3061151 on 2016/07/22 by Niklas.Smedberg Fast ASTC texture compression, using ISPC. #jira UE-32308 Change 3061428 on 2016/07/22 by Peter.Sauerbrei Back out changelist 3061151 as it wasn't approved for submission Change 3061970 on 2016/07/22 by Steve.Cano Adding AdMob interstitital ad support for Android, including Blueprint functions #jira UE-33286 #ue4 #android Change 3062160 on 2016/07/22 by Mark.Satterthwaite Fix the fix for handling RHISetStreamSource overriding stride on Metal - not all MTLVertexDescriptors are equally hashable so do this ourselves. #jira UE-33355 Change 3062770 on 2016/07/24 by Brent.Pease UE-32397 Error Message displays as Unknown Error when failing to supply a Remote Build server for ios on Windows Change 3063227 on 2016/07/25 by Dmitry.Rekman Update hlslcc cross-compile after libc++ change. Change 3063314 on 2016/07/25 by Jeff.Campeau Xbox One DLL loading Receipts can be read back by request for target info Change 3063329 on 2016/07/25 by Mark.Satterthwaite CL #3046743 was breaking other samples in unexpected ways after a recent Main merge, so make a Metal-specific change to the shader instead and amend the MetalBackend to better match HLSL's handling of NaN/inf with common single-precision float intrinsics. This is sufficient to fix the AtmosphericFog and the recent regressions. #jira UE-33600 #jira UE-33028 #jira UE-27879 #jira UE-25802 Change 3063492 on 2016/07/25 by Brent.Pease UE-23846 - iOS Movie Player can't handle videos at resolutions that aren't multiples of 16 UE-33200 - A movie isn't played on iOS occasionally. Change 3063729 on 2016/07/25 by Dmitry.Rekman Linux: enable XGE on all platforms. #tests Cross-compiled a number of Linux targets on Windows. Change 3063732 on 2016/07/25 by Dmitry.Rekman Fixed formatting (spaces->tabs) in previous change. Change 3063750 on 2016/07/25 by Daniel.Lamb Added code to dump the cook modification delegate loads to log. Fixed the memory usage output log. #test cook paragon. Change 3063804 on 2016/07/25 by Daniel.Lamb Added cookpartialgc additional commandline option to uat. #test UFE Change 3064008 on 2016/07/25 by Mark.Satterthwaite For non-shipping builds conditionally bind a default uniform buffer in Metal and report an error if the slot was unbound, if our validation layer is enabled attempt to report the shader source in question. This relies on the shader compiler providing accurate information about uniform buffer bindings and won't fix all occurances of bad uniform usage (if a buffer is bound but too short the result will be GPU restarts or an error in Apple's validation layer - we can't detect this case) but will help debug the typical error of leaving an active slot unbound. #jira FORT-27685 Change 3064141 on 2016/07/25 by Jeff.Campeau Rebuild vpxmd.lib with delayed codegen disabled (fixes linker warning building Win64). Change 3065024 on 2016/07/26 by Nick.Shin Change filetype remove exclusive check out bit requested by or.coheni & nick.penwarden Change 3065274 on 2016/07/26 by Jonathan.Fitzpatrick DirectoriesToAlwaysStageAsUFS now properly filters out *.uasset and *.umap files This prevents the bug where cooked assets get trampled by staging their uncooked version on top of them during the UFS step Added a file filter to DirectoriesToAlwaysStageAsUFS for uasset and umap. Change 3066338 on 2016/07/27 by Mark.Satterthwaite Handle releasing an SRV/UAV & the source object within a single Metal command-buffer. #jira UE-33779 Change 3066789 on 2016/07/27 by Daniel.Lamb Realtime mode does not save any packages anymore unless they are ready. #test cookontheside, cookbythebook shooter game Change 3066847 on 2016/07/27 by Jeff.Campeau Fix define #2634 #jira UE-33813 Change 3068868 on 2016/07/28 by Mark.Satterthwaite Extend hlslcc's handling of switch-statements to allow implict casts from scalar bool, half & float as HLSL itself permits while also making sure it errors if the expression input is not scalar. This fixes shader compile errors in UT. Change 3070040 on 2016/07/29 by Dmitry.Rekman Delete Nadzorca. Change 3070947 on 2016/07/29 by Jeff.Campeau Perforce C++ API 2015.2 (includes debug libraries) Change 3073707 on 2016/08/02 by Daniel.Lamb Derived data cache commandlet runs resolve string asset references to load any string asset refereced packages from the map. Also process async results from shaders being compiled so they can have their memory resources released. #test DerivedDataCache commandlet shootergame. Change 3076613 on 2016/08/03 by Brent.Pease + UnrealTargetConfiguration is now passed into deploy and package methods + The UIRequiredDeviceCapabilities plist key now only considers the architectures from the corresponding target configuration (shipping or development) Change 3076668 on 2016/08/03 by Brent.Pease Back out changelist 3076613 Change 3077157 on 2016/08/04 by Daniel.Lamb Fixed up DLC staging so that it stages to the proper mount point. Fixes up include engine content in DLC staging paths. #test Made up shooter game DLC Change 3077191 on 2016/08/04 by Daniel.Lamb More smartly process async shader compilation if we are waiting for it. #test cook on the side shooter game cook by the book shooter game. Change 3077412 on 2016/08/04 by Mark.Satterthwaite Fix "iOS Metal-based build crashes at launch with sub-levels": - Slate should not bind the null RHI texture from an unitialised texture atlas - atlases only have a valid texture pointer once an entry has been added to them and in the template projects an empty sub-level doesn't add anything. - To prevent this kind of bug resurfacing and being so hard to track down add Metal shader binding validation to our validation layer as Apple's is incomplete on iOS and won't warn us about nil texture usage which causes these GPU restarts. This requires reworking our vertex declaration handling to be more efficient so that we can cache the pipeline reflection data as well as the pipeline objects. - Fix validation error of texture reallocation on loading template projects under Metal. #jira UE-30847 Change 3077958 on 2016/08/04 by Brent.Pease + UnrealTargetConfiguration is now passed into deploy and package methods + The UIRequiredDeviceCapabilities plist key now only considers the architectures from the corresponding target configuration (shipping or development) Change 3079503 on 2016/08/05 by Mark.Satterthwaite Initialise more variable types to 0 in Metal shaders to workaround Xcode 8 toolchain no longer doing this for us for "threadgroup shared" variables. Everything but structs and atomic's will now be initialised. #jira UE-33856 Change 3079737 on 2016/08/05 by Jeff.Campeau Add support for delay load DLLs on Xbox One Turn off warnging for missing PDBs to match VCToolchain.cs Change 3081005 on 2016/08/08 by Mark.Satterthwaite Fix-up Metal device name on AMD for macOS 10.12 which reports it correctly and enable tiled reflections on Intel from macOS 10.12 too as they now work. Change 3081557 on 2016/08/08 by Daniel.Lamb File-> Package saves all packages before starting packaging. #test File package first person template Change 3082215 on 2016/08/09 by Lee.Clark PS4 - Added 4k profile Change 3082412 on 2016/08/09 by Daniel.Lamb Fixed cook on the fly server not handling cook requests. #test Cook on the fly shooter game. Change 3082955 on 2016/08/09 by Dmitry.Rekman Linux: convert existing Strcat() uses to Strncat(). - Strcat() does not check destination size so can silently corrupt memory. While this was not observed, this conversion removes this concern altogether. Change 3083772 on 2016/08/10 by Luke.Thatcher [PLATFORM] [PS4] [+] Checking in PS4CrashHandler files so we have a copy in Perforce rather than just on the server. - Taken from \\devweb-02 and removed all the unused files/dependencies. - Created a publish profile pointing to \\devweb-02\Sites\PS4Services\PS4CrashHandlerDev so I'm not writing over the existing deployed crash handler. - Moved all code in the Page_Load event to inside the check for the HTTP method (POST) otherwise GET'ing the page from a browser will generate crash folders that hang around forever. Change 3085450 on 2016/08/11 by Lee.Clark PS4 - Fix mediaplayer pipeline allocation Change 3086360 on 2016/08/11 by Michael.Trepka Fixed a non-unity build error in Mac UnrealFrontend Change 3087224 on 2016/08/12 by Luke.Thatcher [PLATFORM] [PS4] [~] Refactor PS4 Crash Handler site - Removed CoreDumpHandler. Processing dump files is handled directly by an async thread within the aspx process. - Separated configuration values into their own class. Currently set to output to a testing directory, rather than the actual crash reporter landing zone. - Added a debug upload page to allow manual submission of .orbisdmp/.txt settings files, accessible by GET'ing Default.aspx. - Added logging. Logs self-delete after 30 days. Testing required before we switch to the new system. #jira UE-34504 #jira OR-26886 Change 3087626 on 2016/08/12 by Dmitry.Rekman PR #2689: Fix copying/duplicating failing on Linux (UE-34586). - Contributed by Web-eWorks. Change 3087991 on 2016/08/12 by Mark.Satterthwaite Initial AVFoundation implementation of Media Framework for Mac, iOS & tvOS. - Video playback occurs via AVPlayerItemVideoOutput's attached to the AVPlayerItem's output. This means gathering video samples is trivial. - Metal texture updates occur by wrapping the texture object provided by AVF - for Mac this is simple as it can bind to the IOSurface directly, for iOS/tvOS we have to create a CVMetalTextureCache and allocate our texture from there. - OpenGL and OpenGLES currently have to lock the pixel buffer and upload to a texture the old fashioned way - this should be revisited when there is time. - Subtitles/Captions are captured using AVPlayerItemLegibleOutput which also connects to the AVPlayerItem's output. - On Mac audio samples are returned by manually reading from the stream using an AVAssetReaderTrackOutput, including manual seeking and synching. - On iOS/tvOS the audio is played directly by AVPlayer because the IOSAudio system can't handle procedural buffers - otherwise it could reuse the Mac code. - AVFoundation does not support AVI - that's an obsolete Microsoft/Windows file-format. - Only 'file://' URLs are supported - streaming would require a totally different audio solution (using MTAudioProcessingTap) and has many more edge and failure cases that would need to be handled. #jira UE-34315 Change 3088790 on 2016/08/15 by Luke.Thatcher [PLATFORM] [PS4] [~] Hook new PS4 crash handler up to the crash reporter website. - Removed indentation from generated crash context XML file. The crash reporter process does manual XML parsing which doesn't correctly handle whitespace at the start of lines. - Switched the final output folder to match the one the crash reporter process is watching. - Hide upload form on a config variable. #jira UE-34504 #jira OR-26886 Change 3089060 on 2016/08/15 by Luke.Thatcher [PLATFORM] [PS4] [!] Change PS4 crash handler log file extension to ".ps4chlog", otherwise the crash reporter site attaches the wrong log file to the crash report. Allowed showing of debug upload form via "Default.aspx?showform=1" query string. #jira UE-34504 #jira OR-26886 Change 3089089 on 2016/08/15 by Mark.Satterthwaite Duplicated changes to AppleMovieStreamer from CL #3088149. #jira UE-34315 Change 3089460 on 2016/08/15 by Mark.Satterthwaite Duplicate CL #3080971: Workaround a macOS 10.12 Beta bug on some Metal drivers that can't initialise temporary/local variable arrays, only those that are marked threadgroup shared. #jira UE-34355 Change 3089465 on 2016/08/15 by Mark.Satterthwaite For Metal shader translation retain more precision for float constants -1.0f >< 1.0f by emitting them in scientific notation - prevents Hammersley constant amongst others from being flushed to 0. Change 3089902 on 2016/08/15 by Daniel.Lamb Changed the next compiling ID to the correct compiling ID. #test Cook Change 3089903 on 2016/08/15 by Daniel.Lamb Cooker monitors config useage during cook and uses those settings to invalidate cooked content instead of all config settings. Change 3090114 on 2016/08/16 by Luke.Thatcher [PLATFORM] [PS4] [~] Minor change to PS4 settings text on crash handler site. Change 3090949 on 2016/08/16 by Nick.Shin WebSocketNetDriver crash fix filled in missing chunk of code that calls PacketHandler's "packet modifiers" #jira UE-25492 HTML5 Client cannot connect to Windows Server #jira UE-30880 WinServer crashes when NetDriver is set to WebSocket and Client attempts to connect via websocket #code.review john.pollard john.barrett Change 3091265 on 2016/08/16 by Brent.Pease Add IOS support to HarfBuzz Change 3091267 on 2016/08/16 by Brent.Pease Add references to fix mono build Change 3091291 on 2016/08/16 by Nick.Shin CIS warning fix #jira UE-25492 HTML5 Client cannot connect to Windows Server #jira UE-30880 WinServer crashes when NetDriver is set to WebSocket and Client attempts to connect via websocket Change 3091781 on 2016/08/17 by Joe.Barnes UE-33640: Exposed UPrimitiveComponent::IsAnyRigidBodyAwake() to Blueprints. Change 3092687 on 2016/08/17 by Daniel.Lamb Added support for using binned allocator in cooker instead of tbb. #test Cook shootergame. Change 3093867 on 2016/08/18 by Mark.Satterthwaite Use a read/write mutex to protect access to Metal's internal shader pipeline caches so that parallel threads can progress in the common case where new shaders are not being compiled. Change 3093950 on 2016/08/18 by Mark.Satterthwaite Change the Mac GPU identification code to cope with AMD's new naming scheme on 10.12. Change 3093951 on 2016/08/18 by Mark.Satterthwaite More SCW threads on Mac - they work now. Change 3093960 on 2016/08/18 by Mark.Satterthwaite Increase the default number of command-buffers on Mac because bigger games overflow the current limit of 64 per queue. Change 3096493 on 2016/08/22 by Jeff.Campeau Use Xbox version of DirectX include. Change 3097509 on 2016/08/23 by Luke.Thatcher [PLATFORM] [PS4] [+] Refactor PS4 Symbol Publish - Moved the SymStore task from Win.Automation to BuildGraph.Automation, and made it more generic. - The specifics of uploading symbols are now implemented in the platform tool chain, alongside StripSymbols(). - Re-generated the build graph schema file. - Removed the old PS4 symbols upload path in the package step. Modified OrionBuild.xml to publish symbols for all PS4 dev, test and shipping config builds of OrionClient. Change 3097635 on 2016/08/23 by Luke.Thatcher [PLATFORM] [PS4] [+] Refactor Age Symbols task in UAT. - Moved the AgeStore task from Win.Automation to BuildGraph.Automation and made it more generic. - Symbol server directory structure is now defined by the platform tool chain, which the common task uses to clean out old symbols. - Added a "filter" parameter to prevent age tasks deleting symbols from unrelated builds in shared symbol servers. Modified OrionBuild.xml to age both the Windows and PS4 symbol stores. Change 3097713 on 2016/08/23 by Luke.Thatcher [PLATFORM] [PS4] [+] Enable new PS4 crash handler server - Created live deployment profile and applied the required config file changes. Change 3099214 on 2016/08/24 by Luke.Thatcher [PLATFORM] [PS4] [!] Fix compile error in PS4 tool chain. For some reason, this only breaks ocassionally. Maybe we're alternating between the 2013 and 2015 C# compilers depending on what initiates the build (e.g. Visual Studio vs GenerateProjectFiles)? Change 3099222 on 2016/08/24 by Luke.Thatcher [PLATFORM] [PS4] [+] Added PS4 support for FPlatformMisc::MessageBoxExt using the MsgDialog library. - Note, only one and two button message dialogs are supported (limitation of MsgDialog). Change 3099260 on 2016/08/24 by Luke.Thatcher [PLATFORM] [PS4] [~] Better PS4 exit function. Calls quick_exit instead of abort when we've not asserted. Allows for a "cleaner" forced exit without generating a crash dump. Change 3101192 on 2016/08/25 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3101944 on 2016/08/25 by Daniel.Lamb Ask to save the current level when we are using launch on. Change 3102036 on 2016/08/25 by Nick.Shin check for minimum expected size upon data received from network #jira UE-13657 - HTML5 plugin OnRawRecieve overflow Change 3102115 on 2016/08/25 by Brent.Pease - Fix small errors that probably only show up in the mac mono build #code.review peter.sauerbrei Change 3102747 on 2016/08/26 by Jeremiah.Waldron Re-submitting OnlineSubsystemGameCircle with TPS permission for Amazon SDK - Also fixed the plugin to remove any related files from the final package when IAP is disabled or GameCircle support itself is disabled with the plugin still enabled - Added support for new AlreadyOwned IAP response code as well which is already used for GooglePlay and IOS Change 3102900 on 2016/08/26 by Nick.Shin since last checkin (CL: 2981945) - prints are crashing the browser - this change will allow browser to print the details via console.log() #jira UE-26047 - HTML5 HTTP Response Headers not implemented Change 3103130 on 2016/08/26 by Brent.Pease UE-24679 - Enable the ability to change ports for a firewall to pass them through rsync Change 3103225 on 2016/08/26 by Daniel.Lamb Fixed issue with warning which would cause crash. Change 3103425 on 2016/08/26 by Dmitry.Rekman Enable offscreen GL rendering without X. - Added new video subsystem to SDL that is uses EGL to initialize the context. - Most windoing functions stubbed. - Also added a new test case to TestPAL for easier debugging. Change 3104743 on 2016/08/29 by Brent.Pease Support remote offline metal shader compilation Change 3105051 on 2016/08/29 by Brent.Pease UE-2382 - TASK: MobleMVP: iOS: Add ability to view iOS device console output in the editor UFE - IOS Automation will now create a thread to collect the console logs from the device and send them to C# Console output while the app is running on device - Made ProcessResult an interface (IProcessResult) which ProcessResult implements. This allows platforms to provide their own implementation if needed. - Moved the RunLoop related parts of CoreFoundation into MobileDevice.cs Change 3105053 on 2016/08/29 by Brent.Pease - IOS dll's as part of the last check-in Change 3106853 on 2016/08/30 by Jeff.Campeau Implement FD3D11DynamicRHI::RHICreateComputeFence to prevent memory overwrite Change 3107361 on 2016/08/30 by Dmitry.Rekman Renderer: changes to allow postproc delegates. Change 3107362 on 2016/08/30 by Dmitry.Rekman Plugin with a CUDA postproc example. - Linux version only. Runs under a headless GL too (without X). - Disabled during cross-compilation, can be compiled natively only. - CUDA kernel should be compiled separately, CMakefile with compilation attached (can be used to generate VStudio projects as well). - To test the output, run under the debugger, interrupt and set global variable GSaveTheOutput to 50 (this will write out kernel output buffer 50 times as .bmp files into working directory). Change 3107913 on 2016/08/31 by Daniel.Lamb Fixed loading of cooked content in the editor. Change 3107916 on 2016/08/31 by Daniel.Lamb Added error case when shader compilation fails to notify shader. #test Cook shooter game. Change 3108080 on 2016/08/31 by Josh.Adams - Fixed PS4Automation compile errors Change 3109077 on 2016/08/31 by Brent.Pease Fix C# debug builds by specifying x64 and add reference to MobileDeviceInterface Change 3110086 on 2016/09/01 by Dmitry.Rekman Fix race condition in PThread runnable (UE-35074). - Instead of relying on busy-wait, join the threads. This prevents race between PostRun() (executed in the context of the thread) and FPThreadRunnableThread() destructor (see UE-34909). - Do not use an invalid value for pthread_t, since there's none. Change 3110172 on 2016/09/01 by Dmitry.Rekman Fixed a crash exiting VR Preview on Windows GL4 (UE-28708). - PR #2188 submitted by ardneran. Change 3110313 on 2016/09/01 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3111134 on 2016/09/01 by Dmitry.Rekman UBT: prevent mono from hanging on Ctrl-C. - Sometimes Ctrl-C can cause thread creation to fail. Without this change, UBT would lock up. Change 3111171 on 2016/09/01 by Brent.Pease Move all C# projects to use the x64 Platform for consistency with other changes made to move to the x64 Platform Change 3111177 on 2016/09/01 by Dmitry.Rekman Fix Linux build on systems without CUDA (UE-35460). Change 3111548 on 2016/09/02 by Luke.Thatcher [PLATFORM] [PS4] [!] Fix for PS4 iterative deployment. - Changes in Dev-Mobile broke the deployment manifests, as PS4 was now using the wrong filename when creating delta and obsolete file lists. Change 3111863 on 2016/09/02 by Dmitry.Rekman Better fix for build without CUDA (UE-35460). Change 3112738 on 2016/09/02 by Mark.Satterthwaite Fix the pausing particles on Metal - one line bug in the Metal query implementation meant that the first query wouldn't return the correct result for no good reason. #jira UE-34989 Change 3114579 on 2016/09/06 by Chris.Babcock Fix Vulkan include path in NDK check (contributed by geediiiiky) #jira UE-35490 #github #2758 #ue4 #android Change 3115115 on 2016/09/06 by Jeff.Campeau Calculate buffer size for paks using the bitwindow override as needed Change 3115600 on 2016/09/07 by Luke.Thatcher [PLATFORM] [PS4] [~] Make the crash dump handler registration much earlier, to catch crashes in early engine init. - Fixed up places in FGenericCrashContext::SerializeContentToBuffer which used the command line. If we crash early, the command line may not have been initialized yet. - Added a GetNoInit function to FThreadHeartBeat to avoid creating the heart beat thread if we crash early, and the thread doesn't exist yet. Tested by calling abort() immediately inside int main(), and we get a valid crash dump that the crash handler service can consume. Change 3115676 on 2016/09/07 by Luke.Thatcher [PLATFORM] [~] Dev-Platform integration fix for original CL 3064888 in //Orion/Release-29.1 Add .exe and .dll to windows symbol upload file filters. Change 3115811 on 2016/09/07 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3115944 on 2016/09/07 by Michael.Trepka Implemented IsGamepadAttached() for Mac Change 3115948 on 2016/09/07 by Michael.Trepka Don't try to restore Help menu item on Mac if MenuBlock does not contain it Change 3116200 on 2016/09/07 by Jeff.Campeau Fix parameter ordering Change 3117660 on 2016/09/08 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3117728 on 2016/09/08 by Michael.Trepka Copy of CL 3117698 by Mike.Fricker Fixed regression with editor's Simulate mode where cursor would teleport back to the center of the viewport after every click - This bug was introduced in CL 3075932 from a borderless window cursor handling fix that was needed for games that capture the cursor Change 3117797 on 2016/09/08 by Peter.Sauerbrei Shader Resource compression Change 3117988 on 2016/09/08 by Brent.Pease - Solutiion generator will now pick x64 instead of AnyCPU for the default platform configuration - Fix what I think was a merge error in BuildGraph.cs Change 3118296 on 2016/09/08 by Daniel.Lamb Fixed crash with launch on. Couldnt' correctly detect previous generated ini settings. #test launch on QA game #jira UE-35741 Change 3118438 on 2016/09/08 by JohnHenry.Carawon Fix UAT compilation on Linux #UE-35745 Change 3118934 on 2016/09/08 by Jeff.Campeau Shader compression setting based on target platform instead of cooking host platform. #jira UE-35753 Change 3120190 on 2016/09/09 by Ben.Marsh Add missing Platform attribute to build script for Dev-Platform. [CL 3120378 by Josh Adams in Main branch]
2016-09-09 20:13:41 -04:00
private static IProcessResult RunDedicatedServer(ProjectParams Params, string ServerLogFile, string AdditionalCommandLine)
{
ProjectParams ServerParams = new ProjectParams(Params);
Copying //UE4/Dev-Mobile to //UE4/Dev-Main (Source: //UE4/Dev-Mobile @ 3056055) #lockdown Nick.Penwarden #rb None ========================== MAJOR FEATURES + CHANGES ========================== Change 3011102 on 2016/06/13 by Steve.Cano After taking a screenshot using glReadPixels, transfer the data to the target buffer from bottom row up to fix the "upside-down" render that OpenGL does. Confirmed with QA (owen.stupka_volt) that this does not appear to be happening on iOS (non-metal devices, inclusion of iOS in write-up was a mistake), verified on an ipod touch 5. Also confirmed that this does not happen on html5, and that Mobile HDR flag does not make a difference in function. #jira UE-26421 #ue4 #android Change 3015801 on 2016/06/16 by Dmitriy.Dyomin Probbably fix for UE-30878, was not able to repro an actual crash(FFoliageInstanceBaseCache::AddInstanceBaseId). Added even more logging in case fix does not work. #jira UE-30878 Change 3015903 on 2016/06/16 by Dmitriy.Dyomin Fixed: Levels window has Refresh/UI issues when World Composition is active #jira UE-26160 Change 3018352 on 2016/06/17 by Chris.Babcock Handle Android media prepare failure (URL without internet for example) #jira UE-32029 #ue4 #android Change 3026387 on 2016/06/24 by Jack.Porter Remove FFuncTestManager warning about PIE when running on a standalone game binary Change 3026398 on 2016/06/24 by Jack.Porter Prevent FSocketBSD::Recv returning false on SE_EWOULDBLOCK Change 3027553 on 2016/06/25 by Niklas.Smedberg OpenGL: Made some block size calculation work for arbitrary block sizes (e.g. not pow-of-two). Change 3027554 on 2016/06/25 by Niklas.Smedberg Metal: copyFromTexture now gets block-aligned size parameter (e.g. used for texture streaming) Change 3028061 on 2016/06/26 by Jack.Porter Fixed a problem where newly discovered instances were not added to an existing session in the Session Browser. Fixed a problem where selecting an instance in a session with multiple instances didn't deselect the previously selected instance correctly. Change 3029220 on 2016/06/27 by Steve.Cano Change Android Tilt values to use GetRotationMatrix/GetOrientation logic, same as java-side android would use, and adjust slightly to match as closely as possible to iOS values for tilt. There is drift and some differences in the "Y" value but the same sort of inconsistencies are also seen on iOS. #jira UE-6135 #ue4 #android Change 3030420 on 2016/06/28 by Jack.Porter Fix crash with RenderOutputValidation when running with cooked content Change 3030426 on 2016/06/28 by Jack.Porter Fix to CL 3026398 - make FSocketBSD(IPv6)::Recv(From) return false when recv returns 0. A return value of 0 indicates the connection was shutdown in an orderly manner. Change 3030973 on 2016/06/28 by Steve.Cano Added a landscape downloader background along with the options to change it from within Android settings #ue4 #android #jira UE-32318 Change 3031757 on 2016/06/28 by Chris.Babcock Remove unused methods from AndroidJNI header #ue4 #android Change 3032387 on 2016/06/29 by Allan.Bentham Rename android es31+aep -> glesdeferred. Change 3032711 on 2016/06/29 by Allan.Bentham Rename GLSL_310_ES_EXT shader define: ES31_AEP_PROFILE -> ESDEFERRED_PROFILE bumped UE_SHADER_GLSL_310_ES_EXT_VER version number. Change 3033698 on 2016/06/29 by Jack.Porter Merging //UE4/Dev-Main to Dev-Mobile (//UE4/Dev-Mobile) Change 3034210 on 2016/06/30 by Steve.Cano Added a new AndroidRuntimeSettings variable that allows creation of installers for both Windows and Mac/Linux if set to true. #jira UE-32302 #ue4 #android Change 3034530 on 2016/06/30 by Chris.Babcock Rename FManifestReader to FAndroidFileManifestReader in AndroidFile #jira UE-32679 #ue4 #android Change 3034612 on 2016/06/30 by Steve.Cano Change Alpha from being set to a range of 0-255 to being in a range of 0-1 (which is the correct range of values) #jira UE-25325 #ue4 #android Change 3034679 on 2016/06/30 by Chris.Babcock Fix tooltip (.command for mac, not .sh) #jira UE-32302 #ue4 #android Change 3038881 on 2016/07/05 by Jack.Porter Package and launch on multiple Android devices simultaneously using the -Device=xxxxxxx+yyyyyyyy+zzzzzzzz format generated by a Project Launcher profile when you select multiple devices #jira UEMOB-115 Change 3039240 on 2016/07/06 by Jack.Porter TcpMessageTransport - connection-based message bus transport. #jira UEMOB-112 #jira UEMOB-113 Change 3039252 on 2016/07/06 by Jack.Porter Enable messaging and session services and functional testing on Android when launched with -messaging Android device detection module support for adding port forwarding and connection announcement for TcpMessageTransport #jira UEMOB-112 #jira UEMOB-113 Change 3039264 on 2016/07/06 by Jack.Porter Merging //UE4/Dev-Main to Dev-Mobile (//UE4/Dev-Mobile) Change 3040041 on 2016/07/06 by Chris.Babcock Pass proper value to script generator functions #jira UE-32861 #ue4 #android Change 3040890 on 2016/07/07 by Allan.Bentham Fix shadow crash #jira UE-32884 Change 3041458 on 2016/07/07 by Peter.Sauerbrei fix for IOS launch on failures Change 3041542 on 2016/07/07 by Peter.Sauerbrei better fix for the multi-device deployment issue Change 3041774 on 2016/07/07 by Steve.Cano Fixing crash that occurs when a games app id for Google Play is set before configuring the apk packaging. Also validating the value that is inserted and using it to override any values that have been hand-inserted into the GooglePlayAppID.xml #jira UE-16992 #android #ue4 Change 3042222 on 2016/07/08 by Dmitriy.Dyomin Mobile packaging scenarious Added a wizard for creating launcher profiles (Android & IOS) for scenario: Minimal App + Downloadable content Added Archive step to launcher profiles to be able to store build product into specified directory Changes to a cooker to be able to pack DLC based with a different flavor to a release App Changes to DLC packaging to be able to build streaming data without chunking pak files #jira UEMOB-119 Change 3042244 on 2016/07/08 by Dmitriy.Dyomin Fixed crash in FTcpMessageTransportConnection::Stop Change 3042270 on 2016/07/08 by Dmitriy.Dyomin GitHub #2320 : [ULevelStreamingKismet] Load Level Instance, Enables UE4 Users to create multiple transformed instances of a .umap without having to include in persistent level's list ? Rama contributed by: EverNewJoy #jira UE-29867 Change 3042449 on 2016/07/08 by Dmitriy.Dyomin Fixing Mac Editor build erros from CL# 3042222 Change 3042480 on 2016/07/08 by Allan.Bentham Add ES3.1 profile & compiler_glsl_es3_1 to shaders. Change 3042481 on 2016/07/08 by Allan.Bentham hlslcc - ES3.1 changes. set ES3.1 version number to 310 Do not use ES2 keywords for ES3.1. Generate Layout Locations for ES3.1 bump version. Change 3042483 on 2016/07/08 by Allan.Bentham Add mobile ES3.1 support. Recreates EGL and ES3.1 context during PlatformInitOpenGL if ES3.1 is required. Change 3042485 on 2016/07/08 by Allan.Bentham Undo android XGE change. Change 3042506 on 2016/07/08 by Dmitriy.Dyomin One more compile fix from CL# 3042222 Change 3044173 on 2016/07/10 by Dmitriy.Dyomin UAT: Added support for building target platforms with multiple cook flavors ex: -targetplatform=Android -cookflavor=ETC1+ETC2 Change 3044213 on 2016/07/11 by Dmitriy.Dyomin Fixed: Can't stream in a level whose name is a substring of another streaming level #jira UE-32999 Change 3044221 on 2016/07/11 by Jack.Porter Merging //UE4/Dev-Main to Dev-Mobile (//UE4/Dev-Mobile) Change 3044815 on 2016/07/11 by Allan.Bentham Corrected NAME_GLSL_ES3_1_ANDROID format string. Change 3046911 on 2016/07/12 by Chris.Babcock Add handling of OnTextChanged for virtual keyboard input on Android #jira UE-32348 #ue4 #android Change 3046958 on 2016/07/12 by Chris.Babcock Rename some functions with Error in the name to prevent false coloring in the logs #jira UE-30541 #ue4 #android Change 3047169 on 2016/07/12 by Chris.Babcock Return player ID and handle auth token for Google Play Games on Android (contributed by gameDNAstudio) #jira UE-30610 #pr #2372 #ue4 #android Change 3047406 on 2016/07/12 by Jack.Porter Add missing import to GameActivity.java Change 3047442 on 2016/07/13 by Dmitriy.Dyomin Added: Mobile custom post-process Limitations: can fetch only from PostProcessInput0 (SceneColor) other scene textures are not supported. Does not support "Replacing the Tonemapper" blendable location. #jira UEMOB-147 Change 3047466 on 2016/07/13 by Dmitriy.Dyomin Disabled engine crash handler on Android, system crash handler works more reliably across different os versions/devices Change 3047746 on 2016/07/13 by Jack.Porter Rename FBasePassFowardDynamicPointLightInfo Change 3047778 on 2016/07/13 by Jack.Porter Missing file for rename FBasePassFowardDynamicPointLightInfo Change 3047788 on 2016/07/13 by Allan.Bentham Fix incorrect TargetPlatformDescriptor string generation. Change 3047790 on 2016/07/13 by Allan.Bentham Fixed half3x3 matrix use with ES3.1 glsl Fixed couple of interpolator precision mismatch. Fixed ES3.1 support detection issues Change 3047816 on 2016/07/13 by Allan.Bentham Remove AndroidGL4 remnants. Change 3048926 on 2016/07/13 by Chris.Babcock Added detection of Amazon Fire TV to disable requiring virtual joysticks #ue4 #android Change 3049335 on 2016/07/14 by Dmitriy.Dyomin Fixing UAT crash when packaging project for iOS Change 3049390 on 2016/07/14 by Jack.Porter Disabled error for warning 4819 "The file contains a character that cannot be represented in the current code page (xxx). Save the file in Unicode format to prevent data loss" This is triggered by European characters and copyright symbols in source saved as latin-1 when compiling on non-US windows. Seen often in 3rd party headers, eg nvapi. #code_review: Ben.Marsh Change 3049391 on 2016/07/14 by Jack.Porter Fixed incorrect comment order in CL 3049390 Change 3049545 on 2016/07/14 by Dmitriy.Dyomin Reworking some code from CL#3047442 to make static analizer happy Change 3049626 on 2016/07/14 by Allan.Bentham Automatic CSM shader toggling #jira UE-27429 Change 3051574 on 2016/07/15 by Jack.Porter Support for lighting channels on Mobile - Multiple directional lights are supported in different channels but primitives are only affected by the directional light in the first channel they have set - CSM shadows from stationary or movable directional lights correctly follow their lighting channels - No channel limitations for dynamic point lights Notes: Removed mobile-specific directional light shadowing fields from View uniform buffer and mobile no longers uses SimpleDirectionalLight. Separate uniform buffers for mobile directional light are generated for each lighting channel. CSM culling information is now stored in FViewInfo and not per FVisibleLightViewInfo as the visibility bits are per view. #code_review Daniel.Wright #jira UEMOB-110 Change 3051699 on 2016/07/15 by Steve.Cano Preserve the original, pre-transformed input vertices for Slate shaders, which is required to properly do anti-aliasing (the ViewProjection-transformed values were causing the lines to not be drawn). #jira UE-20320 #ue4 #android Change 3051744 on 2016/07/15 by Chris.Babcock Fix Android Vulkan include path checks (contributed by kodomastro) #jira UE-33311 #PR #2602 #ue4 #android Change 3052023 on 2016/07/15 by Chris.Babcock Fix shadowed variables Change 3052110 on 2016/07/15 by Chris.Babcock Compile fixes for light channel support on mobile - missing template - accessor function for MobileDirectionalLights from scene Change 3052242 on 2016/07/15 by Chris.Babcock Compile fixes for light channel support on mobile - removed dependency on C++14 feature Change 3052730 on 2016/07/16 by Dmitriy.Dyomin Win32 build fix Change 3053041 on 2016/07/17 by Jack.Porter Merging //UE4/Dev-Main to Dev-Mobile (//UE4/Dev-Mobile) Change 3053054 on 2016/07/17 by Jack.Porter Changed use of old function ShouldUseDeferredRenderer() to new GetShadingPath() Change 3053055 on 2016/07/17 by Jack.Porter Fixed local variable aliasing in unity build Change 3053206 on 2016/07/18 by Jack.Porter Support ExecuteJavascript on iOS and Android Expose ExecuteJavascript to widget blueprint Fix ExecuteJavascript unicode string support on desktop platforms #jira UEMOB-152 Change 3053323 on 2016/07/18 by Dmitriy.Dyomin Added: Ability to set thread affinity for a device in Device Profiles (ex: +CVars=android.SetThreadAffinity=RT 0x02 GT 0x01) #jira UEMOB-107 Change 3053723 on 2016/07/18 by Jack.Porter Fix for UnrealTournamentProto.Automation.cs build errors Change 3055090 on 2016/07/19 by Dmitriy.Dyomin Junk OnlineBlueprintSupport module binaries [CL 3056789 by Jack Porter in Main branch]
2016-07-19 19:13:01 -04:00
ServerParams.Devices = new ParamList<string>(Params.ServerDevice);
if (ServerParams.ServerTargetPlatforms.Count == 0)
{
throw new AutomationException("No ServerTargetPlatform set for RunDedicatedServer.");
}
var DeployContextList = CreateDeploymentContext(ServerParams, true);
if (DeployContextList.Count == 0)
{
throw new AutomationException("No DeployContextList for RunDedicatedServer.");
}
var SC = DeployContextList[0];
var ServerApp = CombinePaths(CmdEnv.LocalRoot, "Engine/Binaries/Win64/UE4Editor.exe");
if (ServerParams.Cook)
{
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 3491552) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3421703 on 2017/05/03 by Ben.Marsh Surround invalid character message in quotes, so it's clear when a space is listed. #jira UE-44606 Change 3422644 on 2017/05/04 by Steve.Robb Ranged-for support for TChunkedArray. Change 3422754 on 2017/05/04 by Steve.Robb IAsyncReadFileHandle made non-copyable to prevent accidental wrong stat calculation. Change 3422758 on 2017/05/04 by Steve.Robb Misc readability/standards improvements in stats code. Change 3427955 on 2017/05/08 by Steve.Robb Version fix for IOS optimization pragmas, copied from equivalent Mac code. Change 3428017 on 2017/05/08 by Steve.Robb Unused property types removed. Change 3428641 on 2017/05/08 by Ben.Marsh UAT: Remove failed attempt to separate out BuildCookRun into separate commands, which have since rotted. Change 3430407 on 2017/05/09 by Ben.Marsh UBT: Define UE_4_X_OR_LATER macros for every UE4 version greater than 4.17 (eg. UE_4_17_OR_LATER, etc...). Change 3430682 on 2017/05/09 by Gil.Gribb UE4 - Added a fatal error for asking for very large alignments from MallocBinned2 and also return the true size of the memory block in GetAllocationSize(). Change 3430685 on 2017/05/09 by Gil.Gribb UE4 - Fixed a bug with the windows async IO stuff related to an unsafe pointer cast to LPDWORD from int64*. Change 3430756 on 2017/05/09 by Ben.Marsh UBT: Switch some receipt stuff to use FileReference/DirectoryReference objects rather than raw paths. Change 3431157 on 2017/05/09 by Ben.Marsh UBT: Store absolute paths when receipts are in memory; only insert pseudo-variables for $(EngineDir) and $(ProjectDir) when saved to disk. Change 3432334 on 2017/05/10 by Graeme.Thornton Include project name in the UBT error message which appears when a plugin is missing Change 3432481 on 2017/05/10 by Gil.Gribb UE4 - Fixed code to detect cycles in parallel tick sorting. Change 3432485 on 2017/05/10 by Steve.Robb Simplified templating around bitfield offset calculation. Change 3432608 on 2017/05/10 by Steve.Robb 'bool == byte' static_assert restored after being removed in CL# 3432485. Change 3432767 on 2017/05/10 by Ben.Marsh UBT: Fix exception when a missing plugin is encountered if the target does not have a project. Change 3433031 on 2017/05/10 by Ben.Marsh UAT: Add classes to allow safer manipulation of paths within the staging directory (StagedFileReference, StagedDirectoryReference), and convert staging code over to using those and their regular filesystem counterparts (FileReference/DirectoryReference). Lots of cleanup and refactoring of staging code. Change 3433049 on 2017/05/10 by Ben.Marsh Add more diagnostic information to asserts in TStaticIndirectArrayThreadSafeRead, to try and shed light on what sort of corrupted data is being passed in from the cooker. #jira UE-44336 Change 3433097 on 2017/05/10 by Steve.Robb Value initialization fix for MakeUnique<T[]>(). Change 3433972 on 2017/05/10 by Daniel.Lamb Stop unrealpak from crashing if generating a patch with more pak files then the original game. Change 3434124 on 2017/05/10 by Ben.Marsh UAT: Remove hacky bUseWebSocketNetDriver option. Change 3434824 on 2017/05/11 by Gil.Gribb UE4 - Printed an error instead of asserting when there are missing native classes. Change 3434916 on 2017/05/11 by Ben.Marsh UAT: Separate the list of files to be staged into a separate class. Change 3435427 on 2017/05/11 by Gil.Gribb UE4 - Fixed attempts to load compiled in packages, which produces warnings and is slow. Change 3436240 on 2017/05/11 by Ben.Marsh UAT: Add a command to search for restricted folders under a given base directory. Change 3438068 on 2017/05/12 by James.Fox Checking in Phase 1 of the Dev-Core test map for repro purposes. UE-44996 #rb none Change 3438855 on 2017/05/15 by Robert.Manuszewski When verbose cluster logging is enabled and new object is added to an already existing cluster, the cluster will be dumped to log. Change 3438929 on 2017/05/15 by Robert.Manuszewski Merging CL # 3436939 using Dev-Core_To_Dev-LoadTimes: Fix for potential crashes caused by levels staying in memory through material references. Change 3439021 on 2017/05/15 by Ben.Marsh PR #3566: fix non-ascii characters in help command HTML converted to "?" (Contributed by kayama-shift) Change 3439079 on 2017/05/15 by Ben.Marsh PR #2832: Implement missing MessageBox (Contributed by projectgheist) Change 3439258 on 2017/05/15 by Ben.Marsh Highlight lines containing the strings "Error:" or "Warning:" in the output log, so that diagnostics from child processes are highlighted appropriately. The build system already relies similar logic for scraping diagnostics from logs, so it should be safe and predictable to check for messages in this way. #jira UE-43673 Change 3439358 on 2017/05/15 by Ben.Marsh UBT: Fix Visual Studio solution referencing the incorrect platform for existing C# project ("Any CPU" instead of "AnyCPU"). Was causing prompt to save the solution the first time it is opened. Change 3439665 on 2017/05/15 by Ben.Marsh UAT: Remove DeployPakInternalLowerCaseFilenames(). No platforms require this to be true. Change 3440735 on 2017/05/16 by Robert.Manuszewski UBT compile fix after the last merge Change 3440889 on 2017/05/16 by Ben.Marsh EC: Fix regex for matching path to source files included in error messages from the Linux toolchain. Change 3442776 on 2017/05/17 by Steve.Robb Platform fix for FPaths::IsSamePath. Change 3445411 on 2017/05/17 by Ben.Marsh UBT: Fix typo in makefile diagnostic string. Change 3446070 on 2017/05/18 by Steve.Robb Fix to array sizes in generated UFunction code, which should now handle editor-only functions. Change 3446091 on 2017/05/18 by Steve.Robb Another array size fix for generated code. Change 3446605 on 2017/05/18 by Steve.Robb BuildConfiguration option for static analysis. Change 3448601 on 2017/05/19 by Richard.Fawcett Change FWindowsPlatformProcess::ApplicationSettingsDir() so that it no longer returns a path with a mixture of "\" and "/" characters, and only contains "/" characters. This makes it consistent with other related functions like FWindowsPlatformProcess::UserSettingsDir(). Change 3449026 on 2017/05/19 by Ben.Marsh Fix whitespace in template file. Change 3449697 on 2017/05/19 by James.Fox Checking in Phase 2 of Dev-Core test map for QAGame Also enabled Blueprint and Actor clustering by default in QAGame for more thorough GC testing. Change 3451352 on 2017/05/22 by Steve.Robb UFunction flags are now viewable in the debugger. Change 3451355 on 2017/05/22 by Steve.Robb ARRAY_COUNT fix for zero-sized arrays in Clang. Change 3451379 on 2017/05/22 by Steve.Robb C++14 operator delete overloads with size, for consistency. Change 3451398 on 2017/05/22 by Graeme.Thornton Add AES and RSA encryption keys to the list of config fields that get stripped from ini files when staging When creating a pak file, do a filtered copy of all ini files to a temp directory so that all confidential fields can be stripped. Equivalent behaviour to staging a loose file distribution Change 3451476 on 2017/05/22 by Ben.Marsh Compile shipping builds for WEX and Ocean, and post telemetry for the resulting executable size. Change 3451478 on 2017/05/22 by Graeme.Thornton PR #3197: Improved log message formatting (Contributed by projectgheist) Change 3451868 on 2017/05/22 by Steve.Robb Static log category moved out of header. ENUM_CLASS_FLAGS macro used instead of explicit operators. Change 3452319 on 2017/05/22 by Ben.Marsh UBT: Add a new "package" build product type, which can be used for APK files on Android and Stub files on iOS. Treating these files as executables is causing the measured executable size to be incorrect. Change 3452607 on 2017/05/22 by Ben.Marsh UBT: Filter out folders for other platforms when searching for headers to pass to UHT. Change 3453600 on 2017/05/23 by Graeme.Thornton PR #3226 - Updated some code comments to better describe the usage of the log category definition macros Change 3453616 on 2017/05/23 by Steve.Robb Error reported instead of a crash when there's a space between UCLASS or UINTERFACE and the open parenthesis. Change 3453714 on 2017/05/23 by Ben.Marsh Build: Add some Visual Studio 2017 test compiles to the build system. Change 3453795 on 2017/05/23 by Ben.Marsh UBT: Fix parsing of command line attributes that have a specific value assigned. We should never have an '=' suffix for such arguments. Change 3454606 on 2017/05/23 by Ben.Marsh UAT: Make sure log filenames are unique by creating a 0-byte file in its place. Change 3454709 on 2017/05/23 by Ben.Marsh UBT: Enable the /permissive- option for stricter standards compliance on Visual Studio 2017. Currently have /Zc:strictStrings disabled due to violations in Windows headers; all UE4 instances have been fixed up. Change 3456445 on 2017/05/24 by Graeme.Thornton MemoryProfiler2 - Add mprof filename into title bar after opening Change 3457129 on 2017/05/24 by Ben.Marsh Fix comment for FVector::Normalize(). #jira UE-45369 #rnx Change 3457228 on 2017/05/24 by Ben.Marsh Do not allow forward-declaring Rect structs. They are not public, and it conflicts with third party libraries. #rnx Change 3458357 on 2017/05/24 by Ben.Marsh Fix name resolution issue with /permissive- in VS2017. Change 3458812 on 2017/05/25 by Robert.Manuszewski PR #2407: Fix LoadLibrary error with Microsoft Group Policy CWDIllegalinDllSearch mode 1 or 2 (Contributed by bozaro) Change 3458894 on 2017/05/25 by Robert.Manuszewski PR #2096: Fix argument parsing in DiffAssets Comandlet (Contributed by cgrebeld) Change 3461205 on 2017/05/26 by Robert.Manuszewski Fixed parameter parsing so that arguments are not parsed if not preceeded by a whitespace (for example "-Log" was parsed in "TM-Log") #jira UE-33790 Change 3464714 on 2017/05/30 by Robert.Manuszewski Fixing potential deadlock caused by a race condition when using FMallocVerifyProxy with FMallocBinned Change 3465310 on 2017/05/30 by Ben.Marsh UBT: Enable bAdaptiveUnityDisablesOptimizations by default. Change 3465346 on 2017/05/30 by Ben.Marsh UBT: Require Update 3 to be installed when compiling using VS2015. Change 3465389 on 2017/05/30 by Ben.Marsh UBT: Fix support for RTTI when creating PCHs and shared PCHs. Change 3466084 on 2017/05/30 by Ben.Marsh Fix compiling plain C files, where it would incorrectly use a C++ PCH. Change 3467018 on 2017/05/31 by Robert.Manuszewski Async loading code will now properly handle cases when the requested package could not be created. Change 3467113 on 2017/05/31 by Ben.Marsh UGS: When opening a solution in Visual Studio, always start the process in the solution's directory. Change 3467508 on 2017/05/31 by Ben.Marsh Add a function to fix a long package name so it matches the case of a file on disk. Fixes deterministic cooking issues when on-disk case changes. Change 3467510 on 2017/05/31 by Ben.Marsh Fix deterministic cooking issue caused by LODGroup only being initialized in the CDO if it's serialized, causing inconsistent delta serialization for instances. Change 3467967 on 2017/05/31 by Ben.Marsh Always allow UAT to compile on non-Windows platforms, even if a debugger is present, since MSVC is the only one that will load C# PDBs. Change 3468544 on 2017/05/31 by Ben.Marsh UBT: Add a more helpful message when a module is being compiled with implicit PCHs, but a source file is not configured correctly. Change 3469241 on 2017/06/01 by Ben.Marsh UBT: Fix single-file compile causing a different UHT manifest to be generated, potentially excluding hidden dependencies. Change 3471709 on 2017/06/02 by Daniel.Lamb Rebuild lighting commandlet now rebuilds reflections also instead of trashing them. #test None Change 3471719 on 2017/06/02 by Daniel.Lamb Fixed crash in cooker while trying to cook for multiple platforms #test Launch on shootergame windows + ps4 #jira UE-45356 Change 3472261 on 2017/06/02 by Ben.Marsh CRP: Clear out MDD logs whenever we clear out CRP logs. Change 3473169 on 2017/06/05 by Graeme.Thornton PR #3622: Log category code cleanup (Contributed by projectgheist) Change 3473176 on 2017/06/05 by Graeme.Thornton PR #3622: Log category code cleanup (Contributed by projectgheist) (Part II) - Missed some files from my previous checkin Change 3473597 on 2017/06/05 by Ben.Marsh UnrealVS: Fix massive slowdown on startup caused by searching the directory tree under the solution for *.uproject files (including intermediate folders, etc...). Now reads *.uprojectdirs files and only checks the listed directories within. Measured it taking > 30s to run before, now takes < 0.1s. Change 3473722 on 2017/06/05 by Steve.Robb GitHub #3444: UE-42521: Added missing macro's for TMap and TSet PREPROCESSOR_COMMA_SEPARATED added as a better solution for the hacky comma separator solution in the PR. Change 3475073 on 2017/06/06 by Steve.Robb Fix for TPromise's move assignment operator return value. Change 3475331 on 2017/06/06 by Ben.Marsh UAT: Fix invalid paths being generated when stripping encryption settings from config files. * In cases where INI files were in a subfolder of the Config folder (eg. Config\Localization), it was not stripping the separating slash, resulting in files being written to the root directory of the current drive. * Paths under the config folder are not guaranteed to be unique. Change 3475453 on 2017/06/06 by Ben.Marsh UBT: Add an error if a plugin lists a non-plugin module as belonging to it. #jira UE-45178 Change 3475668 on 2017/06/06 by Ben.Marsh Add a message showing when we begin creating the asset registry, since it can take a long time. #jira UE-41675 Change 3475747 on 2017/06/06 by Steve.Robb Replicated from CL# 3332960: Force a gather on hot reload, so we don't use stale state from the makefile. #jira UE-42205 Change 3475897 on 2017/06/06 by Ben.Marsh PR #3655: Improved behavior for Automation.IsBuildMachine (Contributed by projectgheist) Change 3477432 on 2017/06/07 by Robert.Manuszewski Removed AsyncIOBandwidthLimit as it was no longer being used by anything. Change 3478582 on 2017/06/07 by Ben.Marsh UBT: Allow setting the UE_ENGINE_DIRECTORY macro for any monolithic builds, to fix being able to debug cooked foreign projects in the binary release. Change 3480035 on 2017/06/08 by Gil.Gribb UE4 - Fixed async loading from pak files < 64k. Change 3484348 on 2017/06/12 by Robert.Manuszewski Removed private_subobject macro which was a temporary measure to make all subobjects private without breaking game code. Change 3484863 on 2017/06/12 by Steve.Robb Fix for TSparseArray::operator= corrupting non-POD objects. InCopy.ArrayMax cached in a local instead of being read each time. Const-correctness fix for element copy construction. SrcData and DestData names flipped as they were the wrong way around. Source: https://udn.unrealengine.com/questions/374840/possible-bug-in-tsparsearray-assignment-operator.html Change 3485003 on 2017/06/12 by Ben.Marsh UGS: Add support for multiple tabs. Each tab can monitor changes in a separate workspace, and scheduled syncs will run for all open tabs. Change 3485063 on 2017/06/12 by Ben.Marsh UGS: Fix a null reference exception when right clicking on the notification icon during startup. Change 3485104 on 2017/06/12 by Ben.Marsh PR #2084: [UAT] Command-line parameter to override branch name (Contributed by nbjk667) Change 3485112 on 2017/06/12 by Steve.Robb TSetElement generic constructor protected from becoming a copy constructor. Redundant #include removed from AreTypesEqual.h. Source: https://udn.unrealengine.com/questions/374840/possible-bug-in-tsparsearray-assignment-operator.html Change 3485452 on 2017/06/12 by Ben.Marsh UnrealVS: Fix command line not being updated for C# projects. IVsBuildPropertyStorage.SetPropertyValue does not seem to update properties that are cached in memory. #jira UE-45716 Change 3486182 on 2017/06/12 by Ben.Marsh UGS: Include option to selet tab names in the options menu. Change 3486189 on 2017/06/12 by Ben.Marsh UGS: Fix browse button from context menu always opening a new tab. Change 3486636 on 2017/06/13 by Steve.Robb FStatMessagesArray iteration changed to use ranged-for instead of indexing. Change 3486688 on 2017/06/13 by Steve.Robb Fix for CDO pointer replacement in non-UObject properties during hot reload. #jira UE-38146 Change 3486704 on 2017/06/13 by Ben.Marsh UGS: Fix exception when closing the last open tab. Change 3486707 on 2017/06/13 by Ben.Marsh UGS: Fix exception on load if UGS was closed with no projects open. Change 3486715 on 2017/06/13 by Ben.Marsh UGS: Change tabs to show the project file by default. Change 3486718 on 2017/06/13 by Ben.Marsh UGS: Only allow one workspace to sync at a time. Change 3486880 on 2017/06/13 by Ben.Marsh UGS: Show the sync progress of each tab via the underline on the tab button. Change 3486912 on 2017/06/13 by Ben.Marsh UGS: Include the open project and recent project list as separate top-level menu items. Change 3486914 on 2017/06/13 by Ben.Marsh UGS: Update version to 1.101. Change 3487092 on 2017/06/13 by Ben.Marsh UGS: Fix crash on startup if log window is minimized. Change 3487099 on 2017/06/13 by Ben.Marsh UGS: Update version to 1.102 Change 3487198 on 2017/06/13 by Ben.Marsh Remove debug code. Change 3487285 on 2017/06/13 by Ben.Marsh Restore Remap() function that was accidentally removed in merge. Change 3487769 on 2017/06/13 by Ben.Marsh Disable the promoted flag when using the SyncProject command on Mac; doing so prevents UE4Game being compiled when packaging blueprint projects. #jira UE-45995 Change 3487915 on 2017/06/13 by Ben.Marsh UAT: Fix exception due to collection being modified while packaging for Linux. #jira UE-46013 Change 3487972 on 2017/06/13 by Ben.Marsh UAT: Always allow staged files to overwrite previously staged files. New iOS code relies on old behavior to overwrite engine icons and metadata with game copies. #jira UE-46014 Change 3487991 on 2017/06/13 by Ben.Marsh UAT: Ensure that the directory exists before trying to create a placeholder log filename. #jira UE-46015 Change 3489062 on 2017/06/14 by Robert.Manuszewski Removed FPackageFileSummary's AdditionalPackagesToCook as it was not used by anything. This should reduce the package header size considerably for levels with many streaming sublevels. #jira UE-45563 Change 3489063 on 2017/06/14 by Robert.Manuszewski Increasing the maximum package summary size to handle levels with multiple streaming sublevels. #jira UE-45563 Change 3491552 on 2017/06/15 by Ben.Marsh Handle failures to load *MeshReduction modules. [CL 3492074 by Ben Marsh in Main branch]
2017-06-15 12:43:54 -04:00
List<FileReference> Exes = SC.StageTargetPlatform.GetExecutableNames(SC);
ServerApp = Exes[0].FullName;
}
var Args = ServerParams.Cook ? "" : (SC.ProjectArgForCommandLines + " ");
Console.WriteLine(Params.ServerDeviceAddress);
Copying //UE4/Dev-Mobile to //UE4/Dev-Main (Source: //UE4/Dev-Mobile @ 3056055) #lockdown Nick.Penwarden #rb None ========================== MAJOR FEATURES + CHANGES ========================== Change 3011102 on 2016/06/13 by Steve.Cano After taking a screenshot using glReadPixels, transfer the data to the target buffer from bottom row up to fix the "upside-down" render that OpenGL does. Confirmed with QA (owen.stupka_volt) that this does not appear to be happening on iOS (non-metal devices, inclusion of iOS in write-up was a mistake), verified on an ipod touch 5. Also confirmed that this does not happen on html5, and that Mobile HDR flag does not make a difference in function. #jira UE-26421 #ue4 #android Change 3015801 on 2016/06/16 by Dmitriy.Dyomin Probbably fix for UE-30878, was not able to repro an actual crash(FFoliageInstanceBaseCache::AddInstanceBaseId). Added even more logging in case fix does not work. #jira UE-30878 Change 3015903 on 2016/06/16 by Dmitriy.Dyomin Fixed: Levels window has Refresh/UI issues when World Composition is active #jira UE-26160 Change 3018352 on 2016/06/17 by Chris.Babcock Handle Android media prepare failure (URL without internet for example) #jira UE-32029 #ue4 #android Change 3026387 on 2016/06/24 by Jack.Porter Remove FFuncTestManager warning about PIE when running on a standalone game binary Change 3026398 on 2016/06/24 by Jack.Porter Prevent FSocketBSD::Recv returning false on SE_EWOULDBLOCK Change 3027553 on 2016/06/25 by Niklas.Smedberg OpenGL: Made some block size calculation work for arbitrary block sizes (e.g. not pow-of-two). Change 3027554 on 2016/06/25 by Niklas.Smedberg Metal: copyFromTexture now gets block-aligned size parameter (e.g. used for texture streaming) Change 3028061 on 2016/06/26 by Jack.Porter Fixed a problem where newly discovered instances were not added to an existing session in the Session Browser. Fixed a problem where selecting an instance in a session with multiple instances didn't deselect the previously selected instance correctly. Change 3029220 on 2016/06/27 by Steve.Cano Change Android Tilt values to use GetRotationMatrix/GetOrientation logic, same as java-side android would use, and adjust slightly to match as closely as possible to iOS values for tilt. There is drift and some differences in the "Y" value but the same sort of inconsistencies are also seen on iOS. #jira UE-6135 #ue4 #android Change 3030420 on 2016/06/28 by Jack.Porter Fix crash with RenderOutputValidation when running with cooked content Change 3030426 on 2016/06/28 by Jack.Porter Fix to CL 3026398 - make FSocketBSD(IPv6)::Recv(From) return false when recv returns 0. A return value of 0 indicates the connection was shutdown in an orderly manner. Change 3030973 on 2016/06/28 by Steve.Cano Added a landscape downloader background along with the options to change it from within Android settings #ue4 #android #jira UE-32318 Change 3031757 on 2016/06/28 by Chris.Babcock Remove unused methods from AndroidJNI header #ue4 #android Change 3032387 on 2016/06/29 by Allan.Bentham Rename android es31+aep -> glesdeferred. Change 3032711 on 2016/06/29 by Allan.Bentham Rename GLSL_310_ES_EXT shader define: ES31_AEP_PROFILE -> ESDEFERRED_PROFILE bumped UE_SHADER_GLSL_310_ES_EXT_VER version number. Change 3033698 on 2016/06/29 by Jack.Porter Merging //UE4/Dev-Main to Dev-Mobile (//UE4/Dev-Mobile) Change 3034210 on 2016/06/30 by Steve.Cano Added a new AndroidRuntimeSettings variable that allows creation of installers for both Windows and Mac/Linux if set to true. #jira UE-32302 #ue4 #android Change 3034530 on 2016/06/30 by Chris.Babcock Rename FManifestReader to FAndroidFileManifestReader in AndroidFile #jira UE-32679 #ue4 #android Change 3034612 on 2016/06/30 by Steve.Cano Change Alpha from being set to a range of 0-255 to being in a range of 0-1 (which is the correct range of values) #jira UE-25325 #ue4 #android Change 3034679 on 2016/06/30 by Chris.Babcock Fix tooltip (.command for mac, not .sh) #jira UE-32302 #ue4 #android Change 3038881 on 2016/07/05 by Jack.Porter Package and launch on multiple Android devices simultaneously using the -Device=xxxxxxx+yyyyyyyy+zzzzzzzz format generated by a Project Launcher profile when you select multiple devices #jira UEMOB-115 Change 3039240 on 2016/07/06 by Jack.Porter TcpMessageTransport - connection-based message bus transport. #jira UEMOB-112 #jira UEMOB-113 Change 3039252 on 2016/07/06 by Jack.Porter Enable messaging and session services and functional testing on Android when launched with -messaging Android device detection module support for adding port forwarding and connection announcement for TcpMessageTransport #jira UEMOB-112 #jira UEMOB-113 Change 3039264 on 2016/07/06 by Jack.Porter Merging //UE4/Dev-Main to Dev-Mobile (//UE4/Dev-Mobile) Change 3040041 on 2016/07/06 by Chris.Babcock Pass proper value to script generator functions #jira UE-32861 #ue4 #android Change 3040890 on 2016/07/07 by Allan.Bentham Fix shadow crash #jira UE-32884 Change 3041458 on 2016/07/07 by Peter.Sauerbrei fix for IOS launch on failures Change 3041542 on 2016/07/07 by Peter.Sauerbrei better fix for the multi-device deployment issue Change 3041774 on 2016/07/07 by Steve.Cano Fixing crash that occurs when a games app id for Google Play is set before configuring the apk packaging. Also validating the value that is inserted and using it to override any values that have been hand-inserted into the GooglePlayAppID.xml #jira UE-16992 #android #ue4 Change 3042222 on 2016/07/08 by Dmitriy.Dyomin Mobile packaging scenarious Added a wizard for creating launcher profiles (Android & IOS) for scenario: Minimal App + Downloadable content Added Archive step to launcher profiles to be able to store build product into specified directory Changes to a cooker to be able to pack DLC based with a different flavor to a release App Changes to DLC packaging to be able to build streaming data without chunking pak files #jira UEMOB-119 Change 3042244 on 2016/07/08 by Dmitriy.Dyomin Fixed crash in FTcpMessageTransportConnection::Stop Change 3042270 on 2016/07/08 by Dmitriy.Dyomin GitHub #2320 : [ULevelStreamingKismet] Load Level Instance, Enables UE4 Users to create multiple transformed instances of a .umap without having to include in persistent level's list ? Rama contributed by: EverNewJoy #jira UE-29867 Change 3042449 on 2016/07/08 by Dmitriy.Dyomin Fixing Mac Editor build erros from CL# 3042222 Change 3042480 on 2016/07/08 by Allan.Bentham Add ES3.1 profile & compiler_glsl_es3_1 to shaders. Change 3042481 on 2016/07/08 by Allan.Bentham hlslcc - ES3.1 changes. set ES3.1 version number to 310 Do not use ES2 keywords for ES3.1. Generate Layout Locations for ES3.1 bump version. Change 3042483 on 2016/07/08 by Allan.Bentham Add mobile ES3.1 support. Recreates EGL and ES3.1 context during PlatformInitOpenGL if ES3.1 is required. Change 3042485 on 2016/07/08 by Allan.Bentham Undo android XGE change. Change 3042506 on 2016/07/08 by Dmitriy.Dyomin One more compile fix from CL# 3042222 Change 3044173 on 2016/07/10 by Dmitriy.Dyomin UAT: Added support for building target platforms with multiple cook flavors ex: -targetplatform=Android -cookflavor=ETC1+ETC2 Change 3044213 on 2016/07/11 by Dmitriy.Dyomin Fixed: Can't stream in a level whose name is a substring of another streaming level #jira UE-32999 Change 3044221 on 2016/07/11 by Jack.Porter Merging //UE4/Dev-Main to Dev-Mobile (//UE4/Dev-Mobile) Change 3044815 on 2016/07/11 by Allan.Bentham Corrected NAME_GLSL_ES3_1_ANDROID format string. Change 3046911 on 2016/07/12 by Chris.Babcock Add handling of OnTextChanged for virtual keyboard input on Android #jira UE-32348 #ue4 #android Change 3046958 on 2016/07/12 by Chris.Babcock Rename some functions with Error in the name to prevent false coloring in the logs #jira UE-30541 #ue4 #android Change 3047169 on 2016/07/12 by Chris.Babcock Return player ID and handle auth token for Google Play Games on Android (contributed by gameDNAstudio) #jira UE-30610 #pr #2372 #ue4 #android Change 3047406 on 2016/07/12 by Jack.Porter Add missing import to GameActivity.java Change 3047442 on 2016/07/13 by Dmitriy.Dyomin Added: Mobile custom post-process Limitations: can fetch only from PostProcessInput0 (SceneColor) other scene textures are not supported. Does not support "Replacing the Tonemapper" blendable location. #jira UEMOB-147 Change 3047466 on 2016/07/13 by Dmitriy.Dyomin Disabled engine crash handler on Android, system crash handler works more reliably across different os versions/devices Change 3047746 on 2016/07/13 by Jack.Porter Rename FBasePassFowardDynamicPointLightInfo Change 3047778 on 2016/07/13 by Jack.Porter Missing file for rename FBasePassFowardDynamicPointLightInfo Change 3047788 on 2016/07/13 by Allan.Bentham Fix incorrect TargetPlatformDescriptor string generation. Change 3047790 on 2016/07/13 by Allan.Bentham Fixed half3x3 matrix use with ES3.1 glsl Fixed couple of interpolator precision mismatch. Fixed ES3.1 support detection issues Change 3047816 on 2016/07/13 by Allan.Bentham Remove AndroidGL4 remnants. Change 3048926 on 2016/07/13 by Chris.Babcock Added detection of Amazon Fire TV to disable requiring virtual joysticks #ue4 #android Change 3049335 on 2016/07/14 by Dmitriy.Dyomin Fixing UAT crash when packaging project for iOS Change 3049390 on 2016/07/14 by Jack.Porter Disabled error for warning 4819 "The file contains a character that cannot be represented in the current code page (xxx). Save the file in Unicode format to prevent data loss" This is triggered by European characters and copyright symbols in source saved as latin-1 when compiling on non-US windows. Seen often in 3rd party headers, eg nvapi. #code_review: Ben.Marsh Change 3049391 on 2016/07/14 by Jack.Porter Fixed incorrect comment order in CL 3049390 Change 3049545 on 2016/07/14 by Dmitriy.Dyomin Reworking some code from CL#3047442 to make static analizer happy Change 3049626 on 2016/07/14 by Allan.Bentham Automatic CSM shader toggling #jira UE-27429 Change 3051574 on 2016/07/15 by Jack.Porter Support for lighting channels on Mobile - Multiple directional lights are supported in different channels but primitives are only affected by the directional light in the first channel they have set - CSM shadows from stationary or movable directional lights correctly follow their lighting channels - No channel limitations for dynamic point lights Notes: Removed mobile-specific directional light shadowing fields from View uniform buffer and mobile no longers uses SimpleDirectionalLight. Separate uniform buffers for mobile directional light are generated for each lighting channel. CSM culling information is now stored in FViewInfo and not per FVisibleLightViewInfo as the visibility bits are per view. #code_review Daniel.Wright #jira UEMOB-110 Change 3051699 on 2016/07/15 by Steve.Cano Preserve the original, pre-transformed input vertices for Slate shaders, which is required to properly do anti-aliasing (the ViewProjection-transformed values were causing the lines to not be drawn). #jira UE-20320 #ue4 #android Change 3051744 on 2016/07/15 by Chris.Babcock Fix Android Vulkan include path checks (contributed by kodomastro) #jira UE-33311 #PR #2602 #ue4 #android Change 3052023 on 2016/07/15 by Chris.Babcock Fix shadowed variables Change 3052110 on 2016/07/15 by Chris.Babcock Compile fixes for light channel support on mobile - missing template - accessor function for MobileDirectionalLights from scene Change 3052242 on 2016/07/15 by Chris.Babcock Compile fixes for light channel support on mobile - removed dependency on C++14 feature Change 3052730 on 2016/07/16 by Dmitriy.Dyomin Win32 build fix Change 3053041 on 2016/07/17 by Jack.Porter Merging //UE4/Dev-Main to Dev-Mobile (//UE4/Dev-Mobile) Change 3053054 on 2016/07/17 by Jack.Porter Changed use of old function ShouldUseDeferredRenderer() to new GetShadingPath() Change 3053055 on 2016/07/17 by Jack.Porter Fixed local variable aliasing in unity build Change 3053206 on 2016/07/18 by Jack.Porter Support ExecuteJavascript on iOS and Android Expose ExecuteJavascript to widget blueprint Fix ExecuteJavascript unicode string support on desktop platforms #jira UEMOB-152 Change 3053323 on 2016/07/18 by Dmitriy.Dyomin Added: Ability to set thread affinity for a device in Device Profiles (ex: +CVars=android.SetThreadAffinity=RT 0x02 GT 0x01) #jira UEMOB-107 Change 3053723 on 2016/07/18 by Jack.Porter Fix for UnrealTournamentProto.Automation.cs build errors Change 3055090 on 2016/07/19 by Dmitriy.Dyomin Junk OnlineBlueprintSupport module binaries [CL 3056789 by Jack Porter in Main branch]
2016-07-19 19:13:01 -04:00
TargetPlatformDescriptor ServerPlatformDesc = ServerParams.ServerTargetPlatforms[0];
if (ServerParams.Cook && ServerPlatformDesc.Type == UnrealTargetPlatform.Linux && !String.IsNullOrEmpty(ServerParams.ServerDeviceAddress))
{
ServerApp = @"C:\Windows\system32\cmd.exe";
string plinkPath = CombinePaths(Environment.GetEnvironmentVariable("LINUX_ROOT"), "bin/PLINK.exe ");
Copying //UE4/Dev-Mobile to //UE4/Dev-Main (Source: //UE4/Dev-Mobile @ 3056055) #lockdown Nick.Penwarden #rb None ========================== MAJOR FEATURES + CHANGES ========================== Change 3011102 on 2016/06/13 by Steve.Cano After taking a screenshot using glReadPixels, transfer the data to the target buffer from bottom row up to fix the "upside-down" render that OpenGL does. Confirmed with QA (owen.stupka_volt) that this does not appear to be happening on iOS (non-metal devices, inclusion of iOS in write-up was a mistake), verified on an ipod touch 5. Also confirmed that this does not happen on html5, and that Mobile HDR flag does not make a difference in function. #jira UE-26421 #ue4 #android Change 3015801 on 2016/06/16 by Dmitriy.Dyomin Probbably fix for UE-30878, was not able to repro an actual crash(FFoliageInstanceBaseCache::AddInstanceBaseId). Added even more logging in case fix does not work. #jira UE-30878 Change 3015903 on 2016/06/16 by Dmitriy.Dyomin Fixed: Levels window has Refresh/UI issues when World Composition is active #jira UE-26160 Change 3018352 on 2016/06/17 by Chris.Babcock Handle Android media prepare failure (URL without internet for example) #jira UE-32029 #ue4 #android Change 3026387 on 2016/06/24 by Jack.Porter Remove FFuncTestManager warning about PIE when running on a standalone game binary Change 3026398 on 2016/06/24 by Jack.Porter Prevent FSocketBSD::Recv returning false on SE_EWOULDBLOCK Change 3027553 on 2016/06/25 by Niklas.Smedberg OpenGL: Made some block size calculation work for arbitrary block sizes (e.g. not pow-of-two). Change 3027554 on 2016/06/25 by Niklas.Smedberg Metal: copyFromTexture now gets block-aligned size parameter (e.g. used for texture streaming) Change 3028061 on 2016/06/26 by Jack.Porter Fixed a problem where newly discovered instances were not added to an existing session in the Session Browser. Fixed a problem where selecting an instance in a session with multiple instances didn't deselect the previously selected instance correctly. Change 3029220 on 2016/06/27 by Steve.Cano Change Android Tilt values to use GetRotationMatrix/GetOrientation logic, same as java-side android would use, and adjust slightly to match as closely as possible to iOS values for tilt. There is drift and some differences in the "Y" value but the same sort of inconsistencies are also seen on iOS. #jira UE-6135 #ue4 #android Change 3030420 on 2016/06/28 by Jack.Porter Fix crash with RenderOutputValidation when running with cooked content Change 3030426 on 2016/06/28 by Jack.Porter Fix to CL 3026398 - make FSocketBSD(IPv6)::Recv(From) return false when recv returns 0. A return value of 0 indicates the connection was shutdown in an orderly manner. Change 3030973 on 2016/06/28 by Steve.Cano Added a landscape downloader background along with the options to change it from within Android settings #ue4 #android #jira UE-32318 Change 3031757 on 2016/06/28 by Chris.Babcock Remove unused methods from AndroidJNI header #ue4 #android Change 3032387 on 2016/06/29 by Allan.Bentham Rename android es31+aep -> glesdeferred. Change 3032711 on 2016/06/29 by Allan.Bentham Rename GLSL_310_ES_EXT shader define: ES31_AEP_PROFILE -> ESDEFERRED_PROFILE bumped UE_SHADER_GLSL_310_ES_EXT_VER version number. Change 3033698 on 2016/06/29 by Jack.Porter Merging //UE4/Dev-Main to Dev-Mobile (//UE4/Dev-Mobile) Change 3034210 on 2016/06/30 by Steve.Cano Added a new AndroidRuntimeSettings variable that allows creation of installers for both Windows and Mac/Linux if set to true. #jira UE-32302 #ue4 #android Change 3034530 on 2016/06/30 by Chris.Babcock Rename FManifestReader to FAndroidFileManifestReader in AndroidFile #jira UE-32679 #ue4 #android Change 3034612 on 2016/06/30 by Steve.Cano Change Alpha from being set to a range of 0-255 to being in a range of 0-1 (which is the correct range of values) #jira UE-25325 #ue4 #android Change 3034679 on 2016/06/30 by Chris.Babcock Fix tooltip (.command for mac, not .sh) #jira UE-32302 #ue4 #android Change 3038881 on 2016/07/05 by Jack.Porter Package and launch on multiple Android devices simultaneously using the -Device=xxxxxxx+yyyyyyyy+zzzzzzzz format generated by a Project Launcher profile when you select multiple devices #jira UEMOB-115 Change 3039240 on 2016/07/06 by Jack.Porter TcpMessageTransport - connection-based message bus transport. #jira UEMOB-112 #jira UEMOB-113 Change 3039252 on 2016/07/06 by Jack.Porter Enable messaging and session services and functional testing on Android when launched with -messaging Android device detection module support for adding port forwarding and connection announcement for TcpMessageTransport #jira UEMOB-112 #jira UEMOB-113 Change 3039264 on 2016/07/06 by Jack.Porter Merging //UE4/Dev-Main to Dev-Mobile (//UE4/Dev-Mobile) Change 3040041 on 2016/07/06 by Chris.Babcock Pass proper value to script generator functions #jira UE-32861 #ue4 #android Change 3040890 on 2016/07/07 by Allan.Bentham Fix shadow crash #jira UE-32884 Change 3041458 on 2016/07/07 by Peter.Sauerbrei fix for IOS launch on failures Change 3041542 on 2016/07/07 by Peter.Sauerbrei better fix for the multi-device deployment issue Change 3041774 on 2016/07/07 by Steve.Cano Fixing crash that occurs when a games app id for Google Play is set before configuring the apk packaging. Also validating the value that is inserted and using it to override any values that have been hand-inserted into the GooglePlayAppID.xml #jira UE-16992 #android #ue4 Change 3042222 on 2016/07/08 by Dmitriy.Dyomin Mobile packaging scenarious Added a wizard for creating launcher profiles (Android & IOS) for scenario: Minimal App + Downloadable content Added Archive step to launcher profiles to be able to store build product into specified directory Changes to a cooker to be able to pack DLC based with a different flavor to a release App Changes to DLC packaging to be able to build streaming data without chunking pak files #jira UEMOB-119 Change 3042244 on 2016/07/08 by Dmitriy.Dyomin Fixed crash in FTcpMessageTransportConnection::Stop Change 3042270 on 2016/07/08 by Dmitriy.Dyomin GitHub #2320 : [ULevelStreamingKismet] Load Level Instance, Enables UE4 Users to create multiple transformed instances of a .umap without having to include in persistent level's list ? Rama contributed by: EverNewJoy #jira UE-29867 Change 3042449 on 2016/07/08 by Dmitriy.Dyomin Fixing Mac Editor build erros from CL# 3042222 Change 3042480 on 2016/07/08 by Allan.Bentham Add ES3.1 profile & compiler_glsl_es3_1 to shaders. Change 3042481 on 2016/07/08 by Allan.Bentham hlslcc - ES3.1 changes. set ES3.1 version number to 310 Do not use ES2 keywords for ES3.1. Generate Layout Locations for ES3.1 bump version. Change 3042483 on 2016/07/08 by Allan.Bentham Add mobile ES3.1 support. Recreates EGL and ES3.1 context during PlatformInitOpenGL if ES3.1 is required. Change 3042485 on 2016/07/08 by Allan.Bentham Undo android XGE change. Change 3042506 on 2016/07/08 by Dmitriy.Dyomin One more compile fix from CL# 3042222 Change 3044173 on 2016/07/10 by Dmitriy.Dyomin UAT: Added support for building target platforms with multiple cook flavors ex: -targetplatform=Android -cookflavor=ETC1+ETC2 Change 3044213 on 2016/07/11 by Dmitriy.Dyomin Fixed: Can't stream in a level whose name is a substring of another streaming level #jira UE-32999 Change 3044221 on 2016/07/11 by Jack.Porter Merging //UE4/Dev-Main to Dev-Mobile (//UE4/Dev-Mobile) Change 3044815 on 2016/07/11 by Allan.Bentham Corrected NAME_GLSL_ES3_1_ANDROID format string. Change 3046911 on 2016/07/12 by Chris.Babcock Add handling of OnTextChanged for virtual keyboard input on Android #jira UE-32348 #ue4 #android Change 3046958 on 2016/07/12 by Chris.Babcock Rename some functions with Error in the name to prevent false coloring in the logs #jira UE-30541 #ue4 #android Change 3047169 on 2016/07/12 by Chris.Babcock Return player ID and handle auth token for Google Play Games on Android (contributed by gameDNAstudio) #jira UE-30610 #pr #2372 #ue4 #android Change 3047406 on 2016/07/12 by Jack.Porter Add missing import to GameActivity.java Change 3047442 on 2016/07/13 by Dmitriy.Dyomin Added: Mobile custom post-process Limitations: can fetch only from PostProcessInput0 (SceneColor) other scene textures are not supported. Does not support "Replacing the Tonemapper" blendable location. #jira UEMOB-147 Change 3047466 on 2016/07/13 by Dmitriy.Dyomin Disabled engine crash handler on Android, system crash handler works more reliably across different os versions/devices Change 3047746 on 2016/07/13 by Jack.Porter Rename FBasePassFowardDynamicPointLightInfo Change 3047778 on 2016/07/13 by Jack.Porter Missing file for rename FBasePassFowardDynamicPointLightInfo Change 3047788 on 2016/07/13 by Allan.Bentham Fix incorrect TargetPlatformDescriptor string generation. Change 3047790 on 2016/07/13 by Allan.Bentham Fixed half3x3 matrix use with ES3.1 glsl Fixed couple of interpolator precision mismatch. Fixed ES3.1 support detection issues Change 3047816 on 2016/07/13 by Allan.Bentham Remove AndroidGL4 remnants. Change 3048926 on 2016/07/13 by Chris.Babcock Added detection of Amazon Fire TV to disable requiring virtual joysticks #ue4 #android Change 3049335 on 2016/07/14 by Dmitriy.Dyomin Fixing UAT crash when packaging project for iOS Change 3049390 on 2016/07/14 by Jack.Porter Disabled error for warning 4819 "The file contains a character that cannot be represented in the current code page (xxx). Save the file in Unicode format to prevent data loss" This is triggered by European characters and copyright symbols in source saved as latin-1 when compiling on non-US windows. Seen often in 3rd party headers, eg nvapi. #code_review: Ben.Marsh Change 3049391 on 2016/07/14 by Jack.Porter Fixed incorrect comment order in CL 3049390 Change 3049545 on 2016/07/14 by Dmitriy.Dyomin Reworking some code from CL#3047442 to make static analizer happy Change 3049626 on 2016/07/14 by Allan.Bentham Automatic CSM shader toggling #jira UE-27429 Change 3051574 on 2016/07/15 by Jack.Porter Support for lighting channels on Mobile - Multiple directional lights are supported in different channels but primitives are only affected by the directional light in the first channel they have set - CSM shadows from stationary or movable directional lights correctly follow their lighting channels - No channel limitations for dynamic point lights Notes: Removed mobile-specific directional light shadowing fields from View uniform buffer and mobile no longers uses SimpleDirectionalLight. Separate uniform buffers for mobile directional light are generated for each lighting channel. CSM culling information is now stored in FViewInfo and not per FVisibleLightViewInfo as the visibility bits are per view. #code_review Daniel.Wright #jira UEMOB-110 Change 3051699 on 2016/07/15 by Steve.Cano Preserve the original, pre-transformed input vertices for Slate shaders, which is required to properly do anti-aliasing (the ViewProjection-transformed values were causing the lines to not be drawn). #jira UE-20320 #ue4 #android Change 3051744 on 2016/07/15 by Chris.Babcock Fix Android Vulkan include path checks (contributed by kodomastro) #jira UE-33311 #PR #2602 #ue4 #android Change 3052023 on 2016/07/15 by Chris.Babcock Fix shadowed variables Change 3052110 on 2016/07/15 by Chris.Babcock Compile fixes for light channel support on mobile - missing template - accessor function for MobileDirectionalLights from scene Change 3052242 on 2016/07/15 by Chris.Babcock Compile fixes for light channel support on mobile - removed dependency on C++14 feature Change 3052730 on 2016/07/16 by Dmitriy.Dyomin Win32 build fix Change 3053041 on 2016/07/17 by Jack.Porter Merging //UE4/Dev-Main to Dev-Mobile (//UE4/Dev-Mobile) Change 3053054 on 2016/07/17 by Jack.Porter Changed use of old function ShouldUseDeferredRenderer() to new GetShadingPath() Change 3053055 on 2016/07/17 by Jack.Porter Fixed local variable aliasing in unity build Change 3053206 on 2016/07/18 by Jack.Porter Support ExecuteJavascript on iOS and Android Expose ExecuteJavascript to widget blueprint Fix ExecuteJavascript unicode string support on desktop platforms #jira UEMOB-152 Change 3053323 on 2016/07/18 by Dmitriy.Dyomin Added: Ability to set thread affinity for a device in Device Profiles (ex: +CVars=android.SetThreadAffinity=RT 0x02 GT 0x01) #jira UEMOB-107 Change 3053723 on 2016/07/18 by Jack.Porter Fix for UnrealTournamentProto.Automation.cs build errors Change 3055090 on 2016/07/19 by Dmitriy.Dyomin Junk OnlineBlueprintSupport module binaries [CL 3056789 by Jack Porter in Main branch]
2016-07-19 19:13:01 -04:00
string exePath = CombinePaths(SC.ShortProjectName, "Binaries", ServerPlatformDesc.Type.ToString(), SC.ShortProjectName + "Server");
if (ServerParams.ServerConfigsToBuild[0] != UnrealTargetConfiguration.Development)
{
Copying //UE4/Dev-Mobile to //UE4/Dev-Main (Source: //UE4/Dev-Mobile @ 3056055) #lockdown Nick.Penwarden #rb None ========================== MAJOR FEATURES + CHANGES ========================== Change 3011102 on 2016/06/13 by Steve.Cano After taking a screenshot using glReadPixels, transfer the data to the target buffer from bottom row up to fix the "upside-down" render that OpenGL does. Confirmed with QA (owen.stupka_volt) that this does not appear to be happening on iOS (non-metal devices, inclusion of iOS in write-up was a mistake), verified on an ipod touch 5. Also confirmed that this does not happen on html5, and that Mobile HDR flag does not make a difference in function. #jira UE-26421 #ue4 #android Change 3015801 on 2016/06/16 by Dmitriy.Dyomin Probbably fix for UE-30878, was not able to repro an actual crash(FFoliageInstanceBaseCache::AddInstanceBaseId). Added even more logging in case fix does not work. #jira UE-30878 Change 3015903 on 2016/06/16 by Dmitriy.Dyomin Fixed: Levels window has Refresh/UI issues when World Composition is active #jira UE-26160 Change 3018352 on 2016/06/17 by Chris.Babcock Handle Android media prepare failure (URL without internet for example) #jira UE-32029 #ue4 #android Change 3026387 on 2016/06/24 by Jack.Porter Remove FFuncTestManager warning about PIE when running on a standalone game binary Change 3026398 on 2016/06/24 by Jack.Porter Prevent FSocketBSD::Recv returning false on SE_EWOULDBLOCK Change 3027553 on 2016/06/25 by Niklas.Smedberg OpenGL: Made some block size calculation work for arbitrary block sizes (e.g. not pow-of-two). Change 3027554 on 2016/06/25 by Niklas.Smedberg Metal: copyFromTexture now gets block-aligned size parameter (e.g. used for texture streaming) Change 3028061 on 2016/06/26 by Jack.Porter Fixed a problem where newly discovered instances were not added to an existing session in the Session Browser. Fixed a problem where selecting an instance in a session with multiple instances didn't deselect the previously selected instance correctly. Change 3029220 on 2016/06/27 by Steve.Cano Change Android Tilt values to use GetRotationMatrix/GetOrientation logic, same as java-side android would use, and adjust slightly to match as closely as possible to iOS values for tilt. There is drift and some differences in the "Y" value but the same sort of inconsistencies are also seen on iOS. #jira UE-6135 #ue4 #android Change 3030420 on 2016/06/28 by Jack.Porter Fix crash with RenderOutputValidation when running with cooked content Change 3030426 on 2016/06/28 by Jack.Porter Fix to CL 3026398 - make FSocketBSD(IPv6)::Recv(From) return false when recv returns 0. A return value of 0 indicates the connection was shutdown in an orderly manner. Change 3030973 on 2016/06/28 by Steve.Cano Added a landscape downloader background along with the options to change it from within Android settings #ue4 #android #jira UE-32318 Change 3031757 on 2016/06/28 by Chris.Babcock Remove unused methods from AndroidJNI header #ue4 #android Change 3032387 on 2016/06/29 by Allan.Bentham Rename android es31+aep -> glesdeferred. Change 3032711 on 2016/06/29 by Allan.Bentham Rename GLSL_310_ES_EXT shader define: ES31_AEP_PROFILE -> ESDEFERRED_PROFILE bumped UE_SHADER_GLSL_310_ES_EXT_VER version number. Change 3033698 on 2016/06/29 by Jack.Porter Merging //UE4/Dev-Main to Dev-Mobile (//UE4/Dev-Mobile) Change 3034210 on 2016/06/30 by Steve.Cano Added a new AndroidRuntimeSettings variable that allows creation of installers for both Windows and Mac/Linux if set to true. #jira UE-32302 #ue4 #android Change 3034530 on 2016/06/30 by Chris.Babcock Rename FManifestReader to FAndroidFileManifestReader in AndroidFile #jira UE-32679 #ue4 #android Change 3034612 on 2016/06/30 by Steve.Cano Change Alpha from being set to a range of 0-255 to being in a range of 0-1 (which is the correct range of values) #jira UE-25325 #ue4 #android Change 3034679 on 2016/06/30 by Chris.Babcock Fix tooltip (.command for mac, not .sh) #jira UE-32302 #ue4 #android Change 3038881 on 2016/07/05 by Jack.Porter Package and launch on multiple Android devices simultaneously using the -Device=xxxxxxx+yyyyyyyy+zzzzzzzz format generated by a Project Launcher profile when you select multiple devices #jira UEMOB-115 Change 3039240 on 2016/07/06 by Jack.Porter TcpMessageTransport - connection-based message bus transport. #jira UEMOB-112 #jira UEMOB-113 Change 3039252 on 2016/07/06 by Jack.Porter Enable messaging and session services and functional testing on Android when launched with -messaging Android device detection module support for adding port forwarding and connection announcement for TcpMessageTransport #jira UEMOB-112 #jira UEMOB-113 Change 3039264 on 2016/07/06 by Jack.Porter Merging //UE4/Dev-Main to Dev-Mobile (//UE4/Dev-Mobile) Change 3040041 on 2016/07/06 by Chris.Babcock Pass proper value to script generator functions #jira UE-32861 #ue4 #android Change 3040890 on 2016/07/07 by Allan.Bentham Fix shadow crash #jira UE-32884 Change 3041458 on 2016/07/07 by Peter.Sauerbrei fix for IOS launch on failures Change 3041542 on 2016/07/07 by Peter.Sauerbrei better fix for the multi-device deployment issue Change 3041774 on 2016/07/07 by Steve.Cano Fixing crash that occurs when a games app id for Google Play is set before configuring the apk packaging. Also validating the value that is inserted and using it to override any values that have been hand-inserted into the GooglePlayAppID.xml #jira UE-16992 #android #ue4 Change 3042222 on 2016/07/08 by Dmitriy.Dyomin Mobile packaging scenarious Added a wizard for creating launcher profiles (Android & IOS) for scenario: Minimal App + Downloadable content Added Archive step to launcher profiles to be able to store build product into specified directory Changes to a cooker to be able to pack DLC based with a different flavor to a release App Changes to DLC packaging to be able to build streaming data without chunking pak files #jira UEMOB-119 Change 3042244 on 2016/07/08 by Dmitriy.Dyomin Fixed crash in FTcpMessageTransportConnection::Stop Change 3042270 on 2016/07/08 by Dmitriy.Dyomin GitHub #2320 : [ULevelStreamingKismet] Load Level Instance, Enables UE4 Users to create multiple transformed instances of a .umap without having to include in persistent level's list ? Rama contributed by: EverNewJoy #jira UE-29867 Change 3042449 on 2016/07/08 by Dmitriy.Dyomin Fixing Mac Editor build erros from CL# 3042222 Change 3042480 on 2016/07/08 by Allan.Bentham Add ES3.1 profile & compiler_glsl_es3_1 to shaders. Change 3042481 on 2016/07/08 by Allan.Bentham hlslcc - ES3.1 changes. set ES3.1 version number to 310 Do not use ES2 keywords for ES3.1. Generate Layout Locations for ES3.1 bump version. Change 3042483 on 2016/07/08 by Allan.Bentham Add mobile ES3.1 support. Recreates EGL and ES3.1 context during PlatformInitOpenGL if ES3.1 is required. Change 3042485 on 2016/07/08 by Allan.Bentham Undo android XGE change. Change 3042506 on 2016/07/08 by Dmitriy.Dyomin One more compile fix from CL# 3042222 Change 3044173 on 2016/07/10 by Dmitriy.Dyomin UAT: Added support for building target platforms with multiple cook flavors ex: -targetplatform=Android -cookflavor=ETC1+ETC2 Change 3044213 on 2016/07/11 by Dmitriy.Dyomin Fixed: Can't stream in a level whose name is a substring of another streaming level #jira UE-32999 Change 3044221 on 2016/07/11 by Jack.Porter Merging //UE4/Dev-Main to Dev-Mobile (//UE4/Dev-Mobile) Change 3044815 on 2016/07/11 by Allan.Bentham Corrected NAME_GLSL_ES3_1_ANDROID format string. Change 3046911 on 2016/07/12 by Chris.Babcock Add handling of OnTextChanged for virtual keyboard input on Android #jira UE-32348 #ue4 #android Change 3046958 on 2016/07/12 by Chris.Babcock Rename some functions with Error in the name to prevent false coloring in the logs #jira UE-30541 #ue4 #android Change 3047169 on 2016/07/12 by Chris.Babcock Return player ID and handle auth token for Google Play Games on Android (contributed by gameDNAstudio) #jira UE-30610 #pr #2372 #ue4 #android Change 3047406 on 2016/07/12 by Jack.Porter Add missing import to GameActivity.java Change 3047442 on 2016/07/13 by Dmitriy.Dyomin Added: Mobile custom post-process Limitations: can fetch only from PostProcessInput0 (SceneColor) other scene textures are not supported. Does not support "Replacing the Tonemapper" blendable location. #jira UEMOB-147 Change 3047466 on 2016/07/13 by Dmitriy.Dyomin Disabled engine crash handler on Android, system crash handler works more reliably across different os versions/devices Change 3047746 on 2016/07/13 by Jack.Porter Rename FBasePassFowardDynamicPointLightInfo Change 3047778 on 2016/07/13 by Jack.Porter Missing file for rename FBasePassFowardDynamicPointLightInfo Change 3047788 on 2016/07/13 by Allan.Bentham Fix incorrect TargetPlatformDescriptor string generation. Change 3047790 on 2016/07/13 by Allan.Bentham Fixed half3x3 matrix use with ES3.1 glsl Fixed couple of interpolator precision mismatch. Fixed ES3.1 support detection issues Change 3047816 on 2016/07/13 by Allan.Bentham Remove AndroidGL4 remnants. Change 3048926 on 2016/07/13 by Chris.Babcock Added detection of Amazon Fire TV to disable requiring virtual joysticks #ue4 #android Change 3049335 on 2016/07/14 by Dmitriy.Dyomin Fixing UAT crash when packaging project for iOS Change 3049390 on 2016/07/14 by Jack.Porter Disabled error for warning 4819 "The file contains a character that cannot be represented in the current code page (xxx). Save the file in Unicode format to prevent data loss" This is triggered by European characters and copyright symbols in source saved as latin-1 when compiling on non-US windows. Seen often in 3rd party headers, eg nvapi. #code_review: Ben.Marsh Change 3049391 on 2016/07/14 by Jack.Porter Fixed incorrect comment order in CL 3049390 Change 3049545 on 2016/07/14 by Dmitriy.Dyomin Reworking some code from CL#3047442 to make static analizer happy Change 3049626 on 2016/07/14 by Allan.Bentham Automatic CSM shader toggling #jira UE-27429 Change 3051574 on 2016/07/15 by Jack.Porter Support for lighting channels on Mobile - Multiple directional lights are supported in different channels but primitives are only affected by the directional light in the first channel they have set - CSM shadows from stationary or movable directional lights correctly follow their lighting channels - No channel limitations for dynamic point lights Notes: Removed mobile-specific directional light shadowing fields from View uniform buffer and mobile no longers uses SimpleDirectionalLight. Separate uniform buffers for mobile directional light are generated for each lighting channel. CSM culling information is now stored in FViewInfo and not per FVisibleLightViewInfo as the visibility bits are per view. #code_review Daniel.Wright #jira UEMOB-110 Change 3051699 on 2016/07/15 by Steve.Cano Preserve the original, pre-transformed input vertices for Slate shaders, which is required to properly do anti-aliasing (the ViewProjection-transformed values were causing the lines to not be drawn). #jira UE-20320 #ue4 #android Change 3051744 on 2016/07/15 by Chris.Babcock Fix Android Vulkan include path checks (contributed by kodomastro) #jira UE-33311 #PR #2602 #ue4 #android Change 3052023 on 2016/07/15 by Chris.Babcock Fix shadowed variables Change 3052110 on 2016/07/15 by Chris.Babcock Compile fixes for light channel support on mobile - missing template - accessor function for MobileDirectionalLights from scene Change 3052242 on 2016/07/15 by Chris.Babcock Compile fixes for light channel support on mobile - removed dependency on C++14 feature Change 3052730 on 2016/07/16 by Dmitriy.Dyomin Win32 build fix Change 3053041 on 2016/07/17 by Jack.Porter Merging //UE4/Dev-Main to Dev-Mobile (//UE4/Dev-Mobile) Change 3053054 on 2016/07/17 by Jack.Porter Changed use of old function ShouldUseDeferredRenderer() to new GetShadingPath() Change 3053055 on 2016/07/17 by Jack.Porter Fixed local variable aliasing in unity build Change 3053206 on 2016/07/18 by Jack.Porter Support ExecuteJavascript on iOS and Android Expose ExecuteJavascript to widget blueprint Fix ExecuteJavascript unicode string support on desktop platforms #jira UEMOB-152 Change 3053323 on 2016/07/18 by Dmitriy.Dyomin Added: Ability to set thread affinity for a device in Device Profiles (ex: +CVars=android.SetThreadAffinity=RT 0x02 GT 0x01) #jira UEMOB-107 Change 3053723 on 2016/07/18 by Jack.Porter Fix for UnrealTournamentProto.Automation.cs build errors Change 3055090 on 2016/07/19 by Dmitriy.Dyomin Junk OnlineBlueprintSupport module binaries [CL 3056789 by Jack Porter in Main branch]
2016-07-19 19:13:01 -04:00
exePath += "-" + ServerPlatformDesc.Type.ToString() + "-" + ServerParams.ServerConfigsToBuild[0].ToString();
}
exePath = CombinePaths("LinuxServer", exePath.ToLower()).Replace("\\", "/");
Args = String.Format("/k {0} -batch -ssh -t -i {1} {2}@{3} {4} {5} {6} -server -Messaging", plinkPath, ServerParams.DevicePassword, ServerParams.DeviceUsername, ServerParams.ServerDeviceAddress, exePath, Args, ServerParams.MapToRun);
}
else
{
var Map = ServerParams.MapToRun;
if (!String.IsNullOrEmpty(ServerParams.AdditionalServerMapParams))
{
Map += ServerParams.AdditionalServerMapParams;
}
if (Params.FakeClient)
{
Map += "?fake";
}
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3316439) #lockdown Nick.Penwarden Change 3315047 on 2017/02/21 by Mieszko.Zielinski@mieszko.zielinski_T4675_Orion HTN code first check in #UE4 #rb none #test currently unused Change 3314042 on 2017/02/21 by Jason.Bestimt@Jason.Bestimt_Dev-General #ORION_DG - DAILY Main @ CL 3313484 #RB:none #Tests:none Change 3313355 on 2017/02/20 by Uriel.Doyon@uriel.doyon_PC2_Orion Changed the preliminary GPU benchmark workloads to take into account the target workload. This is to prevent running the last test with poor performance, risking a driver reset. #jira OR-29915 #rb marcus.wassmer #test Run the game triggering benchmarks Change 3312553 on 2017/02/20 by Mieszko.Zielinski@mieszko.zielinski_T4675_Orion Implemented a simple AITask for running EQS queries #UE4 #rb Lukasz.Furman #test golden path Change 3311661 on 2017/02/20 by Jason.Bestimt@Jason.Bestimt_Dev-General #ORION_DG - Merge MAIN @ CL 3311631 #RB:none #Tests:none Change 3310392 on 2017/02/17 by Daniel.Lamb@daniel.lamb_T3905_6612 Unreal pak now outputs to named log files instead of timestamps. #rb Trivial #test Cook deploy paragon #jira OR-36057 Change 3310196 on 2017/02/17 by Clayton.Langford@RDU-WD-8359_3635_Paragon_DevGen Created an event to be fired whenever a GameplayCue is routed that passes all relevant info about that GC. Added a listener in OrionPhasedFunctionalTest that parses that event into a string and stores it in an array to be accessed from a test phase later. #test PIE #rb Ben.Salem, Adric.Worley Change 3308437 on 2017/02/16 by Jason.Bestimt@Jason.Bestimt_Dev-General #ORION_DG - Merge MAIN @ CL 3308413 (Prep for Merge up) #RB:none #Tests:none Change 3306497 on 2017/02/16 by Andrew.Grant@andrew.grant.T6730.orion.floating Fix for compilation issue with USE_MALLOC_STOMP #rb none #tests compiled with malloc_stomp Change 3306468 on 2017/02/16 by Cody.Haskell@OrionStream #Orion - Text popup work for Shield. If you click on an OrionEditableTextBox while running the game with -gfn, a special popup is called. Should do nothing normally. #rb none #tests PIE, golden path. Change 3305945 on 2017/02/16 by David.Ratti@David.Ratti_G6218_Orion.Dev-General Remove unused/deprecated UGameplayEffectExtension class #rb #tests none Change 3304630 on 2017/02/15 by Jason.Bestimt@Jason.Bestimt_Dev-General #ORION_DG - Merge Mieszko stuff from MAIN to DG #RB:none #TestS:none #!codereview: mieszko.zielinski Change 3303785 on 2017/02/15 by jason.bestimt@Jason.Bestimt_Dev-General #ORION_MAIN - Merge 38.3 @ CL 3303224 #RB:none #Tests:none #!ROBOMERGE-SOURCE: CL 3303718 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) #!ROBOMERGE-SAYS: Unresolved conflicts. jason.bestimt, please merge this change by hand. //Orion/Dev-General/OrionGame/Content/UI/DeckBuilder/DeckBuilderRoot.uasset - can't integrate exclusive file already opened //Orion/Dev-General/OrionGame/Content/UI/Master_Layouts/FrontEnd.uasset - can't integrate exclusive file already opened #!codereview: jason.bestimt Change 3302382 on 2017/02/14 by Alexis.Matte@amatte-orion-dev-general Fix import of morph target when there is no animation #jira UE-41383 #jira OR-35859 #rb none #test none Change 3301538 on 2017/02/14 by Jason.Bestimt@ROBOMERGE_ORION_Dev_General #!ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 38.3 @ CL 3301392 #RB:none #Tests:none #!ROBOMERGE-SOURCE: CL 3301481 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3299985 on 2017/02/13 by Lukasz.Furman@Lukasz.Furman_T7320_OrionStream added time limit to "get out of overlap" move for minons to avoid getting stuck in moving to inaccessbile spots #jira OR-35834 #rb Mieszko.Zielinski #tests PIE Change 3299732 on 2017/02/13 by Mieszko.Zielinski@mieszko.zielinski_T4675_Orion Tweaked the way EQS tests of negative score get normalized #UE4 #rb none #test golden path + math #!codereview Lukasz.Furman, John.Abercrombie Change 3299724 on 2017/02/13 by Mieszko.Zielinski@mieszko.zielinski_T4675_Orion Generic AI interface extensions #UE4 Mostly getters #rb none #test golden path Change 3299717 on 2017/02/13 by Mieszko.Zielinski@mieszko.zielinski_T4675_Orion A little tweak to VisLog's point labels drawing - if there's only one point in a set it will no longer append '_0' to the label #UE4 #rb none #test PIE Change 3299527 on 2017/02/13 by Paul.Moore@OrionWorkspace_Dev-General #orion #mms - Update libWebSockets binaries to fix Linux server web socket connections. #tests matchmaking, mms #rb none Change 3299278 on 2017/02/13 by David.Ratti@David.Ratti_G6218_Orion.Dev-General Ability Task Pass: tasks should not broadcast out (back into ability graph) if the owning ability has completed EndAbility. #rb none #tests pie, golden path Change 3297884 on 2017/02/10 by Paul.Moore@OrionWorkspace_Dev-General #mms - Enable SSL module for PS4 (needed by OpenSSL when using WebSockets). - Turn on verbose logging for WebSockets module for initial MMS debugging. #tests PS4 #rb none Change 3296911 on 2017/02/10 by John.Pollard@John.Pollard_T2802_Orion_DevGeneral Encode user search string so we support special characters #rb RyanG #tests Replays Change 3296746 on 2017/02/10 by Jason.Bestimt@ROBOMERGE_ORION_Dev_General #!ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 38.3 @ CL 3296659 #RB:none #Tests:none #!ROBOMERGE-SOURCE: CL 3296735 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3296705 on 2017/02/10 by Daniel.Lamb@daniel.lamb_T3905_6612 Added support to the cooker for iterating shared builds. #rb Not used yet #test Fast cook paragon Change 3295747 on 2017/02/09 by Paul.Moore@OrionWorkspace_Dev-General #orion #mms - Integrated WS upgrade header functionality with latest Fortnite libws changes. - Added "ws" and "wss" protocols to web socket manager context. #rb rob.cannaday #!codereview rob.cannaday, james.hopkin #tests win64, ps4 Change 3295579 on 2017/02/09 by John.Pollard@John.Pollard_T2802_Orion_DevGeneral Fix for replay backward compatibility from John.Pollard #tests #rb na Merging using OrionScratchReleaseMapping Change 3295506 on 2017/02/09 by Rolando.Caloca@rolando.caloca_T3903_OrionMainS O - Added option for force recompute tangents using skin cache #rb none #jira UE-41541 #tests Editor run, toggle, restart Change 3295461 on 2017/02/09 by Lukasz.Furman@Lukasz.Furman_T7320_OrionStream fixed huge interpolation times for linear network smoothing on stationary characters, fixed mismatch in movement Base between NavWalking server and Walking client, causing some stationary characters to float in midair copy of CL# 3295439 #jira OR-35664, OR-35572 #rb none #tests game Change 3294954 on 2017/02/09 by Paul.Moore@OrionWorkspace_Dev-General #orion #mms - Integrating Fortnite WebSocket changes into Orion that fixes some win10 issues. #!codereview rob.cannaday, james.hopkin #tests compile ps4, linux, win64 #rb none Change 3294947 on 2017/02/09 by Daniel.Lamb@daniel.lamb_T3905_6612 The generate stub return result is considered as success when saving cooked packages. Fixes bug with cooking blueprint nativized packages. #rb Trivial #test Cook paragon Change 3293307 on 2017/02/08 by Andrew.Grant@andrew.grant.T6730.orion.floating Fix for issue in last checkin - need to clear activecontext regardless #rb none #tests solo smoke with nullrhi Change 3293284 on 2017/02/08 by Ryan.Gerleve@Ryan.Gerleve_T3703_Orion Allow setting the per-frame time limit for processing queued bunches separately for instant replays, since they may have more strict timing/framerate requirements. #rb john.pollard #tests golden path Change 3293148 on 2017/02/08 by Andrew.Grant@andrew.grant.T6730.orion.floating Fixed invalid memory access* with nullrhi and suppressed IME warning if no valid window handle exists (*Likely only an issue when running with memory validation) #rb none #tests verified invalid access exception no longer occurs with nullrhi #!review-3293149 @Matt.Khulenschmidt Change 3293103 on 2017/02/08 by Max.Chen@Max.Chen_T4664_Orion_Main Sequencer: Fix build #jira OR-34918 #rb none #tests none Change 3292921 on 2017/02/08 by Max.Chen@Max.Chen_T4664_Orion_Main Sequencer: Force local player to maintain x fov axis. #jira OR-34918 #rb david.ratti #tests Render/PIE a level sequence and test that the camera isn't zoomed in. Change 3292869 on 2017/02/08 by David.Ratti@David.Ratti_G6218_Orion.Dev-General Yet more logging for OR-35448 #rb #tests none Change 3292821 on 2017/02/08 by Jason.Bestimt@ROBOMERGE_ORION_Dev_General #!ROBOMERGE-AUTHOR: rob.cannaday PS4 libwebsockets build fix Update build cs files to point to PS4 file location Copy libwebsocket include directory from Fortnite to Orion #rb paul.moore #tests compile/link Win64 Development Editor, PS4 Debug, Linux Development Server #!ROBOMERGE-SOURCE: CL 3292820 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3292277 on 2017/02/08 by Jason.Bestimt@ROBOMERGE_ORION_Dev_General #!ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge DMM @ CL 3292219 #RB:none #Tests:none [CODEREVIEW] paul.moore, benjamin.crocker #QAReview #!ROBOMERGE-SOURCE: CL 3292276 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3292211 on 2017/02/08 by Andrew.Grant@andrew.grant.T6730.orion.floating Pulling new ags library from Release-4.15 and reverting hack that disabled feature for AMD users #rb Marcus.Wassmer #tests compiled Change 3292167 on 2017/02/08 by David.Ratti@David.Ratti_G6218_Orion.Dev-General Additional logging for OR-35448 #rb none #tests pie Change 3289462 on 2017/02/06 by Ben.Salem@ben.salem_OrionMain Adding priority filters to Automation tests, also commands to filter on priority levels. #rb adric worley #tests Compiled, ran a few commands to verify it works. Change 3288801 on 2017/02/06 by Jason.Bestimt@ROBOMERGE_ORION_Dev_General #!ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 37.2 (38.3) @ CL 3288681 #RB:none #Tests:none #!ROBOMERGE-SOURCE: CL 3288800 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3288750 on 2017/02/06 by Daniel.Lamb@daniel.lamb_T3905_6612 Fixed issue when cooking client and server platforms in single cook some packages would be marked incorrectly because they would be stripped when from client / server. #rb Andrew.Grant #test Cook paragon Change 3288624 on 2017/02/06 by Andrew.Grant@andrew.grant.T6730.orion.floating Unlocked network version #rb #tests na OR-35603 Change 3288612 on 2017/02/06 by Daniel.Lamb@daniel.lamb_T3905_6612 Added more ini settings to the iterative ini blacklist. #rb Trivial #test Iterative Cook Paragon Change 3288184 on 2017/02/06 by Andrew.Grant@andrew.grant.T6730.orion.floating Downgraded warning to display #!review-3288185 @David.Ratti #rb none #tests none Change 3287634 on 2017/02/06 by Jason.Bestimt@ROBOMERGE_ORION_Dev_General #!ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 37.2 @ 3287498 #RB:none #Tests:none #!ROBOMERGE-SOURCE: CL 3287619 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3286668 on 2017/02/03 by Alexis.Matte@amatte-orion-dev-general Fix a crash when importing a LOD containing different material with less sections #rb none #test none Change 3286112 on 2017/02/03 by Alexis.Matte@amatte-orion-dev-general Fix the re-import skeletal mesh regression, where all material disapear. #jira UE-41294 #rb matt.kuhlenschmidt #test see the jira Change 3285859 on 2017/02/03 by Daniel.Lamb@daniel.lamb_T3905_6612 Fixed merge error from last checkin with the DDC commandlet #!codereview Matthew.Griffin #test DDC commandlet paragon #rb None Change 3285637 on 2017/02/03 by Ryan.Gerleve@Ryan.Gerleve_T3703_Orion Pass in the DemoNetDriver pointer to the ConcurrentWithSlateTickTask instead of accessing it from the world in the task itself. #rb john.pollard #tests golden path Change 3285479 on 2017/02/03 by Mieszko.Zielinski@mieszko.zielinski_T4675_Orion Made bot communicate ults when they're up, not when they're using it #Orion CL also contains a bit of code shuffling around, preparing ground for HTN plug in #rb none #test golden path Change 3285125 on 2017/02/03 by Jason.Bestimt@ROBOMERGE_ORION_Dev_General #!ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 37.2 @ CL 3285078 #RB:none #Tests:none #!ROBOMERGE-SOURCE: CL 3285124 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3283996 on 2017/02/02 by Michael.Trepka@Michael.Trepka_PC_Orion-Dev-General Added UGameUserSettings::GetRecommandedResolutionScale() to replace UOrionGameUserSettings::GetDefaultResolutionScale(). This makes things less confusing (UGameUserSettings::GetRecommandedResolutionScale() returns scale recommended based on results of the benchmark and UGameUserSettings::GetDefaultResolutionScale() returns scale based on user settings) and fixes a regression introduced in 3257936 (OR-35544) #rb Cody.Haskell #tests Tested on PC Change 3283951 on 2017/02/02 by Daniel.Lamb@daniel.lamb_T3905_6612 Ensure DDC commandlet calls begincacheforcookedplatformdata correctly. #rb None #!codereview Matthew.Griffin #test DDC commandlet paragon. Change 3283874 on 2017/02/02 by Lina.Halper@Lina.Halper_Orion fix for invalid resource issue #rb: none #code review: Daniel.Wright #tests: compile and editor with wolf Change 3283621 on 2017/02/02 by Laurent.Delayen@laurent.delayen_Work2016_Orion Femme WIP whip aiming for Q ability. #rb none #tests Femme Change 3283216 on 2017/02/02 by jason.bestimt@Jason.Bestimt_Dev-General #ORION_MAIN - Merge 37.2 @ CL 3282900 #RB:none #Tests:none #!ROBOMERGE-SOURCE: CL 3283199 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3282954 on 2017/02/02 by Lina.Halper@Lina.Halper_Orion It becomes invalid on the resource, so checking null, but still wip on verifying this with Daniel Wright. He's sick out. #rb:none #tests: compile #code review:Daniel.Wright #Jira: OR-35418 Change 3281993 on 2017/02/01 by Daniel.Lamb@daniel.lamb_T3905_6612 Removed default unattended flag. #rb Trivial #test PS4 cook run paragon. Change 3281990 on 2017/02/01 by Daniel.Lamb@daniel.lamb_T3905_6612 Potential fix for deterministic cooking issue with UMovieSceneSignedObjects. #rb Andrew.Grant #!codereview Max.Preussner #test Cook and run paragon ps4. Change 3281610 on 2017/02/01 by Laurent.Delayen@laurent.delayen_Work2016_Orion AimOffsetLookAt is now thread safe. #rb lina.halper #tests femme Change 3281609 on 2017/02/01 by Laurent.Delayen@laurent.delayen_Work2016_Orion Fixed 'Convert to AimOffset LookAt' option being broken in Persona. #rb lina.halper #tests works for Femme now. Change 3281019 on 2017/02/01 by Jason.Bestimt@ROBOMERGE_ORION_Dev_General #!ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 37.2 @ CL 3280498 #RB:none #Tests:none #!ROBOMERGE-SOURCE: CL 3281018 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3280813 on 2017/02/01 by Jason.Bestimt@ROBOMERGE_ORION_Dev_General #!ROBOMERGE-AUTHOR: matthew.griffin Prevent inclusion of NotForLicensees files when staging CrashReportClient config files #rb none #tests none #!ROBOMERGE-SOURCE: CL 3280812 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3279921 on 2017/01/31 by Yanni.Tripolitis@yanni.tripolitis_Dev_General_Cary Fixed an error in the Round MF, that was somehow "leaked" into Paragon from Odin. #lockdown Billy.Rivers, Adam.Bellefeuil #!codereview Tim.Elek Change 3279178 on 2017/01/31 by Daniel.Lamb@daniel.lamb_T3905_6612 Fixed up diff files commandlet stack information #rb Joe.Conley #test Diff cooked packages Change 3279084 on 2017/01/31 by Andrew.Grant@andrew.grant.T6730.orion.floating Merging //UE4/Main at 3276432 through Orion-Staging #rb #tests na Change 3279078 on 2017/01/31 by Jason.Bestimt@ROBOMERGE_ORION_Dev_General #!ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 37.2 @ CL 3279032 #RB:none #Tests:none #!ROBOMERGE-SOURCE: CL 3279077 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3277908 on 2017/01/30 by Jason.Bestimt@ROBOMERGE_ORION_Dev_General #!ROBOMERGE-AUTHOR: jason.bestimt #ORION_37 - Fix for "-game" crash with missing meta data #RB:none #Tests:none [CodeReviewed]: andrew.grant, jamie.dale, mieszko.zielinski #!ROBOMERGE-SOURCE: CL 3277901 in //Orion/Release-37/... via CL 3277902 via CL 3277904 via CL 3277905 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3277520 on 2017/01/30 by Andrew.Grant@andrew.grant.T6730.orion.floating Workaround for OR-35418 #!ROBOMERGE: Main #rb none #tests verified ShortSoloGame test completes without a crash Change 3277357 on 2017/01/30 by Daniel.Lamb@daniel.lamb_T3905_6612 Fixed the rebuild lighting commandlet. #rb Trivial #test Rebuild lighting dev general Change 3277322 on 2017/01/30 by Jason.Bestimt@ROBOMERGE_ORION_Dev_General #!ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 37.2 @ CL 3277275 #RB:none #Tests:none #!ROBOMERGE-SOURCE: CL 3277296 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3277210 on 2017/01/30 by Jason.Bestimt@ROBOMERGE_ORION_Dev_General #!ROBOMERGE-AUTHOR: andrew.grant Non-shipping test changes: Fixed issue where with -stdout messages would be duplicated due to FeedbackContextAnsi echoing to stdout by default Changed stdout output to postfix instead of trail newlines Firstpass of finding and displaying crash callstacks in Orion Test Framework. #rb none #tests ran test framework with tests that purposefully crashed/checked #!ROBOMERGE-SOURCE: CL 3276889 in //Orion/Release-37/... via CL 3277207 via CL 3277208 via CL 3277209 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3276774 on 2017/01/29 by Andrew.Grant@andrew.grant.T6730.orion.floating Fix for non-unity issue. #tests compiled #rb none #!ROBOMERGE: Main, DUI Change 3276594 on 2017/01/28 by Lina.Halper@Lina.Halper_Orion Checked in potential fix for nonunity build issue #rb:none #tests:compile Change 3275806 on 2017/01/27 by Ben.Salem@ben.salem_OrionMain Adding in a checkpointing system for automated test passes where, if a client crashes while running a pass, on reboot and reissue of the automation command the test pass will start off where it left off, skipping the crashing test. #rb clayton.langford #tests Ran several dozen test passses. Seriously. #!codereview steve.white, bob.ferreira, clayton.langford, adric.worley Change 3275803 on 2017/01/27 by Shaun.Kime@shaun.kime_RDU-WD-9788_oriondevgen Paragon has retainer widgets with no World set. When encountered, they can cause the scene list to be desynchronized with the rendering thread. This logic resolves the issue by registering a null scene in this case, properly setting the slate scene index for subsequent slate draw calls. #rb nick.darnell #jira OR-34919 #TESTS na Change 3275533 on 2017/01/27 by Max.Chen@Max.Chen_T4664_Orion_Main Sequencer: Switch to static pointer to fix crash when tearing down curve editor. #jira UE-40796 #rb andrew.rodham #tests none Change 3275093 on 2017/01/27 by Jason.Bestimt@ROBOMERGE_ORION_Dev_General #!ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 37.2 @ CL 3273298 #RB:none #Tests:none #!ROBOMERGE-SOURCE: CL 3273417 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3274700 on 2017/01/26 by Lina.Halper@Lina.Halper_Orion #Anim curve crash on cooking - fixed crash during cooking while accessing default value of material - this code doesn't have to run during cooking with inactive world, so I'm checking that #code review: Daniel.Wright, Chris.Bunner, Jurre.DeBaare #rb: none #tests: cooking Change 3274129 on 2017/01/26 by Lina.Halper@Lina.Halper_Orion Fixed safer to get featurelevel #rb: Daniel.Wright #tests: compile/wolf Change 3274012 on 2017/01/26 by Lukasz.Furman@Lukasz.Furman_T7320_OrionStream fixed crash in navigation grids #jira OR-35356 #rb none #tests PIE Change 3273803 on 2017/01/26 by Lina.Halper@Lina.Halper_Orion Fixed issue with animation curve getting reset to 0.f - the issue is that skeleton contains material flag types, so now it just keeps setting the value - even after I fix validation check, it still cleared it due to the material curve not found anymore, so added to support default value setting #jira: OR-34563 #rb: Martin.Wilson, Chris.Bunner, Benn.Gallagher #code review: Martin.Wilson, Daniel.Wright #tests: wolf, coil Change 3273257 on 2017/01/26 by Alexis.Matte@amatte-orion-dev-general Isolate by material slot instead of section index. Add UI to isolate and highlight material in the material panel #rb matt.kuhlenschmidt #jira UE-41131 #tests none Change 3272527 on 2017/01/25 by Jason.Bestimt@ROBOMERGE_ORION_Dev_General #!ROBOMERGE-AUTHOR: chris.bunner Ensure FSceneRenderTargets snapshot copies default clear colors. #tests Golden path on lowest and high settings #rb None #lockdown Jason.Bestimt #jira OR-34905 #!ROBOMERGE-SOURCE: CL 3272507 in //Orion/Release-37.1/... via CL 3272521 via CL 3272525 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3272244 on 2017/01/25 by Rolando.Caloca@rolando.caloca_T3903_OrionMainS Show more info when a material instance failed to compile #jira OR-34626 #tests Forced crash in the debugger #rb Daniel.Wright Change 3272109 on 2017/01/25 by Jason.Bestimt@ROBOMERGE_ORION_Dev_General #!ROBOMERGE-AUTHOR: philip.buuck Fix bad merge from Main #rb Dan.Hertzka #tests PIE [CodeReviewed] Andrew.Grant #lockdown Andrew.Grant #!ROBOMERGE-SOURCE: CL 3272106 in //Orion/Release-37.1/... via CL 3272107 via CL 3272108 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3271721 on 2017/01/25 by Lukasz.Furman@Lukasz.Furman_T7320_OrionStream jungle minions will spawn navigation obstacles when they are stuck in static geometry, fixed issues with falling off cliffs #jira OR-35054 #rb Mieszko.Zielinski #tests PIE Change 3271432 on 2017/01/25 by Jason.Bestimt@ROBOMERGE_ORION_Dev_General #!ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 37.2 @ CL 3271043 #RB:none #Tests:none #!ROBOMERGE-SOURCE: CL 3271429 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) [CL 3322856 by Andrew Grant in Main branch]
2017-02-25 19:37:22 -05:00
Args += String.Format("{0} -server -abslog={1} -log -Messaging", Map, CommandUtils.MakePathSafeToUseWithCommandLine(ServerLogFile));
if (Params.Unattended)
{
Args += " -unattended";
}
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3431384) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3252833 on 2017/01/10 by Ori.Cohen Refactor constraint so that it can be used for external solvers. (Copying //Tasks/UE4/Dev-ImmediateModePhysics to Dev-Framework (//UE4/Dev-Framework)) Change 3256288 on 2017/01/12 by Ori.Cohen Undo constraint refactor as we found a way around it and it made the code much harder to read/debug Change 3373195 on 2017/03/30 by Mike.Beach For nativization, changing it so we key off of the target platform-info struct instead of the platform (in preparation for defining the nativized plugin's platform whitelist). Change 3381178 on 2017/04/05 by Dan.Oconnor Make sure we don't inherit the NATIVE func flag when generating skeleton functions, also make sure all bojects outer'd to the skeleton class are marked transient #jira UE-43616 Change 3381532 on 2017/04/05 by Marc.Audy (4.16) Fix various cases where built lighting on child actors could be lost when loading a level #jira UE-43553 Change 3381586 on 2017/04/05 by Mike.Beach Now generating TArrayCaster conversions for nativized UClass arrays that need it (to handle different TSubclassOf arrays). #jira UE-42676, UE-43257 Change 3381682 on 2017/04/05 by mason.seay Some more changes to test map Change 3381844 on 2017/04/05 by Dan.Oconnor Match existing logic for CPF_ReturnParm/CPF_OutParm. Fixes compilation error in BP_TurbineBlades when using compilation manager Change 3382054 on 2017/04/05 by Zak.Middleton #ue4 - Optimize CharacterMovementComponent::GetPredictionData_Client_Character() and GetPredictionData_Server_Character() to remove virtual calls. #jira UE-30998 Change 3382703 on 2017/04/06 by Lukasz.Furman fixed missing links between navmesh polys when there are more than 4 neighbor connections #jira UE-43524 Change 3383357 on 2017/04/06 by Marc.Audy (4.16) Make SetHiddenInGame propagate consistently with SetVisibility #jira UE-43709 Change 3383359 on 2017/04/06 by Dan.Oconnor Fix last errant SKEL reference when cooking Odin Change 3383591 on 2017/04/06 by Mike.Beach Prevent users from setting object variables as 'config' properties (disallowed by UHT). This prevents some errors that could happen later when users nativize the Blueprint. #jira UE-42085 Change 3384762 on 2017/04/07 by Zak.Middleton #ue4 - Fix SpringArmComponent not restoring relative transform when bUsePawnControlRotation is turned off. Fixes the editor interaction ignoring transform of the component in the viewport after bUsePawnControlRotation is toggled on then off, since by then the world transform had been overwritten (from tick in editor) and nothing would drive transform changes from the editable value. Toggling bUsePawnControlRotation off at runtime now restores the rotation to the initial relative rotation, not stomping it with the current pawn rotation, allowing toggling between the editable/desired base rotation and the control rotation. #jira UE-24850 Change 3384948 on 2017/04/07 by Dan.Oconnor Prevent GForceDisableBlueprintCompileOnLoad from causing all sorts of badness when dependencies are loaded as part of a Diff operation. Instead of setting a global flag we flag the package as LOAD_DisableCompileOnLoad Change 3385267 on 2017/04/07 by Michael.Noland Graph Editing: Pushed some node diffing code down from UAIGraphNode into UEdGraphNode so nodes with details panel properties will diff correctly (e.g., various animation nodes and BP switch nodes) #jira UE-21724 Change 3385473 on 2017/04/07 by Phillip.Kavan #jira UE-43067 - Fix broken pin wires after an Expand Node operation, along with some misc. cleanup. Change summary: - Fixed to use correct string for "Expand Node" transaction name. - Modified FBlueprintEditor::OnExpandNodes() to consolidate some redundant code. - Fixed to generate a unique node GUID for cases where the source graph is not removed after expansion. Change 3385583 on 2017/04/07 by Dan.Oconnor Handle CreatePropertyOnScope nullptr return values (happens for structs missing a struct property) #jira UE-43746 Change 3386581 on 2017/04/10 by Michael.Noland Blueprints: Further hardening FBlueprintActionInfo::GetOwnerClass() #jira UE-43824 Change 3386615 on 2017/04/10 by Marc.Audy Instanced properties can now properly be set on a per-instance basis in blueprint added components. #jira UE-42066 Change 3387000 on 2017/04/10 by Marc.Audy Fix includes for CIS Change 3387229 on 2017/04/10 by mason.seay More changes to TM-Gameplay Added Save Game test (with blueprint) Tick Interval test (with blueprint) BP logic cleanup Level organization Change 3388437 on 2017/04/11 by Mike.Beach Adding support for map/set literals in the backend (so you can use set nodes for structs containing sets/maps, without having to connect a RHS input - resets to struct defaults). #jira UE-42617 Change 3388532 on 2017/04/11 by mason.seay Submitting latest changes for crash repro Change 3389026 on 2017/04/11 by Ben.Zeigler Performance and bug fixes for incremetal cooking with asset registry, duplicate of several changes made on //Fortnite/Main Fix it so AssetRegistry.ScanPathsAndFilesSynchronous won't scan subdirectories inside already scanned directories, this cuts down on the number of cache files Fix 2 second stall when shutting down AssetSourceFilenameCache if it had never been previously created Change 3389163 on 2017/04/11 by Ben.Zeigler #jira UE-42922 Fix it so connecting function input node output pins does not clear default value, we only want to clear the value when connecting an input pin. Properly testing this fix depends on UE-43883 Change 3389205 on 2017/04/11 by Marc.Audy Protect against a handful of GEditor usages that can now be hit in standalone Change 3389220 on 2017/04/11 by Marc.Audy Don't borrow ClassWithin to masquerade as ParentClass during compilation and instead just set the super struct immediately Change 3389222 on 2017/04/11 by Michael.Noland Framework: Adding a cvar (t.TickComponentLatentActionsWithTheComponent) to allow users to revert to the old behavior on when component latent actions tick - Non-zero values behave the same way as actors do, ticking pending latent action when the component ticks, instead of later on in the frame (default behavior in 4.16 and beyond) - Prior to 4.16, components behaved as if the value were 0, which meant their latent actions behaved differently to actors This CVar will be removed in a future version, defaulting to on #jira UE-43661 Change 3389276 on 2017/04/11 by Marc.Audy Spelling fix and NULL to nullptr Change 3389303 on 2017/04/11 by Mieszko.Zielinski Made sure AIController::Posses doesn't get called when compiling Pawn BP #UE4 #jira UE-43873 Change 3390215 on 2017/04/12 by mason.seay Removed some tests, will need further review Change 3390638 on 2017/04/12 by Mike.Beach Generalizing the omission of the CoerceProperty (in EmitTerm) - previously we were only omitting properties for our custom array lib. For wildcards, a coerce property should not be used as its type will not match. NOTE: There is a slight behavior change in UEdGraphSchema_K2::ConvertPropertyToPinType(), as it will return 'wildcard' for params marked as 'ArrayTypeDependentParams' (previously would have returned 'int'). #jira UE-42747 Change 3390774 on 2017/04/12 by Ben.Zeigler #jira UE-43911 Fix several issues with saving a runtime asset registry containing redirectors that caused crashes in cook on the fly. Don't resolve redirectors on incoming links because it will make a circular link, and fix an issue where chained redirectors would break the for loop iteration and return a bad dependency Fix it so the asset registry written out at the beginning of CookOnTheFly uses the registry generator, otherwise it will include all of the stripped editor only tags Change 3390778 on 2017/04/12 by Ben.Zeigler Fix UCookOnTheFlyServer::CollectFilesToCook to check for initial unsolicited packages up front. This is required in iterative mode because it may skip cooking all explicit packages and thus miss a new startup loaded package Change 3390782 on 2017/04/12 by Ben.Zeigler Change RunProjectCommand to not imply -nomcp, and allow reading -clientcmdline to override setting the map parameter to 127.0.0.1 by default Fix RunProjectCommand to remove ios-specific checks to not pass weird platform parameters, and instead never pass them Fix PS4Platform to pass along command line when calling build cook run, args needs to be the last parameter so explicitly set -target= Change 3390859 on 2017/04/12 by Mike.Beach T3D class fields now export with the class's fully qualified path name (to avoid abiguity). Since we can have multiple classes with the same name (Blueprints in different folders), we have to use the class's fully qualified object path. #jira UE-28048 Change 3390914 on 2017/04/12 by Lukasz.Furman fixed missing navlink component's transform in exported navigation data #jira UE-43688 Change 3391122 on 2017/04/12 by Ben.Zeigler Add new PreloadPrimaryAssets call to AssetManager that stream the desired assets without modifying the official load/unload state. This is useful if you want to preload things in case the might be used in the future, and it also supports recursion Fix crash calling GetAssetDataForPath with null path Change 3391494 on 2017/04/12 by Dan.Oconnor Fix bad references in deep object (widget) hierarchies #jira UE-43802 Change 3391529 on 2017/04/12 by Dan.Oconnor Fix log spam, accidently submitted #rnx Change 3391756 on 2017/04/12 by Dan.Oconnor LinkExternalDependencies needs to be performed before we RefreshVariables #jira UE-43843 Change 3392542 on 2017/04/13 by Marc.Audy Ensure that initialized actors get cleaned up when removed from world even if that world hasn't begun play. #jira UE-43879 Change 3392746 on 2017/04/13 by Marc.Audy (4.16) When duplicating a blueprint node, correctly make the new node a sibling of the duplicated node, not a child of it (unless duplicating the root component). Also resets scale of a duplicated root component to 1 to avoid a squaring of the scale for that component. #jira UE-40218 #jira UE-42086 Change 3393253 on 2017/04/13 by Dan.Oconnor Make sure calculated meta data is correctly set on functions generated by the compilation manager (SKEL_ class functions) #jira UE-43883 Change 3393509 on 2017/04/13 by Mike.Beach Removing hack'ish ResetLoaders() call that was causing undesired side-effects (resetting of a loaded package that other objects were relying on). This was originally intended to release file handles so separate editor processes could make updates and save the file (from CL 1712376). Using ResetLoaders() for this is bad though, as it has too many side effects. Instead we have to wait for GC to run. This also makes sure that GC should run as intended as the CookOnTheFly sever is idling. #jira UE-37284 Change 3394350 on 2017/04/14 by Michael.Noland Core: Making FDateTime and FTimespan actually reflected, so they get duplicated properly in CopyPropertiesForUnrelatedObjects, etc... #jira UE-39921 Change 3395985 on 2017/04/17 by Phillip.Kavan #jira UE-38280 - Fix invalid custom type selections on member fields in the User-Defined Structure Editor after a reload. Change summary: - Ensure that the 'SubCategoryObject' member in a UDS variable descriptor has been loaded when converting to an FEdGraphPinType. Change 3396152 on 2017/04/17 by Marc.Audy TickableGameObjects that have IsTickableInEditor false should not tick in the editor #jira UE-40421 Change 3396279 on 2017/04/17 by Phillip.Kavan #jira UE-43968 - Fix failed validation of bitmask enum types when serializing bitmask literal nodes. Change 3396299 on 2017/04/17 by Dan.Oconnor Fix resintancing issues exposed by running TM-Gameplay with -game. We cannot reinstance actors in levels on load because the scene is not created. #jira UE-43859 Change 3396712 on 2017/04/17 by Marc.Audy Call PostLoad on subobjects before copying for unrelated properties to avoid cases where an out of date object patched over in the linker has not been brought up to date #jira UE-38234 Change 3396718 on 2017/04/17 by Mike.Beach Adding a search bar to the components tree for Blueprints. #epicfriday #jira UE-17620 Change 3396999 on 2017/04/17 by Mike.Beach In generated code, call event '_Implementation' functions directly for interface functions being invoked on self (avoids a UHT runtime error). #jira UE-44018 Change 3397700 on 2017/04/18 by Marc.Audy UT struct BlueprintType fixups Change 3397701 on 2017/04/18 by Marc.Audy Odin struct BlueprintType fixups Change 3397703 on 2017/04/18 by Marc.Audy Ocean struct BlueprintType fixups Change 3397704 on 2017/04/18 by Marc.Audy WEX struct BlueprintType fixups Change 3397705 on 2017/04/18 by Marc.Audy Additional UT blueprint type struct fixups Change 3397706 on 2017/04/18 by Marc.Audy Fortnite struct BlueprintType fixups Change 3397708 on 2017/04/18 by Marc.Audy Fixup Engine BlueprintType markup of structs Change 3397709 on 2017/04/18 by Marc.Audy Sample Game struct BlueprintType fixups Change 3397711 on 2017/04/18 by Marc.Audy Mark AnimNodes as BlueprintType and BlueprintInternalUseOnly Change 3397712 on 2017/04/18 by Marc.Audy Paragon struct BlueprintType fixups Change 3397735 on 2017/04/18 by Marc.Audy Definition pieces of BlueprintInternalUseOnly to fix UHT errors with structs already marked to use it Change 3397912 on 2017/04/18 by Mike.Beach Fix for CIS warnings about shadowed variables (fallout from CL 3396718). Change 3398455 on 2017/04/18 by Marc.Audy Make less critical errors log an error rather than immediately throwing allowing multiple errors to be reported in the same compile Change 3398491 on 2017/04/18 by Marc.Audy BPRW/BPRO in a non-BlueprintType is now a UHT error Change 3398539 on 2017/04/18 by Marc.Audy Fixup live link struct markups Change 3399412 on 2017/04/19 by Marc.Audy Fix Match3 blueprint type struct markups Change 3399509 on 2017/04/19 by Phillip.Kavan #jira UE-38574 - Fix AnimBlueprint function graphs marked as 'const' to treat 'self' as read-only when compiling. Change summary: - Modified FKismetCompilerContext::ProcessOneFunctionGraph() to use the function graph schema rather than the compiler context schema for both the function context's schema as well as testing the function for 'const'-ness. For AnimBPs, the compiler context and the function graph context can differ, so we need to make sure we are using the right one when making queries for a specific function context during compilation. - Minor cleanup: changed the function context schema to be 'const' in order to be consistent with the function graph GetSchema() API's result. Added a few 'const' qualifiers where needed to match. - Added a new object version in order to avoid breaking compilation of existing AnimBP function graphs that may already be violating the 'const' rule (this is the same thing that was done when 'const' was first added to "normal" BP function graphs). Just as with normal function graphs in place before the addition, a warning will be generated for existing AnimBP function graphs if they violate 'const' correctness, and an error will be generated for all new ones. Change 3399749 on 2017/04/19 by Mike.Beach Hiding the Nativized Blueprints plugin from the in-editor browser (prevent users from disabling it). Change 3399774 on 2017/04/19 by Marc.Audy ConditionalPostLoad is already called on StaticMesh earlier in the function #rnx Change 3400313 on 2017/04/19 by Mike.Beach Mirroring CL 3398673 from 4.16 Now, with ICWYU, making sure that the coresponding header gets included first in nativized Blueprint files (else we get a UHT error). Had to fixup some ShooterGame specific files as a result (they had missing includes and forward declarations). #jira UE-44124 Change 3400328 on 2017/04/19 by Mike.Beach Missing file from mirrored change (CL 3400313 - mirroring CL 3398673 from 4.16) #jira UE-44124 Change 3400415 on 2017/04/19 by Chad.Garyet adding physx switch build to framework Change 3400514 on 2017/04/19 by Mike.Beach Back out changelist 3400313 / 3400328 (mirrored from CL 3398673 in 4.16), as it was producing "include PCH first" errors. Likely, CL 3398673 was a fix for a 4.16 specific change, altering the expected include order. We'll have to wait for this one to be integrated back. Change 3400552 on 2017/04/19 by Marc.Audy Undo the calling of post load prior to the CPFUO as dependent objects may not yet be loaded. Instead copy the need load flag to the new CDO subobject, similarly to how the top level CDO object copies its flags over. #jira UE-44150 Change 3400815 on 2017/04/19 by Marc.Audy Spelling fix (part of PR #3490) #rnx Change 3400918 on 2017/04/19 by Marc.Audy Partial pull of PR #3490: Improved remapping game controls support (Contributed by projectgheist) This portion brings in the exposure of the bindings to blueprint #jira UE-44122 Change 3401550 on 2017/04/20 by Marc.Audy fix kitedemo blueprint type markup #rnx Change 3401702 on 2017/04/20 by Mike.Beach Make it so plugins added to a project through the .uproject's 'AdditionalPluginDirectories' list get folded into the generated code project (for visual studio, etc.). Change 3401720 on 2017/04/20 by Mike.Beach Add white and black lists for target type (game, client, server, etc.) to plugin module descriptors. Change 3401725 on 2017/04/20 by Mike.Beach Whitelisting the nativized Blueprint plugin for only the targets it was built for (game, server, or client). Change 3401800 on 2017/04/20 by Ben.Zeigler Add Algo::BinarySearch, LowerBound, and UpperBound. These are setup to allow binary searching a presorted array, and allow for specifying projection and sort predicates. Convert some engine code to use it Add TSortedMap, which is a map data structure that has the same API as TMap, but is backed by a sorted array. It uses half the memory and performance is faster below n=10 Add FName::CompareIndexes so a SortedMap with FNames can be used without doing very slow string compares, and FNameSortIndexes predicate to sort by it Add code to Algo and Container tests. Split up container tests so the new ones aren't run in smoketest as they are a bit slow Add RemoveCurrent and SetToEnd to ArrayIterator Change 3401849 on 2017/04/20 by Marc.Audy Partial pull of PR #3490: Improved remapping game controls support (Contributed by projectgheist) This portion brings bug fixes and improvements to InputKeySelector UMG widgets. #jira UE-44122 Change 3402088 on 2017/04/20 by Marc.Audy Focus the search box when expanding the map value type #jira UE-44211 Change 3402251 on 2017/04/20 by Ben.Zeigler Fix issue where SortedMap needs to be resorted after serialization, because the sorting may have changed from when it was saved out Change 3402335 on 2017/04/20 by Ben.Zeigler Significant changes to FAssetData serialization and memory, cuts memory significantly but will break code that was using some of the internal API that was not properly hidden before Both Editor and Runtime cache now use the same FAssetRegistryVersion, which is now registered as a custom version Rename FAssetData and FAssetPackage operator<< to SerializeForCache to make it clear that it isn't safe to use for general serialization Remove GroupNames from FAssetData, it has not been useful since the UE4 package structure changed around 4.0 Rename generic-sounding but not actually generic SharedMapView class to AssetDataTagMapSharedView to indicate what it is actually used for Change TagsAndValues to use a new array-backed TSortedMap as the base structure instead of a hash map. Also, it only allocates the map on demand, which saves significant memory at runtime as many packages have no tags Add bFilterAssetDataWithNoTags to [AssetRegistry] ini section, if set it will only save cooked asset data if it has tags, off by default but saves significant memory if your whitelist is set up properly Fix issue where asset registry tags updated by loading assets during cook were not being reflected in the cooked registry Add AssetRegistry::GetAllocatedSize and add to MemReport output Change 3402457 on 2017/04/20 by Ben.Zeigler Enable asset registry iteration and stripping unused asset data in Fortnite. Registry iteration is already on in //Fortnite/Main, stripping is a new feature I want to test Change 3402498 on 2017/04/20 by Ben.Zeigler CIS fix. Why did this compile locally? Change 3402537 on 2017/04/20 by Ben.Zeigler Remove ensure for making AssetData for subobjects, the editor does this for thumbnail creation in some cases Change 3402600 on 2017/04/20 by Ben.Zeigler Add bShouldGuessTypeAndNameInEditor to manager settings, can be set false for games where type cannot be safely implied and content must be resaved Fix up some bool setting code inside asset manager, and fix const correctness and for iterator issues AssetManager can now discover any BlueprintCore type when bHasBlueprintClasses=true Add AssetManager.DumpAssetRegistryInfo to output detailed asset registry usage stats Add Primary Name to asset audit window by default Change 3403556 on 2017/04/21 by Marc.Audy Fix Orion input key selector override class #rnx Change 3404090 on 2017/04/21 by mason.seay Applying Forcefeedback to test map Change 3404093 on 2017/04/21 by mason.seay Changing text in level Change 3404139 on 2017/04/21 by mason.seay Added Force Feedback test and made some tweaks. Change 3404146 on 2017/04/21 by mason.seay Added source reference to Instanced Variable test Change 3404154 on 2017/04/21 by mason.seay More minor tweaks Change 3404155 on 2017/04/21 by Marc.Audy Remove auto #rnx Change 3404188 on 2017/04/21 by Marc.Audy Fixed crash changing variable type when any type other than map #jira UE-44249 #rnx Change 3404463 on 2017/04/21 by Ben.Zeigler Fix asset data code to not ensure when loading an object with invalid exports, and instead print warning with name of package that needs to be resaved Resave a map that had a redirector from a DIFFERENT package saved in it's exports. I do not understand how this happened, but it appears to be related to the lightmap BuiltData transition when old maps are opened Change 3404465 on 2017/04/21 by Ben.Zeigler Fix issue with trying to load editor-only asset classes in a cooked build Fix issues with renaming or changing template Ids of assets from the editor Always print the Duplicate Asset ID error, as if you have more than one the ensuremsg only goes off once Change 3404481 on 2017/04/21 by Dan.Oconnor Remove unneeded walk up hierarchy - prevent stale entries in action database if we compile a BP but don't compile its children Change 3404510 on 2017/04/21 by Phillip.Kavan #jira UE-35727 - Collapsed graphs containing a local variable node will no longer cause a compile error when the parent graph is renamed. Change 3404590 on 2017/04/21 by Michael.Noland Editor: Fixed incorrect filtering of abstract/deprecated UDeveloperSettings and UContentBrowserFrontEndFilterExtension classes caused by a typo (HasAnyCastFlags versus HasAnyClassFlags) Change 3404593 on 2017/04/21 by Marc.Audy Fixed another crash to do with input pin secondary combo box #jira UE-44269 #rnx Change 3404600 on 2017/04/21 by Michael.Noland Core: Allow UE_GC_TRACK_OBJ_AVAILABLE to be set externally #rnx Change 3404602 on 2017/04/21 by Michael.Noland Engine: Switched from an include to a forward declaration of SWidget in UDeveloperSettings to keep it slim #rnx Change 3404608 on 2017/04/21 by Michael.Noland Core: Marked TNumericLimits as constexpr so they can be used in static asserts Change 3404659 on 2017/04/21 by Michael.Noland Engine: Adding includes back to two UDeveloperSettings subclasses Change 3405289 on 2017/04/24 by Marc.Audy Remove auto #rnx Change 3405446 on 2017/04/24 by Marc.Audy Fix Win32 unsigned compile issue Change 3405512 on 2017/04/24 by Mike.Beach Piping through NativizationOptions to filename generation (so we're able to gen different files names per target: client vs. server). Change 3406080 on 2017/04/24 by Ben.Zeigler Deprecate UEngine::OnPostEngineInit and move to FCoreDelegates, clean up comments for the initialization delegates Call OnPostEngineInit from commandlet initialization as well as normal execution. I thought about making a wrapper function, but the commandlet calls EditorInit directly so it wouldn't work Bind delegate to refresh the AssetRegistry native class hierarchy after engine init so it picks up game/plugin classes. Undo ini change that was required to hack around this Change 3406381 on 2017/04/24 by Ben.Zeigler #jira UE-23768 Enable Run Physics With No Controller for montage test pawn. The montage pawn has no controller so wasn't correctly running physics when the root motion stopped. This flag needs to be set to allow it to correctly stop after the montage is over Change 3406438 on 2017/04/24 by Ben.Zeigler Fix deprecation warning Change 3406519 on 2017/04/24 by Phillip.Kavan #jira UE-43612 - Suppress array "Get" node fixup notifications on load when the BP Compilation Manager is enabled. Change summary: - Wrapped BPCM calls to FBlueprintEditorUtils::ReconstructAllNodes() and ReplaceDeprecatedNodes() duirng compile-on-load with bIsRegeneratingOnLoad = true. This matches the BP's state during compile-on-load when the BPCM is not enabled. Change 3406565 on 2017/04/24 by Dan.Oconnor Make sure all interface functions are added to skeleton #jira UE-44152 Change 3407489 on 2017/04/25 by Ben.Zeigler #jira UE-44317 Fix game-only TickableGameObjects to correctly tick in PIE Change 3407558 on 2017/04/25 by Ben.Zeigler Fix Fortnite cook warnings, issue had to do with the CDO being registered as a Primary Asset in conflict with the Class being registered Fix issue with renaming a BP primary asset not finding the old name Change 3407701 on 2017/04/25 by Dan.Oconnor Remove unneeded null check, static analysis doen't like the inconsistency Change 3407995 on 2017/04/25 by Marc.Audy Fixed maps and sets not working correctly with split pin. #jira UE-43857 Change 3408124 on 2017/04/25 by Ben.Zeigler #jira UE-39586 Change it so the blueprint String/Name/Object to Text node creates culture invariant text, and also have them show as an expanded node with a comment explaining this Fix Transform to actually return in the format specified in the comment, and fix comments on many text conversions Change 3408134 on 2017/04/25 by Marc.Audy Graph pin container type now represented by an enumeration (EPinContainerType) rather than 3 "independent" booleans. FEdGraphPinType constructor, UEdGraphNode::CreatePin, and FKismetCompilerContext::SpawnInternalVariable that took 3 booleans deprecated and replaced with a version that takes EPinContainerType. UEdGraphNode::CreatePin parameters reorganized so that PinName is before ContainerType and bIsReference, which default to None and false respectively Change 3408256 on 2017/04/25 by Michael.Noland Core: Changed UClass::ClassFlags to be of type EClassFlags for improved type safety Change 3408282 on 2017/04/25 by Marc.Audy (4.16) Fix incorrect positioning of instance components after duplication #jira UE-44314 Change 3408404 on 2017/04/25 by Mike.Beach Adding and removing the nativized plugin to/from the project when we alter the packaging nativization setting (so it gets picked up by project generation). Change 3408445 on 2017/04/25 by Marc.Audy Fix up missed deprecation cases #rnx Change 3409354 on 2017/04/26 by Marc.Audy Fix Linux CIS failure #rnx Change 3409487 on 2017/04/26 by Marc.Audy When dragging assets in to the SCS create them as siblings, not nested #jira UE-43041 Change 3409776 on 2017/04/26 by Ben.Zeigler #jira UE-44401 Fix issue with cooking a map containing a reparented component. In that case the child component may think it's not editor only, but it's archetype is editor only. This is not allowed in EDL, so now the child is marked as editor only as well Change 3410168 on 2017/04/26 by Dan.Oconnor Avoid calling virtual functions in the middle of compile #jira UE-44243 Change 3410252 on 2017/04/26 by Lukasz.Furman adjusted WITH_GAMEPLAY_DEBUGGER checks after IWYU changes #ue4 Change 3410385 on 2017/04/26 by Marc.Audy ChildActorComponent SetClass no longer fails when setting at runtime. #jira UE-43356 Change 3410466 on 2017/04/26 by Michael.Noland Core: Ensuring EClassFlags is 32 bit in a different way (underlying type of the enum is coming out signed even though all members are unsigned, long term fix is probably to move it to an enum class) #rnx Change 3410476 on 2017/04/26 by Michael.Noland Automation: Deleting some commented out methods #rnx Change 3411070 on 2017/04/27 by Marc.Audy Properly complete deprecation of old attachment API Change 3411338 on 2017/04/27 by mason.seay Map for Latent Action Tick Bug Change 3411637 on 2017/04/27 by Ben.Zeigler Back out CL #3381532 as it was causing crashes when adding new variables to blueprints, as the transaction array was being recursively modified while it was being added to Change 3412052 on 2017/04/27 by mason.seay Updated jump test map and pawn Change 3412231 on 2017/04/27 by Ben.Zeigler Fix issue where running SearchAllAssets multiple times after mounting new paths would throw away the asset registry cache, which slowed down incremental cooking substantially because the cooker mounts the autosave folder Duplicate of CL #3411860 Change 3412233 on 2017/04/27 by Ben.Zeigler Made FStreamableHandle::GetLoadedCount much faster by taking advantage of existing progress counter Duplicate of CL #3411778 Change 3412235 on 2017/04/27 by Ben.Zeigler Add code to FStringAssetReferenceThreadContext and FStringAssetReferenceSerializationScope which allows setting package name and collect options for string asset references serialized via something other than linker load Make RedirectCollector threadsafe to avoid issues with async loading asset references Fix it so ProcessStringAssetReferencePackageList will remove entries from the string asset array like resolve did, and rename function to indicate that Fix it so string asset references created by asset labels do not automatically get cooked, and significantly improve the speed of labels with lots of assets Add code to cooker and asset manager to explicitly mark non-cookable assets as NeverVook, this stops labels from ending up in the build if set that way Added option to not recurse package dependency changes more than one level when hashes change. This ended up not being significantly faster in a realistic case so left disabled Duplicate of CL #3412080 Change 3412352 on 2017/04/27 by Marc.Audy Refix lighting getting wrong position when getting component instance data Change 3412426 on 2017/04/27 by Marc.Audy Take first steps to making ComponentToWorld private and force use of accessor Make bWorldToComponentUpdated private Make ComponentToWorld and bWorldToComponentUpdated mutable Add a SetComponentToWorld function for the (likely ill-advised) places that were setting it directly. Change 3412468 on 2017/04/27 by Marc.Audy Remove last remnants of deprecated (4.11) custom location system Change 3413398 on 2017/04/28 by Marc.Audy Fix up missed deprecated attachment API uses Change 3413403 on 2017/04/28 by Marc.Audy Fix Orion compile error #rnx Change 3413448 on 2017/04/28 by Marc.Audy Fix up kite demo component to world privataization warnings #rnx Change 3413792 on 2017/04/28 by Ben.Zeigler Fix many bugs with blueprint pin default values, and add "Reset to Default Value" option to pin context menu Deprecate and rename SetPinDefaultValue because it actually sets the Autogenerated default. This was being called in bad places and destroying the stored autogenerated defaults #jira UE-40101 Fix expose on spawn pins to correctly update when the spawned object's defaults change #jira UE-21642 Fix struct pin default values to properly update when the struct is changed #jira UE-39418 Fix changed function/macro default values to properly update in already placed call nodes Change 3413839 on 2017/04/28 by samuel.proctor Added some Blueprint focused tests for TM-Gameplay Change 3414030 on 2017/04/28 by Ben.Zeigler Enable use of AssetPtr variables with Config, for native and blueprint This incorporates CL #3302487 but also enables for blueprint usage as that code is new to framework branch Change 3414229 on 2017/04/28 by Marc.Audy Fixup virtuals not calling their Super Remove some autos #rnx Change 3414451 on 2017/04/28 by Lukasz.Furman static analysis fix for gameplay debugger Change 3414482 on 2017/04/28 by Ben.Zeigler Fix crash found where changing pin type on ConvertAsset accessed an array while deleting it Change 3414609 on 2017/04/28 by Ben.Zeigler #jira UE-18146 Refresh graph when disconnecting a resolve asset id node Change 3415852 on 2017/05/01 by Marc.Audy Remove unused code #rnx Change 3415856 on 2017/05/01 by Marc.Audy auto removal #rnx Change 3415858 on 2017/05/01 by Marc.Audy Fix function taking an input as reference when unneeded and causing (still unclear why it suddenly started showing up) error in cooking #rnx Change 3415946 on 2017/05/01 by Marc.Audy Have K2Node_StructOperation skip the K2Node_Variable validation as it doesn't need a property (per CL# 1756451) #rnx Change 3415988 on 2017/05/01 by Lukasz.Furman renamed WorldContext param in AI related static blueprint functions to remove load/cook warnings #jira UE-44544 Change 3416030 on 2017/05/01 by Ben.Zeigler Fix issue with WorldContext pins being broken by my pin value refactor, partial paths like "WorldContext" need to be stored as strings and not as broken object references. Change 3416230 on 2017/05/01 by Marc.Audy Fix spelling error #rnx Change 3416419 on 2017/05/01 by Phillip.Kavan #jira UE-44213 - Nativizing a Blueprint class with a non-nativized Blueprint class subobject dependency will no longer lead to a crash at load time. Change summary: - Modified the FFakeImportTableHelper ctor to inject subobject CDOs into the 'SerializeBeforeCreateCDODependencies' array. This in turn ensures that EDL will serialize those subobject CDOs (if necessary) before we create the subobject's nativized owner's CDO at load time. - Modified FEmitDefaultValueHelper::GenerateCustomDynamicClassInitialization() to emit MiscConvertedSubobject instantiations AFTER we emit the FillUsedAssetsInDynamicClass() call. This is now consistent with the code emitted for other subobjects (all of which assumes that the UsedAssets array has been initialized). - Modified FFindAssetsToInclude::HandleObjectReference() to add UField owner CDOs in addition to the owner class to the asset dependency list. This ensures that owner CDOs will be emitted alongside the class to both the nativized asset dependency table as well as to the fake import table associated with the UDynamicClass linker for the nativized BP asset. Change 3416425 on 2017/05/01 by Phillip.Kavan #jira UE-44219 - Nativizing a Blueprint class with a nativized DOBP class dependency will no longer lead to a compile error at cook/nativization time. - Modified the FGatherConvertedClassDependencies ctor to properly handle DOBPs in exclusive mode that have been explicitly enabled for nativization. Previously, this code wasn't taking that possibility into account, and as a result could lead to a missing header file in a dependent nativized class body's include set. - Modified FGatherConvertedClassDependencies::GetFirstNativeOrConvertedClass() to remove the 'bExcludeBPDataOnly' parameter, as it was primarily just being used for a redundant exclusion check when called from the FGatherConvertedClassDependencies ctor. That call site has now been modified to start searching from the super class instead. Additionally, any DOBPs will already fail the preceding WillClassBeConverted() check if they have not been explicitly enabled for nativization in exclusive mode, and will always fail if nativizing in inclusive mode. The extra check was breaking the explicitly-enabled case, so it was removed to allow explicitly-enabled DOBPs to pass. Notes: - Allowing for explicitly-enabled DOBPs in exclusive mode may be removed in a future change, but since it is currently supported, the changes noted above will at least ensure that the generated code will compile properly for now. Change 3416570 on 2017/05/01 by mason.seay Added UMG test to map. Tweaked force feedback test Change 3416580 on 2017/05/01 by mason.seay Resubmitting sub levels Change 3416597 on 2017/05/01 by Dan.Oconnor Compilation manager iteration, adds machinery for individual blueprint compilation, adds comments, cleans up duplicated code Change 3416636 on 2017/05/01 by Phillip.Kavan #jira UE-44505 - Potential fix for a low-repro crash tied to the Blueprint graph context menu. Change summary: - Switched FBlueprintActionInfo::ActionOwner to be a weak object reference. Change 3416960 on 2017/05/01 by Dan.Oconnor Use compilation manager when clicking the compile button, PIE'ing, etc Change 3417207 on 2017/05/01 by Ben.Zeigler Fix issue with None strings causing default value parsing failures Add SetPinDefaultValueAtConstruction needed by some other changes Change 3417519 on 2017/05/01 by Ben.Zeigler Fix BP compile errors caused by local variables with invalid default values. There's no reason to set autogenerated here because the nodes are transient and invisible in the UI. There is still a problem here, local variables are not getting their default values validated when type is changed, so you end up with an integer that has the default value of a struct. Change 3418659 on 2017/05/02 by Ben.Zeigler #jira UE-44534 Fix it so animation node pins get properly created autogenerated default values that are based on the node struct defaults. This fixes issues when they are reset to other defaults #jira UE-44532 Fix it so connecting an animation asset pin on a node player resets the pin value to the autogenerated default instead of the cached asset. This was causing old unused assets to get unnecessarily cooked Fix it so any animation node with an exposed pin that is an object property will reset that object propery when the pin is exposed. This fixes UE-31015 in a generic way Change the OptionalPinManager to take a Defaults address as well as a current address, to allow setting autogenerated defaults properly Remove Import/ExportKismetDefaultValueToProperty as they were redundant with PropertyValueFromString and were using the wrong pin setting functions, replaced with PropertyValueFromString_Direct and calling the schema pin set functions I need to write some backward compatibility code to fix existing nodes, I'll do that in a later checkin Change 3418700 on 2017/05/02 by Ben.Zeigler Actually fix None object paths for real this time. I did not test sufficiently before Change 3418811 on 2017/05/02 by Ben.Zeigler Fix existing animation blueprint nodes with dead asset references duplicated by pins. This code can be applied independent of the other change to fix specific games Change 3419165 on 2017/05/02 by Dan.Oconnor Add misc. functionality from FKismetEditorUtilities::CompileBlueprint Change 3419202 on 2017/05/02 by Marc.Audy Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3417825 #rnx Change 3419236 on 2017/05/02 by mason.seay Removed OnPressed event from Widget BP Change 3419314 on 2017/05/02 by Marc.Audy Fix bad auto-resolve #rnx Change 3419524 on 2017/05/02 by Marc.Audy PR #3528: Improved Input BP library node display names (Contributed by projectgheist) #jira UE-44587 #rn Improved Input BP library node display names Change 3419570 on 2017/05/02 by Zak.Middleton #ue4 - Fix typo in TFunctionRef comment/example. Change 3419709 on 2017/05/02 by Dan.Oconnor Fix missing category metadata on SkeletonGeneratedClass when using compilation manager Change 3419756 on 2017/05/02 by Dan.Oconnor Remove unintentional verbosity increase Change 3420875 on 2017/05/03 by Marc.Audy Make IsExecPin static Minor optimization to IsMetaPin #rnx Change 3420981 on 2017/05/03 by Marc.Audy Change tagging temporarily until other changes are done so that we don't have warnings in the meantime #rnx Change 3421367 on 2017/05/03 by Marc.Audy Manually introduce changes from CL# 3398673 in 4.16 that failed to make it to Dev-Framework as a result of the integration submitted as CL# 3401725. #rnx Change 3421685 on 2017/05/03 by Ben.Zeigler #jira UE-23001 Convert literal Asset ID/Class ID pins to store path as string instead of as hard object reference. Old pins are fixed on load, after resaving the hard references will go away Refactor the way that FStringAssetReference and FAssetPtr are serialized, it now does the various fixups in FStringAssetReference::SerializePath, which is called from archivers Change it so the asset registry reads in a list of all scanned redirectors and adds them to GRedirectCollector, this means that saving a string asset reference will automatically fix it up to point to the redirector destination Change the default behavior of FAssetPtr serialize on ArchiveUObject to match what most of it's children want, and remove several special case hacks. It now serializes as asset reference when saving/loading, and as object for other cases Deprecate StringAssetReferenceLoaded/StringAssetReferenceSaving delegates, replace with PreSavePath and PostLoadPath on FStringAssetReference Make AssetLongPathname private on FStringAssetReference, it was deprecated in 4.9 Change 3421728 on 2017/05/03 by Phillip.Kavan Mirror CL 3408285 from //UE4/Release-4.16. #jira UE-44124 #rnx Change 3422370 on 2017/05/03 by Dan.Oconnor Mirror 3422359 Implement UBlueprintGeneratedClass::NeedsLoadForEditorGame to match UBlueprint, also tag a class's CDO as NeedsLoadForEditorGame. This prevents us from failing to load a UBlueprint's GeneratedClass when running the editor with -server. #jira UE-44659 Change 3423192 on 2017/05/04 by Ben.Zeigler CIS Fix Change 3423305 on 2017/05/04 by Ben.Zeigler Fix "Missing opening parenthesis" warnings for Vector and Rotator the same way they were fixed for Transform Change 3423358 on 2017/05/04 by Marc.Audy Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3422809 #rnx Change 3423766 on 2017/05/04 by Ben.Zeigler #jira UE-44680 Delete some corrupted redirectors that are no longer in use Change 3423804 on 2017/05/04 by Dan.Oconnor Honor SaveIntermediateCompilerResults when using compilation manager Change 3424010 on 2017/05/04 by Marc.Audy Validate that switch string cases are unique Change 3424011 on 2017/05/04 by Marc.Audy Re-fix switch node default pin not appearing as an exec output Remove unused boolean Change 3424071 on 2017/05/04 by Ben.Zeigler Delete FixupRedirects commandlet, replace with -FixupRedirects/FixupRedirectors option on ResavePackages. This new method is much faster than the old commandlet as it uses the asset registry vs loading all packages, fixing up all redirectors in Fortnite only took about an hour vs 12+ hours the old way Removed some hacky bits in Core that only existed to support FixupRedirects Change it so the AssetRegistry listens to DirectoryWatcher callbacks in commandlets now that commandlets use the asset registry properly. This won't do anything unless you tick directory watcher the way that ResavePackages does Change 3424313 on 2017/05/04 by Dan.Oconnor Address missing property flags on SkeletonGeneratedClass when using compilation manager #jira UE-44705 Change 3424325 on 2017/05/04 by Phillip.Kavan #jira UE-44222 - Move nativized UDS implementation details into its own .cpp file in order to avoid circular dependencies. Change summary: - Modified IKismetCompilerInterface::GenerateCppCodeForStruct() to include an output parameter for CPP source and modified FKismet2CompilerModule to match the updated API. - Modified IBlueprintCompilerCppBackend::GenerateCodeFromStruct() to include an output parameter for CPP source and modified FBlueprintCompilerCppBackendBase to match the updated API. - Modified FBlueprintNativeCodeGenUtils::GenerateCppCode() to adjust the call to GenerateCppCodeForStruct() to include CPP source output. - Modified FGatherConvertedClassDependencies::DependenciesForHeader() to switch UDS property dependencies to be forward declarations rather than includes (for default value init code). - Modified FEmitDefaultValueHelper::GenerateGetDefaultValue() to emit implementation details to the 'Body' container, and adjust the header content to be a declaration only. - Modified FIncludeHeaderHelper::EmitInner() to exclude a potentially-redundant line for the module's .h file, for the case when the caller has included the base filename in the 'AlreadyIncluded' set. - Modified FEmitterLocalContext::FindGloballyMappedObject() to limit the 'TryUsedAssetsList' path to UClass conversions only (since that requires a UDynamicClass target to work). - Modified FGatherConvertedClassDependencies::DependenciesForHeader() to only include BPGC fields if they are also being converted. Eliminates an issue with missing header files in generated code. Change 3424359 on 2017/05/04 by Ben.Zeigler Fix issue where StreamableManager would break when requesting an async load that failed the first time. Because our game supports downloading assets during gameplay it's not safe to assume it will never load again. Port of CL #3424159 Change 3424367 on 2017/05/04 by Ben.Zeigler Fix some asset manager warnings to not go off in invalid cases Change 3425270 on 2017/05/05 by Marc.Audy Pack booleans/enums in UEdGraphNode and FOptionalPinFromProperty #rnx Change 3425696 on 2017/05/05 by Ben.Zeigler #jira UE-44672 Fix it so select node option pins get populated with default values properly #jira UE-43927 Fix it so select node opion pin type is correctly maintained accross node recreation, as opposed to deriving from the attached pins #jira UE-44675 Fix it to correctly refresh select node when switching from bool to integer index Change 3425833 on 2017/05/05 by Ben.Zeigler #jira UE-31749 Fix it so Undo works properly when modifying a local variable #jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value Change 3425890 on 2017/05/05 by Marc.Audy Fix Copy/Paste of child actor components losing the template #jira UE-44566 Change 3425947 on 2017/05/05 by Ben.Zeigler This was meant to be part of last checkin Change 3425959 on 2017/05/05 by Ben.Zeigler #jira UE-44692 Fix it so only the sequentially last node can be removed from a Switch On Int, and for Switch On Name stop it from removing an exec pin if it's the only non-default one Change 3425979 on 2017/05/05 by Dan.Oconnor PVS fix Change 3425985 on 2017/05/05 by Phillip.Kavan Fix an uninitialized variable. #rnx Change 3426043 on 2017/05/05 by Ben.Zeigler #jira UE-35583 Correctly refresh array node UI when connecting pins that change it away from wildcard Change 3426174 on 2017/05/05 by Zak.Middleton #ue4 - Avoid call to virtual getSimulationFilterData() to only use it when needed in PreFilter if we actually have items in the IgnoreComponents list (which is rare). The sim filter data 'word2' stores the component ID. Change 3426621 on 2017/05/05 by Phillip.Kavan #jira UE-44708 - Fix an issue that re-introduced component data loss in a non-nativized child Blueprint class with a nativized parent Blueprint class. Change summary: - Removed an unnecessary additional check I had for the presence of "-NativizeAssets" switch on the command line in UBlueprint::BeginCacheForCookedPlatformData(). This check was failing because the usage was recently changed to include an optional value. It was not needed anyway so I just removed it. #rnx Change 3426906 on 2017/05/05 by Ben.Zeigler #jira UE-11189 Fix function/macro input default values to show as a pin customization instead of as a broken text box that doesn't work correctly for most types. This fixes enums and provide validation for other types Types that don't have a customization (most structs) will now show any more, they did not work before either #jira UE-21754 Hide function default values if pass by reference is set Fix it so changing input parameter will also reset default value, to avoid having the wrong type value set and to work the same as local variables Change 3426941 on 2017/05/05 by Dan.Oconnor Fix determinstic cooking of LoadAssetClass nodes in macros Change 3427021 on 2017/05/05 by Dan.Oconnor Build fix, make initialization order in source match artifact #rnx Change 3427135 on 2017/05/05 by Phillip.Kavan #jira UE-44702 - Restore code-based interface classes to Blueprint editor UI. Change summary: - Partially backed out CL# 3348513 to return to previous behavior for 4.16. The UI is no longer filtering on the __is_abstract() type trait for interface classes. - Modified FNativeClassHeaderGenerator::ExportClassFromSourceFileInner() to emit the _getUObject() declaration for native interface types as a default implementation that returns NULL rather than as a pure virtual declaration. #rnx Change 3427144 on 2017/05/06 by Marc.Audy Fix init order #rnx Change 3427146 on 2017/05/06 by Marc.Audy remove stray semicolon #rnx Change 3427242 on 2017/05/06 by Phillip.Kavan #jira UE-44744 - Fix a regression in which a UMG Widget Blueprint property not explicitly marked as a variable would cause Blueprint nativization to fail at package time. Change summary: - Modified FWidgetBlueprintCompiler::CreateClassVariablesFromBlueprint() to only add 'Category' metadata when we set the 'CPF_BlueprintVisible' flag on the UProperty, which in is now tied to whether or not the property has been explcitly marked as a variable. This avoids a UHT warning when compiling the nativized codegen that would cause packaging to fail. #rnx Change 3427720 on 2017/05/08 by Dan.Oconnor Backing out 3419202 #rnx Change 3427725 on 2017/05/08 by Dan.Oconnor SA fix #rnx Change 3427734 on 2017/05/08 by Dan.Oconnor More exhaustive GEditor null checks, to appease SA #rnx Change 3427882 on 2017/05/08 by Marc.Audy Properly order all booleans in intialization #rnx Change 3428049 on 2017/05/08 by Marc.Audy Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 3427804 #rnx Change 3428523 on 2017/05/08 by Ben.Zeigler #jira UE-44781 Refresh function input UI when blueprint graph refreshes, needed as pins may have gone away Change 3428563 on 2017/05/08 by Ben.Zeigler #jira UE-44783 If setting a hard reference pin type from a string, load the referenced object. Change 3428595 on 2017/05/08 by Dan.Oconnor Avoid node reconstruction when we're compiling a blueprint with no linker (e.g., a duplicated blueprint) #jira UE-44777 Change 3428599 on 2017/05/08 by Ben.Zeigler #jira UE-44789 Fix string asset renamer to not mark IsPersistent becuase that crashes in lightmap code, change it so the path fixup doesn't require the persistent flag Change 3428609 on 2017/05/08 by Dan.Oconnor Improved fix for UE-44777 #jira UE-44777 #rnx Change 3429176 on 2017/05/08 by Phillip.Kavan #jira UE-44755 - Fix nativization build errors when packaging a game project that is not IWYU-compliant for a build target that disables PCH files. - Mirrored from //UE4/Release-4.16 (CL# 3429030). #rnx Change 3429198 on 2017/05/08 by Phillip.Kavan CIS fix. #rnx Change 3429583 on 2017/05/08 by Ben.Zeigler Fix SGraphPinClass to work properly after my changes to allow unloaded assets. For Class pins we need to store separate Runtime and Editor asset data objects, as one has _C and refers to the class, and the other doesn't and refers to the blueprint. The content browser wants the editor path, the pin defaults want the runtime path. Change default value widgets to look more like properties widgets by forcing them to act as highlighted and disabling black background Change 3429640 on 2017/05/08 by Marc.Audy Fix issues with select nodes in macros connected to wildcard pins. #jira UE-44799 #rnx Change 3429890 on 2017/05/08 by Ben.Zeigler Fix function/macro defaults to properly propagate when changed using the new edit UI Refactor some code out of the details customization into the k2 schema Disable defaults UI for object/class/interface hard references as it is disabled in KismetCompiler Change 3429947 on 2017/05/08 by Michael.Noland Core: Backing out CL# 3394352 (marking FDateTime and FTimespan nonexport member Tick with UPROPERTY()), which will re-break UE-39921 but fix UE-44418 There appears to be a more serious underlying issue with how the CDO is instanced which needs to be addressed #jira UE-44418 #reimplementing 3411681 from Release 4.16 Change 3429987 on 2017/05/08 by Ben.Zeigler #jira UE-44798 Do a better job of validating object paths saved as default values, due to an old bug with local variables some object paths are saved as struct exportext At load time clear invalid default value for local variables Add IsValidObjectPath to FPackageName that validates the passed in path would be valid to load with LoadObject Change 3430392 on 2017/05/09 by Marc.Audy Fix SA CIS error #rnx Change 3430747 on 2017/05/09 by Ben.Zeigler #jira UE-44836 Don't reconstruct node during callback for param value changing, this can happen during a reconstruction and recursive reconstruction is unsafe Don't call ModifyUserDefinedPinDefaultValue unless the default value has actually changed Change 3431027 on 2017/05/09 by Marc.Audy Fix BPRW mark up causing Ocean warnings #rnx Change 3431353 on 2017/05/09 by Marc.Audy Fix UHT error due to exposing FJsonObjectWrapper to blueprints #rnx [CL 3431398 by Marc Audy in Main branch]
2017-05-09 17:15:32 -04:00
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3106465) #lockdown Nick.Penwarden Change 3110660 on 2016/9/1 by Andrew.Grant Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress. HLOD warning is updated every 20 secs to deal with streaing levels. Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon). #rb Michael.Noland #tests verified we see our unbuilt HLOD warning in v31 :( Change 3106649 on 2016/08/30 by Cody.Haskell #Orion - Input Axis Work #rb DanH #tests PIE Change 3106299 on 2016/08/30 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 31.2 @ CL 3105865 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3106213 on 2016/08/30 by Ben.Marsh BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file. #rb none #tests preflight Change 3105994 on 2016/08/30 by Martin.Wilson Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input) #jira UE-35289 #rb Thomas.Sarkanen #tests Tested UI in editor Change 3105331 on 2016/08/29 by Uriel.Doyon Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget. #rb marcus.wassmer #tests launched editor and played game #jira OR-25814 Change 3105143 on 2016/08/29 by Josh.Markiewicz #UE4 - added assert when histogram input parameters don't match #rb none #tests launched/ran/won game golden path #codereview dmitry.rekman, michael.noland, bart.bressler Change 3104976 on 2016/08/29 by Jon.Lietz pickup refector - fixed a big that would allow mixed replication to call a gameplay cue's added twice. - All pickups now use the pick up manager, consolidated all pick up code into the manager. - added to the XP set so we can define the CXP bounty for targets. #RB Dave.Ratti #tests Bot match, test maps, spawning coins and pickups. Change 3103480 on 2016/08/26 by Josh.Markiewicz #UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession #rb none #tests golden path matchmaking #codereview paul.moore, eric.newman Change 3103410 on 2016/08/26 by Max.Chen Movie Capture: Fix commandline burnin option. #rb none #tests Render movie with commandline -UseBurnIn=yes option. Change 3102134 on 2016/08/25 by Brian.Karis Fix for HDR output exposure. Added 1000nit output option. #rb marcus #tests agora Change 3101276 on 2016/08/25 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_31 - Merging CL 3100347 (head revision of 2 files :o ) #RB:none #Tests:none [CodeReviewed]: matt.schembari, max.preussner #R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274 #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3101267 on 2016/08/25 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_DUI - Integrating Media changes from 4.13 (head revision) #RB:none #Tests:none /Engine/Plugins/Media /Engine/Source/Runtime/Media /Engine/Source/Runtime/MediaAssets [CodeReviewed] matt.schembari, max.preussner #R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266 #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3100378 on 2016/08/24 by John.Pollard Fix a crash that can occur when scrubbing in replays #codereview David.Ratti #tests Replays #rb DavidR This is the output: [2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage Change 3100375 on 2016/08/24 by Laurent.Delayen Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket). #rb none #codereview lina.halper #tests Tacticia's RMB Targeting Change 3100278 on 2016/08/24 by Laurent.Delayen Fix for fast path struct copy being broken for FVectors. #rb lina.halper #codereview thomas.sarkanen #tests Chains' hook, Tacticia's LaserBeam and OrientationWarping Change 3100161 on 2016/08/24 by John.Pollard Merging using Dev-Networking_->_Dev-General_(Orion) Fix issue with refresh viewer command failing due to backend congestion #rb RyanG #tests Replays Change 3100114 on 2016/08/24 by jason.bestimt #ORION_MAIN - Merge DUI @ CL 3098849 #RB:none #Tests:none #CodeReview: kerrington.smith, matt.schembari #R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3100015 on 2016/08/24 by Michael.Noland Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node #jira UE-34998 #rb Aaron.McLeran [re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13] #tests Compiled and ran a golden path match with headphones on Change 3100012 on 2016/08/24 by Michael.Noland UE-34951 - Zero-volume vorbis decoded sounds are too expensive -Adding an audio settings parameter to disable zero-volume playback globally -Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume #rb marc.audy [re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran] #tests Compiled and ran a golden path match with headphones on Change 3099889 on 2016/08/24 by Max.Chen Sequencer: Added command line option to enable burnin #rb none #tests Render movie from command line wtih -UseBurnIn=yes Change 3099801 on 2016/08/24 by Lina.Halper Removed unnecessary comment #rb: none #code review: Benn.Gallagher #tests: compile Change 3099787 on 2016/08/24 by Jason.Bestimt #R@BOMERGE-AUTHOR: sam.zamani #http - fix for cancelled requests that have not been started never triggering a completion delegate - fixes soft lock when handling disconnects during login OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting #rb josh.markiewicz, alex.fennell #tests none #R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785 #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3099252 on 2016/08/24 by Lina.Halper Fixed menu text #rb: none #code review: Thomas.Sarkanen #tests: open editor and create child montage and replaced the animation Change 3099251 on 2016/08/24 by Lina.Halper Deterministic cooking of skeleton - abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked #jira: UE-34834 #rb: Martin.Wilson #tests: cooking orion and make sure it works Change 3098504 on 2016/08/23 by Bart.Bressler Add server time between sending packets monitoring histogram #rb dmitry.rekman #tests ran server locally and made sure analytics events were sent Change 3098494 on 2016/08/23 by Michael.Noland Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements - Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer) - Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected #tests Tested by calling while stat dumphitches was active and confirmed that the interval changed #codereview ben.salem, gil.gribb #rb none Change 3098491 on 2016/08/23 by Mieszko.Zielinski Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4 #rb Lukasz.Furman #test golden path Change 3098070 on 2016/08/23 by Lina.Halper Fix crash with UI update reconstructing - will have to come up with a better solution than this. #rb: Martin.Wilson #tests: child anim montage Change 3097914 on 2016/08/23 by Jason.Bestimt #R@BOMERGE-AUTHOR: david.nikdel Merging CL #3097879 from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/... to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/... #Analytics #OSS: Adjusted cohort selection algorithm and test cases [CodeReviewed]: Philip.Buuck #TESTS: unit tests #RB: none #R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3097745 on 2016/08/23 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Megre 30.2/31 @ CL 3096895 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3097722 on 2016/08/23 by Chris.Bunner Update texture expression properties before triggering parent material recompile. #rb John.Billon #tests Editor replace references, Golden path #jira OR-27531 Change 3097694 on 2016/08/23 by Lina.Halper #Child Anim Montage - Duplicate from parent of the information it cares to get - Currently it is selective on copying what data - Modified GetAllAnimationSequencesReferred to get a partial data - Added ParentAsset/AssetMappingTable in AnimationAsset - Sequence Browser opening would also add to history - AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on #code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti #rb:Martin.Wilson #tests: creating child montage, editing, lots of UI functionality, notifies placement Change 3097513 on 2016/08/23 by Thomas.Sarkanen Non-POD structs can now be copied using the fast path We now always use CPP struct ops to perform copies when dealing with struct properties. #jira UE-34571 - Support struct member access on AnimBP fast path #rb Laurent.Delayen #tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games. Change 3096729 on 2016/08/22 by Mieszko.Zielinski Fixes to EQS scoring function preview #UE4 #rb Lukasz.Furman #test golden path Change 3096596 on 2016/08/22 by Jason.Bestimt #ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970) #RB:none #Tests:none #CodeReview: matt.schembari, max.preussner #R@BOMERGE: MAIN Change 3096550 on 2016/08/22 by Jurre.deBaare Fix for HLOD dirty clusters PIE warning message #tests Simulated Origin with built HLOD clusters, and with one dirty cluster #rb none Change 3096532 on 2016/08/22 by Mieszko.Zielinski Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4 As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized #codereview Lukasz.Furman #rb none #test golden path Change 3096455 on 2016/08/22 by Jason.Bestimt #R@BOMERGE-AUTHOR: keli.hlodversson #CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases #RB David.Nikdel #TESTS none #R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3096316 on 2016/08/22 by Sammy.James Resave to fix log warnings. BPC changes to ensure type saves. #rb #tests editor Change 3096040 on 2016/08/22 by bruce.nesbit Revised fix for landscape crash #rb GarethM #tests Game #codereview Bart.Bressler Change 3096015 on 2016/08/22 by bruce.nesbit Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server #rb none #tests game #codereview Bart.Bressler Change 3095578 on 2016/08/19 by Mieszko.Zielinski Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4 This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor #rb none #test golden path #codereview Lukasz.Furman Change 3095397 on 2016/08/19 by Lina.Halper Fix issue with crash when deleting all segment #rb: Laurent.Delayen #tests: delete segment and make sure it doesn't crash #jira: UE-34830 Change 3095060 on 2016/08/19 by Bart.Bressler Don't load ULandscapeComponent objects on dedicated servers to save memory. #tests cooked server data and played a Solo vs. AI game #rb gareth.martin #codereview james.golding Change 3095037 on 2016/08/19 by Lina.Halper Potential fix with montage trigger ensure on marker sync group #jira: OR-27685 #rb: Benn.Gallagher #code review: Martin.Wilson #tests: attack primhelilx with knock up Change 3094962 on 2016/08/19 by Jason.Bestimt #R@BOMERGE-AUTHOR: david.nikdel #Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort #RB: None #TESTS: test suite in source [CodeReviewed]: Philip.Buuck #R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3094950 on 2016/08/19 by Jason.Bestimt #R@BOMERGE-AUTHOR: david.nikdel #Merge #UE4 - Made FMD5 const-correct #RB: none #TEST: none #R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3094619 on 2016/08/19 by Lina.Halper #DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID. - assumed the name is all set by now #rb: Benn.Gallagher #jira : UE-34886 #tests: cooking infiltrator that showed same issue and run game. Change 3094532 on 2016/08/19 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3094498 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3093260 on 2016/08/18 by Josh.Markiewicz #UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel) - removed unnecessary cast #rb bart.bressler #codereview bart.bressler, rob.cannaday #tests launched game, some basic party testing Change 3093224 on 2016/08/18 by Josh.Markiewicz #UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games #rb paul.moore #codereview anthony.carter #tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining Change 3092597 on 2016/08/17 by Daniel.Lamb Added Ben Crocker to the rebuild lighting emails. #rb Trivial #Test none Change 3092063 on 2016/08/17 by andrew.grant Merging using ROBO://Orion/Release-Candidate->//Orion/Main #rb #tests none Change 3091081 on 2016/08/16 by Jurre.deBaare Fixing non-Editor build errors #fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty) #tests Build Editor + Game #rb none Change 3091009 on 2016/08/16 by Mieszko.Zielinski Added a way to configure a map to not spawn AISystem instance at all #UE4 #rb none #test golden path Change 3090932 on 2016/08/16 by Michael.Noland Vixen: Added indication to the analytics and FPS charts #rb marcus.wassmer #tests Compiled for the platform Change 3090844 on 2016/08/16 by Laurent.Delayen Replicated CL 3090734 from Fortnite. --- Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage Here's the issue in the version of the code prior to this checkin: - UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped - When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value - So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick - It also means if we were playing a montage, and then stop, we'll start ticking - Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing #codereview john.abercrombie #rb none #tests golden path Change 3090832 on 2016/08/16 by Michael.Noland Windows: Fixed a whitespace issue #rb none #tests Compiled for windows Change 3090688 on 2016/08/16 by Jason.Bestimt #R@BOMERGE-AUTHOR: andrew.grant Merging using ROBO://Orion/Release-Candidate->//Orion/Main #rb none #tests built #R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3090547 on 2016/08/16 by Jurre.deBaare Need a warning message similar to lighting unbuilt when HLOD cluster is not built #fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour #jira UE-34335 #rb none #codereview Michael.Noland #tests pie Agora with and without dirty HLOD clusters Change 3090285 on 2016/08/16 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3090267 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3089413 on 2016/08/15 by paul.mader Agora 2.0 assets Change 3089266 on 2016/08/15 by Max.Chen Sequencer: Add Convert to Possessable Copy from Dev-Sequencer #jira UE-32139 #rb none #tests Convert steel to possessable in Gameplay_PS4 map. Change 3089136 on 2016/08/15 by Mieszko.Zielinski Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4 #rb Lukasz.Furman #codereview Dan.Youhon #test golden path Change 3089118 on 2016/08/15 by Mieszko.Zielinski Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4 #rb none #test golden path Change 3088976 on 2016/08/15 by Andrew.Grant Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules. Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting. Removed superflous /Os from VC debugg settings #rb none #tests verified module built with 'Never' on PS4/Win is built without optimizations. #codereview Marcus.Wassmer, Ben.Marsh Change 3088830 on 2016/08/15 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3088807 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3088597 on 2016/08/14 by Jason.Bestimt #ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG) #RB:none #Tests:none #CodeReview: andrew.grant, david.ratti, matt.schembari Change 3087827 on 2016/08/12 by Bart.Bressler Updates to skeletal mesh memory saving on dedicated server #rb lina.halper #tests Cooked server data, played a game for a while in Solo vs. AI Change 3087351 on 2016/08/12 by John.Pollard Merging using Dev-Networking_->_Dev-General_(Orion) #jira OR-27406 #rb RyanG #tests Replays Change 3087118 on 2016/08/12 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3086747 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3086176 on 2016/08/11 by Marcus.Wassmer Fix PS4 ShaderPipelines not matching pixel/vertex shader properly. #rb Rolando.Caloca #tests Broken PS4 content before/after Change 3085992 on 2016/08/11 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Unclog R@BOMERGE #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3085911 on 2016/08/11 by Laurent.Delayen Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex #rb none #tests Orientation Warping Change 3085614 on 2016/08/11 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3085547 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3084507 on 2016/08/10 by Marcus.Wassmer Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen. #rb none #tests paragon ps4/vixen #codereview Olaf.Piesche Change 3084136 on 2016/08/10 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3083799 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3083424 on 2016/08/09 by Max.Chen Sequence Recorder: Fix crash when actor class to record is null. #tests Use sequence recorder to record a skeletal mesh actor #rb none Change 3083134 on 2016/08/09 by Jason.Bestimt #R@BOMERGE-AUTHOR: sam.zamani #online,store,ps4 - creating one offer entry per entitlement #rb david.nikdel, ian.fox #tests MTX purhcase on PS4 #lockdown: andrew.grant #R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131 #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3083069 on 2016/08/09 by Marcus.Wassmer Vixen scalability changes #rb Michael.Noland #tests vixen/ps4 #codereview jordan.walker Change 3083063 on 2016/08/09 by Marcus.Wassmer Most games will probably run out of memory if setup to do auto-4k. Make this a setting that's off by default. #rb Michael.Noland #codereview Luke.Thatcher, Lee.Clark #tests vixen on 4k. Change 3082778 on 2016/08/09 by Marcus.Wassmer Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087) #rb none #tests Agora on vixen. Change 3082772 on 2016/08/09 by Marcus.Wassmer Duplicate fix for detail mode reregistration (3065543) #rb none #tests Toggled detail mode, observe proper items spawning Change 3082765 on 2016/08/09 by Marcus.Wassmer Don't crash when trying to use windowed vsync on vixen #rb Michael.Noland #test ran paragon on vixen #codereview Luke.Thatcher,Lee.Clark Change 3082764 on 2016/08/09 by Marcus.Wassmer fix HLOD distance scale not working properly when components are re-registered. #rb michael.noland #codereview jurre.debarre #tests setting multiple times, setting on boot via deviceprofile Change 3082429 on 2016/08/09 by Jason.Bestimt #R@BOMERGE-AUTHOR: sam.zamani Merging //Orion/Release-30.1 to Main (//Orion/Main) Change: 3082419 #online,store,PS4 OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen - added config option for toggling store on PS4 [OnlineSubsystemPS4] bStoreEnabled=true - can also override via title specific json values in <titleid>\title.json allow_mtx=true [CodeReviewed]: andrew.grant, phillip.buck, ian.fox #lockdown: andrew.grant #rb none #tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support) #R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3082194 on 2016/08/09 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3082105 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3080984 on 2016/08/08 by Lina.Halper Issue with not being able to set static animation data via BP - artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP - also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called. #rb: Martin.Wilson #tests: Sword Beauty map Change 3080665 on 2016/08/08 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3080081 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3080565 on 2016/08/08 by Laurent.Delayen Fix for curve values during URO interpolation. Fixes flashing of materials and Twinblast's ult weapon. https://jira.ol.epicgames.net/browse/OR-27107 https://jira.ol.epicgames.net/browse/OR-24358 #rb lina.halper, martin.wilson #tests Twinblast's ult and Coil's primary. Change 3079832 on 2016/08/05 by Jason.Bestimt #R@BOMERGE-AUTHOR: marcus.wassmer Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline #rb none [CodeReviewed] Chris.Wood #tests checked crashcontext on PC/PS4 #lockdown Andrew.Grant #R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831 #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3079045 on 2016/08/05 by Lina.Halper Adding more log to figure out why ActivePlayers.Count becomes inconsistent. #rb: Martin.Wilson #tests: PIE with bots Change 3078944 on 2016/08/05 by Rolando.Caloca O - Update blacklisted driver #jira OR-27051 #rb Marcus.Wassmer #tests Run with AMD card Change 3078735 on 2016/08/05 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3078670 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3078122 on 2016/08/04 by Dmitry.Rekman Linux: treat abort() / SIGABRT as crash. - Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler. - Rewrote RequestExit() because it used abort() itself. - Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason. #rb Mark.Satterthwaite #codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant #review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant #tests Ran Linux server, crashed using different methods. Change 3077887 on 2016/08/04 by Dmitry.Rekman Initialize StackCount to 0 (kills valgrind warning). #rb David.Ratti #codereview David.Ratti #tests Ran Linux server. Change 3077257 on 2016/08/04 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3077193 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3077242 on 2016/08/04 by Dmitry.Rekman Linux: stop heartbeat thread before handling the crash. #rb Robert.Manuszewski #codereview Robert.Manuszewski, Andrew.Grant #tests Compiled and ran Linux server, crashed it. Change 3076676 on 2016/08/03 by Dmitry.Rekman Linux: print details about memory access (read or write). - Also print all the 16 digits of the pointer. - Read/write detection only implemented for x86_64. #rb Andrew.Grant #codereview Andrew.Grant #tests Compiled (natively) and ran Linux server. Change 3076675 on 2016/08/03 by Dmitry.Rekman Print a bit more info about the array in assert. #rb Andrew.Grant #codereview Andrew.Grant #test Compiled and ran Linux server. Change 3076010 on 2016/08/03 by Laurent.Delayen Moved OrionAnimNode_LegIK from Paragon to Engine. #codereview lina.halper #rb none #tests Grim.exe + Iggy & Scorch Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt Reimplemented 3070766 for Orion: Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash) #rb none #tests none Change 3075446 on 2016/08/03 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3075422 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3075394 on 2016/08/03 by HaarmPieter.Duiker Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in. #rb marcus.wassmer #tests post process color correction Change 3074314 on 2016/08/02 by Dmitry.Rekman Linux: change optimization from -O2 to -O1 (temporarily?). - The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier. - Also adds a line to UBT output during compilation to draw attention. #rb Michael.Noland #codereview Michael.Noland, Andrew.Grant, Bart.Bressler #tests Compiled and ran Linux server. Change 3073553 on 2016/08/02 by jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3073360 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) #R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human. //Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened #CodeReview: jason.bestimt Change 3073505 on 2016/08/02 by Daniel.Lamb Added cook modification delegate stats to cooker stats. #rb Wes.Hunt #test cook paragon. Change 3072440 on 2016/08/01 by Aaron.Eady PlayerController Force Feedback (Debug only); Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries. #rb none #tests SHIPPING Change 3072259 on 2016/08/01 by Aaron.Eady PlayerController Force Feedback (Debug only); Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback. #rb Michael.Noland #tests PIE Change 3071908 on 2016/08/01 by John.Pollard Fix null reference crash #rb DavidR #tests Live game + replays Change 3071876 on 2016/08/01 by John.Pollard Merging using Dev-Networking_->_Dev-General_(Orion) Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player #rb none #tests FN + Paragon live game + replays #codereview Andrew.Grant Change 3071875 on 2016/08/01 by John.Pollard Merging using Dev-Networking_->_Dev-General_(Orion) Finalize replay version system * No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions) * Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore. * Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions) #rb RyanG #tests Live game + replays #codereview Andrew.Grant Change 3071874 on 2016/08/01 by John.Pollard Merging using Dev-Networking_->_Dev-General_(Orion) Fix gameplay tags to work better with backwards compatibility in replays * We use the net field export group system in the package map to export tag names as a packed index * This will allow us to see the names of tags that no longer exists on the remote side #rb RyanG #tests Live game + replays #codereview Andrew.Grant Change 3071776 on 2016/08/01 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30.2 @ CL 3071738 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3071258 on 2016/07/30 by Aaron.McLeran OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay - Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together. - Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now. #rb none #tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues. Change 3071099 on 2016/07/30 by Aaron.McLeran OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay - Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads. #rb none #tests ran paragon with change and noticed no change in audio quality Change 3070916 on 2016/07/29 by Andrew.Grant Missed file! #rb #tests na Change 3070915 on 2016/07/29 by Andrew.Grant Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging #rb none #tests Engine QA, Orion QA smoke Change 3070576 on 2016/07/29 by Uriel.Doyon Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize. #review-3070386 @marcus.wassmer #jira OR-25941 #rb marcus.wassmer #tests Run Game on PS4, and in editor Change 3070086 on 2016/07/29 by Martin.Wilson Fixed ensure triggering during sequencer playback due to double update. #jira UE-33938 #rb Thomas.Sarkanen #tests opened affected asset and verified problem no longer occured Change 3070016 on 2016/07/29 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 30 @ CL 3069935 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3069435 on 2016/07/28 by Ian.Fox #Orion, #Mcp - Check if Price Engine is configured before attempting query #rb Sam.Zamani #tests none #codereview Sam.Zamani Change 3069381 on 2016/07/28 by Michael.Noland Animation: Demoted a check() in anim sync group code to an ensure() to unblock others #rb nick.penwarden #tests Loaded Paragon cine asset that was crashing #codereview lina.halper, martin.wilson Change 3069203 on 2016/07/28 by Dmitry.Rekman Headless client: do not draw windows. - Disables a bunch of code, including reaching into font cache to estimate width. - Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets). #rb Nick.Atamas #review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem #codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem #tests Compiled and ran Orion Linux client. Change 3069181 on 2016/07/28 by Lina.Halper Fix struct redirector for Orion anim node moving to engine #rb: Maciej.Mroz #code review:Laurent.Delayen #tests: editor loading the anim BP that caused the name conversion Change 3069092 on 2016/07/28 by Aaron.McLeran OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves - Not all active sounds have sound classes, was causing a crash #codereview marc.audy #rb zabir.hoque #tests Run game with stat soundcues and not crash Change 3068969 on 2016/07/28 by David.Ratti Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too. #rb none #tests compile Change 3068902 on 2016/07/28 by David.Ratti Code for tracking down UGameplayCueManager::GetInstancedCueActor crash. #rb none #tests compile Change 3068831 on 2016/07/28 by Aaron.McLeran OR-26417 Reverb is too loud in-game in Dev-General - Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set. #rb Jeff.Campeau #tests run a map with no reverb audio volume and reverb is not super wet Change 3068529 on 2016/07/28 by Jason.Bestimt #R@BOMERGE-AUTHOR: david.nikdel #OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config) #RB: none #TESTS: none #R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3068399 on 2016/07/28 by Andrew.Rodham Sequencer: Changed animation tracks to allow more animation types (such as anim montages) - APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility #jira OR-25769 #tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly. #rb Benn.Gallagher Change 3068138 on 2016/07/28 by Marcus.Wassmer Disable mallocleak testing by default #rb none #test none Change 3068121 on 2016/07/28 by Marcus.Wassmer Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled. Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also. #rb Robert.Manuszewski #tests stack tracing / symbolication with mallocleak on windows. Change 3068119 on 2016/07/28 by Marcus.Wassmer Fix MallocLeakProxy deadlock #rb Robert.Manuszewski #tests mallocleak start/stop/dump on windows Change 3067752 on 2016/07/27 by Michael.Noland Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands - IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer - The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class. - The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered - Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code Upgrade Notes: - DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly - In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands) - HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name) - Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future) Paragon: - Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event - Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it. #rb dmitry.rekman #codereview bob.tellez, peter.knepley, andrew.grant, john.mauney #review-3067607 @Dmitry.Rekman, @Bob.Tellez #tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI Change 3067654 on 2016/07/27 by Michael.Noland FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path. #rb steve.robb #jira UE-31959 [duplicating CL# 3039827] #tests Tried moving a folder in the editor Change 3067644 on 2016/07/27 by Aaron.McLeran OR-24537 Looping audio sometimes persists in Agora Adding stopping sounds if audio component is destroyed while playing a looping sound #rb jeff.campeau #tests audio component stops looping sound if audio component is destroyed prematurely Change 3067560 on 2016/07/27 by Aaron.McLeran OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters - Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call - using xaudio2 operation sets to ensure that voice and effect params are executing in sequence - only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands - Don't call EnsureCompletion on pending async tasks on teardown #rb Jeff.Campeau #tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions Change 3067420 on 2016/07/27 by jason.bestimt #ORION_MAIN - Merge 29.2/30 @ CL 3067312 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3067316 on 2016/07/27 by jason.bestimt #ORION_MAIN - Merge DUI @ CL 3065602 #RB:none #Tests:none [CodeReviewed]: matt.schembari #R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3067025 on 2016/07/27 by Michael.Noland Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes #rb none #tests Compiled Change 3067020 on 2016/07/27 by Michael.Noland Core: Various improvements to FHistogram and split it out into separate files - Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate) - Added O(1) getters for total sample counts and sum of all measurements - Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex - Added support for specifying explicit histogram bucket thresholds #rb dmitry.rekman #tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage Change 3066681 on 2016/07/27 by Frank.Gigliotti Camera anim field of view fix; * The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value. * Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees. #RB None #CodeReview Jeff.Farris #Tests Multiple camera animations in PIE Change 3066508 on 2016/07/27 by Lina.Halper Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name. #code review:Martin.Wilson, Benn.Gallagher #rb: Martin.Wilson #tests: cooked test map, run test map, PIE, saving content, loading standalone game Change 3066246 on 2016/07/27 by Jason.Bestimt #R@BOMERGE-AUTHOR: andrew.grant Fix for non-unity error #rb none #tests compiled #R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3066167 on 2016/07/27 by Benn.Gallagher Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding. #rb Ori.Cohen #tests Editor, PIE, Applying clothing to characters. Change 3065868 on 2016/07/27 by Michael.Noland Blueprints: Fixing non-editor build (missing WITH_EDITOR) #rb none #tests Compiled PS4 Change 3065749 on 2016/07/26 by Michael.Noland Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead) #codereview mike.beach, marc.audy #tests Loaded and recovered a corrupted Blueprint on Cameron's machine #rb Phillip.Kavan Change 3065706 on 2016/07/26 by Josh.Markiewicz #UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons - fixed non shipping cmd line override to be correct #rb none #codereview andrew.grant, paul.moore #tests none Change 3065359 on 2016/07/26 by Rob.Cannaday Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit. Break up calls in batches of 100 ids. #jira OR-20674 #rb ian.fox #tests login to front end with PC, PS4. forced tests to simulate > 100 requests. Change 3065197 on 2016/07/26 by Bart.Bressler Change how PS4 sessions work: - We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions. - Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable - Added comments, other misc. code cleanup. #rb josh.markiewicz, sam.zamani, rob.cannaday #tests created cross play parties with multiple pc + ps4 players #jira OR-20332 Change 3065158 on 2016/07/26 by Lina.Halper Fix the guid keep generated by adding to the database. - This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible #rb: Martin.Wilson #jira: UE-33772, UE-33454 #tests: cooked AI_Test map, editor rename curves Change 3064735 on 2016/07/26 by Dmitry.Rekman Linux: added WebRTC libs. - Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc). #rb none #tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform. (Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...) Change 3064727 on 2016/07/26 by Dmitry.Rekman Fix crash on cooker exit (UE-33583). - Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it. #rb none #tests Compiled and ran Linux server and Linux client. (Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...) Change 3064725 on 2016/07/26 by Dmitry.Rekman Linux: use libc++ instead of libstdc++. - Needed to solve problems with third-party C++ libraries (e.g. WebRTC). - Bundled libc++ 3.8.1 (TPS cleared). - Turned off ICU compilation (needs recompile against libc++). - Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix. #rb none #tests Built and ran a number of Linux targets. (Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...) Change 3064572 on 2016/07/26 by Jason.Bestimt #R@BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 29.2 @ CL 3064545 #RB:none #Tests:none #R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/... #R@BOMERGE-BOT: ORION (Main -> Dev-General) Change 3064523 on 2016/07/26 by Jon.Lietz Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements. #RB none #tests BP compiles and stays not dirty #codereview dave.ratti@epicgames.com [CL 3111290 by Andrew Grant in Main branch]
2016-09-01 21:20:38 -04:00
if (Params.ServerCommandline.Length > 0)
{
Args += " " + Params.ServerCommandline;
}
}
Copying //UE4/Orion-Staging to //UE4/Dev-Main (//UE4/Orion-Staging @ 2979119, //Orion/Dev-General @2976565) #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 2976484 on 2016/05/12 by Jason.Bestimt #ROBOMERGE-AUTHOR: nick.atamas Added queueing to HUD Alerts so they don't clobber each other. Added input visualization so that keys show up in game. SRichTextBlock/UOrionRichTextBlock now have a MinDesiredWidth #test PIE #ROBOMERGE-SOURCE: CL 2976474 in //Orion/Release-0.26/... via CL 2976481 via CL 2976482 via CL 2976483 #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 2976256 on 2016/05/12 by Zak.Middleton #ue4 - Fix for shipping build. #tests compiled Change 2976205 on 2016/05/12 by Zak.Middleton #ue4 - (Merge 2957866) Add MaxDepenetration for characters against geometry and pawns. #tests MP PIE PlayGo (Merging CL 2957866 using Framework->DevGeneral) Change 2976166 on 2016/05/12 by Daniel.Lamb Cooking optimziation to unsolicited markup saves 150 seconds paragon cook time. #test Cook paragon Change 2976161 on 2016/05/12 by Zak.Middleton #ue4 - Make sure LastUpdateLocation, Rotation, and Velocity are updated on client and server error corrections. ForcePositionUpdate should call PerformMovement regardless of velocity (there may be root motion or gravity effects). #tests PIE MP w/ real-world networking Change 2976092 on 2016/05/12 by Mieszko.Zielinski Modified adding dynamic subtrees to BT component so that we get a log info if it fails #UE4 #test golden path Change 2976001 on 2016/05/12 by Robert.Manuszewski Don't log to memory on dedicated servers #jira UE-30693 #test Cooked dedicated server and client Change 2975855 on 2016/05/12 by Lukasz.Furman fixed behavior tree serialization spawning duplicates of task services #tests BT editor Change 2975706 on 2016/05/12 by Daniel.Lamb Fixed redirect collector stats. #test Compile Change 2975636 on 2016/05/12 by Jason.Bestimt #ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge DUI @ CL 2975557 #RB:none #Tests:none [CodeReviewed]: matt.schembari, kerrington.smith, tony.oliva, jaymee.stanford, mona.huang, alex.conner, jacob.lawyer, paul.shank #ROBOMERGE-SOURCE: CL 2975635 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 2975592 on 2016/05/12 by Zak.Middleton #ue4 - Add stat for SetHitResultFromShapeAndFaceIndex(). #tests PIE Change 2975589 on 2016/05/12 by Zak.Middleton #ue4 - Avoid filling temp variable unless in Editor builds. It's only used later in the function in Editor builds. #tests PIE Change 2975588 on 2016/05/12 by Zak.Middleton #ue4 - Minor tweak to avoid array read each loop iteration. #tests PIE Change 2975587 on 2016/05/12 by Zak.Middleton #ue4 - Add "IsPlayerController()" function to AController. Variable already existed, just wasn't exposed. #tests PIE Change 2975504 on 2016/05/12 by Daniel.Lamb Remove new stats system because it broke build. #test cook paragon Change 2975500 on 2016/05/12 by Daniel.Lamb Enable redirect timers so I can get stats from build machines. #test cook paragon. Change 2975367 on 2016/05/12 by Jason.Bestimt #ROBOMERGE-AUTHOR: david.nikdel #OGF #CatalogService #OSS #Localization - Flush the cached offers/items in CatalogServiceMcp when the culture changes since they contain localized text - Flush the cached virtual catalog offers/items in McpCatalogHelper when the culture changes since they contain localized text - Replaced SetForceCatalogRefresh with ClearCache per CR with SamZ (will require Launcher fixup) [CodeReviewed]: Sam.Zamani, Matt.Kuhlenschmidt #RB: Sam.Zamani #TESTS: storefront w/ language change #ROBOMERGE-SOURCE: CL 2975366 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 2975209 on 2016/05/12 by Simon.Tovey Fixed initialization order warning. #tests none Change 2975200 on 2016/05/12 by Simon.Tovey Translucency GPU time stats for automation. Refactored separate translucency gpu timer to more general helper class and used it to also time regular translucency. Feeding both of these into a stat to help art identify poorly performing VFX for more detailed investigation. There are occasional spikes when the GPU is starved but overall the data out seems good. #tests GoldenPath, Editor, Auto downsampling works, new stat produces reasonable data. Change 2974984 on 2016/05/11 by Mieszko.Zielinski Fixed a bug in graph-a-star heuristics' calculation #UE4 #test golden path Change 2974916 on 2016/05/11 by Jason.Bestimt #ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 26 @ CL 2974578 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 2974915 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 2974869 on 2016/05/11 by Ben.Marsh BuildGraph: Add a MergeTelemetryWithPrefix="..." parameter to the <Command> task which allows merging the telemetry data from a child UAT run, adding a given prefix to all the key names. #tests none Change 2974673 on 2016/05/11 by Mieszko.Zielinski Fix to BT not stopping if "StopTree" called while BT was waiting for a task to latently abort #UE4 (change by ?ukasz.Furman) #test golden path Change 2974581 on 2016/05/11 by Jason.Bestimt #ROBOMERGE-AUTHOR: matt.kuhlenschmidt Merged CL 2974565 from Release-.26 -> Main: Fixed loc region not saving in shipping builds Partially fixed store not refreshing when changing regions. Real money currency items are pending additional fixes #ROBOMERGE-SOURCE: CL 2974578 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 2974444 on 2016/05/11 by Jason.Bestimt #ROBOMERGE-AUTHOR: richard.fawcett Reimplement support for specifying BuildPatchTool version used in chunking This is now possible after Ben Marsh's fix to BuildGraph with CL 2974407. #tests none #ROBOMERGE-SOURCE: CL 2974441 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 2974408 on 2016/05/11 by Jason.Bestimt #ROBOMERGE-AUTHOR: ben.marsh BuildGraph: Fix support for variable expansion in user-defined enum types. Enums in the schema are now represented as the union of valid values and a regex matching a balanced property expansion string, which still validates/autocompletes cleanly in Visual Studio. #tests none [CodeReviewed] Richard.Fawcett #ROBOMERGE-SOURCE: CL 2974407 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 2974392 on 2016/05/11 by Daniel.Lamb Optimizing resolve string asset reference resolution. Added timing stats (disabled by default). #test Cook paragon. Change 2974349 on 2016/05/11 by Jason.Bestimt #ROBOMERGE-AUTHOR: richard.fawcett Back out changelist 2974298. An issue with the BuildGraph system has prevented this change from working on the build farm. #tests none #ROBOMERGE-SOURCE: CL 2974347 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 2974299 on 2016/05/11 by Jason.Bestimt #ROBOMERGE-AUTHOR: richard.fawcett Add support for chunking builds with the pre-release version of BuildPatchTool. #tests None. This code will be tested by creating a build on the build farm immediately after submission. #ROBOMERGE-SOURCE: CL 2974298 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 2974277 on 2016/05/11 by Lina.Halper Fix up of retargeting when it skips replacing nested reference #tests: retargeting anim BP Change 2974210 on 2016/05/11 by Bart.Bressler Merging Oodle changes from Dev-Networking Change 2939167 on 2016/04/10 by John.Barrett Updated packet bit termination code, so that both UNetConnection's and the PacketHandler use a termination bit (required for both PacketHandler/UNetconnection, as HandlerComponent's such as Oodle, are byte-aligned and do not preserve packet bit size). Added new 'stat packet' stats group, for tracking reserved packet bits. Added '-NoPacketHandler' commandline parameter, for disabling the PacketHandler and all HandlerComponent's (including stateless handshake) - restoring netcode to pre-PacketHandler state. Removed PacketHandler 'packet overhead' method of packet bit size calculation - replaced with termination bit. Still partially used for reserving bits within packets (but renamed to avoid conflict with other 'PacketOverhead' variable). Refactored/consolidated some PacketHandler code. Added more stringent bounds checking on packet sizes. Change 2939168 on 2016/04/10 by John.Barrett Updated Oodle to support new packet bit-termination code. Added Oodle protocol support for selective packet compression (packets can now be sent uncompressed - game code will require a hook for this) - required for new bit-based netcode (Oodle outputs byte-aligned data, allowing compressed data to exceed size of uncompressed data - and thus, maximum packet size if not sent uncompressed - in rare edge cases). Added '-CompressionTest' commandline parameter to Oodle dictionary generation commandlet, which reserves a portion of captured packets, for determining the compression savings percentage. Added '-OodleDebugDump' commandline parameter, which disables normal dictionary generation, and converts packet captures into a .bin file, which is compatible with the Oodle 'example_packet.cpp' code. Added temporary security bandaids to Oodle code, based on report that Luigi Auriemma put together, which deals with potential weaknesses in the Oodle API Added 'stat oodle' stats for tracking failed attempts at compressing packets. Change 2942964 on 2016/04/10 by Ryan.Gerleve Fix broken indentation/formatting Change 2958260 on 2016/04/27 by Bart.bRessler Add branch name and changelist to oodle packet capture filenames. Change 2964360 on 2016/05/03 by John.Barrett Updated Oodle to support using a dictionary and capturing packets at the same time. The dictionary is now always loaded, if specified, and whenever -OodleCapturing is on the commandline, packets are captured alongside the active dictionary. Added several debug commands, to aid with testing compression performance (not QA-ready; only works with 1 player on a server): "Oodle Compression On/Off" - enables/disables packet compression (but still decompresses received compressed packets) "Oodle Dictionary Unload/Load" - unloads/loads the dictionary files, to allow releasing the files for dictionary generation, and reloading the new dictionary. "Oodle Capture On/Off" - Enables/Disables packet capturing at runtime - requires '-OodleCapturing' on commandline. "Oodle ResetStats" - resets the 'stat oodle' stat counters. The NetcodeUnitTest plugin should be enabled, so that these commands can automatically execute on the server as well, as needed. Change 2964553 on 2016/05/03 by Bart.Bressler Add process ID to oodle capture filenames Change 2966247 on 2016/05/04 by John.Pollard Oodle 2.1.5 SDK Change 2968761 on 2016/05/06 by Bart.Bressler - Added changelist number as parameter to most command line tasks to filter captures by their changelist number (use "all" to get everything) - Moved a bunch of the file searching/processing code outside of the tasks themselves so that the tasks all just operate to an array of capture files, this makes it easier to create new command line options - When looking for capture files, we will now recursively search subdirectories Change 2970529 on 2016/05/09 by Bart.Bressler Add an optional "CapturePercentage" command line parameter that has a percentage chance of generating capture files per connection Change 2970874 on 2016/05/09 by Bart.Bressler - Turn on OODLE_DEV_SHIPPING in the Orion server shipping config so that captures can be generated in shipping builds - Link to version 215 of oodle Change 2971233 on 2016/05/09 by Bart.Bressler Update Oodle DLLs in Orion Change 2971362 on 2016/05/09 by Bart.Bressler Create script for building an oodle dictionary out of capture files in an arbitrary location Change 2972176 on 2016/05/10 by Bart.Bressler Update oodle references to version 215 in OodleHandlerComponent.Build.cs #tests used solo vs. ai to test oodle captures and using them Change 2974035 on 2016/05/11 by Simon.Tovey Adding fx.ParticleCollisionIgnoreInvisibleTime to replace hard coded time. This is the time a PSC needs to be invisible for to have all it's collisions ignored. This is potentially the cause of a bug Tim et al are seeing. #tests Editor, Can be used to repro/fix the issue. Change 2973985 on 2016/05/11 by Lina.Halper Retargeting fix with editor saving issue #tests: retargeting Change 2973695 on 2016/05/11 by Jason.Bestimt #ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 26 @ CL 2973469 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 2973694 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 2973679 on 2016/05/11 by Graeme.Thornton UAT parameter -signedpak now no longer implies -pak #tests win64 cooked client. checked that pak generation works as expected through project launcher Change 2973588 on 2016/05/11 by Simon.Tovey OR-21033 - Get physical material from particle collision event exposed in Cascade / Blueprint Particles can now receive collision events selectively based upon the phyisics material of the hit. Physics material is passed through the event and can be accessed in BPs. The Event Receiver Spawn node also now has an array of Allowed and Banned phys materials. #tests Editor and game. Coudln't test cooked as having unrelated crashes in cooked games. Shouldn't be any cooked/uncooked issues here. Change 2973394 on 2016/05/11 by bruce.nesbit Fixed couple of shadow vars #tests compiled Change 2973335 on 2016/05/11 by Andrew.Grant Warning fix #tests compiled Change 2973308 on 2016/05/10 by Dmitry.Rekman Add "unplayable condition" reporting. - The server will report an unplayable condition by creating a local file (under Saved). - An external script can possibly notice this and, applying its own logic on % of servers reporting it, profile or shutdown the whole machine. - Report file is to be deleted by an external script. #tests Compiled and ran Linux server, subjected it to various hitches. Change 2973235 on 2016/05/10 by Zak.Middleton #ue4 - Removed allocs after initial spawn from client saved move processing in character movement. #tests PIE multiplayer w/ Bots Change 2973157 on 2016/05/10 by Olaf.Piesche Merging CL 2973112 from //UE4/Dev-Rendering->//Orion/Dev-General Providing particle source and target for beam emitters #tests editor game PC Change 2972715 on 2016/05/10 by Jason.Bestimt #ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 26 @ CL 2972681 #RB: none #Tests:none #ROBOMERGE-SOURCE: CL 2972712 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 2972678 on 2016/05/10 by Mieszko.Zielinski Fixed babysitter bot not avoiding enemy towers when pathfinding back to base #Orion #jira OR-18590 #test golden path Change 2972595 on 2016/05/10 by Lina.Halper Animation Retargeting fix for blendspaces #code review: Benn.Gallagher, Martin.Wilson #tests: retargeting anim BP Change 2972282 on 2016/05/10 by Daniel.Lamb Optimized string asset reference resolution slightly to help get back missing 10 minutes from paragon cook. #test cook paragon. Change 2972260 on 2016/05/10 by Laurent.Delayen Fixed crash in UCharacterMovementComponent::HasRootMotionSources(). #tests Chains pull not crashing anymore. Change 2972241 on 2016/05/10 by Frank.Fella UMG - Fixes for material animation copied from 4.12. #RB Matt K. #TESTS Struct materials can now be animated and animated materials are named nicely. Change 2971643 on 2016/05/09 by Dmitry.Rekman Add reporting of "zero load" frame times (OR-21035). - Added a thread that does nothing but sleeps and counts how often it missed the target FPS. - Added an analytics event ServerZeroLoadFrameTimeDistribution that is sent at the end of the match. - Server only. #tests Compiled and ran Linux server on a compatible content, played few matches in a row. Change 2971544 on 2016/05/09 by Ben.Marsh EC: Use a full path to the telemetry file, to account for UAT switching directories. Change 2971532 on 2016/05/09 by Wes.Hunt Alter the cook stats hierarchical profile data to reflect the latest cook changes. #tests none Change 2971527 on 2016/05/09 by Ben.Marsh UAT: Move telemetry object into CommandUtils, so we can add stats from anywhere. #tests none Change 2971461 on 2016/05/09 by David.Ratti Fix issues with mesh swap skins: -Front end intro animations not playing -In game spawn animations not playing -Some attachment weirdness (twinblast) #tests golden path Change 2971460 on 2016/05/09 by David.Ratti Fallback to Target actor if there is no instigating actor in the GAmeplayCue parameters when determining if we should play "local only" effects #tests pie Change 2971364 on 2016/05/09 by Ben.Marsh EC: Add support for adding custom telemetry data from UAT scripts, which gets piped through to the trends panel in EC. #tests none Change 2971245 on 2016/05/09 by Dmitry.Rekman Add a "hitchhunter" log message to catch hitches while sleeping. #tests Compiled and ran Linux server on a compatible content. Change 2971196 on 2016/05/09 by jason.bestimt #ORION_MAIN - Merge 25.2 @ CL 2971139 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 2971168 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) #ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human. //Orion/Dev-General/OrionGame/Content/Characters/Heroes/Coil/Audio/Body/Pixie_Cranking_Loop_Cue.uasset - can't branch exclusive file already opened #CodeReview: david.nikdel, jason.bestimt Change 2971113 on 2016/05/09 by Dmitry.Rekman UdpMessaging: Fixed broken filters for when to enable UDP transport. - Redoing MaxP's change from Dev-Sequencer (CL 2963357). - Reduces number of threads spawned by the server. #tests Compiled Linux server, ran it on a compatible content. Change 2971040 on 2016/05/09 by jason.bestimt #ORION_MAIN - Merge 25.2 @ CL 2970990 #RB:none #Tests:none [CodeReviewed]: jon.lietz #ROBOMERGE-SOURCE: CL 2971027 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) #ROBOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human. #CodeReview: david.nikdel, jason.bestimt Change 2970555 on 2016/05/09 by Ben.Marsh BuildGraph: Only show warnings and errors for the SavePackage log during cooks. Prevents redundant display of information that's already in the Cook log. #tests preflight here: https://ec-01.epicgames.net/commander/link/jobDetails/jobs/6443796 Change 2970507 on 2016/05/09 by David.Ratti Support for linking passive abilities to a key binded ability. E.g., allow a passive ability to be unlocked and leveled up in step with a key binded ability. Cleaned up the TryLevel/CanLevelUp code a bit: moved to Orion Ability System Component #tests pie Change 2970414 on 2016/05/09 by Graeme.Thornton Don't take a copy of the child tags array when doing UGameplayTagsManager::FindTagNode, just take a const& #tests win64 client golden path Change 2969729 on 2016/05/06 by Mieszko.Zielinski Fixed a dumb mistake in a conditional expresion in UNavigationQueryFilter::GetQueryFilter #UE4 #test golden path Change 2969675 on 2016/05/06 by Mieszko.Zielinski Implemented "meta navigation filter" that can fetch a filter class based on given agent #UE4 Added NavFilter_AIControllerDefault that fetched DefaultNavigationFilter from AIController Reverted hack-feature that supplied same functionality to EQS #test golden path Change 2969652 on 2016/05/06 by Michael.Noland HLOD: Changed UI gating code so that whether or not a LOD Actor is valid is based on the presence of at least two static mesh components, rather than at least two actors (to improve handling when including BPs) - Repurposed HasValidSubActors for this check, and introduced HasAnySubActors() for the existing uses as this better matches the intent of how the function was used #tests Added a single BP containing 7 mesh components to a new ALODActor and verified that it allowed a proxy to be generated Change 2969651 on 2016/05/06 by Michael.Noland Simplygon: Added time taken for simplygon mesh reduction to the log message #tests Simplified a LOD cluster and inspected the log Change 2969604 on 2016/05/06 by Uriel.Doyon Changed default value to true for UParticleModuleVectorFieldLocal::bUseFixDT. #tests confirmed that default value has changed for old assets, while allowing override. Change 2969418 on 2016/05/06 by jason.bestimt #ROBOMERGE-AUTHOR: andrew.grant Fixed unconverted char string being passed as part of build info #tests ran & verified patch check passes #ROBOMERGE-SOURCE: CL 2969417 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 2968817 on 2016/05/06 by jason.bestimt #ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 25.2 @ CL 2968572 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 2968813 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 2968383 on 2016/05/05 by Mieszko.Zielinski Added "default navigation filter" to AIController #UE4 Also, made EQS take advantage of that #test golden path Change 2968225 on 2016/05/05 by John.Pollard Add sanity checks and more info to help track down possible memory corruption #tests Networking, replication Change 2967903 on 2016/05/05 by jason.bestimt #ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 25.2 @ CL 2967827 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 2967902 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 2967899 on 2016/05/05 by Lina.Halper Merged change of 2956152 Remove invalid ensure - this didn't work if you have composite inside. #tests: none Change 2967870 on 2016/05/05 by Andrew.Grant Fix for OR-20731 (gamever crashes client) #tests gamever at console with -game Change 2967606 on 2016/05/05 by Wes.Hunt Tweaked output log message for HTTP module shutdown. #tests none Change 2967359 on 2016/05/05 by Wes.Hunt HttpManager will log outstanding requests on shutdown so people can debug shutdown issues and ensure their requests get flushed properly. Also changed default LogHttp logging level to display so these messages can be shown by default without using warning level. #tests ran editor build and queued up an event using the console command, then quit immediately. the log indeed showed that HttpManager had to wait at least 0.5 seconds for the request to complete. Change 2966987 on 2016/05/05 by Dmitry.Rekman Fix editor build. #tests Compiled Win64 editor. Change 2966977 on 2016/05/05 by Dmitry.Rekman Added collecting and reporting periodic server frame time distribution. - Added generic FHistogram class and necessary analytic events. - Also added reporting hostname (OR-20842). #tests Built Linux server and ran a few matches on a compatible content. Change 2966920 on 2016/05/04 by jason.bestimt #ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 25.2 @ CL 2966805 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 2966919 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 2966778 on 2016/05/04 by Michael.Noland Rendering: Fixed shadow variable warning in GPUProfiler #tests Compiled and tested GPUProfiler command Change 2966769 on 2016/05/04 by Mieszko.Zielinski Fixed GraphAStar not resetting the output path before fillinf it with results #UE4 #test golden path Change 2966704 on 2016/05/04 by Michael.Noland Rendering: Added triangle and draw call summaries to ProfileGPU output, broken up by asset and material - This is controlled by r.ProfileGPU.PrintAssetSummary, which defaults to 1, but you really need r.ShowMaterialDrawEvents 1 enabled as well for a complete picture - It can also output a summary line for speciifc asset names using a comma separated list in r.ProfileGPU.AssetSummaryCallOuts (e.g., "LOD,HeroName") #tests Used ProfileGPU a number of times Change 2966696 on 2016/05/04 by Michael.Noland Engine: Embedded FPS chart preamble/postamble/row .html files into ChartCreation.cpp to permanently solve packaging woes #tests Tested FPS charts in an uncooked and cooked build #jira OR-19713 Change 2966336 on 2016/05/04 by Lukasz.Furman fixed jungle minions unable to reach spawn locations when camp resets #jira OR-20700 #tests jungle camp POC Change 2965948 on 2016/05/04 by David.Ratti Changes to how passive abilities activate -Passives now continually try to activate by default rather than only on spawn Support for Status.Immortal -Prevents death, fies AbilityTriggerEvent.ImmortalProc when this happens. -Clamps health to 1. Fixed bug in muriel passive where ShieldHealthRegen would be left in the world where muriel died. Fixed bunch of crap in GA_OnSpawn that was causing desync on client at start of match #tests multi pie Change 2965870 on 2016/05/04 by Ryan.Gerleve Duplicated fix from Release-4.12 by marc.audy, CL 2960819: Owned components are once again referenced by their Owning actor for GC purposes #jira UE-29131 #tests golden path Change 2965798 on 2016/05/04 by jason.bestimt #ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 25.2 @ CL 2965789 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 2965796 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 2965220 on 2016/05/03 by Dmitry.Rekman Log instance id and system id (OR-20782). - These ids get reported in multiple analytics events, having them logged is helpful for quickly mapping events to the log file. #tests Compiled Linux server, ran on compatible client. Change 2964907 on 2016/05/03 by Jason.Bestimt #ORION_DG - Merge MAIN @ CL 2964858 #RB:none #Tests:none Change 2964530 on 2016/05/03 by Laurent.Delayen Renamed GetSlotRootMotionWeight to GetSlotNodeGlobalWeight and made it double buffered to it's safe to access anytime. Added GetSlotMontageGlobalWeight() to get the Global Weight of a montage being played on a Slot. (Also double buffered). Added GetInstanceMachineWeight() to get Global Weight of a State Machine in the AnimGraph. (Also double buffered) Added FAnimInstanceProxy::GetStateMachineIndexAndDescription to avoid searching through the AnimNodeProperties twice. #tests Chains full feature system in PIE. Change 2964498 on 2016/05/03 by Frank.Fella DecalComponent - Fix visibility so that it behaves like other scene components with regard to the editor visibility, component visibility, and actor hidden in game flags. #RB Andrew Rodham #TESTS Visibility for decals works like other scene components in the editor, and their visibility can now be animated properly by sequencer. Change 2964428 on 2016/05/03 by Benn.Gallagher Fixed stale clothing chunk/section references after container realloc in editor #tests editor Change 2964316 on 2016/05/03 by bruce.nesbit Banner revisions Banners now use components for various banner items Banners can now be enabled when killing a hero. #tests PIE+Game Change 2964187 on 2016/05/03 by Jon.Lietz Speeding up the tag count check in UAbilitySystemComponent::RegisterAndCallGameplayTagEvent() - Remove the call to GetAggregatedStackCount and creating a FGameplayEffectQuery every time we call RegisterAndCallGameplayTagEvent - Added GetTagCount to the UAbilitySystemComponent that will call GetTagCount on the GameplayTagCountContainer #RB DanY #tests JIP shadow pad still works. Change 2964136 on 2016/05/03 by Laurent.Delayen Fix crash while switching tabs using Persona. #tests not crashing anymore. Change 2964083 on 2016/05/03 by jason.bestimt #ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 25.2 @ CL 2963929 [CodeReviewed]: andrew.grant HTTP Manager has larger stack size (1024) #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 2964080 in //Orion/Main/... #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 2963771 on 2016/05/02 by Nick.Atamas Setting a desired size scale invalidates layout and volatility. #test none Change 2963555 on 2016/05/02 by Rob.Cannaday Fix PS4 Orion players being able to whisper chat with non-Orion players #jira OR-20626 #tests chat with launcher, fortnite Change 2963387 on 2016/05/02 by Laurent.Delayen Added GatherDebugData to FABRIK node. #tests showdebug animation works on Chains now. Change 2963331 on 2016/05/02 by Jon.Lietz fixing compile error, dont need the clamp just the ternary on the EventType and pass down the tag count or 1. #RB none #tests compiles Change 2963106 on 2016/05/02 by Rob.Cannaday Increase HTTP thread's stack size to 128k We discovered a stack overflow when the stack size was 64kb in LavasoftTcpService64.dll (Ad-Aware's Lavasoft Web Companion) #tests log in Change 2963047 on 2016/05/02 by Jon.Lietz OR-20206 for JIP we need to call the bound function if we already have the tag on reconnect. - adding a new function in UAbilitySystemComponent, RegisterAndCallGameplayTagEvent this will bind the passed in delegate and if the ability system has that tag already will execute the delegate. #RB Dave.Ratti #test shadow pad, slow, stun and root still trigger and trigger for JIP players. Change 2962836 on 2016/05/02 by jason.bestimt #ROBOMERGE-AUTHOR: andrew.grant [NULL MERGE] Duplicating 2961899 - Fix minimal code builds for Linux not overwriting files [CodeReviewed] Ben.Marsh #ROBOMERGE-SOURCE: CL 2962812 in //Orion/Release-0.24.2/... via CL 2962830 via CL 2962833 via CL 2962834 via CL 2962835 #ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 2962570 on 2016/05/02 by Jason.Bestimt #ORION_MAIN - Merge MAIN @ CL 2962544 #RB:none #Tests:none Change 2962552 on 2016/05/02 by Ben.Marsh Avoid output of warnings containing the string "error:" (and causing the EC post processor to fail the build) if posting build info has a human-readable error message instead. Output should probably be changed to parse out/sanitize the actual failure message if it's meant to retry and succeed, but this will stop failures caused by multiple builds being posted with the same build version. #tests none Change 2962506 on 2016/05/02 by Ben.Marsh Add a version string to identify a given build (FApp::GetBuildVersion()/BUILD_VERSION) which is distinct from the engine version. Defaults to <Escaped Branch Name>-CL-<Changelist>, but can be overriden by specifying a -Build=... argument to UpdateLocalVersion or the "Build" attribute to the SetVersion BuildGraph task. #tests Preflighted Win64 client/server build (P:\Builds\Orion\++Orion+Dev-General-CL-2962228-PF-2945494-6398155-PF-2945494-6398155) and loaded into Agora. Checked that version strings appear correctly in generated executables. Change 2962228 on 2016/04/30 by Dmitry.Rekman Move processing HTTP requests into separate thread (OR-20723). - First iteration of the implementation, pending implementing feedback. - Adds a separate thread for CurlHttp where actual processing is performed. - Coded by RobC, post-processed by me. #tests Compiled Linux server and Windows client, ran them on compatible content, played a match. Change 2961899 on 2016/04/29 by Ben.Marsh BuildGraph: Fix minimal Linux server builds not overwriting the existing executables, by adding an "Overwrite" parameter into the staging task. Windows exe-only patches already happen to bypass this bug by deleting the Binaries/Win64 directory (designed to remove any configurations that weren't built this time), but could still fail if changes had been made to some other staged binaries. #tests preflighted code-only build against DG CL 2960870 and compared output (P:\Builds\Orion\++Orion+Dev-General-CL-2961878-PF-2961895-6393603) Change 2961587 on 2016/04/29 by Daniel.Lamb Redirector doesn't fire callback if it fails to be loaded. #test Cook orion. Change 2961458 on 2016/04/29 by Wes.Hunt Cooker Stats improvements. Also removed some old UBT telemetry that was not being used. #tests many cooks of orion Change 2961136 on 2016/04/29 by Daniel.Lamb Readded caching of platform data into postload of materials. #test Cook paragon. [CL 2979220 by Ben Marsh in Main branch]
2016-05-16 16:20:52 -04:00
if (ServerParams.UsePak(SC.StageTargetPlatform))
{
if (ServerParams.SignedPak)
{
Args += " -signedpak";
}
else
{
Args += " -pak";
}
}
if (IsBuildMachine || Params.Unattended)
{
Args += " -buildmachine";
}
Args += " -CrashForUAT";
Args += " " + AdditionalCommandLine;
Copying //UE4/Dev-Mobile to //UE4/Dev-Main (Source: //UE4/Dev-Mobile @ 3056055) #lockdown Nick.Penwarden #rb None ========================== MAJOR FEATURES + CHANGES ========================== Change 3011102 on 2016/06/13 by Steve.Cano After taking a screenshot using glReadPixels, transfer the data to the target buffer from bottom row up to fix the "upside-down" render that OpenGL does. Confirmed with QA (owen.stupka_volt) that this does not appear to be happening on iOS (non-metal devices, inclusion of iOS in write-up was a mistake), verified on an ipod touch 5. Also confirmed that this does not happen on html5, and that Mobile HDR flag does not make a difference in function. #jira UE-26421 #ue4 #android Change 3015801 on 2016/06/16 by Dmitriy.Dyomin Probbably fix for UE-30878, was not able to repro an actual crash(FFoliageInstanceBaseCache::AddInstanceBaseId). Added even more logging in case fix does not work. #jira UE-30878 Change 3015903 on 2016/06/16 by Dmitriy.Dyomin Fixed: Levels window has Refresh/UI issues when World Composition is active #jira UE-26160 Change 3018352 on 2016/06/17 by Chris.Babcock Handle Android media prepare failure (URL without internet for example) #jira UE-32029 #ue4 #android Change 3026387 on 2016/06/24 by Jack.Porter Remove FFuncTestManager warning about PIE when running on a standalone game binary Change 3026398 on 2016/06/24 by Jack.Porter Prevent FSocketBSD::Recv returning false on SE_EWOULDBLOCK Change 3027553 on 2016/06/25 by Niklas.Smedberg OpenGL: Made some block size calculation work for arbitrary block sizes (e.g. not pow-of-two). Change 3027554 on 2016/06/25 by Niklas.Smedberg Metal: copyFromTexture now gets block-aligned size parameter (e.g. used for texture streaming) Change 3028061 on 2016/06/26 by Jack.Porter Fixed a problem where newly discovered instances were not added to an existing session in the Session Browser. Fixed a problem where selecting an instance in a session with multiple instances didn't deselect the previously selected instance correctly. Change 3029220 on 2016/06/27 by Steve.Cano Change Android Tilt values to use GetRotationMatrix/GetOrientation logic, same as java-side android would use, and adjust slightly to match as closely as possible to iOS values for tilt. There is drift and some differences in the "Y" value but the same sort of inconsistencies are also seen on iOS. #jira UE-6135 #ue4 #android Change 3030420 on 2016/06/28 by Jack.Porter Fix crash with RenderOutputValidation when running with cooked content Change 3030426 on 2016/06/28 by Jack.Porter Fix to CL 3026398 - make FSocketBSD(IPv6)::Recv(From) return false when recv returns 0. A return value of 0 indicates the connection was shutdown in an orderly manner. Change 3030973 on 2016/06/28 by Steve.Cano Added a landscape downloader background along with the options to change it from within Android settings #ue4 #android #jira UE-32318 Change 3031757 on 2016/06/28 by Chris.Babcock Remove unused methods from AndroidJNI header #ue4 #android Change 3032387 on 2016/06/29 by Allan.Bentham Rename android es31+aep -> glesdeferred. Change 3032711 on 2016/06/29 by Allan.Bentham Rename GLSL_310_ES_EXT shader define: ES31_AEP_PROFILE -> ESDEFERRED_PROFILE bumped UE_SHADER_GLSL_310_ES_EXT_VER version number. Change 3033698 on 2016/06/29 by Jack.Porter Merging //UE4/Dev-Main to Dev-Mobile (//UE4/Dev-Mobile) Change 3034210 on 2016/06/30 by Steve.Cano Added a new AndroidRuntimeSettings variable that allows creation of installers for both Windows and Mac/Linux if set to true. #jira UE-32302 #ue4 #android Change 3034530 on 2016/06/30 by Chris.Babcock Rename FManifestReader to FAndroidFileManifestReader in AndroidFile #jira UE-32679 #ue4 #android Change 3034612 on 2016/06/30 by Steve.Cano Change Alpha from being set to a range of 0-255 to being in a range of 0-1 (which is the correct range of values) #jira UE-25325 #ue4 #android Change 3034679 on 2016/06/30 by Chris.Babcock Fix tooltip (.command for mac, not .sh) #jira UE-32302 #ue4 #android Change 3038881 on 2016/07/05 by Jack.Porter Package and launch on multiple Android devices simultaneously using the -Device=xxxxxxx+yyyyyyyy+zzzzzzzz format generated by a Project Launcher profile when you select multiple devices #jira UEMOB-115 Change 3039240 on 2016/07/06 by Jack.Porter TcpMessageTransport - connection-based message bus transport. #jira UEMOB-112 #jira UEMOB-113 Change 3039252 on 2016/07/06 by Jack.Porter Enable messaging and session services and functional testing on Android when launched with -messaging Android device detection module support for adding port forwarding and connection announcement for TcpMessageTransport #jira UEMOB-112 #jira UEMOB-113 Change 3039264 on 2016/07/06 by Jack.Porter Merging //UE4/Dev-Main to Dev-Mobile (//UE4/Dev-Mobile) Change 3040041 on 2016/07/06 by Chris.Babcock Pass proper value to script generator functions #jira UE-32861 #ue4 #android Change 3040890 on 2016/07/07 by Allan.Bentham Fix shadow crash #jira UE-32884 Change 3041458 on 2016/07/07 by Peter.Sauerbrei fix for IOS launch on failures Change 3041542 on 2016/07/07 by Peter.Sauerbrei better fix for the multi-device deployment issue Change 3041774 on 2016/07/07 by Steve.Cano Fixing crash that occurs when a games app id for Google Play is set before configuring the apk packaging. Also validating the value that is inserted and using it to override any values that have been hand-inserted into the GooglePlayAppID.xml #jira UE-16992 #android #ue4 Change 3042222 on 2016/07/08 by Dmitriy.Dyomin Mobile packaging scenarious Added a wizard for creating launcher profiles (Android & IOS) for scenario: Minimal App + Downloadable content Added Archive step to launcher profiles to be able to store build product into specified directory Changes to a cooker to be able to pack DLC based with a different flavor to a release App Changes to DLC packaging to be able to build streaming data without chunking pak files #jira UEMOB-119 Change 3042244 on 2016/07/08 by Dmitriy.Dyomin Fixed crash in FTcpMessageTransportConnection::Stop Change 3042270 on 2016/07/08 by Dmitriy.Dyomin GitHub #2320 : [ULevelStreamingKismet] Load Level Instance, Enables UE4 Users to create multiple transformed instances of a .umap without having to include in persistent level's list ? Rama contributed by: EverNewJoy #jira UE-29867 Change 3042449 on 2016/07/08 by Dmitriy.Dyomin Fixing Mac Editor build erros from CL# 3042222 Change 3042480 on 2016/07/08 by Allan.Bentham Add ES3.1 profile & compiler_glsl_es3_1 to shaders. Change 3042481 on 2016/07/08 by Allan.Bentham hlslcc - ES3.1 changes. set ES3.1 version number to 310 Do not use ES2 keywords for ES3.1. Generate Layout Locations for ES3.1 bump version. Change 3042483 on 2016/07/08 by Allan.Bentham Add mobile ES3.1 support. Recreates EGL and ES3.1 context during PlatformInitOpenGL if ES3.1 is required. Change 3042485 on 2016/07/08 by Allan.Bentham Undo android XGE change. Change 3042506 on 2016/07/08 by Dmitriy.Dyomin One more compile fix from CL# 3042222 Change 3044173 on 2016/07/10 by Dmitriy.Dyomin UAT: Added support for building target platforms with multiple cook flavors ex: -targetplatform=Android -cookflavor=ETC1+ETC2 Change 3044213 on 2016/07/11 by Dmitriy.Dyomin Fixed: Can't stream in a level whose name is a substring of another streaming level #jira UE-32999 Change 3044221 on 2016/07/11 by Jack.Porter Merging //UE4/Dev-Main to Dev-Mobile (//UE4/Dev-Mobile) Change 3044815 on 2016/07/11 by Allan.Bentham Corrected NAME_GLSL_ES3_1_ANDROID format string. Change 3046911 on 2016/07/12 by Chris.Babcock Add handling of OnTextChanged for virtual keyboard input on Android #jira UE-32348 #ue4 #android Change 3046958 on 2016/07/12 by Chris.Babcock Rename some functions with Error in the name to prevent false coloring in the logs #jira UE-30541 #ue4 #android Change 3047169 on 2016/07/12 by Chris.Babcock Return player ID and handle auth token for Google Play Games on Android (contributed by gameDNAstudio) #jira UE-30610 #pr #2372 #ue4 #android Change 3047406 on 2016/07/12 by Jack.Porter Add missing import to GameActivity.java Change 3047442 on 2016/07/13 by Dmitriy.Dyomin Added: Mobile custom post-process Limitations: can fetch only from PostProcessInput0 (SceneColor) other scene textures are not supported. Does not support "Replacing the Tonemapper" blendable location. #jira UEMOB-147 Change 3047466 on 2016/07/13 by Dmitriy.Dyomin Disabled engine crash handler on Android, system crash handler works more reliably across different os versions/devices Change 3047746 on 2016/07/13 by Jack.Porter Rename FBasePassFowardDynamicPointLightInfo Change 3047778 on 2016/07/13 by Jack.Porter Missing file for rename FBasePassFowardDynamicPointLightInfo Change 3047788 on 2016/07/13 by Allan.Bentham Fix incorrect TargetPlatformDescriptor string generation. Change 3047790 on 2016/07/13 by Allan.Bentham Fixed half3x3 matrix use with ES3.1 glsl Fixed couple of interpolator precision mismatch. Fixed ES3.1 support detection issues Change 3047816 on 2016/07/13 by Allan.Bentham Remove AndroidGL4 remnants. Change 3048926 on 2016/07/13 by Chris.Babcock Added detection of Amazon Fire TV to disable requiring virtual joysticks #ue4 #android Change 3049335 on 2016/07/14 by Dmitriy.Dyomin Fixing UAT crash when packaging project for iOS Change 3049390 on 2016/07/14 by Jack.Porter Disabled error for warning 4819 "The file contains a character that cannot be represented in the current code page (xxx). Save the file in Unicode format to prevent data loss" This is triggered by European characters and copyright symbols in source saved as latin-1 when compiling on non-US windows. Seen often in 3rd party headers, eg nvapi. #code_review: Ben.Marsh Change 3049391 on 2016/07/14 by Jack.Porter Fixed incorrect comment order in CL 3049390 Change 3049545 on 2016/07/14 by Dmitriy.Dyomin Reworking some code from CL#3047442 to make static analizer happy Change 3049626 on 2016/07/14 by Allan.Bentham Automatic CSM shader toggling #jira UE-27429 Change 3051574 on 2016/07/15 by Jack.Porter Support for lighting channels on Mobile - Multiple directional lights are supported in different channels but primitives are only affected by the directional light in the first channel they have set - CSM shadows from stationary or movable directional lights correctly follow their lighting channels - No channel limitations for dynamic point lights Notes: Removed mobile-specific directional light shadowing fields from View uniform buffer and mobile no longers uses SimpleDirectionalLight. Separate uniform buffers for mobile directional light are generated for each lighting channel. CSM culling information is now stored in FViewInfo and not per FVisibleLightViewInfo as the visibility bits are per view. #code_review Daniel.Wright #jira UEMOB-110 Change 3051699 on 2016/07/15 by Steve.Cano Preserve the original, pre-transformed input vertices for Slate shaders, which is required to properly do anti-aliasing (the ViewProjection-transformed values were causing the lines to not be drawn). #jira UE-20320 #ue4 #android Change 3051744 on 2016/07/15 by Chris.Babcock Fix Android Vulkan include path checks (contributed by kodomastro) #jira UE-33311 #PR #2602 #ue4 #android Change 3052023 on 2016/07/15 by Chris.Babcock Fix shadowed variables Change 3052110 on 2016/07/15 by Chris.Babcock Compile fixes for light channel support on mobile - missing template - accessor function for MobileDirectionalLights from scene Change 3052242 on 2016/07/15 by Chris.Babcock Compile fixes for light channel support on mobile - removed dependency on C++14 feature Change 3052730 on 2016/07/16 by Dmitriy.Dyomin Win32 build fix Change 3053041 on 2016/07/17 by Jack.Porter Merging //UE4/Dev-Main to Dev-Mobile (//UE4/Dev-Mobile) Change 3053054 on 2016/07/17 by Jack.Porter Changed use of old function ShouldUseDeferredRenderer() to new GetShadingPath() Change 3053055 on 2016/07/17 by Jack.Porter Fixed local variable aliasing in unity build Change 3053206 on 2016/07/18 by Jack.Porter Support ExecuteJavascript on iOS and Android Expose ExecuteJavascript to widget blueprint Fix ExecuteJavascript unicode string support on desktop platforms #jira UEMOB-152 Change 3053323 on 2016/07/18 by Dmitriy.Dyomin Added: Ability to set thread affinity for a device in Device Profiles (ex: +CVars=android.SetThreadAffinity=RT 0x02 GT 0x01) #jira UEMOB-107 Change 3053723 on 2016/07/18 by Jack.Porter Fix for UnrealTournamentProto.Automation.cs build errors Change 3055090 on 2016/07/19 by Dmitriy.Dyomin Junk OnlineBlueprintSupport module binaries [CL 3056789 by Jack Porter in Main branch]
2016-07-19 19:13:01 -04:00
if (ServerParams.Cook && ServerPlatformDesc.Type == UnrealTargetPlatform.Linux && !String.IsNullOrEmpty(ServerParams.ServerDeviceAddress))
{
Args += String.Format(" 2>&1 > {0}", ServerLogFile);
}
PushDir(Path.GetDirectoryName(ServerApp));
var Result = Run(ServerApp, Args, null, ERunOptions.AllowSpew | ERunOptions.NoWaitForExit | ERunOptions.AppMustExist | ERunOptions.NoStdOutRedirect);
PopDir();
return Result;
}
Copying //UE4/Dev-Platform to //UE4/Dev-Main (Source: //UE4/Dev-Platform @ 3120366) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 2714591 on 2015/10/02 by Ben.Marsh Initial branch of files from Engine-Main (//UE4/Engine-Main) to Dev-Platform (//UE4/Dev-Platform) Change 2916715 on 2016/03/21 by Daniel.Lamb First pass at splitting out build cook run into into seperate scripts. Change 2948322 on 2016/04/19 by Nick.Shin update libwebsockets to v1.7.4 part 4 of 4 - doing this in stages for tracking purposes #jira UEPLAT-1246 - Update libWebsockets #jira UEPLAT-1221 - update websocket library #jira UEPLAT-1204 - Rebuild libwebsockets with SSL Change 2970016 on 2016/05/07 by Nick.Shin undo all of the following upgrades: - zlib - openssl - libcurl - libwebsockets and reset webrtc #jira UE-30298 - Fortnite and Orion crash on login Change 3059693 on 2016/07/21 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3061151 on 2016/07/22 by Niklas.Smedberg Fast ASTC texture compression, using ISPC. #jira UE-32308 Change 3061428 on 2016/07/22 by Peter.Sauerbrei Back out changelist 3061151 as it wasn't approved for submission Change 3061970 on 2016/07/22 by Steve.Cano Adding AdMob interstitital ad support for Android, including Blueprint functions #jira UE-33286 #ue4 #android Change 3062160 on 2016/07/22 by Mark.Satterthwaite Fix the fix for handling RHISetStreamSource overriding stride on Metal - not all MTLVertexDescriptors are equally hashable so do this ourselves. #jira UE-33355 Change 3062770 on 2016/07/24 by Brent.Pease UE-32397 Error Message displays as Unknown Error when failing to supply a Remote Build server for ios on Windows Change 3063227 on 2016/07/25 by Dmitry.Rekman Update hlslcc cross-compile after libc++ change. Change 3063314 on 2016/07/25 by Jeff.Campeau Xbox One DLL loading Receipts can be read back by request for target info Change 3063329 on 2016/07/25 by Mark.Satterthwaite CL #3046743 was breaking other samples in unexpected ways after a recent Main merge, so make a Metal-specific change to the shader instead and amend the MetalBackend to better match HLSL's handling of NaN/inf with common single-precision float intrinsics. This is sufficient to fix the AtmosphericFog and the recent regressions. #jira UE-33600 #jira UE-33028 #jira UE-27879 #jira UE-25802 Change 3063492 on 2016/07/25 by Brent.Pease UE-23846 - iOS Movie Player can't handle videos at resolutions that aren't multiples of 16 UE-33200 - A movie isn't played on iOS occasionally. Change 3063729 on 2016/07/25 by Dmitry.Rekman Linux: enable XGE on all platforms. #tests Cross-compiled a number of Linux targets on Windows. Change 3063732 on 2016/07/25 by Dmitry.Rekman Fixed formatting (spaces->tabs) in previous change. Change 3063750 on 2016/07/25 by Daniel.Lamb Added code to dump the cook modification delegate loads to log. Fixed the memory usage output log. #test cook paragon. Change 3063804 on 2016/07/25 by Daniel.Lamb Added cookpartialgc additional commandline option to uat. #test UFE Change 3064008 on 2016/07/25 by Mark.Satterthwaite For non-shipping builds conditionally bind a default uniform buffer in Metal and report an error if the slot was unbound, if our validation layer is enabled attempt to report the shader source in question. This relies on the shader compiler providing accurate information about uniform buffer bindings and won't fix all occurances of bad uniform usage (if a buffer is bound but too short the result will be GPU restarts or an error in Apple's validation layer - we can't detect this case) but will help debug the typical error of leaving an active slot unbound. #jira FORT-27685 Change 3064141 on 2016/07/25 by Jeff.Campeau Rebuild vpxmd.lib with delayed codegen disabled (fixes linker warning building Win64). Change 3065024 on 2016/07/26 by Nick.Shin Change filetype remove exclusive check out bit requested by or.coheni & nick.penwarden Change 3065274 on 2016/07/26 by Jonathan.Fitzpatrick DirectoriesToAlwaysStageAsUFS now properly filters out *.uasset and *.umap files This prevents the bug where cooked assets get trampled by staging their uncooked version on top of them during the UFS step Added a file filter to DirectoriesToAlwaysStageAsUFS for uasset and umap. Change 3066338 on 2016/07/27 by Mark.Satterthwaite Handle releasing an SRV/UAV & the source object within a single Metal command-buffer. #jira UE-33779 Change 3066789 on 2016/07/27 by Daniel.Lamb Realtime mode does not save any packages anymore unless they are ready. #test cookontheside, cookbythebook shooter game Change 3066847 on 2016/07/27 by Jeff.Campeau Fix define #2634 #jira UE-33813 Change 3068868 on 2016/07/28 by Mark.Satterthwaite Extend hlslcc's handling of switch-statements to allow implict casts from scalar bool, half & float as HLSL itself permits while also making sure it errors if the expression input is not scalar. This fixes shader compile errors in UT. Change 3070040 on 2016/07/29 by Dmitry.Rekman Delete Nadzorca. Change 3070947 on 2016/07/29 by Jeff.Campeau Perforce C++ API 2015.2 (includes debug libraries) Change 3073707 on 2016/08/02 by Daniel.Lamb Derived data cache commandlet runs resolve string asset references to load any string asset refereced packages from the map. Also process async results from shaders being compiled so they can have their memory resources released. #test DerivedDataCache commandlet shootergame. Change 3076613 on 2016/08/03 by Brent.Pease + UnrealTargetConfiguration is now passed into deploy and package methods + The UIRequiredDeviceCapabilities plist key now only considers the architectures from the corresponding target configuration (shipping or development) Change 3076668 on 2016/08/03 by Brent.Pease Back out changelist 3076613 Change 3077157 on 2016/08/04 by Daniel.Lamb Fixed up DLC staging so that it stages to the proper mount point. Fixes up include engine content in DLC staging paths. #test Made up shooter game DLC Change 3077191 on 2016/08/04 by Daniel.Lamb More smartly process async shader compilation if we are waiting for it. #test cook on the side shooter game cook by the book shooter game. Change 3077412 on 2016/08/04 by Mark.Satterthwaite Fix "iOS Metal-based build crashes at launch with sub-levels": - Slate should not bind the null RHI texture from an unitialised texture atlas - atlases only have a valid texture pointer once an entry has been added to them and in the template projects an empty sub-level doesn't add anything. - To prevent this kind of bug resurfacing and being so hard to track down add Metal shader binding validation to our validation layer as Apple's is incomplete on iOS and won't warn us about nil texture usage which causes these GPU restarts. This requires reworking our vertex declaration handling to be more efficient so that we can cache the pipeline reflection data as well as the pipeline objects. - Fix validation error of texture reallocation on loading template projects under Metal. #jira UE-30847 Change 3077958 on 2016/08/04 by Brent.Pease + UnrealTargetConfiguration is now passed into deploy and package methods + The UIRequiredDeviceCapabilities plist key now only considers the architectures from the corresponding target configuration (shipping or development) Change 3079503 on 2016/08/05 by Mark.Satterthwaite Initialise more variable types to 0 in Metal shaders to workaround Xcode 8 toolchain no longer doing this for us for "threadgroup shared" variables. Everything but structs and atomic's will now be initialised. #jira UE-33856 Change 3079737 on 2016/08/05 by Jeff.Campeau Add support for delay load DLLs on Xbox One Turn off warnging for missing PDBs to match VCToolchain.cs Change 3081005 on 2016/08/08 by Mark.Satterthwaite Fix-up Metal device name on AMD for macOS 10.12 which reports it correctly and enable tiled reflections on Intel from macOS 10.12 too as they now work. Change 3081557 on 2016/08/08 by Daniel.Lamb File-> Package saves all packages before starting packaging. #test File package first person template Change 3082215 on 2016/08/09 by Lee.Clark PS4 - Added 4k profile Change 3082412 on 2016/08/09 by Daniel.Lamb Fixed cook on the fly server not handling cook requests. #test Cook on the fly shooter game. Change 3082955 on 2016/08/09 by Dmitry.Rekman Linux: convert existing Strcat() uses to Strncat(). - Strcat() does not check destination size so can silently corrupt memory. While this was not observed, this conversion removes this concern altogether. Change 3083772 on 2016/08/10 by Luke.Thatcher [PLATFORM] [PS4] [+] Checking in PS4CrashHandler files so we have a copy in Perforce rather than just on the server. - Taken from \\devweb-02 and removed all the unused files/dependencies. - Created a publish profile pointing to \\devweb-02\Sites\PS4Services\PS4CrashHandlerDev so I'm not writing over the existing deployed crash handler. - Moved all code in the Page_Load event to inside the check for the HTTP method (POST) otherwise GET'ing the page from a browser will generate crash folders that hang around forever. Change 3085450 on 2016/08/11 by Lee.Clark PS4 - Fix mediaplayer pipeline allocation Change 3086360 on 2016/08/11 by Michael.Trepka Fixed a non-unity build error in Mac UnrealFrontend Change 3087224 on 2016/08/12 by Luke.Thatcher [PLATFORM] [PS4] [~] Refactor PS4 Crash Handler site - Removed CoreDumpHandler. Processing dump files is handled directly by an async thread within the aspx process. - Separated configuration values into their own class. Currently set to output to a testing directory, rather than the actual crash reporter landing zone. - Added a debug upload page to allow manual submission of .orbisdmp/.txt settings files, accessible by GET'ing Default.aspx. - Added logging. Logs self-delete after 30 days. Testing required before we switch to the new system. #jira UE-34504 #jira OR-26886 Change 3087626 on 2016/08/12 by Dmitry.Rekman PR #2689: Fix copying/duplicating failing on Linux (UE-34586). - Contributed by Web-eWorks. Change 3087991 on 2016/08/12 by Mark.Satterthwaite Initial AVFoundation implementation of Media Framework for Mac, iOS & tvOS. - Video playback occurs via AVPlayerItemVideoOutput's attached to the AVPlayerItem's output. This means gathering video samples is trivial. - Metal texture updates occur by wrapping the texture object provided by AVF - for Mac this is simple as it can bind to the IOSurface directly, for iOS/tvOS we have to create a CVMetalTextureCache and allocate our texture from there. - OpenGL and OpenGLES currently have to lock the pixel buffer and upload to a texture the old fashioned way - this should be revisited when there is time. - Subtitles/Captions are captured using AVPlayerItemLegibleOutput which also connects to the AVPlayerItem's output. - On Mac audio samples are returned by manually reading from the stream using an AVAssetReaderTrackOutput, including manual seeking and synching. - On iOS/tvOS the audio is played directly by AVPlayer because the IOSAudio system can't handle procedural buffers - otherwise it could reuse the Mac code. - AVFoundation does not support AVI - that's an obsolete Microsoft/Windows file-format. - Only 'file://' URLs are supported - streaming would require a totally different audio solution (using MTAudioProcessingTap) and has many more edge and failure cases that would need to be handled. #jira UE-34315 Change 3088790 on 2016/08/15 by Luke.Thatcher [PLATFORM] [PS4] [~] Hook new PS4 crash handler up to the crash reporter website. - Removed indentation from generated crash context XML file. The crash reporter process does manual XML parsing which doesn't correctly handle whitespace at the start of lines. - Switched the final output folder to match the one the crash reporter process is watching. - Hide upload form on a config variable. #jira UE-34504 #jira OR-26886 Change 3089060 on 2016/08/15 by Luke.Thatcher [PLATFORM] [PS4] [!] Change PS4 crash handler log file extension to ".ps4chlog", otherwise the crash reporter site attaches the wrong log file to the crash report. Allowed showing of debug upload form via "Default.aspx?showform=1" query string. #jira UE-34504 #jira OR-26886 Change 3089089 on 2016/08/15 by Mark.Satterthwaite Duplicated changes to AppleMovieStreamer from CL #3088149. #jira UE-34315 Change 3089460 on 2016/08/15 by Mark.Satterthwaite Duplicate CL #3080971: Workaround a macOS 10.12 Beta bug on some Metal drivers that can't initialise temporary/local variable arrays, only those that are marked threadgroup shared. #jira UE-34355 Change 3089465 on 2016/08/15 by Mark.Satterthwaite For Metal shader translation retain more precision for float constants -1.0f >< 1.0f by emitting them in scientific notation - prevents Hammersley constant amongst others from being flushed to 0. Change 3089902 on 2016/08/15 by Daniel.Lamb Changed the next compiling ID to the correct compiling ID. #test Cook Change 3089903 on 2016/08/15 by Daniel.Lamb Cooker monitors config useage during cook and uses those settings to invalidate cooked content instead of all config settings. Change 3090114 on 2016/08/16 by Luke.Thatcher [PLATFORM] [PS4] [~] Minor change to PS4 settings text on crash handler site. Change 3090949 on 2016/08/16 by Nick.Shin WebSocketNetDriver crash fix filled in missing chunk of code that calls PacketHandler's "packet modifiers" #jira UE-25492 HTML5 Client cannot connect to Windows Server #jira UE-30880 WinServer crashes when NetDriver is set to WebSocket and Client attempts to connect via websocket #code.review john.pollard john.barrett Change 3091265 on 2016/08/16 by Brent.Pease Add IOS support to HarfBuzz Change 3091267 on 2016/08/16 by Brent.Pease Add references to fix mono build Change 3091291 on 2016/08/16 by Nick.Shin CIS warning fix #jira UE-25492 HTML5 Client cannot connect to Windows Server #jira UE-30880 WinServer crashes when NetDriver is set to WebSocket and Client attempts to connect via websocket Change 3091781 on 2016/08/17 by Joe.Barnes UE-33640: Exposed UPrimitiveComponent::IsAnyRigidBodyAwake() to Blueprints. Change 3092687 on 2016/08/17 by Daniel.Lamb Added support for using binned allocator in cooker instead of tbb. #test Cook shootergame. Change 3093867 on 2016/08/18 by Mark.Satterthwaite Use a read/write mutex to protect access to Metal's internal shader pipeline caches so that parallel threads can progress in the common case where new shaders are not being compiled. Change 3093950 on 2016/08/18 by Mark.Satterthwaite Change the Mac GPU identification code to cope with AMD's new naming scheme on 10.12. Change 3093951 on 2016/08/18 by Mark.Satterthwaite More SCW threads on Mac - they work now. Change 3093960 on 2016/08/18 by Mark.Satterthwaite Increase the default number of command-buffers on Mac because bigger games overflow the current limit of 64 per queue. Change 3096493 on 2016/08/22 by Jeff.Campeau Use Xbox version of DirectX include. Change 3097509 on 2016/08/23 by Luke.Thatcher [PLATFORM] [PS4] [+] Refactor PS4 Symbol Publish - Moved the SymStore task from Win.Automation to BuildGraph.Automation, and made it more generic. - The specifics of uploading symbols are now implemented in the platform tool chain, alongside StripSymbols(). - Re-generated the build graph schema file. - Removed the old PS4 symbols upload path in the package step. Modified OrionBuild.xml to publish symbols for all PS4 dev, test and shipping config builds of OrionClient. Change 3097635 on 2016/08/23 by Luke.Thatcher [PLATFORM] [PS4] [+] Refactor Age Symbols task in UAT. - Moved the AgeStore task from Win.Automation to BuildGraph.Automation and made it more generic. - Symbol server directory structure is now defined by the platform tool chain, which the common task uses to clean out old symbols. - Added a "filter" parameter to prevent age tasks deleting symbols from unrelated builds in shared symbol servers. Modified OrionBuild.xml to age both the Windows and PS4 symbol stores. Change 3097713 on 2016/08/23 by Luke.Thatcher [PLATFORM] [PS4] [+] Enable new PS4 crash handler server - Created live deployment profile and applied the required config file changes. Change 3099214 on 2016/08/24 by Luke.Thatcher [PLATFORM] [PS4] [!] Fix compile error in PS4 tool chain. For some reason, this only breaks ocassionally. Maybe we're alternating between the 2013 and 2015 C# compilers depending on what initiates the build (e.g. Visual Studio vs GenerateProjectFiles)? Change 3099222 on 2016/08/24 by Luke.Thatcher [PLATFORM] [PS4] [+] Added PS4 support for FPlatformMisc::MessageBoxExt using the MsgDialog library. - Note, only one and two button message dialogs are supported (limitation of MsgDialog). Change 3099260 on 2016/08/24 by Luke.Thatcher [PLATFORM] [PS4] [~] Better PS4 exit function. Calls quick_exit instead of abort when we've not asserted. Allows for a "cleaner" forced exit without generating a crash dump. Change 3101192 on 2016/08/25 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3101944 on 2016/08/25 by Daniel.Lamb Ask to save the current level when we are using launch on. Change 3102036 on 2016/08/25 by Nick.Shin check for minimum expected size upon data received from network #jira UE-13657 - HTML5 plugin OnRawRecieve overflow Change 3102115 on 2016/08/25 by Brent.Pease - Fix small errors that probably only show up in the mac mono build #code.review peter.sauerbrei Change 3102747 on 2016/08/26 by Jeremiah.Waldron Re-submitting OnlineSubsystemGameCircle with TPS permission for Amazon SDK - Also fixed the plugin to remove any related files from the final package when IAP is disabled or GameCircle support itself is disabled with the plugin still enabled - Added support for new AlreadyOwned IAP response code as well which is already used for GooglePlay and IOS Change 3102900 on 2016/08/26 by Nick.Shin since last checkin (CL: 2981945) - prints are crashing the browser - this change will allow browser to print the details via console.log() #jira UE-26047 - HTML5 HTTP Response Headers not implemented Change 3103130 on 2016/08/26 by Brent.Pease UE-24679 - Enable the ability to change ports for a firewall to pass them through rsync Change 3103225 on 2016/08/26 by Daniel.Lamb Fixed issue with warning which would cause crash. Change 3103425 on 2016/08/26 by Dmitry.Rekman Enable offscreen GL rendering without X. - Added new video subsystem to SDL that is uses EGL to initialize the context. - Most windoing functions stubbed. - Also added a new test case to TestPAL for easier debugging. Change 3104743 on 2016/08/29 by Brent.Pease Support remote offline metal shader compilation Change 3105051 on 2016/08/29 by Brent.Pease UE-2382 - TASK: MobleMVP: iOS: Add ability to view iOS device console output in the editor UFE - IOS Automation will now create a thread to collect the console logs from the device and send them to C# Console output while the app is running on device - Made ProcessResult an interface (IProcessResult) which ProcessResult implements. This allows platforms to provide their own implementation if needed. - Moved the RunLoop related parts of CoreFoundation into MobileDevice.cs Change 3105053 on 2016/08/29 by Brent.Pease - IOS dll's as part of the last check-in Change 3106853 on 2016/08/30 by Jeff.Campeau Implement FD3D11DynamicRHI::RHICreateComputeFence to prevent memory overwrite Change 3107361 on 2016/08/30 by Dmitry.Rekman Renderer: changes to allow postproc delegates. Change 3107362 on 2016/08/30 by Dmitry.Rekman Plugin with a CUDA postproc example. - Linux version only. Runs under a headless GL too (without X). - Disabled during cross-compilation, can be compiled natively only. - CUDA kernel should be compiled separately, CMakefile with compilation attached (can be used to generate VStudio projects as well). - To test the output, run under the debugger, interrupt and set global variable GSaveTheOutput to 50 (this will write out kernel output buffer 50 times as .bmp files into working directory). Change 3107913 on 2016/08/31 by Daniel.Lamb Fixed loading of cooked content in the editor. Change 3107916 on 2016/08/31 by Daniel.Lamb Added error case when shader compilation fails to notify shader. #test Cook shooter game. Change 3108080 on 2016/08/31 by Josh.Adams - Fixed PS4Automation compile errors Change 3109077 on 2016/08/31 by Brent.Pease Fix C# debug builds by specifying x64 and add reference to MobileDeviceInterface Change 3110086 on 2016/09/01 by Dmitry.Rekman Fix race condition in PThread runnable (UE-35074). - Instead of relying on busy-wait, join the threads. This prevents race between PostRun() (executed in the context of the thread) and FPThreadRunnableThread() destructor (see UE-34909). - Do not use an invalid value for pthread_t, since there's none. Change 3110172 on 2016/09/01 by Dmitry.Rekman Fixed a crash exiting VR Preview on Windows GL4 (UE-28708). - PR #2188 submitted by ardneran. Change 3110313 on 2016/09/01 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3111134 on 2016/09/01 by Dmitry.Rekman UBT: prevent mono from hanging on Ctrl-C. - Sometimes Ctrl-C can cause thread creation to fail. Without this change, UBT would lock up. Change 3111171 on 2016/09/01 by Brent.Pease Move all C# projects to use the x64 Platform for consistency with other changes made to move to the x64 Platform Change 3111177 on 2016/09/01 by Dmitry.Rekman Fix Linux build on systems without CUDA (UE-35460). Change 3111548 on 2016/09/02 by Luke.Thatcher [PLATFORM] [PS4] [!] Fix for PS4 iterative deployment. - Changes in Dev-Mobile broke the deployment manifests, as PS4 was now using the wrong filename when creating delta and obsolete file lists. Change 3111863 on 2016/09/02 by Dmitry.Rekman Better fix for build without CUDA (UE-35460). Change 3112738 on 2016/09/02 by Mark.Satterthwaite Fix the pausing particles on Metal - one line bug in the Metal query implementation meant that the first query wouldn't return the correct result for no good reason. #jira UE-34989 Change 3114579 on 2016/09/06 by Chris.Babcock Fix Vulkan include path in NDK check (contributed by geediiiiky) #jira UE-35490 #github #2758 #ue4 #android Change 3115115 on 2016/09/06 by Jeff.Campeau Calculate buffer size for paks using the bitwindow override as needed Change 3115600 on 2016/09/07 by Luke.Thatcher [PLATFORM] [PS4] [~] Make the crash dump handler registration much earlier, to catch crashes in early engine init. - Fixed up places in FGenericCrashContext::SerializeContentToBuffer which used the command line. If we crash early, the command line may not have been initialized yet. - Added a GetNoInit function to FThreadHeartBeat to avoid creating the heart beat thread if we crash early, and the thread doesn't exist yet. Tested by calling abort() immediately inside int main(), and we get a valid crash dump that the crash handler service can consume. Change 3115676 on 2016/09/07 by Luke.Thatcher [PLATFORM] [~] Dev-Platform integration fix for original CL 3064888 in //Orion/Release-29.1 Add .exe and .dll to windows symbol upload file filters. Change 3115811 on 2016/09/07 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3115944 on 2016/09/07 by Michael.Trepka Implemented IsGamepadAttached() for Mac Change 3115948 on 2016/09/07 by Michael.Trepka Don't try to restore Help menu item on Mac if MenuBlock does not contain it Change 3116200 on 2016/09/07 by Jeff.Campeau Fix parameter ordering Change 3117660 on 2016/09/08 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3117728 on 2016/09/08 by Michael.Trepka Copy of CL 3117698 by Mike.Fricker Fixed regression with editor's Simulate mode where cursor would teleport back to the center of the viewport after every click - This bug was introduced in CL 3075932 from a borderless window cursor handling fix that was needed for games that capture the cursor Change 3117797 on 2016/09/08 by Peter.Sauerbrei Shader Resource compression Change 3117988 on 2016/09/08 by Brent.Pease - Solutiion generator will now pick x64 instead of AnyCPU for the default platform configuration - Fix what I think was a merge error in BuildGraph.cs Change 3118296 on 2016/09/08 by Daniel.Lamb Fixed crash with launch on. Couldnt' correctly detect previous generated ini settings. #test launch on QA game #jira UE-35741 Change 3118438 on 2016/09/08 by JohnHenry.Carawon Fix UAT compilation on Linux #UE-35745 Change 3118934 on 2016/09/08 by Jeff.Campeau Shader compression setting based on target platform instead of cooking host platform. #jira UE-35753 Change 3120190 on 2016/09/09 by Ben.Marsh Add missing Platform attribute to build script for Dev-Platform. [CL 3120378 by Josh Adams in Main branch]
2016-09-09 20:13:41 -04:00
private static IProcessResult RunCookOnTheFlyServer(FileReference ProjectName, string ServerLogFile, string TargetPlatform, string AdditionalCommandLine)
{
var ServerApp = HostPlatform.Current.GetUE4ExePath("UE4Editor.exe");
var Args = String.Format("{0} -run=cook -cookonthefly -unattended -CrashForUAT -log",
CommandUtils.MakePathSafeToUseWithCommandLine(ProjectName.FullName));
if (!String.IsNullOrEmpty(ServerLogFile))
{
Args += " -abslog=" + CommandUtils.MakePathSafeToUseWithCommandLine(ServerLogFile);
}
if (IsBuildMachine)
{
Args += " -buildmachine";
}
Args += " " + AdditionalCommandLine;
// Run the server (Without NoStdOutRedirect -log doesn't log anything to the window)
PushDir(Path.GetDirectoryName(ServerApp));
var Result = Run(ServerApp, Args, null, ERunOptions.AllowSpew | ERunOptions.NoWaitForExit | ERunOptions.AppMustExist | ERunOptions.NoStdOutRedirect);
PopDir();
return Result;
}
Copying //UE4/Dev-Platform to //UE4/Dev-Main (Source: //UE4/Dev-Platform @ 3120366) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 2714591 on 2015/10/02 by Ben.Marsh Initial branch of files from Engine-Main (//UE4/Engine-Main) to Dev-Platform (//UE4/Dev-Platform) Change 2916715 on 2016/03/21 by Daniel.Lamb First pass at splitting out build cook run into into seperate scripts. Change 2948322 on 2016/04/19 by Nick.Shin update libwebsockets to v1.7.4 part 4 of 4 - doing this in stages for tracking purposes #jira UEPLAT-1246 - Update libWebsockets #jira UEPLAT-1221 - update websocket library #jira UEPLAT-1204 - Rebuild libwebsockets with SSL Change 2970016 on 2016/05/07 by Nick.Shin undo all of the following upgrades: - zlib - openssl - libcurl - libwebsockets and reset webrtc #jira UE-30298 - Fortnite and Orion crash on login Change 3059693 on 2016/07/21 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3061151 on 2016/07/22 by Niklas.Smedberg Fast ASTC texture compression, using ISPC. #jira UE-32308 Change 3061428 on 2016/07/22 by Peter.Sauerbrei Back out changelist 3061151 as it wasn't approved for submission Change 3061970 on 2016/07/22 by Steve.Cano Adding AdMob interstitital ad support for Android, including Blueprint functions #jira UE-33286 #ue4 #android Change 3062160 on 2016/07/22 by Mark.Satterthwaite Fix the fix for handling RHISetStreamSource overriding stride on Metal - not all MTLVertexDescriptors are equally hashable so do this ourselves. #jira UE-33355 Change 3062770 on 2016/07/24 by Brent.Pease UE-32397 Error Message displays as Unknown Error when failing to supply a Remote Build server for ios on Windows Change 3063227 on 2016/07/25 by Dmitry.Rekman Update hlslcc cross-compile after libc++ change. Change 3063314 on 2016/07/25 by Jeff.Campeau Xbox One DLL loading Receipts can be read back by request for target info Change 3063329 on 2016/07/25 by Mark.Satterthwaite CL #3046743 was breaking other samples in unexpected ways after a recent Main merge, so make a Metal-specific change to the shader instead and amend the MetalBackend to better match HLSL's handling of NaN/inf with common single-precision float intrinsics. This is sufficient to fix the AtmosphericFog and the recent regressions. #jira UE-33600 #jira UE-33028 #jira UE-27879 #jira UE-25802 Change 3063492 on 2016/07/25 by Brent.Pease UE-23846 - iOS Movie Player can't handle videos at resolutions that aren't multiples of 16 UE-33200 - A movie isn't played on iOS occasionally. Change 3063729 on 2016/07/25 by Dmitry.Rekman Linux: enable XGE on all platforms. #tests Cross-compiled a number of Linux targets on Windows. Change 3063732 on 2016/07/25 by Dmitry.Rekman Fixed formatting (spaces->tabs) in previous change. Change 3063750 on 2016/07/25 by Daniel.Lamb Added code to dump the cook modification delegate loads to log. Fixed the memory usage output log. #test cook paragon. Change 3063804 on 2016/07/25 by Daniel.Lamb Added cookpartialgc additional commandline option to uat. #test UFE Change 3064008 on 2016/07/25 by Mark.Satterthwaite For non-shipping builds conditionally bind a default uniform buffer in Metal and report an error if the slot was unbound, if our validation layer is enabled attempt to report the shader source in question. This relies on the shader compiler providing accurate information about uniform buffer bindings and won't fix all occurances of bad uniform usage (if a buffer is bound but too short the result will be GPU restarts or an error in Apple's validation layer - we can't detect this case) but will help debug the typical error of leaving an active slot unbound. #jira FORT-27685 Change 3064141 on 2016/07/25 by Jeff.Campeau Rebuild vpxmd.lib with delayed codegen disabled (fixes linker warning building Win64). Change 3065024 on 2016/07/26 by Nick.Shin Change filetype remove exclusive check out bit requested by or.coheni & nick.penwarden Change 3065274 on 2016/07/26 by Jonathan.Fitzpatrick DirectoriesToAlwaysStageAsUFS now properly filters out *.uasset and *.umap files This prevents the bug where cooked assets get trampled by staging their uncooked version on top of them during the UFS step Added a file filter to DirectoriesToAlwaysStageAsUFS for uasset and umap. Change 3066338 on 2016/07/27 by Mark.Satterthwaite Handle releasing an SRV/UAV & the source object within a single Metal command-buffer. #jira UE-33779 Change 3066789 on 2016/07/27 by Daniel.Lamb Realtime mode does not save any packages anymore unless they are ready. #test cookontheside, cookbythebook shooter game Change 3066847 on 2016/07/27 by Jeff.Campeau Fix define #2634 #jira UE-33813 Change 3068868 on 2016/07/28 by Mark.Satterthwaite Extend hlslcc's handling of switch-statements to allow implict casts from scalar bool, half & float as HLSL itself permits while also making sure it errors if the expression input is not scalar. This fixes shader compile errors in UT. Change 3070040 on 2016/07/29 by Dmitry.Rekman Delete Nadzorca. Change 3070947 on 2016/07/29 by Jeff.Campeau Perforce C++ API 2015.2 (includes debug libraries) Change 3073707 on 2016/08/02 by Daniel.Lamb Derived data cache commandlet runs resolve string asset references to load any string asset refereced packages from the map. Also process async results from shaders being compiled so they can have their memory resources released. #test DerivedDataCache commandlet shootergame. Change 3076613 on 2016/08/03 by Brent.Pease + UnrealTargetConfiguration is now passed into deploy and package methods + The UIRequiredDeviceCapabilities plist key now only considers the architectures from the corresponding target configuration (shipping or development) Change 3076668 on 2016/08/03 by Brent.Pease Back out changelist 3076613 Change 3077157 on 2016/08/04 by Daniel.Lamb Fixed up DLC staging so that it stages to the proper mount point. Fixes up include engine content in DLC staging paths. #test Made up shooter game DLC Change 3077191 on 2016/08/04 by Daniel.Lamb More smartly process async shader compilation if we are waiting for it. #test cook on the side shooter game cook by the book shooter game. Change 3077412 on 2016/08/04 by Mark.Satterthwaite Fix "iOS Metal-based build crashes at launch with sub-levels": - Slate should not bind the null RHI texture from an unitialised texture atlas - atlases only have a valid texture pointer once an entry has been added to them and in the template projects an empty sub-level doesn't add anything. - To prevent this kind of bug resurfacing and being so hard to track down add Metal shader binding validation to our validation layer as Apple's is incomplete on iOS and won't warn us about nil texture usage which causes these GPU restarts. This requires reworking our vertex declaration handling to be more efficient so that we can cache the pipeline reflection data as well as the pipeline objects. - Fix validation error of texture reallocation on loading template projects under Metal. #jira UE-30847 Change 3077958 on 2016/08/04 by Brent.Pease + UnrealTargetConfiguration is now passed into deploy and package methods + The UIRequiredDeviceCapabilities plist key now only considers the architectures from the corresponding target configuration (shipping or development) Change 3079503 on 2016/08/05 by Mark.Satterthwaite Initialise more variable types to 0 in Metal shaders to workaround Xcode 8 toolchain no longer doing this for us for "threadgroup shared" variables. Everything but structs and atomic's will now be initialised. #jira UE-33856 Change 3079737 on 2016/08/05 by Jeff.Campeau Add support for delay load DLLs on Xbox One Turn off warnging for missing PDBs to match VCToolchain.cs Change 3081005 on 2016/08/08 by Mark.Satterthwaite Fix-up Metal device name on AMD for macOS 10.12 which reports it correctly and enable tiled reflections on Intel from macOS 10.12 too as they now work. Change 3081557 on 2016/08/08 by Daniel.Lamb File-> Package saves all packages before starting packaging. #test File package first person template Change 3082215 on 2016/08/09 by Lee.Clark PS4 - Added 4k profile Change 3082412 on 2016/08/09 by Daniel.Lamb Fixed cook on the fly server not handling cook requests. #test Cook on the fly shooter game. Change 3082955 on 2016/08/09 by Dmitry.Rekman Linux: convert existing Strcat() uses to Strncat(). - Strcat() does not check destination size so can silently corrupt memory. While this was not observed, this conversion removes this concern altogether. Change 3083772 on 2016/08/10 by Luke.Thatcher [PLATFORM] [PS4] [+] Checking in PS4CrashHandler files so we have a copy in Perforce rather than just on the server. - Taken from \\devweb-02 and removed all the unused files/dependencies. - Created a publish profile pointing to \\devweb-02\Sites\PS4Services\PS4CrashHandlerDev so I'm not writing over the existing deployed crash handler. - Moved all code in the Page_Load event to inside the check for the HTTP method (POST) otherwise GET'ing the page from a browser will generate crash folders that hang around forever. Change 3085450 on 2016/08/11 by Lee.Clark PS4 - Fix mediaplayer pipeline allocation Change 3086360 on 2016/08/11 by Michael.Trepka Fixed a non-unity build error in Mac UnrealFrontend Change 3087224 on 2016/08/12 by Luke.Thatcher [PLATFORM] [PS4] [~] Refactor PS4 Crash Handler site - Removed CoreDumpHandler. Processing dump files is handled directly by an async thread within the aspx process. - Separated configuration values into their own class. Currently set to output to a testing directory, rather than the actual crash reporter landing zone. - Added a debug upload page to allow manual submission of .orbisdmp/.txt settings files, accessible by GET'ing Default.aspx. - Added logging. Logs self-delete after 30 days. Testing required before we switch to the new system. #jira UE-34504 #jira OR-26886 Change 3087626 on 2016/08/12 by Dmitry.Rekman PR #2689: Fix copying/duplicating failing on Linux (UE-34586). - Contributed by Web-eWorks. Change 3087991 on 2016/08/12 by Mark.Satterthwaite Initial AVFoundation implementation of Media Framework for Mac, iOS & tvOS. - Video playback occurs via AVPlayerItemVideoOutput's attached to the AVPlayerItem's output. This means gathering video samples is trivial. - Metal texture updates occur by wrapping the texture object provided by AVF - for Mac this is simple as it can bind to the IOSurface directly, for iOS/tvOS we have to create a CVMetalTextureCache and allocate our texture from there. - OpenGL and OpenGLES currently have to lock the pixel buffer and upload to a texture the old fashioned way - this should be revisited when there is time. - Subtitles/Captions are captured using AVPlayerItemLegibleOutput which also connects to the AVPlayerItem's output. - On Mac audio samples are returned by manually reading from the stream using an AVAssetReaderTrackOutput, including manual seeking and synching. - On iOS/tvOS the audio is played directly by AVPlayer because the IOSAudio system can't handle procedural buffers - otherwise it could reuse the Mac code. - AVFoundation does not support AVI - that's an obsolete Microsoft/Windows file-format. - Only 'file://' URLs are supported - streaming would require a totally different audio solution (using MTAudioProcessingTap) and has many more edge and failure cases that would need to be handled. #jira UE-34315 Change 3088790 on 2016/08/15 by Luke.Thatcher [PLATFORM] [PS4] [~] Hook new PS4 crash handler up to the crash reporter website. - Removed indentation from generated crash context XML file. The crash reporter process does manual XML parsing which doesn't correctly handle whitespace at the start of lines. - Switched the final output folder to match the one the crash reporter process is watching. - Hide upload form on a config variable. #jira UE-34504 #jira OR-26886 Change 3089060 on 2016/08/15 by Luke.Thatcher [PLATFORM] [PS4] [!] Change PS4 crash handler log file extension to ".ps4chlog", otherwise the crash reporter site attaches the wrong log file to the crash report. Allowed showing of debug upload form via "Default.aspx?showform=1" query string. #jira UE-34504 #jira OR-26886 Change 3089089 on 2016/08/15 by Mark.Satterthwaite Duplicated changes to AppleMovieStreamer from CL #3088149. #jira UE-34315 Change 3089460 on 2016/08/15 by Mark.Satterthwaite Duplicate CL #3080971: Workaround a macOS 10.12 Beta bug on some Metal drivers that can't initialise temporary/local variable arrays, only those that are marked threadgroup shared. #jira UE-34355 Change 3089465 on 2016/08/15 by Mark.Satterthwaite For Metal shader translation retain more precision for float constants -1.0f >< 1.0f by emitting them in scientific notation - prevents Hammersley constant amongst others from being flushed to 0. Change 3089902 on 2016/08/15 by Daniel.Lamb Changed the next compiling ID to the correct compiling ID. #test Cook Change 3089903 on 2016/08/15 by Daniel.Lamb Cooker monitors config useage during cook and uses those settings to invalidate cooked content instead of all config settings. Change 3090114 on 2016/08/16 by Luke.Thatcher [PLATFORM] [PS4] [~] Minor change to PS4 settings text on crash handler site. Change 3090949 on 2016/08/16 by Nick.Shin WebSocketNetDriver crash fix filled in missing chunk of code that calls PacketHandler's "packet modifiers" #jira UE-25492 HTML5 Client cannot connect to Windows Server #jira UE-30880 WinServer crashes when NetDriver is set to WebSocket and Client attempts to connect via websocket #code.review john.pollard john.barrett Change 3091265 on 2016/08/16 by Brent.Pease Add IOS support to HarfBuzz Change 3091267 on 2016/08/16 by Brent.Pease Add references to fix mono build Change 3091291 on 2016/08/16 by Nick.Shin CIS warning fix #jira UE-25492 HTML5 Client cannot connect to Windows Server #jira UE-30880 WinServer crashes when NetDriver is set to WebSocket and Client attempts to connect via websocket Change 3091781 on 2016/08/17 by Joe.Barnes UE-33640: Exposed UPrimitiveComponent::IsAnyRigidBodyAwake() to Blueprints. Change 3092687 on 2016/08/17 by Daniel.Lamb Added support for using binned allocator in cooker instead of tbb. #test Cook shootergame. Change 3093867 on 2016/08/18 by Mark.Satterthwaite Use a read/write mutex to protect access to Metal's internal shader pipeline caches so that parallel threads can progress in the common case where new shaders are not being compiled. Change 3093950 on 2016/08/18 by Mark.Satterthwaite Change the Mac GPU identification code to cope with AMD's new naming scheme on 10.12. Change 3093951 on 2016/08/18 by Mark.Satterthwaite More SCW threads on Mac - they work now. Change 3093960 on 2016/08/18 by Mark.Satterthwaite Increase the default number of command-buffers on Mac because bigger games overflow the current limit of 64 per queue. Change 3096493 on 2016/08/22 by Jeff.Campeau Use Xbox version of DirectX include. Change 3097509 on 2016/08/23 by Luke.Thatcher [PLATFORM] [PS4] [+] Refactor PS4 Symbol Publish - Moved the SymStore task from Win.Automation to BuildGraph.Automation, and made it more generic. - The specifics of uploading symbols are now implemented in the platform tool chain, alongside StripSymbols(). - Re-generated the build graph schema file. - Removed the old PS4 symbols upload path in the package step. Modified OrionBuild.xml to publish symbols for all PS4 dev, test and shipping config builds of OrionClient. Change 3097635 on 2016/08/23 by Luke.Thatcher [PLATFORM] [PS4] [+] Refactor Age Symbols task in UAT. - Moved the AgeStore task from Win.Automation to BuildGraph.Automation and made it more generic. - Symbol server directory structure is now defined by the platform tool chain, which the common task uses to clean out old symbols. - Added a "filter" parameter to prevent age tasks deleting symbols from unrelated builds in shared symbol servers. Modified OrionBuild.xml to age both the Windows and PS4 symbol stores. Change 3097713 on 2016/08/23 by Luke.Thatcher [PLATFORM] [PS4] [+] Enable new PS4 crash handler server - Created live deployment profile and applied the required config file changes. Change 3099214 on 2016/08/24 by Luke.Thatcher [PLATFORM] [PS4] [!] Fix compile error in PS4 tool chain. For some reason, this only breaks ocassionally. Maybe we're alternating between the 2013 and 2015 C# compilers depending on what initiates the build (e.g. Visual Studio vs GenerateProjectFiles)? Change 3099222 on 2016/08/24 by Luke.Thatcher [PLATFORM] [PS4] [+] Added PS4 support for FPlatformMisc::MessageBoxExt using the MsgDialog library. - Note, only one and two button message dialogs are supported (limitation of MsgDialog). Change 3099260 on 2016/08/24 by Luke.Thatcher [PLATFORM] [PS4] [~] Better PS4 exit function. Calls quick_exit instead of abort when we've not asserted. Allows for a "cleaner" forced exit without generating a crash dump. Change 3101192 on 2016/08/25 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3101944 on 2016/08/25 by Daniel.Lamb Ask to save the current level when we are using launch on. Change 3102036 on 2016/08/25 by Nick.Shin check for minimum expected size upon data received from network #jira UE-13657 - HTML5 plugin OnRawRecieve overflow Change 3102115 on 2016/08/25 by Brent.Pease - Fix small errors that probably only show up in the mac mono build #code.review peter.sauerbrei Change 3102747 on 2016/08/26 by Jeremiah.Waldron Re-submitting OnlineSubsystemGameCircle with TPS permission for Amazon SDK - Also fixed the plugin to remove any related files from the final package when IAP is disabled or GameCircle support itself is disabled with the plugin still enabled - Added support for new AlreadyOwned IAP response code as well which is already used for GooglePlay and IOS Change 3102900 on 2016/08/26 by Nick.Shin since last checkin (CL: 2981945) - prints are crashing the browser - this change will allow browser to print the details via console.log() #jira UE-26047 - HTML5 HTTP Response Headers not implemented Change 3103130 on 2016/08/26 by Brent.Pease UE-24679 - Enable the ability to change ports for a firewall to pass them through rsync Change 3103225 on 2016/08/26 by Daniel.Lamb Fixed issue with warning which would cause crash. Change 3103425 on 2016/08/26 by Dmitry.Rekman Enable offscreen GL rendering without X. - Added new video subsystem to SDL that is uses EGL to initialize the context. - Most windoing functions stubbed. - Also added a new test case to TestPAL for easier debugging. Change 3104743 on 2016/08/29 by Brent.Pease Support remote offline metal shader compilation Change 3105051 on 2016/08/29 by Brent.Pease UE-2382 - TASK: MobleMVP: iOS: Add ability to view iOS device console output in the editor UFE - IOS Automation will now create a thread to collect the console logs from the device and send them to C# Console output while the app is running on device - Made ProcessResult an interface (IProcessResult) which ProcessResult implements. This allows platforms to provide their own implementation if needed. - Moved the RunLoop related parts of CoreFoundation into MobileDevice.cs Change 3105053 on 2016/08/29 by Brent.Pease - IOS dll's as part of the last check-in Change 3106853 on 2016/08/30 by Jeff.Campeau Implement FD3D11DynamicRHI::RHICreateComputeFence to prevent memory overwrite Change 3107361 on 2016/08/30 by Dmitry.Rekman Renderer: changes to allow postproc delegates. Change 3107362 on 2016/08/30 by Dmitry.Rekman Plugin with a CUDA postproc example. - Linux version only. Runs under a headless GL too (without X). - Disabled during cross-compilation, can be compiled natively only. - CUDA kernel should be compiled separately, CMakefile with compilation attached (can be used to generate VStudio projects as well). - To test the output, run under the debugger, interrupt and set global variable GSaveTheOutput to 50 (this will write out kernel output buffer 50 times as .bmp files into working directory). Change 3107913 on 2016/08/31 by Daniel.Lamb Fixed loading of cooked content in the editor. Change 3107916 on 2016/08/31 by Daniel.Lamb Added error case when shader compilation fails to notify shader. #test Cook shooter game. Change 3108080 on 2016/08/31 by Josh.Adams - Fixed PS4Automation compile errors Change 3109077 on 2016/08/31 by Brent.Pease Fix C# debug builds by specifying x64 and add reference to MobileDeviceInterface Change 3110086 on 2016/09/01 by Dmitry.Rekman Fix race condition in PThread runnable (UE-35074). - Instead of relying on busy-wait, join the threads. This prevents race between PostRun() (executed in the context of the thread) and FPThreadRunnableThread() destructor (see UE-34909). - Do not use an invalid value for pthread_t, since there's none. Change 3110172 on 2016/09/01 by Dmitry.Rekman Fixed a crash exiting VR Preview on Windows GL4 (UE-28708). - PR #2188 submitted by ardneran. Change 3110313 on 2016/09/01 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3111134 on 2016/09/01 by Dmitry.Rekman UBT: prevent mono from hanging on Ctrl-C. - Sometimes Ctrl-C can cause thread creation to fail. Without this change, UBT would lock up. Change 3111171 on 2016/09/01 by Brent.Pease Move all C# projects to use the x64 Platform for consistency with other changes made to move to the x64 Platform Change 3111177 on 2016/09/01 by Dmitry.Rekman Fix Linux build on systems without CUDA (UE-35460). Change 3111548 on 2016/09/02 by Luke.Thatcher [PLATFORM] [PS4] [!] Fix for PS4 iterative deployment. - Changes in Dev-Mobile broke the deployment manifests, as PS4 was now using the wrong filename when creating delta and obsolete file lists. Change 3111863 on 2016/09/02 by Dmitry.Rekman Better fix for build without CUDA (UE-35460). Change 3112738 on 2016/09/02 by Mark.Satterthwaite Fix the pausing particles on Metal - one line bug in the Metal query implementation meant that the first query wouldn't return the correct result for no good reason. #jira UE-34989 Change 3114579 on 2016/09/06 by Chris.Babcock Fix Vulkan include path in NDK check (contributed by geediiiiky) #jira UE-35490 #github #2758 #ue4 #android Change 3115115 on 2016/09/06 by Jeff.Campeau Calculate buffer size for paks using the bitwindow override as needed Change 3115600 on 2016/09/07 by Luke.Thatcher [PLATFORM] [PS4] [~] Make the crash dump handler registration much earlier, to catch crashes in early engine init. - Fixed up places in FGenericCrashContext::SerializeContentToBuffer which used the command line. If we crash early, the command line may not have been initialized yet. - Added a GetNoInit function to FThreadHeartBeat to avoid creating the heart beat thread if we crash early, and the thread doesn't exist yet. Tested by calling abort() immediately inside int main(), and we get a valid crash dump that the crash handler service can consume. Change 3115676 on 2016/09/07 by Luke.Thatcher [PLATFORM] [~] Dev-Platform integration fix for original CL 3064888 in //Orion/Release-29.1 Add .exe and .dll to windows symbol upload file filters. Change 3115811 on 2016/09/07 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3115944 on 2016/09/07 by Michael.Trepka Implemented IsGamepadAttached() for Mac Change 3115948 on 2016/09/07 by Michael.Trepka Don't try to restore Help menu item on Mac if MenuBlock does not contain it Change 3116200 on 2016/09/07 by Jeff.Campeau Fix parameter ordering Change 3117660 on 2016/09/08 by Josh.Adams Merging //UE4/Dev-Main to Dev-Platform (//UE4/Dev-Platform) Change 3117728 on 2016/09/08 by Michael.Trepka Copy of CL 3117698 by Mike.Fricker Fixed regression with editor's Simulate mode where cursor would teleport back to the center of the viewport after every click - This bug was introduced in CL 3075932 from a borderless window cursor handling fix that was needed for games that capture the cursor Change 3117797 on 2016/09/08 by Peter.Sauerbrei Shader Resource compression Change 3117988 on 2016/09/08 by Brent.Pease - Solutiion generator will now pick x64 instead of AnyCPU for the default platform configuration - Fix what I think was a merge error in BuildGraph.cs Change 3118296 on 2016/09/08 by Daniel.Lamb Fixed crash with launch on. Couldnt' correctly detect previous generated ini settings. #test launch on QA game #jira UE-35741 Change 3118438 on 2016/09/08 by JohnHenry.Carawon Fix UAT compilation on Linux #UE-35745 Change 3118934 on 2016/09/08 by Jeff.Campeau Shader compression setting based on target platform instead of cooking host platform. #jira UE-35753 Change 3120190 on 2016/09/09 by Ben.Marsh Add missing Platform attribute to build script for Dev-Platform. [CL 3120378 by Josh Adams in Main branch]
2016-09-09 20:13:41 -04:00
private static IProcessResult RunFileServer(ProjectParams Params, string ServerLogFile, string AdditionalCommandLine)
{
#if false
// this section of code would provide UFS with a more accurate file mapping
var SC = new StagingContext(Params, false);
CreateStagingManifest(SC);
MaybeConvertToLowerCase(Params, SC);
var UnrealFileServerResponseFile = new List<string>();
foreach (var Pair in SC.UFSStagingFiles)
{
string Src = Pair.Key;
string Dest = Pair.Value;
Dest = CombinePaths(PathSeparator.Slash, SC.UnrealFileServerInternalRoot, Dest);
UnrealFileServerResponseFile.Add("\"" + Src + "\" \"" + Dest + "\"");
}
string UnrealFileServerResponseFileName = CombinePaths(CmdEnv.LogFolder, "UnrealFileServerList.txt");
File.WriteAllLines(UnrealFileServerResponseFileName, UnrealFileServerResponseFile);
#endif
var UnrealFileServerExe = HostPlatform.Current.GetUE4ExePath("UnrealFileServer.exe");
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 4285612) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3836829 by Ben.Marsh UBT: Fix ability to precompile plugins from installed engine builds. Change 3839519 by Ben.Marsh UBT: Simplify configuring bPrecompile and bUsePrecompile settings for modules. Each rules assembly can now be configured as installed, which defaults the module rules it creates to use precompiled data. Change 4042043 by Steve.Robb GitHub #4705 : Added weak lambda's for delegates and multicast delegates. Change 4042056 by Robert.Manuszewski Optimized Mark Phase of GC by up to 10ms by making it run in parallel and removing a huge array presize which we didn't need. Change 4042104 by Robert.Manuszewski Set the minimum GC cluster size to 5 so that GC doesn't have to process micro clusters which are more expensive than processing individual objects + Exposed the minimum cluster size to ini and project settings as gc.MinGCClusterSize + Added the ability to sort clusters by name/object count/mutable object count/referenced clusters count when dumping them with gc.ListClusters command Change 4042377 by Robert.Manuszewski Reworked how GC and other threads (ALT specifically) interact - GC will now notify the ALT it wants to run and ALT will immediately try to finish its current work to allow that. Also the entire ALT tick is now protected against GC running at the same time to improve ALT stability. + added gc.ForceCollectGarbageEveryFrame console variable that triggers a forced GC every frame Change 4042427 by Robert.Manuszewski Changed FGCCSyncObject to use events when waiting for GC to finish so that it doesn't spin on non-game threads when GC is running Change 4042482 by Robert.Manuszewski Unhashing unreachable objects (ConditionalBeginDestroy) will now also be done incrementally, just like the purge phase of Garbage Collection Change 4042635 by Robert.Manuszewski Fix for a potential assert when incremental purge garbage is pending and something forces a full purge Change 4044092 by Steve.Robb Fix for forward declared CoreUObject weakobject types in delegates when building in Clang. Change 4044102 by Robert.Manuszewski Fix for a possible hang when worker threads are preventing GC from running and something is later trying to FlushAsyncLoading with the Async Loading Thread enabled Change 4044113 by Steve.Robb Another Clang fix. Change 4044160 by Robert.Manuszewski Disregard For GC pool will now be enabled by default in cooked builds Change 4044287 by Steve.Robb Typo fix. Change 4047723 by Graeme.Thornton TBA: Fixes for import/export name cache and object resolving Change 4048015 by Graeme.Thornton TBA: Weak/Soft/Lazy pointer serialization changes * Remove FWeakObjectPtr::Serialize, move it's logic into, and replace usages of with calls to, FArchiveUObject::SerializeWeakObjectPtr(). Ensures that something is always sent to the archive so that structured archives can be kept happy in the future. * Added Weak/Soft/Lazy pointer handling to the structured archive slot interface and all the formatters. Binary formatters just forward the call onto their inner and text archives store as a string path reference. * FArchiveUObjectFromStructuredArchive caches all these pointer types and stores indices in the binary block, same as with a UObject*. All pointers are then forwarded to the underlying formatter in one go on finalization. Change 4048021 by Steve.Robb Fix for binding an unbound TFunction to another TFunction with a different signature. Also all null pointers now count as unbindings, not just nullptr. TIsMemberPointer added. TIsATFunction and TIsATFunctionRef renamed to remove the 'A's. Change 4048544 by Robert.Manuszewski Fixing ConditionalBeginDestroy profiling after changes to incremental CBD. Change 4051028 by Graeme.Thornton TBA: ArchiveFromStructuredArchive adapter uses Inner to determine if it is outputting to text, and sets it's own ArIsTextFormat to false Change 4051056 by Graeme.Thornton TBA: High level tagged property / UObject base class text serialization - UObject serialize converted to structured archive - Properties written to text individually with text tags, and then binary adapted values - Only saves, doesn't load Change 4051111 by Graeme.Thornton TBA: Temporarily disable loading of text assets until tagged property serialization path is fixed up Change 4051154 by Graeme.Thornton TBA: Convert a few uobject serializers to structured archive format for example purposes Change 4051181 by Graeme.Thornton TBA: Added default structured archive implementation of SerializeItem to UProperty, which just calls the FArchive version on an FArchiveUObjectFromStructuredArchive adapter. Implemented structured archive SerializeItem for UArrayProperty Change 4051197 by Graeme.Thornton TBA: ObjectProperty text serialization Change 4051216 by Graeme.Thornton Restored a modified FWeakObjectPtr::Serialize function to keep backwards compatibility in code I don't have access to. Change 4051261 by Graeme.Thornton TBA: Convert UMetaData to structured archive Change 4051374 by Steve.Robb Incorrect assert removed. Change 4051562 by Robert.Manuszewski Adding stats for the new GC internal functions Change 4051614 by Graeme.Thornton TBA: Removed UProperty::SerializeItem(FArchive, ...) and replaced with UProperty::SerializeItem(FStructuredArchive::FSlot, ...). Fixed up most of them to work properly and added adapters in for any that were non-trivial. Change 4052512 by Graeme.Thornton TBA: Temporary workaround for softobjectptr and lazyobjectptr uproperties not serialization anything when they know the archive is a reference collector. They should always be serializing their pointers and letting the underlying archive itself ignore them. Change 4053917 by Robert.Manuszewski Clustered objects from clusters that are no longer reachable will now be marked as unreachable immediately when gathering unreachable objects Change 4053919 by Robert.Manuszewski Added the ability to disable incremental BeginDestroy in ini/project settings Change 4055518 by Daniel.Lamb Fixup for deterministic audio generation issue. Submitted on behalf of Rich.Whitehouse #jira nojira #test prefilght automated test. Change 4056854 by Graeme.Thornton TBA: Added a test asset to EngineTest which contains all the different property types and test cases. Change 4056858 by Graeme.Thornton TBA: Updated USetProperty to proper structured archive usage Change 4056872 by Graeme.Thornton TBA: Add map property field to test object Change 4056873 by Graeme.Thornton TBA: Convert UMapProperty to full structured archive Change 4056994 by Graeme.Thornton TBA: Converted FText over to structured archive. Implemented saving, but not loading. Change 4059728 by Ben.Marsh UBT: Add support for using adaptive non-unity builds when the engine and project are in separate repositories. Change 4059805 by Graeme.Thornton Fixed typo in text serialization. Fixes CIS automation test errors Change 4060007 by Graeme.Thornton TBA: FArchiveFromStructuredArchive will now access it's host slot lazily, i.e. only when a value is actually written to the archive. Change 4060092 by Stefan.Boberg Added optimized Windows console window output path to GenericConsoleOutput since this slowed down cooking considerably (2 minutes spent in wprintf alone for one large dataset) When stdout is attached to a console we use the WriteConsoleW function instead of wprintf since the latter is very slow especially in unbuffered mode which the engine currently configures for stdout (see setvbuf call in LaunchEngineLoop.cpp). At some point we should reconsider this buffering policy since it's likely to slow down other platforms as well but I wanted to do a safe change for now as I don't yet fully understand why the setvbuf call is there in the first place. Change 4060108 by Stefan.Boberg Introduced some additional target platform utilities to help with asset cook optimizations * We now assign each ITargetPlatform a zero-based ordinal value * Introduced FTargetPlatform and FTargetPlatformSet types to help store platform references and platform sets efficiently. These are not currently used in the engine but are designed to replace the existing ITargetPlatform/string/FName representations in the cooking data structures. Change 4060143 by Graeme.Thornton Undo //UE4/Dev-Core/Engine/Source/Runtime/... changelist 4060007 Needs some other changes that I haven't checked in yet... Change 4062432 by Ben.Marsh Fix error message when enumerating P4 changes. Change 4062648 by Ben.Marsh Add missing p4 integration action. Change 4063620 by Graeme.Thornton Integrated a fix from UDN where the engine would crash when trying to load a very small encrypted file (<16bytes) from a pak file, where the read address wasn't already aligned to the AES block size. (https://udn.unrealengine.com/questions/431989/crash-while-reading-a-very-small-file-in-encrypted.html) Change 4066963 by Robert.Manuszewski Fixing GC cluster verification code reporting false positives when a cluster is referencing another cluster through 'mutable' objects list. Change 4067133 by Robert.Manuszewski Changed log verbosity when reporting individual cases of GC cluster assumption violations as they are followed by an asser anyway and this way we get the chance to see all issues before we assert at the end of these checks. Change 4067443 by Steve.Robb FString can now be constructed from any char pointer type and length. Change 4068156 by Steve.Robb Fix necessary because of FString constructor change in CL# 4067443. Change 4070258 by Graeme.Thornton Fixes for VSCode Change 4070372 by Graeme.Thornton TBA: Script struct serialization to structured archives Change 4071913 by Ben.Marsh Move bulk of the code for UnrealPak into an engine developer module, so it can be used in the editor. Change 4071914 by Ben.Marsh Missing files. Change 4071937 by Ben.Marsh Missing header. Change 4072015 by Ben.Marsh Fixes for compiling PakFileUtilities as part of the editor. Change 4072826 by Steve.Robb TBitArray::Reserve() added. TBitArray::Add() overloaded to allow adding multiple bits. TSparseArray::Reserve() optimized to call the overloaded Add(). Change 4073271 by Daniel.Lamb Fixed add patch tier in project launcher passing the wrong commandline option to UAT. #test none Change 4074708 by James.Hopkin #core Removed redundant Casts Change 4074763 by Steve.Robb Fix for TSparseArray::Reserve() size. Change 4076063 by Ben.Marsh Add an "UnrealPak" commandlet with the same functionality as the standalone UnrealPak program. Invoke by running the editor with -run=UnrealPak and the standard UnrealPak commandline options. Change 4077064 by Robert.Manuszewski Fixing compile error in PakFileUtilities Change 4077144 by Graeme.Thornton TBA: TextAssetCommandlet improvements * Collect lists of broken assets during roundtrip tests and print a summary of packages that failed each phase at the end * After resaving as text, load the file back as a plain JSON hierarchy to ensure the output was valid Change 4077412 by Ben.Marsh Set the correct exit code for UnrealPak. Should return 0 on success, not 1. Change 4077760 by Graeme.Thornton TBA: Loading fixed for tagged property serialization Includes conversion of all UProperty::ConvertFromType() and SerializeFromMismatchedTag() functions to use structured archives Lazy initialization of FArchiveFromStructruredArchive when loading, to support the possibility of an adapter being create around an object property serialize call to its inner UStruct, which then decides not to do anything and return false. Stops the ArchiveFromStructuredArchive from consuming the slot and getting upset later on when we try to serialize normal tagged properties from it. Disabled lazy bulk data loading from text assets. Requires a bigger change to make it work. Added some debug checks to json input formatter which track the current value stack size when a new object is pushed onto the stack, and makes sure that the stack has returned to the same size when the object is popped. Catches cases where we unpack an array/stream to the value stack but then don't consume all the items. Change 4078800 by Ben.Marsh Change UAT to using the editor's UnrealPak commandlet rather than invoking the standalone UnrealPak executable. To improve performance when building several PAK files, also add a new -batch=<file> command which reads commands to execute in parallel from a text file. Change 4079745 by Graeme.Thornton TBA: Migrated a couple of UObject Serialize functions to FStructuredArchive (SoundCue / MaterialExpressions / Editor strip flags) Change 4079847 by Graeme.Thornton TBA: Add 'FindMismatchedSerializers' mode to text asset commandlet, which dumps out a list of all UClasses which don't have the CLASS_MatchedSerializers flag, meaning we can't guarantee the have Serialize functions for FArchive AND FStructuredArchive, therefore we can't use the new structured archive based serialize path. Should only ever be native instrinsic classes as UHT takes care of all other cases. Change 4079925 by Ben.Marsh Fix incorrect assignment when deriving name for chunked pak file. Change 4080214 by Ben.Marsh Move the ThreadPoolWorkQueue class into DotNETUtilities so it can be used by other projects. Change 4082394 by Graeme.Thornton CIS fix for variable shadowing warning Change 4082583 by Ben.Marsh Add a IBinarySerializable interface for types that support reading from a BinaryReader and writing to a BinaryWriter. Implementing IBinarySerializable implies a constructor taking a BinaryReader argument is available for deserializing. Change 4082652 by Ben.Marsh Fix FileReference.Directory not returning a directory with a trailing backslash for files in the root directory. Change 4082755 by Graeme.Thornton Fixed an erroneous usage of TUniquePtr<uint8>as a pointer to a uint8 array when creating pak files. Caused a crash when compression was enabled, and has probably surfaced because pak generation is now done by an editor commandlet rather than a standalone program. Change 4082756 by Graeme.Thornton Fixed some incorrect documentation for pakfile compressed chunk headers Change 4082883 by Graeme.Thornton Static analysis warning fix Change 4082912 by Ben.Marsh Move ExceptionUtils into DotNETUtilities. Change 4085291 by Graeme.Thornton TBA: In the Json output formatter, write float and double values out with enough precision for successful roundtripping. Added some debug only code which will immediately reconvert the string back to its original value and compare the the input Change 4085523 by Graeme.Thornton TBA: Remove only explicit usage of DECLARE_FSTRUCTUREDARCHIVE_SERIALIZER. Should only be used from UHT generated code. Change 4086037 by Robert.Manuszewski Fix for a potential race condition when two threads want to acquire GC lock Change 4088655 by Graeme.Thornton Pak creation now uses the bEnablePakSigning setting from the crypto config json file Change 4091474 by Steve.Robb Fix for TStaticBitArray::FindFirstSetBit() and TStaticBitArray::FindFirstClearBit(). Unused variables removed. Change 4093632 by Steve.Robb CIS fixes. Change 4093656 by Graeme.Thornton Build fix Change 4093744 by Ben.Marsh Allow per-chunk settings for whether to enable compression in UnrealPak. Change 4099712 by Gil.Gribb UE4 - Fixed rare case where insufficient space was preallocated for cooldown ticks. #jira UE-59686 Change 4099912 by Stefan.Boberg Cooking timer optimizations: - Replaced data structures for FScopeTimer and FHierarchicalTimerInfo. Previous implementation used FString for many things and caused *lots* of heap and string concatenation activity. Replaced with a compile-time node id (using __COUNTER__) and raw string literals. - Removed PERPACKAGE_TIMER support (was disabled by default and was difficult to test) - Made it possible to toggle OUTPUT_TIMING and ENABLE_COOK_STATS independently - Removed some extremely tight timers because the overhead from calling QPC significantly exceeded the measured code This change shaved some 15% off a clean cook of Fortnite WindowsClient (en) with fully populated local DDC Change 4100519 by Stefan.Boberg Quick fix for Linux build issue introduced in 4099927 Change 4105327 by Stefan.Boberg Cooker: Changed FHierarchicalTimerInfo so it uses a linked list for tracking child nodes, to be able to deal with any child count. Previously we assumed there would never be more than 9 children but it turns out there are cooker modes that need more. Fixes check when using -FullLoadAndSave to cook Change 4105448 by Stefan.Boberg - Fixed Linux build warning re: member initialization order - Also eliminated OUTPUT_HIERARCHYTIMERS/CLEAR_HIEARCHYTIMERS macros (plain functions are fine) - Moved finishing-up code for FullLoadAndSave() to TickCookOnTheSide() call site to improve timer output. Previously some of the scopes would not have been closed before printing and thus the output was misleading. Change 4109031 by Ben.Marsh Attribute-driven Perforce wrapper (old Epic Friday project). Offers a more complete implementation than the current P4 wrapper in UAT without requiring any platform-specific libraries. Uses the Python binary output for parsing. Change 4109588 by Ben.Marsh UBT: Add extension methods for serializing a nullable type to a BinaryReader/BinaryWriter. Change 4109595 by Ben.Marsh Missing project file for DotNETUtilities. Change 4110724 by Stefan.Boberg Removed annotation map locking in UObjectMarks, eliminating around one minute (~3.5%) from Fortnite cook time. The locking was redundant since the annotation maps are managed per thread anyway. Change 4111304 by Ben.Marsh UAT: Add support for setting a status message through the log class. Allows writing transient messages (eg. progress messages) which will be cleared out before writing other messages. Best used through the LogStatusScope class, which can set a status message for the duration of a using() block. As part of this change, the console no longer has to be added as a dedicated trace listener. Since we already special-case this listener when formatting log output, it's easier to just keep the implementation separate to the other trace listeners. Change 4112708 by Steve.Robb Fix for TBitArray::MaxBits in assignment. Change 4114133 by Stefan.Boberg Tweaked how low-level memory (LLM) tracker is implemented to reduce overheads. Previously FMemory functions would acquire the LLM singleton and call OnLowLevelFree/OnLowLevelAlloc etc which would check the bIsDisabled flag and early out if it was set. Due to how frequently these functions were called this ended up costing quite a bit. - This change makes the flag a static member variable instead of a member variable and therefore enables a simpler early-out to be implemented. - The singleton getter is also simplified to avoid hitting the threadsafe singleton construction path on every call. - The enable flag is no longer TAtomic - this also incurs extra overhead for no clear benefit Shaves approximately 3.5% (one minute) off a Fortnite cook test scenario (using -FullLoadAndSave) Change 4115010 by Robert.Manuszewski Fixing CIS Change 4115249 by Robert.Manuszewski Fixing async loading code asserts when exiting game very early due to an error #jira UE-56267 Change 4117091 by Ben.Marsh Prevent doubled-up lines when writing status updates with console log verbosity. Change 4117207 by Ben.Marsh UGS: Do not include executables in diagnostics zip file, and ignore "no such files" error when cleaning workspace. Change 4119175 by Ben.Marsh UGS: Fix crash writing version files when directory does not already exist. Change 4119987 by Ben.Marsh UGS: Show a dialog box while the launcher is updating executables from Perforce, which allows cancelling the operation if necessary. Allow setting the username on the settings window, and prompt for login credentials if necessary. Should prevent situations where users have to update settings from the command prompt. Holding down shift during launch now shows the settings dialog rather than an immediate prompt to launch the unstable version (unstable version is shown as a checkbox on this dialog). Change 4119991 by Ben.Marsh Update version number for UGS launcher to 1.13. Change 4121943 by Robert.Manuszewski Don't use FArchiveAsync2 for reading packages with non-async path in editor builds as its performance is worse than the standard archive's (saves about 1 minute when doing larger cooks and 7 seconds when loading into PIE) Change 4122592 by Steve.Robb GitHub #4762 : Improve wording and grammar of Math comments Also includes improved accuracy in FMath::ComputeBoundingSphereForCone(). Change 4122819 by Stefan.Boberg Don't call CreateDirectory redundantly when opening files for writing using FFileManagerGeneric::CreateFileWriter This change avoids calling IPlatformFile::CreateDirectoryTree if possible since this is a very expensive function especially for deep hierarchies as it performs directory creation from the root directory onwards instead of from the leaf downwards. That function should also be fixed but this change improves performance in the meantime. Change 4122872 by Stefan.Boberg CreateDirectoryTree now creates directories leaf-to-root instead of the other way around. This is much more efficient since we don't spend time on system API calls for directories which already exist. This accounted for a very large amount of CPU time in cooking as the full target file directory hierarchy would be "created" for every single output file. Change 4123109 by Stefan.Boberg - Disable overlapped I/O in editor / cooker. Synchronous I/O reduces the number of syscalls and Windows performs prefetching on our behalf anyway for sequential reads - Eliminated syscall which was issued for every write to update cached file size -- since we're the only writers to the file (file access allows read sharing at most) we can authoritatively update the file size on write completion Change 4123455 by Ben.Marsh PR #4775: New build param PCHMemoryAllocationFactor to set /Zm VS build param. (Contributed by lucaswall) Change 4124207 by Ben.Marsh UBT: Remove some unnecessary indirection for generated code paths. Change 4124217 by Ben.Marsh UBT: Remove another unused variable from UEBuildModuleCPP. Change 4124377 by Stefan.Boberg In IPlatformFile::DeleteDirectoryRecursively, attempt to delete file first and if it fails clear the readonly flag and try again Previously there was a call to clear the readonly flag for every deleted file and this is a waste of resources 99% of the time. The SetFileAttributes call accounted for a significant amount of time during cooker sandbox directory deletion Change 4125071 by Stefan.Boberg Some tweaks to FQueuedThreadPoolBase scheduling and memory management - Explicitly pass in false for TArray::RemoveAt(..., bool bAllowShrinking) argument to prevent memory reallocation when arrays are drained and inevitably repopulated shortly afterwards - Use a MRU strategy instead of LRU when picking a thread to wake up. The MRU thread is the most likely to have a 'hot' cache for the stack etc. Picking from the back of the array also happens to be cheaper since no memory movement is necessary when RemoveAt is called. (This was the strategy in place before CL2600362 which seems to have changed it unintentionally) - Release lock as soon as a thread has been chosen, before asking the worker thread to wake up and do the work Change 4126132 by Ben.Marsh UAT: Detect when stdout is redirected and prevent using backspace characters to move the cursor. Change 4126867 by Graeme.Thornton TBA: Fix tagged binary formatter Change 4127010 by Robert.Manuszewski AnimScriptInstances created at runtime will now also be added to the owning omponent's cluster to avoid GC issues. Change 4127932 by Ben.Marsh WorkspaceTool: Reduce unnecessary logging of status messages when console output is not redirected. Change 4129050 by Ben.Marsh UGS: Check for NET Framework 4.5 being installed before running the installer. Also fix warning trying to kill existing UGS instances before upgrade. Change 4129459 by Graeme.Thornton TBA: TextAssetCommandlet - When outputting converted assets to an output path, replicate the workspace relative path in the output directory Change 4129515 by Graeme.Thornton TBA: Add EnterRecord overload that allows outputting of available field names when loading. Change 4129517 by Graeme.Thornton TBA: Tagged properties are written out as named fields on the "Properties" record, rather than as a stream with a null tag at the end Change 4129518 by Graeme.Thornton TBA: Added a local const bool to allow easy hacking out of text asset loading support Change 4129558 by Graeme.Thornton TBA: Build fix for textasset-less configs Change 4129614 by Ben.Marsh UGS: Main window is now restored to normal size when activated by clicking on the tray icon. #jira UE-60490 Change 4129618 by Ben.Marsh UGS: Speculative fix for unreproduced exception accessing disposed window while shutting down. Change 4131936 by Robert.Manuszewski Removing some WIP code accidentally checked in with CL #4121943 Change 4133490 by Ben.Marsh UGS: Allow the $(Change) variable to be used in more places than just the context menu. #jira UE-60573 Change 4133550 by Ben.Marsh UGS: Setting for whether or not to use incremental builds is now exposed through the variable "$(UseIncrementalBuilds)" for use by custom build steps. #jira UE-60554 Change 4133681 by Ben.Marsh UGS: A per-project list of folders and extensions to be deleted by default when running the 'clean workspace' tool can now be specified through the <ProjectDir>/Build/UnrealGameSync.ini file. Settings may be specified for an individual branch (via a category with the depot path to the project) or for wherever the project is currently open (via the [Default] category). The SafeToDeleteFolders list specifies a substring that will be checked against folder paths. Anything containing this folder will be marked as safe for delete by default. The SafeToDeleteExtensions list specifies a list of extensions for files that can always be deleted. Example: [Default] +SafeToDeleteFolders=/MyGame/Test/ +SafeToDeleteFolders=/DataService/ +SafeToDeleteExtensions=.xx1 +SafeToDeleteExtensions=.xx2 #jira UE-60575 Change 4135449 by Ben.Marsh Fix allowing use of Job objects on Windows platforms (debug code submitted by mistake) Change 4135730 by Ben.Marsh UBT: Plugins can now be enabled and disabled from the .target.cs file (for targets that do not use the shared compile environment), by compiling the list of enabled/disabled plugin names into the Projects module. Change 4135823 by Ben.Marsh UBT: Remove legacy code to handle disabling optional plugins; now that this is compiled into the target, it will work for any plugins we choose. Change 4135945 by Ben.Marsh UBT: Fix error running programs with no explicitly enabled or disabled plugins. Change 4137207 by Ben.Marsh UGS: Align all badges with the same name, to make it easier to see which CIS steps are being run. Allow overriding the slot taken by a particular badge by calling it "SlotName:LabelName". Change 4137311 by Stefan.Boberg Removed child cooker support. In practice it is not a useful feature as it provides no performance improvement (quite the opposite in fact) and adds testing and maintenance complexity. Change 4137393 by Ben.Marsh UGS: Fix display of multiline errors in the status panel. Change 4141708 by Steve.Robb GitHub #3631 : Incorrect default argument in WeakObjectPtrTemplate #jira UE-45490 Change 4146655 by Stefan.Boberg Removed FullGCAssetClasses logic - no longer necessary nor useful Change 4147318 by Ben.Marsh UGS: Compress build badges in a column if it shrinks below the size that they would be visible. Change 4148207 by Ben.Marsh UGS: Added support for showing the latest completed build from a specific list of badges in the status panel. To declare a badge as one that should appear in the status panel rather than the CIS column, add it to the project's UnrealGameSync.ini in the project or [Default] section like so: +ServiceBadges=RoboMerge Change 4148282 by Stefan.Boberg Fixed bug in UCookOnTheFlyServer::GetCookOnTheFlyUnsolicitedFiles - UnsolicitedFiles should be passed by reference not by value Change 4148344 by Stefan.Boberg Fixed minor indentation error (most likely caused by sloppy merge) Change 4148521 by Stefan.Boberg Removed accidentally checked in PRAGMA_DISABLE_OPTIMIZATION from CookOnTheFlyServer.cpp Change 4148639 by Ben.Marsh UGS: Fix tooltips not showing for changes that have description badges. Change 4149373 by Ben.Marsh UGS: Allow adding additional columns to display particular badges by adding entries from the project config file. Example syntax: +Columns=(Name="Desktop",MinWidth=50,DesiredWidth=100,Weight=3,Badges="Editor") +Columns=(Name="Mobile",MinWidth=50,DesiredWidth=100,Weight=3,Badges="IOS,Android") Same form can be used to control how default columns are displayed (though badge settings are ignored). Also allow PerforceMonitor to detect local changes to project config files and update settings automatically. Change 4149399 by Ben.Marsh UGS: Update version to 1.143. Change 4155660 by Steve.Robb PROJECTION and PROJECTION_MEMBER macros which provide the correct behavior when creating projections using functions which are overloaded or use default arguments. Change 4157117 by Ben.Marsh Fix warning due to plugins disabled in .target.cs file. Change 4158011 by Ben.Marsh UBT: Add a check that the UnrealHeaderTool target file exists, rather than throwing an exception when reading it fails. Change 4158646 by Ben.Marsh UGS: Fix exception when login is discovered to have expired during a workspace update. Change 4158678 by Ben.Marsh UGS: Fix an exception on shutdown due to the icon being hidden after it's already been disposed. Change 4158683 by Ben.Marsh UGS: Add an unhandled exception filter which sends the exception data to the backend. Change 4159131 by Ben.Marsh UGS: Reduce the number of characters displayed for build badges based on the available space. Change 4159194 by Graeme.Thornton TBA: Fix incorrect map property conversion code when converting an old property that contains a map with different key/value types Change 4159239 by Steve.Robb Improved readability and compliance with coding standards. Change 4159246 by Ben.Marsh UGS: Allow syncing projects where source code is not available (and various version files don't exist). #jira UE-60985 Change 4159286 by Ben.Marsh UGS: Remove requirement for UE4Editor.target.cs to be visible in the depot in order to open a project. #jira UE-60986 Change 4159302 by Ben.Marsh UGS: Update version to 1.144. Change 4160308 by Ben.Marsh All staging client executables for blueprint projects. #jira UE-60983 Change 4161567 by Steve.Robb GitHub #4816 : UE-60771: Handle escaped double quote in FParse::LineExtended Change 4162641 by Ben.Marsh UGS: Allow customizing the position of custom columns, via the Index=N attribute. Change 4162647 by Ben.Marsh UGS: Update version to 1.145. Change 4165319 by Robert.Manuszewski PR #4812: Fix inconsistent command-line argument handling under Windows (Contributed by adamrehn) Change 4166150 by Ben.Marsh UGS: Include *.inl when looking for code changes. Change 4166551 by Steve.Robb Whitespace fixes caused by a bad merge. Change 4168483 by Ben.Marsh UGS: Add a more useful error if a file to be synced exceeds the max allowed path length. Change 4168490 by Ben.Marsh UGS: Update version to 1.146. Change 4168551 by Ben.Marsh UBT: Move bBuildLargeAddressAwareBinary into an exposed setting. Change 4168560 by Ben.Marsh UBT: Remove static config variable for controlling which configuration of UHT to use. Change 4171296 by Ben.Marsh UGS: Move the check for overlong paths earlier. Change 4171531 by Ben.Marsh UBT: Fix exception if BuildConfiguration.xml contains an unknown category. Change 4183371 by Robert.Manuszewski Fix for a crash in Async Loading Graph's CheckCycles when GC kicks in on the game thread and forces ALT to exit early Change 4184312 by Ben.Marsh UGS: Update version to 1.148 Change 4184480 by Robert.Manuszewski Removing unused async loading stat Change 4186390 by Ben.Marsh UBT: Format XML validation errors in a format that allows double-clicking on the message in Visual Studio. Change 4188644 by Ben.Marsh UBT: Add the MakePathSafeToUseWithCommandLine() function to UBT. Change 4188647 by Ben.Marsh UBT: Fix exception in target receipt when architecture is null. Change 4189617 by Ben.Marsh Change FileSystemReference, FileReference and DirectoryReference objects to use OrdinalIgnoreCase comparisons without creating a separate copy of the string to compare. The filesystem does not use the invariant culture, and it can produce the wrong results in some cases (the ordinal comparison is faster, too). Change 4189740 by Ben.Marsh UAT: Remote code to build UnrealPak when packaging; we use the editor now. Change 4189860 by Ben.Marsh UGS: Make the filter for excluding automated lighting rebuilds more explicit. Change 4190082 by Ben.Marsh Fixes to allow enabling edit and continue for Windows builds. Have experienced quite a few VS crashes when testing it in editor; not yet recommended for general use. - Allow edit and continue for any configuration, not just debug. - Fixed PDB errors compiling files that use a shared PCH with edit and continue enabled. Path to the generated PDB file was using the wrong directory. - Removed code that tracks PDB output files, since they're modified multiple times during a build. - Enable debug information when compiling generated CPP files, since it causes errors if the shared PCH PDB doesn't have the same option. - Disable support for remote execution of steps that modify the PDB, since the same file has to be modified many times. Remote execution causes the PDB files to be corrupted. Unfortunately, this makes E&C builds significantly slower. #jira Change 4192949 by Ben.Marsh UBT: Minor tidy-up (merging UEBuildBinary.Build and UEBuildBinary.SetupOutputFiles) Change 4193218 by Ben.Marsh Fix formatting. Change 4197252 by Mike.Erwin UAT: Fix log output w/ correct count of non-code projects. #jira none Change 4197941 by Ben.Marsh UGS: Add support for DebugGame editors that have an executable with a DebugGame suffix. Change 4197964 by Ben.Marsh UGS: Prevent attempts to automatically reopen projects while a modal dialog is up, or the workspace is syncing. Change 4198144 by Ben.Marsh UGS: Prevent modal dialogs when login expires in P4, and prompt for password when hitting "retry". Change 4198413 by Ben.Marsh UGS: Always show the main window when launched manually, and run with -RestoreState when launched at startup. Also add a couple more places that save the visibility state, since logging off seems like it can terminate the process abrubtly. Change 4198779 by Ben.Marsh UBT: Allow generating manifests to any arbitrary locations with the -Manifest=<Path> argument. Change 4198825 by Ben.Marsh UBT: Move code to enumerate Slate runtime dependencies into the Slate module. Doesn't need to be done inside core UBT. Change 4199341 by Ben.Marsh UGS: Update version to 1.149 Change 4199642 by Chad.Garyet - Deprecate CISController - Add BuildController to replace CIS GET/POST for builds - Add LatestController, GET does what CIS/GET used to do - Change Latest/GET to return the last 25 builds filtered by project, rather than the last 5000 individual Ids - Latest/GET now returns "LatestData" object instead of array of longs - Updated EventMonitor to match all API changes - Fixed bug where IDs were getting reset to initial startup values every update loop Change 4199663 by Chad.Garyet CIS controller still needs to return an array of longs #jira none Change 4199680 by Ben.Marsh UGS: Update version to 1.150 Change 4200457 by Ben.Marsh Merging CIS fix for non-development configurations. Change 4200472 by Mike.Erwin UAT: fix -skipbuildclient param default It was defaulting to skipbuildeditor's value, likely a copy-paste error. #jira none Change 4202595 by Ben.Marsh Fix static analysis warning due to constant comparison against macro. Change 4203250 by Ben.Marsh UGS: Always show the "Sync Precompiled Editor" option, but disable it and show a tooltip explaining why if it is not available. Change 4206191 by Ben.Marsh Exclude editor target files from installed builds, since they leak info about DLLs that have been stripped out. Change 4213011 by Ben.Marsh UBT: Include contents of modified intermediate files in the log, to make it easier to debug hidden dependencies. Change 4213487 by Ben.Marsh UBT: Fix assumption that bPrecompile is equivalent to bBuildAllModules. This is no longer the case; they are now controlled by separate options. Should fix CIS errors building the editor. Change 4213609 by Ben.Marsh Ensure that strings formatted using FMicrosoftPlatformString::GetVarArgs() are always null terminated, whether we use the secure CRT or not. Change 4215971 by Ben.Marsh UBT: Remove action graph visualization code; no longer used. Change 4215996 by Ben.Marsh UBT: Remove unqiue id from all actions in the action graph. This is only used for printing debug info in the case of a (rare) cycle in the action graph, so just look it up when needed. Change 4216022 by Ben.Marsh UBT: Rename Crypto.cs to EncryptionAndSigning.cs to match the name of the class inside it, and move it under the System folder. Change 4216031 by Ben.Marsh UBT: Move all the action executors into their own folder in the project. Change 4216526 by Ben.Marsh Fix CIS warnings. Change 4216544 by Ben.Marsh Replace custom code to ensure FMicrosoftPlatformString::GetVarArgs() null terminates its buffer with Microsoft's standards-compliant implementation. Change 4216633 by Ben.Marsh Add support for UnrealPak plugins. * Project and plugin modules can now specify an array of supported programs in the "WhitelistPrograms" field of their module descriptors, to allow modules to be loaded by programs. * Programs can now load any runtime modules, as long as they are whitelisted. * Programs under the engine directory can now use a shared build environment, so that building with a project file does not cause output binaries to be output to the project directory. * UnrealPak is now always built by default when packaging * Convert UnrealPak to a modular configuration Change 4216736 by Ben.Marsh UnrealPak: Move "ExportDependencies" command into an editor commandlet, since it relies on the UObject system, asset registry, etc... Change 4217447 by Ben.Marsh Back out revision 50 from //UE4/Dev-Core/Engine/Build/InstalledEngineBuild.xml Change 4217451 by Ben.Marsh Back out revision 11 from //UE4/Dev-Core/Engine/Plugins/Developer/VisualStudioSourceCodeAccess/Source/VisualStudioSourceCodeAccess/VisualStudioSourceCodeAccess.Build.cs Change 4217617 by Ben.Marsh Back out changelist 4217451 Change 4222552 by Ben.Marsh Don't use #import <TypeLib> for VS source code accessor when building with Clang; it's not supported. Change 4222630 by Ben.Marsh UBT: Fix spam while generating project files if Clang isn't installed. Change 4223316 by Ben.Marsh UBT: Change the order in which Visual C++ toolchains are enumerated to prefer full releases over preview releases. Change 4223318 by Ben.Marsh UBT: Add a build setting which allows creating a dedicated PCH for every file that's excluded from the unity working set (disabled by default). Improves iteration times when working on individual cpp files, but slows down iterating on header changes (and can take a lot of disk space for large changes). Dedicated PCH contains all includes scraped from the top of each cpp file, until a non-#include directive is encountered. Change 4223401 by Ben.Marsh UBT: Add an option to automatically enable edit and continue for files in the adaptive non-unity working set. E&C doesn't seem very useful for UE4 projects right now; compile time is comparable to regular build times, but it can take several minutes to apply code changes for large projects. Change 4223899 by Ben.Marsh UBT: Fix loading XML config files on Mono; Type.GetField(Name) does not seem to return values unless binding flags are specified. Change 4224637 by Ben.Marsh Add a "SupportedPrograms" field to plugin descriptors, which allows plugins to declare which plugins they support independently of individual modules. Programs now respect the "bEnabledByDefault" setting in plugins. Plugins that are compatible with a program now need to list that program in the SupportedPrograms list, and whitelist any modules that should load for that program. Change 4224710 by Ben.Marsh UBT: Don't add import libraries as final build products unless the target is being precompiled. Prevents the need for building them for leaf nodes in the action graph. Change 4224715 by Ben.Marsh UBT: Remove hack to allow Stats2.cpp to not follow IWYU convention. Change 4224726 by Ben.Marsh Remove commented out line. Change 4224903 by Ben.Marsh Fix non-unity compile error in Stats2.h. Change 4225051 by Ben.Marsh Back out changelist 4224710; causing CIS errors due to receipts not matching. Change 4225134 by Ben.Marsh Fixing non-unity errors. Change 4225203 by Ben.Marsh Another non-unity fix. Change 4225249 by Ben.Marsh Fix Linux dependencies being copied for the Windows editor; they can be added as requirements for the Linux target platform on Windows instead, so it respects the user's chosen platforms. #jira UE-62001 Change 4225512 by Ben.Marsh BuildGraph: Allow setting the target to build when using the <CsCompile> task. Change 4228815 by Ben.Marsh UBT: Always add the generated code directory to the list of include paths when generating project files. It may only be created after UHT has been run. Change 4228944 by Ben.Marsh UBT: Remove legacy CppCompileEnvironment and LinkEnvironment wrappers from TargetRules that were deprecated in 4.19. Change 4229028 by Ben.Marsh UBT: Fix editor targets with unique build environment having the wrong executable path in generated project files. Move move logic to configure target rules post-construction by the rules assembly to ensure it's valid. Change 4229065 by Ben.Marsh UBT: Move another target setting into the rules assembly. Change 4229105 by Ben.Marsh Fix BPT exception when generating project files. Change 4229311 by Ben.Marsh UBT: Store the module rules file location on the ModuleRules instance, as well as the plugin that it was created from. Also expose the plugin directory as a property on the ModuleRules instance. Change 4229421 by Ben.Marsh UBT: Consolidate functionality for UHT module setup in ExternalExecution.cs. Change 4229817 by Ben.Marsh UBT: Modules must now explicitly specify the path to the header used to generate a PCH if one is desired, rather than the header being determined automatically by attempting to parse the source code. Now that PCHs are force-included anyway, this removes a lot of dependencies inside UBT. Change 4229824 by Ben.Marsh UBT: Remove unused lists inside UEBuildModuleCPP.SourceFilesClass. Change 4229841 by Ben.Marsh UBT: Remove some legacy code from auto-detecting PCHs. Change 4230521 by Ben.Marsh UBT: Add utility functions to the log class to allow formatting errors and warnings in Visual Studio output format (eg. File(Line): warning: Message) Change 4230871 by Ben.Marsh UAT: Remove StreamUtilis utility class; there is a simpler way to implement the one place it's used. Change 4230882 by Ben.Marsh UAT: Add StreamUtils back into UAT, seems like it's still used there. Change 4230896 by Ben.Marsh UBT: Remove some redundant parameters from UEBuildModule/UEBuildModuleCPP/UEBuildModuleExternal constructors. Change 4231014 by Ben.Marsh WorkspaceTool: Include a dump of raw bytes when garbage is read from the P4 process, for diagnostic purposes. Change 4231032 by Ben.Marsh Fix CIS. Change 4231096 by Ben.Marsh Bump the FlatCPPIncludeDependencyCache version, to prevent errors trying to load old files. Change 4231446 by Ben.Marsh UBT: Added support for expanding UE-specific variables in include paths and library paths: $(EngineDir), $(ProjectDir), $(PluginDir), $(ModuleDir). Change 4231460 by Ben.Marsh Modules may now explicitly specify rpaths on Linux via the PublicRuntimeLibraryPaths and PrivateRuntimeLibraryPaths properties. Change 4233909 by Robert.Manuszewski PR #4779: Reason fails as the supplied variable is incorrect (Contributed by projectgheist) Change 4233910 by Ben.Marsh Enable PCHs on IOS. Reduces build time by ~25%. Change 4234176 by Ben.Marsh UBT: Add better messaging for modules that need to have a private PCH set. Now detects the likely PCH using the same method as legacy code and includes it as a suggestion. Change 4234193 by Ben.Marsh Add the Delete command to Perforce wrapper in DotNETUtilities. Change 4234688 by Ben.Marsh UBT: Simplify handling of installed/precompiled builds. Settings for whether a folder is installed/read-only or not is now stored on the RulesAssembly instance, allowing multiple things to be configured separately and stacked together (eg. engine/enterprise/project). RulesAssembly.IsReadOnly() allows determining if a flie can be modified or not and replaces many previous IsXXXInstalledCalls(), and traverses the chain of assemblies. Change 4234711 by Ben.Marsh UBT: Runtime dependencies can now be copied to output directories as part of the build. When adding a runtime dependency, an optional source location can be specified to copy from. Both the source and target paths can use variables can be used as part of the path, eg. $(OutputDir), $(ModuleDir), $(PluginDir). Example usage (from a .build.cs file): RuntimeDependencies.Add("$(OutputDir)/Foo.dll", "$(PluginDir)/Source/ThirdParty/Foo.dll", StagedFileType.NonUFS); Change 4234872 by Ben.Marsh Expose a flag for whether the engine is installed, to fix issues generating project files. Change 4234929 by Ben.Marsh Fix null reference generating receipts when UBT makefiles are active. Change 4235883 by Chad.Garyet Merging 4231245 to core Giving Coordinator its own sln. This should fix what 4158155 was supposed to. #jira UE-61955 Change 4236075 by Ben.Marsh CIS fix Change 4237066 by Robert.Manuszewski Fix for a potential crash when terminating the engine while it's being initialized #jira UE-60545 Change 4237078 by Robert.Manuszewski The engine will no longer be resetting all linkers causing massive load times when renaming the world package when entering Play In Editor Change 4237116 by Ben.Marsh Rewrite some Windows utility functions to support paths longer than MAX_PATH. Change 4237158 by Ben.Marsh Add const TCHAR* overloads of FString::RemoveFromStart() and FString::RemoveFromEnd(). Change 4237159 by Ben.Marsh Fix FWindowsPlatformFile::GetFilenameOnDisk() support for paths longer than MAX_PATH, and simplify some of the other long path functions to avoid copying string buffers. Change 4239050 by Ben.Marsh Missing file Change 4239318 by Ben.Marsh Linux CIS fix. Change 4239685 by Ben.Marsh Static analysis CIS fix. Change 4240800 by Ben.Marsh WorkspaceTool: Include the full command line in the log for any P4 commands. Change 4240903 by Ben.Marsh PR #4909: Update copyright notices to 2018 (Contributed by projectgheist) Change 4241025 by Ben.Marsh UBT: Exclude mobile pipeline caches from generated project files. Causes huge slowdown when using 'Find in Files' through the IDE. Change 4241770 by Ben.Marsh UBT: Include action number in parallel executor output. #jira UE-62032 Change 4243469 by Ben.Marsh TBA: Merge FAnnotatedStructuredArchiveFormatter with FStructuredArchiveFormatter. Any functions that are only implemented for text archives now have a _TextOnly suffix, and are exposed through the FStructuredArchive interface. Change 4245723 by Robert.Manuszewski Fixing another creash when terminating the engine while initializing. #jira UE-60545 Change 4245862 by Steve.Robb VectorLoadFloat2(Ptr) added, which loads { Ptr[0], Ptr[1], Ptr[0], Ptr[1] } into a VectorRegister. Change 4246412 by Robert.Manuszewski The warning 'Calling StaticLoadObject during PostLoad may result in hitches during streaming' will now also report the object which had the PostLoad called on it when StaticLoadObject call happened. Change 4246612 by Ben.Marsh UBT: Fix spelling of "Intellisense". Change 4249454 by Robert.Manuszewski Added extra checks to catch scenarios where the EDL Precache Buffer is flushed before a package header is fully read Change 4249513 by Robert.Manuszewski Made sure the Async Loading Thread doesn't continue running after creating new async packages when garbage collector wants to run on the game thread Change 4255207 by Ben.Marsh UGS: Add additional logging whenever a P4 command fails, and when the user is logged out. Change 4255288 by Ben.Marsh PR #4921: Honor ModuleRules' bEnableExceptions flag when creating precompiled h. (Contributed by surakin) Change 4256422 by Ben.Marsh UBT: Add an error if a module referenced by a plugin descriptor doesn't exist. Change 4257385 by Robert.Manuszewski Creating new objects from within ForEachObjectWithOuter will now result in a fatal error as it's unsafe to change internal UObject hash tables when iterating over them. Change 4257454 by Robert.Manuszewski Added the option to filter clusters listed with gc.ListClusters by objects within them. Usage: gc.ListClusters Hierachy With=ObjectName1,ObjectName2... Change 4257526 by Robert.Manuszewski It's now possible to filter clusters that get logged with verbose cluster logging enabled (UE_GCCLUSTER_VERBOSE_LOGGING=1) by objects within them by specifying -DumpClustersWithObjects=ObjectName1,ObjectName2 in the command line Change 4257822 by Ben.Marsh Fixes for PlatformShowcase compile errors. Change 4258771 by Ben.Marsh UBT: Fix project files not being generated for foreign projects when creating .stub files. #jira UE-62462 Change 4258790 by Ben.Marsh UBT: Clean up the logic around generating project files before creating a stub IPA, so that it fails loudly if project files do not exist, and can accept target names not matching project names. Change 4259276 by Ben.Marsh UBT: Make it an error if a framework doesn't exist, rather than failing silently. Also remove some remote toolchain stuff that's no longer necessary. Change 4259280 by Ben.Marsh UBT: Fix embedded framework zips not being uploaded for plugins. #jira UE-62485 Change 4260236 by Ben.Marsh UBT: Fix path to generated engine project file. Change 4260334 by Ben.Marsh UGS: Fix custom build steps dialog inadvertantly modifying config file settings in-place. Change 4260361 by Ben.Marsh UGS: Allow for p4 login commands to fail, even though the user is logged in (due to a bad connection, etc...) Change 4260559 by Ben.Marsh UGS: Update version. Change 4261160 by Robert.Manuszewski MediaPlaylist will now be added to root set if the owning MediaPlayer is in the disregard for GC set (fixes GC assumption violation crash) #jira UE-62495 Change 4261421 by Ben.Marsh Force-sync files for building documentation, to fix issues with files not being updated. #jira UE-62413 Change 4261425 by Ben.Marsh UBT: Remove some leftover functions for handling the remote toolchain. Change 4261530 by Ben.Marsh UBT: Speculative fix (and better error reporting) for IOS mobile provision not being found in CIS. Change 4261611 by Ben.Marsh UBT: Downgrade warning to a log message, since it appears when generating project files. Change 4261710 by Ben.Marsh Remove assert that GLogConsole is set; it won't be for command line utilities that don't depend on ApplicationCore. #jira UE-62545 Change 4261831 by Ben.Marsh Fix compile errors due to missing include path when hot-reloading a module from the editor. There are not necessarily source files to compile when -modulewithsuffix is specified on the command line, which was results in GeneratedCodeWildcard not being set. #jira UE-62463, UE-62384 Change 4262723 by Ben.Marsh Whitelist plugins that need to be loaded by UFE. #jira UE-62564 Change 4265444 by Ben.Marsh Fix incorrect executable name for DebugGame configurations in Xcode. #jira UE-62574 Change 4265892 by Ben.Marsh Fix incremental compile failures due to dependency checking for unity files. CachedIncludePaths was not correctly being set on file items, so dependencies were being ignored. #jira UE-62575, UE-62603, UE-62597 Change 4266019 by Josh.Adams - Fixed the CopyAction for runtime dependencies that need to be copied to different location, on non-XGE Change 4266264 by Ben.Marsh Remove override for the __IPHONE_OS_VERSION_MIN_REQUIRED macro on TVOS. This macro is already defined by system headers (in <AvailabilityInternal.h>). Now that we support PCHs on IOS and TVOS, manually defining this macro results in it being defined three times (once for the PCH, once by AvailabilityInternal.h, and once by the force-included list of definitions for the source file being built). The errors for redefining the macro in AvailabilityInternal.h are suppressed due to it being a system header, but the error for redefining it for the source file being compiled are not. #jira UE-62578 Change 4266273 by Ben.Marsh Fixes incremental build failure when compile arguments for PCH have changed on IOS/TVOS. Compile action needs to have a dependency on PCH build action. Change 4266614 by Graeme.Thornton Fix crash when cooking nativized blueprints due to removal of child cooker system. Change 4266763 by Ben.Marsh Always build UnrealPak when building client targets. The ProjectParams.Pak option is not reliable, because it can be forced on later by the target platform. #jira UE-62584 Change 4267985 by Robert.Manuszewski When iterating with ForEachObjectWithouter, don't lock the entire has table but only the hash bucket that is currently being iterated #jira UE-62600 Change 4268558 by Robert.Manuszewski PurgeLegacyBlueprints will no longer be called from within ForEachObjectWithOuter is it renames objects that reside in hash tables that are being iterated over which may lead to undefined behavior. #jira UE-62600 Change 4269011 by Chad.Garyet - Fixing Wildcard match issue, the change to ugsapi sends projects as //Depot/Stream instead of //Depot/Stream/ Wildcard match was only substringing to 3 chars. - Checking in the change a while back that increases the number of queried jobs up to 432 based on some maths from Bob about how many builds we want to grab Published to ugsapi server 8/8/17 #jira none Change 4270788 by Ben.Marsh Fix IOS provisioning data being using when remote compiling on TVOS. #jira UE-62705 Change 4271916 by Ben.Marsh Tag the XGEControlWorker executable as a build product after compiling SCW, to make sure it's included in the UGS zip file. Change 4271934 by Ben.Marsh Upload all static libraries in plugin folders as part of remote builds. #jira UE-62694 Change 4273368 by Ben.Marsh Fix Slate dependencies not being enumerated, and rules assembly not being rebuilt when building remotely. #jira UE-62705 Change 4274049 by Ben.Marsh Always parse the team UUID out of the mobile provision when doing a remote compile. The provision installed on the remote Mac (and selected for signing) may be different. #jira UE-62751 Change 4274823 by Ben.Marsh Add the -VersionCookedContent argument to disable the -unversioned parameter on the cooker command line. Change 4275838 by Ben.Marsh Fix BuildVersion string not being passed through from <SetVersion> task. Also add a -BuildVersion command line argument to UBT to override it for a particular build. Change 4275913 by Ben.Marsh Add a dummy exported symbol to the XGEController module, to fix build errors due to missing .lib file when it's built with WITH_XGE_CONTROLLER = 0. Change 4284161 by Ben.Marsh Allow mirroring Oodle files to remote Mac. Change 4074774 by Steve.Robb Vast simplification of TFunction, making it smaller in footprint, easier to follow and extend, and more correct. TUniqueFunction added, which is a move-only TFunction which can hold move-only functors. Fix for UWidgetBlueprint::ForEachSourceWidget() which should never have compiled but did. FFunctionGraphTask and TFuture<> updated to use TUniqueFunction to make them more general. TArray::HeapPop() made to work with move-only types. Change 4082591 by Ben.Marsh Move the Log class from UBT to DotNetUtilities. Change 4083236 by Ben.Marsh Add a Log.WriteException() method to dump an exception message to the console (and write the exception trace to the log) Change 4084107 by Ben.Marsh UAT: Remove the unused -SkipHeader argument to UE4Build. Change 4089771 by Steve.Robb GitHub #4743 : modified VirtualAlloc function flag https://blogs.msdn.microsoft.com/oldnewthing/20151008-00/?p=91411 Change 4091456 by Steve.Robb Unification of all platforms' FMath::CountTrailingZeros() and FMath::CountLeadingZeros() for both 32-bit and 64-bit. Change 4156437 by Ben.Marsh Lots and lots of fixes compiling for Clang on Windows. Editor now compiles cleanly without warnings, but crashes on startup due to error in intrinsics test. Disabling that runs further, but crashes accessing freed memory. Switching to the ANSI allocator runs further, but crashes in Slate after the splash screen and before the editor window opens. // TODO! * Switching between Clang/ICL/VS2015/VS2017 is now supported through the same mechanism as switching Visual Studio versions, without requiring any source level changes. To use Clang, set WindowsPlatform.Compiler = WindowsCompiler.Clang from a .target.cs file, or set <WindowsPlatform><Compiler>Clang</Compiler></WindowsPlatform> from BuildConfiguration.xml. To pick a specific toolchain version, set WindowsPlatform.CompilerVersion. * Clang is now supported through AutoSDKs; will be added to CIS. * The Samples/Sandbox/Clang project forces Clang to be used from its target.cs file, and allows easily building all editor modules and plugins with Clang on Windows. * UnrealMathSSE intrinsics have been re-enabled for Clang due to missing functions from the UnrealMathFPU implementation, but causes failure in tests at startup. * SSE4_CRC32() is disabled in D3D12Pipelinestate.cpp, since intrinsics are only allowed if enabled for the whole target (rather than being used in specific functions due to runtime checks) Change 4157389 by Ben.Marsh Few more fixes for compiling the editor with Clang. Change 4183911 by Ben.Marsh Fixes to support incremental linking on Windows. Does not seem to have any net benefit right now; may improve once minimal rebuild is enabled. * Incremental linking no longer forces PDB files to be enabled for source files. * Actions can specify specific files to be deleted before each build. Code to forcibly delete PDB files has been moved to the MSVC toolchain. * Unused libraries produced by the cross-referenced link are no longer added as build products, since (a) deleting them breaks dependency checking for incremental linking and causes a full link, and (b) not deleting them breaks UBT dependency checking and causes actions to be run over and over again. * Icon update is disabled for Windows when incremental linking is enabled. * Removed rarely-used setting to always delete produced items before each build. Change 4184311 by Ben.Marsh UGS: Added a dialog which shows all the required platform SDKs for a branch, linked from the status panel in UGS. The llist is configured via the UGS config file submitted to Engine/Programs/UnrealGameSync/UnrealGameSync.ini (and may be overridden by the project config file if necessary): [Default] ; Set this to a network share which contains the SDK installers for your site SdkInstallerDir= ; All the required SDKs for the current version of the engine +SdkInfo=(Category="Android", Description="NDK r21", Browse="$(SdkInstallerDir)\\Android") +SdkInfo=(Category="Windows", Description="Visual Studio 2017") +SdkInfo=(Category="Windows", Description="Visual C++ Toolchain 14.13.26128") +SdkInfo=(Category="Windows", Description="Windows SDK 10.0.16299.0") Similar entries for console platforms are added in console subdirectories. Each entry may contain an Install="Foo.exe" and/or Browse="C:\Foo" style attribute, specifying the path to an installer to run or directory to open in explorer respectively. The SdkInstallerDir setting is used as a base directory for the default installers, seen above for Android. Licensees may override this with a network path specific to the site that UGS is being deployed to (either in this file, in a project specific config file, or in a Engine/Programs/UnrealGameSync/NotForLicensees/UnrealGameSync.ini file). Change 4200452 by Ben.Marsh UBT: Change DebugGame configurations to output a separate executable rather than requiring a -Debug argument at runtime. Previous behavior was a common source of errors. Engine modules are still shared between Development and DebugGame, but the launch module sets a flag in Core on startup indicating the game configuration. Change 4206189 by Ben.Marsh UBT: Simplify logic for precompiling binaries. * Target no longer has separate list of "precompile only" binaries or modules. New -AllModules option allows adding every module to a target, which can be used with -Precompile and -NoLink to precompile object files for monolithic builds. * Precompiled file lists have been removed from target receipts. * The manifest now includes all generated headers and precompiled files when run with the -Precompile option. * Separate -DependencyList=Foo.txt has been added to write a list of all dependencies required to use precompiled binaries. This file list can be read using the <Tag> task in buildgraph. Change 4215466 by Ben.Marsh UBT: Remove indirect calls to determine extensions for object files and precompiled headers. The toolchain knows the correct convention for the platform. Change 4215975 by Ben.Marsh UBT: Remove telemetry code. This has never proved useful for analyzing performance due to the number of incidental factors that affect build times (eg. number of files being compiled). Change 4220154 by Ben.Marsh Move text-only implementations of FOutputDeviceError back into Core, so we can build command-line applications that don't depend on ApplicationCore. Change 4224708 by Ben.Marsh Add a bCompileAgainstApplicationCore setting to the target rules, which allows compiling out references to the ApplicationCore module (which should only be necessary for applications with a GUI). Removed ApplicationCore from several engine tools and utilities. Change 4224958 by Ben.Marsh Remove CoreMinimal.h includes from Core. Change 4229059 by Ben.Marsh UBT: Remove the UEBuildPlatform.ShouldNotBuildEditor() hook for target platforms. We shouldn't be modifying a target's build environment to disable the editor; it is invalid to build the editor for these target platforms at all, and this is already enforced by the GetSupportedPlatforms() function. Change 4230508 by Ben.Marsh Fixup precompiled header setting for samples and games. Change 4231457 by Ben.Marsh Fix exceptions in log messages having trailing newlines. Change 4232406 by Ben.Marsh UBT: Always force include a PCH for generated code if there's one set; the code may depend on it to compile. Change 4234177 by Ben.Marsh Set up private PCH files everywhere that previously used them. Change 4235973 by Ben.Marsh Change FPlatformMisc::GetEnvironmentVariable() to return an FString() rather than requiring a fixed size buffer to be passed in. Removes references to MAX_PATH. Change 4238842 by Ben.Marsh Add support for paths longer than MAX_PATH in the editor. Requires Windows 10 version 1607, and the functionality to be enabled via a registry key or group policy (see https://docs.microsoft.com/en-us/windows/desktop/FileIO/naming-a-file). Only a subset of Win32 functions support long paths (executables can only be started from paths shorter than MAX_PATH, for example). * Added a FPlatformMisc::GetMaxPathLength() function to return the maximum length of a path on the current system. On Windows, this returns a different value for systems with long paths enabled to those without. * The MAX_PATH define is no longer set by non-Windows platforms. Instead, there is a MAC_MAX_PATH, UNIX_MAX_PATH, etc... for any platform-specific code that still relies on the previous macro. * The MAX_UNREAL_FILENAME_LENGTH macro has been renamed to MAX_UNREAL_FILENAME_LENGTH_DEPRECATED * The PLATFORM_MAX_FILEPATH_LENGTH macro has been renamed to PLATFORM_MAX_FILEPATH_LENGTH_DEPRECATED. * Removed custom resource files for programs, since they are just copies of the base UE4 one (which is used by default anyway). The base UE4 manifest declares support for long paths. * Fix 512 character maximum length on editor commands. 260 character limit remains in place for cooking at the moment (see ContentBrowserUtils.h), until C# staging code supports long paths. Change 4255042 by Ben.Marsh UBT: Remote compilation now uploads the entire workspace to the remote Mac and executes a separate remote instance of UBT rather than synchronizing individual actions. This makes the remote compile codepath much simpler, and removes a lot of special cases that exist to support it previously. The list of files to be transferred to the remote are listed as rsync filter rules in Engine/Build/Rsync/RsyncEngine.txt and RsyncProject.txt, which are applied to the root engine directory and project directory respectively. Projects that need to customize which files are uploaded can add their own <ProjectDir>/Build/Rsync/RsyncProject.txt file, which will be included in the filter before the default version. Change 4260567 by Ben.Marsh UAT: Rename CommandUtils.Log to CommandUtils.LogInformation, to avoid conflicts with the underlying Tools.DotNETCommon.Log class. #rb none [CL 4285673 by Ben Marsh in Main branch]
2018-08-14 18:32:34 -04:00
LogInformation("Running UnrealFileServer *******");
var Args = String.Format("{0} -abslog={1} -unattended -CrashForUAT -log {2}",
CommandUtils.MakePathSafeToUseWithCommandLine(Params.RawProjectPath.FullName),
CommandUtils.MakePathSafeToUseWithCommandLine(ServerLogFile),
AdditionalCommandLine);
if (IsBuildMachine)
{
Args += " -buildmachine";
}
PushDir(Path.GetDirectoryName(UnrealFileServerExe));
var Result = Run(UnrealFileServerExe, Args, null, ERunOptions.AllowSpew | ERunOptions.NoWaitForExit | ERunOptions.AppMustExist | ERunOptions.NoStdOutRedirect);
PopDir();
return Result;
}
#endregion
}