2015-10-06 16:47:09 -04:00
// Copyright 1998-2015 Epic Games, Inc. All Rights Reserved.
# include "AnimGraphRuntimePrivatePCH.h"
# include "AnimNode_AnimDynamics.h"
Copying //UE4/Dev-Framework to Dev-Main (//UE4/Dev-Main)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2720406 on 2015/10/07 by Aaron.McLeran
Audio optimization
Don't search for nearest listener if there's only 1 listener.
Change 2720411 on 2015/10/07 by Aaron.McLeran
Fixing HRTF spatialization code with recent changes to stereo spatialization.
HRTF emitter posiition doesn't need to be converted to XAudio2 coordinates.
Change 2723829 on 2015/10/09 by Mieszko.Zielinski
Fixed NavigationSystem trying to set label of newly spawned navigation data #UE4
UE-21880
Change 2723873 on 2015/10/09 by Mieszko.Zielinski
Fixed a bug in FNavAgentProperties::IsEquivalent resulting in failing the test for FNavAgentProperties instances having default AgentStepHeight value (-1) #UE4
UE-21977
Change 2724834 on 2015/10/12 by Ori.Cohen
PR #1634: Add PxVehicleDriveNW support to PhysXVehicleManager.cpp (Contributed by zeduk)
Change 2724850 on 2015/10/12 by Marc.Audy
Fix sound not restarting in matinee preview when jumping back along timeline after reaching end
#codereview Nick.Darnell
Change 2726499 on 2015/10/13 by Ori.Cohen
Fix edge case where sphyl length and radius are 0 and they are not properly clamped to 0.1
Change 2726689 on 2015/10/13 by Marc.Audy
Make UPackage::PackageFlags private
Add debugging for UE-21181 to try and track down when EditorWorld's PackageFlags are getting flagged as PlayInEditor
#codereview Mike.Fricker
Change 2726862 on 2015/10/13 by Lukasz.Furman
removed unused code from DetourNavMeshQuery
#ue4 UE-21988
Change 2726888 on 2015/10/13 by Lukasz.Furman
fixed observer abort: both mode in behavior tree's cone check decorator
#ue4 UE-19375
Change 2726913 on 2015/10/13 by Lukasz.Furman
navmesh raycast will use nearest poly containing ray origin instead of just closest one
#ue4 UE-19334
Change 2726920 on 2015/10/13 by Marc.Audy
Re-unify ULevelStreaming::GetWorldAssetPackageName and GetWorldAssetPackageFName
#codereview Dmitriy.Dyomin, Bob.Tellez
Change 2726931 on 2015/10/13 by Lukasz.Furman
fixed missing Tick event in aborting behavior tree tasks from abandoned subtree
#ue4 UE-21777
Change 2728093 on 2015/10/14 by Ori.Cohen
Fix edge case of sphyl scale take two. The previous approach did double scaling
Change 2728577 on 2015/10/14 by Mieszko.Zielinski
Improved navmesh labeling condition #UE4
Change suggested by github user
#rb Lukasz.Furman
Change 2728587 on 2015/10/14 by Lukasz.Furman
fixed crowd simulation for auto possessed pawns placed on level
#ue4
#rb Mieszko.Zielinski
Change 2728629 on 2015/10/14 by Lukasz.Furman
fixed influence of navmesh edges on crowd simulation near end of path
#ue4 UE-21380
#rb Mieszko.Zielinski
Change 2728678 on 2015/10/14 by Lukasz.Furman
added Z check to detour's crowd avoidance segment gathering
#ue4 UE-20889
#rb Mieszko.Zielinski
Change 2728745 on 2015/10/14 by Lukasz.Furman
fixed copy&paste operation in behavior tree's composite decorators subgraphs
#ue4 UE-18740
Change 2729276 on 2015/10/14 by Stan.Melax
ensure all actors get recreated with new collision shape specification.
this wasn't being done for a couple of editing methods.
todo: this should be merged into 4.10
#UE-20961
#rb ori.cohen
Change 2730709 on 2015/10/15 by Marc.Audy
Prevent memory corruption when an invalid controller ID is passed in to the forcefeedback channel functions
#rb Lina.Halper
Change 2733590 on 2015/10/19 by Benn.Gallagher
Fixed various crashes when using undo and redo while manipulating state machines UE 22088
Change 2735143 on 2015/10/20 by Lukasz.Furman
clearing behavior tree debugger's state when displayed subtree becomes inactive
#ue4
#rb Mieszko.Zielinski
Change 2735144 on 2015/10/20 by Lukasz.Furman
rebuilding behavior tree graph node order when node is being moved
#ue4
#rb Mieszko.Zielinski
Change 2735403 on 2015/10/20 by sebastian.kowalczyk
Integrated fix for issue UE-18594 "Gameplay Debugger is hijacking the Canvas" issue from 4.10 (2735391). Extended previous fix to care about OSX users - it's possible to configure shortcuts in engine config file now (little different ones for osx platform).
Change 2736406 on 2015/10/21 by sebastian.kowalczyk
Added new GameplayDebugger as a plugin. Old gameplay debugger is still here to keep backward compatibility but it's deprecated now. Current projects should be moved to use new plugin soon.
Change 2736436 on 2015/10/21 by sebastian.kowalczyk
Fixed crash in gameplay debugger with player set as debug target.
Change 2736437 on 2015/10/21 by sebastian.kowalczyk
Added visual indicator around selected pawn to fix FORT-10273 issue. (FN is not using new gd plugin yet).
Change 2736489 on 2015/10/21 by sebastian.kowalczyk
Hide internal and debug hud classes from drop down lists.
Change 2736504 on 2015/10/21 by sebastian.kowalczyk
Fix for UE-18548 "EnableGDT does not work correctly in PIE".
Change 2736529 on 2015/10/21 by sebastian.kowalczyk
Fixed UE-18548 "EnableGDT does not work correctly in PIE"
Change 2736588 on 2015/10/21 by sebastian.kowalczyk
Removed old log visualizer classes.
Change 2736700 on 2015/10/21 by sebastian.kowalczyk
Fixed UE-19256 "Perception debug data doesn't get replicated by Gameplay Debuger" for old gameplay debugger module.
Change 2737180 on 2015/10/21 by Zak.Middleton
#ue4 - Fix UPrimitiveComponent::GetCollisionShape not correctly enforcing bounds limits.
#rb Aaron.Mcleran
#jira UE-22436
Change 2738084 on 2015/10/22 by sebastian.kowalczyk
Better indication of selected pawn for Gameplay Debugger.
Change 2738413 on 2015/10/22 by Marc.Audy
Disable duplication of worlds/maps via the content browser
#jira UE-22200
#rb James.Golding
Change 2739743 on 2015/10/23 by bruce.nesbit
UE-18707 - Issue with drawing material triangle on canvas #1387
Added DrawTriangleUsingVertexColor
Change 2739751 on 2015/10/23 by bruce.nesbit
Revised bShowDebugForReticleTarget should not be static #1539
Change 2739788 on 2015/10/23 by bruce.nesbit
Revised the 2 functions that used FTriangleRenderer::DrawTriangle to use FTriangleRenderer::DrawTriangleUsingVertexColor
Fixed compile error
Change 2739870 on 2015/10/23 by Marc.Audy
Avoid issues while detaching child components if OnAttachmentChange were to remove a sibling component itself.
#jira UE-22362
#rb Zak.Middleton
Change 2739882 on 2015/10/23 by sebastian.kowalczyk
Fix for UE-20901 "VisualLog redirections are broken after PIE finishes" issue.
Change 2740140 on 2015/10/23 by Marc.Audy
Ensure that components reregister tick functions after seamless travel
#jira UE-20892
#rb Zak.Middleton
Change 2740614 on 2015/10/23 by Ori.Cohen
Fix linker issues for people wanting to use physics lock lambdas
Change 2740674 on 2015/10/23 by Aaron.McLeran
Sound Focus Feature
Added new parameters to SoundAttenuation settings to allow audio to change behavior based on its angle to the listener
- Define the min/max azimuth angle to establish in-focus and non-focus regions
- Can scale the priority of a sound based on focus angle
- Can attenuate the volume of a sound based on focus angle
- Can scale the listener-emitter distance based on focus angle
- Distance scale is applied when determining max audible distance for USoundBase
- Can opt-out of focus effects for a sound at the USoundBase level
#rb Ryan.Vance
Change 2741542 on 2015/10/26 by Lukasz.Furman
lowered min value clamping in navigation filter properties
#ue4
#rb Mieszko.Zielinski
Change 2743227 on 2015/10/27 by Marc.Audy
Make ASceneCaptureCube subclassable outside of Engine module
#jira UE-22609
Make USceneCaptureComponentCube::UpdateContent callable outside of Engine module
#jira UE-22610
#rb Jeff.Farris
Change 2743255 on 2015/10/27 by Marc.Audy
Wrap FActorSpawnParameters class with deprecation warning disable pragma instead of hand implementing copy constructor
#rb Jeff.Farris
Change 2743729 on 2015/10/27 by Ori.Cohen
Fix case where we spawn and adjust location which gives us implicit velocity.
#codereview Stan.Melax
Change 2746135 on 2015/10/29 by sebastian.kowalczyk
Fixed UE-21668 "Saving log filters selected in LogVisualizer causes insane ini file sizes! And doesn't really work."
Change 2746437 on 2015/10/29 by Lukasz.Furman
pass on verifying behavior tree stack before accessing its elements
#ue4
#rb Mieszko.Zielinski
Change 2748028 on 2015/10/30 by sebastian.kowalczyk
Changed GameplayDebugger's console variable from gd.EQSOnHUD to ai.gd.EQSOnHUD" after suggestion with MieszkoZ.
Change 2748184 on 2015/10/30 by Aaron.McLeran
UE-22693 Fix for streaming bug
- 3rd decoded buffer in initial 3 buffers was not getting submitted to xaudio2 voice resulting in garbled/skipped audio.
- Wasn't able to repro the 'cannot read chunk' part of the bug
#rb ryan.vance
Change 2749255 on 2015/10/31 by sebastian.kowalczyk
Fixed ai.gd.EQSOnHUD console variable after rename from gd.EQSOnHUD.
Change 2749276 on 2015/10/31 by sebastian.kowalczyk
Added switch to toggle highlight of selected actor to GameplayDebugger.
Change 2749318 on 2015/10/31 by sebastian.kowalczyk
New Gameplay Debugger plugin can be used with old module simultaneously. It's best to configure different keyboard binding for plugin when using old module (it can be set in project settings, for new gameplay debugger plugin - when activated for project).
Change 2749337 on 2015/10/31 by sebastian.kowalczyk
Fixed GameplayDebugger compilation in shipping/test builds.
Change 2749376 on 2015/10/31 by sebastian.kowalczyk
Small clean-up in gameplay debugger class for BT.
Change 2749931 on 2015/11/02 by James.Golding
Add stats to ProcMeshComp
Change 2749932 on 2015/11/02 by James.Golding
Remove PhysicsThrusterComponent.h from Engine.h
Change 2749960 on 2015/11/02 by James.Golding
- Fix PS4 compile errors in ActiveSound.cpp
- Constructor order of FActiveSound
- Shadowed AudioComponent var in CheckOcclusion
#RB thomas.sarkanen
#codereview aaron.mcleran
Change 2749961 on 2015/11/02 by James.Golding
Fix PS4 compile errors in GameplayDebuggerBaseObject.cpp
- Shadowed DefaultContext function param, now just Context, which matches declaration
#RB thomas.sarkanen
#codereview sebastian.kowalczyk
Change 2750026 on 2015/11/02 by Thomas.Sarkanen
Anim Multithreading: thread-safety refactor
Segregated access to various parts of anim update data by spitting off a new proxy class (FAnimInstanceProxy) containing all data accessed in Update() and Evaluate() passes. Gated access to the proxy data on the game thread in a number of ways:
- Explicit access via GetValueOnGameThread() - this blocks on any existing task, completes and then allows control to return to the accessing function. This allows stuff like Blueprints to continue to operate as normal.
- Explicit access via GetValueOnAnyThread() - this ensures that in the limited set of circumstances we need this (Blueprint pure functions mostly) that conditions are met about concurrent access.
- Deprecating many APIs on UAnimInstance that should not be used (and in fact are not used at present, happily).
Derived classes of UAnimInstance can override the creation of the proxy class to create their own type. We do this for UAnimSingleNodeInstance etc.
Any API deprecation should continue to function - no functions have been removed yet. The only things that are not backwards-compatible are direct access to some public member variables for which there is no way to support (e.g. via references, for example UngroupedActivePlayerArrays).
Some APIs have been changed to more specifically represent the dependencies involved. For example TickAssetPlayerInstance() used to take a UAnimInstance*, only to use it to simply queue notifies. This has been deprecated and replaced with a new FNotifyQueue API. FNotifyQueue also uses a thread-safe FRandomStream instead of FMath::Rand.
Many changes are due to substituting accessor functions for direct variable access.
Removed 'service' tick group as we no longer need to segregate the running of our parallel update.
Anim nodes that need to do some game thread-side update should register for a pre-update callback delegate in the proxy. See FAnimNode_AnimDynamics for an example of this.
Moved UpdateActiveVertexAnims into FAnimRuntime so I can subsume some of the code that was in USkeletalMeshComponent::EvaluateAnimation into UAnimInstance (and hence keep the proxy access private).
#rb Martin.Wilson,Lina.Halper
#codereview Michael.Noland
Change 2750077 on 2015/11/02 by Marc.Audy
Expose UInputComponent::BindAction that supports WithKey delegate signature
Change 2751767 on 2015/11/03 by Thomas.Sarkanen
Added extra support to Anim Blueprint 'fast-path'
Added support for negated bools (value gets negated during copy).
Added support for copying from struct members (via break struct) and split struct pins.
Removed potentially troublesome references to BP-constructed UProperties, replacing them with the property FName. This adds some extra Initialize() overhead, but prevents various crash-on load issues (one when generating the class CRC). Added guard to prevent multiple initialization to save this more expensive work being done more often.
#rb Martin.Wilson
Change 2752158 on 2015/11/03 by Jeff.Farris
Fixed UGameplayStatics::SpawnEmitterAttached() to register the ParticleSystemComponent after it spawns.
#rb marc.audy
Change 2752159 on 2015/11/03 by Jeff.Farris
Improvements to camera lens effects to (EmitterCameraLensEffectBase)
- can now specify a transform to align the emitter with the camera
- exposed several key parameters to Blueprints
- ENGINE_API now applies to the entire class
#rb marc.audy
Change 2753454 on 2015/11/04 by Thomas.Sarkanen
Fixup deprecation warnings fallout from multithreaded update changes.
Fixed up use of AnimInstance in Vicon plugin.
Fixed up use of AnimInstance in slope warping node.
Un-deprecated some APIs to become warning free (these APIs are safe to call but just a 'bad idea if you want to do it right').
Also an extra API to allow for smoother transition: Allow custom allocation/deallocation (including using a proxy member struct) by providing an override point for proxy destruction.
#rb Martin.Wilson
Change 2754099 on 2015/11/04 by Ori.Cohen
Fix for task threads dropping stats (from Gil)
#rb Gil.Gribb
Change 2754449 on 2015/11/04 by Marc.Audy
Ensure that components created from an Actor's blueprint BeginPlay implementation get BeginPlay called on them and register their component ticks
#jira UE-20853
Reorganize some booleans to get better bit packing
#rb Jeff.Farris
#codereview Mieszko.Zielinski
Change 2754573 on 2015/11/04 by Aaron.McLeran
Fixing audio component PostLoad code to not set all LowPassFilterFrequency values to 0.0f
Change 2755345 on 2015/11/05 by Thomas.Sarkanen
Added deprecated constructors for various animation contexts
Allows existing code to compile if it creates its own contexts from UAnimInstance.
#rb James.Golding
Change 2755348 on 2015/11/05 by James.Golding
Add BP-exposed SetBoundsScale function to PrimitiveComponent
#RB thomas.sarkanen
Change 2755437 on 2015/11/05 by Marc.Audy
Fix compile errors
#codereview Thomas.Sarkanen, Mieszko.Zielinski, Aaron.McLeran
Change 2755982 on 2015/11/05 by Marc.Audy
Move HeaderParse changes for deprecation macro from Core
Fix world settings warning
Change 2756028 on 2015/11/05 by Marc.Audy
Fix shadow variable issue
Change 2756090 on 2015/11/05 by Ori.Cohen
Improve budget tool so that task threads are computed automatically.
#rb Gil.Gribb
Change 2756120 on 2015/11/05 by Mieszko.Zielinski
Fixed AIController::MoveTo not using DefaultQueryExtent of its navigation data #UE4
#rb Lukasz.Furman
Change 2756243 on 2015/11/05 by Mieszko.Zielinski
Fixed AI perception sight's "auto-visibility" mechanism totally skipping distance and vision cone checks #UE4
The old way was resulting in false positives when for example observer teleported somewhere far
#rb Lukasz.Furman
#codereview John.Abercrombie
Change 2756280 on 2015/11/05 by Mieszko.Zielinski
Minor VLog code cleanup and dumb-fixing visual logger accessing timer manager off of game thread #UE4
#rb Lukasz.Furman
Change 2756500 on 2015/11/05 by Mieszko.Zielinski
Added sanity-checking to BlueprintNodeHelpers::HasBlueprintFunction and cleaned up its usage #UE4
Also, refactored its parameters into references over pointers.
#rb Lukasz.Furman
Change 2757041 on 2015/11/06 by Thomas.Sarkanen
Removed check() in UAnimInstance::GetProxyOnAnyThread()
The check was no longer needed as if we are on the game thread we block until tasks are completed below, and if we are on any other thread we are 'safe' anyway.
#rb James.Golding
Change 2757207 on 2015/11/06 by Ori.Cohen
Fix incorrect root body cache which causes a single frame "freak out" when simulating physics from an animation
#rb Lina.Halper
Change 2757238 on 2015/11/06 by Marc.Audy
Force compiler generated functions to be generated for FHierarchicalSimplification in WorldSettings.h so that they are generated while the deprecation warnings are disabled.
#rb Mike.Fricker
Change 2757284 on 2015/11/06 by Stan.Melax
tapered capsule drawing
cloth collision happens with spheres and for the hull or tapered capsule goemetry between any specified pair of spheres.
(this was already code reviewed before, but missed the check-in window before streamtime)
#rb ori.cohen
Change 2757743 on 2015/11/06 by Lukasz.Furman
fixed node memory allocations for injected behavior tree decorators
#ue4 UE-22783
#rb Mieszko.Zielinski
Change 2757772 on 2015/11/06 by Lukasz.Furman
added setters for crowd avoidance
#ue4 UE-22785
#rb Mieszko.Zielinski
Change 2758422 on 2015/11/07 by Lina.Halper
Potential fix for invalid root bone index input
#jira :/UE-23086
#code review: Ori.Cohen
Change 2758429 on 2015/11/07 by Mieszko.Zielinski
Reimplemented a fix for AI Sight's "auto seeing" mechanics in a more flexible way #UE4
#jira UE-23089
Change 2758571 on 2015/11/08 by Mieszko.Zielinski
Modified ensure condition in UAIPerceptionComponent::OnRegister so it doesn't go off when BP does it's magic when components are being added to a BP actor class #UE4
#jira UE-23080
Change 2758821 on 2015/11/09 by Thomas.Sarkanen
Fixed animations no longer playing when using a dedicated server.
Uses correct logic to determine whether we are running as a server or not.
#rb Martin.Wilson
Change 2758920 on 2015/11/09 by Marc.Audy
Don't dereference weak object pointers repeatedly in FBoneContainer::Initialize
#rb Lina.Halper
Change 2758944 on 2015/11/09 by Ori.Cohen
Fix crash when stats are only on one thread and budget mode is used
Change 2758967 on 2015/11/09 by Benn.Gallagher
Fix for crash undoing notify socket changes in Persona, needed to recache the notify track data after the transaction had reserialized the sequence.
#jira UE-22963
Change 2758973 on 2015/11/09 by Benn.Gallagher
Added new 'Random Player' node for anim graphs allowing the user to play a selection of animations in a random order with certain randomised paramers. Also allows 'Shuffle Mode' to act more like a playlist in that it will play everything on the list before repeating.
#rb Bruce.Nesbit
Change 2759219 on 2015/11/09 by Ori.Cohen
Character perf test is now looking at stats directly and sending to analytics
#RB Ben.Salem
Change 2759398 on 2015/11/09 by Lina.Halper
Fix issue where placed montages are not playing.
- the issue is that IsPlaying does not consider montage, but SetPlaying does. It is asymmetry, so I made it same. However, there are other functions that need to be re-looked at wr.t. montage
#code review: Thomas.Sarkanen
#RB: Marc.Audy
Change 2759491 on 2015/11/09 by Lina.Halper
#Anim: Fix not getting input correctly for Copy Pose node
#RB: Marc.Audy
Change 2759602 on 2015/11/09 by Marc.Audy
Fix imporperly named struct
Change 2759795 on 2015/11/09 by Aaron.McLeran
UE-23145 Adding a Priority value to USoundBase to use in concurrency evaluation and sorting wave instances for voice stealing.
#rb zak.middleton
Change 2760081 on 2015/11/09 by Aaron.McLeran
UE-23091 Adding more logging for NaN checks and fixing one source of NaNs for audio.
OmniDirectional Math Explanation:
For XAudio2, because we do our own distance-attenuation calculations, we use the X3dAudio2 API to simply compute a speaker-map for spatialization and force the listener to be at the origin and the emitter to be on the unit-circle. Thus, from XAudio2's perspective, all distances for every listener-emitter pair will be 1.0.
So in order to use the InnerRadius blending feature, we need to trick it into doing a an inner radius blend relative to a distance of 1.0. For example, if OmniRadius and Distance are the same, then the "NormalizedOmniRadius" is 1.0 and XAudio2 will begin its "blend" of the sound to an omni-directional speaker map.
If Emitter-listener distance is less than the OmniRadius, we'll want to do more blending to an omni-directional speaker map, but we need to set the InnerRadius to something greater than 1.0 (i.e. so that the normalized distance of 1.0 will be treated as less than the InnerRadius). To do "full" omni-directional blending, the emitter-listener distance will be 0 or close to zero, and the NormalizedOmniRadius will be very large (i.e. close to infiinity).
The previous math just set the NormalizedOmniRadius to FLT_MAX which is fine but that number is eventually squared before making the API call. FLT_MAX squared is INF.
Note: I do not think we need to square the OmniRadius in:
Emitter.InnerRadius = OmniRadius*OmniRadius;
But I am keeping it t here because of legacy content which depends on that behavior.
#rb zak.middleton
hange 2760401 on 2015/11/10 by Thomas.Sarkanen@Thomas.Sarkanen-Dev-Framework
Re-instated deleted protected functions in UAnimInstance.
Fixed access of UAnimInstance in FAnimNode_StateMachine.
#rb Martin.Wilson
Change 2760407 on 2015/11/10 by Jurre.deBaare
Construct raw meshes for spline meshes now uses the render data instead of original model data (preserves tangents/normals)
Change 2760468 on 2015/11/10 by Benn.Gallagher
Anim Dynamics optimizations, cached iteration independant data to reduce footprint of iteration on limits.
#rb Graeme.Thornton
Change 2760613 on 2015/11/10 by Jeff.Farris
Fixed async collision completion delegate potentially firing repeatedly. (UE-23149)
#cr marc.audy
#codereview lina.halper
Change 2760795 on 2015/11/10 by Marc.Audy
Don't compile in pointless AddReferencedObjects when with editoronly data not defined
Minor coding standard cleanup (NULL and auto)
Change 2760848 on 2015/11/10 by Benn.Gallagher
Fix to anim instance proxy to not rely on state machine initialization to bind native delegates as nested state machines are not guaranteed to be initialized. This was fixed in UAnimInstance originally but broken again by the proxy instance code.
#jira UE-23164
#rb Martin.Wilson
Change 2760866 on 2015/11/10 by Marc.Audy
Manage transient visualization components for camera component in the same way that sprite component for other actor components are
#rb Mike.Beach
Change 2760963 on 2015/11/10 by Marc.Audy
Since construction script can cause actors to be spawned don't use a ranged for to iterate
#jira UE-22639
#rb Jeff.Farris
#codereview Dmitriy.Dyomin
Change 2762297 on 2015/11/11 by James.Golding
UE-23086 Don't ensure in SetRootBodyIndex when Bodies array is empty (ie no physics state created)
#rb martin.wilson
#codereview ori.cohen, lina.halper
Change 2763566 on 2015/11/11 by Lina.Halper
FAnimNode_CopyPoseFromMesh::Evaluate - was accessing skeleton joint, not mesh joint.
#RB: Laurent.Delayen
Change 2763926 on 2015/11/12 by Thomas.Sarkanen
Fix anim notifies not firing from single anim instances
UE-23248 - Anim Notifies are not working for Animation Sequences
UE-23249 - Anim Notifies using Sound Cues do not work
#rb James.Golding
Change 2764039 on 2015/11/12 by Jurre.deBaare
Fix for issue with incorrect material indices after reducing a skeletal mesh with non LOD0 mesh as BaseLOD (OR-9243) #rb Lina.Halper
Change 2764307 on 2015/11/12 by Jurre.deBaare
VS2015 SSF library
Change 2764314 on 2015/11/12 by Stan.Melax
crashfix was putting bad bodies to sleep at start
Fatal error!
Unhandled Exception: EXCEPTION_ACCESS_VIOLATION reading address 0x00000000
UE4Editor-Engine.dll!USkeletalMeshComponent::InitArticulated() [...\\engine\\source\\runtime\\engine\\private\\skeletalmeshcomponentphysics.cpp:875]
On some skeletalmeshcomponent, some bodies aren't getting created correctly. Trying to force them to sleep was causing a crash - it expected instantiated physx bodies. Seems that all the rest of the code is able to tolerate bad bodies.
Added check to ensure physx body exists before trying to force it to sleep.
not sure if bad bodies are the norm or if this fix is just more "kicking the can down the road".
#codereview ori.cohen
Change 2764343 on 2015/11/12 by Jurre.deBaare
- Fixed crash when building a LOD with SubActors.Num < 2
- Force HLOD level slider is now always enabled, however won't show complete image if not all HLODs are build
- LODActor tree view item now scrolls into view if selected in the world
- Set bAllowCullDistanceVolume to false for LODActor's static mesh components by default
- Added 7zip files
- Fixed issue with WinINet complaining about http-request without 'http://' prefix
- Changed % reduced or original triangles display string, now uses float instead of int (for < 1% reductions)
- Override texture sizes and automatic texture bias
- Fixed issue with incorrect material merging, not picking up it required mesh-data during baking. Added extra conditions for rendering with mesh-data.
- Now incorporate static meshes with opague materials into HLOD merging
- Fixed issue with incorrect normals after merging meshes who's owning components had been negatively scaled
- Fixed issue with incorrect texture size being set from MergeActor window (was only changing .X component)
- Fixed issue with material merging when meshes with multiple LODs are merged, right now only merges LOD0's together if we are also merging the materials (otherwise, merge each LOD)
- Added ENUM for texture scaling/resizing type that has to be applied while merging the materials
- Added detail customization class for FMaterialProxySettings
#rb James.Golding
[CL 2765024 by Marc Audy in Main branch]
2015-11-12 18:11:48 -05:00
# include "Animation/AnimInstanceProxy.h"
2015-10-06 16:47:09 -04:00
Copying //UE4/Dev-Framework to Dev-Main (//UE4/Dev-Main)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2720406 on 2015/10/07 by Aaron.McLeran
Audio optimization
Don't search for nearest listener if there's only 1 listener.
Change 2720411 on 2015/10/07 by Aaron.McLeran
Fixing HRTF spatialization code with recent changes to stereo spatialization.
HRTF emitter posiition doesn't need to be converted to XAudio2 coordinates.
Change 2723829 on 2015/10/09 by Mieszko.Zielinski
Fixed NavigationSystem trying to set label of newly spawned navigation data #UE4
UE-21880
Change 2723873 on 2015/10/09 by Mieszko.Zielinski
Fixed a bug in FNavAgentProperties::IsEquivalent resulting in failing the test for FNavAgentProperties instances having default AgentStepHeight value (-1) #UE4
UE-21977
Change 2724834 on 2015/10/12 by Ori.Cohen
PR #1634: Add PxVehicleDriveNW support to PhysXVehicleManager.cpp (Contributed by zeduk)
Change 2724850 on 2015/10/12 by Marc.Audy
Fix sound not restarting in matinee preview when jumping back along timeline after reaching end
#codereview Nick.Darnell
Change 2726499 on 2015/10/13 by Ori.Cohen
Fix edge case where sphyl length and radius are 0 and they are not properly clamped to 0.1
Change 2726689 on 2015/10/13 by Marc.Audy
Make UPackage::PackageFlags private
Add debugging for UE-21181 to try and track down when EditorWorld's PackageFlags are getting flagged as PlayInEditor
#codereview Mike.Fricker
Change 2726862 on 2015/10/13 by Lukasz.Furman
removed unused code from DetourNavMeshQuery
#ue4 UE-21988
Change 2726888 on 2015/10/13 by Lukasz.Furman
fixed observer abort: both mode in behavior tree's cone check decorator
#ue4 UE-19375
Change 2726913 on 2015/10/13 by Lukasz.Furman
navmesh raycast will use nearest poly containing ray origin instead of just closest one
#ue4 UE-19334
Change 2726920 on 2015/10/13 by Marc.Audy
Re-unify ULevelStreaming::GetWorldAssetPackageName and GetWorldAssetPackageFName
#codereview Dmitriy.Dyomin, Bob.Tellez
Change 2726931 on 2015/10/13 by Lukasz.Furman
fixed missing Tick event in aborting behavior tree tasks from abandoned subtree
#ue4 UE-21777
Change 2728093 on 2015/10/14 by Ori.Cohen
Fix edge case of sphyl scale take two. The previous approach did double scaling
Change 2728577 on 2015/10/14 by Mieszko.Zielinski
Improved navmesh labeling condition #UE4
Change suggested by github user
#rb Lukasz.Furman
Change 2728587 on 2015/10/14 by Lukasz.Furman
fixed crowd simulation for auto possessed pawns placed on level
#ue4
#rb Mieszko.Zielinski
Change 2728629 on 2015/10/14 by Lukasz.Furman
fixed influence of navmesh edges on crowd simulation near end of path
#ue4 UE-21380
#rb Mieszko.Zielinski
Change 2728678 on 2015/10/14 by Lukasz.Furman
added Z check to detour's crowd avoidance segment gathering
#ue4 UE-20889
#rb Mieszko.Zielinski
Change 2728745 on 2015/10/14 by Lukasz.Furman
fixed copy&paste operation in behavior tree's composite decorators subgraphs
#ue4 UE-18740
Change 2729276 on 2015/10/14 by Stan.Melax
ensure all actors get recreated with new collision shape specification.
this wasn't being done for a couple of editing methods.
todo: this should be merged into 4.10
#UE-20961
#rb ori.cohen
Change 2730709 on 2015/10/15 by Marc.Audy
Prevent memory corruption when an invalid controller ID is passed in to the forcefeedback channel functions
#rb Lina.Halper
Change 2733590 on 2015/10/19 by Benn.Gallagher
Fixed various crashes when using undo and redo while manipulating state machines UE 22088
Change 2735143 on 2015/10/20 by Lukasz.Furman
clearing behavior tree debugger's state when displayed subtree becomes inactive
#ue4
#rb Mieszko.Zielinski
Change 2735144 on 2015/10/20 by Lukasz.Furman
rebuilding behavior tree graph node order when node is being moved
#ue4
#rb Mieszko.Zielinski
Change 2735403 on 2015/10/20 by sebastian.kowalczyk
Integrated fix for issue UE-18594 "Gameplay Debugger is hijacking the Canvas" issue from 4.10 (2735391). Extended previous fix to care about OSX users - it's possible to configure shortcuts in engine config file now (little different ones for osx platform).
Change 2736406 on 2015/10/21 by sebastian.kowalczyk
Added new GameplayDebugger as a plugin. Old gameplay debugger is still here to keep backward compatibility but it's deprecated now. Current projects should be moved to use new plugin soon.
Change 2736436 on 2015/10/21 by sebastian.kowalczyk
Fixed crash in gameplay debugger with player set as debug target.
Change 2736437 on 2015/10/21 by sebastian.kowalczyk
Added visual indicator around selected pawn to fix FORT-10273 issue. (FN is not using new gd plugin yet).
Change 2736489 on 2015/10/21 by sebastian.kowalczyk
Hide internal and debug hud classes from drop down lists.
Change 2736504 on 2015/10/21 by sebastian.kowalczyk
Fix for UE-18548 "EnableGDT does not work correctly in PIE".
Change 2736529 on 2015/10/21 by sebastian.kowalczyk
Fixed UE-18548 "EnableGDT does not work correctly in PIE"
Change 2736588 on 2015/10/21 by sebastian.kowalczyk
Removed old log visualizer classes.
Change 2736700 on 2015/10/21 by sebastian.kowalczyk
Fixed UE-19256 "Perception debug data doesn't get replicated by Gameplay Debuger" for old gameplay debugger module.
Change 2737180 on 2015/10/21 by Zak.Middleton
#ue4 - Fix UPrimitiveComponent::GetCollisionShape not correctly enforcing bounds limits.
#rb Aaron.Mcleran
#jira UE-22436
Change 2738084 on 2015/10/22 by sebastian.kowalczyk
Better indication of selected pawn for Gameplay Debugger.
Change 2738413 on 2015/10/22 by Marc.Audy
Disable duplication of worlds/maps via the content browser
#jira UE-22200
#rb James.Golding
Change 2739743 on 2015/10/23 by bruce.nesbit
UE-18707 - Issue with drawing material triangle on canvas #1387
Added DrawTriangleUsingVertexColor
Change 2739751 on 2015/10/23 by bruce.nesbit
Revised bShowDebugForReticleTarget should not be static #1539
Change 2739788 on 2015/10/23 by bruce.nesbit
Revised the 2 functions that used FTriangleRenderer::DrawTriangle to use FTriangleRenderer::DrawTriangleUsingVertexColor
Fixed compile error
Change 2739870 on 2015/10/23 by Marc.Audy
Avoid issues while detaching child components if OnAttachmentChange were to remove a sibling component itself.
#jira UE-22362
#rb Zak.Middleton
Change 2739882 on 2015/10/23 by sebastian.kowalczyk
Fix for UE-20901 "VisualLog redirections are broken after PIE finishes" issue.
Change 2740140 on 2015/10/23 by Marc.Audy
Ensure that components reregister tick functions after seamless travel
#jira UE-20892
#rb Zak.Middleton
Change 2740614 on 2015/10/23 by Ori.Cohen
Fix linker issues for people wanting to use physics lock lambdas
Change 2740674 on 2015/10/23 by Aaron.McLeran
Sound Focus Feature
Added new parameters to SoundAttenuation settings to allow audio to change behavior based on its angle to the listener
- Define the min/max azimuth angle to establish in-focus and non-focus regions
- Can scale the priority of a sound based on focus angle
- Can attenuate the volume of a sound based on focus angle
- Can scale the listener-emitter distance based on focus angle
- Distance scale is applied when determining max audible distance for USoundBase
- Can opt-out of focus effects for a sound at the USoundBase level
#rb Ryan.Vance
Change 2741542 on 2015/10/26 by Lukasz.Furman
lowered min value clamping in navigation filter properties
#ue4
#rb Mieszko.Zielinski
Change 2743227 on 2015/10/27 by Marc.Audy
Make ASceneCaptureCube subclassable outside of Engine module
#jira UE-22609
Make USceneCaptureComponentCube::UpdateContent callable outside of Engine module
#jira UE-22610
#rb Jeff.Farris
Change 2743255 on 2015/10/27 by Marc.Audy
Wrap FActorSpawnParameters class with deprecation warning disable pragma instead of hand implementing copy constructor
#rb Jeff.Farris
Change 2743729 on 2015/10/27 by Ori.Cohen
Fix case where we spawn and adjust location which gives us implicit velocity.
#codereview Stan.Melax
Change 2746135 on 2015/10/29 by sebastian.kowalczyk
Fixed UE-21668 "Saving log filters selected in LogVisualizer causes insane ini file sizes! And doesn't really work."
Change 2746437 on 2015/10/29 by Lukasz.Furman
pass on verifying behavior tree stack before accessing its elements
#ue4
#rb Mieszko.Zielinski
Change 2748028 on 2015/10/30 by sebastian.kowalczyk
Changed GameplayDebugger's console variable from gd.EQSOnHUD to ai.gd.EQSOnHUD" after suggestion with MieszkoZ.
Change 2748184 on 2015/10/30 by Aaron.McLeran
UE-22693 Fix for streaming bug
- 3rd decoded buffer in initial 3 buffers was not getting submitted to xaudio2 voice resulting in garbled/skipped audio.
- Wasn't able to repro the 'cannot read chunk' part of the bug
#rb ryan.vance
Change 2749255 on 2015/10/31 by sebastian.kowalczyk
Fixed ai.gd.EQSOnHUD console variable after rename from gd.EQSOnHUD.
Change 2749276 on 2015/10/31 by sebastian.kowalczyk
Added switch to toggle highlight of selected actor to GameplayDebugger.
Change 2749318 on 2015/10/31 by sebastian.kowalczyk
New Gameplay Debugger plugin can be used with old module simultaneously. It's best to configure different keyboard binding for plugin when using old module (it can be set in project settings, for new gameplay debugger plugin - when activated for project).
Change 2749337 on 2015/10/31 by sebastian.kowalczyk
Fixed GameplayDebugger compilation in shipping/test builds.
Change 2749376 on 2015/10/31 by sebastian.kowalczyk
Small clean-up in gameplay debugger class for BT.
Change 2749931 on 2015/11/02 by James.Golding
Add stats to ProcMeshComp
Change 2749932 on 2015/11/02 by James.Golding
Remove PhysicsThrusterComponent.h from Engine.h
Change 2749960 on 2015/11/02 by James.Golding
- Fix PS4 compile errors in ActiveSound.cpp
- Constructor order of FActiveSound
- Shadowed AudioComponent var in CheckOcclusion
#RB thomas.sarkanen
#codereview aaron.mcleran
Change 2749961 on 2015/11/02 by James.Golding
Fix PS4 compile errors in GameplayDebuggerBaseObject.cpp
- Shadowed DefaultContext function param, now just Context, which matches declaration
#RB thomas.sarkanen
#codereview sebastian.kowalczyk
Change 2750026 on 2015/11/02 by Thomas.Sarkanen
Anim Multithreading: thread-safety refactor
Segregated access to various parts of anim update data by spitting off a new proxy class (FAnimInstanceProxy) containing all data accessed in Update() and Evaluate() passes. Gated access to the proxy data on the game thread in a number of ways:
- Explicit access via GetValueOnGameThread() - this blocks on any existing task, completes and then allows control to return to the accessing function. This allows stuff like Blueprints to continue to operate as normal.
- Explicit access via GetValueOnAnyThread() - this ensures that in the limited set of circumstances we need this (Blueprint pure functions mostly) that conditions are met about concurrent access.
- Deprecating many APIs on UAnimInstance that should not be used (and in fact are not used at present, happily).
Derived classes of UAnimInstance can override the creation of the proxy class to create their own type. We do this for UAnimSingleNodeInstance etc.
Any API deprecation should continue to function - no functions have been removed yet. The only things that are not backwards-compatible are direct access to some public member variables for which there is no way to support (e.g. via references, for example UngroupedActivePlayerArrays).
Some APIs have been changed to more specifically represent the dependencies involved. For example TickAssetPlayerInstance() used to take a UAnimInstance*, only to use it to simply queue notifies. This has been deprecated and replaced with a new FNotifyQueue API. FNotifyQueue also uses a thread-safe FRandomStream instead of FMath::Rand.
Many changes are due to substituting accessor functions for direct variable access.
Removed 'service' tick group as we no longer need to segregate the running of our parallel update.
Anim nodes that need to do some game thread-side update should register for a pre-update callback delegate in the proxy. See FAnimNode_AnimDynamics for an example of this.
Moved UpdateActiveVertexAnims into FAnimRuntime so I can subsume some of the code that was in USkeletalMeshComponent::EvaluateAnimation into UAnimInstance (and hence keep the proxy access private).
#rb Martin.Wilson,Lina.Halper
#codereview Michael.Noland
Change 2750077 on 2015/11/02 by Marc.Audy
Expose UInputComponent::BindAction that supports WithKey delegate signature
Change 2751767 on 2015/11/03 by Thomas.Sarkanen
Added extra support to Anim Blueprint 'fast-path'
Added support for negated bools (value gets negated during copy).
Added support for copying from struct members (via break struct) and split struct pins.
Removed potentially troublesome references to BP-constructed UProperties, replacing them with the property FName. This adds some extra Initialize() overhead, but prevents various crash-on load issues (one when generating the class CRC). Added guard to prevent multiple initialization to save this more expensive work being done more often.
#rb Martin.Wilson
Change 2752158 on 2015/11/03 by Jeff.Farris
Fixed UGameplayStatics::SpawnEmitterAttached() to register the ParticleSystemComponent after it spawns.
#rb marc.audy
Change 2752159 on 2015/11/03 by Jeff.Farris
Improvements to camera lens effects to (EmitterCameraLensEffectBase)
- can now specify a transform to align the emitter with the camera
- exposed several key parameters to Blueprints
- ENGINE_API now applies to the entire class
#rb marc.audy
Change 2753454 on 2015/11/04 by Thomas.Sarkanen
Fixup deprecation warnings fallout from multithreaded update changes.
Fixed up use of AnimInstance in Vicon plugin.
Fixed up use of AnimInstance in slope warping node.
Un-deprecated some APIs to become warning free (these APIs are safe to call but just a 'bad idea if you want to do it right').
Also an extra API to allow for smoother transition: Allow custom allocation/deallocation (including using a proxy member struct) by providing an override point for proxy destruction.
#rb Martin.Wilson
Change 2754099 on 2015/11/04 by Ori.Cohen
Fix for task threads dropping stats (from Gil)
#rb Gil.Gribb
Change 2754449 on 2015/11/04 by Marc.Audy
Ensure that components created from an Actor's blueprint BeginPlay implementation get BeginPlay called on them and register their component ticks
#jira UE-20853
Reorganize some booleans to get better bit packing
#rb Jeff.Farris
#codereview Mieszko.Zielinski
Change 2754573 on 2015/11/04 by Aaron.McLeran
Fixing audio component PostLoad code to not set all LowPassFilterFrequency values to 0.0f
Change 2755345 on 2015/11/05 by Thomas.Sarkanen
Added deprecated constructors for various animation contexts
Allows existing code to compile if it creates its own contexts from UAnimInstance.
#rb James.Golding
Change 2755348 on 2015/11/05 by James.Golding
Add BP-exposed SetBoundsScale function to PrimitiveComponent
#RB thomas.sarkanen
Change 2755437 on 2015/11/05 by Marc.Audy
Fix compile errors
#codereview Thomas.Sarkanen, Mieszko.Zielinski, Aaron.McLeran
Change 2755982 on 2015/11/05 by Marc.Audy
Move HeaderParse changes for deprecation macro from Core
Fix world settings warning
Change 2756028 on 2015/11/05 by Marc.Audy
Fix shadow variable issue
Change 2756090 on 2015/11/05 by Ori.Cohen
Improve budget tool so that task threads are computed automatically.
#rb Gil.Gribb
Change 2756120 on 2015/11/05 by Mieszko.Zielinski
Fixed AIController::MoveTo not using DefaultQueryExtent of its navigation data #UE4
#rb Lukasz.Furman
Change 2756243 on 2015/11/05 by Mieszko.Zielinski
Fixed AI perception sight's "auto-visibility" mechanism totally skipping distance and vision cone checks #UE4
The old way was resulting in false positives when for example observer teleported somewhere far
#rb Lukasz.Furman
#codereview John.Abercrombie
Change 2756280 on 2015/11/05 by Mieszko.Zielinski
Minor VLog code cleanup and dumb-fixing visual logger accessing timer manager off of game thread #UE4
#rb Lukasz.Furman
Change 2756500 on 2015/11/05 by Mieszko.Zielinski
Added sanity-checking to BlueprintNodeHelpers::HasBlueprintFunction and cleaned up its usage #UE4
Also, refactored its parameters into references over pointers.
#rb Lukasz.Furman
Change 2757041 on 2015/11/06 by Thomas.Sarkanen
Removed check() in UAnimInstance::GetProxyOnAnyThread()
The check was no longer needed as if we are on the game thread we block until tasks are completed below, and if we are on any other thread we are 'safe' anyway.
#rb James.Golding
Change 2757207 on 2015/11/06 by Ori.Cohen
Fix incorrect root body cache which causes a single frame "freak out" when simulating physics from an animation
#rb Lina.Halper
Change 2757238 on 2015/11/06 by Marc.Audy
Force compiler generated functions to be generated for FHierarchicalSimplification in WorldSettings.h so that they are generated while the deprecation warnings are disabled.
#rb Mike.Fricker
Change 2757284 on 2015/11/06 by Stan.Melax
tapered capsule drawing
cloth collision happens with spheres and for the hull or tapered capsule goemetry between any specified pair of spheres.
(this was already code reviewed before, but missed the check-in window before streamtime)
#rb ori.cohen
Change 2757743 on 2015/11/06 by Lukasz.Furman
fixed node memory allocations for injected behavior tree decorators
#ue4 UE-22783
#rb Mieszko.Zielinski
Change 2757772 on 2015/11/06 by Lukasz.Furman
added setters for crowd avoidance
#ue4 UE-22785
#rb Mieszko.Zielinski
Change 2758422 on 2015/11/07 by Lina.Halper
Potential fix for invalid root bone index input
#jira :/UE-23086
#code review: Ori.Cohen
Change 2758429 on 2015/11/07 by Mieszko.Zielinski
Reimplemented a fix for AI Sight's "auto seeing" mechanics in a more flexible way #UE4
#jira UE-23089
Change 2758571 on 2015/11/08 by Mieszko.Zielinski
Modified ensure condition in UAIPerceptionComponent::OnRegister so it doesn't go off when BP does it's magic when components are being added to a BP actor class #UE4
#jira UE-23080
Change 2758821 on 2015/11/09 by Thomas.Sarkanen
Fixed animations no longer playing when using a dedicated server.
Uses correct logic to determine whether we are running as a server or not.
#rb Martin.Wilson
Change 2758920 on 2015/11/09 by Marc.Audy
Don't dereference weak object pointers repeatedly in FBoneContainer::Initialize
#rb Lina.Halper
Change 2758944 on 2015/11/09 by Ori.Cohen
Fix crash when stats are only on one thread and budget mode is used
Change 2758967 on 2015/11/09 by Benn.Gallagher
Fix for crash undoing notify socket changes in Persona, needed to recache the notify track data after the transaction had reserialized the sequence.
#jira UE-22963
Change 2758973 on 2015/11/09 by Benn.Gallagher
Added new 'Random Player' node for anim graphs allowing the user to play a selection of animations in a random order with certain randomised paramers. Also allows 'Shuffle Mode' to act more like a playlist in that it will play everything on the list before repeating.
#rb Bruce.Nesbit
Change 2759219 on 2015/11/09 by Ori.Cohen
Character perf test is now looking at stats directly and sending to analytics
#RB Ben.Salem
Change 2759398 on 2015/11/09 by Lina.Halper
Fix issue where placed montages are not playing.
- the issue is that IsPlaying does not consider montage, but SetPlaying does. It is asymmetry, so I made it same. However, there are other functions that need to be re-looked at wr.t. montage
#code review: Thomas.Sarkanen
#RB: Marc.Audy
Change 2759491 on 2015/11/09 by Lina.Halper
#Anim: Fix not getting input correctly for Copy Pose node
#RB: Marc.Audy
Change 2759602 on 2015/11/09 by Marc.Audy
Fix imporperly named struct
Change 2759795 on 2015/11/09 by Aaron.McLeran
UE-23145 Adding a Priority value to USoundBase to use in concurrency evaluation and sorting wave instances for voice stealing.
#rb zak.middleton
Change 2760081 on 2015/11/09 by Aaron.McLeran
UE-23091 Adding more logging for NaN checks and fixing one source of NaNs for audio.
OmniDirectional Math Explanation:
For XAudio2, because we do our own distance-attenuation calculations, we use the X3dAudio2 API to simply compute a speaker-map for spatialization and force the listener to be at the origin and the emitter to be on the unit-circle. Thus, from XAudio2's perspective, all distances for every listener-emitter pair will be 1.0.
So in order to use the InnerRadius blending feature, we need to trick it into doing a an inner radius blend relative to a distance of 1.0. For example, if OmniRadius and Distance are the same, then the "NormalizedOmniRadius" is 1.0 and XAudio2 will begin its "blend" of the sound to an omni-directional speaker map.
If Emitter-listener distance is less than the OmniRadius, we'll want to do more blending to an omni-directional speaker map, but we need to set the InnerRadius to something greater than 1.0 (i.e. so that the normalized distance of 1.0 will be treated as less than the InnerRadius). To do "full" omni-directional blending, the emitter-listener distance will be 0 or close to zero, and the NormalizedOmniRadius will be very large (i.e. close to infiinity).
The previous math just set the NormalizedOmniRadius to FLT_MAX which is fine but that number is eventually squared before making the API call. FLT_MAX squared is INF.
Note: I do not think we need to square the OmniRadius in:
Emitter.InnerRadius = OmniRadius*OmniRadius;
But I am keeping it t here because of legacy content which depends on that behavior.
#rb zak.middleton
hange 2760401 on 2015/11/10 by Thomas.Sarkanen@Thomas.Sarkanen-Dev-Framework
Re-instated deleted protected functions in UAnimInstance.
Fixed access of UAnimInstance in FAnimNode_StateMachine.
#rb Martin.Wilson
Change 2760407 on 2015/11/10 by Jurre.deBaare
Construct raw meshes for spline meshes now uses the render data instead of original model data (preserves tangents/normals)
Change 2760468 on 2015/11/10 by Benn.Gallagher
Anim Dynamics optimizations, cached iteration independant data to reduce footprint of iteration on limits.
#rb Graeme.Thornton
Change 2760613 on 2015/11/10 by Jeff.Farris
Fixed async collision completion delegate potentially firing repeatedly. (UE-23149)
#cr marc.audy
#codereview lina.halper
Change 2760795 on 2015/11/10 by Marc.Audy
Don't compile in pointless AddReferencedObjects when with editoronly data not defined
Minor coding standard cleanup (NULL and auto)
Change 2760848 on 2015/11/10 by Benn.Gallagher
Fix to anim instance proxy to not rely on state machine initialization to bind native delegates as nested state machines are not guaranteed to be initialized. This was fixed in UAnimInstance originally but broken again by the proxy instance code.
#jira UE-23164
#rb Martin.Wilson
Change 2760866 on 2015/11/10 by Marc.Audy
Manage transient visualization components for camera component in the same way that sprite component for other actor components are
#rb Mike.Beach
Change 2760963 on 2015/11/10 by Marc.Audy
Since construction script can cause actors to be spawned don't use a ranged for to iterate
#jira UE-22639
#rb Jeff.Farris
#codereview Dmitriy.Dyomin
Change 2762297 on 2015/11/11 by James.Golding
UE-23086 Don't ensure in SetRootBodyIndex when Bodies array is empty (ie no physics state created)
#rb martin.wilson
#codereview ori.cohen, lina.halper
Change 2763566 on 2015/11/11 by Lina.Halper
FAnimNode_CopyPoseFromMesh::Evaluate - was accessing skeleton joint, not mesh joint.
#RB: Laurent.Delayen
Change 2763926 on 2015/11/12 by Thomas.Sarkanen
Fix anim notifies not firing from single anim instances
UE-23248 - Anim Notifies are not working for Animation Sequences
UE-23249 - Anim Notifies using Sound Cues do not work
#rb James.Golding
Change 2764039 on 2015/11/12 by Jurre.deBaare
Fix for issue with incorrect material indices after reducing a skeletal mesh with non LOD0 mesh as BaseLOD (OR-9243) #rb Lina.Halper
Change 2764307 on 2015/11/12 by Jurre.deBaare
VS2015 SSF library
Change 2764314 on 2015/11/12 by Stan.Melax
crashfix was putting bad bodies to sleep at start
Fatal error!
Unhandled Exception: EXCEPTION_ACCESS_VIOLATION reading address 0x00000000
UE4Editor-Engine.dll!USkeletalMeshComponent::InitArticulated() [...\\engine\\source\\runtime\\engine\\private\\skeletalmeshcomponentphysics.cpp:875]
On some skeletalmeshcomponent, some bodies aren't getting created correctly. Trying to force them to sleep was causing a crash - it expected instantiated physx bodies. Seems that all the rest of the code is able to tolerate bad bodies.
Added check to ensure physx body exists before trying to force it to sleep.
not sure if bad bodies are the norm or if this fix is just more "kicking the can down the road".
#codereview ori.cohen
Change 2764343 on 2015/11/12 by Jurre.deBaare
- Fixed crash when building a LOD with SubActors.Num < 2
- Force HLOD level slider is now always enabled, however won't show complete image if not all HLODs are build
- LODActor tree view item now scrolls into view if selected in the world
- Set bAllowCullDistanceVolume to false for LODActor's static mesh components by default
- Added 7zip files
- Fixed issue with WinINet complaining about http-request without 'http://' prefix
- Changed % reduced or original triangles display string, now uses float instead of int (for < 1% reductions)
- Override texture sizes and automatic texture bias
- Fixed issue with incorrect material merging, not picking up it required mesh-data during baking. Added extra conditions for rendering with mesh-data.
- Now incorporate static meshes with opague materials into HLOD merging
- Fixed issue with incorrect normals after merging meshes who's owning components had been negatively scaled
- Fixed issue with incorrect texture size being set from MergeActor window (was only changing .X component)
- Fixed issue with material merging when meshes with multiple LODs are merged, right now only merges LOD0's together if we are also merging the materials (otherwise, merge each LOD)
- Added ENUM for texture scaling/resizing type that has to be applied while merging the materials
- Added detail customization class for FMaterialProxySettings
#rb James.Golding
[CL 2765024 by Marc Audy in Main branch]
2015-11-12 18:11:48 -05:00
DEFINE_STAT ( STAT_AnimDynamicsOverall ) ;
2015-10-28 08:58:16 -04:00
DEFINE_STAT ( STAT_AnimDynamicsWindData ) ;
DEFINE_STAT ( STAT_AnimDynamicsBoneEval ) ;
DEFINE_STAT ( STAT_AnimDynamicsSubSteps ) ;
TAutoConsoleVariable < int32 > CVarRestrictLod ( TEXT ( " p.AnimDynamicsRestrictLOD " ) , - 1 , TEXT ( " Forces anim dynamics to be enabled for only a specified LOD, -1 to enable on all LODs. " ) ) ;
2015-10-06 16:47:09 -04:00
TAutoConsoleVariable < int32 > CVarEnableDynamics ( TEXT ( " p.AnimDynamics " ) , 1 , TEXT ( " Enables/Disables anim dynamics node updates. " ) ) ;
TAutoConsoleVariable < int32 > CVarEnableAdaptiveSubstep ( TEXT ( " p.AnimDynamicsAdaptiveSubstep " ) , 0 , TEXT ( " Enables/disables adaptive substepping. Adaptive substepping will substep the simulation when it is necessary and maintain a debt buffer for time, always trying to utilise as much time as possible. " ) ) ;
TAutoConsoleVariable < int32 > CVarAdaptiveSubstepNumDebtFrames ( TEXT ( " p.AnimDynamicsNumDebtFrames " ) , 5 , TEXT ( " Number of frames to maintain as time debt when using adaptive substepping, this should be at least 1 or the time debt will never be cleared. " ) ) ;
2015-10-28 08:58:16 -04:00
TAutoConsoleVariable < int32 > CVarEnableWind ( TEXT ( " p.AnimDynamicsWind " ) , 1 , TEXT ( " Enables/Disables anim dynamics wind forces globally. " ) ) ;
2015-10-06 16:47:09 -04:00
const float FAnimNode_AnimDynamics : : MaxTimeDebt = ( 1.0f / 60.0f ) * 5.0f ; // 5 frames max debt
FAnimNode_AnimDynamics : : FAnimNode_AnimDynamics ( )
: BoxExtents ( 0.0f )
, LocalJointOffset ( 0.0f )
, GravityScale ( 1.0f )
, bLinearSpring ( false )
, bAngularSpring ( false )
, LinearSpringConstant ( 0.0f )
, AngularSpringConstant ( 0.0f )
2015-10-28 08:58:16 -04:00
, bEnableWind ( true )
, WindScale ( 1.0f )
2015-10-06 16:47:09 -04:00
, bOverrideLinearDamping ( false )
, LinearDampingOverride ( 0.0f )
, bOverrideAngularDamping ( false )
, AngularDampingOverride ( 0.0f )
, bDoUpdate ( true )
, bDoEval ( true )
, NumSolverIterationsPreUpdate ( 4 )
, NumSolverIterationsPostUpdate ( 1 )
2015-10-28 08:58:16 -04:00
, bUsePlanarLimit ( true )
2015-10-06 16:47:09 -04:00
{
}
void FAnimNode_AnimDynamics : : Initialize ( const FAnimationInitializeContext & Context )
{
FAnimNode_SkeletalControlBase : : Initialize ( Context ) ;
Copying //UE4/Dev-Framework to Dev-Main (//UE4/Dev-Main)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2720406 on 2015/10/07 by Aaron.McLeran
Audio optimization
Don't search for nearest listener if there's only 1 listener.
Change 2720411 on 2015/10/07 by Aaron.McLeran
Fixing HRTF spatialization code with recent changes to stereo spatialization.
HRTF emitter posiition doesn't need to be converted to XAudio2 coordinates.
Change 2723829 on 2015/10/09 by Mieszko.Zielinski
Fixed NavigationSystem trying to set label of newly spawned navigation data #UE4
UE-21880
Change 2723873 on 2015/10/09 by Mieszko.Zielinski
Fixed a bug in FNavAgentProperties::IsEquivalent resulting in failing the test for FNavAgentProperties instances having default AgentStepHeight value (-1) #UE4
UE-21977
Change 2724834 on 2015/10/12 by Ori.Cohen
PR #1634: Add PxVehicleDriveNW support to PhysXVehicleManager.cpp (Contributed by zeduk)
Change 2724850 on 2015/10/12 by Marc.Audy
Fix sound not restarting in matinee preview when jumping back along timeline after reaching end
#codereview Nick.Darnell
Change 2726499 on 2015/10/13 by Ori.Cohen
Fix edge case where sphyl length and radius are 0 and they are not properly clamped to 0.1
Change 2726689 on 2015/10/13 by Marc.Audy
Make UPackage::PackageFlags private
Add debugging for UE-21181 to try and track down when EditorWorld's PackageFlags are getting flagged as PlayInEditor
#codereview Mike.Fricker
Change 2726862 on 2015/10/13 by Lukasz.Furman
removed unused code from DetourNavMeshQuery
#ue4 UE-21988
Change 2726888 on 2015/10/13 by Lukasz.Furman
fixed observer abort: both mode in behavior tree's cone check decorator
#ue4 UE-19375
Change 2726913 on 2015/10/13 by Lukasz.Furman
navmesh raycast will use nearest poly containing ray origin instead of just closest one
#ue4 UE-19334
Change 2726920 on 2015/10/13 by Marc.Audy
Re-unify ULevelStreaming::GetWorldAssetPackageName and GetWorldAssetPackageFName
#codereview Dmitriy.Dyomin, Bob.Tellez
Change 2726931 on 2015/10/13 by Lukasz.Furman
fixed missing Tick event in aborting behavior tree tasks from abandoned subtree
#ue4 UE-21777
Change 2728093 on 2015/10/14 by Ori.Cohen
Fix edge case of sphyl scale take two. The previous approach did double scaling
Change 2728577 on 2015/10/14 by Mieszko.Zielinski
Improved navmesh labeling condition #UE4
Change suggested by github user
#rb Lukasz.Furman
Change 2728587 on 2015/10/14 by Lukasz.Furman
fixed crowd simulation for auto possessed pawns placed on level
#ue4
#rb Mieszko.Zielinski
Change 2728629 on 2015/10/14 by Lukasz.Furman
fixed influence of navmesh edges on crowd simulation near end of path
#ue4 UE-21380
#rb Mieszko.Zielinski
Change 2728678 on 2015/10/14 by Lukasz.Furman
added Z check to detour's crowd avoidance segment gathering
#ue4 UE-20889
#rb Mieszko.Zielinski
Change 2728745 on 2015/10/14 by Lukasz.Furman
fixed copy&paste operation in behavior tree's composite decorators subgraphs
#ue4 UE-18740
Change 2729276 on 2015/10/14 by Stan.Melax
ensure all actors get recreated with new collision shape specification.
this wasn't being done for a couple of editing methods.
todo: this should be merged into 4.10
#UE-20961
#rb ori.cohen
Change 2730709 on 2015/10/15 by Marc.Audy
Prevent memory corruption when an invalid controller ID is passed in to the forcefeedback channel functions
#rb Lina.Halper
Change 2733590 on 2015/10/19 by Benn.Gallagher
Fixed various crashes when using undo and redo while manipulating state machines UE 22088
Change 2735143 on 2015/10/20 by Lukasz.Furman
clearing behavior tree debugger's state when displayed subtree becomes inactive
#ue4
#rb Mieszko.Zielinski
Change 2735144 on 2015/10/20 by Lukasz.Furman
rebuilding behavior tree graph node order when node is being moved
#ue4
#rb Mieszko.Zielinski
Change 2735403 on 2015/10/20 by sebastian.kowalczyk
Integrated fix for issue UE-18594 "Gameplay Debugger is hijacking the Canvas" issue from 4.10 (2735391). Extended previous fix to care about OSX users - it's possible to configure shortcuts in engine config file now (little different ones for osx platform).
Change 2736406 on 2015/10/21 by sebastian.kowalczyk
Added new GameplayDebugger as a plugin. Old gameplay debugger is still here to keep backward compatibility but it's deprecated now. Current projects should be moved to use new plugin soon.
Change 2736436 on 2015/10/21 by sebastian.kowalczyk
Fixed crash in gameplay debugger with player set as debug target.
Change 2736437 on 2015/10/21 by sebastian.kowalczyk
Added visual indicator around selected pawn to fix FORT-10273 issue. (FN is not using new gd plugin yet).
Change 2736489 on 2015/10/21 by sebastian.kowalczyk
Hide internal and debug hud classes from drop down lists.
Change 2736504 on 2015/10/21 by sebastian.kowalczyk
Fix for UE-18548 "EnableGDT does not work correctly in PIE".
Change 2736529 on 2015/10/21 by sebastian.kowalczyk
Fixed UE-18548 "EnableGDT does not work correctly in PIE"
Change 2736588 on 2015/10/21 by sebastian.kowalczyk
Removed old log visualizer classes.
Change 2736700 on 2015/10/21 by sebastian.kowalczyk
Fixed UE-19256 "Perception debug data doesn't get replicated by Gameplay Debuger" for old gameplay debugger module.
Change 2737180 on 2015/10/21 by Zak.Middleton
#ue4 - Fix UPrimitiveComponent::GetCollisionShape not correctly enforcing bounds limits.
#rb Aaron.Mcleran
#jira UE-22436
Change 2738084 on 2015/10/22 by sebastian.kowalczyk
Better indication of selected pawn for Gameplay Debugger.
Change 2738413 on 2015/10/22 by Marc.Audy
Disable duplication of worlds/maps via the content browser
#jira UE-22200
#rb James.Golding
Change 2739743 on 2015/10/23 by bruce.nesbit
UE-18707 - Issue with drawing material triangle on canvas #1387
Added DrawTriangleUsingVertexColor
Change 2739751 on 2015/10/23 by bruce.nesbit
Revised bShowDebugForReticleTarget should not be static #1539
Change 2739788 on 2015/10/23 by bruce.nesbit
Revised the 2 functions that used FTriangleRenderer::DrawTriangle to use FTriangleRenderer::DrawTriangleUsingVertexColor
Fixed compile error
Change 2739870 on 2015/10/23 by Marc.Audy
Avoid issues while detaching child components if OnAttachmentChange were to remove a sibling component itself.
#jira UE-22362
#rb Zak.Middleton
Change 2739882 on 2015/10/23 by sebastian.kowalczyk
Fix for UE-20901 "VisualLog redirections are broken after PIE finishes" issue.
Change 2740140 on 2015/10/23 by Marc.Audy
Ensure that components reregister tick functions after seamless travel
#jira UE-20892
#rb Zak.Middleton
Change 2740614 on 2015/10/23 by Ori.Cohen
Fix linker issues for people wanting to use physics lock lambdas
Change 2740674 on 2015/10/23 by Aaron.McLeran
Sound Focus Feature
Added new parameters to SoundAttenuation settings to allow audio to change behavior based on its angle to the listener
- Define the min/max azimuth angle to establish in-focus and non-focus regions
- Can scale the priority of a sound based on focus angle
- Can attenuate the volume of a sound based on focus angle
- Can scale the listener-emitter distance based on focus angle
- Distance scale is applied when determining max audible distance for USoundBase
- Can opt-out of focus effects for a sound at the USoundBase level
#rb Ryan.Vance
Change 2741542 on 2015/10/26 by Lukasz.Furman
lowered min value clamping in navigation filter properties
#ue4
#rb Mieszko.Zielinski
Change 2743227 on 2015/10/27 by Marc.Audy
Make ASceneCaptureCube subclassable outside of Engine module
#jira UE-22609
Make USceneCaptureComponentCube::UpdateContent callable outside of Engine module
#jira UE-22610
#rb Jeff.Farris
Change 2743255 on 2015/10/27 by Marc.Audy
Wrap FActorSpawnParameters class with deprecation warning disable pragma instead of hand implementing copy constructor
#rb Jeff.Farris
Change 2743729 on 2015/10/27 by Ori.Cohen
Fix case where we spawn and adjust location which gives us implicit velocity.
#codereview Stan.Melax
Change 2746135 on 2015/10/29 by sebastian.kowalczyk
Fixed UE-21668 "Saving log filters selected in LogVisualizer causes insane ini file sizes! And doesn't really work."
Change 2746437 on 2015/10/29 by Lukasz.Furman
pass on verifying behavior tree stack before accessing its elements
#ue4
#rb Mieszko.Zielinski
Change 2748028 on 2015/10/30 by sebastian.kowalczyk
Changed GameplayDebugger's console variable from gd.EQSOnHUD to ai.gd.EQSOnHUD" after suggestion with MieszkoZ.
Change 2748184 on 2015/10/30 by Aaron.McLeran
UE-22693 Fix for streaming bug
- 3rd decoded buffer in initial 3 buffers was not getting submitted to xaudio2 voice resulting in garbled/skipped audio.
- Wasn't able to repro the 'cannot read chunk' part of the bug
#rb ryan.vance
Change 2749255 on 2015/10/31 by sebastian.kowalczyk
Fixed ai.gd.EQSOnHUD console variable after rename from gd.EQSOnHUD.
Change 2749276 on 2015/10/31 by sebastian.kowalczyk
Added switch to toggle highlight of selected actor to GameplayDebugger.
Change 2749318 on 2015/10/31 by sebastian.kowalczyk
New Gameplay Debugger plugin can be used with old module simultaneously. It's best to configure different keyboard binding for plugin when using old module (it can be set in project settings, for new gameplay debugger plugin - when activated for project).
Change 2749337 on 2015/10/31 by sebastian.kowalczyk
Fixed GameplayDebugger compilation in shipping/test builds.
Change 2749376 on 2015/10/31 by sebastian.kowalczyk
Small clean-up in gameplay debugger class for BT.
Change 2749931 on 2015/11/02 by James.Golding
Add stats to ProcMeshComp
Change 2749932 on 2015/11/02 by James.Golding
Remove PhysicsThrusterComponent.h from Engine.h
Change 2749960 on 2015/11/02 by James.Golding
- Fix PS4 compile errors in ActiveSound.cpp
- Constructor order of FActiveSound
- Shadowed AudioComponent var in CheckOcclusion
#RB thomas.sarkanen
#codereview aaron.mcleran
Change 2749961 on 2015/11/02 by James.Golding
Fix PS4 compile errors in GameplayDebuggerBaseObject.cpp
- Shadowed DefaultContext function param, now just Context, which matches declaration
#RB thomas.sarkanen
#codereview sebastian.kowalczyk
Change 2750026 on 2015/11/02 by Thomas.Sarkanen
Anim Multithreading: thread-safety refactor
Segregated access to various parts of anim update data by spitting off a new proxy class (FAnimInstanceProxy) containing all data accessed in Update() and Evaluate() passes. Gated access to the proxy data on the game thread in a number of ways:
- Explicit access via GetValueOnGameThread() - this blocks on any existing task, completes and then allows control to return to the accessing function. This allows stuff like Blueprints to continue to operate as normal.
- Explicit access via GetValueOnAnyThread() - this ensures that in the limited set of circumstances we need this (Blueprint pure functions mostly) that conditions are met about concurrent access.
- Deprecating many APIs on UAnimInstance that should not be used (and in fact are not used at present, happily).
Derived classes of UAnimInstance can override the creation of the proxy class to create their own type. We do this for UAnimSingleNodeInstance etc.
Any API deprecation should continue to function - no functions have been removed yet. The only things that are not backwards-compatible are direct access to some public member variables for which there is no way to support (e.g. via references, for example UngroupedActivePlayerArrays).
Some APIs have been changed to more specifically represent the dependencies involved. For example TickAssetPlayerInstance() used to take a UAnimInstance*, only to use it to simply queue notifies. This has been deprecated and replaced with a new FNotifyQueue API. FNotifyQueue also uses a thread-safe FRandomStream instead of FMath::Rand.
Many changes are due to substituting accessor functions for direct variable access.
Removed 'service' tick group as we no longer need to segregate the running of our parallel update.
Anim nodes that need to do some game thread-side update should register for a pre-update callback delegate in the proxy. See FAnimNode_AnimDynamics for an example of this.
Moved UpdateActiveVertexAnims into FAnimRuntime so I can subsume some of the code that was in USkeletalMeshComponent::EvaluateAnimation into UAnimInstance (and hence keep the proxy access private).
#rb Martin.Wilson,Lina.Halper
#codereview Michael.Noland
Change 2750077 on 2015/11/02 by Marc.Audy
Expose UInputComponent::BindAction that supports WithKey delegate signature
Change 2751767 on 2015/11/03 by Thomas.Sarkanen
Added extra support to Anim Blueprint 'fast-path'
Added support for negated bools (value gets negated during copy).
Added support for copying from struct members (via break struct) and split struct pins.
Removed potentially troublesome references to BP-constructed UProperties, replacing them with the property FName. This adds some extra Initialize() overhead, but prevents various crash-on load issues (one when generating the class CRC). Added guard to prevent multiple initialization to save this more expensive work being done more often.
#rb Martin.Wilson
Change 2752158 on 2015/11/03 by Jeff.Farris
Fixed UGameplayStatics::SpawnEmitterAttached() to register the ParticleSystemComponent after it spawns.
#rb marc.audy
Change 2752159 on 2015/11/03 by Jeff.Farris
Improvements to camera lens effects to (EmitterCameraLensEffectBase)
- can now specify a transform to align the emitter with the camera
- exposed several key parameters to Blueprints
- ENGINE_API now applies to the entire class
#rb marc.audy
Change 2753454 on 2015/11/04 by Thomas.Sarkanen
Fixup deprecation warnings fallout from multithreaded update changes.
Fixed up use of AnimInstance in Vicon plugin.
Fixed up use of AnimInstance in slope warping node.
Un-deprecated some APIs to become warning free (these APIs are safe to call but just a 'bad idea if you want to do it right').
Also an extra API to allow for smoother transition: Allow custom allocation/deallocation (including using a proxy member struct) by providing an override point for proxy destruction.
#rb Martin.Wilson
Change 2754099 on 2015/11/04 by Ori.Cohen
Fix for task threads dropping stats (from Gil)
#rb Gil.Gribb
Change 2754449 on 2015/11/04 by Marc.Audy
Ensure that components created from an Actor's blueprint BeginPlay implementation get BeginPlay called on them and register their component ticks
#jira UE-20853
Reorganize some booleans to get better bit packing
#rb Jeff.Farris
#codereview Mieszko.Zielinski
Change 2754573 on 2015/11/04 by Aaron.McLeran
Fixing audio component PostLoad code to not set all LowPassFilterFrequency values to 0.0f
Change 2755345 on 2015/11/05 by Thomas.Sarkanen
Added deprecated constructors for various animation contexts
Allows existing code to compile if it creates its own contexts from UAnimInstance.
#rb James.Golding
Change 2755348 on 2015/11/05 by James.Golding
Add BP-exposed SetBoundsScale function to PrimitiveComponent
#RB thomas.sarkanen
Change 2755437 on 2015/11/05 by Marc.Audy
Fix compile errors
#codereview Thomas.Sarkanen, Mieszko.Zielinski, Aaron.McLeran
Change 2755982 on 2015/11/05 by Marc.Audy
Move HeaderParse changes for deprecation macro from Core
Fix world settings warning
Change 2756028 on 2015/11/05 by Marc.Audy
Fix shadow variable issue
Change 2756090 on 2015/11/05 by Ori.Cohen
Improve budget tool so that task threads are computed automatically.
#rb Gil.Gribb
Change 2756120 on 2015/11/05 by Mieszko.Zielinski
Fixed AIController::MoveTo not using DefaultQueryExtent of its navigation data #UE4
#rb Lukasz.Furman
Change 2756243 on 2015/11/05 by Mieszko.Zielinski
Fixed AI perception sight's "auto-visibility" mechanism totally skipping distance and vision cone checks #UE4
The old way was resulting in false positives when for example observer teleported somewhere far
#rb Lukasz.Furman
#codereview John.Abercrombie
Change 2756280 on 2015/11/05 by Mieszko.Zielinski
Minor VLog code cleanup and dumb-fixing visual logger accessing timer manager off of game thread #UE4
#rb Lukasz.Furman
Change 2756500 on 2015/11/05 by Mieszko.Zielinski
Added sanity-checking to BlueprintNodeHelpers::HasBlueprintFunction and cleaned up its usage #UE4
Also, refactored its parameters into references over pointers.
#rb Lukasz.Furman
Change 2757041 on 2015/11/06 by Thomas.Sarkanen
Removed check() in UAnimInstance::GetProxyOnAnyThread()
The check was no longer needed as if we are on the game thread we block until tasks are completed below, and if we are on any other thread we are 'safe' anyway.
#rb James.Golding
Change 2757207 on 2015/11/06 by Ori.Cohen
Fix incorrect root body cache which causes a single frame "freak out" when simulating physics from an animation
#rb Lina.Halper
Change 2757238 on 2015/11/06 by Marc.Audy
Force compiler generated functions to be generated for FHierarchicalSimplification in WorldSettings.h so that they are generated while the deprecation warnings are disabled.
#rb Mike.Fricker
Change 2757284 on 2015/11/06 by Stan.Melax
tapered capsule drawing
cloth collision happens with spheres and for the hull or tapered capsule goemetry between any specified pair of spheres.
(this was already code reviewed before, but missed the check-in window before streamtime)
#rb ori.cohen
Change 2757743 on 2015/11/06 by Lukasz.Furman
fixed node memory allocations for injected behavior tree decorators
#ue4 UE-22783
#rb Mieszko.Zielinski
Change 2757772 on 2015/11/06 by Lukasz.Furman
added setters for crowd avoidance
#ue4 UE-22785
#rb Mieszko.Zielinski
Change 2758422 on 2015/11/07 by Lina.Halper
Potential fix for invalid root bone index input
#jira :/UE-23086
#code review: Ori.Cohen
Change 2758429 on 2015/11/07 by Mieszko.Zielinski
Reimplemented a fix for AI Sight's "auto seeing" mechanics in a more flexible way #UE4
#jira UE-23089
Change 2758571 on 2015/11/08 by Mieszko.Zielinski
Modified ensure condition in UAIPerceptionComponent::OnRegister so it doesn't go off when BP does it's magic when components are being added to a BP actor class #UE4
#jira UE-23080
Change 2758821 on 2015/11/09 by Thomas.Sarkanen
Fixed animations no longer playing when using a dedicated server.
Uses correct logic to determine whether we are running as a server or not.
#rb Martin.Wilson
Change 2758920 on 2015/11/09 by Marc.Audy
Don't dereference weak object pointers repeatedly in FBoneContainer::Initialize
#rb Lina.Halper
Change 2758944 on 2015/11/09 by Ori.Cohen
Fix crash when stats are only on one thread and budget mode is used
Change 2758967 on 2015/11/09 by Benn.Gallagher
Fix for crash undoing notify socket changes in Persona, needed to recache the notify track data after the transaction had reserialized the sequence.
#jira UE-22963
Change 2758973 on 2015/11/09 by Benn.Gallagher
Added new 'Random Player' node for anim graphs allowing the user to play a selection of animations in a random order with certain randomised paramers. Also allows 'Shuffle Mode' to act more like a playlist in that it will play everything on the list before repeating.
#rb Bruce.Nesbit
Change 2759219 on 2015/11/09 by Ori.Cohen
Character perf test is now looking at stats directly and sending to analytics
#RB Ben.Salem
Change 2759398 on 2015/11/09 by Lina.Halper
Fix issue where placed montages are not playing.
- the issue is that IsPlaying does not consider montage, but SetPlaying does. It is asymmetry, so I made it same. However, there are other functions that need to be re-looked at wr.t. montage
#code review: Thomas.Sarkanen
#RB: Marc.Audy
Change 2759491 on 2015/11/09 by Lina.Halper
#Anim: Fix not getting input correctly for Copy Pose node
#RB: Marc.Audy
Change 2759602 on 2015/11/09 by Marc.Audy
Fix imporperly named struct
Change 2759795 on 2015/11/09 by Aaron.McLeran
UE-23145 Adding a Priority value to USoundBase to use in concurrency evaluation and sorting wave instances for voice stealing.
#rb zak.middleton
Change 2760081 on 2015/11/09 by Aaron.McLeran
UE-23091 Adding more logging for NaN checks and fixing one source of NaNs for audio.
OmniDirectional Math Explanation:
For XAudio2, because we do our own distance-attenuation calculations, we use the X3dAudio2 API to simply compute a speaker-map for spatialization and force the listener to be at the origin and the emitter to be on the unit-circle. Thus, from XAudio2's perspective, all distances for every listener-emitter pair will be 1.0.
So in order to use the InnerRadius blending feature, we need to trick it into doing a an inner radius blend relative to a distance of 1.0. For example, if OmniRadius and Distance are the same, then the "NormalizedOmniRadius" is 1.0 and XAudio2 will begin its "blend" of the sound to an omni-directional speaker map.
If Emitter-listener distance is less than the OmniRadius, we'll want to do more blending to an omni-directional speaker map, but we need to set the InnerRadius to something greater than 1.0 (i.e. so that the normalized distance of 1.0 will be treated as less than the InnerRadius). To do "full" omni-directional blending, the emitter-listener distance will be 0 or close to zero, and the NormalizedOmniRadius will be very large (i.e. close to infiinity).
The previous math just set the NormalizedOmniRadius to FLT_MAX which is fine but that number is eventually squared before making the API call. FLT_MAX squared is INF.
Note: I do not think we need to square the OmniRadius in:
Emitter.InnerRadius = OmniRadius*OmniRadius;
But I am keeping it t here because of legacy content which depends on that behavior.
#rb zak.middleton
hange 2760401 on 2015/11/10 by Thomas.Sarkanen@Thomas.Sarkanen-Dev-Framework
Re-instated deleted protected functions in UAnimInstance.
Fixed access of UAnimInstance in FAnimNode_StateMachine.
#rb Martin.Wilson
Change 2760407 on 2015/11/10 by Jurre.deBaare
Construct raw meshes for spline meshes now uses the render data instead of original model data (preserves tangents/normals)
Change 2760468 on 2015/11/10 by Benn.Gallagher
Anim Dynamics optimizations, cached iteration independant data to reduce footprint of iteration on limits.
#rb Graeme.Thornton
Change 2760613 on 2015/11/10 by Jeff.Farris
Fixed async collision completion delegate potentially firing repeatedly. (UE-23149)
#cr marc.audy
#codereview lina.halper
Change 2760795 on 2015/11/10 by Marc.Audy
Don't compile in pointless AddReferencedObjects when with editoronly data not defined
Minor coding standard cleanup (NULL and auto)
Change 2760848 on 2015/11/10 by Benn.Gallagher
Fix to anim instance proxy to not rely on state machine initialization to bind native delegates as nested state machines are not guaranteed to be initialized. This was fixed in UAnimInstance originally but broken again by the proxy instance code.
#jira UE-23164
#rb Martin.Wilson
Change 2760866 on 2015/11/10 by Marc.Audy
Manage transient visualization components for camera component in the same way that sprite component for other actor components are
#rb Mike.Beach
Change 2760963 on 2015/11/10 by Marc.Audy
Since construction script can cause actors to be spawned don't use a ranged for to iterate
#jira UE-22639
#rb Jeff.Farris
#codereview Dmitriy.Dyomin
Change 2762297 on 2015/11/11 by James.Golding
UE-23086 Don't ensure in SetRootBodyIndex when Bodies array is empty (ie no physics state created)
#rb martin.wilson
#codereview ori.cohen, lina.halper
Change 2763566 on 2015/11/11 by Lina.Halper
FAnimNode_CopyPoseFromMesh::Evaluate - was accessing skeleton joint, not mesh joint.
#RB: Laurent.Delayen
Change 2763926 on 2015/11/12 by Thomas.Sarkanen
Fix anim notifies not firing from single anim instances
UE-23248 - Anim Notifies are not working for Animation Sequences
UE-23249 - Anim Notifies using Sound Cues do not work
#rb James.Golding
Change 2764039 on 2015/11/12 by Jurre.deBaare
Fix for issue with incorrect material indices after reducing a skeletal mesh with non LOD0 mesh as BaseLOD (OR-9243) #rb Lina.Halper
Change 2764307 on 2015/11/12 by Jurre.deBaare
VS2015 SSF library
Change 2764314 on 2015/11/12 by Stan.Melax
crashfix was putting bad bodies to sleep at start
Fatal error!
Unhandled Exception: EXCEPTION_ACCESS_VIOLATION reading address 0x00000000
UE4Editor-Engine.dll!USkeletalMeshComponent::InitArticulated() [...\\engine\\source\\runtime\\engine\\private\\skeletalmeshcomponentphysics.cpp:875]
On some skeletalmeshcomponent, some bodies aren't getting created correctly. Trying to force them to sleep was causing a crash - it expected instantiated physx bodies. Seems that all the rest of the code is able to tolerate bad bodies.
Added check to ensure physx body exists before trying to force it to sleep.
not sure if bad bodies are the norm or if this fix is just more "kicking the can down the road".
#codereview ori.cohen
Change 2764343 on 2015/11/12 by Jurre.deBaare
- Fixed crash when building a LOD with SubActors.Num < 2
- Force HLOD level slider is now always enabled, however won't show complete image if not all HLODs are build
- LODActor tree view item now scrolls into view if selected in the world
- Set bAllowCullDistanceVolume to false for LODActor's static mesh components by default
- Added 7zip files
- Fixed issue with WinINet complaining about http-request without 'http://' prefix
- Changed % reduced or original triangles display string, now uses float instead of int (for < 1% reductions)
- Override texture sizes and automatic texture bias
- Fixed issue with incorrect material merging, not picking up it required mesh-data during baking. Added extra conditions for rendering with mesh-data.
- Now incorporate static meshes with opague materials into HLOD merging
- Fixed issue with incorrect normals after merging meshes who's owning components had been negatively scaled
- Fixed issue with incorrect texture size being set from MergeActor window (was only changing .X component)
- Fixed issue with material merging when meshes with multiple LODs are merged, right now only merges LOD0's together if we are also merging the materials (otherwise, merge each LOD)
- Added ENUM for texture scaling/resizing type that has to be applied while merging the materials
- Added detail customization class for FMaterialProxySettings
#rb James.Golding
[CL 2765024 by Marc Audy in Main branch]
2015-11-12 18:11:48 -05:00
FBoneContainer & RequiredBones = Context . AnimInstanceProxy - > GetRequiredBones ( ) ;
2015-10-06 16:47:09 -04:00
BoundBone . Initialize ( RequiredBones ) ;
if ( bChain )
{
ChainEnd . Initialize ( RequiredBones ) ;
}
2015-10-28 08:58:16 -04:00
for ( FAnimPhysPlanarLimit & PlanarLimit : PlanarLimits )
{
PlanarLimit . DrivingBone . Initialize ( RequiredBones ) ;
}
2015-10-06 16:47:09 -04:00
if ( BoundBone . IsValid ( RequiredBones ) )
{
RequestInitialise ( ) ;
}
NextTimeStep = 0.0f ;
TimeDebt = 0.0f ;
}
2015-10-31 10:55:13 -04:00
void FAnimNode_AnimDynamics : : UpdateInternal ( const FAnimationUpdateContext & Context )
2015-10-06 16:47:09 -04:00
{
2015-10-31 10:55:13 -04:00
FAnimNode_SkeletalControlBase : : UpdateInternal ( Context ) ;
2015-10-06 16:47:09 -04:00
NextTimeStep = Context . GetDeltaTime ( ) ;
}
void FAnimNode_AnimDynamics : : EvaluateBoneTransforms ( USkeletalMeshComponent * SkelComp , FCSPose < FCompactPose > & MeshBases , TArray < FBoneTransform > & OutBoneTransforms )
{
Copying //UE4/Dev-Framework to Dev-Main (//UE4/Dev-Main)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2720406 on 2015/10/07 by Aaron.McLeran
Audio optimization
Don't search for nearest listener if there's only 1 listener.
Change 2720411 on 2015/10/07 by Aaron.McLeran
Fixing HRTF spatialization code with recent changes to stereo spatialization.
HRTF emitter posiition doesn't need to be converted to XAudio2 coordinates.
Change 2723829 on 2015/10/09 by Mieszko.Zielinski
Fixed NavigationSystem trying to set label of newly spawned navigation data #UE4
UE-21880
Change 2723873 on 2015/10/09 by Mieszko.Zielinski
Fixed a bug in FNavAgentProperties::IsEquivalent resulting in failing the test for FNavAgentProperties instances having default AgentStepHeight value (-1) #UE4
UE-21977
Change 2724834 on 2015/10/12 by Ori.Cohen
PR #1634: Add PxVehicleDriveNW support to PhysXVehicleManager.cpp (Contributed by zeduk)
Change 2724850 on 2015/10/12 by Marc.Audy
Fix sound not restarting in matinee preview when jumping back along timeline after reaching end
#codereview Nick.Darnell
Change 2726499 on 2015/10/13 by Ori.Cohen
Fix edge case where sphyl length and radius are 0 and they are not properly clamped to 0.1
Change 2726689 on 2015/10/13 by Marc.Audy
Make UPackage::PackageFlags private
Add debugging for UE-21181 to try and track down when EditorWorld's PackageFlags are getting flagged as PlayInEditor
#codereview Mike.Fricker
Change 2726862 on 2015/10/13 by Lukasz.Furman
removed unused code from DetourNavMeshQuery
#ue4 UE-21988
Change 2726888 on 2015/10/13 by Lukasz.Furman
fixed observer abort: both mode in behavior tree's cone check decorator
#ue4 UE-19375
Change 2726913 on 2015/10/13 by Lukasz.Furman
navmesh raycast will use nearest poly containing ray origin instead of just closest one
#ue4 UE-19334
Change 2726920 on 2015/10/13 by Marc.Audy
Re-unify ULevelStreaming::GetWorldAssetPackageName and GetWorldAssetPackageFName
#codereview Dmitriy.Dyomin, Bob.Tellez
Change 2726931 on 2015/10/13 by Lukasz.Furman
fixed missing Tick event in aborting behavior tree tasks from abandoned subtree
#ue4 UE-21777
Change 2728093 on 2015/10/14 by Ori.Cohen
Fix edge case of sphyl scale take two. The previous approach did double scaling
Change 2728577 on 2015/10/14 by Mieszko.Zielinski
Improved navmesh labeling condition #UE4
Change suggested by github user
#rb Lukasz.Furman
Change 2728587 on 2015/10/14 by Lukasz.Furman
fixed crowd simulation for auto possessed pawns placed on level
#ue4
#rb Mieszko.Zielinski
Change 2728629 on 2015/10/14 by Lukasz.Furman
fixed influence of navmesh edges on crowd simulation near end of path
#ue4 UE-21380
#rb Mieszko.Zielinski
Change 2728678 on 2015/10/14 by Lukasz.Furman
added Z check to detour's crowd avoidance segment gathering
#ue4 UE-20889
#rb Mieszko.Zielinski
Change 2728745 on 2015/10/14 by Lukasz.Furman
fixed copy&paste operation in behavior tree's composite decorators subgraphs
#ue4 UE-18740
Change 2729276 on 2015/10/14 by Stan.Melax
ensure all actors get recreated with new collision shape specification.
this wasn't being done for a couple of editing methods.
todo: this should be merged into 4.10
#UE-20961
#rb ori.cohen
Change 2730709 on 2015/10/15 by Marc.Audy
Prevent memory corruption when an invalid controller ID is passed in to the forcefeedback channel functions
#rb Lina.Halper
Change 2733590 on 2015/10/19 by Benn.Gallagher
Fixed various crashes when using undo and redo while manipulating state machines UE 22088
Change 2735143 on 2015/10/20 by Lukasz.Furman
clearing behavior tree debugger's state when displayed subtree becomes inactive
#ue4
#rb Mieszko.Zielinski
Change 2735144 on 2015/10/20 by Lukasz.Furman
rebuilding behavior tree graph node order when node is being moved
#ue4
#rb Mieszko.Zielinski
Change 2735403 on 2015/10/20 by sebastian.kowalczyk
Integrated fix for issue UE-18594 "Gameplay Debugger is hijacking the Canvas" issue from 4.10 (2735391). Extended previous fix to care about OSX users - it's possible to configure shortcuts in engine config file now (little different ones for osx platform).
Change 2736406 on 2015/10/21 by sebastian.kowalczyk
Added new GameplayDebugger as a plugin. Old gameplay debugger is still here to keep backward compatibility but it's deprecated now. Current projects should be moved to use new plugin soon.
Change 2736436 on 2015/10/21 by sebastian.kowalczyk
Fixed crash in gameplay debugger with player set as debug target.
Change 2736437 on 2015/10/21 by sebastian.kowalczyk
Added visual indicator around selected pawn to fix FORT-10273 issue. (FN is not using new gd plugin yet).
Change 2736489 on 2015/10/21 by sebastian.kowalczyk
Hide internal and debug hud classes from drop down lists.
Change 2736504 on 2015/10/21 by sebastian.kowalczyk
Fix for UE-18548 "EnableGDT does not work correctly in PIE".
Change 2736529 on 2015/10/21 by sebastian.kowalczyk
Fixed UE-18548 "EnableGDT does not work correctly in PIE"
Change 2736588 on 2015/10/21 by sebastian.kowalczyk
Removed old log visualizer classes.
Change 2736700 on 2015/10/21 by sebastian.kowalczyk
Fixed UE-19256 "Perception debug data doesn't get replicated by Gameplay Debuger" for old gameplay debugger module.
Change 2737180 on 2015/10/21 by Zak.Middleton
#ue4 - Fix UPrimitiveComponent::GetCollisionShape not correctly enforcing bounds limits.
#rb Aaron.Mcleran
#jira UE-22436
Change 2738084 on 2015/10/22 by sebastian.kowalczyk
Better indication of selected pawn for Gameplay Debugger.
Change 2738413 on 2015/10/22 by Marc.Audy
Disable duplication of worlds/maps via the content browser
#jira UE-22200
#rb James.Golding
Change 2739743 on 2015/10/23 by bruce.nesbit
UE-18707 - Issue with drawing material triangle on canvas #1387
Added DrawTriangleUsingVertexColor
Change 2739751 on 2015/10/23 by bruce.nesbit
Revised bShowDebugForReticleTarget should not be static #1539
Change 2739788 on 2015/10/23 by bruce.nesbit
Revised the 2 functions that used FTriangleRenderer::DrawTriangle to use FTriangleRenderer::DrawTriangleUsingVertexColor
Fixed compile error
Change 2739870 on 2015/10/23 by Marc.Audy
Avoid issues while detaching child components if OnAttachmentChange were to remove a sibling component itself.
#jira UE-22362
#rb Zak.Middleton
Change 2739882 on 2015/10/23 by sebastian.kowalczyk
Fix for UE-20901 "VisualLog redirections are broken after PIE finishes" issue.
Change 2740140 on 2015/10/23 by Marc.Audy
Ensure that components reregister tick functions after seamless travel
#jira UE-20892
#rb Zak.Middleton
Change 2740614 on 2015/10/23 by Ori.Cohen
Fix linker issues for people wanting to use physics lock lambdas
Change 2740674 on 2015/10/23 by Aaron.McLeran
Sound Focus Feature
Added new parameters to SoundAttenuation settings to allow audio to change behavior based on its angle to the listener
- Define the min/max azimuth angle to establish in-focus and non-focus regions
- Can scale the priority of a sound based on focus angle
- Can attenuate the volume of a sound based on focus angle
- Can scale the listener-emitter distance based on focus angle
- Distance scale is applied when determining max audible distance for USoundBase
- Can opt-out of focus effects for a sound at the USoundBase level
#rb Ryan.Vance
Change 2741542 on 2015/10/26 by Lukasz.Furman
lowered min value clamping in navigation filter properties
#ue4
#rb Mieszko.Zielinski
Change 2743227 on 2015/10/27 by Marc.Audy
Make ASceneCaptureCube subclassable outside of Engine module
#jira UE-22609
Make USceneCaptureComponentCube::UpdateContent callable outside of Engine module
#jira UE-22610
#rb Jeff.Farris
Change 2743255 on 2015/10/27 by Marc.Audy
Wrap FActorSpawnParameters class with deprecation warning disable pragma instead of hand implementing copy constructor
#rb Jeff.Farris
Change 2743729 on 2015/10/27 by Ori.Cohen
Fix case where we spawn and adjust location which gives us implicit velocity.
#codereview Stan.Melax
Change 2746135 on 2015/10/29 by sebastian.kowalczyk
Fixed UE-21668 "Saving log filters selected in LogVisualizer causes insane ini file sizes! And doesn't really work."
Change 2746437 on 2015/10/29 by Lukasz.Furman
pass on verifying behavior tree stack before accessing its elements
#ue4
#rb Mieszko.Zielinski
Change 2748028 on 2015/10/30 by sebastian.kowalczyk
Changed GameplayDebugger's console variable from gd.EQSOnHUD to ai.gd.EQSOnHUD" after suggestion with MieszkoZ.
Change 2748184 on 2015/10/30 by Aaron.McLeran
UE-22693 Fix for streaming bug
- 3rd decoded buffer in initial 3 buffers was not getting submitted to xaudio2 voice resulting in garbled/skipped audio.
- Wasn't able to repro the 'cannot read chunk' part of the bug
#rb ryan.vance
Change 2749255 on 2015/10/31 by sebastian.kowalczyk
Fixed ai.gd.EQSOnHUD console variable after rename from gd.EQSOnHUD.
Change 2749276 on 2015/10/31 by sebastian.kowalczyk
Added switch to toggle highlight of selected actor to GameplayDebugger.
Change 2749318 on 2015/10/31 by sebastian.kowalczyk
New Gameplay Debugger plugin can be used with old module simultaneously. It's best to configure different keyboard binding for plugin when using old module (it can be set in project settings, for new gameplay debugger plugin - when activated for project).
Change 2749337 on 2015/10/31 by sebastian.kowalczyk
Fixed GameplayDebugger compilation in shipping/test builds.
Change 2749376 on 2015/10/31 by sebastian.kowalczyk
Small clean-up in gameplay debugger class for BT.
Change 2749931 on 2015/11/02 by James.Golding
Add stats to ProcMeshComp
Change 2749932 on 2015/11/02 by James.Golding
Remove PhysicsThrusterComponent.h from Engine.h
Change 2749960 on 2015/11/02 by James.Golding
- Fix PS4 compile errors in ActiveSound.cpp
- Constructor order of FActiveSound
- Shadowed AudioComponent var in CheckOcclusion
#RB thomas.sarkanen
#codereview aaron.mcleran
Change 2749961 on 2015/11/02 by James.Golding
Fix PS4 compile errors in GameplayDebuggerBaseObject.cpp
- Shadowed DefaultContext function param, now just Context, which matches declaration
#RB thomas.sarkanen
#codereview sebastian.kowalczyk
Change 2750026 on 2015/11/02 by Thomas.Sarkanen
Anim Multithreading: thread-safety refactor
Segregated access to various parts of anim update data by spitting off a new proxy class (FAnimInstanceProxy) containing all data accessed in Update() and Evaluate() passes. Gated access to the proxy data on the game thread in a number of ways:
- Explicit access via GetValueOnGameThread() - this blocks on any existing task, completes and then allows control to return to the accessing function. This allows stuff like Blueprints to continue to operate as normal.
- Explicit access via GetValueOnAnyThread() - this ensures that in the limited set of circumstances we need this (Blueprint pure functions mostly) that conditions are met about concurrent access.
- Deprecating many APIs on UAnimInstance that should not be used (and in fact are not used at present, happily).
Derived classes of UAnimInstance can override the creation of the proxy class to create their own type. We do this for UAnimSingleNodeInstance etc.
Any API deprecation should continue to function - no functions have been removed yet. The only things that are not backwards-compatible are direct access to some public member variables for which there is no way to support (e.g. via references, for example UngroupedActivePlayerArrays).
Some APIs have been changed to more specifically represent the dependencies involved. For example TickAssetPlayerInstance() used to take a UAnimInstance*, only to use it to simply queue notifies. This has been deprecated and replaced with a new FNotifyQueue API. FNotifyQueue also uses a thread-safe FRandomStream instead of FMath::Rand.
Many changes are due to substituting accessor functions for direct variable access.
Removed 'service' tick group as we no longer need to segregate the running of our parallel update.
Anim nodes that need to do some game thread-side update should register for a pre-update callback delegate in the proxy. See FAnimNode_AnimDynamics for an example of this.
Moved UpdateActiveVertexAnims into FAnimRuntime so I can subsume some of the code that was in USkeletalMeshComponent::EvaluateAnimation into UAnimInstance (and hence keep the proxy access private).
#rb Martin.Wilson,Lina.Halper
#codereview Michael.Noland
Change 2750077 on 2015/11/02 by Marc.Audy
Expose UInputComponent::BindAction that supports WithKey delegate signature
Change 2751767 on 2015/11/03 by Thomas.Sarkanen
Added extra support to Anim Blueprint 'fast-path'
Added support for negated bools (value gets negated during copy).
Added support for copying from struct members (via break struct) and split struct pins.
Removed potentially troublesome references to BP-constructed UProperties, replacing them with the property FName. This adds some extra Initialize() overhead, but prevents various crash-on load issues (one when generating the class CRC). Added guard to prevent multiple initialization to save this more expensive work being done more often.
#rb Martin.Wilson
Change 2752158 on 2015/11/03 by Jeff.Farris
Fixed UGameplayStatics::SpawnEmitterAttached() to register the ParticleSystemComponent after it spawns.
#rb marc.audy
Change 2752159 on 2015/11/03 by Jeff.Farris
Improvements to camera lens effects to (EmitterCameraLensEffectBase)
- can now specify a transform to align the emitter with the camera
- exposed several key parameters to Blueprints
- ENGINE_API now applies to the entire class
#rb marc.audy
Change 2753454 on 2015/11/04 by Thomas.Sarkanen
Fixup deprecation warnings fallout from multithreaded update changes.
Fixed up use of AnimInstance in Vicon plugin.
Fixed up use of AnimInstance in slope warping node.
Un-deprecated some APIs to become warning free (these APIs are safe to call but just a 'bad idea if you want to do it right').
Also an extra API to allow for smoother transition: Allow custom allocation/deallocation (including using a proxy member struct) by providing an override point for proxy destruction.
#rb Martin.Wilson
Change 2754099 on 2015/11/04 by Ori.Cohen
Fix for task threads dropping stats (from Gil)
#rb Gil.Gribb
Change 2754449 on 2015/11/04 by Marc.Audy
Ensure that components created from an Actor's blueprint BeginPlay implementation get BeginPlay called on them and register their component ticks
#jira UE-20853
Reorganize some booleans to get better bit packing
#rb Jeff.Farris
#codereview Mieszko.Zielinski
Change 2754573 on 2015/11/04 by Aaron.McLeran
Fixing audio component PostLoad code to not set all LowPassFilterFrequency values to 0.0f
Change 2755345 on 2015/11/05 by Thomas.Sarkanen
Added deprecated constructors for various animation contexts
Allows existing code to compile if it creates its own contexts from UAnimInstance.
#rb James.Golding
Change 2755348 on 2015/11/05 by James.Golding
Add BP-exposed SetBoundsScale function to PrimitiveComponent
#RB thomas.sarkanen
Change 2755437 on 2015/11/05 by Marc.Audy
Fix compile errors
#codereview Thomas.Sarkanen, Mieszko.Zielinski, Aaron.McLeran
Change 2755982 on 2015/11/05 by Marc.Audy
Move HeaderParse changes for deprecation macro from Core
Fix world settings warning
Change 2756028 on 2015/11/05 by Marc.Audy
Fix shadow variable issue
Change 2756090 on 2015/11/05 by Ori.Cohen
Improve budget tool so that task threads are computed automatically.
#rb Gil.Gribb
Change 2756120 on 2015/11/05 by Mieszko.Zielinski
Fixed AIController::MoveTo not using DefaultQueryExtent of its navigation data #UE4
#rb Lukasz.Furman
Change 2756243 on 2015/11/05 by Mieszko.Zielinski
Fixed AI perception sight's "auto-visibility" mechanism totally skipping distance and vision cone checks #UE4
The old way was resulting in false positives when for example observer teleported somewhere far
#rb Lukasz.Furman
#codereview John.Abercrombie
Change 2756280 on 2015/11/05 by Mieszko.Zielinski
Minor VLog code cleanup and dumb-fixing visual logger accessing timer manager off of game thread #UE4
#rb Lukasz.Furman
Change 2756500 on 2015/11/05 by Mieszko.Zielinski
Added sanity-checking to BlueprintNodeHelpers::HasBlueprintFunction and cleaned up its usage #UE4
Also, refactored its parameters into references over pointers.
#rb Lukasz.Furman
Change 2757041 on 2015/11/06 by Thomas.Sarkanen
Removed check() in UAnimInstance::GetProxyOnAnyThread()
The check was no longer needed as if we are on the game thread we block until tasks are completed below, and if we are on any other thread we are 'safe' anyway.
#rb James.Golding
Change 2757207 on 2015/11/06 by Ori.Cohen
Fix incorrect root body cache which causes a single frame "freak out" when simulating physics from an animation
#rb Lina.Halper
Change 2757238 on 2015/11/06 by Marc.Audy
Force compiler generated functions to be generated for FHierarchicalSimplification in WorldSettings.h so that they are generated while the deprecation warnings are disabled.
#rb Mike.Fricker
Change 2757284 on 2015/11/06 by Stan.Melax
tapered capsule drawing
cloth collision happens with spheres and for the hull or tapered capsule goemetry between any specified pair of spheres.
(this was already code reviewed before, but missed the check-in window before streamtime)
#rb ori.cohen
Change 2757743 on 2015/11/06 by Lukasz.Furman
fixed node memory allocations for injected behavior tree decorators
#ue4 UE-22783
#rb Mieszko.Zielinski
Change 2757772 on 2015/11/06 by Lukasz.Furman
added setters for crowd avoidance
#ue4 UE-22785
#rb Mieszko.Zielinski
Change 2758422 on 2015/11/07 by Lina.Halper
Potential fix for invalid root bone index input
#jira :/UE-23086
#code review: Ori.Cohen
Change 2758429 on 2015/11/07 by Mieszko.Zielinski
Reimplemented a fix for AI Sight's "auto seeing" mechanics in a more flexible way #UE4
#jira UE-23089
Change 2758571 on 2015/11/08 by Mieszko.Zielinski
Modified ensure condition in UAIPerceptionComponent::OnRegister so it doesn't go off when BP does it's magic when components are being added to a BP actor class #UE4
#jira UE-23080
Change 2758821 on 2015/11/09 by Thomas.Sarkanen
Fixed animations no longer playing when using a dedicated server.
Uses correct logic to determine whether we are running as a server or not.
#rb Martin.Wilson
Change 2758920 on 2015/11/09 by Marc.Audy
Don't dereference weak object pointers repeatedly in FBoneContainer::Initialize
#rb Lina.Halper
Change 2758944 on 2015/11/09 by Ori.Cohen
Fix crash when stats are only on one thread and budget mode is used
Change 2758967 on 2015/11/09 by Benn.Gallagher
Fix for crash undoing notify socket changes in Persona, needed to recache the notify track data after the transaction had reserialized the sequence.
#jira UE-22963
Change 2758973 on 2015/11/09 by Benn.Gallagher
Added new 'Random Player' node for anim graphs allowing the user to play a selection of animations in a random order with certain randomised paramers. Also allows 'Shuffle Mode' to act more like a playlist in that it will play everything on the list before repeating.
#rb Bruce.Nesbit
Change 2759219 on 2015/11/09 by Ori.Cohen
Character perf test is now looking at stats directly and sending to analytics
#RB Ben.Salem
Change 2759398 on 2015/11/09 by Lina.Halper
Fix issue where placed montages are not playing.
- the issue is that IsPlaying does not consider montage, but SetPlaying does. It is asymmetry, so I made it same. However, there are other functions that need to be re-looked at wr.t. montage
#code review: Thomas.Sarkanen
#RB: Marc.Audy
Change 2759491 on 2015/11/09 by Lina.Halper
#Anim: Fix not getting input correctly for Copy Pose node
#RB: Marc.Audy
Change 2759602 on 2015/11/09 by Marc.Audy
Fix imporperly named struct
Change 2759795 on 2015/11/09 by Aaron.McLeran
UE-23145 Adding a Priority value to USoundBase to use in concurrency evaluation and sorting wave instances for voice stealing.
#rb zak.middleton
Change 2760081 on 2015/11/09 by Aaron.McLeran
UE-23091 Adding more logging for NaN checks and fixing one source of NaNs for audio.
OmniDirectional Math Explanation:
For XAudio2, because we do our own distance-attenuation calculations, we use the X3dAudio2 API to simply compute a speaker-map for spatialization and force the listener to be at the origin and the emitter to be on the unit-circle. Thus, from XAudio2's perspective, all distances for every listener-emitter pair will be 1.0.
So in order to use the InnerRadius blending feature, we need to trick it into doing a an inner radius blend relative to a distance of 1.0. For example, if OmniRadius and Distance are the same, then the "NormalizedOmniRadius" is 1.0 and XAudio2 will begin its "blend" of the sound to an omni-directional speaker map.
If Emitter-listener distance is less than the OmniRadius, we'll want to do more blending to an omni-directional speaker map, but we need to set the InnerRadius to something greater than 1.0 (i.e. so that the normalized distance of 1.0 will be treated as less than the InnerRadius). To do "full" omni-directional blending, the emitter-listener distance will be 0 or close to zero, and the NormalizedOmniRadius will be very large (i.e. close to infiinity).
The previous math just set the NormalizedOmniRadius to FLT_MAX which is fine but that number is eventually squared before making the API call. FLT_MAX squared is INF.
Note: I do not think we need to square the OmniRadius in:
Emitter.InnerRadius = OmniRadius*OmniRadius;
But I am keeping it t here because of legacy content which depends on that behavior.
#rb zak.middleton
hange 2760401 on 2015/11/10 by Thomas.Sarkanen@Thomas.Sarkanen-Dev-Framework
Re-instated deleted protected functions in UAnimInstance.
Fixed access of UAnimInstance in FAnimNode_StateMachine.
#rb Martin.Wilson
Change 2760407 on 2015/11/10 by Jurre.deBaare
Construct raw meshes for spline meshes now uses the render data instead of original model data (preserves tangents/normals)
Change 2760468 on 2015/11/10 by Benn.Gallagher
Anim Dynamics optimizations, cached iteration independant data to reduce footprint of iteration on limits.
#rb Graeme.Thornton
Change 2760613 on 2015/11/10 by Jeff.Farris
Fixed async collision completion delegate potentially firing repeatedly. (UE-23149)
#cr marc.audy
#codereview lina.halper
Change 2760795 on 2015/11/10 by Marc.Audy
Don't compile in pointless AddReferencedObjects when with editoronly data not defined
Minor coding standard cleanup (NULL and auto)
Change 2760848 on 2015/11/10 by Benn.Gallagher
Fix to anim instance proxy to not rely on state machine initialization to bind native delegates as nested state machines are not guaranteed to be initialized. This was fixed in UAnimInstance originally but broken again by the proxy instance code.
#jira UE-23164
#rb Martin.Wilson
Change 2760866 on 2015/11/10 by Marc.Audy
Manage transient visualization components for camera component in the same way that sprite component for other actor components are
#rb Mike.Beach
Change 2760963 on 2015/11/10 by Marc.Audy
Since construction script can cause actors to be spawned don't use a ranged for to iterate
#jira UE-22639
#rb Jeff.Farris
#codereview Dmitriy.Dyomin
Change 2762297 on 2015/11/11 by James.Golding
UE-23086 Don't ensure in SetRootBodyIndex when Bodies array is empty (ie no physics state created)
#rb martin.wilson
#codereview ori.cohen, lina.halper
Change 2763566 on 2015/11/11 by Lina.Halper
FAnimNode_CopyPoseFromMesh::Evaluate - was accessing skeleton joint, not mesh joint.
#RB: Laurent.Delayen
Change 2763926 on 2015/11/12 by Thomas.Sarkanen
Fix anim notifies not firing from single anim instances
UE-23248 - Anim Notifies are not working for Animation Sequences
UE-23249 - Anim Notifies using Sound Cues do not work
#rb James.Golding
Change 2764039 on 2015/11/12 by Jurre.deBaare
Fix for issue with incorrect material indices after reducing a skeletal mesh with non LOD0 mesh as BaseLOD (OR-9243) #rb Lina.Halper
Change 2764307 on 2015/11/12 by Jurre.deBaare
VS2015 SSF library
Change 2764314 on 2015/11/12 by Stan.Melax
crashfix was putting bad bodies to sleep at start
Fatal error!
Unhandled Exception: EXCEPTION_ACCESS_VIOLATION reading address 0x00000000
UE4Editor-Engine.dll!USkeletalMeshComponent::InitArticulated() [...\\engine\\source\\runtime\\engine\\private\\skeletalmeshcomponentphysics.cpp:875]
On some skeletalmeshcomponent, some bodies aren't getting created correctly. Trying to force them to sleep was causing a crash - it expected instantiated physx bodies. Seems that all the rest of the code is able to tolerate bad bodies.
Added check to ensure physx body exists before trying to force it to sleep.
not sure if bad bodies are the norm or if this fix is just more "kicking the can down the road".
#codereview ori.cohen
Change 2764343 on 2015/11/12 by Jurre.deBaare
- Fixed crash when building a LOD with SubActors.Num < 2
- Force HLOD level slider is now always enabled, however won't show complete image if not all HLODs are build
- LODActor tree view item now scrolls into view if selected in the world
- Set bAllowCullDistanceVolume to false for LODActor's static mesh components by default
- Added 7zip files
- Fixed issue with WinINet complaining about http-request without 'http://' prefix
- Changed % reduced or original triangles display string, now uses float instead of int (for < 1% reductions)
- Override texture sizes and automatic texture bias
- Fixed issue with incorrect material merging, not picking up it required mesh-data during baking. Added extra conditions for rendering with mesh-data.
- Now incorporate static meshes with opague materials into HLOD merging
- Fixed issue with incorrect normals after merging meshes who's owning components had been negatively scaled
- Fixed issue with incorrect texture size being set from MergeActor window (was only changing .X component)
- Fixed issue with material merging when meshes with multiple LODs are merged, right now only merges LOD0's together if we are also merging the materials (otherwise, merge each LOD)
- Added ENUM for texture scaling/resizing type that has to be applied while merging the materials
- Added detail customization class for FMaterialProxySettings
#rb James.Golding
[CL 2765024 by Marc Audy in Main branch]
2015-11-12 18:11:48 -05:00
SCOPE_CYCLE_COUNTER ( STAT_AnimDynamicsOverall ) ;
2015-10-28 08:58:16 -04:00
int32 RestrictToLOD = CVarRestrictLod . GetValueOnAnyThread ( ) ;
bool bEnabledForLod = RestrictToLOD > = 0 ? SkelComp - > PredictedLODLevel = = RestrictToLOD : true ;
if ( CVarEnableDynamics . GetValueOnAnyThread ( ) = = 1 & & bEnabledForLod )
2015-10-06 16:47:09 -04:00
{
// Pretty nasty - but there isn't really a good way to get clean bone transforms (without the modification from
// previous runs) so we have to initialize here, checking often so we can restart a simulation in the editor.
if ( bRequiresInit )
{
InitPhysics ( SkelComp , MeshBases ) ;
bRequiresInit = false ;
}
if ( bDoUpdate & & NextTimeStep > 0.0f )
{
2015-10-28 08:58:16 -04:00
// Wind / Force update
if ( CVarEnableWind . GetValueOnAnyThread ( ) = = 1 & & bEnableWind )
{
SCOPE_CYCLE_COUNTER ( STAT_AnimDynamicsWindData ) ;
for ( FAnimPhysRigidBody * Body : BaseBodyPtrs )
{
if ( SkelComp & & SkelComp - > GetWorld ( ) )
{
Body - > bWindEnabled = bEnableWind ;
if ( Body - > bWindEnabled )
{
UWorld * World = SkelComp - > GetWorld ( ) ;
FSceneInterface * Scene = World - > Scene ;
// Unused by our simulation but needed for the call to GetWindParameters below
float WindMinGust ;
float WindMaxGust ;
// Setup wind data
Body - > bWindEnabled = true ;
Scene - > GetWindParameters ( SkelComp - > ComponentToWorld . TransformPosition ( Body - > Pose . Position ) , Body - > WindData . WindDirection , Body - > WindData . WindSpeed , WindMinGust , WindMaxGust ) ;
Body - > WindData . WindDirection = SkelComp - > ComponentToWorld . Inverse ( ) . TransformVector ( Body - > WindData . WindDirection ) ;
Body - > WindData . WindAdaption = FMath : : FRandRange ( 0.0f , 2.0f ) ;
Body - > WindData . BodyWindScale = WindScale ;
}
}
}
}
else
{
SCOPE_CYCLE_COUNTER ( STAT_AnimDynamicsWindData ) ;
// Disable wind.
for ( FAnimPhysRigidBody * Body : BaseBodyPtrs )
{
Body - > bWindEnabled = false ;
}
}
2015-10-06 16:47:09 -04:00
if ( CVarEnableAdaptiveSubstep . GetValueOnAnyThread ( ) = = 1 )
{
2015-10-28 08:58:16 -04:00
float FixedTimeStep = MaxSubstepDeltaTime * CurrentTimeDilation ;
// Clamp the fixed timestep down to max physics tick time.
// at high speeds the simulation will not converge as the delta time is too high, this will
// help to keep constraints together at a cost of physical accuracy
FixedTimeStep = FMath : : Clamp ( FixedTimeStep , 0.0f , MaxPhysicsDeltaTime ) ;
2015-10-06 16:47:09 -04:00
// Calculate number of substeps we should do.
2015-10-28 08:58:16 -04:00
int32 NumIters = FMath : : TruncToInt ( ( NextTimeStep + ( TimeDebt * CurrentTimeDilation ) ) / FixedTimeStep ) ;
2015-10-06 16:47:09 -04:00
NumIters = FMath : : Clamp ( NumIters , 0 , MaxSubsteps ) ;
2015-10-28 08:58:16 -04:00
SET_DWORD_STAT ( STAT_AnimDynamicsSubSteps , NumIters ) ;
2015-10-06 16:47:09 -04:00
// Store the remaining time as debt for later frames
TimeDebt = ( NextTimeStep + TimeDebt ) - ( NumIters * FixedTimeStep ) ;
TimeDebt = FMath : : Clamp ( TimeDebt , 0.0f , MaxTimeDebt ) ;
2015-10-28 08:58:16 -04:00
NextTimeStep = FixedTimeStep ;
2015-10-06 16:47:09 -04:00
for ( int32 Iter = 0 ; Iter < NumIters ; + + Iter )
{
2015-10-28 08:58:16 -04:00
UpdateLimits ( SkelComp , MeshBases ) ;
FAnimPhys : : PhysicsUpdate ( FixedTimeStep , BaseBodyPtrs , LinearLimits , AngularLimits , Springs , NumSolverIterationsPreUpdate , NumSolverIterationsPostUpdate ) ;
2015-10-06 16:47:09 -04:00
}
}
else
{
// Do variable frame-time update
2015-10-28 08:58:16 -04:00
const float MaxDeltaTime = MaxPhysicsDeltaTime ;
NextTimeStep = FMath : : Min ( NextTimeStep , MaxDeltaTime ) ;
UpdateLimits ( SkelComp , MeshBases ) ;
FAnimPhys : : PhysicsUpdate ( NextTimeStep , BaseBodyPtrs , LinearLimits , AngularLimits , Springs , NumSolverIterationsPreUpdate , NumSolverIterationsPostUpdate ) ;
2015-10-06 16:47:09 -04:00
}
}
if ( bDoEval )
{
2015-10-28 08:58:16 -04:00
SCOPE_CYCLE_COUNTER ( STAT_AnimDynamicsBoneEval ) ;
2015-10-06 16:47:09 -04:00
const FBoneContainer & BoneContainer = MeshBases . GetPose ( ) . GetBoneContainer ( ) ;
for ( int32 Idx = 0 ; Idx < BoundBoneReferences . Num ( ) ; + + Idx )
{
FBoneReference & CurrentChainBone = BoundBoneReferences [ Idx ] ;
FAnimPhysRigidBody & CurrentBody = Bodies [ Idx ] . RigidBody . PhysBody ;
2015-10-28 08:58:16 -04:00
// Skip invalid bones
if ( ! CurrentChainBone . IsValid ( BoneContainer ) )
{
continue ;
}
2015-10-06 16:47:09 -04:00
FCompactPoseBoneIndex BoneIndex = CurrentChainBone . GetCompactPoseIndex ( BoneContainer ) ;
Copying //UE4/Dev-Framework to //UE4/Main @ 2775446
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2720537 on 2015/10/07 by Aaron.McLeran
Audio Optimization: Implementing an audio update delta time so audio isn't updated with every engine tick
Change 2746582 on 2015/10/29 by Aaron.McLeran
Implementing single ray-cast sound occlusion
- Fixing/Implementing sound occlusion using one ray cast
- Update rate of the ray cast is conifgurable by the user
- User can enabled/disable occlusion and set various properties of the occlusion at the audio component level
- Occlusion ray-casts are made at a slower rate than the audio engine is updated
- The following properties are supported:
* LowPassFilterFrequency (the LPF cutoff frequency of the per-voice filter to apply if a sound is occluded)
* OcclusionVolumeAttenuation (the volume attenuation to apply to sounds that are occluded)
* OcclusionInterpolationTime (how fast a sound moves from occluded to unoccluded... allows user-defined interpolation times, avoids fast parameter setting for smoother transitions)
- Fixed how low-pass filter frequency is applied on platforms that support it.
* Changed the older HighFrequencyGain parameter to a more understandable and correct LowPassFilterFrequency parameter
* Updated the parameter for the various other features that use per-voice LPF (e.g. audio volumes, distance-based filtering)
* Added backward-compatibility code to take old HighFrequencyGain params to new LowPassFilterFrequency params.
* At the lowest level, there is only one filter which is applied to a sound, but the parameter that has the lowest cutoff frequency is the one used
* Fixed how the parameter is applied at the lower-level in XAudio2 and CoreAudio. The old parameter was incorrectly applied.
* XAudio2 documentation on the low-pass-fitler frequency cutoff param is confirmed incorrect through testing.
#rb zak.middleton
Change 2765174 on 2015/11/12 by Aaron.McLeran
UE-23091 More fixage for NaN audio log spam
Last checkin for this (CL 2760896) was fixing a legit issue but there was still an issue that I was rarely catching during the FN gate encounter in AITestbed after about 5 min of gate defense.
To track down, I added a lot more logging and asserts on NaN numbers in the audio code, enabled ENABLE_NAN_DIAGNOSTIC in UnrealMathUtility.h.
- Was able to trace another cause of the NaNs in audio to 2 uninitialized variables in SoundAttenuationSettings struct: OmniRadius and StereoSpread.
- Zak M suggested the change of the const ref position vector in ListenerPosition and the usage of GetSafeNormal() in Audio.cpp since the value returned by GetLocation() is a temporary and Normalize() is unsafe.
- I removed the flag for the XAudio2 call to compute doppler since we don't use that value and it could've been as source of more NaNs in X3DAudioCalculate
#codereview Zak.Middleton
#rb Zak.Middleton
Change 2765467 on 2015/11/13 by James.Golding
- Allow -ms option to work with 'stat dumphitches' for controlling min time logged
#rb gil.gribb
Change 2765746 on 2015/11/13 by Benn.Gallagher
Added buckets for update rate shift tags (for staggering anim updates)
#jira UE-23213
#rb Bruce.Nesbit
Change 2765747 on 2015/11/13 by Benn.Gallagher
Fixes for bone length calculation in anim dynamics chains.
#rb Bruce.Nesbit
Change 2765749 on 2015/11/13 by Benn.Gallagher
Removed allocations from local CS blends for skeletal controls.
#rb Bruce.Nesbit
Change 2765752 on 2015/11/13 by Benn.Gallagher
Lod mapping support for URO customization
#jira UE-23211
#rb Bruce.Nesbit
Change 2765965 on 2015/11/13 by Marc.Audy
Remove outdated code in LoadMap previously used for matching up downloaded packages from servers. These code paths no longer operate, but in the case where a PIE client was connecting to a non-PIE server (not really supported, but possible), it would cause the Editor Level package to be flagged as as PIE package and cause a crash on exit of PIE
#jira UE-21181
#rb Josh.Markiewicz
Change 2766071 on 2015/11/13 by Mieszko.Zielinski
Fixed dumb mistake in AEQSTestingPawn::PostLoad #UE4
the 'bTickDuringGame == bTickDuringGame' thing
#rb John.Abercrombie
Change 2766086 on 2015/11/13 by Mieszko.Zielinski
Exposing NavModifierComponent to ENGINE_API #UE4
#codereview Lukasz.Furman
Change 2766345 on 2015/11/13 by Mieszko.Zielinski
No longer compiling AISystem's creation out from client builds #UE4
Instead AISystem's instantiation on clients is configurable via UAISystemBase::bInstantiateAISystemOnClient config variable
Change 2766346 on 2015/11/13 by Mieszko.Zielinski
Improvements to EQS test scoring function preview #UE4
#rb Lukasz.Furman
Change 2766528 on 2015/11/13 by Stan.Melax
multiple materials/chunks on a single cloth sim mesh
This supposedly used to work in 4.7 but broke for 4.8
It looks like previous change 2493547 may have introduced the condition statement that makes multiple materials not include all of there verts.
Changing this to instead check for the bounds on the skinningmap instead of the NumRealSimVerts which doesn't look like it takes the offset into consideration.
jira:
#UE-23300
https://jira.ol.epicgames.net/browse/UE-23300
https://answers.unrealengine.com/questions/287833/apex-not-working-on-multiple-materials-since-48.html
Double tested code change with test asset from https://jira.ol.epicgames.net/browse/UE-10674
#rb Benn.Gallagher
Change 2766546 on 2015/11/13 by Marc.Audy
Throw warning for orphaned looping sounds caused by a looping sound node
Don't do somewhat expensive (due to weak pointer) orphaned sound checks in test or shipping
#rb Aaron.McLeran
Change 2766917 on 2015/11/14 by Jurre.deBaare
Fix UE4-23349 Simplygon doens't support sub 64 pixel textures
Change 2767742 on 2015/11/16 by Marc.Audy
Restructure SignificanceManager to store significance manager references in a FGCObject Module class instead of using a singleton.
Improve performance by eliminating StaticFindObjectFast calls in ::Get and force inlining Get calls
#rb Zak.Middleton, Rob.Manuszewski
Change 2767827 on 2015/11/16 by Zak.Middleton
#ue4 - Perf: avoid SmoothClientPosition() calls once the target mesh offset has been reached.
- New flag bNetworkSmoothingComplete indicates whether smoothing has reached the destination. This is set to false when a new network position is received.
- Also fixes trying to smooth rotation towards identity rotation before receiving network updates.
- Deprecated FNetworkPredictionData_Client_Character::CurrentSmoothTime in favor of saving last update time, to prevent needing to update time every tick (since we skip updates now).
#rb Dan.Youhon
Change 2768070 on 2015/11/16 by Marc.Audy
Change StaticDuplicateObject and DuplicateObject to take FName instead of char* (existing usages can automatically convert to FName so no backwards compatibility issues)
Fixup usages to avoid unnecessary string -> char* -> name conversions
Change AActor::CreateComponentFromTemplate to take an FName instead of FString, deprecated FString version
#rb Gil.Gribb
Change 2768121 on 2015/11/16 by Marc.Audy
Forceinline GetFName
Change 2768161 on 2015/11/16 by Aaron.McLeran
Checking occlusion back in
- Bug was due to improper interpolation of LPFFrequency values in audio volumes.
Change 2769428 on 2015/11/17 by Thomas.Sarkanen
Fixed backwards-compatibility issues with FExposedValueCopyRecord
Added PostSerialize function to patch up older data to the new format (copies properties->property FNames).
Made sure to zero FExposedValueCopyRecord in its constructor, prevents uninitialized variable issues when generating CRCs. This is necessary despite these members being UPROPERTYs because they are simply built on the stack then stuffed into the new CDO during compilation.
UE-23268 - EDITOR CRASH: Assertion failed: ((UObject*)ContainerPtr)->IsA((UClass*)GetOuter())
#rb James.Golding
#codereview Mike.Beach,Bob.Tellez
Change 2769488 on 2015/11/17 by Benn.Gallagher
DrawCanvas and debug string support for skeletal controls - accessed using "Skeletal Controls" option in Show->Display Info in Persona
#rb Martin.Wilson
Change 2769545 on 2015/11/17 by Benn.Gallagher
Added space conversion options to copy bone node.
#jira OR-9430
#rb Martin.Wilson
Change 2770228 on 2015/11/17 by Marc.Audy
Fix cause of assert firing when detaching if AttachTo(AttachParent) returns false
#rb Ori.Cohen
#jira UE-23366
Change 2770489 on 2015/11/17 by Marc.Audy
Make ::Serialize WITH_EDITORONLY_DATA since it did nothing otherwise
Change 2770761 on 2015/11/17 by Aaron.McLeran
Removing optimization disablement
- Forgot to remove these lines before checking in/testing.
Change 2771375 on 2015/11/18 by Thomas.Sarkanen
Added initialzation of internal state machine desc ptrs to (finally) remove random crashes when using sub-state machines
#rb Benn.Gallagher
Change 2771697 on 2015/11/18 by Jeff.Farris
Sensible defaults for APlayerController::ClientPlayCameraAnim and ClientPlayCameraShake
#rb marc.audy
Change 2771755 on 2015/11/18 by Marc.Audy
Put back in the recursion block for destroy actor
#rb James.Golding
Change 2772217 on 2015/11/18 by Marc.Audy
Update axis inversion to work the same way as sensitivity instead of old problematic way
Also change to use Reset instead of Empty(Array.Num())
#rb Jeff.Farris
Change 2772686 on 2015/11/18 by Aaron.McLeran
Fixing HRTF spatialization coordinate bug.
Don't need to convert to xaudio2 coordinates for HRTF spatialization
#rb chad.taylor
Change 2772766 on 2015/11/18 by Aaron.McLeran
Fixing HRTF spatialization with xaudio2 voice pools
- Issue was caused by 2 issues:
- effect chains weren't properly clearing their state between uses (SetEffectChain(nullptr) releases the effect for use with other voices)
- Not re-setting MaxEffectChainChannels = 0 in CreateSource() was causing re-used SoundSources to release their XAudio2 voices to the wrong pool.
#rb chad.taylor
Change 2773027 on 2015/11/19 by Thomas.Sarkanen
PR #1765: Git Plugin can find the git.exe binary installed on the Local AppData user directory (Contributed by SRombauts)
#rb Thomas.Sarkanen
Change 2773142 on 2015/11/19 by Benn.Gallagher
Optimized SafeSetCSBoneTransforms, no longer doing 2 iterations over the whole pose.
- Only iterating beyond the index of the first bone transform, cutting off all bones before
- No longer using a bone mask the size of the skeleton, just an array of interesting nodes
- No longer attempting to convert a transform if it isn't necessary (which was happening a lot)
#rb Laurent.Delayen
Change 2773212 on 2015/11/19 by Richard.Hinckley
#jira UEDOC-2685
Removing ugly comment. Not going to remove the node itself for backward compatibility.
Change 2773351 on 2015/11/19 by Zak.Middleton
#orion - Make sure we don't skip a final visual update when character mesh interpolation tries to stop smoothing once it reaches its destination. We keep setting bNetworkSmoothingComplete to false until the first visual update, at which point if it remains true we will stop getting updates.
#rb Dan.Youhon
Change 2773599 on 2015/11/19 by Marc.Audy
Fix shadow variable, initialization order, and incorrect placement of ENGINE_API that fails compiles on clang
#codereview Aaron.McLeran
Change 2773661 on 2015/11/19 by Richard.Hinckley
#jira UEDOC-2685
Following up by deprecating the CastToPlayerController function for 4.11.
Change 2774707 on 2015/11/19 by Stan.Melax
FCollisionQueryParams constructor API pitfall
Deprecating something that will call the unintended constructor if the programmer provides a string literal instead of explicitly creating an FName.
So this line of code:
FCollisionQueryParams Param(FName(TEXT("DragDropTrace")));
will invoke:
FCollisionQueryParams::FCollisionQueryParams(FName,bool=false,...)
But this line of code:
FCollisionQueryParams Param(TEXT("DragDropTrace"));
invokes:
FCollisionQueryParams::FCollisionQueryParams(bool)
Yes that actually happens, the string literal (the TEXT("whatever")) ends up specifies a bool parameter instead of a FName parameter. So the name is lost and a flag (that is usually set to false) is now set to true (since the string literal address is non-NULL). Yeah, that's could potentially be not what the programmer had intended.
It looks like this interface was introduced in CL 1792949
back in august 2013. Since its been a couple of years, we'll phase it out using the deprecation approach.
Making an API change would break things for existing projects.
If it had been a more recent change we could have probably just gone down to a single constructor right away.
Figured out that going one step further and removing bool param's default and adding a default constructor would minimize the number of places that will be hit with this deprecation. So, yes this is *increasing* the number of construtors temporarily, but this solution has minimal impact on the community. Later after other to-be-deprecated constructor gets removed, the two remaining can be combined into one with defaults for all parameters.
see also
https://udn.unrealengine.com/questions/269512/dangerous-fcollisionqueryparams-overloads.html
#codereview ori.cohen
[CL 2775460 by Marc Audy in Main branch]
2015-11-20 11:02:37 -05:00
FTransform NewBoneTransform ( CurrentBody . Pose . Orientation , CurrentBody . Pose . Position + CurrentBody . Pose . Orientation . RotateVector ( JointOffsets [ Idx ] ) ) ;
2015-10-06 16:47:09 -04:00
OutBoneTransforms . Add ( FBoneTransform ( BoneIndex , NewBoneTransform ) ) ;
}
}
}
}
void FAnimNode_AnimDynamics : : InitializeBoneReferences ( const FBoneContainer & RequiredBones )
{
2015-10-28 08:58:16 -04:00
BoundBone . Initialize ( RequiredBones ) ;
if ( bChain )
{
ChainEnd . Initialize ( RequiredBones ) ;
}
2015-10-06 16:47:09 -04:00
2015-10-28 08:58:16 -04:00
for ( FBoneReference & BoneRef : BoundBoneReferences )
{
BoneRef . Initialize ( RequiredBones ) ;
}
2015-10-06 16:47:09 -04:00
}
void FAnimNode_AnimDynamics : : GatherDebugData ( FNodeDebugData & DebugData )
{
const float ActualAlpha = AlphaScaleBias . ApplyTo ( Alpha ) ;
FString DebugLine = DebugData . GetNodeName ( this ) ;
DebugLine + = FString : : Printf ( TEXT ( " (Alpha: %.1f%%) " ) , ActualAlpha * 100.f ) ;
DebugData . AddDebugItem ( DebugLine ) ;
ComponentPose . GatherDebugData ( DebugData . BranchFlow ( 1.f ) ) ;
}
bool FAnimNode_AnimDynamics : : IsValidToEvaluate ( const USkeleton * Skeleton , const FBoneContainer & RequiredBones )
{
bool bValid = BoundBone . IsValid ( RequiredBones ) ;
if ( bChain )
{
bValid = bValid & & ChainEnd . IsValid ( RequiredBones ) ;
}
return bValid ;
}
int32 FAnimNode_AnimDynamics : : GetNumBodies ( ) const
{
return Bodies . Num ( ) ;
}
const FAnimPhysRigidBody & FAnimNode_AnimDynamics : : GetPhysBody ( int32 BodyIndex ) const
{
return Bodies [ BodyIndex ] . RigidBody . PhysBody ;
}
Copying //UE4/Dev-Framework to //UE4/Main @ 2775446
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2720537 on 2015/10/07 by Aaron.McLeran
Audio Optimization: Implementing an audio update delta time so audio isn't updated with every engine tick
Change 2746582 on 2015/10/29 by Aaron.McLeran
Implementing single ray-cast sound occlusion
- Fixing/Implementing sound occlusion using one ray cast
- Update rate of the ray cast is conifgurable by the user
- User can enabled/disable occlusion and set various properties of the occlusion at the audio component level
- Occlusion ray-casts are made at a slower rate than the audio engine is updated
- The following properties are supported:
* LowPassFilterFrequency (the LPF cutoff frequency of the per-voice filter to apply if a sound is occluded)
* OcclusionVolumeAttenuation (the volume attenuation to apply to sounds that are occluded)
* OcclusionInterpolationTime (how fast a sound moves from occluded to unoccluded... allows user-defined interpolation times, avoids fast parameter setting for smoother transitions)
- Fixed how low-pass filter frequency is applied on platforms that support it.
* Changed the older HighFrequencyGain parameter to a more understandable and correct LowPassFilterFrequency parameter
* Updated the parameter for the various other features that use per-voice LPF (e.g. audio volumes, distance-based filtering)
* Added backward-compatibility code to take old HighFrequencyGain params to new LowPassFilterFrequency params.
* At the lowest level, there is only one filter which is applied to a sound, but the parameter that has the lowest cutoff frequency is the one used
* Fixed how the parameter is applied at the lower-level in XAudio2 and CoreAudio. The old parameter was incorrectly applied.
* XAudio2 documentation on the low-pass-fitler frequency cutoff param is confirmed incorrect through testing.
#rb zak.middleton
Change 2765174 on 2015/11/12 by Aaron.McLeran
UE-23091 More fixage for NaN audio log spam
Last checkin for this (CL 2760896) was fixing a legit issue but there was still an issue that I was rarely catching during the FN gate encounter in AITestbed after about 5 min of gate defense.
To track down, I added a lot more logging and asserts on NaN numbers in the audio code, enabled ENABLE_NAN_DIAGNOSTIC in UnrealMathUtility.h.
- Was able to trace another cause of the NaNs in audio to 2 uninitialized variables in SoundAttenuationSettings struct: OmniRadius and StereoSpread.
- Zak M suggested the change of the const ref position vector in ListenerPosition and the usage of GetSafeNormal() in Audio.cpp since the value returned by GetLocation() is a temporary and Normalize() is unsafe.
- I removed the flag for the XAudio2 call to compute doppler since we don't use that value and it could've been as source of more NaNs in X3DAudioCalculate
#codereview Zak.Middleton
#rb Zak.Middleton
Change 2765467 on 2015/11/13 by James.Golding
- Allow -ms option to work with 'stat dumphitches' for controlling min time logged
#rb gil.gribb
Change 2765746 on 2015/11/13 by Benn.Gallagher
Added buckets for update rate shift tags (for staggering anim updates)
#jira UE-23213
#rb Bruce.Nesbit
Change 2765747 on 2015/11/13 by Benn.Gallagher
Fixes for bone length calculation in anim dynamics chains.
#rb Bruce.Nesbit
Change 2765749 on 2015/11/13 by Benn.Gallagher
Removed allocations from local CS blends for skeletal controls.
#rb Bruce.Nesbit
Change 2765752 on 2015/11/13 by Benn.Gallagher
Lod mapping support for URO customization
#jira UE-23211
#rb Bruce.Nesbit
Change 2765965 on 2015/11/13 by Marc.Audy
Remove outdated code in LoadMap previously used for matching up downloaded packages from servers. These code paths no longer operate, but in the case where a PIE client was connecting to a non-PIE server (not really supported, but possible), it would cause the Editor Level package to be flagged as as PIE package and cause a crash on exit of PIE
#jira UE-21181
#rb Josh.Markiewicz
Change 2766071 on 2015/11/13 by Mieszko.Zielinski
Fixed dumb mistake in AEQSTestingPawn::PostLoad #UE4
the 'bTickDuringGame == bTickDuringGame' thing
#rb John.Abercrombie
Change 2766086 on 2015/11/13 by Mieszko.Zielinski
Exposing NavModifierComponent to ENGINE_API #UE4
#codereview Lukasz.Furman
Change 2766345 on 2015/11/13 by Mieszko.Zielinski
No longer compiling AISystem's creation out from client builds #UE4
Instead AISystem's instantiation on clients is configurable via UAISystemBase::bInstantiateAISystemOnClient config variable
Change 2766346 on 2015/11/13 by Mieszko.Zielinski
Improvements to EQS test scoring function preview #UE4
#rb Lukasz.Furman
Change 2766528 on 2015/11/13 by Stan.Melax
multiple materials/chunks on a single cloth sim mesh
This supposedly used to work in 4.7 but broke for 4.8
It looks like previous change 2493547 may have introduced the condition statement that makes multiple materials not include all of there verts.
Changing this to instead check for the bounds on the skinningmap instead of the NumRealSimVerts which doesn't look like it takes the offset into consideration.
jira:
#UE-23300
https://jira.ol.epicgames.net/browse/UE-23300
https://answers.unrealengine.com/questions/287833/apex-not-working-on-multiple-materials-since-48.html
Double tested code change with test asset from https://jira.ol.epicgames.net/browse/UE-10674
#rb Benn.Gallagher
Change 2766546 on 2015/11/13 by Marc.Audy
Throw warning for orphaned looping sounds caused by a looping sound node
Don't do somewhat expensive (due to weak pointer) orphaned sound checks in test or shipping
#rb Aaron.McLeran
Change 2766917 on 2015/11/14 by Jurre.deBaare
Fix UE4-23349 Simplygon doens't support sub 64 pixel textures
Change 2767742 on 2015/11/16 by Marc.Audy
Restructure SignificanceManager to store significance manager references in a FGCObject Module class instead of using a singleton.
Improve performance by eliminating StaticFindObjectFast calls in ::Get and force inlining Get calls
#rb Zak.Middleton, Rob.Manuszewski
Change 2767827 on 2015/11/16 by Zak.Middleton
#ue4 - Perf: avoid SmoothClientPosition() calls once the target mesh offset has been reached.
- New flag bNetworkSmoothingComplete indicates whether smoothing has reached the destination. This is set to false when a new network position is received.
- Also fixes trying to smooth rotation towards identity rotation before receiving network updates.
- Deprecated FNetworkPredictionData_Client_Character::CurrentSmoothTime in favor of saving last update time, to prevent needing to update time every tick (since we skip updates now).
#rb Dan.Youhon
Change 2768070 on 2015/11/16 by Marc.Audy
Change StaticDuplicateObject and DuplicateObject to take FName instead of char* (existing usages can automatically convert to FName so no backwards compatibility issues)
Fixup usages to avoid unnecessary string -> char* -> name conversions
Change AActor::CreateComponentFromTemplate to take an FName instead of FString, deprecated FString version
#rb Gil.Gribb
Change 2768121 on 2015/11/16 by Marc.Audy
Forceinline GetFName
Change 2768161 on 2015/11/16 by Aaron.McLeran
Checking occlusion back in
- Bug was due to improper interpolation of LPFFrequency values in audio volumes.
Change 2769428 on 2015/11/17 by Thomas.Sarkanen
Fixed backwards-compatibility issues with FExposedValueCopyRecord
Added PostSerialize function to patch up older data to the new format (copies properties->property FNames).
Made sure to zero FExposedValueCopyRecord in its constructor, prevents uninitialized variable issues when generating CRCs. This is necessary despite these members being UPROPERTYs because they are simply built on the stack then stuffed into the new CDO during compilation.
UE-23268 - EDITOR CRASH: Assertion failed: ((UObject*)ContainerPtr)->IsA((UClass*)GetOuter())
#rb James.Golding
#codereview Mike.Beach,Bob.Tellez
Change 2769488 on 2015/11/17 by Benn.Gallagher
DrawCanvas and debug string support for skeletal controls - accessed using "Skeletal Controls" option in Show->Display Info in Persona
#rb Martin.Wilson
Change 2769545 on 2015/11/17 by Benn.Gallagher
Added space conversion options to copy bone node.
#jira OR-9430
#rb Martin.Wilson
Change 2770228 on 2015/11/17 by Marc.Audy
Fix cause of assert firing when detaching if AttachTo(AttachParent) returns false
#rb Ori.Cohen
#jira UE-23366
Change 2770489 on 2015/11/17 by Marc.Audy
Make ::Serialize WITH_EDITORONLY_DATA since it did nothing otherwise
Change 2770761 on 2015/11/17 by Aaron.McLeran
Removing optimization disablement
- Forgot to remove these lines before checking in/testing.
Change 2771375 on 2015/11/18 by Thomas.Sarkanen
Added initialzation of internal state machine desc ptrs to (finally) remove random crashes when using sub-state machines
#rb Benn.Gallagher
Change 2771697 on 2015/11/18 by Jeff.Farris
Sensible defaults for APlayerController::ClientPlayCameraAnim and ClientPlayCameraShake
#rb marc.audy
Change 2771755 on 2015/11/18 by Marc.Audy
Put back in the recursion block for destroy actor
#rb James.Golding
Change 2772217 on 2015/11/18 by Marc.Audy
Update axis inversion to work the same way as sensitivity instead of old problematic way
Also change to use Reset instead of Empty(Array.Num())
#rb Jeff.Farris
Change 2772686 on 2015/11/18 by Aaron.McLeran
Fixing HRTF spatialization coordinate bug.
Don't need to convert to xaudio2 coordinates for HRTF spatialization
#rb chad.taylor
Change 2772766 on 2015/11/18 by Aaron.McLeran
Fixing HRTF spatialization with xaudio2 voice pools
- Issue was caused by 2 issues:
- effect chains weren't properly clearing their state between uses (SetEffectChain(nullptr) releases the effect for use with other voices)
- Not re-setting MaxEffectChainChannels = 0 in CreateSource() was causing re-used SoundSources to release their XAudio2 voices to the wrong pool.
#rb chad.taylor
Change 2773027 on 2015/11/19 by Thomas.Sarkanen
PR #1765: Git Plugin can find the git.exe binary installed on the Local AppData user directory (Contributed by SRombauts)
#rb Thomas.Sarkanen
Change 2773142 on 2015/11/19 by Benn.Gallagher
Optimized SafeSetCSBoneTransforms, no longer doing 2 iterations over the whole pose.
- Only iterating beyond the index of the first bone transform, cutting off all bones before
- No longer using a bone mask the size of the skeleton, just an array of interesting nodes
- No longer attempting to convert a transform if it isn't necessary (which was happening a lot)
#rb Laurent.Delayen
Change 2773212 on 2015/11/19 by Richard.Hinckley
#jira UEDOC-2685
Removing ugly comment. Not going to remove the node itself for backward compatibility.
Change 2773351 on 2015/11/19 by Zak.Middleton
#orion - Make sure we don't skip a final visual update when character mesh interpolation tries to stop smoothing once it reaches its destination. We keep setting bNetworkSmoothingComplete to false until the first visual update, at which point if it remains true we will stop getting updates.
#rb Dan.Youhon
Change 2773599 on 2015/11/19 by Marc.Audy
Fix shadow variable, initialization order, and incorrect placement of ENGINE_API that fails compiles on clang
#codereview Aaron.McLeran
Change 2773661 on 2015/11/19 by Richard.Hinckley
#jira UEDOC-2685
Following up by deprecating the CastToPlayerController function for 4.11.
Change 2774707 on 2015/11/19 by Stan.Melax
FCollisionQueryParams constructor API pitfall
Deprecating something that will call the unintended constructor if the programmer provides a string literal instead of explicitly creating an FName.
So this line of code:
FCollisionQueryParams Param(FName(TEXT("DragDropTrace")));
will invoke:
FCollisionQueryParams::FCollisionQueryParams(FName,bool=false,...)
But this line of code:
FCollisionQueryParams Param(TEXT("DragDropTrace"));
invokes:
FCollisionQueryParams::FCollisionQueryParams(bool)
Yes that actually happens, the string literal (the TEXT("whatever")) ends up specifies a bool parameter instead of a FName parameter. So the name is lost and a flag (that is usually set to false) is now set to true (since the string literal address is non-NULL). Yeah, that's could potentially be not what the programmer had intended.
It looks like this interface was introduced in CL 1792949
back in august 2013. Since its been a couple of years, we'll phase it out using the deprecation approach.
Making an API change would break things for existing projects.
If it had been a more recent change we could have probably just gone down to a single constructor right away.
Figured out that going one step further and removing bool param's default and adding a default constructor would minimize the number of places that will be hit with this deprecation. So, yes this is *increasing* the number of construtors temporarily, but this solution has minimal impact on the community. Later after other to-be-deprecated constructor gets removed, the two remaining can be combined into one with defaults for all parameters.
see also
https://udn.unrealengine.com/questions/269512/dangerous-fcollisionqueryparams-overloads.html
#codereview ori.cohen
[CL 2775460 by Marc Audy in Main branch]
2015-11-20 11:02:37 -05:00
# if WITH_EDITOR
FVector FAnimNode_AnimDynamics : : GetBodyLocalJointOffset ( int32 BodyIndex ) const
{
if ( JointOffsets . IsValidIndex ( BodyIndex ) )
{
return JointOffsets [ BodyIndex ] ;
}
return FVector : : ZeroVector ;
}
int32 FAnimNode_AnimDynamics : : GetNumBoundBones ( ) const
{
return BoundBoneReferences . Num ( ) ;
}
const FBoneReference * FAnimNode_AnimDynamics : : GetBoundBoneReference ( int32 Index ) const
{
if ( BoundBoneReferences . IsValidIndex ( Index ) )
{
return & BoundBoneReferences [ Index ] ;
}
return nullptr ;
}
# endif
2015-10-06 16:47:09 -04:00
void FAnimNode_AnimDynamics : : InitPhysics ( USkeletalMeshComponent * Component , FCSPose < FCompactPose > & MeshBases )
{
// Clear up any existing physics data
TermPhysics ( ) ;
const FBoneContainer & BoneContainer = MeshBases . GetPose ( ) . GetBoneContainer ( ) ;
2015-10-28 08:58:16 -04:00
// List of bone indices in the chain.
TArray < int32 > ChainBoneIndices ;
TArray < FName > ChainBoneNames ;
2015-10-06 16:47:09 -04:00
2015-10-28 08:58:16 -04:00
if ( ChainEnd . IsValid ( BoneContainer ) )
{
2015-10-06 16:47:09 -04:00
// Add the end of the chain. We have to walk from the bottom upwards to find a chain
// as walking downwards doesn't guarantee a single end point.
2015-10-28 08:58:16 -04:00
2015-10-06 16:47:09 -04:00
ChainBoneIndices . Add ( ChainEnd . BoneIndex ) ;
ChainBoneNames . Add ( ChainEnd . BoneName ) ;
int32 ParentBoneIndex = BoneContainer . GetParentBoneIndex ( ChainEnd . BoneIndex ) ;
// Walk up the chain until we either find the top or hit the root bone
2015-10-28 08:58:16 -04:00
while ( ParentBoneIndex ! = 0 )
2015-10-06 16:47:09 -04:00
{
ChainBoneIndices . Add ( ParentBoneIndex ) ;
ChainBoneNames . Add ( Component - > GetBoneName ( ParentBoneIndex ) ) ;
2015-10-28 08:58:16 -04:00
if ( ParentBoneIndex = = BoundBone . BoneIndex )
2015-10-06 16:47:09 -04:00
{
// Found the top of the chain
break ;
}
ParentBoneIndex = BoneContainer . GetParentBoneIndex ( ParentBoneIndex ) ;
}
// Bail if we can't find a chain, and let the user know
2015-10-28 08:58:16 -04:00
if ( ParentBoneIndex ! = BoundBone . BoneIndex )
2015-10-06 16:47:09 -04:00
{
UE_LOG ( LogAnimation , Error , TEXT ( " AnimDynamics: Attempted to find bone chain starting at %s and ending at %s but failed. " ) , * BoundBone . BoneName . ToString ( ) , * ChainEnd . BoneName . ToString ( ) ) ;
return ;
}
}
else
{
2015-10-28 08:58:16 -04:00
// No chain specified, just use the bound bone
ChainBoneIndices . Add ( BoundBone . BoneIndex ) ;
ChainBoneNames . Add ( BoundBone . BoneName ) ;
}
Bodies . Reserve ( ChainBoneIndices . Num ( ) ) ;
// Walk backwards here as the chain was discovered in reverse order
for ( int32 Idx = ChainBoneIndices . Num ( ) - 1 ; Idx > = 0 ; - - Idx )
{
2015-10-06 16:47:09 -04:00
TArray < FAnimPhysShape > BodyShapes ;
BodyShapes . Add ( FAnimPhysShape : : MakeBox ( BoxExtents ) ) ;
2015-10-28 08:58:16 -04:00
FBoneReference LinkBoneRef ;
LinkBoneRef . BoneName = ChainBoneNames [ Idx ] ;
LinkBoneRef . Initialize ( BoneContainer ) ;
// Calculate joint offsets by looking at the length of the bones and extending the provided offset
if ( BoundBoneReferences . Num ( ) > 0 )
{
FTransform CurrentBoneTransform = MeshBases . GetComponentSpaceTransform ( LinkBoneRef . GetCompactPoseIndex ( BoneContainer ) ) ;
FTransform PreviousBoneTransform = MeshBases . GetComponentSpaceTransform ( BoundBoneReferences . Last ( ) . GetCompactPoseIndex ( BoneContainer ) ) ;
FVector PreviousAnchor = PreviousBoneTransform . TransformPosition ( - LocalJointOffset ) ;
Copying //UE4/Dev-Framework to //UE4/Main @ 2775446
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2720537 on 2015/10/07 by Aaron.McLeran
Audio Optimization: Implementing an audio update delta time so audio isn't updated with every engine tick
Change 2746582 on 2015/10/29 by Aaron.McLeran
Implementing single ray-cast sound occlusion
- Fixing/Implementing sound occlusion using one ray cast
- Update rate of the ray cast is conifgurable by the user
- User can enabled/disable occlusion and set various properties of the occlusion at the audio component level
- Occlusion ray-casts are made at a slower rate than the audio engine is updated
- The following properties are supported:
* LowPassFilterFrequency (the LPF cutoff frequency of the per-voice filter to apply if a sound is occluded)
* OcclusionVolumeAttenuation (the volume attenuation to apply to sounds that are occluded)
* OcclusionInterpolationTime (how fast a sound moves from occluded to unoccluded... allows user-defined interpolation times, avoids fast parameter setting for smoother transitions)
- Fixed how low-pass filter frequency is applied on platforms that support it.
* Changed the older HighFrequencyGain parameter to a more understandable and correct LowPassFilterFrequency parameter
* Updated the parameter for the various other features that use per-voice LPF (e.g. audio volumes, distance-based filtering)
* Added backward-compatibility code to take old HighFrequencyGain params to new LowPassFilterFrequency params.
* At the lowest level, there is only one filter which is applied to a sound, but the parameter that has the lowest cutoff frequency is the one used
* Fixed how the parameter is applied at the lower-level in XAudio2 and CoreAudio. The old parameter was incorrectly applied.
* XAudio2 documentation on the low-pass-fitler frequency cutoff param is confirmed incorrect through testing.
#rb zak.middleton
Change 2765174 on 2015/11/12 by Aaron.McLeran
UE-23091 More fixage for NaN audio log spam
Last checkin for this (CL 2760896) was fixing a legit issue but there was still an issue that I was rarely catching during the FN gate encounter in AITestbed after about 5 min of gate defense.
To track down, I added a lot more logging and asserts on NaN numbers in the audio code, enabled ENABLE_NAN_DIAGNOSTIC in UnrealMathUtility.h.
- Was able to trace another cause of the NaNs in audio to 2 uninitialized variables in SoundAttenuationSettings struct: OmniRadius and StereoSpread.
- Zak M suggested the change of the const ref position vector in ListenerPosition and the usage of GetSafeNormal() in Audio.cpp since the value returned by GetLocation() is a temporary and Normalize() is unsafe.
- I removed the flag for the XAudio2 call to compute doppler since we don't use that value and it could've been as source of more NaNs in X3DAudioCalculate
#codereview Zak.Middleton
#rb Zak.Middleton
Change 2765467 on 2015/11/13 by James.Golding
- Allow -ms option to work with 'stat dumphitches' for controlling min time logged
#rb gil.gribb
Change 2765746 on 2015/11/13 by Benn.Gallagher
Added buckets for update rate shift tags (for staggering anim updates)
#jira UE-23213
#rb Bruce.Nesbit
Change 2765747 on 2015/11/13 by Benn.Gallagher
Fixes for bone length calculation in anim dynamics chains.
#rb Bruce.Nesbit
Change 2765749 on 2015/11/13 by Benn.Gallagher
Removed allocations from local CS blends for skeletal controls.
#rb Bruce.Nesbit
Change 2765752 on 2015/11/13 by Benn.Gallagher
Lod mapping support for URO customization
#jira UE-23211
#rb Bruce.Nesbit
Change 2765965 on 2015/11/13 by Marc.Audy
Remove outdated code in LoadMap previously used for matching up downloaded packages from servers. These code paths no longer operate, but in the case where a PIE client was connecting to a non-PIE server (not really supported, but possible), it would cause the Editor Level package to be flagged as as PIE package and cause a crash on exit of PIE
#jira UE-21181
#rb Josh.Markiewicz
Change 2766071 on 2015/11/13 by Mieszko.Zielinski
Fixed dumb mistake in AEQSTestingPawn::PostLoad #UE4
the 'bTickDuringGame == bTickDuringGame' thing
#rb John.Abercrombie
Change 2766086 on 2015/11/13 by Mieszko.Zielinski
Exposing NavModifierComponent to ENGINE_API #UE4
#codereview Lukasz.Furman
Change 2766345 on 2015/11/13 by Mieszko.Zielinski
No longer compiling AISystem's creation out from client builds #UE4
Instead AISystem's instantiation on clients is configurable via UAISystemBase::bInstantiateAISystemOnClient config variable
Change 2766346 on 2015/11/13 by Mieszko.Zielinski
Improvements to EQS test scoring function preview #UE4
#rb Lukasz.Furman
Change 2766528 on 2015/11/13 by Stan.Melax
multiple materials/chunks on a single cloth sim mesh
This supposedly used to work in 4.7 but broke for 4.8
It looks like previous change 2493547 may have introduced the condition statement that makes multiple materials not include all of there verts.
Changing this to instead check for the bounds on the skinningmap instead of the NumRealSimVerts which doesn't look like it takes the offset into consideration.
jira:
#UE-23300
https://jira.ol.epicgames.net/browse/UE-23300
https://answers.unrealengine.com/questions/287833/apex-not-working-on-multiple-materials-since-48.html
Double tested code change with test asset from https://jira.ol.epicgames.net/browse/UE-10674
#rb Benn.Gallagher
Change 2766546 on 2015/11/13 by Marc.Audy
Throw warning for orphaned looping sounds caused by a looping sound node
Don't do somewhat expensive (due to weak pointer) orphaned sound checks in test or shipping
#rb Aaron.McLeran
Change 2766917 on 2015/11/14 by Jurre.deBaare
Fix UE4-23349 Simplygon doens't support sub 64 pixel textures
Change 2767742 on 2015/11/16 by Marc.Audy
Restructure SignificanceManager to store significance manager references in a FGCObject Module class instead of using a singleton.
Improve performance by eliminating StaticFindObjectFast calls in ::Get and force inlining Get calls
#rb Zak.Middleton, Rob.Manuszewski
Change 2767827 on 2015/11/16 by Zak.Middleton
#ue4 - Perf: avoid SmoothClientPosition() calls once the target mesh offset has been reached.
- New flag bNetworkSmoothingComplete indicates whether smoothing has reached the destination. This is set to false when a new network position is received.
- Also fixes trying to smooth rotation towards identity rotation before receiving network updates.
- Deprecated FNetworkPredictionData_Client_Character::CurrentSmoothTime in favor of saving last update time, to prevent needing to update time every tick (since we skip updates now).
#rb Dan.Youhon
Change 2768070 on 2015/11/16 by Marc.Audy
Change StaticDuplicateObject and DuplicateObject to take FName instead of char* (existing usages can automatically convert to FName so no backwards compatibility issues)
Fixup usages to avoid unnecessary string -> char* -> name conversions
Change AActor::CreateComponentFromTemplate to take an FName instead of FString, deprecated FString version
#rb Gil.Gribb
Change 2768121 on 2015/11/16 by Marc.Audy
Forceinline GetFName
Change 2768161 on 2015/11/16 by Aaron.McLeran
Checking occlusion back in
- Bug was due to improper interpolation of LPFFrequency values in audio volumes.
Change 2769428 on 2015/11/17 by Thomas.Sarkanen
Fixed backwards-compatibility issues with FExposedValueCopyRecord
Added PostSerialize function to patch up older data to the new format (copies properties->property FNames).
Made sure to zero FExposedValueCopyRecord in its constructor, prevents uninitialized variable issues when generating CRCs. This is necessary despite these members being UPROPERTYs because they are simply built on the stack then stuffed into the new CDO during compilation.
UE-23268 - EDITOR CRASH: Assertion failed: ((UObject*)ContainerPtr)->IsA((UClass*)GetOuter())
#rb James.Golding
#codereview Mike.Beach,Bob.Tellez
Change 2769488 on 2015/11/17 by Benn.Gallagher
DrawCanvas and debug string support for skeletal controls - accessed using "Skeletal Controls" option in Show->Display Info in Persona
#rb Martin.Wilson
Change 2769545 on 2015/11/17 by Benn.Gallagher
Added space conversion options to copy bone node.
#jira OR-9430
#rb Martin.Wilson
Change 2770228 on 2015/11/17 by Marc.Audy
Fix cause of assert firing when detaching if AttachTo(AttachParent) returns false
#rb Ori.Cohen
#jira UE-23366
Change 2770489 on 2015/11/17 by Marc.Audy
Make ::Serialize WITH_EDITORONLY_DATA since it did nothing otherwise
Change 2770761 on 2015/11/17 by Aaron.McLeran
Removing optimization disablement
- Forgot to remove these lines before checking in/testing.
Change 2771375 on 2015/11/18 by Thomas.Sarkanen
Added initialzation of internal state machine desc ptrs to (finally) remove random crashes when using sub-state machines
#rb Benn.Gallagher
Change 2771697 on 2015/11/18 by Jeff.Farris
Sensible defaults for APlayerController::ClientPlayCameraAnim and ClientPlayCameraShake
#rb marc.audy
Change 2771755 on 2015/11/18 by Marc.Audy
Put back in the recursion block for destroy actor
#rb James.Golding
Change 2772217 on 2015/11/18 by Marc.Audy
Update axis inversion to work the same way as sensitivity instead of old problematic way
Also change to use Reset instead of Empty(Array.Num())
#rb Jeff.Farris
Change 2772686 on 2015/11/18 by Aaron.McLeran
Fixing HRTF spatialization coordinate bug.
Don't need to convert to xaudio2 coordinates for HRTF spatialization
#rb chad.taylor
Change 2772766 on 2015/11/18 by Aaron.McLeran
Fixing HRTF spatialization with xaudio2 voice pools
- Issue was caused by 2 issues:
- effect chains weren't properly clearing their state between uses (SetEffectChain(nullptr) releases the effect for use with other voices)
- Not re-setting MaxEffectChainChannels = 0 in CreateSource() was causing re-used SoundSources to release their XAudio2 voices to the wrong pool.
#rb chad.taylor
Change 2773027 on 2015/11/19 by Thomas.Sarkanen
PR #1765: Git Plugin can find the git.exe binary installed on the Local AppData user directory (Contributed by SRombauts)
#rb Thomas.Sarkanen
Change 2773142 on 2015/11/19 by Benn.Gallagher
Optimized SafeSetCSBoneTransforms, no longer doing 2 iterations over the whole pose.
- Only iterating beyond the index of the first bone transform, cutting off all bones before
- No longer using a bone mask the size of the skeleton, just an array of interesting nodes
- No longer attempting to convert a transform if it isn't necessary (which was happening a lot)
#rb Laurent.Delayen
Change 2773212 on 2015/11/19 by Richard.Hinckley
#jira UEDOC-2685
Removing ugly comment. Not going to remove the node itself for backward compatibility.
Change 2773351 on 2015/11/19 by Zak.Middleton
#orion - Make sure we don't skip a final visual update when character mesh interpolation tries to stop smoothing once it reaches its destination. We keep setting bNetworkSmoothingComplete to false until the first visual update, at which point if it remains true we will stop getting updates.
#rb Dan.Youhon
Change 2773599 on 2015/11/19 by Marc.Audy
Fix shadow variable, initialization order, and incorrect placement of ENGINE_API that fails compiles on clang
#codereview Aaron.McLeran
Change 2773661 on 2015/11/19 by Richard.Hinckley
#jira UEDOC-2685
Following up by deprecating the CastToPlayerController function for 4.11.
Change 2774707 on 2015/11/19 by Stan.Melax
FCollisionQueryParams constructor API pitfall
Deprecating something that will call the unintended constructor if the programmer provides a string literal instead of explicitly creating an FName.
So this line of code:
FCollisionQueryParams Param(FName(TEXT("DragDropTrace")));
will invoke:
FCollisionQueryParams::FCollisionQueryParams(FName,bool=false,...)
But this line of code:
FCollisionQueryParams Param(TEXT("DragDropTrace"));
invokes:
FCollisionQueryParams::FCollisionQueryParams(bool)
Yes that actually happens, the string literal (the TEXT("whatever")) ends up specifies a bool parameter instead of a FName parameter. So the name is lost and a flag (that is usually set to false) is now set to true (since the string literal address is non-NULL). Yeah, that's could potentially be not what the programmer had intended.
It looks like this interface was introduced in CL 1792949
back in august 2013. Since its been a couple of years, we'll phase it out using the deprecation approach.
Making an API change would break things for existing projects.
If it had been a more recent change we could have probably just gone down to a single constructor right away.
Figured out that going one step further and removing bool param's default and adding a default constructor would minimize the number of places that will be hit with this deprecation. So, yes this is *increasing* the number of construtors temporarily, but this solution has minimal impact on the community. Later after other to-be-deprecated constructor gets removed, the two remaining can be combined into one with defaults for all parameters.
see also
https://udn.unrealengine.com/questions/269512/dangerous-fcollisionqueryparams-overloads.html
#codereview ori.cohen
[CL 2775460 by Marc Audy in Main branch]
2015-11-20 11:02:37 -05:00
float DistanceToAnchor = ( PreviousBoneTransform . GetTranslation ( ) - CurrentBoneTransform . GetTranslation ( ) ) . Size ( ) * 0.5f ;
2015-10-28 08:58:16 -04:00
if ( LocalJointOffset . SizeSquared ( ) < SMALL_NUMBER )
{
// No offset, just use the position between chain links as the offset
// This is likely to just look horrible, but at least the bodies will
// be placed correctly and not stack up at the top of the chain.
JointOffsets . Add ( PreviousAnchor - CurrentBoneTransform . GetTranslation ( ) ) ;
}
else
{
// Extend offset along chain.
JointOffsets . Add ( LocalJointOffset . GetSafeNormal ( ) * DistanceToAnchor ) ;
}
}
else
{
// No chain to worry about, just use the specified offset.
JointOffsets . Add ( LocalJointOffset ) ;
}
BoundBoneReferences . Add ( LinkBoneRef ) ;
FTransform BodyTransform = MeshBases . GetComponentSpaceTransform ( LinkBoneRef . GetCompactPoseIndex ( BoneContainer ) ) ;
BodyTransform . SetTranslation ( BodyTransform . GetTranslation ( ) + BodyTransform . GetRotation ( ) . RotateVector ( - LocalJointOffset ) ) ;
FAnimPhysLinkedBody NewChainBody ( BodyShapes , BodyTransform . GetTranslation ( ) , LinkBoneRef ) ;
2015-10-06 16:47:09 -04:00
FAnimPhysRigidBody & PhysicsBody = NewChainBody . RigidBody . PhysBody ;
2015-10-28 08:58:16 -04:00
PhysicsBody . Pose . Orientation = BodyTransform . GetRotation ( ) ;
2015-10-06 16:47:09 -04:00
PhysicsBody . PreviousOrientation = PhysicsBody . Pose . Orientation ;
PhysicsBody . NextOrientation = PhysicsBody . Pose . Orientation ;
2015-10-28 08:58:16 -04:00
PhysicsBody . CollisionType = CollisionType ;
switch ( PhysicsBody . CollisionType )
{
case AnimPhysCollisionType : : CustomSphere :
PhysicsBody . SphereCollisionRadius = SphereCollisionRadius ;
break ;
case AnimPhysCollisionType : : InnerSphere :
PhysicsBody . SphereCollisionRadius = BoxExtents . GetAbsMin ( ) / 2.0f ;
break ;
case AnimPhysCollisionType : : OuterSphere :
PhysicsBody . SphereCollisionRadius = BoxExtents . GetAbsMax ( ) / 2.0f ;
break ;
default :
break ;
}
2015-10-06 16:47:09 -04:00
if ( bOverrideLinearDamping )
{
PhysicsBody . bLinearDampingOverriden = true ;
PhysicsBody . LinearDamping = LinearDampingOverride ;
}
if ( bOverrideAngularDamping )
{
PhysicsBody . bAngularDampingOverriden = true ;
PhysicsBody . AngularDamping = AngularDampingOverride ;
}
PhysicsBody . GravityScale = GravityScale ;
2015-10-28 08:58:16 -04:00
// Link to parent
if ( Bodies . Num ( ) > 0 )
{
NewChainBody . ParentBody = & Bodies . Last ( ) . RigidBody ;
}
2015-10-06 16:47:09 -04:00
Bodies . Add ( NewChainBody ) ;
2015-10-28 08:58:16 -04:00
}
BaseBodyPtrs . Empty ( ) ;
for ( FAnimPhysLinkedBody & Body : Bodies )
{
BaseBodyPtrs . Add ( & Body . RigidBody . PhysBody ) ;
2015-10-06 16:47:09 -04:00
}
// Set up transient constraint data
const bool bXAxisLocked = ConstraintSetup . LinearXLimitType ! = AnimPhysLinearConstraintType : : Free & & ConstraintSetup . LinearAxesMin . X - ConstraintSetup . LinearAxesMax . X = = 0.0f ;
const bool bYAxisLocked = ConstraintSetup . LinearYLimitType ! = AnimPhysLinearConstraintType : : Free & & ConstraintSetup . LinearAxesMin . Y - ConstraintSetup . LinearAxesMax . Y = = 0.0f ;
const bool bZAxisLocked = ConstraintSetup . LinearZLimitType ! = AnimPhysLinearConstraintType : : Free & & ConstraintSetup . LinearAxesMin . Z - ConstraintSetup . LinearAxesMax . Z = = 0.0f ;
ConstraintSetup . bLinearFullyLocked = bXAxisLocked & & bYAxisLocked & & bZAxisLocked ;
2015-10-28 08:58:16 -04:00
// Cache physics settings to avoid accessing UPhysicsSettings continuously
if ( UPhysicsSettings * Settings = UPhysicsSettings : : Get ( ) )
{
MaxPhysicsDeltaTime = Settings - > MaxPhysicsDeltaTime ;
MaxSubstepDeltaTime = Settings - > MaxSubstepDeltaTime ;
MaxSubsteps = Settings - > MaxSubsteps ;
}
else
{
MaxPhysicsDeltaTime = ( 1.0f / 30.0f ) ;
MaxSubstepDeltaTime = ( 1.0f / 60.0f ) ;
MaxSubsteps = 4 ;
}
2015-10-06 16:47:09 -04:00
bRequiresInit = false ;
}
void FAnimNode_AnimDynamics : : TermPhysics ( )
{
Bodies . Empty ( ) ;
LinearLimits . Empty ( ) ;
AngularLimits . Empty ( ) ;
Springs . Empty ( ) ;
BoundBoneReferences . Empty ( ) ;
JointOffsets . Empty ( ) ;
}
2015-10-28 08:58:16 -04:00
void FAnimNode_AnimDynamics : : UpdateLimits ( USkeletalMeshComponent * SkelComp , FCSPose < FCompactPose > & MeshBases )
2015-10-06 16:47:09 -04:00
{
SCOPE_CYCLE_COUNTER ( STAT_AnimDynamicsLimitUpdate ) ;
// We're always going to use the same number so don't realloc
LinearLimits . Empty ( LinearLimits . Num ( ) ) ;
AngularLimits . Empty ( AngularLimits . Num ( ) ) ;
Springs . Empty ( Springs . Num ( ) ) ;
2015-10-28 08:58:16 -04:00
const FBoneContainer & BoneContainer = MeshBases . GetPose ( ) . GetBoneContainer ( ) ;
2015-10-06 16:47:09 -04:00
for ( int32 Idx = 0 ; Idx < Bodies . Num ( ) ; + + Idx )
{
2015-10-28 08:58:16 -04:00
const FBoneReference & CurrentBoneRef = BoundBoneReferences [ Idx ] ;
// If our bone isn't valid, move on
if ( ! CurrentBoneRef . IsValid ( BoneContainer ) )
{
continue ;
}
2015-10-06 16:47:09 -04:00
FAnimPhysLinkedBody & ChainBody = Bodies [ Idx ] ;
FAnimPhysRigidBody & RigidBody = Bodies [ Idx ] . RigidBody . PhysBody ;
FAnimPhysRigidBody * PrevBody = nullptr ;
if ( ChainBody . ParentBody )
{
PrevBody = & ChainBody . ParentBody - > PhysBody ;
}
// Get joint transform
2015-10-28 08:58:16 -04:00
FCompactPoseBoneIndex BoneIndex = CurrentBoneRef . GetCompactPoseIndex ( BoneContainer ) ;
2015-10-06 16:47:09 -04:00
FTransform BoundBoneTransform = MeshBases . GetComponentSpaceTransform ( BoneIndex ) ;
FTransform ShapeTransform = BoundBoneTransform ;
// Local offset to joint for Body1
FVector Body1JointOffset = LocalJointOffset ;
if ( PrevBody )
{
// Get the correct offset
Body1JointOffset = JointOffsets [ Idx ] ;
Copying //UE4/Dev-Framework to //UE4/Main @ 2775446
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2720537 on 2015/10/07 by Aaron.McLeran
Audio Optimization: Implementing an audio update delta time so audio isn't updated with every engine tick
Change 2746582 on 2015/10/29 by Aaron.McLeran
Implementing single ray-cast sound occlusion
- Fixing/Implementing sound occlusion using one ray cast
- Update rate of the ray cast is conifgurable by the user
- User can enabled/disable occlusion and set various properties of the occlusion at the audio component level
- Occlusion ray-casts are made at a slower rate than the audio engine is updated
- The following properties are supported:
* LowPassFilterFrequency (the LPF cutoff frequency of the per-voice filter to apply if a sound is occluded)
* OcclusionVolumeAttenuation (the volume attenuation to apply to sounds that are occluded)
* OcclusionInterpolationTime (how fast a sound moves from occluded to unoccluded... allows user-defined interpolation times, avoids fast parameter setting for smoother transitions)
- Fixed how low-pass filter frequency is applied on platforms that support it.
* Changed the older HighFrequencyGain parameter to a more understandable and correct LowPassFilterFrequency parameter
* Updated the parameter for the various other features that use per-voice LPF (e.g. audio volumes, distance-based filtering)
* Added backward-compatibility code to take old HighFrequencyGain params to new LowPassFilterFrequency params.
* At the lowest level, there is only one filter which is applied to a sound, but the parameter that has the lowest cutoff frequency is the one used
* Fixed how the parameter is applied at the lower-level in XAudio2 and CoreAudio. The old parameter was incorrectly applied.
* XAudio2 documentation on the low-pass-fitler frequency cutoff param is confirmed incorrect through testing.
#rb zak.middleton
Change 2765174 on 2015/11/12 by Aaron.McLeran
UE-23091 More fixage for NaN audio log spam
Last checkin for this (CL 2760896) was fixing a legit issue but there was still an issue that I was rarely catching during the FN gate encounter in AITestbed after about 5 min of gate defense.
To track down, I added a lot more logging and asserts on NaN numbers in the audio code, enabled ENABLE_NAN_DIAGNOSTIC in UnrealMathUtility.h.
- Was able to trace another cause of the NaNs in audio to 2 uninitialized variables in SoundAttenuationSettings struct: OmniRadius and StereoSpread.
- Zak M suggested the change of the const ref position vector in ListenerPosition and the usage of GetSafeNormal() in Audio.cpp since the value returned by GetLocation() is a temporary and Normalize() is unsafe.
- I removed the flag for the XAudio2 call to compute doppler since we don't use that value and it could've been as source of more NaNs in X3DAudioCalculate
#codereview Zak.Middleton
#rb Zak.Middleton
Change 2765467 on 2015/11/13 by James.Golding
- Allow -ms option to work with 'stat dumphitches' for controlling min time logged
#rb gil.gribb
Change 2765746 on 2015/11/13 by Benn.Gallagher
Added buckets for update rate shift tags (for staggering anim updates)
#jira UE-23213
#rb Bruce.Nesbit
Change 2765747 on 2015/11/13 by Benn.Gallagher
Fixes for bone length calculation in anim dynamics chains.
#rb Bruce.Nesbit
Change 2765749 on 2015/11/13 by Benn.Gallagher
Removed allocations from local CS blends for skeletal controls.
#rb Bruce.Nesbit
Change 2765752 on 2015/11/13 by Benn.Gallagher
Lod mapping support for URO customization
#jira UE-23211
#rb Bruce.Nesbit
Change 2765965 on 2015/11/13 by Marc.Audy
Remove outdated code in LoadMap previously used for matching up downloaded packages from servers. These code paths no longer operate, but in the case where a PIE client was connecting to a non-PIE server (not really supported, but possible), it would cause the Editor Level package to be flagged as as PIE package and cause a crash on exit of PIE
#jira UE-21181
#rb Josh.Markiewicz
Change 2766071 on 2015/11/13 by Mieszko.Zielinski
Fixed dumb mistake in AEQSTestingPawn::PostLoad #UE4
the 'bTickDuringGame == bTickDuringGame' thing
#rb John.Abercrombie
Change 2766086 on 2015/11/13 by Mieszko.Zielinski
Exposing NavModifierComponent to ENGINE_API #UE4
#codereview Lukasz.Furman
Change 2766345 on 2015/11/13 by Mieszko.Zielinski
No longer compiling AISystem's creation out from client builds #UE4
Instead AISystem's instantiation on clients is configurable via UAISystemBase::bInstantiateAISystemOnClient config variable
Change 2766346 on 2015/11/13 by Mieszko.Zielinski
Improvements to EQS test scoring function preview #UE4
#rb Lukasz.Furman
Change 2766528 on 2015/11/13 by Stan.Melax
multiple materials/chunks on a single cloth sim mesh
This supposedly used to work in 4.7 but broke for 4.8
It looks like previous change 2493547 may have introduced the condition statement that makes multiple materials not include all of there verts.
Changing this to instead check for the bounds on the skinningmap instead of the NumRealSimVerts which doesn't look like it takes the offset into consideration.
jira:
#UE-23300
https://jira.ol.epicgames.net/browse/UE-23300
https://answers.unrealengine.com/questions/287833/apex-not-working-on-multiple-materials-since-48.html
Double tested code change with test asset from https://jira.ol.epicgames.net/browse/UE-10674
#rb Benn.Gallagher
Change 2766546 on 2015/11/13 by Marc.Audy
Throw warning for orphaned looping sounds caused by a looping sound node
Don't do somewhat expensive (due to weak pointer) orphaned sound checks in test or shipping
#rb Aaron.McLeran
Change 2766917 on 2015/11/14 by Jurre.deBaare
Fix UE4-23349 Simplygon doens't support sub 64 pixel textures
Change 2767742 on 2015/11/16 by Marc.Audy
Restructure SignificanceManager to store significance manager references in a FGCObject Module class instead of using a singleton.
Improve performance by eliminating StaticFindObjectFast calls in ::Get and force inlining Get calls
#rb Zak.Middleton, Rob.Manuszewski
Change 2767827 on 2015/11/16 by Zak.Middleton
#ue4 - Perf: avoid SmoothClientPosition() calls once the target mesh offset has been reached.
- New flag bNetworkSmoothingComplete indicates whether smoothing has reached the destination. This is set to false when a new network position is received.
- Also fixes trying to smooth rotation towards identity rotation before receiving network updates.
- Deprecated FNetworkPredictionData_Client_Character::CurrentSmoothTime in favor of saving last update time, to prevent needing to update time every tick (since we skip updates now).
#rb Dan.Youhon
Change 2768070 on 2015/11/16 by Marc.Audy
Change StaticDuplicateObject and DuplicateObject to take FName instead of char* (existing usages can automatically convert to FName so no backwards compatibility issues)
Fixup usages to avoid unnecessary string -> char* -> name conversions
Change AActor::CreateComponentFromTemplate to take an FName instead of FString, deprecated FString version
#rb Gil.Gribb
Change 2768121 on 2015/11/16 by Marc.Audy
Forceinline GetFName
Change 2768161 on 2015/11/16 by Aaron.McLeran
Checking occlusion back in
- Bug was due to improper interpolation of LPFFrequency values in audio volumes.
Change 2769428 on 2015/11/17 by Thomas.Sarkanen
Fixed backwards-compatibility issues with FExposedValueCopyRecord
Added PostSerialize function to patch up older data to the new format (copies properties->property FNames).
Made sure to zero FExposedValueCopyRecord in its constructor, prevents uninitialized variable issues when generating CRCs. This is necessary despite these members being UPROPERTYs because they are simply built on the stack then stuffed into the new CDO during compilation.
UE-23268 - EDITOR CRASH: Assertion failed: ((UObject*)ContainerPtr)->IsA((UClass*)GetOuter())
#rb James.Golding
#codereview Mike.Beach,Bob.Tellez
Change 2769488 on 2015/11/17 by Benn.Gallagher
DrawCanvas and debug string support for skeletal controls - accessed using "Skeletal Controls" option in Show->Display Info in Persona
#rb Martin.Wilson
Change 2769545 on 2015/11/17 by Benn.Gallagher
Added space conversion options to copy bone node.
#jira OR-9430
#rb Martin.Wilson
Change 2770228 on 2015/11/17 by Marc.Audy
Fix cause of assert firing when detaching if AttachTo(AttachParent) returns false
#rb Ori.Cohen
#jira UE-23366
Change 2770489 on 2015/11/17 by Marc.Audy
Make ::Serialize WITH_EDITORONLY_DATA since it did nothing otherwise
Change 2770761 on 2015/11/17 by Aaron.McLeran
Removing optimization disablement
- Forgot to remove these lines before checking in/testing.
Change 2771375 on 2015/11/18 by Thomas.Sarkanen
Added initialzation of internal state machine desc ptrs to (finally) remove random crashes when using sub-state machines
#rb Benn.Gallagher
Change 2771697 on 2015/11/18 by Jeff.Farris
Sensible defaults for APlayerController::ClientPlayCameraAnim and ClientPlayCameraShake
#rb marc.audy
Change 2771755 on 2015/11/18 by Marc.Audy
Put back in the recursion block for destroy actor
#rb James.Golding
Change 2772217 on 2015/11/18 by Marc.Audy
Update axis inversion to work the same way as sensitivity instead of old problematic way
Also change to use Reset instead of Empty(Array.Num())
#rb Jeff.Farris
Change 2772686 on 2015/11/18 by Aaron.McLeran
Fixing HRTF spatialization coordinate bug.
Don't need to convert to xaudio2 coordinates for HRTF spatialization
#rb chad.taylor
Change 2772766 on 2015/11/18 by Aaron.McLeran
Fixing HRTF spatialization with xaudio2 voice pools
- Issue was caused by 2 issues:
- effect chains weren't properly clearing their state between uses (SetEffectChain(nullptr) releases the effect for use with other voices)
- Not re-setting MaxEffectChainChannels = 0 in CreateSource() was causing re-used SoundSources to release their XAudio2 voices to the wrong pool.
#rb chad.taylor
Change 2773027 on 2015/11/19 by Thomas.Sarkanen
PR #1765: Git Plugin can find the git.exe binary installed on the Local AppData user directory (Contributed by SRombauts)
#rb Thomas.Sarkanen
Change 2773142 on 2015/11/19 by Benn.Gallagher
Optimized SafeSetCSBoneTransforms, no longer doing 2 iterations over the whole pose.
- Only iterating beyond the index of the first bone transform, cutting off all bones before
- No longer using a bone mask the size of the skeleton, just an array of interesting nodes
- No longer attempting to convert a transform if it isn't necessary (which was happening a lot)
#rb Laurent.Delayen
Change 2773212 on 2015/11/19 by Richard.Hinckley
#jira UEDOC-2685
Removing ugly comment. Not going to remove the node itself for backward compatibility.
Change 2773351 on 2015/11/19 by Zak.Middleton
#orion - Make sure we don't skip a final visual update when character mesh interpolation tries to stop smoothing once it reaches its destination. We keep setting bNetworkSmoothingComplete to false until the first visual update, at which point if it remains true we will stop getting updates.
#rb Dan.Youhon
Change 2773599 on 2015/11/19 by Marc.Audy
Fix shadow variable, initialization order, and incorrect placement of ENGINE_API that fails compiles on clang
#codereview Aaron.McLeran
Change 2773661 on 2015/11/19 by Richard.Hinckley
#jira UEDOC-2685
Following up by deprecating the CastToPlayerController function for 4.11.
Change 2774707 on 2015/11/19 by Stan.Melax
FCollisionQueryParams constructor API pitfall
Deprecating something that will call the unintended constructor if the programmer provides a string literal instead of explicitly creating an FName.
So this line of code:
FCollisionQueryParams Param(FName(TEXT("DragDropTrace")));
will invoke:
FCollisionQueryParams::FCollisionQueryParams(FName,bool=false,...)
But this line of code:
FCollisionQueryParams Param(TEXT("DragDropTrace"));
invokes:
FCollisionQueryParams::FCollisionQueryParams(bool)
Yes that actually happens, the string literal (the TEXT("whatever")) ends up specifies a bool parameter instead of a FName parameter. So the name is lost and a flag (that is usually set to false) is now set to true (since the string literal address is non-NULL). Yeah, that's could potentially be not what the programmer had intended.
It looks like this interface was introduced in CL 1792949
back in august 2013. Since its been a couple of years, we'll phase it out using the deprecation approach.
Making an API change would break things for existing projects.
If it had been a more recent change we could have probably just gone down to a single constructor right away.
Figured out that going one step further and removing bool param's default and adding a default constructor would minimize the number of places that will be hit with this deprecation. So, yes this is *increasing* the number of construtors temporarily, but this solution has minimal impact on the community. Later after other to-be-deprecated constructor gets removed, the two remaining can be combined into one with defaults for all parameters.
see also
https://udn.unrealengine.com/questions/269512/dangerous-fcollisionqueryparams-overloads.html
#codereview ori.cohen
[CL 2775460 by Marc Audy in Main branch]
2015-11-20 11:02:37 -05:00
// Modify the shape transform to be correct in Body0 frame
ShapeTransform = FTransform ( FQuat : : Identity , - Body1JointOffset ) ;
2015-10-06 16:47:09 -04:00
}
if ( ConstraintSetup . bLinearFullyLocked )
{
// Rather than calculate prismatic limits, just lock the transform (1 limit instead of 6)
FAnimPhys : : ConstrainPositionNailed ( NextTimeStep , LinearLimits , PrevBody , ShapeTransform . GetTranslation ( ) , & RigidBody , Body1JointOffset ) ;
}
else
{
if ( ConstraintSetup . LinearXLimitType ! = AnimPhysLinearConstraintType : : Free )
{
FAnimPhys : : ConstrainAlongDirection ( NextTimeStep , LinearLimits , PrevBody , ShapeTransform . GetTranslation ( ) , & RigidBody , Body1JointOffset , ShapeTransform . GetRotation ( ) . GetAxisX ( ) , FVector2D ( ConstraintSetup . LinearAxesMin . X , ConstraintSetup . LinearAxesMax . X ) ) ;
}
if ( ConstraintSetup . LinearYLimitType ! = AnimPhysLinearConstraintType : : Free )
{
FAnimPhys : : ConstrainAlongDirection ( NextTimeStep , LinearLimits , PrevBody , ShapeTransform . GetTranslation ( ) , & RigidBody , Body1JointOffset , ShapeTransform . GetRotation ( ) . GetAxisY ( ) , FVector2D ( ConstraintSetup . LinearAxesMin . Y , ConstraintSetup . LinearAxesMax . Y ) ) ;
}
if ( ConstraintSetup . LinearZLimitType ! = AnimPhysLinearConstraintType : : Free )
{
FAnimPhys : : ConstrainAlongDirection ( NextTimeStep , LinearLimits , PrevBody , ShapeTransform . GetTranslation ( ) , & RigidBody , Body1JointOffset , ShapeTransform . GetRotation ( ) . GetAxisZ ( ) , FVector2D ( ConstraintSetup . LinearAxesMin . Z , ConstraintSetup . LinearAxesMax . Z ) ) ;
}
}
if ( ConstraintSetup . AngularConstraintType = = AnimPhysAngularConstraintType : : Angular )
{
# if WITH_EDITOR
// Check the ranges are valid when running in the editor, log if something is wrong
if ( ConstraintSetup . AngularLimitsMin . X > ConstraintSetup . AngularLimitsMax . X | |
ConstraintSetup . AngularLimitsMin . Y > ConstraintSetup . AngularLimitsMax . Y | |
ConstraintSetup . AngularLimitsMin . Z > ConstraintSetup . AngularLimitsMax . Z )
{
UE_LOG ( LogAnimation , Warning , TEXT ( " AnimDynamics: Min/Max angular limits for bone %s incorrect, at least one min axis value is greater than the corresponding max. " ) , * BoundBone . BoneName . ToString ( ) ) ;
}
# endif
// Add angular limits. any limit with 360+ degree range is ignored and left free.
FAnimPhys : : ConstrainAngularRange ( NextTimeStep , AngularLimits , PrevBody , & RigidBody , ShapeTransform . GetRotation ( ) , ConstraintSetup . TwistAxis , ConstraintSetup . AngularLimitsMin , ConstraintSetup . AngularLimitsMax ) ;
}
else
{
FAnimPhys : : ConstrainConeAngle ( NextTimeStep , AngularLimits , PrevBody , BoundBoneTransform . GetRotation ( ) . GetAxisX ( ) , & RigidBody , FVector ( 1.0f , 0.0f , 0.0f ) , ConstraintSetup . ConeAngle ) ;
}
2015-10-28 08:58:16 -04:00
if ( PlanarLimits . Num ( ) > 0 )
{
for ( FAnimPhysPlanarLimit & PlanarLimit : PlanarLimits )
{
FTransform LimitPlaneTransform = PlanarLimit . PlaneTransform ;
if ( PlanarLimit . DrivingBone . IsValid ( BoneContainer ) )
{
FCompactPoseBoneIndex DrivingBoneIndex = PlanarLimit . DrivingBone . GetCompactPoseIndex ( BoneContainer ) ;
LimitPlaneTransform * = MeshBases . GetComponentSpaceTransform ( DrivingBoneIndex ) ; // * LimitPlaneTransform;
}
FAnimPhys : : ConstrainPlanar ( NextTimeStep , LinearLimits , & RigidBody , LimitPlaneTransform ) ;
}
}
2015-10-06 16:47:09 -04:00
// Add spring if we need spring forces
if ( bAngularSpring | | bLinearSpring )
{
FAnimPhys : : CreateSpring ( Springs , PrevBody , ShapeTransform . GetTranslation ( ) , & RigidBody , FVector : : ZeroVector ) ;
FAnimPhysSpring & NewSpring = Springs . Last ( ) ;
NewSpring . SpringConstantLinear = LinearSpringConstant ;
NewSpring . SpringConstantAngular = AngularSpringConstant ;
NewSpring . AngularTarget = ConstraintSetup . AngularTarget . GetSafeNormal ( ) ;
NewSpring . AngularTargetAxis = ConstraintSetup . AngularTargetAxis ;
NewSpring . TargetOrientationOffset = ShapeTransform . GetRotation ( ) ;
NewSpring . bApplyAngular = bAngularSpring ;
NewSpring . bApplyLinear = bLinearSpring ;
}
}
}
Copying //UE4/Dev-Framework to Dev-Main (//UE4/Dev-Main)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2720406 on 2015/10/07 by Aaron.McLeran
Audio optimization
Don't search for nearest listener if there's only 1 listener.
Change 2720411 on 2015/10/07 by Aaron.McLeran
Fixing HRTF spatialization code with recent changes to stereo spatialization.
HRTF emitter posiition doesn't need to be converted to XAudio2 coordinates.
Change 2723829 on 2015/10/09 by Mieszko.Zielinski
Fixed NavigationSystem trying to set label of newly spawned navigation data #UE4
UE-21880
Change 2723873 on 2015/10/09 by Mieszko.Zielinski
Fixed a bug in FNavAgentProperties::IsEquivalent resulting in failing the test for FNavAgentProperties instances having default AgentStepHeight value (-1) #UE4
UE-21977
Change 2724834 on 2015/10/12 by Ori.Cohen
PR #1634: Add PxVehicleDriveNW support to PhysXVehicleManager.cpp (Contributed by zeduk)
Change 2724850 on 2015/10/12 by Marc.Audy
Fix sound not restarting in matinee preview when jumping back along timeline after reaching end
#codereview Nick.Darnell
Change 2726499 on 2015/10/13 by Ori.Cohen
Fix edge case where sphyl length and radius are 0 and they are not properly clamped to 0.1
Change 2726689 on 2015/10/13 by Marc.Audy
Make UPackage::PackageFlags private
Add debugging for UE-21181 to try and track down when EditorWorld's PackageFlags are getting flagged as PlayInEditor
#codereview Mike.Fricker
Change 2726862 on 2015/10/13 by Lukasz.Furman
removed unused code from DetourNavMeshQuery
#ue4 UE-21988
Change 2726888 on 2015/10/13 by Lukasz.Furman
fixed observer abort: both mode in behavior tree's cone check decorator
#ue4 UE-19375
Change 2726913 on 2015/10/13 by Lukasz.Furman
navmesh raycast will use nearest poly containing ray origin instead of just closest one
#ue4 UE-19334
Change 2726920 on 2015/10/13 by Marc.Audy
Re-unify ULevelStreaming::GetWorldAssetPackageName and GetWorldAssetPackageFName
#codereview Dmitriy.Dyomin, Bob.Tellez
Change 2726931 on 2015/10/13 by Lukasz.Furman
fixed missing Tick event in aborting behavior tree tasks from abandoned subtree
#ue4 UE-21777
Change 2728093 on 2015/10/14 by Ori.Cohen
Fix edge case of sphyl scale take two. The previous approach did double scaling
Change 2728577 on 2015/10/14 by Mieszko.Zielinski
Improved navmesh labeling condition #UE4
Change suggested by github user
#rb Lukasz.Furman
Change 2728587 on 2015/10/14 by Lukasz.Furman
fixed crowd simulation for auto possessed pawns placed on level
#ue4
#rb Mieszko.Zielinski
Change 2728629 on 2015/10/14 by Lukasz.Furman
fixed influence of navmesh edges on crowd simulation near end of path
#ue4 UE-21380
#rb Mieszko.Zielinski
Change 2728678 on 2015/10/14 by Lukasz.Furman
added Z check to detour's crowd avoidance segment gathering
#ue4 UE-20889
#rb Mieszko.Zielinski
Change 2728745 on 2015/10/14 by Lukasz.Furman
fixed copy&paste operation in behavior tree's composite decorators subgraphs
#ue4 UE-18740
Change 2729276 on 2015/10/14 by Stan.Melax
ensure all actors get recreated with new collision shape specification.
this wasn't being done for a couple of editing methods.
todo: this should be merged into 4.10
#UE-20961
#rb ori.cohen
Change 2730709 on 2015/10/15 by Marc.Audy
Prevent memory corruption when an invalid controller ID is passed in to the forcefeedback channel functions
#rb Lina.Halper
Change 2733590 on 2015/10/19 by Benn.Gallagher
Fixed various crashes when using undo and redo while manipulating state machines UE 22088
Change 2735143 on 2015/10/20 by Lukasz.Furman
clearing behavior tree debugger's state when displayed subtree becomes inactive
#ue4
#rb Mieszko.Zielinski
Change 2735144 on 2015/10/20 by Lukasz.Furman
rebuilding behavior tree graph node order when node is being moved
#ue4
#rb Mieszko.Zielinski
Change 2735403 on 2015/10/20 by sebastian.kowalczyk
Integrated fix for issue UE-18594 "Gameplay Debugger is hijacking the Canvas" issue from 4.10 (2735391). Extended previous fix to care about OSX users - it's possible to configure shortcuts in engine config file now (little different ones for osx platform).
Change 2736406 on 2015/10/21 by sebastian.kowalczyk
Added new GameplayDebugger as a plugin. Old gameplay debugger is still here to keep backward compatibility but it's deprecated now. Current projects should be moved to use new plugin soon.
Change 2736436 on 2015/10/21 by sebastian.kowalczyk
Fixed crash in gameplay debugger with player set as debug target.
Change 2736437 on 2015/10/21 by sebastian.kowalczyk
Added visual indicator around selected pawn to fix FORT-10273 issue. (FN is not using new gd plugin yet).
Change 2736489 on 2015/10/21 by sebastian.kowalczyk
Hide internal and debug hud classes from drop down lists.
Change 2736504 on 2015/10/21 by sebastian.kowalczyk
Fix for UE-18548 "EnableGDT does not work correctly in PIE".
Change 2736529 on 2015/10/21 by sebastian.kowalczyk
Fixed UE-18548 "EnableGDT does not work correctly in PIE"
Change 2736588 on 2015/10/21 by sebastian.kowalczyk
Removed old log visualizer classes.
Change 2736700 on 2015/10/21 by sebastian.kowalczyk
Fixed UE-19256 "Perception debug data doesn't get replicated by Gameplay Debuger" for old gameplay debugger module.
Change 2737180 on 2015/10/21 by Zak.Middleton
#ue4 - Fix UPrimitiveComponent::GetCollisionShape not correctly enforcing bounds limits.
#rb Aaron.Mcleran
#jira UE-22436
Change 2738084 on 2015/10/22 by sebastian.kowalczyk
Better indication of selected pawn for Gameplay Debugger.
Change 2738413 on 2015/10/22 by Marc.Audy
Disable duplication of worlds/maps via the content browser
#jira UE-22200
#rb James.Golding
Change 2739743 on 2015/10/23 by bruce.nesbit
UE-18707 - Issue with drawing material triangle on canvas #1387
Added DrawTriangleUsingVertexColor
Change 2739751 on 2015/10/23 by bruce.nesbit
Revised bShowDebugForReticleTarget should not be static #1539
Change 2739788 on 2015/10/23 by bruce.nesbit
Revised the 2 functions that used FTriangleRenderer::DrawTriangle to use FTriangleRenderer::DrawTriangleUsingVertexColor
Fixed compile error
Change 2739870 on 2015/10/23 by Marc.Audy
Avoid issues while detaching child components if OnAttachmentChange were to remove a sibling component itself.
#jira UE-22362
#rb Zak.Middleton
Change 2739882 on 2015/10/23 by sebastian.kowalczyk
Fix for UE-20901 "VisualLog redirections are broken after PIE finishes" issue.
Change 2740140 on 2015/10/23 by Marc.Audy
Ensure that components reregister tick functions after seamless travel
#jira UE-20892
#rb Zak.Middleton
Change 2740614 on 2015/10/23 by Ori.Cohen
Fix linker issues for people wanting to use physics lock lambdas
Change 2740674 on 2015/10/23 by Aaron.McLeran
Sound Focus Feature
Added new parameters to SoundAttenuation settings to allow audio to change behavior based on its angle to the listener
- Define the min/max azimuth angle to establish in-focus and non-focus regions
- Can scale the priority of a sound based on focus angle
- Can attenuate the volume of a sound based on focus angle
- Can scale the listener-emitter distance based on focus angle
- Distance scale is applied when determining max audible distance for USoundBase
- Can opt-out of focus effects for a sound at the USoundBase level
#rb Ryan.Vance
Change 2741542 on 2015/10/26 by Lukasz.Furman
lowered min value clamping in navigation filter properties
#ue4
#rb Mieszko.Zielinski
Change 2743227 on 2015/10/27 by Marc.Audy
Make ASceneCaptureCube subclassable outside of Engine module
#jira UE-22609
Make USceneCaptureComponentCube::UpdateContent callable outside of Engine module
#jira UE-22610
#rb Jeff.Farris
Change 2743255 on 2015/10/27 by Marc.Audy
Wrap FActorSpawnParameters class with deprecation warning disable pragma instead of hand implementing copy constructor
#rb Jeff.Farris
Change 2743729 on 2015/10/27 by Ori.Cohen
Fix case where we spawn and adjust location which gives us implicit velocity.
#codereview Stan.Melax
Change 2746135 on 2015/10/29 by sebastian.kowalczyk
Fixed UE-21668 "Saving log filters selected in LogVisualizer causes insane ini file sizes! And doesn't really work."
Change 2746437 on 2015/10/29 by Lukasz.Furman
pass on verifying behavior tree stack before accessing its elements
#ue4
#rb Mieszko.Zielinski
Change 2748028 on 2015/10/30 by sebastian.kowalczyk
Changed GameplayDebugger's console variable from gd.EQSOnHUD to ai.gd.EQSOnHUD" after suggestion with MieszkoZ.
Change 2748184 on 2015/10/30 by Aaron.McLeran
UE-22693 Fix for streaming bug
- 3rd decoded buffer in initial 3 buffers was not getting submitted to xaudio2 voice resulting in garbled/skipped audio.
- Wasn't able to repro the 'cannot read chunk' part of the bug
#rb ryan.vance
Change 2749255 on 2015/10/31 by sebastian.kowalczyk
Fixed ai.gd.EQSOnHUD console variable after rename from gd.EQSOnHUD.
Change 2749276 on 2015/10/31 by sebastian.kowalczyk
Added switch to toggle highlight of selected actor to GameplayDebugger.
Change 2749318 on 2015/10/31 by sebastian.kowalczyk
New Gameplay Debugger plugin can be used with old module simultaneously. It's best to configure different keyboard binding for plugin when using old module (it can be set in project settings, for new gameplay debugger plugin - when activated for project).
Change 2749337 on 2015/10/31 by sebastian.kowalczyk
Fixed GameplayDebugger compilation in shipping/test builds.
Change 2749376 on 2015/10/31 by sebastian.kowalczyk
Small clean-up in gameplay debugger class for BT.
Change 2749931 on 2015/11/02 by James.Golding
Add stats to ProcMeshComp
Change 2749932 on 2015/11/02 by James.Golding
Remove PhysicsThrusterComponent.h from Engine.h
Change 2749960 on 2015/11/02 by James.Golding
- Fix PS4 compile errors in ActiveSound.cpp
- Constructor order of FActiveSound
- Shadowed AudioComponent var in CheckOcclusion
#RB thomas.sarkanen
#codereview aaron.mcleran
Change 2749961 on 2015/11/02 by James.Golding
Fix PS4 compile errors in GameplayDebuggerBaseObject.cpp
- Shadowed DefaultContext function param, now just Context, which matches declaration
#RB thomas.sarkanen
#codereview sebastian.kowalczyk
Change 2750026 on 2015/11/02 by Thomas.Sarkanen
Anim Multithreading: thread-safety refactor
Segregated access to various parts of anim update data by spitting off a new proxy class (FAnimInstanceProxy) containing all data accessed in Update() and Evaluate() passes. Gated access to the proxy data on the game thread in a number of ways:
- Explicit access via GetValueOnGameThread() - this blocks on any existing task, completes and then allows control to return to the accessing function. This allows stuff like Blueprints to continue to operate as normal.
- Explicit access via GetValueOnAnyThread() - this ensures that in the limited set of circumstances we need this (Blueprint pure functions mostly) that conditions are met about concurrent access.
- Deprecating many APIs on UAnimInstance that should not be used (and in fact are not used at present, happily).
Derived classes of UAnimInstance can override the creation of the proxy class to create their own type. We do this for UAnimSingleNodeInstance etc.
Any API deprecation should continue to function - no functions have been removed yet. The only things that are not backwards-compatible are direct access to some public member variables for which there is no way to support (e.g. via references, for example UngroupedActivePlayerArrays).
Some APIs have been changed to more specifically represent the dependencies involved. For example TickAssetPlayerInstance() used to take a UAnimInstance*, only to use it to simply queue notifies. This has been deprecated and replaced with a new FNotifyQueue API. FNotifyQueue also uses a thread-safe FRandomStream instead of FMath::Rand.
Many changes are due to substituting accessor functions for direct variable access.
Removed 'service' tick group as we no longer need to segregate the running of our parallel update.
Anim nodes that need to do some game thread-side update should register for a pre-update callback delegate in the proxy. See FAnimNode_AnimDynamics for an example of this.
Moved UpdateActiveVertexAnims into FAnimRuntime so I can subsume some of the code that was in USkeletalMeshComponent::EvaluateAnimation into UAnimInstance (and hence keep the proxy access private).
#rb Martin.Wilson,Lina.Halper
#codereview Michael.Noland
Change 2750077 on 2015/11/02 by Marc.Audy
Expose UInputComponent::BindAction that supports WithKey delegate signature
Change 2751767 on 2015/11/03 by Thomas.Sarkanen
Added extra support to Anim Blueprint 'fast-path'
Added support for negated bools (value gets negated during copy).
Added support for copying from struct members (via break struct) and split struct pins.
Removed potentially troublesome references to BP-constructed UProperties, replacing them with the property FName. This adds some extra Initialize() overhead, but prevents various crash-on load issues (one when generating the class CRC). Added guard to prevent multiple initialization to save this more expensive work being done more often.
#rb Martin.Wilson
Change 2752158 on 2015/11/03 by Jeff.Farris
Fixed UGameplayStatics::SpawnEmitterAttached() to register the ParticleSystemComponent after it spawns.
#rb marc.audy
Change 2752159 on 2015/11/03 by Jeff.Farris
Improvements to camera lens effects to (EmitterCameraLensEffectBase)
- can now specify a transform to align the emitter with the camera
- exposed several key parameters to Blueprints
- ENGINE_API now applies to the entire class
#rb marc.audy
Change 2753454 on 2015/11/04 by Thomas.Sarkanen
Fixup deprecation warnings fallout from multithreaded update changes.
Fixed up use of AnimInstance in Vicon plugin.
Fixed up use of AnimInstance in slope warping node.
Un-deprecated some APIs to become warning free (these APIs are safe to call but just a 'bad idea if you want to do it right').
Also an extra API to allow for smoother transition: Allow custom allocation/deallocation (including using a proxy member struct) by providing an override point for proxy destruction.
#rb Martin.Wilson
Change 2754099 on 2015/11/04 by Ori.Cohen
Fix for task threads dropping stats (from Gil)
#rb Gil.Gribb
Change 2754449 on 2015/11/04 by Marc.Audy
Ensure that components created from an Actor's blueprint BeginPlay implementation get BeginPlay called on them and register their component ticks
#jira UE-20853
Reorganize some booleans to get better bit packing
#rb Jeff.Farris
#codereview Mieszko.Zielinski
Change 2754573 on 2015/11/04 by Aaron.McLeran
Fixing audio component PostLoad code to not set all LowPassFilterFrequency values to 0.0f
Change 2755345 on 2015/11/05 by Thomas.Sarkanen
Added deprecated constructors for various animation contexts
Allows existing code to compile if it creates its own contexts from UAnimInstance.
#rb James.Golding
Change 2755348 on 2015/11/05 by James.Golding
Add BP-exposed SetBoundsScale function to PrimitiveComponent
#RB thomas.sarkanen
Change 2755437 on 2015/11/05 by Marc.Audy
Fix compile errors
#codereview Thomas.Sarkanen, Mieszko.Zielinski, Aaron.McLeran
Change 2755982 on 2015/11/05 by Marc.Audy
Move HeaderParse changes for deprecation macro from Core
Fix world settings warning
Change 2756028 on 2015/11/05 by Marc.Audy
Fix shadow variable issue
Change 2756090 on 2015/11/05 by Ori.Cohen
Improve budget tool so that task threads are computed automatically.
#rb Gil.Gribb
Change 2756120 on 2015/11/05 by Mieszko.Zielinski
Fixed AIController::MoveTo not using DefaultQueryExtent of its navigation data #UE4
#rb Lukasz.Furman
Change 2756243 on 2015/11/05 by Mieszko.Zielinski
Fixed AI perception sight's "auto-visibility" mechanism totally skipping distance and vision cone checks #UE4
The old way was resulting in false positives when for example observer teleported somewhere far
#rb Lukasz.Furman
#codereview John.Abercrombie
Change 2756280 on 2015/11/05 by Mieszko.Zielinski
Minor VLog code cleanup and dumb-fixing visual logger accessing timer manager off of game thread #UE4
#rb Lukasz.Furman
Change 2756500 on 2015/11/05 by Mieszko.Zielinski
Added sanity-checking to BlueprintNodeHelpers::HasBlueprintFunction and cleaned up its usage #UE4
Also, refactored its parameters into references over pointers.
#rb Lukasz.Furman
Change 2757041 on 2015/11/06 by Thomas.Sarkanen
Removed check() in UAnimInstance::GetProxyOnAnyThread()
The check was no longer needed as if we are on the game thread we block until tasks are completed below, and if we are on any other thread we are 'safe' anyway.
#rb James.Golding
Change 2757207 on 2015/11/06 by Ori.Cohen
Fix incorrect root body cache which causes a single frame "freak out" when simulating physics from an animation
#rb Lina.Halper
Change 2757238 on 2015/11/06 by Marc.Audy
Force compiler generated functions to be generated for FHierarchicalSimplification in WorldSettings.h so that they are generated while the deprecation warnings are disabled.
#rb Mike.Fricker
Change 2757284 on 2015/11/06 by Stan.Melax
tapered capsule drawing
cloth collision happens with spheres and for the hull or tapered capsule goemetry between any specified pair of spheres.
(this was already code reviewed before, but missed the check-in window before streamtime)
#rb ori.cohen
Change 2757743 on 2015/11/06 by Lukasz.Furman
fixed node memory allocations for injected behavior tree decorators
#ue4 UE-22783
#rb Mieszko.Zielinski
Change 2757772 on 2015/11/06 by Lukasz.Furman
added setters for crowd avoidance
#ue4 UE-22785
#rb Mieszko.Zielinski
Change 2758422 on 2015/11/07 by Lina.Halper
Potential fix for invalid root bone index input
#jira :/UE-23086
#code review: Ori.Cohen
Change 2758429 on 2015/11/07 by Mieszko.Zielinski
Reimplemented a fix for AI Sight's "auto seeing" mechanics in a more flexible way #UE4
#jira UE-23089
Change 2758571 on 2015/11/08 by Mieszko.Zielinski
Modified ensure condition in UAIPerceptionComponent::OnRegister so it doesn't go off when BP does it's magic when components are being added to a BP actor class #UE4
#jira UE-23080
Change 2758821 on 2015/11/09 by Thomas.Sarkanen
Fixed animations no longer playing when using a dedicated server.
Uses correct logic to determine whether we are running as a server or not.
#rb Martin.Wilson
Change 2758920 on 2015/11/09 by Marc.Audy
Don't dereference weak object pointers repeatedly in FBoneContainer::Initialize
#rb Lina.Halper
Change 2758944 on 2015/11/09 by Ori.Cohen
Fix crash when stats are only on one thread and budget mode is used
Change 2758967 on 2015/11/09 by Benn.Gallagher
Fix for crash undoing notify socket changes in Persona, needed to recache the notify track data after the transaction had reserialized the sequence.
#jira UE-22963
Change 2758973 on 2015/11/09 by Benn.Gallagher
Added new 'Random Player' node for anim graphs allowing the user to play a selection of animations in a random order with certain randomised paramers. Also allows 'Shuffle Mode' to act more like a playlist in that it will play everything on the list before repeating.
#rb Bruce.Nesbit
Change 2759219 on 2015/11/09 by Ori.Cohen
Character perf test is now looking at stats directly and sending to analytics
#RB Ben.Salem
Change 2759398 on 2015/11/09 by Lina.Halper
Fix issue where placed montages are not playing.
- the issue is that IsPlaying does not consider montage, but SetPlaying does. It is asymmetry, so I made it same. However, there are other functions that need to be re-looked at wr.t. montage
#code review: Thomas.Sarkanen
#RB: Marc.Audy
Change 2759491 on 2015/11/09 by Lina.Halper
#Anim: Fix not getting input correctly for Copy Pose node
#RB: Marc.Audy
Change 2759602 on 2015/11/09 by Marc.Audy
Fix imporperly named struct
Change 2759795 on 2015/11/09 by Aaron.McLeran
UE-23145 Adding a Priority value to USoundBase to use in concurrency evaluation and sorting wave instances for voice stealing.
#rb zak.middleton
Change 2760081 on 2015/11/09 by Aaron.McLeran
UE-23091 Adding more logging for NaN checks and fixing one source of NaNs for audio.
OmniDirectional Math Explanation:
For XAudio2, because we do our own distance-attenuation calculations, we use the X3dAudio2 API to simply compute a speaker-map for spatialization and force the listener to be at the origin and the emitter to be on the unit-circle. Thus, from XAudio2's perspective, all distances for every listener-emitter pair will be 1.0.
So in order to use the InnerRadius blending feature, we need to trick it into doing a an inner radius blend relative to a distance of 1.0. For example, if OmniRadius and Distance are the same, then the "NormalizedOmniRadius" is 1.0 and XAudio2 will begin its "blend" of the sound to an omni-directional speaker map.
If Emitter-listener distance is less than the OmniRadius, we'll want to do more blending to an omni-directional speaker map, but we need to set the InnerRadius to something greater than 1.0 (i.e. so that the normalized distance of 1.0 will be treated as less than the InnerRadius). To do "full" omni-directional blending, the emitter-listener distance will be 0 or close to zero, and the NormalizedOmniRadius will be very large (i.e. close to infiinity).
The previous math just set the NormalizedOmniRadius to FLT_MAX which is fine but that number is eventually squared before making the API call. FLT_MAX squared is INF.
Note: I do not think we need to square the OmniRadius in:
Emitter.InnerRadius = OmniRadius*OmniRadius;
But I am keeping it t here because of legacy content which depends on that behavior.
#rb zak.middleton
hange 2760401 on 2015/11/10 by Thomas.Sarkanen@Thomas.Sarkanen-Dev-Framework
Re-instated deleted protected functions in UAnimInstance.
Fixed access of UAnimInstance in FAnimNode_StateMachine.
#rb Martin.Wilson
Change 2760407 on 2015/11/10 by Jurre.deBaare
Construct raw meshes for spline meshes now uses the render data instead of original model data (preserves tangents/normals)
Change 2760468 on 2015/11/10 by Benn.Gallagher
Anim Dynamics optimizations, cached iteration independant data to reduce footprint of iteration on limits.
#rb Graeme.Thornton
Change 2760613 on 2015/11/10 by Jeff.Farris
Fixed async collision completion delegate potentially firing repeatedly. (UE-23149)
#cr marc.audy
#codereview lina.halper
Change 2760795 on 2015/11/10 by Marc.Audy
Don't compile in pointless AddReferencedObjects when with editoronly data not defined
Minor coding standard cleanup (NULL and auto)
Change 2760848 on 2015/11/10 by Benn.Gallagher
Fix to anim instance proxy to not rely on state machine initialization to bind native delegates as nested state machines are not guaranteed to be initialized. This was fixed in UAnimInstance originally but broken again by the proxy instance code.
#jira UE-23164
#rb Martin.Wilson
Change 2760866 on 2015/11/10 by Marc.Audy
Manage transient visualization components for camera component in the same way that sprite component for other actor components are
#rb Mike.Beach
Change 2760963 on 2015/11/10 by Marc.Audy
Since construction script can cause actors to be spawned don't use a ranged for to iterate
#jira UE-22639
#rb Jeff.Farris
#codereview Dmitriy.Dyomin
Change 2762297 on 2015/11/11 by James.Golding
UE-23086 Don't ensure in SetRootBodyIndex when Bodies array is empty (ie no physics state created)
#rb martin.wilson
#codereview ori.cohen, lina.halper
Change 2763566 on 2015/11/11 by Lina.Halper
FAnimNode_CopyPoseFromMesh::Evaluate - was accessing skeleton joint, not mesh joint.
#RB: Laurent.Delayen
Change 2763926 on 2015/11/12 by Thomas.Sarkanen
Fix anim notifies not firing from single anim instances
UE-23248 - Anim Notifies are not working for Animation Sequences
UE-23249 - Anim Notifies using Sound Cues do not work
#rb James.Golding
Change 2764039 on 2015/11/12 by Jurre.deBaare
Fix for issue with incorrect material indices after reducing a skeletal mesh with non LOD0 mesh as BaseLOD (OR-9243) #rb Lina.Halper
Change 2764307 on 2015/11/12 by Jurre.deBaare
VS2015 SSF library
Change 2764314 on 2015/11/12 by Stan.Melax
crashfix was putting bad bodies to sleep at start
Fatal error!
Unhandled Exception: EXCEPTION_ACCESS_VIOLATION reading address 0x00000000
UE4Editor-Engine.dll!USkeletalMeshComponent::InitArticulated() [...\\engine\\source\\runtime\\engine\\private\\skeletalmeshcomponentphysics.cpp:875]
On some skeletalmeshcomponent, some bodies aren't getting created correctly. Trying to force them to sleep was causing a crash - it expected instantiated physx bodies. Seems that all the rest of the code is able to tolerate bad bodies.
Added check to ensure physx body exists before trying to force it to sleep.
not sure if bad bodies are the norm or if this fix is just more "kicking the can down the road".
#codereview ori.cohen
Change 2764343 on 2015/11/12 by Jurre.deBaare
- Fixed crash when building a LOD with SubActors.Num < 2
- Force HLOD level slider is now always enabled, however won't show complete image if not all HLODs are build
- LODActor tree view item now scrolls into view if selected in the world
- Set bAllowCullDistanceVolume to false for LODActor's static mesh components by default
- Added 7zip files
- Fixed issue with WinINet complaining about http-request without 'http://' prefix
- Changed % reduced or original triangles display string, now uses float instead of int (for < 1% reductions)
- Override texture sizes and automatic texture bias
- Fixed issue with incorrect material merging, not picking up it required mesh-data during baking. Added extra conditions for rendering with mesh-data.
- Now incorporate static meshes with opague materials into HLOD merging
- Fixed issue with incorrect normals after merging meshes who's owning components had been negatively scaled
- Fixed issue with incorrect texture size being set from MergeActor window (was only changing .X component)
- Fixed issue with material merging when meshes with multiple LODs are merged, right now only merges LOD0's together if we are also merging the materials (otherwise, merge each LOD)
- Added ENUM for texture scaling/resizing type that has to be applied while merging the materials
- Added detail customization class for FMaterialProxySettings
#rb James.Golding
[CL 2765024 by Marc Audy in Main branch]
2015-11-12 18:11:48 -05:00
Copying //UE4/Dev-Frame to //UE4/Main
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2775736 on 2015/11/20 by Richard.Hinckley
Fix for Paper2D issue with repeated imports in one edutor session. Paper2D import process now creates a new importer at the end. This prevents the sprite sheet import process from leaving frame data around, causing subsequent imports (including imports of different sprite sheets) to include this data inappropriately.
#codereview michael.noland
Change 2776352 on 2015/11/20 by Zak.Middleton
#ue4 - Avoid useless DetachFromParent() for the same pending AttachParent during registration. Added missing UpdateOverlaps() when detaching from object simulating physics.
#rb Marc.Audy, Ori.Cohen
#codereview James.Golding
Change 2776401 on 2015/11/20 by Mieszko.Zielinski
Implemented a way to do batched points projection to navmesh, where every point can declare a custom projection box #UE4
The biggest advantage here is that projection box is independent from projected point - no more manual offsetting of projected point to achieve "100uu up and 500uu down"-like functionality
#jira UE-23705
#rb Lukasz.Furman
Change 2777450 on 2015/11/23 by Martin.Wilson
Bake additive data into animations during cooking to avoid doing additive calculations and extra pose extraction and blending at runtime
#rb Thomas.Sarkanen
Change 2777698 on 2015/11/23 by Mieszko.Zielinski
Gameplay debugging tools fixes #UE4
Fixes:
- made newly added logs respect Log Visualizer's filters
- added handling of invalid data when trying to draw EGameplayDebuggerShapeElement::Cylinder in AGameplayDebuggingHUDComponent::DrawPerception. This is a patch, root cause to be found.
- fixed Log Visualizer resetting it's data while trying to serialize invalid objects. This is a patch, root cause to be addressed.
In addition
- while at it removed bunch of 'auto' and 'class' keywords from the files I've touched
#rb Lukasz.Furman
Change 2777762 on 2015/11/23 by Mieszko.Zielinski
Removed BlackboardComponent's functionality deprecated since 4.7 #UE4
#rb Lukasz.Furman
Change 2777839 on 2015/11/23 by Zak.Middleton
#ue4 - Wrap all vector library calls to math functions through our FMath versions, so they benefit from fixes or improvements therein. Added Exp2() function.
#rb Laurent.Delayen
Change 2777840 on 2015/11/23 by Zak.Middleton
#ue4 - Fix up uses of library math functions to go through our FMath namespace.
#rb Laurent.Delayen
Change 2778287 on 2015/11/23 by Stan.Melax
deprecation of FCollisionQueryParams(bool)
See 2774707 description for the whole story
#OR-9936
#codereview marc.audy
Changes to kite will have to be in a separate check-in
I couldn't submit to all files from the framework branch addition fixes have their files are shelved in cl 2778299
Change 2778507 on 2015/11/23 by Marc.Audy
Eliminate spurious cook warnings for known missing packages
#rb Michael.Noland
Change 2778546 on 2015/11/23 by Aaron.McLeran
Moving occlusion feature settings from audio component to sound attenuation settings struct.
- Sound attenuation setting struct is used for all sounds that do 3d spatialization so it make sense for the occlusion feature settings to be there.
- Kept old low-pass frequency filter setting values on audio component (where HighFrequencyAttenuation used to be)
#rb Zak.Middleton
Change 2778664 on 2015/11/23 by Zak.Middleton
#ue4 - Clarify some comparison functions (IsZero, IsNearlyZero, Equals) in FRotator to explain that they compare as orientations, not other interpretations such as rotational speed, winding, etc.
#rb Aaron.Mcleran
#codereview Frank.Gigliotti
Change 2779335 on 2015/11/24 by Mieszko.Zielinski
Another VisualLog patch to avoid crashing due to a core bug that remains to be investigated #UE4
Again, the core bug here is related visual log trying to serialize invalid objects on a regular basis.
#rb Lukasz.Furman
Change 2779338 on 2015/11/24 by Benn.Gallagher
Fixed crash in Persona when focus is taken from a different window
#jira UE-22516
#rb Ben.Cosh
Change 2779375 on 2015/11/24 by Benn.Gallagher
Fix for deadlock in destructibles. Aquiring actor buffer without releasing causes an infinite wait on next aquire.
#rb Ori.Cohen
Change 2779753 on 2015/11/24 by Zak.Middleton
#ue4 - FMath::Atan2() no longer calls atan2f() because of some compiler or library bugs causing it to randomly return NaN for valid input. It now uses a high-precision minimax approximation instead, measured to be 2x faster than the stock C version.
#rb Brian.Karis
Change 2779853 on 2015/11/24 by Marc.Audy
2015-12-02 16:42:06 -05:00
void FAnimNode_AnimDynamics : : PreUpdate ( const UAnimInstance * InAnimInstance )
Copying //UE4/Dev-Framework to Dev-Main (//UE4/Dev-Main)
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2720406 on 2015/10/07 by Aaron.McLeran
Audio optimization
Don't search for nearest listener if there's only 1 listener.
Change 2720411 on 2015/10/07 by Aaron.McLeran
Fixing HRTF spatialization code with recent changes to stereo spatialization.
HRTF emitter posiition doesn't need to be converted to XAudio2 coordinates.
Change 2723829 on 2015/10/09 by Mieszko.Zielinski
Fixed NavigationSystem trying to set label of newly spawned navigation data #UE4
UE-21880
Change 2723873 on 2015/10/09 by Mieszko.Zielinski
Fixed a bug in FNavAgentProperties::IsEquivalent resulting in failing the test for FNavAgentProperties instances having default AgentStepHeight value (-1) #UE4
UE-21977
Change 2724834 on 2015/10/12 by Ori.Cohen
PR #1634: Add PxVehicleDriveNW support to PhysXVehicleManager.cpp (Contributed by zeduk)
Change 2724850 on 2015/10/12 by Marc.Audy
Fix sound not restarting in matinee preview when jumping back along timeline after reaching end
#codereview Nick.Darnell
Change 2726499 on 2015/10/13 by Ori.Cohen
Fix edge case where sphyl length and radius are 0 and they are not properly clamped to 0.1
Change 2726689 on 2015/10/13 by Marc.Audy
Make UPackage::PackageFlags private
Add debugging for UE-21181 to try and track down when EditorWorld's PackageFlags are getting flagged as PlayInEditor
#codereview Mike.Fricker
Change 2726862 on 2015/10/13 by Lukasz.Furman
removed unused code from DetourNavMeshQuery
#ue4 UE-21988
Change 2726888 on 2015/10/13 by Lukasz.Furman
fixed observer abort: both mode in behavior tree's cone check decorator
#ue4 UE-19375
Change 2726913 on 2015/10/13 by Lukasz.Furman
navmesh raycast will use nearest poly containing ray origin instead of just closest one
#ue4 UE-19334
Change 2726920 on 2015/10/13 by Marc.Audy
Re-unify ULevelStreaming::GetWorldAssetPackageName and GetWorldAssetPackageFName
#codereview Dmitriy.Dyomin, Bob.Tellez
Change 2726931 on 2015/10/13 by Lukasz.Furman
fixed missing Tick event in aborting behavior tree tasks from abandoned subtree
#ue4 UE-21777
Change 2728093 on 2015/10/14 by Ori.Cohen
Fix edge case of sphyl scale take two. The previous approach did double scaling
Change 2728577 on 2015/10/14 by Mieszko.Zielinski
Improved navmesh labeling condition #UE4
Change suggested by github user
#rb Lukasz.Furman
Change 2728587 on 2015/10/14 by Lukasz.Furman
fixed crowd simulation for auto possessed pawns placed on level
#ue4
#rb Mieszko.Zielinski
Change 2728629 on 2015/10/14 by Lukasz.Furman
fixed influence of navmesh edges on crowd simulation near end of path
#ue4 UE-21380
#rb Mieszko.Zielinski
Change 2728678 on 2015/10/14 by Lukasz.Furman
added Z check to detour's crowd avoidance segment gathering
#ue4 UE-20889
#rb Mieszko.Zielinski
Change 2728745 on 2015/10/14 by Lukasz.Furman
fixed copy&paste operation in behavior tree's composite decorators subgraphs
#ue4 UE-18740
Change 2729276 on 2015/10/14 by Stan.Melax
ensure all actors get recreated with new collision shape specification.
this wasn't being done for a couple of editing methods.
todo: this should be merged into 4.10
#UE-20961
#rb ori.cohen
Change 2730709 on 2015/10/15 by Marc.Audy
Prevent memory corruption when an invalid controller ID is passed in to the forcefeedback channel functions
#rb Lina.Halper
Change 2733590 on 2015/10/19 by Benn.Gallagher
Fixed various crashes when using undo and redo while manipulating state machines UE 22088
Change 2735143 on 2015/10/20 by Lukasz.Furman
clearing behavior tree debugger's state when displayed subtree becomes inactive
#ue4
#rb Mieszko.Zielinski
Change 2735144 on 2015/10/20 by Lukasz.Furman
rebuilding behavior tree graph node order when node is being moved
#ue4
#rb Mieszko.Zielinski
Change 2735403 on 2015/10/20 by sebastian.kowalczyk
Integrated fix for issue UE-18594 "Gameplay Debugger is hijacking the Canvas" issue from 4.10 (2735391). Extended previous fix to care about OSX users - it's possible to configure shortcuts in engine config file now (little different ones for osx platform).
Change 2736406 on 2015/10/21 by sebastian.kowalczyk
Added new GameplayDebugger as a plugin. Old gameplay debugger is still here to keep backward compatibility but it's deprecated now. Current projects should be moved to use new plugin soon.
Change 2736436 on 2015/10/21 by sebastian.kowalczyk
Fixed crash in gameplay debugger with player set as debug target.
Change 2736437 on 2015/10/21 by sebastian.kowalczyk
Added visual indicator around selected pawn to fix FORT-10273 issue. (FN is not using new gd plugin yet).
Change 2736489 on 2015/10/21 by sebastian.kowalczyk
Hide internal and debug hud classes from drop down lists.
Change 2736504 on 2015/10/21 by sebastian.kowalczyk
Fix for UE-18548 "EnableGDT does not work correctly in PIE".
Change 2736529 on 2015/10/21 by sebastian.kowalczyk
Fixed UE-18548 "EnableGDT does not work correctly in PIE"
Change 2736588 on 2015/10/21 by sebastian.kowalczyk
Removed old log visualizer classes.
Change 2736700 on 2015/10/21 by sebastian.kowalczyk
Fixed UE-19256 "Perception debug data doesn't get replicated by Gameplay Debuger" for old gameplay debugger module.
Change 2737180 on 2015/10/21 by Zak.Middleton
#ue4 - Fix UPrimitiveComponent::GetCollisionShape not correctly enforcing bounds limits.
#rb Aaron.Mcleran
#jira UE-22436
Change 2738084 on 2015/10/22 by sebastian.kowalczyk
Better indication of selected pawn for Gameplay Debugger.
Change 2738413 on 2015/10/22 by Marc.Audy
Disable duplication of worlds/maps via the content browser
#jira UE-22200
#rb James.Golding
Change 2739743 on 2015/10/23 by bruce.nesbit
UE-18707 - Issue with drawing material triangle on canvas #1387
Added DrawTriangleUsingVertexColor
Change 2739751 on 2015/10/23 by bruce.nesbit
Revised bShowDebugForReticleTarget should not be static #1539
Change 2739788 on 2015/10/23 by bruce.nesbit
Revised the 2 functions that used FTriangleRenderer::DrawTriangle to use FTriangleRenderer::DrawTriangleUsingVertexColor
Fixed compile error
Change 2739870 on 2015/10/23 by Marc.Audy
Avoid issues while detaching child components if OnAttachmentChange were to remove a sibling component itself.
#jira UE-22362
#rb Zak.Middleton
Change 2739882 on 2015/10/23 by sebastian.kowalczyk
Fix for UE-20901 "VisualLog redirections are broken after PIE finishes" issue.
Change 2740140 on 2015/10/23 by Marc.Audy
Ensure that components reregister tick functions after seamless travel
#jira UE-20892
#rb Zak.Middleton
Change 2740614 on 2015/10/23 by Ori.Cohen
Fix linker issues for people wanting to use physics lock lambdas
Change 2740674 on 2015/10/23 by Aaron.McLeran
Sound Focus Feature
Added new parameters to SoundAttenuation settings to allow audio to change behavior based on its angle to the listener
- Define the min/max azimuth angle to establish in-focus and non-focus regions
- Can scale the priority of a sound based on focus angle
- Can attenuate the volume of a sound based on focus angle
- Can scale the listener-emitter distance based on focus angle
- Distance scale is applied when determining max audible distance for USoundBase
- Can opt-out of focus effects for a sound at the USoundBase level
#rb Ryan.Vance
Change 2741542 on 2015/10/26 by Lukasz.Furman
lowered min value clamping in navigation filter properties
#ue4
#rb Mieszko.Zielinski
Change 2743227 on 2015/10/27 by Marc.Audy
Make ASceneCaptureCube subclassable outside of Engine module
#jira UE-22609
Make USceneCaptureComponentCube::UpdateContent callable outside of Engine module
#jira UE-22610
#rb Jeff.Farris
Change 2743255 on 2015/10/27 by Marc.Audy
Wrap FActorSpawnParameters class with deprecation warning disable pragma instead of hand implementing copy constructor
#rb Jeff.Farris
Change 2743729 on 2015/10/27 by Ori.Cohen
Fix case where we spawn and adjust location which gives us implicit velocity.
#codereview Stan.Melax
Change 2746135 on 2015/10/29 by sebastian.kowalczyk
Fixed UE-21668 "Saving log filters selected in LogVisualizer causes insane ini file sizes! And doesn't really work."
Change 2746437 on 2015/10/29 by Lukasz.Furman
pass on verifying behavior tree stack before accessing its elements
#ue4
#rb Mieszko.Zielinski
Change 2748028 on 2015/10/30 by sebastian.kowalczyk
Changed GameplayDebugger's console variable from gd.EQSOnHUD to ai.gd.EQSOnHUD" after suggestion with MieszkoZ.
Change 2748184 on 2015/10/30 by Aaron.McLeran
UE-22693 Fix for streaming bug
- 3rd decoded buffer in initial 3 buffers was not getting submitted to xaudio2 voice resulting in garbled/skipped audio.
- Wasn't able to repro the 'cannot read chunk' part of the bug
#rb ryan.vance
Change 2749255 on 2015/10/31 by sebastian.kowalczyk
Fixed ai.gd.EQSOnHUD console variable after rename from gd.EQSOnHUD.
Change 2749276 on 2015/10/31 by sebastian.kowalczyk
Added switch to toggle highlight of selected actor to GameplayDebugger.
Change 2749318 on 2015/10/31 by sebastian.kowalczyk
New Gameplay Debugger plugin can be used with old module simultaneously. It's best to configure different keyboard binding for plugin when using old module (it can be set in project settings, for new gameplay debugger plugin - when activated for project).
Change 2749337 on 2015/10/31 by sebastian.kowalczyk
Fixed GameplayDebugger compilation in shipping/test builds.
Change 2749376 on 2015/10/31 by sebastian.kowalczyk
Small clean-up in gameplay debugger class for BT.
Change 2749931 on 2015/11/02 by James.Golding
Add stats to ProcMeshComp
Change 2749932 on 2015/11/02 by James.Golding
Remove PhysicsThrusterComponent.h from Engine.h
Change 2749960 on 2015/11/02 by James.Golding
- Fix PS4 compile errors in ActiveSound.cpp
- Constructor order of FActiveSound
- Shadowed AudioComponent var in CheckOcclusion
#RB thomas.sarkanen
#codereview aaron.mcleran
Change 2749961 on 2015/11/02 by James.Golding
Fix PS4 compile errors in GameplayDebuggerBaseObject.cpp
- Shadowed DefaultContext function param, now just Context, which matches declaration
#RB thomas.sarkanen
#codereview sebastian.kowalczyk
Change 2750026 on 2015/11/02 by Thomas.Sarkanen
Anim Multithreading: thread-safety refactor
Segregated access to various parts of anim update data by spitting off a new proxy class (FAnimInstanceProxy) containing all data accessed in Update() and Evaluate() passes. Gated access to the proxy data on the game thread in a number of ways:
- Explicit access via GetValueOnGameThread() - this blocks on any existing task, completes and then allows control to return to the accessing function. This allows stuff like Blueprints to continue to operate as normal.
- Explicit access via GetValueOnAnyThread() - this ensures that in the limited set of circumstances we need this (Blueprint pure functions mostly) that conditions are met about concurrent access.
- Deprecating many APIs on UAnimInstance that should not be used (and in fact are not used at present, happily).
Derived classes of UAnimInstance can override the creation of the proxy class to create their own type. We do this for UAnimSingleNodeInstance etc.
Any API deprecation should continue to function - no functions have been removed yet. The only things that are not backwards-compatible are direct access to some public member variables for which there is no way to support (e.g. via references, for example UngroupedActivePlayerArrays).
Some APIs have been changed to more specifically represent the dependencies involved. For example TickAssetPlayerInstance() used to take a UAnimInstance*, only to use it to simply queue notifies. This has been deprecated and replaced with a new FNotifyQueue API. FNotifyQueue also uses a thread-safe FRandomStream instead of FMath::Rand.
Many changes are due to substituting accessor functions for direct variable access.
Removed 'service' tick group as we no longer need to segregate the running of our parallel update.
Anim nodes that need to do some game thread-side update should register for a pre-update callback delegate in the proxy. See FAnimNode_AnimDynamics for an example of this.
Moved UpdateActiveVertexAnims into FAnimRuntime so I can subsume some of the code that was in USkeletalMeshComponent::EvaluateAnimation into UAnimInstance (and hence keep the proxy access private).
#rb Martin.Wilson,Lina.Halper
#codereview Michael.Noland
Change 2750077 on 2015/11/02 by Marc.Audy
Expose UInputComponent::BindAction that supports WithKey delegate signature
Change 2751767 on 2015/11/03 by Thomas.Sarkanen
Added extra support to Anim Blueprint 'fast-path'
Added support for negated bools (value gets negated during copy).
Added support for copying from struct members (via break struct) and split struct pins.
Removed potentially troublesome references to BP-constructed UProperties, replacing them with the property FName. This adds some extra Initialize() overhead, but prevents various crash-on load issues (one when generating the class CRC). Added guard to prevent multiple initialization to save this more expensive work being done more often.
#rb Martin.Wilson
Change 2752158 on 2015/11/03 by Jeff.Farris
Fixed UGameplayStatics::SpawnEmitterAttached() to register the ParticleSystemComponent after it spawns.
#rb marc.audy
Change 2752159 on 2015/11/03 by Jeff.Farris
Improvements to camera lens effects to (EmitterCameraLensEffectBase)
- can now specify a transform to align the emitter with the camera
- exposed several key parameters to Blueprints
- ENGINE_API now applies to the entire class
#rb marc.audy
Change 2753454 on 2015/11/04 by Thomas.Sarkanen
Fixup deprecation warnings fallout from multithreaded update changes.
Fixed up use of AnimInstance in Vicon plugin.
Fixed up use of AnimInstance in slope warping node.
Un-deprecated some APIs to become warning free (these APIs are safe to call but just a 'bad idea if you want to do it right').
Also an extra API to allow for smoother transition: Allow custom allocation/deallocation (including using a proxy member struct) by providing an override point for proxy destruction.
#rb Martin.Wilson
Change 2754099 on 2015/11/04 by Ori.Cohen
Fix for task threads dropping stats (from Gil)
#rb Gil.Gribb
Change 2754449 on 2015/11/04 by Marc.Audy
Ensure that components created from an Actor's blueprint BeginPlay implementation get BeginPlay called on them and register their component ticks
#jira UE-20853
Reorganize some booleans to get better bit packing
#rb Jeff.Farris
#codereview Mieszko.Zielinski
Change 2754573 on 2015/11/04 by Aaron.McLeran
Fixing audio component PostLoad code to not set all LowPassFilterFrequency values to 0.0f
Change 2755345 on 2015/11/05 by Thomas.Sarkanen
Added deprecated constructors for various animation contexts
Allows existing code to compile if it creates its own contexts from UAnimInstance.
#rb James.Golding
Change 2755348 on 2015/11/05 by James.Golding
Add BP-exposed SetBoundsScale function to PrimitiveComponent
#RB thomas.sarkanen
Change 2755437 on 2015/11/05 by Marc.Audy
Fix compile errors
#codereview Thomas.Sarkanen, Mieszko.Zielinski, Aaron.McLeran
Change 2755982 on 2015/11/05 by Marc.Audy
Move HeaderParse changes for deprecation macro from Core
Fix world settings warning
Change 2756028 on 2015/11/05 by Marc.Audy
Fix shadow variable issue
Change 2756090 on 2015/11/05 by Ori.Cohen
Improve budget tool so that task threads are computed automatically.
#rb Gil.Gribb
Change 2756120 on 2015/11/05 by Mieszko.Zielinski
Fixed AIController::MoveTo not using DefaultQueryExtent of its navigation data #UE4
#rb Lukasz.Furman
Change 2756243 on 2015/11/05 by Mieszko.Zielinski
Fixed AI perception sight's "auto-visibility" mechanism totally skipping distance and vision cone checks #UE4
The old way was resulting in false positives when for example observer teleported somewhere far
#rb Lukasz.Furman
#codereview John.Abercrombie
Change 2756280 on 2015/11/05 by Mieszko.Zielinski
Minor VLog code cleanup and dumb-fixing visual logger accessing timer manager off of game thread #UE4
#rb Lukasz.Furman
Change 2756500 on 2015/11/05 by Mieszko.Zielinski
Added sanity-checking to BlueprintNodeHelpers::HasBlueprintFunction and cleaned up its usage #UE4
Also, refactored its parameters into references over pointers.
#rb Lukasz.Furman
Change 2757041 on 2015/11/06 by Thomas.Sarkanen
Removed check() in UAnimInstance::GetProxyOnAnyThread()
The check was no longer needed as if we are on the game thread we block until tasks are completed below, and if we are on any other thread we are 'safe' anyway.
#rb James.Golding
Change 2757207 on 2015/11/06 by Ori.Cohen
Fix incorrect root body cache which causes a single frame "freak out" when simulating physics from an animation
#rb Lina.Halper
Change 2757238 on 2015/11/06 by Marc.Audy
Force compiler generated functions to be generated for FHierarchicalSimplification in WorldSettings.h so that they are generated while the deprecation warnings are disabled.
#rb Mike.Fricker
Change 2757284 on 2015/11/06 by Stan.Melax
tapered capsule drawing
cloth collision happens with spheres and for the hull or tapered capsule goemetry between any specified pair of spheres.
(this was already code reviewed before, but missed the check-in window before streamtime)
#rb ori.cohen
Change 2757743 on 2015/11/06 by Lukasz.Furman
fixed node memory allocations for injected behavior tree decorators
#ue4 UE-22783
#rb Mieszko.Zielinski
Change 2757772 on 2015/11/06 by Lukasz.Furman
added setters for crowd avoidance
#ue4 UE-22785
#rb Mieszko.Zielinski
Change 2758422 on 2015/11/07 by Lina.Halper
Potential fix for invalid root bone index input
#jira :/UE-23086
#code review: Ori.Cohen
Change 2758429 on 2015/11/07 by Mieszko.Zielinski
Reimplemented a fix for AI Sight's "auto seeing" mechanics in a more flexible way #UE4
#jira UE-23089
Change 2758571 on 2015/11/08 by Mieszko.Zielinski
Modified ensure condition in UAIPerceptionComponent::OnRegister so it doesn't go off when BP does it's magic when components are being added to a BP actor class #UE4
#jira UE-23080
Change 2758821 on 2015/11/09 by Thomas.Sarkanen
Fixed animations no longer playing when using a dedicated server.
Uses correct logic to determine whether we are running as a server or not.
#rb Martin.Wilson
Change 2758920 on 2015/11/09 by Marc.Audy
Don't dereference weak object pointers repeatedly in FBoneContainer::Initialize
#rb Lina.Halper
Change 2758944 on 2015/11/09 by Ori.Cohen
Fix crash when stats are only on one thread and budget mode is used
Change 2758967 on 2015/11/09 by Benn.Gallagher
Fix for crash undoing notify socket changes in Persona, needed to recache the notify track data after the transaction had reserialized the sequence.
#jira UE-22963
Change 2758973 on 2015/11/09 by Benn.Gallagher
Added new 'Random Player' node for anim graphs allowing the user to play a selection of animations in a random order with certain randomised paramers. Also allows 'Shuffle Mode' to act more like a playlist in that it will play everything on the list before repeating.
#rb Bruce.Nesbit
Change 2759219 on 2015/11/09 by Ori.Cohen
Character perf test is now looking at stats directly and sending to analytics
#RB Ben.Salem
Change 2759398 on 2015/11/09 by Lina.Halper
Fix issue where placed montages are not playing.
- the issue is that IsPlaying does not consider montage, but SetPlaying does. It is asymmetry, so I made it same. However, there are other functions that need to be re-looked at wr.t. montage
#code review: Thomas.Sarkanen
#RB: Marc.Audy
Change 2759491 on 2015/11/09 by Lina.Halper
#Anim: Fix not getting input correctly for Copy Pose node
#RB: Marc.Audy
Change 2759602 on 2015/11/09 by Marc.Audy
Fix imporperly named struct
Change 2759795 on 2015/11/09 by Aaron.McLeran
UE-23145 Adding a Priority value to USoundBase to use in concurrency evaluation and sorting wave instances for voice stealing.
#rb zak.middleton
Change 2760081 on 2015/11/09 by Aaron.McLeran
UE-23091 Adding more logging for NaN checks and fixing one source of NaNs for audio.
OmniDirectional Math Explanation:
For XAudio2, because we do our own distance-attenuation calculations, we use the X3dAudio2 API to simply compute a speaker-map for spatialization and force the listener to be at the origin and the emitter to be on the unit-circle. Thus, from XAudio2's perspective, all distances for every listener-emitter pair will be 1.0.
So in order to use the InnerRadius blending feature, we need to trick it into doing a an inner radius blend relative to a distance of 1.0. For example, if OmniRadius and Distance are the same, then the "NormalizedOmniRadius" is 1.0 and XAudio2 will begin its "blend" of the sound to an omni-directional speaker map.
If Emitter-listener distance is less than the OmniRadius, we'll want to do more blending to an omni-directional speaker map, but we need to set the InnerRadius to something greater than 1.0 (i.e. so that the normalized distance of 1.0 will be treated as less than the InnerRadius). To do "full" omni-directional blending, the emitter-listener distance will be 0 or close to zero, and the NormalizedOmniRadius will be very large (i.e. close to infiinity).
The previous math just set the NormalizedOmniRadius to FLT_MAX which is fine but that number is eventually squared before making the API call. FLT_MAX squared is INF.
Note: I do not think we need to square the OmniRadius in:
Emitter.InnerRadius = OmniRadius*OmniRadius;
But I am keeping it t here because of legacy content which depends on that behavior.
#rb zak.middleton
hange 2760401 on 2015/11/10 by Thomas.Sarkanen@Thomas.Sarkanen-Dev-Framework
Re-instated deleted protected functions in UAnimInstance.
Fixed access of UAnimInstance in FAnimNode_StateMachine.
#rb Martin.Wilson
Change 2760407 on 2015/11/10 by Jurre.deBaare
Construct raw meshes for spline meshes now uses the render data instead of original model data (preserves tangents/normals)
Change 2760468 on 2015/11/10 by Benn.Gallagher
Anim Dynamics optimizations, cached iteration independant data to reduce footprint of iteration on limits.
#rb Graeme.Thornton
Change 2760613 on 2015/11/10 by Jeff.Farris
Fixed async collision completion delegate potentially firing repeatedly. (UE-23149)
#cr marc.audy
#codereview lina.halper
Change 2760795 on 2015/11/10 by Marc.Audy
Don't compile in pointless AddReferencedObjects when with editoronly data not defined
Minor coding standard cleanup (NULL and auto)
Change 2760848 on 2015/11/10 by Benn.Gallagher
Fix to anim instance proxy to not rely on state machine initialization to bind native delegates as nested state machines are not guaranteed to be initialized. This was fixed in UAnimInstance originally but broken again by the proxy instance code.
#jira UE-23164
#rb Martin.Wilson
Change 2760866 on 2015/11/10 by Marc.Audy
Manage transient visualization components for camera component in the same way that sprite component for other actor components are
#rb Mike.Beach
Change 2760963 on 2015/11/10 by Marc.Audy
Since construction script can cause actors to be spawned don't use a ranged for to iterate
#jira UE-22639
#rb Jeff.Farris
#codereview Dmitriy.Dyomin
Change 2762297 on 2015/11/11 by James.Golding
UE-23086 Don't ensure in SetRootBodyIndex when Bodies array is empty (ie no physics state created)
#rb martin.wilson
#codereview ori.cohen, lina.halper
Change 2763566 on 2015/11/11 by Lina.Halper
FAnimNode_CopyPoseFromMesh::Evaluate - was accessing skeleton joint, not mesh joint.
#RB: Laurent.Delayen
Change 2763926 on 2015/11/12 by Thomas.Sarkanen
Fix anim notifies not firing from single anim instances
UE-23248 - Anim Notifies are not working for Animation Sequences
UE-23249 - Anim Notifies using Sound Cues do not work
#rb James.Golding
Change 2764039 on 2015/11/12 by Jurre.deBaare
Fix for issue with incorrect material indices after reducing a skeletal mesh with non LOD0 mesh as BaseLOD (OR-9243) #rb Lina.Halper
Change 2764307 on 2015/11/12 by Jurre.deBaare
VS2015 SSF library
Change 2764314 on 2015/11/12 by Stan.Melax
crashfix was putting bad bodies to sleep at start
Fatal error!
Unhandled Exception: EXCEPTION_ACCESS_VIOLATION reading address 0x00000000
UE4Editor-Engine.dll!USkeletalMeshComponent::InitArticulated() [...\\engine\\source\\runtime\\engine\\private\\skeletalmeshcomponentphysics.cpp:875]
On some skeletalmeshcomponent, some bodies aren't getting created correctly. Trying to force them to sleep was causing a crash - it expected instantiated physx bodies. Seems that all the rest of the code is able to tolerate bad bodies.
Added check to ensure physx body exists before trying to force it to sleep.
not sure if bad bodies are the norm or if this fix is just more "kicking the can down the road".
#codereview ori.cohen
Change 2764343 on 2015/11/12 by Jurre.deBaare
- Fixed crash when building a LOD with SubActors.Num < 2
- Force HLOD level slider is now always enabled, however won't show complete image if not all HLODs are build
- LODActor tree view item now scrolls into view if selected in the world
- Set bAllowCullDistanceVolume to false for LODActor's static mesh components by default
- Added 7zip files
- Fixed issue with WinINet complaining about http-request without 'http://' prefix
- Changed % reduced or original triangles display string, now uses float instead of int (for < 1% reductions)
- Override texture sizes and automatic texture bias
- Fixed issue with incorrect material merging, not picking up it required mesh-data during baking. Added extra conditions for rendering with mesh-data.
- Now incorporate static meshes with opague materials into HLOD merging
- Fixed issue with incorrect normals after merging meshes who's owning components had been negatively scaled
- Fixed issue with incorrect texture size being set from MergeActor window (was only changing .X component)
- Fixed issue with material merging when meshes with multiple LODs are merged, right now only merges LOD0's together if we are also merging the materials (otherwise, merge each LOD)
- Added ENUM for texture scaling/resizing type that has to be applied while merging the materials
- Added detail customization class for FMaterialProxySettings
#rb James.Golding
[CL 2765024 by Marc Audy in Main branch]
2015-11-12 18:11:48 -05:00
{
const USkeletalMeshComponent * SkelComp = InAnimInstance - > GetSkelMeshComponent ( ) ;
const UWorld * World = SkelComp - > GetWorld ( ) ;
check ( World - > GetWorldSettings ( ) ) ;
CurrentTimeDilation = World - > GetWorldSettings ( ) - > GetEffectiveTimeDilation ( ) ;
}