Files
UnrealEngineUWP/Engine/Source/Developer/TargetPlatform/Public/Common/TargetPlatformBase.h

525 lines
15 KiB
C
Raw Normal View History

// Copyright Epic Games, Inc. All Rights Reserved.
#pragma once
Copying //UE4/Dev-Build to //UE4/Dev-Main (Source: //UE4/Dev-Build @ 3209340) #lockdown Nick.Penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 3209340 on 2016/11/23 by Ben.Marsh Convert UE4 codebase to an "include what you use" model - where every header just includes the dependencies it needs, rather than every source file including large monolithic headers like Engine.h and UnrealEd.h. Measured full rebuild times around 2x faster using XGE on Windows, and improvements of 25% or more for incremental builds and full rebuilds on most other platforms. * Every header now includes everything it needs to compile. * There's a CoreMinimal.h header that gets you a set of ubiquitous types from Core (eg. FString, FName, TArray, FVector, etc...). Most headers now include this first. * There's a CoreTypes.h header that sets up primitive UE4 types and build macros (int32, PLATFORM_WIN64, etc...). All headers in Core include this first, as does CoreMinimal.h. * Every .cpp file includes its matching .h file first. * This helps validate that each header is including everything it needs to compile. * No engine code includes a monolithic header such as Engine.h or UnrealEd.h any more. * You will get a warning if you try to include one of these from the engine. They still exist for compatibility with game projects and do not produce warnings when included there. * There have only been minor changes to our internal games down to accommodate these changes. The intent is for this to be as seamless as possible. * No engine code explicitly includes a precompiled header any more. * We still use PCHs, but they're force-included on the compiler command line by UnrealBuildTool instead. This lets us tune what they contain without breaking any existing include dependencies. * PCHs are generated by a tool to get a statistical amount of coverage for the source files using it, and I've seeded the new shared PCHs to contain any header included by > 15% of source files. Tool used to generate this transform is at Engine\Source\Programs\IncludeTool. [CL 3209342 by Ben Marsh in Main branch]
2016-11-23 15:48:37 -05:00
#include "CoreMinimal.h"
#include "Interfaces/ITargetPlatform.h"
#include "PlatformInfo.h"
#include "GenericPlatform/GenericPlatformFile.h"
#include "Misc/Paths.h"
#include "HAL/PlatformFileManager.h"
#include "Misc/ConfigCacheIni.h"
/**
* Base class for target platforms.
*/
class FTargetPlatformBase
: public ITargetPlatform
{
public:
// ITargetPlatform interface
virtual bool AddDevice( const FString& DeviceName, bool bDefault ) override
{
return false;
}
virtual bool AddDevice(const FString& DeviceId, const FString& DeviceUserFriendlyName, const FString& Username, const FString& Password, bool bDefault) override
{
return AddDevice(DeviceId, bDefault);
}
virtual FText DisplayName() const override
{
return PlatformInfo->DisplayName;
}
- Renamed PlatformInfo::FPlatformInfo to PlatformInfo::FTargetPlatformInfo - Renamed FDataDrivenPlatformRegistry::FPlatformInfo to FDataDrivenPlatformInfo - Moved some fields from PlatformInfo::FTargetPlatformInfo to FDataDrivenPlatformInfo, and cleaned them up in the process - Fixed the DataDrivePlatformInfo.ini files to match the previous items - Removed FVanillaPlatformEntry, and now just using FTargetPlatformInfo to manage flavors under a vanilla PlatformInfo (see PlatformInfo::GetVanillaPlatformInfoArray()) - Cleaned up TPerPlatformValue, as it was often misused (took a group and platform name, but we can get the group from the platform name) [AnimationSharingManager.cpp, *Engine.cpp, Runtime\Engine\*, ] - Fixed FBlueprintNativeCodeGenPaths::GetDefaultCodeGenPaths() to use IniPlatformName instead of some hacky code [BlueprintNativeCodeGenManifest.cpp] - Fixed various Turnkey bugs that recent testing exposed - Enabled AUTOSDKS_ENABLED in both Mac and Linux on the Editor side (not that there are much set up to use it) - Using Turnkey to get the SDK status instead of ValidatePlatforms (gives more detailed information - may want to go back to ValidatePlatforms so only UBT is needed, but change it to give more info) - Moved OnDeviceDiscovered and Lost delegates from each platform's TargetPlatform class to a static in ITargetPlatform - there was no need for per-platform implementations - Started working on allowing for SDK to be installed with editor running and not need to restart editor - Work in Progress! It is not usable yet. #fyi jack.porter #rb pete.sauerbrei [CL 13816905 by Josh Adams in ue5-main branch]
2020-07-01 17:07:12 -04:00
virtual const PlatformInfo::FTargetPlatformInfo& GetTargetPlatformInfo() const override
{
return *PlatformInfo;
}
- Renamed PlatformInfo::FPlatformInfo to PlatformInfo::FTargetPlatformInfo - Renamed FDataDrivenPlatformRegistry::FPlatformInfo to FDataDrivenPlatformInfo - Moved some fields from PlatformInfo::FTargetPlatformInfo to FDataDrivenPlatformInfo, and cleaned them up in the process - Fixed the DataDrivePlatformInfo.ini files to match the previous items - Removed FVanillaPlatformEntry, and now just using FTargetPlatformInfo to manage flavors under a vanilla PlatformInfo (see PlatformInfo::GetVanillaPlatformInfoArray()) - Cleaned up TPerPlatformValue, as it was often misused (took a group and platform name, but we can get the group from the platform name) [AnimationSharingManager.cpp, *Engine.cpp, Runtime\Engine\*, ] - Fixed FBlueprintNativeCodeGenPaths::GetDefaultCodeGenPaths() to use IniPlatformName instead of some hacky code [BlueprintNativeCodeGenManifest.cpp] - Fixed various Turnkey bugs that recent testing exposed - Enabled AUTOSDKS_ENABLED in both Mac and Linux on the Editor side (not that there are much set up to use it) - Using Turnkey to get the SDK status instead of ValidatePlatforms (gives more detailed information - may want to go back to ValidatePlatforms so only UBT is needed, but change it to give more info) - Moved OnDeviceDiscovered and Lost delegates from each platform's TargetPlatform class to a static in ITargetPlatform - there was no need for per-platform implementations - Started working on allowing for SDK to be installed with editor running and not need to restart editor - Work in Progress! It is not usable yet. #fyi jack.porter #rb pete.sauerbrei [CL 13816905 by Josh Adams in ue5-main branch]
2020-07-01 17:07:12 -04:00
virtual const FDataDrivenPlatformInfo& GetPlatformInfo() const override
{
return *PlatformInfo->DataDrivenPlatformInfo;
}
virtual FConfigCacheIni* GetConfigSystem() const override
{
return FConfigCacheIni::ForPlatform(*IniPlatformName());
}
TARGETPLATFORM_API virtual bool UsesForwardShading() const override;
TARGETPLATFORM_API virtual bool UsesDBuffer() const override;
TARGETPLATFORM_API virtual bool UsesBasePassVelocity() const override;
TARGETPLATFORM_API virtual bool VelocityEncodeDepth() const override;
TARGETPLATFORM_API virtual bool UsesSelectiveBasePassOutputs() const override;
TARGETPLATFORM_API virtual bool UsesDistanceFields() const override;
TARGETPLATFORM_API virtual bool UsesRayTracing() const override;
TARGETPLATFORM_API virtual bool ForcesSimpleSkyDiffuse() const override;
TARGETPLATFORM_API virtual float GetDownSampleMeshDistanceFieldDivider() const override;
TARGETPLATFORM_API virtual int32 GetHeightFogModeForOpaque() const override;
TARGETPLATFORM_API virtual bool UsesMobileAmbientOcclusion() const override;
#if WITH_ENGINE
virtual void GetReflectionCaptureFormats( TArray<FName>& OutFormats ) const override
{
OutFormats.Add(FName(TEXT("FullHDR")));
}
Copying //UE4/Dev-Rendering to //UE4/Dev-Main (Source: //UE4/Dev-Rendering @ 4358666) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 4073167 by Krzysztof.Narkowicz Added subsurface profile for eye shading model. #jira none Change 4073422 by Krzysztof.Narkowicz Added dual specular for subsurface profile shading model. #jira none Change 4075278 by Krzysztof.Narkowicz Fixed forward reflection/refraction rendering issues, which caused ShaderModels.Material.Refraction to fail. #jira none Change 4084231 by Krzysztof.Narkowicz Dual specular - replace lobe spread with two separate roughness multipliers. Default material roughness is now replaced by an average lobe roughness in order to support non dual specular features. #jira none Change 4092798 by Matt.Collins Some HDR refactoring. Previously the DisplayOutput and ColorGamut were only set in GameUserSettings. I added a Sink that checks the HDR enable. If it's toggled we apply the correct DisplayOutput and ColorGamut for the current platform (this way we get good settings even if you toggle via the console). These settings are still exposed via the console and can be set independently if the user wants. Change 4096954 by Chris.Bunner Added ShaderModelID as scene texture option and renamed existing value to ShaderModelColor to better reflect the internal code. Change 4111285 by Brian.Karis Eye shading update. Added Iris normal (disabled). Removed wrap. Fixed contact shadows. Change 4155261 by Krzysztof.Narkowicz Planar reflection prefilter - use scene viewport size instead of reflection target size in order to keep filter size constant in screen space. This makes planar reflection filter more stable in case of dynamic resolution. #jira none Change 4167644 by Krzysztof.Narkowicz Global shader map is now stored in multiple DDC entries (one per shader filename) instead of keeping everything in a single one. This allows to skip recompilation of unchanged shader files. Change 4183727 by Yuriy.ODonnell Implemented auto-conversion from deferred to DBuffer decals in forward shading mode (when GBuffer is not available). Added support for specular and metallic channels for DBuffer decals, based on work by Chris Bunner. This requires DBufferC to be expanded from 2 to 4 channels, leading to slight increase in DBuffer bandwidth and memory requirements. Appearance of DBuffer decals is affected by this change, as specular and metallic channel values previously hard-coded in DBufferDecalShared.ush. Decals were forced to be non-metallic and have specular of 4% (0.5 numeric value). Now the authored decal material values will be used, which matches GBuffer decals. Added support for DBuffer decals with emissive component. Most decal types can now be automatically converted, with the exception of stain decals. Those are currently approximated as regular translucent decals. Change 4197684 by laz.matech Added a PostProcess Volume test to the map to test that Cinematic Depth of View can be achieved through PPVs as well. Changed the BP_DepthOfFeildPOV asset - I exposed Focus Method so that it can be disabled for the PPV test. Added a second Hair Model head to the InFocusHair test so that it tests in and out of focus hair models (changed the name of the test to FocusHair). #jira none Change 4225614 by Rolando.Caloca DR - Enable depth collision particles on Vulkan mobile Change 4235489 by Uriel.Doyon Removed r.DefaultFeature.PointLightUnits and r.DefaultFeature.SpotLightUnits and replaced them by a single r.DefaultFeature.LightUnits which also controls the units of newly placed rect lights. #jira UE-59525 Change 4260154 by Mark.Satterthwaite Parallelize the creation of Metal archives and libraries when they are broken up into smaller sub-libraries, this should reduce apparent cook time by going wide across threads on the host of the cooker. Change 4270594 by Brian.Karis Fix for textured rect light L pointing away from plane due to approximate diffuse integration. Change 4273361 by Daniel.Wright Particle Cutouts with 8 verts now always use stochastic approach. Circle textures with > 234 edges in the convex hull were overflowing the uint64 calculation of the total number of combinations, causing an infinite loop. Change 4309174 by Mark.Satterthwaite Graph device utilization from the driver monitor stats - really helps see how well the GPU is being used. Change 4310121 by Matt.Collins Optmizing RemoveUniformBuffersFromSource. Brings it from ~20% to ~1.5% in my testing. #jira none Change 4312960 by Daniel.Wright Fix from Stephen Hill for incorrect light grid culling near the near plane Change 4314169 by Richard.Wallis FShaderCache and associated public structures are now marked as deprecated. All FShaderCache code hooks removed from MetalRHI, OpenGLDrv and engine Launch/Shutdown logic. #jira none Change 4320760 by Arne.Schober DR - Remove SV_Coverage from basepass interpolants when running with Masked in early Depth with ForwardShading as otherwise earlyZ will be disabled (as the PS has to run). #jira UE-60992 Change 4334607 by Uriel.Doyon Added custom overrides to reset ULightComponent::Intensity to default (in FLightComponentDetails). Now settings a light Intesity to default resets the brightness to the archetype brightness. This handles correctly cases where the intensity units differs between the two objects. Also changed FLocalLightComponentDetails so that changing intensity units kepts the same brightness (by recomputing the Intensity). #jira UE-61401 Change 4336188 by Rolando.Caloca DR - Added -ReduceThreadUsage so programs can use less threads (for SCW ) Change 4337967 by Rolando.Caloca DR - Remove unused RHISupportsShaderCompression function #rb none [CL 4358751 by Rolando Caloca in Main branch]
2018-09-11 14:44:10 -04:00
virtual FName FinalizeVirtualTextureLayerFormat(FName Format) const override
{
return Format;
}
Copying //UE4/Dev-Rendering to //UE4/Dev-Main (Source: //UE4/Dev-Rendering @ 4358666) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 4073167 by Krzysztof.Narkowicz Added subsurface profile for eye shading model. #jira none Change 4073422 by Krzysztof.Narkowicz Added dual specular for subsurface profile shading model. #jira none Change 4075278 by Krzysztof.Narkowicz Fixed forward reflection/refraction rendering issues, which caused ShaderModels.Material.Refraction to fail. #jira none Change 4084231 by Krzysztof.Narkowicz Dual specular - replace lobe spread with two separate roughness multipliers. Default material roughness is now replaced by an average lobe roughness in order to support non dual specular features. #jira none Change 4092798 by Matt.Collins Some HDR refactoring. Previously the DisplayOutput and ColorGamut were only set in GameUserSettings. I added a Sink that checks the HDR enable. If it's toggled we apply the correct DisplayOutput and ColorGamut for the current platform (this way we get good settings even if you toggle via the console). These settings are still exposed via the console and can be set independently if the user wants. Change 4096954 by Chris.Bunner Added ShaderModelID as scene texture option and renamed existing value to ShaderModelColor to better reflect the internal code. Change 4111285 by Brian.Karis Eye shading update. Added Iris normal (disabled). Removed wrap. Fixed contact shadows. Change 4155261 by Krzysztof.Narkowicz Planar reflection prefilter - use scene viewport size instead of reflection target size in order to keep filter size constant in screen space. This makes planar reflection filter more stable in case of dynamic resolution. #jira none Change 4167644 by Krzysztof.Narkowicz Global shader map is now stored in multiple DDC entries (one per shader filename) instead of keeping everything in a single one. This allows to skip recompilation of unchanged shader files. Change 4183727 by Yuriy.ODonnell Implemented auto-conversion from deferred to DBuffer decals in forward shading mode (when GBuffer is not available). Added support for specular and metallic channels for DBuffer decals, based on work by Chris Bunner. This requires DBufferC to be expanded from 2 to 4 channels, leading to slight increase in DBuffer bandwidth and memory requirements. Appearance of DBuffer decals is affected by this change, as specular and metallic channel values previously hard-coded in DBufferDecalShared.ush. Decals were forced to be non-metallic and have specular of 4% (0.5 numeric value). Now the authored decal material values will be used, which matches GBuffer decals. Added support for DBuffer decals with emissive component. Most decal types can now be automatically converted, with the exception of stain decals. Those are currently approximated as regular translucent decals. Change 4197684 by laz.matech Added a PostProcess Volume test to the map to test that Cinematic Depth of View can be achieved through PPVs as well. Changed the BP_DepthOfFeildPOV asset - I exposed Focus Method so that it can be disabled for the PPV test. Added a second Hair Model head to the InFocusHair test so that it tests in and out of focus hair models (changed the name of the test to FocusHair). #jira none Change 4225614 by Rolando.Caloca DR - Enable depth collision particles on Vulkan mobile Change 4235489 by Uriel.Doyon Removed r.DefaultFeature.PointLightUnits and r.DefaultFeature.SpotLightUnits and replaced them by a single r.DefaultFeature.LightUnits which also controls the units of newly placed rect lights. #jira UE-59525 Change 4260154 by Mark.Satterthwaite Parallelize the creation of Metal archives and libraries when they are broken up into smaller sub-libraries, this should reduce apparent cook time by going wide across threads on the host of the cooker. Change 4270594 by Brian.Karis Fix for textured rect light L pointing away from plane due to approximate diffuse integration. Change 4273361 by Daniel.Wright Particle Cutouts with 8 verts now always use stochastic approach. Circle textures with > 234 edges in the convex hull were overflowing the uint64 calculation of the total number of combinations, causing an infinite loop. Change 4309174 by Mark.Satterthwaite Graph device utilization from the driver monitor stats - really helps see how well the GPU is being used. Change 4310121 by Matt.Collins Optmizing RemoveUniformBuffersFromSource. Brings it from ~20% to ~1.5% in my testing. #jira none Change 4312960 by Daniel.Wright Fix from Stephen Hill for incorrect light grid culling near the near plane Change 4314169 by Richard.Wallis FShaderCache and associated public structures are now marked as deprecated. All FShaderCache code hooks removed from MetalRHI, OpenGLDrv and engine Launch/Shutdown logic. #jira none Change 4320760 by Arne.Schober DR - Remove SV_Coverage from basepass interpolants when running with Masked in early Depth with ForwardShading as otherwise earlyZ will be disabled (as the PS has to run). #jira UE-60992 Change 4334607 by Uriel.Doyon Added custom overrides to reset ULightComponent::Intensity to default (in FLightComponentDetails). Now settings a light Intesity to default resets the brightness to the archetype brightness. This handles correctly cases where the intensity units differs between the two objects. Also changed FLocalLightComponentDetails so that changing intensity units kepts the same brightness (by recomputing the Intensity). #jira UE-61401 Change 4336188 by Rolando.Caloca DR - Added -ReduceThreadUsage so programs can use less threads (for SCW ) Change 4337967 by Rolando.Caloca DR - Remove unused RHISupportsShaderCompression function #rb none [CL 4358751 by Rolando Caloca in Main branch]
2018-09-11 14:44:10 -04:00
virtual FName GetVirtualTextureLayerFormat(
int32 SourceFormat,
bool bAllowCompression, bool bNoAlpha,
bool bSupportDX11TextureFormats, int32 Settings) const override
{
return FName();
}
#endif //WITH_ENGINE
virtual bool PackageBuild( const FString& InPackgeDirectory ) override
{
return true;
}
virtual bool CanSupportRemoteShaderCompile() const override
Copying //UE4/Release-Staging-4.19 to //UE4/Dev-Main (Source: //UE4/Release-4.19 @ 3944462) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3944462 by Jack.Porter Prevent TVOS packaging from PC from attempting to build an asset catalog #jira UE-56114 Change 3943602 by Leslie.Nivison Adding licenses for additional TPS #jira none Change 3943597 by Leslie.Nivison Adding Enterprise licenses; licenses for additional TPS. #jira none Change 3941962 by Leslie.Nivison Updating 4.19 credit list #jira none Change 3941865 by Mark.Satterthwaite Fix the incorrect landscape rendering and the incorrect render-to-texture from blueprint bugs with MetalRHI. - Track outstanding AsyncCopyBufferFromBufferToBuffer operations to identify attempts to modify overlapping ranges within the same prologue command-buffer. This doesn't work and requires that we break the current render-pass and issue on the current command-buffer. A log warning will be emitted when this occurs. - Don't attempt to alias private memory buffers the moment they are released from the RHI resource because that can lead to incorrect sharing of the memory when used by AsyncCopyBufferFromBufferToBuffer. #jira UE-56021 Change 3940993 by Marc.Audy Do not return the last column if the specified column does not exist. Allow display names to be used when looking for a property if the table is backed by a user defined struct. Do not crash if a property with the given name is not found. #jira UE-56017 Change 3939179 by Ben.Marsh Revert change to not poison memory in development configuration. Making a tradeoff that editor stability and consistency is more important than performance. #jira Change 3938566 by Aaron.McLeran #jira UE-55940 Fix for wavetable synth Missed a case. Change 3938533 by Dan.Oconnor Fix uninitialized variable exposed by recent MallocTBB change #jira UE-56013 Change 3938508 by Aaron.McLeran Fixing CIS error, init order issues. #jira UE-55940 Change 3938490 by Aaron.McLeran #jira UE-55940 Fix for wavetable synth Change 3938352 by josh.jensen Show an error message for Windows iOS builds when packaging/launching and icons are present but no remote Mac is specified #jira UE-55987 Change 3938345 by Peter.Sauerbrei fix to Icons not being built on Mac #jira UE-53492 Change 3938305 by Mark.Satterthwaite For whatever reason moving the buffer initialisation into the prologue command buffer doesn't work - this make absolutely no sense to me. I suspect that this is *merely* moving a render pass boundary around somewhere and forcing raster-state to be reapplied. #jira UE-56005 Change 3937968 by Ben.Marsh Disable the boot DDC if we're not in the editor. Fixes access violations when multiple SCW instances attempt to read/write to the same file. #jira UE-56003 Change 3937573 by Mitchell.Wilson Saving asset to resolve empty asset warning. #jira UE-56004 Change 3937561 by Max.Preussner ImgMedia: Added support for single-threaded platforms Copied from Dev-Sequencer CL# 3937516 #jira UE-55986 Change 3937305 by Mike.Beach Resaving google VR model content with UGS build to fix the empty file version error. #jira UE-55984 Change 3935595 by Arne.Schober Fix missing UV precission on BSP surfaces #jira UE-54014 Change 3935411 by josh.jensen Fixed Windows iOS remote Mac build issue where the user icons were considered remote Mac compilation targets coming solely from the Engine directory #jira UE-55899 Change 3934982 by Marc.Audy Fix shadow variable issue #jira UE-55957 Change 3934892 by Mark.Satterthwaite In MetalRHI treat BUF_Volatile buffers as Shared or Managed memory in all circumstances so that multiple updates within a render pass are respected even though this will hurt CPU performance. This fixes GPU particles on macOS. Also push initialisation upload into the async. command buffer to avoid it overwriting a later Lock/Unlock! Only read-back and copy-buffer operations should be on the 'current' command buffer as they need to be inline with all outstanding commands. #jira UE-55956 Change 3934421 by Arciel.Rekman Fix lockup/OOM when setting audio sources to 2 (UE-53968). #jira UE-53968 Change 3934156 by Peter.Sauerbrei fix for backgrounding problems on iOS and tvOS this will re-open UE-50979 as the fix for that was not correct and would have caused crashes when backgrounding during startup #jira UE4-55609 Change 3933547 by Aaron.McLeran #jira UE-55940 Fix for wavetable sample duration and seek Change 3933544 by Aaron.McLeran #jira UE-55939 Hiding channel format Submix channel format is an experimental feature and shouldn't be exposed to the submix editor for 4.19. Change 3933540 by Aaron.McLeran #jira UE-55718 Fix for playback progress. Change 3933280 by Ethan.Geller [Release-4.19] #jira UE-55810 Ensure AudioComponent is created before we start using it. #rb Aaron.McLeran Change 3933079 by Ryan.Vance #jira UE-55936 Fixed missing referenced uniform bindings on AR pass-through camera shaders. Change 3932319 by Ben.Zeigler #jira UE-55885 Fix corruption of packages when starting and then cancelling an async load of a package that already exists, or attempting to async load a script package It now keeps track of which packages were created by the async load system and will only throw those away on cancel Copy of CL #3932312 Change 3932287 by Matt.Kuhlenschmidt Updated substance texture #jira UE-55081 Change 3931729 by josh.jensen Ensure the tvOS and iOS Assets.car is always produced as part of a regular remote/local build #jira UE-55899 Change 3929723 by josh.jensen Removed packaging requirement on Windows of a remote Mac after setting an app icon to default #jira UE-53495 Change 3929722 by josh.jensen Fixed iOS asset catalog generation issues when swapping out/resetting to default app icons for both code- and BP-projects #jira UE-53492, UE-51879 #robomerge Change 3929350 by Mike.Erwin "Save As" support for #jira UE-55732 Change 3927829 by Steve.Robb Out-of-memory handler for MallocStomp. #jira UE-55550 Change 3926404 by Mike.Erwin #jira UE-55732 Change 3926394 by Dan.Oconnor Recompile bytecode dependencies when compiling an individual blueprint interface, this prevents crashes due to stale bytecode #jira UE-55813 Change 3926098 by Guillaume.Abadie Do not allow dynamic resolution to be enabled on unsupported platforms avoiding game breaker experience by security. #jira UE-55697 Change 3925927 by Guillaume.Abadie Enables TAA's AA_BORDER on all permutation for dynamic resolution. #jira UE-55353 Change 3925882 by Matt.Kuhlenschmidt Fix substance uri having one extra / Fix substance menu option showing up for github (incompatible with plugin) #jira UE-55766 Change 3925873 by Ben.Zeigler #jira UE-55783 Fix issue introduced in 4.18 where user structs did not handle converting AssetPtrs to SoftObjectPtrs properly Copy of CL #3925871 Change 3925163 by Guillaume.Abadie Fixes DFAO's temporal AA passes that was handling FViewInfo::ViewRect.Min wrongly. #jira UE-55788 Change 3924839 by Guillaume.Abadie Fixes a crash of LDR android preview with OS DPI scale != 0. #jira UE-43622 Change 3924542 by Cosmin.Sulea Merged fixes: UE-55299 - XGE Shader Compile Interferes with Remote Shader Compiling Causing Materials to Fail to Compile #7 UE-51086 - No clear editor activity during remote shader compiling #jira UE-55299 Change 3922398 by Mark.Satterthwaite Compile fix for 3922273. #jira UE-53993 Change 3922273 by Mark.Satterthwaite Fix validation error caused by the game updating its orientation before the drawable system catches up. We need to drop drawables that are incorrectly sized until we get one with the correct size. #jira UE-53993 Change 3921127 by Ethan.Geller [Release-4.19] #jira UE-55744: Add OnTick virtual to IAudioPluginListener, fix thread safety issue in Resonance Audio. #rb aaron.mcleran Change 3920632 by Lina.Halper Fix render thread crash when morphtarget is deleted or added #jira: UE-55521 Change 3920557 by Lauren.Ridge Fixing material editor resetting background to off #jira UE-55267 Change 3920519 by Phillip.Kavan Fix a regression in which elements would not be initialized when constructing the value assignment for UDS-typed container members in nativized Blueprint C++ code. Change summary: - Modified FEmitDefaultValueHelper::InnerGenerate() to remove UDS from the list of special cases that avoid calling InitializeStruct() as part of new element construction. Previously the conversion code assumed the compiler would perform value initialization of a nameless temporary, but that is no longer valid in 4.19, as UDS types have been changed to function more like native structs, and as such all converted UDS types will now emit an explicit default ctor which is now used to assign defaults that differ from the zero-initialized value. #jira UE-55628 Change 3920476 by Michael.Trepka Clean up Mac menu item cache at exit before SlateApplication is fully destroyed. #jira UE-55599 Change 3920336 by Ben.Marsh Ignore license warnings from PVS-Studio. #jira UE-55729 Change 3920134 by Jurre.deBaare Moving over: "HLOD: Building HLOD for P map with sublevels requires HLODSetupAsset when it should not #fix Ensure that we dynamically add HLOD level treeview items whenever they are required, rather than adding a static number of levels according to the worldsettings" #jira UE-55619 Change 3920126 by Max.Preussner MediaCompositing: Implemented media track for Sequencer Copied from Dev-Sequencer #jira UE-53974 Change 3920004 by Jack.Porter Disable Manual Vertex Fetch SRV creation when MVF is disabled. Made a single RHISupportsManualVertexFetch(EShaderPlatform) to control whether to use MVF. The Shader Platform (or alternatively, feature level) is the only thing that can decide whether or not to use MVF because we need to know when we compile the shaders if we're going to do MVF or not. Checking GSupportsResourceView at runtime is useless because the shaders can't change and so if GSupportsResourceView can ever be false for a platform, the shaders need to have been built without it. Creating SRVs without using them on mobile is not harmless because several devices don't support formats that are needed. #jira UE-54764 #jira UE-55622 Change 3919069 by Aaron.McLeran #jira UE-55718 Fix for playback progress. Change 3918942 by Graeme.Thornton Added "ProjectBuildMutatorFeature" modular feature, allowing plugins to register said feature and dictate whether the current project requires a code build. CryptoKeys plugin uses this feature to force a code build when encryption or signing is enabled. #jira UE-55686 Change 3918721 by Zak.Parrish Lighter version map for Gremlin + new Engine.ini - result is 60Hz #jira none Change 3918236 by Joe.Graf Added a bFlipTrackedRotation to give a better result when mirroring the rotation of a tracked face #jira: UE-55531 Change 3917970 by Martin.Wilson Expose curve data in remap assets to blueprints #jira UE-55585 Change 3917740 by Olaf.Piesche Properly checking for presence of buffer SRV capability via GSupportsResourceView so ES3.1 and Metal devices don't crash using GPU particles (and possibly in other circumstances); #jira UE-55591 Change 3917713 by Cody.Albert Build fixes for Match3 on iOS #jira UE-53742 Change 3917472 by zak.parrish added mouthPressLeft and MouthPressRight back into debug screen #jira none Change 3917244 by Michael.Dupuis #jira UE-35097: Fixed crash when creating a new landscape with 2x2 subsections and material containing grass spawning node Change 3916775 by Ben.Marsh Add missing files for packaging IOS on Windows. #jira UE-53873 Change 3916293 by Joe.Graf Removed the redundant GetTransform() from UARFaceGeometry since GetLocalToWorldTransform() is exposed on a base class #jira: UE-55531 Change 3916011 by Joe.Graf Added an accessor to get the transform of the face mesh or a face mesh component #jira: UE-55531 Change 3915967 by Mark.Satterthwaite Place buffer updates into the prologue command-buffer in MetalRHI to avoid breaking the current command-encoder. This improves performance, though the semantics of Metal now differ subtly to other RHI implementations as the buffer updates happen prior to the SetRenderTargets call in the GPU's view of the world. #jira UE-54858 Change 3915751 by Nick.Atamas Merging CL 3913931 from //UE/Partner-Google-VR/... to //UE4/Release-4.19/... #jira UE-55639 Change 3915421 by Martin.Wilson Fix crash from live link message bus heartbeat manager #jira UE-55644 Change 3915326 by Dan.Oconnor Make compilation manager's skeleton class layout better match the old compilation path's skeleton class layout, fixes a crash when renaming blueprint functions #jira UE-55592 Change 3915250 by JeanLuc.Corenthin Can't add C++ code to Enterprise projects (when enterprise is installed) Root cause: When compiling a C++ project, Datasmith modules are included in the build process (with the wrong path) Fix: - Added two more Enterprise directories, Plugins and Intermediate, to the Enterprise directories to check against - Build the correct path for the Datasmith modules and plugins in FindOrCreateModuleByName. Added check to see if module is under one of the Enterprise directories. - Added modules to list of precompiled modeules in UEBuildTargets.AddPrecompiledModules if Engine and Enterprise are 'installed and the module is under Enterprise. #jira UEENT-1032 Change 3915240 by Ben.Marsh Reduce editor startup times by ~15s on Windows. Platform loading code recursively scans every module for dependent DLL modules to load first. Change to make it early-out as soon as it encounters a module which is already in memory (via a call to GetModuleHandle() from ResolveMissingLibraryImportsRecursive). Also use a TSet<> to store set of visited modules rather than an Array. Now spends <0.1s total in this function on editor startup. (Change looks larger than it is due to moving functions out of WindowsPlatformProcess.h to avoid introducing TSet dependency into this header). #jira UE-55642 Change 3914803 by Gil.Gribb UE4 - Removed memory track from the lock free list links. This is not safe and will sometimes assert in debug. #jira UE-49600 Change 3914616 by zak.parrish Adding Calibrate button #jira none Change 3914599 by Andrew.Rodham Sequencer: Sequence template source signatures are now also compared to catch the case where a sub-sequence asset has been saved but not modified - The following sequence of events exposes this issue: - Create a master sequence with a single shot that spawns a cube - Add this sequence to a level and set it to auto-play - Save everything and restart - Resave just the inner shot asset without opening it - PIE - The inner shot never spawns its cube because its template was wiped on save, but its signature never changed. Since the master sequence previously didn't check the template source signature, it ends up trying to evaluate an empty template. #jira UE-55626 Change 3914479 by Krzysztof.Narkowicz Added encoded HDR reflection capture cooking if targeting ES 2.0/3.1 on Windows #jira UE-53875 Change 3914347 by Martin.Wilson Stop anim preview instance from ever running in parallel #Jira UE-55577 Change 3914179 by Benn.Gallagher Fixed clothing sections not displaying in LOD section list in skeletal mesh editor, due to no longer duplicating clothing sections in the model data. #jira UE-55528 Change 3914122 by Steven.Barnett Fix perf regression in BSP queries by changing suppression of PhysX mesh cleaning failure message. #jira UE-54081 Change 3913950 by zak.parrish Clamping my normalization math #jira none Change 3913926 by Zak.Parrish First pass at Gremlin Calibrate button. Also added shirt/backpack to boy so he's not a floating head. #jira none Change 3913668 by Matt.Kuhlenschmidt Adding missing substance styling info #jira UE-55081 Change 3913667 by Nick.Atamas Merging CL 3912976 from //UE4/Partner-Google-VR/... //UE4/Release-4.19/... Upgrading to support ARCore 1.0 runtime. #jira UE-55602 Change 3913645 by Aaron.McLeran #jira UE-55618 fix for mono audio devices Change 3913509 by Cody.Albert Removing PhsX build exclusion from Match3 #jira UE-53742 Change 3913380 by Dan.Oconnor Preload Sequence Bindings node at proper time #jira UE-55412 Change 3913300 by Mitchell.Wilson Updating iOS default startup movie to H.264, 1280x720, 30 fps. #jira UE-55382 Change 3913291 by Cody.Albert More iOS build fixes for Match3 #jira UE-53742 Change 3913169 by Cody.Albert Fixed iOS build issues for UnrealMatch3 #jira UE-53742 Change 3913131 by Krzysztof.Narkowicz Fixed remaining quad overdraw viewmode contents on screen after switching to certain other viewmodes (e.g. light overlap or complexity) #jira UE-54580 Change 3912851 by Lina.Halper Fixed issue with pose asset blending additively multiple poses suming up to 1 weight. #jira: UE-55603 Change 3912629 by Guillaume.Abadie Fixes SSR that was computing vigneting according to PrevScreen that could let some outside viewport samples going through when rotating the camera. #jira UE-55353 Change 3912170 by Martin.Wilson Add logging for UE-55511 (NaN crash) #jira UE-55511 Change 3912161 by Phillip.Kavan Fix editor-only default subobjects inherited from a native C++ parent class not being handled correctly during nativized Blueprint class ctor generation. Change summary: - Modified FEmitDefaultValueHelper::HandleSpecialTypes() to skip editor-only checks for instanced default subobjects. These will have already been created by a native parent class. - Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert before creating a "dummy" component in place of an editor-only instance if we're not supposed to be creating it. #jira UE-55474 Change 3912100 by Luke.Thatcher [RELEASE] [^] Merging (as edit) fix for building pak patches (CL 3911754) from //UE4/Dev-Core to //UE4/Release-4.19 #jira UE-55340 Change 3912072 by Mike.Beach Art cleanup pass on AR template icon. #jira UE-55587 Change 3912057 by Michael.Trepka Additional widget path validity check in FSlateUser::NotifyWindowDestroyed() #jira UE-55580 Change 3911592 by Jurre.deBaare Crash on merge actor when Use specific LOD Level #fix make sure we use the correct array to determine the number of components being merged #jira UE-55508 Change 3911466 by Cosmin.Sulea Mega change list for the following related issues: UEMOB-417 - Support Xcode automagical code signing UE-49829 - Remote build fails to use / sign distribution provisions coming from PC UE-39501 - Packaging for tvOS in Distribution fails to find valid provision UE-55334 - XCode managed provisions don╞t operate gracefully with manual provisions UE-55330 - Automatic signing doesn't work with tvOS UE-10969 - Remote build fails if there is no development provision provided #jira UEMOB-417 Change 3911454 by Luke.Thatcher [RELEASE] [!] Fix rendering thread memory leak in FLandscapeComponentSceneProxy::InitViewCustomData - FViewCustomDataLOD is allocated on a memstack, but contains a TArray, so is not trivially destructible. - The SubSections array is leaked when the memstack is popped. - Fix replaces the TArray with a TStaticArray of max size MAX_SUBSECTION_COUNT (which is 4). (Merging as edit CL 3911422 from //Fortnite/Release-3.1/... to //UE4/Release-4.19/...) #jira UE-54835 Change 3911370 by Dragan.Jerosimovic changed browOuterLeft -> browOuterUpLeft, browOuterRight->browOuterUpRight updated KiteBoyHead_JointsAndBlends.fbx #jira none Change 3910545 by Dan.Oconnor PR #4512: Fix FNetNameMapping::GetUniqueName regression (Contributed by dfb) #jira UE-55513 Change 3910449 by Michael.Trepka Fix for crash on exit on Mac when closing the root editor window with Cmd+W #jira UE-54973 Change 3909601 by Patrick.Boutot Expose to Blueprint GetProjectDirectory functions. #jira UE-55548, UEENT-999 Change 3909543 by Patrick.Boutot Rename ECollisionResponse to CollisionResponseType in script to prevent collision with FCollisionResponse. Python's help function now output the Python type instead of the cpp type. Do not export hidden enum entry from Python. #jira UE-55545, UEENT-961 Change 3909289 by Zak.Parrish Adding shirt/chest to faceAR sample #jira none Change 3908808 by Dragan.Jerosimovic added combination shapes network #jira none Change 3908788 by Mitchell.Wilson Updaing Match3Camera to resolve clipping issue on iPhone X #jira UE-54723 Change 3908374 by Jack.Porter Fix viewport offset problem for preview PIE window #jira UE-52583 Change 3907108 by Shane.Caudle #JIRA Added DefaultDeviceProfiles.ini to set the [IOS DeviceProfile] +CVars=r.ShadowQuality=4 Change 3907105 by Lauren.Ridge Fix for thumbnails not resetting when layers/blends reset and for them being incorrectly scaled when null #jira UETOOL-1303 Change 3907011 by Chris.Phillips UE-52667 Unable to package an Android DLC Using "Android APK" and "Android DLC" profiles in Project Launcher. #jira UE-52667 Change 3906792 by Lauren.Ridge When constructing the material editor viewport, use the direct method to set the environment visibility. #jira UE-55267 Change 3906734 by Chris.Babcock Fix issue with vertex fetch disable #jira UE-55475 Change 3906721 by Rolando.Caloca UE4.19 - Check if the results file from SCW is corrupt #jira UE-53124 Change 3906648 by Chris.Phillips UE-53184 Assertion when running mobile PIE in iPhone 5S mode. Updated the iPhone5s.json Metal settings. #jira UE-53184 Change 3906474 by David.Hibbitts Added default constructor for FLiveLinkWorldTime. #jira UEENT-879 #rb none Change 3906467 by Lauren.Ridge Swapping sibling materials now correctly swaps the overridden parameters out #jira nojira demobug Change 3906156 by Michael.Trepka Reverting CL 3728924 as it's causing problems with modal windows. A different, much more involved fix for UE-51711 will be needed. #jira UE-52492 Change 3906144 by Michael.Dupuis #jira UE-54547: Added guard to be sure that material is valid Change 3905882 by Matt.Kuhlenschmidt Enable substance buttons again #jira UE-55081 Change 3905513 by Sorin.Gradinaru UE-55394 iOS crash exiting app during startup movie: SPRINGBOARD, process-exit watchdog transgression #jira UE-55394 #jira UE-52328 #iOS #4.19 This is a particular case of UE-52328 iOS reporting crash on application exit: SPRINGBOARD, process-exit watchdog transgression Found several issues on iOS if the game is forced closed when the startup movie is playing and "Wait for movies to complete" is enabled in Project Settings - the game thread is waiting for the movie to complete on game shutdown - more that 5 sec - crash on FDefaultGameMoviePlayer::Shutdown if the above is fixed - HTTP module no longer has time to wait for the requests to complete. Change 3905506 by Michael.Dupuis Remove static mesh instancing async buffer filling, as with all the changes made, it's no longer necessary, the cost of loading very large buffer is negligable Rebuild the occlusion tree when using foliage.DensityScale with something other than 1.0 #jira 0 Change 3905498 by Lina.Halper Fix multiple pose asset issue - fallout from CL 3903509 - as for fullbody, went back to old mathod because in the fullbody, we want shortest path most of times and you don't blend more than 1 weight, so this is likely fine - as for additive, change to use blend from identity. #jira: UE-55439, UE-55448, UE-55250 Change 3905325 by Sorin.Gradinaru UE-54764 UnrealMatch3 spams Kindle device log with "Unsupported EPixelFormat" #jira UE-54764 #4.19 Also reproduced on Samsung Galaxy S5 Neo (SM-G903F, GPU Mali-T720). Check GMaxRHIFeatureLevel > ERHIFeatureLevel::ES3_1 (not mobile) before creating RSV params used with SupportsManualVertexFetch: (Positions, Tangents, TextureCoordinates, Color buffers) Change 3905307 by Jack.Porter Removed iPhone5 PIE json file as it's not a supported device #jira UE-53184 Change 3905132 by Shane.Caudle #JIRA Pushed it a little more out of the yellow. Change 3905117 by Shane.Caudle #JIRA Got SSS working and made some tweaks. Change 3904936 by Max.Chen Fix editor only #jira UE-55459 Change 3904269 by Chris.Babcock Disable manual vertex fetch on mobile #jira UE-55389 #ue4 #android #ios Change 3904186 by Lina.Halper Pose asset crash when skeleton not existing during serialization #jira: UE-55422 Change 3904063 by Max.Chen Sequencer: Fix copy/paste crash. Only process UMovieSceneCopyableBinding and objects that can be spawned by the movie scene spawn register. Copy from Dev-Sequencer #jira UE-55314 Change 3904060 by Lauren.Ridge Fix for saving a child out of a layer stack capturing the wrong parameters #jira UETOOL-1280 Change 3904050 by Luke.Thatcher [CONSOLE] [^] Added RHI Command List Enqueue Lambda method (merging as edit CL 3879722 from //Fortnite/Main to //UE4/Release-4.19) - Can be used to enqueue arbitrary tasks on the RHI thread from the render thread (similar to how EURC works for GT -> RT tasks), without having to write lots of bolierplate FRHICommand functor classes. - The first overload of EnqueueLambda method will check Bypass() to determine if it should run the lambda immediately or defer to the RHI thread. - This can be overriden via the 2nd overload if you need to check additional things such as IsRunningRHIInSeparateThread. - The function returns true if the lambda was enqueued and deferred to the RHI thread, otherwise false. This can be used to optionally add RHIThreadFences for unlock commands etc. #jira UE-55437 Change 3904004 by Lauren.Ridge Fix for material layer output nodes being able to be placed in other graphs #jira UE-54867 Change 3903931 by Aaron.McLeran #jira UE-55435 Crash in google resonance when toggling visualization fix for issue described here -- https://github.com/resonance-audio/resonance-audio-unreal-sdk/issues/1 Change 3903722 by David.Hill The ProxyLOD plugin is experimental: don't load it by default. #jira: ue-55402 Change 3903583 by Ben.Marsh Include .version and .modules files in manifest. Should fix missing version information in precompiled binaries. #jira Change 3903529 by Richard.Hinckley #jira UEDOC-7180 4.19 API Documentation manual update. Change 3903509 by Lina.Halper Merging using //UE4/Dev-AnimPhys/->//UE4/Release-4.19/ #DUPE MERGE: Fix issue with pose blending with shortest path - causing additive to blend linearly between pose if the rotation is same direction. #jira: UE-55250 Change 3903501 by Michael.Dupuis #jira UE-55122: Fixed bad neighbors updating for mobile Change 3903387 by Will.Fissler ; r.XGEShaderCompile is now enabled by default in source. Uncomment to disable XGE shader compilation. ;r.XGEShaderCompile = 0 #jira UE-55286 Change 3903251 by Sungjin.Hong #JIRA UE-55349 #loc added KO locallization for VR, Handheld AR templates Change 3903219 by Adrian.Siminciuc https://jira.it.epicgames.net/browse/UE-54738 removed redundant iOS warning when IOnlineIdentity::Login is called by FOnlineExternalUIIOS::ShowLoginUI #jira UE-54738 #iOS Change 3903130 by Cody.Albert Updated build configuration to resolve iOS build error on UnrealMatch3 #jira UE-53742 Change 3903056 by Shane.Caudle #JIRA Latest tweaks to lighitng and rendering for boy. Change 3903032 by Cody.Albert Added missing include that was preventing iOS builds from succeeding on TopDown template #jira UE-54341 Change 3902669 by Lauren.Ridge Fix for thumbnail crash after saving material instances that contain layers #jira crash Change 3902581 by Mitchell.Wilson Updating Samples and Template Min iOS Version to iOS 9. #jira UE-55148 Change 3902448 by Lauren.Ridge Fix for crash due to unparented material instance #jira crash Change 3902206 by Chris.Phillips UE-52612 External textures only work in pixel shaders. Sampling external textures are now only limited to pixel shaders when the shader model is < SM4. #jira UE-52612 Change 3902120 by Peter.Sauerbrei bvringing over the fix for backgrounding crash on iPhone X from Fortnite #jira UE-54883 Change 3902097 by Lina.Halper Merging using //UE4/Dev-AnimPhys/->//UE4/Release-4.19/ #DUPE MERGE: CL 3901939 #jira: UE-55401 Change 3902082 by Mike.Beach Fixing an issue with the fix from CL 3889470 - fully matching the old UEnum name check (checking both the value name and the typed name, for example: "Left" and "EControllerHand::Left"). #jira UE-55153 Change 3901963 by Peter.Sauerbrei bring over the fix from Fortnite for Remote Shader Compilation not respecting settings in the passed in shader #jira UE-52797 Change 3901959 by Ethan.Geller [Release-4.19] #jira UE-55225: Stop RtAudio stream on StopRecording in sequence recorder. #rb Aaron.McLaren Change 3901482 by Lauren.Ridge Fix for crash on opening materials due to array out of bounds #jira crash Change 3901181 by Michael.Dupuis #jira UE-55313: To enable tessellation we MUST have 2 materials in the list Change 3900935 by Nick.Bullard Updating Default_Startup.mp4 with more recent UE branding. This still requires another update for final version with audio #jira UE-55382 Change 3900660 by Aaron.McLeran #jira UE-55381 crash in sound submix Bringing fix from FN to 4.19 (CL 3890630) Change 3900643 by Aaron.McLeran #jira UE-55380 fixing synth envelopes Change 3900617 by Aaron.McLeran #jira UE-55151 Fixing crash w/ mic component Change 3900544 by tim.gautier QAGame: Submitting asset for AsNumber fix submitted with UE-10310 #jira UE-29618 Change 3900430 by Ryan.Brucks KismetRenderingLibrary: Applied a fix from FN to make it possible to create textures from BP created RTs. Without the fix the assets would be created but invisible to the user due to missing RF_Public and RF_Standalone. #JIRA none Change 3900399 by Lauren.Ridge Fixing global parameters not working #jira UE-55242 Change 3900297 by Ben.Marsh Speculative fix for hot reload causing version files to be updated with a locally made installed build. #jira UE-55072 Change 3900116 by Chris.Bunner Removing outdated tests and test assets. #jira UETOOL-1298 Change 3900042 by Chris.Bunner Deleted SharedInputCollection and associated material graph nodes. #jira UETOOL-1298 Change 3899887 by Lauren.Ridge Fix for background checkbox stomping profile info for material editor. Note that you may have to delete Saved/Config/Windows/Editor.ini to get this to work. #jira UE-55267 Change 3899824 by Chris.Phillips UE-52813 Editor's mobile preview doesn't serialize the landscape's cooked heightmap data. Now only regenerating landscape pixel data when needed when using Mobile Preview Rendering Levels. #jira UE-52813 Change 3899775 by Lauren.Ridge Fix for crash on opening material layer material #jira crash Change 3899673 by Jamie.Dale Fixed Functions sometimes being exposed to Python as if they were Structs #jira none Change 3899487 by Chris.Bunner Duplicate [CL 3852020, 3896571] - Disabling non-performant code only required by experimental material layers feature. Users can opt-in per-project through experimental renderer settings, replacing the previous editor experimental flag. #jira UETOOL-1298 Change 3899156 by Phillip.Kavan Include address of object reference in persistent frame debug info. #jira UE-51952 Change 3899146 by Rolando.Caloca UE4.19 - hlslcc - Workaround for intrinsics with two output arguments #jira UE-52477 Change 3899060 by Bart.Hawthorne Add a null check for the game mode pointer in UWorld::SpawnPlayActor #jira UE-54461 Change 3899015 by Krzysztof.Narkowicz Fixed initialization of instancing random vertex stream. #jira UE-53605 Change 3899008 by Michael.Dupuis Fix issue with landscape mobile vertex factory accessing unbound LodTessellationParams when r.ShaderDevelopmentMode=1 #jira 0 Change 3898994 by Phillip.Kavan More verbose debug logging if an invalid object reference is detected in the BP ubergraph frame during garbage collection. #jira UE-51952 Change 3898962 by Guillaume.Abadie Fixes wrong parameters about whether GPU timing may have CPU generated bubbles to the dynamic resolution heuristic. #jira UE-55352 Change 3898826 by Sorin.Gradinaru UE-54784 StrategyGame crashes entering game on KindleFire 7 - Assertion failed: ViewSize.GetMin #4.19 #Android #jira UE-54784 Wrong code to make an integer even + operator precedence Change 3898822 by Sorin.Gradinaru UE-52328 iOS reporting crash on application exit: SPRINGBOARD, process-exit watchdog transgression FORT-70783 FHttpManager::Flush is immediately canceling all HTTP requests #jira UE-52328 #jira FORT-70783 #iOS #PC #4.19 UE-52328 reopened because of FORT-70783 iOS only: Delay Request->CancelRequest() on Http module shutdown - wait for 2 sec on FHttpManager::Flush to allow pending requests to be sent to the server. Change 3898705 by Max.Chen Sequencer: Skip if the binding id's sequence can't be found. #jira UE-55337 Change 3898108 by Michael.Dupuis #jira UE-54547: Remove the FORCEINLINE so we get a proper callstack of what's happening Change 3898076 by Max.Chen Sequencer: Override the animation asset in the player state if it doesn't match the animation asset that's being evaluated. #jira UE-55328 Change 3897897 by Matt.Kuhlenschmidt Disable substance buttons for now #jira UE-55081 Change 3897742 by Aaron.McLeran Merging fix for UE-55223 to 4.19 #jira UE-55223 Change 3897538 by Michael.Dupuis #jira UE-53787: Added guard if for some reason the material is null we should not try to draw using this material Change 3897406 by Phillip.Kavan Back out local debug logs. #jira UE-51952 Change 3897400 by Phillip.Kavan Serializing object will now be passed to GC so that it can be logged in case the referenced objects is garbage. - Mirrored from //UE4/Dev-Core (3871863). #jira UE-51952 Change 3897391 by Max.Chen Sequencer: Don't update current time to be within the view range when stepping into a sequence. #jira UE-55322 Change 3897274 by Krzysztof.Narkowicz Fixed issues with loading shaders from DDC - hardcoded CustomAttributes initialization instead of filling them inside UObject costructors in order to properly initialize CustomAttributes before DDC key was created. Added an assert that CustomAttributes are initialized before the AttributeDDCString, so we won't run into this issue again in the future. #jira UE-54683 Change 3897148 by Adrian.Siminciuc https://jira.it.epicgames.net/browse/UE-55147 #4.19 #iOS #jira UE-55147 Change 3897138 by Max.Chen Sequencer: Fix crash when an actor factory is not found. Copy from Dev-Sequencer #jira UE-55309 Change 3897045 by Jack.Porter Fix for crash in ALandscapeProxy::UpdateGrass #jira UE-54362 Change 3897036 by Jack.Porter Fix InstancedStaticMesh crash with invalid lightmap coordinates #jira UE-54423 Change 3896801 by Dmitriy.Dyomin Fixed: Planar reflections does not handle origin rebasing #jira UE-52351 Change 3896743 by Dmitriy.Dyomin Discard CPU copy of vertex/index buffers in OpenGL RHI #jira UE-52133 Change 3896619 by Guillaume.Abadie Cherry-pick 3896598: Fixes after TAAU post process material that had wrong default buffer UV. #jira UE-55317 Change 3895718 by Max.Chen Sequencer: Null checks to prevent crash when saving the default state of a spawnable #jira UE-55304 Change 3895426 by Rolando.Caloca UE4.19 - Add an increased timeout for SCW to avoid OOM situations #jira UE-55306 Change 3895245 by tim.gautier QAGame: Submitting updated test assets. Broke ML_Base out into individual components #jira UE-29618 Change 3895194 by Marc.Audy Prevent crash due to a null entry in the linked to graph of the destination pin #jira UE-54606 Change 3894913 by Arne.Schober REL - Fix crash in Speedtree wind where Renderdata is unavailable #jira UE-54544 Change 3894625 by Arne.Schober REL - Fix assert not in RenderingThread from Triangle Renderer. #jira UE-55247 Change 3894464 by Martin.Wilson Extra debugging info for UE-54705 plus remove check so it is no longer fatal #jira UE-54705 Change 3894450 by Martin.Wilson Remove pinnable ness of retarget asset. Paves the way for exposing retarget asset properties on the node #jira none Change 3893948 by Jostin.Bilyeu Adding default player start location to help with launch on testing within level TM-Materials_POM #jira UE-55063 Change 3893495 by Robert.Manuszewski Fixing a crash when running DDC commandlet #jira UE-54646 Change 3893451 by Jurre.deBaare Altered fix for actor merging with negative scaling to get correct normals #jira UE-54996 #misc updated automated test to include this test-case Change 3892913 by Ethan.Geller [Release-4.19] #jira UE-55151 Fix for Mic Component crashing on re-init. #rb aaron.mcleran Change 3892871 by Ryan.Vance Multi-view requires the day dream compositor. #jira UE-55253 Change 3892785 by Arciel.Rekman Linux: fix inability to create a C++ project (UE-55222). - NullSourceCodeAccessor will unconditionally allow C++ project creation in source builds. - Installed build will check for more compilers in commonly found locations. #jira UE-55222 Change 3892687 by Jostin.Bilyeu Checking in replacement Built Data for map TM-Materials_POM #jira UE-55063 Change 3892674 by Jostin.Bilyeu Adding an invisible plane to TM-Materials_POM to help testing on mobile devices #jira UE-55063 Change 3892622 by Aaron.McLeran #jira none Fixing scope lock in phonon probe volume Change 3892511 by Matt.Kuhlenschmidt Fix zero engine version warning #jira UE-55081 Change 3892211 by Yuriy.ODonnell Fix/workaround for inconsistent preprocessor definitions for NVAftermath that result in FD3D11DynamicRHI class layout mismatch. NVAftermath support is now enabled by default for Win64. NVAftermath is declared as a private dependency in D3D11RHI. It does not automatically propagate to modules that explicitly include private RHI headers (OculusHMD, OSVR, OSVRInput). This results in NV_AFTERMATH being defined while compiling RHI module and not defined when compiling other modules, causing memory corruption at runtime. The long-term solution for this and similar issues requires some mechanism for adding transitive module dependencies, so that anyone that depends on D3D11RHI module would automatically also get the NVAftermath. Additionally, private headers should *never* be included directly by external modules. The short-term solution is to explicitly add NVAftermath dependency to OculusHMD, OSVR and OSVRInput. Additionally, NV_AFTERMATH is no longer forced by D3D11RHIPrivate.h when it's not defined. This allows catching this kind of mismatch in the future through a compiler warning (C4668). #jira UE-53065 Change 3891732 by Brian.Zaugg Re-adding iPhoneX launch images with correct case. #JIRA UE-53541 Change 3891727 by Arne.Schober REL - Do not recreate one Frame Resource for dynamic draws #jira UE-55063 Change 3891716 by Ben.Marsh Fix buffer overrun when generating callstack. #jira Change 3891697 by Brian.Zaugg Deleting iPhoneX launch images that have incorrect case. #jira UE-53541 Change 3891678 by Brian.Zaugg IPP binaries for iPhoneX support. #jira UE-53541 Change 3891525 by Lauren.Ridge Thumbnails now update correctly w/parameters #jira UETOOL-1333 Change 3891520 by Lauren.Ridge Fixing SA error in material editor #jira UE-55206 Change 3891495 by Jurre.deBaare Normal are different after Merge Actor on scaled objects #fix Make sure we do not apply scale when transform Normals/Tangents #jira UE-54996 Change 3891352 by Guillaume.Abadie Fixes ensure when visualizing HDR with TAAU. #jira UE-55019 Change 3891323 by Matt.Kuhlenschmidt Added substance buttons to content browser and material editor #jira UE-55081 Change 3891033 by David.Hibbitts #JIRA UE-55135 Moved Message Bus Source heartbeats to their own thread using a new FHeartbeatManager singleton. This prevents sources from incorrectly being removed during Slate UI operations. Change 3890642 by Arne.Schober REL - Better fix for Paper2d which honors batching #jira UE-55063 Change 3890593 by Arne.Schober REL - Fix Paper2d crash. When addMesh is called the Vertex and Indexbuffers are nulled out. re-create Dynamic Mesh builder for every Mesh instead. #jira UE-55063 Change 3890502 by Mike.Erwin Fix reported VRAM size on Metal We were getting correct value in MB from system but overflowing uint32 arithmetic when converting to bytes. This led 4GB and 8GB configs to report 0 total VRAM, 0 dedicated tex mem, and GTexturePoolSize = 0. Noticed the problem on my 6GB FirePro, which reported 2GB and set GTexturePoolSize to 70% of that. Also fixed log of texture pool size to show MB. Other platforms' RHIs already report this in MB. #jira none Change 3890404 by Jostin.Bilyeu Updating Demo Display names to remove redundant spaces #jira UE-29618 Change 3890401 by Dan.Oconnor Fix for property table performance regression #jira UE-54984 Change 3890194 by Dan.Oconnor Make sure a CDO's subobjects are preloaded when running in -game #jira UE-54242 Change 3890182 by Krzysztof.Narkowicz Moving CL3867594 from Dev-Rendering to fix missing shaders in cooked Binary Editor DCC. USE_EDITOR_ONLY_DEFAULT_MATERIAL_FALLBACK generated default material shaders had no cooking code path. #jira UE-54683 Change 3890140 by Rob.Cannaday Merging cacert.pem from //UE4/Dev-Online to //UE4/Release-4.19 Includes latest cacert.pem from https://curl.haxx.se/docs/caextract.html as of January 17, 2018 #jira none Change 3889850 by Shaun.Kime Now initializing Niagara scripts and emitters even if the config file isn't ready yet. #jira UE-54168 #jira UE-54169 #tests can create a blank emitter and all script sub-types Change 3889833 by Michael.Trepka Disabled Clang's unused-lambda-capture warning added in Xcode 9.3 #jira none Change 3889696 by Patrick.Boutot Allow rename from AssetTool when there is no source control enabled. Fix crash when you rename an asset without an enabled source control. #jira UEENT-803 Change 3889470 by Mike.Beach Switching the source-name to legacy hand enum lookup functions to use a static table instead of finding a UEnum object and iterating over reflection data (to prevent a GC lockup with the UObject query). #jira UE-55153 Change 3889319 by Matt.Kuhlenschmidt Disable hardware survey on build machines. They run windows server and lack the necessary win32 api functionality to execute it properly #jira UE-55166 Change 3889087 by Jostin.Bilyeu Minor adjustments TM-SceneTexture for better testing clarity. Minor adjustments to TM-MipLevels for test map clean up #jira UE-29618 Change 3889073 by Sorin.Gradinaru UE-55117 Android virtual keyboard can have text input hidden by software buttons #jira UE-55117 #Android #4.19 Adjusted x-coord and width for the native EditText Change 3888841 by Jurre.deBaare Make FSkeletalMeshRenderData::GetMaxBonesPerSection an ENGINE_API exported function #jira none Change 3888837 by Guillaume.Abadie Fixes a crash in dynamic resolution when doing UE4Editor -server #jira UE-55158 Change 3888831 by Dragan.Jerosimovic added fbx files #jira none Change 3888340 by Ethan.Geller [Release-4.19] #jira UE-54787 edit settings for Strategy Game to prevent stuttering in AudioMixer on low performance Android Devices #rb Aaron.McLeran #fyi Aaron.McLeran #lockdown Cristina.Riveron Change 3888133 by Michael.Karambelas QAGame: Adding a BP Actor to test the Mic component feature that AaronM implemented with UE-51471. #jira UE-29618 Change 3887957 by Krzysztof.Narkowicz "Fixed" Vulkan instancing in by doing Metal style set instance offset to 0 hack #jira UE-54367 Change 3887912 by Jostin.Bilyeu Adding content to TM-SceneTexture to verify Screen Positioning as well as Scene Color and Depth. Adding a new map (TM-MIPLevels) for testing custom mip levels #jira UE-29618 Change 3887571 by Zak.Parrish Adding FaceAR content and cleanup #jira none Change 3887458 by Dan.Oconnor Fix 'Step Out' functionality for macro and collapsed graphs #jira UE-55000, UE-55002, UE-55022 Change 3886883 by zachary.wilson Add testing content to QAGame: Texture and material for testing mip levels. Postprocess material for testing scene buffer sampling. #jira UE-29618 Change 3886848 by Max.Preussner Engine: Workaround for uninitialized external textures causing white flashes in media playback Copied from Fortnite-Main and Dev-Sequencer #jira UE-53357 Change 3886720 by Matt.Kuhlenschmidt Guard against mac menus updating during slow tasks. #jira UE-55068 Change 3886657 by Guillaume.Abadie Cherry-pick 3886626: Cherry-pick 3886560: Fixes strong aliasing on TAAU's fast shader permutation. This adds a 6th neighbor sampling, and switch AA_TONE ON as TAA does for its fast shader permutation. #jira FORT-69961 Change 3886653 by Matt.Kuhlenschmidt Perforce Plugin: Removed all calls to methods that would update the P4PASSWD environment variable. Perforce stores this as plain text so it is not safe and we do not want the editor to be responsible for this being set. All users should be using ticket based p4 servers for the best security but if they are unable to then they can call p4 passwd on their own to set a slightly better hashed password directly. They may also log in each time to the editor which prevents any password from being stored #jira UE-55111 Change 3886621 by Benn.Gallagher Fixed crash closing clothing tab if workflow centric application puts the tab spawners in a bad state due to incorrect handling of tab context menus. #JIRA UE-55067 Change 3886552 by Thomas.Sarkanen Fixed crash loading an anim instance with a re-instanced class Unable to repro, but in editor we dont need the optimization that this provides. Now we always re-initialize functions and properties in case the class has changed out from under us. #jira UE-55065 - [CrashReport] UE4Editor_Engine!FExposedValueHandler::Initialize() [animnodebase.cpp:521] Change 3886442 by Cosmin.Sulea UE-53033 - Editor Rapidly Spawns Multiple Empty Windows Throughout Remote Shader Compiling #jira UE-53033 Change 3886441 by Cosmin.Sulea UE-54598 - Using an Invalid iOS Mobile Provision does not give descriptive error in Project Launcher, IPhonePackager #jira UE-54598 Change 3886427 by Sorin.Gradinaru UE-54139 Possible crash with new virtual keyboard on Android if suggestions not disabled - from //Dev-Mobile@CL3843552 #4.19 #Android #jira UE-54139 S8 on 7.0 is not hiding suggestions and disabling predictive input. There are cases with this that can cause a crash. Fix: On text change, downgrade to simple suggestions all the easy correction spans that are not a spell check span (remove android.text.style.SuggestionSpan.FLAG_EASY_CORRECT flags) Change 3886210 by Ethan.Geller [Release-4.19] #jira UE-53867 Ensure we don't read off into garbage memory for uncompressed PCM. Change 3886005 by Zak.Parrish Checking in faceAR work on behalf of 3Lateral #jira none Change 3885925 by Mike.Erwin Material preview label off-center on HiDPI screen #jira UE-52533 Change 3885778 by Dan.Oconnor Fix stepping over collapsed graph and macro nodes #jira UE-54950, UE-54955 Change 3885713 by Mike.Erwin glTF: fix material using wrong textures Imported material could plug the wrong textures into its inputs. The previous code tracked a material's textures based on image source index, corrected code uses texture (source + sampler) index. This is more general allowing an image to be referenced by multiple textures. Bug reported yesterday via email, demonstrated using the Khronos TextureSettingsTest sample model. #jira none Change 3885603 by Ben.Marsh Fixes for compiler errors in nightly builds of VS2017 in /permissive- mode. #jira Change 3885566 by Phillip.Kavan Fix a scoping issue related to inaccessible property reference caching in nativized Blueprint code. Change summary: - Modified FDefaultSubobjectData::EmitPropertyInitialization() to utilize the FScopeBlock utility to manage the inaccessible property cache during code generation for instanced subobject initialization. #jira UE-55061 Change 3885481 by Mark.Satterthwaite Attempt to workaround an Intel shader compiler bug without reopening a related AMD bug. This may cost performance unless function constants are available and the runtime compiler actually bothers to perform optimisation (AMD's did not in 10.12.6 and earlier). #jira UE-54333 Change 3885461 by Lauren.Ridge Fix for slot not being initialized to null #jira UE-55069 Change 3885455 by zak.parrish Adding initial files for FaceAR scene lookdev #jira none Change 3885446 by Zak.Parrish Adding test assets for Gremlin look dev. May get removed later prior to release. #jira none Change 3885424 by Krzysztof.Narkowicz Fixed skeletal mesh LODs inside editor. If skeletal mesh wasn't recently visible, code was incorrectly changing LOD settings without updating LOD data on render thread. #jira UE-53861 Change 3885406 by Zak.Parrish Rollback //UE4/Release-4.19/Samples/FaceARSample/Content/UI/FaceARDebugUI.uasset to revision 1 #jira UE-54639 Change 3885340 by Arne.Schober REL - Bitarray FindFromLast was masking incorrectly for the corner case where there is no slack #jira none Change 3885143 by Marc.Audy Merge memory corruption fix in CL# 3884991 from Fortnite-Staging to Release-4.19 #jira UE-54977 #jira UE-54976 #jira UE-54898 Change 3885093 by Mark.Satterthwaite Apple don't like testing for the validation layer in iOS App Store builds - it is unnecessary so we can disable this for shipping builds. #JIRA N/A Change 3884622 by Jurre.deBaare Moving over missing file from changelist for UE-54508 #jira UE-54508 Change 3883391 by Nick.Atamas Fix for UE-54622 : PIE in VR available when ARKit/ARCore plugins enabled. Only create ARKit/ARCore tracking systems on iOS/Android. #jira UE-54622 Change 3883257 by Phillip.Kavan Fix a Blueprint compile error for the GetClassDefaults node Map value outputs introduced by stronger type checking in 4.19 between Map pin types. #jira UE-55026 Change 3883024 by Lauren.Ridge Fixing static analysis warning #jira SA Change 3882510 by Michael.Dupuis #jira none : Fixed screen size calculation to take aspect ratio into account correctly Change 3882502 by Lauren.Ridge Fix for material layer parameters not rebuilding and adding save child button #jira UETOOL-1275 Change 3882458 by Krzysztof.Narkowicz Copying cached shadow map assert fix from Fortnite-Main (CL3802813) #jira UE-54747 Change 3882366 by Michael.Karambelas QAGame: made changes to QABP_Debugging, QABP_FunctionLib, and QA_TestHelper for Blueprint debugger tests. #jira UE-29618 Change 3881971 by andrew.porter QAGame: Removing actor from Shot_003 #jira UE-29618 Change 3881795 by Krzysztof.Narkowicz Added encoded HDR reflection capture cooking if targeting ES 2.0/3.1 on Windows #jira UE-53875 Change 3881550 by David.Hibbitts #JIRA UEENT-879 Subject frames now store world time explictly as a double with optional scene timecode as MetaData. This allows for use cases such as posing a single frame in Maya where the world time would be changing but the scene timecode associated with the animation remains fixed. THIS IS A BREAKING CHANGE: Sources from before this change will no longer compile. Change 3881339 by Jurre.deBaare Moving over: "Editor crashed when attempting to bake out all the material channels #jira UE-54508 #misc small UDN Merge actor / bake material fixes Change 3879557 by Dan.Oconnor Fix stepover behavior when no debug target is selected #jira UE-54978 Change 3879485 by Mike.Beach Limiting the number of stereo layers on Oculus android to 4 (otherwise, their lib crashes). #jira UE-54999 Change 3879438 by David.Hibbitts #JIRA UEENT-880 Added support for Subject level MetaData to LiveLink #rb martin.wilson #fyi james.golding, simon.tourangeau Change 3879343 by Lina.Halper Last min change that skiped compiling #jira: none Change 3879337 by Lina.Halper Fix issue where tick is skipped due to last ticked pose isn't cleared after AnimInstance changes. #jira: UE-54806 Change 3878968 by Phillip.Kavan Fix deprecation warnings in compiled stub class wrapper codegen for Blueprint class dependencies excluded from nativization. Change summary: - Modified FBlueprintCompilerCppBackendBase::GenerateWrapperForClass() to const-correct the assignment of cached weak pointers to referenced properties. #jira UE-54981 Change 3878962 by Adrian.Siminciuc https://jira.it.epicgames.net/browse/UE-54831 (No error occurs accepting if Android SDK license file cannot be written, but user cannot accept license) #4.19 #jira UE-54831 #android - shows an error message box informing that the license file could not be written. Change 3878821 by Andrew.Rodham Sequencer: Fixed overlapping ranges being inserted into the evaluation field during compilation - The issue was that track segments that had been combined with adjacent segments (due to them being identical) would potentially cause a subsequently compiled frame to overlap with a range that had already been inserted into the evaluation field. - The insertion code previously asserted that only minor overlaps were catered for (due to fp rounding errors) and assumed that a supplied range could not entirely contain any other range in the field. - The solution is to supply the insertion time along with the range to know exactly where the data should live in the field, and crop the range to the maximum allowable space between adjacent ranges. #jira UE-54922 Change 3878171 by Chris.Phillips Android: Fixed crash after splash screen when using Vulkan. #jira UE-54299 Change 3877950 by Ethan.Geller Fix copyright information from previous CL #jira none #rb none #lockdown Cristina.Riveron Change 3877859 by Nick.Shin rebuilt lighting for TM-ShaderModels and resaved the level #jira UE-53374 Client displays "lighting needs to be rebuilt (1 unbuilt object(s))" when launching TM-Shadermodels onto HTML5 Change 3877854 by tim.gautier Adding additional (temp) ML Test asset #jira UE-29318 Change 3877609 by Ethan.Geller [4.19] Change FWhiteNoise generate function to use SRand, due to weird distribution in FRandRange #jira UE-54965 #rb aaron.mcleran #lockdown cristina.riveron Change 3877474 by Lauren.Ridge Adding WITH_EDITOR wrappers to editor-only section of code #jira fixingcompiles Change 3877271 by Arne.Schober REL - Integrate 3872827 - The VFs are not owners of the data, e.g the underlying Buffers might be released before this and this reference counting should not be neccessary #jira none Change 3877260 by Lina.Halper If revision is too far away, ignore the request and send current buffer - this is exactly how it used to do and it is still required, but this means motion vector will be ignored when this happens #jira: UE-54398 Change 3876950 by Lauren.Ridge Renaming layers in a material instance - from 4.19 preview feedback #jira UETOOL-1296 Change 3876932 by Arciel.Rekman Linux: updated the link to the cross-toolchain (UE-54597). #jira UE-54597 Change 3876918 by Phillip.Kavan Fix a regression that could cause packaging to fail and/or data loss with Blueprint nativization enabled. Change summary: - Removed logic that attempted to avoid redundant assignments of instanced default subobject references. This was not compatible with editinline characteristics that can allow certain object reference values to be overridden by the Blueprint class. - Explicitly defer to ExportTextItem() when generating C++ code for UObjectProperty/UInterfaceProperty reference values in which the underlying object reference is NULL. #jira UE-54870 Change 3876759 by tim.gautier Updated Material Layer test assets to include Opacity and Emissive. #jira UE-29318 Change 3876575 by Michael.Karambelas Updating the QABP_Debugging asset in QAGame with a couple of interfaces and additional logic for testing purposes. #jira UE-29618 Change 3876406 by Robert.Manuszewski Fixed a crash when reporting linker errors #jira UE-51037 Change 3875891 by Nick.Atamas Fixed scenario where geometries were being updated once per pin, instead of just being updated once. Also fixes a scenario where there are no pins and geometries fail to update. #jira UE-54914 Change 3875880 by Aaron.McLeran #jira UE-54916 Fixing up submix effect templates Change 3875673 by Brandon.Schaefer Fix Apex dependencies Depend on static Apex libraries in Apex.Build.cs versus Physx.Build.cs #jira UE-54861 Change 3875498 by Lauren.Ridge PR #4477: 4.19 Fixed a crash caused by the layered material property widget of the material instance editor. (Contributed by mlaveaux) #jira UE-54862 Change 3875322 by tim.gautier Recreating Material Layer test assets (asset version has changed) #jira UE-29318 Change 3875157 by Aaron.McLeran #jira UE-54901 Synth components do not allow sends to buses Change 3875103 by Brandon.Schaefer Need to use our bundled libc++.so not libstdc++.so when building Apex/PhysX/NvCloth libraries #jira UE-54815 Change 3875037 by Aaron.McLeran #jira UE-54896 Fixing up audio capture component to parameterize the delay Parameterize the jitter latency delay. Change 3875026 by Aaron.McLeran #jira UE-54895 Filter frequency values don't update live with EQ effects and 0-frequency cutoff causes pops Change 3874927 by Ryan.Vance #jira UE-54894 Ensure we don't delete aliased texture resources, they are managed externally. Change 3874925 by Martin.Wilson Remove XR post fix from live link code written during motion controller integration #jira none Change 3874354 by Ben.Marsh Use the compiler matching the user's preferred IDE if they don't have a specific compiler selected in the project settings. #jira UE-54272 Change 3877545 by Ben.Marsh Replace FPlatformMisc::DebugBreak() with the UE_DEBUG_BREAK() macro. VS2017 is able to show force-inlined calls on the callstack, which makes debugging asserts and ensures annoying. Use similar logic for expanding ensure() macros in place. #jira UE-54961 [CL 3963579 by Ben Marsh in Main branch]
2018-03-24 09:22:20 -04:00
{
return true;
}
virtual void GetShaderCompilerDependencies(TArray<FString>& OutDependencies) const override
{
}
/** Helper method to fill a dependencies array for the shader compiler with absolute paths, passing a relative path to the Engine as the parameter. */
static void AddDependencySCArrayHelper(TArray<FString>& OutDependencies, const FString& DependencyRelativePath)
{
IPlatformFile& PlatformFile = FPlatformFileManager::Get().GetPlatformFile();
FString DependencyAbsolutePath = PlatformFile.ConvertToAbsolutePathForExternalAppForRead(*(FPaths::EngineDir() / DependencyRelativePath));
FPaths::NormalizeDirectoryName(DependencyAbsolutePath);
OutDependencies.AddUnique(DependencyAbsolutePath);
}
Copying //UE4/Release-Staging-4.19 to //UE4/Dev-Main (Source: //UE4/Release-4.19 @ 3944462) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3944462 by Jack.Porter Prevent TVOS packaging from PC from attempting to build an asset catalog #jira UE-56114 Change 3943602 by Leslie.Nivison Adding licenses for additional TPS #jira none Change 3943597 by Leslie.Nivison Adding Enterprise licenses; licenses for additional TPS. #jira none Change 3941962 by Leslie.Nivison Updating 4.19 credit list #jira none Change 3941865 by Mark.Satterthwaite Fix the incorrect landscape rendering and the incorrect render-to-texture from blueprint bugs with MetalRHI. - Track outstanding AsyncCopyBufferFromBufferToBuffer operations to identify attempts to modify overlapping ranges within the same prologue command-buffer. This doesn't work and requires that we break the current render-pass and issue on the current command-buffer. A log warning will be emitted when this occurs. - Don't attempt to alias private memory buffers the moment they are released from the RHI resource because that can lead to incorrect sharing of the memory when used by AsyncCopyBufferFromBufferToBuffer. #jira UE-56021 Change 3940993 by Marc.Audy Do not return the last column if the specified column does not exist. Allow display names to be used when looking for a property if the table is backed by a user defined struct. Do not crash if a property with the given name is not found. #jira UE-56017 Change 3939179 by Ben.Marsh Revert change to not poison memory in development configuration. Making a tradeoff that editor stability and consistency is more important than performance. #jira Change 3938566 by Aaron.McLeran #jira UE-55940 Fix for wavetable synth Missed a case. Change 3938533 by Dan.Oconnor Fix uninitialized variable exposed by recent MallocTBB change #jira UE-56013 Change 3938508 by Aaron.McLeran Fixing CIS error, init order issues. #jira UE-55940 Change 3938490 by Aaron.McLeran #jira UE-55940 Fix for wavetable synth Change 3938352 by josh.jensen Show an error message for Windows iOS builds when packaging/launching and icons are present but no remote Mac is specified #jira UE-55987 Change 3938345 by Peter.Sauerbrei fix to Icons not being built on Mac #jira UE-53492 Change 3938305 by Mark.Satterthwaite For whatever reason moving the buffer initialisation into the prologue command buffer doesn't work - this make absolutely no sense to me. I suspect that this is *merely* moving a render pass boundary around somewhere and forcing raster-state to be reapplied. #jira UE-56005 Change 3937968 by Ben.Marsh Disable the boot DDC if we're not in the editor. Fixes access violations when multiple SCW instances attempt to read/write to the same file. #jira UE-56003 Change 3937573 by Mitchell.Wilson Saving asset to resolve empty asset warning. #jira UE-56004 Change 3937561 by Max.Preussner ImgMedia: Added support for single-threaded platforms Copied from Dev-Sequencer CL# 3937516 #jira UE-55986 Change 3937305 by Mike.Beach Resaving google VR model content with UGS build to fix the empty file version error. #jira UE-55984 Change 3935595 by Arne.Schober Fix missing UV precission on BSP surfaces #jira UE-54014 Change 3935411 by josh.jensen Fixed Windows iOS remote Mac build issue where the user icons were considered remote Mac compilation targets coming solely from the Engine directory #jira UE-55899 Change 3934982 by Marc.Audy Fix shadow variable issue #jira UE-55957 Change 3934892 by Mark.Satterthwaite In MetalRHI treat BUF_Volatile buffers as Shared or Managed memory in all circumstances so that multiple updates within a render pass are respected even though this will hurt CPU performance. This fixes GPU particles on macOS. Also push initialisation upload into the async. command buffer to avoid it overwriting a later Lock/Unlock! Only read-back and copy-buffer operations should be on the 'current' command buffer as they need to be inline with all outstanding commands. #jira UE-55956 Change 3934421 by Arciel.Rekman Fix lockup/OOM when setting audio sources to 2 (UE-53968). #jira UE-53968 Change 3934156 by Peter.Sauerbrei fix for backgrounding problems on iOS and tvOS this will re-open UE-50979 as the fix for that was not correct and would have caused crashes when backgrounding during startup #jira UE4-55609 Change 3933547 by Aaron.McLeran #jira UE-55940 Fix for wavetable sample duration and seek Change 3933544 by Aaron.McLeran #jira UE-55939 Hiding channel format Submix channel format is an experimental feature and shouldn't be exposed to the submix editor for 4.19. Change 3933540 by Aaron.McLeran #jira UE-55718 Fix for playback progress. Change 3933280 by Ethan.Geller [Release-4.19] #jira UE-55810 Ensure AudioComponent is created before we start using it. #rb Aaron.McLeran Change 3933079 by Ryan.Vance #jira UE-55936 Fixed missing referenced uniform bindings on AR pass-through camera shaders. Change 3932319 by Ben.Zeigler #jira UE-55885 Fix corruption of packages when starting and then cancelling an async load of a package that already exists, or attempting to async load a script package It now keeps track of which packages were created by the async load system and will only throw those away on cancel Copy of CL #3932312 Change 3932287 by Matt.Kuhlenschmidt Updated substance texture #jira UE-55081 Change 3931729 by josh.jensen Ensure the tvOS and iOS Assets.car is always produced as part of a regular remote/local build #jira UE-55899 Change 3929723 by josh.jensen Removed packaging requirement on Windows of a remote Mac after setting an app icon to default #jira UE-53495 Change 3929722 by josh.jensen Fixed iOS asset catalog generation issues when swapping out/resetting to default app icons for both code- and BP-projects #jira UE-53492, UE-51879 #robomerge Change 3929350 by Mike.Erwin "Save As" support for #jira UE-55732 Change 3927829 by Steve.Robb Out-of-memory handler for MallocStomp. #jira UE-55550 Change 3926404 by Mike.Erwin #jira UE-55732 Change 3926394 by Dan.Oconnor Recompile bytecode dependencies when compiling an individual blueprint interface, this prevents crashes due to stale bytecode #jira UE-55813 Change 3926098 by Guillaume.Abadie Do not allow dynamic resolution to be enabled on unsupported platforms avoiding game breaker experience by security. #jira UE-55697 Change 3925927 by Guillaume.Abadie Enables TAA's AA_BORDER on all permutation for dynamic resolution. #jira UE-55353 Change 3925882 by Matt.Kuhlenschmidt Fix substance uri having one extra / Fix substance menu option showing up for github (incompatible with plugin) #jira UE-55766 Change 3925873 by Ben.Zeigler #jira UE-55783 Fix issue introduced in 4.18 where user structs did not handle converting AssetPtrs to SoftObjectPtrs properly Copy of CL #3925871 Change 3925163 by Guillaume.Abadie Fixes DFAO's temporal AA passes that was handling FViewInfo::ViewRect.Min wrongly. #jira UE-55788 Change 3924839 by Guillaume.Abadie Fixes a crash of LDR android preview with OS DPI scale != 0. #jira UE-43622 Change 3924542 by Cosmin.Sulea Merged fixes: UE-55299 - XGE Shader Compile Interferes with Remote Shader Compiling Causing Materials to Fail to Compile #7 UE-51086 - No clear editor activity during remote shader compiling #jira UE-55299 Change 3922398 by Mark.Satterthwaite Compile fix for 3922273. #jira UE-53993 Change 3922273 by Mark.Satterthwaite Fix validation error caused by the game updating its orientation before the drawable system catches up. We need to drop drawables that are incorrectly sized until we get one with the correct size. #jira UE-53993 Change 3921127 by Ethan.Geller [Release-4.19] #jira UE-55744: Add OnTick virtual to IAudioPluginListener, fix thread safety issue in Resonance Audio. #rb aaron.mcleran Change 3920632 by Lina.Halper Fix render thread crash when morphtarget is deleted or added #jira: UE-55521 Change 3920557 by Lauren.Ridge Fixing material editor resetting background to off #jira UE-55267 Change 3920519 by Phillip.Kavan Fix a regression in which elements would not be initialized when constructing the value assignment for UDS-typed container members in nativized Blueprint C++ code. Change summary: - Modified FEmitDefaultValueHelper::InnerGenerate() to remove UDS from the list of special cases that avoid calling InitializeStruct() as part of new element construction. Previously the conversion code assumed the compiler would perform value initialization of a nameless temporary, but that is no longer valid in 4.19, as UDS types have been changed to function more like native structs, and as such all converted UDS types will now emit an explicit default ctor which is now used to assign defaults that differ from the zero-initialized value. #jira UE-55628 Change 3920476 by Michael.Trepka Clean up Mac menu item cache at exit before SlateApplication is fully destroyed. #jira UE-55599 Change 3920336 by Ben.Marsh Ignore license warnings from PVS-Studio. #jira UE-55729 Change 3920134 by Jurre.deBaare Moving over: "HLOD: Building HLOD for P map with sublevels requires HLODSetupAsset when it should not #fix Ensure that we dynamically add HLOD level treeview items whenever they are required, rather than adding a static number of levels according to the worldsettings" #jira UE-55619 Change 3920126 by Max.Preussner MediaCompositing: Implemented media track for Sequencer Copied from Dev-Sequencer #jira UE-53974 Change 3920004 by Jack.Porter Disable Manual Vertex Fetch SRV creation when MVF is disabled. Made a single RHISupportsManualVertexFetch(EShaderPlatform) to control whether to use MVF. The Shader Platform (or alternatively, feature level) is the only thing that can decide whether or not to use MVF because we need to know when we compile the shaders if we're going to do MVF or not. Checking GSupportsResourceView at runtime is useless because the shaders can't change and so if GSupportsResourceView can ever be false for a platform, the shaders need to have been built without it. Creating SRVs without using them on mobile is not harmless because several devices don't support formats that are needed. #jira UE-54764 #jira UE-55622 Change 3919069 by Aaron.McLeran #jira UE-55718 Fix for playback progress. Change 3918942 by Graeme.Thornton Added "ProjectBuildMutatorFeature" modular feature, allowing plugins to register said feature and dictate whether the current project requires a code build. CryptoKeys plugin uses this feature to force a code build when encryption or signing is enabled. #jira UE-55686 Change 3918721 by Zak.Parrish Lighter version map for Gremlin + new Engine.ini - result is 60Hz #jira none Change 3918236 by Joe.Graf Added a bFlipTrackedRotation to give a better result when mirroring the rotation of a tracked face #jira: UE-55531 Change 3917970 by Martin.Wilson Expose curve data in remap assets to blueprints #jira UE-55585 Change 3917740 by Olaf.Piesche Properly checking for presence of buffer SRV capability via GSupportsResourceView so ES3.1 and Metal devices don't crash using GPU particles (and possibly in other circumstances); #jira UE-55591 Change 3917713 by Cody.Albert Build fixes for Match3 on iOS #jira UE-53742 Change 3917472 by zak.parrish added mouthPressLeft and MouthPressRight back into debug screen #jira none Change 3917244 by Michael.Dupuis #jira UE-35097: Fixed crash when creating a new landscape with 2x2 subsections and material containing grass spawning node Change 3916775 by Ben.Marsh Add missing files for packaging IOS on Windows. #jira UE-53873 Change 3916293 by Joe.Graf Removed the redundant GetTransform() from UARFaceGeometry since GetLocalToWorldTransform() is exposed on a base class #jira: UE-55531 Change 3916011 by Joe.Graf Added an accessor to get the transform of the face mesh or a face mesh component #jira: UE-55531 Change 3915967 by Mark.Satterthwaite Place buffer updates into the prologue command-buffer in MetalRHI to avoid breaking the current command-encoder. This improves performance, though the semantics of Metal now differ subtly to other RHI implementations as the buffer updates happen prior to the SetRenderTargets call in the GPU's view of the world. #jira UE-54858 Change 3915751 by Nick.Atamas Merging CL 3913931 from //UE/Partner-Google-VR/... to //UE4/Release-4.19/... #jira UE-55639 Change 3915421 by Martin.Wilson Fix crash from live link message bus heartbeat manager #jira UE-55644 Change 3915326 by Dan.Oconnor Make compilation manager's skeleton class layout better match the old compilation path's skeleton class layout, fixes a crash when renaming blueprint functions #jira UE-55592 Change 3915250 by JeanLuc.Corenthin Can't add C++ code to Enterprise projects (when enterprise is installed) Root cause: When compiling a C++ project, Datasmith modules are included in the build process (with the wrong path) Fix: - Added two more Enterprise directories, Plugins and Intermediate, to the Enterprise directories to check against - Build the correct path for the Datasmith modules and plugins in FindOrCreateModuleByName. Added check to see if module is under one of the Enterprise directories. - Added modules to list of precompiled modeules in UEBuildTargets.AddPrecompiledModules if Engine and Enterprise are 'installed and the module is under Enterprise. #jira UEENT-1032 Change 3915240 by Ben.Marsh Reduce editor startup times by ~15s on Windows. Platform loading code recursively scans every module for dependent DLL modules to load first. Change to make it early-out as soon as it encounters a module which is already in memory (via a call to GetModuleHandle() from ResolveMissingLibraryImportsRecursive). Also use a TSet<> to store set of visited modules rather than an Array. Now spends <0.1s total in this function on editor startup. (Change looks larger than it is due to moving functions out of WindowsPlatformProcess.h to avoid introducing TSet dependency into this header). #jira UE-55642 Change 3914803 by Gil.Gribb UE4 - Removed memory track from the lock free list links. This is not safe and will sometimes assert in debug. #jira UE-49600 Change 3914616 by zak.parrish Adding Calibrate button #jira none Change 3914599 by Andrew.Rodham Sequencer: Sequence template source signatures are now also compared to catch the case where a sub-sequence asset has been saved but not modified - The following sequence of events exposes this issue: - Create a master sequence with a single shot that spawns a cube - Add this sequence to a level and set it to auto-play - Save everything and restart - Resave just the inner shot asset without opening it - PIE - The inner shot never spawns its cube because its template was wiped on save, but its signature never changed. Since the master sequence previously didn't check the template source signature, it ends up trying to evaluate an empty template. #jira UE-55626 Change 3914479 by Krzysztof.Narkowicz Added encoded HDR reflection capture cooking if targeting ES 2.0/3.1 on Windows #jira UE-53875 Change 3914347 by Martin.Wilson Stop anim preview instance from ever running in parallel #Jira UE-55577 Change 3914179 by Benn.Gallagher Fixed clothing sections not displaying in LOD section list in skeletal mesh editor, due to no longer duplicating clothing sections in the model data. #jira UE-55528 Change 3914122 by Steven.Barnett Fix perf regression in BSP queries by changing suppression of PhysX mesh cleaning failure message. #jira UE-54081 Change 3913950 by zak.parrish Clamping my normalization math #jira none Change 3913926 by Zak.Parrish First pass at Gremlin Calibrate button. Also added shirt/backpack to boy so he's not a floating head. #jira none Change 3913668 by Matt.Kuhlenschmidt Adding missing substance styling info #jira UE-55081 Change 3913667 by Nick.Atamas Merging CL 3912976 from //UE4/Partner-Google-VR/... //UE4/Release-4.19/... Upgrading to support ARCore 1.0 runtime. #jira UE-55602 Change 3913645 by Aaron.McLeran #jira UE-55618 fix for mono audio devices Change 3913509 by Cody.Albert Removing PhsX build exclusion from Match3 #jira UE-53742 Change 3913380 by Dan.Oconnor Preload Sequence Bindings node at proper time #jira UE-55412 Change 3913300 by Mitchell.Wilson Updating iOS default startup movie to H.264, 1280x720, 30 fps. #jira UE-55382 Change 3913291 by Cody.Albert More iOS build fixes for Match3 #jira UE-53742 Change 3913169 by Cody.Albert Fixed iOS build issues for UnrealMatch3 #jira UE-53742 Change 3913131 by Krzysztof.Narkowicz Fixed remaining quad overdraw viewmode contents on screen after switching to certain other viewmodes (e.g. light overlap or complexity) #jira UE-54580 Change 3912851 by Lina.Halper Fixed issue with pose asset blending additively multiple poses suming up to 1 weight. #jira: UE-55603 Change 3912629 by Guillaume.Abadie Fixes SSR that was computing vigneting according to PrevScreen that could let some outside viewport samples going through when rotating the camera. #jira UE-55353 Change 3912170 by Martin.Wilson Add logging for UE-55511 (NaN crash) #jira UE-55511 Change 3912161 by Phillip.Kavan Fix editor-only default subobjects inherited from a native C++ parent class not being handled correctly during nativized Blueprint class ctor generation. Change summary: - Modified FEmitDefaultValueHelper::HandleSpecialTypes() to skip editor-only checks for instanced default subobjects. These will have already been created by a native parent class. - Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert before creating a "dummy" component in place of an editor-only instance if we're not supposed to be creating it. #jira UE-55474 Change 3912100 by Luke.Thatcher [RELEASE] [^] Merging (as edit) fix for building pak patches (CL 3911754) from //UE4/Dev-Core to //UE4/Release-4.19 #jira UE-55340 Change 3912072 by Mike.Beach Art cleanup pass on AR template icon. #jira UE-55587 Change 3912057 by Michael.Trepka Additional widget path validity check in FSlateUser::NotifyWindowDestroyed() #jira UE-55580 Change 3911592 by Jurre.deBaare Crash on merge actor when Use specific LOD Level #fix make sure we use the correct array to determine the number of components being merged #jira UE-55508 Change 3911466 by Cosmin.Sulea Mega change list for the following related issues: UEMOB-417 - Support Xcode automagical code signing UE-49829 - Remote build fails to use / sign distribution provisions coming from PC UE-39501 - Packaging for tvOS in Distribution fails to find valid provision UE-55334 - XCode managed provisions don╞t operate gracefully with manual provisions UE-55330 - Automatic signing doesn't work with tvOS UE-10969 - Remote build fails if there is no development provision provided #jira UEMOB-417 Change 3911454 by Luke.Thatcher [RELEASE] [!] Fix rendering thread memory leak in FLandscapeComponentSceneProxy::InitViewCustomData - FViewCustomDataLOD is allocated on a memstack, but contains a TArray, so is not trivially destructible. - The SubSections array is leaked when the memstack is popped. - Fix replaces the TArray with a TStaticArray of max size MAX_SUBSECTION_COUNT (which is 4). (Merging as edit CL 3911422 from //Fortnite/Release-3.1/... to //UE4/Release-4.19/...) #jira UE-54835 Change 3911370 by Dragan.Jerosimovic changed browOuterLeft -> browOuterUpLeft, browOuterRight->browOuterUpRight updated KiteBoyHead_JointsAndBlends.fbx #jira none Change 3910545 by Dan.Oconnor PR #4512: Fix FNetNameMapping::GetUniqueName regression (Contributed by dfb) #jira UE-55513 Change 3910449 by Michael.Trepka Fix for crash on exit on Mac when closing the root editor window with Cmd+W #jira UE-54973 Change 3909601 by Patrick.Boutot Expose to Blueprint GetProjectDirectory functions. #jira UE-55548, UEENT-999 Change 3909543 by Patrick.Boutot Rename ECollisionResponse to CollisionResponseType in script to prevent collision with FCollisionResponse. Python's help function now output the Python type instead of the cpp type. Do not export hidden enum entry from Python. #jira UE-55545, UEENT-961 Change 3909289 by Zak.Parrish Adding shirt/chest to faceAR sample #jira none Change 3908808 by Dragan.Jerosimovic added combination shapes network #jira none Change 3908788 by Mitchell.Wilson Updaing Match3Camera to resolve clipping issue on iPhone X #jira UE-54723 Change 3908374 by Jack.Porter Fix viewport offset problem for preview PIE window #jira UE-52583 Change 3907108 by Shane.Caudle #JIRA Added DefaultDeviceProfiles.ini to set the [IOS DeviceProfile] +CVars=r.ShadowQuality=4 Change 3907105 by Lauren.Ridge Fix for thumbnails not resetting when layers/blends reset and for them being incorrectly scaled when null #jira UETOOL-1303 Change 3907011 by Chris.Phillips UE-52667 Unable to package an Android DLC Using "Android APK" and "Android DLC" profiles in Project Launcher. #jira UE-52667 Change 3906792 by Lauren.Ridge When constructing the material editor viewport, use the direct method to set the environment visibility. #jira UE-55267 Change 3906734 by Chris.Babcock Fix issue with vertex fetch disable #jira UE-55475 Change 3906721 by Rolando.Caloca UE4.19 - Check if the results file from SCW is corrupt #jira UE-53124 Change 3906648 by Chris.Phillips UE-53184 Assertion when running mobile PIE in iPhone 5S mode. Updated the iPhone5s.json Metal settings. #jira UE-53184 Change 3906474 by David.Hibbitts Added default constructor for FLiveLinkWorldTime. #jira UEENT-879 #rb none Change 3906467 by Lauren.Ridge Swapping sibling materials now correctly swaps the overridden parameters out #jira nojira demobug Change 3906156 by Michael.Trepka Reverting CL 3728924 as it's causing problems with modal windows. A different, much more involved fix for UE-51711 will be needed. #jira UE-52492 Change 3906144 by Michael.Dupuis #jira UE-54547: Added guard to be sure that material is valid Change 3905882 by Matt.Kuhlenschmidt Enable substance buttons again #jira UE-55081 Change 3905513 by Sorin.Gradinaru UE-55394 iOS crash exiting app during startup movie: SPRINGBOARD, process-exit watchdog transgression #jira UE-55394 #jira UE-52328 #iOS #4.19 This is a particular case of UE-52328 iOS reporting crash on application exit: SPRINGBOARD, process-exit watchdog transgression Found several issues on iOS if the game is forced closed when the startup movie is playing and "Wait for movies to complete" is enabled in Project Settings - the game thread is waiting for the movie to complete on game shutdown - more that 5 sec - crash on FDefaultGameMoviePlayer::Shutdown if the above is fixed - HTTP module no longer has time to wait for the requests to complete. Change 3905506 by Michael.Dupuis Remove static mesh instancing async buffer filling, as with all the changes made, it's no longer necessary, the cost of loading very large buffer is negligable Rebuild the occlusion tree when using foliage.DensityScale with something other than 1.0 #jira 0 Change 3905498 by Lina.Halper Fix multiple pose asset issue - fallout from CL 3903509 - as for fullbody, went back to old mathod because in the fullbody, we want shortest path most of times and you don't blend more than 1 weight, so this is likely fine - as for additive, change to use blend from identity. #jira: UE-55439, UE-55448, UE-55250 Change 3905325 by Sorin.Gradinaru UE-54764 UnrealMatch3 spams Kindle device log with "Unsupported EPixelFormat" #jira UE-54764 #4.19 Also reproduced on Samsung Galaxy S5 Neo (SM-G903F, GPU Mali-T720). Check GMaxRHIFeatureLevel > ERHIFeatureLevel::ES3_1 (not mobile) before creating RSV params used with SupportsManualVertexFetch: (Positions, Tangents, TextureCoordinates, Color buffers) Change 3905307 by Jack.Porter Removed iPhone5 PIE json file as it's not a supported device #jira UE-53184 Change 3905132 by Shane.Caudle #JIRA Pushed it a little more out of the yellow. Change 3905117 by Shane.Caudle #JIRA Got SSS working and made some tweaks. Change 3904936 by Max.Chen Fix editor only #jira UE-55459 Change 3904269 by Chris.Babcock Disable manual vertex fetch on mobile #jira UE-55389 #ue4 #android #ios Change 3904186 by Lina.Halper Pose asset crash when skeleton not existing during serialization #jira: UE-55422 Change 3904063 by Max.Chen Sequencer: Fix copy/paste crash. Only process UMovieSceneCopyableBinding and objects that can be spawned by the movie scene spawn register. Copy from Dev-Sequencer #jira UE-55314 Change 3904060 by Lauren.Ridge Fix for saving a child out of a layer stack capturing the wrong parameters #jira UETOOL-1280 Change 3904050 by Luke.Thatcher [CONSOLE] [^] Added RHI Command List Enqueue Lambda method (merging as edit CL 3879722 from //Fortnite/Main to //UE4/Release-4.19) - Can be used to enqueue arbitrary tasks on the RHI thread from the render thread (similar to how EURC works for GT -> RT tasks), without having to write lots of bolierplate FRHICommand functor classes. - The first overload of EnqueueLambda method will check Bypass() to determine if it should run the lambda immediately or defer to the RHI thread. - This can be overriden via the 2nd overload if you need to check additional things such as IsRunningRHIInSeparateThread. - The function returns true if the lambda was enqueued and deferred to the RHI thread, otherwise false. This can be used to optionally add RHIThreadFences for unlock commands etc. #jira UE-55437 Change 3904004 by Lauren.Ridge Fix for material layer output nodes being able to be placed in other graphs #jira UE-54867 Change 3903931 by Aaron.McLeran #jira UE-55435 Crash in google resonance when toggling visualization fix for issue described here -- https://github.com/resonance-audio/resonance-audio-unreal-sdk/issues/1 Change 3903722 by David.Hill The ProxyLOD plugin is experimental: don't load it by default. #jira: ue-55402 Change 3903583 by Ben.Marsh Include .version and .modules files in manifest. Should fix missing version information in precompiled binaries. #jira Change 3903529 by Richard.Hinckley #jira UEDOC-7180 4.19 API Documentation manual update. Change 3903509 by Lina.Halper Merging using //UE4/Dev-AnimPhys/->//UE4/Release-4.19/ #DUPE MERGE: Fix issue with pose blending with shortest path - causing additive to blend linearly between pose if the rotation is same direction. #jira: UE-55250 Change 3903501 by Michael.Dupuis #jira UE-55122: Fixed bad neighbors updating for mobile Change 3903387 by Will.Fissler ; r.XGEShaderCompile is now enabled by default in source. Uncomment to disable XGE shader compilation. ;r.XGEShaderCompile = 0 #jira UE-55286 Change 3903251 by Sungjin.Hong #JIRA UE-55349 #loc added KO locallization for VR, Handheld AR templates Change 3903219 by Adrian.Siminciuc https://jira.it.epicgames.net/browse/UE-54738 removed redundant iOS warning when IOnlineIdentity::Login is called by FOnlineExternalUIIOS::ShowLoginUI #jira UE-54738 #iOS Change 3903130 by Cody.Albert Updated build configuration to resolve iOS build error on UnrealMatch3 #jira UE-53742 Change 3903056 by Shane.Caudle #JIRA Latest tweaks to lighitng and rendering for boy. Change 3903032 by Cody.Albert Added missing include that was preventing iOS builds from succeeding on TopDown template #jira UE-54341 Change 3902669 by Lauren.Ridge Fix for thumbnail crash after saving material instances that contain layers #jira crash Change 3902581 by Mitchell.Wilson Updating Samples and Template Min iOS Version to iOS 9. #jira UE-55148 Change 3902448 by Lauren.Ridge Fix for crash due to unparented material instance #jira crash Change 3902206 by Chris.Phillips UE-52612 External textures only work in pixel shaders. Sampling external textures are now only limited to pixel shaders when the shader model is < SM4. #jira UE-52612 Change 3902120 by Peter.Sauerbrei bvringing over the fix for backgrounding crash on iPhone X from Fortnite #jira UE-54883 Change 3902097 by Lina.Halper Merging using //UE4/Dev-AnimPhys/->//UE4/Release-4.19/ #DUPE MERGE: CL 3901939 #jira: UE-55401 Change 3902082 by Mike.Beach Fixing an issue with the fix from CL 3889470 - fully matching the old UEnum name check (checking both the value name and the typed name, for example: "Left" and "EControllerHand::Left"). #jira UE-55153 Change 3901963 by Peter.Sauerbrei bring over the fix from Fortnite for Remote Shader Compilation not respecting settings in the passed in shader #jira UE-52797 Change 3901959 by Ethan.Geller [Release-4.19] #jira UE-55225: Stop RtAudio stream on StopRecording in sequence recorder. #rb Aaron.McLaren Change 3901482 by Lauren.Ridge Fix for crash on opening materials due to array out of bounds #jira crash Change 3901181 by Michael.Dupuis #jira UE-55313: To enable tessellation we MUST have 2 materials in the list Change 3900935 by Nick.Bullard Updating Default_Startup.mp4 with more recent UE branding. This still requires another update for final version with audio #jira UE-55382 Change 3900660 by Aaron.McLeran #jira UE-55381 crash in sound submix Bringing fix from FN to 4.19 (CL 3890630) Change 3900643 by Aaron.McLeran #jira UE-55380 fixing synth envelopes Change 3900617 by Aaron.McLeran #jira UE-55151 Fixing crash w/ mic component Change 3900544 by tim.gautier QAGame: Submitting asset for AsNumber fix submitted with UE-10310 #jira UE-29618 Change 3900430 by Ryan.Brucks KismetRenderingLibrary: Applied a fix from FN to make it possible to create textures from BP created RTs. Without the fix the assets would be created but invisible to the user due to missing RF_Public and RF_Standalone. #JIRA none Change 3900399 by Lauren.Ridge Fixing global parameters not working #jira UE-55242 Change 3900297 by Ben.Marsh Speculative fix for hot reload causing version files to be updated with a locally made installed build. #jira UE-55072 Change 3900116 by Chris.Bunner Removing outdated tests and test assets. #jira UETOOL-1298 Change 3900042 by Chris.Bunner Deleted SharedInputCollection and associated material graph nodes. #jira UETOOL-1298 Change 3899887 by Lauren.Ridge Fix for background checkbox stomping profile info for material editor. Note that you may have to delete Saved/Config/Windows/Editor.ini to get this to work. #jira UE-55267 Change 3899824 by Chris.Phillips UE-52813 Editor's mobile preview doesn't serialize the landscape's cooked heightmap data. Now only regenerating landscape pixel data when needed when using Mobile Preview Rendering Levels. #jira UE-52813 Change 3899775 by Lauren.Ridge Fix for crash on opening material layer material #jira crash Change 3899673 by Jamie.Dale Fixed Functions sometimes being exposed to Python as if they were Structs #jira none Change 3899487 by Chris.Bunner Duplicate [CL 3852020, 3896571] - Disabling non-performant code only required by experimental material layers feature. Users can opt-in per-project through experimental renderer settings, replacing the previous editor experimental flag. #jira UETOOL-1298 Change 3899156 by Phillip.Kavan Include address of object reference in persistent frame debug info. #jira UE-51952 Change 3899146 by Rolando.Caloca UE4.19 - hlslcc - Workaround for intrinsics with two output arguments #jira UE-52477 Change 3899060 by Bart.Hawthorne Add a null check for the game mode pointer in UWorld::SpawnPlayActor #jira UE-54461 Change 3899015 by Krzysztof.Narkowicz Fixed initialization of instancing random vertex stream. #jira UE-53605 Change 3899008 by Michael.Dupuis Fix issue with landscape mobile vertex factory accessing unbound LodTessellationParams when r.ShaderDevelopmentMode=1 #jira 0 Change 3898994 by Phillip.Kavan More verbose debug logging if an invalid object reference is detected in the BP ubergraph frame during garbage collection. #jira UE-51952 Change 3898962 by Guillaume.Abadie Fixes wrong parameters about whether GPU timing may have CPU generated bubbles to the dynamic resolution heuristic. #jira UE-55352 Change 3898826 by Sorin.Gradinaru UE-54784 StrategyGame crashes entering game on KindleFire 7 - Assertion failed: ViewSize.GetMin #4.19 #Android #jira UE-54784 Wrong code to make an integer even + operator precedence Change 3898822 by Sorin.Gradinaru UE-52328 iOS reporting crash on application exit: SPRINGBOARD, process-exit watchdog transgression FORT-70783 FHttpManager::Flush is immediately canceling all HTTP requests #jira UE-52328 #jira FORT-70783 #iOS #PC #4.19 UE-52328 reopened because of FORT-70783 iOS only: Delay Request->CancelRequest() on Http module shutdown - wait for 2 sec on FHttpManager::Flush to allow pending requests to be sent to the server. Change 3898705 by Max.Chen Sequencer: Skip if the binding id's sequence can't be found. #jira UE-55337 Change 3898108 by Michael.Dupuis #jira UE-54547: Remove the FORCEINLINE so we get a proper callstack of what's happening Change 3898076 by Max.Chen Sequencer: Override the animation asset in the player state if it doesn't match the animation asset that's being evaluated. #jira UE-55328 Change 3897897 by Matt.Kuhlenschmidt Disable substance buttons for now #jira UE-55081 Change 3897742 by Aaron.McLeran Merging fix for UE-55223 to 4.19 #jira UE-55223 Change 3897538 by Michael.Dupuis #jira UE-53787: Added guard if for some reason the material is null we should not try to draw using this material Change 3897406 by Phillip.Kavan Back out local debug logs. #jira UE-51952 Change 3897400 by Phillip.Kavan Serializing object will now be passed to GC so that it can be logged in case the referenced objects is garbage. - Mirrored from //UE4/Dev-Core (3871863). #jira UE-51952 Change 3897391 by Max.Chen Sequencer: Don't update current time to be within the view range when stepping into a sequence. #jira UE-55322 Change 3897274 by Krzysztof.Narkowicz Fixed issues with loading shaders from DDC - hardcoded CustomAttributes initialization instead of filling them inside UObject costructors in order to properly initialize CustomAttributes before DDC key was created. Added an assert that CustomAttributes are initialized before the AttributeDDCString, so we won't run into this issue again in the future. #jira UE-54683 Change 3897148 by Adrian.Siminciuc https://jira.it.epicgames.net/browse/UE-55147 #4.19 #iOS #jira UE-55147 Change 3897138 by Max.Chen Sequencer: Fix crash when an actor factory is not found. Copy from Dev-Sequencer #jira UE-55309 Change 3897045 by Jack.Porter Fix for crash in ALandscapeProxy::UpdateGrass #jira UE-54362 Change 3897036 by Jack.Porter Fix InstancedStaticMesh crash with invalid lightmap coordinates #jira UE-54423 Change 3896801 by Dmitriy.Dyomin Fixed: Planar reflections does not handle origin rebasing #jira UE-52351 Change 3896743 by Dmitriy.Dyomin Discard CPU copy of vertex/index buffers in OpenGL RHI #jira UE-52133 Change 3896619 by Guillaume.Abadie Cherry-pick 3896598: Fixes after TAAU post process material that had wrong default buffer UV. #jira UE-55317 Change 3895718 by Max.Chen Sequencer: Null checks to prevent crash when saving the default state of a spawnable #jira UE-55304 Change 3895426 by Rolando.Caloca UE4.19 - Add an increased timeout for SCW to avoid OOM situations #jira UE-55306 Change 3895245 by tim.gautier QAGame: Submitting updated test assets. Broke ML_Base out into individual components #jira UE-29618 Change 3895194 by Marc.Audy Prevent crash due to a null entry in the linked to graph of the destination pin #jira UE-54606 Change 3894913 by Arne.Schober REL - Fix crash in Speedtree wind where Renderdata is unavailable #jira UE-54544 Change 3894625 by Arne.Schober REL - Fix assert not in RenderingThread from Triangle Renderer. #jira UE-55247 Change 3894464 by Martin.Wilson Extra debugging info for UE-54705 plus remove check so it is no longer fatal #jira UE-54705 Change 3894450 by Martin.Wilson Remove pinnable ness of retarget asset. Paves the way for exposing retarget asset properties on the node #jira none Change 3893948 by Jostin.Bilyeu Adding default player start location to help with launch on testing within level TM-Materials_POM #jira UE-55063 Change 3893495 by Robert.Manuszewski Fixing a crash when running DDC commandlet #jira UE-54646 Change 3893451 by Jurre.deBaare Altered fix for actor merging with negative scaling to get correct normals #jira UE-54996 #misc updated automated test to include this test-case Change 3892913 by Ethan.Geller [Release-4.19] #jira UE-55151 Fix for Mic Component crashing on re-init. #rb aaron.mcleran Change 3892871 by Ryan.Vance Multi-view requires the day dream compositor. #jira UE-55253 Change 3892785 by Arciel.Rekman Linux: fix inability to create a C++ project (UE-55222). - NullSourceCodeAccessor will unconditionally allow C++ project creation in source builds. - Installed build will check for more compilers in commonly found locations. #jira UE-55222 Change 3892687 by Jostin.Bilyeu Checking in replacement Built Data for map TM-Materials_POM #jira UE-55063 Change 3892674 by Jostin.Bilyeu Adding an invisible plane to TM-Materials_POM to help testing on mobile devices #jira UE-55063 Change 3892622 by Aaron.McLeran #jira none Fixing scope lock in phonon probe volume Change 3892511 by Matt.Kuhlenschmidt Fix zero engine version warning #jira UE-55081 Change 3892211 by Yuriy.ODonnell Fix/workaround for inconsistent preprocessor definitions for NVAftermath that result in FD3D11DynamicRHI class layout mismatch. NVAftermath support is now enabled by default for Win64. NVAftermath is declared as a private dependency in D3D11RHI. It does not automatically propagate to modules that explicitly include private RHI headers (OculusHMD, OSVR, OSVRInput). This results in NV_AFTERMATH being defined while compiling RHI module and not defined when compiling other modules, causing memory corruption at runtime. The long-term solution for this and similar issues requires some mechanism for adding transitive module dependencies, so that anyone that depends on D3D11RHI module would automatically also get the NVAftermath. Additionally, private headers should *never* be included directly by external modules. The short-term solution is to explicitly add NVAftermath dependency to OculusHMD, OSVR and OSVRInput. Additionally, NV_AFTERMATH is no longer forced by D3D11RHIPrivate.h when it's not defined. This allows catching this kind of mismatch in the future through a compiler warning (C4668). #jira UE-53065 Change 3891732 by Brian.Zaugg Re-adding iPhoneX launch images with correct case. #JIRA UE-53541 Change 3891727 by Arne.Schober REL - Do not recreate one Frame Resource for dynamic draws #jira UE-55063 Change 3891716 by Ben.Marsh Fix buffer overrun when generating callstack. #jira Change 3891697 by Brian.Zaugg Deleting iPhoneX launch images that have incorrect case. #jira UE-53541 Change 3891678 by Brian.Zaugg IPP binaries for iPhoneX support. #jira UE-53541 Change 3891525 by Lauren.Ridge Thumbnails now update correctly w/parameters #jira UETOOL-1333 Change 3891520 by Lauren.Ridge Fixing SA error in material editor #jira UE-55206 Change 3891495 by Jurre.deBaare Normal are different after Merge Actor on scaled objects #fix Make sure we do not apply scale when transform Normals/Tangents #jira UE-54996 Change 3891352 by Guillaume.Abadie Fixes ensure when visualizing HDR with TAAU. #jira UE-55019 Change 3891323 by Matt.Kuhlenschmidt Added substance buttons to content browser and material editor #jira UE-55081 Change 3891033 by David.Hibbitts #JIRA UE-55135 Moved Message Bus Source heartbeats to their own thread using a new FHeartbeatManager singleton. This prevents sources from incorrectly being removed during Slate UI operations. Change 3890642 by Arne.Schober REL - Better fix for Paper2d which honors batching #jira UE-55063 Change 3890593 by Arne.Schober REL - Fix Paper2d crash. When addMesh is called the Vertex and Indexbuffers are nulled out. re-create Dynamic Mesh builder for every Mesh instead. #jira UE-55063 Change 3890502 by Mike.Erwin Fix reported VRAM size on Metal We were getting correct value in MB from system but overflowing uint32 arithmetic when converting to bytes. This led 4GB and 8GB configs to report 0 total VRAM, 0 dedicated tex mem, and GTexturePoolSize = 0. Noticed the problem on my 6GB FirePro, which reported 2GB and set GTexturePoolSize to 70% of that. Also fixed log of texture pool size to show MB. Other platforms' RHIs already report this in MB. #jira none Change 3890404 by Jostin.Bilyeu Updating Demo Display names to remove redundant spaces #jira UE-29618 Change 3890401 by Dan.Oconnor Fix for property table performance regression #jira UE-54984 Change 3890194 by Dan.Oconnor Make sure a CDO's subobjects are preloaded when running in -game #jira UE-54242 Change 3890182 by Krzysztof.Narkowicz Moving CL3867594 from Dev-Rendering to fix missing shaders in cooked Binary Editor DCC. USE_EDITOR_ONLY_DEFAULT_MATERIAL_FALLBACK generated default material shaders had no cooking code path. #jira UE-54683 Change 3890140 by Rob.Cannaday Merging cacert.pem from //UE4/Dev-Online to //UE4/Release-4.19 Includes latest cacert.pem from https://curl.haxx.se/docs/caextract.html as of January 17, 2018 #jira none Change 3889850 by Shaun.Kime Now initializing Niagara scripts and emitters even if the config file isn't ready yet. #jira UE-54168 #jira UE-54169 #tests can create a blank emitter and all script sub-types Change 3889833 by Michael.Trepka Disabled Clang's unused-lambda-capture warning added in Xcode 9.3 #jira none Change 3889696 by Patrick.Boutot Allow rename from AssetTool when there is no source control enabled. Fix crash when you rename an asset without an enabled source control. #jira UEENT-803 Change 3889470 by Mike.Beach Switching the source-name to legacy hand enum lookup functions to use a static table instead of finding a UEnum object and iterating over reflection data (to prevent a GC lockup with the UObject query). #jira UE-55153 Change 3889319 by Matt.Kuhlenschmidt Disable hardware survey on build machines. They run windows server and lack the necessary win32 api functionality to execute it properly #jira UE-55166 Change 3889087 by Jostin.Bilyeu Minor adjustments TM-SceneTexture for better testing clarity. Minor adjustments to TM-MipLevels for test map clean up #jira UE-29618 Change 3889073 by Sorin.Gradinaru UE-55117 Android virtual keyboard can have text input hidden by software buttons #jira UE-55117 #Android #4.19 Adjusted x-coord and width for the native EditText Change 3888841 by Jurre.deBaare Make FSkeletalMeshRenderData::GetMaxBonesPerSection an ENGINE_API exported function #jira none Change 3888837 by Guillaume.Abadie Fixes a crash in dynamic resolution when doing UE4Editor -server #jira UE-55158 Change 3888831 by Dragan.Jerosimovic added fbx files #jira none Change 3888340 by Ethan.Geller [Release-4.19] #jira UE-54787 edit settings for Strategy Game to prevent stuttering in AudioMixer on low performance Android Devices #rb Aaron.McLeran #fyi Aaron.McLeran #lockdown Cristina.Riveron Change 3888133 by Michael.Karambelas QAGame: Adding a BP Actor to test the Mic component feature that AaronM implemented with UE-51471. #jira UE-29618 Change 3887957 by Krzysztof.Narkowicz "Fixed" Vulkan instancing in by doing Metal style set instance offset to 0 hack #jira UE-54367 Change 3887912 by Jostin.Bilyeu Adding content to TM-SceneTexture to verify Screen Positioning as well as Scene Color and Depth. Adding a new map (TM-MIPLevels) for testing custom mip levels #jira UE-29618 Change 3887571 by Zak.Parrish Adding FaceAR content and cleanup #jira none Change 3887458 by Dan.Oconnor Fix 'Step Out' functionality for macro and collapsed graphs #jira UE-55000, UE-55002, UE-55022 Change 3886883 by zachary.wilson Add testing content to QAGame: Texture and material for testing mip levels. Postprocess material for testing scene buffer sampling. #jira UE-29618 Change 3886848 by Max.Preussner Engine: Workaround for uninitialized external textures causing white flashes in media playback Copied from Fortnite-Main and Dev-Sequencer #jira UE-53357 Change 3886720 by Matt.Kuhlenschmidt Guard against mac menus updating during slow tasks. #jira UE-55068 Change 3886657 by Guillaume.Abadie Cherry-pick 3886626: Cherry-pick 3886560: Fixes strong aliasing on TAAU's fast shader permutation. This adds a 6th neighbor sampling, and switch AA_TONE ON as TAA does for its fast shader permutation. #jira FORT-69961 Change 3886653 by Matt.Kuhlenschmidt Perforce Plugin: Removed all calls to methods that would update the P4PASSWD environment variable. Perforce stores this as plain text so it is not safe and we do not want the editor to be responsible for this being set. All users should be using ticket based p4 servers for the best security but if they are unable to then they can call p4 passwd on their own to set a slightly better hashed password directly. They may also log in each time to the editor which prevents any password from being stored #jira UE-55111 Change 3886621 by Benn.Gallagher Fixed crash closing clothing tab if workflow centric application puts the tab spawners in a bad state due to incorrect handling of tab context menus. #JIRA UE-55067 Change 3886552 by Thomas.Sarkanen Fixed crash loading an anim instance with a re-instanced class Unable to repro, but in editor we dont need the optimization that this provides. Now we always re-initialize functions and properties in case the class has changed out from under us. #jira UE-55065 - [CrashReport] UE4Editor_Engine!FExposedValueHandler::Initialize() [animnodebase.cpp:521] Change 3886442 by Cosmin.Sulea UE-53033 - Editor Rapidly Spawns Multiple Empty Windows Throughout Remote Shader Compiling #jira UE-53033 Change 3886441 by Cosmin.Sulea UE-54598 - Using an Invalid iOS Mobile Provision does not give descriptive error in Project Launcher, IPhonePackager #jira UE-54598 Change 3886427 by Sorin.Gradinaru UE-54139 Possible crash with new virtual keyboard on Android if suggestions not disabled - from //Dev-Mobile@CL3843552 #4.19 #Android #jira UE-54139 S8 on 7.0 is not hiding suggestions and disabling predictive input. There are cases with this that can cause a crash. Fix: On text change, downgrade to simple suggestions all the easy correction spans that are not a spell check span (remove android.text.style.SuggestionSpan.FLAG_EASY_CORRECT flags) Change 3886210 by Ethan.Geller [Release-4.19] #jira UE-53867 Ensure we don't read off into garbage memory for uncompressed PCM. Change 3886005 by Zak.Parrish Checking in faceAR work on behalf of 3Lateral #jira none Change 3885925 by Mike.Erwin Material preview label off-center on HiDPI screen #jira UE-52533 Change 3885778 by Dan.Oconnor Fix stepping over collapsed graph and macro nodes #jira UE-54950, UE-54955 Change 3885713 by Mike.Erwin glTF: fix material using wrong textures Imported material could plug the wrong textures into its inputs. The previous code tracked a material's textures based on image source index, corrected code uses texture (source + sampler) index. This is more general allowing an image to be referenced by multiple textures. Bug reported yesterday via email, demonstrated using the Khronos TextureSettingsTest sample model. #jira none Change 3885603 by Ben.Marsh Fixes for compiler errors in nightly builds of VS2017 in /permissive- mode. #jira Change 3885566 by Phillip.Kavan Fix a scoping issue related to inaccessible property reference caching in nativized Blueprint code. Change summary: - Modified FDefaultSubobjectData::EmitPropertyInitialization() to utilize the FScopeBlock utility to manage the inaccessible property cache during code generation for instanced subobject initialization. #jira UE-55061 Change 3885481 by Mark.Satterthwaite Attempt to workaround an Intel shader compiler bug without reopening a related AMD bug. This may cost performance unless function constants are available and the runtime compiler actually bothers to perform optimisation (AMD's did not in 10.12.6 and earlier). #jira UE-54333 Change 3885461 by Lauren.Ridge Fix for slot not being initialized to null #jira UE-55069 Change 3885455 by zak.parrish Adding initial files for FaceAR scene lookdev #jira none Change 3885446 by Zak.Parrish Adding test assets for Gremlin look dev. May get removed later prior to release. #jira none Change 3885424 by Krzysztof.Narkowicz Fixed skeletal mesh LODs inside editor. If skeletal mesh wasn't recently visible, code was incorrectly changing LOD settings without updating LOD data on render thread. #jira UE-53861 Change 3885406 by Zak.Parrish Rollback //UE4/Release-4.19/Samples/FaceARSample/Content/UI/FaceARDebugUI.uasset to revision 1 #jira UE-54639 Change 3885340 by Arne.Schober REL - Bitarray FindFromLast was masking incorrectly for the corner case where there is no slack #jira none Change 3885143 by Marc.Audy Merge memory corruption fix in CL# 3884991 from Fortnite-Staging to Release-4.19 #jira UE-54977 #jira UE-54976 #jira UE-54898 Change 3885093 by Mark.Satterthwaite Apple don't like testing for the validation layer in iOS App Store builds - it is unnecessary so we can disable this for shipping builds. #JIRA N/A Change 3884622 by Jurre.deBaare Moving over missing file from changelist for UE-54508 #jira UE-54508 Change 3883391 by Nick.Atamas Fix for UE-54622 : PIE in VR available when ARKit/ARCore plugins enabled. Only create ARKit/ARCore tracking systems on iOS/Android. #jira UE-54622 Change 3883257 by Phillip.Kavan Fix a Blueprint compile error for the GetClassDefaults node Map value outputs introduced by stronger type checking in 4.19 between Map pin types. #jira UE-55026 Change 3883024 by Lauren.Ridge Fixing static analysis warning #jira SA Change 3882510 by Michael.Dupuis #jira none : Fixed screen size calculation to take aspect ratio into account correctly Change 3882502 by Lauren.Ridge Fix for material layer parameters not rebuilding and adding save child button #jira UETOOL-1275 Change 3882458 by Krzysztof.Narkowicz Copying cached shadow map assert fix from Fortnite-Main (CL3802813) #jira UE-54747 Change 3882366 by Michael.Karambelas QAGame: made changes to QABP_Debugging, QABP_FunctionLib, and QA_TestHelper for Blueprint debugger tests. #jira UE-29618 Change 3881971 by andrew.porter QAGame: Removing actor from Shot_003 #jira UE-29618 Change 3881795 by Krzysztof.Narkowicz Added encoded HDR reflection capture cooking if targeting ES 2.0/3.1 on Windows #jira UE-53875 Change 3881550 by David.Hibbitts #JIRA UEENT-879 Subject frames now store world time explictly as a double with optional scene timecode as MetaData. This allows for use cases such as posing a single frame in Maya where the world time would be changing but the scene timecode associated with the animation remains fixed. THIS IS A BREAKING CHANGE: Sources from before this change will no longer compile. Change 3881339 by Jurre.deBaare Moving over: "Editor crashed when attempting to bake out all the material channels #jira UE-54508 #misc small UDN Merge actor / bake material fixes Change 3879557 by Dan.Oconnor Fix stepover behavior when no debug target is selected #jira UE-54978 Change 3879485 by Mike.Beach Limiting the number of stereo layers on Oculus android to 4 (otherwise, their lib crashes). #jira UE-54999 Change 3879438 by David.Hibbitts #JIRA UEENT-880 Added support for Subject level MetaData to LiveLink #rb martin.wilson #fyi james.golding, simon.tourangeau Change 3879343 by Lina.Halper Last min change that skiped compiling #jira: none Change 3879337 by Lina.Halper Fix issue where tick is skipped due to last ticked pose isn't cleared after AnimInstance changes. #jira: UE-54806 Change 3878968 by Phillip.Kavan Fix deprecation warnings in compiled stub class wrapper codegen for Blueprint class dependencies excluded from nativization. Change summary: - Modified FBlueprintCompilerCppBackendBase::GenerateWrapperForClass() to const-correct the assignment of cached weak pointers to referenced properties. #jira UE-54981 Change 3878962 by Adrian.Siminciuc https://jira.it.epicgames.net/browse/UE-54831 (No error occurs accepting if Android SDK license file cannot be written, but user cannot accept license) #4.19 #jira UE-54831 #android - shows an error message box informing that the license file could not be written. Change 3878821 by Andrew.Rodham Sequencer: Fixed overlapping ranges being inserted into the evaluation field during compilation - The issue was that track segments that had been combined with adjacent segments (due to them being identical) would potentially cause a subsequently compiled frame to overlap with a range that had already been inserted into the evaluation field. - The insertion code previously asserted that only minor overlaps were catered for (due to fp rounding errors) and assumed that a supplied range could not entirely contain any other range in the field. - The solution is to supply the insertion time along with the range to know exactly where the data should live in the field, and crop the range to the maximum allowable space between adjacent ranges. #jira UE-54922 Change 3878171 by Chris.Phillips Android: Fixed crash after splash screen when using Vulkan. #jira UE-54299 Change 3877950 by Ethan.Geller Fix copyright information from previous CL #jira none #rb none #lockdown Cristina.Riveron Change 3877859 by Nick.Shin rebuilt lighting for TM-ShaderModels and resaved the level #jira UE-53374 Client displays "lighting needs to be rebuilt (1 unbuilt object(s))" when launching TM-Shadermodels onto HTML5 Change 3877854 by tim.gautier Adding additional (temp) ML Test asset #jira UE-29318 Change 3877609 by Ethan.Geller [4.19] Change FWhiteNoise generate function to use SRand, due to weird distribution in FRandRange #jira UE-54965 #rb aaron.mcleran #lockdown cristina.riveron Change 3877474 by Lauren.Ridge Adding WITH_EDITOR wrappers to editor-only section of code #jira fixingcompiles Change 3877271 by Arne.Schober REL - Integrate 3872827 - The VFs are not owners of the data, e.g the underlying Buffers might be released before this and this reference counting should not be neccessary #jira none Change 3877260 by Lina.Halper If revision is too far away, ignore the request and send current buffer - this is exactly how it used to do and it is still required, but this means motion vector will be ignored when this happens #jira: UE-54398 Change 3876950 by Lauren.Ridge Renaming layers in a material instance - from 4.19 preview feedback #jira UETOOL-1296 Change 3876932 by Arciel.Rekman Linux: updated the link to the cross-toolchain (UE-54597). #jira UE-54597 Change 3876918 by Phillip.Kavan Fix a regression that could cause packaging to fail and/or data loss with Blueprint nativization enabled. Change summary: - Removed logic that attempted to avoid redundant assignments of instanced default subobject references. This was not compatible with editinline characteristics that can allow certain object reference values to be overridden by the Blueprint class. - Explicitly defer to ExportTextItem() when generating C++ code for UObjectProperty/UInterfaceProperty reference values in which the underlying object reference is NULL. #jira UE-54870 Change 3876759 by tim.gautier Updated Material Layer test assets to include Opacity and Emissive. #jira UE-29318 Change 3876575 by Michael.Karambelas Updating the QABP_Debugging asset in QAGame with a couple of interfaces and additional logic for testing purposes. #jira UE-29618 Change 3876406 by Robert.Manuszewski Fixed a crash when reporting linker errors #jira UE-51037 Change 3875891 by Nick.Atamas Fixed scenario where geometries were being updated once per pin, instead of just being updated once. Also fixes a scenario where there are no pins and geometries fail to update. #jira UE-54914 Change 3875880 by Aaron.McLeran #jira UE-54916 Fixing up submix effect templates Change 3875673 by Brandon.Schaefer Fix Apex dependencies Depend on static Apex libraries in Apex.Build.cs versus Physx.Build.cs #jira UE-54861 Change 3875498 by Lauren.Ridge PR #4477: 4.19 Fixed a crash caused by the layered material property widget of the material instance editor. (Contributed by mlaveaux) #jira UE-54862 Change 3875322 by tim.gautier Recreating Material Layer test assets (asset version has changed) #jira UE-29318 Change 3875157 by Aaron.McLeran #jira UE-54901 Synth components do not allow sends to buses Change 3875103 by Brandon.Schaefer Need to use our bundled libc++.so not libstdc++.so when building Apex/PhysX/NvCloth libraries #jira UE-54815 Change 3875037 by Aaron.McLeran #jira UE-54896 Fixing up audio capture component to parameterize the delay Parameterize the jitter latency delay. Change 3875026 by Aaron.McLeran #jira UE-54895 Filter frequency values don't update live with EQ effects and 0-frequency cutoff causes pops Change 3874927 by Ryan.Vance #jira UE-54894 Ensure we don't delete aliased texture resources, they are managed externally. Change 3874925 by Martin.Wilson Remove XR post fix from live link code written during motion controller integration #jira none Change 3874354 by Ben.Marsh Use the compiler matching the user's preferred IDE if they don't have a specific compiler selected in the project settings. #jira UE-54272 Change 3877545 by Ben.Marsh Replace FPlatformMisc::DebugBreak() with the UE_DEBUG_BREAK() macro. VS2017 is able to show force-inlined calls on the callstack, which makes debugging asserts and ensures annoying. Use similar logic for expanding ensure() macros in place. #jira UE-54961 [CL 3963579 by Ben Marsh in Main branch]
2018-03-24 09:22:20 -04:00
virtual bool IsSdkInstalled(bool bProjectHasCode, FString& OutDocumentationPath) const override
{
return true;
}
virtual int32 CheckRequirements(bool bProjectHasCode, EBuildConfiguration Configuration, bool bRequiresAssetNativization, FString& OutTutorialPath, FString& OutDocumentationPath, FText& CustomizedLogMessage) const override
{
int32 bReadyToBuild = ETargetPlatformReadyStatus::Ready; // @todo How do we check that the iOS SDK is installed when building from Windows? Is that even possible?
Copying //UE4/Dev-Mobile to //UE4/Main (Source: //UE4/Dev-Mobile @ 3600060) #rb none #lockdown nick.penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 3292215 on 2017/02/08 by Nick.Shin HTML5 emscripten: wasm and wbegl2 support - emscripten toolchain #jira UEPLAT-1437 Switch [to] web assembly #rb none Change 3293994 on 2017/02/09 by Nick.Shin HTML5 emscripten: wasm and webgl2 support - OSX toolchain #jira UEPLAT-1437 Switch [to] web assembly #rb none Change 3317951 on 2017/02/22 by Nick.Shin HTML5 emscripten: wasm & webgl2 support - RC1 - emscripten toolchain WARNING: emscripten/incoming/source/include/libc/bit (the file) might need to be deleted first #jira UEMOB-263 Switch [to] web assembly #jira UEMOB-201 Support ES3 / WebGL2 in HTML5 #rb none Change 3318669 on 2017/02/23 by Nick.Shin HTML5 emscripten: wasm & webgl2 support - RC1 - OSX toolchain #jira UEMOB-263 Switch [to] web assembly #jira UEMOB-201 Support ES3 / WebGL2 in HTML5 #rb none Change 3462146 on 2017/05/26 by Nick.Shin HTML5 - merge from Release-4.16 to Dev-Mobile #jira none #rb none #rnx Change 3504996 on 2017/06/22 by Cosmin.Sulea UEMOB-362 - Add per-texture and per-format compression quality override settings #rb Dmitriy.Dyomin #jira UEMOB-362 #codereview Dmitriy.Dyomin #codereview Jack.Porter Change 3505056 on 2017/06/22 by Cosmin.Sulea Back out changelist 3504996 - due to errors generated in xboxOne, PS4 and Switch versions #rb none Change 3508049 on 2017/06/23 by Nick.Shin HTML5 toolchain notes corrections #jira none #rb none #rnx Change 3508663 on 2017/06/24 by Nick.Shin HTML5LaunchHelper.exe on linux - redo - it seems that i need to also check-in the exe and pdb file instead of having CIS make and checking-in them itself... - modified c# program to output a version number to help track which version of HTML5LaunchHelper is running... #jira UE-45302 HTML5LaunchHelper.exe hosts the files in the current working directory on Linux #rnx #rb none Change 3509210 on 2017/06/26 by Dmitriy.Dyomin ExposureScale will be applied during tonemap pass when MobileHDR is on #rb jack.porter #codereview Allan.Bentham Change 3511058 on 2017/06/27 by Cosmin.Sulea UEMOB-362 - Add per-texture and per-format compression quality override settings - resubmitted #rb Dmitriy.Dyomin #jira UEMOB-362 #codereview Dmitriy.Dyomin Change 3511069 on 2017/06/27 by Jack.Porter PS4, XboxOne and Switch fixes for changes to ITextureFormat interface #rb Dmitriy.Dyomin #jira UEMOB-362 Change 3513028 on 2017/06/28 by Jack.Porter Merging //UE4/Dev-Main to Dev-Mobile (//UE4/Dev-Mobile) #rb None Change 3517409 on 2017/06/30 by Jack.Porter Merging //UE4/Dev-Main to Dev-Mobile (//UE4/Dev-Mobile) #rb None Change 3517730 on 2017/06/30 by Cosmin.Sulea UEMOB-328 - Improve handling of iOS signing key on remote Mac system keychain when using remote toolchain #rb Jack.Porter #jira UEMOB-328 #codereview: peter.sauerbrei Change 3517757 on 2017/06/30 by Cosmin.Sulea UE-46245 - Building with remote toolchain does not use Project Setting for iOS signing identity which can cause signing errors #rb Jack.Porter #jira UE-46245 #codereview: peter.sauerbrei Change 3518149 on 2017/06/30 by Adrian.Chelu UE-43035 Tilt axis for X and Z are not consistent between Android and iOS devices #rb Jack.Porter #jira UE-46245 #codereview: Chris Babcock <chris.babcock@epicgames.com> Change 3524242 on 2017/07/06 by Nick.Shin HTML5 - refraction shader note: this CL also contains fixes to webgl2 [float4 vs half2] and a [% vs Mod()] material custom function changes to some TM-ShaderModels shaders specifically: fixes to and similar with: DitherTemporalAA #jria UE-46434 No Refraction in QA Game TM-Shadermodels HTML5 #rb none #rn #codereview jack.porter dmitriy.dyomin Change 3535295 on 2017/07/13 by Allan.Bentham #jira UEMOB-390 Add Android cpu stats. add 'stat AndroidCPU' to android's console spinner UI. increase GetCPUState's core count support to 16. #jira UE-45888 Use cvar value to limit android cpu stat update rate. #rb none Change 3535306 on 2017/07/13 by Allan.Bentham Add missing pragma once #rb none Change 3537047 on 2017/07/13 by Ben.Marsh Fixing case of iOS directories, pt1 #rb none Change 3537051 on 2017/07/13 by Ben.Marsh Fixing case of iOS directories, pt2 #rb none Change 3537373 on 2017/07/14 by Allan.Bentham Add scope level android egl error verification. work around minor issue with invalid egl config property. #rb chris.babcock Change 3541735 on 2017/07/18 by Allan.Bentham Add 'sustained performance mode' support for API 24+ devices. #jira UEMOB-386 #rb chris.babcock Change 3543001 on 2017/07/18 by Sorin.Gradinaru #jira UE-45766 Improved Virtual Keyboard cannot receive non-English characters. - for Android, add an native EditBox above the virtual keyboard to receive the text and pass it to the object from the slate #rb Chris.Babcock Change 3554399 on 2017/07/25 by Nick.Shin STATS disabled for non multi-threaded platforms #jira UE-47485 ( Pri:1 - 4.18 ) Crash running Stat Command test in TM-Core on Firefox #rnx #rb none Change 3554402 on 2017/07/25 by Nick.Shin STATS TaskGraph disabled for non multi-threaded platforms #jira UE-47486 ( Pri:1 - 4.18 ) QAGame hard locks on Firefox when triggering Task Graph Benchmark test #rb none #rnx Change 3556957 on 2017/07/26 by Nick.Shin HTML5 - WASM enabled by default - part 1 -- commenting out asmjs stuff begin sunsetting ASM.JS note to self: CL#3462146 "backout" asmjs #jira UEMOB-416 WASM enabled by default #rnx #rb none Change 3557654 on 2017/07/26 by Nick.Shin HTML5 - WASM enabled by default - part 2 -- remove asmjs code sunsetting ASM.JS note to self: CL#3462146 "backout" asmjs #jira UEMOB-416 WASM enabled by default #rn #rb none Change 3557910 on 2017/07/27 by Jack.Porter Support Client configuration when packaging in the editor #jira UE-39973 #rb Dmitriy.Dyomin Change 3557917 on 2017/07/27 by Jack.Porter Missing file from CL 3557910 #rb trivial Change 3559642 on 2017/07/27 by Nick.Shin STATS TaskGraph disabled for non multi-threaded platforms - both "LockFree stress test" and "task graph benchmark" are disabled - no multi-threading for WASM exist yet (note: ASM.JS has been sunsetted) - stat command crash "fixed" - but, font size are totally broken - i can look at this (much) later... - new bug: physx will crash on "gc and level load stress test" -- please bug this as a new jira #jira UE-47486 ( Pri:1 - 4.18 ) QAGame hard locks on Firefox when triggering Task Graph Benchmark test #rb none #rnx Change 3565656 on 2017/07/31 by Dmitriy.Dyomin Added a way to lock level position in Word Composition #jira UE-47713 #rb none Change 3565757 on 2017/08/01 by Dmitriy.Dyomin compile fix #rb none Change 3567446 on 2017/08/01 by Chris.Babcock Allow addElement and addElements to only insert once with once="true" attribute in UPL #jira UE-47951 #ue4 #android #rb Peter.Sauerbrei Change 3567592 on 2017/08/01 by Chris.Babcock Use absolute path for repositories for Gradle #jira UE-47952 #ue4 #android #rb Tim.Lincoln Change 3568690 on 2017/08/02 by Chris.Babcock Removed warnings for once attribute in UPL #ue4 #android #rb none Change 3569975 on 2017/08/02 by Chris.Babcock Add <baseBuildGradleAdditions> to UPL to allow additions to the root-level build.gradle #jira UE-47995 #ue4 #android #rb Tim.Lincoln Change 3570117 on 2017/08/02 by Chris.Babcock Add <setBoolFromPropertyContains> to UPL - sets bool to true if string list in ini matches contains attribute #jira UE-47996 #ue4 #android #rb Jack.Porter Change 3571552 on 2017/08/03 by Chris.Babcock Removed unneeded settings.gradle file (generated) #jira UE-48041 #ue4 #android #rb none Change 3572224 on 2017/08/04 by Dmitriy.Dyomin Better selection tracking in world composition #rb none Change 3573662 on 2017/08/04 by Nick.Shin HTML5 remove PreLoadMap "feature" (was only available/used with HTML5) - asyncronous loads are not allowed during UEngine::LoadMap() - the files/code will be repurposed for pakfile CHUNK support #jira UEMOB-425 HTML5 streaming content investigation (part 1 of 2) #rn #rb none Change 3574471 on 2017/08/07 by Dmitriy.Dyomin Export ULevelStreamingKismet::LoadLevelInstance function #rb none Change 3576262 on 2017/08/08 by Dmitriy.Dyomin Fixed: widget clipping issues in world composition #rb none Change 3576845 on 2017/08/08 by Nick.Shin set HTML5LaunchHelper application's icon to UE4.ico #jira UE-19225 HTML5LaunchHelper application does not have an unreal icon #rb none #rnx Change 3578313 on 2017/08/09 by Dmitriy.Dyomin Added: an RHI call to invalidate/clear cached state, RHIInvalidateCachedState #jira UEMOB-435 #rb jack.porter Change 3578364 on 2017/08/09 by Dmitriy.Dyomin Vertex Fog is disabled on mobile by default. If scene uses vertex fog - Mobile preview and device will show on screen message: PROJECT HAS VERTEX FOG ON MOBILE DISABLED This saves about 90 instructions in VS and a few in PS #jira UEMOB-166 #rb jack.porter Change 3578703 on 2017/08/09 by Nick.Shin set HTML5LaunchHelper application's icon to UE4.ico forgot to check in exe and pdb file #jira UE-19225 HTML5LaunchHelper application does not have an unreal icon #rb none #rnx Change 3578961 on 2017/08/09 by Peter.Sauerbrei deprecate IOS 8 as the minimum OS supported. #jira UEMOB-429 #rb chris.babcock Change 3579319 on 2017/08/09 by Peter.Sauerbrei fixes for compile errors with Xcode 9 beta 4 #rb none Change 3579356 on 2017/08/09 by Peter.Sauerbrei modified minimum IOS to build with #rb chris.babcock Change 3579687 on 2017/08/09 by Chris.Babcock Fix GoogleVR Gradle packaging #jira UE-48239 #ue4 #android #rb none Change 3579921 on 2017/08/10 by Dmitriy.Dyomin GitHub 3670 : More zoom levels for World Composition (300) #contributedby: user37337 #jira UE-45977 #3670 #rb none Change 3580576 on 2017/08/10 by Peter.Sauerbrei detection of iPad Pro 10.5 and IPad Pro 12.9 (2nd Gen) #rb chris.babcock Change 3580611 on 2017/08/10 by Chris.Babcock Set online provider back to GooglePlay and remove forcing IAP permission (contributed by umerov1999) #jira UE-48185 #PR #3876 #ue4 #android #rb Peter.Sauerbrei Change 3582166 on 2017/08/11 by Nick.Shin nuke PLATFORM_HTML5_WIN32 PLATFORM_HTML5_WIN32 code removal tested successfully with (force rebuild and repackaging): * Win64 server (WindowsServer) * Win64 client (WindowsNoEditor) * HTML5 client all playing together via websocket net driver (i've attached a screen shot of this in jira) code changes touches: physics, audio and main build files #jira UEMOB-433 Remove Win32 SDL "HTML5 Simulator" code #rb ben.marsh #rnx #codereview josh.adams #fyi ori.cohen, aaron.mclera Change 3582474 on 2017/08/11 by Chris.Babcock Don't use V2 signing for Gear VR APKs #jira UE-48354 #ue4 #android #rb Peter.Sauerbrei Change 3582614 on 2017/08/11 by Chris.Babcock Filter out unneeded architectures from APK for Gradle builds #jira UE-48355 #ue4 #android #rb Peter.Sauerbrei Change 3582923 on 2017/08/11 by Nick.Shin backport release 4.17 to dev-mobile #jira none #rb none #rnx Change 3582924 on 2017/08/11 by Nick.Shin FNetworkFileServerHttp - error gracefully when port is already in use #jira UE-46409 [CrashReport] Assertion on Mac: Could not create a libwebsocket - FNetworkFileServerHttp::Init() #rnx #rb none Change 3582925 on 2017/08/11 by Nick.Shin HTML5 - turn off pak file compression in favor of gzip packages #jira UE-46729 HTML5 - on shipping builds - turn off pak file compression in favor of gzip packages #rn #rb none Change 3583943 on 2017/08/14 by Cosmin.Sulea UEMOB-363 - second iteration - Project wide texture quality control by texture group #rb Dmitriy Dyomin #jira UEMOB-363 Change 3583967 on 2017/08/14 by Cosmin.Sulea Back out changelist 3583943 #rb none Change 3584121 on 2017/08/14 by Peter.Sauerbrei fix for mac compile failure #rb none Change 3587877 on 2017/08/15 by Peter.Sauerbrei josh's suggested fix is not working for Xcode 8.3, so brute forcing for now #rb none Change 3588612 on 2017/08/15 by Peter.Sauerbrei Xcode 9 project compatbility updates #rb chris.babcock #codereview michael.trepka Change 3589223 on 2017/08/15 by Dmitriy.Dyomin Fixed: bNavigationAutoUpdateEnabled was not always working when reopeinig the map Fixed: Navigation Build was not clearing some mesh tiles when bNavigationAutoUpdateEnabled is enabled Fixed: Streaming out a level in editor was not always updating NavMesh debug draw #rb lukasz.furman Change 3589900 on 2017/08/16 by Dmitriy.Dyomin Support vulkan validation layers on Android, only in Debug and Development configuration (requires r.Vulkan.EnableValidation=1) #codereview chris.babcock, rolando.caloca #rb none Change 3590592 on 2017/08/16 by Nick.Shin HTML5 emscripten 1.37.19 OSX #jira UE-47813 #rb none #rn HTML5 emscripten 1.37.19 OSX Change 3590597 on 2017/08/16 by Nick.Shin HTML5 emscripten 1.37.19 Linux #jira UE-47813 #rb none #rn HTML5 emscripten 1.37.19 Linux Change 3590624 on 2017/08/16 by Nick.Shin HTML5 emscripten 1.37.19 toolchain #jira UE-47813 #rb none #rn HTML5 emscripten 1.37.19 toolchain Change 3591720 on 2017/08/16 by Chris.Babcock Enable Gradle by default and add button to accept Android SDK license to project settings #jira UE-48519 #ue4 #android #rb Tim.Lincoln #fyi Peter.Sauerbrei Change 3591998 on 2017/08/16 by Chris.Babcock Fix nonunity build #ue4 #android #rb none Change 3592407 on 2017/08/17 by Nick.Shin HTML5 emscripten 1.37.19 Win64 #jira UE-47813 #rb none #rn HTML5 emscripten 1.37.19 Win64 Change 3592479 on 2017/08/17 by Nick.Shin HTML5 3rd Party Libs - compiled with emscripten 1.37.19 #jira UE-47813 #rb none #rn HTML5 3rd Party Libs - compiled with emscripten 1.37.19 toolchain Change 3592480 on 2017/08/17 by Nick.Shin HTML5 emscripten 1.37.19 toolchain Epic edits as well as setting UE4 HTML c# scripts to use new toolchain #jira UE-47813 #rb none #rn HTML5 emscripten 1.37.19 toolchain Epic edits Change 3592481 on 2017/08/17 by Nick.Shin HTML5 remove old emscripten toolchain #jira UE-47813 #rb none #rn HTML5 remove old emscripten toolchain Change 3592485 on 2017/08/17 by Nick.Shin HTML5 undo CanUseXGE - this might be breaking CIS for HTML5 builds... #jira UE-47813 #rb none #rnx Change 3592549 on 2017/08/17 by Dmitriy.Dyomin Added GetDiskTotalAndFreeSpace for IOS and Android #jira UE-46479 #codereview chris.babcock, peter.sauerbrei #rb none Change 3594045 on 2017/08/17 by Peter.Sauerbrei comment about potential failure case in the remote tool chain #rb none Change 3594342 on 2017/08/17 by Peter.Sauerbrei Merging //UE4/Main/... to //UE4/Dev-Mobile/... #rb none Change 3594920 on 2017/08/17 by Peter.Sauerbrei fix for non-unity builds (accidentally merged something incorrectly) #rb none Change 3595347 on 2017/08/17 by Chris.Babcock merge fixes for Android #ue4 #android #rb Peter.Sauerbrei #lockdown Peter.Sauerbrei Change 3595752 on 2017/08/17 by Chris.Babcock Update Facebook plugin to support Gradle #jira UE-48569 #ue4 #android #fyi Josh.Markiewicz #rb none #lockdown Peter.Sauerbrei Change 3595849 on 2017/08/17 by Chris.Babcock Fix issue with libovrplatformloader.so for non armv7 targets #jira UE-48533 #ue4 #android #rb none #lockdown Peter.Sauerbrei Change 3596419 on 2017/08/18 by Peter.Sauerbrei fix for Mac Editor build failure #rb none Change 3597023 on 2017/08/18 by Peter.Sauerbrei fix for game editor build failure #rb none Change 3597032 on 2017/08/18 by Peter.Sauerbrei fix for app bundle id in Info-Editor.plist #rb none Change 3597034 on 2017/08/18 by Peter.Sauerbrei put back the info.plist, found the real problem #rb none Change 3597197 on 2017/08/18 by Peter.Sauerbrei pull Info.plist from the build products #rb none [CL 3600450 by Chris Babcock in Main branch]
2017-08-21 15:05:19 -04:00
if (!IsSdkInstalled(bProjectHasCode, OutTutorialPath))
{
bReadyToBuild |= ETargetPlatformReadyStatus::SDKNotFound;
}
return bReadyToBuild;
}
TARGETPLATFORM_API virtual bool RequiresTempTarget(bool bProjectHasCode, EBuildConfiguration Configuration, bool bRequiresAssetNativization, FText& OutReason) const override;
virtual bool SupportsValueForType(FName SupportedType, FName RequiredSupportedValue) const override
{
#if WITH_ENGINE
// check if the given shader format is returned by this TargetPlatform
if (SupportedType == TEXT("ShaderFormat"))
{
TArray<FName> AllPossibleShaderFormats;
GetAllPossibleShaderFormats(AllPossibleShaderFormats);
return AllPossibleShaderFormats.Contains(RequiredSupportedValue);
}
#endif
return false;
}
virtual bool SupportsVariants() const override
{
return false;
}
virtual float GetVariantPriority() const override
{
return IsClientOnly() ? 0.0f : 0.2f;
}
virtual bool SendLowerCaseFilePaths() const override
{
return false;
}
virtual bool AllowsEditorObjects() const override
{
return HasEditorOnlyData();
}
virtual void GetBuildProjectSettingKeys(FString& OutSection, TArray<FString>& InBoolKeys, TArray<FString>& InIntKeys, TArray<FString>& InStringKeys) const override
{
// do nothing in the base class
}
Copying //UE4/Dev-VR to //UE4/Dev-Main (Source: //UE4/Dev-VR @ 4268149) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 4048227 by Rolando.Caloca VR - vk - Some Vulkan merge conflicts resolved Change 4078631 by Mike.Beach Fixing MR Calibration so it scales the alignment model according the the capture's FOV (so they appear the same size across capture devices - leading to a homogenous experience). Also moved the FOV override config setting to be a console command/setting (mrc.FovOverride) to help in testing this. #jira UE-55499 Change 4080389 by Mike.Beach Speculative fix/guard against live crash - trying to catch malformed model data. Logging helpful information to give us insight in the future. #jira UE-57680 Change 4080792 by Joe.Graf Prep work for moving face ar to its own plugin Change 4080852 by Joe.Graf Prep work for moving face ar support to its own plugin Change 4081735 by Keli.Hlodversson Remove a workaround change from the Lumin branch that should not have been merged over. Change 4081737 by Keli.Hlodversson Fix SteamVR forcing full screen regardless of user settings. #jira UE-51654 Change 4082323 by Joe.Graf Pulled face ar support into its own plugin so that it can be enabled/disabled independently from room ar Change 4082334 by Joe.Graf Changed where face LiveLink was logging to Change 4095529 by Joe.Graf Dramatically simplified the face API isolation to a separate plugin Change 4103356 by Joe.Graf Fixed a threading bug that appeared when migrating the face ar code into its own plugin Change 4109752 by Joe.Graf Added a setting to specify the type of AR world alignment transform type a session should use Deleted some old ARKit configuration code that wasn't really used Fixed the setting of light estimation using the wrong value to determine the setting on ARKit #jira: UE-58544, UE-59371 Change 4110601 by Jason.Bestimt #DEV-VR - Adding spaces to plugin names #JIRA: UE-58642, UE-58643 Change 4110721 by Jason.Bestimt #DEV-VR - Removing question mark from tooltip #JIRA: UE-58641 Change 4111412 by Joe.Graf Fixed a bad merge of BaseEngine.ini Change 4111902 by Nick.Whiting Adding in support for locking HMD tracking to an external tracking environment (e.g. mo cap). This is not meant to drive the position continually in lieu of an HMD's built in system, but is rather to help keep the HMD from generally getting out of alignment with another tracking system. Two functions, CalibrateExternalTrackingToHMD and UpdateExternalTrackingHMDPosition allow for arbitrary rigid offsets between the HMD and the external tracking source, and updating as desired. Change 4116059 by Joe.Graf First pass integration of ARKit 2.0 (very wip, thar be dragons everywhere) Change 4116109 by Jason.Bestimt #DEV-VR - Disable editing of Tegra Debugger setting for installed builds #JIRA: UE-58636 Change 4117821 by Jason.Bestimt #DEV-VR - Fix for crash in DebugCanvas on application termination #JIRA: UE-58865 Change 4118560 by Joe.Conley MagicLeap ImageTrackerComponent: Adding check for PLATFORM_LUMIN to prevent PIE crash running code that was designed to only run on device. Tested PIE in editor and launching to device. Change 4118626 by Jason.Bestimt #DEV-VR - Removing ES2 from bMobileRendering Tooltop #JIRA: UE-58640 Change 4119786 by Joe.Conley Merging CL-4118965 from Release-4.20 using DevVRtoRelease420 Change 4119906 by Joe.Conley Magic Leap settings: Changing comment/tooltip on mobile rendering flag to not mention vulkan and just say "mobile". Still technically possible to use ES2 but it's hidden. #jira UE-59755 "Magic Leap: Project setting to set vulkan or ES2 needs to be removed" Change 4122067 by Jason.Bestimt #DEV-VR - Copying all relevant files for Resonance Audio Change 4122930 by Keli.Hlodversson Use XR ThreadUtils when scheduling GameTrackingThread to Render and RHI thread. #jira UE-58852 Change 4123848 by Nick.Whiting Enabling RHI threading on Lumin Change 4124116 by Nick.Whiting Adding support for DefaultStereoLayers on Lumin Change 4151051 by Joe.Conley Magic Leap: Override IniPlatfromName() for LuminTargetPlatform to report "Lumin" rather than reporting the value from it's parent, AndroidTargetPlatform, "Android". #jira UE-60389 "Lumin - Need to switch the *Phaedra* launch on option "All_Android_On..." to a single "All_Phaedra_On..." with no expandable options" Unsure if this will affect more than just this display name, as IniPlatformName() is used in a few places in the code, but eventually it will need to be "Lumin" anyway so we'll fix fallout as we find it. Change 4160099 by Nick.Whiting Enabling RHI threading on Vulkan by default on Magic Leap Change 4163986 by Joe.Graf Merging using Dev-VR_to_Release-4.20 Change 4164500 by Joe.Graf Merging using Release-4.20_to_Dev-VR Change 4166311 by Jason.Bestimt #DEV-VR - Merge from //UE4/Dev-MagicLeap/... @ CL 4136411 Change 4167085 by Ryan.Vance #integrating 4.20 cl 4132173 to fix mobile vulkan occusion query issues. #jira UE-61051 Change 4167151 by Jason.Bestimt #DEV-VR - Manual merge of Dev-MAIN to resolve conflicts for robomerge Change 4167983 by Joe.Conley For Lumin, only build shaders for OpenGL or Vulkan, not both. Fix a shader compile error in BogMyrtle material (can't use SpeedTree node on mobile). #jira UE-61126 Lumin Sample: Warning: LogMaterial : Failed to compile material for GLSL_ES2 Change 4168244 by Nick.Whiting Fix for stereo layers crashing on exit, where the DebugCanvas was destroyed after the layer manager, causing a nullptr dereference Change 4170213 by Mike.Beach CIS build fix - removing duplicate definition & adding a missing #pragma once to a header fille #mlqdr Change 4170299 by Mike.Beach LNK fix - fixing up more fallout from the recent merge from DevMain. Adding in missing function that was dropped in the merge (matching Main's version). Change 4170962 by Nick.Whiting Back out changelist 4160099: Removing the enabling by default on lumin Change 4171227 by Chance.Ivey Unreal Engine logos for Portal and Model. These need to be set in Project Settings. Change 4171260 by Chance.Ivey Removing ML basic assets for project icons. Change 4171939 by Joe.Conley #jira UE-61124 Lumin Sample: EDL errors during Launch On Change Lumin Sample to use vulkan, like we do for everything by default now. Didn't see this error after this change. Change 4172321 by Mike.Beach Sizing the debug layer properly for the magic leap device (inverting the y when rendering with opengl). #jira UE-60299 #mlqdr Change 4174175 by Jason.Bestimt #DEV-VR - Fix for dragging a "skylight" from lighting menu directly into sequencer. Change 4174237 by Jason.Bestimt #DEV-VR - fixing initializer order #JIRA - UE-61337 Change 4175281 by Joe.Graf Added support to stream a preview image and the accompanying AR world data for shared AR experiences Change 4175656 by Ryan.Vance Copying //Tasks/UE4/Dev-VR-VulkanMedia to Dev-VR (//UE4/Dev-VR) Preliminary vulkan media player support for ML. There are a number of tasks left to do with this feature before committing to main: - Clean up leaked color conversion handles - Texture slot binding is not robust for media textures - Color conversion extension init should be move to a lumin platform function - Mobile renderer's base pass may collapse multiple materials together into the same drawing policy, so the immutable samplers referenced in the pso would bleed into other materials - Fixing above will allow us to remove the immutable samplers from the mobile material rendering proxy to ensure we don't re-introduce the fort bug listed in the related comment Change 4175684 by Ryan.Vance Fix for vk media player crash Change 4175699 by Nick.Whiting Merging CL 4175640 (fix for Audio Capture pausing and resuming) to Dev-VR Change 4176804 by Joe.Conley Rolando originally hacked the RHI for Lumin with the ForceEnableDebugMarkers() function; return false there instead of if PLATFORM_LUMIN. Change 4178261 by Ethan.Geller Back out changelist 4175699 #fyi nick.whiting #rb none Change 4179088 by Mike.Beach Mirroring CL4178961. Removing spammy error log, per consult from ML - apparently, at this time, MLSnapshotGetTransform() can return NaNs (which we handle). It is currently expected from the API. #jira UE-61127 #mlqdr Change 4179629 by Jeff.Fisher UEVR-1209 Update to Magic Leap Hand Tracking API -Switched from the Gestures API to the HandTracking API -There is nothing like the 0 and 1 tracking point that change meaning per gesture in the new API, so I assigned the former Center/Pointer/Secondary special 1/3/5 2/4/6 to Center/IndexFingerTip/ThumbTip. #review-4178177 #jira UEVR-1209 #mlqdr Change 4179705 by Jeff.Fisher MagicLeapHandTracking CIS fix. Change 4181301 by Joe.Graf Moved FaceARSample to Samples/Sandbox/AR/ so we can have all of the AR samples together Change 4181402 by Joe.Graf Fixed a missing #ifdef wrapper in the MagicLeap plugin Change 4181445 by Joe.Graf Fixed another missing #ifdef wrapper in the MagicLeap plugin Change 4181558 by Jeff.Fisher HandTracking LeftGestureButton fix -The reality is Nihav made the fix, and I reviewed it. Change 4185551 by Joe.Graf Added support to query and specify the desired video format for an AR session Change 4185843 by Joe.Graf Merged in absolute scale/location/rotation PR #4760 from Wang Hao Change 4186875 by Joe.Graf Added stats for face ar #jira: UE-53883 Change 4187681 by Joe.Graf Fixed unity build compilation error Change 4188782 by Joe.Graf Work around LiveLink interpreting ARKit timestamps incorrectly causing jitter and animation lag #jira: UE-61540 Change 4189204 by Joe.Graf Merging using Release-4.20_to_Dev-VR Change 4189331 by Joe.Graf Removed all of my merge markers from the lab Change 4189477 by Joe.Graf Added performance tuning options for Face AR to ARSessionConfig Added whether to mirror or be face relative for Face AR to ARSessionConfig #jira: UE-53881 Change 4189835 by Joe.Graf Changed how timestamps for ARKit objects are updated to make them more amenable with the engine #jira: UE-61550 Change 4190085 by Jeff.Fisher Duplicating from Dev-Partner-MagicLeap-4.20 cl 4189995 HandTracking 'failed to load' errors. -Needed a package redirector as well as the various class and enum redirectors. #MLQDR #review-4189613 Files: //UE4/Dev-Partner-MagicLeap-4.20/Engine/Config/BaseEngine.ini#8 Change 4190100 by Jason.Bestimt #DEV-VR - Adding script version string to make sure AutoSDK gets run again [To Fix CIS Builds for UE4 Lumin] Change 4190795 by Joe.Conley #jira UE-61265 Audio Capture Components need to hook Lumin backgrounding notifications to pause capture Shelve 4175638 got committed but didn't compile. Fixed compile errors and changed some checks from Handle != ML_HANDLE_INVALID to MlIsValidHandle(Handle), fixed functions to return false if they error, responded to the errors by not continuing further, etc... Don't know if this fixes all the functionality, but doesn't crash for me anymore. Change 4196211 by Jason.Bestimt #DEV-VR - Fixes for Android platform with new Lumin Vulkan Color Conversion Functions Change 4199020 by Jason.Bestimt Making sure bHaveVulkan is true for Lumin Change 4199506 by Jason.Bestimt #DEV-VR - Merging CL 4199443 from Dev-Magicleap to clear cache on looping media Change 4200139 by Joe.Graf Initial check in of a project to illustrate AR persistent sessions Change 4200299 by Joe.Graf Fixed the plugin setup for ARSaveLoad Change 4200327 by Joe.Graf Fixed adding face ar plugin instead of world ar plugin Change 4200330 by Joe.Graf Added a sample for using ARKit's environment probe feature Change 4200352 by Joe.Graf Changed the ARSessionConfig to use automatic environment probe generation Change 4201607 by Zak.Parrish Moving latest version of FaceARSample to DevVR Change 4203453 by Jason.Bestimt #DEV-VR - Fixing Audio Capture to not re-open stream if it's already open #JIRA: UE-61609 Change 4204527 by Joe.Graf Changed the AR World Save and AR Get Candidate Object latent actions to use the new mechanism to reduce code Change 4204533 by Joe.Graf POC of saving and load an AR world Change 4204806 by Joe.Graf Added more descriptive display names for AR blueprint operations Change 4204870 by Jeff.Fisher HandTracking blueprint access to all keypoints -Duplicating for Dev-VR from Dev-Partner-MagicLeap-4.20 -Created new GetGestureKeypointTransform blueprint function to get a keypoint's transform by hand and keypoint enum. -Deprecated the old GetGestureKeypoint methods -Fixed Special_1 and Special_2 to use hand center instead of wrist center. -Exposed all the keypoints to blueprint, so they can work right away when underlyign support appears in the OS. #MLQDR #review-4200777 Change 4204877 by Jeff.Fisher Updated gesture test content to replace deprecated hand tracking blueprint functions. Change 4204915 by Joe.Graf Hid blueprint internal methods from being callable Change 4205082 by Joe.Graf Split ImportFileAsTexture2D into two functions so you can also import from a buffer Change 4205170 by Joe.Graf Made the proxy create function blueprint internal only Change 4206898 by Joe.Graf Initial ARSharedWorld multiplayer sample check in Change 4207396 by Joe.Graf Removed the FARSharedWorld from ARSharedWorldGameState to make things simpler/cleaner Change 4207406 by Joe.Graf Hooked up the delivery of the AR shared world data to the clients in the MP sample Change 4207444 by Joe.Graf Fixed the shadowing warning Change 4207794 by zak.parrish Checking in first stage of usable Save/Load AR work. Some UI, foundational functionality. Not testable yet. Change 4207832 by Joe.Graf For Zak Change 4207952 by Joe.Graf For Zak part 2 Change 4208268 by zak.parrish Checking in changes to ARSaveLoad's game mode Change 4208316 by zak.parrish Living in shame under JoeG's rough admonishment. And fixing UI bugs. Change 4208404 by zak.parrish Actually saving... maybe? Change 4208407 by Joe.Graf Fixed wrong platform name being used as the whitelist for the AppleImageUtils plugin Change 4209764 by Joe.Graf Added missing module class for AppleImageUtilsBlueprintSupport Change 4210695 by Joe.Graf Added compression and versioning to the AR saved world data Change 4211461 by Joe.Graf Incremented the face live link packet version since the new blendshapes were added Change 4211843 by Joe.Graf Split some of the methods for ARKit conversion into a cpp from being all in the header Added some logging during conversion Change 4212020 by Joe.Graf Added support for telling the AR system whether to reset tracking and tracked objects (useful for generating a play space and then using lower cpu/gpu tracking only) Change 4212878 by Joe.Graf Fixed inline problem and exported FAppleARKitConversion class Change 4214969 by Ryan.Vance #jira UEVR-1257 Adding initialization to all members in the default FAppleARKitFrame ctor Change 4217193 by Jason.Bestimt #DEV-VR - Fix for swapping shader cache formats and using Launch On We now reload the settings each time they are used rather than caching once at startup Change 4217487 by Jason.Bestimt #DEV-VR - Fix for CIS shadowed member variable error Change 4220007 by Jason.Bestimt #DEV-VR - Fix for Dev-VR compile issue for Lumin Target Platform dependencies on Engine Change 4223757 by Jason.Bestimt #DEV-VR - Moving Lumin Audio Platform above Android because Lumin is Android Change 4230863 by Keli.Hlodversson Updating to SteamVR 1.0.15 Change 4235330 by Jason.Bestimt #DEV-VR - Selective Merge from Dev-Partner-MagicLeap-4.20 CL 4117808 SKIP 4166531, 4172433, 4173415, 4174167, 4175152, 4174192 CL 4175448, 4175781, 4176126, 4176135, 4176138, 4176803, 4178961 SKIP - 4179818, 4179864 CL 4179921, 4179956, 4180229, 4180268, 4180298, 4182733, 4183548, 4184684, 4186883, 4187230, 4189420, 4189995, 4190527, 4190721 SKIP - 4191085 CL 4192219 SKIP 4195948 CL 4197287, 4197951, 4197956, 4201351, 4202541, 4202544, 4202547 SKIP 4202774 CL 4203462, 4203484 SKIP 4204670 CL 4206823, 4209729, 4209810, 4211003, 4215367, 4215662, 4215892, 4215898, 4220239, 4220257 SKIP 4220295 CL 4220307 SKIP 4221842 CL 4221866, 4222959, 4223772, 4225943 SKIP 4226329, 4227773 CL 4228213, 4228270 SKIP 422902, 4229054, 4229365, 4230881, 4233277 Change 4235969 by Joe.Conley MagicLeap: Add quotes around the path to the tools (clang etc) in the mlsdk directory, so that it won't fail if the MLSDK directory has a space in the path. Change 4239300 by Nick.Whiting Adding missing uplugin file to GoogleARCoreServices Change 4240183 by Keli.Hlodversson Updating to SteamVR 1.0.16 Change 4241714 by joe.conley #jira UE-62189 - "Various QAARApp/Content/...uassets have been saved with empty engine version" Resaved assets. Change 4242300 by Nick.Whiting Fix for ARCore Tools being in the wrong folder, emitting RuntimeDependency ref to make sure they're properly included #jira UE-62277 Change 4244428 by Mike.Beach Copying //UE4/Partner-Oculus-Staging to Dev-VR (//UE4/Dev-VR) Change 4244671 by Jeff.Fisher Fxing 'Lumi" build break. Change 4247283 by Nick.Whiting Merging fix from CL 4247094 for ARCore external dependency locations Change 4255817 by Ryan.Vance #jira UE-58854 Vulkan Shared Texture Media Framework support cleanup Don't leak vk color conversion handles and only allocate if needed Move color conversion device init to a lumin platform call Add immutable sampler state to mobile base pass policy comparison Remove WITH_VULKAN_COLOR_CONVERSIONS wrappers around color conversion code TODO: FVulkanDescriptorSetsLayoutInfo::AddBindingsForStage still uses the first combined image sampler found when handking materials w/ immutable sampelrs which is not robust. The correct binding needs to be selected from reflection data generated by the compiler. Change 4256021 by Jeff.Fisher UEVR-1261 MagicLeap HandTracking should be exposed to LiveLink -Exposed hand tracking transforms through live link. -Added blueprint function to get the livelink source. -Exposed LiveLikeSourceHandle through ILiveLinkSource.h so that it can be used by the MagicLeapPlugin. -The transforms are in tracking space. They form a hierarchical skeleton with HandCenter as the root. See FMagicLeapHandTracking::SetupLiveLinkData() for details on the hierarchy. With the current magicleap runtime functionality many transforms in the skeleton are always identity. #jira UEVR-1261 #review-4248322 Change 4258366 by Jeff.Fisher UE-62494 Dev-VR Editor fails to build with errors related to MagicLeapHandTrackingLiveLink.cpp -Fixed build break Change 4260114 by Ryan.Vance #jira UE-62509 Moving color conversion vk entry points to lumin platform to avoid failing to find them in android drivers. Change 4263040 by Ryan.Vance Fixing scope issue. Change 4263556 by Jeff.Fisher UE-62507 Fatal error crash opening packaged QAGame UE-62544 //UE4/Dev-VR - Run Automated Tests Cooked Win64 - Unhandled Exception -Updated #define OPENVR_SDK_VER TEXT("OpenVRv1_0_16") #jira UE-62507 Change 4265161 by Jason.Bestimt #DEV-VR - Fix for Lumin BP Projects not using their project specific ini files for compiling/cooking/packaging #JIRA: UE-62568 Change 4265739 by Ryan.Vance Marker API override for ML VK. The current ML driver unofficially supports debug markers, but will report the extension unsupported if queried directly. Once they add official support, we need to add the extension name back into the list. Change 4267320 by Ryan.Vance We need to add the debug marker extension for all platforms but Lumin. Change 4268149 by Michael.Trepka Fix for Lumin Toolchain failing to compile on Mac due to changes to the SDK [CL 4268410 by Jason Bestimt in Main branch]
2018-08-08 10:57:55 -04:00
virtual void RefreshSettings() override
{
}
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 4285612) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3836829 by Ben.Marsh UBT: Fix ability to precompile plugins from installed engine builds. Change 3839519 by Ben.Marsh UBT: Simplify configuring bPrecompile and bUsePrecompile settings for modules. Each rules assembly can now be configured as installed, which defaults the module rules it creates to use precompiled data. Change 4042043 by Steve.Robb GitHub #4705 : Added weak lambda's for delegates and multicast delegates. Change 4042056 by Robert.Manuszewski Optimized Mark Phase of GC by up to 10ms by making it run in parallel and removing a huge array presize which we didn't need. Change 4042104 by Robert.Manuszewski Set the minimum GC cluster size to 5 so that GC doesn't have to process micro clusters which are more expensive than processing individual objects + Exposed the minimum cluster size to ini and project settings as gc.MinGCClusterSize + Added the ability to sort clusters by name/object count/mutable object count/referenced clusters count when dumping them with gc.ListClusters command Change 4042377 by Robert.Manuszewski Reworked how GC and other threads (ALT specifically) interact - GC will now notify the ALT it wants to run and ALT will immediately try to finish its current work to allow that. Also the entire ALT tick is now protected against GC running at the same time to improve ALT stability. + added gc.ForceCollectGarbageEveryFrame console variable that triggers a forced GC every frame Change 4042427 by Robert.Manuszewski Changed FGCCSyncObject to use events when waiting for GC to finish so that it doesn't spin on non-game threads when GC is running Change 4042482 by Robert.Manuszewski Unhashing unreachable objects (ConditionalBeginDestroy) will now also be done incrementally, just like the purge phase of Garbage Collection Change 4042635 by Robert.Manuszewski Fix for a potential assert when incremental purge garbage is pending and something forces a full purge Change 4044092 by Steve.Robb Fix for forward declared CoreUObject weakobject types in delegates when building in Clang. Change 4044102 by Robert.Manuszewski Fix for a possible hang when worker threads are preventing GC from running and something is later trying to FlushAsyncLoading with the Async Loading Thread enabled Change 4044113 by Steve.Robb Another Clang fix. Change 4044160 by Robert.Manuszewski Disregard For GC pool will now be enabled by default in cooked builds Change 4044287 by Steve.Robb Typo fix. Change 4047723 by Graeme.Thornton TBA: Fixes for import/export name cache and object resolving Change 4048015 by Graeme.Thornton TBA: Weak/Soft/Lazy pointer serialization changes * Remove FWeakObjectPtr::Serialize, move it's logic into, and replace usages of with calls to, FArchiveUObject::SerializeWeakObjectPtr(). Ensures that something is always sent to the archive so that structured archives can be kept happy in the future. * Added Weak/Soft/Lazy pointer handling to the structured archive slot interface and all the formatters. Binary formatters just forward the call onto their inner and text archives store as a string path reference. * FArchiveUObjectFromStructuredArchive caches all these pointer types and stores indices in the binary block, same as with a UObject*. All pointers are then forwarded to the underlying formatter in one go on finalization. Change 4048021 by Steve.Robb Fix for binding an unbound TFunction to another TFunction with a different signature. Also all null pointers now count as unbindings, not just nullptr. TIsMemberPointer added. TIsATFunction and TIsATFunctionRef renamed to remove the 'A's. Change 4048544 by Robert.Manuszewski Fixing ConditionalBeginDestroy profiling after changes to incremental CBD. Change 4051028 by Graeme.Thornton TBA: ArchiveFromStructuredArchive adapter uses Inner to determine if it is outputting to text, and sets it's own ArIsTextFormat to false Change 4051056 by Graeme.Thornton TBA: High level tagged property / UObject base class text serialization - UObject serialize converted to structured archive - Properties written to text individually with text tags, and then binary adapted values - Only saves, doesn't load Change 4051111 by Graeme.Thornton TBA: Temporarily disable loading of text assets until tagged property serialization path is fixed up Change 4051154 by Graeme.Thornton TBA: Convert a few uobject serializers to structured archive format for example purposes Change 4051181 by Graeme.Thornton TBA: Added default structured archive implementation of SerializeItem to UProperty, which just calls the FArchive version on an FArchiveUObjectFromStructuredArchive adapter. Implemented structured archive SerializeItem for UArrayProperty Change 4051197 by Graeme.Thornton TBA: ObjectProperty text serialization Change 4051216 by Graeme.Thornton Restored a modified FWeakObjectPtr::Serialize function to keep backwards compatibility in code I don't have access to. Change 4051261 by Graeme.Thornton TBA: Convert UMetaData to structured archive Change 4051374 by Steve.Robb Incorrect assert removed. Change 4051562 by Robert.Manuszewski Adding stats for the new GC internal functions Change 4051614 by Graeme.Thornton TBA: Removed UProperty::SerializeItem(FArchive, ...) and replaced with UProperty::SerializeItem(FStructuredArchive::FSlot, ...). Fixed up most of them to work properly and added adapters in for any that were non-trivial. Change 4052512 by Graeme.Thornton TBA: Temporary workaround for softobjectptr and lazyobjectptr uproperties not serialization anything when they know the archive is a reference collector. They should always be serializing their pointers and letting the underlying archive itself ignore them. Change 4053917 by Robert.Manuszewski Clustered objects from clusters that are no longer reachable will now be marked as unreachable immediately when gathering unreachable objects Change 4053919 by Robert.Manuszewski Added the ability to disable incremental BeginDestroy in ini/project settings Change 4055518 by Daniel.Lamb Fixup for deterministic audio generation issue. Submitted on behalf of Rich.Whitehouse #jira nojira #test prefilght automated test. Change 4056854 by Graeme.Thornton TBA: Added a test asset to EngineTest which contains all the different property types and test cases. Change 4056858 by Graeme.Thornton TBA: Updated USetProperty to proper structured archive usage Change 4056872 by Graeme.Thornton TBA: Add map property field to test object Change 4056873 by Graeme.Thornton TBA: Convert UMapProperty to full structured archive Change 4056994 by Graeme.Thornton TBA: Converted FText over to structured archive. Implemented saving, but not loading. Change 4059728 by Ben.Marsh UBT: Add support for using adaptive non-unity builds when the engine and project are in separate repositories. Change 4059805 by Graeme.Thornton Fixed typo in text serialization. Fixes CIS automation test errors Change 4060007 by Graeme.Thornton TBA: FArchiveFromStructuredArchive will now access it's host slot lazily, i.e. only when a value is actually written to the archive. Change 4060092 by Stefan.Boberg Added optimized Windows console window output path to GenericConsoleOutput since this slowed down cooking considerably (2 minutes spent in wprintf alone for one large dataset) When stdout is attached to a console we use the WriteConsoleW function instead of wprintf since the latter is very slow especially in unbuffered mode which the engine currently configures for stdout (see setvbuf call in LaunchEngineLoop.cpp). At some point we should reconsider this buffering policy since it's likely to slow down other platforms as well but I wanted to do a safe change for now as I don't yet fully understand why the setvbuf call is there in the first place. Change 4060108 by Stefan.Boberg Introduced some additional target platform utilities to help with asset cook optimizations * We now assign each ITargetPlatform a zero-based ordinal value * Introduced FTargetPlatform and FTargetPlatformSet types to help store platform references and platform sets efficiently. These are not currently used in the engine but are designed to replace the existing ITargetPlatform/string/FName representations in the cooking data structures. Change 4060143 by Graeme.Thornton Undo //UE4/Dev-Core/Engine/Source/Runtime/... changelist 4060007 Needs some other changes that I haven't checked in yet... Change 4062432 by Ben.Marsh Fix error message when enumerating P4 changes. Change 4062648 by Ben.Marsh Add missing p4 integration action. Change 4063620 by Graeme.Thornton Integrated a fix from UDN where the engine would crash when trying to load a very small encrypted file (<16bytes) from a pak file, where the read address wasn't already aligned to the AES block size. (https://udn.unrealengine.com/questions/431989/crash-while-reading-a-very-small-file-in-encrypted.html) Change 4066963 by Robert.Manuszewski Fixing GC cluster verification code reporting false positives when a cluster is referencing another cluster through 'mutable' objects list. Change 4067133 by Robert.Manuszewski Changed log verbosity when reporting individual cases of GC cluster assumption violations as they are followed by an asser anyway and this way we get the chance to see all issues before we assert at the end of these checks. Change 4067443 by Steve.Robb FString can now be constructed from any char pointer type and length. Change 4068156 by Steve.Robb Fix necessary because of FString constructor change in CL# 4067443. Change 4070258 by Graeme.Thornton Fixes for VSCode Change 4070372 by Graeme.Thornton TBA: Script struct serialization to structured archives Change 4071913 by Ben.Marsh Move bulk of the code for UnrealPak into an engine developer module, so it can be used in the editor. Change 4071914 by Ben.Marsh Missing files. Change 4071937 by Ben.Marsh Missing header. Change 4072015 by Ben.Marsh Fixes for compiling PakFileUtilities as part of the editor. Change 4072826 by Steve.Robb TBitArray::Reserve() added. TBitArray::Add() overloaded to allow adding multiple bits. TSparseArray::Reserve() optimized to call the overloaded Add(). Change 4073271 by Daniel.Lamb Fixed add patch tier in project launcher passing the wrong commandline option to UAT. #test none Change 4074708 by James.Hopkin #core Removed redundant Casts Change 4074763 by Steve.Robb Fix for TSparseArray::Reserve() size. Change 4076063 by Ben.Marsh Add an "UnrealPak" commandlet with the same functionality as the standalone UnrealPak program. Invoke by running the editor with -run=UnrealPak and the standard UnrealPak commandline options. Change 4077064 by Robert.Manuszewski Fixing compile error in PakFileUtilities Change 4077144 by Graeme.Thornton TBA: TextAssetCommandlet improvements * Collect lists of broken assets during roundtrip tests and print a summary of packages that failed each phase at the end * After resaving as text, load the file back as a plain JSON hierarchy to ensure the output was valid Change 4077412 by Ben.Marsh Set the correct exit code for UnrealPak. Should return 0 on success, not 1. Change 4077760 by Graeme.Thornton TBA: Loading fixed for tagged property serialization Includes conversion of all UProperty::ConvertFromType() and SerializeFromMismatchedTag() functions to use structured archives Lazy initialization of FArchiveFromStructruredArchive when loading, to support the possibility of an adapter being create around an object property serialize call to its inner UStruct, which then decides not to do anything and return false. Stops the ArchiveFromStructuredArchive from consuming the slot and getting upset later on when we try to serialize normal tagged properties from it. Disabled lazy bulk data loading from text assets. Requires a bigger change to make it work. Added some debug checks to json input formatter which track the current value stack size when a new object is pushed onto the stack, and makes sure that the stack has returned to the same size when the object is popped. Catches cases where we unpack an array/stream to the value stack but then don't consume all the items. Change 4078800 by Ben.Marsh Change UAT to using the editor's UnrealPak commandlet rather than invoking the standalone UnrealPak executable. To improve performance when building several PAK files, also add a new -batch=<file> command which reads commands to execute in parallel from a text file. Change 4079745 by Graeme.Thornton TBA: Migrated a couple of UObject Serialize functions to FStructuredArchive (SoundCue / MaterialExpressions / Editor strip flags) Change 4079847 by Graeme.Thornton TBA: Add 'FindMismatchedSerializers' mode to text asset commandlet, which dumps out a list of all UClasses which don't have the CLASS_MatchedSerializers flag, meaning we can't guarantee the have Serialize functions for FArchive AND FStructuredArchive, therefore we can't use the new structured archive based serialize path. Should only ever be native instrinsic classes as UHT takes care of all other cases. Change 4079925 by Ben.Marsh Fix incorrect assignment when deriving name for chunked pak file. Change 4080214 by Ben.Marsh Move the ThreadPoolWorkQueue class into DotNETUtilities so it can be used by other projects. Change 4082394 by Graeme.Thornton CIS fix for variable shadowing warning Change 4082583 by Ben.Marsh Add a IBinarySerializable interface for types that support reading from a BinaryReader and writing to a BinaryWriter. Implementing IBinarySerializable implies a constructor taking a BinaryReader argument is available for deserializing. Change 4082652 by Ben.Marsh Fix FileReference.Directory not returning a directory with a trailing backslash for files in the root directory. Change 4082755 by Graeme.Thornton Fixed an erroneous usage of TUniquePtr<uint8>as a pointer to a uint8 array when creating pak files. Caused a crash when compression was enabled, and has probably surfaced because pak generation is now done by an editor commandlet rather than a standalone program. Change 4082756 by Graeme.Thornton Fixed some incorrect documentation for pakfile compressed chunk headers Change 4082883 by Graeme.Thornton Static analysis warning fix Change 4082912 by Ben.Marsh Move ExceptionUtils into DotNETUtilities. Change 4085291 by Graeme.Thornton TBA: In the Json output formatter, write float and double values out with enough precision for successful roundtripping. Added some debug only code which will immediately reconvert the string back to its original value and compare the the input Change 4085523 by Graeme.Thornton TBA: Remove only explicit usage of DECLARE_FSTRUCTUREDARCHIVE_SERIALIZER. Should only be used from UHT generated code. Change 4086037 by Robert.Manuszewski Fix for a potential race condition when two threads want to acquire GC lock Change 4088655 by Graeme.Thornton Pak creation now uses the bEnablePakSigning setting from the crypto config json file Change 4091474 by Steve.Robb Fix for TStaticBitArray::FindFirstSetBit() and TStaticBitArray::FindFirstClearBit(). Unused variables removed. Change 4093632 by Steve.Robb CIS fixes. Change 4093656 by Graeme.Thornton Build fix Change 4093744 by Ben.Marsh Allow per-chunk settings for whether to enable compression in UnrealPak. Change 4099712 by Gil.Gribb UE4 - Fixed rare case where insufficient space was preallocated for cooldown ticks. #jira UE-59686 Change 4099912 by Stefan.Boberg Cooking timer optimizations: - Replaced data structures for FScopeTimer and FHierarchicalTimerInfo. Previous implementation used FString for many things and caused *lots* of heap and string concatenation activity. Replaced with a compile-time node id (using __COUNTER__) and raw string literals. - Removed PERPACKAGE_TIMER support (was disabled by default and was difficult to test) - Made it possible to toggle OUTPUT_TIMING and ENABLE_COOK_STATS independently - Removed some extremely tight timers because the overhead from calling QPC significantly exceeded the measured code This change shaved some 15% off a clean cook of Fortnite WindowsClient (en) with fully populated local DDC Change 4100519 by Stefan.Boberg Quick fix for Linux build issue introduced in 4099927 Change 4105327 by Stefan.Boberg Cooker: Changed FHierarchicalTimerInfo so it uses a linked list for tracking child nodes, to be able to deal with any child count. Previously we assumed there would never be more than 9 children but it turns out there are cooker modes that need more. Fixes check when using -FullLoadAndSave to cook Change 4105448 by Stefan.Boberg - Fixed Linux build warning re: member initialization order - Also eliminated OUTPUT_HIERARCHYTIMERS/CLEAR_HIEARCHYTIMERS macros (plain functions are fine) - Moved finishing-up code for FullLoadAndSave() to TickCookOnTheSide() call site to improve timer output. Previously some of the scopes would not have been closed before printing and thus the output was misleading. Change 4109031 by Ben.Marsh Attribute-driven Perforce wrapper (old Epic Friday project). Offers a more complete implementation than the current P4 wrapper in UAT without requiring any platform-specific libraries. Uses the Python binary output for parsing. Change 4109588 by Ben.Marsh UBT: Add extension methods for serializing a nullable type to a BinaryReader/BinaryWriter. Change 4109595 by Ben.Marsh Missing project file for DotNETUtilities. Change 4110724 by Stefan.Boberg Removed annotation map locking in UObjectMarks, eliminating around one minute (~3.5%) from Fortnite cook time. The locking was redundant since the annotation maps are managed per thread anyway. Change 4111304 by Ben.Marsh UAT: Add support for setting a status message through the log class. Allows writing transient messages (eg. progress messages) which will be cleared out before writing other messages. Best used through the LogStatusScope class, which can set a status message for the duration of a using() block. As part of this change, the console no longer has to be added as a dedicated trace listener. Since we already special-case this listener when formatting log output, it's easier to just keep the implementation separate to the other trace listeners. Change 4112708 by Steve.Robb Fix for TBitArray::MaxBits in assignment. Change 4114133 by Stefan.Boberg Tweaked how low-level memory (LLM) tracker is implemented to reduce overheads. Previously FMemory functions would acquire the LLM singleton and call OnLowLevelFree/OnLowLevelAlloc etc which would check the bIsDisabled flag and early out if it was set. Due to how frequently these functions were called this ended up costing quite a bit. - This change makes the flag a static member variable instead of a member variable and therefore enables a simpler early-out to be implemented. - The singleton getter is also simplified to avoid hitting the threadsafe singleton construction path on every call. - The enable flag is no longer TAtomic - this also incurs extra overhead for no clear benefit Shaves approximately 3.5% (one minute) off a Fortnite cook test scenario (using -FullLoadAndSave) Change 4115010 by Robert.Manuszewski Fixing CIS Change 4115249 by Robert.Manuszewski Fixing async loading code asserts when exiting game very early due to an error #jira UE-56267 Change 4117091 by Ben.Marsh Prevent doubled-up lines when writing status updates with console log verbosity. Change 4117207 by Ben.Marsh UGS: Do not include executables in diagnostics zip file, and ignore "no such files" error when cleaning workspace. Change 4119175 by Ben.Marsh UGS: Fix crash writing version files when directory does not already exist. Change 4119987 by Ben.Marsh UGS: Show a dialog box while the launcher is updating executables from Perforce, which allows cancelling the operation if necessary. Allow setting the username on the settings window, and prompt for login credentials if necessary. Should prevent situations where users have to update settings from the command prompt. Holding down shift during launch now shows the settings dialog rather than an immediate prompt to launch the unstable version (unstable version is shown as a checkbox on this dialog). Change 4119991 by Ben.Marsh Update version number for UGS launcher to 1.13. Change 4121943 by Robert.Manuszewski Don't use FArchiveAsync2 for reading packages with non-async path in editor builds as its performance is worse than the standard archive's (saves about 1 minute when doing larger cooks and 7 seconds when loading into PIE) Change 4122592 by Steve.Robb GitHub #4762 : Improve wording and grammar of Math comments Also includes improved accuracy in FMath::ComputeBoundingSphereForCone(). Change 4122819 by Stefan.Boberg Don't call CreateDirectory redundantly when opening files for writing using FFileManagerGeneric::CreateFileWriter This change avoids calling IPlatformFile::CreateDirectoryTree if possible since this is a very expensive function especially for deep hierarchies as it performs directory creation from the root directory onwards instead of from the leaf downwards. That function should also be fixed but this change improves performance in the meantime. Change 4122872 by Stefan.Boberg CreateDirectoryTree now creates directories leaf-to-root instead of the other way around. This is much more efficient since we don't spend time on system API calls for directories which already exist. This accounted for a very large amount of CPU time in cooking as the full target file directory hierarchy would be "created" for every single output file. Change 4123109 by Stefan.Boberg - Disable overlapped I/O in editor / cooker. Synchronous I/O reduces the number of syscalls and Windows performs prefetching on our behalf anyway for sequential reads - Eliminated syscall which was issued for every write to update cached file size -- since we're the only writers to the file (file access allows read sharing at most) we can authoritatively update the file size on write completion Change 4123455 by Ben.Marsh PR #4775: New build param PCHMemoryAllocationFactor to set /Zm VS build param. (Contributed by lucaswall) Change 4124207 by Ben.Marsh UBT: Remove some unnecessary indirection for generated code paths. Change 4124217 by Ben.Marsh UBT: Remove another unused variable from UEBuildModuleCPP. Change 4124377 by Stefan.Boberg In IPlatformFile::DeleteDirectoryRecursively, attempt to delete file first and if it fails clear the readonly flag and try again Previously there was a call to clear the readonly flag for every deleted file and this is a waste of resources 99% of the time. The SetFileAttributes call accounted for a significant amount of time during cooker sandbox directory deletion Change 4125071 by Stefan.Boberg Some tweaks to FQueuedThreadPoolBase scheduling and memory management - Explicitly pass in false for TArray::RemoveAt(..., bool bAllowShrinking) argument to prevent memory reallocation when arrays are drained and inevitably repopulated shortly afterwards - Use a MRU strategy instead of LRU when picking a thread to wake up. The MRU thread is the most likely to have a 'hot' cache for the stack etc. Picking from the back of the array also happens to be cheaper since no memory movement is necessary when RemoveAt is called. (This was the strategy in place before CL2600362 which seems to have changed it unintentionally) - Release lock as soon as a thread has been chosen, before asking the worker thread to wake up and do the work Change 4126132 by Ben.Marsh UAT: Detect when stdout is redirected and prevent using backspace characters to move the cursor. Change 4126867 by Graeme.Thornton TBA: Fix tagged binary formatter Change 4127010 by Robert.Manuszewski AnimScriptInstances created at runtime will now also be added to the owning omponent's cluster to avoid GC issues. Change 4127932 by Ben.Marsh WorkspaceTool: Reduce unnecessary logging of status messages when console output is not redirected. Change 4129050 by Ben.Marsh UGS: Check for NET Framework 4.5 being installed before running the installer. Also fix warning trying to kill existing UGS instances before upgrade. Change 4129459 by Graeme.Thornton TBA: TextAssetCommandlet - When outputting converted assets to an output path, replicate the workspace relative path in the output directory Change 4129515 by Graeme.Thornton TBA: Add EnterRecord overload that allows outputting of available field names when loading. Change 4129517 by Graeme.Thornton TBA: Tagged properties are written out as named fields on the "Properties" record, rather than as a stream with a null tag at the end Change 4129518 by Graeme.Thornton TBA: Added a local const bool to allow easy hacking out of text asset loading support Change 4129558 by Graeme.Thornton TBA: Build fix for textasset-less configs Change 4129614 by Ben.Marsh UGS: Main window is now restored to normal size when activated by clicking on the tray icon. #jira UE-60490 Change 4129618 by Ben.Marsh UGS: Speculative fix for unreproduced exception accessing disposed window while shutting down. Change 4131936 by Robert.Manuszewski Removing some WIP code accidentally checked in with CL #4121943 Change 4133490 by Ben.Marsh UGS: Allow the $(Change) variable to be used in more places than just the context menu. #jira UE-60573 Change 4133550 by Ben.Marsh UGS: Setting for whether or not to use incremental builds is now exposed through the variable "$(UseIncrementalBuilds)" for use by custom build steps. #jira UE-60554 Change 4133681 by Ben.Marsh UGS: A per-project list of folders and extensions to be deleted by default when running the 'clean workspace' tool can now be specified through the <ProjectDir>/Build/UnrealGameSync.ini file. Settings may be specified for an individual branch (via a category with the depot path to the project) or for wherever the project is currently open (via the [Default] category). The SafeToDeleteFolders list specifies a substring that will be checked against folder paths. Anything containing this folder will be marked as safe for delete by default. The SafeToDeleteExtensions list specifies a list of extensions for files that can always be deleted. Example: [Default] +SafeToDeleteFolders=/MyGame/Test/ +SafeToDeleteFolders=/DataService/ +SafeToDeleteExtensions=.xx1 +SafeToDeleteExtensions=.xx2 #jira UE-60575 Change 4135449 by Ben.Marsh Fix allowing use of Job objects on Windows platforms (debug code submitted by mistake) Change 4135730 by Ben.Marsh UBT: Plugins can now be enabled and disabled from the .target.cs file (for targets that do not use the shared compile environment), by compiling the list of enabled/disabled plugin names into the Projects module. Change 4135823 by Ben.Marsh UBT: Remove legacy code to handle disabling optional plugins; now that this is compiled into the target, it will work for any plugins we choose. Change 4135945 by Ben.Marsh UBT: Fix error running programs with no explicitly enabled or disabled plugins. Change 4137207 by Ben.Marsh UGS: Align all badges with the same name, to make it easier to see which CIS steps are being run. Allow overriding the slot taken by a particular badge by calling it "SlotName:LabelName". Change 4137311 by Stefan.Boberg Removed child cooker support. In practice it is not a useful feature as it provides no performance improvement (quite the opposite in fact) and adds testing and maintenance complexity. Change 4137393 by Ben.Marsh UGS: Fix display of multiline errors in the status panel. Change 4141708 by Steve.Robb GitHub #3631 : Incorrect default argument in WeakObjectPtrTemplate #jira UE-45490 Change 4146655 by Stefan.Boberg Removed FullGCAssetClasses logic - no longer necessary nor useful Change 4147318 by Ben.Marsh UGS: Compress build badges in a column if it shrinks below the size that they would be visible. Change 4148207 by Ben.Marsh UGS: Added support for showing the latest completed build from a specific list of badges in the status panel. To declare a badge as one that should appear in the status panel rather than the CIS column, add it to the project's UnrealGameSync.ini in the project or [Default] section like so: +ServiceBadges=RoboMerge Change 4148282 by Stefan.Boberg Fixed bug in UCookOnTheFlyServer::GetCookOnTheFlyUnsolicitedFiles - UnsolicitedFiles should be passed by reference not by value Change 4148344 by Stefan.Boberg Fixed minor indentation error (most likely caused by sloppy merge) Change 4148521 by Stefan.Boberg Removed accidentally checked in PRAGMA_DISABLE_OPTIMIZATION from CookOnTheFlyServer.cpp Change 4148639 by Ben.Marsh UGS: Fix tooltips not showing for changes that have description badges. Change 4149373 by Ben.Marsh UGS: Allow adding additional columns to display particular badges by adding entries from the project config file. Example syntax: +Columns=(Name="Desktop",MinWidth=50,DesiredWidth=100,Weight=3,Badges="Editor") +Columns=(Name="Mobile",MinWidth=50,DesiredWidth=100,Weight=3,Badges="IOS,Android") Same form can be used to control how default columns are displayed (though badge settings are ignored). Also allow PerforceMonitor to detect local changes to project config files and update settings automatically. Change 4149399 by Ben.Marsh UGS: Update version to 1.143. Change 4155660 by Steve.Robb PROJECTION and PROJECTION_MEMBER macros which provide the correct behavior when creating projections using functions which are overloaded or use default arguments. Change 4157117 by Ben.Marsh Fix warning due to plugins disabled in .target.cs file. Change 4158011 by Ben.Marsh UBT: Add a check that the UnrealHeaderTool target file exists, rather than throwing an exception when reading it fails. Change 4158646 by Ben.Marsh UGS: Fix exception when login is discovered to have expired during a workspace update. Change 4158678 by Ben.Marsh UGS: Fix an exception on shutdown due to the icon being hidden after it's already been disposed. Change 4158683 by Ben.Marsh UGS: Add an unhandled exception filter which sends the exception data to the backend. Change 4159131 by Ben.Marsh UGS: Reduce the number of characters displayed for build badges based on the available space. Change 4159194 by Graeme.Thornton TBA: Fix incorrect map property conversion code when converting an old property that contains a map with different key/value types Change 4159239 by Steve.Robb Improved readability and compliance with coding standards. Change 4159246 by Ben.Marsh UGS: Allow syncing projects where source code is not available (and various version files don't exist). #jira UE-60985 Change 4159286 by Ben.Marsh UGS: Remove requirement for UE4Editor.target.cs to be visible in the depot in order to open a project. #jira UE-60986 Change 4159302 by Ben.Marsh UGS: Update version to 1.144. Change 4160308 by Ben.Marsh All staging client executables for blueprint projects. #jira UE-60983 Change 4161567 by Steve.Robb GitHub #4816 : UE-60771: Handle escaped double quote in FParse::LineExtended Change 4162641 by Ben.Marsh UGS: Allow customizing the position of custom columns, via the Index=N attribute. Change 4162647 by Ben.Marsh UGS: Update version to 1.145. Change 4165319 by Robert.Manuszewski PR #4812: Fix inconsistent command-line argument handling under Windows (Contributed by adamrehn) Change 4166150 by Ben.Marsh UGS: Include *.inl when looking for code changes. Change 4166551 by Steve.Robb Whitespace fixes caused by a bad merge. Change 4168483 by Ben.Marsh UGS: Add a more useful error if a file to be synced exceeds the max allowed path length. Change 4168490 by Ben.Marsh UGS: Update version to 1.146. Change 4168551 by Ben.Marsh UBT: Move bBuildLargeAddressAwareBinary into an exposed setting. Change 4168560 by Ben.Marsh UBT: Remove static config variable for controlling which configuration of UHT to use. Change 4171296 by Ben.Marsh UGS: Move the check for overlong paths earlier. Change 4171531 by Ben.Marsh UBT: Fix exception if BuildConfiguration.xml contains an unknown category. Change 4183371 by Robert.Manuszewski Fix for a crash in Async Loading Graph's CheckCycles when GC kicks in on the game thread and forces ALT to exit early Change 4184312 by Ben.Marsh UGS: Update version to 1.148 Change 4184480 by Robert.Manuszewski Removing unused async loading stat Change 4186390 by Ben.Marsh UBT: Format XML validation errors in a format that allows double-clicking on the message in Visual Studio. Change 4188644 by Ben.Marsh UBT: Add the MakePathSafeToUseWithCommandLine() function to UBT. Change 4188647 by Ben.Marsh UBT: Fix exception in target receipt when architecture is null. Change 4189617 by Ben.Marsh Change FileSystemReference, FileReference and DirectoryReference objects to use OrdinalIgnoreCase comparisons without creating a separate copy of the string to compare. The filesystem does not use the invariant culture, and it can produce the wrong results in some cases (the ordinal comparison is faster, too). Change 4189740 by Ben.Marsh UAT: Remote code to build UnrealPak when packaging; we use the editor now. Change 4189860 by Ben.Marsh UGS: Make the filter for excluding automated lighting rebuilds more explicit. Change 4190082 by Ben.Marsh Fixes to allow enabling edit and continue for Windows builds. Have experienced quite a few VS crashes when testing it in editor; not yet recommended for general use. - Allow edit and continue for any configuration, not just debug. - Fixed PDB errors compiling files that use a shared PCH with edit and continue enabled. Path to the generated PDB file was using the wrong directory. - Removed code that tracks PDB output files, since they're modified multiple times during a build. - Enable debug information when compiling generated CPP files, since it causes errors if the shared PCH PDB doesn't have the same option. - Disable support for remote execution of steps that modify the PDB, since the same file has to be modified many times. Remote execution causes the PDB files to be corrupted. Unfortunately, this makes E&C builds significantly slower. #jira Change 4192949 by Ben.Marsh UBT: Minor tidy-up (merging UEBuildBinary.Build and UEBuildBinary.SetupOutputFiles) Change 4193218 by Ben.Marsh Fix formatting. Change 4197252 by Mike.Erwin UAT: Fix log output w/ correct count of non-code projects. #jira none Change 4197941 by Ben.Marsh UGS: Add support for DebugGame editors that have an executable with a DebugGame suffix. Change 4197964 by Ben.Marsh UGS: Prevent attempts to automatically reopen projects while a modal dialog is up, or the workspace is syncing. Change 4198144 by Ben.Marsh UGS: Prevent modal dialogs when login expires in P4, and prompt for password when hitting "retry". Change 4198413 by Ben.Marsh UGS: Always show the main window when launched manually, and run with -RestoreState when launched at startup. Also add a couple more places that save the visibility state, since logging off seems like it can terminate the process abrubtly. Change 4198779 by Ben.Marsh UBT: Allow generating manifests to any arbitrary locations with the -Manifest=<Path> argument. Change 4198825 by Ben.Marsh UBT: Move code to enumerate Slate runtime dependencies into the Slate module. Doesn't need to be done inside core UBT. Change 4199341 by Ben.Marsh UGS: Update version to 1.149 Change 4199642 by Chad.Garyet - Deprecate CISController - Add BuildController to replace CIS GET/POST for builds - Add LatestController, GET does what CIS/GET used to do - Change Latest/GET to return the last 25 builds filtered by project, rather than the last 5000 individual Ids - Latest/GET now returns "LatestData" object instead of array of longs - Updated EventMonitor to match all API changes - Fixed bug where IDs were getting reset to initial startup values every update loop Change 4199663 by Chad.Garyet CIS controller still needs to return an array of longs #jira none Change 4199680 by Ben.Marsh UGS: Update version to 1.150 Change 4200457 by Ben.Marsh Merging CIS fix for non-development configurations. Change 4200472 by Mike.Erwin UAT: fix -skipbuildclient param default It was defaulting to skipbuildeditor's value, likely a copy-paste error. #jira none Change 4202595 by Ben.Marsh Fix static analysis warning due to constant comparison against macro. Change 4203250 by Ben.Marsh UGS: Always show the "Sync Precompiled Editor" option, but disable it and show a tooltip explaining why if it is not available. Change 4206191 by Ben.Marsh Exclude editor target files from installed builds, since they leak info about DLLs that have been stripped out. Change 4213011 by Ben.Marsh UBT: Include contents of modified intermediate files in the log, to make it easier to debug hidden dependencies. Change 4213487 by Ben.Marsh UBT: Fix assumption that bPrecompile is equivalent to bBuildAllModules. This is no longer the case; they are now controlled by separate options. Should fix CIS errors building the editor. Change 4213609 by Ben.Marsh Ensure that strings formatted using FMicrosoftPlatformString::GetVarArgs() are always null terminated, whether we use the secure CRT or not. Change 4215971 by Ben.Marsh UBT: Remove action graph visualization code; no longer used. Change 4215996 by Ben.Marsh UBT: Remove unqiue id from all actions in the action graph. This is only used for printing debug info in the case of a (rare) cycle in the action graph, so just look it up when needed. Change 4216022 by Ben.Marsh UBT: Rename Crypto.cs to EncryptionAndSigning.cs to match the name of the class inside it, and move it under the System folder. Change 4216031 by Ben.Marsh UBT: Move all the action executors into their own folder in the project. Change 4216526 by Ben.Marsh Fix CIS warnings. Change 4216544 by Ben.Marsh Replace custom code to ensure FMicrosoftPlatformString::GetVarArgs() null terminates its buffer with Microsoft's standards-compliant implementation. Change 4216633 by Ben.Marsh Add support for UnrealPak plugins. * Project and plugin modules can now specify an array of supported programs in the "WhitelistPrograms" field of their module descriptors, to allow modules to be loaded by programs. * Programs can now load any runtime modules, as long as they are whitelisted. * Programs under the engine directory can now use a shared build environment, so that building with a project file does not cause output binaries to be output to the project directory. * UnrealPak is now always built by default when packaging * Convert UnrealPak to a modular configuration Change 4216736 by Ben.Marsh UnrealPak: Move "ExportDependencies" command into an editor commandlet, since it relies on the UObject system, asset registry, etc... Change 4217447 by Ben.Marsh Back out revision 50 from //UE4/Dev-Core/Engine/Build/InstalledEngineBuild.xml Change 4217451 by Ben.Marsh Back out revision 11 from //UE4/Dev-Core/Engine/Plugins/Developer/VisualStudioSourceCodeAccess/Source/VisualStudioSourceCodeAccess/VisualStudioSourceCodeAccess.Build.cs Change 4217617 by Ben.Marsh Back out changelist 4217451 Change 4222552 by Ben.Marsh Don't use #import <TypeLib> for VS source code accessor when building with Clang; it's not supported. Change 4222630 by Ben.Marsh UBT: Fix spam while generating project files if Clang isn't installed. Change 4223316 by Ben.Marsh UBT: Change the order in which Visual C++ toolchains are enumerated to prefer full releases over preview releases. Change 4223318 by Ben.Marsh UBT: Add a build setting which allows creating a dedicated PCH for every file that's excluded from the unity working set (disabled by default). Improves iteration times when working on individual cpp files, but slows down iterating on header changes (and can take a lot of disk space for large changes). Dedicated PCH contains all includes scraped from the top of each cpp file, until a non-#include directive is encountered. Change 4223401 by Ben.Marsh UBT: Add an option to automatically enable edit and continue for files in the adaptive non-unity working set. E&C doesn't seem very useful for UE4 projects right now; compile time is comparable to regular build times, but it can take several minutes to apply code changes for large projects. Change 4223899 by Ben.Marsh UBT: Fix loading XML config files on Mono; Type.GetField(Name) does not seem to return values unless binding flags are specified. Change 4224637 by Ben.Marsh Add a "SupportedPrograms" field to plugin descriptors, which allows plugins to declare which plugins they support independently of individual modules. Programs now respect the "bEnabledByDefault" setting in plugins. Plugins that are compatible with a program now need to list that program in the SupportedPrograms list, and whitelist any modules that should load for that program. Change 4224710 by Ben.Marsh UBT: Don't add import libraries as final build products unless the target is being precompiled. Prevents the need for building them for leaf nodes in the action graph. Change 4224715 by Ben.Marsh UBT: Remove hack to allow Stats2.cpp to not follow IWYU convention. Change 4224726 by Ben.Marsh Remove commented out line. Change 4224903 by Ben.Marsh Fix non-unity compile error in Stats2.h. Change 4225051 by Ben.Marsh Back out changelist 4224710; causing CIS errors due to receipts not matching. Change 4225134 by Ben.Marsh Fixing non-unity errors. Change 4225203 by Ben.Marsh Another non-unity fix. Change 4225249 by Ben.Marsh Fix Linux dependencies being copied for the Windows editor; they can be added as requirements for the Linux target platform on Windows instead, so it respects the user's chosen platforms. #jira UE-62001 Change 4225512 by Ben.Marsh BuildGraph: Allow setting the target to build when using the <CsCompile> task. Change 4228815 by Ben.Marsh UBT: Always add the generated code directory to the list of include paths when generating project files. It may only be created after UHT has been run. Change 4228944 by Ben.Marsh UBT: Remove legacy CppCompileEnvironment and LinkEnvironment wrappers from TargetRules that were deprecated in 4.19. Change 4229028 by Ben.Marsh UBT: Fix editor targets with unique build environment having the wrong executable path in generated project files. Move move logic to configure target rules post-construction by the rules assembly to ensure it's valid. Change 4229065 by Ben.Marsh UBT: Move another target setting into the rules assembly. Change 4229105 by Ben.Marsh Fix BPT exception when generating project files. Change 4229311 by Ben.Marsh UBT: Store the module rules file location on the ModuleRules instance, as well as the plugin that it was created from. Also expose the plugin directory as a property on the ModuleRules instance. Change 4229421 by Ben.Marsh UBT: Consolidate functionality for UHT module setup in ExternalExecution.cs. Change 4229817 by Ben.Marsh UBT: Modules must now explicitly specify the path to the header used to generate a PCH if one is desired, rather than the header being determined automatically by attempting to parse the source code. Now that PCHs are force-included anyway, this removes a lot of dependencies inside UBT. Change 4229824 by Ben.Marsh UBT: Remove unused lists inside UEBuildModuleCPP.SourceFilesClass. Change 4229841 by Ben.Marsh UBT: Remove some legacy code from auto-detecting PCHs. Change 4230521 by Ben.Marsh UBT: Add utility functions to the log class to allow formatting errors and warnings in Visual Studio output format (eg. File(Line): warning: Message) Change 4230871 by Ben.Marsh UAT: Remove StreamUtilis utility class; there is a simpler way to implement the one place it's used. Change 4230882 by Ben.Marsh UAT: Add StreamUtils back into UAT, seems like it's still used there. Change 4230896 by Ben.Marsh UBT: Remove some redundant parameters from UEBuildModule/UEBuildModuleCPP/UEBuildModuleExternal constructors. Change 4231014 by Ben.Marsh WorkspaceTool: Include a dump of raw bytes when garbage is read from the P4 process, for diagnostic purposes. Change 4231032 by Ben.Marsh Fix CIS. Change 4231096 by Ben.Marsh Bump the FlatCPPIncludeDependencyCache version, to prevent errors trying to load old files. Change 4231446 by Ben.Marsh UBT: Added support for expanding UE-specific variables in include paths and library paths: $(EngineDir), $(ProjectDir), $(PluginDir), $(ModuleDir). Change 4231460 by Ben.Marsh Modules may now explicitly specify rpaths on Linux via the PublicRuntimeLibraryPaths and PrivateRuntimeLibraryPaths properties. Change 4233909 by Robert.Manuszewski PR #4779: Reason fails as the supplied variable is incorrect (Contributed by projectgheist) Change 4233910 by Ben.Marsh Enable PCHs on IOS. Reduces build time by ~25%. Change 4234176 by Ben.Marsh UBT: Add better messaging for modules that need to have a private PCH set. Now detects the likely PCH using the same method as legacy code and includes it as a suggestion. Change 4234193 by Ben.Marsh Add the Delete command to Perforce wrapper in DotNETUtilities. Change 4234688 by Ben.Marsh UBT: Simplify handling of installed/precompiled builds. Settings for whether a folder is installed/read-only or not is now stored on the RulesAssembly instance, allowing multiple things to be configured separately and stacked together (eg. engine/enterprise/project). RulesAssembly.IsReadOnly() allows determining if a flie can be modified or not and replaces many previous IsXXXInstalledCalls(), and traverses the chain of assemblies. Change 4234711 by Ben.Marsh UBT: Runtime dependencies can now be copied to output directories as part of the build. When adding a runtime dependency, an optional source location can be specified to copy from. Both the source and target paths can use variables can be used as part of the path, eg. $(OutputDir), $(ModuleDir), $(PluginDir). Example usage (from a .build.cs file): RuntimeDependencies.Add("$(OutputDir)/Foo.dll", "$(PluginDir)/Source/ThirdParty/Foo.dll", StagedFileType.NonUFS); Change 4234872 by Ben.Marsh Expose a flag for whether the engine is installed, to fix issues generating project files. Change 4234929 by Ben.Marsh Fix null reference generating receipts when UBT makefiles are active. Change 4235883 by Chad.Garyet Merging 4231245 to core Giving Coordinator its own sln. This should fix what 4158155 was supposed to. #jira UE-61955 Change 4236075 by Ben.Marsh CIS fix Change 4237066 by Robert.Manuszewski Fix for a potential crash when terminating the engine while it's being initialized #jira UE-60545 Change 4237078 by Robert.Manuszewski The engine will no longer be resetting all linkers causing massive load times when renaming the world package when entering Play In Editor Change 4237116 by Ben.Marsh Rewrite some Windows utility functions to support paths longer than MAX_PATH. Change 4237158 by Ben.Marsh Add const TCHAR* overloads of FString::RemoveFromStart() and FString::RemoveFromEnd(). Change 4237159 by Ben.Marsh Fix FWindowsPlatformFile::GetFilenameOnDisk() support for paths longer than MAX_PATH, and simplify some of the other long path functions to avoid copying string buffers. Change 4239050 by Ben.Marsh Missing file Change 4239318 by Ben.Marsh Linux CIS fix. Change 4239685 by Ben.Marsh Static analysis CIS fix. Change 4240800 by Ben.Marsh WorkspaceTool: Include the full command line in the log for any P4 commands. Change 4240903 by Ben.Marsh PR #4909: Update copyright notices to 2018 (Contributed by projectgheist) Change 4241025 by Ben.Marsh UBT: Exclude mobile pipeline caches from generated project files. Causes huge slowdown when using 'Find in Files' through the IDE. Change 4241770 by Ben.Marsh UBT: Include action number in parallel executor output. #jira UE-62032 Change 4243469 by Ben.Marsh TBA: Merge FAnnotatedStructuredArchiveFormatter with FStructuredArchiveFormatter. Any functions that are only implemented for text archives now have a _TextOnly suffix, and are exposed through the FStructuredArchive interface. Change 4245723 by Robert.Manuszewski Fixing another creash when terminating the engine while initializing. #jira UE-60545 Change 4245862 by Steve.Robb VectorLoadFloat2(Ptr) added, which loads { Ptr[0], Ptr[1], Ptr[0], Ptr[1] } into a VectorRegister. Change 4246412 by Robert.Manuszewski The warning 'Calling StaticLoadObject during PostLoad may result in hitches during streaming' will now also report the object which had the PostLoad called on it when StaticLoadObject call happened. Change 4246612 by Ben.Marsh UBT: Fix spelling of "Intellisense". Change 4249454 by Robert.Manuszewski Added extra checks to catch scenarios where the EDL Precache Buffer is flushed before a package header is fully read Change 4249513 by Robert.Manuszewski Made sure the Async Loading Thread doesn't continue running after creating new async packages when garbage collector wants to run on the game thread Change 4255207 by Ben.Marsh UGS: Add additional logging whenever a P4 command fails, and when the user is logged out. Change 4255288 by Ben.Marsh PR #4921: Honor ModuleRules' bEnableExceptions flag when creating precompiled h. (Contributed by surakin) Change 4256422 by Ben.Marsh UBT: Add an error if a module referenced by a plugin descriptor doesn't exist. Change 4257385 by Robert.Manuszewski Creating new objects from within ForEachObjectWithOuter will now result in a fatal error as it's unsafe to change internal UObject hash tables when iterating over them. Change 4257454 by Robert.Manuszewski Added the option to filter clusters listed with gc.ListClusters by objects within them. Usage: gc.ListClusters Hierachy With=ObjectName1,ObjectName2... Change 4257526 by Robert.Manuszewski It's now possible to filter clusters that get logged with verbose cluster logging enabled (UE_GCCLUSTER_VERBOSE_LOGGING=1) by objects within them by specifying -DumpClustersWithObjects=ObjectName1,ObjectName2 in the command line Change 4257822 by Ben.Marsh Fixes for PlatformShowcase compile errors. Change 4258771 by Ben.Marsh UBT: Fix project files not being generated for foreign projects when creating .stub files. #jira UE-62462 Change 4258790 by Ben.Marsh UBT: Clean up the logic around generating project files before creating a stub IPA, so that it fails loudly if project files do not exist, and can accept target names not matching project names. Change 4259276 by Ben.Marsh UBT: Make it an error if a framework doesn't exist, rather than failing silently. Also remove some remote toolchain stuff that's no longer necessary. Change 4259280 by Ben.Marsh UBT: Fix embedded framework zips not being uploaded for plugins. #jira UE-62485 Change 4260236 by Ben.Marsh UBT: Fix path to generated engine project file. Change 4260334 by Ben.Marsh UGS: Fix custom build steps dialog inadvertantly modifying config file settings in-place. Change 4260361 by Ben.Marsh UGS: Allow for p4 login commands to fail, even though the user is logged in (due to a bad connection, etc...) Change 4260559 by Ben.Marsh UGS: Update version. Change 4261160 by Robert.Manuszewski MediaPlaylist will now be added to root set if the owning MediaPlayer is in the disregard for GC set (fixes GC assumption violation crash) #jira UE-62495 Change 4261421 by Ben.Marsh Force-sync files for building documentation, to fix issues with files not being updated. #jira UE-62413 Change 4261425 by Ben.Marsh UBT: Remove some leftover functions for handling the remote toolchain. Change 4261530 by Ben.Marsh UBT: Speculative fix (and better error reporting) for IOS mobile provision not being found in CIS. Change 4261611 by Ben.Marsh UBT: Downgrade warning to a log message, since it appears when generating project files. Change 4261710 by Ben.Marsh Remove assert that GLogConsole is set; it won't be for command line utilities that don't depend on ApplicationCore. #jira UE-62545 Change 4261831 by Ben.Marsh Fix compile errors due to missing include path when hot-reloading a module from the editor. There are not necessarily source files to compile when -modulewithsuffix is specified on the command line, which was results in GeneratedCodeWildcard not being set. #jira UE-62463, UE-62384 Change 4262723 by Ben.Marsh Whitelist plugins that need to be loaded by UFE. #jira UE-62564 Change 4265444 by Ben.Marsh Fix incorrect executable name for DebugGame configurations in Xcode. #jira UE-62574 Change 4265892 by Ben.Marsh Fix incremental compile failures due to dependency checking for unity files. CachedIncludePaths was not correctly being set on file items, so dependencies were being ignored. #jira UE-62575, UE-62603, UE-62597 Change 4266019 by Josh.Adams - Fixed the CopyAction for runtime dependencies that need to be copied to different location, on non-XGE Change 4266264 by Ben.Marsh Remove override for the __IPHONE_OS_VERSION_MIN_REQUIRED macro on TVOS. This macro is already defined by system headers (in <AvailabilityInternal.h>). Now that we support PCHs on IOS and TVOS, manually defining this macro results in it being defined three times (once for the PCH, once by AvailabilityInternal.h, and once by the force-included list of definitions for the source file being built). The errors for redefining the macro in AvailabilityInternal.h are suppressed due to it being a system header, but the error for redefining it for the source file being compiled are not. #jira UE-62578 Change 4266273 by Ben.Marsh Fixes incremental build failure when compile arguments for PCH have changed on IOS/TVOS. Compile action needs to have a dependency on PCH build action. Change 4266614 by Graeme.Thornton Fix crash when cooking nativized blueprints due to removal of child cooker system. Change 4266763 by Ben.Marsh Always build UnrealPak when building client targets. The ProjectParams.Pak option is not reliable, because it can be forced on later by the target platform. #jira UE-62584 Change 4267985 by Robert.Manuszewski When iterating with ForEachObjectWithouter, don't lock the entire has table but only the hash bucket that is currently being iterated #jira UE-62600 Change 4268558 by Robert.Manuszewski PurgeLegacyBlueprints will no longer be called from within ForEachObjectWithOuter is it renames objects that reside in hash tables that are being iterated over which may lead to undefined behavior. #jira UE-62600 Change 4269011 by Chad.Garyet - Fixing Wildcard match issue, the change to ugsapi sends projects as //Depot/Stream instead of //Depot/Stream/ Wildcard match was only substringing to 3 chars. - Checking in the change a while back that increases the number of queried jobs up to 432 based on some maths from Bob about how many builds we want to grab Published to ugsapi server 8/8/17 #jira none Change 4270788 by Ben.Marsh Fix IOS provisioning data being using when remote compiling on TVOS. #jira UE-62705 Change 4271916 by Ben.Marsh Tag the XGEControlWorker executable as a build product after compiling SCW, to make sure it's included in the UGS zip file. Change 4271934 by Ben.Marsh Upload all static libraries in plugin folders as part of remote builds. #jira UE-62694 Change 4273368 by Ben.Marsh Fix Slate dependencies not being enumerated, and rules assembly not being rebuilt when building remotely. #jira UE-62705 Change 4274049 by Ben.Marsh Always parse the team UUID out of the mobile provision when doing a remote compile. The provision installed on the remote Mac (and selected for signing) may be different. #jira UE-62751 Change 4274823 by Ben.Marsh Add the -VersionCookedContent argument to disable the -unversioned parameter on the cooker command line. Change 4275838 by Ben.Marsh Fix BuildVersion string not being passed through from <SetVersion> task. Also add a -BuildVersion command line argument to UBT to override it for a particular build. Change 4275913 by Ben.Marsh Add a dummy exported symbol to the XGEController module, to fix build errors due to missing .lib file when it's built with WITH_XGE_CONTROLLER = 0. Change 4284161 by Ben.Marsh Allow mirroring Oodle files to remote Mac. Change 4074774 by Steve.Robb Vast simplification of TFunction, making it smaller in footprint, easier to follow and extend, and more correct. TUniqueFunction added, which is a move-only TFunction which can hold move-only functors. Fix for UWidgetBlueprint::ForEachSourceWidget() which should never have compiled but did. FFunctionGraphTask and TFuture<> updated to use TUniqueFunction to make them more general. TArray::HeapPop() made to work with move-only types. Change 4082591 by Ben.Marsh Move the Log class from UBT to DotNetUtilities. Change 4083236 by Ben.Marsh Add a Log.WriteException() method to dump an exception message to the console (and write the exception trace to the log) Change 4084107 by Ben.Marsh UAT: Remove the unused -SkipHeader argument to UE4Build. Change 4089771 by Steve.Robb GitHub #4743 : modified VirtualAlloc function flag https://blogs.msdn.microsoft.com/oldnewthing/20151008-00/?p=91411 Change 4091456 by Steve.Robb Unification of all platforms' FMath::CountTrailingZeros() and FMath::CountLeadingZeros() for both 32-bit and 64-bit. Change 4156437 by Ben.Marsh Lots and lots of fixes compiling for Clang on Windows. Editor now compiles cleanly without warnings, but crashes on startup due to error in intrinsics test. Disabling that runs further, but crashes accessing freed memory. Switching to the ANSI allocator runs further, but crashes in Slate after the splash screen and before the editor window opens. // TODO! * Switching between Clang/ICL/VS2015/VS2017 is now supported through the same mechanism as switching Visual Studio versions, without requiring any source level changes. To use Clang, set WindowsPlatform.Compiler = WindowsCompiler.Clang from a .target.cs file, or set <WindowsPlatform><Compiler>Clang</Compiler></WindowsPlatform> from BuildConfiguration.xml. To pick a specific toolchain version, set WindowsPlatform.CompilerVersion. * Clang is now supported through AutoSDKs; will be added to CIS. * The Samples/Sandbox/Clang project forces Clang to be used from its target.cs file, and allows easily building all editor modules and plugins with Clang on Windows. * UnrealMathSSE intrinsics have been re-enabled for Clang due to missing functions from the UnrealMathFPU implementation, but causes failure in tests at startup. * SSE4_CRC32() is disabled in D3D12Pipelinestate.cpp, since intrinsics are only allowed if enabled for the whole target (rather than being used in specific functions due to runtime checks) Change 4157389 by Ben.Marsh Few more fixes for compiling the editor with Clang. Change 4183911 by Ben.Marsh Fixes to support incremental linking on Windows. Does not seem to have any net benefit right now; may improve once minimal rebuild is enabled. * Incremental linking no longer forces PDB files to be enabled for source files. * Actions can specify specific files to be deleted before each build. Code to forcibly delete PDB files has been moved to the MSVC toolchain. * Unused libraries produced by the cross-referenced link are no longer added as build products, since (a) deleting them breaks dependency checking for incremental linking and causes a full link, and (b) not deleting them breaks UBT dependency checking and causes actions to be run over and over again. * Icon update is disabled for Windows when incremental linking is enabled. * Removed rarely-used setting to always delete produced items before each build. Change 4184311 by Ben.Marsh UGS: Added a dialog which shows all the required platform SDKs for a branch, linked from the status panel in UGS. The llist is configured via the UGS config file submitted to Engine/Programs/UnrealGameSync/UnrealGameSync.ini (and may be overridden by the project config file if necessary): [Default] ; Set this to a network share which contains the SDK installers for your site SdkInstallerDir= ; All the required SDKs for the current version of the engine +SdkInfo=(Category="Android", Description="NDK r21", Browse="$(SdkInstallerDir)\\Android") +SdkInfo=(Category="Windows", Description="Visual Studio 2017") +SdkInfo=(Category="Windows", Description="Visual C++ Toolchain 14.13.26128") +SdkInfo=(Category="Windows", Description="Windows SDK 10.0.16299.0") Similar entries for console platforms are added in console subdirectories. Each entry may contain an Install="Foo.exe" and/or Browse="C:\Foo" style attribute, specifying the path to an installer to run or directory to open in explorer respectively. The SdkInstallerDir setting is used as a base directory for the default installers, seen above for Android. Licensees may override this with a network path specific to the site that UGS is being deployed to (either in this file, in a project specific config file, or in a Engine/Programs/UnrealGameSync/NotForLicensees/UnrealGameSync.ini file). Change 4200452 by Ben.Marsh UBT: Change DebugGame configurations to output a separate executable rather than requiring a -Debug argument at runtime. Previous behavior was a common source of errors. Engine modules are still shared between Development and DebugGame, but the launch module sets a flag in Core on startup indicating the game configuration. Change 4206189 by Ben.Marsh UBT: Simplify logic for precompiling binaries. * Target no longer has separate list of "precompile only" binaries or modules. New -AllModules option allows adding every module to a target, which can be used with -Precompile and -NoLink to precompile object files for monolithic builds. * Precompiled file lists have been removed from target receipts. * The manifest now includes all generated headers and precompiled files when run with the -Precompile option. * Separate -DependencyList=Foo.txt has been added to write a list of all dependencies required to use precompiled binaries. This file list can be read using the <Tag> task in buildgraph. Change 4215466 by Ben.Marsh UBT: Remove indirect calls to determine extensions for object files and precompiled headers. The toolchain knows the correct convention for the platform. Change 4215975 by Ben.Marsh UBT: Remove telemetry code. This has never proved useful for analyzing performance due to the number of incidental factors that affect build times (eg. number of files being compiled). Change 4220154 by Ben.Marsh Move text-only implementations of FOutputDeviceError back into Core, so we can build command-line applications that don't depend on ApplicationCore. Change 4224708 by Ben.Marsh Add a bCompileAgainstApplicationCore setting to the target rules, which allows compiling out references to the ApplicationCore module (which should only be necessary for applications with a GUI). Removed ApplicationCore from several engine tools and utilities. Change 4224958 by Ben.Marsh Remove CoreMinimal.h includes from Core. Change 4229059 by Ben.Marsh UBT: Remove the UEBuildPlatform.ShouldNotBuildEditor() hook for target platforms. We shouldn't be modifying a target's build environment to disable the editor; it is invalid to build the editor for these target platforms at all, and this is already enforced by the GetSupportedPlatforms() function. Change 4230508 by Ben.Marsh Fixup precompiled header setting for samples and games. Change 4231457 by Ben.Marsh Fix exceptions in log messages having trailing newlines. Change 4232406 by Ben.Marsh UBT: Always force include a PCH for generated code if there's one set; the code may depend on it to compile. Change 4234177 by Ben.Marsh Set up private PCH files everywhere that previously used them. Change 4235973 by Ben.Marsh Change FPlatformMisc::GetEnvironmentVariable() to return an FString() rather than requiring a fixed size buffer to be passed in. Removes references to MAX_PATH. Change 4238842 by Ben.Marsh Add support for paths longer than MAX_PATH in the editor. Requires Windows 10 version 1607, and the functionality to be enabled via a registry key or group policy (see https://docs.microsoft.com/en-us/windows/desktop/FileIO/naming-a-file). Only a subset of Win32 functions support long paths (executables can only be started from paths shorter than MAX_PATH, for example). * Added a FPlatformMisc::GetMaxPathLength() function to return the maximum length of a path on the current system. On Windows, this returns a different value for systems with long paths enabled to those without. * The MAX_PATH define is no longer set by non-Windows platforms. Instead, there is a MAC_MAX_PATH, UNIX_MAX_PATH, etc... for any platform-specific code that still relies on the previous macro. * The MAX_UNREAL_FILENAME_LENGTH macro has been renamed to MAX_UNREAL_FILENAME_LENGTH_DEPRECATED * The PLATFORM_MAX_FILEPATH_LENGTH macro has been renamed to PLATFORM_MAX_FILEPATH_LENGTH_DEPRECATED. * Removed custom resource files for programs, since they are just copies of the base UE4 one (which is used by default anyway). The base UE4 manifest declares support for long paths. * Fix 512 character maximum length on editor commands. 260 character limit remains in place for cooking at the moment (see ContentBrowserUtils.h), until C# staging code supports long paths. Change 4255042 by Ben.Marsh UBT: Remote compilation now uploads the entire workspace to the remote Mac and executes a separate remote instance of UBT rather than synchronizing individual actions. This makes the remote compile codepath much simpler, and removes a lot of special cases that exist to support it previously. The list of files to be transferred to the remote are listed as rsync filter rules in Engine/Build/Rsync/RsyncEngine.txt and RsyncProject.txt, which are applied to the root engine directory and project directory respectively. Projects that need to customize which files are uploaded can add their own <ProjectDir>/Build/Rsync/RsyncProject.txt file, which will be included in the filter before the default version. Change 4260567 by Ben.Marsh UAT: Rename CommandUtils.Log to CommandUtils.LogInformation, to avoid conflicts with the underlying Tools.DotNETCommon.Log class. #rb none [CL 4285673 by Ben Marsh in Main branch]
2018-08-14 18:32:34 -04:00
virtual int32 GetPlatformOrdinal() const override
{
return PlatformOrdinal;
}
TARGETPLATFORM_API virtual TSharedPtr<IDeviceManagerCustomPlatformWidgetCreator> GetCustomWidgetCreator() const override;
virtual bool ShouldExpandTo32Bit(const uint16* Indices, const int32 NumIndices) const override
{
return false;
}
#if WITH_ENGINE
virtual bool AllowAudioVisualData() const override
{
return !IsServerOnly();
}
virtual bool AllowObject(const class UObject* Object) const override
{
return true;
}
virtual FName GetMeshBuilderModuleName() const override
{
// MeshBuilder is the default module. Platforms may override this to provide platform specific mesh data.
static const FName NAME_MeshBuilder(TEXT("MeshBuilder"));
return NAME_MeshBuilder;
}
#endif
virtual bool CopyFileToTarget(const FString& TargetAddress, const FString& HostFilename, const FString& TargetFilename, const TMap<FString,FString>& CustomPlatformData) override
{
return false;
}
virtual void GetExtraPackagesToCook(TArray<FName>& PackageNames) const override
{
}
- Renamed PlatformInfo::FPlatformInfo to PlatformInfo::FTargetPlatformInfo - Renamed FDataDrivenPlatformRegistry::FPlatformInfo to FDataDrivenPlatformInfo - Moved some fields from PlatformInfo::FTargetPlatformInfo to FDataDrivenPlatformInfo, and cleaned them up in the process - Fixed the DataDrivePlatformInfo.ini files to match the previous items - Removed FVanillaPlatformEntry, and now just using FTargetPlatformInfo to manage flavors under a vanilla PlatformInfo (see PlatformInfo::GetVanillaPlatformInfoArray()) - Cleaned up TPerPlatformValue, as it was often misused (took a group and platform name, but we can get the group from the platform name) [AnimationSharingManager.cpp, *Engine.cpp, Runtime\Engine\*, ] - Fixed FBlueprintNativeCodeGenPaths::GetDefaultCodeGenPaths() to use IniPlatformName instead of some hacky code [BlueprintNativeCodeGenManifest.cpp] - Fixed various Turnkey bugs that recent testing exposed - Enabled AUTOSDKS_ENABLED in both Mac and Linux on the Editor side (not that there are much set up to use it) - Using Turnkey to get the SDK status instead of ValidatePlatforms (gives more detailed information - may want to go back to ValidatePlatforms so only UBT is needed, but change it to give more info) - Moved OnDeviceDiscovered and Lost delegates from each platform's TargetPlatform class to a static in ITargetPlatform - there was no need for per-platform implementations - Started working on allowing for SDK to be installed with editor running and not need to restart editor - Work in Progress! It is not usable yet. #fyi jack.porter #rb pete.sauerbrei [CL 13816905 by Josh Adams in ue5-main branch]
2020-07-01 17:07:12 -04:00
virtual bool InitializeHostPlatform()
{
// if the platform doesn't need anything, it's valid to do nothing
return true;
}
protected:
- Renamed PlatformInfo::FPlatformInfo to PlatformInfo::FTargetPlatformInfo - Renamed FDataDrivenPlatformRegistry::FPlatformInfo to FDataDrivenPlatformInfo - Moved some fields from PlatformInfo::FTargetPlatformInfo to FDataDrivenPlatformInfo, and cleaned them up in the process - Fixed the DataDrivePlatformInfo.ini files to match the previous items - Removed FVanillaPlatformEntry, and now just using FTargetPlatformInfo to manage flavors under a vanilla PlatformInfo (see PlatformInfo::GetVanillaPlatformInfoArray()) - Cleaned up TPerPlatformValue, as it was often misused (took a group and platform name, but we can get the group from the platform name) [AnimationSharingManager.cpp, *Engine.cpp, Runtime\Engine\*, ] - Fixed FBlueprintNativeCodeGenPaths::GetDefaultCodeGenPaths() to use IniPlatformName instead of some hacky code [BlueprintNativeCodeGenManifest.cpp] - Fixed various Turnkey bugs that recent testing exposed - Enabled AUTOSDKS_ENABLED in both Mac and Linux on the Editor side (not that there are much set up to use it) - Using Turnkey to get the SDK status instead of ValidatePlatforms (gives more detailed information - may want to go back to ValidatePlatforms so only UBT is needed, but change it to give more info) - Moved OnDeviceDiscovered and Lost delegates from each platform's TargetPlatform class to a static in ITargetPlatform - there was no need for per-platform implementations - Started working on allowing for SDK to be installed with editor running and not need to restart editor - Work in Progress! It is not usable yet. #fyi jack.porter #rb pete.sauerbrei [CL 13816905 by Josh Adams in ue5-main branch]
2020-07-01 17:07:12 -04:00
FTargetPlatformBase(const PlatformInfo::FTargetPlatformInfo *const InPlatformInfo)
: PlatformInfo(InPlatformInfo)
{
checkf(PlatformInfo, TEXT("Null PlatformInfo was passed to FTargetPlatformBase. Check the static IsUsable function before creating this object. See FWindowsTargetPlatformModule::GetTargetPlatform()"));
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 4285612) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3836829 by Ben.Marsh UBT: Fix ability to precompile plugins from installed engine builds. Change 3839519 by Ben.Marsh UBT: Simplify configuring bPrecompile and bUsePrecompile settings for modules. Each rules assembly can now be configured as installed, which defaults the module rules it creates to use precompiled data. Change 4042043 by Steve.Robb GitHub #4705 : Added weak lambda's for delegates and multicast delegates. Change 4042056 by Robert.Manuszewski Optimized Mark Phase of GC by up to 10ms by making it run in parallel and removing a huge array presize which we didn't need. Change 4042104 by Robert.Manuszewski Set the minimum GC cluster size to 5 so that GC doesn't have to process micro clusters which are more expensive than processing individual objects + Exposed the minimum cluster size to ini and project settings as gc.MinGCClusterSize + Added the ability to sort clusters by name/object count/mutable object count/referenced clusters count when dumping them with gc.ListClusters command Change 4042377 by Robert.Manuszewski Reworked how GC and other threads (ALT specifically) interact - GC will now notify the ALT it wants to run and ALT will immediately try to finish its current work to allow that. Also the entire ALT tick is now protected against GC running at the same time to improve ALT stability. + added gc.ForceCollectGarbageEveryFrame console variable that triggers a forced GC every frame Change 4042427 by Robert.Manuszewski Changed FGCCSyncObject to use events when waiting for GC to finish so that it doesn't spin on non-game threads when GC is running Change 4042482 by Robert.Manuszewski Unhashing unreachable objects (ConditionalBeginDestroy) will now also be done incrementally, just like the purge phase of Garbage Collection Change 4042635 by Robert.Manuszewski Fix for a potential assert when incremental purge garbage is pending and something forces a full purge Change 4044092 by Steve.Robb Fix for forward declared CoreUObject weakobject types in delegates when building in Clang. Change 4044102 by Robert.Manuszewski Fix for a possible hang when worker threads are preventing GC from running and something is later trying to FlushAsyncLoading with the Async Loading Thread enabled Change 4044113 by Steve.Robb Another Clang fix. Change 4044160 by Robert.Manuszewski Disregard For GC pool will now be enabled by default in cooked builds Change 4044287 by Steve.Robb Typo fix. Change 4047723 by Graeme.Thornton TBA: Fixes for import/export name cache and object resolving Change 4048015 by Graeme.Thornton TBA: Weak/Soft/Lazy pointer serialization changes * Remove FWeakObjectPtr::Serialize, move it's logic into, and replace usages of with calls to, FArchiveUObject::SerializeWeakObjectPtr(). Ensures that something is always sent to the archive so that structured archives can be kept happy in the future. * Added Weak/Soft/Lazy pointer handling to the structured archive slot interface and all the formatters. Binary formatters just forward the call onto their inner and text archives store as a string path reference. * FArchiveUObjectFromStructuredArchive caches all these pointer types and stores indices in the binary block, same as with a UObject*. All pointers are then forwarded to the underlying formatter in one go on finalization. Change 4048021 by Steve.Robb Fix for binding an unbound TFunction to another TFunction with a different signature. Also all null pointers now count as unbindings, not just nullptr. TIsMemberPointer added. TIsATFunction and TIsATFunctionRef renamed to remove the 'A's. Change 4048544 by Robert.Manuszewski Fixing ConditionalBeginDestroy profiling after changes to incremental CBD. Change 4051028 by Graeme.Thornton TBA: ArchiveFromStructuredArchive adapter uses Inner to determine if it is outputting to text, and sets it's own ArIsTextFormat to false Change 4051056 by Graeme.Thornton TBA: High level tagged property / UObject base class text serialization - UObject serialize converted to structured archive - Properties written to text individually with text tags, and then binary adapted values - Only saves, doesn't load Change 4051111 by Graeme.Thornton TBA: Temporarily disable loading of text assets until tagged property serialization path is fixed up Change 4051154 by Graeme.Thornton TBA: Convert a few uobject serializers to structured archive format for example purposes Change 4051181 by Graeme.Thornton TBA: Added default structured archive implementation of SerializeItem to UProperty, which just calls the FArchive version on an FArchiveUObjectFromStructuredArchive adapter. Implemented structured archive SerializeItem for UArrayProperty Change 4051197 by Graeme.Thornton TBA: ObjectProperty text serialization Change 4051216 by Graeme.Thornton Restored a modified FWeakObjectPtr::Serialize function to keep backwards compatibility in code I don't have access to. Change 4051261 by Graeme.Thornton TBA: Convert UMetaData to structured archive Change 4051374 by Steve.Robb Incorrect assert removed. Change 4051562 by Robert.Manuszewski Adding stats for the new GC internal functions Change 4051614 by Graeme.Thornton TBA: Removed UProperty::SerializeItem(FArchive, ...) and replaced with UProperty::SerializeItem(FStructuredArchive::FSlot, ...). Fixed up most of them to work properly and added adapters in for any that were non-trivial. Change 4052512 by Graeme.Thornton TBA: Temporary workaround for softobjectptr and lazyobjectptr uproperties not serialization anything when they know the archive is a reference collector. They should always be serializing their pointers and letting the underlying archive itself ignore them. Change 4053917 by Robert.Manuszewski Clustered objects from clusters that are no longer reachable will now be marked as unreachable immediately when gathering unreachable objects Change 4053919 by Robert.Manuszewski Added the ability to disable incremental BeginDestroy in ini/project settings Change 4055518 by Daniel.Lamb Fixup for deterministic audio generation issue. Submitted on behalf of Rich.Whitehouse #jira nojira #test prefilght automated test. Change 4056854 by Graeme.Thornton TBA: Added a test asset to EngineTest which contains all the different property types and test cases. Change 4056858 by Graeme.Thornton TBA: Updated USetProperty to proper structured archive usage Change 4056872 by Graeme.Thornton TBA: Add map property field to test object Change 4056873 by Graeme.Thornton TBA: Convert UMapProperty to full structured archive Change 4056994 by Graeme.Thornton TBA: Converted FText over to structured archive. Implemented saving, but not loading. Change 4059728 by Ben.Marsh UBT: Add support for using adaptive non-unity builds when the engine and project are in separate repositories. Change 4059805 by Graeme.Thornton Fixed typo in text serialization. Fixes CIS automation test errors Change 4060007 by Graeme.Thornton TBA: FArchiveFromStructuredArchive will now access it's host slot lazily, i.e. only when a value is actually written to the archive. Change 4060092 by Stefan.Boberg Added optimized Windows console window output path to GenericConsoleOutput since this slowed down cooking considerably (2 minutes spent in wprintf alone for one large dataset) When stdout is attached to a console we use the WriteConsoleW function instead of wprintf since the latter is very slow especially in unbuffered mode which the engine currently configures for stdout (see setvbuf call in LaunchEngineLoop.cpp). At some point we should reconsider this buffering policy since it's likely to slow down other platforms as well but I wanted to do a safe change for now as I don't yet fully understand why the setvbuf call is there in the first place. Change 4060108 by Stefan.Boberg Introduced some additional target platform utilities to help with asset cook optimizations * We now assign each ITargetPlatform a zero-based ordinal value * Introduced FTargetPlatform and FTargetPlatformSet types to help store platform references and platform sets efficiently. These are not currently used in the engine but are designed to replace the existing ITargetPlatform/string/FName representations in the cooking data structures. Change 4060143 by Graeme.Thornton Undo //UE4/Dev-Core/Engine/Source/Runtime/... changelist 4060007 Needs some other changes that I haven't checked in yet... Change 4062432 by Ben.Marsh Fix error message when enumerating P4 changes. Change 4062648 by Ben.Marsh Add missing p4 integration action. Change 4063620 by Graeme.Thornton Integrated a fix from UDN where the engine would crash when trying to load a very small encrypted file (<16bytes) from a pak file, where the read address wasn't already aligned to the AES block size. (https://udn.unrealengine.com/questions/431989/crash-while-reading-a-very-small-file-in-encrypted.html) Change 4066963 by Robert.Manuszewski Fixing GC cluster verification code reporting false positives when a cluster is referencing another cluster through 'mutable' objects list. Change 4067133 by Robert.Manuszewski Changed log verbosity when reporting individual cases of GC cluster assumption violations as they are followed by an asser anyway and this way we get the chance to see all issues before we assert at the end of these checks. Change 4067443 by Steve.Robb FString can now be constructed from any char pointer type and length. Change 4068156 by Steve.Robb Fix necessary because of FString constructor change in CL# 4067443. Change 4070258 by Graeme.Thornton Fixes for VSCode Change 4070372 by Graeme.Thornton TBA: Script struct serialization to structured archives Change 4071913 by Ben.Marsh Move bulk of the code for UnrealPak into an engine developer module, so it can be used in the editor. Change 4071914 by Ben.Marsh Missing files. Change 4071937 by Ben.Marsh Missing header. Change 4072015 by Ben.Marsh Fixes for compiling PakFileUtilities as part of the editor. Change 4072826 by Steve.Robb TBitArray::Reserve() added. TBitArray::Add() overloaded to allow adding multiple bits. TSparseArray::Reserve() optimized to call the overloaded Add(). Change 4073271 by Daniel.Lamb Fixed add patch tier in project launcher passing the wrong commandline option to UAT. #test none Change 4074708 by James.Hopkin #core Removed redundant Casts Change 4074763 by Steve.Robb Fix for TSparseArray::Reserve() size. Change 4076063 by Ben.Marsh Add an "UnrealPak" commandlet with the same functionality as the standalone UnrealPak program. Invoke by running the editor with -run=UnrealPak and the standard UnrealPak commandline options. Change 4077064 by Robert.Manuszewski Fixing compile error in PakFileUtilities Change 4077144 by Graeme.Thornton TBA: TextAssetCommandlet improvements * Collect lists of broken assets during roundtrip tests and print a summary of packages that failed each phase at the end * After resaving as text, load the file back as a plain JSON hierarchy to ensure the output was valid Change 4077412 by Ben.Marsh Set the correct exit code for UnrealPak. Should return 0 on success, not 1. Change 4077760 by Graeme.Thornton TBA: Loading fixed for tagged property serialization Includes conversion of all UProperty::ConvertFromType() and SerializeFromMismatchedTag() functions to use structured archives Lazy initialization of FArchiveFromStructruredArchive when loading, to support the possibility of an adapter being create around an object property serialize call to its inner UStruct, which then decides not to do anything and return false. Stops the ArchiveFromStructuredArchive from consuming the slot and getting upset later on when we try to serialize normal tagged properties from it. Disabled lazy bulk data loading from text assets. Requires a bigger change to make it work. Added some debug checks to json input formatter which track the current value stack size when a new object is pushed onto the stack, and makes sure that the stack has returned to the same size when the object is popped. Catches cases where we unpack an array/stream to the value stack but then don't consume all the items. Change 4078800 by Ben.Marsh Change UAT to using the editor's UnrealPak commandlet rather than invoking the standalone UnrealPak executable. To improve performance when building several PAK files, also add a new -batch=<file> command which reads commands to execute in parallel from a text file. Change 4079745 by Graeme.Thornton TBA: Migrated a couple of UObject Serialize functions to FStructuredArchive (SoundCue / MaterialExpressions / Editor strip flags) Change 4079847 by Graeme.Thornton TBA: Add 'FindMismatchedSerializers' mode to text asset commandlet, which dumps out a list of all UClasses which don't have the CLASS_MatchedSerializers flag, meaning we can't guarantee the have Serialize functions for FArchive AND FStructuredArchive, therefore we can't use the new structured archive based serialize path. Should only ever be native instrinsic classes as UHT takes care of all other cases. Change 4079925 by Ben.Marsh Fix incorrect assignment when deriving name for chunked pak file. Change 4080214 by Ben.Marsh Move the ThreadPoolWorkQueue class into DotNETUtilities so it can be used by other projects. Change 4082394 by Graeme.Thornton CIS fix for variable shadowing warning Change 4082583 by Ben.Marsh Add a IBinarySerializable interface for types that support reading from a BinaryReader and writing to a BinaryWriter. Implementing IBinarySerializable implies a constructor taking a BinaryReader argument is available for deserializing. Change 4082652 by Ben.Marsh Fix FileReference.Directory not returning a directory with a trailing backslash for files in the root directory. Change 4082755 by Graeme.Thornton Fixed an erroneous usage of TUniquePtr<uint8>as a pointer to a uint8 array when creating pak files. Caused a crash when compression was enabled, and has probably surfaced because pak generation is now done by an editor commandlet rather than a standalone program. Change 4082756 by Graeme.Thornton Fixed some incorrect documentation for pakfile compressed chunk headers Change 4082883 by Graeme.Thornton Static analysis warning fix Change 4082912 by Ben.Marsh Move ExceptionUtils into DotNETUtilities. Change 4085291 by Graeme.Thornton TBA: In the Json output formatter, write float and double values out with enough precision for successful roundtripping. Added some debug only code which will immediately reconvert the string back to its original value and compare the the input Change 4085523 by Graeme.Thornton TBA: Remove only explicit usage of DECLARE_FSTRUCTUREDARCHIVE_SERIALIZER. Should only be used from UHT generated code. Change 4086037 by Robert.Manuszewski Fix for a potential race condition when two threads want to acquire GC lock Change 4088655 by Graeme.Thornton Pak creation now uses the bEnablePakSigning setting from the crypto config json file Change 4091474 by Steve.Robb Fix for TStaticBitArray::FindFirstSetBit() and TStaticBitArray::FindFirstClearBit(). Unused variables removed. Change 4093632 by Steve.Robb CIS fixes. Change 4093656 by Graeme.Thornton Build fix Change 4093744 by Ben.Marsh Allow per-chunk settings for whether to enable compression in UnrealPak. Change 4099712 by Gil.Gribb UE4 - Fixed rare case where insufficient space was preallocated for cooldown ticks. #jira UE-59686 Change 4099912 by Stefan.Boberg Cooking timer optimizations: - Replaced data structures for FScopeTimer and FHierarchicalTimerInfo. Previous implementation used FString for many things and caused *lots* of heap and string concatenation activity. Replaced with a compile-time node id (using __COUNTER__) and raw string literals. - Removed PERPACKAGE_TIMER support (was disabled by default and was difficult to test) - Made it possible to toggle OUTPUT_TIMING and ENABLE_COOK_STATS independently - Removed some extremely tight timers because the overhead from calling QPC significantly exceeded the measured code This change shaved some 15% off a clean cook of Fortnite WindowsClient (en) with fully populated local DDC Change 4100519 by Stefan.Boberg Quick fix for Linux build issue introduced in 4099927 Change 4105327 by Stefan.Boberg Cooker: Changed FHierarchicalTimerInfo so it uses a linked list for tracking child nodes, to be able to deal with any child count. Previously we assumed there would never be more than 9 children but it turns out there are cooker modes that need more. Fixes check when using -FullLoadAndSave to cook Change 4105448 by Stefan.Boberg - Fixed Linux build warning re: member initialization order - Also eliminated OUTPUT_HIERARCHYTIMERS/CLEAR_HIEARCHYTIMERS macros (plain functions are fine) - Moved finishing-up code for FullLoadAndSave() to TickCookOnTheSide() call site to improve timer output. Previously some of the scopes would not have been closed before printing and thus the output was misleading. Change 4109031 by Ben.Marsh Attribute-driven Perforce wrapper (old Epic Friday project). Offers a more complete implementation than the current P4 wrapper in UAT without requiring any platform-specific libraries. Uses the Python binary output for parsing. Change 4109588 by Ben.Marsh UBT: Add extension methods for serializing a nullable type to a BinaryReader/BinaryWriter. Change 4109595 by Ben.Marsh Missing project file for DotNETUtilities. Change 4110724 by Stefan.Boberg Removed annotation map locking in UObjectMarks, eliminating around one minute (~3.5%) from Fortnite cook time. The locking was redundant since the annotation maps are managed per thread anyway. Change 4111304 by Ben.Marsh UAT: Add support for setting a status message through the log class. Allows writing transient messages (eg. progress messages) which will be cleared out before writing other messages. Best used through the LogStatusScope class, which can set a status message for the duration of a using() block. As part of this change, the console no longer has to be added as a dedicated trace listener. Since we already special-case this listener when formatting log output, it's easier to just keep the implementation separate to the other trace listeners. Change 4112708 by Steve.Robb Fix for TBitArray::MaxBits in assignment. Change 4114133 by Stefan.Boberg Tweaked how low-level memory (LLM) tracker is implemented to reduce overheads. Previously FMemory functions would acquire the LLM singleton and call OnLowLevelFree/OnLowLevelAlloc etc which would check the bIsDisabled flag and early out if it was set. Due to how frequently these functions were called this ended up costing quite a bit. - This change makes the flag a static member variable instead of a member variable and therefore enables a simpler early-out to be implemented. - The singleton getter is also simplified to avoid hitting the threadsafe singleton construction path on every call. - The enable flag is no longer TAtomic - this also incurs extra overhead for no clear benefit Shaves approximately 3.5% (one minute) off a Fortnite cook test scenario (using -FullLoadAndSave) Change 4115010 by Robert.Manuszewski Fixing CIS Change 4115249 by Robert.Manuszewski Fixing async loading code asserts when exiting game very early due to an error #jira UE-56267 Change 4117091 by Ben.Marsh Prevent doubled-up lines when writing status updates with console log verbosity. Change 4117207 by Ben.Marsh UGS: Do not include executables in diagnostics zip file, and ignore "no such files" error when cleaning workspace. Change 4119175 by Ben.Marsh UGS: Fix crash writing version files when directory does not already exist. Change 4119987 by Ben.Marsh UGS: Show a dialog box while the launcher is updating executables from Perforce, which allows cancelling the operation if necessary. Allow setting the username on the settings window, and prompt for login credentials if necessary. Should prevent situations where users have to update settings from the command prompt. Holding down shift during launch now shows the settings dialog rather than an immediate prompt to launch the unstable version (unstable version is shown as a checkbox on this dialog). Change 4119991 by Ben.Marsh Update version number for UGS launcher to 1.13. Change 4121943 by Robert.Manuszewski Don't use FArchiveAsync2 for reading packages with non-async path in editor builds as its performance is worse than the standard archive's (saves about 1 minute when doing larger cooks and 7 seconds when loading into PIE) Change 4122592 by Steve.Robb GitHub #4762 : Improve wording and grammar of Math comments Also includes improved accuracy in FMath::ComputeBoundingSphereForCone(). Change 4122819 by Stefan.Boberg Don't call CreateDirectory redundantly when opening files for writing using FFileManagerGeneric::CreateFileWriter This change avoids calling IPlatformFile::CreateDirectoryTree if possible since this is a very expensive function especially for deep hierarchies as it performs directory creation from the root directory onwards instead of from the leaf downwards. That function should also be fixed but this change improves performance in the meantime. Change 4122872 by Stefan.Boberg CreateDirectoryTree now creates directories leaf-to-root instead of the other way around. This is much more efficient since we don't spend time on system API calls for directories which already exist. This accounted for a very large amount of CPU time in cooking as the full target file directory hierarchy would be "created" for every single output file. Change 4123109 by Stefan.Boberg - Disable overlapped I/O in editor / cooker. Synchronous I/O reduces the number of syscalls and Windows performs prefetching on our behalf anyway for sequential reads - Eliminated syscall which was issued for every write to update cached file size -- since we're the only writers to the file (file access allows read sharing at most) we can authoritatively update the file size on write completion Change 4123455 by Ben.Marsh PR #4775: New build param PCHMemoryAllocationFactor to set /Zm VS build param. (Contributed by lucaswall) Change 4124207 by Ben.Marsh UBT: Remove some unnecessary indirection for generated code paths. Change 4124217 by Ben.Marsh UBT: Remove another unused variable from UEBuildModuleCPP. Change 4124377 by Stefan.Boberg In IPlatformFile::DeleteDirectoryRecursively, attempt to delete file first and if it fails clear the readonly flag and try again Previously there was a call to clear the readonly flag for every deleted file and this is a waste of resources 99% of the time. The SetFileAttributes call accounted for a significant amount of time during cooker sandbox directory deletion Change 4125071 by Stefan.Boberg Some tweaks to FQueuedThreadPoolBase scheduling and memory management - Explicitly pass in false for TArray::RemoveAt(..., bool bAllowShrinking) argument to prevent memory reallocation when arrays are drained and inevitably repopulated shortly afterwards - Use a MRU strategy instead of LRU when picking a thread to wake up. The MRU thread is the most likely to have a 'hot' cache for the stack etc. Picking from the back of the array also happens to be cheaper since no memory movement is necessary when RemoveAt is called. (This was the strategy in place before CL2600362 which seems to have changed it unintentionally) - Release lock as soon as a thread has been chosen, before asking the worker thread to wake up and do the work Change 4126132 by Ben.Marsh UAT: Detect when stdout is redirected and prevent using backspace characters to move the cursor. Change 4126867 by Graeme.Thornton TBA: Fix tagged binary formatter Change 4127010 by Robert.Manuszewski AnimScriptInstances created at runtime will now also be added to the owning omponent's cluster to avoid GC issues. Change 4127932 by Ben.Marsh WorkspaceTool: Reduce unnecessary logging of status messages when console output is not redirected. Change 4129050 by Ben.Marsh UGS: Check for NET Framework 4.5 being installed before running the installer. Also fix warning trying to kill existing UGS instances before upgrade. Change 4129459 by Graeme.Thornton TBA: TextAssetCommandlet - When outputting converted assets to an output path, replicate the workspace relative path in the output directory Change 4129515 by Graeme.Thornton TBA: Add EnterRecord overload that allows outputting of available field names when loading. Change 4129517 by Graeme.Thornton TBA: Tagged properties are written out as named fields on the "Properties" record, rather than as a stream with a null tag at the end Change 4129518 by Graeme.Thornton TBA: Added a local const bool to allow easy hacking out of text asset loading support Change 4129558 by Graeme.Thornton TBA: Build fix for textasset-less configs Change 4129614 by Ben.Marsh UGS: Main window is now restored to normal size when activated by clicking on the tray icon. #jira UE-60490 Change 4129618 by Ben.Marsh UGS: Speculative fix for unreproduced exception accessing disposed window while shutting down. Change 4131936 by Robert.Manuszewski Removing some WIP code accidentally checked in with CL #4121943 Change 4133490 by Ben.Marsh UGS: Allow the $(Change) variable to be used in more places than just the context menu. #jira UE-60573 Change 4133550 by Ben.Marsh UGS: Setting for whether or not to use incremental builds is now exposed through the variable "$(UseIncrementalBuilds)" for use by custom build steps. #jira UE-60554 Change 4133681 by Ben.Marsh UGS: A per-project list of folders and extensions to be deleted by default when running the 'clean workspace' tool can now be specified through the <ProjectDir>/Build/UnrealGameSync.ini file. Settings may be specified for an individual branch (via a category with the depot path to the project) or for wherever the project is currently open (via the [Default] category). The SafeToDeleteFolders list specifies a substring that will be checked against folder paths. Anything containing this folder will be marked as safe for delete by default. The SafeToDeleteExtensions list specifies a list of extensions for files that can always be deleted. Example: [Default] +SafeToDeleteFolders=/MyGame/Test/ +SafeToDeleteFolders=/DataService/ +SafeToDeleteExtensions=.xx1 +SafeToDeleteExtensions=.xx2 #jira UE-60575 Change 4135449 by Ben.Marsh Fix allowing use of Job objects on Windows platforms (debug code submitted by mistake) Change 4135730 by Ben.Marsh UBT: Plugins can now be enabled and disabled from the .target.cs file (for targets that do not use the shared compile environment), by compiling the list of enabled/disabled plugin names into the Projects module. Change 4135823 by Ben.Marsh UBT: Remove legacy code to handle disabling optional plugins; now that this is compiled into the target, it will work for any plugins we choose. Change 4135945 by Ben.Marsh UBT: Fix error running programs with no explicitly enabled or disabled plugins. Change 4137207 by Ben.Marsh UGS: Align all badges with the same name, to make it easier to see which CIS steps are being run. Allow overriding the slot taken by a particular badge by calling it "SlotName:LabelName". Change 4137311 by Stefan.Boberg Removed child cooker support. In practice it is not a useful feature as it provides no performance improvement (quite the opposite in fact) and adds testing and maintenance complexity. Change 4137393 by Ben.Marsh UGS: Fix display of multiline errors in the status panel. Change 4141708 by Steve.Robb GitHub #3631 : Incorrect default argument in WeakObjectPtrTemplate #jira UE-45490 Change 4146655 by Stefan.Boberg Removed FullGCAssetClasses logic - no longer necessary nor useful Change 4147318 by Ben.Marsh UGS: Compress build badges in a column if it shrinks below the size that they would be visible. Change 4148207 by Ben.Marsh UGS: Added support for showing the latest completed build from a specific list of badges in the status panel. To declare a badge as one that should appear in the status panel rather than the CIS column, add it to the project's UnrealGameSync.ini in the project or [Default] section like so: +ServiceBadges=RoboMerge Change 4148282 by Stefan.Boberg Fixed bug in UCookOnTheFlyServer::GetCookOnTheFlyUnsolicitedFiles - UnsolicitedFiles should be passed by reference not by value Change 4148344 by Stefan.Boberg Fixed minor indentation error (most likely caused by sloppy merge) Change 4148521 by Stefan.Boberg Removed accidentally checked in PRAGMA_DISABLE_OPTIMIZATION from CookOnTheFlyServer.cpp Change 4148639 by Ben.Marsh UGS: Fix tooltips not showing for changes that have description badges. Change 4149373 by Ben.Marsh UGS: Allow adding additional columns to display particular badges by adding entries from the project config file. Example syntax: +Columns=(Name="Desktop",MinWidth=50,DesiredWidth=100,Weight=3,Badges="Editor") +Columns=(Name="Mobile",MinWidth=50,DesiredWidth=100,Weight=3,Badges="IOS,Android") Same form can be used to control how default columns are displayed (though badge settings are ignored). Also allow PerforceMonitor to detect local changes to project config files and update settings automatically. Change 4149399 by Ben.Marsh UGS: Update version to 1.143. Change 4155660 by Steve.Robb PROJECTION and PROJECTION_MEMBER macros which provide the correct behavior when creating projections using functions which are overloaded or use default arguments. Change 4157117 by Ben.Marsh Fix warning due to plugins disabled in .target.cs file. Change 4158011 by Ben.Marsh UBT: Add a check that the UnrealHeaderTool target file exists, rather than throwing an exception when reading it fails. Change 4158646 by Ben.Marsh UGS: Fix exception when login is discovered to have expired during a workspace update. Change 4158678 by Ben.Marsh UGS: Fix an exception on shutdown due to the icon being hidden after it's already been disposed. Change 4158683 by Ben.Marsh UGS: Add an unhandled exception filter which sends the exception data to the backend. Change 4159131 by Ben.Marsh UGS: Reduce the number of characters displayed for build badges based on the available space. Change 4159194 by Graeme.Thornton TBA: Fix incorrect map property conversion code when converting an old property that contains a map with different key/value types Change 4159239 by Steve.Robb Improved readability and compliance with coding standards. Change 4159246 by Ben.Marsh UGS: Allow syncing projects where source code is not available (and various version files don't exist). #jira UE-60985 Change 4159286 by Ben.Marsh UGS: Remove requirement for UE4Editor.target.cs to be visible in the depot in order to open a project. #jira UE-60986 Change 4159302 by Ben.Marsh UGS: Update version to 1.144. Change 4160308 by Ben.Marsh All staging client executables for blueprint projects. #jira UE-60983 Change 4161567 by Steve.Robb GitHub #4816 : UE-60771: Handle escaped double quote in FParse::LineExtended Change 4162641 by Ben.Marsh UGS: Allow customizing the position of custom columns, via the Index=N attribute. Change 4162647 by Ben.Marsh UGS: Update version to 1.145. Change 4165319 by Robert.Manuszewski PR #4812: Fix inconsistent command-line argument handling under Windows (Contributed by adamrehn) Change 4166150 by Ben.Marsh UGS: Include *.inl when looking for code changes. Change 4166551 by Steve.Robb Whitespace fixes caused by a bad merge. Change 4168483 by Ben.Marsh UGS: Add a more useful error if a file to be synced exceeds the max allowed path length. Change 4168490 by Ben.Marsh UGS: Update version to 1.146. Change 4168551 by Ben.Marsh UBT: Move bBuildLargeAddressAwareBinary into an exposed setting. Change 4168560 by Ben.Marsh UBT: Remove static config variable for controlling which configuration of UHT to use. Change 4171296 by Ben.Marsh UGS: Move the check for overlong paths earlier. Change 4171531 by Ben.Marsh UBT: Fix exception if BuildConfiguration.xml contains an unknown category. Change 4183371 by Robert.Manuszewski Fix for a crash in Async Loading Graph's CheckCycles when GC kicks in on the game thread and forces ALT to exit early Change 4184312 by Ben.Marsh UGS: Update version to 1.148 Change 4184480 by Robert.Manuszewski Removing unused async loading stat Change 4186390 by Ben.Marsh UBT: Format XML validation errors in a format that allows double-clicking on the message in Visual Studio. Change 4188644 by Ben.Marsh UBT: Add the MakePathSafeToUseWithCommandLine() function to UBT. Change 4188647 by Ben.Marsh UBT: Fix exception in target receipt when architecture is null. Change 4189617 by Ben.Marsh Change FileSystemReference, FileReference and DirectoryReference objects to use OrdinalIgnoreCase comparisons without creating a separate copy of the string to compare. The filesystem does not use the invariant culture, and it can produce the wrong results in some cases (the ordinal comparison is faster, too). Change 4189740 by Ben.Marsh UAT: Remote code to build UnrealPak when packaging; we use the editor now. Change 4189860 by Ben.Marsh UGS: Make the filter for excluding automated lighting rebuilds more explicit. Change 4190082 by Ben.Marsh Fixes to allow enabling edit and continue for Windows builds. Have experienced quite a few VS crashes when testing it in editor; not yet recommended for general use. - Allow edit and continue for any configuration, not just debug. - Fixed PDB errors compiling files that use a shared PCH with edit and continue enabled. Path to the generated PDB file was using the wrong directory. - Removed code that tracks PDB output files, since they're modified multiple times during a build. - Enable debug information when compiling generated CPP files, since it causes errors if the shared PCH PDB doesn't have the same option. - Disable support for remote execution of steps that modify the PDB, since the same file has to be modified many times. Remote execution causes the PDB files to be corrupted. Unfortunately, this makes E&C builds significantly slower. #jira Change 4192949 by Ben.Marsh UBT: Minor tidy-up (merging UEBuildBinary.Build and UEBuildBinary.SetupOutputFiles) Change 4193218 by Ben.Marsh Fix formatting. Change 4197252 by Mike.Erwin UAT: Fix log output w/ correct count of non-code projects. #jira none Change 4197941 by Ben.Marsh UGS: Add support for DebugGame editors that have an executable with a DebugGame suffix. Change 4197964 by Ben.Marsh UGS: Prevent attempts to automatically reopen projects while a modal dialog is up, or the workspace is syncing. Change 4198144 by Ben.Marsh UGS: Prevent modal dialogs when login expires in P4, and prompt for password when hitting "retry". Change 4198413 by Ben.Marsh UGS: Always show the main window when launched manually, and run with -RestoreState when launched at startup. Also add a couple more places that save the visibility state, since logging off seems like it can terminate the process abrubtly. Change 4198779 by Ben.Marsh UBT: Allow generating manifests to any arbitrary locations with the -Manifest=<Path> argument. Change 4198825 by Ben.Marsh UBT: Move code to enumerate Slate runtime dependencies into the Slate module. Doesn't need to be done inside core UBT. Change 4199341 by Ben.Marsh UGS: Update version to 1.149 Change 4199642 by Chad.Garyet - Deprecate CISController - Add BuildController to replace CIS GET/POST for builds - Add LatestController, GET does what CIS/GET used to do - Change Latest/GET to return the last 25 builds filtered by project, rather than the last 5000 individual Ids - Latest/GET now returns "LatestData" object instead of array of longs - Updated EventMonitor to match all API changes - Fixed bug where IDs were getting reset to initial startup values every update loop Change 4199663 by Chad.Garyet CIS controller still needs to return an array of longs #jira none Change 4199680 by Ben.Marsh UGS: Update version to 1.150 Change 4200457 by Ben.Marsh Merging CIS fix for non-development configurations. Change 4200472 by Mike.Erwin UAT: fix -skipbuildclient param default It was defaulting to skipbuildeditor's value, likely a copy-paste error. #jira none Change 4202595 by Ben.Marsh Fix static analysis warning due to constant comparison against macro. Change 4203250 by Ben.Marsh UGS: Always show the "Sync Precompiled Editor" option, but disable it and show a tooltip explaining why if it is not available. Change 4206191 by Ben.Marsh Exclude editor target files from installed builds, since they leak info about DLLs that have been stripped out. Change 4213011 by Ben.Marsh UBT: Include contents of modified intermediate files in the log, to make it easier to debug hidden dependencies. Change 4213487 by Ben.Marsh UBT: Fix assumption that bPrecompile is equivalent to bBuildAllModules. This is no longer the case; they are now controlled by separate options. Should fix CIS errors building the editor. Change 4213609 by Ben.Marsh Ensure that strings formatted using FMicrosoftPlatformString::GetVarArgs() are always null terminated, whether we use the secure CRT or not. Change 4215971 by Ben.Marsh UBT: Remove action graph visualization code; no longer used. Change 4215996 by Ben.Marsh UBT: Remove unqiue id from all actions in the action graph. This is only used for printing debug info in the case of a (rare) cycle in the action graph, so just look it up when needed. Change 4216022 by Ben.Marsh UBT: Rename Crypto.cs to EncryptionAndSigning.cs to match the name of the class inside it, and move it under the System folder. Change 4216031 by Ben.Marsh UBT: Move all the action executors into their own folder in the project. Change 4216526 by Ben.Marsh Fix CIS warnings. Change 4216544 by Ben.Marsh Replace custom code to ensure FMicrosoftPlatformString::GetVarArgs() null terminates its buffer with Microsoft's standards-compliant implementation. Change 4216633 by Ben.Marsh Add support for UnrealPak plugins. * Project and plugin modules can now specify an array of supported programs in the "WhitelistPrograms" field of their module descriptors, to allow modules to be loaded by programs. * Programs can now load any runtime modules, as long as they are whitelisted. * Programs under the engine directory can now use a shared build environment, so that building with a project file does not cause output binaries to be output to the project directory. * UnrealPak is now always built by default when packaging * Convert UnrealPak to a modular configuration Change 4216736 by Ben.Marsh UnrealPak: Move "ExportDependencies" command into an editor commandlet, since it relies on the UObject system, asset registry, etc... Change 4217447 by Ben.Marsh Back out revision 50 from //UE4/Dev-Core/Engine/Build/InstalledEngineBuild.xml Change 4217451 by Ben.Marsh Back out revision 11 from //UE4/Dev-Core/Engine/Plugins/Developer/VisualStudioSourceCodeAccess/Source/VisualStudioSourceCodeAccess/VisualStudioSourceCodeAccess.Build.cs Change 4217617 by Ben.Marsh Back out changelist 4217451 Change 4222552 by Ben.Marsh Don't use #import <TypeLib> for VS source code accessor when building with Clang; it's not supported. Change 4222630 by Ben.Marsh UBT: Fix spam while generating project files if Clang isn't installed. Change 4223316 by Ben.Marsh UBT: Change the order in which Visual C++ toolchains are enumerated to prefer full releases over preview releases. Change 4223318 by Ben.Marsh UBT: Add a build setting which allows creating a dedicated PCH for every file that's excluded from the unity working set (disabled by default). Improves iteration times when working on individual cpp files, but slows down iterating on header changes (and can take a lot of disk space for large changes). Dedicated PCH contains all includes scraped from the top of each cpp file, until a non-#include directive is encountered. Change 4223401 by Ben.Marsh UBT: Add an option to automatically enable edit and continue for files in the adaptive non-unity working set. E&C doesn't seem very useful for UE4 projects right now; compile time is comparable to regular build times, but it can take several minutes to apply code changes for large projects. Change 4223899 by Ben.Marsh UBT: Fix loading XML config files on Mono; Type.GetField(Name) does not seem to return values unless binding flags are specified. Change 4224637 by Ben.Marsh Add a "SupportedPrograms" field to plugin descriptors, which allows plugins to declare which plugins they support independently of individual modules. Programs now respect the "bEnabledByDefault" setting in plugins. Plugins that are compatible with a program now need to list that program in the SupportedPrograms list, and whitelist any modules that should load for that program. Change 4224710 by Ben.Marsh UBT: Don't add import libraries as final build products unless the target is being precompiled. Prevents the need for building them for leaf nodes in the action graph. Change 4224715 by Ben.Marsh UBT: Remove hack to allow Stats2.cpp to not follow IWYU convention. Change 4224726 by Ben.Marsh Remove commented out line. Change 4224903 by Ben.Marsh Fix non-unity compile error in Stats2.h. Change 4225051 by Ben.Marsh Back out changelist 4224710; causing CIS errors due to receipts not matching. Change 4225134 by Ben.Marsh Fixing non-unity errors. Change 4225203 by Ben.Marsh Another non-unity fix. Change 4225249 by Ben.Marsh Fix Linux dependencies being copied for the Windows editor; they can be added as requirements for the Linux target platform on Windows instead, so it respects the user's chosen platforms. #jira UE-62001 Change 4225512 by Ben.Marsh BuildGraph: Allow setting the target to build when using the <CsCompile> task. Change 4228815 by Ben.Marsh UBT: Always add the generated code directory to the list of include paths when generating project files. It may only be created after UHT has been run. Change 4228944 by Ben.Marsh UBT: Remove legacy CppCompileEnvironment and LinkEnvironment wrappers from TargetRules that were deprecated in 4.19. Change 4229028 by Ben.Marsh UBT: Fix editor targets with unique build environment having the wrong executable path in generated project files. Move move logic to configure target rules post-construction by the rules assembly to ensure it's valid. Change 4229065 by Ben.Marsh UBT: Move another target setting into the rules assembly. Change 4229105 by Ben.Marsh Fix BPT exception when generating project files. Change 4229311 by Ben.Marsh UBT: Store the module rules file location on the ModuleRules instance, as well as the plugin that it was created from. Also expose the plugin directory as a property on the ModuleRules instance. Change 4229421 by Ben.Marsh UBT: Consolidate functionality for UHT module setup in ExternalExecution.cs. Change 4229817 by Ben.Marsh UBT: Modules must now explicitly specify the path to the header used to generate a PCH if one is desired, rather than the header being determined automatically by attempting to parse the source code. Now that PCHs are force-included anyway, this removes a lot of dependencies inside UBT. Change 4229824 by Ben.Marsh UBT: Remove unused lists inside UEBuildModuleCPP.SourceFilesClass. Change 4229841 by Ben.Marsh UBT: Remove some legacy code from auto-detecting PCHs. Change 4230521 by Ben.Marsh UBT: Add utility functions to the log class to allow formatting errors and warnings in Visual Studio output format (eg. File(Line): warning: Message) Change 4230871 by Ben.Marsh UAT: Remove StreamUtilis utility class; there is a simpler way to implement the one place it's used. Change 4230882 by Ben.Marsh UAT: Add StreamUtils back into UAT, seems like it's still used there. Change 4230896 by Ben.Marsh UBT: Remove some redundant parameters from UEBuildModule/UEBuildModuleCPP/UEBuildModuleExternal constructors. Change 4231014 by Ben.Marsh WorkspaceTool: Include a dump of raw bytes when garbage is read from the P4 process, for diagnostic purposes. Change 4231032 by Ben.Marsh Fix CIS. Change 4231096 by Ben.Marsh Bump the FlatCPPIncludeDependencyCache version, to prevent errors trying to load old files. Change 4231446 by Ben.Marsh UBT: Added support for expanding UE-specific variables in include paths and library paths: $(EngineDir), $(ProjectDir), $(PluginDir), $(ModuleDir). Change 4231460 by Ben.Marsh Modules may now explicitly specify rpaths on Linux via the PublicRuntimeLibraryPaths and PrivateRuntimeLibraryPaths properties. Change 4233909 by Robert.Manuszewski PR #4779: Reason fails as the supplied variable is incorrect (Contributed by projectgheist) Change 4233910 by Ben.Marsh Enable PCHs on IOS. Reduces build time by ~25%. Change 4234176 by Ben.Marsh UBT: Add better messaging for modules that need to have a private PCH set. Now detects the likely PCH using the same method as legacy code and includes it as a suggestion. Change 4234193 by Ben.Marsh Add the Delete command to Perforce wrapper in DotNETUtilities. Change 4234688 by Ben.Marsh UBT: Simplify handling of installed/precompiled builds. Settings for whether a folder is installed/read-only or not is now stored on the RulesAssembly instance, allowing multiple things to be configured separately and stacked together (eg. engine/enterprise/project). RulesAssembly.IsReadOnly() allows determining if a flie can be modified or not and replaces many previous IsXXXInstalledCalls(), and traverses the chain of assemblies. Change 4234711 by Ben.Marsh UBT: Runtime dependencies can now be copied to output directories as part of the build. When adding a runtime dependency, an optional source location can be specified to copy from. Both the source and target paths can use variables can be used as part of the path, eg. $(OutputDir), $(ModuleDir), $(PluginDir). Example usage (from a .build.cs file): RuntimeDependencies.Add("$(OutputDir)/Foo.dll", "$(PluginDir)/Source/ThirdParty/Foo.dll", StagedFileType.NonUFS); Change 4234872 by Ben.Marsh Expose a flag for whether the engine is installed, to fix issues generating project files. Change 4234929 by Ben.Marsh Fix null reference generating receipts when UBT makefiles are active. Change 4235883 by Chad.Garyet Merging 4231245 to core Giving Coordinator its own sln. This should fix what 4158155 was supposed to. #jira UE-61955 Change 4236075 by Ben.Marsh CIS fix Change 4237066 by Robert.Manuszewski Fix for a potential crash when terminating the engine while it's being initialized #jira UE-60545 Change 4237078 by Robert.Manuszewski The engine will no longer be resetting all linkers causing massive load times when renaming the world package when entering Play In Editor Change 4237116 by Ben.Marsh Rewrite some Windows utility functions to support paths longer than MAX_PATH. Change 4237158 by Ben.Marsh Add const TCHAR* overloads of FString::RemoveFromStart() and FString::RemoveFromEnd(). Change 4237159 by Ben.Marsh Fix FWindowsPlatformFile::GetFilenameOnDisk() support for paths longer than MAX_PATH, and simplify some of the other long path functions to avoid copying string buffers. Change 4239050 by Ben.Marsh Missing file Change 4239318 by Ben.Marsh Linux CIS fix. Change 4239685 by Ben.Marsh Static analysis CIS fix. Change 4240800 by Ben.Marsh WorkspaceTool: Include the full command line in the log for any P4 commands. Change 4240903 by Ben.Marsh PR #4909: Update copyright notices to 2018 (Contributed by projectgheist) Change 4241025 by Ben.Marsh UBT: Exclude mobile pipeline caches from generated project files. Causes huge slowdown when using 'Find in Files' through the IDE. Change 4241770 by Ben.Marsh UBT: Include action number in parallel executor output. #jira UE-62032 Change 4243469 by Ben.Marsh TBA: Merge FAnnotatedStructuredArchiveFormatter with FStructuredArchiveFormatter. Any functions that are only implemented for text archives now have a _TextOnly suffix, and are exposed through the FStructuredArchive interface. Change 4245723 by Robert.Manuszewski Fixing another creash when terminating the engine while initializing. #jira UE-60545 Change 4245862 by Steve.Robb VectorLoadFloat2(Ptr) added, which loads { Ptr[0], Ptr[1], Ptr[0], Ptr[1] } into a VectorRegister. Change 4246412 by Robert.Manuszewski The warning 'Calling StaticLoadObject during PostLoad may result in hitches during streaming' will now also report the object which had the PostLoad called on it when StaticLoadObject call happened. Change 4246612 by Ben.Marsh UBT: Fix spelling of "Intellisense". Change 4249454 by Robert.Manuszewski Added extra checks to catch scenarios where the EDL Precache Buffer is flushed before a package header is fully read Change 4249513 by Robert.Manuszewski Made sure the Async Loading Thread doesn't continue running after creating new async packages when garbage collector wants to run on the game thread Change 4255207 by Ben.Marsh UGS: Add additional logging whenever a P4 command fails, and when the user is logged out. Change 4255288 by Ben.Marsh PR #4921: Honor ModuleRules' bEnableExceptions flag when creating precompiled h. (Contributed by surakin) Change 4256422 by Ben.Marsh UBT: Add an error if a module referenced by a plugin descriptor doesn't exist. Change 4257385 by Robert.Manuszewski Creating new objects from within ForEachObjectWithOuter will now result in a fatal error as it's unsafe to change internal UObject hash tables when iterating over them. Change 4257454 by Robert.Manuszewski Added the option to filter clusters listed with gc.ListClusters by objects within them. Usage: gc.ListClusters Hierachy With=ObjectName1,ObjectName2... Change 4257526 by Robert.Manuszewski It's now possible to filter clusters that get logged with verbose cluster logging enabled (UE_GCCLUSTER_VERBOSE_LOGGING=1) by objects within them by specifying -DumpClustersWithObjects=ObjectName1,ObjectName2 in the command line Change 4257822 by Ben.Marsh Fixes for PlatformShowcase compile errors. Change 4258771 by Ben.Marsh UBT: Fix project files not being generated for foreign projects when creating .stub files. #jira UE-62462 Change 4258790 by Ben.Marsh UBT: Clean up the logic around generating project files before creating a stub IPA, so that it fails loudly if project files do not exist, and can accept target names not matching project names. Change 4259276 by Ben.Marsh UBT: Make it an error if a framework doesn't exist, rather than failing silently. Also remove some remote toolchain stuff that's no longer necessary. Change 4259280 by Ben.Marsh UBT: Fix embedded framework zips not being uploaded for plugins. #jira UE-62485 Change 4260236 by Ben.Marsh UBT: Fix path to generated engine project file. Change 4260334 by Ben.Marsh UGS: Fix custom build steps dialog inadvertantly modifying config file settings in-place. Change 4260361 by Ben.Marsh UGS: Allow for p4 login commands to fail, even though the user is logged in (due to a bad connection, etc...) Change 4260559 by Ben.Marsh UGS: Update version. Change 4261160 by Robert.Manuszewski MediaPlaylist will now be added to root set if the owning MediaPlayer is in the disregard for GC set (fixes GC assumption violation crash) #jira UE-62495 Change 4261421 by Ben.Marsh Force-sync files for building documentation, to fix issues with files not being updated. #jira UE-62413 Change 4261425 by Ben.Marsh UBT: Remove some leftover functions for handling the remote toolchain. Change 4261530 by Ben.Marsh UBT: Speculative fix (and better error reporting) for IOS mobile provision not being found in CIS. Change 4261611 by Ben.Marsh UBT: Downgrade warning to a log message, since it appears when generating project files. Change 4261710 by Ben.Marsh Remove assert that GLogConsole is set; it won't be for command line utilities that don't depend on ApplicationCore. #jira UE-62545 Change 4261831 by Ben.Marsh Fix compile errors due to missing include path when hot-reloading a module from the editor. There are not necessarily source files to compile when -modulewithsuffix is specified on the command line, which was results in GeneratedCodeWildcard not being set. #jira UE-62463, UE-62384 Change 4262723 by Ben.Marsh Whitelist plugins that need to be loaded by UFE. #jira UE-62564 Change 4265444 by Ben.Marsh Fix incorrect executable name for DebugGame configurations in Xcode. #jira UE-62574 Change 4265892 by Ben.Marsh Fix incremental compile failures due to dependency checking for unity files. CachedIncludePaths was not correctly being set on file items, so dependencies were being ignored. #jira UE-62575, UE-62603, UE-62597 Change 4266019 by Josh.Adams - Fixed the CopyAction for runtime dependencies that need to be copied to different location, on non-XGE Change 4266264 by Ben.Marsh Remove override for the __IPHONE_OS_VERSION_MIN_REQUIRED macro on TVOS. This macro is already defined by system headers (in <AvailabilityInternal.h>). Now that we support PCHs on IOS and TVOS, manually defining this macro results in it being defined three times (once for the PCH, once by AvailabilityInternal.h, and once by the force-included list of definitions for the source file being built). The errors for redefining the macro in AvailabilityInternal.h are suppressed due to it being a system header, but the error for redefining it for the source file being compiled are not. #jira UE-62578 Change 4266273 by Ben.Marsh Fixes incremental build failure when compile arguments for PCH have changed on IOS/TVOS. Compile action needs to have a dependency on PCH build action. Change 4266614 by Graeme.Thornton Fix crash when cooking nativized blueprints due to removal of child cooker system. Change 4266763 by Ben.Marsh Always build UnrealPak when building client targets. The ProjectParams.Pak option is not reliable, because it can be forced on later by the target platform. #jira UE-62584 Change 4267985 by Robert.Manuszewski When iterating with ForEachObjectWithouter, don't lock the entire has table but only the hash bucket that is currently being iterated #jira UE-62600 Change 4268558 by Robert.Manuszewski PurgeLegacyBlueprints will no longer be called from within ForEachObjectWithOuter is it renames objects that reside in hash tables that are being iterated over which may lead to undefined behavior. #jira UE-62600 Change 4269011 by Chad.Garyet - Fixing Wildcard match issue, the change to ugsapi sends projects as //Depot/Stream instead of //Depot/Stream/ Wildcard match was only substringing to 3 chars. - Checking in the change a while back that increases the number of queried jobs up to 432 based on some maths from Bob about how many builds we want to grab Published to ugsapi server 8/8/17 #jira none Change 4270788 by Ben.Marsh Fix IOS provisioning data being using when remote compiling on TVOS. #jira UE-62705 Change 4271916 by Ben.Marsh Tag the XGEControlWorker executable as a build product after compiling SCW, to make sure it's included in the UGS zip file. Change 4271934 by Ben.Marsh Upload all static libraries in plugin folders as part of remote builds. #jira UE-62694 Change 4273368 by Ben.Marsh Fix Slate dependencies not being enumerated, and rules assembly not being rebuilt when building remotely. #jira UE-62705 Change 4274049 by Ben.Marsh Always parse the team UUID out of the mobile provision when doing a remote compile. The provision installed on the remote Mac (and selected for signing) may be different. #jira UE-62751 Change 4274823 by Ben.Marsh Add the -VersionCookedContent argument to disable the -unversioned parameter on the cooker command line. Change 4275838 by Ben.Marsh Fix BuildVersion string not being passed through from <SetVersion> task. Also add a -BuildVersion command line argument to UBT to override it for a particular build. Change 4275913 by Ben.Marsh Add a dummy exported symbol to the XGEController module, to fix build errors due to missing .lib file when it's built with WITH_XGE_CONTROLLER = 0. Change 4284161 by Ben.Marsh Allow mirroring Oodle files to remote Mac. Change 4074774 by Steve.Robb Vast simplification of TFunction, making it smaller in footprint, easier to follow and extend, and more correct. TUniqueFunction added, which is a move-only TFunction which can hold move-only functors. Fix for UWidgetBlueprint::ForEachSourceWidget() which should never have compiled but did. FFunctionGraphTask and TFuture<> updated to use TUniqueFunction to make them more general. TArray::HeapPop() made to work with move-only types. Change 4082591 by Ben.Marsh Move the Log class from UBT to DotNetUtilities. Change 4083236 by Ben.Marsh Add a Log.WriteException() method to dump an exception message to the console (and write the exception trace to the log) Change 4084107 by Ben.Marsh UAT: Remove the unused -SkipHeader argument to UE4Build. Change 4089771 by Steve.Robb GitHub #4743 : modified VirtualAlloc function flag https://blogs.msdn.microsoft.com/oldnewthing/20151008-00/?p=91411 Change 4091456 by Steve.Robb Unification of all platforms' FMath::CountTrailingZeros() and FMath::CountLeadingZeros() for both 32-bit and 64-bit. Change 4156437 by Ben.Marsh Lots and lots of fixes compiling for Clang on Windows. Editor now compiles cleanly without warnings, but crashes on startup due to error in intrinsics test. Disabling that runs further, but crashes accessing freed memory. Switching to the ANSI allocator runs further, but crashes in Slate after the splash screen and before the editor window opens. // TODO! * Switching between Clang/ICL/VS2015/VS2017 is now supported through the same mechanism as switching Visual Studio versions, without requiring any source level changes. To use Clang, set WindowsPlatform.Compiler = WindowsCompiler.Clang from a .target.cs file, or set <WindowsPlatform><Compiler>Clang</Compiler></WindowsPlatform> from BuildConfiguration.xml. To pick a specific toolchain version, set WindowsPlatform.CompilerVersion. * Clang is now supported through AutoSDKs; will be added to CIS. * The Samples/Sandbox/Clang project forces Clang to be used from its target.cs file, and allows easily building all editor modules and plugins with Clang on Windows. * UnrealMathSSE intrinsics have been re-enabled for Clang due to missing functions from the UnrealMathFPU implementation, but causes failure in tests at startup. * SSE4_CRC32() is disabled in D3D12Pipelinestate.cpp, since intrinsics are only allowed if enabled for the whole target (rather than being used in specific functions due to runtime checks) Change 4157389 by Ben.Marsh Few more fixes for compiling the editor with Clang. Change 4183911 by Ben.Marsh Fixes to support incremental linking on Windows. Does not seem to have any net benefit right now; may improve once minimal rebuild is enabled. * Incremental linking no longer forces PDB files to be enabled for source files. * Actions can specify specific files to be deleted before each build. Code to forcibly delete PDB files has been moved to the MSVC toolchain. * Unused libraries produced by the cross-referenced link are no longer added as build products, since (a) deleting them breaks dependency checking for incremental linking and causes a full link, and (b) not deleting them breaks UBT dependency checking and causes actions to be run over and over again. * Icon update is disabled for Windows when incremental linking is enabled. * Removed rarely-used setting to always delete produced items before each build. Change 4184311 by Ben.Marsh UGS: Added a dialog which shows all the required platform SDKs for a branch, linked from the status panel in UGS. The llist is configured via the UGS config file submitted to Engine/Programs/UnrealGameSync/UnrealGameSync.ini (and may be overridden by the project config file if necessary): [Default] ; Set this to a network share which contains the SDK installers for your site SdkInstallerDir= ; All the required SDKs for the current version of the engine +SdkInfo=(Category="Android", Description="NDK r21", Browse="$(SdkInstallerDir)\\Android") +SdkInfo=(Category="Windows", Description="Visual Studio 2017") +SdkInfo=(Category="Windows", Description="Visual C++ Toolchain 14.13.26128") +SdkInfo=(Category="Windows", Description="Windows SDK 10.0.16299.0") Similar entries for console platforms are added in console subdirectories. Each entry may contain an Install="Foo.exe" and/or Browse="C:\Foo" style attribute, specifying the path to an installer to run or directory to open in explorer respectively. The SdkInstallerDir setting is used as a base directory for the default installers, seen above for Android. Licensees may override this with a network path specific to the site that UGS is being deployed to (either in this file, in a project specific config file, or in a Engine/Programs/UnrealGameSync/NotForLicensees/UnrealGameSync.ini file). Change 4200452 by Ben.Marsh UBT: Change DebugGame configurations to output a separate executable rather than requiring a -Debug argument at runtime. Previous behavior was a common source of errors. Engine modules are still shared between Development and DebugGame, but the launch module sets a flag in Core on startup indicating the game configuration. Change 4206189 by Ben.Marsh UBT: Simplify logic for precompiling binaries. * Target no longer has separate list of "precompile only" binaries or modules. New -AllModules option allows adding every module to a target, which can be used with -Precompile and -NoLink to precompile object files for monolithic builds. * Precompiled file lists have been removed from target receipts. * The manifest now includes all generated headers and precompiled files when run with the -Precompile option. * Separate -DependencyList=Foo.txt has been added to write a list of all dependencies required to use precompiled binaries. This file list can be read using the <Tag> task in buildgraph. Change 4215466 by Ben.Marsh UBT: Remove indirect calls to determine extensions for object files and precompiled headers. The toolchain knows the correct convention for the platform. Change 4215975 by Ben.Marsh UBT: Remove telemetry code. This has never proved useful for analyzing performance due to the number of incidental factors that affect build times (eg. number of files being compiled). Change 4220154 by Ben.Marsh Move text-only implementations of FOutputDeviceError back into Core, so we can build command-line applications that don't depend on ApplicationCore. Change 4224708 by Ben.Marsh Add a bCompileAgainstApplicationCore setting to the target rules, which allows compiling out references to the ApplicationCore module (which should only be necessary for applications with a GUI). Removed ApplicationCore from several engine tools and utilities. Change 4224958 by Ben.Marsh Remove CoreMinimal.h includes from Core. Change 4229059 by Ben.Marsh UBT: Remove the UEBuildPlatform.ShouldNotBuildEditor() hook for target platforms. We shouldn't be modifying a target's build environment to disable the editor; it is invalid to build the editor for these target platforms at all, and this is already enforced by the GetSupportedPlatforms() function. Change 4230508 by Ben.Marsh Fixup precompiled header setting for samples and games. Change 4231457 by Ben.Marsh Fix exceptions in log messages having trailing newlines. Change 4232406 by Ben.Marsh UBT: Always force include a PCH for generated code if there's one set; the code may depend on it to compile. Change 4234177 by Ben.Marsh Set up private PCH files everywhere that previously used them. Change 4235973 by Ben.Marsh Change FPlatformMisc::GetEnvironmentVariable() to return an FString() rather than requiring a fixed size buffer to be passed in. Removes references to MAX_PATH. Change 4238842 by Ben.Marsh Add support for paths longer than MAX_PATH in the editor. Requires Windows 10 version 1607, and the functionality to be enabled via a registry key or group policy (see https://docs.microsoft.com/en-us/windows/desktop/FileIO/naming-a-file). Only a subset of Win32 functions support long paths (executables can only be started from paths shorter than MAX_PATH, for example). * Added a FPlatformMisc::GetMaxPathLength() function to return the maximum length of a path on the current system. On Windows, this returns a different value for systems with long paths enabled to those without. * The MAX_PATH define is no longer set by non-Windows platforms. Instead, there is a MAC_MAX_PATH, UNIX_MAX_PATH, etc... for any platform-specific code that still relies on the previous macro. * The MAX_UNREAL_FILENAME_LENGTH macro has been renamed to MAX_UNREAL_FILENAME_LENGTH_DEPRECATED * The PLATFORM_MAX_FILEPATH_LENGTH macro has been renamed to PLATFORM_MAX_FILEPATH_LENGTH_DEPRECATED. * Removed custom resource files for programs, since they are just copies of the base UE4 one (which is used by default anyway). The base UE4 manifest declares support for long paths. * Fix 512 character maximum length on editor commands. 260 character limit remains in place for cooking at the moment (see ContentBrowserUtils.h), until C# staging code supports long paths. Change 4255042 by Ben.Marsh UBT: Remote compilation now uploads the entire workspace to the remote Mac and executes a separate remote instance of UBT rather than synchronizing individual actions. This makes the remote compile codepath much simpler, and removes a lot of special cases that exist to support it previously. The list of files to be transferred to the remote are listed as rsync filter rules in Engine/Build/Rsync/RsyncEngine.txt and RsyncProject.txt, which are applied to the root engine directory and project directory respectively. Projects that need to customize which files are uploaded can add their own <ProjectDir>/Build/Rsync/RsyncProject.txt file, which will be included in the filter before the default version. Change 4260567 by Ben.Marsh UAT: Rename CommandUtils.Log to CommandUtils.LogInformation, to avoid conflicts with the underlying Tools.DotNETCommon.Log class. #rb none [CL 4285673 by Ben Marsh in Main branch]
2018-08-14 18:32:34 -04:00
PlatformOrdinal = AssignPlatformOrdinal(*this);
}
/** Information about this platform */
- Renamed PlatformInfo::FPlatformInfo to PlatformInfo::FTargetPlatformInfo - Renamed FDataDrivenPlatformRegistry::FPlatformInfo to FDataDrivenPlatformInfo - Moved some fields from PlatformInfo::FTargetPlatformInfo to FDataDrivenPlatformInfo, and cleaned them up in the process - Fixed the DataDrivePlatformInfo.ini files to match the previous items - Removed FVanillaPlatformEntry, and now just using FTargetPlatformInfo to manage flavors under a vanilla PlatformInfo (see PlatformInfo::GetVanillaPlatformInfoArray()) - Cleaned up TPerPlatformValue, as it was often misused (took a group and platform name, but we can get the group from the platform name) [AnimationSharingManager.cpp, *Engine.cpp, Runtime\Engine\*, ] - Fixed FBlueprintNativeCodeGenPaths::GetDefaultCodeGenPaths() to use IniPlatformName instead of some hacky code [BlueprintNativeCodeGenManifest.cpp] - Fixed various Turnkey bugs that recent testing exposed - Enabled AUTOSDKS_ENABLED in both Mac and Linux on the Editor side (not that there are much set up to use it) - Using Turnkey to get the SDK status instead of ValidatePlatforms (gives more detailed information - may want to go back to ValidatePlatforms so only UBT is needed, but change it to give more info) - Moved OnDeviceDiscovered and Lost delegates from each platform's TargetPlatform class to a static in ITargetPlatform - there was no need for per-platform implementations - Started working on allowing for SDK to be installed with editor running and not need to restart editor - Work in Progress! It is not usable yet. #fyi jack.porter #rb pete.sauerbrei [CL 13816905 by Josh Adams in ue5-main branch]
2020-07-01 17:07:12 -04:00
const PlatformInfo::FTargetPlatformInfo *PlatformInfo;
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 4285612) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3836829 by Ben.Marsh UBT: Fix ability to precompile plugins from installed engine builds. Change 3839519 by Ben.Marsh UBT: Simplify configuring bPrecompile and bUsePrecompile settings for modules. Each rules assembly can now be configured as installed, which defaults the module rules it creates to use precompiled data. Change 4042043 by Steve.Robb GitHub #4705 : Added weak lambda's for delegates and multicast delegates. Change 4042056 by Robert.Manuszewski Optimized Mark Phase of GC by up to 10ms by making it run in parallel and removing a huge array presize which we didn't need. Change 4042104 by Robert.Manuszewski Set the minimum GC cluster size to 5 so that GC doesn't have to process micro clusters which are more expensive than processing individual objects + Exposed the minimum cluster size to ini and project settings as gc.MinGCClusterSize + Added the ability to sort clusters by name/object count/mutable object count/referenced clusters count when dumping them with gc.ListClusters command Change 4042377 by Robert.Manuszewski Reworked how GC and other threads (ALT specifically) interact - GC will now notify the ALT it wants to run and ALT will immediately try to finish its current work to allow that. Also the entire ALT tick is now protected against GC running at the same time to improve ALT stability. + added gc.ForceCollectGarbageEveryFrame console variable that triggers a forced GC every frame Change 4042427 by Robert.Manuszewski Changed FGCCSyncObject to use events when waiting for GC to finish so that it doesn't spin on non-game threads when GC is running Change 4042482 by Robert.Manuszewski Unhashing unreachable objects (ConditionalBeginDestroy) will now also be done incrementally, just like the purge phase of Garbage Collection Change 4042635 by Robert.Manuszewski Fix for a potential assert when incremental purge garbage is pending and something forces a full purge Change 4044092 by Steve.Robb Fix for forward declared CoreUObject weakobject types in delegates when building in Clang. Change 4044102 by Robert.Manuszewski Fix for a possible hang when worker threads are preventing GC from running and something is later trying to FlushAsyncLoading with the Async Loading Thread enabled Change 4044113 by Steve.Robb Another Clang fix. Change 4044160 by Robert.Manuszewski Disregard For GC pool will now be enabled by default in cooked builds Change 4044287 by Steve.Robb Typo fix. Change 4047723 by Graeme.Thornton TBA: Fixes for import/export name cache and object resolving Change 4048015 by Graeme.Thornton TBA: Weak/Soft/Lazy pointer serialization changes * Remove FWeakObjectPtr::Serialize, move it's logic into, and replace usages of with calls to, FArchiveUObject::SerializeWeakObjectPtr(). Ensures that something is always sent to the archive so that structured archives can be kept happy in the future. * Added Weak/Soft/Lazy pointer handling to the structured archive slot interface and all the formatters. Binary formatters just forward the call onto their inner and text archives store as a string path reference. * FArchiveUObjectFromStructuredArchive caches all these pointer types and stores indices in the binary block, same as with a UObject*. All pointers are then forwarded to the underlying formatter in one go on finalization. Change 4048021 by Steve.Robb Fix for binding an unbound TFunction to another TFunction with a different signature. Also all null pointers now count as unbindings, not just nullptr. TIsMemberPointer added. TIsATFunction and TIsATFunctionRef renamed to remove the 'A's. Change 4048544 by Robert.Manuszewski Fixing ConditionalBeginDestroy profiling after changes to incremental CBD. Change 4051028 by Graeme.Thornton TBA: ArchiveFromStructuredArchive adapter uses Inner to determine if it is outputting to text, and sets it's own ArIsTextFormat to false Change 4051056 by Graeme.Thornton TBA: High level tagged property / UObject base class text serialization - UObject serialize converted to structured archive - Properties written to text individually with text tags, and then binary adapted values - Only saves, doesn't load Change 4051111 by Graeme.Thornton TBA: Temporarily disable loading of text assets until tagged property serialization path is fixed up Change 4051154 by Graeme.Thornton TBA: Convert a few uobject serializers to structured archive format for example purposes Change 4051181 by Graeme.Thornton TBA: Added default structured archive implementation of SerializeItem to UProperty, which just calls the FArchive version on an FArchiveUObjectFromStructuredArchive adapter. Implemented structured archive SerializeItem for UArrayProperty Change 4051197 by Graeme.Thornton TBA: ObjectProperty text serialization Change 4051216 by Graeme.Thornton Restored a modified FWeakObjectPtr::Serialize function to keep backwards compatibility in code I don't have access to. Change 4051261 by Graeme.Thornton TBA: Convert UMetaData to structured archive Change 4051374 by Steve.Robb Incorrect assert removed. Change 4051562 by Robert.Manuszewski Adding stats for the new GC internal functions Change 4051614 by Graeme.Thornton TBA: Removed UProperty::SerializeItem(FArchive, ...) and replaced with UProperty::SerializeItem(FStructuredArchive::FSlot, ...). Fixed up most of them to work properly and added adapters in for any that were non-trivial. Change 4052512 by Graeme.Thornton TBA: Temporary workaround for softobjectptr and lazyobjectptr uproperties not serialization anything when they know the archive is a reference collector. They should always be serializing their pointers and letting the underlying archive itself ignore them. Change 4053917 by Robert.Manuszewski Clustered objects from clusters that are no longer reachable will now be marked as unreachable immediately when gathering unreachable objects Change 4053919 by Robert.Manuszewski Added the ability to disable incremental BeginDestroy in ini/project settings Change 4055518 by Daniel.Lamb Fixup for deterministic audio generation issue. Submitted on behalf of Rich.Whitehouse #jira nojira #test prefilght automated test. Change 4056854 by Graeme.Thornton TBA: Added a test asset to EngineTest which contains all the different property types and test cases. Change 4056858 by Graeme.Thornton TBA: Updated USetProperty to proper structured archive usage Change 4056872 by Graeme.Thornton TBA: Add map property field to test object Change 4056873 by Graeme.Thornton TBA: Convert UMapProperty to full structured archive Change 4056994 by Graeme.Thornton TBA: Converted FText over to structured archive. Implemented saving, but not loading. Change 4059728 by Ben.Marsh UBT: Add support for using adaptive non-unity builds when the engine and project are in separate repositories. Change 4059805 by Graeme.Thornton Fixed typo in text serialization. Fixes CIS automation test errors Change 4060007 by Graeme.Thornton TBA: FArchiveFromStructuredArchive will now access it's host slot lazily, i.e. only when a value is actually written to the archive. Change 4060092 by Stefan.Boberg Added optimized Windows console window output path to GenericConsoleOutput since this slowed down cooking considerably (2 minutes spent in wprintf alone for one large dataset) When stdout is attached to a console we use the WriteConsoleW function instead of wprintf since the latter is very slow especially in unbuffered mode which the engine currently configures for stdout (see setvbuf call in LaunchEngineLoop.cpp). At some point we should reconsider this buffering policy since it's likely to slow down other platforms as well but I wanted to do a safe change for now as I don't yet fully understand why the setvbuf call is there in the first place. Change 4060108 by Stefan.Boberg Introduced some additional target platform utilities to help with asset cook optimizations * We now assign each ITargetPlatform a zero-based ordinal value * Introduced FTargetPlatform and FTargetPlatformSet types to help store platform references and platform sets efficiently. These are not currently used in the engine but are designed to replace the existing ITargetPlatform/string/FName representations in the cooking data structures. Change 4060143 by Graeme.Thornton Undo //UE4/Dev-Core/Engine/Source/Runtime/... changelist 4060007 Needs some other changes that I haven't checked in yet... Change 4062432 by Ben.Marsh Fix error message when enumerating P4 changes. Change 4062648 by Ben.Marsh Add missing p4 integration action. Change 4063620 by Graeme.Thornton Integrated a fix from UDN where the engine would crash when trying to load a very small encrypted file (<16bytes) from a pak file, where the read address wasn't already aligned to the AES block size. (https://udn.unrealengine.com/questions/431989/crash-while-reading-a-very-small-file-in-encrypted.html) Change 4066963 by Robert.Manuszewski Fixing GC cluster verification code reporting false positives when a cluster is referencing another cluster through 'mutable' objects list. Change 4067133 by Robert.Manuszewski Changed log verbosity when reporting individual cases of GC cluster assumption violations as they are followed by an asser anyway and this way we get the chance to see all issues before we assert at the end of these checks. Change 4067443 by Steve.Robb FString can now be constructed from any char pointer type and length. Change 4068156 by Steve.Robb Fix necessary because of FString constructor change in CL# 4067443. Change 4070258 by Graeme.Thornton Fixes for VSCode Change 4070372 by Graeme.Thornton TBA: Script struct serialization to structured archives Change 4071913 by Ben.Marsh Move bulk of the code for UnrealPak into an engine developer module, so it can be used in the editor. Change 4071914 by Ben.Marsh Missing files. Change 4071937 by Ben.Marsh Missing header. Change 4072015 by Ben.Marsh Fixes for compiling PakFileUtilities as part of the editor. Change 4072826 by Steve.Robb TBitArray::Reserve() added. TBitArray::Add() overloaded to allow adding multiple bits. TSparseArray::Reserve() optimized to call the overloaded Add(). Change 4073271 by Daniel.Lamb Fixed add patch tier in project launcher passing the wrong commandline option to UAT. #test none Change 4074708 by James.Hopkin #core Removed redundant Casts Change 4074763 by Steve.Robb Fix for TSparseArray::Reserve() size. Change 4076063 by Ben.Marsh Add an "UnrealPak" commandlet with the same functionality as the standalone UnrealPak program. Invoke by running the editor with -run=UnrealPak and the standard UnrealPak commandline options. Change 4077064 by Robert.Manuszewski Fixing compile error in PakFileUtilities Change 4077144 by Graeme.Thornton TBA: TextAssetCommandlet improvements * Collect lists of broken assets during roundtrip tests and print a summary of packages that failed each phase at the end * After resaving as text, load the file back as a plain JSON hierarchy to ensure the output was valid Change 4077412 by Ben.Marsh Set the correct exit code for UnrealPak. Should return 0 on success, not 1. Change 4077760 by Graeme.Thornton TBA: Loading fixed for tagged property serialization Includes conversion of all UProperty::ConvertFromType() and SerializeFromMismatchedTag() functions to use structured archives Lazy initialization of FArchiveFromStructruredArchive when loading, to support the possibility of an adapter being create around an object property serialize call to its inner UStruct, which then decides not to do anything and return false. Stops the ArchiveFromStructuredArchive from consuming the slot and getting upset later on when we try to serialize normal tagged properties from it. Disabled lazy bulk data loading from text assets. Requires a bigger change to make it work. Added some debug checks to json input formatter which track the current value stack size when a new object is pushed onto the stack, and makes sure that the stack has returned to the same size when the object is popped. Catches cases where we unpack an array/stream to the value stack but then don't consume all the items. Change 4078800 by Ben.Marsh Change UAT to using the editor's UnrealPak commandlet rather than invoking the standalone UnrealPak executable. To improve performance when building several PAK files, also add a new -batch=<file> command which reads commands to execute in parallel from a text file. Change 4079745 by Graeme.Thornton TBA: Migrated a couple of UObject Serialize functions to FStructuredArchive (SoundCue / MaterialExpressions / Editor strip flags) Change 4079847 by Graeme.Thornton TBA: Add 'FindMismatchedSerializers' mode to text asset commandlet, which dumps out a list of all UClasses which don't have the CLASS_MatchedSerializers flag, meaning we can't guarantee the have Serialize functions for FArchive AND FStructuredArchive, therefore we can't use the new structured archive based serialize path. Should only ever be native instrinsic classes as UHT takes care of all other cases. Change 4079925 by Ben.Marsh Fix incorrect assignment when deriving name for chunked pak file. Change 4080214 by Ben.Marsh Move the ThreadPoolWorkQueue class into DotNETUtilities so it can be used by other projects. Change 4082394 by Graeme.Thornton CIS fix for variable shadowing warning Change 4082583 by Ben.Marsh Add a IBinarySerializable interface for types that support reading from a BinaryReader and writing to a BinaryWriter. Implementing IBinarySerializable implies a constructor taking a BinaryReader argument is available for deserializing. Change 4082652 by Ben.Marsh Fix FileReference.Directory not returning a directory with a trailing backslash for files in the root directory. Change 4082755 by Graeme.Thornton Fixed an erroneous usage of TUniquePtr<uint8>as a pointer to a uint8 array when creating pak files. Caused a crash when compression was enabled, and has probably surfaced because pak generation is now done by an editor commandlet rather than a standalone program. Change 4082756 by Graeme.Thornton Fixed some incorrect documentation for pakfile compressed chunk headers Change 4082883 by Graeme.Thornton Static analysis warning fix Change 4082912 by Ben.Marsh Move ExceptionUtils into DotNETUtilities. Change 4085291 by Graeme.Thornton TBA: In the Json output formatter, write float and double values out with enough precision for successful roundtripping. Added some debug only code which will immediately reconvert the string back to its original value and compare the the input Change 4085523 by Graeme.Thornton TBA: Remove only explicit usage of DECLARE_FSTRUCTUREDARCHIVE_SERIALIZER. Should only be used from UHT generated code. Change 4086037 by Robert.Manuszewski Fix for a potential race condition when two threads want to acquire GC lock Change 4088655 by Graeme.Thornton Pak creation now uses the bEnablePakSigning setting from the crypto config json file Change 4091474 by Steve.Robb Fix for TStaticBitArray::FindFirstSetBit() and TStaticBitArray::FindFirstClearBit(). Unused variables removed. Change 4093632 by Steve.Robb CIS fixes. Change 4093656 by Graeme.Thornton Build fix Change 4093744 by Ben.Marsh Allow per-chunk settings for whether to enable compression in UnrealPak. Change 4099712 by Gil.Gribb UE4 - Fixed rare case where insufficient space was preallocated for cooldown ticks. #jira UE-59686 Change 4099912 by Stefan.Boberg Cooking timer optimizations: - Replaced data structures for FScopeTimer and FHierarchicalTimerInfo. Previous implementation used FString for many things and caused *lots* of heap and string concatenation activity. Replaced with a compile-time node id (using __COUNTER__) and raw string literals. - Removed PERPACKAGE_TIMER support (was disabled by default and was difficult to test) - Made it possible to toggle OUTPUT_TIMING and ENABLE_COOK_STATS independently - Removed some extremely tight timers because the overhead from calling QPC significantly exceeded the measured code This change shaved some 15% off a clean cook of Fortnite WindowsClient (en) with fully populated local DDC Change 4100519 by Stefan.Boberg Quick fix for Linux build issue introduced in 4099927 Change 4105327 by Stefan.Boberg Cooker: Changed FHierarchicalTimerInfo so it uses a linked list for tracking child nodes, to be able to deal with any child count. Previously we assumed there would never be more than 9 children but it turns out there are cooker modes that need more. Fixes check when using -FullLoadAndSave to cook Change 4105448 by Stefan.Boberg - Fixed Linux build warning re: member initialization order - Also eliminated OUTPUT_HIERARCHYTIMERS/CLEAR_HIEARCHYTIMERS macros (plain functions are fine) - Moved finishing-up code for FullLoadAndSave() to TickCookOnTheSide() call site to improve timer output. Previously some of the scopes would not have been closed before printing and thus the output was misleading. Change 4109031 by Ben.Marsh Attribute-driven Perforce wrapper (old Epic Friday project). Offers a more complete implementation than the current P4 wrapper in UAT without requiring any platform-specific libraries. Uses the Python binary output for parsing. Change 4109588 by Ben.Marsh UBT: Add extension methods for serializing a nullable type to a BinaryReader/BinaryWriter. Change 4109595 by Ben.Marsh Missing project file for DotNETUtilities. Change 4110724 by Stefan.Boberg Removed annotation map locking in UObjectMarks, eliminating around one minute (~3.5%) from Fortnite cook time. The locking was redundant since the annotation maps are managed per thread anyway. Change 4111304 by Ben.Marsh UAT: Add support for setting a status message through the log class. Allows writing transient messages (eg. progress messages) which will be cleared out before writing other messages. Best used through the LogStatusScope class, which can set a status message for the duration of a using() block. As part of this change, the console no longer has to be added as a dedicated trace listener. Since we already special-case this listener when formatting log output, it's easier to just keep the implementation separate to the other trace listeners. Change 4112708 by Steve.Robb Fix for TBitArray::MaxBits in assignment. Change 4114133 by Stefan.Boberg Tweaked how low-level memory (LLM) tracker is implemented to reduce overheads. Previously FMemory functions would acquire the LLM singleton and call OnLowLevelFree/OnLowLevelAlloc etc which would check the bIsDisabled flag and early out if it was set. Due to how frequently these functions were called this ended up costing quite a bit. - This change makes the flag a static member variable instead of a member variable and therefore enables a simpler early-out to be implemented. - The singleton getter is also simplified to avoid hitting the threadsafe singleton construction path on every call. - The enable flag is no longer TAtomic - this also incurs extra overhead for no clear benefit Shaves approximately 3.5% (one minute) off a Fortnite cook test scenario (using -FullLoadAndSave) Change 4115010 by Robert.Manuszewski Fixing CIS Change 4115249 by Robert.Manuszewski Fixing async loading code asserts when exiting game very early due to an error #jira UE-56267 Change 4117091 by Ben.Marsh Prevent doubled-up lines when writing status updates with console log verbosity. Change 4117207 by Ben.Marsh UGS: Do not include executables in diagnostics zip file, and ignore "no such files" error when cleaning workspace. Change 4119175 by Ben.Marsh UGS: Fix crash writing version files when directory does not already exist. Change 4119987 by Ben.Marsh UGS: Show a dialog box while the launcher is updating executables from Perforce, which allows cancelling the operation if necessary. Allow setting the username on the settings window, and prompt for login credentials if necessary. Should prevent situations where users have to update settings from the command prompt. Holding down shift during launch now shows the settings dialog rather than an immediate prompt to launch the unstable version (unstable version is shown as a checkbox on this dialog). Change 4119991 by Ben.Marsh Update version number for UGS launcher to 1.13. Change 4121943 by Robert.Manuszewski Don't use FArchiveAsync2 for reading packages with non-async path in editor builds as its performance is worse than the standard archive's (saves about 1 minute when doing larger cooks and 7 seconds when loading into PIE) Change 4122592 by Steve.Robb GitHub #4762 : Improve wording and grammar of Math comments Also includes improved accuracy in FMath::ComputeBoundingSphereForCone(). Change 4122819 by Stefan.Boberg Don't call CreateDirectory redundantly when opening files for writing using FFileManagerGeneric::CreateFileWriter This change avoids calling IPlatformFile::CreateDirectoryTree if possible since this is a very expensive function especially for deep hierarchies as it performs directory creation from the root directory onwards instead of from the leaf downwards. That function should also be fixed but this change improves performance in the meantime. Change 4122872 by Stefan.Boberg CreateDirectoryTree now creates directories leaf-to-root instead of the other way around. This is much more efficient since we don't spend time on system API calls for directories which already exist. This accounted for a very large amount of CPU time in cooking as the full target file directory hierarchy would be "created" for every single output file. Change 4123109 by Stefan.Boberg - Disable overlapped I/O in editor / cooker. Synchronous I/O reduces the number of syscalls and Windows performs prefetching on our behalf anyway for sequential reads - Eliminated syscall which was issued for every write to update cached file size -- since we're the only writers to the file (file access allows read sharing at most) we can authoritatively update the file size on write completion Change 4123455 by Ben.Marsh PR #4775: New build param PCHMemoryAllocationFactor to set /Zm VS build param. (Contributed by lucaswall) Change 4124207 by Ben.Marsh UBT: Remove some unnecessary indirection for generated code paths. Change 4124217 by Ben.Marsh UBT: Remove another unused variable from UEBuildModuleCPP. Change 4124377 by Stefan.Boberg In IPlatformFile::DeleteDirectoryRecursively, attempt to delete file first and if it fails clear the readonly flag and try again Previously there was a call to clear the readonly flag for every deleted file and this is a waste of resources 99% of the time. The SetFileAttributes call accounted for a significant amount of time during cooker sandbox directory deletion Change 4125071 by Stefan.Boberg Some tweaks to FQueuedThreadPoolBase scheduling and memory management - Explicitly pass in false for TArray::RemoveAt(..., bool bAllowShrinking) argument to prevent memory reallocation when arrays are drained and inevitably repopulated shortly afterwards - Use a MRU strategy instead of LRU when picking a thread to wake up. The MRU thread is the most likely to have a 'hot' cache for the stack etc. Picking from the back of the array also happens to be cheaper since no memory movement is necessary when RemoveAt is called. (This was the strategy in place before CL2600362 which seems to have changed it unintentionally) - Release lock as soon as a thread has been chosen, before asking the worker thread to wake up and do the work Change 4126132 by Ben.Marsh UAT: Detect when stdout is redirected and prevent using backspace characters to move the cursor. Change 4126867 by Graeme.Thornton TBA: Fix tagged binary formatter Change 4127010 by Robert.Manuszewski AnimScriptInstances created at runtime will now also be added to the owning omponent's cluster to avoid GC issues. Change 4127932 by Ben.Marsh WorkspaceTool: Reduce unnecessary logging of status messages when console output is not redirected. Change 4129050 by Ben.Marsh UGS: Check for NET Framework 4.5 being installed before running the installer. Also fix warning trying to kill existing UGS instances before upgrade. Change 4129459 by Graeme.Thornton TBA: TextAssetCommandlet - When outputting converted assets to an output path, replicate the workspace relative path in the output directory Change 4129515 by Graeme.Thornton TBA: Add EnterRecord overload that allows outputting of available field names when loading. Change 4129517 by Graeme.Thornton TBA: Tagged properties are written out as named fields on the "Properties" record, rather than as a stream with a null tag at the end Change 4129518 by Graeme.Thornton TBA: Added a local const bool to allow easy hacking out of text asset loading support Change 4129558 by Graeme.Thornton TBA: Build fix for textasset-less configs Change 4129614 by Ben.Marsh UGS: Main window is now restored to normal size when activated by clicking on the tray icon. #jira UE-60490 Change 4129618 by Ben.Marsh UGS: Speculative fix for unreproduced exception accessing disposed window while shutting down. Change 4131936 by Robert.Manuszewski Removing some WIP code accidentally checked in with CL #4121943 Change 4133490 by Ben.Marsh UGS: Allow the $(Change) variable to be used in more places than just the context menu. #jira UE-60573 Change 4133550 by Ben.Marsh UGS: Setting for whether or not to use incremental builds is now exposed through the variable "$(UseIncrementalBuilds)" for use by custom build steps. #jira UE-60554 Change 4133681 by Ben.Marsh UGS: A per-project list of folders and extensions to be deleted by default when running the 'clean workspace' tool can now be specified through the <ProjectDir>/Build/UnrealGameSync.ini file. Settings may be specified for an individual branch (via a category with the depot path to the project) or for wherever the project is currently open (via the [Default] category). The SafeToDeleteFolders list specifies a substring that will be checked against folder paths. Anything containing this folder will be marked as safe for delete by default. The SafeToDeleteExtensions list specifies a list of extensions for files that can always be deleted. Example: [Default] +SafeToDeleteFolders=/MyGame/Test/ +SafeToDeleteFolders=/DataService/ +SafeToDeleteExtensions=.xx1 +SafeToDeleteExtensions=.xx2 #jira UE-60575 Change 4135449 by Ben.Marsh Fix allowing use of Job objects on Windows platforms (debug code submitted by mistake) Change 4135730 by Ben.Marsh UBT: Plugins can now be enabled and disabled from the .target.cs file (for targets that do not use the shared compile environment), by compiling the list of enabled/disabled plugin names into the Projects module. Change 4135823 by Ben.Marsh UBT: Remove legacy code to handle disabling optional plugins; now that this is compiled into the target, it will work for any plugins we choose. Change 4135945 by Ben.Marsh UBT: Fix error running programs with no explicitly enabled or disabled plugins. Change 4137207 by Ben.Marsh UGS: Align all badges with the same name, to make it easier to see which CIS steps are being run. Allow overriding the slot taken by a particular badge by calling it "SlotName:LabelName". Change 4137311 by Stefan.Boberg Removed child cooker support. In practice it is not a useful feature as it provides no performance improvement (quite the opposite in fact) and adds testing and maintenance complexity. Change 4137393 by Ben.Marsh UGS: Fix display of multiline errors in the status panel. Change 4141708 by Steve.Robb GitHub #3631 : Incorrect default argument in WeakObjectPtrTemplate #jira UE-45490 Change 4146655 by Stefan.Boberg Removed FullGCAssetClasses logic - no longer necessary nor useful Change 4147318 by Ben.Marsh UGS: Compress build badges in a column if it shrinks below the size that they would be visible. Change 4148207 by Ben.Marsh UGS: Added support for showing the latest completed build from a specific list of badges in the status panel. To declare a badge as one that should appear in the status panel rather than the CIS column, add it to the project's UnrealGameSync.ini in the project or [Default] section like so: +ServiceBadges=RoboMerge Change 4148282 by Stefan.Boberg Fixed bug in UCookOnTheFlyServer::GetCookOnTheFlyUnsolicitedFiles - UnsolicitedFiles should be passed by reference not by value Change 4148344 by Stefan.Boberg Fixed minor indentation error (most likely caused by sloppy merge) Change 4148521 by Stefan.Boberg Removed accidentally checked in PRAGMA_DISABLE_OPTIMIZATION from CookOnTheFlyServer.cpp Change 4148639 by Ben.Marsh UGS: Fix tooltips not showing for changes that have description badges. Change 4149373 by Ben.Marsh UGS: Allow adding additional columns to display particular badges by adding entries from the project config file. Example syntax: +Columns=(Name="Desktop",MinWidth=50,DesiredWidth=100,Weight=3,Badges="Editor") +Columns=(Name="Mobile",MinWidth=50,DesiredWidth=100,Weight=3,Badges="IOS,Android") Same form can be used to control how default columns are displayed (though badge settings are ignored). Also allow PerforceMonitor to detect local changes to project config files and update settings automatically. Change 4149399 by Ben.Marsh UGS: Update version to 1.143. Change 4155660 by Steve.Robb PROJECTION and PROJECTION_MEMBER macros which provide the correct behavior when creating projections using functions which are overloaded or use default arguments. Change 4157117 by Ben.Marsh Fix warning due to plugins disabled in .target.cs file. Change 4158011 by Ben.Marsh UBT: Add a check that the UnrealHeaderTool target file exists, rather than throwing an exception when reading it fails. Change 4158646 by Ben.Marsh UGS: Fix exception when login is discovered to have expired during a workspace update. Change 4158678 by Ben.Marsh UGS: Fix an exception on shutdown due to the icon being hidden after it's already been disposed. Change 4158683 by Ben.Marsh UGS: Add an unhandled exception filter which sends the exception data to the backend. Change 4159131 by Ben.Marsh UGS: Reduce the number of characters displayed for build badges based on the available space. Change 4159194 by Graeme.Thornton TBA: Fix incorrect map property conversion code when converting an old property that contains a map with different key/value types Change 4159239 by Steve.Robb Improved readability and compliance with coding standards. Change 4159246 by Ben.Marsh UGS: Allow syncing projects where source code is not available (and various version files don't exist). #jira UE-60985 Change 4159286 by Ben.Marsh UGS: Remove requirement for UE4Editor.target.cs to be visible in the depot in order to open a project. #jira UE-60986 Change 4159302 by Ben.Marsh UGS: Update version to 1.144. Change 4160308 by Ben.Marsh All staging client executables for blueprint projects. #jira UE-60983 Change 4161567 by Steve.Robb GitHub #4816 : UE-60771: Handle escaped double quote in FParse::LineExtended Change 4162641 by Ben.Marsh UGS: Allow customizing the position of custom columns, via the Index=N attribute. Change 4162647 by Ben.Marsh UGS: Update version to 1.145. Change 4165319 by Robert.Manuszewski PR #4812: Fix inconsistent command-line argument handling under Windows (Contributed by adamrehn) Change 4166150 by Ben.Marsh UGS: Include *.inl when looking for code changes. Change 4166551 by Steve.Robb Whitespace fixes caused by a bad merge. Change 4168483 by Ben.Marsh UGS: Add a more useful error if a file to be synced exceeds the max allowed path length. Change 4168490 by Ben.Marsh UGS: Update version to 1.146. Change 4168551 by Ben.Marsh UBT: Move bBuildLargeAddressAwareBinary into an exposed setting. Change 4168560 by Ben.Marsh UBT: Remove static config variable for controlling which configuration of UHT to use. Change 4171296 by Ben.Marsh UGS: Move the check for overlong paths earlier. Change 4171531 by Ben.Marsh UBT: Fix exception if BuildConfiguration.xml contains an unknown category. Change 4183371 by Robert.Manuszewski Fix for a crash in Async Loading Graph's CheckCycles when GC kicks in on the game thread and forces ALT to exit early Change 4184312 by Ben.Marsh UGS: Update version to 1.148 Change 4184480 by Robert.Manuszewski Removing unused async loading stat Change 4186390 by Ben.Marsh UBT: Format XML validation errors in a format that allows double-clicking on the message in Visual Studio. Change 4188644 by Ben.Marsh UBT: Add the MakePathSafeToUseWithCommandLine() function to UBT. Change 4188647 by Ben.Marsh UBT: Fix exception in target receipt when architecture is null. Change 4189617 by Ben.Marsh Change FileSystemReference, FileReference and DirectoryReference objects to use OrdinalIgnoreCase comparisons without creating a separate copy of the string to compare. The filesystem does not use the invariant culture, and it can produce the wrong results in some cases (the ordinal comparison is faster, too). Change 4189740 by Ben.Marsh UAT: Remote code to build UnrealPak when packaging; we use the editor now. Change 4189860 by Ben.Marsh UGS: Make the filter for excluding automated lighting rebuilds more explicit. Change 4190082 by Ben.Marsh Fixes to allow enabling edit and continue for Windows builds. Have experienced quite a few VS crashes when testing it in editor; not yet recommended for general use. - Allow edit and continue for any configuration, not just debug. - Fixed PDB errors compiling files that use a shared PCH with edit and continue enabled. Path to the generated PDB file was using the wrong directory. - Removed code that tracks PDB output files, since they're modified multiple times during a build. - Enable debug information when compiling generated CPP files, since it causes errors if the shared PCH PDB doesn't have the same option. - Disable support for remote execution of steps that modify the PDB, since the same file has to be modified many times. Remote execution causes the PDB files to be corrupted. Unfortunately, this makes E&C builds significantly slower. #jira Change 4192949 by Ben.Marsh UBT: Minor tidy-up (merging UEBuildBinary.Build and UEBuildBinary.SetupOutputFiles) Change 4193218 by Ben.Marsh Fix formatting. Change 4197252 by Mike.Erwin UAT: Fix log output w/ correct count of non-code projects. #jira none Change 4197941 by Ben.Marsh UGS: Add support for DebugGame editors that have an executable with a DebugGame suffix. Change 4197964 by Ben.Marsh UGS: Prevent attempts to automatically reopen projects while a modal dialog is up, or the workspace is syncing. Change 4198144 by Ben.Marsh UGS: Prevent modal dialogs when login expires in P4, and prompt for password when hitting "retry". Change 4198413 by Ben.Marsh UGS: Always show the main window when launched manually, and run with -RestoreState when launched at startup. Also add a couple more places that save the visibility state, since logging off seems like it can terminate the process abrubtly. Change 4198779 by Ben.Marsh UBT: Allow generating manifests to any arbitrary locations with the -Manifest=<Path> argument. Change 4198825 by Ben.Marsh UBT: Move code to enumerate Slate runtime dependencies into the Slate module. Doesn't need to be done inside core UBT. Change 4199341 by Ben.Marsh UGS: Update version to 1.149 Change 4199642 by Chad.Garyet - Deprecate CISController - Add BuildController to replace CIS GET/POST for builds - Add LatestController, GET does what CIS/GET used to do - Change Latest/GET to return the last 25 builds filtered by project, rather than the last 5000 individual Ids - Latest/GET now returns "LatestData" object instead of array of longs - Updated EventMonitor to match all API changes - Fixed bug where IDs were getting reset to initial startup values every update loop Change 4199663 by Chad.Garyet CIS controller still needs to return an array of longs #jira none Change 4199680 by Ben.Marsh UGS: Update version to 1.150 Change 4200457 by Ben.Marsh Merging CIS fix for non-development configurations. Change 4200472 by Mike.Erwin UAT: fix -skipbuildclient param default It was defaulting to skipbuildeditor's value, likely a copy-paste error. #jira none Change 4202595 by Ben.Marsh Fix static analysis warning due to constant comparison against macro. Change 4203250 by Ben.Marsh UGS: Always show the "Sync Precompiled Editor" option, but disable it and show a tooltip explaining why if it is not available. Change 4206191 by Ben.Marsh Exclude editor target files from installed builds, since they leak info about DLLs that have been stripped out. Change 4213011 by Ben.Marsh UBT: Include contents of modified intermediate files in the log, to make it easier to debug hidden dependencies. Change 4213487 by Ben.Marsh UBT: Fix assumption that bPrecompile is equivalent to bBuildAllModules. This is no longer the case; they are now controlled by separate options. Should fix CIS errors building the editor. Change 4213609 by Ben.Marsh Ensure that strings formatted using FMicrosoftPlatformString::GetVarArgs() are always null terminated, whether we use the secure CRT or not. Change 4215971 by Ben.Marsh UBT: Remove action graph visualization code; no longer used. Change 4215996 by Ben.Marsh UBT: Remove unqiue id from all actions in the action graph. This is only used for printing debug info in the case of a (rare) cycle in the action graph, so just look it up when needed. Change 4216022 by Ben.Marsh UBT: Rename Crypto.cs to EncryptionAndSigning.cs to match the name of the class inside it, and move it under the System folder. Change 4216031 by Ben.Marsh UBT: Move all the action executors into their own folder in the project. Change 4216526 by Ben.Marsh Fix CIS warnings. Change 4216544 by Ben.Marsh Replace custom code to ensure FMicrosoftPlatformString::GetVarArgs() null terminates its buffer with Microsoft's standards-compliant implementation. Change 4216633 by Ben.Marsh Add support for UnrealPak plugins. * Project and plugin modules can now specify an array of supported programs in the "WhitelistPrograms" field of their module descriptors, to allow modules to be loaded by programs. * Programs can now load any runtime modules, as long as they are whitelisted. * Programs under the engine directory can now use a shared build environment, so that building with a project file does not cause output binaries to be output to the project directory. * UnrealPak is now always built by default when packaging * Convert UnrealPak to a modular configuration Change 4216736 by Ben.Marsh UnrealPak: Move "ExportDependencies" command into an editor commandlet, since it relies on the UObject system, asset registry, etc... Change 4217447 by Ben.Marsh Back out revision 50 from //UE4/Dev-Core/Engine/Build/InstalledEngineBuild.xml Change 4217451 by Ben.Marsh Back out revision 11 from //UE4/Dev-Core/Engine/Plugins/Developer/VisualStudioSourceCodeAccess/Source/VisualStudioSourceCodeAccess/VisualStudioSourceCodeAccess.Build.cs Change 4217617 by Ben.Marsh Back out changelist 4217451 Change 4222552 by Ben.Marsh Don't use #import <TypeLib> for VS source code accessor when building with Clang; it's not supported. Change 4222630 by Ben.Marsh UBT: Fix spam while generating project files if Clang isn't installed. Change 4223316 by Ben.Marsh UBT: Change the order in which Visual C++ toolchains are enumerated to prefer full releases over preview releases. Change 4223318 by Ben.Marsh UBT: Add a build setting which allows creating a dedicated PCH for every file that's excluded from the unity working set (disabled by default). Improves iteration times when working on individual cpp files, but slows down iterating on header changes (and can take a lot of disk space for large changes). Dedicated PCH contains all includes scraped from the top of each cpp file, until a non-#include directive is encountered. Change 4223401 by Ben.Marsh UBT: Add an option to automatically enable edit and continue for files in the adaptive non-unity working set. E&C doesn't seem very useful for UE4 projects right now; compile time is comparable to regular build times, but it can take several minutes to apply code changes for large projects. Change 4223899 by Ben.Marsh UBT: Fix loading XML config files on Mono; Type.GetField(Name) does not seem to return values unless binding flags are specified. Change 4224637 by Ben.Marsh Add a "SupportedPrograms" field to plugin descriptors, which allows plugins to declare which plugins they support independently of individual modules. Programs now respect the "bEnabledByDefault" setting in plugins. Plugins that are compatible with a program now need to list that program in the SupportedPrograms list, and whitelist any modules that should load for that program. Change 4224710 by Ben.Marsh UBT: Don't add import libraries as final build products unless the target is being precompiled. Prevents the need for building them for leaf nodes in the action graph. Change 4224715 by Ben.Marsh UBT: Remove hack to allow Stats2.cpp to not follow IWYU convention. Change 4224726 by Ben.Marsh Remove commented out line. Change 4224903 by Ben.Marsh Fix non-unity compile error in Stats2.h. Change 4225051 by Ben.Marsh Back out changelist 4224710; causing CIS errors due to receipts not matching. Change 4225134 by Ben.Marsh Fixing non-unity errors. Change 4225203 by Ben.Marsh Another non-unity fix. Change 4225249 by Ben.Marsh Fix Linux dependencies being copied for the Windows editor; they can be added as requirements for the Linux target platform on Windows instead, so it respects the user's chosen platforms. #jira UE-62001 Change 4225512 by Ben.Marsh BuildGraph: Allow setting the target to build when using the <CsCompile> task. Change 4228815 by Ben.Marsh UBT: Always add the generated code directory to the list of include paths when generating project files. It may only be created after UHT has been run. Change 4228944 by Ben.Marsh UBT: Remove legacy CppCompileEnvironment and LinkEnvironment wrappers from TargetRules that were deprecated in 4.19. Change 4229028 by Ben.Marsh UBT: Fix editor targets with unique build environment having the wrong executable path in generated project files. Move move logic to configure target rules post-construction by the rules assembly to ensure it's valid. Change 4229065 by Ben.Marsh UBT: Move another target setting into the rules assembly. Change 4229105 by Ben.Marsh Fix BPT exception when generating project files. Change 4229311 by Ben.Marsh UBT: Store the module rules file location on the ModuleRules instance, as well as the plugin that it was created from. Also expose the plugin directory as a property on the ModuleRules instance. Change 4229421 by Ben.Marsh UBT: Consolidate functionality for UHT module setup in ExternalExecution.cs. Change 4229817 by Ben.Marsh UBT: Modules must now explicitly specify the path to the header used to generate a PCH if one is desired, rather than the header being determined automatically by attempting to parse the source code. Now that PCHs are force-included anyway, this removes a lot of dependencies inside UBT. Change 4229824 by Ben.Marsh UBT: Remove unused lists inside UEBuildModuleCPP.SourceFilesClass. Change 4229841 by Ben.Marsh UBT: Remove some legacy code from auto-detecting PCHs. Change 4230521 by Ben.Marsh UBT: Add utility functions to the log class to allow formatting errors and warnings in Visual Studio output format (eg. File(Line): warning: Message) Change 4230871 by Ben.Marsh UAT: Remove StreamUtilis utility class; there is a simpler way to implement the one place it's used. Change 4230882 by Ben.Marsh UAT: Add StreamUtils back into UAT, seems like it's still used there. Change 4230896 by Ben.Marsh UBT: Remove some redundant parameters from UEBuildModule/UEBuildModuleCPP/UEBuildModuleExternal constructors. Change 4231014 by Ben.Marsh WorkspaceTool: Include a dump of raw bytes when garbage is read from the P4 process, for diagnostic purposes. Change 4231032 by Ben.Marsh Fix CIS. Change 4231096 by Ben.Marsh Bump the FlatCPPIncludeDependencyCache version, to prevent errors trying to load old files. Change 4231446 by Ben.Marsh UBT: Added support for expanding UE-specific variables in include paths and library paths: $(EngineDir), $(ProjectDir), $(PluginDir), $(ModuleDir). Change 4231460 by Ben.Marsh Modules may now explicitly specify rpaths on Linux via the PublicRuntimeLibraryPaths and PrivateRuntimeLibraryPaths properties. Change 4233909 by Robert.Manuszewski PR #4779: Reason fails as the supplied variable is incorrect (Contributed by projectgheist) Change 4233910 by Ben.Marsh Enable PCHs on IOS. Reduces build time by ~25%. Change 4234176 by Ben.Marsh UBT: Add better messaging for modules that need to have a private PCH set. Now detects the likely PCH using the same method as legacy code and includes it as a suggestion. Change 4234193 by Ben.Marsh Add the Delete command to Perforce wrapper in DotNETUtilities. Change 4234688 by Ben.Marsh UBT: Simplify handling of installed/precompiled builds. Settings for whether a folder is installed/read-only or not is now stored on the RulesAssembly instance, allowing multiple things to be configured separately and stacked together (eg. engine/enterprise/project). RulesAssembly.IsReadOnly() allows determining if a flie can be modified or not and replaces many previous IsXXXInstalledCalls(), and traverses the chain of assemblies. Change 4234711 by Ben.Marsh UBT: Runtime dependencies can now be copied to output directories as part of the build. When adding a runtime dependency, an optional source location can be specified to copy from. Both the source and target paths can use variables can be used as part of the path, eg. $(OutputDir), $(ModuleDir), $(PluginDir). Example usage (from a .build.cs file): RuntimeDependencies.Add("$(OutputDir)/Foo.dll", "$(PluginDir)/Source/ThirdParty/Foo.dll", StagedFileType.NonUFS); Change 4234872 by Ben.Marsh Expose a flag for whether the engine is installed, to fix issues generating project files. Change 4234929 by Ben.Marsh Fix null reference generating receipts when UBT makefiles are active. Change 4235883 by Chad.Garyet Merging 4231245 to core Giving Coordinator its own sln. This should fix what 4158155 was supposed to. #jira UE-61955 Change 4236075 by Ben.Marsh CIS fix Change 4237066 by Robert.Manuszewski Fix for a potential crash when terminating the engine while it's being initialized #jira UE-60545 Change 4237078 by Robert.Manuszewski The engine will no longer be resetting all linkers causing massive load times when renaming the world package when entering Play In Editor Change 4237116 by Ben.Marsh Rewrite some Windows utility functions to support paths longer than MAX_PATH. Change 4237158 by Ben.Marsh Add const TCHAR* overloads of FString::RemoveFromStart() and FString::RemoveFromEnd(). Change 4237159 by Ben.Marsh Fix FWindowsPlatformFile::GetFilenameOnDisk() support for paths longer than MAX_PATH, and simplify some of the other long path functions to avoid copying string buffers. Change 4239050 by Ben.Marsh Missing file Change 4239318 by Ben.Marsh Linux CIS fix. Change 4239685 by Ben.Marsh Static analysis CIS fix. Change 4240800 by Ben.Marsh WorkspaceTool: Include the full command line in the log for any P4 commands. Change 4240903 by Ben.Marsh PR #4909: Update copyright notices to 2018 (Contributed by projectgheist) Change 4241025 by Ben.Marsh UBT: Exclude mobile pipeline caches from generated project files. Causes huge slowdown when using 'Find in Files' through the IDE. Change 4241770 by Ben.Marsh UBT: Include action number in parallel executor output. #jira UE-62032 Change 4243469 by Ben.Marsh TBA: Merge FAnnotatedStructuredArchiveFormatter with FStructuredArchiveFormatter. Any functions that are only implemented for text archives now have a _TextOnly suffix, and are exposed through the FStructuredArchive interface. Change 4245723 by Robert.Manuszewski Fixing another creash when terminating the engine while initializing. #jira UE-60545 Change 4245862 by Steve.Robb VectorLoadFloat2(Ptr) added, which loads { Ptr[0], Ptr[1], Ptr[0], Ptr[1] } into a VectorRegister. Change 4246412 by Robert.Manuszewski The warning 'Calling StaticLoadObject during PostLoad may result in hitches during streaming' will now also report the object which had the PostLoad called on it when StaticLoadObject call happened. Change 4246612 by Ben.Marsh UBT: Fix spelling of "Intellisense". Change 4249454 by Robert.Manuszewski Added extra checks to catch scenarios where the EDL Precache Buffer is flushed before a package header is fully read Change 4249513 by Robert.Manuszewski Made sure the Async Loading Thread doesn't continue running after creating new async packages when garbage collector wants to run on the game thread Change 4255207 by Ben.Marsh UGS: Add additional logging whenever a P4 command fails, and when the user is logged out. Change 4255288 by Ben.Marsh PR #4921: Honor ModuleRules' bEnableExceptions flag when creating precompiled h. (Contributed by surakin) Change 4256422 by Ben.Marsh UBT: Add an error if a module referenced by a plugin descriptor doesn't exist. Change 4257385 by Robert.Manuszewski Creating new objects from within ForEachObjectWithOuter will now result in a fatal error as it's unsafe to change internal UObject hash tables when iterating over them. Change 4257454 by Robert.Manuszewski Added the option to filter clusters listed with gc.ListClusters by objects within them. Usage: gc.ListClusters Hierachy With=ObjectName1,ObjectName2... Change 4257526 by Robert.Manuszewski It's now possible to filter clusters that get logged with verbose cluster logging enabled (UE_GCCLUSTER_VERBOSE_LOGGING=1) by objects within them by specifying -DumpClustersWithObjects=ObjectName1,ObjectName2 in the command line Change 4257822 by Ben.Marsh Fixes for PlatformShowcase compile errors. Change 4258771 by Ben.Marsh UBT: Fix project files not being generated for foreign projects when creating .stub files. #jira UE-62462 Change 4258790 by Ben.Marsh UBT: Clean up the logic around generating project files before creating a stub IPA, so that it fails loudly if project files do not exist, and can accept target names not matching project names. Change 4259276 by Ben.Marsh UBT: Make it an error if a framework doesn't exist, rather than failing silently. Also remove some remote toolchain stuff that's no longer necessary. Change 4259280 by Ben.Marsh UBT: Fix embedded framework zips not being uploaded for plugins. #jira UE-62485 Change 4260236 by Ben.Marsh UBT: Fix path to generated engine project file. Change 4260334 by Ben.Marsh UGS: Fix custom build steps dialog inadvertantly modifying config file settings in-place. Change 4260361 by Ben.Marsh UGS: Allow for p4 login commands to fail, even though the user is logged in (due to a bad connection, etc...) Change 4260559 by Ben.Marsh UGS: Update version. Change 4261160 by Robert.Manuszewski MediaPlaylist will now be added to root set if the owning MediaPlayer is in the disregard for GC set (fixes GC assumption violation crash) #jira UE-62495 Change 4261421 by Ben.Marsh Force-sync files for building documentation, to fix issues with files not being updated. #jira UE-62413 Change 4261425 by Ben.Marsh UBT: Remove some leftover functions for handling the remote toolchain. Change 4261530 by Ben.Marsh UBT: Speculative fix (and better error reporting) for IOS mobile provision not being found in CIS. Change 4261611 by Ben.Marsh UBT: Downgrade warning to a log message, since it appears when generating project files. Change 4261710 by Ben.Marsh Remove assert that GLogConsole is set; it won't be for command line utilities that don't depend on ApplicationCore. #jira UE-62545 Change 4261831 by Ben.Marsh Fix compile errors due to missing include path when hot-reloading a module from the editor. There are not necessarily source files to compile when -modulewithsuffix is specified on the command line, which was results in GeneratedCodeWildcard not being set. #jira UE-62463, UE-62384 Change 4262723 by Ben.Marsh Whitelist plugins that need to be loaded by UFE. #jira UE-62564 Change 4265444 by Ben.Marsh Fix incorrect executable name for DebugGame configurations in Xcode. #jira UE-62574 Change 4265892 by Ben.Marsh Fix incremental compile failures due to dependency checking for unity files. CachedIncludePaths was not correctly being set on file items, so dependencies were being ignored. #jira UE-62575, UE-62603, UE-62597 Change 4266019 by Josh.Adams - Fixed the CopyAction for runtime dependencies that need to be copied to different location, on non-XGE Change 4266264 by Ben.Marsh Remove override for the __IPHONE_OS_VERSION_MIN_REQUIRED macro on TVOS. This macro is already defined by system headers (in <AvailabilityInternal.h>). Now that we support PCHs on IOS and TVOS, manually defining this macro results in it being defined three times (once for the PCH, once by AvailabilityInternal.h, and once by the force-included list of definitions for the source file being built). The errors for redefining the macro in AvailabilityInternal.h are suppressed due to it being a system header, but the error for redefining it for the source file being compiled are not. #jira UE-62578 Change 4266273 by Ben.Marsh Fixes incremental build failure when compile arguments for PCH have changed on IOS/TVOS. Compile action needs to have a dependency on PCH build action. Change 4266614 by Graeme.Thornton Fix crash when cooking nativized blueprints due to removal of child cooker system. Change 4266763 by Ben.Marsh Always build UnrealPak when building client targets. The ProjectParams.Pak option is not reliable, because it can be forced on later by the target platform. #jira UE-62584 Change 4267985 by Robert.Manuszewski When iterating with ForEachObjectWithouter, don't lock the entire has table but only the hash bucket that is currently being iterated #jira UE-62600 Change 4268558 by Robert.Manuszewski PurgeLegacyBlueprints will no longer be called from within ForEachObjectWithOuter is it renames objects that reside in hash tables that are being iterated over which may lead to undefined behavior. #jira UE-62600 Change 4269011 by Chad.Garyet - Fixing Wildcard match issue, the change to ugsapi sends projects as //Depot/Stream instead of //Depot/Stream/ Wildcard match was only substringing to 3 chars. - Checking in the change a while back that increases the number of queried jobs up to 432 based on some maths from Bob about how many builds we want to grab Published to ugsapi server 8/8/17 #jira none Change 4270788 by Ben.Marsh Fix IOS provisioning data being using when remote compiling on TVOS. #jira UE-62705 Change 4271916 by Ben.Marsh Tag the XGEControlWorker executable as a build product after compiling SCW, to make sure it's included in the UGS zip file. Change 4271934 by Ben.Marsh Upload all static libraries in plugin folders as part of remote builds. #jira UE-62694 Change 4273368 by Ben.Marsh Fix Slate dependencies not being enumerated, and rules assembly not being rebuilt when building remotely. #jira UE-62705 Change 4274049 by Ben.Marsh Always parse the team UUID out of the mobile provision when doing a remote compile. The provision installed on the remote Mac (and selected for signing) may be different. #jira UE-62751 Change 4274823 by Ben.Marsh Add the -VersionCookedContent argument to disable the -unversioned parameter on the cooker command line. Change 4275838 by Ben.Marsh Fix BuildVersion string not being passed through from <SetVersion> task. Also add a -BuildVersion command line argument to UBT to override it for a particular build. Change 4275913 by Ben.Marsh Add a dummy exported symbol to the XGEController module, to fix build errors due to missing .lib file when it's built with WITH_XGE_CONTROLLER = 0. Change 4284161 by Ben.Marsh Allow mirroring Oodle files to remote Mac. Change 4074774 by Steve.Robb Vast simplification of TFunction, making it smaller in footprint, easier to follow and extend, and more correct. TUniqueFunction added, which is a move-only TFunction which can hold move-only functors. Fix for UWidgetBlueprint::ForEachSourceWidget() which should never have compiled but did. FFunctionGraphTask and TFuture<> updated to use TUniqueFunction to make them more general. TArray::HeapPop() made to work with move-only types. Change 4082591 by Ben.Marsh Move the Log class from UBT to DotNetUtilities. Change 4083236 by Ben.Marsh Add a Log.WriteException() method to dump an exception message to the console (and write the exception trace to the log) Change 4084107 by Ben.Marsh UAT: Remove the unused -SkipHeader argument to UE4Build. Change 4089771 by Steve.Robb GitHub #4743 : modified VirtualAlloc function flag https://blogs.msdn.microsoft.com/oldnewthing/20151008-00/?p=91411 Change 4091456 by Steve.Robb Unification of all platforms' FMath::CountTrailingZeros() and FMath::CountLeadingZeros() for both 32-bit and 64-bit. Change 4156437 by Ben.Marsh Lots and lots of fixes compiling for Clang on Windows. Editor now compiles cleanly without warnings, but crashes on startup due to error in intrinsics test. Disabling that runs further, but crashes accessing freed memory. Switching to the ANSI allocator runs further, but crashes in Slate after the splash screen and before the editor window opens. // TODO! * Switching between Clang/ICL/VS2015/VS2017 is now supported through the same mechanism as switching Visual Studio versions, without requiring any source level changes. To use Clang, set WindowsPlatform.Compiler = WindowsCompiler.Clang from a .target.cs file, or set <WindowsPlatform><Compiler>Clang</Compiler></WindowsPlatform> from BuildConfiguration.xml. To pick a specific toolchain version, set WindowsPlatform.CompilerVersion. * Clang is now supported through AutoSDKs; will be added to CIS. * The Samples/Sandbox/Clang project forces Clang to be used from its target.cs file, and allows easily building all editor modules and plugins with Clang on Windows. * UnrealMathSSE intrinsics have been re-enabled for Clang due to missing functions from the UnrealMathFPU implementation, but causes failure in tests at startup. * SSE4_CRC32() is disabled in D3D12Pipelinestate.cpp, since intrinsics are only allowed if enabled for the whole target (rather than being used in specific functions due to runtime checks) Change 4157389 by Ben.Marsh Few more fixes for compiling the editor with Clang. Change 4183911 by Ben.Marsh Fixes to support incremental linking on Windows. Does not seem to have any net benefit right now; may improve once minimal rebuild is enabled. * Incremental linking no longer forces PDB files to be enabled for source files. * Actions can specify specific files to be deleted before each build. Code to forcibly delete PDB files has been moved to the MSVC toolchain. * Unused libraries produced by the cross-referenced link are no longer added as build products, since (a) deleting them breaks dependency checking for incremental linking and causes a full link, and (b) not deleting them breaks UBT dependency checking and causes actions to be run over and over again. * Icon update is disabled for Windows when incremental linking is enabled. * Removed rarely-used setting to always delete produced items before each build. Change 4184311 by Ben.Marsh UGS: Added a dialog which shows all the required platform SDKs for a branch, linked from the status panel in UGS. The llist is configured via the UGS config file submitted to Engine/Programs/UnrealGameSync/UnrealGameSync.ini (and may be overridden by the project config file if necessary): [Default] ; Set this to a network share which contains the SDK installers for your site SdkInstallerDir= ; All the required SDKs for the current version of the engine +SdkInfo=(Category="Android", Description="NDK r21", Browse="$(SdkInstallerDir)\\Android") +SdkInfo=(Category="Windows", Description="Visual Studio 2017") +SdkInfo=(Category="Windows", Description="Visual C++ Toolchain 14.13.26128") +SdkInfo=(Category="Windows", Description="Windows SDK 10.0.16299.0") Similar entries for console platforms are added in console subdirectories. Each entry may contain an Install="Foo.exe" and/or Browse="C:\Foo" style attribute, specifying the path to an installer to run or directory to open in explorer respectively. The SdkInstallerDir setting is used as a base directory for the default installers, seen above for Android. Licensees may override this with a network path specific to the site that UGS is being deployed to (either in this file, in a project specific config file, or in a Engine/Programs/UnrealGameSync/NotForLicensees/UnrealGameSync.ini file). Change 4200452 by Ben.Marsh UBT: Change DebugGame configurations to output a separate executable rather than requiring a -Debug argument at runtime. Previous behavior was a common source of errors. Engine modules are still shared between Development and DebugGame, but the launch module sets a flag in Core on startup indicating the game configuration. Change 4206189 by Ben.Marsh UBT: Simplify logic for precompiling binaries. * Target no longer has separate list of "precompile only" binaries or modules. New -AllModules option allows adding every module to a target, which can be used with -Precompile and -NoLink to precompile object files for monolithic builds. * Precompiled file lists have been removed from target receipts. * The manifest now includes all generated headers and precompiled files when run with the -Precompile option. * Separate -DependencyList=Foo.txt has been added to write a list of all dependencies required to use precompiled binaries. This file list can be read using the <Tag> task in buildgraph. Change 4215466 by Ben.Marsh UBT: Remove indirect calls to determine extensions for object files and precompiled headers. The toolchain knows the correct convention for the platform. Change 4215975 by Ben.Marsh UBT: Remove telemetry code. This has never proved useful for analyzing performance due to the number of incidental factors that affect build times (eg. number of files being compiled). Change 4220154 by Ben.Marsh Move text-only implementations of FOutputDeviceError back into Core, so we can build command-line applications that don't depend on ApplicationCore. Change 4224708 by Ben.Marsh Add a bCompileAgainstApplicationCore setting to the target rules, which allows compiling out references to the ApplicationCore module (which should only be necessary for applications with a GUI). Removed ApplicationCore from several engine tools and utilities. Change 4224958 by Ben.Marsh Remove CoreMinimal.h includes from Core. Change 4229059 by Ben.Marsh UBT: Remove the UEBuildPlatform.ShouldNotBuildEditor() hook for target platforms. We shouldn't be modifying a target's build environment to disable the editor; it is invalid to build the editor for these target platforms at all, and this is already enforced by the GetSupportedPlatforms() function. Change 4230508 by Ben.Marsh Fixup precompiled header setting for samples and games. Change 4231457 by Ben.Marsh Fix exceptions in log messages having trailing newlines. Change 4232406 by Ben.Marsh UBT: Always force include a PCH for generated code if there's one set; the code may depend on it to compile. Change 4234177 by Ben.Marsh Set up private PCH files everywhere that previously used them. Change 4235973 by Ben.Marsh Change FPlatformMisc::GetEnvironmentVariable() to return an FString() rather than requiring a fixed size buffer to be passed in. Removes references to MAX_PATH. Change 4238842 by Ben.Marsh Add support for paths longer than MAX_PATH in the editor. Requires Windows 10 version 1607, and the functionality to be enabled via a registry key or group policy (see https://docs.microsoft.com/en-us/windows/desktop/FileIO/naming-a-file). Only a subset of Win32 functions support long paths (executables can only be started from paths shorter than MAX_PATH, for example). * Added a FPlatformMisc::GetMaxPathLength() function to return the maximum length of a path on the current system. On Windows, this returns a different value for systems with long paths enabled to those without. * The MAX_PATH define is no longer set by non-Windows platforms. Instead, there is a MAC_MAX_PATH, UNIX_MAX_PATH, etc... for any platform-specific code that still relies on the previous macro. * The MAX_UNREAL_FILENAME_LENGTH macro has been renamed to MAX_UNREAL_FILENAME_LENGTH_DEPRECATED * The PLATFORM_MAX_FILEPATH_LENGTH macro has been renamed to PLATFORM_MAX_FILEPATH_LENGTH_DEPRECATED. * Removed custom resource files for programs, since they are just copies of the base UE4 one (which is used by default anyway). The base UE4 manifest declares support for long paths. * Fix 512 character maximum length on editor commands. 260 character limit remains in place for cooking at the moment (see ContentBrowserUtils.h), until C# staging code supports long paths. Change 4255042 by Ben.Marsh UBT: Remote compilation now uploads the entire workspace to the remote Mac and executes a separate remote instance of UBT rather than synchronizing individual actions. This makes the remote compile codepath much simpler, and removes a lot of special cases that exist to support it previously. The list of files to be transferred to the remote are listed as rsync filter rules in Engine/Build/Rsync/RsyncEngine.txt and RsyncProject.txt, which are applied to the root engine directory and project directory respectively. Projects that need to customize which files are uploaded can add their own <ProjectDir>/Build/Rsync/RsyncProject.txt file, which will be included in the filter before the default version. Change 4260567 by Ben.Marsh UAT: Rename CommandUtils.Log to CommandUtils.LogInformation, to avoid conflicts with the underlying Tools.DotNETCommon.Log class. #rb none [CL 4285673 by Ben Marsh in Main branch]
2018-08-14 18:32:34 -04:00
int32 PlatformOrdinal;
private:
bool HasDefaultBuildSettings() const;
static bool DoProjectSettingsMatchDefault(const FString& InPlatformName, const FString& InSection, const TArray<FString>* InBoolKeys, const TArray<FString>* InIntKeys, const TArray<FString>* InStringKeys);
};
/**
* Template for target platforms.
*
* @param TPlatformProperties Type of platform properties.
*/
template<typename TPlatformProperties>
class TTargetPlatformBase
: public FTargetPlatformBase
{
public:
/**
* Returns true if the target platform will be able to be initialized with an FPlatformInfo. Because FPlatformInfo now comes from a .ini file,
* it's possible that the .dll exists, but the .ini does not (should be uncommon, but is necessary to be handled)
*/
static bool IsUsable()
{
return true;
}
/**
* Constructor that already has a TPI (notably coming from TNonDesktopTargetPlatform)
*/
TTargetPlatformBase(PlatformInfo::FTargetPlatformInfo* PremadePlatformInfo)
: FTargetPlatformBase(PremadePlatformInfo)
{
// HasEditorOnlyData and RequiresCookedData are mutually exclusive.
check(TPlatformProperties::HasEditorOnlyData() != TPlatformProperties::RequiresCookedData());
}
/**
* Constructor that makes a TPI based solely on TPlatformProperties
*/
TTargetPlatformBase()
: TTargetPlatformBase( new PlatformInfo::FTargetPlatformInfo(
TPlatformProperties::IniPlatformName(),
TPlatformProperties::HasEditorOnlyData() ? EBuildTargetType::Editor :
TPlatformProperties::IsServerOnly() ? EBuildTargetType::Server :
TPlatformProperties::IsClientOnly() ? EBuildTargetType::Client :
EBuildTargetType::Game,
TEXT(""))
)
{
}
public:
// ITargetPlatform interface
virtual bool HasEditorOnlyData() const override
{
return TPlatformProperties::HasEditorOnlyData();
}
virtual bool IsLittleEndian() const override
{
return TPlatformProperties::IsLittleEndian();
}
virtual bool IsServerOnly() const override
{
return TPlatformProperties::IsServerOnly();
}
virtual bool IsClientOnly() const override
{
return TPlatformProperties::IsClientOnly();
}
virtual FString PlatformName() const override
{
// we assume these match for DesktopPlatforms (NonDesktop doesn't return "FooClient", but Desktop does, for legacy reasons)
checkSlow(this->PlatformInfo->Name == TPlatformProperties::PlatformName());
return FString(TPlatformProperties::PlatformName());
}
virtual FString IniPlatformName() const override
{
return FString(TPlatformProperties::IniPlatformName());
}
virtual FString CookingDeviceProfileName() const override
{
// default to using TargetPlatform name, like WindowsClient, when looking up the DeviceProfile to cook with
return PlatformName();
}
virtual bool RequiresCookedData() const override
{
return TPlatformProperties::RequiresCookedData();
}
virtual bool HasSecurePackageFormat() const override
{
return TPlatformProperties::HasSecurePackageFormat();
}
virtual EPlatformAuthentication RequiresUserCredentials() const override
{
if (TPlatformProperties::RequiresUserCredentials())
{
return EPlatformAuthentication::Always;
}
else
{
return EPlatformAuthentication::Never;
}
}
virtual bool SupportsBuildTarget( EBuildTargetType TargetType ) const override
{
return TPlatformProperties::SupportsBuildTarget(TargetType);
}
virtual bool SupportsAutoSDK() const override
{
return TPlatformProperties::SupportsAutoSDK();
}
virtual bool SupportsFeature( ETargetPlatformFeatures Feature ) const override
{
switch (Feature)
{
case ETargetPlatformFeatures::AudioStreaming:
return TPlatformProperties::SupportsAudioStreaming();
case ETargetPlatformFeatures::DistanceFieldShadows:
return TPlatformProperties::SupportsDistanceFieldShadows();
Copying //UE4/Dev-Console to //UE4/Dev-Main (Source: //UE4/Dev-Console @ 4362408) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 4125165 by Ben.Woodhouse [INTEGRATE] Integrate from //UE4/Main/...@4124306 to //UE4/Dev-Console/... Change 4136060 by Marcin.Undak Editor: fixed device unclaiming #jira UE-58464 Change 4190321 by Marcin.Undak Linux: fixes for automation and RecordPerformance #jira UE-61053 Change 4199010 by Marcin.Undak Linux: remove unnecessary -g option Change 4201876 by Marcin.Undak First implementation of WebM media player for Windows and Linux Change 4201922 by Marcin.Undak Whitelisted WebMem plugin only for Windows and Linux Change 4202203 by Marcin.Undak WebM build fixes Change 4223102 by Marcin.Undak Vulkan: console commands for testing device lost #jira UE-61789 Change 4225028 by Marcin.Undak WebMMedia: disabled on Linux until fixed compilation issues Change 4231444 by David.Harvey UI - Fixing where the virtual cursor renders. It doesn't correctly take into account DPI scale, which isn't apparent except on the Xbox One. Integrate as edit from CL 4166648. #jira UE-62115 Change 4233057 by Marcin.Undak TestPAL: added new test for string allocation size Change 4234649 by Marcin.Undak Linux: switched linux plaform to 16bit wide strings Change 4235253 by Marcin.Undak TestPAL: compilation fix for platforms that don't use DirectoryWatcher Change 4235477 by Marcin.Undak Linux: re-enabled WebMMedia plugin Change 4242242 by Marcin.Undak WebMMediaPlayer: implemented proper format retrieving. MediaFrameworkTest now works. Change 4243321 by Marcin.Undak WebMPlayer: static code analisys fix Change 4243505 by Marcin.Undak MediaFrameworkTest: added WebM video for testing Change 4244646 by Marcin.Undak WebMMedia: improved concurrency Change 4244735 by Arciel.Rekman Vulkan: skip unnecessary transitions properly (UE-62348, merge). (Edigrating CL 4244274 from Release-4.20) Change 4246685 by Arciel.Rekman PhysX: remove Cygwin from %PATH% on Windows as it confuses CMake (UE-62326). Change 4247808 by Marcin.Undak WebMMediaPlayer: added support for seeking Change 4254841 by Marcin.Undak WebM: module dependencies fix Change 4255124 by laz.matech Updated UMG_AllPaletterWidgets' combo box to include options so that when selected, the dropdown presents 2 options instead of it appearing like it is broken #jira none Change 4256415 by Marcin.Undak WebM: added missing editor module Change 4256716 by Arciel.Rekman Make SetReuseAddr() also set SO_REUSEPORT where available (UE-57076). - Pull request #4617 by malavon. #jira UE-57076 Change 4266049 by Marcin.Undak Linux: UnrealLightmass and CrashReportClient compilation fixes #jira UE-62521 #jira UE-62522 Change 4266678 by Arciel.Rekman Merge speculative commit to get aligned pointer on mmap(). (Edigrating CL 4225330) Change 4267998 by Anthony.Bills Fix DBufferC clear color due to bad merge. #jira UE-62649 Change 4269441 by Marcin.Undak GenericPlatformStrings::VarArgs() implemented %-*s, %lu, %z, %h formatting #jira UE-62582 Change 4269712 by Marcin.Undak WebMMediaPlayer: removed LibSimpleWebM Change 4272849 by Marcin.Undak WebMMediaPlayer: fixed re-initialisation Change 4277931 by Arciel.Rekman Linux: switch to Vulkan by default (UE-62807). - Default behavior: attempt Vulkan first, but in case of failure instead of quitting silently fall back to GL, unless -vulkan is passed. - Forcing GL is still possible. Change 4277965 by Arciel.Rekman Fix standalone applications after the Vulkan switch. Change 4277968 by Arciel.Rekman Linux: make CrashReportClient headful (UE-14089). - The -unattended flags keep even a headful CRC usable on the servers. - ldd did not change. Need to check Localization stuff to see if there are any deployment concerns. #jira UE-14089 Change 4279402 by Arciel.Rekman Merge from 4.20.1: Vulkan: log validation errors. Also fix handling of some message types (UE-62628). (Edigrating 4273516 from //UE4/Release-4.20/... to //UE4/Dev-Console/...) Change 4279992 by Marcin.Undak Linux: fix SlateViewer compilation #jira UE-62831 Change 4285613 by Arciel.Rekman Vulkan: fix mismatched layout. - I tested with RecordPerformance on InfiltratorDemo and haven't found any impact. Change 4285622 by Arciel.Rekman Merged from 4.20.2: Linux: do not refuse to start if system limits cannot be raised (UE-62515). - Too aggressive behavior, which can break cooking for no valid reason. - If a commandline argument is used, the engine will still treat inability to raise the limits as an error. (Edigrating 4273547 from //UE4/Release-4.20/... to //UE4/Dev-Console/...) Change 4293083 by Arciel.Rekman Merging //UE4/Main@4291654 to //UE4/Dev-Console Change 4295297 by Marcin.Undak Vulkan: temporary disable generic pipeline cache saving to prevent crashes #jira UE-62848 Change 4300191 by Arciel.Rekman Delete files added under lowercase directories. Change 4300211 by Arciel.Rekman Re-add files deleted in previous commit under camel-cased paths. Change 4300895 by Arciel.Rekman Linux: fix editor build Change 4303543 by Ben.Marsh Fix compile error for FortGPUTestBed. Change 4305659 by Marcin.Undak [Vulkan][Engine] Update the Vulkan RHI to obey r.VSync (and the vsync and novsync command-line arguments). Change 4222769 by Jason.Stewart@Jason.Stewart_AMD_Dev_Rendering_threadripper-win10 on 2018/07/19 10:55:48 The original implementation ran into a latent thread hazard between the RHI thread and the rendering thread, where the rendering thread would try to use the backbuffer of the swap chain while the swap chain was being recreated (specifically after the swap chain recreation code had released and nulled out the back buffer, but before swap chain creation had actually happened to get a new back buffer). This implementation addresses that issue. This is Tim's code. I'm just submitting it as Tim is currently out of office. Change 4305661 by Marcin.Undak Moved libwebm and libvpx inside WebMMediaPlayer directory Change 4308659 by Marcin.Undak Linux: fixed LLDB visualizers #jira UE-52619 Change 4313650 by Marcin.Undak WebMMediaPlayer: implemented looping Change 4321713 by David.Harvey removed hard-coded platform labels from device output log window in favour of ITargetPlatform::SupportsFeature + updated editor tooltip with correct platform list. https://ec-01.epicgames.net/commander/link/jobDetails/jobs/8641984? Change 4321942 by Brandon.Schaefer Linux: Use the Target RHI list as the default ordering for which RHI is prefered Also update the RHI list in the project settings for our default list #jira UE-59487 #review-4316134 @Arciel.Rekman Change 4322230 by Brandon.Schaefer Treat %lf as %f in GenericWidePlatformString #jira UE-62582 Change 4322392 by Brandon.Schaefer Make sure our fmt size is large enough to check indexes #jira none Change 4322895 by Brandon.Schaefer Actually get the current size of Src as it could have been moved down #jira none Change 4327866 by Brandon.Schaefer Linux: Tell the platform misc what RHI we are using #jira none Change 4328926 by Brandon.Schaefer Linux: Add haptic support for controllers Github PR #4167 (thanks maiself!) #jira UE-51681 Change 4328963 by Arciel.Rekman TestPAL: improve the test by randomizing allocation size. - The range will no longer be constrained to <=128KB at once, allocations can be as big as 16MB but they will unevenly distributed, with smaller sizes being more frequent. Change 4329208 by Arciel.Rekman hlslcc: suppressed benign compiler warning during the Linux build (UE-43988). Change 4329283 by Arciel.Rekman Linux: replace CachedOSPageAllocator with PooledVirtualMemoryAllocator for Linux. For the explanation of FPooledVirtualMemoryAllocator, see PooledVirtualMemoryAllocator.h For the details, test data and comparisons, message Arciel Rekman. Relevant command line args added: -vmapoolscale=<float> (defaults to 1.4) -vmapoolevict -novmapoolevict By default, freed memory will not be evicted from RAM (unless running on a server) Also changed: - Removed the fixed-size pool previously used by Linux (and supporting machinery like scaling it on start) - Replaced the way we manage free blocks from pointers to a bitmap to reduce memory footprint. Change 4331946 by Luke.Thatcher [CONSOLE] [^] (merging CL 4162064) Implement new thread heart beat clock to solve the suspend/resume problem across all platforms. - The hang and hitch detectors now maintain their own clocks which are ticked by their respective threads. - If the title is suspended, the ticking thread will stop and the clock will stop advancing. On resume, the maximum delta in the clock is clamped to a small value, so we ignore all the time the thread was not ticking for (i.e. the duration of the title being suspended). - As such, we don't need any logic for handling PLM suspend/resume in the hang and hitch detectors, so this change removes that too. #jira FORT-96886 Change 4331973 by Luke.Thatcher [CONSOLE] [^] (merging CL 4183499) Add frame-present-based hang detection. - RHIs call FThreadHeartBeat::PresentFrame() whenever they present a frame to the swap chain. - These calls form a separate heartbeat from the thread-based ones, allowing the hang detector to fire if, for example, the game thread is stuck in an async loading loop and is ticking the game thread heartbeat, but making no progress. - Also refactored ThreadHeartBeat.cpp to move hang detection logging into a FORCENOINLINE function. This will put OnHang and OnPresentHang at the top of the callstack in retail crash dumps, making the bucketing easier to recognise. Change 4332200 by Luke.Thatcher [CONSOLE] [+] (merging CL 4227517) Add PlatformDebugData to FShaderResource. - We can use this to store platform specific shader symbols etc. The data gets serialized to the DDC and can be retrieved during a cook. - Data is entirely discarded in cooked builds, and is a no-op on platforms which don't implement support for shader debug data. - Bumped shader version to invalidate DDC keys. Change 4332407 by Luke.Thatcher [CONSOLE] [CORE] [!] (merging CL 4279686) Fixed unaligned integer load macro inconsistencies. - Renamed PLATFORM_SUPPORTS_UNALIGNED_INT_LOADS to PLATFORM_SUPPORTS_UNALIGNED_LOADS - Merged it with REQUIRES_ALIGNED_ACCESS and REQUIRES_ALIGNED_INT_ACCESS - Fixed Linux platform which had both the old macros defined to 1, which is wrong because they are mutually exclusive. Change 4333386 by Luke.Thatcher [CONSOLE] [!] (merging CL 4317367) Fix compile error in AnimationCompression.h Change 4334395 by Arciel.Rekman Corrected PLATFORM_DESKTOP definition. Change 4336190 by Anthony.Bills (Original CL4314280) Use the debug file writer when using framepro. This buffers more data which should reduce stalls when writing out on certain platforms. #jira none Change 4336291 by Anthony.Bills Use a clamped local clock when timing out the renderthread. - This prevents suspend and resume issues on platforms where suspend events may not occur or the system clock is not set to the process time. #jira none Change 4336292 by Anthony.Bills (Orignal CL 4195778) Fix printing of the hang detector multiplier and other logging. "f" is the correct format specifier for a double. #jira none Change 4336307 by Anthony.Bills (Orignal CL 4257875) Use the correct clock when printing the scoped hitch stat. - Needs to be the internal FGameThreadHitchHeartBeat clock incase FPlatformTime::Seconds becomes out of sync with FrameStartTime. #jira none Change 4336321 by Anthony.Bills (Original CL 4258186) Add GetNoInit function to FGameThreadHitchHeartBeat. #jira none Change 4336397 by Anthony.Bills Fix redefinition of macro. #jira none Change 4336738 by Brandon.Schaefer Linux: Add options for ASan, TSan, and UBSan #jira UE-62784 UE-62803 UE-62804 Change 4336791 by Brandon.Schaefer Linux: Add missing xml comments #jira none Change 4336957 by Joe.Barnes Integrate as edit CL#4218145: Convert some of our Vector macros to inline functions as thier names class with 3rd party functions. #jira ue-61733 Change 4338228 by Arciel.Rekman Switch to v12 Linux cross-toolchain (UE-63589). #jira UE-63589 Change 4339195 by Ben.Woodhouse Integrate-as-edit latest CSV profiler changes up to CL 4292187 Change 4339237 by Ben.Woodhouse Integrate-as-edit CL 4226269 Add support for extern GPU stats, so we can use one stat across multiple CPPs Fix the Forward rendering GPUProjection stat Change 4339239 by Ben.Woodhouse Integrate-as-edit CL 4292520 Support different sized buffers for FArchiveFileWriterGeneric per-platform so we can tune per-platform as needed. No changes to existing defaults values of 1KB for read, 4KB for write: #define PLATFORM_FILE_READER_BUFFER_SIZE 1024 #define PLATFORM_FILE_WRITER_BUFFER_SIZE 4096 #define PLATFORM_DEBUG_FILE_WRITER_BUFFER_SIZE 4096 Change 4339241 by Ben.Woodhouse Integrate-as-edit CL 4210462 Comment out an assert while I investigate properly (doesn't appear to be fatal) Change 4339265 by Anthony.Bills [Linux] Fix ContainerBuildThirdParty.sh to pick the first default interface. #jira none Change 4339274 by Anthony.Bills [Linux] Cache the bundled toolchain when using git builds. - Also will not attempt to download the toolchain if AutoSDK or Multiarch root are specified. #jira UE-63394 Change 4339623 by Anthony.Bills [Linux] Update native toolchain buildscript to support clang 6.0.1 - Main issue was due to libxml2 as an extra dependency of some test libraries, so needs to be disabled via DLLVM_ENABLE_LIBXML2. #jira UE-63588 Change 4339685 by Anthony.Bills [Linux] Update toolchain setup script to download v12 when it is available. #jira UE-63588 Change 4339833 by Ben.Woodhouse [INTEGRATE] Integrate from //UE4/Main/...@4339548 to //UE4/Dev-Console/... Change 4339843 by Ben.Woodhouse Attempt to fix a weird possible bad merge issue Change 4339890 by Ben.Woodhouse Fix a build issue #jira nojira Change 4340314 by Anthony.Bills Fix mesh decal rendering when write mask is enabled and no deferred decals are in the scene. #jira UE-55159 Change 4341099 by Marcin.Undak Mediashader fix #jira UE-63650 Change 4341106 by Marcin.Undak QAGame: added MediaPlayer for Linux test #jira UE-59667 #jira UE-62775 #jira UE-62780 Change 4341107 by Marcin.Undak WebMMediaPlayer: blacklist all not supported platforms #jira UE-59667 #jira UE-62775 #jira UE-62780 Change 4341110 by Marcin.Undak WebMMediaPlayer: enable for Unix platforms #jira UE-59667 #jira UE-62775 #jira UE-62780 Change 4341804 by Luke.Thatcher [CONSOLE] [!] Fix memory scribble in black depth texture cube on platforms with 16-bit depth. - Original code was writing a FColor into the locked texture data, which causes a 2 byte scribble if the PF_ShadowDepth format is 16-bits. [!] Also fixed GWhiteTextureCube being black. FColor::White is not a compile-time constant, so an initialization order problem meant the value of FColor::White is actually black when the GWhiteTextureCube constructor runs. #jira none Change 4342244 by Anthony.Bills [Linux] Allow restarting the crashed application from the crash report client #jira UE-62903 Change 4342636 by Brandon.Schaefer Linux: Update LLVM libc++.a libc++abi.a with version 6.0.1 #jira UE-63587 Change 4343420 by Marcin.Undak Fixed assert in console #jira UE-63643 Change 4345166 by Luke.Thatcher [CONSOLE] [!] (merging CL 4345072) Fix initialization order bug with FColor and FLinearColor constants. - The original constants were dynamically initialized during startup. Using these constants from other global constructors may result in getting the wrong value (transparent black) if a given constructor runs before FColor/FLinearColor's constructor. - Adding constexpr to the FColor/FLinearColor constructor makes these constants known at compile-time, and included in the readonly data section, so they don't require dynamic initialization. [~] Also restores the original constant color values in RenderUtils.cpp #jira none Change 4345860 by Arciel.Rekman Make StompMalloc return 16-byte aligned memory on 64 bit platforms (UE-63743). #jira UE-63743 (Edigrating 4345734 from Release-4.20) Change 4345950 by Brandon.Schaefer Linux: Remove libelf/libdwarf fallback for symbolicating symbols during a crash #jira UE-63103 Change 4350249 by David.Harvey helper function to retrieve an LLM tag's name, including platform tags. Change 4351184 by Ben.Woodhouse [INTEGRATE] Integrate from //UE4/Main/...@4348973 to //UE4/Dev-Console/... Change 4351593 by Ben.Woodhouse Clean up aggressive batching (remove xbox specific #if and //TODO) #jira UE-46780 Change 4351734 by James.Cobbett Setting TM-ShaderModels_Niagara to always load Change 4351984 by Marcin.Undak QAGame: restored platform media source in TM-ShaderModels map Change 4353508 by Ben.Woodhouse [INTEGRATE] Integrate from //UE4/Main/...@4353110 to //UE4/Dev-Console/... Change 4354237 by Anthony.Bills [Linux] Fix Linux compilation issues due to change over to TCHAR being char16_t. #jira UE-63544 Change 4354334 by Anthony.Bills [Linux] (Missing file from CL 4354237) Fix Linux compilation issues due to change over to TCHAR being char16_t. #jira UE-63544 Change 4355994 by Brandon.Schaefer Linux: Agree not Agreed #jira UE-63937 Change 4356068 by Joe.Barnes Replace a duplicate DEFINE_EXPRESSION_NODE_TYPE(bool,...) causing errors with iOS unity build compiles. Remove version in ExpressionParser.cpp and include TextFilterExpressionEvaluator.h. #jira ue-63877 Change 4357726 by David.Harvey [iOS] add clean support for device output log, after catchup. #jira none Change 4357724 by Ben.Woodhouse [INTEGRATE] Integrate from //UE4/Main/...@4357176 to //UE4/Dev-Console/... Change 4359634 by Ben.Woodhouse [INTEGRATE] Integrate from //UE4/Main/...@4359072 to //UE4/Dev-Console/... Change 4359958 by Ben.Woodhouse Fix FortGPUTestbed merge issues via p4 copy (content files didn't get moved before for some reason) Change 4361108 by Anthony.Bills Fix webm deprecation issues with DrawPrimitiveUp. #jira UE-64012 Change 4361896 by James.Cobbett Re-saving materials so that they render correctly outside of the editor. Change 4362262 by Anthony.Bills Fix for WebM video decoder crash. #jira UE-64025 [CL 4362700 by Joe Barnes in Main branch]
2018-09-12 15:59:49 -04:00
case ETargetPlatformFeatures::DistanceFieldAO:
return TPlatformProperties::SupportsDistanceFieldAO();
case ETargetPlatformFeatures::GrayscaleSRGB:
return TPlatformProperties::SupportsGrayscaleSRGB();
case ETargetPlatformFeatures::HighQualityLightmaps:
return TPlatformProperties::SupportsHighQualityLightmaps();
case ETargetPlatformFeatures::LowQualityLightmaps:
return TPlatformProperties::SupportsLowQualityLightmaps();
case ETargetPlatformFeatures::MultipleGameInstances:
return TPlatformProperties::SupportsMultipleGameInstances();
case ETargetPlatformFeatures::Packaging:
return false;
case ETargetPlatformFeatures::TextureStreaming:
return TPlatformProperties::SupportsTextureStreaming();
case ETargetPlatformFeatures::MeshLODStreaming:
return TPlatformProperties::SupportsMeshLODStreaming();
case ETargetPlatformFeatures::LandscapeMeshLODStreaming:
return false;
case ETargetPlatformFeatures::MemoryMappedFiles:
return TPlatformProperties::SupportsMemoryMappedFiles();
case ETargetPlatformFeatures::MemoryMappedAudio:
return TPlatformProperties::SupportsMemoryMappedAudio();
case ETargetPlatformFeatures::MemoryMappedAnimation:
return TPlatformProperties::SupportsMemoryMappedAnimation();
case ETargetPlatformFeatures::VirtualTextureStreaming:
return TPlatformProperties::SupportsVirtualTextureStreaming();
case ETargetPlatformFeatures::SdkConnectDisconnect:
case ETargetPlatformFeatures::UserCredentials:
break;
Copying //UE4/Dev-Mobile to //UE4/Dev-Main (Source: //UE4/Dev-Mobile @ 3010693) #lockdown nick.penwarden #rb none ========================== MAJOR FEATURES + CHANGES ========================== Change 2958982 on 2016/04/28 by Dmitriy.Dyomin Set owner name for RHI texture, for easier debugging Change 2976446 on 2016/05/12 by Niklas.Smedberg Fixed Device Profile CVars so they work even if a DLL with the cvar definition is loaded afterwards. (And they now also go through the common code path for CVars.) Change 2983781 on 2016/05/19 by Steve.Cano Check in PlayUsingLauncher if the device we're launching to is authorized by the computer. Could not get to this information about Devices so added an IsAuthorized interface to ITargetDevice that is overriden in the AndroidTargetDevice. Also make sure to referesh the authorized state as needed for Android device detection. Finally, changed the name of the authorized variable to be more readable (true == authorized instead of true == unauthorized) #jira UE-21121 #ue4 #android Change 2994202 on 2016/05/31 by Allan.Bentham Prevent clear transulcency volume null deref crash. Change test for allocated deferred render targets by testing against an exclusively deferred target (instead of potentially shared shadow depth surface) probable fix for UE-22073 Change 2995613 on 2016/05/31 by Dmitriy.Dyomin Added: Option to force full precision in a material UEMOB-109 Change 2997960 on 2016/06/02 by Gareth.Martin Refactored Landscape serialization to allow cooking both the data used for normal rendering and mobile rendering into the same package #jira UE-31474 Change 2997988 on 2016/06/02 by Gareth.Martin Files missing from CL 2997960 #jira UE-31474 Change 2999222 on 2016/06/03 by Jack.Porter Fix up ETargetPlatformFeatures::ForwardRendering and ETargetPlatformFeatures::DeferredRendering for iOS to support the Metal MRT deferred renderer Change 2999229 on 2016/06/03 by Jack.Porter Rename ETargetPlatformFeatures::ForwardRendering to TargetPlatformFeatures::MobileRendering Change 3003540 on 2016/06/07 by Jack.Porter Merging //UE4/Dev-Main to Dev-Mobile (//UE4/Dev-Mobile) Change 3003779 on 2016/06/07 by Dmitriy.Dyomin Fixed: Criss-crossed sublevels cause NavMesh errors #jira UE-27157 Change 3004535 on 2016/06/07 by Steve.Cano Adding the OnControllerConnectionChange delegate message when a controller is connected on Android. Also added additional future broadcast statement when disconnect support is added for Android. #jira UE-25697 #ue4 #android Change 3005205 on 2016/06/07 by Niklas.Smedberg Bumped ASTC format version to invalidate bad server DDC Change 3005347 on 2016/06/08 by Dmitriy.Dyomin Added a way to cache OpenGL program binaries on the disk. Disabled by default. Can be enabled only on Android platform (r.UseProgramBinaryCache=1) #jira UEMOB-108 Change 3005524 on 2016/06/08 by Dmitriy.Dyomin Fixed iOS build broken by CL# 3005347 Change 3005528 on 2016/06/08 by Jack.Porter Changed hardcoded checkboxes from quality level overrides dialog to use the general property details code. Now magically supports any uproperty types such as enums or integers added to FMaterialQualityOverrides. Change 3005607 on 2016/06/08 by Dmitriy.Dyomin Fixed: Occasional crash on using Launch on Android device when device is being disconnected Change 3006705 on 2016/06/08 by Chris.Babcock Fix virtual joystick to return -1 to 1 ranges for thumbsticks #jira UE-31799 #ue4 #android #ios Change 3006960 on 2016/06/08 by Jack.Porter Merging //UE4/Dev-Main to Dev-Mobile (//UE4/Dev-Mobile) Change 3007050 on 2016/06/09 by Jack.Porter FAutomationWorkerModule::ReportTestComplete() needs to send analytics first as the message endpoint will free the memory resulting in a crash Change 3007129 on 2016/06/09 by Dmitriy.Dyomin Fixed: Black edges seen on flames in Sun Temple #jira UE-31712 Change 3010686 on 2016/06/13 by Dmitriy.Dyomin Fixed: Android Monolithic warnings for glGetProgramBinaryOES and glProgramBinaryOES #jira UE-31933 [CL 3011074 by Jack Porter in Main branch]
2016-06-13 12:20:22 -04:00
case ETargetPlatformFeatures::MobileRendering:
return false;
case ETargetPlatformFeatures::DeferredRendering:
return true;
Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3271386) #lockdown Nick.Penwarden Change 3270776 on 2017/01/24 by Laurent.Delayen Fixed missing call to CacheBones in AnimNode_SubInstance. Fixes Mudang crash. #c0der3view benn.ghallager, lina.halper #tests does not crash #rb none Change 3270483 on 2017/01/24 by Shaun.Kime Removing the ensure and making it behave safely whenever the scene count is out of sync. Since Paragon isn't using the primary driving feature of MaterialParameterCollections in the UI that required this feature, Nick Darnell and I deemed this okay. #jira OR-34919 #rb nick.darnell #tests PIE and golden path Change 3270067 on 2017/01/24 by Laurent.Delayen Fixed crash when recompiling Mudang's AnimBP. (SubInstances array holding null references) #rb benn.ghallager #tests doesn not crash Change 3269760 on 2017/01/24 by Daniel.Lamb Added more files to inisettings blacklist. #rb Trivial #test cook paragon. Change 3269578 on 2017/01/24 by jason.bestimt #ORION_MAIN - Merge 37.2 @ CL 3269468 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3269570 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) #R0BOMERGE-SAYS: Unresolved conflicts. jason.bestimt, please merge this change by hand. //R0BOMERGE_ORION_Dev_General/OrionGame/Content/Characters/Heroes/Grux/Abilities/Stampede/GA_Grux_Stampede.uasset //R0BOMERGE_ORION_Dev_General/OrionGame/Content/Characters/Heroes/Ice/Icons/Minimap_char_portrait_Ice.uasset //R0BOMERGE_ORION_Dev_General/OrionGame/Content/Characters/Heroes/Ice/Icons/PORT_Ice.uasset #c0der3view: jason.bestimt Change 3269141 on 2017/01/23 by Mieszko.Zielinski TSimpleCellGrid::InvalidCell refactor to avoid it being a static member variable #UE4 #rb Lukasz.Furman #test golden path Change 3268953 on 2017/01/23 by Jason.Bestimt #ORION_DG - R0BOMERGE resolution from MAIN to DG of compile fix and banner stuff #RB:none #Tests:none #c0der3view: matt.schembari, andrew.grant Change 3268576 on 2017/01/23 by John.Pollard Add DemoNetDriver to the level collection earlier to remove small window where World->DemoNetDriver could be null as a result of FScopedLevelCollectionContextSwitch #rb RyanG #tests Live game play + replays + instant replay Change 3268119 on 2017/01/23 by Daniel.Lamb Added support for splitting up chunks into maximum sizes. #rb Andrew.Grant #test Cook paragon ps4 windows windowserver Change 3268020 on 2017/01/23 by Dan.Hertzka Moving TreeFilterHandler.h out into Slate/Public via branch & delete #c0der3view Nick.Darnell #rb none #tests compile Change 3267820 on 2017/01/23 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 37.2 @ CL 3267733 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3267817 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3266798 on 2017/01/20 by Daniel.Lamb Make the diff files commandlet more helpful. #rb Trivial #test Diff files commandlet. Change 3266795 on 2017/01/20 by Daniel.Lamb Fixed issue with Cooked packages trying to load dependencies from a dependency offset which is incorrect. #rb Gil.Gribb #c0der3view Gil.Gribb #test Load cooked packages using the editor. Change 3266310 on 2017/01/20 by Daniel.Lamb Fixed issue with cook ont he fly not resolving string asset reference redirectors on load. Added fastcook to the iterative cook detection. #rb Jamie.Dale #test Cook Paragon Change 3265879 on 2017/01/20 by Jon.Lietz fixing PS4 compile error #rb none #tests compiles #c0der3view andrew.grant Change 3265756 on 2017/01/20 by Jon.Lietz quest evaluator - added in an ability type that will evaluate in game events and increments player stats for quests, these abilities can be granted by quests or the hero data - added support to the ability system to have ability specs not replicated to the client, this will allow for passive only abillities for quest evaluation to only live and exicute on the dedicated server - now support loading in data for quest info asynchronously - orion quests can now grant evaluator abilities to the players that own the quests - AOrionPlayerState_Game::GiveAbilityData() now grabs all the abilities from active quests - at the end of the match unload any data loaded by the quests #RB david.ratti #test granting abilities Change 3265658 on 2017/01/20 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 37 @ CL 3265610 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3265627 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3265530 on 2017/01/20 by Robert.Manuszewski Making sure all package dependencies are loaded before post loading its objects #jira OR-34891 #tests Golden path x 12 #rb none Change 3265126 on 2017/01/19 by Frank.Gigliotti Notifies for abilities waiting on input confirmation; * Ability tasks waiting for input confirmation will now notify the ability when it begins and ends waiting. #RB Dave.Ratti #Tests PIE Change 3264489 on 2017/01/19 by Jason.Bestimt #R0BOMERGE-AUTHOR: andrew.grant Merged fix from 36.2. #rb #tests na #R0BOMERGE-SOURCE: CL 3264488 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3263948 on 2017/01/19 by Andrew.Grant Non-unity fixes. #tests compiled WIn64 editor #rb na #R0BOMERGE: Main, 37 Change 3263755 on 2017/01/19 by Laurent.Delayen OR-34970 FRootMotionSource_ConstantForce now has DisablePartialEndTick set, so we end up with a consistent velocity when the root motion ends. Added VelocityOnFinishMode to UAbilityTask_ApplyRootMotionConstantForce so we can optionally override or clamp velocity. CVarDebugRootMotionSources now displays Velocity and LastPreAdditiveVelocity on HUD to help debugging RootMotionSources. #rb frank.gigliotti #tests Ice Q Change 3263616 on 2017/01/19 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 37 @ CL 3263608 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3263613 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3262543 on 2017/01/18 by Eric.Newman Added GetAttributeSetValues feature to Ability System. Allows for pulling attribute rows without needing an Actor or AbilitySystemComponent #rb david.ratti #c0der3view david.ratti #tests used to export paragon hero attributes #jira TON-25429 Change 3262414 on 2017/01/18 by Laurent.Delayen Fixed crash opening up Ice's AnimBP. #rb lina.halper #c0der3view thomas.sarkanen #tests opening up AnimBP doesn't crash anymore. Change 3262291 on 2017/01/18 by Ryan.Gerleve Cache the network role of AbilitySystemComponents in PreNetReceive, to make sure the role is correct during serialization if properties are received before BeginPlay. Factor out the caching into its own function to reduce code duplication. #rb david.ratti #tests golden path, bug repro #jira OR-31424 Change 3262062 on 2017/01/18 by Max.Chen Sequencer: Fixed crash caused by lingering persistent evaluation data Copy from Release-4.15 #jira UE-40775 #rb andrew.rodham #tests none Change 3262061 on 2017/01/18 by Max.Chen Sequencer: Evaluation templates are now only fully rebuilt in PIE, and will not re-cycle track identifiers - This addresses issues with newly compiled tracks recycling the persistent data of old stale tracks. - This commit also ensures we don't fully rebuild templates in the editor when in Sequencer Copy from Release-4.15 #jira UE-40775 #rb andrew.rodham #tests none Change 3261946 on 2017/01/18 by Jason.Bestimt #ORION_DG - Fix for event tracks in sequencer #RB:none #Tests:none #R0BOMERGE: MAIN #c0der3view: Max.Chen, andrew.rodham, scott.james Change 3261812 on 2017/01/18 by Mieszko.Zielinski Made bos' perception component vlog information #Orion #rb Lukasz.Furman #test golden path Change 3261731 on 2017/01/18 by Benn.Gallagher Readded fix to clothing index buffer overflow (lost in merge a while back) #tests Editor, assigned clothing to skel mesh #rb Tom.Sarkanen Change 3261730 on 2017/01/18 by Robert.Manuszewski Build script sdk upgrade #rb none #tests Ran the script that was upgraded Change 3261392 on 2017/01/17 by Jason.Bestimt #R0BOMERGE-AUTHOR: andrew.grant non-unity fix #rb none #tests compiled #R0BOMERGE-SOURCE: CL 3261391 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3261096 on 2017/01/17 by Laurent.Delayen OR-33666 Removed 'bImpartsVelocityOnRemoval' for additive root motion sources, as that can create a 'bouncing' effect when Velocity is modified externally. #rb frank.gigliotti #tests Preflight QA test https://jira.it.epicgames.net/browse/PQATC-8713 Change 3261030 on 2017/01/17 by Laurent.Delayen Fix crash in Persona. #rb none #tests doesn't crash Change 3260561 on 2017/01/17 by Jason.Bestimt #R0BOMERGE-AUTHOR: andrew.grant Merging Fix from UE 4.15 Look at the body instance's desired collision enabled value rather than the primitive component's current collision enabled value when determining whether physics state should be created #rb Ori.Cohen #jira UE-39994 #tests na #R0BOMERGE-SOURCE: CL 3260557 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3260553 on 2017/01/17 by Ryan.Gerleve Change cvar in UDemoNetDriver::ShouldSaveCheckpoint to use GetValueOnAnyThread. Fixes OR-34759. #rb john.pollard #tests bug repro, golden path Change 3260202 on 2017/01/17 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 37/36.2 @ CL 3260077 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3260201 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3259560 on 2017/01/16 by Marcus.Wassmer Fix reflections #rb none #c0der3view Brian.Karis #tests added some reflections Change 3259348 on 2017/01/16 by Daniel.Lamb Moved automation maps from alwayscookmaps to AllAutomationMaps. #rb Andrew.Grant #test Cook Paragon + Fast Cook Paragon + Preflight Cook Paragon Change 3259113 on 2017/01/16 by Jason.Bestimt #R0BOMERGE-AUTHOR: andrew.grant #ORION_MAIN - Merge 36.2 @ CL 3258788 #RB:none #Tests:compiled Win64 editor #R0BOMERGE-SOURCE: CL 3258986 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3259090 on 2017/01/16 by Chris.Bunner Duplicating CL 3246830: Allow AllocGBuffer call when in simple-forward so dummy uniform buffer creation can occur. #rb None #tests Editor, -game, epic and min settings Change 3258910 on 2017/01/16 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - DAILY DG @ CL 3258854 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3258871 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3258807 on 2017/01/16 by Rolando.Caloca O - Fix for outlines #rb Chris.Bunner #tests Ran sovereign2 game #c0der3view Andrew.Grant Change 3258637 on 2017/01/16 by Charles.Anderson Removing wrongly added files (agrant) Change 3258601 on 2017/01/16 by Andrew.Grant Temp fix for rendering crash by disabling custom depth rendering #rb na #tests PIE'd Change 3258590 on 2017/01/16 by Tom.Wright One of these files are not syncing properly in my UnrealGameSync so I'm adding them manually (the .exe). Change 3258523 on 2017/01/16 by Andrew.Grant Removing intermediate build file that was checked in #rb #tests na Change 3258464 on 2017/01/16 by Andrew.Grant Fixes for non-unity #R0BOMERGE: Main #tests compiled Win64 #rb na Change 3258208 on 2017/01/15 by Mieszko.Zielinski FMetaNavMeshPath's Waypoints have been expanded to store user flags. #UE4 #rb none #test golden path Change 3258042 on 2017/01/14 by andrew.grant Merging test framework changes from //Orion/Release-36.2 to Main (//Orion/Main) #rb #tests preflighted #R0BOMERGE-SOURCE: CL 3258036 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) #R0BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human. //R0BOMERGE_ORION_Dev_General/OrionGame/Build/OrionBuild.xml #c0der3view: andrew.grant, jason.bestimt Change 3258035 on 2017/01/14 by Andrew.Grant Disable MfMedia plugin by default Change 3257936 on 2017/01/14 by Andrew.Grant Merging from //UE4/Main @ 3253977 through Orion-Staging #rb na #tests QA smoke in staging, built locally, preflighted Change 3257583 on 2017/01/13 by Daniel.Lamb Removed nomcp from the commandline when running on PC #rb Trivial #test Buildcookrun paragon windows Change 3257320 on 2017/01/13 by Cody.Haskell #Orion - Ansel Integration into Replay Mode - Updated Ansel SDK - Bug Fix for Ansel plugin - Made it not look terrible when you pause the game in regular replay mode #rb Andrew #r3view-3256093 @andrew.grant #tests Golden Path, compiles on PS4 #lockdown Andrew.Grant Change 3257239 on 2017/01/13 by Frank.Gigliotti ApplyRootMotionJumpForce end velocity options; * "ApplyRootMotionJumpForce" task now supports setting the end velocity. * Moved root motion end velocity options from the individual tasks into the base class. * Fixed a property on UAbilityTask_ApplyRootMotionConstantForce not replicating properly. #RB None #Tests PIE Change 3256173 on 2017/01/12 by Laurent.Delayen Added additional debug message to ShowResaveMessage. #rb lina.halper #test loaded broken Femme assets. Change 3256082 on 2017/01/12 by Andrew.Grant Temp fix for BuildHealth warning. Following up with BP team #rb none #tests verifierd compile warnings are gone Change 3255991 on 2017/01/12 by Ben.Woodhouse Cherry pick NV gpu hang fix from //ue4/release-4.14 @3238182 Disable timestamp queries on pre-Maxwell nvidia hardware. Local testing suggests that this is the major cause of instability in the UE4.14 release. It's possible that we could be more targeted by only excluding Fermi and older hardware, but identifying fermi hardware by device ID is difficult in practice, since the range overlaps with Kepler. #jira OR-22580 #rb none (r3viewed for 4.14 by Marcus Wassmer) #tests run locally on PC (change is windows-specific) Change 3255185 on 2017/01/12 by John.Nielson Made it so that PS4 compiles without warning from misordered initialization. #RB: r3view #r3view-3255186: Andrew.Grant #Test: None Change 3254885 on 2017/01/11 by Michael.Trepka CIS fix #rb none #tests none Change 3254568 on 2017/01/11 by Andrew.Grant Merging relay fix from //Orion/Release-36.2 to Dev-General (//Orion/Dev-General) #rb #tests na Change 3254544 on 2017/01/11 by Jason.Bestimt #R0BOMERGE-AUTHOR: andrew.grant Robomerging previous fix to Dev-Gen #rb #tests na #R0BOMERGE-SOURCE: CL 3254532 in //Orion/Release-36.1/... via CL 3254537 via CL 3254540 #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3254204 on 2017/01/11 by Michael.Trepka Added title bar area to the game layer manager, so that games can easily setup custom title bar content when using borderless windows. Disabled/hidden by default #rb none #tests Tested in editor build on PC Change 3254074 on 2017/01/11 by Ryan.Gerleve Fix for gameplay tags not being recorded in client replays. #rb david.ratti #tests golden path, replays Change 3254035 on 2017/01/11 by Laurent.Delayen OR-28756 Added WaitForMovementInput Ability Task to use with Emote ability. #rb dave.ratti, frank.gigliotti #tests Kallari's emotes Change 3253736 on 2017/01/11 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 36.2 @ CL 3253668 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3253715 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3252981 on 2017/01/10 by Daniel.Lamb Added async load package delegate. #rb Trivial #test BuildCookRun Paragon with local server Change 3252975 on 2017/01/10 by Daniel.Lamb Added EditorPerProjectUserSettings to the ignore config field for iterative cooking #rb None #test cook paragon. Change 3252784 on 2017/01/10 by Daniel.Lamb Integrated fix for rebuild lighting commandlet from Greg Korman @ Impulse Gear. #rb Daniel.Lamb #test Rebuild lighting Paragon Change 3252460 on 2017/01/10 by Aaron.Eady #jira UE-40390 Fix crash saving blueprint with an inherited DataTable/CurveTable reference. Delta serialization meant that the necessary name wasn't in the name table, so adding it manually now. #rb robert.manuszewski Copied from CL #3252418 Written by Ben.Zeigler #c0der3view Ben.Zeigler, David.Ratti, Andrew.Grant #tests PIE Change 3252222 on 2017/01/10 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 36.2 @ CL 3252019 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3252221 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3251379 on 2017/01/09 by Ori.Cohen Fix build #rb none #tests none Change 3251242 on 2017/01/09 by buildmachine BuildPhysX.Automation: Deploying PhysX & APEX Win64 libs. #rb none #lockdown Nick.Penwarden #tests none Change 3251240 on 2017/01/09 by buildmachine BuildPhysX.Automation: Deploying PhysX & APEX Win32 libs. #rb none #lockdown Nick.Penwarden #tests none Change 3251224 on 2017/01/09 by buildmachine BuildPhysX.Automation: Deploying PhysX & APEX Linux_x86_64-unknown-linux-gnu libs. #rb none #lockdown Nick.Penwarden #tests none Change 3251220 on 2017/01/09 by buildmachine BuildPhysX.Automation: Deploying PhysX & APEX PS4 libs. #rb none #lockdown Nick.Penwarden #tests none Change 3251206 on 2017/01/09 by Ori.Cohen Add logging to possible physx infinite loop. #JIRA OR-32515 #rb Dave.Ratti #tests none Change 3250847 on 2017/01/09 by Daniel.Lamb Added excution time stat to unrealpak. #rb Trivial #test BuildCookRun Paragon with timing info. Change 3250761 on 2017/01/09 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 36.2 @ CL 3250717 #RB: none #Tests:none #R0BOMERGE-SOURCE: CL 3250759 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3249410 on 2017/01/06 by Chris.Bunner Duplicating CL 3249213: Fixed up logic for windowed/fullscreen output display selection when working with HDR. Now selects the most appropriate display if HDR enabled, else current monitor window is on. FullscreenDisplay commandline functions regardless of HDR support. #rb None #tests -game windowed/fullscreen behavior Change 3249285 on 2017/01/06 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 36.2 @ CL 3249117 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3249278 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3247989 on 2017/01/05 by Dan.Hertzka Re-adding the null checks from CL 3247771 in Release-36 (the R0BOMERGEd submit didn't include these for some reason) #c0der3view Andrew.Grant #rb none #tests Compiled and didn't crash on editor startup #R0BOMERGE: Main Change 3247790 on 2017/01/05 by Jason.Bestimt #R0BOMERGE-AUTHOR: andrew.grant Robomerging! #tests #rb na #R0BOMERGE-SOURCE: CL 3247786 in //Orion/Release-36/... via CL 3247787 via CL 3247788 via CL 3247789 #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3247717 on 2017/01/05 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 36.2 @ CL 3247673 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3247716 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3247575 on 2017/01/05 by David.Ratti -Fix crash if GE has a null linked target GE -Change FGameplayEFfectContext::Ability to be AbilityCDO via TWeakObjectPtr rather than a TSubclass. TSubclass is not weak, so if a class was GC'd while still in a GEEC somewhere, it could crash. #rb none #tests pie Change 3247032 on 2017/01/04 by Ori.Cohen Touch engine file to re-link physx libs #JIRA OR-32839 #rb none #tests none Change 3247006 on 2017/01/04 by buildmachine BuildPhysX.Automation: Deploying PhysX & APEX PS4 libs. #rb none #lockdown Nick.Penwarden #tests none Change 3246987 on 2017/01/04 by Ori.Cohen Add newline for ps4 #rb none #tests none Change 3246986 on 2017/01/04 by buildmachine BuildPhysX.Automation: Deploying PhysX & APEX Win64 libs. #rb none #lockdown Nick.Penwarden #tests none Change 3246981 on 2017/01/04 by buildmachine BuildPhysX.Automation: Deploying PhysX & APEX Linux_x86_64-unknown-linux-gnu libs. #rb none #lockdown Nick.Penwarden #tests none Change 3246969 on 2017/01/04 by buildmachine BuildPhysX.Automation: Deploying PhysX & APEX Win32 libs. #rb none #lockdown Nick.Penwarden #tests none Change 3246921 on 2017/01/04 by Ori.Cohen Fix automation to include #tests none #rb none #tests none Change 3246900 on 2017/01/04 by Ori.Cohen Fix newline issues for ps4. #rb none #tests none Change 3246666 on 2017/01/04 by Chad.Garyet Updating physx build to include switch and linux-arm64 integrate/resolve from dev-physics-upgrade #c0der3view ori.cohen Change 3246450 on 2017/01/04 by Arciel.Rekman Fix for sweeps taking too long time (OR-32839). - Exhaustive investigation uncovered apparent numerical problems in this code (when compiling with clang 3.9.x with -ffast-math). - Current solution can result in overshoot for certain trace extents, but they are not expected to be a practical problem in Unreal. - NVidia is aware and will investigate a better solution. #rb Ori.Cohen #c0der3view Ori.Cohen #tests Compiled Linux server with the changed PhysX and continuously ran bot matches for about a day. Change 3246229 on 2017/01/04 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 36.2 @ CL 3246134 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3246204 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3245068 on 2017/01/03 by Lukasz.Furman improving obstacle grid avoidance: adjusting start location when inside obstacle, fixes for string pulling #jira OR-33318 #rb none #c0der3view Mieszko.Zielinski #tests PIE Change 3244698 on 2017/01/03 by Lukasz.Furman compilation fix: removed optimization pragmas from AISense_Sight.cpp #rb none #tests none Change 3244679 on 2017/01/03 by David.Ratti Unify linked gameplay effect spec creation: -Linked GEs -Conditional Execution GEs -Overflow GEs -Expiration GEs (premature/routine) These now create the dependant GE Spec the same way, by duplicating the original context and copying spec tags, MINUS the original GE's asset tags. Actor tags are still recaptured at the moment the spec is created. #rb Lietz #tests golden path #c0der3view Billy.Bramer, Fred.Kimberley Change 3244499 on 2017/01/02 by Mieszko.Zielinski Major AI tactics upgrade #Orion Introduction of new objective dealing algorithm (CSP inspired) Bots can now place wards Bots can now destroy wards and other appopriately marked up OrionDamagableActors (content change in following CL, allows bots to see these actors) Switched OrionAIBot.CurrentEnemy to AActor type Removed code related to Jungle Rig objectives #rb none #test golden path Change 3242918 on 2016/12/22 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 36.2 @ CL 3242890 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3242917 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3241817 on 2016/12/21 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 36.2 @ CL 3241745 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3241811 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3240916 on 2016/12/20 by Ben.Marsh Add metadata properties to jobs that create promotable artifacts and execute promotions, for consumption by the pipeline tool. Properties are added to /job[XXX]/Pipeline/Promotable-<Platform>-<Type> or /Promotion-<Platform>-<Type>. #rb none #c0der3view David.Vossel, Trevor.Pounds #tests Ran through preflight Change 3240857 on 2016/12/20 by Lina.Halper Added ensure to track marker sync crash #rb: Laurent.Delayen #code r3view: Martin.Wilson #tests: PIE with mudangs Change 3240856 on 2016/12/20 by Laurent.Delayen Potential fix for sync marker crash. #rb lina.halper #c0der3view martin.wilson, lina.halper #tests Mudang Change 3240813 on 2016/12/20 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 36.2 @ CL 3240768 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3240812 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3239624 on 2016/12/19 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 36.2 @ CL 3239590 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3239623 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3238573 on 2016/12/16 by Andrew.Grant Moved console vars to source file to avoid multiple definitions (OR-33470) #rb none #tests compiled Change 3238077 on 2016/12/16 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 36 @ CL 3238017 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3238059 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3237176 on 2016/12/15 by Laurent.Delayen Moved FloatRK4SpringInterpolator and VectorRK4Interpolator from Orion to Engine. #rb ori.cohen #c0der3view lina.halper, james.golding #tests Twinblast and Ice Change 3236911 on 2016/12/15 by Lukasz.Furman changed navgrid projection to use 2D poly search for more accurate results #orion #rb none #tests PIE Change 3236660 on 2016/12/15 by Jamie.Dale Updating Orion text block to upper-case its text in a localized way This also prevents it clobbering the text property value with the transformed text, resulting in key stability issues. #jira OR-32716 #rb Dan.Hertzka #tests Ran Orion and verified that the "all caps" text was correct, and responded to live-culture changes #R0BOMERGE: Main, Release-36 Change 3236658 on 2016/12/15 by Jamie.Dale Adding FText::ToLower and FText::ToUpper These also track history and rebuild when the text they were generated from is changed. #jira OR-32716 #rb Dan.Hertzka #tests Ran Orion and verified that the "all caps" text was correct, and responded to live-culture changes #R0BOMERGE: Main, Release-36 Change 3236501 on 2016/12/15 by Lukasz.Furman enabled navigation grid avoidance for jungle minions #jira OR-33318 #rb Mieszko.Zielinski #tests PIE Change 3236479 on 2016/12/15 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 36 @ CL 3236423 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3236474 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3236399 on 2016/12/15 by Andrew.Grant Fixed pkg warning "Patch created by newer SDK must contain sce_module files" by not excluding "libSceNpToolkit.prx" #rb none #tests none #R0BOMERGE: Main,36 Change 3236280 on 2016/12/15 by Benn.Gallagher Fixed crash when clothing cooked data is updated on a client that is not powerful enough to run multithreaded physics (2 or fewer cores) #rb Ori.Cohen #jira OR-33248 #tests - Editor + PIE, running through multiple character viewer screens in menu (as per repro), forced single threaded physics and re-ran tests Change 3235666 on 2016/12/14 by Matt.Schembari Merging 3200968 from Dev-Editor for OR-32947. #c0der3view Andrew.Grant,Arthur.Flew #tests compile ------- Fixed localization gather including texts that were instanced or otherwise unchanged - It now uses the archetype when exporting to diff against the default property value, and will only gather text that has changed from the default. - UMG widgets that are instanced from another UMG asset now only gather overridden values, and skip all child instances. #rb Nick.Darnell --------- Change 3235315 on 2016/12/14 by Adric.Worley Fix FText parse warning spam when dragging in world outliner #jira UE-29099 #tests editor #rb Matt.Kuhlenschmidt Change 3235177 on 2016/12/14 by Sam.Zamani Chat toxicity info added to every out-going party/team chat message Added optional "chat-info" XML element to XMPP chat stanzas being sent to a MUC room The chat info is added to the room's configuration via ChatInterface OSS Currently capturing playlist id, team size, and party size with each chat message OGS-479 Add extra attributes to XMPP chat messages for toxicity processing #rb: josh.markiewicz, rob.cannaday #coderview: ian.fox #tests: none Change 3235093 on 2016/12/14 by Arciel.Rekman Linux: switched PhysX/APEX debug info to DWARF3 and rebuilt the libs - Also fixed an unrelated compile error (by suppressing the warning - do not merge back to main). #rb Ori.Cohen, Andrew.Grant #c0der3view Ori.Cohen, Andrew.Grant #tests Compiled the server Change 3234913 on 2016/12/14 by Andrew.Grant Duplicated 3200382 from Dev-Core as suspected fix for OR-33328 #rb #tests na Change 3234910 on 2016/12/14 by Laurent.Delayen Added AnimNotifyState_DisableRootMotion to turn off root motion during a RootMotion Montage, and give control back to the player. #rb martin.wilson #tests Ice RootMotion Ult networked. Change 3234823 on 2016/12/14 by Lukasz.Furman added capsule support for local navigation grids #orion #rb none #tests PIE Change 3234768 on 2016/12/14 by Lukasz.Furman fixed crash in registering debug scene proxies of gameplay debugger tool #orion #rb none #tests PIE Change 3234682 on 2016/12/14 by Chad.Garyet Adding physx build to dev-general Change 3234643 on 2016/12/14 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 35.2/36 @ CL 3234401 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3234640 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3234597 on 2016/12/14 by Wes.Hunt Merging RealMoneyPurchaseComplete delegate from CatalogHelper into Orion * Hooked it up so CatalogHelper doesn't take a persistent reference to the analytics provider. Extensive refactor of Orion's AnalyticsProvider lifetime and management. * More tightly controlled provider lifetime, eliminated need to recreate the providers unnecessarily. * Made provider access functions simpler and clarified creation vs. access (no more lazy getters). * Improved handling of GameSessionIDs and UserIDs outside of match to improve data clarity for the analytics backend. Details: AnalyticsProviderET * Added Get/SetAppID APIs to allow the AppID to change without recreating the provider (needed for CompQA support, which isn't always known when the provider is created). * SetAppID and SetSessionID now flush their cached events before changing them. * SetUserID still does not Flush because we inadvertently rely on this so the UserID can be set several frames later and all events will be sent with a valid UserID. OrionAnalytics * Simplified contract for correctly creating a new provider: CreateAnalyticsProvider now takes an AccountID and GameSessionID so the provider can be fully initialized with a single call. * Exposed CreateAppID function so the places where the AppID needed to dynamically change (CompQA purposes) could use shared Orion naming conventions. * Exposed SetDefaultAttributes function so game code could share the logic for setting default attributes. * Add assert to CreateAnalyticsProvider because we never expect it to fail, and outside code doesn't have to do it. DemoNetDriver * Exposed UDemoNetDriver::GetDemoSessionID to allow analytics to set a consistent GameSessionID during replay that is NOT the game session ID of the original match, which was throwing heartbeat events for replays into the same session on the backend, if the replay was watched fast enough. OrionGameInstance * Server's analytics provider moved to GameInstance as it's lifetime is more appropriate than the GameMode. * SetUserID now works in PIE, and sets it to PIE_INSTANCE so we don't pollute our account data with random GUIDs GameInstanceCommon * When playing back a replay, use the DemoNetDriver's SessionID instead of the Game Session ID of the game being replayed. OrionGameMode_MOBA * Moved Login functionality to GameMode_Base so it will work properly in all Orion GameModes (ie, DraftLobby). OrionGameMode_Base * Removed SetAnalyticsProvider. This was confusing the interface and making it seem like providers could change dynamically (they couldn't). * GetAnalyticsProvider changed to just get it from the GameInstance where it is really stored now. OrionPlayerController_Base * Removed SetAnalyticsProvider. No external code should be changing the provider. * Exposed an explicit CreateAnalyticsProvider so GetAnalyticsProvider() no longer has to lazily create the provider. * Added some asserts on preconditions to CreateAnalyticsProvider to ensure we are not creating them at the wrong times. OrionGameSession * The Server Analytics provider now sets a UserID that is a combination of the machine name, PID, and a GUID unqiue to that run. This makes server analytics easier to trace back to servers. OrionGameState_Base * CreateGameSessionID renamed to StoreGameSessionID to better reflect that it isn't creating anything. * Remove the code that sets a random GUID for non game modes, which was just confusing the session handling code on the analytics backend. * Ensure that demo playback sets the demo session ID and not the replayed game's session ID. OrionGameStateMain * GameSessionID is always set to the empty string for non game modes. McpContext * InitAnalytics no longer needs to create the analytics provider or restart any session, etc. It just sets the new AppID (if we now know we are CompQA) and the UserID (since we just logged in). #c0der3view:john.pollard,ryan.gerleve,josh.markiewicz #rb josh.markiewicz #tests extensive runs of the game, dedicated server, menu, and match traveral, and replay watching. Also editor, PIE standalone, PIE w/ dedicated server, and nomcp configurations to ensure no crashes and the providers are created as expected, not recreated, and get the proper Session and GameSessionIDs at the expected times. #R0BOMERGE-AUTHOR: david.nikdel #CatalogHelper #Analytics: - Added a RealMoneyPurchaseComplete multicast delegate to CatalogHelper mostly intended for apps to be able to listen for this event (not as a completion delegate) and do their own analytics events. - Rolled up a bunch of the params into a struct for forward compatibility - Moved the ECom.ClientInAppPurchase code into a helper on the struct (would like to get this out of catalog helper now that the delegate is there) [c0der3viewed]: Ian.Fox, Wes.Hunt #R0BOMERGE-SOURCE: CL 3209122 in //WEX/Release-05/... via CL 3209123 #R0BOMERGE-BOT: OGS (BattleBreakers -> Main) #AUTOMERGE using branch ROBO://GamePlugins/Main->//Orion/Dev-General of change#3209125 by Jason.Bestimt on 2016/11/23 12:33:06. #R0BOMERGE-AUTHOR: david.nikdel Why does the compiler think a parameter can "hide" a non-static member from an outer class. That is most definitely not in scope... #R0BOMERGE-SOURCE: CL 3209212 in //WEX/Release-05/... via CL 3209213 #R0BOMERGE-BOT: OGS (BattleBreakers -> Main) #AUTOMERGE using branch ROBO://GamePlugins/Main->//Orion/Dev-General of change#3209214 by Jason.Bestimt on 2016/11/23 14:00:12. #R0BOMERGE-AUTHOR: david.nikdel #CatalogHelper: Change to AnalyticsProvider to shared reference [c0der3viewed]: Ian.Fox #R0BOMERGE-SOURCE: CL 3209222 in //WEX/Release-05/... via CL 3209223 #R0BOMERGE-BOT: OGS (BattleBreakers -> Main) #AUTOMERGE using branch ROBO://GamePlugins/Main->//Orion/Dev-General of change#3209225 by Jason.Bestimt on 2016/11/23 14:07:47. #R0BOMERGE-AUTHOR: wes.hunt Ensure that Heartbeat events will not clog the retry queue if the data router cannot be reached. * Renamed to Usage.Heartbeat and Context to match the more "non-gamey" naming we want to move to (also can't have WorldExplorers prefix). * Removed the Analytics provider from McpCatalogHelper and use the callback delegate instead. This removes analytics assumptions from the McpCatalog code and allows the analytics provider references to not leak outside of WExpAnalytics. This allows us to put ensures in the shutdown code to make sure it doesn't leak and sessions are closed when we expect. Also cleaned up some code that tried to work around the fact that outside code held onto a reference when trying to end the session. [c0der3viewed]:david.nikdel #jira wex-4038 #R0BOMERGE-SOURCE: CL 3209575 in //WEX/Main/WEX/Plugins/... #R0BOMERGE-BOT: OGS (BattleBreakers -> Main) #AUTOMERGE using branch ROBO://GamePlugins/Main->//Orion/Dev-General of change#3209653 by Jason.Bestimt on 2016/11/24 01:43:48. Change 3233911 on 2016/12/13 by Andrew.Grant Duplicating 3203865 from //UE4/Dev-Sequencer/... #tests #rb na Change 3233789 on 2016/12/13 by Olaf.Piesche Replicating 3233289 from Dev-Rendering - light component distance fade properties not initialized #c0der3view marcus.wassmer #rb marcus.wassmer #tests build Change 3233016 on 2016/12/13 by Ryan.Gerleve Fix for conditional properties being evaluated incorrectly when recording replay checkpoints. Fixes heroes appearing as grey boxes in deathcam and replays. #jira OR-32926 #tests golden path, deathcam, replays #rb john.pollard Change 3232909 on 2016/12/13 by Laurent.Delayen Renamed USkeletalMeshComponent::IsPlayingRootMotion() to ::IsPlayingNetworkedRootMotionMontage() to better match what the function does, and match definitions in ACharacter. (Also checks for RootMotionMode to be FromMontageOnly). Added proper IsPlayingRootMotion() to match ACharacter. Also constified these functions. #rb Martin.Wilson #tests Ice Root Motion ult Change 3232336 on 2016/12/13 by David.Ratti Spot merge async loading fix #rb Gil #tests cooked build front end store Change 3231733 on 2016/12/12 by Andrew.Grant Added code to dump out deferred engine commands when frametime is above desired #rb Michael.Noland #tests compiled, ran server #R0BOMERGE: Main Change 3231406 on 2016/12/12 by Laurent.Delayen CharacterMovementComponent: allow physics rotation to be performed during AnimRootMotion. #rb none #tests Ice Change 3230272 on 2016/12/10 by Andrew.Grant Fix for automation code being dead-stripped #rb none #tests verified automation works Change 3229976 on 2016/12/09 by Ryan.Gerleve Fix multiple UI/HUD issues during deathcam playback: No longer switch the local player's PlayerController during deathcam playback. The game player controller will now set it viewtarget to the hero in the deathcam replay. Add an option for the recording DemoNetDriver to not spawn a spectator controller at all. Clean up some hacks that were needed when the player controller did switch to make the card shop close properly. Remove other code that was related to the player controller switch. Add a deathcam camera component to hero characters and activate it during deathcam playback. Factor out the code common to the spectator chase camera and the deathcam camera into a helper struct that both camera components use. Client notifies the server when it starts and stops deathcam, so the server knows not to update the client's viewtarget for the duration. #jira OR-32433, OR-32568, OR-31299, OR-31197 #rb john.pollard, jon.lietz #tests golden path, deathcam, replays Change 3229790 on 2016/12/09 by Lina.Halper #DUPEFIX of CL 3219688 Merging using //Orion/Dev-General_to_//UE4/Dev-Framework Expected fix for cooking issue of animation #rb: Martin.Wilson #code r3view: Martin.Wilson, Laurent.Delayen #tests: none Change 3228731 on 2016/12/09 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 35.2 @ CL 3228573 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3228715 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3228602 on 2016/12/09 by Benn.Gallagher Added temporary CVar to fix broken clothing imports due to errant transposition of bone bind matrices on apx file import. This should not be integrated to main - hoping on a fix soon from Nvidia for this issue to be fully solved, this just gets our content creators back up and running while Nvidia investigates #tests Win64 Editor, importing clothing files for Twinblast and Fallen Angel #rb Lina.Halper Change 3227456 on 2016/12/08 by Andrew.Grant Stopped _BUiltData from being dirtied by autosave (copied from 3223169 in Dev-Editor) #rb #tests na Change 3227417 on 2016/12/08 by David.Ratti Fix category on gameplay tag settings #rb none #tests none Change 3227401 on 2016/12/08 by David.Ratti GameplayTag category restrictions remapping support. This allows engine properties to specify categories that can be specified/expanded by projects. Added categories for gameplayeffect tags #rb BenZ #tests editor, golden path #c0der3view Billy.Bramer, Fred.Kimberly Change 3227368 on 2016/12/08 by Uriel.Doyon Simple forward shading now disables self shadowed translucency (because it samples an invalid volumetric light buffer). #jira OR-32645 #tests Loaded editor, tested in game at different quality settings #rb daniel.wright Change 3227243 on 2016/12/08 by David.Ratti Spot integrate CL 3225990 to fix tag sorting #rb none #tests compile Change 3227029 on 2016/12/08 by Laurent.Delayen Fixed crash when creating a new Montage from scratch. #rb Lina.Halper #tests no more crashing when creating a montage from scratch Change 3226877 on 2016/12/08 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 35.2 @ CL 3226846 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3226876 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3226157 on 2016/12/07 by Aaron.McLeran Implementing UE-39421 fix into Orion-DevGeneral2 #rb none #tests Be able to view sound class graphs without destroying links. Change 3225422 on 2016/12/07 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - PhysX libs null merge from 35.2 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3225413 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3224772 on 2016/12/07 by David.Ratti Fix for Rentry in gameplaycue GetWorld functions #rb none #tests golden path Change 3224771 on 2016/12/07 by David.Ratti Reset RemoetInstanceHasended in UGameplayAbility::PreActivate #rb none #tests pie Change 3224752 on 2016/12/07 by Ben.Marsh Merge CL 3224750 from //UE4/Main: Removing -forcelogflush parameter from UAT invocations of the editor to improve cook times. #rb none #tests preflight Change 3224691 on 2016/12/07 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 35.2 @ CL 3224223 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3224690 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3224166 on 2016/12/06 by Daniel.Lamb Reenabled iterative cooking inisettings saving. #rb Trivial #test Cook paragon Change 3223965 on 2016/12/06 by Uriel.Doyon Building texture streaming data for materials does not wait for pending shaders to finish compilation anymore. Added more options to allow the user to cancel this build also. #rb daniel.wright #tests modified different shaders in the material editor and also in the material instance editor Change 3223953 on 2016/12/06 by Frank.Gigliotti Root motion time stamp reset; * The character movement time stamp is now decremented by MinTimeBetweenTimeStampResets instead of being reset to 0. * The character movement time stamp reset is now applied to the start times on root motions. This fixes root motions being stuck on since the time stamp could potentially never reach the start time. * Changed how root motion detects invalid start times since a negative start time is now valid. #RB zak.middleton, laurent.delayen #c0der3view zak.middleton, laurent.delayen #Tests PIE Change 3223463 on 2016/12/06 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 35.2 @ CL 3223380 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3223458 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3223219 on 2016/12/06 by Daniel.Lamb Added more stats to saving asset registry code. #rb None #test cook Change 3222459 on 2016/12/05 by Uriel.Doyon "Texture Streaming Build" now updates the map check after execution. Removed texture streaming data for primitives hidden in game. Fixed an issue where build all would not rebuild texture streaming data. #rb none #jira OR-32771 #tests rebuilt texture streaming data in different maps Change 3222246 on 2016/12/05 by Jason.Bestimt #R0BOMERGE-AUTHOR: andrew.grant Suppress warning when converting from int when the dest is floating point and the converted values are the same #rb none #tests verified converting -1 to -1.000 no longer results in a warning #R0BOMERGE-SOURCE: CL 3222245 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3221951 on 2016/12/05 by Daniel.Lamb More stats into saving asset registry. #rb None #test cook paragon Change 3221518 on 2016/12/05 by Daniel.Lamb Added some more ini settings parsing stats. Removed SaveCurrentIniSettings when not using iterative builds as it is slow will reenable when it's fast again. #rb None #test Cook paragon Change 3221475 on 2016/12/05 by Jason.Bestimt #R0BOMERGE-AUTHOR: andrew.grant Fix for atrac9 logging issue on PS4 #rb none #tests compiled PS4 client in unity #R0BOMERGE-SOURCE: CL 3221474 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3221403 on 2016/12/05 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 35.2 @ CL 3221235 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3221399 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3221247 on 2016/12/05 by Jason.Bestimt #R0BOMERGE-AUTHOR: andrew.grant Third-try at fixing non-unity compile issue #rb none #tests compiled PS4 client #R0BOMERGE-SOURCE: CL 3221242 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3219738 on 2016/12/02 by Daniel.Lamb Integrate Dev-Platform -> Dev-General Added support to rebuild lightmaps commandlet for building lightmaps in seperate files. #rb Daniel.Wright #test rebuild lighting Custom QAGame maps. #jira OR-31907 Change 3219133 on 2016/12/02 by Jason.Bestimt #R0BOMERGE-AUTHOR: guillaume.abadie Cherry picks Dev-Rendering's 3209305: Fix contact shadow's assemption on objects thickness #rb None #R0BOMERGE-SOURCE: CL 3219131 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3219081 on 2016/12/02 by Andrew.Grant Merging material fixes in 3208490 from //UE4/Dev-Rendering/... to //Orion/Dev-General/... #rb none #tests compiled WIn64 editor Change 3218980 on 2016/12/02 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 35.2 @ CL 3218942 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3218979 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3218970 on 2016/12/02 by Andrew.Grant Second attempt at unity / non-unity fix #rb none #tests compiled PS4 Client Change 3218807 on 2016/12/02 by Andrew.Grant Fix for non-unity issue #rb none #tests compiled Win64 editor Change 3218472 on 2016/12/01 by Andrew.Grant Temp fix to allow checked-out blueprint to compile #rb none #tests none Change 3218417 on 2016/12/01 by Andrew.Grant Merging //UE4/Main @ 3205566 through //UE4/Orion-Stating #rb #tests na Change 3218140 on 2016/12/01 by Arciel.Rekman Linux: report server hangs by crashing the hung thread (UE-39164). #rb Michael.Trepka #c0der3view Bart.Hawthorne, Andrew.Grant. #tests none in this branch (Merging 3218133 from Dev-Platform to to //Orion/Dev-General) Change 3216959 on 2016/12/01 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 35.2 @ CL 3216930 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3216954 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3216341 on 2016/11/30 by Michael.Noland Engine: Reduced the length of the hitch when turning off ToggleDebugCamera while showdebug was active by removing expired strings from the back of the array instead of the front (the underlying issue of strings accumulating while not being displayed / processed is covered by UE-39226) #rb marc.audy #tests showdebug significancemanager + toggledebugcamera + wait 30 s + toggledebugcamera Change 3216233 on 2016/11/30 by Andrew.Grant Generate symbols for PS4 as a post-build UBT step At runtime do a better job of searching paths for symbols #rb Marcus.Wassmer #tests verified symbols are generated and valid Change 3215522 on 2016/11/30 by David.Ratti Fixes from Simon for particle significance overriding explicit call to SetEmitterEnabled by game code. #rb none #tests pie #c0der3view Simon.Tovey Change 3215444 on 2016/11/30 by Aaron.McLeran OR-19392 (and now) OR-32017 Reintroducing CL 2943174 after it was lost due to integration issues! #rb none #tests none Change 3215110 on 2016/11/30 by jason.bestimt #ORION_MAIN - Merge 35.2 @ CL 3215050 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3215097 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) #R0BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human. //R0BOMERGE_ORION_Dev_General/OrionGame/Content/Characters/Heroes/Rampage/Skins/Rampage_v001_IceBlue/M_RampageV001_MASTER.uasset #c0der3view: jason.bestimt Change 3213268 on 2016/11/29 by jason.bestimt #ORION_MAIN - Merge 35.2 @ CL 3213062 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3213118 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) #R0BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human. //R0BOMERGE_ORION_Dev_General/OrionGame/Source/BlueprintContext/Private/BannerContext.cpp #c0der3view: jason.bestimt Change 3212226 on 2016/11/28 by Aaron.McLeran OR-32363 Client ensure with USoundWave::GetResourceSize() v35 DevGen Ensure is not valid since it's possible for the sound wave to have its resource size queried before its finished decoded in the case of precache on load. Rather than report ResourceSize (the compressed asset size), we're going to just report the fully decompressed data size (RawPCMDataSize) since that's what it will be when it finishes decoding. #tests none #rb zak.middleton Change 3208273 on 2016/11/22 by Tim.Elek Fix for Tonemapping sharpen black border for HDR #rb marc.olano #c0der3view marcus.wassmer, jordan.walker, andrew.grant Change 3207881 on 2016/11/22 by Jason.Bestimt #R0BOMERGE-AUTHOR: andrew.grant If a requested package can't be found and async loading is not an option, load the object instead of hoping that FlushAsyncLoading() will make things right... This flaw was spotted while investigating OR-31699 which was due to a different issue, but should have been handled by this codepath. #rb none #tests Faked a condition where a package wasn't loaded on the client but became referenced by a object from the server [c0der3viewed] Ben.Ziegler #R0BOMERGE-SOURCE: CL 3207880 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3207807 on 2016/11/22 by Jason.Bestimt #R0BOMERGE-AUTHOR: andrew.grant Fix for OR-31699 While preloading packages check that a package has actually been loaded. Previously this could result in a package failing to load because FindObjectFast would return it to itself (!) #rb none [c0der3viewed] Michael.Noland #tests verified can load into Monolith and get the shadow buff #R0BOMERGE-SOURCE: CL 3207806 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3207756 on 2016/11/22 by David.Ratti rollback networking changes since they seem to be causing side effects and v35 isnt the version to take chances on #rb none #tests compile Change 3206348 on 2016/11/21 by Dan.Hertzka Re-added lost type checking changes to the widget BP compiler when evaluating whether to bind a widget Also added the type check when renaming a widget - if the property name is taken by a BindWidget property, but the widget isn't of a valid type, the rename now fails #c0der3view Nick.Darnell #rb Nick.Darnell #tests Widget BP binding Change 3205882 on 2016/11/21 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 34.3 @ CL 3205612 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3205880 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3205802 on 2016/11/21 by Daniel.Lamb Fixed commandlet used for diffing cooked packages and generating serialization callstacks. #rb None #test Diff cooked package commandlet Change 3204959 on 2016/11/18 by Ryan.Gerleve World time is no longer adjusted when scrubbing in replays. Fixes several issues related to deathcam. Originally done to to fix ability cooldowns in replays, but shouldn't be necessary. #rb john.pollard #jira OR-30918, OR-31268, OR-31302 #tests golden path, deathcam, replays Change 3204805 on 2016/11/18 by Frank.Gigliotti Don't clamp root motion finish velocity if it doesn't need it. #RB None #Tests PIE Change 3204327 on 2016/11/18 by Mieszko.Zielinski Extended UBTDecorator_IsAtLocation with an option of using regular geometric distances rather than pathfollowing-based test #UE4 #rb Lukasz.Furman #test golden path Change 3204078 on 2016/11/18 by Ryan.Gerleve Flip incorrect sort when there are multiple viewpoints in the significance manager (duplicate of CL 3203997 from Dev-Framework). Fixes objects having incorrect significance in deathcam playback. #rb marc.audy #tests golden path, deathcam Change 3204041 on 2016/11/18 by John.Pollard Fix issue where old player controller from draft lobby was hanging around, causing replication warnings #rb BartH #tests Replays Change 3203971 on 2016/11/18 by John.Pollard Fix assert that can occur in player controller iterator when last element cast's to nullptr #rb BartH #tests Live + replays Change 3203843 on 2016/11/18 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 34.3 @ CL 3203682 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3203842 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3202948 on 2016/11/17 by Daniel.Lamb Disabled warning about invalidating cook due to unparsable ini setting. This occurs when you don't have any previously cooked content (like on build machine). #jira OR-31916 #rb trivial #test cook paragon Change 3202798 on 2016/11/17 by David.Ratti Fix logic error around bSuppressGameplayCues #rb none #tests compile Change 3202761 on 2016/11/17 by Jason.Bestimt #R0BOMERGE-AUTHOR: david.ratti Use FObjectKey instead of UClass* for function acceleration map. Speculative fix for rare client crash. #rb none #test pie #R0BOMERGE-SOURCE: CL 3202552 in //Orion/Release-34.3/... via CL 3202760 #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3202688 on 2016/11/17 by Michael.Noland Engine: Adding stats to performance assassians GetAllActorsWithInterface and GetAllActorsWithTag to make them clearer in dumphitches reports (also in GetAllActorsOfClass, which is usually fine unless used with something really broad like AActor or AStaticMeshActor) #rb none #tests Compiled and ran on PS4 Change 3202687 on 2016/11/17 by Michael.Noland Engine: Changed console variables and commands to allow using ? immediately following the command (without a space) to bring up the help text, in addition to the existing behavior of using ? as the first parameter #tests Tested with/without spaces on both a console variable and a console command #rb nick.darnell Change 3202686 on 2016/11/17 by Michael.Noland Engine: Made help console command open the generated HTML file via LaunchURL on windows #tests Tested help command on Windows (LaunchURL with file:// use is only enabled for Windows now, but will be tested on Mac and possibly enabled later) #rb nick.darnell Change 3202622 on 2016/11/17 by Ryan.Gerleve Support duplication of UReflectionCaptureComponents that were loaded from cooked data. Needed to support deathcam in Monolith. #rb daniel.wright #tests golden path on monolith with deathcam enabled on PS4 Change 3202575 on 2016/11/17 by Dan.Hertzka Blur widget updates - Renamed to SBackgroundBlur/UBackgroundBlur - Split SBackgroundBlur out into its own file - Added bApplyAlphaToBlur - when true, the strength of the blur is modulated by the widget alpha - Updated BlurRadius to be TOptional, so we auto-calculate radius when it isn't set - Added a UBackgroundBlurSlot, but left it unattached so it can be done in dev-editor (and update based on the engine version) - Updated OrionBlurWidget to export dll symbols and set up default low quality fallback image #c0der3view Matt.Kuhlenschmidt #rb none #tests PIE & widget designer Change 3202533 on 2016/11/17 by Mieszko.Zielinski Fixed new toggleable nav links not working in client-server environment #Orion #rb none #test golden path Change 3202456 on 2016/11/17 by Mieszko.Zielinski Introduced a new constant to Recast soruces to be used as initial value of tile salt variables #UE4 #rb none #test golden path Change 3202414 on 2016/11/17 by Chris.Bunner Clamp eye adapation working area to match scene viewrect. #rb Marcus.Wassmer #tests Editor #jira OR-31821 Change 3202205 on 2016/11/17 by David.Ratti Networking fix: -Fix ensure about Delayed Prediction Key being flushed while invalid -Fix issue where predicted GE would be removed due to prediction key catch up, but would be added to the removed predicted GE list, causing the later replicated GE to be ignored incorrrectly. This can cause cooldowns to not appear on client, making abilities appear to not function. #rb none #tests golden path, latency #c0der3view Frank.Gigliotti Change 3202063 on 2016/11/17 by Jason.Bestimt #R0BOMERGE-AUTHOR: nicholas.davies #jira OR-31641 Chat logs overlap text box when pressing enter Jamie Dale fix for adjusting text spacing when lines are removed from TextLayouts [c0der3viewed] Jamie.Dale #RB Jamie.Dale #TESTS Chat should no longer overlap when more than 40 messages have been added #R0BOMERGE-SOURCE: CL 3202062 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3201964 on 2016/11/17 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 34.3 @ CL 3201880 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3201956 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3201426 on 2016/11/16 by Mieszko.Zielinski Implemented a generic way to set up simple point navigation links that could be disabled at runtime on static navmesh #Orion #rb none #test golden path Change 3201174 on 2016/11/16 by John.Pollard Increase number of retries when refreshing viewer fails + refactor so that a refresh doesn't starve other REST calls #rb BartH #tests Replays Change 3200669 on 2016/11/16 by Jason.Bestimt #R0BOMERGE-AUTHOR: andrew.grant Merging test framework changes from Release-34 to resolve some known conflicts #rb #tests na #R0BOMERGE-SOURCE: CL 3200668 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3199192 on 2016/11/15 by Lina.Halper Extra ensure for the crash with OR-31795 #jira: OR-31795 #rb: Laurent.Delayen #tests: cooked, and test AI_Test with 9 bots Change 3199187 on 2016/11/15 by Aaron.McLeran UE-35533 Implementing from CL 3112097 Dev-Framework for joey #tests Perform tests described in JIRA #rb Jeff.Campeau Change 3199094 on 2016/11/15 by Eric.Newman Only ping Slate last interaction time for analog input outside the deadzone Orion now only reports handled for analog movements outside the deadzone #c0der3view matt.kulhenschmidt,chris.gagnon #rb cody.haskell #tests golden path w/ ps4 controller on PC Change 3199085 on 2016/11/15 by Laurent.Delayen Potential fix for https://jira.it.epicgames.net/browse/OR-31795 #rb lina.halper #tests twinblast ult multiPIE Change 3198934 on 2016/11/15 by Frank.Gigliotti Fixed out of sync root motion ability tasks; * Root motion ability tasks were out of sync and ending before the root motion was finished. The tasks now wait for the root motion to say it is done. #RB Laurent.Delayen #Tests PIE Change 3198486 on 2016/11/15 by David.Ratti Iniitalize EffectContext to default ASC EffectContext when no context is specified in AddGameplayCue_Internal. Fixes some GC translation issues. #rb none #tests pie Change 3198424 on 2016/11/15 by Rob.Cannaday Fix JSON_SERIALIZE_OBJECT_SERIALIZABLE macro in write mode not beginning a JSON object #rb ian.fox #tests class using JSON macros that writes a named subobject (BEGIN_JSON_SERIALIZER/JSON_SERIALIZE_OBJECT_SERIALIZABLE("name", obj)/END_JSON_SERIALIZER) Change 3198418 on 2016/11/15 by Rob.Cannaday More profiling for hitch when receiving friend request #jira OR-30503 #rb ian.fox #tests front end add/remove friend #lockdown nicholas.davies Change 3198214 on 2016/11/15 by David.Ratti Ability System: Added support for some advanced client prediction with the intention of removing latency from the effective duration of predictive gameplay effects. 1. Predicted GameplayEffect reconciliation. Predicted GEs are now reconciled with their replicated counter parts. Previously the predicted GE would be removed when the replicated one came in. Now we reconcile the predicted GE with the replicated GE, and throw out the replicated GE as if it was never added. To the outside, the predicted GE becomes the replicated GE seamlessly. 2. Server retry client activation fails. When a client ability activation fails on the server, the server can retry the activation for a few frames before officially failing it. This is to combat minor discrepencies caused by different server frame rate or jitter in networking conditions. The common example is that we handle RPCs at the top of the frame, before we update timer manager and removed expired GEs or end animations. Both features can be disabled with -DisableAdvancedClientPrediction. They can be toggled individually via config file. #QAr3view: 1. Verify ping time no longer affects attack speed OR-30123. We still expect packet loss to have some effect on rate of fire. 2. Be on the look out for "ability stuck" type of issues 3. If there are resources, I would like to get 2 people to give qualitative feedback on this. Have them lane 1v1 for ~7 minutes with 200 ms of ping (no packet loss). Do this twice, once normally and again with -DisableAdvancedClientPrediction on both client AND server. Do it blind: don't tell them which run has which setting, just see if they notice differences. The hope is that your LMB attacks feel consistent with respect to timing and match what the UI shows in terms of cooldown. I would recommend testing with Murdock and maybe a melee like Crunch #rb frank #c0der3view Frank.Gigliotti, Billy.Bramer, Fred.Kimberley #tests pie, golden path Change 3197309 on 2016/11/14 by Laurent.Delayen Additional debugging info for https://jira.it.epicgames.net/browse/OR-31266 #rb none #tests riftmage + venus VS riftmage multiPIE Change 3196654 on 2016/11/14 by Laurent.Delayen Additional debug info to track down https://jira.it.epicgames.net/browse/OR-31677 #rb none #tests compiles [CL 3276432 by Andrew Grant in Main branch]
2017-01-27 23:32:44 -05:00
case ETargetPlatformFeatures::ShouldSplitPaksIntoSmallerSizes :
return false;
case ETargetPlatformFeatures::HalfFloatVertexFormat:
return true;
case ETargetPlatformFeatures::LumenGI:
return TPlatformProperties::SupportsLumenGI();
case ETargetPlatformFeatures::HardwareLZDecompression:
return TPlatformProperties::SupportsHardwareLZDecompression();
}
return false;
}
virtual FName GetZlibReplacementFormat() const override
{
return TPlatformProperties::GetZlibReplacementFormat() != nullptr ? FName(TPlatformProperties::GetZlibReplacementFormat()) : NAME_Zlib;
}
virtual int32 GetMemoryMappingAlignment() const override
{
return TPlatformProperties::GetMemoryMappingAlignment();
}
#if WITH_ENGINE
virtual FName GetPhysicsFormat( class UBodySetup* Body ) const override
{
return FName(TPlatformProperties::GetPhysicsFormat());
}
#endif // WITH_ENGINE
};
template<typename TPlatformProperties>
class TNonDesktopTargetPlatformBase
: public TTargetPlatformBase<TPlatformProperties>
{
public:
/**
* A simplified version for TPs that never will have Editor or ServerOnly versions, potentially multiple CookFlavors, as well as IN VERY RARE CASES,
* a different runtime IniPlatformName than what is passed in here (an example being TVOS and IOS, where passing in TVOS properties is very complicated)
* Note that if we delayed the Info creation, we could just use this->IniPlatformName() and override that in, say TVOS, but we can't call a virtual here,
* so we pass it up into the ctor
*/
TNonDesktopTargetPlatformBase(bool bInIsClientOnly, const TCHAR* CookFlavor=nullptr, const TCHAR* OverrideIniPlatformName=nullptr)
: TTargetPlatformBase<TPlatformProperties>(new PlatformInfo::FTargetPlatformInfo(
OverrideIniPlatformName ? FString(OverrideIniPlatformName) : FString(TPlatformProperties::IniPlatformName()),
bInIsClientOnly ? EBuildTargetType::Client : EBuildTargetType::Game,
CookFlavor))
, bIsClientOnly(bInIsClientOnly)
{
}
virtual FString PlatformName() const override
{
// instead of TPlatformProperties (which won't have Client for non-desktop platforms), use the Info's name, which is programmatically made
return this->PlatformInfo->Name.ToString();
}
virtual FString IniPlatformName() const override
{
// we use the Info's IniPlatformName as it may have been overridden in the constructor IN RARE CASES
return this->PlatformInfo->IniPlatformName.ToString();
}
virtual FString CookingDeviceProfileName() const override
{
// when cooking for non-desktop platforms, always use the base platform name as the DP to cook with (there aren't IOSClient DPs, there are IOS (base), IPhone7, iPad4, etc DPs)
return IniPlatformName();
}
virtual bool HasEditorOnlyData() const override
{
return false;
}
virtual bool IsServerOnly() const override
{
return false;
}
virtual bool IsClientOnly() const override
{
return bIsClientOnly;
}
virtual bool IsRunningPlatform() const override
{
// IsRunningPlatform is only for editor platforms
return false;
}
protected:
// true if this target platform is client-only, ie strips out server stuff
bool bIsClientOnly;
};