2019-12-26 15:33:43 -05:00
|
|
|
// Copyright Epic Games, Inc. All Rights Reserved.
|
2014-03-14 14:13:41 -04:00
|
|
|
|
Copying //UE4/Dev-Build to //UE4/Dev-Main (Source: //UE4/Dev-Build @ 3209340)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3209340 on 2016/11/23 by Ben.Marsh
Convert UE4 codebase to an "include what you use" model - where every header just includes the dependencies it needs, rather than every source file including large monolithic headers like Engine.h and UnrealEd.h.
Measured full rebuild times around 2x faster using XGE on Windows, and improvements of 25% or more for incremental builds and full rebuilds on most other platforms.
* Every header now includes everything it needs to compile.
* There's a CoreMinimal.h header that gets you a set of ubiquitous types from Core (eg. FString, FName, TArray, FVector, etc...). Most headers now include this first.
* There's a CoreTypes.h header that sets up primitive UE4 types and build macros (int32, PLATFORM_WIN64, etc...). All headers in Core include this first, as does CoreMinimal.h.
* Every .cpp file includes its matching .h file first.
* This helps validate that each header is including everything it needs to compile.
* No engine code includes a monolithic header such as Engine.h or UnrealEd.h any more.
* You will get a warning if you try to include one of these from the engine. They still exist for compatibility with game projects and do not produce warnings when included there.
* There have only been minor changes to our internal games down to accommodate these changes. The intent is for this to be as seamless as possible.
* No engine code explicitly includes a precompiled header any more.
* We still use PCHs, but they're force-included on the compiler command line by UnrealBuildTool instead. This lets us tune what they contain without breaking any existing include dependencies.
* PCHs are generated by a tool to get a statistical amount of coverage for the source files using it, and I've seeded the new shared PCHs to contain any header included by > 15% of source files.
Tool used to generate this transform is at Engine\Source\Programs\IncludeTool.
[CL 3209342 by Ben Marsh in Main branch]
2016-11-23 15:48:37 -05:00
|
|
|
#include "MaterialExpressionClasses.h"
|
|
|
|
|
#include "UObject/ObjectMacros.h"
|
|
|
|
|
#include "UObject/Class.h"
|
|
|
|
|
#include "UObject/UnrealType.h"
|
|
|
|
|
#include "Materials/MaterialExpression.h"
|
|
|
|
|
#include "UObject/Package.h"
|
|
|
|
|
#include "MaterialEditor.h"
|
|
|
|
|
#include "UObject/UObjectHash.h"
|
|
|
|
|
#include "UObject/UObjectIterator.h"
|
2018-02-22 11:25:06 -05:00
|
|
|
#include "Modules/ModuleManager.h"
|
Copying //UE4/Dev-Build to //UE4/Dev-Main (Source: //UE4/Dev-Build @ 3209340)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3209340 on 2016/11/23 by Ben.Marsh
Convert UE4 codebase to an "include what you use" model - where every header just includes the dependencies it needs, rather than every source file including large monolithic headers like Engine.h and UnrealEd.h.
Measured full rebuild times around 2x faster using XGE on Windows, and improvements of 25% or more for incremental builds and full rebuilds on most other platforms.
* Every header now includes everything it needs to compile.
* There's a CoreMinimal.h header that gets you a set of ubiquitous types from Core (eg. FString, FName, TArray, FVector, etc...). Most headers now include this first.
* There's a CoreTypes.h header that sets up primitive UE4 types and build macros (int32, PLATFORM_WIN64, etc...). All headers in Core include this first, as does CoreMinimal.h.
* Every .cpp file includes its matching .h file first.
* This helps validate that each header is including everything it needs to compile.
* No engine code includes a monolithic header such as Engine.h or UnrealEd.h any more.
* You will get a warning if you try to include one of these from the engine. They still exist for compatibility with game projects and do not produce warnings when included there.
* There have only been minor changes to our internal games down to accommodate these changes. The intent is for this to be as seamless as possible.
* No engine code explicitly includes a precompiled header any more.
* We still use PCHs, but they're force-included on the compiler command line by UnrealBuildTool instead. This lets us tune what they contain without breaking any existing include dependencies.
* PCHs are generated by a tool to get a statistical amount of coverage for the source files using it, and I've seeded the new shared PCHs to contain any header included by > 15% of source files.
Tool used to generate this transform is at Engine\Source\Programs\IncludeTool.
[CL 3209342 by Ben Marsh in Main branch]
2016-11-23 15:48:37 -05:00
|
|
|
#include "Preferences/MaterialEditorOptions.h"
|
Copying //UE4/Dev-Rendering to //UE4/Dev-Main (Source: //UE4/Dev-Rendering @ 3680113)
#lockdown Nick.Penwarden
#rb none
============================
MAJOR FEATURES & CHANGES
============================
Change 3441680 by Uriel.Doyon
Added units to point light intensity, to allow the user to specify the value in candelas or lumens.
New point light actors now configure the intensity in candelas by default.
Replaced viewport exposure settings by an EV100 slider.
Hidding the tone mapper in the show flag now still applies the exposure.
Added a new AutoExposure method called EV100 which allows to specify :
- MinEV100, MaxEV100
- Calibration Constnat
- Exposure Compensation
#jira UE-42783
Change 3454934 by Chris.Bunner
Backing out changelists 3441680, 3454636 and 3454844 for the sake of integration stability.
Change 3629223 by Rolando.Caloca
DR - Rollback //UE4/Dev-Rendering/Engine/Source/Runtime/VulkanRHI to changelist 3627847
Change 3629708 by Rolando.Caloca
DR - vk - Redo some changes from DevMobile
3601439
3604186
3606672
3617383
3617474
3617483
Change 3636145 by Chris.Bunner
Linux compile fix.
Change 3636198 by Chris.Bunner
Include fix.
Change 3636225 by Daniel.Wright
Removed spammy draw event
Change 3636397 by Daniel.Wright
Visualize volumetric lightmaps uses 18% grey in lit mode
Change 3636398 by Daniel.Wright
Translucency lighting modes work with Volumetric Lightmaps
* The old Indirect Lighting Cache always interpolated one sample per object, while Volumetric lightmaps operate at the frequency of the Translucency Lighting Mode (per-vertex or per-pixel) so the lighting accuracy is much higher.
* The old ILC always applied the single lighting sample with a per-pixel normal, even in per-vertex lighting modes
* Volumetric PerVertex NonDirectional (cheapest lit translucency) went from 74 instructions down to 42
* Volumetric Directional went from 104 up to 122
Change 3636604 by Chris.Bunner
Added a material translation error on identically named/associated but differently valued parameters as this will cause one of them to be lost during parameter evaluation, the result being "random".
Change 3637668 by Rolando.Caloca
DR - hlslcc - Skip preprocessor when not required which reduces peak mem consumption by ~500 MB
- Fix missing indexing on intrinsic return type
Change 3638541 by Chris.Bunner
Fixed editor materials - Skip hardcoded parameter names that we rely on being overridden when checking for non-matching duplicate parameters.
Change 3638798 by Mark.Satterthwaite
Rebuilt hlslcc for Mac for Rolando's 3637668 changes.
Change 3638861 by Mark.Satterthwaite
Missed making a log verbose in the Metal ring-buffer.
Change 3639482 by Rolando.Caloca
DR - vk - Minor fixes
Change 3639909 by Michael.Lentine
Add special case for struct needed to compile.
Workaround issues in parser such that (x)[0] is replaced with x[0] and (x).a is replaced with x.a.
Change 3639916 by Michael.Lentine
Spelling fix.
Change 3640053 by Mark.Satterthwaite
Fix Desktop Forward rendering on Nvidia Metal rendering on macOS by modifying the shader and runtime to treat ForwardLocalLightBuffer data as uint rather than float and invert the use of as*() casts.
Tthis is *necessary* to avoid a bug/limitation of Nvidia's current Metal shader compiler that flushes all denorm values to zero on load from any resource. AMD & iOS Metal only flush-to-zero when sampling from textures and that's what Apple regard as the expected behaviour. I have however asked them to standardise on the D3D behaviour of preserving denorms on all load, move (incl. min/max/as*()-casts) & store operations. This won't happen in the current or imminent OS/Xcode releases.
Now only Intel Metal is broken and their problems run deeper.
#jira UE-48881
Change 3640983 by Olaf.Piesche
Cache the depth buffer collision shader for GPU particles even when simple forward is enabled, as that can be turned off at runtime.
#jira UE-48799
Change 3641480 by Michael.Lentine
Add min16float to FP16Math
Change 3642442 by Mark.Satterthwaite
Fix the native shader libraries again & undo the increase in cook time from changes to the way FShaderCodeLibrary was compiling & deduplicating the shaders.
- Remvoe the single linear array for accumulated shader code: reallocating this is tremendously expensive and will double the time taken to iteratively cook large projects.
- Uncompress the shader data for the native library system so that it actually works again.
- Fix some errant change to the Metal compiler that was trying to wedge the fully compiled library into the single Metal library which is 100% bogus.
#jira UE-49192
Change 3642919 by Chris.Bunner
Reverted unintended changes to material static parameter set serialization.
Bumped material version to force re-serialization.
Fixed a few typos.
Change 3642923 by Richard.Wallis
Fix for "Pixel Inspector On" message not disappearing when closing pixel inspector window while on. Handle tab closed events to cancel the pixel inspector if window closed while running.
#jira UE-46504
Change 3643296 by Michael.Lentine
Convert all structures that aren't use globally to halfs.
Change 3643381 by Ryan.Brucks
New Plugin allowing Blueprint Texture and RT reads as well as MIC creation and modification.
Change 3643929 by Ben.Salem
Added better precision on thread values in Perf Monitor. Also added global thread values to go with per-world ones to help track down the most accurate numbers possible.
#tests Ran locally, changes validated by benj
Change 3644203 by Mark.Satterthwaite
Refactor mtlpp a little bit to make the compiler do more of the work & update for all the latest publicly exposed APIs.
Change 3644336 by Mark.Satterthwaite
Ref-count the mtlpp Device object so that it can be the repository for IMP caching - now just have to go through the types created from a specific device and have them keep a reference....
Change 3644431 by Uriel.Doyon
Added a intensity units property, for point lights and spot lights, that can be set to Candelas, Lumens or Unitless (legacy).
The default units value for newly placed point lights and spot lights is configured in the project settings.
Spot lights configured in lumens have their whole luminous energy redirected toward the cone.
This means that changing the outer cone angle, changes the spot light brightness.
New exposure menu that uses an EV100 slider.
New post process settings "camera" tab regrouping : ShutterSpeed, ISO, Aperture and ExposureCompensation.
Post process settings "auto exposure" tab renamed "exposure".
The calibration constant for "Auto Exposure Basic" is now configurable in the advanced tab.
The auto exposure method is renamed "Metering Mode"
New pre-exposure feature that allows the engine to apply the previous frame exposure before writing to the scene color.
This allows the engine to render the scene with similar range than the final color (after exposure), and avoid arithmetic overflow for low precision RT formats.
The amount of exposure applied directly is called pre-exposure, and is compensated by a smaller post-exposure value.
Change 3645098 by Marcus.Wassmer
Don't add meshes twice when in simpleforward
Change 3645551 by Daniel.Wright
VolumetricScatteringIntensity is greyed out based on Mobility
Change 3645707 by Chris.Bunner
Skip empty parameters when identifying invalid duplicates during material translation.
Change 3646225 by Uriel.Doyon
Texture streaming support for particle sub-uv
Change 3646323 by Rolando.Caloca
DR - vk - Fix bad update texture 2/3d parameters
Change 3646463 by Mark.Satterthwaite
Metal shader files that can serve as extensions to the metal_stdlib rather than trying to wedge even more into the shader compiler. Might as well leverage Metal's C++'ness.
Currently just a skeleton of a buffer type that would better emulate HLSL Buffer<>/RWBuffer<> objects.
Change 3646727 by Marcus.Wassmer
fix linux and nonunity compiles
Change 3647777 by Rolando.Caloca
DR - Mobile Vulkan optimization
Change 3647822 by Lauren.Ridge
Layers are now renameable (except Layer 0 is always "Background") in Material Layers Functions
Change 3647918 by Chris.Bunner
Static analysis fixes - Monolithic include, forward delcared enums, locally shadowed variable.
Change 3648010 by Michael.Lentine
Don't use min16float by default.
Change 3648015 by Michael.Lentine
Add special case fixes for min16float as well as half on console.
Change 3648024 by Lauren.Ridge
Moving MaterialLayersFunctions Layer naming to EditorOnly wrappers
Change 3648127 by Lauren.Ridge
Moving name getter functionality to FMaterialLayersFunctions
Change 3648265 by Lauren.Ridge
Fixing loctext key
Change 3648293 by Rolando.Caloca
DR - D3D12 fix
Change 3648326 by Rolando.Caloca
DR - vk - Added subrectangle support when updating Texture2D and Texture3D
Change 3648522 by Rolando.Caloca
DR - vk - Do not try to create a BufferView of a StructuredBuffer (no valid pixelformat)
Change 3648612 by Rolando.Caloca
DR - vk - Implement RHIMapStagingSurface
Change 3648673 by Rolando.Caloca
DR - vk - Reduce Vulkan pipeline cache disk size by filtering duplicated shader ucodes
Change 3648913 by Arne.Schober
DR - Performance optimization during HLod traversal. using vector load and avoiding array copy by passing it through reference instead through value.
Change 3649443 by Daniel.Wright
Exposed EmissiveBoost, since Lightmass supports Emissive areas on meshes
Change 3650436 by Mark.Satterthwaite
Implemented the necessary extensions for Metal shading language to move lots of complexity out of MetalBackend and into actual shader code to make life *vastly* simpler.
- Full ue4::typed_buffer<T> wrapper type & associated ue4::buffer<>/ue4::buffer_atomic<> API - totally untested but should be functionally equivalent to HLSL Buffer<T>/RWBuffer<T>.
- All the sensible casts I can think of are now defined in ue4_format - any additional ones can just be added. The enurm of formats needs to be exposed to MetalRHI so we upload the correct values, but this should be trivial.
- Added a full series of wrappers around texturecube_array and depthcube_array to insulate code from whether it is backed by a real cube_array or a texture2d_array so we don't have to maintain complicated variants for new/old iOS devices.
- Added implementations for a bunch of annoying HLSL & GLSL intrinsics that were being matched by name + reverse_bits which needs a custom implementation on old shader standards.
Change 3650861 by Rolando.Caloca
DR - vk - Fix warnings
Change 3651116 by Rolando.Caloca
DR - vk - Support for compressed saved PSO cache
Change 3651321 by Rolando.Caloca
DR - vk - Prep for load multiple PSO files
Change 3651337 by Chris.Bunner
Editor-only default material fallback (hardcoded material).
#jira UE-48404
Change 3651839 by Rolando.Caloca
DR - vk - Integrate minor pipeline changes
Change 3652042 by Mark.Satterthwaite
More work on mtlpp:
- Selector class that caches IMP from SEL & Class.
- Fixes to ns::Error.
- Added test case application for testing denorm & float reinterpret-cast behaviour on Metal.
Change 3652370 by Uriel.Doyon
New "stat StreamingOverview" giving high level metrics of texture usage.
New function ResetAverageRequiredTexturePoolSize() and GetAverageRequiredTexturePoolSize() giving the average ideal value for "r.streaming.poolsize".
Change 3653658 by Chris.Bunner
Material vertex interpolator for sprite and gpu sprite particles.
Change 3653676 by Rolando.Caloca
DR - vk - Integrate changes: Multiple PSO caches, shared ucode & compression, size reduction up to 80%
Change 3653940 by Daniel.Wright
Moved Volumetric Lightmap textures out of FScene and into FPrecomputedVolumetricLightmapData so their lifetime can match the MapBuildData. This allows tossing the source BulkData in game after RHI texture creation even though switching lighting scenarios does Release/InitializeRenderingResources multiple times.
Change 3653956 by Daniel.Wright
Fixed leak of BatchVisibilityId's
Change 3653991 by Daniel.Wright
Fixed missing include
Change 3654013 by Daniel.Wright
Refactored reflection capture composite SM4 handling, now forces fully rough even if !REFLECTION_COMPOSITE_USE_BLENDED_REFLECTION_CAPTURES (forward shading default)
Change 3654018 by Daniel.Wright
Remove unused SM4 reflection capture cubemap
Change 3654118 by Rolando.Caloca
DR - vk - Fix for queries; support for r.Vulkan.ProfileCmdBuffers to only time cmd buffers w/o gpu bubbles
Change 3654339 by Chris.Bunner
Temporarily disabed a material error whilst working with content teams to fix the introduced bugs.
Change 3654534 by Daniel.Wright
Editor is only supported on Feature Level 5 platforms. Added a message box and exit when SM4 is detected (d3d10, OpenGL 3).
Change 3654751 by Rolando.Caloca
DR - vk - Add readback for RGB10A2; minor optimization
Change 3654940 by Rolando.Caloca
DR - vk - Warning fix
Change 3655104 by Mark.Satterthwaite
Add a bunch of code to mtlpp to wrap the Xcode command-line Metal tools and use them to provide a convenient command-line tool that can compile two Metal shaders & diff the resulting AIR to make debugging easier. Obviously this only works on macOS.
Change 3655173 by Jian.Ru
Render dithered material as masked if a stencil prepass is not used
#jira UE-50064, UE-49537
Change 3655479 by Daniel.Wright
Fixed HandleLegacyMapBuildData not getting called on P maps loaded in the editor, which apparently was dropped in an integration error, causing all legacy maps (before the BuildData change) to lose their built lighting.
Change 3656341 by Richard.Wallis
Metal validation checks to test for drawing of the end of a vertex stream as seen in UE-48172 (Landscape Mesh Flickers Rapidly When Using Sculpting Landscape). This is not a fix for that but just a error log to catch the bad draw calls.
#jira UE-48172
Change 3656844 by Rolando.Caloca
DR - vk - Avoid microcode copy
- Fix link error
Change 3656894 by Rolando.Caloca
DR - vk - Enable api dump without needing validation enabled
Change 3656915 by Marcus.Wassmer
Fix DX12 buffer lock for read
Change 3657166 by Rolando.Caloca
DR - vk - Proper fix for api dump layer
Change 3657401 by Rolando.Caloca
DR - vk - Linux compile fix
Change 3657607 by Rolando.Caloca
DR - vk - Prep for changes
Change 3658722 by Chris.Bunner
Refresh shared texture samplers when changing max ansiotropy level (e.g. scalability settings).
#jira UE-30086
Change 3659499 by Daniel.Wright
Moved bEnableAutoLODGeneration to LOD category so it's not the only one in HLOD category
Change 3659644 by Mark.Satterthwaite
D3D11 equivalent to 3656341 (only enabled when -d3ddebug is) to validate DrawIndexedPrimitives isn't trying to draw off the end of the instanced vertex streams which has inconsistent (and potentially undefined) behaviour across the various APIs we support. This fires when painting the landscape because the code attempts to render with a FirstInstance value that is as large as the number of elements in the instance-data streams which D3D11 drivers silently fails to render, but which Metal (& probably Vulkan too) will renders as garbage. This pattern is wrong & will be even more dangerous in a Draw*Indirect world.
#jira UE-48172
Change 3659831 by Rolando.Caloca
DR - vk - Copy 3657927 (fixes for Mali)
Change 3661921 by Rolando.Caloca
DR - vk - Minor log/info changes
Change 3661985 by Mark.Satterthwaite
Change the Metal sampler filter translation to better match D3D.
Change 3662050 by Richard.Wallis
Compile fix for Metal enums.
Change 3662062 by Rolando.Caloca
DR - Copy from 3662060
- OpenGL cloth fix
Change 3662100 by Mark.Satterthwaite
Use a temporary file and an atomic move to put the Metal PCH into the right place and reduce the number of false PCH compile failures on the build farm.
Change 3662253 by Daniel.Wright
Reflection Captures support Lighting Scenarios without recapturing
* Reflection Captures are now part of the Map Build
* Modifying a capture in editor will display a preview, but game can only display built captures (black for unbuilt with screen message)
* Reflection Capture build data moved to the BuildData package
* Building lighting / reflection captures no longer dirties ULevels
* Sky lights which capture the scene now work correctly with Lighting Scenarios
* Lighting Scenarios must now be loaded for each time they are made visible (no switching back and forth while keeping both loaded)
Change 3663215 by Mark.Satterthwaite
Initial, incomplete, tool added to mtlpp to help debug macOS Internal Compiler Errors - the mtlpp command-line tool can be fed the debug output from UE4 along with compiler settings to automatically compile shaders and construct the render pipeline that crashes the runtime compiler.
So far only macOS render-pipeline-states are supported currently.
Change 3663293 by Mark.Satterthwaite
Added Metal device selection to the mtlpp command-line tool so I can quickly test compile on dual-GPU Macbook Pro's.
Change 3663471 by Daniel.Wright
Reflection Capture Builds no longer use UEditorLevelUtils::SetLevelVisibility to control level visibility, which streams out sublevels, modifying nav mesh
Fixed status updates during Reflection Capture Build
Captures overflowing GMaxNumReflectionCaptures now log a warning instead of pretending that they built successfully
Change 3664056 by Rolando.Caloca
DR - Linux compile fix
Change 3664460 by Daniel.Wright
Restored unused LoadTimesObjectVersion, packages saved with it will issue a warning on load
Change 3664802 by Uriel.Doyon
Fixed flash created by pre-exposure when the value changed dramatically between frames
Change 3664890 by Daniel.Wright
Created 'Stat MapBuildData' to track the memory size of lighting and reflection capture build outputs
Change 3665163 by Rolando.Caloca
DR - Copy from 3665156
- Gracefully fail when there are mem leaks exiting Vulkan
Change 3665629 by Daniel.Wright
Only Surface domain materials cast shadows in Lightmass
Change 3665855 by Marcus.Wassmer
PR #4032: Fix comparison of SceneColorFormat (Contributed by Hybrid0)
Change 3666707 by Guillaume.Abadie
Replaces some custom material node to get View.BufferSizeAndInvSize with ViewProperty material expression in some engine material functions.
Change 3667239 by Rolando.Caloca
DR - Use hlslcc define for common issues
Change 3668108 by Brian.Karis
Disabled to Catmull-Rom filter. Too many flickering issues. Disabled antiflicker as well.
Change 3668157 by Mark.Satterthwaite
In the prototype Metal stdlib extension library add inline versions of the D3D SM6 "wave" intrinsics that can be expressed in terms of Metal 2.0 simd/quad group operations (macOS=simd, iOS=quad). These are unlikely to be as efficient as direct intrinsics but they should be functionally equivalent.
These functions are not available *yet* as I still need to hook the ue4_stdlib into MetalShaderFormat & MetalRHI.
The following HLSL 6 functions are implemented:
WaveAllBitAnd
WaveAllMax
WaveAllMin
WaveAllBitOr
WaveAllBitXor
WaveAllEqual
WaveAllProduct
WaveAllSum
WaveAllTrue
WaveAnyTrue
WaveBallot
WaveGetLaneCount
WaveGetLaneIndex
WaveOnce
WavePrefixProduct
WavePrefixSum
WaveReadFirstLane
WaveReadLaneAt
The following can't be implemented in Metal as of Metal 2.0 AFAIK:
WaveGetOrderedIndex
WaveIsHelperLane
GlobalOrderedCountIncrement
QuadReadLaneAt
QuadSwapX
QuadSwapY
Change 3668260 by Olaf.Piesche
Cache particle collision shaders regardless of simple forward state
Missed this checkin
#jira FORT-51307
Change 3669243 by Daniel.Wright
Bumped shader version to propagate FReflectionCaptureData rename
Change 3669369 by Mark.Satterthwaite
Duplicating Metal changes from //UE4/Release-4.18 to Dev-Rendering (//UE4/Dev-Rendering)
3662503 Collapse system-variables to one declaration in MetalUtils to avoid later shader compiler errors when they are specified more than once, which is seemingly permissable. Fixes volumetric fog.
#jira UE-50293
3665210 - Invalidate all Metal shaders again to force a recompile to workaround another driver bug.
- On macOS compact the clip-distance value into a single output to avoid bugs in the runtime pipeline compilers.
- In SCW's direct-compile mode MetalShaderForamt should always dump the resulting Metal shader and print any errors we encounter to the log.
- Change FGenerateMetalVisitor to take a FMetalCodeBackend& not a FMetalCodeBackend* to avoid a lot of pointless pointer validation.
#jira UE-50244
3665429 Fix a crash on shutdown due to MetalRHI caching vertex-declarations beyond the lifetime of the RHI by moving the cache into the FMetalDynamicRHI itself.
#jira UE-50356
3665613 Fix DistanceField rendering on Metal & the associated validation layer error when it is enabled - MetalRHI can't use the same approach as Vulkan without a bit more work.
#jira UE-50364
3667584 Fix black flickering on some materials that use World Position Offset - the Metal sincos intrinsic comes into two flavours for single precision floats and we want the precise version not the fast version. The "cross" implementation needed a few more fma's too and this change has to invalidate Metal shaders again to take effect.
#jira UE-50399
3667805 Changing sincos in Metal fragment shaders had undesirable side-effects - the compiler is now re-associating another floating point operation - so limit the use of precise::sincos to vertex-shaders for now. This fixes the WPO materials without causing any other obvious problems.
#jira UE-50399
Change 3669912 by Mark.Satterthwaite
Fix Metal compilation for PCSS shadows - the HLSL that is compiled uses both SampleCmp and Sample which GLSL disallows (shadowSampler types in GLSL only allow SampleCmp) but is perfectly valid in Metal where only the texture type declaration changes.
Duplicate MetalBackend.cpp changes from Joe.Graf's: 3667781
Fixed an extra ) being emitted during HLSL->Metal translation
Added depthcube_array support per Mark's instructions
Change 3670308 by Mark.Satterthwaite
Missing autorelease pool blocks in MetalTexture functions.
Change 3670989 by Mark.Satterthwaite
Stop trying to be so clever with Metal clip-distances: AMD have a bug in 10.13.0 that means we can only emit one clip-distance value, so simply emit the value with the lowest index (we have handily ordered them by importance!) and let the others become user-interpolators until this bug is resolved in a macOS SU (according to Max@AMD the fix is in, just not in time for 4.18). This means planar reflections will work, VR no-multi-view-fallback will work & layered rendering will work either individually or together - the difference being that on macOS *only* the VR no-multi-view-fallback & layered rendering paths may be slower when combined with the global clip plane.
Hit & run fix to MetalCaptureManager and availability of tile-shader functions while I'm here.
#jira UE-50518
Change 3671014 by Mark.Satterthwaite
Correct handling of RowLinearPVRTC blits for iOS Metal desired for Ocean.
Change 3671575 by Rolando.Caloca
DR - Copy 3668036
Stop syncing CPU with GPU on Vulkan
Change 3671637 by Rolando.Caloca
DR - Copy 3670937
Fixes Vulkan editor outline
Change 3672309 by Mark.Satterthwaite
Submitted on behalf of Richard Wallis:
Only disable V-Sync on Metal in macOS 10.13 when running in "true" fullscreen mode (where we switch display modes & forbid switching spaces or tabbing out) so that you won't see the rainbow artefact caused by being out-of-sync with WindowServer, only the tearing you'd expect when V-Sync is disabled. We'll chat with Apple about whether there is a way to avoid the rainbow artefact when switching spaces in Windowed Fullscreen with displaySync disabled.
#jira UE-50134
Change 3672314 by Daniel.Wright
User friendly message dialog for when a required key is missing from BaseLightmass.ini
Change 3672315 by Daniel.Wright
Assert on load when a uniform buffer struct goes missing, instead of a crash on save
Change 3672476 by Chris.Bunner
Removed duplicate material instance editor command binding that appeared in a task stream merge.
Change 3672626 by Mark.Satterthwaite
Move the ue4_stdlib.metal extensions to MetalRHI's Public header directory as it'll need to be available to both modules and that's easier to accomplish from here.
Change 3672643 by Mark.Satterthwaite
iOS compilation fixes.
Change 3672728 by Daniel.Wright
Fixed encoded HDR reflection captures
Change 3672753 by Jian.Ru
Fix texture swimming
#jira UE-49369
Change 3672815 by Daniel.Wright
Tooltip for build button explaining why it might be disabled
Change 3673350 by Rolando.Caloca
DR - vk - Do not reallocate memory every draw call
Change 3673501 by Rolando.Caloca
DR - vk - Remove more reallocations
Change 3673505 by Rolando.Caloca
DR - Remove global variable with semantic
Change 3673514 by Rolando.Caloca
DR - vk - compile fix
Change 3675899 by Chris.Bunner
Fixed support for editor-time transient parameter overrides. This happens when a compiled material's scalar or vector parameter is changed in value only, the active material resources should also update and be reverted when the material graph is closed. The code was incorrectly pulling base parameters from expressions instead of the actual uniform.
Change 3676843 by Arne.Schober
DR - UE-49473 - Fix Stateleak caused by custom drawer in the long for loop, where the depth stencil state might not be reset in a subsequent itteration of the loop.
Change 3678269 by Daniel.Wright
Fixed Encoded HDR reflection capture data getting the wrong Brightness applied when cooking
Change 3678543 by Daniel.Wright
MapBuildData now tosses the unneeded reflection capture format on load. Affects target platforms that require multiple formats at cook time.
Change 3679602 by Jian.Ru
Fix up mesh decal shader complexity view mode
#jira UE-50272
Change 3679959 by Chris.Bunner
Fixed logic on overriden vector parameter retrieval for material instances checking a function owned parameter.
#jira UE-50712
Change 3679998 by Daniel.Wright
Fixed crash when precomputing static visibility only
[CL 3680175 by Marcus Wassmer in Main branch]
2017-10-04 13:36:51 -04:00
|
|
|
#include "MaterialEditorModule.h"
|
2023-04-21 17:43:44 -04:00
|
|
|
#include "MaterialShared.h"
|
2014-05-22 11:33:54 -04:00
|
|
|
|
|
|
|
|
#include "Materials/MaterialExpressionComment.h"
|
|
|
|
|
#include "Materials/MaterialExpressionParameter.h"
|
Copying //UE4/Release-Staging-4.19 to //UE4/Dev-Main (Source: //UE4/Release-4.19 @ 3944462)
#lockdown Nick.Penwarden
============================
MAJOR FEATURES & CHANGES
============================
Change 3944462 by Jack.Porter
Prevent TVOS packaging from PC from attempting to build an asset catalog
#jira UE-56114
Change 3943602 by Leslie.Nivison
Adding licenses for additional TPS
#jira none
Change 3943597 by Leslie.Nivison
Adding Enterprise licenses; licenses for additional TPS.
#jira none
Change 3941962 by Leslie.Nivison
Updating 4.19 credit list
#jira none
Change 3941865 by Mark.Satterthwaite
Fix the incorrect landscape rendering and the incorrect render-to-texture from blueprint bugs with MetalRHI.
- Track outstanding AsyncCopyBufferFromBufferToBuffer operations to identify attempts to modify overlapping ranges within the same prologue command-buffer. This doesn't work and requires that we break the current render-pass and issue on the current command-buffer. A log warning will be emitted when this occurs.
- Don't attempt to alias private memory buffers the moment they are released from the RHI resource because that can lead to incorrect sharing of the memory when used by AsyncCopyBufferFromBufferToBuffer.
#jira UE-56021
Change 3940993 by Marc.Audy
Do not return the last column if the specified column does not exist.
Allow display names to be used when looking for a property if the table is backed by a user defined struct.
Do not crash if a property with the given name is not found.
#jira UE-56017
Change 3939179 by Ben.Marsh
Revert change to not poison memory in development configuration. Making a tradeoff that editor stability and consistency is more important than performance.
#jira
Change 3938566 by Aaron.McLeran
#jira UE-55940 Fix for wavetable synth
Missed a case.
Change 3938533 by Dan.Oconnor
Fix uninitialized variable exposed by recent MallocTBB change
#jira UE-56013
Change 3938508 by Aaron.McLeran
Fixing CIS error, init order issues.
#jira UE-55940
Change 3938490 by Aaron.McLeran
#jira UE-55940 Fix for wavetable synth
Change 3938352 by josh.jensen
Show an error message for Windows iOS builds when packaging/launching and icons are present but no remote Mac is specified
#jira UE-55987
Change 3938345 by Peter.Sauerbrei
fix to Icons not being built on Mac
#jira UE-53492
Change 3938305 by Mark.Satterthwaite
For whatever reason moving the buffer initialisation into the prologue command buffer doesn't work - this make absolutely no sense to me. I suspect that this is *merely* moving a render pass boundary around somewhere and forcing raster-state to be reapplied.
#jira UE-56005
Change 3937968 by Ben.Marsh
Disable the boot DDC if we're not in the editor. Fixes access violations when multiple SCW instances attempt to read/write to the same file.
#jira UE-56003
Change 3937573 by Mitchell.Wilson
Saving asset to resolve empty asset warning.
#jira UE-56004
Change 3937561 by Max.Preussner
ImgMedia: Added support for single-threaded platforms
Copied from Dev-Sequencer CL# 3937516
#jira UE-55986
Change 3937305 by Mike.Beach
Resaving google VR model content with UGS build to fix the empty file version error.
#jira UE-55984
Change 3935595 by Arne.Schober
Fix missing UV precission on BSP surfaces
#jira UE-54014
Change 3935411 by josh.jensen
Fixed Windows iOS remote Mac build issue where the user icons were considered remote Mac compilation targets coming solely from the Engine directory
#jira UE-55899
Change 3934982 by Marc.Audy
Fix shadow variable issue
#jira UE-55957
Change 3934892 by Mark.Satterthwaite
In MetalRHI treat BUF_Volatile buffers as Shared or Managed memory in all circumstances so that multiple updates within a render pass are respected even though this will hurt CPU performance. This fixes GPU particles on macOS. Also push initialisation upload into the async. command buffer to avoid it overwriting a later Lock/Unlock! Only read-back and copy-buffer operations should be on the 'current' command buffer as they need to be inline with all outstanding commands.
#jira UE-55956
Change 3934421 by Arciel.Rekman
Fix lockup/OOM when setting audio sources to 2 (UE-53968).
#jira UE-53968
Change 3934156 by Peter.Sauerbrei
fix for backgrounding problems on iOS and tvOS
this will re-open UE-50979 as the fix for that was not correct and would have caused crashes when backgrounding during startup
#jira UE4-55609
Change 3933547 by Aaron.McLeran
#jira UE-55940 Fix for wavetable sample duration and seek
Change 3933544 by Aaron.McLeran
#jira UE-55939 Hiding channel format
Submix channel format is an experimental feature and shouldn't be exposed to the submix editor for 4.19.
Change 3933540 by Aaron.McLeran
#jira UE-55718 Fix for playback progress.
Change 3933280 by Ethan.Geller
[Release-4.19] #jira UE-55810 Ensure AudioComponent is created before we start using it. #rb Aaron.McLeran
Change 3933079 by Ryan.Vance
#jira UE-55936
Fixed missing referenced uniform bindings on AR pass-through camera shaders.
Change 3932319 by Ben.Zeigler
#jira UE-55885 Fix corruption of packages when starting and then cancelling an async load of a package that already exists, or attempting to async load a script package
It now keeps track of which packages were created by the async load system and will only throw those away on cancel
Copy of CL #3932312
Change 3932287 by Matt.Kuhlenschmidt
Updated substance texture
#jira UE-55081
Change 3931729 by josh.jensen
Ensure the tvOS and iOS Assets.car is always produced as part of a regular remote/local build
#jira UE-55899
Change 3929723 by josh.jensen
Removed packaging requirement on Windows of a remote Mac after setting an app icon to default
#jira UE-53495
Change 3929722 by josh.jensen
Fixed iOS asset catalog generation issues when swapping out/resetting to default app icons for both code- and BP-projects
#jira UE-53492, UE-51879
#robomerge
Change 3929350 by Mike.Erwin
"Save As" support for
#jira UE-55732
Change 3927829 by Steve.Robb
Out-of-memory handler for MallocStomp.
#jira UE-55550
Change 3926404 by Mike.Erwin
#jira UE-55732
Change 3926394 by Dan.Oconnor
Recompile bytecode dependencies when compiling an individual blueprint interface, this prevents crashes due to stale bytecode
#jira UE-55813
Change 3926098 by Guillaume.Abadie
Do not allow dynamic resolution to be enabled on unsupported platforms avoiding game breaker experience by security.
#jira UE-55697
Change 3925927 by Guillaume.Abadie
Enables TAA's AA_BORDER on all permutation for dynamic resolution.
#jira UE-55353
Change 3925882 by Matt.Kuhlenschmidt
Fix substance uri having one extra /
Fix substance menu option showing up for github (incompatible with plugin)
#jira UE-55766
Change 3925873 by Ben.Zeigler
#jira UE-55783 Fix issue introduced in 4.18 where user structs did not handle converting AssetPtrs to SoftObjectPtrs properly
Copy of CL #3925871
Change 3925163 by Guillaume.Abadie
Fixes DFAO's temporal AA passes that was handling FViewInfo::ViewRect.Min wrongly.
#jira UE-55788
Change 3924839 by Guillaume.Abadie
Fixes a crash of LDR android preview with OS DPI scale != 0.
#jira UE-43622
Change 3924542 by Cosmin.Sulea
Merged fixes:
UE-55299 - XGE Shader Compile Interferes with Remote Shader Compiling Causing Materials to Fail to Compile #7
UE-51086 - No clear editor activity during remote shader compiling
#jira UE-55299
Change 3922398 by Mark.Satterthwaite
Compile fix for 3922273.
#jira UE-53993
Change 3922273 by Mark.Satterthwaite
Fix validation error caused by the game updating its orientation before the drawable system catches up. We need to drop drawables that are incorrectly sized until we get one with the correct size.
#jira UE-53993
Change 3921127 by Ethan.Geller
[Release-4.19] #jira UE-55744: Add OnTick virtual to IAudioPluginListener, fix thread safety issue in Resonance Audio. #rb aaron.mcleran
Change 3920632 by Lina.Halper
Fix render thread crash when morphtarget is deleted or added
#jira: UE-55521
Change 3920557 by Lauren.Ridge
Fixing material editor resetting background to off
#jira UE-55267
Change 3920519 by Phillip.Kavan
Fix a regression in which elements would not be initialized when constructing the value assignment for UDS-typed container members in nativized Blueprint C++ code.
Change summary:
- Modified FEmitDefaultValueHelper::InnerGenerate() to remove UDS from the list of special cases that avoid calling InitializeStruct() as part of new element construction. Previously the conversion code assumed the compiler would perform value initialization of a nameless temporary, but that is no longer valid in 4.19, as UDS types have been changed to function more like native structs, and as such all converted UDS types will now emit an explicit default ctor which is now used to assign defaults that differ from the zero-initialized value.
#jira UE-55628
Change 3920476 by Michael.Trepka
Clean up Mac menu item cache at exit before SlateApplication is fully destroyed.
#jira UE-55599
Change 3920336 by Ben.Marsh
Ignore license warnings from PVS-Studio.
#jira UE-55729
Change 3920134 by Jurre.deBaare
Moving over:
"HLOD: Building HLOD for P map with sublevels requires HLODSetupAsset when it should not
#fix Ensure that we dynamically add HLOD level treeview items whenever they are required, rather than adding a static number of levels according to the worldsettings"
#jira UE-55619
Change 3920126 by Max.Preussner
MediaCompositing: Implemented media track for Sequencer
Copied from Dev-Sequencer
#jira UE-53974
Change 3920004 by Jack.Porter
Disable Manual Vertex Fetch SRV creation when MVF is disabled.
Made a single RHISupportsManualVertexFetch(EShaderPlatform) to control whether to use MVF. The Shader Platform (or alternatively, feature level) is the only thing that can decide whether or not to use MVF because we need to know when we compile the shaders if we're going to do MVF or not. Checking GSupportsResourceView at runtime is useless because the shaders can't change and so if GSupportsResourceView can ever be false for a platform, the shaders need to have been built without it.
Creating SRVs without using them on mobile is not harmless because several devices don't support formats that are needed.
#jira UE-54764
#jira UE-55622
Change 3919069 by Aaron.McLeran
#jira UE-55718 Fix for playback progress.
Change 3918942 by Graeme.Thornton
Added "ProjectBuildMutatorFeature" modular feature, allowing plugins to register said feature and dictate whether the current project requires a code build. CryptoKeys plugin uses this feature to force a code build when encryption or signing is enabled.
#jira UE-55686
Change 3918721 by Zak.Parrish
Lighter version map for Gremlin + new Engine.ini - result is 60Hz #jira none
Change 3918236 by Joe.Graf
Added a bFlipTrackedRotation to give a better result when mirroring the rotation of a tracked face
#jira: UE-55531
Change 3917970 by Martin.Wilson
Expose curve data in remap assets to blueprints
#jira UE-55585
Change 3917740 by Olaf.Piesche
Properly checking for presence of buffer SRV capability via GSupportsResourceView so ES3.1 and Metal devices don't crash using GPU particles (and possibly in other circumstances);
#jira UE-55591
Change 3917713 by Cody.Albert
Build fixes for Match3 on iOS
#jira UE-53742
Change 3917472 by zak.parrish
added mouthPressLeft and MouthPressRight back into debug screen #jira none
Change 3917244 by Michael.Dupuis
#jira UE-35097: Fixed crash when creating a new landscape with 2x2 subsections and material containing grass spawning node
Change 3916775 by Ben.Marsh
Add missing files for packaging IOS on Windows.
#jira UE-53873
Change 3916293 by Joe.Graf
Removed the redundant GetTransform() from UARFaceGeometry since GetLocalToWorldTransform() is exposed on a base class
#jira: UE-55531
Change 3916011 by Joe.Graf
Added an accessor to get the transform of the face mesh or a face mesh component
#jira: UE-55531
Change 3915967 by Mark.Satterthwaite
Place buffer updates into the prologue command-buffer in MetalRHI to avoid breaking the current command-encoder. This improves performance, though the semantics of Metal now differ subtly to other RHI implementations as the buffer updates happen prior to the SetRenderTargets call in the GPU's view of the world.
#jira UE-54858
Change 3915751 by Nick.Atamas
Merging CL 3913931 from //UE/Partner-Google-VR/... to //UE4/Release-4.19/...
#jira UE-55639
Change 3915421 by Martin.Wilson
Fix crash from live link message bus heartbeat manager
#jira UE-55644
Change 3915326 by Dan.Oconnor
Make compilation manager's skeleton class layout better match the old compilation path's skeleton class layout, fixes a crash when renaming blueprint functions
#jira UE-55592
Change 3915250 by JeanLuc.Corenthin
Can't add C++ code to Enterprise projects (when enterprise is installed)
Root cause: When compiling a C++ project, Datasmith modules are included in the build process (with the wrong path)
Fix:
- Added two more Enterprise directories, Plugins and Intermediate, to the Enterprise directories to check against
- Build the correct path for the Datasmith modules and plugins in FindOrCreateModuleByName. Added check to see if module is under one of the Enterprise directories.
- Added modules to list of precompiled modeules in UEBuildTargets.AddPrecompiledModules if Engine and Enterprise are 'installed and the module is under Enterprise.
#jira UEENT-1032
Change 3915240 by Ben.Marsh
Reduce editor startup times by ~15s on Windows.
Platform loading code recursively scans every module for dependent DLL modules to load first. Change to make it early-out as soon as it encounters a module which is already in memory (via a call to GetModuleHandle() from ResolveMissingLibraryImportsRecursive). Also use a TSet<> to store set of visited modules rather than an Array.
Now spends <0.1s total in this function on editor startup.
(Change looks larger than it is due to moving functions out of WindowsPlatformProcess.h to avoid introducing TSet dependency into this header).
#jira UE-55642
Change 3914803 by Gil.Gribb
UE4 - Removed memory track from the lock free list links. This is not safe and will sometimes assert in debug.
#jira UE-49600
Change 3914616 by zak.parrish
Adding Calibrate button #jira none
Change 3914599 by Andrew.Rodham
Sequencer: Sequence template source signatures are now also compared to catch the case where a sub-sequence asset has been saved but not modified
- The following sequence of events exposes this issue:
- Create a master sequence with a single shot that spawns a cube
- Add this sequence to a level and set it to auto-play
- Save everything and restart
- Resave just the inner shot asset without opening it
- PIE
- The inner shot never spawns its cube because its template was wiped on save, but its signature never changed. Since the master sequence previously didn't check the template source signature, it ends up trying to evaluate an empty template.
#jira UE-55626
Change 3914479 by Krzysztof.Narkowicz
Added encoded HDR reflection capture cooking if targeting ES 2.0/3.1 on Windows
#jira UE-53875
Change 3914347 by Martin.Wilson
Stop anim preview instance from ever running in parallel
#Jira UE-55577
Change 3914179 by Benn.Gallagher
Fixed clothing sections not displaying in LOD section list in skeletal mesh editor, due to no longer duplicating clothing sections in the model data.
#jira UE-55528
Change 3914122 by Steven.Barnett
Fix perf regression in BSP queries by changing suppression of PhysX mesh cleaning failure message.
#jira UE-54081
Change 3913950 by zak.parrish
Clamping my normalization math #jira none
Change 3913926 by Zak.Parrish
First pass at Gremlin Calibrate button. Also added shirt/backpack to boy so he's not a floating head. #jira none
Change 3913668 by Matt.Kuhlenschmidt
Adding missing substance styling info
#jira UE-55081
Change 3913667 by Nick.Atamas
Merging CL 3912976 from //UE4/Partner-Google-VR/... //UE4/Release-4.19/...
Upgrading to support ARCore 1.0 runtime.
#jira UE-55602
Change 3913645 by Aaron.McLeran
#jira UE-55618 fix for mono audio devices
Change 3913509 by Cody.Albert
Removing PhsX build exclusion from Match3
#jira UE-53742
Change 3913380 by Dan.Oconnor
Preload Sequence Bindings node at proper time
#jira UE-55412
Change 3913300 by Mitchell.Wilson
Updating iOS default startup movie to H.264, 1280x720, 30 fps.
#jira UE-55382
Change 3913291 by Cody.Albert
More iOS build fixes for Match3
#jira UE-53742
Change 3913169 by Cody.Albert
Fixed iOS build issues for UnrealMatch3
#jira UE-53742
Change 3913131 by Krzysztof.Narkowicz
Fixed remaining quad overdraw viewmode contents on screen after switching to certain other viewmodes (e.g. light overlap or complexity)
#jira UE-54580
Change 3912851 by Lina.Halper
Fixed issue with pose asset blending additively multiple poses suming up to 1 weight.
#jira: UE-55603
Change 3912629 by Guillaume.Abadie
Fixes SSR that was computing vigneting according to PrevScreen that could let some outside viewport samples going through when rotating the camera.
#jira UE-55353
Change 3912170 by Martin.Wilson
Add logging for UE-55511 (NaN crash)
#jira UE-55511
Change 3912161 by Phillip.Kavan
Fix editor-only default subobjects inherited from a native C++ parent class not being handled correctly during nativized Blueprint class ctor generation.
Change summary:
- Modified FEmitDefaultValueHelper::HandleSpecialTypes() to skip editor-only checks for instanced default subobjects. These will have already been created by a native parent class.
- Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert before creating a "dummy" component in place of an editor-only instance if we're not supposed to be creating it.
#jira UE-55474
Change 3912100 by Luke.Thatcher
[RELEASE] [^] Merging (as edit) fix for building pak patches (CL 3911754) from //UE4/Dev-Core to //UE4/Release-4.19
#jira UE-55340
Change 3912072 by Mike.Beach
Art cleanup pass on AR template icon.
#jira UE-55587
Change 3912057 by Michael.Trepka
Additional widget path validity check in FSlateUser::NotifyWindowDestroyed()
#jira UE-55580
Change 3911592 by Jurre.deBaare
Crash on merge actor when Use specific LOD Level
#fix make sure we use the correct array to determine the number of components being merged
#jira UE-55508
Change 3911466 by Cosmin.Sulea
Mega change list for the following related issues:
UEMOB-417 - Support Xcode automagical code signing
UE-49829 - Remote build fails to use / sign distribution provisions coming from PC
UE-39501 - Packaging for tvOS in Distribution fails to find valid provision
UE-55334 - XCode managed provisions don╞t operate gracefully with manual provisions
UE-55330 - Automatic signing doesn't work with tvOS
UE-10969 - Remote build fails if there is no development provision provided
#jira UEMOB-417
Change 3911454 by Luke.Thatcher
[RELEASE] [!] Fix rendering thread memory leak in FLandscapeComponentSceneProxy::InitViewCustomData
- FViewCustomDataLOD is allocated on a memstack, but contains a TArray, so is not trivially destructible.
- The SubSections array is leaked when the memstack is popped.
- Fix replaces the TArray with a TStaticArray of max size MAX_SUBSECTION_COUNT (which is 4).
(Merging as edit CL 3911422 from //Fortnite/Release-3.1/... to //UE4/Release-4.19/...)
#jira UE-54835
Change 3911370 by Dragan.Jerosimovic
changed browOuterLeft -> browOuterUpLeft, browOuterRight->browOuterUpRight
updated KiteBoyHead_JointsAndBlends.fbx
#jira none
Change 3910545 by Dan.Oconnor
PR #4512: Fix FNetNameMapping::GetUniqueName regression (Contributed by dfb)
#jira UE-55513
Change 3910449 by Michael.Trepka
Fix for crash on exit on Mac when closing the root editor window with Cmd+W
#jira UE-54973
Change 3909601 by Patrick.Boutot
Expose to Blueprint GetProjectDirectory functions.
#jira UE-55548, UEENT-999
Change 3909543 by Patrick.Boutot
Rename ECollisionResponse to CollisionResponseType in script to prevent collision with FCollisionResponse.
Python's help function now output the Python type instead of the cpp type.
Do not export hidden enum entry from Python.
#jira UE-55545, UEENT-961
Change 3909289 by Zak.Parrish
Adding shirt/chest to faceAR sample #jira none
Change 3908808 by Dragan.Jerosimovic
added combination shapes network
#jira none
Change 3908788 by Mitchell.Wilson
Updaing Match3Camera to resolve clipping issue on iPhone X
#jira UE-54723
Change 3908374 by Jack.Porter
Fix viewport offset problem for preview PIE window
#jira UE-52583
Change 3907108 by Shane.Caudle
#JIRA
Added DefaultDeviceProfiles.ini to set the [IOS DeviceProfile]
+CVars=r.ShadowQuality=4
Change 3907105 by Lauren.Ridge
Fix for thumbnails not resetting when layers/blends reset and for them being incorrectly scaled when null
#jira UETOOL-1303
Change 3907011 by Chris.Phillips
UE-52667 Unable to package an Android DLC Using "Android APK" and "Android DLC" profiles in Project Launcher.
#jira UE-52667
Change 3906792 by Lauren.Ridge
When constructing the material editor viewport, use the direct method to set the environment visibility.
#jira UE-55267
Change 3906734 by Chris.Babcock
Fix issue with vertex fetch disable
#jira UE-55475
Change 3906721 by Rolando.Caloca
UE4.19 - Check if the results file from SCW is corrupt
#jira UE-53124
Change 3906648 by Chris.Phillips
UE-53184 Assertion when running mobile PIE in iPhone 5S mode.
Updated the iPhone5s.json Metal settings.
#jira UE-53184
Change 3906474 by David.Hibbitts
Added default constructor for FLiveLinkWorldTime.
#jira UEENT-879 #rb none
Change 3906467 by Lauren.Ridge
Swapping sibling materials now correctly swaps the overridden parameters out
#jira nojira demobug
Change 3906156 by Michael.Trepka
Reverting CL 3728924 as it's causing problems with modal windows. A different, much more involved fix for UE-51711 will be needed.
#jira UE-52492
Change 3906144 by Michael.Dupuis
#jira UE-54547: Added guard to be sure that material is valid
Change 3905882 by Matt.Kuhlenschmidt
Enable substance buttons again
#jira UE-55081
Change 3905513 by Sorin.Gradinaru
UE-55394 iOS crash exiting app during startup movie: SPRINGBOARD, process-exit watchdog transgression
#jira UE-55394
#jira UE-52328
#iOS
#4.19
This is a particular case of UE-52328 iOS reporting crash on application exit: SPRINGBOARD, process-exit watchdog transgression
Found several issues on iOS if the game is forced closed when the startup movie is playing and "Wait for movies to complete" is enabled in Project Settings
- the game thread is waiting for the movie to complete on game shutdown - more that 5 sec
- crash on FDefaultGameMoviePlayer::Shutdown if the above is fixed
- HTTP module no longer has time to wait for the requests to complete.
Change 3905506 by Michael.Dupuis
Remove static mesh instancing async buffer filling, as with all the changes made, it's no longer necessary, the cost of loading very large buffer is negligable
Rebuild the occlusion tree when using foliage.DensityScale with something other than 1.0
#jira 0
Change 3905498 by Lina.Halper
Fix multiple pose asset issue - fallout from CL 3903509
- as for fullbody, went back to old mathod because in the fullbody, we want shortest path most of times and you don't blend more than 1 weight, so this is likely fine
- as for additive, change to use blend from identity.
#jira: UE-55439, UE-55448, UE-55250
Change 3905325 by Sorin.Gradinaru
UE-54764 UnrealMatch3 spams Kindle device log with "Unsupported EPixelFormat"
#jira UE-54764
#4.19
Also reproduced on Samsung Galaxy S5 Neo (SM-G903F, GPU Mali-T720).
Check GMaxRHIFeatureLevel > ERHIFeatureLevel::ES3_1 (not mobile) before creating RSV params used with SupportsManualVertexFetch: (Positions, Tangents, TextureCoordinates, Color buffers)
Change 3905307 by Jack.Porter
Removed iPhone5 PIE json file as it's not a supported device
#jira UE-53184
Change 3905132 by Shane.Caudle
#JIRA
Pushed it a little more out of the yellow.
Change 3905117 by Shane.Caudle
#JIRA
Got SSS working and made some tweaks.
Change 3904936 by Max.Chen
Fix editor only
#jira UE-55459
Change 3904269 by Chris.Babcock
Disable manual vertex fetch on mobile
#jira UE-55389
#ue4
#android
#ios
Change 3904186 by Lina.Halper
Pose asset crash when skeleton not existing during serialization
#jira: UE-55422
Change 3904063 by Max.Chen
Sequencer: Fix copy/paste crash. Only process UMovieSceneCopyableBinding and objects that can be spawned by the movie scene spawn register.
Copy from Dev-Sequencer
#jira UE-55314
Change 3904060 by Lauren.Ridge
Fix for saving a child out of a layer stack capturing the wrong parameters
#jira UETOOL-1280
Change 3904050 by Luke.Thatcher
[CONSOLE] [^] Added RHI Command List Enqueue Lambda method (merging as edit CL 3879722 from //Fortnite/Main to //UE4/Release-4.19)
- Can be used to enqueue arbitrary tasks on the RHI thread from the render thread (similar to how EURC works for GT -> RT tasks), without having to write lots of bolierplate FRHICommand functor classes.
- The first overload of EnqueueLambda method will check Bypass() to determine if it should run the lambda immediately or defer to the RHI thread.
- This can be overriden via the 2nd overload if you need to check additional things such as IsRunningRHIInSeparateThread.
- The function returns true if the lambda was enqueued and deferred to the RHI thread, otherwise false. This can be used to optionally add RHIThreadFences for unlock commands etc.
#jira UE-55437
Change 3904004 by Lauren.Ridge
Fix for material layer output nodes being able to be placed in other graphs
#jira UE-54867
Change 3903931 by Aaron.McLeran
#jira UE-55435 Crash in google resonance when toggling visualization
fix for issue described here -- https://github.com/resonance-audio/resonance-audio-unreal-sdk/issues/1
Change 3903722 by David.Hill
The ProxyLOD plugin is experimental: don't load it by default.
#jira: ue-55402
Change 3903583 by Ben.Marsh
Include .version and .modules files in manifest. Should fix missing version information in precompiled binaries.
#jira
Change 3903529 by Richard.Hinckley
#jira UEDOC-7180
4.19 API Documentation manual update.
Change 3903509 by Lina.Halper
Merging using //UE4/Dev-AnimPhys/->//UE4/Release-4.19/
#DUPE MERGE: Fix issue with pose blending with shortest path - causing additive to blend linearly between pose if the rotation is same direction.
#jira: UE-55250
Change 3903501 by Michael.Dupuis
#jira UE-55122: Fixed bad neighbors updating for mobile
Change 3903387 by Will.Fissler
; r.XGEShaderCompile is now enabled by default in source. Uncomment to disable XGE shader compilation.
;r.XGEShaderCompile = 0
#jira UE-55286
Change 3903251 by Sungjin.Hong
#JIRA UE-55349
#loc added KO locallization for VR, Handheld AR templates
Change 3903219 by Adrian.Siminciuc
https://jira.it.epicgames.net/browse/UE-54738
removed redundant iOS warning when IOnlineIdentity::Login is called by FOnlineExternalUIIOS::ShowLoginUI
#jira UE-54738
#iOS
Change 3903130 by Cody.Albert
Updated build configuration to resolve iOS build error on UnrealMatch3
#jira UE-53742
Change 3903056 by Shane.Caudle
#JIRA
Latest tweaks to lighitng and rendering for boy.
Change 3903032 by Cody.Albert
Added missing include that was preventing iOS builds from succeeding on TopDown template
#jira UE-54341
Change 3902669 by Lauren.Ridge
Fix for thumbnail crash after saving material instances that contain layers
#jira crash
Change 3902581 by Mitchell.Wilson
Updating Samples and Template Min iOS Version to iOS 9.
#jira UE-55148
Change 3902448 by Lauren.Ridge
Fix for crash due to unparented material instance
#jira crash
Change 3902206 by Chris.Phillips
UE-52612 External textures only work in pixel shaders.
Sampling external textures are now only limited to pixel shaders when the shader model is < SM4.
#jira UE-52612
Change 3902120 by Peter.Sauerbrei
bvringing over the fix for backgrounding crash on iPhone X from Fortnite
#jira UE-54883
Change 3902097 by Lina.Halper
Merging using //UE4/Dev-AnimPhys/->//UE4/Release-4.19/
#DUPE MERGE: CL 3901939
#jira: UE-55401
Change 3902082 by Mike.Beach
Fixing an issue with the fix from CL 3889470 - fully matching the old UEnum name check (checking both the value name and the typed name, for example: "Left" and "EControllerHand::Left").
#jira UE-55153
Change 3901963 by Peter.Sauerbrei
bring over the fix from Fortnite for Remote Shader Compilation not respecting settings in the passed in shader
#jira UE-52797
Change 3901959 by Ethan.Geller
[Release-4.19] #jira UE-55225: Stop RtAudio stream on StopRecording in sequence recorder. #rb Aaron.McLaren
Change 3901482 by Lauren.Ridge
Fix for crash on opening materials due to array out of bounds
#jira crash
Change 3901181 by Michael.Dupuis
#jira UE-55313: To enable tessellation we MUST have 2 materials in the list
Change 3900935 by Nick.Bullard
Updating Default_Startup.mp4 with more recent UE branding.
This still requires another update for final version with audio
#jira UE-55382
Change 3900660 by Aaron.McLeran
#jira UE-55381 crash in sound submix
Bringing fix from FN to 4.19 (CL 3890630)
Change 3900643 by Aaron.McLeran
#jira UE-55380 fixing synth envelopes
Change 3900617 by Aaron.McLeran
#jira UE-55151 Fixing crash w/ mic component
Change 3900544 by tim.gautier
QAGame: Submitting asset for AsNumber fix submitted with UE-10310
#jira UE-29618
Change 3900430 by Ryan.Brucks
KismetRenderingLibrary: Applied a fix from FN to make it possible to create textures from BP created RTs. Without the fix the assets would be created but invisible to the user due to missing RF_Public and RF_Standalone.
#JIRA none
Change 3900399 by Lauren.Ridge
Fixing global parameters not working
#jira UE-55242
Change 3900297 by Ben.Marsh
Speculative fix for hot reload causing version files to be updated with a locally made installed build.
#jira UE-55072
Change 3900116 by Chris.Bunner
Removing outdated tests and test assets.
#jira UETOOL-1298
Change 3900042 by Chris.Bunner
Deleted SharedInputCollection and associated material graph nodes.
#jira UETOOL-1298
Change 3899887 by Lauren.Ridge
Fix for background checkbox stomping profile info for material editor. Note that you may have to delete Saved/Config/Windows/Editor.ini to get this to work.
#jira UE-55267
Change 3899824 by Chris.Phillips
UE-52813 Editor's mobile preview doesn't serialize the landscape's cooked heightmap data.
Now only regenerating landscape pixel data when needed when using Mobile Preview Rendering Levels.
#jira UE-52813
Change 3899775 by Lauren.Ridge
Fix for crash on opening material layer material
#jira crash
Change 3899673 by Jamie.Dale
Fixed Functions sometimes being exposed to Python as if they were Structs
#jira none
Change 3899487 by Chris.Bunner
Duplicate [CL 3852020, 3896571] - Disabling non-performant code only required by experimental material layers feature. Users can opt-in per-project through experimental renderer settings, replacing the previous editor experimental flag.
#jira UETOOL-1298
Change 3899156 by Phillip.Kavan
Include address of object reference in persistent frame debug info.
#jira UE-51952
Change 3899146 by Rolando.Caloca
UE4.19 - hlslcc - Workaround for intrinsics with two output arguments
#jira UE-52477
Change 3899060 by Bart.Hawthorne
Add a null check for the game mode pointer in UWorld::SpawnPlayActor
#jira UE-54461
Change 3899015 by Krzysztof.Narkowicz
Fixed initialization of instancing random vertex stream.
#jira UE-53605
Change 3899008 by Michael.Dupuis
Fix issue with landscape mobile vertex factory accessing unbound LodTessellationParams when r.ShaderDevelopmentMode=1
#jira 0
Change 3898994 by Phillip.Kavan
More verbose debug logging if an invalid object reference is detected in the BP ubergraph frame during garbage collection.
#jira UE-51952
Change 3898962 by Guillaume.Abadie
Fixes wrong parameters about whether GPU timing may have CPU generated bubbles to the dynamic resolution heuristic.
#jira UE-55352
Change 3898826 by Sorin.Gradinaru
UE-54784 StrategyGame crashes entering game on KindleFire 7 - Assertion failed: ViewSize.GetMin
#4.19
#Android
#jira UE-54784
Wrong code to make an integer even + operator precedence
Change 3898822 by Sorin.Gradinaru
UE-52328 iOS reporting crash on application exit: SPRINGBOARD, process-exit watchdog transgression
FORT-70783 FHttpManager::Flush is immediately canceling all HTTP requests
#jira UE-52328
#jira FORT-70783
#iOS
#PC
#4.19
UE-52328 reopened because of FORT-70783
iOS only: Delay Request->CancelRequest() on Http module shutdown - wait for 2 sec on FHttpManager::Flush to allow pending requests to be sent to the server.
Change 3898705 by Max.Chen
Sequencer: Skip if the binding id's sequence can't be found.
#jira UE-55337
Change 3898108 by Michael.Dupuis
#jira UE-54547: Remove the FORCEINLINE so we get a proper callstack of what's happening
Change 3898076 by Max.Chen
Sequencer: Override the animation asset in the player state if it doesn't match the animation asset that's being evaluated.
#jira UE-55328
Change 3897897 by Matt.Kuhlenschmidt
Disable substance buttons for now
#jira UE-55081
Change 3897742 by Aaron.McLeran
Merging fix for UE-55223 to 4.19
#jira UE-55223
Change 3897538 by Michael.Dupuis
#jira UE-53787: Added guard if for some reason the material is null we should not try to draw using this material
Change 3897406 by Phillip.Kavan
Back out local debug logs.
#jira UE-51952
Change 3897400 by Phillip.Kavan
Serializing object will now be passed to GC so that it can be logged in case the referenced objects is garbage.
- Mirrored from //UE4/Dev-Core (3871863).
#jira UE-51952
Change 3897391 by Max.Chen
Sequencer: Don't update current time to be within the view range when stepping into a sequence.
#jira UE-55322
Change 3897274 by Krzysztof.Narkowicz
Fixed issues with loading shaders from DDC - hardcoded CustomAttributes initialization instead of filling them inside UObject costructors in order to properly initialize CustomAttributes before DDC key was created. Added an assert that CustomAttributes are initialized before the AttributeDDCString, so we won't run into this issue again in the future.
#jira UE-54683
Change 3897148 by Adrian.Siminciuc
https://jira.it.epicgames.net/browse/UE-55147
#4.19
#iOS
#jira UE-55147
Change 3897138 by Max.Chen
Sequencer: Fix crash when an actor factory is not found.
Copy from Dev-Sequencer
#jira UE-55309
Change 3897045 by Jack.Porter
Fix for crash in ALandscapeProxy::UpdateGrass
#jira UE-54362
Change 3897036 by Jack.Porter
Fix InstancedStaticMesh crash with invalid lightmap coordinates
#jira UE-54423
Change 3896801 by Dmitriy.Dyomin
Fixed: Planar reflections does not handle origin rebasing
#jira UE-52351
Change 3896743 by Dmitriy.Dyomin
Discard CPU copy of vertex/index buffers in OpenGL RHI
#jira UE-52133
Change 3896619 by Guillaume.Abadie
Cherry-pick 3896598: Fixes after TAAU post process material that had wrong default buffer UV.
#jira UE-55317
Change 3895718 by Max.Chen
Sequencer: Null checks to prevent crash when saving the default state of a spawnable
#jira UE-55304
Change 3895426 by Rolando.Caloca
UE4.19 - Add an increased timeout for SCW to avoid OOM situations
#jira UE-55306
Change 3895245 by tim.gautier
QAGame: Submitting updated test assets. Broke ML_Base out into individual components
#jira UE-29618
Change 3895194 by Marc.Audy
Prevent crash due to a null entry in the linked to graph of the destination pin
#jira UE-54606
Change 3894913 by Arne.Schober
REL - Fix crash in Speedtree wind where Renderdata is unavailable
#jira UE-54544
Change 3894625 by Arne.Schober
REL - Fix assert not in RenderingThread from Triangle Renderer.
#jira UE-55247
Change 3894464 by Martin.Wilson
Extra debugging info for UE-54705 plus remove check so it is no longer fatal
#jira UE-54705
Change 3894450 by Martin.Wilson
Remove pinnable ness of retarget asset. Paves the way for exposing retarget asset properties on the node
#jira none
Change 3893948 by Jostin.Bilyeu
Adding default player start location to help with launch on testing within level TM-Materials_POM
#jira UE-55063
Change 3893495 by Robert.Manuszewski
Fixing a crash when running DDC commandlet
#jira UE-54646
Change 3893451 by Jurre.deBaare
Altered fix for actor merging with negative scaling to get correct normals
#jira UE-54996
#misc updated automated test to include this test-case
Change 3892913 by Ethan.Geller
[Release-4.19] #jira UE-55151 Fix for Mic Component crashing on re-init. #rb aaron.mcleran
Change 3892871 by Ryan.Vance
Multi-view requires the day dream compositor.
#jira UE-55253
Change 3892785 by Arciel.Rekman
Linux: fix inability to create a C++ project (UE-55222).
- NullSourceCodeAccessor will unconditionally allow C++ project creation in source builds.
- Installed build will check for more compilers in commonly found locations.
#jira UE-55222
Change 3892687 by Jostin.Bilyeu
Checking in replacement Built Data for map TM-Materials_POM
#jira UE-55063
Change 3892674 by Jostin.Bilyeu
Adding an invisible plane to TM-Materials_POM to help testing on mobile devices
#jira UE-55063
Change 3892622 by Aaron.McLeran
#jira none Fixing scope lock in phonon probe volume
Change 3892511 by Matt.Kuhlenschmidt
Fix zero engine version warning
#jira UE-55081
Change 3892211 by Yuriy.ODonnell
Fix/workaround for inconsistent preprocessor definitions for NVAftermath that result in FD3D11DynamicRHI class layout mismatch. NVAftermath support is now enabled by default for Win64.
NVAftermath is declared as a private dependency in D3D11RHI. It does not automatically propagate to modules that explicitly include private RHI headers (OculusHMD, OSVR, OSVRInput). This results in NV_AFTERMATH being defined while compiling RHI module and not defined when compiling other modules, causing memory corruption at runtime.
The long-term solution for this and similar issues requires some mechanism for adding transitive module dependencies, so that anyone that depends on D3D11RHI module would automatically also get the NVAftermath. Additionally, private headers should *never* be included directly by external modules.
The short-term solution is to explicitly add NVAftermath dependency to OculusHMD, OSVR and OSVRInput.
Additionally, NV_AFTERMATH is no longer forced by D3D11RHIPrivate.h when it's not defined. This allows catching this kind of mismatch in the future through a compiler warning (C4668).
#jira UE-53065
Change 3891732 by Brian.Zaugg
Re-adding iPhoneX launch images with correct case.
#JIRA UE-53541
Change 3891727 by Arne.Schober
REL - Do not recreate one Frame Resource for dynamic draws
#jira UE-55063
Change 3891716 by Ben.Marsh
Fix buffer overrun when generating callstack.
#jira
Change 3891697 by Brian.Zaugg
Deleting iPhoneX launch images that have incorrect case.
#jira UE-53541
Change 3891678 by Brian.Zaugg
IPP binaries for iPhoneX support.
#jira UE-53541
Change 3891525 by Lauren.Ridge
Thumbnails now update correctly w/parameters
#jira UETOOL-1333
Change 3891520 by Lauren.Ridge
Fixing SA error in material editor
#jira UE-55206
Change 3891495 by Jurre.deBaare
Normal are different after Merge Actor on scaled objects
#fix Make sure we do not apply scale when transform Normals/Tangents
#jira UE-54996
Change 3891352 by Guillaume.Abadie
Fixes ensure when visualizing HDR with TAAU.
#jira UE-55019
Change 3891323 by Matt.Kuhlenschmidt
Added substance buttons to content browser and material editor
#jira UE-55081
Change 3891033 by David.Hibbitts
#JIRA UE-55135
Moved Message Bus Source heartbeats to their own thread using a new FHeartbeatManager singleton. This prevents sources from incorrectly being removed during Slate UI operations.
Change 3890642 by Arne.Schober
REL - Better fix for Paper2d which honors batching
#jira UE-55063
Change 3890593 by Arne.Schober
REL - Fix Paper2d crash. When addMesh is called the Vertex and Indexbuffers are nulled out. re-create Dynamic Mesh builder for every Mesh instead.
#jira UE-55063
Change 3890502 by Mike.Erwin
Fix reported VRAM size on Metal
We were getting correct value in MB from system but overflowing uint32 arithmetic when converting to bytes.
This led 4GB and 8GB configs to report 0 total VRAM, 0 dedicated tex mem, and GTexturePoolSize = 0.
Noticed the problem on my 6GB FirePro, which reported 2GB and set GTexturePoolSize to 70% of that.
Also fixed log of texture pool size to show MB. Other platforms' RHIs already report this in MB.
#jira none
Change 3890404 by Jostin.Bilyeu
Updating Demo Display names to remove redundant spaces
#jira UE-29618
Change 3890401 by Dan.Oconnor
Fix for property table performance regression
#jira UE-54984
Change 3890194 by Dan.Oconnor
Make sure a CDO's subobjects are preloaded when running in -game
#jira UE-54242
Change 3890182 by Krzysztof.Narkowicz
Moving CL3867594 from Dev-Rendering to fix missing shaders in cooked Binary Editor DCC. USE_EDITOR_ONLY_DEFAULT_MATERIAL_FALLBACK generated default material shaders had no cooking code path.
#jira UE-54683
Change 3890140 by Rob.Cannaday
Merging cacert.pem from //UE4/Dev-Online to //UE4/Release-4.19
Includes latest cacert.pem from https://curl.haxx.se/docs/caextract.html as of January 17, 2018
#jira none
Change 3889850 by Shaun.Kime
Now initializing Niagara scripts and emitters even if the config file isn't ready yet.
#jira UE-54168
#jira UE-54169
#tests can create a blank emitter and all script sub-types
Change 3889833 by Michael.Trepka
Disabled Clang's unused-lambda-capture warning added in Xcode 9.3
#jira none
Change 3889696 by Patrick.Boutot
Allow rename from AssetTool when there is no source control enabled.
Fix crash when you rename an asset without an enabled source control.
#jira UEENT-803
Change 3889470 by Mike.Beach
Switching the source-name to legacy hand enum lookup functions to use a static table instead of finding a UEnum object and iterating over reflection data (to prevent a GC lockup with the UObject query).
#jira UE-55153
Change 3889319 by Matt.Kuhlenschmidt
Disable hardware survey on build machines. They run windows server and lack the necessary win32 api functionality to execute it properly
#jira UE-55166
Change 3889087 by Jostin.Bilyeu
Minor adjustments TM-SceneTexture for better testing clarity. Minor adjustments to TM-MipLevels for test map clean up
#jira UE-29618
Change 3889073 by Sorin.Gradinaru
UE-55117 Android virtual keyboard can have text input hidden by software buttons
#jira UE-55117
#Android
#4.19
Adjusted x-coord and width for the native EditText
Change 3888841 by Jurre.deBaare
Make FSkeletalMeshRenderData::GetMaxBonesPerSection an ENGINE_API exported function
#jira none
Change 3888837 by Guillaume.Abadie
Fixes a crash in dynamic resolution when doing UE4Editor -server
#jira UE-55158
Change 3888831 by Dragan.Jerosimovic
added fbx files
#jira none
Change 3888340 by Ethan.Geller
[Release-4.19] #jira UE-54787 edit settings for Strategy Game to prevent stuttering in AudioMixer on low performance Android Devices #rb Aaron.McLeran #fyi Aaron.McLeran #lockdown Cristina.Riveron
Change 3888133 by Michael.Karambelas
QAGame: Adding a BP Actor to test the Mic component feature that AaronM implemented with UE-51471.
#jira UE-29618
Change 3887957 by Krzysztof.Narkowicz
"Fixed" Vulkan instancing in by doing Metal style set instance offset to 0 hack
#jira UE-54367
Change 3887912 by Jostin.Bilyeu
Adding content to TM-SceneTexture to verify Screen Positioning as well as Scene Color and Depth. Adding a new map (TM-MIPLevels) for testing custom mip levels
#jira UE-29618
Change 3887571 by Zak.Parrish
Adding FaceAR content and cleanup #jira none
Change 3887458 by Dan.Oconnor
Fix 'Step Out' functionality for macro and collapsed graphs
#jira UE-55000, UE-55002, UE-55022
Change 3886883 by zachary.wilson
Add testing content to QAGame: Texture and material for testing mip levels. Postprocess material for testing scene buffer sampling.
#jira UE-29618
Change 3886848 by Max.Preussner
Engine: Workaround for uninitialized external textures causing white flashes in media playback
Copied from Fortnite-Main and Dev-Sequencer
#jira UE-53357
Change 3886720 by Matt.Kuhlenschmidt
Guard against mac menus updating during slow tasks.
#jira UE-55068
Change 3886657 by Guillaume.Abadie
Cherry-pick 3886626: Cherry-pick 3886560: Fixes strong aliasing on TAAU's fast shader permutation.
This adds a 6th neighbor sampling, and switch AA_TONE ON as TAA does for its fast shader permutation.
#jira FORT-69961
Change 3886653 by Matt.Kuhlenschmidt
Perforce Plugin: Removed all calls to methods that would update the P4PASSWD environment variable. Perforce stores this as plain text so it is not safe and we do not want the editor to be responsible for this being set. All users should be using ticket based p4 servers for the best security but if they are unable to then they can call p4 passwd on their own to set a slightly better hashed password directly. They may also log in each time to the editor which prevents any password from being stored
#jira UE-55111
Change 3886621 by Benn.Gallagher
Fixed crash closing clothing tab if workflow centric application puts the tab spawners in a bad state due to incorrect handling of tab context menus.
#JIRA UE-55067
Change 3886552 by Thomas.Sarkanen
Fixed crash loading an anim instance with a re-instanced class
Unable to repro, but in editor we dont need the optimization that this provides. Now we always re-initialize functions and properties in case the class has changed out from under us.
#jira UE-55065 - [CrashReport] UE4Editor_Engine!FExposedValueHandler::Initialize() [animnodebase.cpp:521]
Change 3886442 by Cosmin.Sulea
UE-53033 - Editor Rapidly Spawns Multiple Empty Windows Throughout Remote Shader Compiling
#jira UE-53033
Change 3886441 by Cosmin.Sulea
UE-54598 - Using an Invalid iOS Mobile Provision does not give descriptive error in Project Launcher, IPhonePackager
#jira UE-54598
Change 3886427 by Sorin.Gradinaru
UE-54139 Possible crash with new virtual keyboard on Android if suggestions not disabled - from //Dev-Mobile@CL3843552
#4.19
#Android
#jira UE-54139
S8 on 7.0 is not hiding suggestions and disabling predictive input. There are cases with this that can cause a crash.
Fix: On text change, downgrade to simple suggestions all the easy correction spans that are not a spell check span (remove android.text.style.SuggestionSpan.FLAG_EASY_CORRECT flags)
Change 3886210 by Ethan.Geller
[Release-4.19] #jira UE-53867 Ensure we don't read off into garbage memory for uncompressed PCM.
Change 3886005 by Zak.Parrish
Checking in faceAR work on behalf of 3Lateral #jira none
Change 3885925 by Mike.Erwin
Material preview label off-center on HiDPI screen
#jira UE-52533
Change 3885778 by Dan.Oconnor
Fix stepping over collapsed graph and macro nodes
#jira UE-54950, UE-54955
Change 3885713 by Mike.Erwin
glTF: fix material using wrong textures
Imported material could plug the wrong textures into its inputs. The previous code tracked a material's textures based on image source index, corrected code uses texture (source + sampler) index. This is more general allowing an image to be referenced by multiple textures.
Bug reported yesterday via email, demonstrated using the Khronos TextureSettingsTest sample model.
#jira none
Change 3885603 by Ben.Marsh
Fixes for compiler errors in nightly builds of VS2017 in /permissive- mode.
#jira
Change 3885566 by Phillip.Kavan
Fix a scoping issue related to inaccessible property reference caching in nativized Blueprint code.
Change summary:
- Modified FDefaultSubobjectData::EmitPropertyInitialization() to utilize the FScopeBlock utility to manage the inaccessible property cache during code generation for instanced subobject initialization.
#jira UE-55061
Change 3885481 by Mark.Satterthwaite
Attempt to workaround an Intel shader compiler bug without reopening a related AMD bug. This may cost performance unless function constants are available and the runtime compiler actually bothers to perform optimisation (AMD's did not in 10.12.6 and earlier).
#jira UE-54333
Change 3885461 by Lauren.Ridge
Fix for slot not being initialized to null
#jira UE-55069
Change 3885455 by zak.parrish
Adding initial files for FaceAR scene lookdev #jira none
Change 3885446 by Zak.Parrish
Adding test assets for Gremlin look dev. May get removed later prior to release. #jira none
Change 3885424 by Krzysztof.Narkowicz
Fixed skeletal mesh LODs inside editor. If skeletal mesh wasn't recently visible, code was incorrectly changing LOD settings without updating LOD data on render thread.
#jira UE-53861
Change 3885406 by Zak.Parrish
Rollback //UE4/Release-4.19/Samples/FaceARSample/Content/UI/FaceARDebugUI.uasset to revision 1 #jira UE-54639
Change 3885340 by Arne.Schober
REL - Bitarray FindFromLast was masking incorrectly for the corner case where there is no slack
#jira none
Change 3885143 by Marc.Audy
Merge memory corruption fix in CL# 3884991 from Fortnite-Staging to Release-4.19
#jira UE-54977
#jira UE-54976
#jira UE-54898
Change 3885093 by Mark.Satterthwaite
Apple don't like testing for the validation layer in iOS App Store builds - it is unnecessary so we can disable this for shipping builds.
#JIRA N/A
Change 3884622 by Jurre.deBaare
Moving over missing file from changelist for UE-54508
#jira UE-54508
Change 3883391 by Nick.Atamas
Fix for UE-54622 : PIE in VR available when ARKit/ARCore plugins enabled.
Only create ARKit/ARCore tracking systems on iOS/Android.
#jira UE-54622
Change 3883257 by Phillip.Kavan
Fix a Blueprint compile error for the GetClassDefaults node Map value outputs introduced by stronger type checking in 4.19 between Map pin types.
#jira UE-55026
Change 3883024 by Lauren.Ridge
Fixing static analysis warning
#jira SA
Change 3882510 by Michael.Dupuis
#jira none : Fixed screen size calculation to take aspect ratio into account correctly
Change 3882502 by Lauren.Ridge
Fix for material layer parameters not rebuilding and adding save child button
#jira UETOOL-1275
Change 3882458 by Krzysztof.Narkowicz
Copying cached shadow map assert fix from Fortnite-Main (CL3802813)
#jira UE-54747
Change 3882366 by Michael.Karambelas
QAGame: made changes to QABP_Debugging, QABP_FunctionLib, and QA_TestHelper for Blueprint debugger tests.
#jira UE-29618
Change 3881971 by andrew.porter
QAGame: Removing actor from Shot_003
#jira UE-29618
Change 3881795 by Krzysztof.Narkowicz
Added encoded HDR reflection capture cooking if targeting ES 2.0/3.1 on Windows
#jira UE-53875
Change 3881550 by David.Hibbitts
#JIRA UEENT-879
Subject frames now store world time explictly as a double with optional scene timecode as MetaData. This allows for use cases such as posing a single frame in Maya where the world time would be changing but the scene timecode associated with the animation remains fixed.
THIS IS A BREAKING CHANGE: Sources from before this change will no longer compile.
Change 3881339 by Jurre.deBaare
Moving over:
"Editor crashed when attempting to bake out all the material channels
#jira UE-54508
#misc small UDN Merge actor / bake material fixes
Change 3879557 by Dan.Oconnor
Fix stepover behavior when no debug target is selected
#jira UE-54978
Change 3879485 by Mike.Beach
Limiting the number of stereo layers on Oculus android to 4 (otherwise, their lib crashes).
#jira UE-54999
Change 3879438 by David.Hibbitts
#JIRA UEENT-880 Added support for Subject level MetaData to LiveLink #rb martin.wilson #fyi james.golding, simon.tourangeau
Change 3879343 by Lina.Halper
Last min change that skiped compiling
#jira: none
Change 3879337 by Lina.Halper
Fix issue where tick is skipped due to last ticked pose isn't cleared after AnimInstance changes.
#jira: UE-54806
Change 3878968 by Phillip.Kavan
Fix deprecation warnings in compiled stub class wrapper codegen for Blueprint class dependencies excluded from nativization.
Change summary:
- Modified FBlueprintCompilerCppBackendBase::GenerateWrapperForClass() to const-correct the assignment of cached weak pointers to referenced properties.
#jira UE-54981
Change 3878962 by Adrian.Siminciuc
https://jira.it.epicgames.net/browse/UE-54831 (No error occurs accepting if Android SDK license file cannot be written, but user cannot accept license)
#4.19
#jira UE-54831
#android
- shows an error message box informing that the license file could not be written.
Change 3878821 by Andrew.Rodham
Sequencer: Fixed overlapping ranges being inserted into the evaluation field during compilation
- The issue was that track segments that had been combined with adjacent segments (due to them being identical) would potentially cause a subsequently compiled frame to overlap with a range that had already been inserted into the evaluation field.
- The insertion code previously asserted that only minor overlaps were catered for (due to fp rounding errors) and assumed that a supplied range could not entirely contain any other range in the field.
- The solution is to supply the insertion time along with the range to know exactly where the data should live in the field, and crop the range to the maximum allowable space between adjacent ranges.
#jira UE-54922
Change 3878171 by Chris.Phillips
Android: Fixed crash after splash screen when using Vulkan.
#jira UE-54299
Change 3877950 by Ethan.Geller
Fix copyright information from previous CL #jira none #rb none #lockdown Cristina.Riveron
Change 3877859 by Nick.Shin
rebuilt lighting for TM-ShaderModels and resaved the level
#jira UE-53374 Client displays "lighting needs to be rebuilt (1 unbuilt object(s))" when launching TM-Shadermodels onto HTML5
Change 3877854 by tim.gautier
Adding additional (temp) ML Test asset
#jira UE-29318
Change 3877609 by Ethan.Geller
[4.19] Change FWhiteNoise generate function to use SRand, due to weird distribution in FRandRange #jira UE-54965 #rb aaron.mcleran #lockdown cristina.riveron
Change 3877474 by Lauren.Ridge
Adding WITH_EDITOR wrappers to editor-only section of code
#jira fixingcompiles
Change 3877271 by Arne.Schober
REL - Integrate 3872827 - The VFs are not owners of the data, e.g the underlying Buffers might be released before this and this reference counting should not be neccessary
#jira none
Change 3877260 by Lina.Halper
If revision is too far away, ignore the request and send current buffer
- this is exactly how it used to do and it is still required, but this means motion vector will be ignored when this happens
#jira: UE-54398
Change 3876950 by Lauren.Ridge
Renaming layers in a material instance - from 4.19 preview feedback
#jira UETOOL-1296
Change 3876932 by Arciel.Rekman
Linux: updated the link to the cross-toolchain (UE-54597).
#jira UE-54597
Change 3876918 by Phillip.Kavan
Fix a regression that could cause packaging to fail and/or data loss with Blueprint nativization enabled.
Change summary:
- Removed logic that attempted to avoid redundant assignments of instanced default subobject references. This was not compatible with editinline characteristics that can allow certain object reference values to be overridden by the Blueprint class.
- Explicitly defer to ExportTextItem() when generating C++ code for UObjectProperty/UInterfaceProperty reference values in which the underlying object reference is NULL.
#jira UE-54870
Change 3876759 by tim.gautier
Updated Material Layer test assets to include Opacity and Emissive.
#jira UE-29318
Change 3876575 by Michael.Karambelas
Updating the QABP_Debugging asset in QAGame with a couple of interfaces and additional logic for testing purposes.
#jira UE-29618
Change 3876406 by Robert.Manuszewski
Fixed a crash when reporting linker errors
#jira UE-51037
Change 3875891 by Nick.Atamas
Fixed scenario where geometries were being updated once per pin, instead of just being updated once.
Also fixes a scenario where there are no pins and geometries fail to update.
#jira UE-54914
Change 3875880 by Aaron.McLeran
#jira UE-54916
Fixing up submix effect templates
Change 3875673 by Brandon.Schaefer
Fix Apex dependencies
Depend on static Apex libraries in Apex.Build.cs versus Physx.Build.cs
#jira UE-54861
Change 3875498 by Lauren.Ridge
PR #4477: 4.19 Fixed a crash caused by the layered material property widget of the material instance editor. (Contributed by mlaveaux)
#jira UE-54862
Change 3875322 by tim.gautier
Recreating Material Layer test assets (asset version has changed)
#jira UE-29318
Change 3875157 by Aaron.McLeran
#jira UE-54901 Synth components do not allow sends to buses
Change 3875103 by Brandon.Schaefer
Need to use our bundled libc++.so not libstdc++.so when building Apex/PhysX/NvCloth libraries
#jira UE-54815
Change 3875037 by Aaron.McLeran
#jira UE-54896 Fixing up audio capture component to parameterize the delay
Parameterize the jitter latency delay.
Change 3875026 by Aaron.McLeran
#jira UE-54895 Filter frequency values don't update live with EQ effects and 0-frequency cutoff causes pops
Change 3874927 by Ryan.Vance
#jira UE-54894
Ensure we don't delete aliased texture resources, they are managed externally.
Change 3874925 by Martin.Wilson
Remove XR post fix from live link code written during motion controller integration
#jira none
Change 3874354 by Ben.Marsh
Use the compiler matching the user's preferred IDE if they don't have a specific compiler selected in the project settings.
#jira UE-54272
Change 3877545 by Ben.Marsh
Replace FPlatformMisc::DebugBreak() with the UE_DEBUG_BREAK() macro. VS2017 is able to show force-inlined calls on the callstack, which makes debugging asserts and ensures annoying.
Use similar logic for expanding ensure() macros in place.
#jira UE-54961
[CL 3963579 by Ben Marsh in Main branch]
2018-03-24 09:22:20 -04:00
|
|
|
#include "Materials/MaterialExpressionMaterialLayerOutput.h"
|
2020-12-11 14:21:20 -04:00
|
|
|
#include "Materials/MaterialExpressionNamedReroute.h"
|
2021-01-28 17:48:58 -04:00
|
|
|
#include "Materials/MaterialExpressionExecBegin.h"
|
2021-05-14 13:05:50 -04:00
|
|
|
#include "Materials/MaterialExpressionExecEnd.h"
|
2014-05-22 11:33:54 -04:00
|
|
|
|
2021-01-28 17:48:58 -04:00
|
|
|
#include "Materials/MaterialExpressionIfThenElse.h"
|
|
|
|
|
#include "Materials/MaterialExpressionForLoop.h"
|
|
|
|
|
#include "Materials/MaterialExpressionGetLocal.h"
|
|
|
|
|
#include "Materials/MaterialExpressionSetLocal.h"
|
2023-08-31 04:47:50 -04:00
|
|
|
#include "Materials/MaterialExpressionSubstrate.h"
|
2014-03-14 14:13:41 -04:00
|
|
|
|
|
|
|
|
///////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
|
|
|
|
|
//
|
|
|
|
|
// MaterialExpressionClasses
|
|
|
|
|
//
|
|
|
|
|
///////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
|
|
|
|
|
|
|
|
|
|
MaterialExpressionClasses::MaterialExpressionClasses()
|
|
|
|
|
: bInitialized( false )
|
|
|
|
|
{
|
|
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
MaterialExpressionClasses::~MaterialExpressionClasses()
|
|
|
|
|
{
|
|
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
MaterialExpressionClasses* MaterialExpressionClasses::Get()
|
|
|
|
|
{
|
|
|
|
|
static MaterialExpressionClasses Inst;
|
|
|
|
|
Inst.InitMaterialExpressionClasses();
|
|
|
|
|
return &Inst;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
const UStruct* MaterialExpressionClasses::GetExpressionInputStruct()
|
|
|
|
|
{
|
|
|
|
|
static const UStruct* ExpressionInputStruct =
|
2022-05-22 10:30:02 -04:00
|
|
|
CastChecked<UStruct>( StaticFindObject( UStruct::StaticClass(), nullptr, TEXT("/Script/Engine.ExpressionInput")) );
|
2014-03-14 14:13:41 -04:00
|
|
|
check( ExpressionInputStruct );
|
|
|
|
|
return ExpressionInputStruct;
|
|
|
|
|
}
|
|
|
|
|
|
2015-05-08 10:46:42 -04:00
|
|
|
FCategorizedMaterialExpressionNode* MaterialExpressionClasses::GetCategoryNode(const FText& InCategoryName, bool bCreate)
|
2014-03-14 14:13:41 -04:00
|
|
|
{
|
|
|
|
|
for (int32 CheckIndex = 0; CheckIndex < CategorizedExpressionClasses.Num(); CheckIndex++)
|
|
|
|
|
{
|
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 3420477)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3386262 on 2017/04/10 by Ben.Marsh
Add app-local deployment of DirectX components that are no longer included with newer versions of Windows by default (XAudio 2.7, XInput 1.3). Also add a one-click button to the packaging settings to include the default app-local dependencies, rather than having to specify the path.
Change 3386999 on 2017/04/10 by Ben.Marsh
Plugins: Add support for explicit dependencies from one plugin onto another. Required plugins can be configured in an identical manner to project files, by adding a "Plugins" key to the .uplugin file. Dependencies are automatically built and loaded, and the plugin browser will warn if you try to disable a plugin that something else has a dependency on.
Change 3387073 on 2017/04/10 by Ben.Marsh
Move FLightPropagationRuntimeSettings into the Renderer module, to remove engine dependency on a plugin.
Change 3387988 on 2017/04/11 by Steve.Robb
Comments added to clarify the role of DestructItem and DestructItems.
Change 3388085 on 2017/04/11 by Ben.Marsh
UBT: Fix bEnabled flag on plugin references being ignored. Now collect up all the plugin references in order of priority before creating plugin instances for them. Fixes CIS fail for UT.
Change 3390048 on 2017/04/12 by Richard.Hinckley
#jira UE-43876
Fixed description of Streaming settings (within Project Settings).
Change 3390697 on 2017/04/12 by Steve.Robb
CLASS_PointersDefaultToAutoWeak and CLASS_PointersDefaultToWeak removed.
Change 3390711 on 2017/04/12 by Steve.Robb
AGRESSIVE_ARRAY_FORCEINLINE removed.
Change 3392167 on 2017/04/13 by Robert.Manuszewski
UObject can be added to GC cluster only if all of its Outers can also be added to it.
Fixing asserts caused by components that are added to GC clusters even if their owner actors that can't be in GC clusters.
#jira UE-42948
Change 3392309 on 2017/04/13 by Robert.Manuszewski
When adding objects to clusters after these clusters have been created it's possible to come across objects that are already in the cluster we're adding the object to so instead of crashing, allow it.
Change 3392620 on 2017/04/13 by Ben.Marsh
UGS: Only check for updates every 5 minutes.
Change 3392623 on 2017/04/13 by Ben.Marsh
UGS: Only poll for new changes every 60 seconds.
Change 3392744 on 2017/04/13 by Ben.Marsh
UGS: Query changelist descriptions individually to determine whether changes affect code or content, to hopefully reduce Perforce server load.
Change 3392874 on 2017/04/13 by Ben.Marsh
UGS: Allow specifying regexes in the project config file which filters which changes to be displayed. Useful for changes submitted by build machines, updates to collections, etc...
Change 3392878 on 2017/04/13 by Ben.Marsh
Update UGS to version 1.96
Change 3395635 on 2017/04/17 by Ben.Marsh
UAT: Prefix log output from executing UAT commands through BuildGraph with the name of that command.
Change 3395655 on 2017/04/17 by Ben.Marsh
UAT: Add a command for syncing a DDC over the network (SyncDDC). Allows specifying a maximum size to copy, number of days worth of modified files to copy, and time limit not to be exceeded.
Change 3396989 on 2017/04/17 by Wes.Hunt
CrashReporter configurable tweaks.
* Added QueueWaitingTimeAlertThreshold (used to be hardcoded to 1 min).
- When the queue waiting time gets beyond this many seconds, trigger a slack alert message. Default is 10 min.
- Zero means never alert.
* Added DiskSpaceAvailableAlertInterval (used to be hardcoded to 1 day).
- Interval by which to report disk space availability.
- Default is never (Zero)
* Updated config file to match production config.
#codereview:jin.zhang
Change 3397656 on 2017/04/18 by Ben.Marsh
UBT: Allow modules to opt-out of getting the default include paths from being added, by setting bAddDefaultIncludePaths = false from their build.cs file.
Change 3397677 on 2017/04/18 by Robert.Manuszewski
PR #3167 : Adding more descriptive error text to DetatchLinker error check (by rooneym)
Change 3397722 on 2017/04/18 by Robert.Manuszewski
PR #2252: Increase linker reporting for failed imports (Contributed by FineRedMist)
Change 3397739 on 2017/04/18 by Richard.Hinckley
#jira UE-44100
Fixed SanitizePackageName() to remove double-slash, triple-slash, etc. from package names. Also updated CreatePackage() to call SanitizePackageName() before creating.
Change 3398023 on 2017/04/18 by Ben.Marsh
PR #3105: Cook/package with editor and debugger attached (Contributed by projectgheist)
Change 3398095 on 2017/04/18 by Ben.Marsh
PR #3051: Generate map file from UAT (Contributed by projectgheist)
Change 3398212 on 2017/04/18 by Ben.Marsh
PR #2915: UE-38232: Removed duplicate stats (Contributed by projectgheist)
Change 3399304 on 2017/04/19 by Ben.Marsh
UGS: Prevent editor target files being removed when running custom tools.
Change 3399306 on 2017/04/19 by Robert.Manuszewski
Moved InitPropertiesFromCustomList to UbLueprintGeneratedClass and made it thread safe
Change 3399729 on 2017/04/19 by Steve.Robb
Simple optimization to TBitArray::RemoveAt() when all removed bits are at the end of the array.
RemoveAtSwap() now simply decrements the count instead of calling RemoveAt().
Checks for a positive count added to RemoveAt() and RemoveAtSwap().
Change 3399750 on 2017/04/19 by Jin.Zhang
Order branch alphabetically #RB
Change 3400186 on 2017/04/19 by Steve.Robb
Per-header generated code.
Change 3401458 on 2017/04/20 by Steve.Robb
Static log categories moved out of headers to prevent duplicates when the header is included multiple times.
#jira UE-37507
Change 3401657 on 2017/04/20 by Gil.Gribb
UE4 - Simplified and reworked lock free lists and the task graph bringing all platforms under the same scheme.
Change 3401735 on 2017/04/20 by Gil.Gribb
UE4 - Updated apple platform atomics with a new clang version which is intended to be shared among all clang platforms.
Change 3403362 on 2017/04/21 by Steve.Robb
Algo::Sort() fixed to support C arrays.
Size+count versions of Also::IsSorted() deprecated.
Algo::IsSortedBy() added.
Algo::FindBy() added to allow an element to be found by projection.
Simplifications and generalizations.
Change 3404017 on 2017/04/21 by Ben.Marsh
Fix issue where referenced plugin descriptors were missing from console builds, and prevent monolithic builds from offering to disable missing plugins.
Change 3405299 on 2017/04/24 by Steve.Robb
Clarified the class of the incompatible function in the error message about incompatible BP event specifiers.
#jira UE-35106
Change 3405302 on 2017/04/24 by Ben.Marsh
UBT: Allow excluding documentation from generated project files, by setting <ProjectFileGenerator><bIncludeDocumentation>false</bIncludeDocumentation></ProjectFileGenerator> in the XML configuration file.
Change 3405629 on 2017/04/24 by Ben.Marsh
Rename CPPEnvironment to CppCompileEnvironment, to reflect the class name.
Change 3406431 on 2017/04/24 by Ben.Marsh
UAT: Fix incorrect handling of P4SubmitOptions when multiple values are present.
Change 3406670 on 2017/04/24 by Ben.Marsh
UBT: Enable warnings for classes with virtual functions and no virtual destructor (C4265 on Windows, -fdelete-non-virtual-dtor on Clang).
Change 3407080 on 2017/04/25 by Gil.Gribb
UE4 - Critical fix: Propoerly disambiguate imports with the same name and the same outer name. This fixes an assert: LocalExportIndex.IsNull.
Change 3407486 on 2017/04/25 by Gil.Gribb
UE4 - Made changes so that servers, programs and non-engine executables do not create background or high priority threads.
Change 3407495 on 2017/04/25 by Gil.Gribb
UE4 - Tweaked out XBox and Windows low level file IO.
Change 3407497 on 2017/04/25 by Gil.Gribb
UE4 - Fixed bug in the pak precacher that would result in blocks being discarded too soon, which, in turn, resulted in redudnant reads.
Change 3407705 on 2017/04/25 by Ben.Marsh
Removing most of the junk in DotNETUtilities.
Change 3409701 on 2017/04/26 by Ben.Marsh
Disable another static analyzer warning for third party libraries.
Change 3410074 on 2017/04/26 by Daniel.Lamb
Network platform file runs heart beats and responds to modified file changes.
Cook on the fly server in the editor (COTS) now detects changes to content and notifies client.
Fixed issue with network platform file not using correct sandbox.
#test cook on the side shootergame
Change 3411131 on 2017/04/27 by Steve.Robb
TIsTriviallyDestructible now supports forward-declared enums.
Change 3411186 on 2017/04/27 by Steve.Robb
Fix for #includes in generated code for Within classes which are in a different module from the generated class.
Change 3411917 on 2017/04/27 by Steve.Robb
Fixes to pushing/popping the CPP macro.
Change 3411966 on 2017/04/27 by Steve.Robb
Include spam reduced in generated code.
Change 3412155 on 2017/04/27 by Ben.Marsh
Fix for PVS Studio warning: VFOVInRadians used instead of HFOVInRadians.
Change 3412223 on 2017/04/27 by Ben.Marsh
Fix for PVS-Studio warning: Calling SetHelperA.Num() twice.
Change 3412273 on 2017/04/27 by Ben.Marsh
Fix for PVS-Studio warning: Duplicated variable name.
Change 3412511 on 2017/04/27 by Ben.Marsh
PR #3462: Fixed PVS-Studio issues (Part 1) (Contributed by PaulEremeeff)
Change 3412582 on 2017/04/27 by Ben.Marsh
Fix for PVS-Studio warning: Incorrect variable name in copy/pasted code
Change 3413136 on 2017/04/28 by Robert.Manuszewski
Helper functions for dissolving specific GC clusters
Change 3413310 on 2017/04/28 by Ben.Marsh
Fix for PVS-Studio warning: Incorrect variable name in copy/pasted code.
Change 3413341 on 2017/04/28 by Gil.Gribb
UE4 - Add prestream capability to allow us to preload always loaded sublevels. Only turned on for Shootergame.
Change 3413351 on 2017/04/28 by Ben.Marsh
Include code analysis macros directly from Platform.h, so that macros are available to everything.
Change 3413352 on 2017/04/28 by Ben.Marsh
Fixing a few more PVS studio warnings.
Change 3413437 on 2017/04/28 by Ben.Marsh
Fix for PVS-Studio warning: Comparison is always true.
Change 3413759 on 2017/04/28 by Ben.Marsh
Suppressing warnings for PVS-Studio.
Change 3413784 on 2017/04/28 by Ben.Marsh
Fix PVS-Studio warning.
Change 3413898 on 2017/04/28 by Ben.Marsh
Fix PVS-Studio warning: Same conditional is checked twice.
Change 3413915 on 2017/04/28 by Ben.Marsh
Fix PVS-Studio warning: LHS of expression is identical to RHS.
Change 3413989 on 2017/04/28 by Ben.Marsh
Fix for PVS-Studio warning: If CurrentGraph->SubGraphs.Num() == 1, it will always enter the first conditional block.
Change 3414053 on 2017/04/28 by Ben.Marsh
More PVS-Studio fixes.
Change 3414062 on 2017/04/28 by Ben.Marsh
Fix for PVS-Studio warning: Pointer to object goes out of scope without being freed.
Change 3414070 on 2017/04/28 by Ben.Marsh
Fix for PVS-Studio warning: Fix incorrect condition.
Change 3414071 on 2017/04/28 by Ben.Marsh
Fix for PVS-Studio warning: Array index is always zero.
Change 3414116 on 2017/04/28 by Ben.Marsh
BuildGraph: Allow marking compile tasks as unsuitable for use with the parallel executor, via an AllowParallelExecutor="false" attribute.
Change 3414160 on 2017/04/28 by Ben.Marsh
Add support for running PVS-Studio through UnrealBuildTool. To use, pass -StaticAnalyzer=PVSStudio to the build command line (similarly, the Visual C++ analyzer can now be invoked using -StaticAnalyzer=VisualCpp). A log file will be written to the Engine/Saved/PVS-Studio or <Project>/Saved/PVS-Studio directory containing diagnostics, which can be opened using the "unparsed output" filter in the PVS-Studio standalone application. High priority warnings are printed to stdout.
Change 3414237 on 2017/04/28 by Ben.Marsh
EC: Allow disabling and enabling the log preprocessor via special markers in the log.
To disable: <-- Suspend Log Parsing -->
To enable: <-- Resume Log Parsing -->
Change 3414343 on 2017/04/28 by Ben.Marsh
UBT: Exclude ThirdParty folders from PVS output.
Change 3414392 on 2017/04/28 by Ben.Marsh
Fix regular strings being casted to BSTRs; BSTRs have a hidden length prefix in the two bytes before the first character, so passing a regular TCHAR* is reading random memory.
Change 3414459 on 2017/04/28 by Ben.Marsh
Fix for PVS-Studio warning: Object goes out of scope without being freed.
Change 3414495 on 2017/04/28 by Ben.Marsh
Suppress some more PVS-Studio warnings.
Change 3414514 on 2017/04/28 by Ben.Marsh
Fix for PVS-Studio warning: Testing WorldType being equal to EditorPreview and not equal to Inactive is redundant; changing to match description in comment instead.
Change 3414526 on 2017/04/28 by Ben.Marsh
Fix for PVS-Studio warning: Variable assigned to itself has no effect.
Change 3415183 on 2017/04/29 by Ben.Marsh
Fix conflict in macro definitions for ENABLE_HTTP_FOR_NFS - rename the macro defined by NetworkFile to ENABLE_HTTP_FOR_NF. Hopefully fix CIS.
Change 3415765 on 2017/05/01 by Ben.Marsh
Suppressing PVS-Studio warning to get things building cleanly. Not sure if FContentHelper is being leaked or not.
Change 3415853 on 2017/05/01 by Ben.Marsh
EC: Fix jobs never completing if a "Sync & Build" step fails. Dependent jobs should evaluate their run conditions as soon as the parent step finishes, rather than waiting for child job steps to be created.
Change 3416138 on 2017/05/01 by Ben.Marsh
Fix Fortnite cook failures. Not sure what the exact problem is here, but my hunch is that discarded "const" causes blueprint compile failures due to not being able to connect output pins between nodes for overloaded functions, or something like that.
Change 3416309 on 2017/05/01 by Ben.Marsh
Build: Fix node names for static analysis.
Change 3416360 on 2017/05/01 by Ben.Marsh
UBT: Remove unused arguments to PrepForUATPackageOrDeploy for Windows.
Change 3416398 on 2017/05/01 by Daniel.Lamb
Cook on the fly NetworkFileServerConnection Remove FileModifiedCallback delegate when the connection is closed.
#test Cook on the side shootergame.
Change 3416826 on 2017/05/01 by Daniel.Lamb
Added callback to game when files are requested reload from networkfileserver.
Game will need to unload / reload effected objects.
Working on simple reload capability in shootergame.
#test Cook on the side shootergame with reloading
Change 3417983 on 2017/05/02 by Ben.Marsh
EC: Remove warning for lines not matching p4 tag syntax when running preflights; multi-line descriptions in shelved changelists break this pattern.
Change 3418747 on 2017/05/02 by Steve.Robb
Fix for const pointer properties.
Fix for UHT debugging manifest.
Test added for pointer properties.
Change 3420477 on 2017/05/03 by Gil.Gribb
UE4 - Removed check from windows async IO layer.
[CL 3421020 by Ben Marsh in Main branch]
2017-05-03 14:18:32 -04:00
|
|
|
FCategorizedMaterialExpressionNode& CheckNode = CategorizedExpressionClasses[CheckIndex];
|
|
|
|
|
if (CheckNode.CategoryName.EqualTo(InCategoryName))
|
2014-03-14 14:13:41 -04:00
|
|
|
{
|
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 3420477)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3386262 on 2017/04/10 by Ben.Marsh
Add app-local deployment of DirectX components that are no longer included with newer versions of Windows by default (XAudio 2.7, XInput 1.3). Also add a one-click button to the packaging settings to include the default app-local dependencies, rather than having to specify the path.
Change 3386999 on 2017/04/10 by Ben.Marsh
Plugins: Add support for explicit dependencies from one plugin onto another. Required plugins can be configured in an identical manner to project files, by adding a "Plugins" key to the .uplugin file. Dependencies are automatically built and loaded, and the plugin browser will warn if you try to disable a plugin that something else has a dependency on.
Change 3387073 on 2017/04/10 by Ben.Marsh
Move FLightPropagationRuntimeSettings into the Renderer module, to remove engine dependency on a plugin.
Change 3387988 on 2017/04/11 by Steve.Robb
Comments added to clarify the role of DestructItem and DestructItems.
Change 3388085 on 2017/04/11 by Ben.Marsh
UBT: Fix bEnabled flag on plugin references being ignored. Now collect up all the plugin references in order of priority before creating plugin instances for them. Fixes CIS fail for UT.
Change 3390048 on 2017/04/12 by Richard.Hinckley
#jira UE-43876
Fixed description of Streaming settings (within Project Settings).
Change 3390697 on 2017/04/12 by Steve.Robb
CLASS_PointersDefaultToAutoWeak and CLASS_PointersDefaultToWeak removed.
Change 3390711 on 2017/04/12 by Steve.Robb
AGRESSIVE_ARRAY_FORCEINLINE removed.
Change 3392167 on 2017/04/13 by Robert.Manuszewski
UObject can be added to GC cluster only if all of its Outers can also be added to it.
Fixing asserts caused by components that are added to GC clusters even if their owner actors that can't be in GC clusters.
#jira UE-42948
Change 3392309 on 2017/04/13 by Robert.Manuszewski
When adding objects to clusters after these clusters have been created it's possible to come across objects that are already in the cluster we're adding the object to so instead of crashing, allow it.
Change 3392620 on 2017/04/13 by Ben.Marsh
UGS: Only check for updates every 5 minutes.
Change 3392623 on 2017/04/13 by Ben.Marsh
UGS: Only poll for new changes every 60 seconds.
Change 3392744 on 2017/04/13 by Ben.Marsh
UGS: Query changelist descriptions individually to determine whether changes affect code or content, to hopefully reduce Perforce server load.
Change 3392874 on 2017/04/13 by Ben.Marsh
UGS: Allow specifying regexes in the project config file which filters which changes to be displayed. Useful for changes submitted by build machines, updates to collections, etc...
Change 3392878 on 2017/04/13 by Ben.Marsh
Update UGS to version 1.96
Change 3395635 on 2017/04/17 by Ben.Marsh
UAT: Prefix log output from executing UAT commands through BuildGraph with the name of that command.
Change 3395655 on 2017/04/17 by Ben.Marsh
UAT: Add a command for syncing a DDC over the network (SyncDDC). Allows specifying a maximum size to copy, number of days worth of modified files to copy, and time limit not to be exceeded.
Change 3396989 on 2017/04/17 by Wes.Hunt
CrashReporter configurable tweaks.
* Added QueueWaitingTimeAlertThreshold (used to be hardcoded to 1 min).
- When the queue waiting time gets beyond this many seconds, trigger a slack alert message. Default is 10 min.
- Zero means never alert.
* Added DiskSpaceAvailableAlertInterval (used to be hardcoded to 1 day).
- Interval by which to report disk space availability.
- Default is never (Zero)
* Updated config file to match production config.
#codereview:jin.zhang
Change 3397656 on 2017/04/18 by Ben.Marsh
UBT: Allow modules to opt-out of getting the default include paths from being added, by setting bAddDefaultIncludePaths = false from their build.cs file.
Change 3397677 on 2017/04/18 by Robert.Manuszewski
PR #3167 : Adding more descriptive error text to DetatchLinker error check (by rooneym)
Change 3397722 on 2017/04/18 by Robert.Manuszewski
PR #2252: Increase linker reporting for failed imports (Contributed by FineRedMist)
Change 3397739 on 2017/04/18 by Richard.Hinckley
#jira UE-44100
Fixed SanitizePackageName() to remove double-slash, triple-slash, etc. from package names. Also updated CreatePackage() to call SanitizePackageName() before creating.
Change 3398023 on 2017/04/18 by Ben.Marsh
PR #3105: Cook/package with editor and debugger attached (Contributed by projectgheist)
Change 3398095 on 2017/04/18 by Ben.Marsh
PR #3051: Generate map file from UAT (Contributed by projectgheist)
Change 3398212 on 2017/04/18 by Ben.Marsh
PR #2915: UE-38232: Removed duplicate stats (Contributed by projectgheist)
Change 3399304 on 2017/04/19 by Ben.Marsh
UGS: Prevent editor target files being removed when running custom tools.
Change 3399306 on 2017/04/19 by Robert.Manuszewski
Moved InitPropertiesFromCustomList to UbLueprintGeneratedClass and made it thread safe
Change 3399729 on 2017/04/19 by Steve.Robb
Simple optimization to TBitArray::RemoveAt() when all removed bits are at the end of the array.
RemoveAtSwap() now simply decrements the count instead of calling RemoveAt().
Checks for a positive count added to RemoveAt() and RemoveAtSwap().
Change 3399750 on 2017/04/19 by Jin.Zhang
Order branch alphabetically #RB
Change 3400186 on 2017/04/19 by Steve.Robb
Per-header generated code.
Change 3401458 on 2017/04/20 by Steve.Robb
Static log categories moved out of headers to prevent duplicates when the header is included multiple times.
#jira UE-37507
Change 3401657 on 2017/04/20 by Gil.Gribb
UE4 - Simplified and reworked lock free lists and the task graph bringing all platforms under the same scheme.
Change 3401735 on 2017/04/20 by Gil.Gribb
UE4 - Updated apple platform atomics with a new clang version which is intended to be shared among all clang platforms.
Change 3403362 on 2017/04/21 by Steve.Robb
Algo::Sort() fixed to support C arrays.
Size+count versions of Also::IsSorted() deprecated.
Algo::IsSortedBy() added.
Algo::FindBy() added to allow an element to be found by projection.
Simplifications and generalizations.
Change 3404017 on 2017/04/21 by Ben.Marsh
Fix issue where referenced plugin descriptors were missing from console builds, and prevent monolithic builds from offering to disable missing plugins.
Change 3405299 on 2017/04/24 by Steve.Robb
Clarified the class of the incompatible function in the error message about incompatible BP event specifiers.
#jira UE-35106
Change 3405302 on 2017/04/24 by Ben.Marsh
UBT: Allow excluding documentation from generated project files, by setting <ProjectFileGenerator><bIncludeDocumentation>false</bIncludeDocumentation></ProjectFileGenerator> in the XML configuration file.
Change 3405629 on 2017/04/24 by Ben.Marsh
Rename CPPEnvironment to CppCompileEnvironment, to reflect the class name.
Change 3406431 on 2017/04/24 by Ben.Marsh
UAT: Fix incorrect handling of P4SubmitOptions when multiple values are present.
Change 3406670 on 2017/04/24 by Ben.Marsh
UBT: Enable warnings for classes with virtual functions and no virtual destructor (C4265 on Windows, -fdelete-non-virtual-dtor on Clang).
Change 3407080 on 2017/04/25 by Gil.Gribb
UE4 - Critical fix: Propoerly disambiguate imports with the same name and the same outer name. This fixes an assert: LocalExportIndex.IsNull.
Change 3407486 on 2017/04/25 by Gil.Gribb
UE4 - Made changes so that servers, programs and non-engine executables do not create background or high priority threads.
Change 3407495 on 2017/04/25 by Gil.Gribb
UE4 - Tweaked out XBox and Windows low level file IO.
Change 3407497 on 2017/04/25 by Gil.Gribb
UE4 - Fixed bug in the pak precacher that would result in blocks being discarded too soon, which, in turn, resulted in redudnant reads.
Change 3407705 on 2017/04/25 by Ben.Marsh
Removing most of the junk in DotNETUtilities.
Change 3409701 on 2017/04/26 by Ben.Marsh
Disable another static analyzer warning for third party libraries.
Change 3410074 on 2017/04/26 by Daniel.Lamb
Network platform file runs heart beats and responds to modified file changes.
Cook on the fly server in the editor (COTS) now detects changes to content and notifies client.
Fixed issue with network platform file not using correct sandbox.
#test cook on the side shootergame
Change 3411131 on 2017/04/27 by Steve.Robb
TIsTriviallyDestructible now supports forward-declared enums.
Change 3411186 on 2017/04/27 by Steve.Robb
Fix for #includes in generated code for Within classes which are in a different module from the generated class.
Change 3411917 on 2017/04/27 by Steve.Robb
Fixes to pushing/popping the CPP macro.
Change 3411966 on 2017/04/27 by Steve.Robb
Include spam reduced in generated code.
Change 3412155 on 2017/04/27 by Ben.Marsh
Fix for PVS Studio warning: VFOVInRadians used instead of HFOVInRadians.
Change 3412223 on 2017/04/27 by Ben.Marsh
Fix for PVS-Studio warning: Calling SetHelperA.Num() twice.
Change 3412273 on 2017/04/27 by Ben.Marsh
Fix for PVS-Studio warning: Duplicated variable name.
Change 3412511 on 2017/04/27 by Ben.Marsh
PR #3462: Fixed PVS-Studio issues (Part 1) (Contributed by PaulEremeeff)
Change 3412582 on 2017/04/27 by Ben.Marsh
Fix for PVS-Studio warning: Incorrect variable name in copy/pasted code
Change 3413136 on 2017/04/28 by Robert.Manuszewski
Helper functions for dissolving specific GC clusters
Change 3413310 on 2017/04/28 by Ben.Marsh
Fix for PVS-Studio warning: Incorrect variable name in copy/pasted code.
Change 3413341 on 2017/04/28 by Gil.Gribb
UE4 - Add prestream capability to allow us to preload always loaded sublevels. Only turned on for Shootergame.
Change 3413351 on 2017/04/28 by Ben.Marsh
Include code analysis macros directly from Platform.h, so that macros are available to everything.
Change 3413352 on 2017/04/28 by Ben.Marsh
Fixing a few more PVS studio warnings.
Change 3413437 on 2017/04/28 by Ben.Marsh
Fix for PVS-Studio warning: Comparison is always true.
Change 3413759 on 2017/04/28 by Ben.Marsh
Suppressing warnings for PVS-Studio.
Change 3413784 on 2017/04/28 by Ben.Marsh
Fix PVS-Studio warning.
Change 3413898 on 2017/04/28 by Ben.Marsh
Fix PVS-Studio warning: Same conditional is checked twice.
Change 3413915 on 2017/04/28 by Ben.Marsh
Fix PVS-Studio warning: LHS of expression is identical to RHS.
Change 3413989 on 2017/04/28 by Ben.Marsh
Fix for PVS-Studio warning: If CurrentGraph->SubGraphs.Num() == 1, it will always enter the first conditional block.
Change 3414053 on 2017/04/28 by Ben.Marsh
More PVS-Studio fixes.
Change 3414062 on 2017/04/28 by Ben.Marsh
Fix for PVS-Studio warning: Pointer to object goes out of scope without being freed.
Change 3414070 on 2017/04/28 by Ben.Marsh
Fix for PVS-Studio warning: Fix incorrect condition.
Change 3414071 on 2017/04/28 by Ben.Marsh
Fix for PVS-Studio warning: Array index is always zero.
Change 3414116 on 2017/04/28 by Ben.Marsh
BuildGraph: Allow marking compile tasks as unsuitable for use with the parallel executor, via an AllowParallelExecutor="false" attribute.
Change 3414160 on 2017/04/28 by Ben.Marsh
Add support for running PVS-Studio through UnrealBuildTool. To use, pass -StaticAnalyzer=PVSStudio to the build command line (similarly, the Visual C++ analyzer can now be invoked using -StaticAnalyzer=VisualCpp). A log file will be written to the Engine/Saved/PVS-Studio or <Project>/Saved/PVS-Studio directory containing diagnostics, which can be opened using the "unparsed output" filter in the PVS-Studio standalone application. High priority warnings are printed to stdout.
Change 3414237 on 2017/04/28 by Ben.Marsh
EC: Allow disabling and enabling the log preprocessor via special markers in the log.
To disable: <-- Suspend Log Parsing -->
To enable: <-- Resume Log Parsing -->
Change 3414343 on 2017/04/28 by Ben.Marsh
UBT: Exclude ThirdParty folders from PVS output.
Change 3414392 on 2017/04/28 by Ben.Marsh
Fix regular strings being casted to BSTRs; BSTRs have a hidden length prefix in the two bytes before the first character, so passing a regular TCHAR* is reading random memory.
Change 3414459 on 2017/04/28 by Ben.Marsh
Fix for PVS-Studio warning: Object goes out of scope without being freed.
Change 3414495 on 2017/04/28 by Ben.Marsh
Suppress some more PVS-Studio warnings.
Change 3414514 on 2017/04/28 by Ben.Marsh
Fix for PVS-Studio warning: Testing WorldType being equal to EditorPreview and not equal to Inactive is redundant; changing to match description in comment instead.
Change 3414526 on 2017/04/28 by Ben.Marsh
Fix for PVS-Studio warning: Variable assigned to itself has no effect.
Change 3415183 on 2017/04/29 by Ben.Marsh
Fix conflict in macro definitions for ENABLE_HTTP_FOR_NFS - rename the macro defined by NetworkFile to ENABLE_HTTP_FOR_NF. Hopefully fix CIS.
Change 3415765 on 2017/05/01 by Ben.Marsh
Suppressing PVS-Studio warning to get things building cleanly. Not sure if FContentHelper is being leaked or not.
Change 3415853 on 2017/05/01 by Ben.Marsh
EC: Fix jobs never completing if a "Sync & Build" step fails. Dependent jobs should evaluate their run conditions as soon as the parent step finishes, rather than waiting for child job steps to be created.
Change 3416138 on 2017/05/01 by Ben.Marsh
Fix Fortnite cook failures. Not sure what the exact problem is here, but my hunch is that discarded "const" causes blueprint compile failures due to not being able to connect output pins between nodes for overloaded functions, or something like that.
Change 3416309 on 2017/05/01 by Ben.Marsh
Build: Fix node names for static analysis.
Change 3416360 on 2017/05/01 by Ben.Marsh
UBT: Remove unused arguments to PrepForUATPackageOrDeploy for Windows.
Change 3416398 on 2017/05/01 by Daniel.Lamb
Cook on the fly NetworkFileServerConnection Remove FileModifiedCallback delegate when the connection is closed.
#test Cook on the side shootergame.
Change 3416826 on 2017/05/01 by Daniel.Lamb
Added callback to game when files are requested reload from networkfileserver.
Game will need to unload / reload effected objects.
Working on simple reload capability in shootergame.
#test Cook on the side shootergame with reloading
Change 3417983 on 2017/05/02 by Ben.Marsh
EC: Remove warning for lines not matching p4 tag syntax when running preflights; multi-line descriptions in shelved changelists break this pattern.
Change 3418747 on 2017/05/02 by Steve.Robb
Fix for const pointer properties.
Fix for UHT debugging manifest.
Test added for pointer properties.
Change 3420477 on 2017/05/03 by Gil.Gribb
UE4 - Removed check from windows async IO layer.
[CL 3421020 by Ben Marsh in Main branch]
2017-05-03 14:18:32 -04:00
|
|
|
return &CheckNode;
|
2014-03-14 14:13:41 -04:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (bCreate == true)
|
|
|
|
|
{
|
|
|
|
|
FCategorizedMaterialExpressionNode* NewNode = new(CategorizedExpressionClasses)FCategorizedMaterialExpressionNode;
|
|
|
|
|
check(NewNode);
|
|
|
|
|
|
|
|
|
|
NewNode->CategoryName = InCategoryName;
|
|
|
|
|
return NewNode;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return NULL;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void MaterialExpressionClasses::InitMaterialExpressionClasses()
|
|
|
|
|
{
|
2020-09-24 00:43:27 -04:00
|
|
|
if(!bInitialized)
|
2014-03-14 14:13:41 -04:00
|
|
|
{
|
2021-05-24 15:49:04 -04:00
|
|
|
static const auto CVarMaterialEnableNewHLSLGenerator = IConsoleManager::Get().FindTConsoleVariableDataInt(TEXT("r.MaterialEnableNewHLSLGenerator"));
|
|
|
|
|
|
2023-04-21 17:43:44 -04:00
|
|
|
const bool bEnableControlFlow = AllowMaterialControlFlow();
|
2021-05-24 15:49:04 -04:00
|
|
|
const bool bEnableNewHLSLGenerator = CVarMaterialEnableNewHLSLGenerator->GetValueOnAnyThread() != 0;
|
2021-01-28 17:48:58 -04:00
|
|
|
|
2015-02-03 05:40:57 -05:00
|
|
|
UMaterialEditorOptions* TempEditorOptions = NewObject<UMaterialEditorOptions>();
|
2014-03-14 14:13:41 -04:00
|
|
|
UClass* BaseType = UMaterialExpression::StaticClass();
|
|
|
|
|
if( BaseType )
|
|
|
|
|
{
|
2019-12-13 11:07:03 -05:00
|
|
|
TArray<FStructProperty*> ExpressionInputs;
|
2014-03-14 14:13:41 -04:00
|
|
|
const UStruct* ExpressionInputStruct = GetExpressionInputStruct();
|
|
|
|
|
|
|
|
|
|
for( TObjectIterator<UClass> It ; It ; ++It )
|
|
|
|
|
{
|
|
|
|
|
UClass* Class = *It;
|
|
|
|
|
if( !Class->HasAnyClassFlags(CLASS_Abstract | CLASS_Deprecated) )
|
|
|
|
|
{
|
|
|
|
|
if( Class->IsChildOf(UMaterialExpression::StaticClass()) )
|
|
|
|
|
{
|
|
|
|
|
ExpressionInputs.Empty();
|
|
|
|
|
|
Copying //UE4/Release-Staging-4.19 to //UE4/Dev-Main (Source: //UE4/Release-4.19 @ 3944462)
#lockdown Nick.Penwarden
============================
MAJOR FEATURES & CHANGES
============================
Change 3944462 by Jack.Porter
Prevent TVOS packaging from PC from attempting to build an asset catalog
#jira UE-56114
Change 3943602 by Leslie.Nivison
Adding licenses for additional TPS
#jira none
Change 3943597 by Leslie.Nivison
Adding Enterprise licenses; licenses for additional TPS.
#jira none
Change 3941962 by Leslie.Nivison
Updating 4.19 credit list
#jira none
Change 3941865 by Mark.Satterthwaite
Fix the incorrect landscape rendering and the incorrect render-to-texture from blueprint bugs with MetalRHI.
- Track outstanding AsyncCopyBufferFromBufferToBuffer operations to identify attempts to modify overlapping ranges within the same prologue command-buffer. This doesn't work and requires that we break the current render-pass and issue on the current command-buffer. A log warning will be emitted when this occurs.
- Don't attempt to alias private memory buffers the moment they are released from the RHI resource because that can lead to incorrect sharing of the memory when used by AsyncCopyBufferFromBufferToBuffer.
#jira UE-56021
Change 3940993 by Marc.Audy
Do not return the last column if the specified column does not exist.
Allow display names to be used when looking for a property if the table is backed by a user defined struct.
Do not crash if a property with the given name is not found.
#jira UE-56017
Change 3939179 by Ben.Marsh
Revert change to not poison memory in development configuration. Making a tradeoff that editor stability and consistency is more important than performance.
#jira
Change 3938566 by Aaron.McLeran
#jira UE-55940 Fix for wavetable synth
Missed a case.
Change 3938533 by Dan.Oconnor
Fix uninitialized variable exposed by recent MallocTBB change
#jira UE-56013
Change 3938508 by Aaron.McLeran
Fixing CIS error, init order issues.
#jira UE-55940
Change 3938490 by Aaron.McLeran
#jira UE-55940 Fix for wavetable synth
Change 3938352 by josh.jensen
Show an error message for Windows iOS builds when packaging/launching and icons are present but no remote Mac is specified
#jira UE-55987
Change 3938345 by Peter.Sauerbrei
fix to Icons not being built on Mac
#jira UE-53492
Change 3938305 by Mark.Satterthwaite
For whatever reason moving the buffer initialisation into the prologue command buffer doesn't work - this make absolutely no sense to me. I suspect that this is *merely* moving a render pass boundary around somewhere and forcing raster-state to be reapplied.
#jira UE-56005
Change 3937968 by Ben.Marsh
Disable the boot DDC if we're not in the editor. Fixes access violations when multiple SCW instances attempt to read/write to the same file.
#jira UE-56003
Change 3937573 by Mitchell.Wilson
Saving asset to resolve empty asset warning.
#jira UE-56004
Change 3937561 by Max.Preussner
ImgMedia: Added support for single-threaded platforms
Copied from Dev-Sequencer CL# 3937516
#jira UE-55986
Change 3937305 by Mike.Beach
Resaving google VR model content with UGS build to fix the empty file version error.
#jira UE-55984
Change 3935595 by Arne.Schober
Fix missing UV precission on BSP surfaces
#jira UE-54014
Change 3935411 by josh.jensen
Fixed Windows iOS remote Mac build issue where the user icons were considered remote Mac compilation targets coming solely from the Engine directory
#jira UE-55899
Change 3934982 by Marc.Audy
Fix shadow variable issue
#jira UE-55957
Change 3934892 by Mark.Satterthwaite
In MetalRHI treat BUF_Volatile buffers as Shared or Managed memory in all circumstances so that multiple updates within a render pass are respected even though this will hurt CPU performance. This fixes GPU particles on macOS. Also push initialisation upload into the async. command buffer to avoid it overwriting a later Lock/Unlock! Only read-back and copy-buffer operations should be on the 'current' command buffer as they need to be inline with all outstanding commands.
#jira UE-55956
Change 3934421 by Arciel.Rekman
Fix lockup/OOM when setting audio sources to 2 (UE-53968).
#jira UE-53968
Change 3934156 by Peter.Sauerbrei
fix for backgrounding problems on iOS and tvOS
this will re-open UE-50979 as the fix for that was not correct and would have caused crashes when backgrounding during startup
#jira UE4-55609
Change 3933547 by Aaron.McLeran
#jira UE-55940 Fix for wavetable sample duration and seek
Change 3933544 by Aaron.McLeran
#jira UE-55939 Hiding channel format
Submix channel format is an experimental feature and shouldn't be exposed to the submix editor for 4.19.
Change 3933540 by Aaron.McLeran
#jira UE-55718 Fix for playback progress.
Change 3933280 by Ethan.Geller
[Release-4.19] #jira UE-55810 Ensure AudioComponent is created before we start using it. #rb Aaron.McLeran
Change 3933079 by Ryan.Vance
#jira UE-55936
Fixed missing referenced uniform bindings on AR pass-through camera shaders.
Change 3932319 by Ben.Zeigler
#jira UE-55885 Fix corruption of packages when starting and then cancelling an async load of a package that already exists, or attempting to async load a script package
It now keeps track of which packages were created by the async load system and will only throw those away on cancel
Copy of CL #3932312
Change 3932287 by Matt.Kuhlenschmidt
Updated substance texture
#jira UE-55081
Change 3931729 by josh.jensen
Ensure the tvOS and iOS Assets.car is always produced as part of a regular remote/local build
#jira UE-55899
Change 3929723 by josh.jensen
Removed packaging requirement on Windows of a remote Mac after setting an app icon to default
#jira UE-53495
Change 3929722 by josh.jensen
Fixed iOS asset catalog generation issues when swapping out/resetting to default app icons for both code- and BP-projects
#jira UE-53492, UE-51879
#robomerge
Change 3929350 by Mike.Erwin
"Save As" support for
#jira UE-55732
Change 3927829 by Steve.Robb
Out-of-memory handler for MallocStomp.
#jira UE-55550
Change 3926404 by Mike.Erwin
#jira UE-55732
Change 3926394 by Dan.Oconnor
Recompile bytecode dependencies when compiling an individual blueprint interface, this prevents crashes due to stale bytecode
#jira UE-55813
Change 3926098 by Guillaume.Abadie
Do not allow dynamic resolution to be enabled on unsupported platforms avoiding game breaker experience by security.
#jira UE-55697
Change 3925927 by Guillaume.Abadie
Enables TAA's AA_BORDER on all permutation for dynamic resolution.
#jira UE-55353
Change 3925882 by Matt.Kuhlenschmidt
Fix substance uri having one extra /
Fix substance menu option showing up for github (incompatible with plugin)
#jira UE-55766
Change 3925873 by Ben.Zeigler
#jira UE-55783 Fix issue introduced in 4.18 where user structs did not handle converting AssetPtrs to SoftObjectPtrs properly
Copy of CL #3925871
Change 3925163 by Guillaume.Abadie
Fixes DFAO's temporal AA passes that was handling FViewInfo::ViewRect.Min wrongly.
#jira UE-55788
Change 3924839 by Guillaume.Abadie
Fixes a crash of LDR android preview with OS DPI scale != 0.
#jira UE-43622
Change 3924542 by Cosmin.Sulea
Merged fixes:
UE-55299 - XGE Shader Compile Interferes with Remote Shader Compiling Causing Materials to Fail to Compile #7
UE-51086 - No clear editor activity during remote shader compiling
#jira UE-55299
Change 3922398 by Mark.Satterthwaite
Compile fix for 3922273.
#jira UE-53993
Change 3922273 by Mark.Satterthwaite
Fix validation error caused by the game updating its orientation before the drawable system catches up. We need to drop drawables that are incorrectly sized until we get one with the correct size.
#jira UE-53993
Change 3921127 by Ethan.Geller
[Release-4.19] #jira UE-55744: Add OnTick virtual to IAudioPluginListener, fix thread safety issue in Resonance Audio. #rb aaron.mcleran
Change 3920632 by Lina.Halper
Fix render thread crash when morphtarget is deleted or added
#jira: UE-55521
Change 3920557 by Lauren.Ridge
Fixing material editor resetting background to off
#jira UE-55267
Change 3920519 by Phillip.Kavan
Fix a regression in which elements would not be initialized when constructing the value assignment for UDS-typed container members in nativized Blueprint C++ code.
Change summary:
- Modified FEmitDefaultValueHelper::InnerGenerate() to remove UDS from the list of special cases that avoid calling InitializeStruct() as part of new element construction. Previously the conversion code assumed the compiler would perform value initialization of a nameless temporary, but that is no longer valid in 4.19, as UDS types have been changed to function more like native structs, and as such all converted UDS types will now emit an explicit default ctor which is now used to assign defaults that differ from the zero-initialized value.
#jira UE-55628
Change 3920476 by Michael.Trepka
Clean up Mac menu item cache at exit before SlateApplication is fully destroyed.
#jira UE-55599
Change 3920336 by Ben.Marsh
Ignore license warnings from PVS-Studio.
#jira UE-55729
Change 3920134 by Jurre.deBaare
Moving over:
"HLOD: Building HLOD for P map with sublevels requires HLODSetupAsset when it should not
#fix Ensure that we dynamically add HLOD level treeview items whenever they are required, rather than adding a static number of levels according to the worldsettings"
#jira UE-55619
Change 3920126 by Max.Preussner
MediaCompositing: Implemented media track for Sequencer
Copied from Dev-Sequencer
#jira UE-53974
Change 3920004 by Jack.Porter
Disable Manual Vertex Fetch SRV creation when MVF is disabled.
Made a single RHISupportsManualVertexFetch(EShaderPlatform) to control whether to use MVF. The Shader Platform (or alternatively, feature level) is the only thing that can decide whether or not to use MVF because we need to know when we compile the shaders if we're going to do MVF or not. Checking GSupportsResourceView at runtime is useless because the shaders can't change and so if GSupportsResourceView can ever be false for a platform, the shaders need to have been built without it.
Creating SRVs without using them on mobile is not harmless because several devices don't support formats that are needed.
#jira UE-54764
#jira UE-55622
Change 3919069 by Aaron.McLeran
#jira UE-55718 Fix for playback progress.
Change 3918942 by Graeme.Thornton
Added "ProjectBuildMutatorFeature" modular feature, allowing plugins to register said feature and dictate whether the current project requires a code build. CryptoKeys plugin uses this feature to force a code build when encryption or signing is enabled.
#jira UE-55686
Change 3918721 by Zak.Parrish
Lighter version map for Gremlin + new Engine.ini - result is 60Hz #jira none
Change 3918236 by Joe.Graf
Added a bFlipTrackedRotation to give a better result when mirroring the rotation of a tracked face
#jira: UE-55531
Change 3917970 by Martin.Wilson
Expose curve data in remap assets to blueprints
#jira UE-55585
Change 3917740 by Olaf.Piesche
Properly checking for presence of buffer SRV capability via GSupportsResourceView so ES3.1 and Metal devices don't crash using GPU particles (and possibly in other circumstances);
#jira UE-55591
Change 3917713 by Cody.Albert
Build fixes for Match3 on iOS
#jira UE-53742
Change 3917472 by zak.parrish
added mouthPressLeft and MouthPressRight back into debug screen #jira none
Change 3917244 by Michael.Dupuis
#jira UE-35097: Fixed crash when creating a new landscape with 2x2 subsections and material containing grass spawning node
Change 3916775 by Ben.Marsh
Add missing files for packaging IOS on Windows.
#jira UE-53873
Change 3916293 by Joe.Graf
Removed the redundant GetTransform() from UARFaceGeometry since GetLocalToWorldTransform() is exposed on a base class
#jira: UE-55531
Change 3916011 by Joe.Graf
Added an accessor to get the transform of the face mesh or a face mesh component
#jira: UE-55531
Change 3915967 by Mark.Satterthwaite
Place buffer updates into the prologue command-buffer in MetalRHI to avoid breaking the current command-encoder. This improves performance, though the semantics of Metal now differ subtly to other RHI implementations as the buffer updates happen prior to the SetRenderTargets call in the GPU's view of the world.
#jira UE-54858
Change 3915751 by Nick.Atamas
Merging CL 3913931 from //UE/Partner-Google-VR/... to //UE4/Release-4.19/...
#jira UE-55639
Change 3915421 by Martin.Wilson
Fix crash from live link message bus heartbeat manager
#jira UE-55644
Change 3915326 by Dan.Oconnor
Make compilation manager's skeleton class layout better match the old compilation path's skeleton class layout, fixes a crash when renaming blueprint functions
#jira UE-55592
Change 3915250 by JeanLuc.Corenthin
Can't add C++ code to Enterprise projects (when enterprise is installed)
Root cause: When compiling a C++ project, Datasmith modules are included in the build process (with the wrong path)
Fix:
- Added two more Enterprise directories, Plugins and Intermediate, to the Enterprise directories to check against
- Build the correct path for the Datasmith modules and plugins in FindOrCreateModuleByName. Added check to see if module is under one of the Enterprise directories.
- Added modules to list of precompiled modeules in UEBuildTargets.AddPrecompiledModules if Engine and Enterprise are 'installed and the module is under Enterprise.
#jira UEENT-1032
Change 3915240 by Ben.Marsh
Reduce editor startup times by ~15s on Windows.
Platform loading code recursively scans every module for dependent DLL modules to load first. Change to make it early-out as soon as it encounters a module which is already in memory (via a call to GetModuleHandle() from ResolveMissingLibraryImportsRecursive). Also use a TSet<> to store set of visited modules rather than an Array.
Now spends <0.1s total in this function on editor startup.
(Change looks larger than it is due to moving functions out of WindowsPlatformProcess.h to avoid introducing TSet dependency into this header).
#jira UE-55642
Change 3914803 by Gil.Gribb
UE4 - Removed memory track from the lock free list links. This is not safe and will sometimes assert in debug.
#jira UE-49600
Change 3914616 by zak.parrish
Adding Calibrate button #jira none
Change 3914599 by Andrew.Rodham
Sequencer: Sequence template source signatures are now also compared to catch the case where a sub-sequence asset has been saved but not modified
- The following sequence of events exposes this issue:
- Create a master sequence with a single shot that spawns a cube
- Add this sequence to a level and set it to auto-play
- Save everything and restart
- Resave just the inner shot asset without opening it
- PIE
- The inner shot never spawns its cube because its template was wiped on save, but its signature never changed. Since the master sequence previously didn't check the template source signature, it ends up trying to evaluate an empty template.
#jira UE-55626
Change 3914479 by Krzysztof.Narkowicz
Added encoded HDR reflection capture cooking if targeting ES 2.0/3.1 on Windows
#jira UE-53875
Change 3914347 by Martin.Wilson
Stop anim preview instance from ever running in parallel
#Jira UE-55577
Change 3914179 by Benn.Gallagher
Fixed clothing sections not displaying in LOD section list in skeletal mesh editor, due to no longer duplicating clothing sections in the model data.
#jira UE-55528
Change 3914122 by Steven.Barnett
Fix perf regression in BSP queries by changing suppression of PhysX mesh cleaning failure message.
#jira UE-54081
Change 3913950 by zak.parrish
Clamping my normalization math #jira none
Change 3913926 by Zak.Parrish
First pass at Gremlin Calibrate button. Also added shirt/backpack to boy so he's not a floating head. #jira none
Change 3913668 by Matt.Kuhlenschmidt
Adding missing substance styling info
#jira UE-55081
Change 3913667 by Nick.Atamas
Merging CL 3912976 from //UE4/Partner-Google-VR/... //UE4/Release-4.19/...
Upgrading to support ARCore 1.0 runtime.
#jira UE-55602
Change 3913645 by Aaron.McLeran
#jira UE-55618 fix for mono audio devices
Change 3913509 by Cody.Albert
Removing PhsX build exclusion from Match3
#jira UE-53742
Change 3913380 by Dan.Oconnor
Preload Sequence Bindings node at proper time
#jira UE-55412
Change 3913300 by Mitchell.Wilson
Updating iOS default startup movie to H.264, 1280x720, 30 fps.
#jira UE-55382
Change 3913291 by Cody.Albert
More iOS build fixes for Match3
#jira UE-53742
Change 3913169 by Cody.Albert
Fixed iOS build issues for UnrealMatch3
#jira UE-53742
Change 3913131 by Krzysztof.Narkowicz
Fixed remaining quad overdraw viewmode contents on screen after switching to certain other viewmodes (e.g. light overlap or complexity)
#jira UE-54580
Change 3912851 by Lina.Halper
Fixed issue with pose asset blending additively multiple poses suming up to 1 weight.
#jira: UE-55603
Change 3912629 by Guillaume.Abadie
Fixes SSR that was computing vigneting according to PrevScreen that could let some outside viewport samples going through when rotating the camera.
#jira UE-55353
Change 3912170 by Martin.Wilson
Add logging for UE-55511 (NaN crash)
#jira UE-55511
Change 3912161 by Phillip.Kavan
Fix editor-only default subobjects inherited from a native C++ parent class not being handled correctly during nativized Blueprint class ctor generation.
Change summary:
- Modified FEmitDefaultValueHelper::HandleSpecialTypes() to skip editor-only checks for instanced default subobjects. These will have already been created by a native parent class.
- Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert before creating a "dummy" component in place of an editor-only instance if we're not supposed to be creating it.
#jira UE-55474
Change 3912100 by Luke.Thatcher
[RELEASE] [^] Merging (as edit) fix for building pak patches (CL 3911754) from //UE4/Dev-Core to //UE4/Release-4.19
#jira UE-55340
Change 3912072 by Mike.Beach
Art cleanup pass on AR template icon.
#jira UE-55587
Change 3912057 by Michael.Trepka
Additional widget path validity check in FSlateUser::NotifyWindowDestroyed()
#jira UE-55580
Change 3911592 by Jurre.deBaare
Crash on merge actor when Use specific LOD Level
#fix make sure we use the correct array to determine the number of components being merged
#jira UE-55508
Change 3911466 by Cosmin.Sulea
Mega change list for the following related issues:
UEMOB-417 - Support Xcode automagical code signing
UE-49829 - Remote build fails to use / sign distribution provisions coming from PC
UE-39501 - Packaging for tvOS in Distribution fails to find valid provision
UE-55334 - XCode managed provisions don╞t operate gracefully with manual provisions
UE-55330 - Automatic signing doesn't work with tvOS
UE-10969 - Remote build fails if there is no development provision provided
#jira UEMOB-417
Change 3911454 by Luke.Thatcher
[RELEASE] [!] Fix rendering thread memory leak in FLandscapeComponentSceneProxy::InitViewCustomData
- FViewCustomDataLOD is allocated on a memstack, but contains a TArray, so is not trivially destructible.
- The SubSections array is leaked when the memstack is popped.
- Fix replaces the TArray with a TStaticArray of max size MAX_SUBSECTION_COUNT (which is 4).
(Merging as edit CL 3911422 from //Fortnite/Release-3.1/... to //UE4/Release-4.19/...)
#jira UE-54835
Change 3911370 by Dragan.Jerosimovic
changed browOuterLeft -> browOuterUpLeft, browOuterRight->browOuterUpRight
updated KiteBoyHead_JointsAndBlends.fbx
#jira none
Change 3910545 by Dan.Oconnor
PR #4512: Fix FNetNameMapping::GetUniqueName regression (Contributed by dfb)
#jira UE-55513
Change 3910449 by Michael.Trepka
Fix for crash on exit on Mac when closing the root editor window with Cmd+W
#jira UE-54973
Change 3909601 by Patrick.Boutot
Expose to Blueprint GetProjectDirectory functions.
#jira UE-55548, UEENT-999
Change 3909543 by Patrick.Boutot
Rename ECollisionResponse to CollisionResponseType in script to prevent collision with FCollisionResponse.
Python's help function now output the Python type instead of the cpp type.
Do not export hidden enum entry from Python.
#jira UE-55545, UEENT-961
Change 3909289 by Zak.Parrish
Adding shirt/chest to faceAR sample #jira none
Change 3908808 by Dragan.Jerosimovic
added combination shapes network
#jira none
Change 3908788 by Mitchell.Wilson
Updaing Match3Camera to resolve clipping issue on iPhone X
#jira UE-54723
Change 3908374 by Jack.Porter
Fix viewport offset problem for preview PIE window
#jira UE-52583
Change 3907108 by Shane.Caudle
#JIRA
Added DefaultDeviceProfiles.ini to set the [IOS DeviceProfile]
+CVars=r.ShadowQuality=4
Change 3907105 by Lauren.Ridge
Fix for thumbnails not resetting when layers/blends reset and for them being incorrectly scaled when null
#jira UETOOL-1303
Change 3907011 by Chris.Phillips
UE-52667 Unable to package an Android DLC Using "Android APK" and "Android DLC" profiles in Project Launcher.
#jira UE-52667
Change 3906792 by Lauren.Ridge
When constructing the material editor viewport, use the direct method to set the environment visibility.
#jira UE-55267
Change 3906734 by Chris.Babcock
Fix issue with vertex fetch disable
#jira UE-55475
Change 3906721 by Rolando.Caloca
UE4.19 - Check if the results file from SCW is corrupt
#jira UE-53124
Change 3906648 by Chris.Phillips
UE-53184 Assertion when running mobile PIE in iPhone 5S mode.
Updated the iPhone5s.json Metal settings.
#jira UE-53184
Change 3906474 by David.Hibbitts
Added default constructor for FLiveLinkWorldTime.
#jira UEENT-879 #rb none
Change 3906467 by Lauren.Ridge
Swapping sibling materials now correctly swaps the overridden parameters out
#jira nojira demobug
Change 3906156 by Michael.Trepka
Reverting CL 3728924 as it's causing problems with modal windows. A different, much more involved fix for UE-51711 will be needed.
#jira UE-52492
Change 3906144 by Michael.Dupuis
#jira UE-54547: Added guard to be sure that material is valid
Change 3905882 by Matt.Kuhlenschmidt
Enable substance buttons again
#jira UE-55081
Change 3905513 by Sorin.Gradinaru
UE-55394 iOS crash exiting app during startup movie: SPRINGBOARD, process-exit watchdog transgression
#jira UE-55394
#jira UE-52328
#iOS
#4.19
This is a particular case of UE-52328 iOS reporting crash on application exit: SPRINGBOARD, process-exit watchdog transgression
Found several issues on iOS if the game is forced closed when the startup movie is playing and "Wait for movies to complete" is enabled in Project Settings
- the game thread is waiting for the movie to complete on game shutdown - more that 5 sec
- crash on FDefaultGameMoviePlayer::Shutdown if the above is fixed
- HTTP module no longer has time to wait for the requests to complete.
Change 3905506 by Michael.Dupuis
Remove static mesh instancing async buffer filling, as with all the changes made, it's no longer necessary, the cost of loading very large buffer is negligable
Rebuild the occlusion tree when using foliage.DensityScale with something other than 1.0
#jira 0
Change 3905498 by Lina.Halper
Fix multiple pose asset issue - fallout from CL 3903509
- as for fullbody, went back to old mathod because in the fullbody, we want shortest path most of times and you don't blend more than 1 weight, so this is likely fine
- as for additive, change to use blend from identity.
#jira: UE-55439, UE-55448, UE-55250
Change 3905325 by Sorin.Gradinaru
UE-54764 UnrealMatch3 spams Kindle device log with "Unsupported EPixelFormat"
#jira UE-54764
#4.19
Also reproduced on Samsung Galaxy S5 Neo (SM-G903F, GPU Mali-T720).
Check GMaxRHIFeatureLevel > ERHIFeatureLevel::ES3_1 (not mobile) before creating RSV params used with SupportsManualVertexFetch: (Positions, Tangents, TextureCoordinates, Color buffers)
Change 3905307 by Jack.Porter
Removed iPhone5 PIE json file as it's not a supported device
#jira UE-53184
Change 3905132 by Shane.Caudle
#JIRA
Pushed it a little more out of the yellow.
Change 3905117 by Shane.Caudle
#JIRA
Got SSS working and made some tweaks.
Change 3904936 by Max.Chen
Fix editor only
#jira UE-55459
Change 3904269 by Chris.Babcock
Disable manual vertex fetch on mobile
#jira UE-55389
#ue4
#android
#ios
Change 3904186 by Lina.Halper
Pose asset crash when skeleton not existing during serialization
#jira: UE-55422
Change 3904063 by Max.Chen
Sequencer: Fix copy/paste crash. Only process UMovieSceneCopyableBinding and objects that can be spawned by the movie scene spawn register.
Copy from Dev-Sequencer
#jira UE-55314
Change 3904060 by Lauren.Ridge
Fix for saving a child out of a layer stack capturing the wrong parameters
#jira UETOOL-1280
Change 3904050 by Luke.Thatcher
[CONSOLE] [^] Added RHI Command List Enqueue Lambda method (merging as edit CL 3879722 from //Fortnite/Main to //UE4/Release-4.19)
- Can be used to enqueue arbitrary tasks on the RHI thread from the render thread (similar to how EURC works for GT -> RT tasks), without having to write lots of bolierplate FRHICommand functor classes.
- The first overload of EnqueueLambda method will check Bypass() to determine if it should run the lambda immediately or defer to the RHI thread.
- This can be overriden via the 2nd overload if you need to check additional things such as IsRunningRHIInSeparateThread.
- The function returns true if the lambda was enqueued and deferred to the RHI thread, otherwise false. This can be used to optionally add RHIThreadFences for unlock commands etc.
#jira UE-55437
Change 3904004 by Lauren.Ridge
Fix for material layer output nodes being able to be placed in other graphs
#jira UE-54867
Change 3903931 by Aaron.McLeran
#jira UE-55435 Crash in google resonance when toggling visualization
fix for issue described here -- https://github.com/resonance-audio/resonance-audio-unreal-sdk/issues/1
Change 3903722 by David.Hill
The ProxyLOD plugin is experimental: don't load it by default.
#jira: ue-55402
Change 3903583 by Ben.Marsh
Include .version and .modules files in manifest. Should fix missing version information in precompiled binaries.
#jira
Change 3903529 by Richard.Hinckley
#jira UEDOC-7180
4.19 API Documentation manual update.
Change 3903509 by Lina.Halper
Merging using //UE4/Dev-AnimPhys/->//UE4/Release-4.19/
#DUPE MERGE: Fix issue with pose blending with shortest path - causing additive to blend linearly between pose if the rotation is same direction.
#jira: UE-55250
Change 3903501 by Michael.Dupuis
#jira UE-55122: Fixed bad neighbors updating for mobile
Change 3903387 by Will.Fissler
; r.XGEShaderCompile is now enabled by default in source. Uncomment to disable XGE shader compilation.
;r.XGEShaderCompile = 0
#jira UE-55286
Change 3903251 by Sungjin.Hong
#JIRA UE-55349
#loc added KO locallization for VR, Handheld AR templates
Change 3903219 by Adrian.Siminciuc
https://jira.it.epicgames.net/browse/UE-54738
removed redundant iOS warning when IOnlineIdentity::Login is called by FOnlineExternalUIIOS::ShowLoginUI
#jira UE-54738
#iOS
Change 3903130 by Cody.Albert
Updated build configuration to resolve iOS build error on UnrealMatch3
#jira UE-53742
Change 3903056 by Shane.Caudle
#JIRA
Latest tweaks to lighitng and rendering for boy.
Change 3903032 by Cody.Albert
Added missing include that was preventing iOS builds from succeeding on TopDown template
#jira UE-54341
Change 3902669 by Lauren.Ridge
Fix for thumbnail crash after saving material instances that contain layers
#jira crash
Change 3902581 by Mitchell.Wilson
Updating Samples and Template Min iOS Version to iOS 9.
#jira UE-55148
Change 3902448 by Lauren.Ridge
Fix for crash due to unparented material instance
#jira crash
Change 3902206 by Chris.Phillips
UE-52612 External textures only work in pixel shaders.
Sampling external textures are now only limited to pixel shaders when the shader model is < SM4.
#jira UE-52612
Change 3902120 by Peter.Sauerbrei
bvringing over the fix for backgrounding crash on iPhone X from Fortnite
#jira UE-54883
Change 3902097 by Lina.Halper
Merging using //UE4/Dev-AnimPhys/->//UE4/Release-4.19/
#DUPE MERGE: CL 3901939
#jira: UE-55401
Change 3902082 by Mike.Beach
Fixing an issue with the fix from CL 3889470 - fully matching the old UEnum name check (checking both the value name and the typed name, for example: "Left" and "EControllerHand::Left").
#jira UE-55153
Change 3901963 by Peter.Sauerbrei
bring over the fix from Fortnite for Remote Shader Compilation not respecting settings in the passed in shader
#jira UE-52797
Change 3901959 by Ethan.Geller
[Release-4.19] #jira UE-55225: Stop RtAudio stream on StopRecording in sequence recorder. #rb Aaron.McLaren
Change 3901482 by Lauren.Ridge
Fix for crash on opening materials due to array out of bounds
#jira crash
Change 3901181 by Michael.Dupuis
#jira UE-55313: To enable tessellation we MUST have 2 materials in the list
Change 3900935 by Nick.Bullard
Updating Default_Startup.mp4 with more recent UE branding.
This still requires another update for final version with audio
#jira UE-55382
Change 3900660 by Aaron.McLeran
#jira UE-55381 crash in sound submix
Bringing fix from FN to 4.19 (CL 3890630)
Change 3900643 by Aaron.McLeran
#jira UE-55380 fixing synth envelopes
Change 3900617 by Aaron.McLeran
#jira UE-55151 Fixing crash w/ mic component
Change 3900544 by tim.gautier
QAGame: Submitting asset for AsNumber fix submitted with UE-10310
#jira UE-29618
Change 3900430 by Ryan.Brucks
KismetRenderingLibrary: Applied a fix from FN to make it possible to create textures from BP created RTs. Without the fix the assets would be created but invisible to the user due to missing RF_Public and RF_Standalone.
#JIRA none
Change 3900399 by Lauren.Ridge
Fixing global parameters not working
#jira UE-55242
Change 3900297 by Ben.Marsh
Speculative fix for hot reload causing version files to be updated with a locally made installed build.
#jira UE-55072
Change 3900116 by Chris.Bunner
Removing outdated tests and test assets.
#jira UETOOL-1298
Change 3900042 by Chris.Bunner
Deleted SharedInputCollection and associated material graph nodes.
#jira UETOOL-1298
Change 3899887 by Lauren.Ridge
Fix for background checkbox stomping profile info for material editor. Note that you may have to delete Saved/Config/Windows/Editor.ini to get this to work.
#jira UE-55267
Change 3899824 by Chris.Phillips
UE-52813 Editor's mobile preview doesn't serialize the landscape's cooked heightmap data.
Now only regenerating landscape pixel data when needed when using Mobile Preview Rendering Levels.
#jira UE-52813
Change 3899775 by Lauren.Ridge
Fix for crash on opening material layer material
#jira crash
Change 3899673 by Jamie.Dale
Fixed Functions sometimes being exposed to Python as if they were Structs
#jira none
Change 3899487 by Chris.Bunner
Duplicate [CL 3852020, 3896571] - Disabling non-performant code only required by experimental material layers feature. Users can opt-in per-project through experimental renderer settings, replacing the previous editor experimental flag.
#jira UETOOL-1298
Change 3899156 by Phillip.Kavan
Include address of object reference in persistent frame debug info.
#jira UE-51952
Change 3899146 by Rolando.Caloca
UE4.19 - hlslcc - Workaround for intrinsics with two output arguments
#jira UE-52477
Change 3899060 by Bart.Hawthorne
Add a null check for the game mode pointer in UWorld::SpawnPlayActor
#jira UE-54461
Change 3899015 by Krzysztof.Narkowicz
Fixed initialization of instancing random vertex stream.
#jira UE-53605
Change 3899008 by Michael.Dupuis
Fix issue with landscape mobile vertex factory accessing unbound LodTessellationParams when r.ShaderDevelopmentMode=1
#jira 0
Change 3898994 by Phillip.Kavan
More verbose debug logging if an invalid object reference is detected in the BP ubergraph frame during garbage collection.
#jira UE-51952
Change 3898962 by Guillaume.Abadie
Fixes wrong parameters about whether GPU timing may have CPU generated bubbles to the dynamic resolution heuristic.
#jira UE-55352
Change 3898826 by Sorin.Gradinaru
UE-54784 StrategyGame crashes entering game on KindleFire 7 - Assertion failed: ViewSize.GetMin
#4.19
#Android
#jira UE-54784
Wrong code to make an integer even + operator precedence
Change 3898822 by Sorin.Gradinaru
UE-52328 iOS reporting crash on application exit: SPRINGBOARD, process-exit watchdog transgression
FORT-70783 FHttpManager::Flush is immediately canceling all HTTP requests
#jira UE-52328
#jira FORT-70783
#iOS
#PC
#4.19
UE-52328 reopened because of FORT-70783
iOS only: Delay Request->CancelRequest() on Http module shutdown - wait for 2 sec on FHttpManager::Flush to allow pending requests to be sent to the server.
Change 3898705 by Max.Chen
Sequencer: Skip if the binding id's sequence can't be found.
#jira UE-55337
Change 3898108 by Michael.Dupuis
#jira UE-54547: Remove the FORCEINLINE so we get a proper callstack of what's happening
Change 3898076 by Max.Chen
Sequencer: Override the animation asset in the player state if it doesn't match the animation asset that's being evaluated.
#jira UE-55328
Change 3897897 by Matt.Kuhlenschmidt
Disable substance buttons for now
#jira UE-55081
Change 3897742 by Aaron.McLeran
Merging fix for UE-55223 to 4.19
#jira UE-55223
Change 3897538 by Michael.Dupuis
#jira UE-53787: Added guard if for some reason the material is null we should not try to draw using this material
Change 3897406 by Phillip.Kavan
Back out local debug logs.
#jira UE-51952
Change 3897400 by Phillip.Kavan
Serializing object will now be passed to GC so that it can be logged in case the referenced objects is garbage.
- Mirrored from //UE4/Dev-Core (3871863).
#jira UE-51952
Change 3897391 by Max.Chen
Sequencer: Don't update current time to be within the view range when stepping into a sequence.
#jira UE-55322
Change 3897274 by Krzysztof.Narkowicz
Fixed issues with loading shaders from DDC - hardcoded CustomAttributes initialization instead of filling them inside UObject costructors in order to properly initialize CustomAttributes before DDC key was created. Added an assert that CustomAttributes are initialized before the AttributeDDCString, so we won't run into this issue again in the future.
#jira UE-54683
Change 3897148 by Adrian.Siminciuc
https://jira.it.epicgames.net/browse/UE-55147
#4.19
#iOS
#jira UE-55147
Change 3897138 by Max.Chen
Sequencer: Fix crash when an actor factory is not found.
Copy from Dev-Sequencer
#jira UE-55309
Change 3897045 by Jack.Porter
Fix for crash in ALandscapeProxy::UpdateGrass
#jira UE-54362
Change 3897036 by Jack.Porter
Fix InstancedStaticMesh crash with invalid lightmap coordinates
#jira UE-54423
Change 3896801 by Dmitriy.Dyomin
Fixed: Planar reflections does not handle origin rebasing
#jira UE-52351
Change 3896743 by Dmitriy.Dyomin
Discard CPU copy of vertex/index buffers in OpenGL RHI
#jira UE-52133
Change 3896619 by Guillaume.Abadie
Cherry-pick 3896598: Fixes after TAAU post process material that had wrong default buffer UV.
#jira UE-55317
Change 3895718 by Max.Chen
Sequencer: Null checks to prevent crash when saving the default state of a spawnable
#jira UE-55304
Change 3895426 by Rolando.Caloca
UE4.19 - Add an increased timeout for SCW to avoid OOM situations
#jira UE-55306
Change 3895245 by tim.gautier
QAGame: Submitting updated test assets. Broke ML_Base out into individual components
#jira UE-29618
Change 3895194 by Marc.Audy
Prevent crash due to a null entry in the linked to graph of the destination pin
#jira UE-54606
Change 3894913 by Arne.Schober
REL - Fix crash in Speedtree wind where Renderdata is unavailable
#jira UE-54544
Change 3894625 by Arne.Schober
REL - Fix assert not in RenderingThread from Triangle Renderer.
#jira UE-55247
Change 3894464 by Martin.Wilson
Extra debugging info for UE-54705 plus remove check so it is no longer fatal
#jira UE-54705
Change 3894450 by Martin.Wilson
Remove pinnable ness of retarget asset. Paves the way for exposing retarget asset properties on the node
#jira none
Change 3893948 by Jostin.Bilyeu
Adding default player start location to help with launch on testing within level TM-Materials_POM
#jira UE-55063
Change 3893495 by Robert.Manuszewski
Fixing a crash when running DDC commandlet
#jira UE-54646
Change 3893451 by Jurre.deBaare
Altered fix for actor merging with negative scaling to get correct normals
#jira UE-54996
#misc updated automated test to include this test-case
Change 3892913 by Ethan.Geller
[Release-4.19] #jira UE-55151 Fix for Mic Component crashing on re-init. #rb aaron.mcleran
Change 3892871 by Ryan.Vance
Multi-view requires the day dream compositor.
#jira UE-55253
Change 3892785 by Arciel.Rekman
Linux: fix inability to create a C++ project (UE-55222).
- NullSourceCodeAccessor will unconditionally allow C++ project creation in source builds.
- Installed build will check for more compilers in commonly found locations.
#jira UE-55222
Change 3892687 by Jostin.Bilyeu
Checking in replacement Built Data for map TM-Materials_POM
#jira UE-55063
Change 3892674 by Jostin.Bilyeu
Adding an invisible plane to TM-Materials_POM to help testing on mobile devices
#jira UE-55063
Change 3892622 by Aaron.McLeran
#jira none Fixing scope lock in phonon probe volume
Change 3892511 by Matt.Kuhlenschmidt
Fix zero engine version warning
#jira UE-55081
Change 3892211 by Yuriy.ODonnell
Fix/workaround for inconsistent preprocessor definitions for NVAftermath that result in FD3D11DynamicRHI class layout mismatch. NVAftermath support is now enabled by default for Win64.
NVAftermath is declared as a private dependency in D3D11RHI. It does not automatically propagate to modules that explicitly include private RHI headers (OculusHMD, OSVR, OSVRInput). This results in NV_AFTERMATH being defined while compiling RHI module and not defined when compiling other modules, causing memory corruption at runtime.
The long-term solution for this and similar issues requires some mechanism for adding transitive module dependencies, so that anyone that depends on D3D11RHI module would automatically also get the NVAftermath. Additionally, private headers should *never* be included directly by external modules.
The short-term solution is to explicitly add NVAftermath dependency to OculusHMD, OSVR and OSVRInput.
Additionally, NV_AFTERMATH is no longer forced by D3D11RHIPrivate.h when it's not defined. This allows catching this kind of mismatch in the future through a compiler warning (C4668).
#jira UE-53065
Change 3891732 by Brian.Zaugg
Re-adding iPhoneX launch images with correct case.
#JIRA UE-53541
Change 3891727 by Arne.Schober
REL - Do not recreate one Frame Resource for dynamic draws
#jira UE-55063
Change 3891716 by Ben.Marsh
Fix buffer overrun when generating callstack.
#jira
Change 3891697 by Brian.Zaugg
Deleting iPhoneX launch images that have incorrect case.
#jira UE-53541
Change 3891678 by Brian.Zaugg
IPP binaries for iPhoneX support.
#jira UE-53541
Change 3891525 by Lauren.Ridge
Thumbnails now update correctly w/parameters
#jira UETOOL-1333
Change 3891520 by Lauren.Ridge
Fixing SA error in material editor
#jira UE-55206
Change 3891495 by Jurre.deBaare
Normal are different after Merge Actor on scaled objects
#fix Make sure we do not apply scale when transform Normals/Tangents
#jira UE-54996
Change 3891352 by Guillaume.Abadie
Fixes ensure when visualizing HDR with TAAU.
#jira UE-55019
Change 3891323 by Matt.Kuhlenschmidt
Added substance buttons to content browser and material editor
#jira UE-55081
Change 3891033 by David.Hibbitts
#JIRA UE-55135
Moved Message Bus Source heartbeats to their own thread using a new FHeartbeatManager singleton. This prevents sources from incorrectly being removed during Slate UI operations.
Change 3890642 by Arne.Schober
REL - Better fix for Paper2d which honors batching
#jira UE-55063
Change 3890593 by Arne.Schober
REL - Fix Paper2d crash. When addMesh is called the Vertex and Indexbuffers are nulled out. re-create Dynamic Mesh builder for every Mesh instead.
#jira UE-55063
Change 3890502 by Mike.Erwin
Fix reported VRAM size on Metal
We were getting correct value in MB from system but overflowing uint32 arithmetic when converting to bytes.
This led 4GB and 8GB configs to report 0 total VRAM, 0 dedicated tex mem, and GTexturePoolSize = 0.
Noticed the problem on my 6GB FirePro, which reported 2GB and set GTexturePoolSize to 70% of that.
Also fixed log of texture pool size to show MB. Other platforms' RHIs already report this in MB.
#jira none
Change 3890404 by Jostin.Bilyeu
Updating Demo Display names to remove redundant spaces
#jira UE-29618
Change 3890401 by Dan.Oconnor
Fix for property table performance regression
#jira UE-54984
Change 3890194 by Dan.Oconnor
Make sure a CDO's subobjects are preloaded when running in -game
#jira UE-54242
Change 3890182 by Krzysztof.Narkowicz
Moving CL3867594 from Dev-Rendering to fix missing shaders in cooked Binary Editor DCC. USE_EDITOR_ONLY_DEFAULT_MATERIAL_FALLBACK generated default material shaders had no cooking code path.
#jira UE-54683
Change 3890140 by Rob.Cannaday
Merging cacert.pem from //UE4/Dev-Online to //UE4/Release-4.19
Includes latest cacert.pem from https://curl.haxx.se/docs/caextract.html as of January 17, 2018
#jira none
Change 3889850 by Shaun.Kime
Now initializing Niagara scripts and emitters even if the config file isn't ready yet.
#jira UE-54168
#jira UE-54169
#tests can create a blank emitter and all script sub-types
Change 3889833 by Michael.Trepka
Disabled Clang's unused-lambda-capture warning added in Xcode 9.3
#jira none
Change 3889696 by Patrick.Boutot
Allow rename from AssetTool when there is no source control enabled.
Fix crash when you rename an asset without an enabled source control.
#jira UEENT-803
Change 3889470 by Mike.Beach
Switching the source-name to legacy hand enum lookup functions to use a static table instead of finding a UEnum object and iterating over reflection data (to prevent a GC lockup with the UObject query).
#jira UE-55153
Change 3889319 by Matt.Kuhlenschmidt
Disable hardware survey on build machines. They run windows server and lack the necessary win32 api functionality to execute it properly
#jira UE-55166
Change 3889087 by Jostin.Bilyeu
Minor adjustments TM-SceneTexture for better testing clarity. Minor adjustments to TM-MipLevels for test map clean up
#jira UE-29618
Change 3889073 by Sorin.Gradinaru
UE-55117 Android virtual keyboard can have text input hidden by software buttons
#jira UE-55117
#Android
#4.19
Adjusted x-coord and width for the native EditText
Change 3888841 by Jurre.deBaare
Make FSkeletalMeshRenderData::GetMaxBonesPerSection an ENGINE_API exported function
#jira none
Change 3888837 by Guillaume.Abadie
Fixes a crash in dynamic resolution when doing UE4Editor -server
#jira UE-55158
Change 3888831 by Dragan.Jerosimovic
added fbx files
#jira none
Change 3888340 by Ethan.Geller
[Release-4.19] #jira UE-54787 edit settings for Strategy Game to prevent stuttering in AudioMixer on low performance Android Devices #rb Aaron.McLeran #fyi Aaron.McLeran #lockdown Cristina.Riveron
Change 3888133 by Michael.Karambelas
QAGame: Adding a BP Actor to test the Mic component feature that AaronM implemented with UE-51471.
#jira UE-29618
Change 3887957 by Krzysztof.Narkowicz
"Fixed" Vulkan instancing in by doing Metal style set instance offset to 0 hack
#jira UE-54367
Change 3887912 by Jostin.Bilyeu
Adding content to TM-SceneTexture to verify Screen Positioning as well as Scene Color and Depth. Adding a new map (TM-MIPLevels) for testing custom mip levels
#jira UE-29618
Change 3887571 by Zak.Parrish
Adding FaceAR content and cleanup #jira none
Change 3887458 by Dan.Oconnor
Fix 'Step Out' functionality for macro and collapsed graphs
#jira UE-55000, UE-55002, UE-55022
Change 3886883 by zachary.wilson
Add testing content to QAGame: Texture and material for testing mip levels. Postprocess material for testing scene buffer sampling.
#jira UE-29618
Change 3886848 by Max.Preussner
Engine: Workaround for uninitialized external textures causing white flashes in media playback
Copied from Fortnite-Main and Dev-Sequencer
#jira UE-53357
Change 3886720 by Matt.Kuhlenschmidt
Guard against mac menus updating during slow tasks.
#jira UE-55068
Change 3886657 by Guillaume.Abadie
Cherry-pick 3886626: Cherry-pick 3886560: Fixes strong aliasing on TAAU's fast shader permutation.
This adds a 6th neighbor sampling, and switch AA_TONE ON as TAA does for its fast shader permutation.
#jira FORT-69961
Change 3886653 by Matt.Kuhlenschmidt
Perforce Plugin: Removed all calls to methods that would update the P4PASSWD environment variable. Perforce stores this as plain text so it is not safe and we do not want the editor to be responsible for this being set. All users should be using ticket based p4 servers for the best security but if they are unable to then they can call p4 passwd on their own to set a slightly better hashed password directly. They may also log in each time to the editor which prevents any password from being stored
#jira UE-55111
Change 3886621 by Benn.Gallagher
Fixed crash closing clothing tab if workflow centric application puts the tab spawners in a bad state due to incorrect handling of tab context menus.
#JIRA UE-55067
Change 3886552 by Thomas.Sarkanen
Fixed crash loading an anim instance with a re-instanced class
Unable to repro, but in editor we dont need the optimization that this provides. Now we always re-initialize functions and properties in case the class has changed out from under us.
#jira UE-55065 - [CrashReport] UE4Editor_Engine!FExposedValueHandler::Initialize() [animnodebase.cpp:521]
Change 3886442 by Cosmin.Sulea
UE-53033 - Editor Rapidly Spawns Multiple Empty Windows Throughout Remote Shader Compiling
#jira UE-53033
Change 3886441 by Cosmin.Sulea
UE-54598 - Using an Invalid iOS Mobile Provision does not give descriptive error in Project Launcher, IPhonePackager
#jira UE-54598
Change 3886427 by Sorin.Gradinaru
UE-54139 Possible crash with new virtual keyboard on Android if suggestions not disabled - from //Dev-Mobile@CL3843552
#4.19
#Android
#jira UE-54139
S8 on 7.0 is not hiding suggestions and disabling predictive input. There are cases with this that can cause a crash.
Fix: On text change, downgrade to simple suggestions all the easy correction spans that are not a spell check span (remove android.text.style.SuggestionSpan.FLAG_EASY_CORRECT flags)
Change 3886210 by Ethan.Geller
[Release-4.19] #jira UE-53867 Ensure we don't read off into garbage memory for uncompressed PCM.
Change 3886005 by Zak.Parrish
Checking in faceAR work on behalf of 3Lateral #jira none
Change 3885925 by Mike.Erwin
Material preview label off-center on HiDPI screen
#jira UE-52533
Change 3885778 by Dan.Oconnor
Fix stepping over collapsed graph and macro nodes
#jira UE-54950, UE-54955
Change 3885713 by Mike.Erwin
glTF: fix material using wrong textures
Imported material could plug the wrong textures into its inputs. The previous code tracked a material's textures based on image source index, corrected code uses texture (source + sampler) index. This is more general allowing an image to be referenced by multiple textures.
Bug reported yesterday via email, demonstrated using the Khronos TextureSettingsTest sample model.
#jira none
Change 3885603 by Ben.Marsh
Fixes for compiler errors in nightly builds of VS2017 in /permissive- mode.
#jira
Change 3885566 by Phillip.Kavan
Fix a scoping issue related to inaccessible property reference caching in nativized Blueprint code.
Change summary:
- Modified FDefaultSubobjectData::EmitPropertyInitialization() to utilize the FScopeBlock utility to manage the inaccessible property cache during code generation for instanced subobject initialization.
#jira UE-55061
Change 3885481 by Mark.Satterthwaite
Attempt to workaround an Intel shader compiler bug without reopening a related AMD bug. This may cost performance unless function constants are available and the runtime compiler actually bothers to perform optimisation (AMD's did not in 10.12.6 and earlier).
#jira UE-54333
Change 3885461 by Lauren.Ridge
Fix for slot not being initialized to null
#jira UE-55069
Change 3885455 by zak.parrish
Adding initial files for FaceAR scene lookdev #jira none
Change 3885446 by Zak.Parrish
Adding test assets for Gremlin look dev. May get removed later prior to release. #jira none
Change 3885424 by Krzysztof.Narkowicz
Fixed skeletal mesh LODs inside editor. If skeletal mesh wasn't recently visible, code was incorrectly changing LOD settings without updating LOD data on render thread.
#jira UE-53861
Change 3885406 by Zak.Parrish
Rollback //UE4/Release-4.19/Samples/FaceARSample/Content/UI/FaceARDebugUI.uasset to revision 1 #jira UE-54639
Change 3885340 by Arne.Schober
REL - Bitarray FindFromLast was masking incorrectly for the corner case where there is no slack
#jira none
Change 3885143 by Marc.Audy
Merge memory corruption fix in CL# 3884991 from Fortnite-Staging to Release-4.19
#jira UE-54977
#jira UE-54976
#jira UE-54898
Change 3885093 by Mark.Satterthwaite
Apple don't like testing for the validation layer in iOS App Store builds - it is unnecessary so we can disable this for shipping builds.
#JIRA N/A
Change 3884622 by Jurre.deBaare
Moving over missing file from changelist for UE-54508
#jira UE-54508
Change 3883391 by Nick.Atamas
Fix for UE-54622 : PIE in VR available when ARKit/ARCore plugins enabled.
Only create ARKit/ARCore tracking systems on iOS/Android.
#jira UE-54622
Change 3883257 by Phillip.Kavan
Fix a Blueprint compile error for the GetClassDefaults node Map value outputs introduced by stronger type checking in 4.19 between Map pin types.
#jira UE-55026
Change 3883024 by Lauren.Ridge
Fixing static analysis warning
#jira SA
Change 3882510 by Michael.Dupuis
#jira none : Fixed screen size calculation to take aspect ratio into account correctly
Change 3882502 by Lauren.Ridge
Fix for material layer parameters not rebuilding and adding save child button
#jira UETOOL-1275
Change 3882458 by Krzysztof.Narkowicz
Copying cached shadow map assert fix from Fortnite-Main (CL3802813)
#jira UE-54747
Change 3882366 by Michael.Karambelas
QAGame: made changes to QABP_Debugging, QABP_FunctionLib, and QA_TestHelper for Blueprint debugger tests.
#jira UE-29618
Change 3881971 by andrew.porter
QAGame: Removing actor from Shot_003
#jira UE-29618
Change 3881795 by Krzysztof.Narkowicz
Added encoded HDR reflection capture cooking if targeting ES 2.0/3.1 on Windows
#jira UE-53875
Change 3881550 by David.Hibbitts
#JIRA UEENT-879
Subject frames now store world time explictly as a double with optional scene timecode as MetaData. This allows for use cases such as posing a single frame in Maya where the world time would be changing but the scene timecode associated with the animation remains fixed.
THIS IS A BREAKING CHANGE: Sources from before this change will no longer compile.
Change 3881339 by Jurre.deBaare
Moving over:
"Editor crashed when attempting to bake out all the material channels
#jira UE-54508
#misc small UDN Merge actor / bake material fixes
Change 3879557 by Dan.Oconnor
Fix stepover behavior when no debug target is selected
#jira UE-54978
Change 3879485 by Mike.Beach
Limiting the number of stereo layers on Oculus android to 4 (otherwise, their lib crashes).
#jira UE-54999
Change 3879438 by David.Hibbitts
#JIRA UEENT-880 Added support for Subject level MetaData to LiveLink #rb martin.wilson #fyi james.golding, simon.tourangeau
Change 3879343 by Lina.Halper
Last min change that skiped compiling
#jira: none
Change 3879337 by Lina.Halper
Fix issue where tick is skipped due to last ticked pose isn't cleared after AnimInstance changes.
#jira: UE-54806
Change 3878968 by Phillip.Kavan
Fix deprecation warnings in compiled stub class wrapper codegen for Blueprint class dependencies excluded from nativization.
Change summary:
- Modified FBlueprintCompilerCppBackendBase::GenerateWrapperForClass() to const-correct the assignment of cached weak pointers to referenced properties.
#jira UE-54981
Change 3878962 by Adrian.Siminciuc
https://jira.it.epicgames.net/browse/UE-54831 (No error occurs accepting if Android SDK license file cannot be written, but user cannot accept license)
#4.19
#jira UE-54831
#android
- shows an error message box informing that the license file could not be written.
Change 3878821 by Andrew.Rodham
Sequencer: Fixed overlapping ranges being inserted into the evaluation field during compilation
- The issue was that track segments that had been combined with adjacent segments (due to them being identical) would potentially cause a subsequently compiled frame to overlap with a range that had already been inserted into the evaluation field.
- The insertion code previously asserted that only minor overlaps were catered for (due to fp rounding errors) and assumed that a supplied range could not entirely contain any other range in the field.
- The solution is to supply the insertion time along with the range to know exactly where the data should live in the field, and crop the range to the maximum allowable space between adjacent ranges.
#jira UE-54922
Change 3878171 by Chris.Phillips
Android: Fixed crash after splash screen when using Vulkan.
#jira UE-54299
Change 3877950 by Ethan.Geller
Fix copyright information from previous CL #jira none #rb none #lockdown Cristina.Riveron
Change 3877859 by Nick.Shin
rebuilt lighting for TM-ShaderModels and resaved the level
#jira UE-53374 Client displays "lighting needs to be rebuilt (1 unbuilt object(s))" when launching TM-Shadermodels onto HTML5
Change 3877854 by tim.gautier
Adding additional (temp) ML Test asset
#jira UE-29318
Change 3877609 by Ethan.Geller
[4.19] Change FWhiteNoise generate function to use SRand, due to weird distribution in FRandRange #jira UE-54965 #rb aaron.mcleran #lockdown cristina.riveron
Change 3877474 by Lauren.Ridge
Adding WITH_EDITOR wrappers to editor-only section of code
#jira fixingcompiles
Change 3877271 by Arne.Schober
REL - Integrate 3872827 - The VFs are not owners of the data, e.g the underlying Buffers might be released before this and this reference counting should not be neccessary
#jira none
Change 3877260 by Lina.Halper
If revision is too far away, ignore the request and send current buffer
- this is exactly how it used to do and it is still required, but this means motion vector will be ignored when this happens
#jira: UE-54398
Change 3876950 by Lauren.Ridge
Renaming layers in a material instance - from 4.19 preview feedback
#jira UETOOL-1296
Change 3876932 by Arciel.Rekman
Linux: updated the link to the cross-toolchain (UE-54597).
#jira UE-54597
Change 3876918 by Phillip.Kavan
Fix a regression that could cause packaging to fail and/or data loss with Blueprint nativization enabled.
Change summary:
- Removed logic that attempted to avoid redundant assignments of instanced default subobject references. This was not compatible with editinline characteristics that can allow certain object reference values to be overridden by the Blueprint class.
- Explicitly defer to ExportTextItem() when generating C++ code for UObjectProperty/UInterfaceProperty reference values in which the underlying object reference is NULL.
#jira UE-54870
Change 3876759 by tim.gautier
Updated Material Layer test assets to include Opacity and Emissive.
#jira UE-29318
Change 3876575 by Michael.Karambelas
Updating the QABP_Debugging asset in QAGame with a couple of interfaces and additional logic for testing purposes.
#jira UE-29618
Change 3876406 by Robert.Manuszewski
Fixed a crash when reporting linker errors
#jira UE-51037
Change 3875891 by Nick.Atamas
Fixed scenario where geometries were being updated once per pin, instead of just being updated once.
Also fixes a scenario where there are no pins and geometries fail to update.
#jira UE-54914
Change 3875880 by Aaron.McLeran
#jira UE-54916
Fixing up submix effect templates
Change 3875673 by Brandon.Schaefer
Fix Apex dependencies
Depend on static Apex libraries in Apex.Build.cs versus Physx.Build.cs
#jira UE-54861
Change 3875498 by Lauren.Ridge
PR #4477: 4.19 Fixed a crash caused by the layered material property widget of the material instance editor. (Contributed by mlaveaux)
#jira UE-54862
Change 3875322 by tim.gautier
Recreating Material Layer test assets (asset version has changed)
#jira UE-29318
Change 3875157 by Aaron.McLeran
#jira UE-54901 Synth components do not allow sends to buses
Change 3875103 by Brandon.Schaefer
Need to use our bundled libc++.so not libstdc++.so when building Apex/PhysX/NvCloth libraries
#jira UE-54815
Change 3875037 by Aaron.McLeran
#jira UE-54896 Fixing up audio capture component to parameterize the delay
Parameterize the jitter latency delay.
Change 3875026 by Aaron.McLeran
#jira UE-54895 Filter frequency values don't update live with EQ effects and 0-frequency cutoff causes pops
Change 3874927 by Ryan.Vance
#jira UE-54894
Ensure we don't delete aliased texture resources, they are managed externally.
Change 3874925 by Martin.Wilson
Remove XR post fix from live link code written during motion controller integration
#jira none
Change 3874354 by Ben.Marsh
Use the compiler matching the user's preferred IDE if they don't have a specific compiler selected in the project settings.
#jira UE-54272
Change 3877545 by Ben.Marsh
Replace FPlatformMisc::DebugBreak() with the UE_DEBUG_BREAK() macro. VS2017 is able to show force-inlined calls on the callstack, which makes debugging asserts and ensures annoying.
Use similar logic for expanding ensure() macros in place.
#jira UE-54961
[CL 3963579 by Ben Marsh in Main branch]
2018-03-24 09:22:20 -04:00
|
|
|
if (Class == UMaterialExpressionMaterialLayerOutput::StaticClass())
|
Copying //UE4/Dev-Rendering to //UE4/Dev-Main (Source: //UE4/Dev-Rendering @ 3680113)
#lockdown Nick.Penwarden
#rb none
============================
MAJOR FEATURES & CHANGES
============================
Change 3441680 by Uriel.Doyon
Added units to point light intensity, to allow the user to specify the value in candelas or lumens.
New point light actors now configure the intensity in candelas by default.
Replaced viewport exposure settings by an EV100 slider.
Hidding the tone mapper in the show flag now still applies the exposure.
Added a new AutoExposure method called EV100 which allows to specify :
- MinEV100, MaxEV100
- Calibration Constnat
- Exposure Compensation
#jira UE-42783
Change 3454934 by Chris.Bunner
Backing out changelists 3441680, 3454636 and 3454844 for the sake of integration stability.
Change 3629223 by Rolando.Caloca
DR - Rollback //UE4/Dev-Rendering/Engine/Source/Runtime/VulkanRHI to changelist 3627847
Change 3629708 by Rolando.Caloca
DR - vk - Redo some changes from DevMobile
3601439
3604186
3606672
3617383
3617474
3617483
Change 3636145 by Chris.Bunner
Linux compile fix.
Change 3636198 by Chris.Bunner
Include fix.
Change 3636225 by Daniel.Wright
Removed spammy draw event
Change 3636397 by Daniel.Wright
Visualize volumetric lightmaps uses 18% grey in lit mode
Change 3636398 by Daniel.Wright
Translucency lighting modes work with Volumetric Lightmaps
* The old Indirect Lighting Cache always interpolated one sample per object, while Volumetric lightmaps operate at the frequency of the Translucency Lighting Mode (per-vertex or per-pixel) so the lighting accuracy is much higher.
* The old ILC always applied the single lighting sample with a per-pixel normal, even in per-vertex lighting modes
* Volumetric PerVertex NonDirectional (cheapest lit translucency) went from 74 instructions down to 42
* Volumetric Directional went from 104 up to 122
Change 3636604 by Chris.Bunner
Added a material translation error on identically named/associated but differently valued parameters as this will cause one of them to be lost during parameter evaluation, the result being "random".
Change 3637668 by Rolando.Caloca
DR - hlslcc - Skip preprocessor when not required which reduces peak mem consumption by ~500 MB
- Fix missing indexing on intrinsic return type
Change 3638541 by Chris.Bunner
Fixed editor materials - Skip hardcoded parameter names that we rely on being overridden when checking for non-matching duplicate parameters.
Change 3638798 by Mark.Satterthwaite
Rebuilt hlslcc for Mac for Rolando's 3637668 changes.
Change 3638861 by Mark.Satterthwaite
Missed making a log verbose in the Metal ring-buffer.
Change 3639482 by Rolando.Caloca
DR - vk - Minor fixes
Change 3639909 by Michael.Lentine
Add special case for struct needed to compile.
Workaround issues in parser such that (x)[0] is replaced with x[0] and (x).a is replaced with x.a.
Change 3639916 by Michael.Lentine
Spelling fix.
Change 3640053 by Mark.Satterthwaite
Fix Desktop Forward rendering on Nvidia Metal rendering on macOS by modifying the shader and runtime to treat ForwardLocalLightBuffer data as uint rather than float and invert the use of as*() casts.
Tthis is *necessary* to avoid a bug/limitation of Nvidia's current Metal shader compiler that flushes all denorm values to zero on load from any resource. AMD & iOS Metal only flush-to-zero when sampling from textures and that's what Apple regard as the expected behaviour. I have however asked them to standardise on the D3D behaviour of preserving denorms on all load, move (incl. min/max/as*()-casts) & store operations. This won't happen in the current or imminent OS/Xcode releases.
Now only Intel Metal is broken and their problems run deeper.
#jira UE-48881
Change 3640983 by Olaf.Piesche
Cache the depth buffer collision shader for GPU particles even when simple forward is enabled, as that can be turned off at runtime.
#jira UE-48799
Change 3641480 by Michael.Lentine
Add min16float to FP16Math
Change 3642442 by Mark.Satterthwaite
Fix the native shader libraries again & undo the increase in cook time from changes to the way FShaderCodeLibrary was compiling & deduplicating the shaders.
- Remvoe the single linear array for accumulated shader code: reallocating this is tremendously expensive and will double the time taken to iteratively cook large projects.
- Uncompress the shader data for the native library system so that it actually works again.
- Fix some errant change to the Metal compiler that was trying to wedge the fully compiled library into the single Metal library which is 100% bogus.
#jira UE-49192
Change 3642919 by Chris.Bunner
Reverted unintended changes to material static parameter set serialization.
Bumped material version to force re-serialization.
Fixed a few typos.
Change 3642923 by Richard.Wallis
Fix for "Pixel Inspector On" message not disappearing when closing pixel inspector window while on. Handle tab closed events to cancel the pixel inspector if window closed while running.
#jira UE-46504
Change 3643296 by Michael.Lentine
Convert all structures that aren't use globally to halfs.
Change 3643381 by Ryan.Brucks
New Plugin allowing Blueprint Texture and RT reads as well as MIC creation and modification.
Change 3643929 by Ben.Salem
Added better precision on thread values in Perf Monitor. Also added global thread values to go with per-world ones to help track down the most accurate numbers possible.
#tests Ran locally, changes validated by benj
Change 3644203 by Mark.Satterthwaite
Refactor mtlpp a little bit to make the compiler do more of the work & update for all the latest publicly exposed APIs.
Change 3644336 by Mark.Satterthwaite
Ref-count the mtlpp Device object so that it can be the repository for IMP caching - now just have to go through the types created from a specific device and have them keep a reference....
Change 3644431 by Uriel.Doyon
Added a intensity units property, for point lights and spot lights, that can be set to Candelas, Lumens or Unitless (legacy).
The default units value for newly placed point lights and spot lights is configured in the project settings.
Spot lights configured in lumens have their whole luminous energy redirected toward the cone.
This means that changing the outer cone angle, changes the spot light brightness.
New exposure menu that uses an EV100 slider.
New post process settings "camera" tab regrouping : ShutterSpeed, ISO, Aperture and ExposureCompensation.
Post process settings "auto exposure" tab renamed "exposure".
The calibration constant for "Auto Exposure Basic" is now configurable in the advanced tab.
The auto exposure method is renamed "Metering Mode"
New pre-exposure feature that allows the engine to apply the previous frame exposure before writing to the scene color.
This allows the engine to render the scene with similar range than the final color (after exposure), and avoid arithmetic overflow for low precision RT formats.
The amount of exposure applied directly is called pre-exposure, and is compensated by a smaller post-exposure value.
Change 3645098 by Marcus.Wassmer
Don't add meshes twice when in simpleforward
Change 3645551 by Daniel.Wright
VolumetricScatteringIntensity is greyed out based on Mobility
Change 3645707 by Chris.Bunner
Skip empty parameters when identifying invalid duplicates during material translation.
Change 3646225 by Uriel.Doyon
Texture streaming support for particle sub-uv
Change 3646323 by Rolando.Caloca
DR - vk - Fix bad update texture 2/3d parameters
Change 3646463 by Mark.Satterthwaite
Metal shader files that can serve as extensions to the metal_stdlib rather than trying to wedge even more into the shader compiler. Might as well leverage Metal's C++'ness.
Currently just a skeleton of a buffer type that would better emulate HLSL Buffer<>/RWBuffer<> objects.
Change 3646727 by Marcus.Wassmer
fix linux and nonunity compiles
Change 3647777 by Rolando.Caloca
DR - Mobile Vulkan optimization
Change 3647822 by Lauren.Ridge
Layers are now renameable (except Layer 0 is always "Background") in Material Layers Functions
Change 3647918 by Chris.Bunner
Static analysis fixes - Monolithic include, forward delcared enums, locally shadowed variable.
Change 3648010 by Michael.Lentine
Don't use min16float by default.
Change 3648015 by Michael.Lentine
Add special case fixes for min16float as well as half on console.
Change 3648024 by Lauren.Ridge
Moving MaterialLayersFunctions Layer naming to EditorOnly wrappers
Change 3648127 by Lauren.Ridge
Moving name getter functionality to FMaterialLayersFunctions
Change 3648265 by Lauren.Ridge
Fixing loctext key
Change 3648293 by Rolando.Caloca
DR - D3D12 fix
Change 3648326 by Rolando.Caloca
DR - vk - Added subrectangle support when updating Texture2D and Texture3D
Change 3648522 by Rolando.Caloca
DR - vk - Do not try to create a BufferView of a StructuredBuffer (no valid pixelformat)
Change 3648612 by Rolando.Caloca
DR - vk - Implement RHIMapStagingSurface
Change 3648673 by Rolando.Caloca
DR - vk - Reduce Vulkan pipeline cache disk size by filtering duplicated shader ucodes
Change 3648913 by Arne.Schober
DR - Performance optimization during HLod traversal. using vector load and avoiding array copy by passing it through reference instead through value.
Change 3649443 by Daniel.Wright
Exposed EmissiveBoost, since Lightmass supports Emissive areas on meshes
Change 3650436 by Mark.Satterthwaite
Implemented the necessary extensions for Metal shading language to move lots of complexity out of MetalBackend and into actual shader code to make life *vastly* simpler.
- Full ue4::typed_buffer<T> wrapper type & associated ue4::buffer<>/ue4::buffer_atomic<> API - totally untested but should be functionally equivalent to HLSL Buffer<T>/RWBuffer<T>.
- All the sensible casts I can think of are now defined in ue4_format - any additional ones can just be added. The enurm of formats needs to be exposed to MetalRHI so we upload the correct values, but this should be trivial.
- Added a full series of wrappers around texturecube_array and depthcube_array to insulate code from whether it is backed by a real cube_array or a texture2d_array so we don't have to maintain complicated variants for new/old iOS devices.
- Added implementations for a bunch of annoying HLSL & GLSL intrinsics that were being matched by name + reverse_bits which needs a custom implementation on old shader standards.
Change 3650861 by Rolando.Caloca
DR - vk - Fix warnings
Change 3651116 by Rolando.Caloca
DR - vk - Support for compressed saved PSO cache
Change 3651321 by Rolando.Caloca
DR - vk - Prep for load multiple PSO files
Change 3651337 by Chris.Bunner
Editor-only default material fallback (hardcoded material).
#jira UE-48404
Change 3651839 by Rolando.Caloca
DR - vk - Integrate minor pipeline changes
Change 3652042 by Mark.Satterthwaite
More work on mtlpp:
- Selector class that caches IMP from SEL & Class.
- Fixes to ns::Error.
- Added test case application for testing denorm & float reinterpret-cast behaviour on Metal.
Change 3652370 by Uriel.Doyon
New "stat StreamingOverview" giving high level metrics of texture usage.
New function ResetAverageRequiredTexturePoolSize() and GetAverageRequiredTexturePoolSize() giving the average ideal value for "r.streaming.poolsize".
Change 3653658 by Chris.Bunner
Material vertex interpolator for sprite and gpu sprite particles.
Change 3653676 by Rolando.Caloca
DR - vk - Integrate changes: Multiple PSO caches, shared ucode & compression, size reduction up to 80%
Change 3653940 by Daniel.Wright
Moved Volumetric Lightmap textures out of FScene and into FPrecomputedVolumetricLightmapData so their lifetime can match the MapBuildData. This allows tossing the source BulkData in game after RHI texture creation even though switching lighting scenarios does Release/InitializeRenderingResources multiple times.
Change 3653956 by Daniel.Wright
Fixed leak of BatchVisibilityId's
Change 3653991 by Daniel.Wright
Fixed missing include
Change 3654013 by Daniel.Wright
Refactored reflection capture composite SM4 handling, now forces fully rough even if !REFLECTION_COMPOSITE_USE_BLENDED_REFLECTION_CAPTURES (forward shading default)
Change 3654018 by Daniel.Wright
Remove unused SM4 reflection capture cubemap
Change 3654118 by Rolando.Caloca
DR - vk - Fix for queries; support for r.Vulkan.ProfileCmdBuffers to only time cmd buffers w/o gpu bubbles
Change 3654339 by Chris.Bunner
Temporarily disabed a material error whilst working with content teams to fix the introduced bugs.
Change 3654534 by Daniel.Wright
Editor is only supported on Feature Level 5 platforms. Added a message box and exit when SM4 is detected (d3d10, OpenGL 3).
Change 3654751 by Rolando.Caloca
DR - vk - Add readback for RGB10A2; minor optimization
Change 3654940 by Rolando.Caloca
DR - vk - Warning fix
Change 3655104 by Mark.Satterthwaite
Add a bunch of code to mtlpp to wrap the Xcode command-line Metal tools and use them to provide a convenient command-line tool that can compile two Metal shaders & diff the resulting AIR to make debugging easier. Obviously this only works on macOS.
Change 3655173 by Jian.Ru
Render dithered material as masked if a stencil prepass is not used
#jira UE-50064, UE-49537
Change 3655479 by Daniel.Wright
Fixed HandleLegacyMapBuildData not getting called on P maps loaded in the editor, which apparently was dropped in an integration error, causing all legacy maps (before the BuildData change) to lose their built lighting.
Change 3656341 by Richard.Wallis
Metal validation checks to test for drawing of the end of a vertex stream as seen in UE-48172 (Landscape Mesh Flickers Rapidly When Using Sculpting Landscape). This is not a fix for that but just a error log to catch the bad draw calls.
#jira UE-48172
Change 3656844 by Rolando.Caloca
DR - vk - Avoid microcode copy
- Fix link error
Change 3656894 by Rolando.Caloca
DR - vk - Enable api dump without needing validation enabled
Change 3656915 by Marcus.Wassmer
Fix DX12 buffer lock for read
Change 3657166 by Rolando.Caloca
DR - vk - Proper fix for api dump layer
Change 3657401 by Rolando.Caloca
DR - vk - Linux compile fix
Change 3657607 by Rolando.Caloca
DR - vk - Prep for changes
Change 3658722 by Chris.Bunner
Refresh shared texture samplers when changing max ansiotropy level (e.g. scalability settings).
#jira UE-30086
Change 3659499 by Daniel.Wright
Moved bEnableAutoLODGeneration to LOD category so it's not the only one in HLOD category
Change 3659644 by Mark.Satterthwaite
D3D11 equivalent to 3656341 (only enabled when -d3ddebug is) to validate DrawIndexedPrimitives isn't trying to draw off the end of the instanced vertex streams which has inconsistent (and potentially undefined) behaviour across the various APIs we support. This fires when painting the landscape because the code attempts to render with a FirstInstance value that is as large as the number of elements in the instance-data streams which D3D11 drivers silently fails to render, but which Metal (& probably Vulkan too) will renders as garbage. This pattern is wrong & will be even more dangerous in a Draw*Indirect world.
#jira UE-48172
Change 3659831 by Rolando.Caloca
DR - vk - Copy 3657927 (fixes for Mali)
Change 3661921 by Rolando.Caloca
DR - vk - Minor log/info changes
Change 3661985 by Mark.Satterthwaite
Change the Metal sampler filter translation to better match D3D.
Change 3662050 by Richard.Wallis
Compile fix for Metal enums.
Change 3662062 by Rolando.Caloca
DR - Copy from 3662060
- OpenGL cloth fix
Change 3662100 by Mark.Satterthwaite
Use a temporary file and an atomic move to put the Metal PCH into the right place and reduce the number of false PCH compile failures on the build farm.
Change 3662253 by Daniel.Wright
Reflection Captures support Lighting Scenarios without recapturing
* Reflection Captures are now part of the Map Build
* Modifying a capture in editor will display a preview, but game can only display built captures (black for unbuilt with screen message)
* Reflection Capture build data moved to the BuildData package
* Building lighting / reflection captures no longer dirties ULevels
* Sky lights which capture the scene now work correctly with Lighting Scenarios
* Lighting Scenarios must now be loaded for each time they are made visible (no switching back and forth while keeping both loaded)
Change 3663215 by Mark.Satterthwaite
Initial, incomplete, tool added to mtlpp to help debug macOS Internal Compiler Errors - the mtlpp command-line tool can be fed the debug output from UE4 along with compiler settings to automatically compile shaders and construct the render pipeline that crashes the runtime compiler.
So far only macOS render-pipeline-states are supported currently.
Change 3663293 by Mark.Satterthwaite
Added Metal device selection to the mtlpp command-line tool so I can quickly test compile on dual-GPU Macbook Pro's.
Change 3663471 by Daniel.Wright
Reflection Capture Builds no longer use UEditorLevelUtils::SetLevelVisibility to control level visibility, which streams out sublevels, modifying nav mesh
Fixed status updates during Reflection Capture Build
Captures overflowing GMaxNumReflectionCaptures now log a warning instead of pretending that they built successfully
Change 3664056 by Rolando.Caloca
DR - Linux compile fix
Change 3664460 by Daniel.Wright
Restored unused LoadTimesObjectVersion, packages saved with it will issue a warning on load
Change 3664802 by Uriel.Doyon
Fixed flash created by pre-exposure when the value changed dramatically between frames
Change 3664890 by Daniel.Wright
Created 'Stat MapBuildData' to track the memory size of lighting and reflection capture build outputs
Change 3665163 by Rolando.Caloca
DR - Copy from 3665156
- Gracefully fail when there are mem leaks exiting Vulkan
Change 3665629 by Daniel.Wright
Only Surface domain materials cast shadows in Lightmass
Change 3665855 by Marcus.Wassmer
PR #4032: Fix comparison of SceneColorFormat (Contributed by Hybrid0)
Change 3666707 by Guillaume.Abadie
Replaces some custom material node to get View.BufferSizeAndInvSize with ViewProperty material expression in some engine material functions.
Change 3667239 by Rolando.Caloca
DR - Use hlslcc define for common issues
Change 3668108 by Brian.Karis
Disabled to Catmull-Rom filter. Too many flickering issues. Disabled antiflicker as well.
Change 3668157 by Mark.Satterthwaite
In the prototype Metal stdlib extension library add inline versions of the D3D SM6 "wave" intrinsics that can be expressed in terms of Metal 2.0 simd/quad group operations (macOS=simd, iOS=quad). These are unlikely to be as efficient as direct intrinsics but they should be functionally equivalent.
These functions are not available *yet* as I still need to hook the ue4_stdlib into MetalShaderFormat & MetalRHI.
The following HLSL 6 functions are implemented:
WaveAllBitAnd
WaveAllMax
WaveAllMin
WaveAllBitOr
WaveAllBitXor
WaveAllEqual
WaveAllProduct
WaveAllSum
WaveAllTrue
WaveAnyTrue
WaveBallot
WaveGetLaneCount
WaveGetLaneIndex
WaveOnce
WavePrefixProduct
WavePrefixSum
WaveReadFirstLane
WaveReadLaneAt
The following can't be implemented in Metal as of Metal 2.0 AFAIK:
WaveGetOrderedIndex
WaveIsHelperLane
GlobalOrderedCountIncrement
QuadReadLaneAt
QuadSwapX
QuadSwapY
Change 3668260 by Olaf.Piesche
Cache particle collision shaders regardless of simple forward state
Missed this checkin
#jira FORT-51307
Change 3669243 by Daniel.Wright
Bumped shader version to propagate FReflectionCaptureData rename
Change 3669369 by Mark.Satterthwaite
Duplicating Metal changes from //UE4/Release-4.18 to Dev-Rendering (//UE4/Dev-Rendering)
3662503 Collapse system-variables to one declaration in MetalUtils to avoid later shader compiler errors when they are specified more than once, which is seemingly permissable. Fixes volumetric fog.
#jira UE-50293
3665210 - Invalidate all Metal shaders again to force a recompile to workaround another driver bug.
- On macOS compact the clip-distance value into a single output to avoid bugs in the runtime pipeline compilers.
- In SCW's direct-compile mode MetalShaderForamt should always dump the resulting Metal shader and print any errors we encounter to the log.
- Change FGenerateMetalVisitor to take a FMetalCodeBackend& not a FMetalCodeBackend* to avoid a lot of pointless pointer validation.
#jira UE-50244
3665429 Fix a crash on shutdown due to MetalRHI caching vertex-declarations beyond the lifetime of the RHI by moving the cache into the FMetalDynamicRHI itself.
#jira UE-50356
3665613 Fix DistanceField rendering on Metal & the associated validation layer error when it is enabled - MetalRHI can't use the same approach as Vulkan without a bit more work.
#jira UE-50364
3667584 Fix black flickering on some materials that use World Position Offset - the Metal sincos intrinsic comes into two flavours for single precision floats and we want the precise version not the fast version. The "cross" implementation needed a few more fma's too and this change has to invalidate Metal shaders again to take effect.
#jira UE-50399
3667805 Changing sincos in Metal fragment shaders had undesirable side-effects - the compiler is now re-associating another floating point operation - so limit the use of precise::sincos to vertex-shaders for now. This fixes the WPO materials without causing any other obvious problems.
#jira UE-50399
Change 3669912 by Mark.Satterthwaite
Fix Metal compilation for PCSS shadows - the HLSL that is compiled uses both SampleCmp and Sample which GLSL disallows (shadowSampler types in GLSL only allow SampleCmp) but is perfectly valid in Metal where only the texture type declaration changes.
Duplicate MetalBackend.cpp changes from Joe.Graf's: 3667781
Fixed an extra ) being emitted during HLSL->Metal translation
Added depthcube_array support per Mark's instructions
Change 3670308 by Mark.Satterthwaite
Missing autorelease pool blocks in MetalTexture functions.
Change 3670989 by Mark.Satterthwaite
Stop trying to be so clever with Metal clip-distances: AMD have a bug in 10.13.0 that means we can only emit one clip-distance value, so simply emit the value with the lowest index (we have handily ordered them by importance!) and let the others become user-interpolators until this bug is resolved in a macOS SU (according to Max@AMD the fix is in, just not in time for 4.18). This means planar reflections will work, VR no-multi-view-fallback will work & layered rendering will work either individually or together - the difference being that on macOS *only* the VR no-multi-view-fallback & layered rendering paths may be slower when combined with the global clip plane.
Hit & run fix to MetalCaptureManager and availability of tile-shader functions while I'm here.
#jira UE-50518
Change 3671014 by Mark.Satterthwaite
Correct handling of RowLinearPVRTC blits for iOS Metal desired for Ocean.
Change 3671575 by Rolando.Caloca
DR - Copy 3668036
Stop syncing CPU with GPU on Vulkan
Change 3671637 by Rolando.Caloca
DR - Copy 3670937
Fixes Vulkan editor outline
Change 3672309 by Mark.Satterthwaite
Submitted on behalf of Richard Wallis:
Only disable V-Sync on Metal in macOS 10.13 when running in "true" fullscreen mode (where we switch display modes & forbid switching spaces or tabbing out) so that you won't see the rainbow artefact caused by being out-of-sync with WindowServer, only the tearing you'd expect when V-Sync is disabled. We'll chat with Apple about whether there is a way to avoid the rainbow artefact when switching spaces in Windowed Fullscreen with displaySync disabled.
#jira UE-50134
Change 3672314 by Daniel.Wright
User friendly message dialog for when a required key is missing from BaseLightmass.ini
Change 3672315 by Daniel.Wright
Assert on load when a uniform buffer struct goes missing, instead of a crash on save
Change 3672476 by Chris.Bunner
Removed duplicate material instance editor command binding that appeared in a task stream merge.
Change 3672626 by Mark.Satterthwaite
Move the ue4_stdlib.metal extensions to MetalRHI's Public header directory as it'll need to be available to both modules and that's easier to accomplish from here.
Change 3672643 by Mark.Satterthwaite
iOS compilation fixes.
Change 3672728 by Daniel.Wright
Fixed encoded HDR reflection captures
Change 3672753 by Jian.Ru
Fix texture swimming
#jira UE-49369
Change 3672815 by Daniel.Wright
Tooltip for build button explaining why it might be disabled
Change 3673350 by Rolando.Caloca
DR - vk - Do not reallocate memory every draw call
Change 3673501 by Rolando.Caloca
DR - vk - Remove more reallocations
Change 3673505 by Rolando.Caloca
DR - Remove global variable with semantic
Change 3673514 by Rolando.Caloca
DR - vk - compile fix
Change 3675899 by Chris.Bunner
Fixed support for editor-time transient parameter overrides. This happens when a compiled material's scalar or vector parameter is changed in value only, the active material resources should also update and be reverted when the material graph is closed. The code was incorrectly pulling base parameters from expressions instead of the actual uniform.
Change 3676843 by Arne.Schober
DR - UE-49473 - Fix Stateleak caused by custom drawer in the long for loop, where the depth stencil state might not be reset in a subsequent itteration of the loop.
Change 3678269 by Daniel.Wright
Fixed Encoded HDR reflection capture data getting the wrong Brightness applied when cooking
Change 3678543 by Daniel.Wright
MapBuildData now tosses the unneeded reflection capture format on load. Affects target platforms that require multiple formats at cook time.
Change 3679602 by Jian.Ru
Fix up mesh decal shader complexity view mode
#jira UE-50272
Change 3679959 by Chris.Bunner
Fixed logic on overriden vector parameter retrieval for material instances checking a function owned parameter.
#jira UE-50712
Change 3679998 by Daniel.Wright
Fixed crash when precomputing static visibility only
[CL 3680175 by Marcus Wassmer in Main branch]
2017-10-04 13:36:51 -04:00
|
|
|
{
|
|
|
|
|
continue;
|
|
|
|
|
}
|
2021-01-28 17:48:58 -04:00
|
|
|
|
|
|
|
|
// Hide node types related to control flow, unless it's enabled
|
|
|
|
|
if (!bEnableControlFlow && Class->HasMetaData("MaterialControlFlow"))
|
|
|
|
|
{
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
|
2021-05-24 15:49:04 -04:00
|
|
|
if (!bEnableNewHLSLGenerator && Class->HasMetaData("MaterialNewHLSLGenerator"))
|
|
|
|
|
{
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
|
2023-06-19 08:36:04 -04:00
|
|
|
// Hide node types that are tagged private
|
|
|
|
|
if(Class->HasMetaData(TEXT("Private")))
|
|
|
|
|
{
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
|
2020-12-11 14:21:20 -04:00
|
|
|
// Exclude comments from the expression list, as well as the base parameter expression and local variable usage, as they should not be used directly
|
2014-03-14 14:13:41 -04:00
|
|
|
if ( Class != UMaterialExpressionComment::StaticClass()
|
2020-12-11 14:21:20 -04:00
|
|
|
&& Class != UMaterialExpressionParameter::StaticClass()
|
2021-01-28 17:48:58 -04:00
|
|
|
&& Class != UMaterialExpressionNamedRerouteUsage::StaticClass()
|
2021-05-14 13:05:50 -04:00
|
|
|
&& Class != UMaterialExpressionExecBegin::StaticClass()
|
|
|
|
|
&& Class != UMaterialExpressionExecEnd::StaticClass() )
|
2014-03-14 14:13:41 -04:00
|
|
|
{
|
|
|
|
|
FMaterialExpression MaterialExpression;
|
|
|
|
|
// Trim the material expression name and add it to the list used for filtering.
|
2015-02-03 05:57:20 -05:00
|
|
|
static const FString ExpressionPrefix = TEXT("MaterialExpression");
|
|
|
|
|
FString ClassName = *Class->GetName();
|
Copying //UE4/Dev-Editor to //UE4/Dev-Main (Source: //UE4/Dev-Editor @ 3228984)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3168749 on 2016/10/20 by Richard.TalbotWatkin
Fixed bug in csgRebuild where dynamic brushes from the whole world are rebuilt instead of just those from the current level. csgRebuild is supposed to act only on the current level's geometry.
#jira UE-37376 - csgRebuild builds dynamic brushes from the whole world, instead of just the current level
Change 3169740 on 2016/10/20 by Nick.Darnell
Automation - Removing old screenshots, working on new naming convention.
Change 3169796 on 2016/10/20 by Nick.Darnell
Automation - Adding new screenshots.
Change 3169800 on 2016/10/20 by Nick.Darnell
Automation - Working on improvements to screenshot comparions, now using the Unique device id instead of adapter name. Working on better metadata based matching for which screenshot to use, stubbing in support for adding alternative versions of screenshots.
Change 3169901 on 2016/10/20 by Nick.Darnell
Automation - More fixes / refinements to the way we add alternatives and replace old versions of screenshots.
Change 3169926 on 2016/10/20 by Cody.Albert
Added extension point for level editor viewport's Show and Camera menus
Change 3170053 on 2016/10/20 by Cody.Albert
Back out changelist 3169926
Change 3170067 on 2016/10/20 by Cody.Albert
Added extension point for level editor viewport's Show and Camera menus
Change 3170382 on 2016/10/21 by Michael.Dupuis
#jira UE-36585 Added Copy/Paste to Material list/item, section list/item to StaticMeshEditor and Persona Editor
Change 3170520 on 2016/10/21 by Alex.Delesky
#jira UE-36510 - You can now toggle if combo boxes can receive keyboard focus from the Widget Blueprint
Change 3170522 on 2016/10/21 by Alex.Delesky
#jira UE-33031 - Buttons will no longer remained in a hovered state on mobile devices if the user drags their finger into a button, and then lifts their finger without dragging it outside of the button.
Change 3170524 on 2016/10/21 by Alex.Delesky
#jira UE-25591 - Static Mesh LODs can now be removed from the editor without a mesh reduction tool like Simplygon configured for use in the editor.
Change 3170530 on 2016/10/21 by Alex.Delesky
Moved the HasKey method from UMapProperty to FScriptMapHelper, and moved the HasElement property from USetProperty to FScriptSetHelper
#jira none
Change 3170768 on 2016/10/21 by Cody.Albert
Back out changelist 3170067
Change 3170795 on 2016/10/21 by Nick.Darnell
JsonObjectConverter - By default UStructToJsonAttributes now skips transient properties.
Change 3170797 on 2016/10/21 by Nick.Darnell
Automation - Fixing several warnings dealing with fbx testing.
Change 3170921 on 2016/10/21 by Nick.Darnell
Automation - Fixing more warnings with FBX tests.
Change 3171109 on 2016/10/21 by Cody.Albert
Added extension point for level editor viewport Show menu
Change 3171812 on 2016/10/24 by Jamie.Dale
Back out changelist 3163044
This broke wrapping for Japanese and Chinese.
Change 3171842 on 2016/10/24 by Michael.Dupuis
#jira UE-36400
Name each Parameter uniquely either from copy/paste of any creation menu
Changed the default value for Scalar and Vector Parameter to 1 and 1,1,1,1
Added a Promote To Parameter when clicking on an Input pin that will generate proper node type based on type pin type
When editing a color property update the material expression preview
Change 3171958 on 2016/10/24 by Alex.Delesky
#jira UE-37444 - The Primitive Stats browser (and other statistics browsers) can now sort columns based on singular objects or object types as well as texture dimensions.
Change 3171969 on 2016/10/24 by Nick.Darnell
Slate - Adding some code to prevent crashes if bogus user indexes are passed into SlateApplications GetUser functions.
Change 3171970 on 2016/10/24 by Matt.Kuhlenschmidt
PR #2885: Fixed Stretched Landscape Editor Icons (Contributed by teessider)
Change 3172035 on 2016/10/24 by Alex.Delesky
Fix to build warning for 3171970
#jira none
Change 3172078 on 2016/10/24 by Michael.Dupuis
#jira UE-37626 Fetch property node from property handle if there is no property editor
Change 3172143 on 2016/10/24 by Jamie.Dale
Line-break iterators will now avoid breaking words in Hangul
The default behavior for wrapping Hangul is to use Western-style wrapping (where words are kept as-is) rather than East Asian-style (where words are broken by syllables). This behavior can be controlled by the Localization.HangulTextWrappingMethod CVar in-case you were dependant on the old behavior, but since modern Hangul uses spaces, the per-word wrapping is preferred by native speakers.
Change 3172418 on 2016/10/24 by Michael.Dupuis
Fixed Static Analysis error
Change 3173389 on 2016/10/25 by Michael.Dupuis
#jira UE-9284 Make the UI appear only on hover and change icons size
Change 3173918 on 2016/10/25 by Alex.Delesky
#jira UE-37753 - WidgetBlueprints saved without a root widget (e.g., by deleting the starting Canvas panel) will no longer set a Canvas panel as the root widget. New WidgetBlueprints will still contain a Canvas Panel when created.
Change 3173966 on 2016/10/25 by Alex.Delesky
#jira UE-20891 - SpinBox now receives MouseMove events while simulating touch events using the mouse.
Change 3174847 on 2016/10/26 by Alex.Delesky
#jira UE-36371 - Windowed Fullscreen will now expand to fit the entirety of the current window and will not be displaced when the Windows taskbar is docked on the top or left sides of the screen.
Change 3174916 on 2016/10/26 by Alexis.Matte
When re-importing fbx file, always log to the message log.
#jira UE-37639
Change 3174940 on 2016/10/26 by Alex.Delesky
Back out changelist 3174847 at request of platforms team. Was fixed on Main.
Change 3174995 on 2016/10/26 by Matt.Kuhlenschmidt
Import commandlet fixes
- Fixed crash when source control could not be contacted
- Fixed assets not importing correctly if they depended on other assets in a previous import group within the automated import
Change 3175217 on 2016/10/26 by Alexis.Matte
The FBX reimport animation code now return false if there was an error when importing
#jira UE-37755
Change 3175728 on 2016/10/26 by Alexis.Matte
Log a message when importing a skeletal mesh with more bone influence then the maximum supported
#2875
#jira UE-37613
Change 3177997 on 2016/10/28 by Nick.Darnell
Editor - Prevent re-entrant calls when EndPlayMap is called.
Change 3178429 on 2016/10/28 by Nick.Darnell
Engine - Bumping BaseEngine.ini to IOS_8, MinimumiOSVersion, as that is now the minimum allowed to fix an error on startup. Tweaking the location of where some importing files go when they're imported.
Change 3179774 on 2016/10/31 by Matt.Kuhlenschmidt
Guard against bad render targets in Slate RHI
#jira UE-37905
Change 3179900 on 2016/10/31 by Matt.Kuhlenschmidt
Added logging to track https://jira.it.epicgames.net/browse/UE-37900
#jira UE-37900
Change 3179920 on 2016/10/31 by Alex.Delesky
Removing LODs from skeletal meshes is now a transacted action and can be undone. Related to UE-25591.
#jira none
Change 3179921 on 2016/10/31 by Alex.Delesky
#jira UE-37725 - Adding safeguard against a potential crash in FTextureEditorViewportClient caused by a texture not having a valid texture resource
Change 3180119 on 2016/10/31 by Alexis.Matte
fbx importer avoid asset creation name clash
#jira UE-35100
Change 3181905 on 2016/11/01 by Alexis.Matte
Paint tool now allow users to paint on any vertex if they need it.
#jira UE-8372
Change 3182355 on 2016/11/01 by Alexis.Matte
We now support FBX LODs export for the asset exporter from the content browser.
#jira UE-35302
Change 3183286 on 2016/11/02 by Alexis.Matte
Make sure static mesh build settings are set properly when we re-import with different options. Specifically the normals, tangents and tangent space are dependent on the import options.
#jira UE-37520
Change 3183567 on 2016/11/02 by Shaun.Kime
#jira UE-38019
The Content Browser's View Options originally included both Engine and GameProject plugins only when clicking Show Plugin Content. Since there are quite a few Engine plugins, this produces quite a bit of content in the Folders panel. Most of the Engine plugins have classes or content that isn't really meant to be user-facing, so the experience of hunting for a game plugin-in's content is poor.
The new behavior is that GameProject plugins are controlled by the "View Plugin Content" option. In order to see the Engine plugins you'll need both Engine Content and Plugin Content checkboxes enabled. By default, the editor should enable the "View Plugin Content" checkbox since it should be limited to just the content in the game's Plugins folder.
Change 3184002 on 2016/11/02 by Jamie.Dale
Fixed crash during TSF IME shutdown
#jira UE-38073
Change 3185126 on 2016/11/03 by Shaun.Kime
Some of the plugin templates define Editor specific plugins. If created and a Standalone build is run, the application will attempt to link in editor libraries in game mode and will run into issues when you hit any key. The fix is to specify an Editor module description for these plugins.
Additionally, there appears to be a mismatch in pathing types when dealing with plugin path and GameDir. Plugin path is absolute and GameDir is relative by default. We check to see if the gameDir is a subset of the plugin path, but this fails due to the mismatch. The fix is to force both to be absolute (enforcing normalization of both paths as well).
#jira UE-38065
#jira UE-37645
Change 3185278 on 2016/11/03 by Nick.Darnell
UMG - Fixing some issues with HDPI mode in the widget designer.
Change 3185355 on 2016/11/03 by Nick.Darnell
UMG - Widget Component's Draw At Desired size now should also work correctly if it's in screenspace.
Change 3185510 on 2016/11/03 by Nick.Darnell
UMG - Restoring the ability of the Widget Component to directly recieve hardware input. The Widget Interaction Component is great for just about every interaction use case - the one it's not is when you actually want the 3D widgets to take focus, and to be able to be typed directly into by the user. The kind of situation where you might want to use them as a 3D menu, in a non-VR environment. By default - Widget Components will not behave in this manner, but you can now use the option bReceiveHardwareInput to enable the ability for Widget Components to function more like a widget in the screenspace of the viewport.
Slate - The scene viewport now correctly takes scale into account when drawing the 'software cursor', this fixes an issue with HDPI mode, and the cursor not being restored to the same location after moving a gizmo.
Change 3185514 on 2016/11/03 by Nick.Darnell
UMG - Fixing some HDPI mode problems with widget position calculation when projecting world to viewport / screen, absolute spaces.
Change 3185652 on 2016/11/03 by Nick.Darnell
Slate - Exposing a cached version of the widget geometry that comes in during Tick. Also performed a bit of optimization work on the class to make some space for the geometry object we now cache, by compacting the pointer event delegates we were storing.
Change 3185952 on 2016/11/03 by Nick.Darnell
UMG - Fixing another build error relating to local widget geometry.
Change 3185953 on 2016/11/03 by Nick.Darnell
UMG - Fixing a mac compiler warning.
Change 3186886 on 2016/11/04 by Matt.Kuhlenschmidt
Fixed collapse all hiding everything in the settings editors
#jira UE-38151
Change 3187014 on 2016/11/04 by Matt.Kuhlenschmidt
Fixed new assets opening in a minimized window not restoring that window.
Change 3187026 on 2016/11/04 by Shaun.Kime
UUnrealEdEngine::edactDeleteSelected calls out to FBlueprintEditorUtils::FindActorsThatReferenceActor. This checks the entire world for each actor to be deleted. When you have tens of thousands of actors in the world and are deleting tens of thousands of actors, this can take minutes. This change amortizes the cost of finding the actor references once for the world and for each actor to be deleted, we query the cached list of references. This brings the deletion time down to seconds.
#jira UE-38094
Change 3187073 on 2016/11/04 by Nick.Darnell
Automation - Changing the code that writes out json to force no BOM as is the json standard.
Change 3187113 on 2016/11/04 by Jamie.Dale
Removed double look-up in UTextProperty::SerializeItem
Change 3187114 on 2016/11/04 by Jamie.Dale
Feedback context now uses culture correct percentage formatting
Change 3187273 on 2016/11/04 by Alexis.Matte
Fbx importer for static mesh, make sure that we order the materials array to follow the section order.
Add also some fbx automation test
#jira UE-38242
Change 3187276 on 2016/11/04 by Matt.Kuhlenschmidt
Fix crash when an actor picker shows up in the struct editor. Structs do not have root property nodes
#jira UE-38268
Change 3187463 on 2016/11/04 by Nick.Darnell
Automation - Updating the blessed screenshots, and fixing the BOM issues with the json.
Change 3188638 on 2016/11/07 by Shaun.Kime
Making the UI for adding/removing parameters in custom blueprint functions behave similarly to the struct creation dialog in the content browser. There are no longer "New" buttons at the bottom of the panel and the parameter moving controls have been moved onto the main parameter row instead of being nested inside the collapse panel. A tooltip will now let you know the full parameter name and type when you hover over the editable name field. Made the move up/down icons more legible by increasing contrast between the arrow and the light grey background.
#jira UE-38240
Change 3189056 on 2016/11/07 by Nick.Darnell
Core/Editor - UObject::IsAsset() now returns false if the outermost package is RF_Transient. Also updating the creation of the transient package to be RF_Transient. This makes it so transient packages created by UMG or some other editor for things like previewing a streamed in level instance, no longer show up in the content browser.
Change 3189147 on 2016/11/07 by Jamie.Dale
Fixed potential race-condition where a UFont object could be GC'd while the loading screen was using the font cache
This queues up the pending removal until it's safe to execute it (by a thread that fully owns Slate rendering).
#jira UE-38309
Change 3189344 on 2016/11/07 by Matt.Kuhlenschmidt
Merging //UE4/Dev-Main to Dev-Editor (//UE4/Dev-Editor)
Change 3189380 on 2016/11/07 by Matt.Kuhlenschmidt
Guard against null object when creating details panel
Change 3190017 on 2016/11/08 by Alexis.Matte
FrontX support for scene importer
#jira UETOOL-1061
Change 3190058 on 2016/11/08 by Matt.Kuhlenschmidt
Fixed misaligned button in the new blueprint class dialog
Change 3190086 on 2016/11/08 by Nick.Darnell
UMG - Fixing the calculation for widget componets screen position if the camera aspect is constrained.
Change 3190159 on 2016/11/08 by Nick.Darnell
UMG - We no longer also take the platform DPI scale into account when applying UMG's UI scale. Since UMG already provides a DPI scaling system, compounding it with the native OSes produces undesirable results, since the DPI scale curve does not take into account some unknown platform scale set by a user.
Change 3190161 on 2016/11/08 by Nick.Darnell
UMG - UWidget is now Blueprintable. Improving some doc.
Change 3190545 on 2016/11/08 by Alexis.Matte
Support scaling when exporting skeleton (bind pose) to FBX
#jira UE-36120
Change 3191614 on 2016/11/09 by Simon.Tourangeau
Fix cooking crash after fbx import of a scene without meshes
#jira UE-38264
Change 3191659 on 2016/11/09 by Simon.Tourangeau
Cleanup Persona LOD section button layout
#jira UE-38339
Change 3191882 on 2016/11/09 by Jamie.Dale
Changed FBlackboardKeySelector::AddObjectFilter to use MakeUniqueObjectName so it generates more stable names, rather than relying on a static counter.
Also updated FBlackboardKeySelector::AddClassFilter, FBlackboardKeySelector::AddEnumFilter, and FBlackboardKeySelector::AddNativeEnumFilter to use MakeUniqueObjectName to ensure they don't conflict.
Change 3192092 on 2016/11/09 by Jamie.Dale
Deleting some test assets that were accidentally checked in, some of which no longer load
Change 3192281 on 2016/11/09 by Alex.Delesky
#jira UE-31866 - Widget Blueprints will no longer experience compile issues when dragging widgets between the hierarchy views of different Widget Blueprints.
Change 3192365 on 2016/11/09 by Shaun.Kime
Adding support for MaterialParameterCollections to Slate UI objects. For reasons of Blueprint controls amongst other things, MPC's are owned by individual UWorlds and transferred over to their respective Scenes. Since we want the latest values from those in-UWorld representations, Slate needs to know about the Scene on the render thread to properly map the materials to their MPC inputs. This involved keeping Scene arrays synchronized between the game logic thread and render thread, and adding a Scene index field to each batched draw element in Slate. SceneViewports are now responsible for registering their associated Scenes with the SlateRenderer. Since RetainerBoxes also draw their content as well, they too need to register their Scenes.
#jira UE-19022
Change 3192494 on 2016/11/09 by Alex.Delesky
#jira UE-37829 - Dynamically changing an option in the style for an Editable Text Box or Multiline Editable Text Box will now update it correctly.
Change 3193183 on 2016/11/10 by Alexis.Matte
When doing FBX scene re-import, the new staticmesh asset was not mark as dirty. So the system was not saving the new asset.
#jira UE-38450
Change 3193419 on 2016/11/10 by Alex.Delesky
Fixing UnrealTournament build error in SUTChatEditBox
#jira none
Change 3193456 on 2016/11/10 by Alex.Delesky
Fix to build warning C6011 in SWidgetHierarchyItem
#jira none
Change 3193704 on 2016/11/10 by Simon.Tourangeau
Create Cinematic Camera when importing camera from fbx
#jira UE-37764
Change 3194593 on 2016/11/11 by Nick.Darnell
Slate - Fixing the window reshaping logic to avoid work if we don't need to do it, rather than external calls attempting to do the check (poorly). This appears to fix the problem with popup menus being slightly off in size, creating scrollbars. This also prevents constant reshaping of windows, due to people performing the wrong checks over and over, because they were comparing against non-truncated or rounded values against truncated/rounded values.
Change 3194595 on 2016/11/11 by Nick.Darnell
Slate - Simplifying the Menu Anchor popup code for new Windows, and correcting it so that it does not take non-DPI scale into account when calculating the size of the window. Otherwise, popup menus on say, the blueprint editor change size depending upon the scale of the area.
Change 3194830 on 2016/11/11 by Richard.TalbotWatkin
Optimized pasting brushes, so geometry is not constantly rebuilt for every brush that's added. This improves performance by a couple of orders of magnitude!
#jira UE-38524 - Moving many brushes to another level is very slow
Change 3194859 on 2016/11/11 by Alexis.Matte
Fix fbx skeletal mesh cleanup material crash
#jira UE-38525
Change 3195199 on 2016/11/11 by Nick.Darnell
UMG - Updating the bindable widget searching code in sequencer to use the WidgetTree traversing code, instead of something custom. This fixes the issue where it wasn't finding widgets inside of named slots.
#jira UE-38536
Change 3196579 on 2016/11/14 by Matt.Kuhlenschmidt
Guard against rendering crashes when a mesh with no lod resources is opened.
#jira UE-38520
Change 3196614 on 2016/11/14 by Nick.Darnell
Slate - The ignore incoming scale option for the scale box should now behave as expected in more cases. It required modifying the GetRelativeLayoutScale function to also pass down the prepass scale, otherwise it can't extract out the incoming scale ahead of time before text is measured ahead of time.
Change 3196624 on 2016/11/14 by Matt.Kuhlenschmidt
PR #2927: UE-38473: Shadow outline color uses shadow color (Contributed by projectgheist)
Change 3196770 on 2016/11/14 by Matt.Kuhlenschmidt
Ensure instead of crash when updating the selection pivot if a component's actor is not selected (this is non fatal)
#jira UE-38544
Change 3196863 on 2016/11/14 by Nick.Darnell
Slate - Allowing font outline settings to be specified in native code when constructing a SlateFontInfo via a ctor.
Change 3196900 on 2016/11/14 by Nick.Darnell
Slate - Upgrading some cases that were using the older version of GetRelativeLayoutScale.
Change 3196947 on 2016/11/14 by Matt.Kuhlenschmidt
Guard against crashes in the details panel when an OS message causes the tree to refresh when a previous event has invalidate the contents of the details panel.
#jira UE-36499, UE-38497
Change 3197028 on 2016/11/14 by Alexis.Matte
Shift Drag is not moving the camera when the user is dragging the 3 axis in same time.
#jira UE-38382
Change 3197167 on 2016/11/14 by Matt.Kuhlenschmidt
Removed pivot updating code per frame for now. It changes on selection so I cant see a reason why it is needed every frame
Change 3197227 on 2016/11/14 by Nick.Darnell
UMG/Blueprint - Exposing a way to set the default schema a blueprint editor derivation uses. Updating all widget blueprints to finally use the WidgetGraphSchema.
Change 3197239 on 2016/11/14 by Nick.Darnell
UMG - Improving the ReceiveHardwareInput option to limit exposure of widgets to hit testing that did not register for it.
Change 3197538 on 2016/11/14 by Nick.Darnell
UMG - Making some progress on converting the schema over on load, now appear to correctly be loading it in time to be able to perform node conversions to convert older nodes to newer nodes. Required changing the UBlueprint interface to have a virtual for upgrading nodes, that could be overriden in WidgetBlueprint to make sure the schemas have all been updated, as Serialize is too early, and PostLoad is too late.
Change 3198211 on 2016/11/15 by Matt.Kuhlenschmidt
Guard against reimport factories being deleted while in use
#jira UE-37577
Change 3198589 on 2016/11/15 by Alex.Delesky
#jira UE-38527 - Curves editors will no longer crash when trying to scale to fit after resetting the curve to its default values. This also fixes an issue where selecting a key before resetting the curve to default would sometimes cause the timestamp to display for a now-invalid key.
Change 3198783 on 2016/11/15 by Nick.Darnell
The Widget Component's Allow Hardware Input should now correctly convert coordinates coming from a viewport scaled up by the OS DPI scaling code.
Change 3198933 on 2016/11/15 by Jamie.Dale
Changing the package localization ID used by a package now marks the package as dirty
Change 3198942 on 2016/11/15 by Jamie.Dale
Clearing the package localization ID used by a package now marks the package as dirty
Change 3200241 on 2016/11/16 by Shaun.Kime
Now allowing users to customize the Class Browser/Picker to filter out developer folders as well as hide internal use classes via INI settings. A ViewOptions button has been added to allow users to choose whether or not these filters are enabled.
By default, internal only classes will be hidden and you will be limited to your own developer folder.
Example change to DefaultEngine.ini or BaseEngine.ini to hide some classes as internal use
[/Script/ClassViewer.ClassViewerProjectSettings]
+InternalOnlyPaths=(Path="/Engine/VREditor")
+InternalOnlyClasses=/Script/VREditor.VREditorBaseUserWidget
The InternalOnlyPaths example will hide any classes in the VREditor folder or subfolders.
The InternalOnlyClasses example will hide any classes that derive from VREditorBaseUserWidget.
Both can be edited by the project settings UI so no manual INI tweaking is required. Please go to Project Settings->Class Viewer->Class Visibility Management
#jira UE-38313
Change 3200621 on 2016/11/16 by Matt.Kuhlenschmidt
Adding missing change needed post merge from main
Change 3200968 on 2016/11/16 by Jamie.Dale
Fixed localization gather including texts that were instanced or otherwise unchanged
- It now uses the archetype when exporting to diff against the default property value, and will only gather text that has changed from the default.
- UMG widgets that are instanced from another UMG asset now only gather overridden values, and skip all child instances.
Change 3201033 on 2016/11/16 by Cody.Albert
Fixed source control to properly notify when files need to be checked out if a blueprint node is dragged
Change 3201829 on 2016/11/17 by Shaun.Kime
Fixing issue where GEngine is null in early game loading, potentially causing a crash.
Change 3201832 on 2016/11/17 by Matt.Kuhlenschmidt
Fix build warning
Change 3201835 on 2016/11/17 by Nick.Darnell
Slate - Making it so explictly focusing a slate user that does not yet exist, creates the slate user so that the state is properly maintained in prepartion for that user's arrival / input.
Change 3201947 on 2016/11/17 by Matt.Kuhlenschmidt
Fix streaming pause rendering starting a movie if a movie was already playing
Change 3202089 on 2016/11/17 by Nick.Darnell
Editor - When replacing references, code that was added in 2729702, was allowing redirectors to be created that then might be abandoned and not renamed later if there was a collision on object name. There's no problem if two objects have the same name, as long as they have different paths (except for classes). So now the code records object paths in a seperate set, and avoids reprocessing / and creating multiple redirectors for the same objects, instead of just using object name.
Change 3202139 on 2016/11/17 by Jamie.Dale
Fix for adjusting text spacing when lines are removed from TextLayouts
Change 3202398 on 2016/11/17 by Cody.Albert
Updated UMG Sequencer to properly fire events once per loop
Change 3202591 on 2016/11/17 by Shaun.Kime
Fixing coding standards violations.
Change 3202744 on 2016/11/17 by Shaun.Kime
StaticMeshComponent's OverriddenLightMapRes current displays the value it was set to, even when the bOverrideLightMapRes is false. The behavior within UStaticMeshComponent::GetLightMapResolution is to use the LightMapResolution on the StaticMesh member instead when bOverrideLightMapRes is false. The UI was adjusted to reflect the more accurate behavior.
#jira UE-38315
Change 3203009 on 2016/11/17 by Alex.Delesky
Backing out changelist 3170522 per request
#jira UE-33031
Change 3204077 on 2016/11/18 by Nick.Darnell
Automation - Updating several bits of the screenshot automation piece to work a bit better, show names if we have them, and show preview dialogs for images.
Change 3204086 on 2016/11/18 by Jamie.Dale
Added FGCObjectScopeGuard and TStrongObjectPtr as a convenient way to keep a UObject alive without having to add it to the root-set
Both use FGCObject internally to reference the object and keep it alive.
FGCObjectScopeGuard is designed to be lean and used as a guard for an existing pointer, whereas TStrongObjectPtr is more "full-fat" and designed to be a replacement for a raw-pointer.
You should prefer FGCObjectScopeGuard where possible. Also note that TStrongObjectPtr isn't supported by UHT/UPROPERTY as you should just use a raw-pointer in that case (it would do the same thing).
Change 3204189 on 2016/11/18 by Alex.Delesky
Removing content from dev folder
Change 3204205 on 2016/11/18 by Jamie.Dale
Fix for being unable to delete folders that still have sub-folders in the Content Browser
#jira UE-38752
Change 3204270 on 2016/11/18 by Simon.Tourangeau
Fix StaticMesh socket reimports
- socket transforms are now updated correctly on reimport
- deleted socket from source will be removed on reimport
- fix SocketManager refresh after import
#jira UE-38195
Change 3204283 on 2016/11/18 by Alex.Delesky
#jira UE-38314 - Undoing a change in the Preview Scene Viewer in Static Mesh Editor will now properly update changes within the scene itself.
Change 3205757 on 2016/11/21 by Jamie.Dale
PR #2923: Slate: Fixed bug where NumCharactersInGlyph was set incorrectly for TAB characters (Contributed by pluranium)
Change 3205759 on 2016/11/21 by Matt.Kuhlenschmidt
PR #2958: Handle legacy Windows exe icon location (Contributed by projectgheist)
Change 3205816 on 2016/11/21 by Matt.Kuhlenschmidt
PR #2956: Add plane to basicshapes (Contributed by tommybear)
Change 3205831 on 2016/11/21 by Jamie.Dale
Speculative fix for UE-38492
This guards against null objects being passed to FAssetDeleteModel, as well as objects that become null due to the GC that happens in FAssetDeleteModel.
#jira UE-38492
Change 3205869 on 2016/11/21 by Alex.Delesky
#jira UE-38227 - Trying to transform a component on a blueprint while a spline mesh actor has the transform gizmo active in the editor will no longer modify the spline mesh actor
Change 3205873 on 2016/11/21 by Alex.Delesky
#jira UE-38379 - When editing a row in the data table, clicking on a different row before committing changes will now switch to that row. This also fixes the issue of data tables constantly regenerating cell widgets on data changes.
Should also address the issue mentioned in #jira UE-32965
Change 3205954 on 2016/11/21 by Shaun.Kime
Reverting changes from 3202744 that allowed override properties to show up as real properties in the list. There are several detail panel customizations that don't deal with this properly and rather than force everyone to upgrade, we'll just modify the static mesh detail customization to do the work.
#jira UE-38315
Change 3205965 on 2016/11/21 by Alex.Delesky
#jira UE-38749, UE-38755 - Space and Enter should now fire button OnClicked events when a button is focused
PR #2942
Change 3207157 on 2016/11/22 by Chris.Wood
Added UnrealWatchdog tool, run by the Editor, to improve abnormal shutdown tracking.
[UE-32952] - Watchdog - Show CRC when reporting abnormal shutdowns in internal builds
Change 3207344 on 2016/11/22 by Matthew.Griffin
Added UnrealWatchdog to the Binary Release
Change 3207396 on 2016/11/22 by Ben.Marsh
Add UnrealWatchdog to UGS precompiled binaries for Odin and Orion.
Change 3207418 on 2016/11/22 by Matt.Kuhlenschmidt
Redid blur changes from Paragon Dev-General
Blur widget updates
- Renamed to SBackgroundBlur/UBackgroundBlur
- Split SBackgroundBlur out into its own file
- Added bApplyAlphaToBlur - when true, the strength of the blur is modulated by the widget alpha
- Updated BlurRadius to be TOptional, so we auto-calculate radius when it isn't set
- Added a UBackgroundBlurSlot, but left it unattached so it can be done in dev-editor (and update based on the engine version)
- Updated OrionBlurWidget to export dll symbols and set up default low quality fallback image
Change 3207443 on 2016/11/22 by Chris.Wood
Fix CIS error on Mac from my change CL 3207157
Change 3207702 on 2016/11/22 by Matt.Kuhlenschmidt
Added missing files
Change 3207958 on 2016/11/22 by Matt.Kuhlenschmidt
Guard against crash clearing scenes from the slate RHI renderer during movie loading code.
Change 3207962 on 2016/11/22 by Matt.Kuhlenschmidt
Added a guard against the rendering thread timing out while on a breakpoint by checking if the debugger is present before performing the timeout check
Change 3208194 on 2016/11/22 by Matt.Kuhlenschmidt
Actually call correct method of checking for a debugger
Change 3209139 on 2016/11/23 by Cody.Albert
Adding support for "Show Only Modified Properties" filter to DetailWidgetRow
Change 3209206 on 2016/11/23 by Jamie.Dale
Moving folders now removes the old folder from disk if it's empty
This had already been done for deleting folders, but moving them was missed.
#jira UE-11796
Change 3209281 on 2016/11/23 by Jamie.Dale
PR #2932: Fix crash while updating cursor highlight (Contributed by nakosung)
Change 3210383 on 2016/11/25 by Chris.Wood
Documented Crash Report Client analytics events
[UE-32787] - Document Crash Report Client analytics events in code
Change 3210385 on 2016/11/25 by Alexis.Matte
Make sure the combine mesh option of the staticmesh import is stored in staticmeshimportdata so the re-import know if it must re-import in combined or not
#jira UE-38925
Change 3210983 on 2016/11/28 by Matt.Kuhlenschmidt
Merging //UE4/Dev-Main to Dev-Editor (//UE4/Dev-Editor)
Change 3211001 on 2016/11/28 by Matt.Kuhlenschmidt
Fix build errors
Change 3211009 on 2016/11/28 by Matt.Kuhlenschmidt
PR #2960: Git plugin: multiline initial commit message and other connect screen cleanup (Contributed by SRombauts)
Change 3211017 on 2016/11/28 by Matt.Kuhlenschmidt
Fix ATSC texture compression quality tooltip
#jira UE-38996
Change 3211045 on 2016/11/28 by Matt.Kuhlenschmidt
Fix compile errors
Change 3211081 on 2016/11/28 by Matt.Kuhlenschmidt
Fix post process anim blueprints on skeletal meshes not being clearable
#jira UE-39017
Change 3211094 on 2016/11/28 by Matt.Kuhlenschmidt
Added more logging for jira UE-39000
#jira UE-39000
Change 3211284 on 2016/11/28 by Matt.Kuhlenschmidt
Redid fix for UE-35822 in dev-editor
Change 3211544 on 2016/11/28 by Matt.Kuhlenschmidt
Fix deprecation warning
Change 3211769 on 2016/11/28 by Matt.Kuhlenschmidt
Disable motion blur in editor views by default
#jira 38424
Change 3211776 on 2016/11/28 by Matt.Kuhlenschmidt
Fix PS4 compile errors
Change 3211949 on 2016/11/28 by Matt.Kuhlenschmidt
Details panels changes
- Added the ability to create groups within groups in details panel customizations
- Added the ability for struct customizations to add categories to the parent
Change 3211954 on 2016/11/28 by Matt.Kuhlenschmidt
Reorganized the post process settings so they appear as categories in the parent and so that they have better categories to make it clear what all the settings do.
Change 3213158 on 2016/11/29 by Jamie.Dale
Updated User Defined Enum display names to use real FText instances so they can have stable keys
This avoids the issue where the FText display names were cached from an FString, resulting in them having a different identity each time they were re-cached, which lead to localization and deterministic cooking issues.
User Defined Enums no longer use meta-data to store their display names, and instead use a TMap in UUserDefinedEnum to map the raw enum entry name to its friendly display name. In addition to this, the enum editor has been updated to use STextPropertyEditableTextBox, which will keep the keys used by the display names stable where possible (allowing for delta-localization and historic tracking).
#jira UE-26274
Change 3213172 on 2016/11/29 by Jamie.Dale
Adding experimental support for content hot-reloading
The underlying support for this is in CoreUObject (see ReloadPackage and ReloadPackages in UObjectGlobals.h/.cpp), with editor specific support being added via PackageTools::ReloadPackages, and also hooks registered with FCoreUObjectDelegates::OnPackageReloaded (eg, UEditorEngine::HandlePackageReloaded).
The basic workflow for package reloading is as follows:
1) The current package is renamed, and the RF_NewerVersionExists flag is added to it and all its sub-objects.
2) The new package is loaded. Should this fail the old package is renamed back, and the RF_NewerVersionExists flag is removed.
3) We generate a mapping between objects in the old package and objects in the new package (see UObject::BuildSubobjectMapping).
4) We enumerate every object in memory, and fix-up any serialized or ARO object pointers referencing something from the old package, to reference the equivalent object from the new package (or null if no object could be found).
5) We run a GC, and verify that the old package was purged (printing any lingering references if it wasn't).
For efficiency reasons package reloading may be run in batches (the editor uses batches of 500), as this allows package reloading to happen faster (as the reference fix-up and GC only happens once per-batch) at the cost of consuming more memory.
In-editor there is an experimental setting to enable content hot-reloading. When this is enabled the SCC operations in the Content Browser will use content hot-reloading, rather than attempt to unload the reload the package as separate operations (which often fails). In order to allow the external SCC program to overwrite the files on disk, the linkers are detached from any packages that will be replaced prior to invoking the internal SCC operation.
Change 3213428 on 2016/11/29 by Jamie.Dale
Implemented clamping on FTextInputMethodContext::SetSelectionRange to fix an issue where composition could provide an invalid range if the text was changed while composing
#jira UE-37746
Change 3213442 on 2016/11/29 by Jamie.Dale
Workaround for a bug in TSF based MS IMEs on Windows 8+
They omit calling GetSelection and instead expect QueryInsert to return the current selection range. This also seems to fix an issue where composition no longer worked once some text had been deleted.
#jira UE-37309
Change 3213603 on 2016/11/29 by Cody.Albert
Changed PanelWidget::RemoveChildAt to not release slate resources if the child is a UserWidget
#jira UE-39106
Change 3213633 on 2016/11/29 by Matt.Kuhlenschmidt
Attempt to fix includetool cis warning
Change 3215159 on 2016/11/30 by Jamie.Dale
Fixing MakeShared forward declaration
Change 3215220 on 2016/11/30 by Alex.Delesky
#jira UE-38698 - Deleting a widget from the Widget Blueprint Hierarchy (or adding a new widget to the hierarchy directly) will no longer cause the scroll bar to return to the top of the hierarchy view.
Change 3215390 on 2016/11/30 by Jamie.Dale
Maps now end a hot-reload batch
Change 3215394 on 2016/11/30 by Matt.Kuhlenschmidt
Updating guard to track down worlds that have no package as an outer
#jira UE-35712
Change 3215500 on 2016/11/30 by Alexis.Matte
Color grading widget customization
#jira UETOOL-1070
Change 3215519 on 2016/11/30 by Jamie.Dale
Fixed crash caused by using TextNamespaceUtil::EnsurePackageNamespace in 'game' mode
Change 3215556 on 2016/11/30 by Cody.Albert
Fixed issue where check-out toast would not disappear
#jira UE-39146
Change 3215585 on 2016/11/30 by Jamie.Dale
Adding an explicit ESPMode to MakeShared to try and placate Android
Change 3215737 on 2016/11/30 by Alexis.Matte
Fix build warning
Change 3215748 on 2016/11/30 by Matt.Kuhlenschmidt
Guard against crashes due to duplicate items in the scene outliner if actors somehow end up attached to themselves
#jira UE-35935
Change 3215758 on 2016/11/30 by Ben.Marsh
Add a 'Custom...' build type for Dev-Editor.
Change 3216183 on 2016/11/30 by Alexis.Matte
Fix win32 build error
Change 3216362 on 2016/11/30 by Matt.Kuhlenschmidt
Fix mac build error.
Change 3216828 on 2016/12/01 by Jamie.Dale
Fixing MakeShared on Android
#jira UE-39204
Change 3216839 on 2016/12/01 by Matt.Kuhlenschmidt
PR #2997: Spelling fix for Actor.h's description of bEnableAutoLODGeneration. (Contributed by hgamiel)
Change 3216842 on 2016/12/01 by Matt.Kuhlenschmidt
Remove the ensure when pushing absolute transforms onto a canvas matrix stack. We can handle this properly now by just adding the transform to the stack if the stack is empty
#jira UE-36496
Change 3216874 on 2016/12/01 by Matt.Kuhlenschmidt
Fix a number of keybindings problems
- Removed editor keybindings from project settings. It should not have been in there (already in editor settings)
- Removed duplicate registration of editor keybindings from editor settings
- Fixed memory leak regenerating keybinding widgets when ending PIE world.
- Cleaned up styling a bit to make keybindings widgets clearer.
#jira UE-39211, UE-38718
Change 3216881 on 2016/12/01 by Shaun.Kime
Added support for reroute nodes to the material editor. These nodes should function identically to their counterparts in Blueprints. A new UMaterialExpression, UMaterialExpressionReroute has been added. It inserts no HLSL code, and instead just moves along its input to find the real UMaterialExpression that it is ultimately bound to.
Since the material system serializes its data as UMaterialExpressions, a more generalized approach across graph types isn't available as only the visual UI layer is shared between blueprints and material graphs.
Also modified the material palette and popup material expression menu to allow for c++ based material name and description customization. If we choose to expand this, it would make the C++ material nodes more discoverable and understandable.
Manually pulled in CL 3200823 and 3208490 to get bugfixes around material attribute usage.
Adding an reroute node should function identically to Blueprints (ie double-click on connection to add or Utility\Add Reroute Node from palette). You should be able to add as many reroute nodes as you want in a chain. A reroute node that only has a connected output and not an input should behave as if there were no reroute node present (i.e. triggering constants on Add). It should be possible to use reroute nodes between any two supported node types if they are connectable in isolation. Where possible, we should show the same type mismatch errors that you'd see if connecting nodes directly (ie dragging a boolean constant into a reroute node connected to an Add should result in a Float/Bool mismatch). A reroute node is purely visual, it should have no impact on the final instruction count.
In the event that an incomplete reroute input was completed by dragging to an invalid type, I tried to guarantee that the compiler would generate the appropriate errors. This can happen because we only know the inputs to a given node in code. If a reroute node doesn't have an input, it does not know what type it should be. However, the compiler should still detect these bad cases and error out.
#jira UE-6882
Change 3216968 on 2016/12/01 by Jamie.Dale
Syncing via source control now unloads (rather than reloads) packages that have been deleted from disk
Change 3216970 on 2016/12/01 by Jamie.Dale
Reverting files now uses hot-reloading (if enabled)
Change 3217233 on 2016/12/01 by Jamie.Dale
You can now choose to reload dirty packages via content hot-reloading
This will revert any in-memory changes to the asset, which may be useful when you want to roll it back to its initial state without restarting the editor.
Change 3217244 on 2016/12/01 by Matt.Kuhlenschmidt
WindowsMoviePlayer: Initialize the movie player texture on first frame regardless of whether or not the decoder has a sample ready. This prevents a white texture from showing up for a frame.
Change 3217466 on 2016/12/01 by Jamie.Dale
Fixed a bug where FTextFormatData::ConditionalCompile_NoLock would always compile the text even if it was up-to-date
Change 3217572 on 2016/12/01 by Jamie.Dale
Using FText::Format with an invalid argument no longer strips any associated argument modifier data from the resultant formatted text
Change 3217688 on 2016/12/01 by Jamie.Dale
Fixed crash reloading the active world package when it was dirty
#jira UE-39250
Change 3217978 on 2016/12/01 by Matt.Kuhlenschmidt
Fixed crash where the slate renderer holds into scenes during maps are loaded causing access to deleted data after the load is complete. We clean up cached scenes each frame but if slate doesnt tick the scenes are not cleaned up. This change moves the CleanupScenes code to a location that is called each tick and during map loads
#jira UE-39243
Change 3218834 on 2016/12/02 by Alexis.Matte
move some scene conversion import fbx options to staticmesh, skeletalmesh and animation import data so the re-import will have acces to those import options
#jira UE-38672
Change 3218838 on 2016/12/02 by Matt.Kuhlenschmidt
Fixed editing static mesh settings manually in the details panel not visually refreshing the collision primitives
#jira UE-39246
Change 3218864 on 2016/12/02 by Matt.Kuhlenschmidt
Fixed basic cube shape having a convex hull instead of a box for collision
Change 3218900 on 2016/12/02 by Matt.Kuhlenschmidt
Move static mesh collision properties to the collision category
Change 3219143 on 2016/12/02 by Michael.Dupuis
#jira UE-39124 We can now place single mesh at a time
#jira UE-39125 We can paint on the current level of the level containing the mesh we're painting on
Change the way GetRandomVectorInBrush generate the Start/end position to use the BrushNormal instead of the BrushDirection
Change 3219199 on 2016/12/02 by Matt.Kuhlenschmidt
Fixed a crash when changing Physical Surface Name and reassigning it on a physical material that uses it
#jira UE-37452
Change 3219358 on 2016/12/02 by Alexis.Matte
Fix fbx automation tests
Change 3219362 on 2016/12/02 by Alexis.Matte
Support for MAX multisub material
#jira UE-38467
#jira UE-38471
Change 3219774 on 2016/12/02 by Jamie.Dale
PR #2888: Add a setting to allow the Sources Panel to expand by default (Contributed by BhaaLseN)
Change 3219793 on 2016/12/02 by Jamie.Dale
SWindow now restores focus back to the widget that last had focus when it was deactivated
#jira UE-38965
Change 3221272 on 2016/12/05 by Matt.Kuhlenschmidt
UI background blur tweaks
- Adjust the downsample amount for lower kernel sizes
- Flush post process memory used by the blur when switching levels
Change 3221273 on 2016/12/05 by Matt.Kuhlenschmidt
Added guards against accesing scene caching methods of the slate resource manager on the rendering thread
Change 3221392 on 2016/12/05 by Matt.Kuhlenschmidt
Added basic support for playing safe movies very early in the engine startup sequence. A movie is considered safe to play very early if it is just a movie file and not some complex slate based UI loading screen
no platform actually supports this yet as none of the movie streamer modules are loaded early enough and many platforms cant render this early
Set PLATFORM_SUPPORTS_EARLY_MOVIE_PLAYBACK to 1 for your platform if it supports early loading
Change 3221831 on 2016/12/05 by Jamie.Dale
Fixed UNumericProperty::ReadEnumAsUint8 not considering enum redirects when resolving the name
Change 3221986 on 2016/12/05 by Jamie.Dale
Added an "Inline" font loading method
This can be used in a cooked build to store the font data within the Font Face asset itself (rather than a separate .ufont file) in order to guarantee a hitch free load, at the cost of potentially using more memory up-front.
The existing "PreLoad" loading method has been renamed to "LazyLoad" to better reflect what it actually does.
This also fixes a bug where FFontData::Serialize could try and use the referenced Font Face asset before it had been fully loaded.
Change 3222065 on 2016/12/05 by Jamie.Dale
Added log warning to detect hitches when lazily loading fonts
Change 3222225 on 2016/12/05 by Jamie.Dale
Fixing style-set typo
#jira UE-39333
Change 3223169 on 2016/12/06 by Matt.Kuhlenschmidt
Fix autosaving prompting to check out built data if the built data asset was dirty during autosave
#jira UE-39295
Change 3223184 on 2016/12/06 by Alexis.Matte
Support LOD group and combine mesh
#jira UE-1088
Change 3223212 on 2016/12/06 by Alex.Delesky
#jira UE-39260 - TMap and TSet struct values should now be editable when editing a component's properties.
Change 3223215 on 2016/12/06 by Alex.Delesky
#jira UE-38594 - The Widget Interaction Component will now default to tick while paused. Widget Components now contain a flag that will either allow or disallow interacting with them while the game is paused, which defaults to false.
Change 3223249 on 2016/12/06 by Matt.Kuhlenschmidt
Added back in missing code that was lost in a merge
Change 3223271 on 2016/12/06 by Alex.Delesky
#jira UE-38786 - The Color Picker will no longer stretch across the screen when exceptionally long strings are either entered or pasted inside one of the spin boxes. This also fixes an issue with editable text fields not validating string input on paste and will now prevent invalid data from being pasted inside a editable text block (e.g., pasting the string "I am a float" inside a spin box).
Change 3223275 on 2016/12/06 by Matt.Kuhlenschmidt
Fixed a race condition in WEX where the loading screen would render an external UI window that was referencing deleted materials
Change 3223276 on 2016/12/06 by Alexis.Matte
Staticmesh socket fbx import.
#jira UE-38284
Change 3223363 on 2016/12/06 by Alexis.Matte
Reimport must ask for missing file when re-importing a old asset that has no source files
#jira UE-39356
Change 3223423 on 2016/12/06 by Chris.Wood
Added option to place canvas panel children in same layer using explicit ZOrder setting.
[UETOOL-935] - Figure out a solution for canvas panel batching
Change 3223551 on 2016/12/06 by Alexis.Matte
UI mesh paint optimization, the slider now do not destroy the paint geometry adapter if the painted LOD has not change
#jira UE-39383
Change 3223844 on 2016/12/06 by Matt.Kuhlenschmidt
Back out change to change the defaults on vector and scalar expressions because this affects existing expressions that have not overridden the default
Change 3223880 on 2016/12/06 by Matt.Kuhlenschmidt
Update doc links for maps and sets
Change 3224746 on 2016/12/07 by Michael.Dupuis
#jira UE-39409 : Was'nt calling EndFoliageBrushTrace causing the transaction to never finish causing both jiras
#jira UE-39410 : Was'nt calling EndFoliageBrushTrace causing the transaction to never finish causing both jiras
Change 3224826 on 2016/12/07 by Michael.Dupuis
#jira UE-39095 : If a tool is active we simply consider inputs as handled to prevent this kind of behavior
Change 3224827 on 2016/12/07 by Simon.Tourangeau
Improve search for material match on fbx mesh import
- Add option to specify material search locations on mesh import
- On Import it will now perform a first match material search in the following order (suppose we are importing into /Game/Content/Assets/Meshes/MyMesh)
- Using Local as a search location will provide same behavior as before (search non recursively in /Game/Content/Assets/Meshes)
- If option is UnderParent or more, search recursively in destination folder (search recursively in /Game/Content/Assets/Meshes)
- If option is UnderParent or more, then recursively from parent folder (search recursively in /Game/Content/Assets)
- If option is UnderRoot or more, search recursively from root folder (search recursively in /Game)
- If option is AllAssets, search in every asset folder (Search recursively everywhere)
#jira UE-39020
Change 3224989 on 2016/12/07 by Chris.Wood
Fixed black callstack text in CrashReportClient.
[UE-38987] - CrashReportClient Callstack text is rendering Black
Change 3225142 on 2016/12/07 by Jamie.Dale
Added collapsing methods when exporting text for translation
You can now choose how to collapse your text for translation from three export modes:
- ELocalizedTextCollapseMode::IdenticalTextIdAndSource - Collapse texts with the same text identity (namespace + key) and source text (default 4.15+ behavior).
- ELocalizedTextCollapseMode::IdenticalPackageIdTextIdAndSource - Collapse texts with the same package ID, text identity (namespace + key), and source text (4.14 behavior).
- ELocalizedTextCollapseMode::IdenticalNamespaceAndSource - Collapse texts with the same namespace and source text (legacy pre-4.14 behavior).
The new default allows you to re-use the same text identity in different packages without having to translate the same text multiple times, and you can also now opt to get back to the legacy pre-4.14 behavior of collapsing all identical texts within the same namespace (in case you were reliant on that behavior).
You can change this setting via the Localization Dashboard, or add it to your gather configs as "LocalizedTextCollapseMode" (this needs to go into any configs that deal with exporting or importing PO files - the default if nothing is specified is "ELocalizedTextCollapseMode::IdenticalTextIdAndSource").
Change 3225509 on 2016/12/07 by Simon.Tourangeau
Static analysis fix, false positive
Change 3225859 on 2016/12/07 by Matt.Kuhlenschmidt
Fix broken physical surface details customization
- Scrolling now works properly
- Edit boxes dont change size while editing
- properly checks out or makes file writable once an edit has been made
#jira UE-39279
Change 3226840 on 2016/12/08 by Jamie.Dale
Fixing a bug in FText formatting where it would ignore the rebuild and Rebuild as Source arguments for the format string itself
#jira OPP-6485
Change 3226940 on 2016/12/08 by Alexis.Matte
Avoid changing the W value when playing with the color grading wheel.
#jira UE-39473
Change 3227814 on 2016/12/08 by Matt.Kuhlenschmidt
Temp disable lazy load font warnings to prevent infinite recursion crashes at startup
Change 3228010 on 2016/12/08 by Matt.Kuhlenschmidt
Fix for iOS compiling
Change 3228597 on 2016/12/09 by Jamie.Dale
Removed hard dependency between UFont and UFontFace during struct serialization as it doesn't work with the EDL
#jira UE-39529
Change 3228607 on 2016/12/09 by Jamie.Dale
Fixed infinite recursion caused by logging while the output log font was still being loaded
#jira UE-39523
Change 3228770 on 2016/12/09 by Jamie.Dale
Fixed UUserDefinedEnum::GetEnumText
it was using GetNameByIndex (which includes C++ scoping), rather than GetEnumName (which doesn't). This was causing all name look-ups to fail.
#jira UE-39531
Change 3228785 on 2016/12/09 by Matt.Kuhlenschmidt
Fix static analysis warning
[CL 3229477 by Matt Kuhlenschmidt in Main branch]
2016-12-09 15:05:28 -05:00
|
|
|
|
|
|
|
|
if (Class->HasMetaData("DisplayName"))
|
|
|
|
|
{
|
|
|
|
|
ClassName = Class->GetDisplayNameText().ToString();
|
|
|
|
|
}
|
|
|
|
|
|
2015-02-03 05:57:20 -05:00
|
|
|
if (ClassName.StartsWith(ExpressionPrefix, ESearchCase::CaseSensitive))
|
|
|
|
|
{
|
2024-01-19 19:41:56 -05:00
|
|
|
ClassName.MidInline(ExpressionPrefix.Len(), MAX_int32, EAllowShrinking::No);
|
2015-02-03 05:57:20 -05:00
|
|
|
}
|
|
|
|
|
MaterialExpression.Name = ClassName;
|
2014-03-14 14:13:41 -04:00
|
|
|
MaterialExpression.MaterialClass = Class;
|
Copying //UE4/Dev-Editor to //UE4/Dev-Main (Source: //UE4/Dev-Editor @ 3228984)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3168749 on 2016/10/20 by Richard.TalbotWatkin
Fixed bug in csgRebuild where dynamic brushes from the whole world are rebuilt instead of just those from the current level. csgRebuild is supposed to act only on the current level's geometry.
#jira UE-37376 - csgRebuild builds dynamic brushes from the whole world, instead of just the current level
Change 3169740 on 2016/10/20 by Nick.Darnell
Automation - Removing old screenshots, working on new naming convention.
Change 3169796 on 2016/10/20 by Nick.Darnell
Automation - Adding new screenshots.
Change 3169800 on 2016/10/20 by Nick.Darnell
Automation - Working on improvements to screenshot comparions, now using the Unique device id instead of adapter name. Working on better metadata based matching for which screenshot to use, stubbing in support for adding alternative versions of screenshots.
Change 3169901 on 2016/10/20 by Nick.Darnell
Automation - More fixes / refinements to the way we add alternatives and replace old versions of screenshots.
Change 3169926 on 2016/10/20 by Cody.Albert
Added extension point for level editor viewport's Show and Camera menus
Change 3170053 on 2016/10/20 by Cody.Albert
Back out changelist 3169926
Change 3170067 on 2016/10/20 by Cody.Albert
Added extension point for level editor viewport's Show and Camera menus
Change 3170382 on 2016/10/21 by Michael.Dupuis
#jira UE-36585 Added Copy/Paste to Material list/item, section list/item to StaticMeshEditor and Persona Editor
Change 3170520 on 2016/10/21 by Alex.Delesky
#jira UE-36510 - You can now toggle if combo boxes can receive keyboard focus from the Widget Blueprint
Change 3170522 on 2016/10/21 by Alex.Delesky
#jira UE-33031 - Buttons will no longer remained in a hovered state on mobile devices if the user drags their finger into a button, and then lifts their finger without dragging it outside of the button.
Change 3170524 on 2016/10/21 by Alex.Delesky
#jira UE-25591 - Static Mesh LODs can now be removed from the editor without a mesh reduction tool like Simplygon configured for use in the editor.
Change 3170530 on 2016/10/21 by Alex.Delesky
Moved the HasKey method from UMapProperty to FScriptMapHelper, and moved the HasElement property from USetProperty to FScriptSetHelper
#jira none
Change 3170768 on 2016/10/21 by Cody.Albert
Back out changelist 3170067
Change 3170795 on 2016/10/21 by Nick.Darnell
JsonObjectConverter - By default UStructToJsonAttributes now skips transient properties.
Change 3170797 on 2016/10/21 by Nick.Darnell
Automation - Fixing several warnings dealing with fbx testing.
Change 3170921 on 2016/10/21 by Nick.Darnell
Automation - Fixing more warnings with FBX tests.
Change 3171109 on 2016/10/21 by Cody.Albert
Added extension point for level editor viewport Show menu
Change 3171812 on 2016/10/24 by Jamie.Dale
Back out changelist 3163044
This broke wrapping for Japanese and Chinese.
Change 3171842 on 2016/10/24 by Michael.Dupuis
#jira UE-36400
Name each Parameter uniquely either from copy/paste of any creation menu
Changed the default value for Scalar and Vector Parameter to 1 and 1,1,1,1
Added a Promote To Parameter when clicking on an Input pin that will generate proper node type based on type pin type
When editing a color property update the material expression preview
Change 3171958 on 2016/10/24 by Alex.Delesky
#jira UE-37444 - The Primitive Stats browser (and other statistics browsers) can now sort columns based on singular objects or object types as well as texture dimensions.
Change 3171969 on 2016/10/24 by Nick.Darnell
Slate - Adding some code to prevent crashes if bogus user indexes are passed into SlateApplications GetUser functions.
Change 3171970 on 2016/10/24 by Matt.Kuhlenschmidt
PR #2885: Fixed Stretched Landscape Editor Icons (Contributed by teessider)
Change 3172035 on 2016/10/24 by Alex.Delesky
Fix to build warning for 3171970
#jira none
Change 3172078 on 2016/10/24 by Michael.Dupuis
#jira UE-37626 Fetch property node from property handle if there is no property editor
Change 3172143 on 2016/10/24 by Jamie.Dale
Line-break iterators will now avoid breaking words in Hangul
The default behavior for wrapping Hangul is to use Western-style wrapping (where words are kept as-is) rather than East Asian-style (where words are broken by syllables). This behavior can be controlled by the Localization.HangulTextWrappingMethod CVar in-case you were dependant on the old behavior, but since modern Hangul uses spaces, the per-word wrapping is preferred by native speakers.
Change 3172418 on 2016/10/24 by Michael.Dupuis
Fixed Static Analysis error
Change 3173389 on 2016/10/25 by Michael.Dupuis
#jira UE-9284 Make the UI appear only on hover and change icons size
Change 3173918 on 2016/10/25 by Alex.Delesky
#jira UE-37753 - WidgetBlueprints saved without a root widget (e.g., by deleting the starting Canvas panel) will no longer set a Canvas panel as the root widget. New WidgetBlueprints will still contain a Canvas Panel when created.
Change 3173966 on 2016/10/25 by Alex.Delesky
#jira UE-20891 - SpinBox now receives MouseMove events while simulating touch events using the mouse.
Change 3174847 on 2016/10/26 by Alex.Delesky
#jira UE-36371 - Windowed Fullscreen will now expand to fit the entirety of the current window and will not be displaced when the Windows taskbar is docked on the top or left sides of the screen.
Change 3174916 on 2016/10/26 by Alexis.Matte
When re-importing fbx file, always log to the message log.
#jira UE-37639
Change 3174940 on 2016/10/26 by Alex.Delesky
Back out changelist 3174847 at request of platforms team. Was fixed on Main.
Change 3174995 on 2016/10/26 by Matt.Kuhlenschmidt
Import commandlet fixes
- Fixed crash when source control could not be contacted
- Fixed assets not importing correctly if they depended on other assets in a previous import group within the automated import
Change 3175217 on 2016/10/26 by Alexis.Matte
The FBX reimport animation code now return false if there was an error when importing
#jira UE-37755
Change 3175728 on 2016/10/26 by Alexis.Matte
Log a message when importing a skeletal mesh with more bone influence then the maximum supported
#2875
#jira UE-37613
Change 3177997 on 2016/10/28 by Nick.Darnell
Editor - Prevent re-entrant calls when EndPlayMap is called.
Change 3178429 on 2016/10/28 by Nick.Darnell
Engine - Bumping BaseEngine.ini to IOS_8, MinimumiOSVersion, as that is now the minimum allowed to fix an error on startup. Tweaking the location of where some importing files go when they're imported.
Change 3179774 on 2016/10/31 by Matt.Kuhlenschmidt
Guard against bad render targets in Slate RHI
#jira UE-37905
Change 3179900 on 2016/10/31 by Matt.Kuhlenschmidt
Added logging to track https://jira.it.epicgames.net/browse/UE-37900
#jira UE-37900
Change 3179920 on 2016/10/31 by Alex.Delesky
Removing LODs from skeletal meshes is now a transacted action and can be undone. Related to UE-25591.
#jira none
Change 3179921 on 2016/10/31 by Alex.Delesky
#jira UE-37725 - Adding safeguard against a potential crash in FTextureEditorViewportClient caused by a texture not having a valid texture resource
Change 3180119 on 2016/10/31 by Alexis.Matte
fbx importer avoid asset creation name clash
#jira UE-35100
Change 3181905 on 2016/11/01 by Alexis.Matte
Paint tool now allow users to paint on any vertex if they need it.
#jira UE-8372
Change 3182355 on 2016/11/01 by Alexis.Matte
We now support FBX LODs export for the asset exporter from the content browser.
#jira UE-35302
Change 3183286 on 2016/11/02 by Alexis.Matte
Make sure static mesh build settings are set properly when we re-import with different options. Specifically the normals, tangents and tangent space are dependent on the import options.
#jira UE-37520
Change 3183567 on 2016/11/02 by Shaun.Kime
#jira UE-38019
The Content Browser's View Options originally included both Engine and GameProject plugins only when clicking Show Plugin Content. Since there are quite a few Engine plugins, this produces quite a bit of content in the Folders panel. Most of the Engine plugins have classes or content that isn't really meant to be user-facing, so the experience of hunting for a game plugin-in's content is poor.
The new behavior is that GameProject plugins are controlled by the "View Plugin Content" option. In order to see the Engine plugins you'll need both Engine Content and Plugin Content checkboxes enabled. By default, the editor should enable the "View Plugin Content" checkbox since it should be limited to just the content in the game's Plugins folder.
Change 3184002 on 2016/11/02 by Jamie.Dale
Fixed crash during TSF IME shutdown
#jira UE-38073
Change 3185126 on 2016/11/03 by Shaun.Kime
Some of the plugin templates define Editor specific plugins. If created and a Standalone build is run, the application will attempt to link in editor libraries in game mode and will run into issues when you hit any key. The fix is to specify an Editor module description for these plugins.
Additionally, there appears to be a mismatch in pathing types when dealing with plugin path and GameDir. Plugin path is absolute and GameDir is relative by default. We check to see if the gameDir is a subset of the plugin path, but this fails due to the mismatch. The fix is to force both to be absolute (enforcing normalization of both paths as well).
#jira UE-38065
#jira UE-37645
Change 3185278 on 2016/11/03 by Nick.Darnell
UMG - Fixing some issues with HDPI mode in the widget designer.
Change 3185355 on 2016/11/03 by Nick.Darnell
UMG - Widget Component's Draw At Desired size now should also work correctly if it's in screenspace.
Change 3185510 on 2016/11/03 by Nick.Darnell
UMG - Restoring the ability of the Widget Component to directly recieve hardware input. The Widget Interaction Component is great for just about every interaction use case - the one it's not is when you actually want the 3D widgets to take focus, and to be able to be typed directly into by the user. The kind of situation where you might want to use them as a 3D menu, in a non-VR environment. By default - Widget Components will not behave in this manner, but you can now use the option bReceiveHardwareInput to enable the ability for Widget Components to function more like a widget in the screenspace of the viewport.
Slate - The scene viewport now correctly takes scale into account when drawing the 'software cursor', this fixes an issue with HDPI mode, and the cursor not being restored to the same location after moving a gizmo.
Change 3185514 on 2016/11/03 by Nick.Darnell
UMG - Fixing some HDPI mode problems with widget position calculation when projecting world to viewport / screen, absolute spaces.
Change 3185652 on 2016/11/03 by Nick.Darnell
Slate - Exposing a cached version of the widget geometry that comes in during Tick. Also performed a bit of optimization work on the class to make some space for the geometry object we now cache, by compacting the pointer event delegates we were storing.
Change 3185952 on 2016/11/03 by Nick.Darnell
UMG - Fixing another build error relating to local widget geometry.
Change 3185953 on 2016/11/03 by Nick.Darnell
UMG - Fixing a mac compiler warning.
Change 3186886 on 2016/11/04 by Matt.Kuhlenschmidt
Fixed collapse all hiding everything in the settings editors
#jira UE-38151
Change 3187014 on 2016/11/04 by Matt.Kuhlenschmidt
Fixed new assets opening in a minimized window not restoring that window.
Change 3187026 on 2016/11/04 by Shaun.Kime
UUnrealEdEngine::edactDeleteSelected calls out to FBlueprintEditorUtils::FindActorsThatReferenceActor. This checks the entire world for each actor to be deleted. When you have tens of thousands of actors in the world and are deleting tens of thousands of actors, this can take minutes. This change amortizes the cost of finding the actor references once for the world and for each actor to be deleted, we query the cached list of references. This brings the deletion time down to seconds.
#jira UE-38094
Change 3187073 on 2016/11/04 by Nick.Darnell
Automation - Changing the code that writes out json to force no BOM as is the json standard.
Change 3187113 on 2016/11/04 by Jamie.Dale
Removed double look-up in UTextProperty::SerializeItem
Change 3187114 on 2016/11/04 by Jamie.Dale
Feedback context now uses culture correct percentage formatting
Change 3187273 on 2016/11/04 by Alexis.Matte
Fbx importer for static mesh, make sure that we order the materials array to follow the section order.
Add also some fbx automation test
#jira UE-38242
Change 3187276 on 2016/11/04 by Matt.Kuhlenschmidt
Fix crash when an actor picker shows up in the struct editor. Structs do not have root property nodes
#jira UE-38268
Change 3187463 on 2016/11/04 by Nick.Darnell
Automation - Updating the blessed screenshots, and fixing the BOM issues with the json.
Change 3188638 on 2016/11/07 by Shaun.Kime
Making the UI for adding/removing parameters in custom blueprint functions behave similarly to the struct creation dialog in the content browser. There are no longer "New" buttons at the bottom of the panel and the parameter moving controls have been moved onto the main parameter row instead of being nested inside the collapse panel. A tooltip will now let you know the full parameter name and type when you hover over the editable name field. Made the move up/down icons more legible by increasing contrast between the arrow and the light grey background.
#jira UE-38240
Change 3189056 on 2016/11/07 by Nick.Darnell
Core/Editor - UObject::IsAsset() now returns false if the outermost package is RF_Transient. Also updating the creation of the transient package to be RF_Transient. This makes it so transient packages created by UMG or some other editor for things like previewing a streamed in level instance, no longer show up in the content browser.
Change 3189147 on 2016/11/07 by Jamie.Dale
Fixed potential race-condition where a UFont object could be GC'd while the loading screen was using the font cache
This queues up the pending removal until it's safe to execute it (by a thread that fully owns Slate rendering).
#jira UE-38309
Change 3189344 on 2016/11/07 by Matt.Kuhlenschmidt
Merging //UE4/Dev-Main to Dev-Editor (//UE4/Dev-Editor)
Change 3189380 on 2016/11/07 by Matt.Kuhlenschmidt
Guard against null object when creating details panel
Change 3190017 on 2016/11/08 by Alexis.Matte
FrontX support for scene importer
#jira UETOOL-1061
Change 3190058 on 2016/11/08 by Matt.Kuhlenschmidt
Fixed misaligned button in the new blueprint class dialog
Change 3190086 on 2016/11/08 by Nick.Darnell
UMG - Fixing the calculation for widget componets screen position if the camera aspect is constrained.
Change 3190159 on 2016/11/08 by Nick.Darnell
UMG - We no longer also take the platform DPI scale into account when applying UMG's UI scale. Since UMG already provides a DPI scaling system, compounding it with the native OSes produces undesirable results, since the DPI scale curve does not take into account some unknown platform scale set by a user.
Change 3190161 on 2016/11/08 by Nick.Darnell
UMG - UWidget is now Blueprintable. Improving some doc.
Change 3190545 on 2016/11/08 by Alexis.Matte
Support scaling when exporting skeleton (bind pose) to FBX
#jira UE-36120
Change 3191614 on 2016/11/09 by Simon.Tourangeau
Fix cooking crash after fbx import of a scene without meshes
#jira UE-38264
Change 3191659 on 2016/11/09 by Simon.Tourangeau
Cleanup Persona LOD section button layout
#jira UE-38339
Change 3191882 on 2016/11/09 by Jamie.Dale
Changed FBlackboardKeySelector::AddObjectFilter to use MakeUniqueObjectName so it generates more stable names, rather than relying on a static counter.
Also updated FBlackboardKeySelector::AddClassFilter, FBlackboardKeySelector::AddEnumFilter, and FBlackboardKeySelector::AddNativeEnumFilter to use MakeUniqueObjectName to ensure they don't conflict.
Change 3192092 on 2016/11/09 by Jamie.Dale
Deleting some test assets that were accidentally checked in, some of which no longer load
Change 3192281 on 2016/11/09 by Alex.Delesky
#jira UE-31866 - Widget Blueprints will no longer experience compile issues when dragging widgets between the hierarchy views of different Widget Blueprints.
Change 3192365 on 2016/11/09 by Shaun.Kime
Adding support for MaterialParameterCollections to Slate UI objects. For reasons of Blueprint controls amongst other things, MPC's are owned by individual UWorlds and transferred over to their respective Scenes. Since we want the latest values from those in-UWorld representations, Slate needs to know about the Scene on the render thread to properly map the materials to their MPC inputs. This involved keeping Scene arrays synchronized between the game logic thread and render thread, and adding a Scene index field to each batched draw element in Slate. SceneViewports are now responsible for registering their associated Scenes with the SlateRenderer. Since RetainerBoxes also draw their content as well, they too need to register their Scenes.
#jira UE-19022
Change 3192494 on 2016/11/09 by Alex.Delesky
#jira UE-37829 - Dynamically changing an option in the style for an Editable Text Box or Multiline Editable Text Box will now update it correctly.
Change 3193183 on 2016/11/10 by Alexis.Matte
When doing FBX scene re-import, the new staticmesh asset was not mark as dirty. So the system was not saving the new asset.
#jira UE-38450
Change 3193419 on 2016/11/10 by Alex.Delesky
Fixing UnrealTournament build error in SUTChatEditBox
#jira none
Change 3193456 on 2016/11/10 by Alex.Delesky
Fix to build warning C6011 in SWidgetHierarchyItem
#jira none
Change 3193704 on 2016/11/10 by Simon.Tourangeau
Create Cinematic Camera when importing camera from fbx
#jira UE-37764
Change 3194593 on 2016/11/11 by Nick.Darnell
Slate - Fixing the window reshaping logic to avoid work if we don't need to do it, rather than external calls attempting to do the check (poorly). This appears to fix the problem with popup menus being slightly off in size, creating scrollbars. This also prevents constant reshaping of windows, due to people performing the wrong checks over and over, because they were comparing against non-truncated or rounded values against truncated/rounded values.
Change 3194595 on 2016/11/11 by Nick.Darnell
Slate - Simplifying the Menu Anchor popup code for new Windows, and correcting it so that it does not take non-DPI scale into account when calculating the size of the window. Otherwise, popup menus on say, the blueprint editor change size depending upon the scale of the area.
Change 3194830 on 2016/11/11 by Richard.TalbotWatkin
Optimized pasting brushes, so geometry is not constantly rebuilt for every brush that's added. This improves performance by a couple of orders of magnitude!
#jira UE-38524 - Moving many brushes to another level is very slow
Change 3194859 on 2016/11/11 by Alexis.Matte
Fix fbx skeletal mesh cleanup material crash
#jira UE-38525
Change 3195199 on 2016/11/11 by Nick.Darnell
UMG - Updating the bindable widget searching code in sequencer to use the WidgetTree traversing code, instead of something custom. This fixes the issue where it wasn't finding widgets inside of named slots.
#jira UE-38536
Change 3196579 on 2016/11/14 by Matt.Kuhlenschmidt
Guard against rendering crashes when a mesh with no lod resources is opened.
#jira UE-38520
Change 3196614 on 2016/11/14 by Nick.Darnell
Slate - The ignore incoming scale option for the scale box should now behave as expected in more cases. It required modifying the GetRelativeLayoutScale function to also pass down the prepass scale, otherwise it can't extract out the incoming scale ahead of time before text is measured ahead of time.
Change 3196624 on 2016/11/14 by Matt.Kuhlenschmidt
PR #2927: UE-38473: Shadow outline color uses shadow color (Contributed by projectgheist)
Change 3196770 on 2016/11/14 by Matt.Kuhlenschmidt
Ensure instead of crash when updating the selection pivot if a component's actor is not selected (this is non fatal)
#jira UE-38544
Change 3196863 on 2016/11/14 by Nick.Darnell
Slate - Allowing font outline settings to be specified in native code when constructing a SlateFontInfo via a ctor.
Change 3196900 on 2016/11/14 by Nick.Darnell
Slate - Upgrading some cases that were using the older version of GetRelativeLayoutScale.
Change 3196947 on 2016/11/14 by Matt.Kuhlenschmidt
Guard against crashes in the details panel when an OS message causes the tree to refresh when a previous event has invalidate the contents of the details panel.
#jira UE-36499, UE-38497
Change 3197028 on 2016/11/14 by Alexis.Matte
Shift Drag is not moving the camera when the user is dragging the 3 axis in same time.
#jira UE-38382
Change 3197167 on 2016/11/14 by Matt.Kuhlenschmidt
Removed pivot updating code per frame for now. It changes on selection so I cant see a reason why it is needed every frame
Change 3197227 on 2016/11/14 by Nick.Darnell
UMG/Blueprint - Exposing a way to set the default schema a blueprint editor derivation uses. Updating all widget blueprints to finally use the WidgetGraphSchema.
Change 3197239 on 2016/11/14 by Nick.Darnell
UMG - Improving the ReceiveHardwareInput option to limit exposure of widgets to hit testing that did not register for it.
Change 3197538 on 2016/11/14 by Nick.Darnell
UMG - Making some progress on converting the schema over on load, now appear to correctly be loading it in time to be able to perform node conversions to convert older nodes to newer nodes. Required changing the UBlueprint interface to have a virtual for upgrading nodes, that could be overriden in WidgetBlueprint to make sure the schemas have all been updated, as Serialize is too early, and PostLoad is too late.
Change 3198211 on 2016/11/15 by Matt.Kuhlenschmidt
Guard against reimport factories being deleted while in use
#jira UE-37577
Change 3198589 on 2016/11/15 by Alex.Delesky
#jira UE-38527 - Curves editors will no longer crash when trying to scale to fit after resetting the curve to its default values. This also fixes an issue where selecting a key before resetting the curve to default would sometimes cause the timestamp to display for a now-invalid key.
Change 3198783 on 2016/11/15 by Nick.Darnell
The Widget Component's Allow Hardware Input should now correctly convert coordinates coming from a viewport scaled up by the OS DPI scaling code.
Change 3198933 on 2016/11/15 by Jamie.Dale
Changing the package localization ID used by a package now marks the package as dirty
Change 3198942 on 2016/11/15 by Jamie.Dale
Clearing the package localization ID used by a package now marks the package as dirty
Change 3200241 on 2016/11/16 by Shaun.Kime
Now allowing users to customize the Class Browser/Picker to filter out developer folders as well as hide internal use classes via INI settings. A ViewOptions button has been added to allow users to choose whether or not these filters are enabled.
By default, internal only classes will be hidden and you will be limited to your own developer folder.
Example change to DefaultEngine.ini or BaseEngine.ini to hide some classes as internal use
[/Script/ClassViewer.ClassViewerProjectSettings]
+InternalOnlyPaths=(Path="/Engine/VREditor")
+InternalOnlyClasses=/Script/VREditor.VREditorBaseUserWidget
The InternalOnlyPaths example will hide any classes in the VREditor folder or subfolders.
The InternalOnlyClasses example will hide any classes that derive from VREditorBaseUserWidget.
Both can be edited by the project settings UI so no manual INI tweaking is required. Please go to Project Settings->Class Viewer->Class Visibility Management
#jira UE-38313
Change 3200621 on 2016/11/16 by Matt.Kuhlenschmidt
Adding missing change needed post merge from main
Change 3200968 on 2016/11/16 by Jamie.Dale
Fixed localization gather including texts that were instanced or otherwise unchanged
- It now uses the archetype when exporting to diff against the default property value, and will only gather text that has changed from the default.
- UMG widgets that are instanced from another UMG asset now only gather overridden values, and skip all child instances.
Change 3201033 on 2016/11/16 by Cody.Albert
Fixed source control to properly notify when files need to be checked out if a blueprint node is dragged
Change 3201829 on 2016/11/17 by Shaun.Kime
Fixing issue where GEngine is null in early game loading, potentially causing a crash.
Change 3201832 on 2016/11/17 by Matt.Kuhlenschmidt
Fix build warning
Change 3201835 on 2016/11/17 by Nick.Darnell
Slate - Making it so explictly focusing a slate user that does not yet exist, creates the slate user so that the state is properly maintained in prepartion for that user's arrival / input.
Change 3201947 on 2016/11/17 by Matt.Kuhlenschmidt
Fix streaming pause rendering starting a movie if a movie was already playing
Change 3202089 on 2016/11/17 by Nick.Darnell
Editor - When replacing references, code that was added in 2729702, was allowing redirectors to be created that then might be abandoned and not renamed later if there was a collision on object name. There's no problem if two objects have the same name, as long as they have different paths (except for classes). So now the code records object paths in a seperate set, and avoids reprocessing / and creating multiple redirectors for the same objects, instead of just using object name.
Change 3202139 on 2016/11/17 by Jamie.Dale
Fix for adjusting text spacing when lines are removed from TextLayouts
Change 3202398 on 2016/11/17 by Cody.Albert
Updated UMG Sequencer to properly fire events once per loop
Change 3202591 on 2016/11/17 by Shaun.Kime
Fixing coding standards violations.
Change 3202744 on 2016/11/17 by Shaun.Kime
StaticMeshComponent's OverriddenLightMapRes current displays the value it was set to, even when the bOverrideLightMapRes is false. The behavior within UStaticMeshComponent::GetLightMapResolution is to use the LightMapResolution on the StaticMesh member instead when bOverrideLightMapRes is false. The UI was adjusted to reflect the more accurate behavior.
#jira UE-38315
Change 3203009 on 2016/11/17 by Alex.Delesky
Backing out changelist 3170522 per request
#jira UE-33031
Change 3204077 on 2016/11/18 by Nick.Darnell
Automation - Updating several bits of the screenshot automation piece to work a bit better, show names if we have them, and show preview dialogs for images.
Change 3204086 on 2016/11/18 by Jamie.Dale
Added FGCObjectScopeGuard and TStrongObjectPtr as a convenient way to keep a UObject alive without having to add it to the root-set
Both use FGCObject internally to reference the object and keep it alive.
FGCObjectScopeGuard is designed to be lean and used as a guard for an existing pointer, whereas TStrongObjectPtr is more "full-fat" and designed to be a replacement for a raw-pointer.
You should prefer FGCObjectScopeGuard where possible. Also note that TStrongObjectPtr isn't supported by UHT/UPROPERTY as you should just use a raw-pointer in that case (it would do the same thing).
Change 3204189 on 2016/11/18 by Alex.Delesky
Removing content from dev folder
Change 3204205 on 2016/11/18 by Jamie.Dale
Fix for being unable to delete folders that still have sub-folders in the Content Browser
#jira UE-38752
Change 3204270 on 2016/11/18 by Simon.Tourangeau
Fix StaticMesh socket reimports
- socket transforms are now updated correctly on reimport
- deleted socket from source will be removed on reimport
- fix SocketManager refresh after import
#jira UE-38195
Change 3204283 on 2016/11/18 by Alex.Delesky
#jira UE-38314 - Undoing a change in the Preview Scene Viewer in Static Mesh Editor will now properly update changes within the scene itself.
Change 3205757 on 2016/11/21 by Jamie.Dale
PR #2923: Slate: Fixed bug where NumCharactersInGlyph was set incorrectly for TAB characters (Contributed by pluranium)
Change 3205759 on 2016/11/21 by Matt.Kuhlenschmidt
PR #2958: Handle legacy Windows exe icon location (Contributed by projectgheist)
Change 3205816 on 2016/11/21 by Matt.Kuhlenschmidt
PR #2956: Add plane to basicshapes (Contributed by tommybear)
Change 3205831 on 2016/11/21 by Jamie.Dale
Speculative fix for UE-38492
This guards against null objects being passed to FAssetDeleteModel, as well as objects that become null due to the GC that happens in FAssetDeleteModel.
#jira UE-38492
Change 3205869 on 2016/11/21 by Alex.Delesky
#jira UE-38227 - Trying to transform a component on a blueprint while a spline mesh actor has the transform gizmo active in the editor will no longer modify the spline mesh actor
Change 3205873 on 2016/11/21 by Alex.Delesky
#jira UE-38379 - When editing a row in the data table, clicking on a different row before committing changes will now switch to that row. This also fixes the issue of data tables constantly regenerating cell widgets on data changes.
Should also address the issue mentioned in #jira UE-32965
Change 3205954 on 2016/11/21 by Shaun.Kime
Reverting changes from 3202744 that allowed override properties to show up as real properties in the list. There are several detail panel customizations that don't deal with this properly and rather than force everyone to upgrade, we'll just modify the static mesh detail customization to do the work.
#jira UE-38315
Change 3205965 on 2016/11/21 by Alex.Delesky
#jira UE-38749, UE-38755 - Space and Enter should now fire button OnClicked events when a button is focused
PR #2942
Change 3207157 on 2016/11/22 by Chris.Wood
Added UnrealWatchdog tool, run by the Editor, to improve abnormal shutdown tracking.
[UE-32952] - Watchdog - Show CRC when reporting abnormal shutdowns in internal builds
Change 3207344 on 2016/11/22 by Matthew.Griffin
Added UnrealWatchdog to the Binary Release
Change 3207396 on 2016/11/22 by Ben.Marsh
Add UnrealWatchdog to UGS precompiled binaries for Odin and Orion.
Change 3207418 on 2016/11/22 by Matt.Kuhlenschmidt
Redid blur changes from Paragon Dev-General
Blur widget updates
- Renamed to SBackgroundBlur/UBackgroundBlur
- Split SBackgroundBlur out into its own file
- Added bApplyAlphaToBlur - when true, the strength of the blur is modulated by the widget alpha
- Updated BlurRadius to be TOptional, so we auto-calculate radius when it isn't set
- Added a UBackgroundBlurSlot, but left it unattached so it can be done in dev-editor (and update based on the engine version)
- Updated OrionBlurWidget to export dll symbols and set up default low quality fallback image
Change 3207443 on 2016/11/22 by Chris.Wood
Fix CIS error on Mac from my change CL 3207157
Change 3207702 on 2016/11/22 by Matt.Kuhlenschmidt
Added missing files
Change 3207958 on 2016/11/22 by Matt.Kuhlenschmidt
Guard against crash clearing scenes from the slate RHI renderer during movie loading code.
Change 3207962 on 2016/11/22 by Matt.Kuhlenschmidt
Added a guard against the rendering thread timing out while on a breakpoint by checking if the debugger is present before performing the timeout check
Change 3208194 on 2016/11/22 by Matt.Kuhlenschmidt
Actually call correct method of checking for a debugger
Change 3209139 on 2016/11/23 by Cody.Albert
Adding support for "Show Only Modified Properties" filter to DetailWidgetRow
Change 3209206 on 2016/11/23 by Jamie.Dale
Moving folders now removes the old folder from disk if it's empty
This had already been done for deleting folders, but moving them was missed.
#jira UE-11796
Change 3209281 on 2016/11/23 by Jamie.Dale
PR #2932: Fix crash while updating cursor highlight (Contributed by nakosung)
Change 3210383 on 2016/11/25 by Chris.Wood
Documented Crash Report Client analytics events
[UE-32787] - Document Crash Report Client analytics events in code
Change 3210385 on 2016/11/25 by Alexis.Matte
Make sure the combine mesh option of the staticmesh import is stored in staticmeshimportdata so the re-import know if it must re-import in combined or not
#jira UE-38925
Change 3210983 on 2016/11/28 by Matt.Kuhlenschmidt
Merging //UE4/Dev-Main to Dev-Editor (//UE4/Dev-Editor)
Change 3211001 on 2016/11/28 by Matt.Kuhlenschmidt
Fix build errors
Change 3211009 on 2016/11/28 by Matt.Kuhlenschmidt
PR #2960: Git plugin: multiline initial commit message and other connect screen cleanup (Contributed by SRombauts)
Change 3211017 on 2016/11/28 by Matt.Kuhlenschmidt
Fix ATSC texture compression quality tooltip
#jira UE-38996
Change 3211045 on 2016/11/28 by Matt.Kuhlenschmidt
Fix compile errors
Change 3211081 on 2016/11/28 by Matt.Kuhlenschmidt
Fix post process anim blueprints on skeletal meshes not being clearable
#jira UE-39017
Change 3211094 on 2016/11/28 by Matt.Kuhlenschmidt
Added more logging for jira UE-39000
#jira UE-39000
Change 3211284 on 2016/11/28 by Matt.Kuhlenschmidt
Redid fix for UE-35822 in dev-editor
Change 3211544 on 2016/11/28 by Matt.Kuhlenschmidt
Fix deprecation warning
Change 3211769 on 2016/11/28 by Matt.Kuhlenschmidt
Disable motion blur in editor views by default
#jira 38424
Change 3211776 on 2016/11/28 by Matt.Kuhlenschmidt
Fix PS4 compile errors
Change 3211949 on 2016/11/28 by Matt.Kuhlenschmidt
Details panels changes
- Added the ability to create groups within groups in details panel customizations
- Added the ability for struct customizations to add categories to the parent
Change 3211954 on 2016/11/28 by Matt.Kuhlenschmidt
Reorganized the post process settings so they appear as categories in the parent and so that they have better categories to make it clear what all the settings do.
Change 3213158 on 2016/11/29 by Jamie.Dale
Updated User Defined Enum display names to use real FText instances so they can have stable keys
This avoids the issue where the FText display names were cached from an FString, resulting in them having a different identity each time they were re-cached, which lead to localization and deterministic cooking issues.
User Defined Enums no longer use meta-data to store their display names, and instead use a TMap in UUserDefinedEnum to map the raw enum entry name to its friendly display name. In addition to this, the enum editor has been updated to use STextPropertyEditableTextBox, which will keep the keys used by the display names stable where possible (allowing for delta-localization and historic tracking).
#jira UE-26274
Change 3213172 on 2016/11/29 by Jamie.Dale
Adding experimental support for content hot-reloading
The underlying support for this is in CoreUObject (see ReloadPackage and ReloadPackages in UObjectGlobals.h/.cpp), with editor specific support being added via PackageTools::ReloadPackages, and also hooks registered with FCoreUObjectDelegates::OnPackageReloaded (eg, UEditorEngine::HandlePackageReloaded).
The basic workflow for package reloading is as follows:
1) The current package is renamed, and the RF_NewerVersionExists flag is added to it and all its sub-objects.
2) The new package is loaded. Should this fail the old package is renamed back, and the RF_NewerVersionExists flag is removed.
3) We generate a mapping between objects in the old package and objects in the new package (see UObject::BuildSubobjectMapping).
4) We enumerate every object in memory, and fix-up any serialized or ARO object pointers referencing something from the old package, to reference the equivalent object from the new package (or null if no object could be found).
5) We run a GC, and verify that the old package was purged (printing any lingering references if it wasn't).
For efficiency reasons package reloading may be run in batches (the editor uses batches of 500), as this allows package reloading to happen faster (as the reference fix-up and GC only happens once per-batch) at the cost of consuming more memory.
In-editor there is an experimental setting to enable content hot-reloading. When this is enabled the SCC operations in the Content Browser will use content hot-reloading, rather than attempt to unload the reload the package as separate operations (which often fails). In order to allow the external SCC program to overwrite the files on disk, the linkers are detached from any packages that will be replaced prior to invoking the internal SCC operation.
Change 3213428 on 2016/11/29 by Jamie.Dale
Implemented clamping on FTextInputMethodContext::SetSelectionRange to fix an issue where composition could provide an invalid range if the text was changed while composing
#jira UE-37746
Change 3213442 on 2016/11/29 by Jamie.Dale
Workaround for a bug in TSF based MS IMEs on Windows 8+
They omit calling GetSelection and instead expect QueryInsert to return the current selection range. This also seems to fix an issue where composition no longer worked once some text had been deleted.
#jira UE-37309
Change 3213603 on 2016/11/29 by Cody.Albert
Changed PanelWidget::RemoveChildAt to not release slate resources if the child is a UserWidget
#jira UE-39106
Change 3213633 on 2016/11/29 by Matt.Kuhlenschmidt
Attempt to fix includetool cis warning
Change 3215159 on 2016/11/30 by Jamie.Dale
Fixing MakeShared forward declaration
Change 3215220 on 2016/11/30 by Alex.Delesky
#jira UE-38698 - Deleting a widget from the Widget Blueprint Hierarchy (or adding a new widget to the hierarchy directly) will no longer cause the scroll bar to return to the top of the hierarchy view.
Change 3215390 on 2016/11/30 by Jamie.Dale
Maps now end a hot-reload batch
Change 3215394 on 2016/11/30 by Matt.Kuhlenschmidt
Updating guard to track down worlds that have no package as an outer
#jira UE-35712
Change 3215500 on 2016/11/30 by Alexis.Matte
Color grading widget customization
#jira UETOOL-1070
Change 3215519 on 2016/11/30 by Jamie.Dale
Fixed crash caused by using TextNamespaceUtil::EnsurePackageNamespace in 'game' mode
Change 3215556 on 2016/11/30 by Cody.Albert
Fixed issue where check-out toast would not disappear
#jira UE-39146
Change 3215585 on 2016/11/30 by Jamie.Dale
Adding an explicit ESPMode to MakeShared to try and placate Android
Change 3215737 on 2016/11/30 by Alexis.Matte
Fix build warning
Change 3215748 on 2016/11/30 by Matt.Kuhlenschmidt
Guard against crashes due to duplicate items in the scene outliner if actors somehow end up attached to themselves
#jira UE-35935
Change 3215758 on 2016/11/30 by Ben.Marsh
Add a 'Custom...' build type for Dev-Editor.
Change 3216183 on 2016/11/30 by Alexis.Matte
Fix win32 build error
Change 3216362 on 2016/11/30 by Matt.Kuhlenschmidt
Fix mac build error.
Change 3216828 on 2016/12/01 by Jamie.Dale
Fixing MakeShared on Android
#jira UE-39204
Change 3216839 on 2016/12/01 by Matt.Kuhlenschmidt
PR #2997: Spelling fix for Actor.h's description of bEnableAutoLODGeneration. (Contributed by hgamiel)
Change 3216842 on 2016/12/01 by Matt.Kuhlenschmidt
Remove the ensure when pushing absolute transforms onto a canvas matrix stack. We can handle this properly now by just adding the transform to the stack if the stack is empty
#jira UE-36496
Change 3216874 on 2016/12/01 by Matt.Kuhlenschmidt
Fix a number of keybindings problems
- Removed editor keybindings from project settings. It should not have been in there (already in editor settings)
- Removed duplicate registration of editor keybindings from editor settings
- Fixed memory leak regenerating keybinding widgets when ending PIE world.
- Cleaned up styling a bit to make keybindings widgets clearer.
#jira UE-39211, UE-38718
Change 3216881 on 2016/12/01 by Shaun.Kime
Added support for reroute nodes to the material editor. These nodes should function identically to their counterparts in Blueprints. A new UMaterialExpression, UMaterialExpressionReroute has been added. It inserts no HLSL code, and instead just moves along its input to find the real UMaterialExpression that it is ultimately bound to.
Since the material system serializes its data as UMaterialExpressions, a more generalized approach across graph types isn't available as only the visual UI layer is shared between blueprints and material graphs.
Also modified the material palette and popup material expression menu to allow for c++ based material name and description customization. If we choose to expand this, it would make the C++ material nodes more discoverable and understandable.
Manually pulled in CL 3200823 and 3208490 to get bugfixes around material attribute usage.
Adding an reroute node should function identically to Blueprints (ie double-click on connection to add or Utility\Add Reroute Node from palette). You should be able to add as many reroute nodes as you want in a chain. A reroute node that only has a connected output and not an input should behave as if there were no reroute node present (i.e. triggering constants on Add). It should be possible to use reroute nodes between any two supported node types if they are connectable in isolation. Where possible, we should show the same type mismatch errors that you'd see if connecting nodes directly (ie dragging a boolean constant into a reroute node connected to an Add should result in a Float/Bool mismatch). A reroute node is purely visual, it should have no impact on the final instruction count.
In the event that an incomplete reroute input was completed by dragging to an invalid type, I tried to guarantee that the compiler would generate the appropriate errors. This can happen because we only know the inputs to a given node in code. If a reroute node doesn't have an input, it does not know what type it should be. However, the compiler should still detect these bad cases and error out.
#jira UE-6882
Change 3216968 on 2016/12/01 by Jamie.Dale
Syncing via source control now unloads (rather than reloads) packages that have been deleted from disk
Change 3216970 on 2016/12/01 by Jamie.Dale
Reverting files now uses hot-reloading (if enabled)
Change 3217233 on 2016/12/01 by Jamie.Dale
You can now choose to reload dirty packages via content hot-reloading
This will revert any in-memory changes to the asset, which may be useful when you want to roll it back to its initial state without restarting the editor.
Change 3217244 on 2016/12/01 by Matt.Kuhlenschmidt
WindowsMoviePlayer: Initialize the movie player texture on first frame regardless of whether or not the decoder has a sample ready. This prevents a white texture from showing up for a frame.
Change 3217466 on 2016/12/01 by Jamie.Dale
Fixed a bug where FTextFormatData::ConditionalCompile_NoLock would always compile the text even if it was up-to-date
Change 3217572 on 2016/12/01 by Jamie.Dale
Using FText::Format with an invalid argument no longer strips any associated argument modifier data from the resultant formatted text
Change 3217688 on 2016/12/01 by Jamie.Dale
Fixed crash reloading the active world package when it was dirty
#jira UE-39250
Change 3217978 on 2016/12/01 by Matt.Kuhlenschmidt
Fixed crash where the slate renderer holds into scenes during maps are loaded causing access to deleted data after the load is complete. We clean up cached scenes each frame but if slate doesnt tick the scenes are not cleaned up. This change moves the CleanupScenes code to a location that is called each tick and during map loads
#jira UE-39243
Change 3218834 on 2016/12/02 by Alexis.Matte
move some scene conversion import fbx options to staticmesh, skeletalmesh and animation import data so the re-import will have acces to those import options
#jira UE-38672
Change 3218838 on 2016/12/02 by Matt.Kuhlenschmidt
Fixed editing static mesh settings manually in the details panel not visually refreshing the collision primitives
#jira UE-39246
Change 3218864 on 2016/12/02 by Matt.Kuhlenschmidt
Fixed basic cube shape having a convex hull instead of a box for collision
Change 3218900 on 2016/12/02 by Matt.Kuhlenschmidt
Move static mesh collision properties to the collision category
Change 3219143 on 2016/12/02 by Michael.Dupuis
#jira UE-39124 We can now place single mesh at a time
#jira UE-39125 We can paint on the current level of the level containing the mesh we're painting on
Change the way GetRandomVectorInBrush generate the Start/end position to use the BrushNormal instead of the BrushDirection
Change 3219199 on 2016/12/02 by Matt.Kuhlenschmidt
Fixed a crash when changing Physical Surface Name and reassigning it on a physical material that uses it
#jira UE-37452
Change 3219358 on 2016/12/02 by Alexis.Matte
Fix fbx automation tests
Change 3219362 on 2016/12/02 by Alexis.Matte
Support for MAX multisub material
#jira UE-38467
#jira UE-38471
Change 3219774 on 2016/12/02 by Jamie.Dale
PR #2888: Add a setting to allow the Sources Panel to expand by default (Contributed by BhaaLseN)
Change 3219793 on 2016/12/02 by Jamie.Dale
SWindow now restores focus back to the widget that last had focus when it was deactivated
#jira UE-38965
Change 3221272 on 2016/12/05 by Matt.Kuhlenschmidt
UI background blur tweaks
- Adjust the downsample amount for lower kernel sizes
- Flush post process memory used by the blur when switching levels
Change 3221273 on 2016/12/05 by Matt.Kuhlenschmidt
Added guards against accesing scene caching methods of the slate resource manager on the rendering thread
Change 3221392 on 2016/12/05 by Matt.Kuhlenschmidt
Added basic support for playing safe movies very early in the engine startup sequence. A movie is considered safe to play very early if it is just a movie file and not some complex slate based UI loading screen
no platform actually supports this yet as none of the movie streamer modules are loaded early enough and many platforms cant render this early
Set PLATFORM_SUPPORTS_EARLY_MOVIE_PLAYBACK to 1 for your platform if it supports early loading
Change 3221831 on 2016/12/05 by Jamie.Dale
Fixed UNumericProperty::ReadEnumAsUint8 not considering enum redirects when resolving the name
Change 3221986 on 2016/12/05 by Jamie.Dale
Added an "Inline" font loading method
This can be used in a cooked build to store the font data within the Font Face asset itself (rather than a separate .ufont file) in order to guarantee a hitch free load, at the cost of potentially using more memory up-front.
The existing "PreLoad" loading method has been renamed to "LazyLoad" to better reflect what it actually does.
This also fixes a bug where FFontData::Serialize could try and use the referenced Font Face asset before it had been fully loaded.
Change 3222065 on 2016/12/05 by Jamie.Dale
Added log warning to detect hitches when lazily loading fonts
Change 3222225 on 2016/12/05 by Jamie.Dale
Fixing style-set typo
#jira UE-39333
Change 3223169 on 2016/12/06 by Matt.Kuhlenschmidt
Fix autosaving prompting to check out built data if the built data asset was dirty during autosave
#jira UE-39295
Change 3223184 on 2016/12/06 by Alexis.Matte
Support LOD group and combine mesh
#jira UE-1088
Change 3223212 on 2016/12/06 by Alex.Delesky
#jira UE-39260 - TMap and TSet struct values should now be editable when editing a component's properties.
Change 3223215 on 2016/12/06 by Alex.Delesky
#jira UE-38594 - The Widget Interaction Component will now default to tick while paused. Widget Components now contain a flag that will either allow or disallow interacting with them while the game is paused, which defaults to false.
Change 3223249 on 2016/12/06 by Matt.Kuhlenschmidt
Added back in missing code that was lost in a merge
Change 3223271 on 2016/12/06 by Alex.Delesky
#jira UE-38786 - The Color Picker will no longer stretch across the screen when exceptionally long strings are either entered or pasted inside one of the spin boxes. This also fixes an issue with editable text fields not validating string input on paste and will now prevent invalid data from being pasted inside a editable text block (e.g., pasting the string "I am a float" inside a spin box).
Change 3223275 on 2016/12/06 by Matt.Kuhlenschmidt
Fixed a race condition in WEX where the loading screen would render an external UI window that was referencing deleted materials
Change 3223276 on 2016/12/06 by Alexis.Matte
Staticmesh socket fbx import.
#jira UE-38284
Change 3223363 on 2016/12/06 by Alexis.Matte
Reimport must ask for missing file when re-importing a old asset that has no source files
#jira UE-39356
Change 3223423 on 2016/12/06 by Chris.Wood
Added option to place canvas panel children in same layer using explicit ZOrder setting.
[UETOOL-935] - Figure out a solution for canvas panel batching
Change 3223551 on 2016/12/06 by Alexis.Matte
UI mesh paint optimization, the slider now do not destroy the paint geometry adapter if the painted LOD has not change
#jira UE-39383
Change 3223844 on 2016/12/06 by Matt.Kuhlenschmidt
Back out change to change the defaults on vector and scalar expressions because this affects existing expressions that have not overridden the default
Change 3223880 on 2016/12/06 by Matt.Kuhlenschmidt
Update doc links for maps and sets
Change 3224746 on 2016/12/07 by Michael.Dupuis
#jira UE-39409 : Was'nt calling EndFoliageBrushTrace causing the transaction to never finish causing both jiras
#jira UE-39410 : Was'nt calling EndFoliageBrushTrace causing the transaction to never finish causing both jiras
Change 3224826 on 2016/12/07 by Michael.Dupuis
#jira UE-39095 : If a tool is active we simply consider inputs as handled to prevent this kind of behavior
Change 3224827 on 2016/12/07 by Simon.Tourangeau
Improve search for material match on fbx mesh import
- Add option to specify material search locations on mesh import
- On Import it will now perform a first match material search in the following order (suppose we are importing into /Game/Content/Assets/Meshes/MyMesh)
- Using Local as a search location will provide same behavior as before (search non recursively in /Game/Content/Assets/Meshes)
- If option is UnderParent or more, search recursively in destination folder (search recursively in /Game/Content/Assets/Meshes)
- If option is UnderParent or more, then recursively from parent folder (search recursively in /Game/Content/Assets)
- If option is UnderRoot or more, search recursively from root folder (search recursively in /Game)
- If option is AllAssets, search in every asset folder (Search recursively everywhere)
#jira UE-39020
Change 3224989 on 2016/12/07 by Chris.Wood
Fixed black callstack text in CrashReportClient.
[UE-38987] - CrashReportClient Callstack text is rendering Black
Change 3225142 on 2016/12/07 by Jamie.Dale
Added collapsing methods when exporting text for translation
You can now choose how to collapse your text for translation from three export modes:
- ELocalizedTextCollapseMode::IdenticalTextIdAndSource - Collapse texts with the same text identity (namespace + key) and source text (default 4.15+ behavior).
- ELocalizedTextCollapseMode::IdenticalPackageIdTextIdAndSource - Collapse texts with the same package ID, text identity (namespace + key), and source text (4.14 behavior).
- ELocalizedTextCollapseMode::IdenticalNamespaceAndSource - Collapse texts with the same namespace and source text (legacy pre-4.14 behavior).
The new default allows you to re-use the same text identity in different packages without having to translate the same text multiple times, and you can also now opt to get back to the legacy pre-4.14 behavior of collapsing all identical texts within the same namespace (in case you were reliant on that behavior).
You can change this setting via the Localization Dashboard, or add it to your gather configs as "LocalizedTextCollapseMode" (this needs to go into any configs that deal with exporting or importing PO files - the default if nothing is specified is "ELocalizedTextCollapseMode::IdenticalTextIdAndSource").
Change 3225509 on 2016/12/07 by Simon.Tourangeau
Static analysis fix, false positive
Change 3225859 on 2016/12/07 by Matt.Kuhlenschmidt
Fix broken physical surface details customization
- Scrolling now works properly
- Edit boxes dont change size while editing
- properly checks out or makes file writable once an edit has been made
#jira UE-39279
Change 3226840 on 2016/12/08 by Jamie.Dale
Fixing a bug in FText formatting where it would ignore the rebuild and Rebuild as Source arguments for the format string itself
#jira OPP-6485
Change 3226940 on 2016/12/08 by Alexis.Matte
Avoid changing the W value when playing with the color grading wheel.
#jira UE-39473
Change 3227814 on 2016/12/08 by Matt.Kuhlenschmidt
Temp disable lazy load font warnings to prevent infinite recursion crashes at startup
Change 3228010 on 2016/12/08 by Matt.Kuhlenschmidt
Fix for iOS compiling
Change 3228597 on 2016/12/09 by Jamie.Dale
Removed hard dependency between UFont and UFontFace during struct serialization as it doesn't work with the EDL
#jira UE-39529
Change 3228607 on 2016/12/09 by Jamie.Dale
Fixed infinite recursion caused by logging while the output log font was still being loaded
#jira UE-39523
Change 3228770 on 2016/12/09 by Jamie.Dale
Fixed UUserDefinedEnum::GetEnumText
it was using GetNameByIndex (which includes C++ scoping), rather than GetEnumName (which doesn't). This was causing all name look-ups to fail.
#jira UE-39531
Change 3228785 on 2016/12/09 by Matt.Kuhlenschmidt
Fix static analysis warning
[CL 3229477 by Matt Kuhlenschmidt in Main branch]
2016-12-09 15:05:28 -05:00
|
|
|
UMaterialExpression* TempObject = Cast<UMaterialExpression>(Class->GetDefaultObject());
|
|
|
|
|
if (TempObject)
|
|
|
|
|
{
|
|
|
|
|
MaterialExpression.CreationDescription = TempObject->GetCreationDescription();
|
|
|
|
|
MaterialExpression.CreationName = TempObject->GetCreationName();
|
|
|
|
|
}
|
2014-03-14 14:13:41 -04:00
|
|
|
|
|
|
|
|
AllExpressionClasses.Add(MaterialExpression);
|
|
|
|
|
|
|
|
|
|
// Initialize the expression class input map.
|
2019-12-13 11:07:03 -05:00
|
|
|
for( TFieldIterator<FStructProperty> InputIt(Class) ; InputIt ; ++InputIt )
|
2014-03-14 14:13:41 -04:00
|
|
|
{
|
2019-12-13 11:07:03 -05:00
|
|
|
FStructProperty* StructProp = *InputIt;
|
2014-03-14 14:13:41 -04:00
|
|
|
if( StructProp->Struct == ExpressionInputStruct )
|
|
|
|
|
{
|
|
|
|
|
ExpressionInputs.Add( StructProp );
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// See if it is in the favorites array...
|
|
|
|
|
for (int32 FavoriteIndex = 0; FavoriteIndex < TempEditorOptions->FavoriteExpressions.Num(); FavoriteIndex++)
|
|
|
|
|
{
|
|
|
|
|
if (Class->GetName() == TempEditorOptions->FavoriteExpressions[FavoriteIndex])
|
|
|
|
|
{
|
|
|
|
|
FavoriteExpressionClasses.AddUnique(MaterialExpression);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2023-09-01 15:06:19 -04:00
|
|
|
// Skip adding Substrate node to the context menu if Substrate is disabled
|
|
|
|
|
// SUBSTRATE_TODO: remove this when Substrate becomes the only shading path
|
|
|
|
|
if ((Class->IsChildOf(UMaterialExpressionSubstrateBSDF::StaticClass()) || Class->IsChildOf(UMaterialExpressionSubstrateUtilityBase::StaticClass())) && !Substrate::IsSubstrateEnabled())
|
2022-09-29 20:57:36 -04:00
|
|
|
{
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
|
2014-03-14 14:13:41 -04:00
|
|
|
// Category fill...
|
|
|
|
|
if (TempObject)
|
|
|
|
|
{
|
|
|
|
|
if (TempObject->MenuCategories.Num() == 0)
|
|
|
|
|
{
|
|
|
|
|
UnassignedExpressionClasses.Add(MaterialExpression);
|
|
|
|
|
}
|
|
|
|
|
else
|
|
|
|
|
{
|
|
|
|
|
for (int32 CategoryIndex = 0; CategoryIndex < TempObject->MenuCategories.Num(); CategoryIndex++)
|
|
|
|
|
{
|
|
|
|
|
FCategorizedMaterialExpressionNode* CategoryNode = GetCategoryNode(TempObject->MenuCategories[CategoryIndex], true);
|
|
|
|
|
check(CategoryNode);
|
|
|
|
|
|
|
|
|
|
CategoryNode->MaterialExpressions.AddUnique(MaterialExpression);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
struct FCompareFMaterialExpression
|
|
|
|
|
{
|
|
|
|
|
FORCEINLINE bool operator()( const FMaterialExpression& A, const FMaterialExpression& B ) const
|
|
|
|
|
{
|
|
|
|
|
return A.Name < B.Name;
|
|
|
|
|
}
|
|
|
|
|
};
|
|
|
|
|
AllExpressionClasses.Sort(FCompareFMaterialExpression());
|
|
|
|
|
struct FCompareFCategorizedMaterialExpressionNode
|
|
|
|
|
{
|
|
|
|
|
FORCEINLINE bool operator()( const FCategorizedMaterialExpressionNode& A, const FCategorizedMaterialExpressionNode& B ) const
|
|
|
|
|
{
|
2015-05-08 10:46:42 -04:00
|
|
|
return A.CategoryName.CompareTo(B.CategoryName) < 0;
|
2014-03-14 14:13:41 -04:00
|
|
|
}
|
|
|
|
|
};
|
|
|
|
|
CategorizedExpressionClasses.Sort( FCompareFCategorizedMaterialExpressionNode() );
|
|
|
|
|
|
|
|
|
|
bInitialized = true;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
bool MaterialExpressionClasses::IsMaterialExpressionInFavorites(UMaterialExpression* InExpression)
|
|
|
|
|
{
|
|
|
|
|
for (int32 CheckIndex = 0; CheckIndex < FavoriteExpressionClasses.Num(); CheckIndex++)
|
|
|
|
|
{
|
|
|
|
|
if (FavoriteExpressionClasses[CheckIndex].MaterialClass == InExpression->GetClass())
|
|
|
|
|
{
|
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return false;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void MaterialExpressionClasses::RemoveMaterialExpressionFromFavorites(UClass* InExpression)
|
|
|
|
|
{
|
|
|
|
|
for (int32 i = 0; i < FavoriteExpressionClasses.Num(); ++i)
|
|
|
|
|
{
|
|
|
|
|
if (FavoriteExpressionClasses[i].MaterialClass == InExpression)
|
|
|
|
|
{
|
|
|
|
|
FavoriteExpressionClasses.RemoveAt(i);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void MaterialExpressionClasses::AddMaterialExpressionToFavorites(UClass* InExpression)
|
|
|
|
|
{
|
|
|
|
|
bool bIsUnique = true;
|
|
|
|
|
for (int32 i = 0; i < FavoriteExpressionClasses.Num(); ++i)
|
|
|
|
|
{
|
|
|
|
|
if (FavoriteExpressionClasses[i].MaterialClass == InExpression)
|
|
|
|
|
{
|
|
|
|
|
bIsUnique = false;
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
if (bIsUnique)
|
|
|
|
|
{
|
|
|
|
|
FMaterialExpression MaterialExpression;
|
|
|
|
|
// Trim the material expression name and add it to the list used for filtering.
|
|
|
|
|
MaterialExpression.Name = FString(*InExpression->GetName()).Mid(FCString::Strlen(TEXT("MaterialExpression")));
|
|
|
|
|
MaterialExpression.MaterialClass = InExpression;
|
|
|
|
|
|
|
|
|
|
FavoriteExpressionClasses.Add(MaterialExpression);
|
|
|
|
|
}
|
|
|
|
|
}
|